Fix bug with empty slice if amount of dimensions matches amount of frequencies, but is not equal to 512

by isemenkov - opened Feb 28

base: refs/heads/main

←

from: refs/pr/1

Discussion Files changed

+25

-6

isemenkov

Feb 28

Currently, in FourierEmb4D if self.dimension != 512, but self.freqs ** 4 == self.dimensions // 2 (no harmonics should be cut off), model will have diff == 0 and a slice loc = loc[:, :, :-diff] will become loc = loc[:, :, :0] where ":0" part will return empty slice instead of all harmonics. Changed:

Fixed empty slice bug: now slicing is only performed if diff > 0
Added ValueError if diff < 0 during forward and similar ValueError if self.dimension > harmonics during init. Both cases represent the case where there are not enough harmonics for positional encoding)
Fixed hardcoding special preprocessing only if self.harmonics != 512 (harmonics cut off) during forward. Now for any self.dimension the same cut off logic is generalized.
Added ValueError during init if rqeuested self.dimension is not even as dimensionality of output Fourier embeddings is always even 2 * self.freqs ** 4 because of doubling while using both sine and cosine
Added small comment of how and why is harmonics cut off performed

Fix bug with empty slice if amount of dimensions matches amount of frequencies, but is not equal to 5128022d1fe

jonathan-lys

Broader Artificial Intelligence org Mar 2

Closing duplicate of https://huggingface.co/brain-bzh/reve-base/discussions/1

jonathan-lys changed pull request status to closed Mar 2

Upload images, audio, and videos by dragging in the text input, pasting, or clicking here.

Tap or paste here to upload images

· Sign up or log in to comment