id
int64
1.9B
3.25B
title
stringlengths
2
244
state
stringclasses
2 values
body
stringlengths
3
58.6k
βŒ€
created_at
timestamp[s]date
2023-09-15 14:23:33
2025-07-22 09:33:54
updated_at
timestamp[s]date
2023-09-18 16:20:09
2025-07-22 10:44:03
closed_at
timestamp[s]date
2023-09-18 16:20:09
2025-07-19 22:45:08
βŒ€
html_url
stringlengths
49
51
pull_request
dict
number
int64
6.24k
7.7k
is_pull_request
bool
2 classes
comments
listlengths
0
24
2,276,763,745
Fix load_dataset for data_files with protocols other than HF
closed
Fixes huggingface/datasets/issues/6598 I've added a new test case and a solution. Before applying the solution the test case was failing with the same error described in the linked issue. MRE: ``` pip install "datasets[s3]" python -c "from datasets import load_dataset; load_dataset('csv', data_files={'train': ...
2024-05-03T01:43:47
2024-07-23T14:37:08
2024-07-23T14:30:09
https://github.com/huggingface/datasets/pull/6862
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6862", "html_url": "https://github.com/huggingface/datasets/pull/6862", "diff_url": "https://github.com/huggingface/datasets/pull/6862.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6862.patch", "merged_at": "2024-07-23T14:30...
6,862
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6862). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,275,988,990
Fix CI by temporarily pinning huggingface-hub < 0.23.0
closed
As a hotfix for CI, temporarily pin `huggingface-hub` upper version Fix #6860. Revert once root cause is fixed, see: - https://github.com/huggingface/transformers/issues/30618
2024-05-02T16:40:04
2024-05-02T16:59:42
2024-05-02T16:53:42
https://github.com/huggingface/datasets/pull/6861
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6861", "html_url": "https://github.com/huggingface/datasets/pull/6861", "diff_url": "https://github.com/huggingface/datasets/pull/6861.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6861.patch", "merged_at": "2024-05-02T16:53...
6,861
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6861). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,275,537,137
CI fails after huggingface_hub-0.23.0 release: FutureWarning: "resume_download"
closed
CI fails after latest huggingface_hub-0.23.0 release: https://github.com/huggingface/huggingface_hub/releases/tag/v0.23.0 ``` FAILED tests/test_metric_common.py::LocalMetricTest::test_load_metric_bertscore - FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume...
2024-05-02T13:24:17
2024-05-02T16:53:45
2024-05-02T16:53:45
https://github.com/huggingface/datasets/issues/6860
null
6,860
false
[ "I think this needs to be fixed on transformers.\r\n\r\nCC: @Wauplin ", "See:\r\n- https://github.com/huggingface/transformers/issues/30618", "Opened https://github.com/huggingface/transformers/pull/30620" ]
2,274,996,774
Support folder-based datasets with large metadata.jsonl
open
I tried creating an `imagefolder` dataset with a 714MB `metadata.jsonl` but got the error below. This pull request fixes the problem by increasing the block size like the message suggests. ``` >>> from datasets import load_dataset >>> dataset = load_dataset("imagefolder", data_dir="data-for-upload") Traceback (mos...
2024-05-02T09:07:26
2024-05-02T09:07:26
null
https://github.com/huggingface/datasets/pull/6859
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6859", "html_url": "https://github.com/huggingface/datasets/pull/6859", "diff_url": "https://github.com/huggingface/datasets/pull/6859.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6859.patch", "merged_at": null }
6,859
true
[]
2,274,917,185
Segmentation fault
closed
### Describe the bug Using various version for datasets, I'm no more longer able to load that dataset without a segmentation fault. Several others files are also concerned. ### Steps to reproduce the bug # Create a new venv python3 -m venv venv_test source venv_test/bin/activate # Install the latest versio...
2024-05-02T08:28:49
2024-05-03T08:43:21
2024-05-03T08:42:36
https://github.com/huggingface/datasets/issues/6858
null
6,858
false
[ "I downloaded the jsonl file and extract it manually. \r\nThe issue seems to be related to pyarrow.json \r\n\r\n\r\n\r\npython3 -q -X faulthandler -c \"from datasets import load_dataset; load_dataset('json', data_files='/Users/scampion/Downloads/1998-09.jsonl')\"\r\nGenerating train split: 0 examples [00:00, ? exa...
2,274,849,730
Fix line-endings in tests on Windows
closed
EDIT: ~~Fix test_delete_from_hub on Windows by passing explicit encoding.~~ Fix test_delete_from_hub and test_xgetsize_private by uploading the README file content directly (encoding the string), instead of writing a local file and uploading it. Note that local files created on Windows will have "\r\n" line ending...
2024-05-02T07:49:15
2024-05-02T11:49:35
2024-05-02T11:43:00
https://github.com/huggingface/datasets/pull/6857
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6857", "html_url": "https://github.com/huggingface/datasets/pull/6857", "diff_url": "https://github.com/huggingface/datasets/pull/6857.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6857.patch", "merged_at": "2024-05-02T11:43...
6,857
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6857). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,274,828,933
CI fails on Windows for test_delete_from_hub and test_xgetsize_private due to new-line character
closed
CI fails on Windows for test_delete_from_hub after the merge of: - #6820 This is weird because the CI was green in the PR branch before merging to main. ``` FAILED tests/test_hub.py::test_delete_from_hub - AssertionError: assert [CommitOperat...\r\n---\r\n')] == [CommitOperat...in/*\n---\n')] At index 1 ...
2024-05-02T07:37:03
2024-05-02T11:43:01
2024-05-02T11:43:01
https://github.com/huggingface/datasets/issues/6856
null
6,856
false
[ "After investigation, I have found that when a local file is uploaded to the Hub, the new line character is no longer transformed to \"\\n\": on Windows machine now it is kept as \"\\r\\n\".\r\n\r\nAny idea why this changed?\r\nCC: @lhoestq " ]
2,274,777,812
Fix dataset name for community Hub script-datasets
closed
Fix dataset name for community Hub script-datasets by passing explicit dataset_name to HubDatasetModuleFactoryWithScript. Fix #6854. CC: @Wauplin
2024-05-02T07:05:44
2024-05-03T15:58:00
2024-05-03T15:51:57
https://github.com/huggingface/datasets/pull/6855
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6855", "html_url": "https://github.com/huggingface/datasets/pull/6855", "diff_url": "https://github.com/huggingface/datasets/pull/6855.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6855.patch", "merged_at": "2024-05-03T15:51...
6,855
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6855). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "The CI errors were unrelated. I am merging main once they were fixed:\r\n- #6857", "T...
2,274,767,686
Wrong example of usage when config name is missing for community script-datasets
closed
As reported by @Wauplin, when loading a community dataset with script, there is a bug in the example of usage of the error message if the dataset has multiple configs (and no default config) and the user does not pass any config. For example: ```python >>> ds = load_dataset("google/fleurs") ValueError: Config name i...
2024-05-02T06:59:39
2024-05-03T15:51:59
2024-05-03T15:51:58
https://github.com/huggingface/datasets/issues/6854
null
6,854
false
[]
2,272,570,000
Support soft links for load_datasets imagefolder
open
### Feature request Load_dataset from a folder of images doesn't seem to support soft links. It would be nice if it did, especially during methods development where image folders are being curated. ### Motivation Images are coming from a complex variety of sources and we'd like to be able to soft link directly from ...
2024-04-30T22:14:29
2024-04-30T22:14:29
null
https://github.com/huggingface/datasets/issues/6853
null
6,853
false
[]
2,272,465,011
Write token isn't working while pushing to datasets
closed
### Describe the bug <img width="1001" alt="Screenshot 2024-05-01 at 3 37 06 AM" src="https://github.com/huggingface/datasets/assets/130903099/00fcf12c-fcc1-4749-8592-d263d4efcbcc"> As you can see I logged in to my account and the write token is valid. But I can't upload on my main account and I am getting that ...
2024-04-30T21:18:20
2024-05-02T00:55:46
2024-05-02T00:55:46
https://github.com/huggingface/datasets/issues/6852
null
6,852
false
[]
2,270,965,503
load_dataset('emotion') UnicodeDecodeError
open
### Describe the bug **emotions = load_dataset('emotion')** _UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte_ ### Steps to reproduce the bug load_dataset('emotion') ### Expected behavior succese ### Environment info py3.10 transformers 4.41.0.dev0 datasets 2....
2024-04-30T09:25:01
2024-09-05T03:11:04
null
https://github.com/huggingface/datasets/issues/6851
null
6,851
false
[ "I met the same problem, here is my code:\r\n```\r\nfrom datasets import load_dataset\r\n\r\nds_name = \"togethercomputer/RedPajama-Data-1T\"\r\nds = load_dataset(ds_name, download_mode=DownloadMode.FORCE_REDOWNLOAD)\r\n```\r\nAnd output error is:\r\n```\r\nTraceback (most recent call last):\r\n File \"/home/yator...
2,269,500,624
Problem loading voxpopuli dataset
closed
### Describe the bug ``` Exception has occurred: FileNotFoundError Couldn't find file at https://huggingface.co/datasets/facebook/voxpopuli/resolve/main/{'en': 'data/en/asr_train.tsv'} ``` Error in logic for link url creation. The link should be https://huggingface.co/datasets/facebook/voxpopuli/resolve/main/da...
2024-04-29T16:46:51
2024-05-06T09:25:54
2024-05-06T09:25:54
https://github.com/huggingface/datasets/issues/6850
null
6,850
false
[ "Version 2.18 works without problem.", "@Namangarg110 @mohsen-goodarzi The bug appears because the number of urls is less than 16 and the algorithm is meant to work on the previously created mode for a single url as stated on line 314: https://github.com/huggingface/datasets/blob/1bf8a46cc7b096d5c547ea3794f6a4b6...
2,268,718,355
fix webdataset filename split
closed
use `os.path.splitext` to parse field_name. fix filename which has dot. like: ``` a.b.jpeg a.b.txt ```
2024-04-29T10:57:18
2024-06-04T12:54:04
2024-06-04T12:54:04
https://github.com/huggingface/datasets/pull/6849
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6849", "html_url": "https://github.com/huggingface/datasets/pull/6849", "diff_url": "https://github.com/huggingface/datasets/pull/6849.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6849.patch", "merged_at": null }
6,849
true
[ "Hi ! This was fixed recently in https://github.com/huggingface/datasets/pull/6904 and https://github.com/huggingface/datasets/pull/6931" ]
2,268,622,609
Cant Downlaod Common Voice 17.0 hy-AM
open
### Describe the bug I want to download Common Voice 17.0 hy-AM but it returns an error. ``` The version_base parameter is not specified. Please specify a compatability version level, or None. Will assume defaults for version 1.1 @hydra.main(config_name='hfds_config', config_path=None) /usr/local/lib/pyth...
2024-04-29T10:06:02
2025-04-01T20:48:09
null
https://github.com/huggingface/datasets/issues/6848
null
6,848
false
[ "Same issue here.", "#self-assign", "Hi @mheryerznkanyan ,\nI tested it on a Linux-5.14.0-284.86.1.el9_2.x86_64-x86_64-with-glibc2.34 machine using the same package versions you mentioned, and it works fine now.\nDoes it work on your machine as well?" ]
2,268,589,177
[Streaming] Only load requested splits without resolving files for the other splits
open
e.g. [thangvip](https://huggingface.co/thangvip)/[cosmopedia_vi_math](https://huggingface.co/datasets/thangvip/cosmopedia_vi_math) has 300 splits and it takes a very long time to load only one split. This is due to `load_dataset()` resolving the files of all the splits even if only one is needed. In `dataset-view...
2024-04-29T09:49:32
2024-05-07T04:43:59
null
https://github.com/huggingface/datasets/issues/6847
null
6,847
false
[ "This should help fixing this issue: https://github.com/huggingface/datasets/pull/6832", "I'm having a similar issue when using splices:\r\n<img width=\"947\" alt=\"image\" src=\"https://github.com/huggingface/datasets/assets/28941213/2153faac-e1fe-4b6d-a79b-30b2699407e8\">\r\n<img width=\"823\" alt=\"image\" src...
2,267,352,120
Unimaginable super slow iteration
closed
### Describe the bug Assuming there is a dataset with 52000 sentences, each with a length of 500, it takes 20 seconds to extract a sentence from the datasetβ€¦β€¦οΌŸIs there something wrong with my iteration? ### Steps to reproduce the bug ```python import datasets import time import random num_rows = 52000 n...
2024-04-28T05:24:14
2024-05-06T08:30:03
2024-05-06T08:30:03
https://github.com/huggingface/datasets/issues/6846
null
6,846
false
[ "In every iteration you load the full \"random_input\" column in memory, only then to access it's i-th element.\r\n\r\nYou can try using this instead\r\n\r\na,b=dataset[i]['random_input'],dataset[i]['random_output']" ]
2,265,876,551
load_dataset doesn't support list column
open
### Describe the bug dataset = load_dataset("Doraemon-AI/text-to-neo4j-cypher-chinese") got exception: Generating train split: 1834 examples [00:00, 5227.98 examples/s] Traceback (most recent call last): File "/usr/local/lib/python3.11/dist-packages/datasets/builder.py", line 2011, in _prepare_split_single ...
2024-04-26T14:11:44
2024-05-15T12:06:59
null
https://github.com/huggingface/datasets/issues/6845
null
6,845
false
[ "I encountered this same issue when loading a customized dataset for ORPO training, in which there were three columns and two of them were lists. \r\nI debugged and found that it might be caused by the type-infer mechanism and because in some chunks one of the columns is always an empty list ([]), it was regarded a...
2,265,870,546
Retry on HF Hub error when streaming
closed
Retry on the `huggingface_hub`'s `HfHubHTTPError` in the streaming mode. Fix #6843
2024-04-26T14:09:04
2024-04-26T15:37:42
2024-04-26T15:37:42
https://github.com/huggingface/datasets/pull/6844
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6844", "html_url": "https://github.com/huggingface/datasets/pull/6844", "diff_url": "https://github.com/huggingface/datasets/pull/6844.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6844.patch", "merged_at": null }
6,844
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6844). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "@Wauplin This PR is indeed not needed as explained in https://github.com/huggingface/da...
2,265,432,897
IterableDataset raises exception instead of retrying
open
### Describe the bug In light of the recent server outages, I decided to look into whether I could somehow wrap my IterableDataset streams to retry rather than error out immediately. To my surprise, `datasets` [already supports retries](https://github.com/huggingface/datasets/issues/6172#issuecomment-1794876229). Si...
2024-04-26T10:00:43
2024-10-28T14:57:07
null
https://github.com/huggingface/datasets/issues/6843
null
6,843
false
[ "Thanks for reporting! I've opened a PR with a fix.", "Thanks, @mariosasko! Related question (although I guess this is a feature request): could we have some kind of exponential back-off for these retries? Here's my reasoning:\r\n- If a one-time accidental error happens, you should retry immediately and will succ...
2,264,692,159
Datasets with files with colon : in filenames cannot be used on Windows
open
### Describe the bug Datasets (such as https://huggingface.co/datasets/MLCommons/peoples_speech) cannot be used on Windows due to the fact that windows does not allow colons ":" in filenames. These should be converted into alternative strings. ### Steps to reproduce the bug 1. Attempt to run load_dataset on MLCo...
2024-04-26T00:14:16
2024-04-26T00:14:16
null
https://github.com/huggingface/datasets/issues/6842
null
6,842
false
[]
2,264,687,683
Unable to load wiki_auto_asset_turk from GEM
closed
### Describe the bug I am unable to load the wiki_auto_asset_turk dataset. I get a fatal error while trying to access wiki_auto_asset_turk and load it with datasets.load_dataset. The error (TypeError: expected str, bytes or os.PathLike object, not NoneType) is from filenames_for_dataset_split in a os.path.join call ...
2024-04-26T00:08:47
2024-05-29T13:54:03
2024-04-26T16:12:29
https://github.com/huggingface/datasets/issues/6841
null
6,841
false
[ "Hi! I've opened a [PR](https://huggingface.co/datasets/GEM/wiki_auto_asset_turk/discussions/5) with a fix. While waiting for it to be merged, you can load the dataset from the PR branch with `datasets.load_dataset(\"GEM/wiki_auto_asset_turk\", revision=\"refs/pr/5\")`", "Thanks Mario. Still getting the same issu...
2,264,604,766
Delete uploaded files from the UI
open
### Feature request Once a file is uploaded and the commit is made, I am unable to delete individual files without completely deleting the whole dataset via the website UI. ### Motivation Would be a useful addition ### Your contribution Would love to help out with some guidance
2024-04-25T22:33:57
2025-01-21T09:44:22
null
https://github.com/huggingface/datasets/issues/6840
null
6,840
false
[ "This is super late, but if you click on any directory, you can delete the directory using a \"Delete Directory\" button in the top right of the interface, and similarly, if you click on any file, you can delete the file using a \"Delete File\" button in the top right." ]
2,263,761,062
Remove token arg from CLI examples
closed
Remove token arg from CLI examples. Fix #6838. CC: @Wauplin
2024-04-25T14:36:58
2024-04-26T17:03:51
2024-04-26T16:57:40
https://github.com/huggingface/datasets/pull/6839
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6839", "html_url": "https://github.com/huggingface/datasets/pull/6839", "diff_url": "https://github.com/huggingface/datasets/pull/6839.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6839.patch", "merged_at": "2024-04-26T16:57...
6,839
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6839). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,263,674,843
Remove token arg from CLI examples
closed
As suggested by @Wauplin, see: https://github.com/huggingface/datasets/pull/6831#discussion_r1579492603 > I would not advertise the --token arg in the example as this shouldn't be the recommended way (best to login with env variable or huggingface-cli login)
2024-04-25T14:00:38
2024-04-26T16:57:41
2024-04-26T16:57:41
https://github.com/huggingface/datasets/issues/6838
null
6,838
false
[]
2,263,273,983
Cannot use cached dataset without Internet connection (or when servers are down)
open
### Describe the bug I want to be able to use cached dataset from HuggingFace even when I have no Internet connection (or when HuggingFace servers are down, or my company has network issues). The problem why I can't use it: `data_files` argument from `datasets.load_dataset()` function get it updates from the serve...
2024-04-25T10:48:20
2025-01-25T16:36:41
null
https://github.com/huggingface/datasets/issues/6837
null
6,837
false
[ "There are 2 workarounds, tho:\r\n1. Download datasets from web and just load them locally\r\n2. Use metadata directly (temporal solution, since metadata can change)\r\n```\r\nimport datasets\r\nfrom datasets.data_files import DataFilesDict, DataFilesList\r\n\r\ndata_files_list = DataFilesList(\r\n [\r\n ...
2,262,249,919
ExpectedMoreSplits error on load_dataset when upgrading to 2.19.0
open
### Describe the bug Hi there, thanks for the great library! We have been using it a lot in torchtune and it's been a huge help for us. Regarding the bug: the same call to `load_dataset` errors with `ExpectedMoreSplits` in 2.19.0 after working fine in 2.18.0. Full details given in the repro below. ### Steps to re...
2024-04-24T21:52:35
2024-05-14T04:08:19
null
https://github.com/huggingface/datasets/issues/6836
null
6,836
false
[ "Get same error on same datasets too.", "+1", "same error" ]
2,261,079,263
Support pyarrow LargeListType
closed
Fixes #6834
2024-04-24T11:34:24
2024-08-12T14:43:47
2024-08-12T14:43:47
https://github.com/huggingface/datasets/pull/6835
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6835", "html_url": "https://github.com/huggingface/datasets/pull/6835", "diff_url": "https://github.com/huggingface/datasets/pull/6835.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6835.patch", "merged_at": null }
6,835
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6835). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Fixed the conversion from `pyarrow` to `python` `Sequence` features. \r\n\r\nThere is s...
2,261,078,104
largelisttype not supported (.from_polars())
closed
### Describe the bug The following code fails because LargeListType is not supported. This is especially a problem for .from_polars since polars uses LargeListType. ### Steps to reproduce the bug ```python import datasets import polars as pl df = pl.DataFrame({"list": [[]]}) datasets.Dataset.from_pola...
2024-04-24T11:33:43
2024-08-12T14:43:46
2024-08-12T14:43:46
https://github.com/huggingface/datasets/issues/6834
null
6,834
false
[]
2,259,731,274
Super slow iteration with trivial custom transform
open
### Describe the bug Dataset is 10X slower when applying trivial transforms: ``` import time import numpy as np from datasets import Dataset, Features, Array2D a = np.zeros((800, 800)) a = np.stack([a] * 1000) features = Features({"a": Array2D(shape=(800, 800), dtype="uint8")}) ds1 = Dataset.from_dict({"...
2024-04-23T20:40:59
2024-10-08T15:41:18
null
https://github.com/huggingface/datasets/issues/6833
null
6,833
false
[ "Similar issue in text process \r\n\r\n```python\r\n\r\ntokenizer=AutoTokenizer.from_pretrained(model_dir[args.model])\r\ntrain_dataset=datasets.load_from_disk(dataset_dir[args.dataset],keep_in_memory=True)['train']\r\ntrain_dataset=train_dataset.map(partial(dname2func[args.dataset],tokenizer=tokenizer),batched=Tru...
2,258,761,447
Support downloading specific splits in `load_dataset`
open
This PR builds on https://github.com/huggingface/datasets/pull/6639 to support downloading only the specified splits in `load_dataset`. For this to work, a builder's `_split_generators` need to be able to accept the requested splits (as a list) via a `splits` argument to avoid processing the non-requested ones. Also, t...
2024-04-23T12:32:27
2025-07-21T07:49:31
null
https://github.com/huggingface/datasets/pull/6832
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6832", "html_url": "https://github.com/huggingface/datasets/pull/6832", "diff_url": "https://github.com/huggingface/datasets/pull/6832.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6832.patch", "merged_at": null }
6,832
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6832). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Friendly ping on this! This feature would be really helpful and useful to me (and likel...
2,258,537,405
Add docs about the CLI
closed
Add docs about the CLI. Close #6830. CC: @severo
2024-04-23T10:41:03
2024-04-26T16:51:09
2024-04-25T10:44:10
https://github.com/huggingface/datasets/pull/6831
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6831", "html_url": "https://github.com/huggingface/datasets/pull/6831", "diff_url": "https://github.com/huggingface/datasets/pull/6831.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6831.patch", "merged_at": "2024-04-25T10:44...
6,831
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6831). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Concretely, the docs about convert_to_parquet are here: https://moon-ci-docs.huggingfac...
2,258,433,178
Add a doc page for the convert_to_parquet CLI
closed
Follow-up to https://github.com/huggingface/datasets/pull/6795. Useful for https://github.com/huggingface/dataset-viewer/issues/2742. cc @albertvillanova
2024-04-23T09:49:04
2024-04-25T10:44:11
2024-04-25T10:44:11
https://github.com/huggingface/datasets/issues/6830
null
6,830
false
[]
2,258,424,577
Load and save from/to disk no longer accept pathlib.Path
open
Reported by @vttrifonov at https://github.com/huggingface/datasets/pull/6704#issuecomment-2071168296: > This change is breaking in > https://github.com/huggingface/datasets/blob/f96e74d5c633cd5435dd526adb4a74631eb05c43/src/datasets/arrow_dataset.py#L1515 > when the input is `pathlib.Path`. The issue is that `url_to...
2024-04-23T09:44:45
2024-04-23T09:44:46
null
https://github.com/huggingface/datasets/issues/6829
null
6,829
false
[]
2,258,420,421
Support PathLike input in save_to_disk / load_from_disk
open
null
2024-04-23T09:42:38
2024-04-23T11:05:52
null
https://github.com/huggingface/datasets/pull/6828
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6828", "html_url": "https://github.com/huggingface/datasets/pull/6828", "diff_url": "https://github.com/huggingface/datasets/pull/6828.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6828.patch", "merged_at": null }
6,828
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6828). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update." ]
2,254,011,833
Loading a remote dataset fails in the last release (v2.19.0)
open
While loading a dataset with multiple splits I get an error saying `Couldn't find file at <URL>` I am loading the dataset like so, nothing out of the ordinary. This dataset needs a token to access it. ``` token="hf_myhftoken-sdhbdsjgkhbd" load_dataset("speechcolab/gigaspeech", "test", cache_dir=f"gigaspeech/test...
2024-04-19T21:11:58
2024-04-19T21:13:42
null
https://github.com/huggingface/datasets/issues/6827
null
6,827
false
[]
2,252,445,242
Set dev version
closed
null
2024-04-19T08:51:42
2024-04-19T09:05:25
2024-04-19T08:52:14
https://github.com/huggingface/datasets/pull/6826
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6826", "html_url": "https://github.com/huggingface/datasets/pull/6826", "diff_url": "https://github.com/huggingface/datasets/pull/6826.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6826.patch", "merged_at": "2024-04-19T08:52...
6,826
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6826). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,252,404,599
Release: 2.19.0
closed
null
2024-04-19T08:29:02
2024-05-04T12:23:26
2024-04-19T08:44:57
https://github.com/huggingface/datasets/pull/6825
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6825", "html_url": "https://github.com/huggingface/datasets/pull/6825", "diff_url": "https://github.com/huggingface/datasets/pull/6825.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6825.patch", "merged_at": "2024-04-19T08:44...
6,825
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6825). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,251,076,197
Winogrande does not seem to be compatible with datasets version of 1.18.0
closed
### Describe the bug I get the following error when simply running `load_dataset('winogrande','winogrande_xl')`. I do not have such an issue in the 1.17.0 version. ```Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/local/lib/python3.10/dist-packages/datasets/load.py", line...
2024-04-18T16:11:04
2024-04-19T09:53:15
2024-04-19T09:52:33
https://github.com/huggingface/datasets/issues/6824
null
6,824
false
[ "Hi ! Do you mean 2.18 ? Can you try to update `fsspec` and `huggingface_hub` ?\r\n\r\n```\r\npip install -U fsspec huggingface_hub\r\n```", "Yes I meant 2.18, and it works after updating `fsspec` and `huggingface_hub`. Thanks!" ]
2,250,775,569
Loading problems of Datasets with a single shard
open
### Describe the bug When saving a dataset on disk and it has a single shard it is not loaded as when it is saved in multiple shards. I installed the latest version of datasets via pip. ### Steps to reproduce the bug The code below reproduces the behavior. All works well when the range of the loop is 10000 bu...
2024-04-18T13:59:00
2024-11-25T05:40:09
null
https://github.com/huggingface/datasets/issues/6823
null
6,823
false
[ "Has there been a PR to resolve this already?", "The problem rises from using a wrong api.\r\nWhen loading a save_to_disk dataset, **load_from_disk** (instead of load_dataset) is what should be used.\r\n\r\n```python\r\nfrom datasets import load_from_disk\r\n\r\ndst.save_to_disk(\"cache\")\r\ndst = load_from_disk...
2,250,316,258
Fix parquet export infos
closed
Don't use the parquet export infos when USE_PARQUET_EXPORT is False. Otherwise the `datasets-server` might reuse erroneous data when re-running a job this follows https://github.com/huggingface/datasets/pull/6714
2024-04-18T10:21:41
2024-04-18T11:15:41
2024-04-18T11:09:13
https://github.com/huggingface/datasets/pull/6822
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6822", "html_url": "https://github.com/huggingface/datasets/pull/6822", "diff_url": "https://github.com/huggingface/datasets/pull/6822.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6822.patch", "merged_at": "2024-04-18T11:09...
6,822
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6822). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,248,471,673
Allow deleting a subset/config from a no-script dataset
closed
TODO: - [x] Add docs - [x] Delete token arg from CLI example - See: #6839 Close #6810.
2024-04-17T14:41:12
2024-05-02T07:31:03
2024-04-30T09:44:24
https://github.com/huggingface/datasets/pull/6820
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6820", "html_url": "https://github.com/huggingface/datasets/pull/6820", "diff_url": "https://github.com/huggingface/datasets/pull/6820.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6820.patch", "merged_at": "2024-04-30T09:44...
6,820
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6820). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "This is ready for review, @huggingface/datasets.", "I am adding a test...", "@lhoes...
2,248,043,797
Give more details in `DataFilesNotFoundError` when getting the config names
open
### Feature request After https://huggingface.co/datasets/cis-lmu/Glot500/commit/39060e01272ff228cc0ce1d31ae53789cacae8c3, the dataset viewer gives the following error: ``` { "error": "Cannot get the config names for the dataset.", "cause_exception": "DataFilesNotFoundError", "cause_message": "No (support...
2024-04-17T11:19:47
2024-04-17T11:19:47
null
https://github.com/huggingface/datasets/issues/6819
null
6,819
false
[]
2,246,578,480
Support indexable objects in `Dataset.__getitem__`
closed
As discussed in https://github.com/huggingface/datasets/pull/6816, this is needed to support objects that implement `__index__` such as `np.int64` in `Dataset.__getitem__`.
2024-04-16T17:41:27
2024-04-16T18:27:44
2024-04-16T18:17:29
https://github.com/huggingface/datasets/pull/6817
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6817", "html_url": "https://github.com/huggingface/datasets/pull/6817", "diff_url": "https://github.com/huggingface/datasets/pull/6817.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6817.patch", "merged_at": "2024-04-16T18:17...
6,817
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6817). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,246,264,911
Improve typing of Dataset.search, matching definition
closed
Previously, the output of `score, indices = Dataset.search(...)` would be numpy arrays. The definition in `SearchResult` is a `List[int]` so this PR now matched the expected type. The previous behavior is a bit annoying as `Dataset.__getitem__` doesn't support `numpy.int64` which forced me to convert `indices` to...
2024-04-16T14:53:39
2024-04-16T15:54:10
2024-04-16T15:54:10
https://github.com/huggingface/datasets/pull/6816
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6816", "html_url": "https://github.com/huggingface/datasets/pull/6816", "diff_url": "https://github.com/huggingface/datasets/pull/6816.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6816.patch", "merged_at": null }
6,816
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6816). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Hi! This is a breaking change. A better solution is to check for \"indexable\" types in...
2,246,197,070
Remove `os.path.relpath` in `resolve_patterns`
closed
... to save a few seconds when resolving repos with many data files.
2024-04-16T14:23:13
2024-04-16T16:06:48
2024-04-16T15:58:22
https://github.com/huggingface/datasets/pull/6815
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6815", "html_url": "https://github.com/huggingface/datasets/pull/6815", "diff_url": "https://github.com/huggingface/datasets/pull/6815.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6815.patch", "merged_at": "2024-04-16T15:58...
6,815
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6815). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,245,857,902
`map` with `num_proc` > 1 leads to OOM
open
### Describe the bug When running `map` on parquet dataset loaded from local machine, the RAM usage increases linearly eventually leading to OOM. I was wondering if I should I save the `cache_file` after every n steps in order to prevent this? ### Steps to reproduce the bug ``` ds = load_dataset("parquet", data...
2024-04-16T11:56:03
2024-04-19T11:53:41
null
https://github.com/huggingface/datasets/issues/6814
null
6,814
false
[ "Hi ! You can try to reduce `writer_batch_size`. It corresponds to the number of samples that stay in RAM before being flushed to disk" ]
2,245,626,870
Add Dataset.take and Dataset.skip
closed
...to be aligned with IterableDataset.take and IterableDataset.skip
2024-04-16T09:53:42
2024-04-16T14:12:14
2024-04-16T14:06:07
https://github.com/huggingface/datasets/pull/6813
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6813", "html_url": "https://github.com/huggingface/datasets/pull/6813", "diff_url": "https://github.com/huggingface/datasets/pull/6813.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6813.patch", "merged_at": "2024-04-16T14:06...
6,813
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6813). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,244,898,824
Run CI
closed
null
2024-04-16T01:12:36
2024-04-16T01:14:16
2024-04-16T01:12:41
https://github.com/huggingface/datasets/pull/6812
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6812", "html_url": "https://github.com/huggingface/datasets/pull/6812", "diff_url": "https://github.com/huggingface/datasets/pull/6812.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6812.patch", "merged_at": null }
6,812
true
[ "(Sorry, meant to open this against my own fork. I'm attempting to debug this issue (https://github.com/astral-sh/uv/issues/1921#issuecomment-2058056192) reported by `huggingface/datasets` on the uv repo.)" ]
2,243,656,096
add allow_primitive_to_str and allow_decimal_to_str instead of allow_number_to_str
closed
Fix #6805
2024-04-15T13:14:38
2024-07-03T14:59:42
2024-04-16T17:03:17
https://github.com/huggingface/datasets/pull/6811
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6811", "html_url": "https://github.com/huggingface/datasets/pull/6811", "diff_url": "https://github.com/huggingface/datasets/pull/6811.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6811.patch", "merged_at": "2024-04-16T17:03...
6,811
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6811). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "@mariosasko pytest seems to be missing on windows?", "CI is not behaving well today οΏ½...
2,242,968,745
Allow deleting a subset/config from a no-script dataset
closed
As proposed by @BramVanroy, it would be neat to have this functionality through the API.
2024-04-15T07:53:26
2025-01-11T18:40:40
2024-04-30T09:44:25
https://github.com/huggingface/datasets/issues/6810
null
6,810
false
[ "Probably best to implement this as a CLI command?", "Thanks for your comment, @mariosasko. Or maybe both (in Python and as CLI command)? The Python command would be just the reverse of `push_to_hub`...\r\n\r\nI am working on a draft implementation, so we can discuss about the API and UX.", "2nd time I've come ...
2,242,956,297
Make convert_to_parquet CLI command create script branch
closed
Make convert_to_parquet CLI command create a "script" branch and keep the script file on it. This PR proposes the simplest UX approach: whenever `--revision` is not explicitly passed (i.e., when the script is in the main branch), try to create a "script" branch from the "main" branch; if the "script" branch exists a...
2024-04-15T07:47:26
2024-04-17T08:44:26
2024-04-17T08:38:18
https://github.com/huggingface/datasets/pull/6809
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6809", "html_url": "https://github.com/huggingface/datasets/pull/6809", "diff_url": "https://github.com/huggingface/datasets/pull/6809.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6809.patch", "merged_at": "2024-04-17T08:38...
6,809
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6809). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "@huggingface/datasets once this PR is merged, I would suggest making a release. Do you ...
2,242,843,611
Make convert_to_parquet CLI command create script branch
closed
As proposed by @severo, maybe we should add this functionality as well to the CLI command to convert a script-dataset to Parquet. See: https://github.com/huggingface/datasets/pull/6795#discussion_r1562819168 > When providing support, we sometimes suggest that users store their script in a script branch. What do you th...
2024-04-15T06:46:07
2024-04-17T08:38:19
2024-04-17T08:38:19
https://github.com/huggingface/datasets/issues/6808
null
6,808
false
[]
2,239,435,074
Fix hf-internal-testing/dataset_with_script commit SHA in CI test
closed
Fix test using latest commit SHA in hf-internal-testing/dataset_with_script dataset: https://huggingface.co/datasets/hf-internal-testing/dataset_with_script/commits/refs%2Fconvert%2Fparquet Fix #6796.
2024-04-12T08:47:50
2024-04-12T09:08:23
2024-04-12T09:02:12
https://github.com/huggingface/datasets/pull/6806
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6806", "html_url": "https://github.com/huggingface/datasets/pull/6806", "diff_url": "https://github.com/huggingface/datasets/pull/6806.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6806.patch", "merged_at": "2024-04-12T09:02...
6,806
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6806). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,239,034,951
Batched mapping of existing string column casts boolean to string
closed
### Describe the bug Let the dataset contain a column named 'a', which is of the string type. If 'a' is converted to a boolean using batched mapping, the mapper automatically casts the boolean to a string (e.g., True -> 'true'). It only happens when the original column and the mapped column name are identical. Th...
2024-04-12T04:21:41
2024-07-03T15:00:07
2024-07-03T15:00:07
https://github.com/huggingface/datasets/issues/6805
null
6,805
false
[ "This seems to be hardcoded behavior in table.py `array_cast`.\r\n```python\r\nif (\r\n not allow_number_to_str\r\n and pa.types.is_string(pa_type)\r\n and (pa.types.is_floating(array.type) or pa.types.is_integer(array.type))\r\n ):\r\n raise TypeError(\r\n ...
2,238,035,124
Fix --repo-type order in cli upload docs
closed
null
2024-04-11T15:39:09
2024-04-11T16:24:57
2024-04-11T16:18:47
https://github.com/huggingface/datasets/pull/6804
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6804", "html_url": "https://github.com/huggingface/datasets/pull/6804", "diff_url": "https://github.com/huggingface/datasets/pull/6804.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6804.patch", "merged_at": "2024-04-11T16:18...
6,804
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6804). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,237,933,090
#6791 Improve type checking around FAISS
closed
Fixes #6791 Small PR to raise a better error when a dataset is not embedded properly.
2024-04-11T14:54:30
2024-04-11T15:44:09
2024-04-11T15:38:04
https://github.com/huggingface/datasets/pull/6803
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6803", "html_url": "https://github.com/huggingface/datasets/pull/6803", "diff_url": "https://github.com/huggingface/datasets/pull/6803.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6803.patch", "merged_at": "2024-04-11T15:38...
6,803
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6803). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "CI failures are unrelated.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArro...
2,237,365,489
Fix typo in docs (upload CLI)
closed
Related to https://huggingface.slack.com/archives/C04RG8YRVB8/p1712643948574129 (interal) Positional args must be placed before optional args. Feel free to merge whenever it's ready.
2024-04-11T10:05:05
2024-04-11T16:19:00
2024-04-11T13:19:43
https://github.com/huggingface/datasets/pull/6802
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6802", "html_url": "https://github.com/huggingface/datasets/pull/6802", "diff_url": "https://github.com/huggingface/datasets/pull/6802.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6802.patch", "merged_at": "2024-04-11T13:19...
6,802
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6802). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,236,911,556
got fileNotFound
closed
### Describe the bug When I use load_dataset to load the nyanko7/danbooru2023 data set, the cache is read in the form of a symlink. There may be a problem with the arrow_dataset initialization process and I get FileNotFoundError: [Errno 2] No such file or directory: '2945000.jpg' ### Steps to reproduce the bug #code...
2024-04-11T04:57:41
2024-04-12T16:47:43
2024-04-12T16:47:43
https://github.com/huggingface/datasets/issues/6801
null
6,801
false
[ "Hi! I'll open a PR on the Hub to fix this, but please use the Hub's [Community tab](https://huggingface.co/datasets/nyanko7/danbooru2023/discussions) to report such issues in the future.", "I've opened a [PR](https://huggingface.co/datasets/nyanko7/danbooru2023/discussions/8) in the repo, so let's continue the d...
2,236,431,288
High overhead when loading lots of subsets from the same dataset
open
### Describe the bug I have a multilingual dataset that contains a lot of subsets. Each subset corresponds to a pair of languages, you can see here an example with 250 subsets: [https://hf.co/datasets/loicmagne/open-subtitles-250-bitext-mining](). As part of the MTEB benchmark, we may need to load all the subsets of t...
2024-04-10T21:08:57
2024-04-24T13:48:05
null
https://github.com/huggingface/datasets/issues/6800
null
6,800
false
[ "Hi !\r\n\r\nIt's possible to multiple files at once:\r\n\r\n```python\r\ndata_files = \"data/*.jsonl\"\r\n# Or pass a list of files\r\nlangs = ['ka-ml', 'br-sr', 'ka-pt', 'id-ko', ..., 'fi-ze_zh', 'he-kk', 'ka-tr']\r\ndata_files = [f\"data/{lang}.jsonl\" for lang in langs]\r\nds = load_dataset(\"loicmagne/open-sub...
2,236,124,531
fix `DatasetBuilder._split_generators` incomplete type annotation
closed
solve #6798: add missing `StreamingDownloadManager` type annotation to the `dl_manager` argument of the `DatasetBuilder._split_generators` function
2024-04-10T17:46:08
2024-04-11T15:41:06
2024-04-11T15:34:58
https://github.com/huggingface/datasets/pull/6799
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6799", "html_url": "https://github.com/huggingface/datasets/pull/6799", "diff_url": "https://github.com/huggingface/datasets/pull/6799.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6799.patch", "merged_at": "2024-04-11T15:34...
6,799
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6799). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "The CI failures are unrelated to the changes", "<details>\n<summary>Show benchmarks</...
2,235,768,891
`DatasetBuilder._split_generators` incomplete type annotation
closed
### Describe the bug The [`DatasetBuilder._split_generators`](https://github.com/huggingface/datasets/blob/0f27d7b77c73412cfc50b24354bfd7a3e838202f/src/datasets/builder.py#L1449) function has currently the following signature: ```python class DatasetBuilder: def _split_generators(self, dl_manager: DownloadMan...
2024-04-10T14:38:50
2024-04-11T15:34:59
2024-04-11T15:34:59
https://github.com/huggingface/datasets/issues/6798
null
6,798
false
[ "Good catch! Feel free to open a PR with the suggested fix :).", "There is also the [`MockDownloadManager`](https://github.com/JonasLoos/datasets/blob/main/src/datasets/download/mock_download_manager.py#L33), which seems like it might get passed here too. However, to me, it doesn't really seem relevant to the use...
2,234,890,097
Fix CI test_load_dataset_distributed_with_script
closed
Fix #6796.
2024-04-10T06:57:48
2024-04-10T08:25:00
2024-04-10T08:18:01
https://github.com/huggingface/datasets/pull/6797
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6797", "html_url": "https://github.com/huggingface/datasets/pull/6797", "diff_url": "https://github.com/huggingface/datasets/pull/6797.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6797.patch", "merged_at": null }
6,797
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6797). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Finally:\r\n- the initial issue seems it was temporary\r\n- there is a different issue ...
2,234,887,618
CI is broken due to hf-internal-testing/dataset_with_script
closed
CI is broken for test_load_dataset_distributed_with_script. See: https://github.com/huggingface/datasets/actions/runs/8614926216/job/23609378127 ``` FAILED tests/test_load.py::test_load_dataset_distributed_with_script[None] - assert False + where False = all(<generator object test_load_dataset_distributed_with_scr...
2024-04-10T06:56:02
2024-04-12T09:02:13
2024-04-12T09:02:13
https://github.com/huggingface/datasets/issues/6796
null
6,796
false
[ "Finally:\r\n- the initial issue seems it was temporary\r\n- there is a different issue now: https://github.com/huggingface/datasets/actions/runs/8627153993/job/23646584590?pr=6797\r\n```\r\nFAILED tests/test_load.py::ModuleFactoryTest::test_HubDatasetModuleFactoryWithParquetExport - datasets.utils._dataset_viewer....
2,233,618,719
Add CLI function to convert script-dataset to Parquet
closed
Close #6690.
2024-04-09T14:45:12
2024-04-17T08:41:23
2024-04-12T15:27:04
https://github.com/huggingface/datasets/pull/6795
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6795", "html_url": "https://github.com/huggingface/datasets/pull/6795", "diff_url": "https://github.com/huggingface/datasets/pull/6795.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6795.patch", "merged_at": "2024-04-12T15:27...
6,795
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6795). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "@huggingface/datasets once this PR is merged, I would suggest making a release. Do you ...
2,233,202,088
Multithreaded downloads
closed
...for faster dataset download when there are many many small files (e.g. imagefolder, audiofolder) ### Behcnmark for example on [lhoestq/tmp-images-writer_batch_size](https://hf.co/datasets/lhoestq/tmp-images-writer_batch_size) (128 images) | | duration of the download step in `load_dataset()` | |--| ----...
2024-04-09T11:13:19
2024-04-15T21:24:13
2024-04-15T21:18:08
https://github.com/huggingface/datasets/pull/6794
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6794", "html_url": "https://github.com/huggingface/datasets/pull/6794", "diff_url": "https://github.com/huggingface/datasets/pull/6794.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6794.patch", "merged_at": "2024-04-15T21:18...
6,794
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6794). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "CI is failing because of the missing parquet export of one test dataset, PR to fix this...
2,231,400,200
Loading just one particular split is not possible for imagenet-1k
open
### Describe the bug I'd expect the following code to download just the validation split but instead I get all data on my disk (train, test and validation splits) ` from datasets import load_dataset dataset = load_dataset("imagenet-1k", split="validation", trust_remote_code=True) ` Is it expected to work li...
2024-04-08T14:39:14
2025-06-23T09:55:08
null
https://github.com/huggingface/datasets/issues/6793
null
6,793
false
[ "+1", "+1\n" ]
2,231,318,682
Fix cache conflict in `_check_legacy_cache2`
closed
It was reloading from the wrong cache dir because of a bug in `_check_legacy_cache2`. This function should not trigger if there are config_kwars like `sample_by=` fix https://github.com/huggingface/datasets/issues/6758
2024-04-08T14:05:42
2024-04-09T11:34:08
2024-04-09T11:27:58
https://github.com/huggingface/datasets/pull/6792
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6792", "html_url": "https://github.com/huggingface/datasets/pull/6792", "diff_url": "https://github.com/huggingface/datasets/pull/6792.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6792.patch", "merged_at": "2024-04-09T11:27...
6,792
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6792). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,230,102,332
`add_faiss_index` raises ValueError: not enough values to unpack (expected 2, got 1)
closed
### Describe the bug Calling `add_faiss_index` on a `Dataset` with a column argument raises a ValueError. The following is the trace ```python 214 def replacement_add(self, x): 215 """Adds vectors to the index. 216 The index must be trained before vectors can be added to it. 217 Th...
2024-04-08T01:57:03
2024-04-11T15:38:05
2024-04-11T15:38:05
https://github.com/huggingface/datasets/issues/6791
null
6,791
false
[ "I realized I was passing a string column to this instead of float. Is it possible to add a warning or error to prevent users from falsely believing there's a bug?", "Hello!\r\n\r\nI agree that we could add some safeguards around the type of `ds[column]`. At least for FAISS, we need the column to be made of embed...
2,229,915,236
PyArrow 'Memory mapping file failed: Cannot allocate memory' bug
open
### Describe the bug Hello, I've been struggling with a problem using Huggingface datasets caused by PyArrow memory allocation. I finally managed to solve it, and thought to document it since similar issues have been raised here before (https://github.com/huggingface/datasets/issues/5710, https://github.com/huggi...
2024-04-07T19:25:39
2025-06-12T07:31:44
null
https://github.com/huggingface/datasets/issues/6790
null
6,790
false
[ "Thanks for a very clean explanation. This happened to me too, and I don't have sudo access to update the value. I wonder if there might be another workaround.", "One option is to just have more data in each file - /proc/sys/vm/max_map_count limits the maximum number of concurrently open files, but I don't know i...
2,229,527,001
Issue with map
open
### Describe the bug Map has been taking extremely long to preprocess my data. It seems to process 1000 examples (which it does really fast in about 10 seconds), then it hangs for a good 1-2 minutes, before it moves on to the next batch of 1000 examples. It also keeps eating up my hard drive space for some reaso...
2024-04-07T02:52:06
2024-07-23T12:41:38
null
https://github.com/huggingface/datasets/issues/6789
null
6,789
false
[ "Default `writer_batch_size `is set to 1000 (see [map](https://huggingface.co/docs/datasets/v2.16.1/en/package_reference/main_classes#datasets.Dataset.map)).\r\nThe \"tmp1335llua\" is probably the temp file it creates while writing to disk.\r\nMaybe try lowering the `writer_batch_size`.\r\n\r\nFor multi-processing ...
2,229,207,521
A Question About the Map Function
closed
### Describe the bug Hello, I have a question regarding the map function in the Hugging Face datasets. The situation is as follows: when I load a jsonl file using load_dataset(..., streaming=False), and then utilize the map function to process it, I specify that the returned example should be of type Torch.ten...
2024-04-06T11:45:23
2024-04-11T05:29:35
2024-04-11T05:29:35
https://github.com/huggingface/datasets/issues/6788
null
6,788
false
[ "All data is saved in the arrow format on disk.\r\nIf you return a tensor it gets converted to arrow before saving to disk when using map.\r\n\r\nTo get a tensor when you access data elements you can use `dataset.set_format(\"pt\")`.\r\nNote that this just changes how the data is loaded, not how it is stored.", "...
2,229,103,264
TimeoutError in map
open
### Describe the bug ```python from datasets import Dataset def worker(example): while True: continue example['a'] = 100 return example data = Dataset.from_list([{"a": 1}, {"a": 2}]) data = data.map(worker) print(data[0]) ``` I'm implementing a worker function whose runtime will de...
2024-04-06T06:25:39
2024-08-14T02:09:57
null
https://github.com/huggingface/datasets/issues/6787
null
6,787
false
[ "From my current understanding, this timeout is only used when we need to get the results.\r\n\r\nOne of:\r\n1. All tasks are done\r\n2. One worker died\r\n\r\nYour function should work fine and it's definitely a bug if it doesn't.", "When one of the `map`'s worker processes crashes, the linked code re-raises an ...
2,228,463,776
Make Image cast storage faster
open
PR for issue #6782. Makes `cast_storage` of the `Image` class faster by removing the slow call to `.pylist`. Instead directly convert each `ListArray` item to either `Array2DExtensionType` or `Array3DExtensionType`. This also preserves the `dtype` removing the warning if the array is already `uint8`.
2024-04-05T17:00:46
2024-10-01T09:09:14
null
https://github.com/huggingface/datasets/pull/6786
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6786", "html_url": "https://github.com/huggingface/datasets/pull/6786", "diff_url": "https://github.com/huggingface/datasets/pull/6786.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6786.patch", "merged_at": null }
6,786
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6786). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Hi ! Thanks for diving into this, this conversion to python lists is indeed quite slow....
2,228,429,852
rename datasets-server to dataset-viewer
closed
See https://github.com/huggingface/dataset-viewer/issues/2650 Tell me if it's OK, or if it's a breaking change that must be handled differently. Also note that the docs page is still https://huggingface.co/docs/datasets-server/, so I didn't change it. And the API URL is still https://datasets-server.huggingfac...
2024-04-05T16:37:05
2024-04-08T12:41:13
2024-04-08T12:35:02
https://github.com/huggingface/datasets/pull/6785
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6785", "html_url": "https://github.com/huggingface/datasets/pull/6785", "diff_url": "https://github.com/huggingface/datasets/pull/6785.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6785.patch", "merged_at": "2024-04-08T12:35...
6,785
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6785). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,228,390,504
Extract data on the fly in packaged builders
closed
Instead of waiting for data files to be extracted in the packaged builders, we can prepend the compression prefix and extract them as they are being read (using `fsspec`). This saves disk space (deleting extracted archives is not set by default) and slightly speeds up dataset generation (less disk reads)
2024-04-05T16:12:25
2024-04-16T16:37:47
2024-04-16T16:31:29
https://github.com/huggingface/datasets/pull/6784
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6784", "html_url": "https://github.com/huggingface/datasets/pull/6784", "diff_url": "https://github.com/huggingface/datasets/pull/6784.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6784.patch", "merged_at": "2024-04-16T16:31...
6,784
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6784). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "CI failures are unrelated, so this is ready for the review", "<details>\n<summary>Sho...
2,228,179,466
AttributeError: module 'numpy' has no attribute 'object'. in Kaggle Notebook
closed
### Describe the bug # problem I can't resample audio dataset in Kaggle Notebook. It looks like some code in `datasets` library use aliases that were deprecated in NumPy 1.20. ## code for resampling ``` from datasets import load_dataset, Audio from transformers import AutoFeatureExtractor from transformers imp...
2024-04-05T14:31:48
2024-04-11T17:18:53
2024-04-11T17:18:53
https://github.com/huggingface/datasets/issues/6783
null
6,783
false
[ "Hi! You can fix this by updating the `datasets` package with `pip install -U datasets` and restarting the notebook.\r\n", "Kaggle removed the problematic `datasets==2.1.0` pin last week, so I'm closing this issue (now it pre-installs the latest version)." ]
2,228,081,955
Image cast_storage very slow for arrays (e.g. numpy, tensors)
open
Update: see comments below ### Describe the bug Operations that save an image from a path are very slow. I believe the reason for this is that the image data (`numpy`) is converted into `pyarrow` format but then back to python using `.pylist()` before being converted to a numpy array again. `pylist` is alread...
2024-04-05T13:46:54
2024-04-10T14:36:13
null
https://github.com/huggingface/datasets/issues/6782
null
6,782
false
[ "This may be a solution that only changes `cast_storage` of `Image`.\r\nHowever, I'm not totally sure that the assumptions hold that are made about the `ListArray`.\r\n\r\n```python\r\nelif pa.types.is_list(storage.type):\r\n from .features import Array3DExtensionType\r\n\r\n def get_shapes(arr):\r\n s...
2,228,026,497
Remove get_inferred_type from ArrowWriter write_batch
closed
Inferring the type seems to be unnecessary given that the pyarrow array has already been created. Because pyarrow array creation is sometimes extremely slow this doubles the time write_batch takes.
2024-04-05T13:21:05
2024-04-09T07:49:11
2024-04-09T07:49:11
https://github.com/huggingface/datasets/pull/6781
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6781", "html_url": "https://github.com/huggingface/datasets/pull/6781", "diff_url": "https://github.com/huggingface/datasets/pull/6781.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6781.patch", "merged_at": null }
6,781
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6781). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Close in favor of #6786." ]
2,226,160,096
Fix CI
closed
Updates the `wmt_t2t` test to pin the `revision` to the version with a loading script (cc @albertvillanova). Additionally, it replaces the occurrences of the `lhoestq/test` repo id with `hf-internal-testing/dataset_with_script` and re-enables logging checks in the `Dataset.from_sql` tests.
2024-04-04T17:45:04
2024-04-04T18:46:04
2024-04-04T18:23:34
https://github.com/huggingface/datasets/pull/6780
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6780", "html_url": "https://github.com/huggingface/datasets/pull/6780", "diff_url": "https://github.com/huggingface/datasets/pull/6780.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6780.patch", "merged_at": "2024-04-04T18:23...
6,780
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6780). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,226,075,551
Install dependencies with `uv` in CI
closed
`diffusers` (https://github.com/huggingface/diffusers/pull/7116) and `huggingface_hub` (https://github.com/huggingface/huggingface_hub/pull/2072) also use `uv` to install their dependencies, so we can do the same here. It seems to make the "Install dependencies" step in the `ubuntu` jobs 5-8x faster and 1.5-2x in th...
2024-04-04T17:02:51
2024-04-08T13:34:01
2024-04-08T13:27:44
https://github.com/huggingface/datasets/pull/6779
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6779", "html_url": "https://github.com/huggingface/datasets/pull/6779", "diff_url": "https://github.com/huggingface/datasets/pull/6779.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6779.patch", "merged_at": "2024-04-08T13:27...
6,779
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6779). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,226,040,636
Dataset.to_csv() missing commas in columns with lists
open
### Describe the bug The `to_csv()` method does not output commas in lists. So when the Dataset is loaded back in the data structure of the column with a list is not correct. Here's an example: Obviously, it's not as trivial as inserting commas in the list, since its a comma-separated file. But hopefully there...
2024-04-04T16:46:13
2024-04-08T15:24:41
null
https://github.com/huggingface/datasets/issues/6778
null
6,778
false
[ "Hello!\r\n\r\nThis is due to how pandas write numpy arrays to csv. [Source](https://stackoverflow.com/questions/54753179/to-csv-saves-np-array-as-string-instead-of-as-a-list)\r\nTo fix this, you can convert them to list yourselves.\r\n\r\n```python\r\ndf = ds.to_pandas()\r\ndf['int'] = df['int'].apply(lambda arr: ...
2,224,611,247
.Jsonl metadata not detected
open
### Describe the bug Hi I have the following directory structure: |--dataset | |-- images | |-- metadata1000.csv | |-- metadata1000.jsonl | |-- padded_images Example of metadata1000.jsonl file {"caption": "a drawing depicts a full shot of a black t-shirt with a triangular pattern on the front there is a white...
2024-04-04T06:31:53
2024-04-05T21:14:48
null
https://github.com/huggingface/datasets/issues/6777
null
6,777
false
[ "Hi! `metadata.jsonl` (or `metadata.csv`) is the only allowed name for the `imagefolder`'s metadata files.", "@mariosasko hey i tried with metadata.jsonl also and it still doesn't get the right columns", "@mariosasko it says metadata.csv not found\r\n<img width=\"1150\" alt=\"image\" src=\"https://github.com/hu...
2,223,457,792
IndexError: Invalid key: 0 is out of bounds for size 0
open
### Describe the bug I am trying to fine-tune llama2-7b model in GCP. The notebook I am using for this can be found [here](https://github.com/GoogleCloudPlatform/vertex-ai-samples/blob/main/notebooks/community/model_garden/model_garden_pytorch_llama2_peft_finetuning.ipynb). When I use the dataset given in the exa...
2024-04-03T17:06:30
2024-04-08T01:24:35
null
https://github.com/huggingface/datasets/issues/6775
null
6,775
false
[ "Same problem.", "Hi! You should be able to fix this by passing `remove_unused_columns=False` to the `transformers` `TrainingArguments` as explained in https://github.com/huggingface/peft/issues/1299.\r\n\r\n(I'm not familiar with Vertex AI, but I'd assume `remove_unused_columns` can be passed as a flag to the do...
2,222,164,316
Generating split is very slow when Image format is PNG
open
### Describe the bug When I create a dataset, it gets stuck while generating cached data. The image format is PNG, and it will not get stuck when the image format is jpeg. ![image](https://github.com/huggingface/datasets/assets/22740819/3b888fd8-e6d6-488f-b828-95a8f206a152) After debugging, I know that it is b...
2024-04-03T07:47:31
2024-04-10T17:28:17
null
https://github.com/huggingface/datasets/issues/6774
null
6,774
false
[ "I think this is due to the speed of reading a `png` image using pillow compared to a `jpg` image.\r\nNotably the same is true with `tiff`, it is even faster than `jpg` in my case." ]
2,221,049,121
Dataset on Hub re-downloads every time?
closed
### Describe the bug Hi, I have a dataset on the hub [here](https://huggingface.co/datasets/manestay/borderlines). It has 1k+ downloads, which I sure is mostly just me and my colleagues working with it. It should have far fewer, since I'm using the same machine with a properly set up HF_HOME variable. However, whene...
2024-04-02T17:23:22
2024-04-08T18:43:45
2024-04-08T18:43:45
https://github.com/huggingface/datasets/issues/6773
null
6,773
false
[ "The caching works as expected when I try to reproduce this locally or on Colab...", "hi @mariosasko , Thank you for checking. I also tried running this again just now, and it seems like the `load_dataset()` caches properly (though I'll double check later).\r\n\r\nI think the issue might be in the caching of the ...
2,220,851,533
`remove_columns`/`rename_columns` doc fixes
closed
Use more consistent wording in `remove_columns` to explain why it's faster than `map` and update `remove_columns`/`rename_columns` docstrings to fix in-place calls. Reported in https://github.com/huggingface/datasets/issues/6700
2024-04-02T15:41:28
2024-04-02T16:28:45
2024-04-02T16:17:46
https://github.com/huggingface/datasets/pull/6772
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6772", "html_url": "https://github.com/huggingface/datasets/pull/6772", "diff_url": "https://github.com/huggingface/datasets/pull/6772.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6772.patch", "merged_at": "2024-04-02T16:17...
6,772
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6772). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,220,131,457
Datasets FileNotFoundError when trying to generate examples.
closed
### Discussed in https://github.com/huggingface/datasets/discussions/6768 <div type='discussions-op-text'> <sup>Originally posted by **RitchieP** April 1, 2024</sup> Currently, I have a dataset hosted on Huggingface with a custom script [here](https://huggingface.co/datasets/RitchieP/VerbaLex_voice). I'm loa...
2024-04-02T10:24:57
2024-04-04T14:22:03
2024-04-04T14:22:03
https://github.com/huggingface/datasets/issues/6771
null
6,771
false
[ "Hi! I've opened a PR in the repo to fix this issue: https://huggingface.co/datasets/RitchieP/VerbaLex_voice/discussions/6", "@mariosasko Thanks for the PR and help! Guess I could close the issue for now. Appreciate the help!" ]
2,218,991,883
[Bug Report] `datasets==2.18.0` is not compatible with `fsspec==2023.12.2`
closed
### Describe the bug `Datasets==2.18.0` is not compatible with `fsspec==2023.12.2`. I have to downgrade fsspec to `fsspec==2023.10.0` to make `Datasets==2.18.0` work properly. ### Steps to reproduce the bug To reproduce the bug: 1. Make sure that `Datasets==2.18.0` and `fsspec==2023.12.2`. 2. Run the following ...
2024-04-01T20:17:48
2024-04-11T17:31:44
2024-04-11T17:31:44
https://github.com/huggingface/datasets/issues/6770
null
6,770
false
[ "You should be able to fix this by updating `huggingface_hub` with `pip install -U huggingface_hub`. We use this package under the hood to resolve the Hub's files." ]
2,218,242,015
(Willing to PR) Datasets with custom python objects
open
### Feature request Hi thanks for the library! I would like to have a huggingface Dataset, and one of its column is custom (non-serializable) Python objects. For example, a minimal code: ``` class MyClass: pass dataset = datasets.Dataset.from_list([ dict(a=MyClass(), b='hello'), ]) ``` It gives...
2024-04-01T13:18:47
2024-04-01T13:36:58
null
https://github.com/huggingface/datasets/issues/6769
null
6,769
false
[]
2,217,065,412
fixing the issue 6755(small typo)
closed
Fixed the issue #6755 on the typo mistake
2024-03-31T16:13:37
2024-04-02T14:14:02
2024-04-02T14:01:18
https://github.com/huggingface/datasets/pull/6767
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6767", "html_url": "https://github.com/huggingface/datasets/pull/6767", "diff_url": "https://github.com/huggingface/datasets/pull/6767.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6767.patch", "merged_at": "2024-04-02T14:01...
6,767
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6767). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>...
2,215,933,515
Compatibility issue between s3fs, fsspec, and datasets
closed
### Describe the bug Here is the full error stack when installing: ``` ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. datasets 2.18.0 requires fsspec[http]<=2024.2.0,>=2023.1.0, but you ...
2024-03-29T19:57:24
2024-11-12T14:50:48
2024-04-03T14:33:12
https://github.com/huggingface/datasets/issues/6765
null
6,765
false
[ "Hi! Instead of running `pip install` separately for each package, you should pass all the packages to a single `pip install` call (in this case, `pip install datasets s3fs`) to let `pip` properly resolve their versions.", "> Hi! Instead of running `pip install` separately for each package, you should pass all th...
2,215,767,119
load_dataset can't work with symbolic links
open
### Feature request Enable the `load_dataset` function to load local datasets with symbolic links. E.g, this dataset can be loaded: β”œβ”€β”€ example_dataset/ β”‚ β”œβ”€β”€ data/ β”‚ β”‚ β”œβ”€β”€ train/ β”‚ β”‚ β”‚ β”œβ”€β”€ file0 β”‚ β”‚ β”‚ β”œβ”€β”€ file1 β”‚ β”‚ β”œβ”€β”€ dev/ β”‚ β”‚ β”‚ β”œβ”€β”€ file2 β”‚ β”‚ β”‚ β”œβ”€β”€ file3 β”‚ β”œβ”€β”€ metad...
2024-03-29T17:49:28
2025-04-29T15:06:28
null
https://github.com/huggingface/datasets/issues/6764
null
6,764
false
[ "In fact,You can use a hard link instead of a symbolic link.Hard link works" ]
2,213,440,804
Fix issue with case sensitivity when loading dataset from local cache
open
When a dataset with upper-cases in its name is first loaded using `load_dataset()`, the local cache directory is created with all lowercase letters. However, upon subsequent loads, the current version attempts to locate the cache directory using the dataset's original name, which includes uppercase letters. This di...
2024-03-28T14:52:35
2024-04-20T12:16:45
null
https://github.com/huggingface/datasets/pull/6763
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6763", "html_url": "https://github.com/huggingface/datasets/pull/6763", "diff_url": "https://github.com/huggingface/datasets/pull/6763.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6763.patch", "merged_at": null }
6,763
true
[ "I also need this feature for [\"Cnam-LMSSC/vibravox \"](https://huggingface.co/datasets/Cnam-LMSSC/vibravox)\r\n\r\n\r\nEDIT: Upgrading to `2.19.0` fixed my problem thanks to [this PR](https://github.com/huggingface/datasets/pull/6754)" ]
2,213,275,468
Allow polars as valid output type
closed
I was trying out polars as an output for a map function and found that it wasn't a valid return type in `validate_function_output`. Thought that we should accommodate this by creating and adding it to the `allowed_processed_input_types` variable.
2024-03-28T13:40:28
2024-08-16T15:54:37
2024-08-16T13:10:37
https://github.com/huggingface/datasets/pull/6762
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6762", "html_url": "https://github.com/huggingface/datasets/pull/6762", "diff_url": "https://github.com/huggingface/datasets/pull/6762.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6762.patch", "merged_at": "2024-08-16T13:10...
6,762
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6762). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Hello @lhoestq, I added the test and modified [update_data](https://github.com/huggingf...
2,212,805,108
Remove deprecated code
closed
What does this PR do? 1. remove `list_files_info` in favor of `list_repo_tree`. As of `0.23`, `list_files_info` will be removed for good. `datasets` had a utility to support both pre-0.20 and post-0.20 versions. Since `hfh` version is already pinned to `>=0.21.2`, I removed the legacy part. 2. `preupload_lfs_files` h...
2024-03-28T09:57:57
2024-03-29T13:27:26
2024-03-29T13:18:13
https://github.com/huggingface/datasets/pull/6761
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6761", "html_url": "https://github.com/huggingface/datasets/pull/6761", "diff_url": "https://github.com/huggingface/datasets/pull/6761.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6761.patch", "merged_at": "2024-03-29T13:18...
6,761
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6761). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "Thanks for cleaning this :) I'm also fine with renaming `hf_dataset_url` (and not `get_...
2,212,288,122
Load codeparrot/apps raising UnicodeDecodeError in datasets-2.18.0
open
### Describe the bug This happens with datasets-2.18.0; I downgraded the version to 2.14.6 fixing this temporarily. ``` Traceback (most recent call last): File "/home/xxx/miniconda3/envs/py310/lib/python3.10/site-packages/datasets/load.py", line 2556, in load_dataset builder_instance = load_dataset_builder...
2024-03-28T03:44:26
2024-06-19T07:06:40
null
https://github.com/huggingface/datasets/issues/6760
null
6,760
false
[ "The same error with mteb datasets.", "Unfortunately, I'm unable to reproduce this error locally or on Colab.", "Here is the requirements.txt from a clean virtual environment (managed by conda) where I only install `datasets` by \r\n`pip install datasets`. \r\nThe pip list:\r\n```\r\naiohttp==3.9.3\r\naiosignal...
2,208,892,891
Persistent multi-process Pool
open
### Feature request Running .map and filter functions with `num_procs` consecutively instantiates several multiprocessing pools iteratively. As instantiating a Pool is very resource intensive it can be a bottleneck to performing iteratively filtering. My ideas: 1. There should be an option to declare `persist...
2024-03-26T17:35:25
2024-03-26T17:35:25
null
https://github.com/huggingface/datasets/issues/6759
null
6,759
false
[]
2,208,494,302
Passing `sample_by` to `load_dataset` when loading text data does not work
closed
### Describe the bug I have a dataset that consists of a bunch of text files, each representing an example. There is an undocumented `sample_by` argument for the `TextConfig` class that is used by `Text` to decide whether to split files into lines, paragraphs or take them whole. Passing `sample_by=β€œdocument”` to `load...
2024-03-26T14:55:33
2024-04-09T11:27:59
2024-04-09T11:27:59
https://github.com/huggingface/datasets/issues/6758
null
6,758
false
[ "Thanks for reporting! We are working on a fix." ]
2,206,280,340
Test disabling transformers containers in docs CI
open
Related to https://github.com/huggingface/doc-builder/pull/487 and [internal slack thread](https://huggingface.slack.com/archives/C04F8N7FQNL/p1711384899462349?thread_ts=1711041424.720769&cid=C04F8N7FQNL). There is now a `custom_container` option when building docs in CI. When set to `""` (instead of `"huggingface/tran...
2024-03-25T17:16:11
2024-03-27T16:26:35
null
https://github.com/huggingface/datasets/pull/6757
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/6757", "html_url": "https://github.com/huggingface/datasets/pull/6757", "diff_url": "https://github.com/huggingface/datasets/pull/6757.diff", "patch_url": "https://github.com/huggingface/datasets/pull/6757.patch", "merged_at": null }
6,757
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6757). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.", "On slack it was mentioned that it was actually slower for `datasets`, should we close t...