issue_owner_repo
listlengths
2
2
issue_body
stringlengths
0
261k
issue_title
stringlengths
1
925
issue_comments_url
stringlengths
56
81
issue_comments_count
int64
0
2.5k
issue_created_at
stringlengths
20
20
issue_updated_at
stringlengths
20
20
issue_html_url
stringlengths
37
62
issue_github_id
int64
387k
2.46B
issue_number
int64
1
127k
[ "weidai11", "cryptopp" ]
Simple program that attempts to calculate message digest from string compiles without warnings, but then crashes. gdb shows the following: ``` Program received signal SIGSEGV, Segmentation fault. 0x000000000049e6db in CryptoPP::SHA3::TruncatedFinal (this=0x7fffffffd7e0, hash=0x7fffffffd960 "\270\f\257\367\377\177...
SHA3 CalculateDigest() results in SIGSEGV
https://api.github.com/repos/weidai11/cryptopp/issues/128/comments
2
2016-01-29T11:06:24Z
2016-01-29T14:57:33Z
https://github.com/weidai11/cryptopp/issues/128
129,734,221
128
[ "weidai11", "cryptopp" ]
This caught my eye from the CFE-Users mailing list: [static inline functions in headers and -Wunused-function](http://lists.llvm.org/pipermail/cfe-users/2016-January/000854.html) (Thread view available at [January 2016 Archives by thread](http://lists.llvm.org/pipermail/cfe-users/2016-January/thread.html)). It caught m...
Use of static inline functions in headers may violate ODR and lead to UB
https://api.github.com/repos/weidai11/cryptopp/issues/127/comments
2
2016-01-28T21:39:31Z
2016-01-30T19:04:02Z
https://github.com/weidai11/cryptopp/issues/127
129,590,513
127
[ "weidai11", "cryptopp" ]
It seems that code in IncrementCounterByOne has minor but very important bug which I've already fixed in my branch: ``` inline void IncrementCounterByOne(byte *output, const byte *input, unsigned int size) { assert(output != NULL); assert(input != NULL); assert(size < INT_MAX); int i, carry; for (i=int(si...
misc.h IncrementCounterByOne (output, input, size)
https://api.github.com/repos/weidai11/cryptopp/issues/126/comments
9
2016-01-28T13:03:00Z
2016-01-29T14:54:44Z
https://github.com/weidai11/cryptopp/issues/126
129,446,600
126
[ "weidai11", "cryptopp" ]
Compiles fine but crashes with: crypt: /usr/include/cryptopp/misc.h:304: void CryptoPP::memcpy_s(void_, size_t, const void_, size_t): Assertion `dest != __null' failed. Aborted (core dumped) Debugging leads to: (gdb) up #5 0x00007ffff79898ff in CryptoPP::AlgorithmParametersBase::GetVoidValue(char const_, std::type_...
misc.h, memcpy_s assert() fails
https://api.github.com/repos/weidai11/cryptopp/issues/125/comments
3
2016-01-26T09:45:18Z
2016-01-29T14:56:18Z
https://github.com/weidai11/cryptopp/issues/125
128,774,370
125
[ "weidai11", "cryptopp" ]
When I was running the test suite compiled with Clang and some optimisation passes, I had an error. After some research, I found that the asm volatile didn't have the clobbered registers setted ([link](http://www.codeproject.com/Articles/15971/Using-Inline-Assembly-in-C-C)) in the file _rdrand.cpp_. I am not an exper...
__asm__ volatile missing clobbered registers
https://api.github.com/repos/weidai11/cryptopp/issues/124/comments
9
2016-01-25T13:44:18Z
2016-09-12T14:17:32Z
https://github.com/weidai11/cryptopp/issues/124
128,540,078
124
[ "weidai11", "cryptopp" ]
We recently cut-in [little-endian Integers](https://github.com/weidai11/cryptopp/commit/f8091d9a156bbd9cd8aa7fa4bc7cda7a934ad64e). On Microsoft platforms, use of **_`std:reverse_copy`**_ is causing a C4996 warning: ``` 1>c:\Program Files\...\VC\include\algorithm(2184): warning C4996: 'std::_Reverse_copy': Function cal...
C4996 warning due to std::reverse_copy on Microsoft platforms
https://api.github.com/repos/weidai11/cryptopp/issues/123/comments
6
2016-01-25T02:14:53Z
2023-11-23T07:49:10Z
https://github.com/weidai11/cryptopp/issues/123
128,444,740
123
[ "weidai11", "cryptopp" ]
[`crytest.sh`](https://github.com/weidai11/cryptopp/blob/master/cryptest.sh#L1487) has a couple of tests with elevated warnings. The elevated warnings include `-Wall -Wextra -Wcast-align`. Under GCC 4.9 and Clang 3.7 (and above), its producing about 500 warnings. The test is run four times under **_`{Debug,Release} x {...
Warning when using -Wcast-align with modern GCC and Clang
https://api.github.com/repos/weidai11/cryptopp/issues/122/comments
2
2016-01-24T19:32:34Z
2016-01-28T00:10:37Z
https://github.com/weidai11/cryptopp/issues/122
128,419,244
122
[ "weidai11", "cryptopp" ]
We've had some suggestions/requests to add deterministic DSA and ECDSA signatures to the library. [RFC 6769](https://tools.ietf.org/html/rfc6979) discusses the reasons for them in-depth. The abbreviated version is: - hardening - ensure **_`k`**_ is not accidentally weak - testability - repeatable results to ensure prop...
Deterministic DSA and ECDSA Signatures
https://api.github.com/repos/weidai11/cryptopp/issues/121/comments
24
2016-01-24T14:42:41Z
2018-02-21T09:03:32Z
https://github.com/weidai11/cryptopp/issues/121
128,401,146
121
[ "weidai11", "cryptopp" ]
Below is from a [LeMaker HiKey](http://www.amazon.com/dp/B019O3QTSA). The device is ARM64 with a Coretx-A53 octa-core and 1GB or RAM. ``` $ ./cryptest.sh HAVE_CXX03: 1 HAVE_CXX11: 1 HAVE_ASAN: 0 HAVE_UBSAN: 0 HAVE_VALGRIND: 1 IS_LINUX: 1 CPU: 8 logical, MEM: 949 MB Compiler: g++ (Debian/Linaro 4.9.2-10) 4.9.2 make ...
g++: internal compiler error: Killed when using -pipe with regtest.cpp
https://api.github.com/repos/weidai11/cryptopp/issues/120/comments
2
2016-01-24T00:39:54Z
2022-12-26T18:40:58Z
https://github.com/weidai11/cryptopp/issues/120
128,363,649
120
[ "weidai11", "cryptopp" ]
Here is the output of the compilation with gcc-4.9 or gcc-5 toolchains of Android NDK (official 10e and CrystaX 10.3.1): ``` [armeabi] Compile++ thumb: cryptopp_static <= integer.cpp /opt/android-ndk-r10e/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/bin/arm-linux-androideabi-g++ -MMD -MP -MF /Users/caw...
Failure on to compile for armeabi using android NDK
https://api.github.com/repos/weidai11/cryptopp/issues/119/comments
12
2016-01-22T01:40:41Z
2016-01-24T21:31:08Z
https://github.com/weidai11/cryptopp/issues/119
128,062,330
119
[ "weidai11", "cryptopp" ]
According to [the wiki](https://cryptopp.com/wiki/Release_process#Executing_the_Script), > The script takes between 3 hours to 3 days to run. which is quite a long time-span. I've had a quick look into the script (I'm not a script wizard :( ) and it looked like everything was executed linearly. Now most modern machin...
Optimizing the test script
https://api.github.com/repos/weidai11/cryptopp/issues/117/comments
13
2016-01-17T12:49:31Z
2016-01-24T02:57:12Z
https://github.com/weidai11/cryptopp/issues/117
127,093,024
117
[ "weidai11", "cryptopp" ]
There recently was [a question over at Crypto.SE about the speed of ECGDSA vs ECKCDSA vs ECDSA](http://crypto.stackexchange.com/q/31853/23623). The question showed a general lack of implementation of the former two schemes and so I though to bring it up here. I'm hereby proposing to adding support for ECGDSA (EC Germa...
Add support for EC-GDSA and EC-KCDSA
https://api.github.com/repos/weidai11/cryptopp/issues/113/comments
7
2016-01-12T19:47:00Z
2017-10-07T21:44:43Z
https://github.com/weidai11/cryptopp/issues/113
126,260,114
113
[ "weidai11", "cryptopp" ]
Most of my compressed data samples `Inflator` class decompresses just fine. But on some compressed data it throws "Inflator: unexpected end of compressed block" yet the data is valid and complete. Adding one extra byte of ANY VALUE to the end of such data makes `Inflator` to decompress it without errors. See the attac...
Inflator throws end of compressed block on complete compressed data
https://api.github.com/repos/weidai11/cryptopp/issues/112/comments
18
2016-01-12T19:03:38Z
2016-04-11T12:35:04Z
https://github.com/weidai11/cryptopp/issues/112
126,250,921
112
[ "weidai11", "cryptopp" ]
Brad from the mailing list [reports the following program causes a segmentation fault on Linux](https://groups.google.com/d/msg/cryptopp-users/5oOQ_8CW0q4/lwUeXwBwBAAJ). The issue was also confirmed on OS X. ``` #include <iostream> #include <sstream> #include <string> #include <cryptopp/base32.h> // This file is int...
Crash when trying to set alternate alphabet for Base32 decoder
https://api.github.com/repos/weidai11/cryptopp/issues/108/comments
7
2016-01-12T00:34:12Z
2018-06-15T15:48:20Z
https://github.com/weidai11/cryptopp/issues/108
126,070,490
108
[ "weidai11", "cryptopp" ]
I'm trying to use the PEM pack available on the wiki https://www.cryptopp.com/wiki/PEM_Pack but it's missing the pem-com.h file. Would it be possible to update it? I understand the PEM pack is not officially part of Crypto++ but I thought someone might have it since it's hosted on the official wiki
pem-com.h missing from PEM pack archive
https://api.github.com/repos/weidai11/cryptopp/issues/106/comments
3
2016-01-08T19:23:01Z
2017-05-01T19:57:56Z
https://github.com/weidai11/cryptopp/issues/106
125,675,831
106
[ "weidai11", "cryptopp" ]
Valgrind is reporting an uninitialized read under 32-bit ARM. The device is a BeagleBone Black running Debian 8.2. The open question at the moment is Debian's Valgrind-3.10.0 and LibVEX. The library has experienced false positives in the past that were cleared with 3.11. We need to wait until `cryptest.sh` is finishe...
Valgrind reports unintialized reads under 32-bit ARM
https://api.github.com/repos/weidai11/cryptopp/issues/105/comments
3
2016-01-08T03:03:57Z
2016-01-10T22:54:44Z
https://github.com/weidai11/cryptopp/issues/105
125,532,854
105
[ "weidai11", "cryptopp" ]
Is there a better way to send patches? I don't have a github clone of your repo. ``` index a6a2700..a39df88 100644 --- a/test.cpp +++ b/test.cpp @@ -796,8 +796,9 @@ void ForwardTcpPort(const char *sourcePortName, const char *destinationHost, con sockListen.Create(); sockListen.Bind(sourcePort); - - int e...
setsockopt EINVAL with cryptopp ft 9109 example.com 80
https://api.github.com/repos/weidai11/cryptopp/issues/104/comments
5
2016-01-07T19:41:43Z
2016-01-08T20:11:51Z
https://github.com/weidai11/cryptopp/issues/104
125,470,205
104
[ "weidai11", "cryptopp" ]
I'm facing a heap corruption if i compile the actual git Version on Windows x86 (using Visual Studio 2015 on Win10), see the minimal code example below! ``` c++ #include <iostream> #if defined(WIN32) #include <windows.h> #endif #include "cryptopp/cryptlib.h" #include "cryptopp/hex.h" #include "cryptopp/sha.h" #inclu...
Heap Corruption on Windows
https://api.github.com/repos/weidai11/cryptopp/issues/103/comments
11
2016-01-07T10:55:58Z
2016-01-11T13:06:43Z
https://github.com/weidai11/cryptopp/issues/103
125,371,316
103
[ "weidai11", "cryptopp" ]
Hello, I was having problems compiling Crypto++ with C++Builder XE6 in 64-bit (Clang compiler). Here is the message I was getting: ``` [bcc64 Error] pkcspad.h(79): call to constructor of 'HashIdentifier' (aka 'pair<const byte *, size_t>') is ambiguous ``` My first move was to cast the second parameter as **size_t**: ...
Length should be using size_t
https://api.github.com/repos/weidai11/cryptopp/issues/102/comments
2
2016-01-06T17:03:53Z
2016-01-12T04:50:53Z
https://github.com/weidai11/cryptopp/issues/102
125,218,622
102
[ "weidai11", "cryptopp" ]
Is there any reason why eccrypto.h appears to contain two copies of itself - with second copy starting from line 337? https://github.com/weidai11/cryptopp/blob/master/eccrypto.h#L338
eccrypto.h duplicated within itself?
https://api.github.com/repos/weidai11/cryptopp/issues/101/comments
3
2016-01-02T13:16:30Z
2016-01-07T15:13:11Z
https://github.com/weidai11/cryptopp/issues/101
124,590,386
101
[ "weidai11", "cryptopp" ]
[cryptest.sh](https://github.com/weidai11/cryptopp/blob/master/cryptest.sh) has one failure when running on Cygwin-x64. Its only present in the Debug/Optimize Size configuration test (-DDEBUG -Os) for the platform. Its not present in other configurations or on other platforms (including Cygwin-x86). Cygwin version is ...
Crash on Cygwin-x64 with -DDEBUG -Os
https://api.github.com/repos/weidai11/cryptopp/issues/100/comments
5
2016-01-02T07:08:06Z
2017-06-14T09:14:31Z
https://github.com/weidai11/cryptopp/issues/100
124,578,752
100
[ "weidai11", "cryptopp" ]
Hi first of all: Thanks for this great library, it helped me a lot in a current student project! However there were some compile issues with msvc2015 and CMake: - for MSVC some assembler sources must be add - also Assembler must be enabled and correct flags must be set - there was also another source winpipes.cpp mis...
MSVC2015 (win64) CMakeLists.txt issues
https://api.github.com/repos/weidai11/cryptopp/issues/99/comments
12
2016-01-01T17:44:57Z
2016-06-22T13:28:37Z
https://github.com/weidai11/cryptopp/issues/99
124,552,658
99
[ "weidai11", "cryptopp" ]
Continuous integration and testing is a topic that comes up frequently. Crypto++ testing is [believed to be thorough](http://github.com/weidai11/cryptopp/blob/master/cryptest.sh) on common platforms like Linux, OS X and Windows, but its a manual process. Tools like Travis-CI can be a helpful to automate testing, but Cr...
Continuous integration and testing
https://api.github.com/repos/weidai11/cryptopp/issues/97/comments
6
2015-12-30T19:15:31Z
2017-04-15T10:35:16Z
https://github.com/weidai11/cryptopp/issues/97
124,388,736
97
[ "weidai11", "cryptopp" ]
Hi there, I have cross-compiled cryptopp for Android using the provided makefile. However, the linker complains about a specific class, see [linker_errors.txt](https://github.com/weidai11/cryptopp/files/73329/linker_errors.txt). Other pieces of code, such as SHA256 and RandomPool link correctly. The code im trying t...
CFB_ModePolicy Android
https://api.github.com/repos/weidai11/cryptopp/issues/94/comments
7
2015-12-28T16:03:43Z
2016-01-07T15:14:45Z
https://github.com/weidai11/cryptopp/issues/94
124,085,151
94
[ "weidai11", "cryptopp" ]
We have a pretty good release process located at [Release](https://www.cryptopp.com/wiki/Release_process). However, a postmortem analysis of [Issue 92](https://github.com/weidai11/cryptopp/issues/92) revealed we don't know what code _lacks_ a test case.
Need a Code Coverage tool added to the Release Process
https://api.github.com/repos/weidai11/cryptopp/issues/93/comments
7
2015-12-28T08:40:28Z
2016-01-18T01:58:11Z
https://github.com/weidai11/cryptopp/issues/93
124,035,546
93
[ "weidai11", "cryptopp" ]
Line 569 and 589 of secblock.h contain this: ``` assert((!t.m_ptr && !t.m_size) || (t.m_ptr && t.m_ptr.m_size)); ``` `m_ptr.m_size` doesn't work, since `m_ptr` is a pointer. I believe what is meant is ``` assert((!t.m_ptr && !t.m_size) || (t.m_ptr && t.m_size)); ``` This prevents use of operators +=`and`+` in a deb...
secblock.h: Error inside assert()
https://api.github.com/repos/weidai11/cryptopp/issues/92/comments
8
2015-12-27T13:26:34Z
2015-12-28T08:41:02Z
https://github.com/weidai11/cryptopp/issues/92
123,978,435
92
[ "weidai11", "cryptopp" ]
Open discussion at [Make VS2010 default sometime in 2016?](http://groups.google.com/d/msg/cryptopp-users/vCYAEj3OI8g/BPxFrKedDgAJ) on the User Group. Here are the breaking changes for [Visual Studio 2010](https://msdn.microsoft.com/en-us/library/bb531344%28v=vs.100%29.aspx). I don't think they materially affect Crypto...
Make VS2010 default sometime in 2016
https://api.github.com/repos/weidai11/cryptopp/issues/89/comments
1
2015-12-26T08:27:25Z
2016-09-10T08:45:19Z
https://github.com/weidai11/cryptopp/issues/89
123,916,567
89
[ "weidai11", "cryptopp" ]
Post build event should be changed to `Win32\output\debug\cryptest mac_dll $(TargetDir)\cryptopp.dll echo mac done > "$(OutDir)"\cryptopp.mac.done`. The reason is that there is a mismatch between the `${TargetName}` which cryptdll and the actual output dll which is `cryptopp.dll`. Ideally the fix should be the other w...
Issues with post build event with newer msvc
https://api.github.com/repos/weidai11/cryptopp/issues/87/comments
11
2015-12-19T04:58:37Z
2015-12-30T18:01:04Z
https://github.com/weidai11/cryptopp/issues/87
123,062,702
87
[ "weidai11", "cryptopp" ]
The input lib is set to AdditionalLibraryDirectories="$(PlatformName)\DLL_Output\$(ConfigurationName) $(NOINHERIT)" however the .cryptopp.lib is output over at $(PlatformName)\Output\etc...
Incorrect paths for AdditionalLibraryDirectories in msvc for dll generation
https://api.github.com/repos/weidai11/cryptopp/issues/86/comments
9
2015-12-19T03:54:59Z
2016-01-08T14:31:04Z
https://github.com/weidai11/cryptopp/issues/86
123,059,730
86
[ "weidai11", "cryptopp" ]
Hi I am trying to install cryptoPP for cross-compilation on a beaglebone black and I am using Ubuntu for compilation. I am quite a newbie in this please help me out. I did ![image](https://cloud.githubusercontent.com/assets/15646312/11831562/4cbaf132-a3ea-11e5-81d5-eddacee42b11.png) And everything seems fine. Then I...
CryptoPP for cross-compilation on ARM-embedded
https://api.github.com/repos/weidai11/cryptopp/issues/85/comments
1
2015-12-16T03:47:03Z
2016-01-08T14:29:00Z
https://github.com/weidai11/cryptopp/issues/85
122,421,682
85
[ "weidai11", "cryptopp" ]
When I compress a plain [atom.txt](https://github.com/weidai11/cryptopp/files/61198/atom.txt) text buffer, I get an assert from zdeflate in MatchFound, line assert(length >= 3 && length < COUNTOF(lengthCodes)); Code snippet that I am using to compress...... ``` CryptoPP::Gzip zipper; //is - is an ifstream p...
zdeflate error
https://api.github.com/repos/weidai11/cryptopp/issues/83/comments
10
2015-12-14T13:09:17Z
2016-09-10T23:57:01Z
https://github.com/weidai11/cryptopp/issues/83
122,039,038
83
[ "weidai11", "cryptopp" ]
Distro maintainers currently have it rough. They install `cryptest.exe` into `/usr/bin`, `TestVectors` and `TestData` into `/usr/share`, and everything breaks because the library presumes a location relative to `cryptest.exe`. We have a [DataDir](https://www.cryptopp.com/wiki/DataDir) patch, but its a bit complicated....
Add Debian-style Data Directory patch
https://api.github.com/repos/weidai11/cryptopp/issues/82/comments
3
2015-12-12T06:19:09Z
2015-12-26T04:52:10Z
https://github.com/weidai11/cryptopp/issues/82
121,836,600
82
[ "weidai11", "cryptopp" ]
When compiling dynamic version of crypto++ library, it uses `install_name` parameter equal to `libcryptopp.dylib`. Effectively, if the library is installed, the programs will be able to compile against it, but the at the runtime the library will not be found. I believe, the default should be `$PREFIX/lib/libcryptopp....
[OSX] Incorrect install_name for dynamic library
https://api.github.com/repos/weidai11/cryptopp/issues/80/comments
13
2015-12-12T01:55:36Z
2015-12-25T17:12:27Z
https://github.com/weidai11/cryptopp/issues/80
121,825,208
80
[ "weidai11", "cryptopp" ]
in function inline void memcpy_s of misc.h, the line ``` assert(dest != NULL); assert(src != NULL); ``` causes that a program that compiles, and assigns both dest and src, still fails. This may be platform specific, but on my g++ 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04), I get the following runtime error: ``` sample: mis...
failiure of assert(dest != NULL); assert(src != NULL);
https://api.github.com/repos/weidai11/cryptopp/issues/79/comments
6
2015-12-09T13:16:55Z
2015-12-12T02:02:33Z
https://github.com/weidai11/cryptopp/issues/79
121,236,105
79
[ "weidai11", "cryptopp" ]
Any link of official tutorial would be great. Or any other link if you already don't have one. I found out this http://www.cryptopp.com/wiki/Compiling but it didn't help me. Any help would be great thank you.
How do I install Crypto++ in Visual Studio 2013 Windows 8?
https://api.github.com/repos/weidai11/cryptopp/issues/78/comments
2
2015-12-09T13:02:15Z
2015-12-16T03:54:57Z
https://github.com/weidai11/cryptopp/issues/78
121,232,665
78
[ "weidai11", "cryptopp" ]
We have some scripts that help with cross-compiling Crypto++ for Android, iOS and ARM Embedded. There are wiki pages on it, but using them requires folks to download the script from the wiki. <strike>In addition, the Android script has incomplete `CXXFLAGS` when compared to what the Android NDK provides. We need to ro...
Add setenv scripts for Makefile based cross-compiles
https://api.github.com/repos/weidai11/cryptopp/issues/76/comments
1
2015-12-07T19:07:29Z
2016-03-09T19:59:40Z
https://github.com/weidai11/cryptopp/issues/76
120,844,422
76
[ "weidai11", "cryptopp" ]
- New virtual machine (android-ndk in home dir) - Pulled the sources directly from git - got the setenv-android.sh from the wiki - Building like ``` AOSP_API="android-8" . ./setenv-android.sh make -f GNUmakefile-cross static dynamic cryptest.exe ``` It looks like the setenv.sh sets everything right, cause the used co...
Build for Android: #include <string>
https://api.github.com/repos/weidai11/cryptopp/issues/74/comments
5
2015-12-07T16:02:37Z
2016-01-08T14:28:26Z
https://github.com/weidai11/cryptopp/issues/74
120,805,448
74
[ "weidai11", "cryptopp" ]
Well, the idea is to move away from traditional Makefile to a Makefile generator. CMake is the most robust, stable and reliable cross-platform build system. Advantages: - Much, MUCH easier to maintain: Now we have to mantain Visual Studio project, Borlang C++ Builder project, GNUmakefile, GNUmakefile-cross, and (bon...
Provide CMake build system
https://api.github.com/repos/weidai11/cryptopp/issues/73/comments
4
2015-12-07T14:00:06Z
2016-02-10T23:36:00Z
https://github.com/weidai11/cryptopp/issues/73
120,779,554
73
[ "weidai11", "cryptopp" ]
Please take note of this source code compiling error: Platform: ``` OSX 10.10 ``` Clang compiler: ``` Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) Target: x86_64-apple-darwin14.4.0 Thread model: posix ``` Command: ``` /usr/bin/clang++ -arch i386 -DCRYPTOPP_DISABLE_ASM cpu.cpp ``` Error: `...
clang compilation error on cpu.cpp
https://api.github.com/repos/weidai11/cryptopp/issues/72/comments
5
2015-11-30T11:07:00Z
2016-01-26T08:35:49Z
https://github.com/weidai11/cryptopp/issues/72
119,470,183
72
[ "weidai11", "cryptopp" ]
Todd Knarr has offered a patch for SONAME under Linux. The patch embeds the SONAME in the shared object, names the output artifact according to Linux standards, and symlinks to to the long shared object name. We want to pick this up in about 30 days, distributions have time to uptake 5.6.3.
Pick-up SONAME merge requests
https://api.github.com/repos/weidai11/cryptopp/issues/71/comments
6
2015-11-24T17:51:52Z
2016-01-07T15:19:44Z
https://github.com/weidai11/cryptopp/issues/71
118,667,558
71
[ "weidai11", "cryptopp" ]
Crypto++ 5.6.3 cleared a number of issues uncovered by analysis and testing tools. To maintain compatibility with Crypto++ 5.6.2, `MAINTAIN_BACKWARDS_COMPATIBILITY_562` was introduced. It allowed us to clear _most_ of the findings while maintaining compatibility. If `MAINTAIN_BACKWARDS_COMPATIBILITY_562` was not define...
Remove MAINTAIN_BACKWARDS_COMPATIBILITY_562
https://api.github.com/repos/weidai11/cryptopp/issues/70/comments
7
2015-11-24T16:19:35Z
2016-12-03T05:46:56Z
https://github.com/weidai11/cryptopp/issues/70
118,645,328
70
[ "weidai11", "cryptopp" ]
Uri uncovered some of the cryptosystem or algorithms don't perform key generation in their self test routines (both with `cryptest.exe v` and `cryptest.exe tv`). Where applicable, the self tests _do_ perform (1) known answer tests and (2) pairwise consistency checks to ensure proper operation, but the keys were generat...
Need a set of tests which perform key generation
https://api.github.com/repos/weidai11/cryptopp/issues/69/comments
1
2015-11-22T12:23:02Z
2016-03-11T07:02:40Z
https://github.com/weidai11/cryptopp/issues/69
118,260,299
69
[ "weidai11", "cryptopp" ]
We noticed problems with CryptoPP when testing our eIDClientCore software (which uses CryptoPP as a shared library). We created a minimal example, which could reproduce the problem on our systems. Makefile: ``` PREFIX ?=$(shell pwd) CRYPTOPP ?= cryptopp all: cryptopp test_rand run cryptopp: git clone https://gi...
AutoSeededRandomPool::GenerateBlock causes Segmentation Fault/Freeze
https://api.github.com/repos/weidai11/cryptopp/issues/68/comments
7
2015-11-19T15:48:25Z
2015-11-26T20:57:18Z
https://github.com/weidai11/cryptopp/issues/68
117,842,286
68
[ "weidai11", "cryptopp" ]
The following page gives a list of safe curves to use with ECC: http://safecurves.cr.yp.to/ As far as I can see, Crypto++ doesn't currently implement any of the safe curves listed on that page (e.g. Curve25519), and a lot of the curves that are implemented have known issues (e.g. secp256k1). I'm no expert, but would...
No safe curves are currently supported
https://api.github.com/repos/weidai11/cryptopp/issues/67/comments
52
2015-11-18T12:48:02Z
2018-12-25T10:46:45Z
https://github.com/weidai11/cryptopp/issues/67
117,579,654
67
[ "weidai11", "cryptopp" ]
Crypto++ has gone through Coverity scans for Debug (x64), Release (x64), Release (No-ASM), Debug (x86), Release (x86). The following are the remaining items that need to be fixed or explained: - CID 147829 - Bad Shift amount in gf2n.cpp. [JPM thinks its a false positive](https://groups.google.com/d/msg/cryptopp-users/c...
Rollup of Coverity items to be fixed before release
https://api.github.com/repos/weidai11/cryptopp/issues/66/comments
1
2015-11-16T22:21:34Z
2015-11-18T20:20:41Z
https://github.com/weidai11/cryptopp/issues/66
117,232,132
66
[ "weidai11", "cryptopp" ]
When using PolynomialMod2 shift left operator, the most significant word is lost when shifting by more than WORD_BITS bits. In "gf2n.c" the line 349 states: ``` reg[reg.size()-1] = carry; ``` it should be: ``` reg[reg.size()-shiftWords-1] = carry; ```
PolynomialMod2::operator<<= Bug
https://api.github.com/repos/weidai11/cryptopp/issues/64/comments
3
2015-11-06T23:38:20Z
2015-11-16T22:12:00Z
https://github.com/weidai11/cryptopp/issues/64
115,612,754
64
[ "weidai11", "cryptopp" ]
https://github.com/weidai11/cryptopp/blob/48809d4e85c125814425c621d8d0d89f95405924/winpipes.h#L60 They inherit `virtual HANDLE GetHandle() const =0;` from `WindowsPipe`. It is then called in `WindowsPipeReceiver::Receive()`, `WindowsPipeReceiver::GetReceiveResult()`, `WindowsPipeSender::Send` and `WindowsPipeSender::...
WindowsPipeReceiver/Sender inherit a pure virtual function but do not override it
https://api.github.com/repos/weidai11/cryptopp/issues/62/comments
6
2015-11-06T14:57:39Z
2016-01-08T14:34:00Z
https://github.com/weidai11/cryptopp/issues/62
115,520,162
62
[ "weidai11", "cryptopp" ]
László Böszörményi of Debian reports a hang near _"BlumBlumShub validation suite running..."_ when testing under Debian QEMU Chroot for ARM64. The hang is present under GCC 5.1, but is _not_ present under Clang on the same machine. --- The issue is present with both `-std=c++03`, `-std=c++11`. Following [GCC miscompi...
Hang on Debian ARM64 QEMU Chroot
https://api.github.com/repos/weidai11/cryptopp/issues/61/comments
1
2015-11-06T12:54:37Z
2016-01-08T13:57:17Z
https://github.com/weidai11/cryptopp/issues/61
115,499,740
61
[ "weidai11", "cryptopp" ]
- Version: 5.6.3 RC6 - Error message: ``` g++ -DNDEBUG -g2 -O2 -fPIC -march=native -pipe -c rdrand.cpp rdrand.cpp:1:0: warning: -fPIC ignored for target (all code is position independent) // rdrand.cpp - written and placed in public domain by Jeffrey Walton and Uri Blumenthal. ^ rdrand.cpp:435:5: error: #error "Plea...
rdrand.cpp causes the library to fail to compile when using MinGW-w64
https://api.github.com/repos/weidai11/cryptopp/issues/60/comments
12
2015-11-06T11:17:26Z
2016-01-07T15:21:35Z
https://github.com/weidai11/cryptopp/issues/60
115,486,173
60
[ "weidai11", "cryptopp" ]
Cross-compiling produced many errors today on OpenSUSE 13.1 and Travis CI (Ubuntu 12.40). We used to follow the procedure described in http://www.cryptopp.com/wiki/Android_%28Command_Line%29 . That means, we downloaded the patched files and then built cryptopp for android. This still worked 7 days ago. With the new co...
Cross-compiling for android does not work anymore on OpenSUSE and Travis CI
https://api.github.com/repos/weidai11/cryptopp/issues/59/comments
5
2015-11-05T14:29:44Z
2016-01-08T14:30:36Z
https://github.com/weidai11/cryptopp/issues/59
115,295,158
59
[ "weidai11", "cryptopp" ]
These are the issues we are aware that should be fixed prior to 5.6.3 release. They were reported after RC6 (give or take...). We are tracking them under a single bug report. - Guard `CRYPTOPP_CXX11_ALIGNOF` on MSC `1900` - `cryptest.exe tv all` does not run HKDF tests. Need to add `hkdf.txt` to `all.txt`. - _"... to t...
Rollup of errata items to be fixed before release
https://api.github.com/repos/weidai11/cryptopp/issues/58/comments
6
2015-11-05T11:21:49Z
2015-11-18T20:21:46Z
https://github.com/weidai11/cryptopp/issues/58
115,263,888
58
[ "weidai11", "cryptopp" ]
``` make ... g++ -DNDEBUG -std=c++03 -g3 -O1 -march=native -pipe -c nbtheory.cpp In file included from nbtheory.cpp:14:0: c:\mingw\include\math.h: In function 'float hypotf(float, float)': c:\mingw\include\math.h:635:30: error: '_hypot' was not declared in this scope { return (float)(_hypot (x, y)); } ...
MinGW cannot compile the library due to missing symbol MinGW _hypot
https://api.github.com/repos/weidai11/cryptopp/issues/57/comments
2
2015-11-02T00:32:21Z
2015-11-04T03:43:10Z
https://github.com/weidai11/cryptopp/issues/57
114,504,363
57
[ "weidai11", "cryptopp" ]
Maximilian Zamorsky reports `WaitObjectsTracer` causes dirty compile under VS2015: ``` 1> network.cpp 1>...\cryptopp\wait.h(141): error C2220: warning treated as error - no 'object' file generated 1>...\cryptopp\wait.h(141): warning C4589: Constructor of abstract class 'WaitObjectsTracer' ignores initializer for virt...
WaitObjectsTracer causes dirty compile under VS2015
https://api.github.com/repos/weidai11/cryptopp/issues/56/comments
8
2015-11-01T14:15:39Z
2016-07-04T12:54:44Z
https://github.com/weidai11/cryptopp/issues/56
114,471,620
56
[ "weidai11", "cryptopp" ]
`test.cpp` and `bench.cpp` include [`#define _CRT_SECURE_NO_DEPRECATE`](http://msdn.microsoft.com/en-us/library/8ef0s5kh.aspx). From [Security Features in the CRT](https://msdn.microsoft.com/en-us/library/8ef0s5kh.aspx): > There are several ways to eliminate deprecation warnings for the older, less secure functions. T...
_CRT_SECURE_NO_DEPRECATE is used under Windows
https://api.github.com/repos/weidai11/cryptopp/issues/55/comments
1
2015-11-01T00:01:09Z
2016-01-08T14:31:28Z
https://github.com/weidai11/cryptopp/issues/55
114,441,365
55
[ "weidai11", "cryptopp" ]
**_Background**_ Crypto++ 5.6.3 and above use GCC's [`init_priority`](http://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Attributes.html) in an effort to tame the [C++ Static Initialization Order Fiasco](http://cryptopp.com/wiki/Static_Initialization_Order_Fiasco). Its an optional feature that is disabled by default under ...
Need a strategy for dealing with OS X ported compilers
https://api.github.com/repos/weidai11/cryptopp/issues/54/comments
2
2015-10-31T12:10:54Z
2015-11-18T21:31:39Z
https://github.com/weidai11/cryptopp/issues/54
114,406,478
54
[ "weidai11", "cryptopp" ]
Here are some test results from Debian Unstable (x64) with GCC 4.9. The messages below are from the log file called `cryptest-result.sh`, which is created by the test script located at [Release Testing](https://cryptopp.com/wiki/Release_Testing). Though not readily apparent, they are produced by the following configur...
Compile Failure under Debian Unstable (x64), GCC 4.9, -std=c++11
https://api.github.com/repos/weidai11/cryptopp/issues/53/comments
2
2015-10-31T08:51:37Z
2016-01-04T08:30:21Z
https://github.com/weidai11/cryptopp/issues/53
114,398,710
53
[ "weidai11", "cryptopp" ]
This is a Microsoft SDLC finding, and we need to switch to `wcstombs_s` for C&A purposes. In addition, we need some test cases for the conversion.
StringNarrow uses wcstombs on Microsoft platforms
https://api.github.com/repos/weidai11/cryptopp/issues/52/comments
1
2015-10-31T03:45:37Z
2016-01-08T14:31:50Z
https://github.com/weidai11/cryptopp/issues/52
114,384,932
52
[ "weidai11", "cryptopp" ]
Reference [FIPS 186-3 Change Notice (2-28-12)](http://csrc.nist.gov/groups/ST/toolkit/documents/FIPS186-3_ChangeNotice041012.pdf). From 5, _Processing Step Error in the Secret Number Generation for ECDSA_: > In Appendices B.5.1 and B.5.2, processing step 1 (i.e., N = len(q)) is incorrect. This change notice specifies ...
Verify conformance with FIPS 186-4, Change Notice, Item 5
https://api.github.com/repos/weidai11/cryptopp/issues/51/comments
2
2015-10-30T21:54:19Z
2015-10-31T14:08:59Z
https://github.com/weidai11/cryptopp/issues/51
114,362,523
51
[ "weidai11", "cryptopp" ]
``` $ make dll.o dsa.o g++ ... -DCRYPTOPP_MAINTAIN_BACKWARDS_COMPATIBILITY ... -c dll.cpp In file included from dll.h:18:0, from dll.cpp:6: dsa.h: In function ‘bool CryptoPP::GenerateDSAPrimes(const byte*, size_t, int&, CryptoPP::Integer&, unsigned int, CryptoPP::Integer&)’: dsa.h:30:10: error: ‘Genera...
GeneratePrimes is not a member of CryptoPP::DSA with CRYPTOPP_MAINTAIN_BACKWARDS_COMPATIBILITY
https://api.github.com/repos/weidai11/cryptopp/issues/50/comments
1
2015-10-29T15:52:00Z
2015-10-31T13:28:40Z
https://github.com/weidai11/cryptopp/issues/50
114,080,772
50
[ "weidai11", "cryptopp" ]
When running [`cryptest.sh`](http://cryptopp.com/wiki/Release_Testing#Test_Script) under Cygwin-i686 and the sanitizers, the `cryptest.exe` program fails to build: ``` ... g++ -DDEBUG -g2 -O2 -std=c++03 -fsanitize=address -march=native -pipe -c fipsalgt.cpp g++ -DDEBUG -g2 -O2 -std=c++03 -fsanitize=address -march=n...
Cryptest.exe fails to build under Cygwin-i686 with sanitizer flags
https://api.github.com/repos/weidai11/cryptopp/issues/49/comments
1
2015-10-27T18:36:43Z
2016-01-04T08:58:41Z
https://github.com/weidai11/cryptopp/issues/49
113,652,701
49
[ "weidai11", "cryptopp" ]
Opened to tend to all issues related to dirty compiles due to use of `auto_ptr` and C++011. It includes [Issue 17](https://github.com/weidai11/cryptopp/issues/17). Bug 17 cleared the issue under Cygwin by using a lot of define magic to determine when C++ 11 was **_really**_ available, and then switched to a `unique_pt...
Use of auto_ptr causes dirty compile under C++11
https://api.github.com/repos/weidai11/cryptopp/issues/48/comments
3
2015-10-27T02:00:32Z
2015-11-01T02:09:22Z
https://github.com/weidai11/cryptopp/issues/48
113,489,097
48
[ "weidai11", "cryptopp" ]
László Böszörményi of Debian reports a hang in SHA self tests when testing under Debian Sid (Unstable) with GCC 5.2 and older hardware. The older hardware includes a Core2 Duo and AMD Athlon.
Hang in SHA with Debian Sid, GCC 5.2 and Core2 Duo hardware
https://api.github.com/repos/weidai11/cryptopp/issues/47/comments
1
2015-10-26T17:21:38Z
2016-01-04T08:56:58Z
https://github.com/weidai11/cryptopp/issues/47
113,406,357
47
[ "weidai11", "cryptopp" ]
GCC offers `-fdevirtualize` option, which appears to be similar to Microsoft's `__declspec(novtable)`. See [Options That Control Optimization](http://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html)
Attempt to support GCC's -fdevirtualize
https://api.github.com/repos/weidai11/cryptopp/issues/45/comments
6
2015-10-25T08:00:41Z
2016-01-04T08:57:25Z
https://github.com/weidai11/cryptopp/issues/45
113,212,350
45
[ "weidai11", "cryptopp" ]
Here's the full message: ``` ==6985== Conditional jump or move depends on uninitialised value(s) ==6985== at 0x557A328: CryptoPP::DetectX86Features() (in /usr/lib/libcryptopp.so) ==6985== by 0x55613F0: CryptoPP::Rijndael::Base::UncheckedSetKey(unsigned char const*, unsigned int, CryptoPP::NameValuePairs const&) ...
Valgrind: "Conditional jump or move depends on uninitialised value(s)"
https://api.github.com/repos/weidai11/cryptopp/issues/44/comments
14
2015-10-24T21:39:19Z
2017-01-28T15:32:21Z
https://github.com/weidai11/cryptopp/issues/44
113,184,715
44
[ "weidai11", "cryptopp" ]
The system is Windows XP 64-bit and Visual Studio 2005. The issue is **_not**_ present with Windows 8 64-bit and Visual Studio 2010 and 2012. With `CRYPTOPP_ALLOW_UNALIGNED_DATA_ACCESS` undefined (i.e., aligned data access), a Visual Studio build for X86 using an `AutoSeededRandomPool` results in a crash. `TestAutoSee...
Crash in AutoSeededRandomPool under Windows XP, VS2005, Aligned Data Access
https://api.github.com/repos/weidai11/cryptopp/issues/43/comments
0
2015-10-23T07:11:15Z
2015-10-31T14:01:00Z
https://github.com/weidai11/cryptopp/issues/43
112,966,041
43
[ "weidai11", "cryptopp" ]
With `CRYPTOPP_ALLOW_UNALIGNED_DATA_ACCESS` undefined (i.e., aligned data access), a Visual Studio build for X64 results in: ``` ------ Build started: Project: cryptest, Configuration: Debug x64 ------ Linking... cryptlib.lib(x64dll.obj) : error LNK2001: unresolved external symbol "unsigned __int64 CryptoPP::rdtable::...
Undefined symbol `rdtable::Te` under Visual Studio, X64, Aligned Data Access
https://api.github.com/repos/weidai11/cryptopp/issues/42/comments
4
2015-10-23T05:56:46Z
2017-05-22T01:53:36Z
https://github.com/weidai11/cryptopp/issues/42
112,958,289
42
[ "weidai11", "cryptopp" ]
Here are the symptoms: ``` $ make g++ -DNDEBUG -g2 -O3 -march=native -DCRYPTOPP_NO_UNALIGNED_DATA_ACCESS -pipe -c cryptlib.cpp g++ -DNDEBUG -g2 -O3 -march=native -DCRYPTOPP_NO_UNALIGNED_DATA_ACCESS -pipe -c shacal2.cpp ... $ ./cryptest.exe v ... MQV validation suite running... passed authenticated key agreement ...
Crash in DL_GroupParameters_IntegerBased::GetEncodedElementSize for Cygwin i386 at -O3
https://api.github.com/repos/weidai11/cryptopp/issues/40/comments
1
2015-10-10T16:47:27Z
2016-01-07T15:21:58Z
https://github.com/weidai11/cryptopp/issues/40
110,804,776
40
[ "weidai11", "cryptopp" ]
László Böszörményi of Debian reports the following issue when testing under Debian Unstable. ``` passed: sizeof(hword) == 4, sizeof(word) == 8, sizeof(dword) == 16 FAILED: hasMMX == 1, hasISSE == 1, hasSSE2 == 1, hasSSSE3 == 0, hasAESNI == 0, hasCLMUL == 0, isP4 == 0, cacheLineSize == 808, AESNI_INTRINSICS == 1 Some...
Feature detection issue in Debian Unstable
https://api.github.com/repos/weidai11/cryptopp/issues/39/comments
2
2015-10-09T18:45:25Z
2016-01-07T15:28:43Z
https://github.com/weidai11/cryptopp/issues/39
110,715,718
39
[ "weidai11", "cryptopp" ]
Testing of `RandomNumberGenerator::GenerateWord32` revealed a potential bug in `GenerateBlock`. `GenerateBlock` calls `GenerateIntoBufferedTransformation`. `GenerateIntoBufferedTransformation`, in turn, calls, `GenerateBlock`. Ad infinitum. In the past, a patch to call `OS_GenerateRandom` was declined; see [Patch for ...
Crash in RandomNumberGenerator::GenerateWord32 due to stack recursion
https://api.github.com/repos/weidai11/cryptopp/issues/38/comments
6
2015-10-06T19:49:26Z
2015-10-31T14:08:17Z
https://github.com/weidai11/cryptopp/issues/38
110,085,954
38
[ "weidai11", "cryptopp" ]
``` $ . ./setenv-ios.sh $ make -f GNUmakefile-cross clang++ -DNDEBUG -g2 -Os -mios-version-min=5.1 -DCRYPTOPP_NO_UNALIGNED_DATA_ACCESS -DCRYPTOPP_DISABLE_ASM -arch armv7 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS7.1.sdk -stdlib=libc++ -c cryptlib.cpp ... J...
Crash in SHA under iOS 5.1.1
https://api.github.com/repos/weidai11/cryptopp/issues/37/comments
4
2015-10-03T18:19:42Z
2016-01-04T08:56:24Z
https://github.com/weidai11/cryptopp/issues/37
109,637,031
37
[ "weidai11", "cryptopp" ]
See [How to change the include file path with autotools?](http://stackoverflow.com/q/32805772) We invited the Debian, Fedora and Macport maintainers to comment and provide general advice.
Crypto++ should provide a pkg-config for users and distros
https://api.github.com/repos/weidai11/cryptopp/issues/36/comments
1
2015-10-03T07:35:31Z
2018-04-25T05:08:14Z
https://github.com/weidai11/cryptopp/issues/36
109,607,805
36
[ "weidai11", "cryptopp" ]
Hi, there is an assert in an app I try to build when encrypting the user data. The affected function is here: https://github.com/ola-ct/Qt-SESAM/blob/master/libSESAM/crypter.cpp#L139 The code runs in an assert here: https://github.com/weidai11/cryptopp/blob/master/secblock.h#L161 This is the stacktrace: ``` #0 0x0...
Assert in class NullAllocator, function deallocate
https://api.github.com/repos/weidai11/cryptopp/issues/34/comments
7
2015-09-23T19:07:18Z
2016-01-07T15:30:29Z
https://github.com/weidai11/cryptopp/issues/34
107,986,036
34
[ "weidai11", "cryptopp" ]
László Böszörményi of Debian helped with some cross validation testing. Building the library under a S/390/chroot on Debian x86_64 results in a configuration failure. There were actually two failures - one was reported, the other was silent. --- The first reported failure was a failure to detect the big endian platfo...
Configuration failure under S/390{x}
https://api.github.com/repos/weidai11/cryptopp/issues/33/comments
0
2015-09-21T07:41:57Z
2015-10-31T13:32:38Z
https://github.com/weidai11/cryptopp/issues/33
107,459,586
33
[ "weidai11", "cryptopp" ]
László Böszörményi of Debian helped with some cross validation testing. Building the library under a X32/chroot on Debian x86_64 results in a number of compile failures. Classes and source files with issues include CPU, Integer, Rijndael, SHA, Panama, Tiger, Sosemanuk, VMAC, Whirlpool and GCM. Here's the 3-second tou...
Compile failures under X32 (32-bit integers, longs, pointers on x86_64)
https://api.github.com/repos/weidai11/cryptopp/issues/32/comments
2
2015-09-18T09:34:31Z
2015-10-31T13:33:21Z
https://github.com/weidai11/cryptopp/issues/32
107,167,863
32
[ "weidai11", "cryptopp" ]
László Böszörményi of Debian helped with some cross validation testing. Building the library under a ARMEL/chroot on Debian x86_64 produces the following results: ``` BlumBlumShub validation suite running... passed 49ea2cfdb01064a0bbb92af101dac18a94f7b7ce FAILED 53171c6887956cea5d3b cryptest.exe: integer.cpp:22...
BlumBlumShub validation fails under ARMEL (likely others)
https://api.github.com/repos/weidai11/cryptopp/issues/31/comments
5
2015-09-10T15:42:51Z
2016-09-20T16:58:24Z
https://github.com/weidai11/cryptopp/issues/31
105,836,994
31
[ "weidai11", "cryptopp" ]
There are many compile warnings when enabling '-Wabi' . It will complain about 'contains empty classes which may cause base classes to be placed at different locations in a future version of GCC' ``` $ g++ -DNDEBUG -g2 -O3 -Wabi -fPIC -march=native -Wall -Wextra -Wno-type-limits -Wno-unknown-pragmas -pipe -c ecp.cpp ...
There are many compile warnings on GCC with '-Wabi'
https://api.github.com/repos/weidai11/cryptopp/issues/30/comments
3
2015-08-27T07:12:40Z
2016-01-26T07:32:30Z
https://github.com/weidai11/cryptopp/issues/30
103,443,734
30
[ "weidai11", "cryptopp" ]
Assertion failed: m_allocated cryptopp\secblock.h, line 197 ``` The issue appears to be some problem with the alignment of the 60 byte array that is allocated. It’s intended to be 8 byte aligned with 8 extra bytes added on to the end. The address used for the array is the next 16 byte aligned address, which is guarant...
Memory allocation not properly aligned on Windows platforms.
https://api.github.com/repos/weidai11/cryptopp/issues/29/comments
18
2015-08-12T20:56:00Z
2019-06-03T23:59:32Z
https://github.com/weidai11/cryptopp/issues/29
100,633,323
29
[ "weidai11", "cryptopp" ]
``` g++ -DNDEBUG -g2 -O3 -march=native -Wall -Wextra -Wno-type-limits -Wno-unknown-pragmas -pipe -c validat0.cpp validat0.cpp: In function 'bool TestSettings()': validat0.cpp:27:47: error: call of overloaded 'memcpy_s(CryptoPP::word32*, long long unsigned int, const char [5], int)' is ambiguous memcpy_s(&w, sizeof(w)...
Building cryptest.exe fails on MinGW-w64
https://api.github.com/repos/weidai11/cryptopp/issues/28/comments
70
2015-08-06T08:01:36Z
2016-10-10T11:08:15Z
https://github.com/weidai11/cryptopp/issues/28
99,381,227
28
[ "weidai11", "cryptopp" ]
This code causes a segmentation fault: ``` unsigned int result; GenerateBlock((byte*)&result, sizeof(unsigned int)); ``` Here is the call stack (image, as I cannot copy text from Code::Blocks call stack window): ![Call stack](https://lh3.googleusercontent.com/-c7nVZKuOvKM/Vbsfhu25CGI/AAAAAAAAA0M/5FpsWjZzEqQ/s1600/201...
A problem with random generator on MinGW
https://api.github.com/repos/weidai11/cryptopp/issues/27/comments
2
2015-08-06T07:44:03Z
2015-12-26T02:00:16Z
https://github.com/weidai11/cryptopp/issues/27
99,378,014
27
[ "weidai11", "cryptopp" ]
On MinGW-32, the **cryptest.exe v** with _CRYPTOPP_NO_UNALIGNED_ACCESS_ defined crashes with SIGSEGV: ``` Using seed: 1438287574 Testing Settings... passed: Your machine is little endian. passed: CRYPTOPP_ALLOW_UNALIGNED_DATA_ACCESS is not defined. Will restrict to a ligned data access. passed: sizeof(byte) == 1...
Tests fail on MinGW-32
https://api.github.com/repos/weidai11/cryptopp/issues/26/comments
3
2015-08-06T07:40:27Z
2016-01-04T08:35:08Z
https://github.com/weidai11/cryptopp/issues/26
99,377,355
26
[ "weidai11", "cryptopp" ]
``` g++ -shared -o libcryptopp.so -DNDEBUG -g2 -O3 -march=native -Wall -Wextra -Wno-type-limits -Wno-unknown-pragmas -pipe 3way.o adler32.o algebra.o algparam.o arc4.o asn.o authenc.o base32.o base64.o basecode.o bfinit.o blowfish.o blumshub.o camellia.o cast.o casts.o cbcmac.o ccm.o channels.o cmac.o cpu.o crc.o crypt...
'dynamic' target fails on MinGW x32 and x64
https://api.github.com/repos/weidai11/cryptopp/issues/25/comments
4
2015-08-06T07:29:08Z
2015-10-31T13:39:48Z
https://github.com/weidai11/cryptopp/issues/25
99,375,522
25
[ "weidai11", "cryptopp" ]
Here are the warnings that are displayed on Linux during compilation with CRYPTOPP_NO_UNALIGNED_ACCESS defined: --- ``` g++ -DNDEBUG -g2 -O3 -fPIC -march=native -DCRYPTOPP_DISABLE_ASM -Wall -Wextra -Wno-type-limits -Wno-unknown-pragmas -pipe -c cpu.cpp cpu.cpp: In function ‘bool CryptoPP::CpuId(CryptoPP::word32, Cryp...
Compiler warnings on GCC and MinGW
https://api.github.com/repos/weidai11/cryptopp/issues/24/comments
18
2015-08-06T07:22:36Z
2016-01-04T08:35:29Z
https://github.com/weidai11/cryptopp/issues/24
99,374,548
24
[ "weidai11", "cryptopp" ]
This apples to the library in general, and the intersection of assemblers and compilers. It was recently brought to light with Clang testing. Clang has an integrated assembler that's not quite as mature as it needs to be. There are 5 or 6 LLVM bugs that affect Crypto++ (cf., 18916, 24200, 24226, 24232 and a few others...
Zeroizer may be removed if assembler is not available
https://api.github.com/repos/weidai11/cryptopp/issues/23/comments
1
2015-08-03T02:56:46Z
2015-10-31T14:12:05Z
https://github.com/weidai11/cryptopp/issues/23
98,661,276
23
[ "weidai11", "cryptopp" ]
`counted_ptr` should use atomics, if available; see http://en.cppreference.com/w/cpp/atomic. ``` template <class T> counted_ptr<T>::counted_ptr(const counted_ptr<T>& rhs) : m_p(rhs.m_p) { if (m_p) m_p->m_referenceCount++; } template <class T> counted_ptr<T>::~counted_ptr() { if (m_p && --m_p->m_re...
counted_ptr should use atomics, if available
https://api.github.com/repos/weidai11/cryptopp/issues/22/comments
1
2015-08-02T12:57:11Z
2016-01-26T07:33:31Z
https://github.com/weidai11/cryptopp/issues/22
98,607,872
22
[ "weidai11", "cryptopp" ]
This issue was originally investigated and reported by Jesse Wilson and Daniele Perito at [Problem with the way gfpcrypt HMAC's the encoding parameters' length in DHAES_MODE](https://groups.google.com/forum/#!msg/cryptopp-users/vR8GSL8wxPA/Bf9koUDyZ88J). Since that time, David Hook of the Bouncy Castle project investig...
ECIES uses byte count, and not bit count, for label size
https://api.github.com/repos/weidai11/cryptopp/issues/21/comments
18
2015-07-30T06:50:23Z
2016-10-18T21:08:23Z
https://github.com/weidai11/cryptopp/issues/21
98,098,452
21
[ "weidai11", "cryptopp" ]
`FileSink::Put2` (from files.cpp) uses the following. If `length` > `std::streamsize`, then only one iteration is performed and the user must retry manually. ``` size_t FileSink::Put2(const byte *inString, size_t length, int messageEnd, bool blocking) { if (!m_stream) throw Err("FileSink: output stream not...
Should FileSInk::Put2 use streamsize blocks?
https://api.github.com/repos/weidai11/cryptopp/issues/20/comments
11
2015-07-30T06:32:17Z
2015-10-31T13:25:48Z
https://github.com/weidai11/cryptopp/issues/20
98,096,358
20
[ "weidai11", "cryptopp" ]
To help facilitate the release of Crypto++ 5.6.3, <strike>`_WINSOCK_DEPRECATED_NO_WARNINGS` was defined before including Winsock gear to avoid the warnings and the rewrite.</strike> `pragmas` were used to disable warning C4996 before including the affected header; and then the warning was re-enabled. See https://gith...
socketft defines _WINSOCK_DEPRECATED_NO_WARNINGS
https://api.github.com/repos/weidai11/cryptopp/issues/19/comments
1
2015-07-27T21:53:11Z
2016-10-10T09:08:09Z
https://github.com/weidai11/cryptopp/issues/19
97,562,322
19
[ "weidai11", "cryptopp" ]
Add missing git tags for a few of the latest releases: - 5.4 - 5.5.2 - 5.6.0 - 5.6.1 - 5.6.2 Adding 5.6.2 tag: ``` git checkout 789f81f048c9bc472c7e7596f49b02eadd6fc1fd git tag -a v5.6.2 -m 'version 5.6.2' ```
Missing Git tags
https://api.github.com/repos/weidai11/cryptopp/issues/18/comments
1
2015-07-27T15:53:27Z
2016-01-04T08:35:47Z
https://github.com/weidai11/cryptopp/issues/18
97,495,028
18
[ "weidai11", "cryptopp" ]
``` cryptlib.cpp: In member function ‘virtual size_t CryptoPP::PK_Signer::SignMessage(CryptoPP::RandomNumberGenerator&, const byte*, size_t, byte*) const’: cryptlib.cpp:770:41: warning: ‘auto_ptr’ is deprecated (declared at /usr/lib/gcc/x86_64-pc-cygwin/4.9.3/include/c++/backward/auto_ptr.h:87) [-Wdeprecated-declaratio...
Use of auto_ptr causes dirty compile under Cygwin with -std=c++11
https://api.github.com/repos/weidai11/cryptopp/issues/17/comments
3
2015-07-27T06:13:23Z
2015-10-31T13:40:54Z
https://github.com/weidai11/cryptopp/issues/17
97,394,678
17
[ "weidai11", "cryptopp" ]
``` g++ -std=c++11 -DNDEBUG -g2 -O3 -march=native -Wall -Wextra -Wno-type-limits -Wno-unknown-pragmas -pipe -c rijndael.cpp rijndael.cpp: In member function ‘virtual size_t CryptoPP::Rijndael::Enc::AdvancedProcessBlocks(const byte*, const byte*, byte*, size_t, CryptoPP::word32) const’: rijndael.cpp:1214:45: error: ‘al...
Compile failure under Cygwin with GCC 4.8 in C++11 mode due to alloca
https://api.github.com/repos/weidai11/cryptopp/issues/16/comments
1
2015-07-27T04:36:52Z
2015-10-31T13:42:24Z
https://github.com/weidai11/cryptopp/issues/16
97,385,382
16
[ "weidai11", "cryptopp" ]
``` > CAST-128 validation suite running... > > passed 0123456712345678234567893456789A 0123456789ABCDEF > 238B4FE5847E44B2 > > Assertion failed: (y > 0 && y < THIS_SIZE), function rotlVariable, file > misc.h, line 713. > > Abort trap: 6 ``` Assert does not fire when inline assembler is in effect because ASM is not...
Assert fires when using rotate in CAST due to Undefined Behavior
https://api.github.com/repos/weidai11/cryptopp/issues/15/comments
1
2015-07-23T00:59:47Z
2015-10-31T13:44:45Z
https://github.com/weidai11/cryptopp/issues/15
96,700,941
15
[ "weidai11", "cryptopp" ]
``` integer.cpp:542:2: error: unknown token in expression AS1( neg %1) ^ ./cpu.h:220:17: note: expanded from macro 'AS1' #define AS1(x) GNU_AS1(x) ^ ./cpu.h:215:24: note: expanded from macro 'GNU_AS1' #define GNU_AS1(x) "\n\t" #x ";" ...
Clang integrated assembler and "unknown token in expression"
https://api.github.com/repos/weidai11/cryptopp/issues/14/comments
1
2015-07-22T10:39:05Z
2016-01-04T08:36:15Z
https://github.com/weidai11/cryptopp/issues/14
96,533,200
14
[ "weidai11", "cryptopp" ]
ASM statements need a `"\n\t"` when being consumed by Clang Integrated Assembler. GAS allows them on a single line separated by a semicolon.
ASM statements need a "\n\t" when being consumed by Clang Integrated Assembler
https://api.github.com/repos/weidai11/cryptopp/issues/13/comments
1
2015-07-22T08:56:23Z
2016-01-04T08:36:36Z
https://github.com/weidai11/cryptopp/issues/13
96,513,685
13
[ "weidai11", "cryptopp" ]
``` $ make GAS210_OR_LATER=1 GAS219_OR_LATER=1 GAS219_OR_LATER=1 clang++ -DNDEBUG -g2 -O3 -Wall -fPIC -march=native -pipe -Wno-tautological-compare -c gcm.cpp gcm.cpp:676:3: error: invalid operand for instruction AS2( movd WORD_REG(di), xmm... ^ ./cpu.h:221:20: note: expanded from...
Clang integrated assembler and "invalid operand for instruction"
https://api.github.com/repos/weidai11/cryptopp/issues/12/comments
1
2015-07-22T08:50:33Z
2016-01-04T08:36:48Z
https://github.com/weidai11/cryptopp/issues/12
96,512,080
12
[ "weidai11", "cryptopp" ]
Issue 18916: https://llvm.org/bugs/show_bug.cgi?id=18916 Issue 24200: https://llvm.org/bugs/show_bug.cgi?id=24200 LLVM will eventually fix the 18916 issue (".intel_syntax noprefix;" and ".att_syntax prefix;"). If they fix it in a forward compatible way, then we can just leave `WORKAROUND_LLVM_BUG_18916` in effect and ...
Need extensible way to handle Clang Integrated Assembler/LLVM Issues 18916 and 24200
https://api.github.com/repos/weidai11/cryptopp/issues/11/comments
4
2015-07-22T08:22:30Z
2016-01-04T08:53:27Z
https://github.com/weidai11/cryptopp/issues/11
96,506,856
11
[ "weidai11", "cryptopp" ]
Library does not compile due to inline assembly and ".att_sytax noprefix" and ".intel_syntax prefix" under Clang
https://api.github.com/repos/weidai11/cryptopp/issues/10/comments
1
2015-07-22T08:21:20Z
2016-01-04T08:53:57Z
https://github.com/weidai11/cryptopp/issues/10
96,506,633
10
[ "weidai11", "cryptopp" ]
The library fails to detect when SSE, SSE2, SSE3 are available under Clang when the Integrated Assembler is being used in the GNUmakefile. The issue is: ``` GAS219_OR_LATER := $(shell $(CXX) -xc -c /dev/null -Wa,-v -o/dev/null 2>&1 | $(EGREP) -i -c "GNU assembler version (2\.19|2\.[2-9]|[3-9])") ``` Reduces to/res...
Library fails to detect when SSE, SSE2, SSE3 are available under Clang
https://api.github.com/repos/weidai11/cryptopp/issues/9/comments
1
2015-07-22T08:13:24Z
2016-01-04T08:55:36Z
https://github.com/weidai11/cryptopp/issues/9
96,505,148
9
[ "weidai11", "cryptopp" ]
`filters.cpp` generates the following findings under UBsan. ``` $ make ubsan $ ./cryptest.exe v | grep error ``` A smaller (but inclusive) list is generated with `./cryptest.exe tv all | grep error`. --- Fedora 22, i386 (GCC 5.1): ``` filters.cpp:519:84: runtime error: null pointer passed as argument 1, which is d...
filters.cpp and undefined behavior
https://api.github.com/repos/weidai11/cryptopp/issues/8/comments
1
2015-07-19T04:14:10Z
2015-10-31T13:40:23Z
https://github.com/weidai11/cryptopp/issues/8
95,883,656
8
[ "weidai11", "cryptopp" ]
``` { simple_ptr<int> p1(new int); simple_ptr<int> p2(p1); } // double delete, undefined behaviour ```
simple_ptr should be non-copyable
https://api.github.com/repos/weidai11/cryptopp/issues/6/comments
2
2015-07-13T10:43:30Z
2016-01-04T08:54:27Z
https://github.com/weidai11/cryptopp/issues/6
94,692,851
6
[ "weidai11", "cryptopp" ]
The uses of Hack_DefaultValueFromConstReferenceType and Hack_GetValueIntoConstReference are undefined behaviour, and quite foul. If the VC60 workaround is still needed (VC6 in 2015, really?) the sane way to do it would be: ``` typename decay<R>::type value; if (!m_source.GetValue(name, value)) throw InvalidArgume...
AssignFromHelperClass is horrible
https://api.github.com/repos/weidai11/cryptopp/issues/5/comments
2
2015-07-13T10:35:59Z
2015-10-31T13:46:09Z
https://github.com/weidai11/cryptopp/issues/5
94,691,769
5