url stringlengths 62 66 | repository_url stringclasses 1
value | labels_url stringlengths 76 80 | comments_url stringlengths 71 75 | events_url stringlengths 69 73 | html_url stringlengths 50 56 | id int64 377M 2.15B | node_id stringlengths 18 32 | number int64 1 29.2k | title stringlengths 1 487 | user dict | labels list | state stringclasses 2
values | locked bool 2
classes | assignee dict | assignees list | comments list | created_at int64 1.54k 1.71k | updated_at int64 1.54k 1.71k | closed_at int64 1.54k 1.71k ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 2
values | body stringlengths 0 234k ⌀ | reactions dict | timeline_url stringlengths 71 75 | state_reason stringclasses 3
values | draft bool 2
classes | pull_request dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/transformers/issues/28256 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28256/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28256/comments | https://api.github.com/repos/huggingface/transformers/issues/28256/events | https://github.com/huggingface/transformers/pull/28256 | 2,057,035,270 | PR_kwDOCUB6oc5iz7e_ | 28,256 | Fix load balancing loss func for mixtral | {
"login": "liangxuZhang",
"id": 57205192,
"node_id": "MDQ6VXNlcjU3MjA1MTky",
"avatar_url": "https://avatars.githubusercontent.com/u/57205192?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/liangxuZhang",
"html_url": "https://github.com/liangxuZhang",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"How does this differ from https://github.com/huggingface/transformers/pull/28115 ?",
"What is the impact of this issue on Mixtral training? Will this fix conceivability improve the quality of training? Is it likely that previous Mixtral trainings are not as good as they could be?\r\n\r\nIt seems like an import... | 1,703 | 1,705 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28256/reactions",
"total_count": 3,
"+1": 3,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28256/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28256",
"html_url": "https://github.com/huggingface/transformers/pull/28256",
"diff_url": "https://github.com/huggingface/transformers/pull/28256.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28256.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28255 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28255/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28255/comments | https://api.github.com/repos/huggingface/transformers/issues/28255/events | https://github.com/huggingface/transformers/issues/28255 | 2,057,030,017 | I_kwDOCUB6oc56m8mB | 28,255 | Incorrect implementation of auxiliary loss | {
"login": "liangxuZhang",
"id": 57205192,
"node_id": "MDQ6VXNlcjU3MjA1MTky",
"avatar_url": "https://avatars.githubusercontent.com/u/57205192?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/liangxuZhang",
"html_url": "https://github.com/liangxuZhang",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"Hi, liangxu! I also noticed this difference between the implementation by mixtral and the equations 4-5 in (https://arxiv.org/pdf/2101.03961.pdf). I am wondering if this has something to do with \"The objective can also be differentiated as the P-vector is differentiable, but the f-vector is not.\" (line1, page8)?... | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.37.0.dev0
- Platform: macOS-13.5-arm64-arm-64bit
- Python version: 3.10.13
- Huggingface_hub version: 0.20.1
- Safetensors version: 0.4.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (False)
- Tensorflow version (... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28255/reactions",
"total_count": 11,
"+1": 11,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28255/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28254 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28254/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28254/comments | https://api.github.com/repos/huggingface/transformers/issues/28254/events | https://github.com/huggingface/transformers/pull/28254 | 2,056,681,551 | PR_kwDOCUB6oc5iyyeq | 28,254 | Add TinyViT | {
"login": "NielsRogge",
"id": 48327001,
"node_id": "MDQ6VXNlcjQ4MzI3MDAx",
"avatar_url": "https://avatars.githubusercontent.com/u/48327001?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NielsRogge",
"html_url": "https://github.com/NielsRogge",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease note that issues that do not follow the [contributing guidelines](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md) a... | 1,703 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
This PR adds TinyViT. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28254/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28254/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28254",
"html_url": "https://github.com/huggingface/transformers/pull/28254",
"diff_url": "https://github.com/huggingface/transformers/pull/28254.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28254.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28253 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28253/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28253/comments | https://api.github.com/repos/huggingface/transformers/issues/28253/events | https://github.com/huggingface/transformers/pull/28253 | 2,056,333,824 | PR_kwDOCUB6oc5ixoGp | 28,253 | Update quantization_config.py | {
"login": "manas95826",
"id": 74074241,
"node_id": "MDQ6VXNlcjc0MDc0MjQx",
"avatar_url": "https://avatars.githubusercontent.com/u/74074241?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/manas95826",
"html_url": "https://github.com/manas95826",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease note that issues that do not follow the [contributing guidelines](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md) a... | 1,703 | 1,706 | 1,706 | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28253/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28253/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28253",
"html_url": "https://github.com/huggingface/transformers/pull/28253",
"diff_url": "https://github.com/huggingface/transformers/pull/28253.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28253.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28252 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28252/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28252/comments | https://api.github.com/repos/huggingface/transformers/issues/28252/events | https://github.com/huggingface/transformers/pull/28252 | 2,056,145,171 | PR_kwDOCUB6oc5iw_dU | 28,252 | Dev/tomato | {
"login": "cliangyu",
"id": 45140242,
"node_id": "MDQ6VXNlcjQ1MTQwMjQy",
"avatar_url": "https://avatars.githubusercontent.com/u/45140242?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cliangyu",
"html_url": "https://github.com/cliangyu",
"followers_url": "https://api.github.com/users/cli... | [] | closed | false | null | [] | [] | 1,703 | 1,703 | 1,703 | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28252/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28252/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28252",
"html_url": "https://github.com/huggingface/transformers/pull/28252",
"diff_url": "https://github.com/huggingface/transformers/pull/28252.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28252.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28251 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28251/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28251/comments | https://api.github.com/repos/huggingface/transformers/issues/28251/events | https://github.com/huggingface/transformers/pull/28251 | 2,056,078,896 | PR_kwDOCUB6oc5iwxan | 28,251 | fix bug:divide by zero in _maybe_log_save_evaluate() | {
"login": "frankenliu",
"id": 7486431,
"node_id": "MDQ6VXNlcjc0ODY0MzE=",
"avatar_url": "https://avatars.githubusercontent.com/u/7486431?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/frankenliu",
"html_url": "https://github.com/frankenliu",
"followers_url": "https://api.github.com/users... | [] | closed | false | null | [] | [
"> Thanks for fixing @frankenliu !\r\n> \r\n> For future PRs, could you make sure to link to the relevant code in the PR description? This will make it quicker and easier to review.\r\n\r\nOkay !"
] | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | Hi, everyone.
**This is a new clean PR for previous PR #28102.**
set logging_strategy="steps" and logging_steps=10,
when that one epoch have 100 steps, the should_log will be set to True in last step.
And self._globalstep_last_logged will be assign to self.state.global_step in _maybe_log_save_evaluate() method by l... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28251/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28251/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28251",
"html_url": "https://github.com/huggingface/transformers/pull/28251",
"diff_url": "https://github.com/huggingface/transformers/pull/28251.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28251.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28250 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28250/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28250/comments | https://api.github.com/repos/huggingface/transformers/issues/28250/events | https://github.com/huggingface/transformers/pull/28250 | 2,056,044,016 | PR_kwDOCUB6oc5iwqGw | 28,250 | Fix model code to accurately convert fairseq wav2vec2 model | {
"login": "upskyy",
"id": 54731898,
"node_id": "MDQ6VXNlcjU0NzMxODk4",
"avatar_url": "https://avatars.githubusercontent.com/u/54731898?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/upskyy",
"html_url": "https://github.com/upskyy",
"followers_url": "https://api.github.com/users/upskyy/fo... | [] | open | false | null | [] | [
"@ylacombe @sanchit-gandhi \r\nI opened a PR and I would appreciate it if you could check it out when you have time. \r\nThanks : )\r\n\r\n",
"@ylacombe @sanchit-gandhi \r\n\r\nThe test error seems to change as the model parameters change. Do you have any next steps for me to take?\r\n\r\n[workflow test error](ht... | 1,703 | 1,706 | null | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28250/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28250/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28250",
"html_url": "https://github.com/huggingface/transformers/pull/28250",
"diff_url": "https://github.com/huggingface/transformers/pull/28250.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28250.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28249 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28249/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28249/comments | https://api.github.com/repos/huggingface/transformers/issues/28249/events | https://github.com/huggingface/transformers/issues/28249 | 2,056,016,481 | I_kwDOCUB6oc56jFJh | 28,249 | For V30.0 and after, save_pretrained() doesn't correctly save values when using set_input_embeddings() | {
"login": "bjascob",
"id": 22728060,
"node_id": "MDQ6VXNlcjIyNzI4MDYw",
"avatar_url": "https://avatars.githubusercontent.com/u/22728060?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bjascob",
"html_url": "https://github.com/bjascob",
"followers_url": "https://api.github.com/users/bjasco... | [] | closed | false | null | [] | [
"The answer to this is posted on the [forum here](https://discuss.huggingface.co/t/set-input-embeddings-values-not-being-saved-with-save-pretrained/67020).\r\n\r\nIn short, gpt2 has tied input and output weights and on saving, only one of the two values are used. Which one seems to have changed between transformer ... | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-6.2.0-39-generic-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: 0.25.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.1+cu121 (True)
- Tensorfl... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28249/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28249/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28248 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28248/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28248/comments | https://api.github.com/repos/huggingface/transformers/issues/28248/events | https://github.com/huggingface/transformers/issues/28248 | 2,055,841,176 | I_kwDOCUB6oc56iaWY | 28,248 | `transformers==4.36.2` not available from `huggingface` conda channel | {
"login": "kevherro",
"id": 10460086,
"node_id": "MDQ6VXNlcjEwNDYwMDg2",
"avatar_url": "https://avatars.githubusercontent.com/u/10460086?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kevherro",
"html_url": "https://github.com/kevherro",
"followers_url": "https://api.github.com/users/kev... | [] | closed | false | null | [] | [
"On a related note: it appears that upgrading to the latest version of `transformers` (`4.36.2`) resolves the `KeyError: 'mixtral'` [bug](https://huggingface.co/mistralai/Mixtral-8x7B-Instruct-v0.1/discussions/9). This means that anyone installing `transformers` from the `huggingface` conda channel (as described in... | 1,703 | 1,707 | 1,704 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.33.3
- Platform: macOS-10.16-x86_64-i386-64bit
- Python version: 3.10.13
- Huggingface_hub version: 0.20.1
- Safetensors version: 0.4.0
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (False)
- Tensorflow version (GP... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28248/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28248/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28247 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28247/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28247/comments | https://api.github.com/repos/huggingface/transformers/issues/28247/events | https://github.com/huggingface/transformers/issues/28247 | 2,055,792,277 | I_kwDOCUB6oc56iOaV | 28,247 | [WIP] Translate 'Contribute' Section into Chinese | {
"login": "Mayfsz",
"id": 145372523,
"node_id": "U_kgDOCKo1aw",
"avatar_url": "https://avatars.githubusercontent.com/u/145372523?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Mayfsz",
"html_url": "https://github.com/Mayfsz",
"followers_url": "https://api.github.com/users/Mayfsz/follower... | [] | closed | false | null | [] | [
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease note that issues that do not follow the [contributing guidelines](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md) a... | 1,703 | 1,707 | 1,707 | CONTRIBUTOR | null | Hello, I'm new here and this is my first time contributing. If there are any issues with my work, please let me know. I'll do my best to make any necessary changes.
This is a part of #26803 .
My plan is to translate the 6 sections of the 'Contribute' chapter into Chinese. The files that need translation include:
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28247/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28247/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28246 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28246/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28246/comments | https://api.github.com/repos/huggingface/transformers/issues/28246/events | https://github.com/huggingface/transformers/pull/28246 | 2,055,780,934 | PR_kwDOCUB6oc5iv0Gx | 28,246 | [WIP] Add CAV-MAE model, initially cloned from VitMAE | {
"login": "rationalism",
"id": 813306,
"node_id": "MDQ6VXNlcjgxMzMwNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/813306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rationalism",
"html_url": "https://github.com/rationalism",
"followers_url": "https://api.github.com/user... | [] | closed | false | null | [] | [
"Created an initial PR to add the CAV-MAE model by cloning the visual-audio multimodal model TVLT\r\n\r\nPaper: https://arxiv.org/abs/2210.07839\r\n\r\nOriginal model repo: https://github.com/YuanGongND/cav-mae\r\n\r\n(haven't actually added the CAV-MAE code yet! this is just a scaffold)",
"Re-basing this on the ... | 1,703 | 1,706 | 1,706 | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28246/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28246/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28246",
"html_url": "https://github.com/huggingface/transformers/pull/28246",
"diff_url": "https://github.com/huggingface/transformers/pull/28246.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28246.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28245 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28245/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28245/comments | https://api.github.com/repos/huggingface/transformers/issues/28245/events | https://github.com/huggingface/transformers/pull/28245 | 2,055,766,865 | PR_kwDOCUB6oc5ivxKU | 28,245 | Fix initialization for missing parameters in `from_pretrained` under ZeRO-3 | {
"login": "XuehaiPan",
"id": 16078332,
"node_id": "MDQ6VXNlcjE2MDc4MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/16078332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuehaiPan",
"html_url": "https://github.com/XuehaiPan",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"I add a simple test case in this PR. I also test it with and without the patch in this PR:\r\n\r\n- with the patch: PASS\r\n- without the patch (main branch): FAIL",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28245). All of your documentation changes will be reflec... | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28245/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28245/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28245",
"html_url": "https://github.com/huggingface/transformers/pull/28245",
"diff_url": "https://github.com/huggingface/transformers/pull/28245.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28245.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28244 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28244/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28244/comments | https://api.github.com/repos/huggingface/transformers/issues/28244/events | https://github.com/huggingface/transformers/issues/28244 | 2,055,760,635 | I_kwDOCUB6oc56iGr7 | 28,244 | [BUG] `from_pretrained` does not properly initialize missing parameters under DeepSpeed ZeRO-3 | {
"login": "XuehaiPan",
"id": 16078332,
"node_id": "MDQ6VXNlcjE2MDc4MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/16078332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/XuehaiPan",
"html_url": "https://github.com/XuehaiPan",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [] | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-6.2.0-39-generic-x86_64-with-glibc2.35
- Python version: 3.11.5
- Huggingface_hub version: 0.20.1
- Safetensors version: 0.4.0
- Accelerate version: 0.25.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (True)
- Tensorflow ve... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28244/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28244/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28243 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28243/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28243/comments | https://api.github.com/repos/huggingface/transformers/issues/28243/events | https://github.com/huggingface/transformers/pull/28243 | 2,055,745,633 | PR_kwDOCUB6oc5ivspF | 28,243 | Translate contributing.md into Chinese | {
"login": "Mayfsz",
"id": 145372523,
"node_id": "U_kgDOCKo1aw",
"avatar_url": "https://avatars.githubusercontent.com/u/145372523?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Mayfsz",
"html_url": "https://github.com/Mayfsz",
"followers_url": "https://api.github.com/users/Mayfsz/follower... | [] | closed | false | null | [] | [] | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28243/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28243/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28243",
"html_url": "https://github.com/huggingface/transformers/pull/28243",
"diff_url": "https://github.com/huggingface/transformers/pull/28243.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28243.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28242 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28242/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28242/comments | https://api.github.com/repos/huggingface/transformers/issues/28242/events | https://github.com/huggingface/transformers/pull/28242 | 2,055,709,028 | PR_kwDOCUB6oc5ivk1c | 28,242 | [Nougat] Fix pipeline | {
"login": "NielsRogge",
"id": 48327001,
"node_id": "MDQ6VXNlcjQ4MzI3MDAx",
"avatar_url": "https://avatars.githubusercontent.com/u/48327001?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NielsRogge",
"html_url": "https://github.com/NielsRogge",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28242). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,703 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
This PR ensures [Nougat](https://huggingface.co/docs/transformers/main/model_doc/nougat) works with the image-to-text pipeline.
Fixes #27475 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28242/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28242/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28242",
"html_url": "https://github.com/huggingface/transformers/pull/28242",
"diff_url": "https://github.com/huggingface/transformers/pull/28242.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28242.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28241 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28241/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28241/comments | https://api.github.com/repos/huggingface/transformers/issues/28241/events | https://github.com/huggingface/transformers/issues/28241 | 2,055,635,695 | I_kwDOCUB6oc56hoLv | 28,241 | why max_position_embeddings = 2048 for llama2 | {
"login": "ckfgihub",
"id": 44078448,
"node_id": "MDQ6VXNlcjQ0MDc4NDQ4",
"avatar_url": "https://avatars.githubusercontent.com/u/44078448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ckfgihub",
"html_url": "https://github.com/ckfgihub",
"followers_url": "https://api.github.com/users/ckf... | [
{
"id": 1990918270,
"node_id": "MDU6TGFiZWwxOTkwOTE4Mjcw",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20First%20Issue",
"name": "Good First Issue",
"color": "bbf794",
"default": false,
"description": ""
}
] | open | false | null | [] | [
"Hi @ckfgihub, thanks for raising this issue! \r\n\r\nThe conversion script was originally written for the original Llama, which I suspect is why we have this discrepancy. cc @ArthurZucker to confirm. If so, it'll be a simple case of updating the condition in the script. Happy to review a PR for anyone who would li... | 1,703 | 1,706 | null | NONE | null | ### System Info
when I use under cmd to convert llama2 7B model and max_position_embeddings = 2048,but llama2 this max_position_embeddings = 4096.
```
python src/transformers/models/llama/convert_llama_weights_to_hf.py \
--input_dir /path/to/downloaded/llama/weights --model_size 7B --output_dir /output/path... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28241/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28241/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28240 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28240/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28240/comments | https://api.github.com/repos/huggingface/transformers/issues/28240/events | https://github.com/huggingface/transformers/pull/28240 | 2,055,633,282 | PR_kwDOCUB6oc5ivUdJ | 28,240 | [`Mixtral` / `Awq`] Add mixtral fused modules for Awq | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"Thanks for your review @amyeroberts ! I left few comments and open questions, let me know wdyt! 🙏 ",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28240). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after... | 1,703 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
Adds Mixtral + AWQ fused modules for blazing fast text generation!
```python
from transformers import MixtralForCausalLM, AwqConfig, AutoTokenizer
model_path = "casperhansen/mixtral-instruct-awq"
quantization_config = AwqConfig(
do_fuse=True,
fuse_max_seq_len=1024,
)
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28240/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28240/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28240",
"html_url": "https://github.com/huggingface/transformers/pull/28240",
"diff_url": "https://github.com/huggingface/transformers/pull/28240.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28240.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28239 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28239/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28239/comments | https://api.github.com/repos/huggingface/transformers/issues/28239/events | https://github.com/huggingface/transformers/pull/28239 | 2,055,607,043 | PR_kwDOCUB6oc5ivOzF | 28,239 | [`Awq`] Add llava fused modules support | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"Thank you soooo much, this PR and #28032 helped me work well now!",
"Thanks for your reviews @ArthurZucker ! Merging ! I'll address the points you shared in https://github.com/huggingface/transformers/pull/28239#discussion_r1448621388 in another PR as stated in my reply"
] | 1,703 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
This PR adds the Llava + fused modules support for blazing fast text generation using Llava + AWQ!
This PR also fixes the issue: https://github.com/huggingface/transformers/pull/28032#issuecomment-1868262141 pointed out by a user since a custom past key value is passed to the model, indee... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28239/reactions",
"total_count": 3,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 2,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28239/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28239",
"html_url": "https://github.com/huggingface/transformers/pull/28239",
"diff_url": "https://github.com/huggingface/transformers/pull/28239.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28239.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28238 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28238/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28238/comments | https://api.github.com/repos/huggingface/transformers/issues/28238/events | https://github.com/huggingface/transformers/issues/28238 | 2,055,478,265 | I_kwDOCUB6oc56hBv5 | 28,238 | Finetuning Whisper with adapter with MAML | {
"login": "LYPinASR",
"id": 112866899,
"node_id": "U_kgDOBro2Uw",
"avatar_url": "https://avatars.githubusercontent.com/u/112866899?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LYPinASR",
"html_url": "https://github.com/LYPinASR",
"followers_url": "https://api.github.com/users/LYPinASR/... | [
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request",
"name": "Feature request",
"color": "FBCA04",
"default": false,
"description": "Request for a new feature"
},
{
"id": 6470596964,
... | open | false | null | [] | [
"cc @sanchit-gandhi @ylacombe "
] | 1,703 | 1,706 | null | NONE | null | ### Feature request
MAML is a widely used meta-learning method for reinitializing model parameters, which can effectively cope with low-resource situations.
As Whisper is a pre-trained model, its parameters cannot be reinitialized, but the bottleneck structure adapter can be applied to the encoder and decoder layers ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28238/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28238/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28237 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28237/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28237/comments | https://api.github.com/repos/huggingface/transformers/issues/28237/events | https://github.com/huggingface/transformers/issues/28237 | 2,055,447,081 | I_kwDOCUB6oc56g6Ip | 28,237 | Add JAX implementation of Phi | {
"login": "shivance",
"id": 51750587,
"node_id": "MDQ6VXNlcjUxNzUwNTg3",
"avatar_url": "https://avatars.githubusercontent.com/u/51750587?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shivance",
"html_url": "https://github.com/shivance",
"followers_url": "https://api.github.com/users/shi... | [
{
"id": 1843244711,
"node_id": "MDU6TGFiZWwxODQzMjQ0NzEx",
"url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model",
"name": "New model",
"color": "fbca04",
"default": false,
"description": ""
}
] | closed | false | null | [] | [
"@shivance This issue is marked as completed but I can neither find the implementation in the [code tree](https://github.com/huggingface/transformers/tree/main/src/transformers/models/phi), nor load the model via `FlaxAutoModel`. Can you please point me to the implementation? ",
"@dfdx The Flax implementation of ... | 1,703 | 1,706 | 1,704 | NONE | null | ### Model description
Transformers already has Phi #26110 . I want to contribute the JAX/Flax implementation of the same.
### Open source status
- [X] The model implementation is available
- [X] The model weights are available
### Provide useful links for the implementation
_No response_ | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28237/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28237/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28236 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28236/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28236/comments | https://api.github.com/repos/huggingface/transformers/issues/28236/events | https://github.com/huggingface/transformers/issues/28236 | 2,055,389,388 | I_kwDOCUB6oc56gsDM | 28,236 | Add CAV-MAE audio-image encoder model | {
"login": "rationalism",
"id": 813306,
"node_id": "MDQ6VXNlcjgxMzMwNg==",
"avatar_url": "https://avatars.githubusercontent.com/u/813306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rationalism",
"html_url": "https://github.com/rationalism",
"followers_url": "https://api.github.com/user... | [
{
"id": 1843244711,
"node_id": "MDU6TGFiZWwxODQzMjQ0NzEx",
"url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model",
"name": "New model",
"color": "fbca04",
"default": false,
"description": ""
}
] | open | false | null | [] | [
"I totally support this proposal. The code and checkpoints are available at https://github.com/YuanGongND/cav-mae.",
"Created an initial PR here by cloning the visual-audio multimodal model TVLT: https://github.com/huggingface/transformers/pull/28246\r\n\r\n(haven't actually added the CAV-MAE code yet! this is ju... | 1,703 | 1,703 | null | NONE | null | ### Model description
Contrastive Audio-Visual Masked Autoencoder (CAV-MAE) combines two major self-supervised learning frameworks: contrastive learning and masked data modeling, to learn a joint and coordinated audio-visual representation. It appears to be the open source SOTA on the AudioSet and VGGSound datasets (t... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28236/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28236/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28235 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28235/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28235/comments | https://api.github.com/repos/huggingface/transformers/issues/28235/events | https://github.com/huggingface/transformers/pull/28235 | 2,055,227,277 | PR_kwDOCUB6oc5it-Ll | 28,235 | if apply_ocr is False, then don't pass any image | {
"login": "fawazahmed0",
"id": 20347013,
"node_id": "MDQ6VXNlcjIwMzQ3MDEz",
"avatar_url": "https://avatars.githubusercontent.com/u/20347013?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fawazahmed0",
"html_url": "https://github.com/fawazahmed0",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"Hi,\r\n\r\nCould you clarify your PR? You still need to prepare the image for the model (by resizing + normalizing it), even if apply_ocr is set to False.",
"sorry, I was using [LayoutLMV1](https://huggingface.co/docs/transformers/model_doc/layoutlm) with LayoutLMv2Processor and in my specific case, I doesn't ha... | 1,703 | 1,703 | 1,703 | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28235/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28235/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28235",
"html_url": "https://github.com/huggingface/transformers/pull/28235",
"diff_url": "https://github.com/huggingface/transformers/pull/28235.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28235.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28234 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28234/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28234/comments | https://api.github.com/repos/huggingface/transformers/issues/28234/events | https://github.com/huggingface/transformers/issues/28234 | 2,055,222,287 | I_kwDOCUB6oc56gDQP | 28,234 | Phi for sequence classfication gives nan | {
"login": "Alymostafa",
"id": 34445689,
"node_id": "MDQ6VXNlcjM0NDQ1Njg5",
"avatar_url": "https://avatars.githubusercontent.com/u/34445689?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Alymostafa",
"html_url": "https://github.com/Alymostafa",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"Hi @Alymostafa \r\nI suspect there might be something off with the trust_remote_code version of phi_1-5, can you try with the official transformers version which is pushed here: https://huggingface.co/susnato/phi-1_5_dev ?\r\nCan you also try to train with bf16 mixed precision? i.e. you need to load the model in f... | 1,703 | 1,706 | 1,706 | NONE | null | ### System Info
I tried fine-tuning the Phi-1_5 model for a sequence classification task, but it gives ```nan``` in the validation loss and ```no log``` in the training loss. I tried fp16 & float 32, and both have the same output.
@younesbelkada
### Who can help?
_No response_
### Information
- [ ] Th... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28234/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28234/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28232 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28232/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28232/comments | https://api.github.com/repos/huggingface/transformers/issues/28232/events | https://github.com/huggingface/transformers/pull/28232 | 2,055,031,094 | PR_kwDOCUB6oc5itXk1 | 28,232 | something | {
"login": "dirwolf",
"id": 92151410,
"node_id": "U_kgDOBX4ecg",
"avatar_url": "https://avatars.githubusercontent.com/u/92151410?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dirwolf",
"html_url": "https://github.com/dirwolf",
"followers_url": "https://api.github.com/users/dirwolf/follow... | [] | closed | false | null | [] | [
"Thanks! https://github.com/huggingface/transformers/pull/28231 should fix this issue and also for `text_generation.py`.",
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease note that iss... | 1,703 | 1,707 | 1,707 | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28232/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28232/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28232",
"html_url": "https://github.com/huggingface/transformers/pull/28232",
"diff_url": "https://github.com/huggingface/transformers/pull/28232.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28232.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28231 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28231/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28231/comments | https://api.github.com/repos/huggingface/transformers/issues/28231/events | https://github.com/huggingface/transformers/pull/28231 | 2,055,015,523 | PR_kwDOCUB6oc5itUlk | 28,231 | Update docs related to generate() method in transformers/pipelines | {
"login": "coolyashas",
"id": 32161167,
"node_id": "MDQ6VXNlcjMyMTYxMTY3",
"avatar_url": "https://avatars.githubusercontent.com/u/32161167?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coolyashas",
"html_url": "https://github.com/coolyashas",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"I believe all necessary changes have been made @stevhliu ",
"Hey, can you also apply the changes to the `text2text_generation.py` and `text_generation.py` files please?",
"> Hey, can you also apply the changes to the `text2text_generation.py` and `text_generation.py` files please?\r\n\r\n, but I find [this](https://huggingface.co/docs/transformers/v4.36.1/en/main_classes/text_generation) to be a better fit.
@stevhliu and @MKhalusova | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28231/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28231/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28231",
"html_url": "https://github.com/huggingface/transformers/pull/28231",
"diff_url": "https://github.com/huggingface/transformers/pull/28231.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28231.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28230 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28230/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28230/comments | https://api.github.com/repos/huggingface/transformers/issues/28230/events | https://github.com/huggingface/transformers/issues/28230 | 2,055,009,660 | I_kwDOCUB6oc56fPV8 | 28,230 | RuntimeError: Failed to import transformers.pipelines because of the following error (look up to see its traceback) [undefined symbol] | {
"login": "ramyaprabhu-alt",
"id": 138777240,
"node_id": "U_kgDOCEWSmA",
"avatar_url": "https://avatars.githubusercontent.com/u/138777240?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ramyaprabhu-alt",
"html_url": "https://github.com/ramyaprabhu-alt",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"solved it",
"@ramyaprabhu-alt Hi, I meet the same question. Can you tell me how did you solve it? thx",
"pip uninstall transformer-engine worked for me",
"Not sure why I was tagged. Glad you found a solution"
] | 1,703 | 1,704 | 1,703 | NONE | null | ### System Info
transformers==4.36.2
torch==2.1.2+cu121
Python==3.10.12
### Who can help?
@Narsil
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X] My own task or dataset (give ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28230/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28230/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28229 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28229/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28229/comments | https://api.github.com/repos/huggingface/transformers/issues/28229/events | https://github.com/huggingface/transformers/pull/28229 | 2,054,981,100 | PR_kwDOCUB6oc5itOI3 | 28,229 | small typo | {
"login": "stas00",
"id": 10676103,
"node_id": "MDQ6VXNlcjEwNjc2MTAz",
"avatar_url": "https://avatars.githubusercontent.com/u/10676103?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stas00",
"html_url": "https://github.com/stas00",
"followers_url": "https://api.github.com/users/stas00/fo... | [] | closed | false | null | [] | [] | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | fixing a small typo | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28229/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28229/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28229",
"html_url": "https://github.com/huggingface/transformers/pull/28229",
"diff_url": "https://github.com/huggingface/transformers/pull/28229.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28229.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28228 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28228/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28228/comments | https://api.github.com/repos/huggingface/transformers/issues/28228/events | https://github.com/huggingface/transformers/issues/28228 | 2,054,969,638 | I_kwDOCUB6oc56fFkm | 28,228 | Prompt_ids vs. decoder_input_ids in Whisper | {
"login": "vymao",
"id": 18024303,
"node_id": "MDQ6VXNlcjE4MDI0MzAz",
"avatar_url": "https://avatars.githubusercontent.com/u/18024303?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vymao",
"html_url": "https://github.com/vymao",
"followers_url": "https://api.github.com/users/vymao/follow... | [] | closed | false | null | [] | [
"Hey @vymao, `prompt_ids` basically refers to the input tokens or token IDs provided to the model before generating text and it serves as an initial context for the model to begin generating text.\r\n\r\nOn the other hand, `decoder_input_ids` are mainly used in sequence-to-sequence models or in models with a decode... | 1,703 | 1,707 | 1,707 | NONE | null | ### Feature request
I am trying to understand the different between adding prior text to `prompt_ids` vs. `decoder_input_ids` when [generating text via Whisper](https://huggingface.co/docs/transformers/v4.36.1/en/model_doc/whisper#transformers.WhisperForConditionalGeneration). The documentation is not very clear on ho... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28228/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28228/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28227 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28227/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28227/comments | https://api.github.com/repos/huggingface/transformers/issues/28227/events | https://github.com/huggingface/transformers/issues/28227 | 2,054,953,571 | I_kwDOCUB6oc56fBpj | 28,227 | TrOCR wrong output after fine-tuning on specific tokenizer | {
"login": "magistermilitum",
"id": 37591896,
"node_id": "MDQ6VXNlcjM3NTkxODk2",
"avatar_url": "https://avatars.githubusercontent.com/u/37591896?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/magistermilitum",
"html_url": "https://github.com/magistermilitum",
"followers_url": "https://api... | [] | closed | false | null | [] | [
"cc @NielsRogge ",
"This was resolved here: https://github.com/huggingface/transformers/issues/19329#issuecomment-1869144991",
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease note th... | 1,703 | 1,706 | 1,706 | NONE | null | ### System Info
I get funny outputs like that: '叡 叡 叡ělělěllioliolio 揮 揮 揮ത്തിത്തിത്തി ὴ ὴ ὴ Dans Dans Dans Wesley Wesley Wesley contaba contaba contaba ......
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An offici... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28227/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28227/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28226 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28226/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28226/comments | https://api.github.com/repos/huggingface/transformers/issues/28226/events | https://github.com/huggingface/transformers/pull/28226 | 2,054,911,110 | PR_kwDOCUB6oc5itA4w | 28,226 | [Whisper] Fix word-level timestamps error in DTW - `ValueError: too many values to unpack (expected 2)` | {
"login": "guy1992l",
"id": 83535508,
"node_id": "MDQ6VXNlcjgzNTM1NTA4",
"avatar_url": "https://avatars.githubusercontent.com/u/83535508?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guy1992l",
"html_url": "https://github.com/guy1992l",
"followers_url": "https://api.github.com/users/guy... | [] | closed | false | null | [] | [
"Just tested this, can confirm it fixes the issue 👍 ",
"Hey @guy1992l, thanks for opening the PR, this is indeed something that slipped through my net with my PR!\r\n\r\n#28288 is offering the same fix + support with MPS backend so we'll probably go with that PR ! Thanks again for your work on this ",
"No pro... | 1,703 | 1,704 | 1,704 | NONE | null | # What does this PR do?
When trying to use the ASR with a whisper model, `return_timestamps="word"` and `batch_size>1`, there was an error in the method `_dynamic_time_warping`:
```
File "/transformers/models/whisper/modeling_whisper.py", line 258, in _dynamic_time_warping
output_length, input_length = matrix... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28226/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28226/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28226",
"html_url": "https://github.com/huggingface/transformers/pull/28226",
"diff_url": "https://github.com/huggingface/transformers/pull/28226.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28226.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28225 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28225/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28225/comments | https://api.github.com/repos/huggingface/transformers/issues/28225/events | https://github.com/huggingface/transformers/pull/28225 | 2,054,864,723 | PR_kwDOCUB6oc5is3hX | 28,225 | HF_quantizers draft PR (created in error) | {
"login": "poedator",
"id": 24738311,
"node_id": "MDQ6VXNlcjI0NzM4MzEx",
"avatar_url": "https://avatars.githubusercontent.com/u/24738311?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/poedator",
"html_url": "https://github.com/poedator",
"followers_url": "https://api.github.com/users/poe... | [] | closed | false | null | [] | [] | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | created by error. pls ignore | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28225/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28225/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28225",
"html_url": "https://github.com/huggingface/transformers/pull/28225",
"diff_url": "https://github.com/huggingface/transformers/pull/28225.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28225.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28224 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28224/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28224/comments | https://api.github.com/repos/huggingface/transformers/issues/28224/events | https://github.com/huggingface/transformers/issues/28224 | 2,054,864,441 | I_kwDOCUB6oc56er45 | 28,224 | [DOCS] - Wrong link to model#generative-models in Pipeline docs | {
"login": "BrunoGomesCoelho",
"id": 17727737,
"node_id": "MDQ6VXNlcjE3NzI3NzM3",
"avatar_url": "https://avatars.githubusercontent.com/u/17727737?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BrunoGomesCoelho",
"html_url": "https://github.com/BrunoGomesCoelho",
"followers_url": "https://... | [] | open | false | null | [] | [
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease note that issues that do not follow the [contributing guidelines](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md) a... | 1,703 | 1,708 | null | NONE | null | ### System Info
Latest docs on https://huggingface.co/docs/transformers/en/main_classes/pipelines#transformers.TextGenerationPipeline
### Who can help?
@stevhliu and @MKhalusova
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in th... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28224/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28224/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28223 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28223/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28223/comments | https://api.github.com/repos/huggingface/transformers/issues/28223/events | https://github.com/huggingface/transformers/pull/28223 | 2,054,843,227 | PR_kwDOCUB6oc5iszYp | 28,223 | Update docs around mixing hf scheduler with deepspeed optimizer | {
"login": "dwyatte",
"id": 2512762,
"node_id": "MDQ6VXNlcjI1MTI3NjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2512762?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dwyatte",
"html_url": "https://github.com/dwyatte",
"followers_url": "https://api.github.com/users/dwyatte/... | [] | closed | false | null | [] | [] | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
Looks like the docs around mixing and matching deepspeed optimizers with HF schedulers were not updated with https://github.com/huggingface/transformers/pull/25863. I think there's probably an analogous update to make in [`accelerate`](https://github.com/huggingface/accelerate/blob/ceb7c699bc... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28223/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28223/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28223",
"html_url": "https://github.com/huggingface/transformers/pull/28223",
"diff_url": "https://github.com/huggingface/transformers/pull/28223.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28223.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28222 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28222/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28222/comments | https://api.github.com/repos/huggingface/transformers/issues/28222/events | https://github.com/huggingface/transformers/issues/28222 | 2,054,797,174 | I_kwDOCUB6oc56ebd2 | 28,222 | torch.export & save doesn't work | {
"login": "MrParosk",
"id": 35773375,
"node_id": "MDQ6VXNlcjM1NzczMzc1",
"avatar_url": "https://avatars.githubusercontent.com/u/35773375?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MrParosk",
"html_url": "https://github.com/MrParosk",
"followers_url": "https://api.github.com/users/MrP... | [] | closed | false | null | [] | [
"Yes, You are totally right, All hugging face models have outputs that are instances of subclasses of [ModelOutput](https://huggingface.co/docs/transformers/v4.36.1/en/main_classes/output#transformers.utils.ModelOutput) which as you mentioned aren't `JSON serializable`.\r\n\r\nThankfully, You can opt not to use the... | 1,703 | 1,703 | 1,703 | NONE | null | ### System Info
## Description
PyTorch 2.x supports torch.export.export to export a model into a graph representation and later serialize to with torch.export.save.
However, trying to do that with HF transformers models doesn't work (see reproduction section below).
I think the main issue is that HF transform... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28222/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28222/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28221 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28221/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28221/comments | https://api.github.com/repos/huggingface/transformers/issues/28221/events | https://github.com/huggingface/transformers/pull/28221 | 2,054,790,352 | PR_kwDOCUB6oc5ispS_ | 28,221 | Make VideoMAEImageProcessor much faster | {
"login": "ikergarcia1996",
"id": 18737249,
"node_id": "MDQ6VXNlcjE4NzM3MjQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/18737249?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ikergarcia1996",
"html_url": "https://github.com/ikergarcia1996",
"followers_url": "https://api.gi... | [] | open | false | null | [] | [
"@amyeroberts The suggestion makes sense, although we also need to define `data` if `return_tensors` is None. I have slightly modified the suggestion.\r\n\r\nRegarding extending this logic to other image processors. I think that the root of the issue is here: https://github.com/huggingface/transformers/blob/4a66c0d... | 1,703 | 1,707 | null | CONTRIBUTOR | null |
# What does this PR do?
Currently, `VideoMAEImageProcessor` is extremely slow. In fact, during inference, it takes longer to preprocess a video than to run the model. After investigating the code, I discovered that this issue can be easily fixed.
Currently, the `preprocess()` function in `VideoMAEImageProcessor... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28221/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28221/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28221",
"html_url": "https://github.com/huggingface/transformers/pull/28221",
"diff_url": "https://github.com/huggingface/transformers/pull/28221.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28221.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28220 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28220/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28220/comments | https://api.github.com/repos/huggingface/transformers/issues/28220/events | https://github.com/huggingface/transformers/pull/28220 | 2,054,790,206 | PR_kwDOCUB6oc5ispRK | 28,220 | remove two deprecated function | {
"login": "statelesshz",
"id": 28150734,
"node_id": "MDQ6VXNlcjI4MTUwNzM0",
"avatar_url": "https://avatars.githubusercontent.com/u/28150734?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/statelesshz",
"html_url": "https://github.com/statelesshz",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"Hi @statelesshz Thanks a lot for this PR! Let's wait a bit the response from #25948 🙏 ",
"@ydshieh \r\nThanks for the notification.\r\n\r\nThis is handled by someone else currently, so I don't hold strong opinion against it.\r\nMy understanding is if there's breaking change they'll likely to pin down version in... | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28220/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28220/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28220",
"html_url": "https://github.com/huggingface/transformers/pull/28220",
"diff_url": "https://github.com/huggingface/transformers/pull/28220.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28220.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28219 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28219/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28219/comments | https://api.github.com/repos/huggingface/transformers/issues/28219/events | https://github.com/huggingface/transformers/pull/28219 | 2,054,714,019 | PR_kwDOCUB6oc5isah- | 28,219 | Fix trainer saving safetensors: metadata is None | {
"login": "hiyouga",
"id": 16256802,
"node_id": "MDQ6VXNlcjE2MjU2ODAy",
"avatar_url": "https://avatars.githubusercontent.com/u/16256802?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hiyouga",
"html_url": "https://github.com/hiyouga",
"followers_url": "https://api.github.com/users/hiyoug... | [] | closed | false | null | [] | [] | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
Fixes https://github.com/hiyouga/LLaMA-Factory/issues/1959
If we use `Trainer` to train a model that does not belong to the `PreTrainedModel` class, such as the `PreTrainedModelwithValuehead` from the TRL library, the trainer will not save the metadata. This leads to errors in reading the ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28219/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28219/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28219",
"html_url": "https://github.com/huggingface/transformers/pull/28219",
"diff_url": "https://github.com/huggingface/transformers/pull/28219.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28219.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28218 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28218/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28218/comments | https://api.github.com/repos/huggingface/transformers/issues/28218/events | https://github.com/huggingface/transformers/issues/28218 | 2,054,646,556 | I_kwDOCUB6oc56d2sc | 28,218 | Tokenizer adds an additional space after the added token | {
"login": "kitkhai",
"id": 71968397,
"node_id": "MDQ6VXNlcjcxOTY4Mzk3",
"avatar_url": "https://avatars.githubusercontent.com/u/71968397?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kitkhai",
"html_url": "https://github.com/kitkhai",
"followers_url": "https://api.github.com/users/kitkha... | [] | open | false | null | [] | [
"Hey! Thanks for raising the issue. This is pretty much a duplicated of #26318 and will be fixed by #27883! \r\nYou can already work around this following the tutorial here: https://github.com/huggingface/tokenizers/pull/1357 ",
"PR Was merged, let me check if this is fixed! ",
"Okay not fixed yet I' ll include... | 1,703 | 1,706 | null | NONE | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: 0.25.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (False)
- Tensorflow ver... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28218/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28218/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28217 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28217/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28217/comments | https://api.github.com/repos/huggingface/transformers/issues/28217/events | https://github.com/huggingface/transformers/issues/28217 | 2,054,557,872 | I_kwDOCUB6oc56dhCw | 28,217 | Huggingface Agents Tutorial has an error when using Huggingface models | {
"login": "mohit-raghavendra",
"id": 42749143,
"node_id": "MDQ6VXNlcjQyNzQ5MTQz",
"avatar_url": "https://avatars.githubusercontent.com/u/42749143?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mohit-raghavendra",
"html_url": "https://github.com/mohit-raghavendra",
"followers_url": "https... | [] | closed | false | null | [] | [
"Hey! I don't have an openAI key, could you try with the latest version of transformers and / or share the exact traceback as where this failed> ",
"I tied running the notebook with the main version of Transformers, with the Huggingface StarCoder model. \r\n\r\nI set the Huggingface token (hf_xyz) as follows:\r\n... | 1,703 | 1,707 | 1,707 | NONE | null | ### System Info
Transformers v4.29.0
### Who can help?
@ArthurZucker
@younesbelkada
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28217/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28217/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28216 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28216/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28216/comments | https://api.github.com/repos/huggingface/transformers/issues/28216/events | https://github.com/huggingface/transformers/pull/28216 | 2,054,515,980 | PR_kwDOCUB6oc5irxrb | 28,216 | Image Feature Extraction pipeline | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [
{
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.githu... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28216). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"We will need to make some changes in \r\n\r\nhttps://github.com/amyeroberts/transf... | 1,703 | 1,707 | 1,707 | COLLABORATOR | null | # What does this PR do?
Adds an ImageFeatureExtractor pipeline, which uses vision models for feature extraction. This is based off the `FeatureExtractionPipeline`, but is compatible with models which use image processors.
```py
from transformers import pipeline
extractor = pipeline(model="google/vit-base-pat... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28216/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28216/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28216",
"html_url": "https://github.com/huggingface/transformers/pull/28216",
"diff_url": "https://github.com/huggingface/transformers/pull/28216.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28216.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28215 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28215/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28215/comments | https://api.github.com/repos/huggingface/transformers/issues/28215/events | https://github.com/huggingface/transformers/issues/28215 | 2,054,492,113 | I_kwDOCUB6oc56dQ_R | 28,215 | causal_mask in GPT2Attention should not be broadcastable across the seq_len | {
"login": "bknyaz",
"id": 3225366,
"node_id": "MDQ6VXNlcjMyMjUzNjY=",
"avatar_url": "https://avatars.githubusercontent.com/u/3225366?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bknyaz",
"html_url": "https://github.com/bknyaz",
"followers_url": "https://api.github.com/users/bknyaz/foll... | [] | open | false | null | [] | [
"cc @ArthurZucker ",
"Hey! The GPT2Attention layer is not part of the public documentation and is not self contained. This is thus expected. You are in luck as #28132 will probably adresse this. "
] | 1,703 | 1,706 | null | NONE | null | ### System Info
Python : 3.8.2
torch : 2.2.0.dev20231207+cu121
transformers : 4.31.0
torchvision : 0.17.0.dev20231207+cu121
cuda version : 12.1
In `transformers.models.gpt2.modeling_gpt2.GPT2Attention`
https://github.com/huggingface/transformers/blob/main/src/transformer... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28215/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28215/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28214 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28214/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28214/comments | https://api.github.com/repos/huggingface/transformers/issues/28214/events | https://github.com/huggingface/transformers/pull/28214 | 2,054,484,317 | PR_kwDOCUB6oc5irq9X | 28,214 | Enable instantiating model with pretrained backbone weights | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28214). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"cc @NielsRogge ",
"As an update - when running slow tests for DETR, the instanti... | 1,703 | 1,706 | 1,706 | COLLABORATOR | null | # What does this PR do?
At the moment, there's two ways backbone weights can be initialized in a model:
* Pretrained weights that are already saved alongside the parent model's weights in a checkpoint
* Randomly initialized from config
However, the main use-case of backbones is to be able to leverage pretraine... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28214/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28214/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28214",
"html_url": "https://github.com/huggingface/transformers/pull/28214",
"diff_url": "https://github.com/huggingface/transformers/pull/28214.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28214.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28213 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28213/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28213/comments | https://api.github.com/repos/huggingface/transformers/issues/28213/events | https://github.com/huggingface/transformers/pull/28213 | 2,054,480,750 | PR_kwDOCUB6oc5irqLN | 28,213 | Remove fast tokenization warning in Data Collators | {
"login": "dbuos",
"id": 68216,
"node_id": "MDQ6VXNlcjY4MjE2",
"avatar_url": "https://avatars.githubusercontent.com/u/68216?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dbuos",
"html_url": "https://github.com/dbuos",
"followers_url": "https://api.github.com/users/dbuos/followers",
"f... | [] | closed | false | null | [] | [
"@amyeroberts"
] | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
Modifies the data collators (DataCollatorWithPadding, DataCollatorForTokenClassification, DataCollatorForSeq2Seq, ...) to pad without warning the user to instead calling tokenizer.__call__ when using fast tokenizers.
The modification in the Data collators:
- we save the state of the token... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28213/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28213/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28213",
"html_url": "https://github.com/huggingface/transformers/pull/28213",
"diff_url": "https://github.com/huggingface/transformers/pull/28213.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28213.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28212 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28212/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28212/comments | https://api.github.com/repos/huggingface/transformers/issues/28212/events | https://github.com/huggingface/transformers/issues/28212 | 2,054,411,482 | I_kwDOCUB6oc56c9Ta | 28,212 | Bark logits_warper(...) 'list' object not calllable while sampling | {
"login": "Colt-Zero",
"id": 5473644,
"node_id": "MDQ6VXNlcjU0NzM2NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5473644?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Colt-Zero",
"html_url": "https://github.com/Colt-Zero",
"followers_url": "https://api.github.com/users/Co... | [] | closed | false | null | [] | [
"I managed to solve my own problem by editing `transformers/generation/utils.py` to reconstruct the logits_warper lists within the function it's called like this:\r\n```\r\ndef beam_sample:\r\n...\r\nlogits_warper = LogitsProcessorList(logits_warper)\r\n...\r\n\r\ndef sample:\r\n...\r\nlogits_warper = LogitsProcess... | 1,703 | 1,708 | 1,708 | NONE | null | ### System Info
transformers 4.36.2, ubuntu 20.04, python 3.10
### Who can help?
@sanchit-gandhi
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or da... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28212/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28212/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28211 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28211/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28211/comments | https://api.github.com/repos/huggingface/transformers/issues/28211/events | https://github.com/huggingface/transformers/pull/28211 | 2,054,322,047 | PR_kwDOCUB6oc5irGlQ | 28,211 | [Phi2] Add support for phi2 models | {
"login": "susnato",
"id": 56069179,
"node_id": "MDQ6VXNlcjU2MDY5MTc5",
"avatar_url": "https://avatars.githubusercontent.com/u/56069179?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/susnato",
"html_url": "https://github.com/susnato",
"followers_url": "https://api.github.com/users/susnat... | [] | closed | false | null | [] | [
"> Hey! Thanks for the PR, alright overall, but let's not add the phi2 changes here since it's not supported!\r\n\r\nHi @ArthurZucker, phi2 has the same modeling code as the library phi model...so I guess it's supported. \r\nI also created [susnato/phi-2](https://huggingface.co/susnato/phi-2) to verify the outputs ... | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28211/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28211/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28211",
"html_url": "https://github.com/huggingface/transformers/pull/28211",
"diff_url": "https://github.com/huggingface/transformers/pull/28211.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28211.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28210 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28210/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28210/comments | https://api.github.com/repos/huggingface/transformers/issues/28210/events | https://github.com/huggingface/transformers/pull/28210 | 2,054,213,644 | PR_kwDOCUB6oc5iqtqJ | 28,210 | add context-free grammar constrained decoding(ebnf interface) into reserach project directory | {
"login": "Saibo-creator",
"id": 53392976,
"node_id": "MDQ6VXNlcjUzMzkyOTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/53392976?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Saibo-creator",
"html_url": "https://github.com/Saibo-creator",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"Hello @gante ,\r\n Thank you for your feedback. I think the first option is better. I will close this PR and keep my repo. \r\n My rationales are:\r\n The grammar constrained generation is not yet complete. It doesn't support all tokenizers and unicode. I will continue to improve it. \r\n As a standalo... | 1,703 | 1,705 | 1,705 | CONTRIBUTOR | null | This PR is a follow-up from PR #27557 where @gante has suggested putting this feature as a research project.
It adds a new feature: Context Free Grammar Constrained Decoding, similarly to what llama-cpp has.
It provides the (almost )same interface as llama-cpp.
Fixes #25778
## Before submitting
- [ ] This ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28210/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28210/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28210",
"html_url": "https://github.com/huggingface/transformers/pull/28210",
"diff_url": "https://github.com/huggingface/transformers/pull/28210.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28210.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28209 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28209/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28209/comments | https://api.github.com/repos/huggingface/transformers/issues/28209/events | https://github.com/huggingface/transformers/pull/28209 | 2,054,146,717 | PR_kwDOCUB6oc5iqePc | 28,209 | update warning for image processor loading | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"cc @NielsRogge ",
"Thanks for opening this @ydshieh! \r\n\r\nAs mentioned in the internal slack channel - I'd rather we had a transition with this: at least two releases instructing the users how to update before downgrading the warnings. Unlike the text_config for CLIP, loading feature extractors for vision is ... | 1,703 | 1,704 | 1,704 | COLLABORATOR | null | # What does this PR do?
Similar to #28108, there is not much we/user can do with the files on the Hub.
For this image processor loading, IMO, the attribute `image_processor_class` / `feature_extractor_class` are super unlikely specified by users (they are created automatically during saving for auto class to work... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28209/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28209/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28209",
"html_url": "https://github.com/huggingface/transformers/pull/28209",
"diff_url": "https://github.com/huggingface/transformers/pull/28209.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28209.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28208 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28208/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28208/comments | https://api.github.com/repos/huggingface/transformers/issues/28208/events | https://github.com/huggingface/transformers/pull/28208 | 2,054,115,320 | PR_kwDOCUB6oc5iqXPA | 28,208 | Convert `torch_dtype` as `str` to actual torch data type (i.e. "float16" …to `torch.float16`) | {
"login": "KossaiSbai",
"id": 35923560,
"node_id": "MDQ6VXNlcjM1OTIzNTYw",
"avatar_url": "https://avatars.githubusercontent.com/u/35923560?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/KossaiSbai",
"html_url": "https://github.com/KossaiSbai",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"@amyeroberts committed your suggestion, thanks for making me understand the difference between `is` and `isinstance`",
"@KossaiSbai There's still some failing tests on the CI run. Rebasing on the most recent version of main should resolve this",
"The docs for this PR live [here](https://moon-ci-docs.huggingfac... | 1,703 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28208/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28208/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28208",
"html_url": "https://github.com/huggingface/transformers/pull/28208",
"diff_url": "https://github.com/huggingface/transformers/pull/28208.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28208.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28207 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28207/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28207/comments | https://api.github.com/repos/huggingface/transformers/issues/28207/events | https://github.com/huggingface/transformers/pull/28207 | 2,054,075,588 | PR_kwDOCUB6oc5iqOfh | 28,207 | Byebye torch 1.10 | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"OK, going to merge. Feel free to drop a more detailed comment on tolerances if it's something needs to be fixed."
] | 1,703 | 1,704 | 1,704 | COLLABORATOR | null | # What does this PR do?
Byebye torch 1.10 ☃️
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28207/reactions",
"total_count": 3,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 3
} | https://api.github.com/repos/huggingface/transformers/issues/28207/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28207",
"html_url": "https://github.com/huggingface/transformers/pull/28207",
"diff_url": "https://github.com/huggingface/transformers/pull/28207.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28207.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28206 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28206/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28206/comments | https://api.github.com/repos/huggingface/transformers/issues/28206/events | https://github.com/huggingface/transformers/issues/28206 | 2,054,033,239 | I_kwDOCUB6oc56bg9X | 28,206 | ValueError: too many values to unpack (expected 2) when Fine-tuning an LLM | {
"login": "0920GX",
"id": 94618005,
"node_id": "U_kgDOBaPBlQ",
"avatar_url": "https://avatars.githubusercontent.com/u/94618005?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/0920GX",
"html_url": "https://github.com/0920GX",
"followers_url": "https://api.github.com/users/0920GX/followers"... | [] | closed | false | null | [] | [
"Hi @0920GX, thanks for raising an issue! \r\n\r\nThis is a question best placed in our [forums](https://discuss.huggingface.co/). We try to reserve the github issues for feature requests and bug reports.",
"This issue has been automatically marked as stale because it has not had recent activity. If you think thi... | 1,703 | 1,707 | 1,707 | NONE | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (False)
- Tensorf... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28206/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28206/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28205 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28205/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28205/comments | https://api.github.com/repos/huggingface/transformers/issues/28205/events | https://github.com/huggingface/transformers/issues/28205 | 2,053,923,404 | I_kwDOCUB6oc56bGJM | 28,205 | loss did not change in expert loss of mixtral model | {
"login": "LinB203",
"id": 62638829,
"node_id": "MDQ6VXNlcjYyNjM4ODI5",
"avatar_url": "https://avatars.githubusercontent.com/u/62638829?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LinB203",
"html_url": "https://github.com/LinB203",
"followers_url": "https://api.github.com/users/LinB20... | [] | closed | false | null | [] | [
"have you fix this problem, i just met the same issue",
"> have you fix this problem, i just met the same issue\r\n\r\nI change to use the deepspeed implementation of moe. I don't know how to fix it in HF. HF's loss is always a constant, while deepspeed's converges to change.",
"@LinB203 could you point me to t... | 1,703 | 1,704 | 1,703 | NONE | null | ### System Info
FROM THIS: https://github.com/huggingface/transformers/issues/28093
If I understand correctly, the loss consists of two parts, the autoregressive categorical loss on the one hand, and balancing the loss of each expert on the other.
I print each of the above two losses before adding up the final one... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28205/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28205/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28204 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28204/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28204/comments | https://api.github.com/repos/huggingface/transformers/issues/28204/events | https://github.com/huggingface/transformers/issues/28204 | 2,053,897,139 | I_kwDOCUB6oc56a_uz | 28,204 | ```RuntimeError: Bad StatusOr access: UNKNOWN: TPU initialization failed: Invalid --2a886c8_slice_builder_worker_addresses specified. Expected 4 worker addresses, got 1.``` when using kaggle tpu | {
"login": "yongjer",
"id": 54315206,
"node_id": "MDQ6VXNlcjU0MzE1MjA2",
"avatar_url": "https://avatars.githubusercontent.com/u/54315206?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yongjer",
"html_url": "https://github.com/yongjer",
"followers_url": "https://api.github.com/users/yongje... | [] | open | false | {
"login": "muellerzr",
"id": 7831895,
"node_id": "MDQ6VXNlcjc4MzE4OTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7831895?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/muellerzr",
"html_url": "https://github.com/muellerzr",
"followers_url": "https://api.github.com/users/mu... | [
{
"login": "muellerzr",
"id": 7831895,
"node_id": "MDQ6VXNlcjc4MzE4OTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7831895?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/muellerzr",
"html_url": "https://github.com/muellerzr",
"followers_url": "https://api... | [
"cc @muellerzr ",
"Hi! Looking at the first 2 lines in the error log (after `The above exception was the direct cause of the following exception:`), it looks like the error occurs at the very early stage, which is relevant with `xla_spawn.py` rather than inside the modeling part.\r\n\r\n```bash\r\n File \"/kaggl... | 1,703 | 1,706 | null | NONE | null | ### System Info
- `transformers` version: 4.37.0.dev0
- Platform: Linux-6.1.58+-x86_64-with-glibc2.36
- Python version: 3.10.13
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: 0.25.0.dev0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (False)
- Tens... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28204/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28204/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28203 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28203/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28203/comments | https://api.github.com/repos/huggingface/transformers/issues/28203/events | https://github.com/huggingface/transformers/pull/28203 | 2,053,810,910 | PR_kwDOCUB6oc5ipUb4 | 28,203 | fix FA2 when using quantization | {
"login": "pacman100",
"id": 13534540,
"node_id": "MDQ6VXNlcjEzNTM0NTQw",
"avatar_url": "https://avatars.githubusercontent.com/u/13534540?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pacman100",
"html_url": "https://github.com/pacman100",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28203). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Hi, this behavior of casting to `float16` is still present in these models - `whis... | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | # What does this PR do?
1. when I use QLoRA+Flash Attention with bf16, I get the following warning of casting to `float16` which is incorrect as it should be casting to bf16:
```bash
The input hidden states seems to be silently casted in float32, this might be related to the fact you have upcasted embedding or layer... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28203/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28203/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28203",
"html_url": "https://github.com/huggingface/transformers/pull/28203",
"diff_url": "https://github.com/huggingface/transformers/pull/28203.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28203.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28202 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28202/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28202/comments | https://api.github.com/repos/huggingface/transformers/issues/28202/events | https://github.com/huggingface/transformers/pull/28202 | 2,053,675,463 | PR_kwDOCUB6oc5io2r6 | 28,202 | Fix the check of models supporting FA/SDPA not run | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"i create the pr(https://github.com/huggingface/transformers/pull/28201) check failed casue by `tests/utils/test_doc_samples.py` faild.\r\nshould i merge this commit, repush pr?",
"@inkinworld Yes, once this PR has been merged into `main` then you can rebase on main or merge in the main branch into yours to inclu... | 1,703 | 1,703 | 1,703 | COLLABORATOR | null | # What does this PR do?
The original check (as test methods) in `tests/utils/test_doc_samples.py` won't run (and didn't run like in #28133) as that file is not impacted by the modeling files (in terms of import relation).
Those 2 checks don't need `torch` at all and could be done in the first stage of check (`che... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28202/reactions",
"total_count": 4,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 3,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28202/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28202",
"html_url": "https://github.com/huggingface/transformers/pull/28202",
"diff_url": "https://github.com/huggingface/transformers/pull/28202.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28202.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28201 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28201/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28201/comments | https://api.github.com/repos/huggingface/transformers/issues/28201/events | https://github.com/huggingface/transformers/pull/28201 | 2,053,671,852 | PR_kwDOCUB6oc5io15K | 28,201 | [BUG] BarkEosPrioritizerLogitsProcessor eos_token_id use list, tensor size mismatch | {
"login": "inkinworld",
"id": 12553724,
"node_id": "MDQ6VXNlcjEyNTUzNzI0",
"avatar_url": "https://avatars.githubusercontent.com/u/12553724?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/inkinworld",
"html_url": "https://github.com/inkinworld",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"(cc @ylacombe )",
"Thanks for fixing @inkinworld !"
] | 1,703 | 1,704 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
Fixes bug about `transformers.generation.logits_process.BarkEosPrioritizerLogitsProcessor`.
when `BarkEosPrioritizerLogitsProcessor` eos_token_id use list, tensor size mismatch.
such as below test case:
```
def test_early_stop_processor_multi_eos(self):
input_ids = None
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28201/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28201/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28201",
"html_url": "https://github.com/huggingface/transformers/pull/28201",
"diff_url": "https://github.com/huggingface/transformers/pull/28201.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28201.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28200 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28200/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28200/comments | https://api.github.com/repos/huggingface/transformers/issues/28200/events | https://github.com/huggingface/transformers/issues/28200 | 2,053,668,491 | I_kwDOCUB6oc56aH6L | 28,200 | RuntimeError: Failed to import transformers.models.mistral.modeling_mistral because of the following error (look up to see its traceback): cannot import name 'is_flash_attn_greater_or_equal_2_10' from 'transformers.utils' (/usr/local/lib/python3.10/dist-packages/transformers/utils/__init__.py) | {
"login": "Jaykumaran",
"id": 60032500,
"node_id": "MDQ6VXNlcjYwMDMyNTAw",
"avatar_url": "https://avatars.githubusercontent.com/u/60032500?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Jaykumaran",
"html_url": "https://github.com/Jaykumaran",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"Hi @Jaykumaran, thanks for raising this issue! \r\n\r\nCould you run the following in the command line to check the version of flash-attn being run in your python environment: \r\n\r\n`python -c \"import flash_attn; from transformers.utils.import_utils import is_flash_attn_greater_or_equal_2_10; print(flash_attn._... | 1,703 | 1,703 | 1,703 | NONE | null | ### System Info
# !pip install trl transformers==4.35.2 accelerate peft==0.6.2 -Uqqq
!pip install trl transformers accelerate peft==0.6.2 -Uqqq
!pip install datasets bitsandbytes einops wandb -Uqqq
!pip install flash-attn --no-build-isolation -Uqq
### Who can help?
_No response_
### Information
- [ ] The offici... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28200/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28200/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28199 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28199/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28199/comments | https://api.github.com/repos/huggingface/transformers/issues/28199/events | https://github.com/huggingface/transformers/pull/28199 | 2,053,656,288 | PR_kwDOCUB6oc5ioyeT | 28,199 | Autocast | {
"login": "jiqing-feng",
"id": 107918818,
"node_id": "U_kgDOBm614g",
"avatar_url": "https://avatars.githubusercontent.com/u/107918818?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jiqing-feng",
"html_url": "https://github.com/jiqing-feng",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Hi @jiqing-feng, thanks for opening a PR and contributing to the library! Let us know when it's ready for final review. \r\n\r\nCould you provide some more context on what this addresses and how this should be used - ideally with an example snippet? I'm assuming to enable FA2?\r\n\r\nAs it's already possible to pa... | 1,703 | 1,705 | 1,705 | CONTRIBUTOR | null | Enable autocast in the pipeline.
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28199/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28199/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28199",
"html_url": "https://github.com/huggingface/transformers/pull/28199",
"diff_url": "https://github.com/huggingface/transformers/pull/28199.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28199.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28198 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28198/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28198/comments | https://api.github.com/repos/huggingface/transformers/issues/28198/events | https://github.com/huggingface/transformers/pull/28198 | 2,053,617,836 | PR_kwDOCUB6oc5ioqFd | 28,198 | Update `docs/source/en/perf_infer_gpu_one.md` | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [] | 1,703 | 1,703 | 1,703 | COLLABORATOR | null | # What does this PR do?
Update `docs/source/en/perf_infer_gpu_one.md` to fix
> FAILED tests/utils/test_doc_samples.py::TestDocLists::test_sdpa_support_list - ValueError: mixtral should be in listed in the SDPA documentation but is not. Please update the documentation. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28198/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28198/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28198",
"html_url": "https://github.com/huggingface/transformers/pull/28198",
"diff_url": "https://github.com/huggingface/transformers/pull/28198.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28198.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28197 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28197/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28197/comments | https://api.github.com/repos/huggingface/transformers/issues/28197/events | https://github.com/huggingface/transformers/issues/28197 | 2,053,583,464 | I_kwDOCUB6oc56ZzJo | 28,197 | LLaVA: index error when computing extended_attention_mask | {
"login": "TideDra",
"id": 92413813,
"node_id": "U_kgDOBYIfdQ",
"avatar_url": "https://avatars.githubusercontent.com/u/92413813?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/TideDra",
"html_url": "https://github.com/TideDra",
"followers_url": "https://api.github.com/users/TideDra/follow... | [] | closed | false | null | [] | [
"Hi @TideDra, thanks for reporting this! \r\n\r\nThere's an ongoing PR which aims to address this issue: #28032 \r\n\r\ncc @younesbelkada for reference",
"Thanks! Yes, I second what @amyeroberts said, I will put that PR as high prio and merge it asap"
] | 1,703 | 1,703 | 1,703 | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-5.15.0-1042-azure-x86_64-with-glibc2.35
- Python version: 3.10.13
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: 0.21.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (True)
- Tenso... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28197/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28197/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28196 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28196/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28196/comments | https://api.github.com/repos/huggingface/transformers/issues/28196/events | https://github.com/huggingface/transformers/pull/28196 | 2,053,577,492 | PR_kwDOCUB6oc5iohTk | 28,196 | Add CogVLM (cleaner) | {
"login": "NielsRogge",
"id": 48327001,
"node_id": "MDQ6VXNlcjQ4MzI3MDAx",
"avatar_url": "https://avatars.githubusercontent.com/u/48327001?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NielsRogge",
"html_url": "https://github.com/NielsRogge",
"followers_url": "https://api.github.com/use... | [] | open | false | null | [] | [
"I have a branch [add_cogvlm_cleaner_address_comments](https://github.com/NielsRogge/transformers/tree/add_cogvlm_cleaner_address_comments) which I can merge once I can verify the conversion",
"Thanks for your review, so 3 comments are about adding a `text_config` to `CogvlmConfig` and leverage `AutoModelForCausa... | 1,703 | 1,708 | null | CONTRIBUTOR | null | # What does this PR do?
This PR adds CogVLM, in a cleaner way. Follow-up of #27718. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28196/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28196/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28196",
"html_url": "https://github.com/huggingface/transformers/pull/28196",
"diff_url": "https://github.com/huggingface/transformers/pull/28196.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28196.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28195 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28195/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28195/comments | https://api.github.com/repos/huggingface/transformers/issues/28195/events | https://github.com/huggingface/transformers/pull/28195 | 2,053,571,469 | PR_kwDOCUB6oc5iogAr | 28,195 | Drop `feature_extractor_type` when loading an image processor file | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"failure is also on `main`.",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28195). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,703 | 1,703 | 1,703 | COLLABORATOR | null | # What does this PR do?
`preprocessor_config.json` created in old days like [this](https://huggingface.co/openai/clip-vit-large-patch14/blob/main/preprocessor_config.json) has, for example, `"feature_extractor_type": "CLIPFeatureExtractor",` in it. If that file is for an image processor, during the loading (in `__in... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28195/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28195/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28195",
"html_url": "https://github.com/huggingface/transformers/pull/28195",
"diff_url": "https://github.com/huggingface/transformers/pull/28195.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28195.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28194 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28194/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28194/comments | https://api.github.com/repos/huggingface/transformers/issues/28194/events | https://github.com/huggingface/transformers/issues/28194 | 2,053,555,305 | I_kwDOCUB6oc56ZsRp | 28,194 | Can you please provide the longformer version of the torch to tf file? | {
"login": "Struggle-lsl",
"id": 109401083,
"node_id": "U_kgDOBoVT-w",
"avatar_url": "https://avatars.githubusercontent.com/u/109401083?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Struggle-lsl",
"html_url": "https://github.com/Struggle-lsl",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"Hi @lsl200032, \r\n\r\nThere isn't a specific file for Longformer to convert from torch to TF weights. The conversion happens when using `from_pt` in the `from_pretrained` call: \r\n\r\n```\r\nfrom transformers import TFLongformerModel \r\n\r\n# Loads the pytorch weights and converts them to the equivalent TF form... | 1,703 | 1,706 | 1,706 | NONE | null | ### Feature request
Can you please provide the longformer version of the torch to tf file?
### Motivation
Can you please provide the longformer version of the torch to tf file?
### Your contribution
Can you please provide the longformer version of the torch to tf file? | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28194/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28194/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28193 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28193/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28193/comments | https://api.github.com/repos/huggingface/transformers/issues/28193/events | https://github.com/huggingface/transformers/issues/28193 | 2,053,500,334 | I_kwDOCUB6oc56Ze2u | 28,193 | ValueError: Target module WQLinear_GEMM is not supported. Currently, only `torch.nn.Linear` and `Conv1D` are supported.- AWQ Quantisation Issues | {
"login": "Vasanth03",
"id": 59615743,
"node_id": "MDQ6VXNlcjU5NjE1NzQz",
"avatar_url": "https://avatars.githubusercontent.com/u/59615743?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Vasanth03",
"html_url": "https://github.com/Vasanth03",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Hi @Vasanth03, AutoAWQ is not compatible with training yet. It will be in the future though.",
"Thank you so much @casper-hansen. And I look forward to its compatibility in the future."
] | 1,703 | 1,703 | 1,703 | NONE | null | Hi @casper-hansen
-> I am trying to train the AWQ quantised model using hugging face trainer.
While using PEFT (LoRA adaptor) the following error pops up.
-> This is the v... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28193/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28193/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28192 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28192/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28192/comments | https://api.github.com/repos/huggingface/transformers/issues/28192/events | https://github.com/huggingface/transformers/pull/28192 | 2,053,434,683 | PR_kwDOCUB6oc5ioCSy | 28,192 | don't initialize the output embeddings if we're going to tie them to input embeddings | {
"login": "tom-p-reichel",
"id": 43631024,
"node_id": "MDQ6VXNlcjQzNjMxMDI0",
"avatar_url": "https://avatars.githubusercontent.com/u/43631024?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tom-p-reichel",
"html_url": "https://github.com/tom-p-reichel",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"Hi @tom-p-reichel - thanks for opening this PR! \r\n\r\nVery nice if there's such a big speedup 🔥 cc @sanchit-gandhi \r\n\r\nCould you share some snippets on how this was tested - speed and outputs? ",
"@amyeroberts Sure. Here's a minimal example:\r\n`python -m timeit -s \"from transformers import pipeline; im... | 1,703 | 1,707 | 1,706 | CONTRIBUTOR | null |
# What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28192/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28192/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28192",
"html_url": "https://github.com/huggingface/transformers/pull/28192",
"diff_url": "https://github.com/huggingface/transformers/pull/28192.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28192.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28191 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28191/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28191/comments | https://api.github.com/repos/huggingface/transformers/issues/28191/events | https://github.com/huggingface/transformers/issues/28191 | 2,053,399,431 | I_kwDOCUB6oc56ZGOH | 28,191 | ImportError: Using the Trainer with PyTorch requires accelerate>=0.20.1 | {
"login": "Ompramod9921",
"id": 86967995,
"node_id": "MDQ6VXNlcjg2OTY3OTk1",
"avatar_url": "https://avatars.githubusercontent.com/u/86967995?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ompramod9921",
"html_url": "https://github.com/Ompramod9921",
"followers_url": "https://api.github.c... | [
{
"id": 5616426447,
"node_id": "LA_kwDOCUB6oc8AAAABTsPdzw",
"url": "https://api.github.com/repos/huggingface/transformers/labels/solved",
"name": "solved",
"color": "B1D6DC",
"default": false,
"description": ""
}
] | closed | false | null | [] | [
"I see that you are using the accelerated runtime from Google Colaboratory. Have you tried restarting the session after installing the accelerate package? I know, it is obvious, but just to be completely foolproof.",
"I encountered the same issue. When I executed the command !pip install accelerate -U and then we... | 1,703 | 1,708 | 1,708 | NONE | null | ### System Info
@muellerzr and @pacman100
I'm trying to use the Trainer with PyTorch in my Python project, but I'm encountering an ImportError stating that accelerate>=0.20.1 is required. Despite having installed the accelerate package, I'm still getting this error.
Here's the error message I'm seeing:
ImportEr... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28191/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28191/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28190 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28190/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28190/comments | https://api.github.com/repos/huggingface/transformers/issues/28190/events | https://github.com/huggingface/transformers/issues/28190 | 2,053,318,726 | I_kwDOCUB6oc56YyhG | 28,190 | torch.compile() silently fails when used on HuggingFace pipeline inference code | {
"login": "rosario-purple",
"id": 123594463,
"node_id": "U_kgDOB13m3w",
"avatar_url": "https://avatars.githubusercontent.com/u/123594463?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rosario-purple",
"html_url": "https://github.com/rosario-purple",
"followers_url": "https://api.github.c... | [
{
"id": 2796628563,
"node_id": "MDU6TGFiZWwyNzk2NjI4NTYz",
"url": "https://api.github.com/repos/huggingface/transformers/labels/WIP",
"name": "WIP",
"color": "234C99",
"default": false,
"description": "Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in pro... | closed | false | null | [] | [
"No this can't work yet at we do not have a static KV cache. #27931 will fix this",
"While working on benchmarking and improving our model's performance I experienced the same issue with `torch.compile`. It does not bring any speed up at all and can confirm the issue. \r\n\r\n@ArthurZucker Looking forward to havi... | 1,703 | 1,707 | 1,707 | NONE | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.35
- Python version: 3.10.13
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.0
- Accelerate version: 0.25.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.1+cu121 (True)
- Tenso... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28190/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28190/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28189 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28189/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28189/comments | https://api.github.com/repos/huggingface/transformers/issues/28189/events | https://github.com/huggingface/transformers/issues/28189 | 2,053,227,321 | I_kwDOCUB6oc56YcM5 | 28,189 | Text-to-speech data collator exhibits weird batching behavior with Seq2SeqTrainer | {
"login": "GinUTE",
"id": 91470404,
"node_id": "MDQ6VXNlcjkxNDcwNDA0",
"avatar_url": "https://avatars.githubusercontent.com/u/91470404?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/GinUTE",
"html_url": "https://github.com/GinUTE",
"followers_url": "https://api.github.com/users/GinUTE/fo... | [] | closed | false | null | [] | [
"cc @sanchit-gandhi @ylacombe ",
"Hello again, I wish to provide more information.\r\n\r\nFirst, I followed the stack trace and landed on this specific line throwing the error: \r\n```\r\n[/usr/local/lib/python3.10/dist-packages/transformers/models/speecht5/modeling_speecht5.py](https://localhost:8080/#) in forw... | 1,703 | 1,704 | 1,703 | NONE | null | ### System Info
- transformers version: 4.37.0.dev0
- platform: Linux-6.1.58+-x86_64-with-glibc2.35 (Colaboratory free accelerated runtime)
- python version: 3.10.12
### Who can help?
_No response_
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] A... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28189/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28189/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28188 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28188/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28188/comments | https://api.github.com/repos/huggingface/transformers/issues/28188/events | https://github.com/huggingface/transformers/issues/28188 | 2,052,983,589 | I_kwDOCUB6oc56Xgsl | 28,188 | RuntimeError: FlashAttention only supports Ampere GPUs or newer. | {
"login": "bilalghanem",
"id": 47889448,
"node_id": "MDQ6VXNlcjQ3ODg5NDQ4",
"avatar_url": "https://avatars.githubusercontent.com/u/47889448?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bilalghanem",
"html_url": "https://github.com/bilalghanem",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"I got the same error on kaggle's notebook.",
"Hey! Not sure I understand the issue? \r\n> RuntimeError: FlashAttention only supports Ampere GPUs or newer. \r\n\r\nMeans that flash attention implementation that you install does not support your GPU yet! (either too old or too new). \r\nI would rather look into th... | 1,703 | 1,706 | 1,704 | NONE | null | ### System Info
I am trying to run the following code:
```
import torch
from transformers import AutoModelForCausalLM, AutoTokenizer
# Configs
device = "cuda:7"
model_name = "openchat/openchat_3.5"
model = AutoModelForCausalLM.from_pretrained(model_name, device_map=device, load_in_4bit=True, bnb_4bit_quant_... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28188/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28188/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28187 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28187/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28187/comments | https://api.github.com/repos/huggingface/transformers/issues/28187/events | https://github.com/huggingface/transformers/pull/28187 | 2,052,849,458 | PR_kwDOCUB6oc5imDdC | 28,187 | Update YOLOS slow test values | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [] | 1,703 | 1,703 | 1,703 | COLLABORATOR | null | # What does this PR do?
Updates the test values for YOLOS after the merging in of #27663 to resolve failing slow model tests on nightly.
Some small value changes are expected because of the change of output image size from the image processor.
As a sense check, plotted the output of the object detection mode... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28187/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28187/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28187",
"html_url": "https://github.com/huggingface/transformers/pull/28187",
"diff_url": "https://github.com/huggingface/transformers/pull/28187.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28187.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28186 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28186/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28186/comments | https://api.github.com/repos/huggingface/transformers/issues/28186/events | https://github.com/huggingface/transformers/pull/28186 | 2,052,807,186 | PR_kwDOCUB6oc5il6Gk | 28,186 | Fix slow backbone tests - out_indices must match stage name ordering | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28186). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,703 | 1,703 | 1,703 | COLLABORATOR | null | # What does this PR do?
Fixes slow autobackbone tests failing on nightly after #27606
#27606 enforces the out_indices and out_features to be in the same order as the stage names. This ensures backbone selects the correct features in its forward pass. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28186/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28186/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28186",
"html_url": "https://github.com/huggingface/transformers/pull/28186",
"diff_url": "https://github.com/huggingface/transformers/pull/28186.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28186.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28185 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28185/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28185/comments | https://api.github.com/repos/huggingface/transformers/issues/28185/events | https://github.com/huggingface/transformers/pull/28185 | 2,052,665,966 | PR_kwDOCUB6oc5ila8v | 28,185 | Cache: dynamic cache with cross attention and UMT5 `Cache` support | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28185). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,703 | 1,706 | null | MEMBER | null | # What does this PR do?
#28065 was becoming messy due to all Bart "copied from" dependencies, so this PR is a tiny version of it.
This PR:
1. Introduces `DynamicCacheWithCrossAttention`, which expands `DynamicCache` [cache object equivalent to the previous `past_key_values` input/output] with the ability to hold... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28185/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28185/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28185",
"html_url": "https://github.com/huggingface/transformers/pull/28185",
"diff_url": "https://github.com/huggingface/transformers/pull/28185.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28185.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28184 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28184/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28184/comments | https://api.github.com/repos/huggingface/transformers/issues/28184/events | https://github.com/huggingface/transformers/issues/28184 | 2,052,603,134 | I_kwDOCUB6oc56WDz- | 28,184 | LLaVa Left Padding Got Weird Results | {
"login": "SeungyounShin",
"id": 20262536,
"node_id": "MDQ6VXNlcjIwMjYyNTM2",
"avatar_url": "https://avatars.githubusercontent.com/u/20262536?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SeungyounShin",
"html_url": "https://github.com/SeungyounShin",
"followers_url": "https://api.githu... | [] | open | false | null | [] | [
"cc @younesbelkada @ArthurZucker ",
"hi @SeungyounShin \r\nWhat transformers version are you using?\r\nin the first input `prompt1 = \"<image>\\n<image>\\nUSER: What's the the difference of two images?\\nASSISTANT:\"` you passed two images; note multi-image query is not well supported for Llava-like models as the... | 1,703 | 1,707 | null | NONE | null | ### System Info
Reproduce :
```python
from PIL import Image
import requests
from transformers import AutoProcessor, LlavaForConditionalGeneration
model = LlavaForConditionalGeneration.from_pretrained("llava-hf/llava-1.5-7b-hf").to(
"cuda"
)
processor = AutoProcessor.from_pretrained("llava-hf/llava-1.5... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28184/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28184/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28183 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28183/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28183/comments | https://api.github.com/repos/huggingface/transformers/issues/28183/events | https://github.com/huggingface/transformers/issues/28183 | 2,052,577,262 | I_kwDOCUB6oc56V9fu | 28,183 | Bug in new version transformers 4.34.0-4.36.2 | {
"login": "JAX627",
"id": 113168400,
"node_id": "U_kgDOBr7QEA",
"avatar_url": "https://avatars.githubusercontent.com/u/113168400?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JAX627",
"html_url": "https://github.com/JAX627",
"followers_url": "https://api.github.com/users/JAX627/follower... | [] | closed | false | null | [] | [
"Hi @JAX627, thanks for opening an issue! \r\n\r\nBy default, a `pytorch_model.bin` file will no longer be saved out as `safetensors` is now the default format. To save a pytorch file out instead, you can explicitly use the `safe_serialization` argument when calling `save_pretrained`:\r\n\r\n```py\r\nmodel.save_pre... | 1,703 | 1,707 | 1,707 | NONE | null | ### System Info
ver: transformers 4.34.0-4.36.2
problem: finetune chatglm3 model, finetune.py don't generate pytorch_model.bin file in output, as point out in https://github.com/THUDM/ChatGLM3/discussions/253#discussioncomment-7837093
it seems like problems in modeling_utils.py file, and it can be solved by pip inst... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28183/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28183/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28182 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28182/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28182/comments | https://api.github.com/repos/huggingface/transformers/issues/28182/events | https://github.com/huggingface/transformers/pull/28182 | 2,052,427,965 | PR_kwDOCUB6oc5ikmUG | 28,182 | [`Docs`] Add 4-bit serialization docs | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28182). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | # What does this PR do?
Follow up work from: https://github.com/huggingface/transformers/pull/26037
Adds few lines in the documentation about serializing 4-bit models on the Hub
cc @amyeroberts @stevhliu
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28182/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28182/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28182",
"html_url": "https://github.com/huggingface/transformers/pull/28182",
"diff_url": "https://github.com/huggingface/transformers/pull/28182.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28182.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28181 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28181/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28181/comments | https://api.github.com/repos/huggingface/transformers/issues/28181/events | https://github.com/huggingface/transformers/pull/28181 | 2,052,412,895 | PR_kwDOCUB6oc5iki_r | 28,181 | update the logger message with accordant weights_file_name | {
"login": "izyForever",
"id": 43177954,
"node_id": "MDQ6VXNlcjQzMTc3OTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/43177954?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/izyForever",
"html_url": "https://github.com/izyForever",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"@amyeroberts \r\n\r\nI can't figure out why I failed the tests_torch for I only changed the logger info.😖 \r\n\r\n\r\n",
"> Thanks for updating this and contributing to improving the code!\... | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | # What does this PR do?
Update the logger message with accordant weights_file_name.
Fixes # (issue)
https://github.com/huggingface/transformers/issues/28076
@amyeroberts
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28181/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28181/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28181",
"html_url": "https://github.com/huggingface/transformers/pull/28181",
"diff_url": "https://github.com/huggingface/transformers/pull/28181.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28181.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28180 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28180/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28180/comments | https://api.github.com/repos/huggingface/transformers/issues/28180/events | https://github.com/huggingface/transformers/issues/28180 | 2,052,332,919 | I_kwDOCUB6oc56VB13 | 28,180 | Verify interpolation of image processors | {
"login": "NielsRogge",
"id": 48327001,
"node_id": "MDQ6VXNlcjQ4MzI3MDAx",
"avatar_url": "https://avatars.githubusercontent.com/u/48327001?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NielsRogge",
"html_url": "https://github.com/NielsRogge",
"followers_url": "https://api.github.com/use... | [
{
"id": 1990918270,
"node_id": "MDU6TGFiZWwxOTkwOTE4Mjcw",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20First%20Issue",
"name": "Good First Issue",
"color": "bbf794",
"default": false,
"description": ""
}
] | open | false | null | [] | [
"@NielsRogge Thanks for opening the issue! \r\n\r\nIt's fine to open up to the community but you'll need to add a checklist of the image processors so it's clear who is working on what and what's done as well as ideally some instructions on what it means for each one to be \"done\" e.g. making sure to run slow test... | 1,703 | 1,707 | null | CONTRIBUTOR | null | ### Feature request
As pointed out in https://github.com/huggingface/transformers/pull/27742, some image processors might need a correction on the default interpolation method being used (resampling in Pillow). We could check this on a per-model basis.
### Motivation
Interpolation methods have a slight (often ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28180/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28180/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28179 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28179/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28179/comments | https://api.github.com/repos/huggingface/transformers/issues/28179/events | https://github.com/huggingface/transformers/issues/28179 | 2,052,091,367 | I_kwDOCUB6oc56UG3n | 28,179 | How to fine tune facebook/esm2_t33_650M_UR50D | {
"login": "Admire7494",
"id": 98265794,
"node_id": "U_kgDOBdtqwg",
"avatar_url": "https://avatars.githubusercontent.com/u/98265794?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Admire7494",
"html_url": "https://github.com/Admire7494",
"followers_url": "https://api.github.com/users/Admir... | [] | closed | false | null | [] | [
"Hi @Admire7494, thanks for raising an issue! \r\n\r\nThis is a question best placed in our [forums](https://discuss.huggingface.co/). We try to reserve the github issues for feature requests and bug reports.",
"This issue has been automatically marked as stale because it has not had recent activity. If you think... | 1,703 | 1,706 | 1,706 | NONE | null | ### System Info
How to fine tune facebook/esm2_t33_650M_UR50D？It's too big and the model.half() couldn't work. Besids, i always met the error : CUDA error: CUBLAS_STATUS_INTERNAL_ERROR when calling `cublasSgemm( handle, opa, opb, m, n, k, &alpha, a, lda, b, ldb, &beta, c, ldc). Is it possible that the model in the hug... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28179/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28179/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28178 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28178/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28178/comments | https://api.github.com/repos/huggingface/transformers/issues/28178/events | https://github.com/huggingface/transformers/issues/28178 | 2,052,081,383 | I_kwDOCUB6oc56UEbn | 28,178 | Call `.destroy()` on `DeepSpeedEngine` somewhere post training | {
"login": "chiragjn",
"id": 10295418,
"node_id": "MDQ6VXNlcjEwMjk1NDE4",
"avatar_url": "https://avatars.githubusercontent.com/u/10295418?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chiragjn",
"html_url": "https://github.com/chiragjn",
"followers_url": "https://api.github.com/users/chi... | [
{
"id": 2155169140,
"node_id": "MDU6TGFiZWwyMTU1MTY5MTQw",
"url": "https://api.github.com/repos/huggingface/transformers/labels/trainer",
"name": "trainer",
"color": "2ef289",
"default": false,
"description": ""
},
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
... | open | false | null | [] | [
"Gentle ping @pacman100 for your thoughts on this feature addition"
] | 1,703 | 1,708 | null | NONE | null | ### System Info
transformers==4.36.2
accelerate==0.25.0
deepspeed==0.12.5
### Who can help?
I was using deepspeed stage 2 with Trainer and accelerate and at the end of training when the Trainer has been garbage collected, I noticed my GPU VRAM was not clearing even after aggressively calling `gc.collect()` and `to... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28178/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28178/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28177 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28177/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28177/comments | https://api.github.com/repos/huggingface/transformers/issues/28177/events | https://github.com/huggingface/transformers/issues/28177 | 2,052,062,336 | I_kwDOCUB6oc56T_yA | 28,177 | AttributeError: Can't get attribute 'SiLUActivation' on <module 'transformers.activations' | {
"login": "Lokesh-Jatangi",
"id": 142205264,
"node_id": "U_kgDOCHnhUA",
"avatar_url": "https://avatars.githubusercontent.com/u/142205264?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Lokesh-Jatangi",
"html_url": "https://github.com/Lokesh-Jatangi",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"Hi @Lokesh-Jatangi, thanks for raising this issue! \r\n\r\nIs there a reason you're using `torch.load` here? The officially supported way to load checkpoints is through the `from_pretrained` method. ",
"The checkpoint stores a pruned model whose structure and weights are different and hence I couldnot use `from_... | 1,703 | 1,705 | 1,705 | NONE | null | ### System Info
System info -
- `transformers` version: 4.36.2
- Platform: Linux-5.10.0-26-cloud-amd64-x86_64-with-glibc2.31
- Python version: 3.10.13
- Huggingface_hub version: 0.20.1
- Safetensors version: 0.4.0
- Accelerate version: 0.24.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.1... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28177/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28177/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28176 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28176/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28176/comments | https://api.github.com/repos/huggingface/transformers/issues/28176/events | https://github.com/huggingface/transformers/issues/28176 | 2,051,950,925 | I_kwDOCUB6oc56TklN | 28,176 | Swinv2config isnt working with depth estimator | {
"login": "hackkhai",
"id": 51231270,
"node_id": "MDQ6VXNlcjUxMjMxMjcw",
"avatar_url": "https://avatars.githubusercontent.com/u/51231270?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hackkhai",
"html_url": "https://github.com/hackkhai",
"followers_url": "https://api.github.com/users/hac... | [] | closed | false | null | [] | [
"@amyeroberts would you be able to merge #27742? Will resolve this PR ;) \r\n\r\nAlso make sure to use Transformers from source as the PR won't be included until the next release: \r\n`pip install --upgrade git+https://github.com/huggingface/transformers.git`",
"This issue has been automatically marked as stale b... | 1,703 | 1,706 | 1,706 | NONE | null | ### System Info
ValueError: Unrecognized configuration class <class 'transformers.models.swinv2.configuration_swinv2.Swinv2Config'> for this kind of AutoModel: AutoBackbone.
Model type should be one of BeitConfig, BitConfig, ConvNextConfig, ConvNextV2Config, DinatConfig, Dinov2Config, FocalNetConfig, MaskFormerSwin... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28176/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28176/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28175 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28175/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28175/comments | https://api.github.com/repos/huggingface/transformers/issues/28175/events | https://github.com/huggingface/transformers/issues/28175 | 2,051,940,970 | I_kwDOCUB6oc56TiJq | 28,175 | ValueError: LlavaForConditionalGeneration does not support an attention implementation through torch.nn.functional.scaled_dot_product_attention yet. Please open an issue on GitHub to request support for this architecture: https://github.com/huggingface/transformers/issues/new | {
"login": "1106280506Hx",
"id": 103016865,
"node_id": "U_kgDOBiPpoQ",
"avatar_url": "https://avatars.githubusercontent.com/u/103016865?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/1106280506Hx",
"html_url": "https://github.com/1106280506Hx",
"followers_url": "https://api.github.com/use... | [
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request",
"name": "Feature request",
"color": "FBCA04",
"default": false,
"description": "Request for a new feature"
},
{
"id": 6349658421,
... | open | false | null | [] | [
"cc @younesbelkada for reference ",
"can you tell me how to sovle it?",
"Hi @1106280506Hx, \r\n\r\nAs the error suggests, SDPA isn't supported in Llava on the version of transformers being run. However, just looking it up, #28107 was merged in a few days ago. You should be able to resolve this by running the de... | 1,703 | 1,703 | null | NONE | null | processor = AutoProcessor.from_pretrained("/gemini/data-2/data/llava")
model = AutoModelForPreTraining.from_pretrained("/gemini/data-2/data/llava",load_in_4bit=True,bnb_4bit_compute_dtype=torch.float16,low_cpu_mem_usage=True,attn_implementation="sdpa").to("cuda")
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28175/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28175/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28174 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28174/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28174/comments | https://api.github.com/repos/huggingface/transformers/issues/28174/events | https://github.com/huggingface/transformers/issues/28174 | 2,051,602,981 | I_kwDOCUB6oc56SPol | 28,174 | Problems when converting fairseq model to hf format | {
"login": "upskyy",
"id": 54731898,
"node_id": "MDQ6VXNlcjU0NzMxODk4",
"avatar_url": "https://avatars.githubusercontent.com/u/54731898?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/upskyy",
"html_url": "https://github.com/upskyy",
"followers_url": "https://api.github.com/users/upskyy/fo... | [] | closed | false | null | [] | [
"cc @ylacombe as well for reference ",
"Hey @upskyy, thanks for opening this issue, this is very clear and in line with #28165 which converts a model from [seamless communication](https://github.com/facebookresearch/seamless_communication) and fairseq2.\r\n\r\nWe are supposed to have [integration tests](https://g... | 1,703 | 1,707 | 1,707 | NONE | null | ### System Info
- `transformers` version: 4.37.0.dev0
- Platform: Linux-5.15.0-88-generic-x86_64-with-glibc2.35
- Python version: 3.10.8
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.3.2
- Accelerate version: 0.21.0
- Accelerate config: not found
- PyTorch version (GPU?): 1.13.1 (True)
- Tens... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28174/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28174/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28173 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28173/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28173/comments | https://api.github.com/repos/huggingface/transformers/issues/28173/events | https://github.com/huggingface/transformers/issues/28173 | 2,051,315,575 | I_kwDOCUB6oc56RJd3 | 28,173 | VitsTokenizer decode without special tokens produces odd results | {
"login": "xenova",
"id": 26504141,
"node_id": "MDQ6VXNlcjI2NTA0MTQx",
"avatar_url": "https://avatars.githubusercontent.com/u/26504141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xenova",
"html_url": "https://github.com/xenova",
"followers_url": "https://api.github.com/users/xenova/fo... | [] | closed | false | null | [] | [
"I understand users won't typically use the decode method, but it's still quite odd behaviour 😅 ",
"👿 I'm using my joker for this on, it's on the audio team 🤭 ",
"Here's the culprit:\r\nhttps://github.com/huggingface/transformers/blob/1d7773594754457ed4a79cf6d98bcaabea5bff51/src/transformers/models/vits/toke... | 1,703 | 1,707 | 1,707 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (False)
- Tensorflow... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28173/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 1,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28173/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28172 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28172/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28172/comments | https://api.github.com/repos/huggingface/transformers/issues/28172/events | https://github.com/huggingface/transformers/pull/28172 | 2,051,285,377 | PR_kwDOCUB6oc5igryw | 28,172 | [docs] Sort es/toctree.yml like en/toctree.yml | {
"login": "aaronjimv",
"id": 67152883,
"node_id": "MDQ6VXNlcjY3MTUyODgz",
"avatar_url": "https://avatars.githubusercontent.com/u/67152883?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aaronjimv",
"html_url": "https://github.com/aaronjimv",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"I was doing a translation of `performance.md`, whose section is not in the Spanish documentation, and I got the impression that the file `es/_toctree.yml` is not aligned with `en/_toctree.yml`. I am open to any comments.",
"Hi the `es/_toctree` should be aligned with the English version, so please feel free to r... | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28172/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28172/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28172",
"html_url": "https://github.com/huggingface/transformers/pull/28172",
"diff_url": "https://github.com/huggingface/transformers/pull/28172.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28172.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28171 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28171/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28171/comments | https://api.github.com/repos/huggingface/transformers/issues/28171/events | https://github.com/huggingface/transformers/pull/28171 | 2,051,234,051 | PR_kwDOCUB6oc5iggiH | 28,171 | Bug: `training_args.py` fix missing import with accelerate with version `accelerate==0.20.1` | {
"login": "michaelfeil",
"id": 63565275,
"node_id": "MDQ6VXNlcjYzNTY1Mjc1",
"avatar_url": "https://avatars.githubusercontent.com/u/63565275?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michaelfeil",
"html_url": "https://github.com/michaelfeil",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"Hi @michaelfeil, thanks for opening this PR and writing the detailed description! \r\n\r\nIndeed, there is a bug where `is_accelerate_available()` doesn't correctly evaluate to `True` if `accelerate==0.20.1`. \r\n\r\nHowever, the [required version for transformers](https://github.com/huggingface/transformers/blob/... | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28171/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28171/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28171",
"html_url": "https://github.com/huggingface/transformers/pull/28171",
"diff_url": "https://github.com/huggingface/transformers/pull/28171.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28171.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28170 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28170/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28170/comments | https://api.github.com/repos/huggingface/transformers/issues/28170/events | https://github.com/huggingface/transformers/issues/28170 | 2,051,205,921 | I_kwDOCUB6oc56Qush | 28,170 | Error while importing the transformers | {
"login": "iamshreeram",
"id": 7752805,
"node_id": "MDQ6VXNlcjc3NTI4MDU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7752805?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/iamshreeram",
"html_url": "https://github.com/iamshreeram",
"followers_url": "https://api.github.com/us... | [] | closed | false | null | [] | [
"@sanchit-gandhi @ylacombe same issue as reported in #28162 \r\n\r\n",
"@amyeroberts , Thank you for investigating. Everything is functioning properly after the installation of the stable version of transformers (`4.36.2`)."
] | 1,703 | 1,703 | 1,703 | NONE | null | ### System Info
**Transformers Version** : 4.36.0.dev0
**Platform** : Mac OS
**Python** : 3.9.18
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
-... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28170/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28170/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28169 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28169/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28169/comments | https://api.github.com/repos/huggingface/transformers/issues/28169/events | https://github.com/huggingface/transformers/pull/28169 | 2,051,138,169 | PR_kwDOCUB6oc5igLsF | 28,169 | disable test_retain_grad_hidden_states_attentions on SeamlessM4TModelWithTextInputTest | {
"login": "dwyatte",
"id": 2512762,
"node_id": "MDQ6VXNlcjI1MTI3NjI=",
"avatar_url": "https://avatars.githubusercontent.com/u/2512762?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dwyatte",
"html_url": "https://github.com/dwyatte",
"followers_url": "https://api.github.com/users/dwyatte/... | [] | closed | false | null | [] | [
"Related to #28035 and #28060 which should have already skipped it"
] | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | # What does this PR do?
Disables `tests/models/seamless_m4t/test_modeling_seamless_m4t.py::SeamlessM4TModelWithTextInputTest::test_retain_grad_hidden_states_attentions` as discussed in https://github.com/huggingface/transformers/pull/28144#issuecomment-1864990888
## Before submitting
- [ ] This PR fixes a typo o... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28169/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28169/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28169",
"html_url": "https://github.com/huggingface/transformers/pull/28169",
"diff_url": "https://github.com/huggingface/transformers/pull/28169.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28169.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28168 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28168/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28168/comments | https://api.github.com/repos/huggingface/transformers/issues/28168/events | https://github.com/huggingface/transformers/pull/28168 | 2,051,109,413 | PR_kwDOCUB6oc5igFeH | 28,168 | Fix `input_embeds` docstring in encoder-decoder architectures | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [] | 1,703 | 1,703 | 1,703 | MEMBER | null | # What does this PR do?
Big diff, small change:
- adds a missing paragraph between the docstring of `past_key_values` and `input_embeds`
- adds missing `input_embeds` docstring in a few TF models
It chips away some of the diff in #28065 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28168/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28168/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28168",
"html_url": "https://github.com/huggingface/transformers/pull/28168",
"diff_url": "https://github.com/huggingface/transformers/pull/28168.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28168.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28167 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28167/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28167/comments | https://api.github.com/repos/huggingface/transformers/issues/28167/events | https://github.com/huggingface/transformers/issues/28167 | 2,050,971,650 | I_kwDOCUB6oc56P1gC | 28,167 | Misleading doc on BLIP `outputs.loss`: doesn't return true NLL but NLL *with label smoothing* | {
"login": "DianeBouchacourt",
"id": 13796686,
"node_id": "MDQ6VXNlcjEzNzk2Njg2",
"avatar_url": "https://avatars.githubusercontent.com/u/13796686?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/DianeBouchacourt",
"html_url": "https://github.com/DianeBouchacourt",
"followers_url": "https://... | [
{
"id": 1990918270,
"node_id": "MDU6TGFiZWwxOTkwOTE4Mjcw",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20First%20Issue",
"name": "Good First Issue",
"color": "bbf794",
"default": false,
"description": ""
}
] | closed | false | null | [] | [
"cc @younesbelkada I would remove the label smoothing from our code actually. We usually just add the regular cross-entropy loss to our models, label smoothing leads to subtle bugs (probably only useful during pre-training on noisy data)",
"Hi @DianeBouchacourt thanks for pointing this out ! Would you be happy to... | 1,703 | 1,708 | 1,708 | NONE | null | ### System Info
Transformers 4.35.2
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
### Reproduction
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28167/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28167/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28166 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28166/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28166/comments | https://api.github.com/repos/huggingface/transformers/issues/28166/events | https://github.com/huggingface/transformers/pull/28166 | 2,050,712,916 | PR_kwDOCUB6oc5ietpb | 28,166 | Generate: fix speculative decoding | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [
"@amyeroberts all tests were passing, the quality of the outputs was meh in some cases. \r\n\r\nGoing to add a slow test with a parameterization corresponding to a bad output in the previous commit, so we don't regress :)"
] | 1,703 | 1,703 | 1,703 | MEMBER | null | # What does this PR do?
This PR:
- Fixes speculative decoding quality:
- Incorrect indexing operation
- The assistant model should sample when the larger model also samples (more generally, it should take the original model's `generation_config`)
- Custom logits processors should also be passed to the assi... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28166/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28166/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28166",
"html_url": "https://github.com/huggingface/transformers/pull/28166",
"diff_url": "https://github.com/huggingface/transformers/pull/28166.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28166.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28165 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28165/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28165/comments | https://api.github.com/repos/huggingface/transformers/issues/28165/events | https://github.com/huggingface/transformers/pull/28165 | 2,050,664,966 | PR_kwDOCUB6oc5iei9i | 28,165 | Add new meta w2v2-conformer BERT-like model | {
"login": "ylacombe",
"id": 52246514,
"node_id": "MDQ6VXNlcjUyMjQ2NTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/52246514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ylacombe",
"html_url": "https://github.com/ylacombe",
"followers_url": "https://api.github.com/users/yla... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28165). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Thanks for the many good suggestions @sanchit-gandhi, could you take one last look... | 1,703 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
Meta just open-sourced a Wav2Vec2-BERT conformer [model](https://huggingface.co/facebook/w2v-bert-2.0). This one is particularly interesting because it's under a MIT license and was pretrained on 101 input languages!
It requires adaption to the current w2v2-conformer code, which this PR d... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28165/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28165/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28165",
"html_url": "https://github.com/huggingface/transformers/pull/28165",
"diff_url": "https://github.com/huggingface/transformers/pull/28165.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28165.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28164 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28164/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28164/comments | https://api.github.com/repos/huggingface/transformers/issues/28164/events | https://github.com/huggingface/transformers/issues/28164 | 2,050,512,860 | I_kwDOCUB6oc56OFfc | 28,164 | Inconsistencies between `.save_pretrained` and `from_pretrained` for slow and fast tokenizers (RoFormer) | {
"login": "xenova",
"id": 26504141,
"node_id": "MDQ6VXNlcjI2NTA0MTQx",
"avatar_url": "https://avatars.githubusercontent.com/u/26504141?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/xenova",
"html_url": "https://github.com/xenova",
"followers_url": "https://api.github.com/users/xenova/fo... | [] | closed | false | null | [] | [
"Another weird thing is that behaviour changes after saving the tokenizer:\r\n```py\r\n>>> from transformers import AutoTokenizer\r\n>>> tokenizer = AutoTokenizer.from_pretrained('alchemab/antiberta2')\r\n>>> text='test $1 R2 #3 €4 £5 ¥6 ₣7 ₹8 ₱9 test'\r\n>>> tokenizer.encode(text)\r\n[1, 4, 4, 4, 4, 4, 4, 4, 4, 4,... | 1,703 | 1,705 | 1,705 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (False)
- Tensorflow... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28164/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28164/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28163 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28163/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28163/comments | https://api.github.com/repos/huggingface/transformers/issues/28163/events | https://github.com/huggingface/transformers/pull/28163 | 2,050,454,676 | PR_kwDOCUB6oc5id0l1 | 28,163 | [Phi] Extend implementation to use GQA/MQA. | {
"login": "gugarosa",
"id": 4120639,
"node_id": "MDQ6VXNlcjQxMjA2Mzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/4120639?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gugarosa",
"html_url": "https://github.com/gugarosa",
"followers_url": "https://api.github.com/users/gugar... | [] | closed | false | null | [] | [
"TODO: address results differences when evaluating models.",
"> The idea for us is that if the model phi2 fits in phi (modeling_phi) with these changes, then a single conversion is great but we don't mind updating it.\r\n\r\nI believe yes `phi2` fits into `phi1/1.5` modeling file... I guess this is to add more fu... | 1,703 | 1,705 | 1,704 | CONTRIBUTOR | null | # What does this PR do?
As we discussed on the repositories and the e-mail thread, these are minor changes that we would like to integrate into HF.
One thing that we need to discuss is how to leverage the current batch of models (using `transformers>=4.36.0`), since the proposed change will make a shape differen... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28163/reactions",
"total_count": 3,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 3,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28163/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28163",
"html_url": "https://github.com/huggingface/transformers/pull/28163",
"diff_url": "https://github.com/huggingface/transformers/pull/28163.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28163.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28162 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28162/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28162/comments | https://api.github.com/repos/huggingface/transformers/issues/28162/events | https://github.com/huggingface/transformers/issues/28162 | 2,050,409,938 | I_kwDOCUB6oc56NsXS | 28,162 | save_pretrained no longer works for AutomaticSpeechRecognitionPipeline | {
"login": "Hubert-Bonisseur",
"id": 48770768,
"node_id": "MDQ6VXNlcjQ4NzcwNzY4",
"avatar_url": "https://avatars.githubusercontent.com/u/48770768?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Hubert-Bonisseur",
"html_url": "https://github.com/Hubert-Bonisseur",
"followers_url": "https://... | [] | closed | false | null | [] | [
"Hi @Hubert-Bonisseur, thanks for raising this issue! \r\n\r\nIndeed, this seems to be the result of two PRs - #25884 - which enables saving image processors in pipelines and #25438 which adapted ASR's pipeline's init. \r\n\r\ncc @sanchit-gandhi who knows more about the decisions in #25438 and the reason for removi... | 1,703 | 1,705 | 1,705 | NONE | null | ### System Info
transformers-4.37.0.dev0
### Who can help?
@Narsil
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28162/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28162/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28161 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28161/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28161/comments | https://api.github.com/repos/huggingface/transformers/issues/28161/events | https://github.com/huggingface/transformers/pull/28161 | 2,050,387,978 | PR_kwDOCUB6oc5idl31 | 28,161 | Update FA2 exception msg to point to hub discussions | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [] | 1,703 | 1,703 | 1,703 | COLLABORATOR | null | # What does this PR do?
Small update the FA2 warning pointing users towards discussions on the hub. Addresses cases like in #28100 when support is requested for model not in the transformers repo.
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28161/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28161/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28161",
"html_url": "https://github.com/huggingface/transformers/pull/28161",
"diff_url": "https://github.com/huggingface/transformers/pull/28161.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28161.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28160 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28160/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28160/comments | https://api.github.com/repos/huggingface/transformers/issues/28160/events | https://github.com/huggingface/transformers/issues/28160 | 2,050,382,630 | I_kwDOCUB6oc56Nlsm | 28,160 | [Flash Attention 2] Performance improvement | {
"login": "li-plus",
"id": 39846316,
"node_id": "MDQ6VXNlcjM5ODQ2MzE2",
"avatar_url": "https://avatars.githubusercontent.com/u/39846316?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/li-plus",
"html_url": "https://github.com/li-plus",
"followers_url": "https://api.github.com/users/li-plu... | [
{
"id": 3081136536,
"node_id": "MDU6TGFiZWwzMDgxMTM2NTM2",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20Difficult%20Issue",
"name": "Good Difficult Issue",
"color": "684CC7",
"default": false,
"description": ""
},
{
"id": 6202871275,
"node_id": ... | open | false | null | [] | [
"cc @ArthurZucker @younesbelkada ",
"Hi @li-plus \r\nThanks a lot for the suggestion ! \r\n@fxmarty tried the approach of pad / unpadd at the beginning of the model forward call here: https://github.com/younesbelkada/transformers/pull/5 but the implementation ended up bloating the modeling code, therefore it has ... | 1,703 | 1,703 | null | CONTRIBUTOR | null | ### Feature request
The current flash attention 2 integration is sub-optimal in performance because it requires unpadding and padding the activations on **each** layer. For example in llama implementation:
https://github.com/huggingface/transformers/blob/769a9542de4e8b23f0a551738e18760621f463e8/src/transformers/m... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28160/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28160/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28159 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28159/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28159/comments | https://api.github.com/repos/huggingface/transformers/issues/28159/events | https://github.com/huggingface/transformers/issues/28159 | 2,050,081,233 | I_kwDOCUB6oc56McHR | 28,159 | traning a model `Falcon-7b instruct` and facing error | {
"login": "rajveer43",
"id": 64583161,
"node_id": "MDQ6VXNlcjY0NTgzMTYx",
"avatar_url": "https://avatars.githubusercontent.com/u/64583161?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rajveer43",
"html_url": "https://github.com/rajveer43",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"The snippet is not full ",
"> The snippet is not full\r\n\r\nI have updated the snippet ",
"I can't guess the model you are using, is it quantized did you use from pretrained, which checkpoint, trust remote code? ? etc",
"```\r\nMODEL_NAME = \"tiiuae/falcon-7b-instruct\"\r\n\r\nbnb_config = BitsAndBytesConfi... | 1,703 | 1,703 | 1,703 | CONTRIBUTOR | null | ### System Info
Kaggle notebook, google colab
```
training_args = transformers.TrainingArguments(
per_device_train_batch_size=4,
gradient_accumulation_steps=4, #4
num_train_epochs=6,
learning_rate=2e-4,
fp16=True,
save_total_limit=3,
logging_steps=500,
outp... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28159/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28159/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28158 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28158/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28158/comments | https://api.github.com/repos/huggingface/transformers/issues/28158/events | https://github.com/huggingface/transformers/issues/28158 | 2,049,997,699 | I_kwDOCUB6oc56MHuD | 28,158 | During the training process, what happens if tf32 and bf16 are enabled at the same time? | {
"login": "Bonytu",
"id": 47250017,
"node_id": "MDQ6VXNlcjQ3MjUwMDE3",
"avatar_url": "https://avatars.githubusercontent.com/u/47250017?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Bonytu",
"html_url": "https://github.com/Bonytu",
"followers_url": "https://api.github.com/users/Bonytu/fo... | [] | open | false | {
"login": "muellerzr",
"id": 7831895,
"node_id": "MDQ6VXNlcjc4MzE4OTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7831895?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/muellerzr",
"html_url": "https://github.com/muellerzr",
"followers_url": "https://api.github.com/users/mu... | [
{
"login": "muellerzr",
"id": 7831895,
"node_id": "MDQ6VXNlcjc4MzE4OTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7831895?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/muellerzr",
"html_url": "https://github.com/muellerzr",
"followers_url": "https://api... | [
"Hi，could you please help me to solve this issue? @muellerzr @pacman100 \r\nThanks！"
] | 1,703 | 1,706 | null | NONE | null | ### System Info
transformers 4.34.1
### Who can help?
@muellerzr @pacman100
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X] My own task or dataset (give details below)
### Rep... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28158/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28158/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28157 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28157/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28157/comments | https://api.github.com/repos/huggingface/transformers/issues/28157/events | https://github.com/huggingface/transformers/issues/28157 | 2,049,793,039 | I_kwDOCUB6oc56LVwP | 28,157 | AUtokenizer is giving wrong result | {
"login": "ONE-THING-9",
"id": 123763769,
"node_id": "U_kgDOB2B8OQ",
"avatar_url": "https://avatars.githubusercontent.com/u/123763769?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ONE-THING-9",
"html_url": "https://github.com/ONE-THING-9",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Hey! Thanks for opening an issue! This is not related to the actual classes but rather the way BPE works. It tries to merge individual characters based on the `merges` it has learned. But in this case `\"▁\", \"विधायकों\"` is not part of the merge pairs. While for example `\"▁\",\"विधायक\"` is. So: \r\n```pytho... | 1,703 | 1,707 | 1,707 | NONE | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (False)
- Tensorflow... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28157/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28157/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28156 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28156/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28156/comments | https://api.github.com/repos/huggingface/transformers/issues/28156/events | https://github.com/huggingface/transformers/issues/28156 | 2,049,744,008 | I_kwDOCUB6oc56LJyI | 28,156 | Whisper v3 dependency issue | {
"login": "lionsheep0724",
"id": 79906095,
"node_id": "MDQ6VXNlcjc5OTA2MDk1",
"avatar_url": "https://avatars.githubusercontent.com/u/79906095?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lionsheep0724",
"html_url": "https://github.com/lionsheep0724",
"followers_url": "https://api.githu... | [] | open | false | null | [] | [
"Hi @lionsheep0724, thanks for raising this issue! \r\n\r\nThe most recent version of transformers [is compatible with tokenizers==0.15](https://github.com/huggingface/transformers/blob/769a9542de4e8b23f0a551738e18760621f463e8/setup.py#L177). \r\n\r\nCould you try reinstalling transformers? \r\n\r\n```\r\npip unins... | 1,703 | 1,706 | null | NONE | null | ### System Info
- transformers version: transformers-4.37.0.dev0 (installed via `pip install --upgrade git+https://github.com/huggingface/transformers.git accelerate datasets[audio]`, which instructed in [here](https://huggingface.co/openai/whisper-large-v3)
- Platform: Windows 10, WSL
- Python version: 3.10
### ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28156/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28156/timeline | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.