url stringlengths 62 66 | repository_url stringclasses 1
value | labels_url stringlengths 76 80 | comments_url stringlengths 71 75 | events_url stringlengths 69 73 | html_url stringlengths 50 56 | id int64 377M 2.15B | node_id stringlengths 18 32 | number int64 1 29.2k | title stringlengths 1 487 | user dict | labels list | state stringclasses 2
values | locked bool 2
classes | assignee dict | assignees list | comments list | created_at int64 1.54k 1.71k | updated_at int64 1.54k 1.71k | closed_at int64 1.54k 1.71k โ | author_association stringclasses 4
values | active_lock_reason stringclasses 2
values | body stringlengths 0 234k โ | reactions dict | timeline_url stringlengths 71 75 | state_reason stringclasses 3
values | draft bool 2
classes | pull_request dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/transformers/issues/28860 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28860/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28860/comments | https://api.github.com/repos/huggingface/transformers/issues/28860/events | https://github.com/huggingface/transformers/issues/28860 | 2,117,831,973 | I_kwDOCUB6oc5-O40l | 28,860 | Question: How do LLMs learn to be "Generative", as we often describe them? | {
"login": "metalwhale",
"id": 45712559,
"node_id": "MDQ6VXNlcjQ1NzEyNTU5",
"avatar_url": "https://avatars.githubusercontent.com/u/45712559?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/metalwhale",
"html_url": "https://github.com/metalwhale",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"When you run a forward pass, you are always predicting the distribution of the next token. So quite simply, model(input_1) with let's say [3442] will compute the distribution of `x1`. ",
"@ArthurZucker \nThank you for your answer!\n\nBut in that case `x1` is no longer the \"first token\", isn't it? The probabili... | 1,707 | 1,707 | 1,707 | NONE | null | (Please forgive me and let me know if I'm not allowed to ask this kind of question here. I'm so sorry if I'm bothering everyone.)
AFAIK to be called "generative", a model should have the ability to learn the joint probability over the training data. In the case of LLMs, we apply the chain rule of Bayes' formula to a... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28860/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28860/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28859 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28859/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28859/comments | https://api.github.com/repos/huggingface/transformers/issues/28859/events | https://github.com/huggingface/transformers/issues/28859 | 2,117,749,812 | I_kwDOCUB6oc5-Okw0 | 28,859 | TypeError: unhashable type: 'dict' with BGE-M3 using AutoTokenizer | {
"login": "NirantK",
"id": 3250749,
"node_id": "MDQ6VXNlcjMyNTA3NDk=",
"avatar_url": "https://avatars.githubusercontent.com/u/3250749?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NirantK",
"html_url": "https://github.com/NirantK",
"followers_url": "https://api.github.com/users/NirantK/... | [] | closed | false | null | [] | [
"Hey! I cannot reproduce this on main:\r\n```python \r\n\r\nIn [3]: from transformers import AutoTokenizer\r\n\r\nIn [4]: model_id = \"BAAI/bge-m3\"\r\n ...: hf_tokenizer = AutoTokenizer.from_pretrained(model_id)\r\ntokenizer_config.json: 100%|โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ... | 1,707 | 1,708 | 1,707 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.20.3
- Safetensors version: 0.4.2
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (True)
- Tensorflow ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28859/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28859/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28858 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28858/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28858/comments | https://api.github.com/repos/huggingface/transformers/issues/28858/events | https://github.com/huggingface/transformers/pull/28858 | 2,117,525,860 | PR_kwDOCUB6oc5l9_Gh | 28,858 | [`Doc`] update contribution guidelines | {
"login": "ArthurZucker",
"id": 48595927,
"node_id": "MDQ6VXNlcjQ4NTk1OTI3",
"avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ArthurZucker",
"html_url": "https://github.com/ArthurZucker",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28858). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,707 | 1,707 | 1,707 | COLLABORATOR | null | # What does this PR do?
Fixes a misunderstanding from #28767 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28858/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28858/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28858",
"html_url": "https://github.com/huggingface/transformers/pull/28858",
"diff_url": "https://github.com/huggingface/transformers/pull/28858.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28858.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28857 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28857/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28857/comments | https://api.github.com/repos/huggingface/transformers/issues/28857/events | https://github.com/huggingface/transformers/issues/28857 | 2,117,499,996 | I_kwDOCUB6oc5-Nnxc | 28,857 | add `push_to_hub( )` method when working with pipelines | {
"login": "not-lain",
"id": 70411813,
"node_id": "MDQ6VXNlcjcwNDExODEz",
"avatar_url": "https://avatars.githubusercontent.com/u/70411813?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/not-lain",
"html_url": "https://github.com/not-lain",
"followers_url": "https://api.github.com/users/not... | [
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request",
"name": "Feature request",
"color": "FBCA04",
"default": false,
"description": "Request for a new feature"
}
] | open | false | null | [] | [
"FYI @Rocketknight1 "
] | 1,707 | 1,707 | null | CONTRIBUTOR | null | ### Feature request
it will be good to addition to the library to add a `push_to_hub( )` method when working with the pipeline method.
### Motivation
I have just finished up a blogpost about creating custom architectures, but i couldn't help but notice that when working with ` AutoConfig` or `AutoModelForxxx` or `Pr... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28857/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28857/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28856 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28856/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28856/comments | https://api.github.com/repos/huggingface/transformers/issues/28856/events | https://github.com/huggingface/transformers/issues/28856 | 2,117,071,793 | I_kwDOCUB6oc5-L_Ox | 28,856 | When using AutoModelForCausalLM, THUDM/cogagent-vqa-hf and load_in_8bit I get this error : self and mat2 must have the same dtype, but got Half and Char | {
"login": "FurkanGozukara",
"id": 19240467,
"node_id": "MDQ6VXNlcjE5MjQwNDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/19240467?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/FurkanGozukara",
"html_url": "https://github.com/FurkanGozukara",
"followers_url": "https://api.gi... | [] | closed | false | null | [] | [
"Hi @FurkanGozukara \r\nThis issue is a duplicate of https://github.com/TimDettmers/bitsandbytes/issues/1029 - can you share the full traceback of the error so that I can fix the issue on the Hub? \r\nMy gut feeling is that the model is not compatible with bnb-8bit, the model code authors will need to make a slight... | 1,707 | 1,707 | 1,707 | NONE | null | ### System Info
```
Microsoft Windows [Version 10.0.19045.3996]
(c) Microsoft Corporation. All rights reserved.
G:\temp Local install\CogVLM\venv\Scripts>activate
(venv) G:\temp Local install\CogVLM\venv\Scripts>pip freeze
accelerate==0.26.1
aiofiles==23.2.1
aiohttp==3.9.3
aiosignal==1.3.1
altair==5.2.0... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28856/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28856/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28855 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28855/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28855/comments | https://api.github.com/repos/huggingface/transformers/issues/28855/events | https://github.com/huggingface/transformers/pull/28855 | 2,116,787,677 | PR_kwDOCUB6oc5l7lL3 | 28,855 | [Docs] Fix bad doc: replace save with logging | {
"login": "chenzizhao",
"id": 31786519,
"node_id": "MDQ6VXNlcjMxNzg2NTE5",
"avatar_url": "https://avatars.githubusercontent.com/u/31786519?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chenzizhao",
"html_url": "https://github.com/chenzizhao",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [] | 1,707 | 1,707 | 1,707 | CONTRIBUTOR | null | # Fix doc typos in TrainingArguments.set_logging
## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-r... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28855/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28855/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28855",
"html_url": "https://github.com/huggingface/transformers/pull/28855",
"diff_url": "https://github.com/huggingface/transformers/pull/28855.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28855.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28854 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28854/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28854/comments | https://api.github.com/repos/huggingface/transformers/issues/28854/events | https://github.com/huggingface/transformers/pull/28854 | 2,116,662,720 | PR_kwDOCUB6oc5l7LNL | 28,854 | Honor trust_remote_code for custom tokenizers | {
"login": "rl337",
"id": 387895,
"node_id": "MDQ6VXNlcjM4Nzg5NQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/387895?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rl337",
"html_url": "https://github.com/rl337",
"followers_url": "https://api.github.com/users/rl337/followers"... | [] | closed | false | null | [] | [
"Yep - I think I might have accidentally caused this with that PR! The original problem I was fixing was that the prompt was not displaying when `trust_remote_code=None`. Let me take a look at this fix.",
"Hi @rl337, can you give me some code to reproduce the issue? I picked `Qwen/Qwen-VL` because it's a recent r... | 1,706 | 1,708 | 1,708 | CONTRIBUTOR | null | When trying to use AutoTokenizer.from_pretrained for a tokenizer that is not recognized in existing tokenizer maps, you're required respond to this trust_remote_code prompt even if you specify trust_remote_code=True.
The cause of this is, in tokenization_auto.py, we kwargs.pop("trust_remote_code"...) but then don't ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28854/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28854/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28854",
"html_url": "https://github.com/huggingface/transformers/pull/28854",
"diff_url": "https://github.com/huggingface/transformers/pull/28854.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28854.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28853 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28853/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28853/comments | https://api.github.com/repos/huggingface/transformers/issues/28853/events | https://github.com/huggingface/transformers/issues/28853 | 2,116,646,239 | I_kwDOCUB6oc5-KXVf | 28,853 | after batch_encode_plus generate returns sequence of EOS tokens | {
"login": "tempdeltavalue",
"id": 36921178,
"node_id": "MDQ6VXNlcjM2OTIxMTc4",
"avatar_url": "https://avatars.githubusercontent.com/u/36921178?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tempdeltavalue",
"html_url": "https://github.com/tempdeltavalue",
"followers_url": "https://api.gi... | [] | open | false | null | [] | [
"Most probably a padding side issue. If you skip the special tokens you should no longer see them when decoding. \r\nIt is planned to get rid of this function anyway to keep only encode and decode for simplicity! \r\nI recommend to use encode"
] | 1,706 | 1,707 | null | NONE | null | ### System Info
Here's the screenshot which is show this issue
HF - discussion:
https://discuss.huggingface.co/t/gpt2-returns-sequence-of-endoftext-after-finetuning/70418
HF top... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28853/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28853/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28852 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28852/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28852/comments | https://api.github.com/repos/huggingface/transformers/issues/28852/events | https://github.com/huggingface/transformers/pull/28852 | 2,116,511,489 | PR_kwDOCUB6oc5l6rzE | 28,852 | [Docs] Add missing language options and fix broken links | {
"login": "khipp",
"id": 9824526,
"node_id": "MDQ6VXNlcjk4MjQ1MjY=",
"avatar_url": "https://avatars.githubusercontent.com/u/9824526?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khipp",
"html_url": "https://github.com/khipp",
"followers_url": "https://api.github.com/users/khipp/follower... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28852). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Rebased to resolve merge conflicts with the main branch."
] | 1,706 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
This PR adds missing entries to the language selection menu, as well as links to the Colab and AWS Studio notebooks for the ONNX examples.
It also fixes various hyperlinks that were broken due to spaces within the URL or spaces between the link text and the URL, and updates the links to Open... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28852/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28852/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28852",
"html_url": "https://github.com/huggingface/transformers/pull/28852",
"diff_url": "https://github.com/huggingface/transformers/pull/28852.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28852.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28851 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28851/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28851/comments | https://api.github.com/repos/huggingface/transformers/issues/28851/events | https://github.com/huggingface/transformers/issues/28851 | 2,116,466,689 | I_kwDOCUB6oc5-JrgB | 28,851 | Getting the error: "ValueError: The following model_kwargs are not used by the model:....." | {
"login": "Pranav110500",
"id": 104620839,
"node_id": "U_kgDOBjxjJw",
"avatar_url": "https://avatars.githubusercontent.com/u/104620839?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Pranav110500",
"html_url": "https://github.com/Pranav110500",
"followers_url": "https://api.github.com/use... | [] | open | false | null | [] | [
"@ArthurZucker @younesbelkada Can either of you provide any insights on this? If additional info is needed to explain the issue further do let me know. Will be really glad for any assistance from you.",
"Hey ๐ค thanks for opening an issue! We try to keep the github issues for bugs/feature requests.\r\nCould you ... | 1,706 | 1,707 | null | NONE | null | Hello @ArthurZucker, I found you to be active in the issues section hence I have tagged you. I needed some help with this error I am facing. So I am basically re-implementing a particular research paper's code, available on their github page with the link:- https://github.com/XiangLi1999/ContrastiveDecoding
When I r... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28851/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28851/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28850 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28850/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28850/comments | https://api.github.com/repos/huggingface/transformers/issues/28850/events | https://github.com/huggingface/transformers/issues/28850 | 2,116,277,709 | I_kwDOCUB6oc5-I9XN | 28,850 | 'LayoutLMv2Processor' object has no attribute 'image_processor' | {
"login": "andysingal",
"id": 20493493,
"node_id": "MDQ6VXNlcjIwNDkzNDkz",
"avatar_url": "https://avatars.githubusercontent.com/u/20493493?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andysingal",
"html_url": "https://github.com/andysingal",
"followers_url": "https://api.github.com/use... | [] | open | false | null | [] | [
"I believe the [preprocessor_config.json](https://huggingface.co/microsoft/layoutlmv2-base-uncased/blob/main/preprocessor_config.json) needs to be edited. Unfortunately I can't get detectron2 installed on my system right now, but I think this should do it:\r\n\r\n```\r\n{\r\n \"apply_ocr\": true,\r\n \"do_resize\... | 1,706 | 1,707 | null | NONE | null | ### System Info
Colab Notebook
### Who can help?
@NielsRogge @amyeroberts
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28850/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28850/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28849 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28849/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28849/comments | https://api.github.com/repos/huggingface/transformers/issues/28849/events | https://github.com/huggingface/transformers/issues/28849 | 2,115,972,878 | I_kwDOCUB6oc5-Hy8O | 28,849 | TextStreamer: An option to print / put every single token instead of whole words | {
"login": "vicboyv",
"id": 12023068,
"node_id": "MDQ6VXNlcjEyMDIzMDY4",
"avatar_url": "https://avatars.githubusercontent.com/u/12023068?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vicboyv",
"html_url": "https://github.com/vicboyv",
"followers_url": "https://api.github.com/users/vicboy... | [
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request",
"name": "Feature request",
"color": "FBCA04",
"default": false,
"description": "Request for a new feature"
}
] | open | false | null | [] | [
"cc @gante ",
"@vicboyv it's in our plans, but I can't give you a timeframe :) "
] | 1,706 | 1,707 | null | NONE | null | ### Feature request
https://github.com/huggingface/transformers/blob/v4.37.2/src/transformers/generation/streamers.py#L108-L114
The current implementation forces us to visualize decoding on a per word basis. Add an option to print the string as soon as it's generated.
### Motivation
I use TextStreamer to vi... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28849/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28849/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28848 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28848/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28848/comments | https://api.github.com/repos/huggingface/transformers/issues/28848/events | https://github.com/huggingface/transformers/pull/28848 | 2,115,904,800 | PR_kwDOCUB6oc5l4mu- | 28,848 | Clean up staging tmp checkpoint directory | {
"login": "woshiyyya",
"id": 26745457,
"node_id": "MDQ6VXNlcjI2NzQ1NDU3",
"avatar_url": "https://avatars.githubusercontent.com/u/26745457?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/woshiyyya",
"html_url": "https://github.com/woshiyyya",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"cc @pacman100 @muellerzr ",
"cc @amyeroberts ",
"@pacman100 Is pinging me for review here a signal that you approve of these changes and it's ready for final review? ",
"Any updates on this?",
"@pacman100 Requested review from you to confirm this fix is in line with expected trainer behaviour. Once you've... | 1,706 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
In PR #28364 , it changed the checkpoint folder renaming logic, which makes only local_rank_0 workers or global_rank_0 worker to rename the checkpoint dir from `tmp-checkpoint-*` to `checkpoint-*`. It will be a noop on other ranks.
When we have multiple nodes, and if you save on global ran... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28848/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28848/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28848",
"html_url": "https://github.com/huggingface/transformers/pull/28848",
"diff_url": "https://github.com/huggingface/transformers/pull/28848.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28848.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28847 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28847/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28847/comments | https://api.github.com/repos/huggingface/transformers/issues/28847/events | https://github.com/huggingface/transformers/pull/28847 | 2,115,744,741 | PR_kwDOCUB6oc5l4DPG | 28,847 | Fast image processor | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [
{
"id": 2796628563,
"node_id": "MDU6TGFiZWwyNzk2NjI4NTYz",
"url": "https://api.github.com/repos/huggingface/transformers/labels/WIP",
"name": "WIP",
"color": "234C99",
"default": false,
"description": "Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in pro... | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28847). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,707 | null | COLLABORATOR | null | # What does this PR do?
Initial benchmark comparing the two image processors:
Fixes # (issue)
## Before submitting
- [ ] This PR fixes a typo or improves the docs (yo... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28847/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28847/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28847",
"html_url": "https://github.com/huggingface/transformers/pull/28847",
"diff_url": "https://github.com/huggingface/transformers/pull/28847.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28847.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28846 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28846/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28846/comments | https://api.github.com/repos/huggingface/transformers/issues/28846/events | https://github.com/huggingface/transformers/issues/28846 | 2,115,724,286 | I_kwDOCUB6oc5-G2P- | 28,846 | Donut model only works on 4.36.2 for inference, not 4.37.2 | {
"login": "VikParuchuri",
"id": 913340,
"node_id": "MDQ6VXNlcjkxMzM0MA==",
"avatar_url": "https://avatars.githubusercontent.com/u/913340?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VikParuchuri",
"html_url": "https://github.com/VikParuchuri",
"followers_url": "https://api.github.com/u... | [] | open | false | null | [] | [
"fyi @NielsRogge "
] | 1,706 | 1,707 | null | NONE | null | ### System Info
I have a donut model with some slight customizations to the mbart decoder (added gqa and moe). It works fine on 4.36.2 and 4.37.2 for training.
But inference only works on 4.36.2. When I run inference on 4.37.2, then the output degenerates into repetition. @amyeroberts
Here is an example (the ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28846/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28846/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28845 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28845/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28845/comments | https://api.github.com/repos/huggingface/transformers/issues/28845/events | https://github.com/huggingface/transformers/pull/28845 | 2,115,516,456 | PR_kwDOCUB6oc5l3P4r | 28,845 | Bump dash from 2.3.0 to 2.15.0 in /examples/research_projects/decision_transformer | {
"login": "dependabot[bot]",
"id": 49699333,
"node_id": "MDM6Qm90NDk2OTkzMzM=",
"avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dependabot%5Bbot%5D",
"html_url": "https://github.com/apps/dependabot",
"followers_url": "https://a... | [
{
"id": 1905493434,
"node_id": "MDU6TGFiZWwxOTA1NDkzNDM0",
"url": "https://api.github.com/repos/huggingface/transformers/labels/dependencies",
"name": "dependencies",
"color": "0366d6",
"default": false,
"description": "Pull requests that update a dependency file"
},
{
"id": 6410... | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28845). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,707 | 1,707 | CONTRIBUTOR | null | Bumps [dash](https://github.com/plotly/dash) from 2.3.0 to 2.15.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/plotly/dash/releases">dash's releases</a>.</em></p>
<blockquote>
<h2>Dash v2.15.0</h2>
<h2>Added</h2>
<ul>
<li><a href="https://redirect.github.com/plotly/dash/pu... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28845/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28845/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28845",
"html_url": "https://github.com/huggingface/transformers/pull/28845",
"diff_url": "https://github.com/huggingface/transformers/pull/28845.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28845.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28844 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28844/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28844/comments | https://api.github.com/repos/huggingface/transformers/issues/28844/events | https://github.com/huggingface/transformers/pull/28844 | 2,115,505,747 | PR_kwDOCUB6oc5l3NgX | 28,844 | [Docs] Spanish translation of task_summary.md | {
"login": "aaronjimv",
"id": 67152883,
"node_id": "MDQ6VXNlcjY3MTUyODgz",
"avatar_url": "https://avatars.githubusercontent.com/u/67152883?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/aaronjimv",
"html_url": "https://github.com/aaronjimv",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Hello. This is a long doc page, so I am open to any feedback. Thanks.",
"Thanks for the PR. Let's try not to ping as many people for this please! ",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28844). All of your documentation changes will be reflected on that end... | 1,706 | 1,708 | 1,708 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28844/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28844/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28844",
"html_url": "https://github.com/huggingface/transformers/pull/28844",
"diff_url": "https://github.com/huggingface/transformers/pull/28844.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28844.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28843 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28843/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28843/comments | https://api.github.com/repos/huggingface/transformers/issues/28843/events | https://github.com/huggingface/transformers/pull/28843 | 2,115,465,267 | PR_kwDOCUB6oc5l3E3J | 28,843 | Abstract image processor arg checks. | {
"login": "molbap",
"id": 39954772,
"node_id": "MDQ6VXNlcjM5OTU0Nzcy",
"avatar_url": "https://avatars.githubusercontent.com/u/39954772?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/molbap",
"html_url": "https://github.com/molbap",
"followers_url": "https://api.github.com/users/molbap/fo... | [] | closed | false | null | [] | [
"Also linked to #28711 as I discovered logic flow issues here, seems fitting to abstract them separately and deal with the actual processing in the main PR. Here I'll try to stick to verifications and fix what's necessary to satisfy existing tests.",
"The docs for this PR live [here](https://moon-ci-docs.huggingf... | 1,706 | 1,708 | 1,708 | CONTRIBUTOR | null | # What does this PR do?
This refactors existing image processor argument checks that sprawl out on all existing models that have an `ImageProcessor`.
Lines such as
```python
if do_resize is not None and size is None:
raise ValueError("Size and max_size must be specified if do_resize is Tru... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28843/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28843/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28843",
"html_url": "https://github.com/huggingface/transformers/pull/28843",
"diff_url": "https://github.com/huggingface/transformers/pull/28843.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28843.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28842 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28842/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28842/comments | https://api.github.com/repos/huggingface/transformers/issues/28842/events | https://github.com/huggingface/transformers/pull/28842 | 2,115,229,416 | PR_kwDOCUB6oc5l2Q0V | 28,842 | Mark `test_encoder_decoder_model_generate` for `vision_encoder_deocder` as flaky | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28842). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"thanks, everyone has a nice Friday evening now :-) I hope"
] | 1,706 | 1,706 | 1,706 | COLLABORATOR | null | # What does this PR do?
Marks the tests as flaky to avoid blocking PRs.
Reference failling CI run: https://app.circleci.com/pipelines/github/huggingface/transformers/83611/workflows/666b01c9-1be8-4daa-b85d-189e670fc168/jobs/1078635/tests#failed-test-0
Reference issue for tracking: #28841
## Before submit... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28842/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28842/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28842",
"html_url": "https://github.com/huggingface/transformers/pull/28842",
"diff_url": "https://github.com/huggingface/transformers/pull/28842.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28842.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28841 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28841/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28841/comments | https://api.github.com/repos/huggingface/transformers/issues/28841/events | https://github.com/huggingface/transformers/issues/28841 | 2,115,227,084 | I_kwDOCUB6oc5-E83M | 28,841 | test_encoder_decoder_model_generate for vision_encoder_deocder is flaky | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"cc @zucchini-nlp"
] | 1,706 | 1,707 | 1,707 | COLLABORATOR | null | ### System Info
transformers 4.38.0dev
### Who can help?
@gante
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
### Reproduction
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28841/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28841/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28840 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28840/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28840/comments | https://api.github.com/repos/huggingface/transformers/issues/28840/events | https://github.com/huggingface/transformers/pull/28840 | 2,115,160,657 | PR_kwDOCUB6oc5l2Bzd | 28,840 | Use `-v` for `pytest` on CircleCI | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"Example run\r\n\r\nhttps://app.circleci.com/pipelines/github/huggingface/transformers/83697/workflows/6b7bf7c2-cf98-474c-a3dd-3eea4cfa0cfa",
"For context for anyone coming cold to this PR - the motivation for introducing this is to enable retrieving which tests were run on which process to help when debugging.\r... | 1,706 | 1,706 | 1,706 | COLLABORATOR | null | # What does this PR do?
So we get info about which process run which tests
> [gw4] [ 99%] PASSED tests/models/kosmos2/test_processor_kosmos2.py::Kosmos2ProcessorTest::test_model_input_names
tests/models/kosmos2/test_processor_kosmos2.py::Kosmos2ProcessorTest::test_processor
[gw3] [ 99%] PASSED tests/models/pi... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28840/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28840/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28840",
"html_url": "https://github.com/huggingface/transformers/pull/28840",
"diff_url": "https://github.com/huggingface/transformers/pull/28840.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28840.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28839 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28839/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28839/comments | https://api.github.com/repos/huggingface/transformers/issues/28839/events | https://github.com/huggingface/transformers/issues/28839 | 2,115,080,605 | I_kwDOCUB6oc5-EZGd | 28,839 | Llava-demo-4bit.ipynb Error (KeyError: 'llava') | {
"login": "RonanKMcGovern",
"id": 78278410,
"node_id": "MDQ6VXNlcjc4Mjc4NDEw",
"avatar_url": "https://avatars.githubusercontent.com/u/78278410?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/RonanKMcGovern",
"html_url": "https://github.com/RonanKMcGovern",
"followers_url": "https://api.gi... | [] | closed | false | null | [] | [
"You are probably running this on a local host, which does not have the latest version of `transformers` make sure to update with `pip install -U transformers`. You should have `import transformers;print(transformers.__version__)` >= transformers==4.37.2",
"Thanks @ArthurZucker , I was running the colab notebook ... | 1,706 | 1,707 | 1,707 | NONE | null | ### System Info
See [this notebook from HuggingFace](https://colab.research.google.com/drive/1qsl6cd2c8gGtEW1xV5io7S8NHh-Cp1TV?usp=sharing#scrollTo=DFVZgElEQk3x)
### Who can help?
@amyeroberts
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [X] An officially supported... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28839/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28839/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28838 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28838/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28838/comments | https://api.github.com/repos/huggingface/transformers/issues/28838/events | https://github.com/huggingface/transformers/pull/28838 | 2,114,848,356 | PR_kwDOCUB6oc5l08WZ | 28,838 | fix / skip (for now) some tests before switch to torch 2.2 | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"Note, this PR doesn't unpin torch ",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28838). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | COLLABORATOR | null | # What does this PR do?
Some changes are necessary to switch to 2.2. Others are flaky even in torch 2.1. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28838/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28838/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28838",
"html_url": "https://github.com/huggingface/transformers/pull/28838",
"diff_url": "https://github.com/huggingface/transformers/pull/28838.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28838.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28837 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28837/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28837/comments | https://api.github.com/repos/huggingface/transformers/issues/28837/events | https://github.com/huggingface/transformers/pull/28837 | 2,114,828,881 | PR_kwDOCUB6oc5l04GH | 28,837 | Llama: device/type-invariant RoPE sin/cos computation, eager attention matches original implementation | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28837). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,707 | null | MEMBER | null | # What does this PR do?
This PR fixes the following problems, all related to RoPE:
1. Casting a model with `.from_pretrained(..., torch_dtype=...)` or `.to(dtype=...)` would produce different sin/cos tensors at recomputation time. The underlying cause was `inv_freq` being a buffer, which means it was subject to buf... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28837/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28837/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28837",
"html_url": "https://github.com/huggingface/transformers/pull/28837",
"diff_url": "https://github.com/huggingface/transformers/pull/28837.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28837.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28836 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28836/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28836/comments | https://api.github.com/repos/huggingface/transformers/issues/28836/events | https://github.com/huggingface/transformers/pull/28836 | 2,114,788,501 | PR_kwDOCUB6oc5l0vTq | 28,836 | Avoid edge case in audio utils | {
"login": "ylacombe",
"id": 52246514,
"node_id": "MDQ6VXNlcjUyMjQ2NTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/52246514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ylacombe",
"html_url": "https://github.com/ylacombe",
"followers_url": "https://api.github.com/users/yla... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28836). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,707 | null | COLLABORATOR | null | # What does this PR do?
Throw an error if the spectrogram is of complex values but `mel_filters` are passed.
Fixes #27772
cc @sanchit-gandhi @ArthurZucker | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28836/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28836/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28836",
"html_url": "https://github.com/huggingface/transformers/pull/28836",
"diff_url": "https://github.com/huggingface/transformers/pull/28836.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28836.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28835 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28835/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28835/comments | https://api.github.com/repos/huggingface/transformers/issues/28835/events | https://github.com/huggingface/transformers/issues/28835 | 2,114,779,598 | I_kwDOCUB6oc5-DPnO | 28,835 | ZeroDivisonError in inverse_sqrt scheduler | {
"login": "Sangh0",
"id": 47784418,
"node_id": "MDQ6VXNlcjQ3Nzg0NDE4",
"avatar_url": "https://avatars.githubusercontent.com/u/47784418?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Sangh0",
"html_url": "https://github.com/Sangh0",
"followers_url": "https://api.github.com/users/Sangh0/fo... | [] | closed | false | null | [] | [
"cc @muellerzr ",
"Thank you for your interest in this issue. I will close this issue now."
] | 1,706 | 1,708 | 1,708 | NONE | null | Hello! I've been findiing your repository very useful.
However, I've encountered a bug. It occurs when trying to train using the inverse_sqrt scheduler, leading to a ZeroDivisionError.
Please refer to the following code link for details.
Therefore, I suggest modifying the code from `decay = 1.0 / math.sqrt((curren... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28835/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28835/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28834 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28834/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28834/comments | https://api.github.com/repos/huggingface/transformers/issues/28834/events | https://github.com/huggingface/transformers/pull/28834 | 2,114,594,175 | PR_kwDOCUB6oc5l0Eac | 28,834 | Fix issues caused by natten | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"> might have nightly issues no?\r\n\r\nsorry, what do you mean? You mean the daily CI? I haven't have the time to check, recently quite a lot of changes arriving",
"I mean we might want to change this for the daily ci as well ๐ ",
"Sure, but let's unblock red CircleCI first (I'm fine but you probably need it... | 1,706 | 1,706 | 1,706 | COLLABORATOR | null | # What does this PR do?
Don't really know what happened, but from the suggestion
> E Failed to import NATTEN's CPP backend. This could be due to an invalid/incomplete install. Please uninstall NATTEN (pip uninstall natten) and re-install with the correct torch build: shi-labs.com/natten
I changed the install... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28834/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28834/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28834",
"html_url": "https://github.com/huggingface/transformers/pull/28834",
"diff_url": "https://github.com/huggingface/transformers/pull/28834.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28834.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28833 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28833/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28833/comments | https://api.github.com/repos/huggingface/transformers/issues/28833/events | https://github.com/huggingface/transformers/pull/28833 | 2,114,581,716 | PR_kwDOCUB6oc5l0Bob | 28,833 | Dynamic parallel processing Size Adjustment for Low Mem Beam Search | {
"login": "Saibo-creator",
"id": 53392976,
"node_id": "MDQ6VXNlcjUzMzkyOTc2",
"avatar_url": "https://avatars.githubusercontent.com/u/53392976?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Saibo-creator",
"html_url": "https://github.com/Saibo-creator",
"followers_url": "https://api.githu... | [] | open | false | null | [] | [
"Hi @Saibo-creator ๐ \r\n\r\nWe're doing a sprint to add `torch.compile` support on `generate` ([tracker](https://github.com/huggingface/transformers/issues/28981)), so I'm halting the addition of changes that substantially modify a decoding method until that is complete. In particular, beam search will have to be... | 1,706 | 1,707 | null | CONTRIBUTOR | null | # What does this PR do?
TL;DR
This PR addresses feedback from the community, specifically a [suggestion](https://github.com/huggingface/transformers/pull/26304#issuecomment-1900489106) from @gante, to enhance memory management in beam search operations without adding complexity through additional flags. This deve... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28833/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28833/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28833",
"html_url": "https://github.com/huggingface/transformers/pull/28833",
"diff_url": "https://github.com/huggingface/transformers/pull/28833.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28833.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28832 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28832/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28832/comments | https://api.github.com/repos/huggingface/transformers/issues/28832/events | https://github.com/huggingface/transformers/issues/28832 | 2,114,324,509 | I_kwDOCUB6oc5-Bggd | 28,832 | Add gpt_neox in fx supported models? | {
"login": "TXacs",
"id": 60869411,
"node_id": "MDQ6VXNlcjYwODY5NDEx",
"avatar_url": "https://avatars.githubusercontent.com/u/60869411?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/TXacs",
"html_url": "https://github.com/TXacs",
"followers_url": "https://api.github.com/users/TXacs/follow... | [] | open | false | null | [] | [
"feel free to open a PR and ping @fxmarty ! ๐ค "
] | 1,706 | 1,706 | null | NONE | null | ### System Info
change
`qkv = qkv.view(*new_qkv_shape)`
to
` qkv = qkv.view(new_qkv_shape)`
I've made a modification, and now it can be traced by `hftracer`.
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28832/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28832/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28831 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28831/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28831/comments | https://api.github.com/repos/huggingface/transformers/issues/28831/events | https://github.com/huggingface/transformers/issues/28831 | 2,114,290,540 | I_kwDOCUB6oc5-BYNs | 28,831 | Missed a guard on hf_quantizer.check_quantized_param | {
"login": "pharaouk",
"id": 36641995,
"node_id": "MDQ6VXNlcjM2NjQxOTk1",
"avatar_url": "https://avatars.githubusercontent.com/u/36641995?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pharaouk",
"html_url": "https://github.com/pharaouk",
"followers_url": "https://api.github.com/users/pha... | [] | open | false | null | [] | [
"cc @younesbelkada ",
"Yes, should be fixed by #28804",
"@pharaouk could you try on transformers main?"
] | 1,706 | 1,706 | null | NONE | null | ### System Info
```
model = AutoModelForCausalLM.from_pretrained(
File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/transformers/models/auto/auto_factory.py", line 562, in from_pretrained
return model_class.from_pretrained(
File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/t... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28831/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28831/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28830 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28830/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28830/comments | https://api.github.com/repos/huggingface/transformers/issues/28830/events | https://github.com/huggingface/transformers/pull/28830 | 2,114,243,647 | PR_kwDOCUB6oc5ly3mS | 28,830 | Reduce GPU memory usage when using FSDP+PEFT | {
"login": "pacman100",
"id": 13534540,
"node_id": "MDQ6VXNlcjEzNTM0NTQw",
"avatar_url": "https://avatars.githubusercontent.com/u/13534540?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pacman100",
"html_url": "https://github.com/pacman100",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28830). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
1. For FSDP+PEFT, When using `use_orig_params=True` which is now the default in Accelerate, there is no memory savings when compared to FSDP full fine-tuning. We have to set `use_orig_params=False` to realize the memory savings which makes it difficult to be in line with Accelerateโs minimal AP... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28830/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28830/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28830",
"html_url": "https://github.com/huggingface/transformers/pull/28830",
"diff_url": "https://github.com/huggingface/transformers/pull/28830.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28830.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28829 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28829/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28829/comments | https://api.github.com/repos/huggingface/transformers/issues/28829/events | https://github.com/huggingface/transformers/issues/28829 | 2,114,203,039 | I_kwDOCUB6oc5-BC2f | 28,829 | AWQ models loaded with AutoModelForCausalLM.from_pretrained not as fast as AutoAWQForCausalLM.from_quantized | {
"login": "nilichen",
"id": 9046815,
"node_id": "MDQ6VXNlcjkwNDY4MTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/9046815?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nilichen",
"html_url": "https://github.com/nilichen",
"followers_url": "https://api.github.com/users/nilic... | [] | open | false | null | [] | [
"Hey! Thanks for reporting. This is expected, the operations are not fused by default in transformers, [as per the documentation](https://huggingface.co/docs/transformers/quantization#fused-modules). ",
"Hi. I did have `fused_layers = False` when loading with `AutoAWQForCausalLM.from_quantized` so in theory they ... | 1,706 | 1,707 | null | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-6.2.0-1018-aws-x86_64-with-glibc2.35
- Python version: 3.11.7
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.3.1
- Accelerate version: 0.21.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2+cu121 (True)
- Tensorf... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28829/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28829/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28828 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28828/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28828/comments | https://api.github.com/repos/huggingface/transformers/issues/28828/events | https://github.com/huggingface/transformers/issues/28828 | 2,114,045,444 | I_kwDOCUB6oc5-AcYE | 28,828 | [i18n-<languageCode>] Translating docs to <languageName> | {
"login": "goalend",
"id": 110501477,
"node_id": "U_kgDOBpYeZQ",
"avatar_url": "https://avatars.githubusercontent.com/u/110501477?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/goalend",
"html_url": "https://github.com/goalend",
"followers_url": "https://api.github.com/users/goalend/foll... | [
{
"id": 2796628563,
"node_id": "MDU6TGFiZWwyNzk2NjI4NTYz",
"url": "https://api.github.com/repos/huggingface/transformers/labels/WIP",
"name": "WIP",
"color": "234C99",
"default": false,
"description": "Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in pro... | open | false | null | [] | [] | 1,706 | 1,707 | null | NONE | null | <!--
Note: Please search to see if an issue already exists for the language you are trying to translate.
-->
Hi!
Let's bring the documentation to all the <languageName>-speaking community ๐ (currently 0 out of 267 complete)
Who would want to translate? Please follow the ๐ค [TRANSLATING guide](https://github.com/hug... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28828/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28828/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28827 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28827/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28827/comments | https://api.github.com/repos/huggingface/transformers/issues/28827/events | https://github.com/huggingface/transformers/issues/28827 | 2,113,910,992 | I_kwDOCUB6oc59_7jQ | 28,827 | SDPA attention causes graph break while compiling model | {
"login": "huzama",
"id": 34284201,
"node_id": "MDQ6VXNlcjM0Mjg0MjAx",
"avatar_url": "https://avatars.githubusercontent.com/u/34284201?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huzama",
"html_url": "https://github.com/huzama",
"followers_url": "https://api.github.com/users/huzama/fo... | [] | open | false | null | [] | [
"Hey! would recommend you to try #27931 ๐ "
] | 1,706 | 1,706 | null | NONE | null | ### Feature request
Static graph support in SDPA attention
### Motivation
The use of SPDA attention significantly enhances transformers' performance and memory utilization. However, when attempting to compile it with the XLA backend on TPUs, there are graph breaks that require continuous recompilation. This makes t... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28827/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28827/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28826 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28826/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28826/comments | https://api.github.com/repos/huggingface/transformers/issues/28826/events | https://github.com/huggingface/transformers/issues/28826 | 2,113,842,792 | I_kwDOCUB6oc59_q5o | 28,826 | Llama 2 model divergence with FSDP | {
"login": "Teng-xu",
"id": 67929972,
"node_id": "MDQ6VXNlcjY3OTI5OTcy",
"avatar_url": "https://avatars.githubusercontent.com/u/67929972?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Teng-xu",
"html_url": "https://github.com/Teng-xu",
"followers_url": "https://api.github.com/users/Teng-x... | [] | open | false | null | [] | [
"cc @younesbelkada I think we have seen something similar recently? ",
"@Teng-xu are you correctly enabling mixed precision through `bf16=True` in `TrainingArguments` ?",
"Yeah bf16 was passed into the training args, and I can verify it is being applied correctly.",
"Just to provide more context on this issue... | 1,706 | 1,707 | null | NONE | null | ### System Info
- `transformers` version: 4.37.1
- Platform: Linux-5.10.199-190.747.amzn2.x86_64-x86_64-with-glibc2.31
- Python version: 3.10.8
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.3.3
- Accelerate version: 0.26.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (True)
- Te... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28826/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28826/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28825 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28825/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28825/comments | https://api.github.com/repos/huggingface/transformers/issues/28825/events | https://github.com/huggingface/transformers/pull/28825 | 2,113,802,629 | PR_kwDOCUB6oc5lxWY_ | 28,825 | [Docs] Fix spelling and grammar mistakes | {
"login": "khipp",
"id": 9824526,
"node_id": "MDQ6VXNlcjk4MjQ1MjY=",
"avatar_url": "https://avatars.githubusercontent.com/u/9824526?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khipp",
"html_url": "https://github.com/khipp",
"followers_url": "https://api.github.com/users/khipp/follower... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28825). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,707 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
This PR fixes various spelling and grammar mistakes in the documentation and docstrings within the source code. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28825/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28825/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28825",
"html_url": "https://github.com/huggingface/transformers/pull/28825",
"diff_url": "https://github.com/huggingface/transformers/pull/28825.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28825.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28824 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28824/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28824/comments | https://api.github.com/repos/huggingface/transformers/issues/28824/events | https://github.com/huggingface/transformers/pull/28824 | 2,113,513,170 | PR_kwDOCUB6oc5lwVa0 | 28,824 | Explicitly check if token ID's are None in TFBertTokenizer constructor | {
"login": "skumar951",
"id": 25424300,
"node_id": "MDQ6VXNlcjI1NDI0MzAw",
"avatar_url": "https://avatars.githubusercontent.com/u/25424300?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/skumar951",
"html_url": "https://github.com/skumar951",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Failing test is unrelated I'll merge"
] | 1,706 | 1,707 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
Since the token ID's are ints, the `if token_id` check will fail if `token_id == 0`, when it should only fail when `token_id == None`. This PR adds an explicit None check.
@ArthurZucker
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28824/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28824/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28824",
"html_url": "https://github.com/huggingface/transformers/pull/28824",
"diff_url": "https://github.com/huggingface/transformers/pull/28824.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28824.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28823 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28823/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28823/comments | https://api.github.com/repos/huggingface/transformers/issues/28823/events | https://github.com/huggingface/transformers/pull/28823 | 2,113,307,590 | PR_kwDOCUB6oc5lvoA3 | 28,823 | Unblock Llama2 ONNX export w/ sdpa by falling back to manual impl | {
"login": "BowenBao",
"id": 9376104,
"node_id": "MDQ6VXNlcjkzNzYxMDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/9376104?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BowenBao",
"html_url": "https://github.com/BowenBao",
"followers_url": "https://api.github.com/users/Bowen... | [] | closed | false | null | [] | [
"Hi @ArthurZucker, I have validated the issue is fixed under your PR, thanks! Do you have an ETA when it will get merged? Our workstreams have been blocked by this issue for a while, we need to resolve this export issue asap.",
"This week ๐ Waiting for @gante's green light and will merge #27931 (it was not clear... | 1,706 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28823/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28823/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28823",
"html_url": "https://github.com/huggingface/transformers/pull/28823",
"diff_url": "https://github.com/huggingface/transformers/pull/28823.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28823.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28822 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28822/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28822/comments | https://api.github.com/repos/huggingface/transformers/issues/28822/events | https://github.com/huggingface/transformers/issues/28822 | 2,113,287,140 | I_kwDOCUB6oc599jPk | 28,822 | Prompt feature causing repetitions and hallucinations | {
"login": "vchagari",
"id": 10948110,
"node_id": "MDQ6VXNlcjEwOTQ4MTEw",
"avatar_url": "https://avatars.githubusercontent.com/u/10948110?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vchagari",
"html_url": "https://github.com/vchagari",
"followers_url": "https://api.github.com/users/vch... | [] | open | false | null | [] | [
"Hi @vchagari ๐ \r\n\r\nWe would need access to the audio file to be able to reproduce the issue ๐ค (or a self-contained reproducer)"
] | 1,706 | 1,707 | null | NONE | null | ### System Info
Hi @sanchit-gandhi and @gante
Using Prompt Feature like it is mentioned here (https://github.com/huggingface/transformers/issues/22395) causing the model output to have too many repetitions and too much of hallucinations.
I recorded an audio and gave it to the Whisper ASR model with prompt like a... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28822/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28822/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28821 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28821/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28821/comments | https://api.github.com/repos/huggingface/transformers/issues/28821/events | https://github.com/huggingface/transformers/pull/28821 | 2,113,189,186 | PR_kwDOCUB6oc5lvNLD | 28,821 | Correct wav2vec2-bert inputs_to_logits_ratio | {
"login": "ylacombe",
"id": 52246514,
"node_id": "MDQ6VXNlcjUyMjQ2NTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/52246514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ylacombe",
"html_url": "https://github.com/ylacombe",
"followers_url": "https://api.github.com/users/yla... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28821). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"inputs_to_logit_ratio is:\r\n\r\n-> Inputs (raw audio) -> [32000; u32] (4s audio a... | 1,706 | 1,708 | 1,707 | COLLABORATOR | null | # What does this PR do?
`chunk_length_s` parameter doesnโt yet work for w2v2-bert, when using the ASR pipeline.
```python
from transformers import pipeline
pipe = pipeline("automatic-speech-recognition", model="ylacombe/wav2vec2-bert-CV16-en-libri-cv", device=0)
pipe("https://huggingface.co/datasets/Narsil... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28821/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28821/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28821",
"html_url": "https://github.com/huggingface/transformers/pull/28821",
"diff_url": "https://github.com/huggingface/transformers/pull/28821.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28821.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28820 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28820/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28820/comments | https://api.github.com/repos/huggingface/transformers/issues/28820/events | https://github.com/huggingface/transformers/pull/28820 | 2,113,110,830 | PR_kwDOCUB6oc5lu7XH | 28,820 | [docs] HfQuantizer | {
"login": "stevhliu",
"id": 59462357,
"node_id": "MDQ6VXNlcjU5NDYyMzU3",
"avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevhliu",
"html_url": "https://github.com/stevhliu",
"followers_url": "https://api.github.com/users/ste... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28820). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | MEMBER | null | A follow-up PR to tidy up some things for the `HfQuantizer`:
โ `HfQuantizer` to the API docs and links to the relevant files for faster navigation for users
โ I think all those emojis are a bit too much and distracting ๐
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28820/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28820/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28820",
"html_url": "https://github.com/huggingface/transformers/pull/28820",
"diff_url": "https://github.com/huggingface/transformers/pull/28820.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28820.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28819 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28819/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28819/comments | https://api.github.com/repos/huggingface/transformers/issues/28819/events | https://github.com/huggingface/transformers/pull/28819 | 2,112,998,190 | PR_kwDOCUB6oc5luiPq | 28,819 | Add MusicGen Melody | {
"login": "ylacombe",
"id": 52246514,
"node_id": "MDQ6VXNlcjUyMjQ2NTE0",
"avatar_url": "https://avatars.githubusercontent.com/u/52246514?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ylacombe",
"html_url": "https://github.com/ylacombe",
"followers_url": "https://api.github.com/users/yla... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28819). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Hey @sanchit-gandhi, thanks for the really relevant suggestions! I've addressed mo... | 1,706 | 1,708 | null | COLLABORATOR | null | # What does this PR do?
MusicGen Melody was released at the same time than the "o.g" MusicGen that has already been integrated to [`transformers`](https://huggingface.co/docs/transformers/v4.37.2/en/model_doc/musicgen#overview).
Contrarily to the already integrated model, you can condition the generation with an ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28819/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28819/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28819",
"html_url": "https://github.com/huggingface/transformers/pull/28819",
"diff_url": "https://github.com/huggingface/transformers/pull/28819.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28819.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28818 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28818/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28818/comments | https://api.github.com/repos/huggingface/transformers/issues/28818/events | https://github.com/huggingface/transformers/pull/28818 | 2,112,216,285 | PR_kwDOCUB6oc5lr03q | 28,818 | [`OWL-VIT`] Added sdpa attention | {
"login": "nileshkokane01",
"id": 8201108,
"node_id": "MDQ6VXNlcjgyMDExMDg=",
"avatar_url": "https://avatars.githubusercontent.com/u/8201108?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nileshkokane01",
"html_url": "https://github.com/nileshkokane01",
"followers_url": "https://api.gith... | [] | open | false | null | [] | [
"I have added an initial draft for sdpa attention, but I guess, more changes are needed as the OWL-ViT is a bit different compared to llama or Mistral.\r\n\r\nCan you please point me out a similar model close to OWL-ViT or rather let me know the additional changes required in the file. Also, casual_attention_mas... | 1,706 | 1,708 | null | CONTRIBUTOR | null | # What does this PR do?
This PR add sdpa attention for OWL-ViT.
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribu... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28818/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28818/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28818",
"html_url": "https://github.com/huggingface/transformers/pull/28818",
"diff_url": "https://github.com/huggingface/transformers/pull/28818.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28818.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28817 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28817/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28817/comments | https://api.github.com/repos/huggingface/transformers/issues/28817/events | https://github.com/huggingface/transformers/issues/28817 | 2,112,124,997 | I_kwDOCUB6oc595HhF | 28,817 | Populate torch_dtype from a model to a pipeline | {
"login": "B-Step62",
"id": 31463517,
"node_id": "MDQ6VXNlcjMxNDYzNTE3",
"avatar_url": "https://avatars.githubusercontent.com/u/31463517?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/B-Step62",
"html_url": "https://github.com/B-Step62",
"followers_url": "https://api.github.com/users/B-S... | [] | open | false | {
"login": "B-Step62",
"id": 31463517,
"node_id": "MDQ6VXNlcjMxNDYzNTE3",
"avatar_url": "https://avatars.githubusercontent.com/u/31463517?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/B-Step62",
"html_url": "https://github.com/B-Step62",
"followers_url": "https://api.github.com/users/B-S... | [
{
"login": "B-Step62",
"id": 31463517,
"node_id": "MDQ6VXNlcjMxNDYzNTE3",
"avatar_url": "https://avatars.githubusercontent.com/u/31463517?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/B-Step62",
"html_url": "https://github.com/B-Step62",
"followers_url": "https://api.... | [
"cc @Rocketknight1 WDYT? Sounds good to me ",
"This sounds like a safe assumption to me too, though obviously I'd like to confirm that with some tests! I'm in favour of the PR if you're happy to open it @B-Step62 ",
"@ArthurZucker @Rocketknight1 Great! I will open a PR soon, in the meantime could you assign th... | 1,706 | 1,707 | null | CONTRIBUTOR | null | ### Feature request
When constructing a pipeline object from a model and a tokenizer, the pipeline doesn't inherit the `torch_dtype` field from the underlying model.
```
model = AutoModelForCausalLM.from_pretrained("t5-small", torch_dtype = torch.bfloat16)
pipeline = pipeline(model=model, task="text-generation", ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28817/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28817/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28816 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28816/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28816/comments | https://api.github.com/repos/huggingface/transformers/issues/28816/events | https://github.com/huggingface/transformers/pull/28816 | 2,112,120,604 | PR_kwDOCUB6oc5lrfWr | 28,816 | Don't use a subset in test fetcher if on `main` branch | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | open | false | null | [] | [
"Let me know if you want me to explore the option to block a PR being merged if the last commit message is not of the form \r\n\r\n> [no_filter] xxx yyy ",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28816). All of your documentation changes will be reflected on that... | 1,706 | 1,706 | null | COLLABORATOR | null | # What does this PR do?
[I don't like surprise, like you do I guess] ๐
Don't select a subset from the detected tests to run when they are many - if we are on the main branch.
This could detect any issue as early as at the merge time, not at the nightly run.
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28816/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28816/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28816",
"html_url": "https://github.com/huggingface/transformers/pull/28816",
"diff_url": "https://github.com/huggingface/transformers/pull/28816.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28816.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28815 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28815/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28815/comments | https://api.github.com/repos/huggingface/transformers/issues/28815/events | https://github.com/huggingface/transformers/issues/28815 | 2,112,073,298 | I_kwDOCUB6oc59465S | 28,815 | codellama/CodeLlama-34b Fine-Tune Evaluation | {
"login": "sanipanwala",
"id": 44312637,
"node_id": "MDQ6VXNlcjQ0MzEyNjM3",
"avatar_url": "https://avatars.githubusercontent.com/u/44312637?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sanipanwala",
"html_url": "https://github.com/sanipanwala",
"followers_url": "https://api.github.com/... | [] | open | false | null | [] | [
"cc @younesbelkada safetensors + peft",
"hi @sanipanwala \r\ndo you face the same issue when you update `peft` and `safetensors` ? `pip install -U peft safetensors`",
"@younesbelkada ,\r\n\r\nYes, I have created a fresh conda environment and installed all the latest packages.\r\n\r\nThanks,",
"Have you used t... | 1,706 | 1,706 | null | NONE | null | Hello,
I have done training and saved the model, and adapter config file on the local disk.
When I load the model from the local disk again to generate the output I get the below error.
Anyone can help me with this issue?
`File "PythonV2.py", line 11, in <module> model = AutoPeftModelForCausalLM.from_pretra... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28815/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28815/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28814 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28814/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28814/comments | https://api.github.com/repos/huggingface/transformers/issues/28814/events | https://github.com/huggingface/transformers/issues/28814 | 2,112,036,474 | I_kwDOCUB6oc594x56 | 28,814 | Bug in whisper finetuning tutorial? "Multiple languages detected when trying to predict..." | {
"login": "SethvdAxe",
"id": 155735980,
"node_id": "U_kgDOCUhXrA",
"avatar_url": "https://avatars.githubusercontent.com/u/155735980?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SethvdAxe",
"html_url": "https://github.com/SethvdAxe",
"followers_url": "https://api.github.com/users/Sethvd... | [] | open | false | null | [] | [
"Ok, can confirm that on 4.37.2 this bug does not appear.\r\nSomething to do with https://github.com/huggingface/transformers/pull/28687 I guess?",
"cc @patrickvonplaten as well",
"I to have the same error. Verified my dataset, this is 1 language. ",
"Sorry for being a bit late here. Yes this error is expect... | 1,706 | 1,708 | null | NONE | null | ### System Info
Transformers version: 4.38.0.dev0
Python version: Python3.10 venv (local)
Platform: MacOS Venture 13.5
### Who can help?
@sanchit-gandhi
### Information
- [X] The official example scripts
- [X] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such a... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28814/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28814/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28813 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28813/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28813/comments | https://api.github.com/repos/huggingface/transformers/issues/28813/events | https://github.com/huggingface/transformers/issues/28813 | 2,112,025,332 | I_kwDOCUB6oc594vL0 | 28,813 | Adding Gradient Checkpointing and Flash Attention 2 implementation to VisionTextDualEncoderModel | {
"login": "Syrinechen",
"id": 127806472,
"node_id": "U_kgDOB54sCA",
"avatar_url": "https://avatars.githubusercontent.com/u/127806472?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Syrinechen",
"html_url": "https://github.com/Syrinechen",
"followers_url": "https://api.github.com/users/Syr... | [
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request",
"name": "Feature request",
"color": "FBCA04",
"default": false,
"description": "Request for a new feature"
},
{
"id": 3081136536,
... | open | false | null | [] | [] | 1,706 | 1,706 | null | NONE | null | VisionTextDualEncoderModel allows training any image and text encoders with a contrastive loss. Would be convenient to add gradient checkpointing as well as flash attention 2 to optimize training.
Thank you | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28813/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28813/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28812 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28812/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28812/comments | https://api.github.com/repos/huggingface/transformers/issues/28812/events | https://github.com/huggingface/transformers/pull/28812 | 2,111,988,484 | PR_kwDOCUB6oc5lrCYA | 28,812 | fixing a typo! | {
"login": "mohammad-gh009",
"id": 75425392,
"node_id": "MDQ6VXNlcjc1NDI1Mzky",
"avatar_url": "https://avatars.githubusercontent.com/u/75425392?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mohammad-gh009",
"html_url": "https://github.com/mohammad-gh009",
"followers_url": "https://api.gi... | [] | closed | false | null | [] | [] | 1,706 | 1,706 | 1,706 | NONE | null | I fixed a typo in the tutorial.
kinda --> kind of
# What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of y... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28812/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28812/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28812",
"html_url": "https://github.com/huggingface/transformers/pull/28812",
"diff_url": "https://github.com/huggingface/transformers/pull/28812.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28812.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28811 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28811/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28811/comments | https://api.github.com/repos/huggingface/transformers/issues/28811/events | https://github.com/huggingface/transformers/pull/28811 | 2,111,791,218 | PR_kwDOCUB6oc5lqWDF | 28,811 | fix dynamic_module import err | {
"login": "Fazziekey",
"id": 55798671,
"node_id": "MDQ6VXNlcjU1Nzk4Njcx",
"avatar_url": "https://avatars.githubusercontent.com/u/55798671?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Fazziekey",
"html_url": "https://github.com/Fazziekey",
"followers_url": "https://api.github.com/users/... | [] | open | false | null | [] | [
"@ArthurZucker ",
"> Hey! I think that is not too bad. IMO we should rather check if the imports are protected or not / have a list of packages that can be ignored because this will no longer warn users for every other packages that might be missing :(\r\n\r\nTheThe Ci is failed, I don't know why tf model will be... | 1,706 | 1,706 | null | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28811/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28811/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28811",
"html_url": "https://github.com/huggingface/transformers/pull/28811",
"diff_url": "https://github.com/huggingface/transformers/pull/28811.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28811.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28810 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28810/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28810/comments | https://api.github.com/repos/huggingface/transformers/issues/28810/events | https://github.com/huggingface/transformers/pull/28810 | 2,111,771,321 | PR_kwDOCUB6oc5lqRoN | 28,810 | Add `StableLM` | {
"login": "jon-tow",
"id": 41410219,
"node_id": "MDQ6VXNlcjQxNDEwMjE5",
"avatar_url": "https://avatars.githubusercontent.com/u/41410219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jon-tow",
"html_url": "https://github.com/jon-tow",
"followers_url": "https://api.github.com/users/jon-to... | [] | closed | false | null | [] | [
"Hey! Thanks for contributing! \r\nWe usually recommend to start by adding the model on the hub, to allow for a quick distribution! \r\nSee the tutorial [here](https://huggingface.co/docs/transformers/custom_models)",
"Hello!\r\n\r\n> We usually recommend to start by adding the model on the hub, to allow for a qu... | 1,706 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
This PR adds modeling support for [`StableLM 3B 4E1T`](https://huggingface.co/stabilityai/stablelm-3b-4e1t) (as well as [`StableLM 2 1.6B`](https://huggingface.co/stabilityai/stablelm-2-1_6b)) based models.
<!--
Congratulations! You've made it this far! You're not quite done yet though.
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28810/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28810/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28810",
"html_url": "https://github.com/huggingface/transformers/pull/28810",
"diff_url": "https://github.com/huggingface/transformers/pull/28810.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28810.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28809 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28809/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28809/comments | https://api.github.com/repos/huggingface/transformers/issues/28809/events | https://github.com/huggingface/transformers/pull/28809 | 2,111,763,732 | PR_kwDOCUB6oc5lqP8x | 28,809 | [`TorchFp8Quantizer`] Attempt to integrate `pytorch-labs/float8_experimental` in HF transformers | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28809). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | null | CONTRIBUTOR | null | # What does this PR do?
As per title, this PR attempts to integrate https://github.com/pytorch-labs/float8_experimental in transformers for efficient FP8 inference. To potentially combine it with https://github.com/huggingface/transformers/pull/27931 for faster text generation on newer hardwares (compute capability ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28809/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/huggingface/transformers/issues/28809/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28809",
"html_url": "https://github.com/huggingface/transformers/pull/28809",
"diff_url": "https://github.com/huggingface/transformers/pull/28809.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28809.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28808 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28808/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28808/comments | https://api.github.com/repos/huggingface/transformers/issues/28808/events | https://github.com/huggingface/transformers/issues/28808 | 2,111,643,277 | I_kwDOCUB6oc593R6N | 28,808 | It's an AlignModel or Deepspeed Zero3 bug. | {
"login": "necrophagists",
"id": 120618287,
"node_id": "U_kgDOBzB9Lw",
"avatar_url": "https://avatars.githubusercontent.com/u/120618287?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/necrophagists",
"html_url": "https://github.com/necrophagists",
"followers_url": "https://api.github.com/... | [] | open | false | null | [] | [
"Hey! Could you give a reproducible snippet? ๐ค ",
"> Hey! Could you give a reproducible snippet? ๐ค\r\n\r\nSorry, this is a company project so I can't provide you with the relevant code. I recently located here in `modeling_utils.py`๏ผ\r\n```\r\n if is_deepspeed_zero3_enabled():\r\n import deeps... | 1,706 | 1,706 | null | NONE | null | ### System Info
When I try to load the AlignModel weights locally and train them using zero3, I get the following error๏ผ
```
File "/opt/licy/MyVLM/model/builder.py", line 152, in load_model
model =AlignModel.from_pretrained(self.args.vm_path)
File "/usr/local/lib/python3.8/dist-packages/transformers/model... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28808/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28808/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28807 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28807/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28807/comments | https://api.github.com/repos/huggingface/transformers/issues/28807/events | https://github.com/huggingface/transformers/issues/28807 | 2,111,597,249 | I_kwDOCUB6oc593GrB | 28,807 | GPT2 minicons surprisal: IndexError: index out of range in self | {
"login": "joyce9936",
"id": 119527282,
"node_id": "U_kgDOBx_Xcg",
"avatar_url": "https://avatars.githubusercontent.com/u/119527282?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/joyce9936",
"html_url": "https://github.com/joyce9936",
"followers_url": "https://api.github.com/users/joyce9... | [] | closed | false | null | [] | [
"Sorry but this seems unrelated to transformers and rather related to the `scorer` library. "
] | 1,706 | 1,706 | 1,706 | NONE | null | ### System Info
I am trying to calculating surprisal value by feeding in a txt file with about 5000 sentences. But there is a error message I encounter: **IndexError: index out of range in self** Can anyone help with this issue?
Thank you!
### Who can help?
_No response_
### Information
- [ ] The ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28807/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28807/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28806 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28806/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28806/comments | https://api.github.com/repos/huggingface/transformers/issues/28806/events | https://github.com/huggingface/transformers/pull/28806 | 2,111,564,467 | PR_kwDOCUB6oc5lpkdt | 28,806 | [docs] fix some bugs about parameter description | {
"login": "zspo",
"id": 26846598,
"node_id": "MDQ6VXNlcjI2ODQ2NTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/26846598?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zspo",
"html_url": "https://github.com/zspo",
"followers_url": "https://api.github.com/users/zspo/followers"... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28806). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
Fixes
1. fix missing spaces in parameter descriptions
2. add parameter description
@amyeroberts | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28806/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28806/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28806",
"html_url": "https://github.com/huggingface/transformers/pull/28806",
"diff_url": "https://github.com/huggingface/transformers/pull/28806.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28806.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28805 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28805/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28805/comments | https://api.github.com/repos/huggingface/transformers/issues/28805/events | https://github.com/huggingface/transformers/issues/28805 | 2,111,545,003 | I_kwDOCUB6oc59256r | 28,805 | sequence_bias feature is not working for Whisper ASR model. | {
"login": "vchagari",
"id": 10948110,
"node_id": "MDQ6VXNlcjEwOTQ4MTEw",
"avatar_url": "https://avatars.githubusercontent.com/u/10948110?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vchagari",
"html_url": "https://github.com/vchagari",
"followers_url": "https://api.github.com/users/vch... | [] | open | false | null | [] | [
"Hi @vchagari ๐ \r\n\r\nThe [same comment](https://github.com/huggingface/transformers/issues/28822) applies here :)"
] | 1,706 | 1,707 | null | NONE | null | ### System Info
Hi @sanchit-gandhi and @gante
Sequence_bias feature is not working, I tried with similar example shown in the SequenceBiasLogitsProcessor class (https://github.com/huggingface/transformers/blob/7b2bd1fbbd50e57cf28013e2d0737912ecc0f2eb/src/transformers/generation/logits_process.py#L942) with fine-tu... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28805/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28805/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28804 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28804/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28804/comments | https://api.github.com/repos/huggingface/transformers/issues/28804/events | https://github.com/huggingface/transformers/pull/28804 | 2,111,349,806 | PR_kwDOCUB6oc5lo0Uj | 28,804 | Add missing None check for hf_quantizer | {
"login": "jganitkevitch",
"id": 190837,
"node_id": "MDQ6VXNlcjE5MDgzNw==",
"avatar_url": "https://avatars.githubusercontent.com/u/190837?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jganitkevitch",
"html_url": "https://github.com/jganitkevitch",
"followers_url": "https://api.github.co... | [] | closed | false | null | [] | [
"@younesbelkada @ArthurZucker @poedator ",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28804). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Added a test. PTAL โ I'm not familiar... | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | Adds None check for hf_quantizer that otherwise can blow up when `from_pretrained` is called with `quanitization_config=None`.
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28804/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28804/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28804",
"html_url": "https://github.com/huggingface/transformers/pull/28804",
"diff_url": "https://github.com/huggingface/transformers/pull/28804.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28804.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28803 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28803/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28803/comments | https://api.github.com/repos/huggingface/transformers/issues/28803/events | https://github.com/huggingface/transformers/issues/28803 | 2,111,240,846 | I_kwDOCUB6oc591vqO | 28,803 | DeepSpeed ZeRO3 errors on config initialization | {
"login": "matthewdeng",
"id": 3967392,
"node_id": "MDQ6VXNlcjM5NjczOTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/3967392?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/matthewdeng",
"html_url": "https://github.com/matthewdeng",
"followers_url": "https://api.github.com/us... | [] | open | false | null | [] | [
"cc @pacman100 and @SunMarc "
] | 1,706 | 1,706 | null | NONE | null | ### System Info
`transformers-cli env`:
- `transformers` version: 4.37.2
- Platform: Linux-6.2.0-1017-aws-x86_64-with-glibc2.31
- Python version: 3.9.18
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: 0.26.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28803/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28803/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28802 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28802/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28802/comments | https://api.github.com/repos/huggingface/transformers/issues/28802/events | https://github.com/huggingface/transformers/pull/28802 | 2,111,123,817 | PR_kwDOCUB6oc5loDqD | 28,802 | [`BERT`] Add support for sdpa | {
"login": "hackyon",
"id": 1557853,
"node_id": "MDQ6VXNlcjE1NTc4NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1557853?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hackyon",
"html_url": "https://github.com/hackyon",
"followers_url": "https://api.github.com/users/hackyon/... | [] | open | false | null | [] | [
"Hey @ArthurZucker @younesbelkada\r\n\r\nI was thinking SDPA (#28005) could be a good addition to BERT, so I drafted this change. It doesn't look too hairy so far.\r\n\r\nAs @ArthurZucker mentioned, BERT doesn't have a lot of params so there might not be much of a speedup, but this didn't look too difficult to impl... | 1,706 | 1,708 | null | CONTRIBUTOR | null | # What does this PR do?
Adding support for SDPA (scaled dot product attention) for Bert. More context in #28005.
Benchmarking Results on A100-80GB, CPUx12, RAM 96.6GB, OS Ubuntu 22.04, using BertLMHeadModel
Training benchmark based on [fxmarty's script](https://gist.github.com/fxmarty/7e75cc3942d6974e4849093eb... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28802/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28802/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28802",
"html_url": "https://github.com/huggingface/transformers/pull/28802",
"diff_url": "https://github.com/huggingface/transformers/pull/28802.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28802.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28801 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28801/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28801/comments | https://api.github.com/repos/huggingface/transformers/issues/28801/events | https://github.com/huggingface/transformers/issues/28801 | 2,111,003,139 | I_kwDOCUB6oc5901oD | 28,801 | Conversational Pipeline returns <|im_end|> in the assistant's output. | {
"login": "OfficialDelta",
"id": 51007646,
"node_id": "MDQ6VXNlcjUxMDA3NjQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/51007646?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/OfficialDelta",
"html_url": "https://github.com/OfficialDelta",
"followers_url": "https://api.githu... | [] | open | false | null | [] | [
"Hey! Thanks for the detailed issue. I donโt think the solution is to monkey patch pipeline. IMO the best practice is to define a single stop token, and not rely on strings (which as you mentioned is brittle because of previous tokens). ",
"Thank you for your quick response.\r\n\r\nIs it possible to configure suc... | 1,706 | 1,706 | null | NONE | null | ### System Info
- `transformers` version: 4.37.2
- Platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.35
- Python version: 3.10.13
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.4.2
- Accelerate version: 0.26.1
- Accelerate config: - compute_environment: LOCAL_MACHINE
- distributed_type... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28801/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28801/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28800 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28800/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28800/comments | https://api.github.com/repos/huggingface/transformers/issues/28800/events | https://github.com/huggingface/transformers/pull/28800 | 2,110,827,898 | PR_kwDOCUB6oc5lnDE6 | 28,800 | `erfinv_` and `clamp_` ops do not exist in float16+cpu | {
"login": "VictorSanh",
"id": 16107619,
"node_id": "MDQ6VXNlcjE2MTA3NjE5",
"avatar_url": "https://avatars.githubusercontent.com/u/16107619?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VictorSanh",
"html_url": "https://github.com/VictorSanh",
"followers_url": "https://api.github.com/use... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28800). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | null | MEMBER | null | On cpu, some ops are not defined. This messes up a lot of init weights operations for siglip.
I know fp16 + CPU is weird and probably never happening in practise. As such, feel free to ignore this PR.
Reproduction case:
```python
from transformers import AutoModel, AutoConfig
import torch
config = AutoConfig.fr... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28800/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28800/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28800",
"html_url": "https://github.com/huggingface/transformers/pull/28800",
"diff_url": "https://github.com/huggingface/transformers/pull/28800.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28800.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28799 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28799/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28799/comments | https://api.github.com/repos/huggingface/transformers/issues/28799/events | https://github.com/huggingface/transformers/issues/28799 | 2,110,630,743 | I_kwDOCUB6oc59zatX | 28,799 | `token` parameter not respected for `AutoModel` | {
"login": "squidarth",
"id": 850115,
"node_id": "MDQ6VXNlcjg1MDExNQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/850115?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/squidarth",
"html_url": "https://github.com/squidarth",
"followers_url": "https://api.github.com/users/squi... | [] | open | false | null | [] | [
"Hey! Thanks for reporting. Could you provide the traceback? \r\n",
"Hi @ArthurZucker -- it's this:\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"/usr/local/lib/python3.9/site-packages/huggingface_hub/utils/_errors.py\", line 261, in hf_raise_for_status\r\n response.raise_for_status()\r\n File ... | 1,706 | 1,706 | null | NONE | null | ### System Info
transformers version: 4.37.2
(`transformers-cli env` errored out for me)
### Who can help?
@ArthurZucker @younesbelkada
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD,... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28799/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28799/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28798 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28798/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28798/comments | https://api.github.com/repos/huggingface/transformers/issues/28798/events | https://github.com/huggingface/transformers/pull/28798 | 2,110,437,958 | PR_kwDOCUB6oc5lltWB | 28,798 | fix some docs and tensor device bug | {
"login": "zspo",
"id": 26846598,
"node_id": "MDQ6VXNlcjI2ODQ2NTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/26846598?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zspo",
"html_url": "https://github.com/zspo",
"followers_url": "https://api.github.com/users/zspo/followers"... | [] | closed | false | null | [] | [
"Hi @zspo, thanks for opening this PR and contributing to the repo! \r\n\r\nThis PR contains a handle of unrelated changes. Let's split up the doc changes from the device placement ones. "
] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
Fixes
1. fix missing spaces in parameter descriptions
2. fix tensor device
3. add parameter description
## Who can review?
@ArthurZucker @amyeroberts
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28798/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28798/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28798",
"html_url": "https://github.com/huggingface/transformers/pull/28798",
"diff_url": "https://github.com/huggingface/transformers/pull/28798.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28798.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28797 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28797/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28797/comments | https://api.github.com/repos/huggingface/transformers/issues/28797/events | https://github.com/huggingface/transformers/issues/28797 | 2,110,224,239 | I_kwDOCUB6oc59x3dv | 28,797 | Segmentation fault when importing ESMFold and Tokenizers from transformers along with Pyrosetta | {
"login": "SIAndersson",
"id": 117816326,
"node_id": "U_kgDOBwW8Bg",
"avatar_url": "https://avatars.githubusercontent.com/u/117816326?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SIAndersson",
"html_url": "https://github.com/SIAndersson",
"followers_url": "https://api.github.com/users/... | [] | open | false | null | [] | [
"cc @Rocketknight1 maybe we can reproduce? ",
"Hi @SIAndersson this is quite an unusual bug! We'll see what we can figure out - in the meantime, if you have any other machines you can test on, can you try it there? \r\n\r\nAlso, the `EsmForProteinFolding` model in `Transformers` doesn't import anything unusual, s... | 1,706 | 1,706 | null | NONE | null | ### System Info
- `transformers` version: 4.37.1
- Platform: Linux-4.18.0-513.11.1.el8_9.x86_64-x86_64-with-glibc2.28
- Python version: 3.9.16
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.3.3
- Accelerate version: 0.26.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (True)
- Ten... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28797/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28797/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28796 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28796/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28796/comments | https://api.github.com/repos/huggingface/transformers/issues/28796/events | https://github.com/huggingface/transformers/pull/28796 | 2,110,160,851 | PR_kwDOCUB6oc5lkv1u | 28,796 | Make `is_torch_bf16_available_on_device` more strict | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28796). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Yes, but we get the same set of tests to run as before. Nothing change. And if on ... | 1,706 | 1,706 | 1,706 | COLLABORATOR | null | # What does this PR do?
The layernorm op is required to be supported in order for this function to return `True`.
### detail
Previously, the function `is_torch_bf16_available_on_device` check
```python
x = torch.zeros(2, 2, dtype=torch.float16).to(device)
_ = x @ x
```
With torch < 2.2 on ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28796/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28796/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28796",
"html_url": "https://github.com/huggingface/transformers/pull/28796",
"diff_url": "https://github.com/huggingface/transformers/pull/28796.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28796.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28795 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28795/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28795/comments | https://api.github.com/repos/huggingface/transformers/issues/28795/events | https://github.com/huggingface/transformers/pull/28795 | 2,110,014,175 | PR_kwDOCUB6oc5lkPbU | 28,795 | canonical repos moves | {
"login": "julien-c",
"id": 326577,
"node_id": "MDQ6VXNlcjMyNjU3Nw==",
"avatar_url": "https://avatars.githubusercontent.com/u/326577?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/julien-c",
"html_url": "https://github.com/julien-c",
"followers_url": "https://api.github.com/users/julien-... | [] | closed | false | null | [] | [
"Already done :)",
"too quick",
"test is flaky no @ArthurZucker ?",
"Yes merging without it",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28795). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after th... | 1,706 | 1,706 | 1,706 | MEMBER | null | we are phasing out canonical models & datasets (as a reminder, "canonical" repos are those that were not under an org or user namespace) and moving them under ad hoc organization namespaces
Note that this move should be backward compatible i.e. old versions of transformers that do `AutoModel.from_pretrained("gpt2")`... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28795/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28795/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28795",
"html_url": "https://github.com/huggingface/transformers/pull/28795",
"diff_url": "https://github.com/huggingface/transformers/pull/28795.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28795.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28794 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28794/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28794/comments | https://api.github.com/repos/huggingface/transformers/issues/28794/events | https://github.com/huggingface/transformers/issues/28794 | 2,109,842,049 | I_kwDOCUB6oc59waKB | 28,794 | BART-base flash_attention_2 causes CUDA error | {
"login": "Kripner",
"id": 9218121,
"node_id": "MDQ6VXNlcjkyMTgxMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9218121?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kripner",
"html_url": "https://github.com/Kripner",
"followers_url": "https://api.github.com/users/Kripner/... | [] | open | false | null | [] | [
"Hey! Thanks for raising the issue, this seems to be a hardware related issue see example issues: https://github.com/nerfstudio-project/nerfacc/issues/207 nothing much we can do on our side I believe. FYI @younesbelkada ",
"Hmm not sure what is wrong here, can you try to train the model without padd tokens by pac... | 1,706 | 1,707 | null | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.37.0
- Platform: Linux-6.5.0-15-generic-x86_64-with-glibc2.31
- Python version: 3.10.13
- Huggingface_hub version: 0.20.3
- Safetensors version: 0.4.1
- Accelerate version: 0.26.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (True)
- Tensorflow ver... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28794/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28794/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28793 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28793/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28793/comments | https://api.github.com/repos/huggingface/transformers/issues/28793/events | https://github.com/huggingface/transformers/issues/28793 | 2,109,683,159 | I_kwDOCUB6oc59vzXX | 28,793 | BART-base save_pretrained triggers a warning about GenerationConfig | {
"login": "Kripner",
"id": 9218121,
"node_id": "MDQ6VXNlcjkyMTgxMjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/9218121?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Kripner",
"html_url": "https://github.com/Kripner",
"followers_url": "https://api.github.com/users/Kripner/... | [] | open | false | null | [] | [
"Hey that is expected as it is a pretty old model! You can safely ignore this for now, otherwise they should be removed. Feel free to open an issue on the repository's discussion tab ! "
] | 1,706 | 1,706 | null | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.37.0
- Platform: Linux-6.5.0-15-generic-x86_64-with-glibc2.31
- Python version: 3.10.13
- Huggingface_hub version: 0.20.3
- Safetensors version: 0.4.1
- Accelerate version: 0.26.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (True)
- Tensorflow v... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28793/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28793/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28792 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28792/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28792/comments | https://api.github.com/repos/huggingface/transformers/issues/28792/events | https://github.com/huggingface/transformers/issues/28792 | 2,109,525,178 | I_kwDOCUB6oc59vMy6 | 28,792 | Add InternLM1 & InternLM2 model | {
"login": "PommesPeter",
"id": 54879512,
"node_id": "MDQ6VXNlcjU0ODc5NTEy",
"avatar_url": "https://avatars.githubusercontent.com/u/54879512?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/PommesPeter",
"html_url": "https://github.com/PommesPeter",
"followers_url": "https://api.github.com/... | [
{
"id": 1843244711,
"node_id": "MDU6TGFiZWwxODQzMjQ0NzEx",
"url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model",
"name": "New model",
"color": "fbca04",
"default": false,
"description": ""
}
] | closed | false | null | [] | [
"Hey! Thanks, seems like it's already supported: #26302 ",
"> Hey! Thanks, seems like it's already supported: #26302\r\n\r\nAlright. I will find another \"good\" model to implement. Closed."
] | 1,706 | 1,706 | 1,706 | NONE | null | ### Model description
Hey,
the recently released [InternLM](https://github.com/InternLM/InternLM) seems like it would be a nice addition to transformers.
Basically, the model has achieved performance that currently exceeds LLaMA2, Mistral, and other models on many Benchmarks. Adding the model to transformers makes... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28792/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28792/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28791 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28791/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28791/comments | https://api.github.com/repos/huggingface/transformers/issues/28791/events | https://github.com/huggingface/transformers/issues/28791 | 2,109,431,587 | I_kwDOCUB6oc59u18j | 28,791 | Inappropriate reduce operation of "num_input_tokens_seen" is prone to get training stuck. | {
"login": "YouliangHUANG",
"id": 56789071,
"node_id": "MDQ6VXNlcjU2Nzg5MDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/56789071?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/YouliangHUANG",
"html_url": "https://github.com/YouliangHUANG",
"followers_url": "https://api.githu... | [] | open | false | null | [] | [
"```\r\n File \"/opt/conda/lib/python3.10/site-packages/transformers/trainer.py\", line 1851, in _inner_training_loop\r\n self.state.num_input_tokens_seen += torch.sum(self.accelerator.gather(\r\n File \"/opt/conda/lib/python3.10/site-packages/accelerate/accelerator.py\", line 2159, in gather\r\n return gat... | 1,706 | 1,708 | null | NONE | null | ### System Info
Trivial
### Who can help?
@pacman100
### Information
- [X] The official example scripts
- [X] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X] My own task or dataset (give details below)
### Reproduct... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28791/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/huggingface/transformers/issues/28791/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28790 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28790/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28790/comments | https://api.github.com/repos/huggingface/transformers/issues/28790/events | https://github.com/huggingface/transformers/pull/28790 | 2,109,295,655 | PR_kwDOCUB6oc5lhzmV | 28,790 | ๐ [i18n-ZH] Translate chat_templating.md into Chinese | {
"login": "shibing624",
"id": 10249622,
"node_id": "MDQ6VXNlcjEwMjQ5NjIy",
"avatar_url": "https://avatars.githubusercontent.com/u/10249622?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shibing624",
"html_url": "https://github.com/shibing624",
"followers_url": "https://api.github.com/use... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28790). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
" @yyLeaves @jiaqiw09 @bojone @yuanzhoulvpi please help to reviewing the translate... | 1,706 | 1,708 | null | NONE | null | # What does this PR do?
Translate chat_templating.md into Chinese
part of https://github.com/huggingface/transformers/issues/20095
## Who can review?
Documentation: @stevhliu
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interes... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28790/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28790/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28790",
"html_url": "https://github.com/huggingface/transformers/pull/28790",
"diff_url": "https://github.com/huggingface/transformers/pull/28790.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28790.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28789 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28789/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28789/comments | https://api.github.com/repos/huggingface/transformers/issues/28789/events | https://github.com/huggingface/transformers/pull/28789 | 2,109,140,665 | PR_kwDOCUB6oc5lhS3S | 28,789 | [`HFQuantizer`] Remove `check_packages_compatibility` logic | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28789). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
Fixes the currently failing tests for AWQ: https://github.com/huggingface/transformers/actions/runs/7705429360/job/21003940543
I propose to remove the `check_package_compatiblity` logic in the `HfQuantizer` as:1
1- it is a duplicate of `validate_environment`
2- For some packages such as ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28789/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28789/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28789",
"html_url": "https://github.com/huggingface/transformers/pull/28789",
"diff_url": "https://github.com/huggingface/transformers/pull/28789.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28789.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28788 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28788/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28788/comments | https://api.github.com/repos/huggingface/transformers/issues/28788/events | https://github.com/huggingface/transformers/pull/28788 | 2,109,011,519 | PR_kwDOCUB6oc5lg3IY | 28,788 | [`bnb`] Fix bnb slow tests | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28788). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
Fixes the current failing BNB slow tests on main: https://github.com/huggingface/transformers/actions/runs/7705429360/job/21003940543
https://github.com/huggingface/transformers/pull/28266 broke the tests which has been merged right before the quantizer refactoring PR.
Since the attri... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28788/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28788/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28788",
"html_url": "https://github.com/huggingface/transformers/pull/28788",
"diff_url": "https://github.com/huggingface/transformers/pull/28788.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28788.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28787 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28787/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28787/comments | https://api.github.com/repos/huggingface/transformers/issues/28787/events | https://github.com/huggingface/transformers/issues/28787 | 2,108,486,087 | I_kwDOCUB6oc59rPHH | 28,787 | Converting TF2 SavedModel models to Huggingface | {
"login": "jhyuklee",
"id": 7017152,
"node_id": "MDQ6VXNlcjcwMTcxNTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/7017152?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jhyuklee",
"html_url": "https://github.com/jhyuklee",
"followers_url": "https://api.github.com/users/jhyuk... | [] | open | false | null | [] | [
"cc @Rocketknight1 ",
"Hi @jhyuklee, take a look at the `convert-gtr` notebook in the HuggingFace sentence transformers repos [here](https://huggingface.co/sentence-transformers/gtr-t5-base/blob/main/convert-gtr.ipynb). This shows the process of converting a model from the TF Hub, so you should be able to adapt t... | 1,706 | 1,706 | null | NONE | null | Hi, I'd like to know how I can convert a TF2 SavedModel (e.g. [gtr-base-1](https://www.kaggle.com/models/google/gtr/frameworks/tensorFlow2/variations/gtr-base/versions/1?tfhub-redirect=true)) to a Huggingface PyTorch model as described in the [README](https://huggingface.co/sentence-transformers/gtr-t5-base). We have a... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28787/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28787/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28786 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28786/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28786/comments | https://api.github.com/repos/huggingface/transformers/issues/28786/events | https://github.com/huggingface/transformers/pull/28786 | 2,108,463,918 | PR_kwDOCUB6oc5le-7o | 28,786 | [docs] Correct the statement in the docstirng of compute_transition_scores in generation/utils.py | {
"login": "Ki-Seki",
"id": 60967965,
"node_id": "MDQ6VXNlcjYwOTY3OTY1",
"avatar_url": "https://avatars.githubusercontent.com/u/60967965?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ki-Seki",
"html_url": "https://github.com/Ki-Seki",
"followers_url": "https://api.github.com/users/Ki-Sek... | [] | closed | false | null | [] | [] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
In the `compute_transition_scores` function's docstring, the table in Example 1 should refer to `log probability` instead of `logits`. This is because setting `normalize_logits=True` transforms the `logits` into `log probability`, according: to [generation/utils.py#L1012-L1015](https://github... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28786/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28786/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28786",
"html_url": "https://github.com/huggingface/transformers/pull/28786",
"diff_url": "https://github.com/huggingface/transformers/pull/28786.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28786.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28785 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28785/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28785/comments | https://api.github.com/repos/huggingface/transformers/issues/28785/events | https://github.com/huggingface/transformers/pull/28785 | 2,108,441,688 | PR_kwDOCUB6oc5le6GM | 28,785 | Pin Torch to <2.2.0 | {
"login": "Rocketknight1",
"id": 12866554,
"node_id": "MDQ6VXNlcjEyODY2NTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Rocketknight1",
"html_url": "https://github.com/Rocketknight1",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28785). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"thanks . merged now to prevent people crying on their PRs"
] | 1,706 | 1,706 | 1,706 | MEMBER | null | PyTorch 2.2.0 was pushed to `pip` about 30 minutes ago and is causing our CI to fail. It isn't showing up on Pytorch.org yet, so this may be an accidental push from the maintainers (the same thing happened with TF 2.16 last week)
For now, we pin `torch<2.2.0` to fix the CI. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28785/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28785/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28785",
"html_url": "https://github.com/huggingface/transformers/pull/28785",
"diff_url": "https://github.com/huggingface/transformers/pull/28785.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28785.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28784 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28784/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28784/comments | https://api.github.com/repos/huggingface/transformers/issues/28784/events | https://github.com/huggingface/transformers/pull/28784 | 2,108,418,715 | PR_kwDOCUB6oc5le1F4 | 28,784 | Backbone kwargs in config | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28784). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"@ArthurZucker Sure! \r\n\r\nWe want to remove the hard-coded conditional logic ins... | 1,706 | 1,707 | 1,707 | COLLABORATOR | null | # What does this PR do?
This enables configuring the backbones through the config directly e.g. passing in `out_indices` to the backbone. This enables configuring a model's backbone when it's loaded from a pretrained checkpoint. At the moment, this is only possible when loading from a `backbone_config`.
Example:
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28784/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28784/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28784",
"html_url": "https://github.com/huggingface/transformers/pull/28784",
"diff_url": "https://github.com/huggingface/transformers/pull/28784.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28784.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28783 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28783/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28783/comments | https://api.github.com/repos/huggingface/transformers/issues/28783/events | https://github.com/huggingface/transformers/pull/28783 | 2,108,360,963 | PR_kwDOCUB6oc5leomi | 28,783 | Ability to override clean_code_for_run | {
"login": "w4ffl35",
"id": 25737761,
"node_id": "MDQ6VXNlcjI1NzM3NzYx",
"avatar_url": "https://avatars.githubusercontent.com/u/25737761?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/w4ffl35",
"html_url": "https://github.com/w4ffl35",
"followers_url": "https://api.github.com/users/w4ffl3... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28783). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"> Thanks for the PR, looks alright, make sure to heck the evaluate agent as well! ... | 1,706 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
Adds an interface function called `clean_code_for_run` to the `Agent` class.
This function simply returns the results of `clean_code_for_run()`, which was happening on line 349.
The reason for this change is to allow developers to override the results of the `clean_code_for_run` function ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28783/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28783/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28783",
"html_url": "https://github.com/huggingface/transformers/pull/28783",
"diff_url": "https://github.com/huggingface/transformers/pull/28783.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28783.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28782 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28782/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28782/comments | https://api.github.com/repos/huggingface/transformers/issues/28782/events | https://github.com/huggingface/transformers/pull/28782 | 2,108,349,430 | PR_kwDOCUB6oc5lemGG | 28,782 | Add ability to override clean code for run | {
"login": "w4ffl35",
"id": 25737761,
"node_id": "MDQ6VXNlcjI1NzM3NzYx",
"avatar_url": "https://avatars.githubusercontent.com/u/25737761?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/w4ffl35",
"html_url": "https://github.com/w4ffl35",
"followers_url": "https://api.github.com/users/w4ffl3... | [] | closed | false | null | [] | [] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
Adds an interface function called `clean_code_for_run` to the `Agent` class.
This function simply returns the results of `clean_code_for_run()`, which was happening on line 349.
The reason for this change is to allow developers to override the results of the `clean_code_for_run` function ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28782/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28782/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28782",
"html_url": "https://github.com/huggingface/transformers/pull/28782",
"diff_url": "https://github.com/huggingface/transformers/pull/28782.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28782.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28781 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28781/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28781/comments | https://api.github.com/repos/huggingface/transformers/issues/28781/events | https://github.com/huggingface/transformers/issues/28781 | 2,108,336,306 | I_kwDOCUB6oc59qqiy | 28,781 | Unable to use torch scripting to export Mask2Former model | {
"login": "rayryeng",
"id": 765375,
"node_id": "MDQ6VXNlcjc2NTM3NQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/765375?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rayryeng",
"html_url": "https://github.com/rayryeng",
"followers_url": "https://api.github.com/users/rayryen... | [
{
"id": 3081136536,
"node_id": "MDU6TGFiZWwzMDgxMTM2NTM2",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20Difficult%20Issue",
"name": "Good Difficult Issue",
"color": "684CC7",
"default": false,
"description": ""
}
] | open | false | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [
{
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "htt... | [
"Hi @rayryeng, thanks for raising this issue and for the detailed PR description, it really helps us address issues ๐ค \r\n\r\nNo, the model isn't compatible with `torch.script` yet unfortunately. I think the correct type is being passed, it's just the model has several assumptions / logic flows / incorrect typing ... | 1,706 | 1,706 | null | NONE | null | ### System Info
- `transformers` version: 4.34.1
- Platform: Linux-5.4.0-100-generic-x86_64-with-glibc2.17
- Python version: 3.8.18
- Huggingface_hub version: 0.17.3
- Safetensors version: 0.4.0
- Accelerate version: 0.23.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (True)
- Tens... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28781/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/huggingface/transformers/issues/28781/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28780 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28780/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28780/comments | https://api.github.com/repos/huggingface/transformers/issues/28780/events | https://github.com/huggingface/transformers/pull/28780 | 2,108,249,014 | PR_kwDOCUB6oc5leQT9 | 28,780 | Further pin pytest version (in a temporary way) | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"A [run](https://app.circleci.com/pipelines/github/huggingface/transformers/83431/workflows/145ee093-f7cb-4912-a64c-6b7f6ca74e98/jobs/1075839) shows we do get the desired version (pytest==7.4.4) now. (see `Show installed libraries and their versions`)",
"The docs for this PR live [here](https://moon-ci-docs.huggi... | 1,706 | 1,706 | 1,706 | COLLABORATOR | null | # What does this PR do?
#28758 tried to pin `pytest<8.0.0` version, however, in `doc_test_job` job, there is a command
> pip install --upgrade --upgrade-strategy eager pytest pytest-sugar
which bring it back to `8.0.0` again after the desired version being installed with `pip install -e .[dev]`.
This PR ch... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28780/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28780/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28780",
"html_url": "https://github.com/huggingface/transformers/pull/28780",
"diff_url": "https://github.com/huggingface/transformers/pull/28780.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28780.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28779 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28779/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28779/comments | https://api.github.com/repos/huggingface/transformers/issues/28779/events | https://github.com/huggingface/transformers/pull/28779 | 2,108,242,406 | PR_kwDOCUB6oc5leO29 | 28,779 | Prevent MLflow exception from disrupting training | {
"login": "codiceSpaghetti",
"id": 71273533,
"node_id": "MDQ6VXNlcjcxMjczNTMz",
"avatar_url": "https://avatars.githubusercontent.com/u/71273533?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/codiceSpaghetti",
"html_url": "https://github.com/codiceSpaghetti",
"followers_url": "https://api... | [] | closed | false | null | [] | [] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | This PR prevents a training in progress from **being interrupted** due to a problem with the MLflow server (e.g., lack of connectivity) and will make the code more **faul-tolerant**, as also discussed in [this](https://github.com/mlflow/mlflow/issues/1550) MLflow issue.
This can be achieved by simply changing the `s... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28779/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28779/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28779",
"html_url": "https://github.com/huggingface/transformers/pull/28779",
"diff_url": "https://github.com/huggingface/transformers/pull/28779.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28779.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28778 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28778/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28778/comments | https://api.github.com/repos/huggingface/transformers/issues/28778/events | https://github.com/huggingface/transformers/issues/28778 | 2,108,209,721 | I_kwDOCUB6oc59qLo5 | 28,778 | OWL-VIT Finetuning code for custom dataset in Hugging Face | {
"login": "solomonmanuelraj",
"id": 25194971,
"node_id": "MDQ6VXNlcjI1MTk0OTcx",
"avatar_url": "https://avatars.githubusercontent.com/u/25194971?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/solomonmanuelraj",
"html_url": "https://github.com/solomonmanuelraj",
"followers_url": "https://... | [] | open | false | null | [] | [
"cc @younesbelkada ",
"Hi @solomonmanuelraj \r\nThanks for the issue, OwlViT cannot be used out of the box with HF trainer, you need either to subclass it with a new class and overwrite the method that computes the loss or design your own custom training loop.\r\nYou can have a look at this notebook from @NielsRo... | 1,706 | 1,708 | null | NONE | null | ### Feature request
Hi team,
when i am trying to finetune owl-vit base 32 model with custom data cppe-5 i am receiving the following error in the time of trainer.train() function.
######################################################################################################################
ValueEr... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28778/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28778/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28777 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28777/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28777/comments | https://api.github.com/repos/huggingface/transformers/issues/28777/events | https://github.com/huggingface/transformers/pull/28777 | 2,108,139,886 | PR_kwDOCUB6oc5ld4rb | 28,777 | Adds LlamaForQuestionAnswering class in modeling_llama.py along with AutoModel Support | {
"login": "nakranivaibhav",
"id": 67785830,
"node_id": "MDQ6VXNlcjY3Nzg1ODMw",
"avatar_url": "https://avatars.githubusercontent.com/u/67785830?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nakranivaibhav",
"html_url": "https://github.com/nakranivaibhav",
"followers_url": "https://api.gi... | [] | closed | false | null | [] | [
"@ArthurZucker Alright the capitalization in the copy statement affects the test. Thank you for pointing it out.",
"Now letโs make sure the CIs are green! Feel free to rebase on main! ",
"@ArthurZucker I did rebase on main, still the tests are failing. What's wrong?\r\nI did \r\n`git fetch upstream ->\r\ngit re... | 1,706 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
Adds AutoModelForQuestionAnswering support for llama.
Fixes # (issue)
#28265
## Who can review?
@ArthurZucker @NielsRogge
I haven't added a copy statement. When I try to add the following copy statement
`# Copied from transformers.models.bloom.modeling_bloom.BloomForQuestionAnsweri... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28777/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28777/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28777",
"html_url": "https://github.com/huggingface/transformers/pull/28777",
"diff_url": "https://github.com/huggingface/transformers/pull/28777.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28777.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28776 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28776/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28776/comments | https://api.github.com/repos/huggingface/transformers/issues/28776/events | https://github.com/huggingface/transformers/issues/28776 | 2,108,044,294 | I_kwDOCUB6oc59pjQG | 28,776 | Allow disabling of deletion of leading SPIECE_UNDERLINE during llama decoding (tokenizer). | {
"login": "JoshC8C7",
"id": 32071009,
"node_id": "MDQ6VXNlcjMyMDcxMDA5",
"avatar_url": "https://avatars.githubusercontent.com/u/32071009?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JoshC8C7",
"html_url": "https://github.com/JoshC8C7",
"followers_url": "https://api.github.com/users/Jos... | [] | open | false | null | [] | [
"I believe this is somewhat related to #28010 ",
"Yes, will be fixed by #28010 ! ๐ค "
] | 1,706 | 1,706 | null | NONE | null | ### Feature request
The `LlamaTokenizer`'s `convert_tokens_to_string` method used during decoding [has the statement](https://github.com/huggingface/transformers/blob/6f7d5db58c7c149c75642b5a4647b5cbc6c55643/src/transformers/models/llama/tokenization_llama.py#L286):
```
if tokens[0].startswith(SPIECE_UNDERLINE):
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28776/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28776/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28775 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28775/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28775/comments | https://api.github.com/repos/huggingface/transformers/issues/28775/events | https://github.com/huggingface/transformers/pull/28775 | 2,107,766,333 | PR_kwDOCUB6oc5lcnIP | 28,775 | add regnet chinese doc | {
"login": "a-strong-python",
"id": 65645246,
"node_id": "MDQ6VXNlcjY1NjQ1MjQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/65645246?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/a-strong-python",
"html_url": "https://github.com/a-strong-python",
"followers_url": "https://api... | [] | open | false | null | [] | [
"@vanpelt ",
"cc @stevhliu ",
"> Thanks for translating this! ๐ค \n> \n> Everything after the `## Resources` section can be left untranslated. These classes/methods are automatically documented with our special doc-builder syntax, [`[[autodoc]]`](https://github.com/huggingface/transformers/blob/4830f2696575988f... | 1,706 | 1,707 | null | NONE | null | Add Chinese reference documents to the regnet model | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28775/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28775/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28775",
"html_url": "https://github.com/huggingface/transformers/pull/28775",
"diff_url": "https://github.com/huggingface/transformers/pull/28775.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28775.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28774 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28774/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28774/comments | https://api.github.com/repos/huggingface/transformers/issues/28774/events | https://github.com/huggingface/transformers/pull/28774 | 2,107,572,860 | PR_kwDOCUB6oc5lb7xE | 28,774 | Fix transformers.utils.fx compatibility with torch<2.0 | {
"login": "fxmarty",
"id": 9808326,
"node_id": "MDQ6VXNlcjk4MDgzMjY=",
"avatar_url": "https://avatars.githubusercontent.com/u/9808326?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fxmarty",
"html_url": "https://github.com/fxmarty",
"followers_url": "https://api.github.com/users/fxmarty/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28774). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | COLLABORATOR | null | Fixes https://github.com/huggingface/transformers/issues/28690
Tested on 1.13 that `pytest tests/models/opt/ -k "test_torch_fx" -s -vvvvv` passes, while it is currently failing with torch<2.0 following https://github.com/huggingface/transformers/pull/28447 (`AttributeError: module 'torch.nn.functional' has no attrib... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28774/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28774/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28774",
"html_url": "https://github.com/huggingface/transformers/pull/28774",
"diff_url": "https://github.com/huggingface/transformers/pull/28774.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28774.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28773 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28773/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28773/comments | https://api.github.com/repos/huggingface/transformers/issues/28773/events | https://github.com/huggingface/transformers/pull/28773 | 2,107,424,909 | PR_kwDOCUB6oc5lbbbd | 28,773 | Split daily CI using 2 level matrix | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28773). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | COLLABORATOR | null | # What does this PR do?
This PR aims to bypass the 256 jobs limitation (in a matrix) on GitHub Actions, as we are approaching that limit soon.
The idea:
- move the model job logic into a new workflow file (it **still uses matrix**)
- call the new workflow file in the original workflow file, but pass some inpu... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28773/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28773/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28773",
"html_url": "https://github.com/huggingface/transformers/pull/28773",
"diff_url": "https://github.com/huggingface/transformers/pull/28773.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28773.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28772 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28772/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28772/comments | https://api.github.com/repos/huggingface/transformers/issues/28772/events | https://github.com/huggingface/transformers/pull/28772 | 2,107,269,695 | PR_kwDOCUB6oc5la5br | 28,772 | doc: fix a typo | {
"login": "ThibaultLengagne",
"id": 11950126,
"node_id": "MDQ6VXNlcjExOTUwMTI2",
"avatar_url": "https://avatars.githubusercontent.com/u/11950126?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ThibaultLengagne",
"html_url": "https://github.com/ThibaultLengagne",
"followers_url": "https://... | [] | closed | false | null | [] | [] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28772/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28772/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28772",
"html_url": "https://github.com/huggingface/transformers/pull/28772",
"diff_url": "https://github.com/huggingface/transformers/pull/28772.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28772.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28771 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28771/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28771/comments | https://api.github.com/repos/huggingface/transformers/issues/28771/events | https://github.com/huggingface/transformers/issues/28771 | 2,107,131,812 | I_kwDOCUB6oc59mEek | 28,771 | Mistral with FlashAttention2 | {
"login": "khalil-Hennara",
"id": 90086758,
"node_id": "MDQ6VXNlcjkwMDg2NzU4",
"avatar_url": "https://avatars.githubusercontent.com/u/90086758?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khalil-Hennara",
"html_url": "https://github.com/khalil-Hennara",
"followers_url": "https://api.gi... | [] | closed | false | null | [] | [
"I think the problem related to @ArthurZucker and @stevhliu ",
"It looks like โattn_implementationโ is supported in version 4.36. Maybe you need to try it after upgrading the transfromers library version\r\n\... | 1,706 | 1,706 | 1,706 | NONE | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.20.3
- Safetensors version: 0.4.1
- Accelerate version: 0.27.0.dev0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (True)
- Tensorflow... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28771/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28771/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28770 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28770/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28770/comments | https://api.github.com/repos/huggingface/transformers/issues/28770/events | https://github.com/huggingface/transformers/issues/28770 | 2,107,013,041 | I_kwDOCUB6oc59lnex | 28,770 | Lora + DeepSpeed non-trainer integration does not work | {
"login": "hrushikesh198",
"id": 6188036,
"node_id": "MDQ6VXNlcjYxODgwMzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/6188036?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hrushikesh198",
"html_url": "https://github.com/hrushikesh198",
"followers_url": "https://api.github.... | [] | open | false | null | [] | [
"cc @younesbelkada ",
"Hello @hrushikesh198 ,\r\n\r\nPR https://github.com/huggingface/peft/pull/1450 fixes support for DeepSpeed Z3 with zero init and `modules_to_save` config of PEFT. In the PR, we show how you can run non trainer example with Accelerate and normal training loop with an official example. \r\n\r... | 1,706 | 1,707 | null | NONE | null | ### System Info
- `transformers` version: 4.37.2
- Platform: Linux-4.19.0-24-cloud-amd64-x86_64-with-glibc2.31
- Python version: 3.10.13
- Huggingface_hub version: 0.20.3
- Safetensors version: 0.4.2
- Accelerate version: 0.26.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (True)
- Tensorflo... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28770/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28770/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28769 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28769/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28769/comments | https://api.github.com/repos/huggingface/transformers/issues/28769/events | https://github.com/huggingface/transformers/pull/28769 | 2,106,899,551 | PR_kwDOCUB6oc5lZqM9 | 28,769 | Trainer - add cache clearing and the option for batched eval metrics computation | {
"login": "FoamoftheSea",
"id": 50897218,
"node_id": "MDQ6VXNlcjUwODk3MjE4",
"avatar_url": "https://avatars.githubusercontent.com/u/50897218?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/FoamoftheSea",
"html_url": "https://github.com/FoamoftheSea",
"followers_url": "https://api.github.c... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28769). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"cc @pacman100 and @muellerzr ",
"Hey everyone, I tried to look at the logs for t... | 1,706 | 1,708 | null | CONTRIBUTOR | null | # What does this PR do?
This PR does two things which are necessary for using the Trainer in resource constrained environments (like my RTX-3070Ti machine):
1. Add cache clearing in training and evaluation loops
- This reduces peak GPU load and prevents CUDA OOM errors when running near capacity.
2. Add Train... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28769/reactions",
"total_count": 3,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 2,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/huggingface/transformers/issues/28769/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28769",
"html_url": "https://github.com/huggingface/transformers/pull/28769",
"diff_url": "https://github.com/huggingface/transformers/pull/28769.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28769.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28768 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28768/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28768/comments | https://api.github.com/repos/huggingface/transformers/issues/28768/events | https://github.com/huggingface/transformers/pull/28768 | 2,106,808,476 | PR_kwDOCUB6oc5lZXU- | 28,768 | [`HfQuantizer`] Move it to "Developper guides" | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28768). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
Move the "How to add a new quantization method" tutorial into "Developper Guide" which seems to be a better appropriate place for that tutorial rather than in "Performance and scalability"
cc @stevhliu @ArthurZucker @amyeroberts
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28768/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28768/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28768",
"html_url": "https://github.com/huggingface/transformers/pull/28768",
"diff_url": "https://github.com/huggingface/transformers/pull/28768.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28768.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28767 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28767/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28767/comments | https://api.github.com/repos/huggingface/transformers/issues/28767/events | https://github.com/huggingface/transformers/pull/28767 | 2,106,654,935 | PR_kwDOCUB6oc5lY2kq | 28,767 | added support for llama v2 and codellama in weight conversion for issue #28241 | {
"login": "christoukmaji",
"id": 51040574,
"node_id": "MDQ6VXNlcjUxMDQwNTc0",
"avatar_url": "https://avatars.githubusercontent.com/u/51040574?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/christoukmaji",
"html_url": "https://github.com/christoukmaji",
"followers_url": "https://api.githu... | [] | open | false | null | [] | [
"Hey @christoukmaji, thanks for opening the PR! Seems like #28754 was opened a bit earlier so we'll try to get it merged! ๐ค ",
"Hi @ArthurZucker, thanks for the response. I would like to avoid the duplication of work for future contributions.\r\n\r\nWhat is the PR selection process for HuggingFace contributions... | 1,706 | 1,707 | null | NONE | null | # What does this PR do?
This PR adds support for LLaMa V2 and CodeLLaMa while maintaining backwards compatibility for LLaMa V1 in the LLaMa-HuggingFace weight conversion script `src/transformers/models/llama/convert_llama_weights_to_hf.py`. This PR changes the max_position_embeddings for LLaMa V2 to 4096, and for Co... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28767/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28767/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28767",
"html_url": "https://github.com/huggingface/transformers/pull/28767",
"diff_url": "https://github.com/huggingface/transformers/pull/28767.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28767.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28766 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28766/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28766/comments | https://api.github.com/repos/huggingface/transformers/issues/28766/events | https://github.com/huggingface/transformers/pull/28766 | 2,106,480,912 | PR_kwDOCUB6oc5lYQHT | 28,766 | #27237 | {
"login": "oublalkhalid",
"id": 76509145,
"node_id": "MDQ6VXNlcjc2NTA5MTQ1",
"avatar_url": "https://avatars.githubusercontent.com/u/76509145?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/oublalkhalid",
"html_url": "https://github.com/oublalkhalid",
"followers_url": "https://api.github.c... | [] | open | false | null | [] | [] | 1,706 | 1,707 | null | NONE | null | #27237 Solved โ
I suggest a resolution for situations where ``sequence_lags=[0]``. In such instances, the length of the context past sequence aligns with the overall sequence length. Let me provide some clarification on this matter
The issue stems from line `1230` in `modeling_time_series_transformer.py.` In cas... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28766/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28766/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28766",
"html_url": "https://github.com/huggingface/transformers/pull/28766",
"diff_url": "https://github.com/huggingface/transformers/pull/28766.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28766.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28765 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28765/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28765/comments | https://api.github.com/repos/huggingface/transformers/issues/28765/events | https://github.com/huggingface/transformers/pull/28765 | 2,106,444,478 | PR_kwDOCUB6oc5lYIGC | 28,765 | Added model Sigma-MoE | {
"login": "jubueche",
"id": 30778073,
"node_id": "MDQ6VXNlcjMwNzc4MDcz",
"avatar_url": "https://avatars.githubusercontent.com/u/30778073?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jubueche",
"html_url": "https://github.com/jubueche",
"followers_url": "https://api.github.com/users/jub... | [] | closed | false | null | [] | [
"Thrilled to see this! Feel free to ping me for reviews! ",
"Thanks, I will.",
"@ArthurZucker in the tests, I am getting\r\n```\r\nRuntimeError: Failed to import transformers.models.sigma_moe.modeling_sigma_moe because of the following error (look up to see its traceback):\r\n'str' object has no attribute 'impl... | 1,706 | 1,706 | 1,706 | NONE | null | # What does this PR do?
Added model from "[Approximating Two-Layer Feedforward Networks for Efficient Transformers](https://openreview.net/pdf?id=zM3mlyflTt)" and replicated experiments on WikiText-103.
The Sigma-MoE is different to the conventional Switch-like architecture when it comes to initialisation of the ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28765/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28765/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28765",
"html_url": "https://github.com/huggingface/transformers/pull/28765",
"diff_url": "https://github.com/huggingface/transformers/pull/28765.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28765.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28764 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28764/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28764/comments | https://api.github.com/repos/huggingface/transformers/issues/28764/events | https://github.com/huggingface/transformers/pull/28764 | 2,106,228,159 | PR_kwDOCUB6oc5lXY1T | 28,764 | Add tip on setting tokenizer attributes | {
"login": "Rocketknight1",
"id": 12866554,
"node_id": "MDQ6VXNlcjEyODY2NTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Rocketknight1",
"html_url": "https://github.com/Rocketknight1",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28764). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,706 | 1,706 | 1,706 | MEMBER | null | This PR adds a quick tip to the chat template docs on setting tokenizer attributes (after some discussion on Slack) | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28764/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28764/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28764",
"html_url": "https://github.com/huggingface/transformers/pull/28764",
"diff_url": "https://github.com/huggingface/transformers/pull/28764.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28764.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28763 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28763/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28763/comments | https://api.github.com/repos/huggingface/transformers/issues/28763/events | https://github.com/huggingface/transformers/issues/28763 | 2,106,179,792 | I_kwDOCUB6oc59icDQ | 28,763 | Allow setting different decoder_start_token_ids for each item in a batch in the generate function. | {
"login": "dpernes",
"id": 25008929,
"node_id": "MDQ6VXNlcjI1MDA4OTI5",
"avatar_url": "https://avatars.githubusercontent.com/u/25008929?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dpernes",
"html_url": "https://github.com/dpernes",
"followers_url": "https://api.github.com/users/dperne... | [
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request",
"name": "Feature request",
"color": "FBCA04",
"default": false,
"description": "Request for a new feature"
}
] | open | false | null | [] | [
"cc @zucchini-nlp",
"@dpernes Hi, if you want to specify in different decoder_start_token_ids for each element, you can do it by passing a tensor of shape `(batch_size, seq_len)`. In your case adding this line before the `generate` is called will solve the issue:\r\n\r\n`decoder_start_token_id = decoder_start_tok... | 1,706 | 1,708 | null | NONE | null | ### Feature request
@gante
The `generate` function has a `decoder_start_token_id` argument that allows the specification of the decoder start token when generating from an encoder-decoder model (e.g. mT5). Currently, `decoder_start_token_id` must be an integer, which means that the same start token is used for all e... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28763/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28763/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28762 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28762/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28762/comments | https://api.github.com/repos/huggingface/transformers/issues/28762/events | https://github.com/huggingface/transformers/issues/28762 | 2,106,086,540 | I_kwDOCUB6oc59iFSM | 28,762 | Update the default depth estimation model of the pipeline | {
"login": "NielsRogge",
"id": 48327001,
"node_id": "MDQ6VXNlcjQ4MzI3MDAx",
"avatar_url": "https://avatars.githubusercontent.com/u/48327001?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NielsRogge",
"html_url": "https://github.com/NielsRogge",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"cc @Narsil @amyeroberts I would propose to update the default depth estimation model to https://huggingface.co/LiheYoung/depth-anything-base-hf. Any objections?\r\n\r\n",
"In principle, I think this might be a good idea: people want to just get good predictions, and serving the \"best\" model by default is proba... | 1,706 | 1,707 | 1,707 | CONTRIBUTOR | null | ### Feature request
The current depth estimation pipeline leverages https://huggingface.co/Intel/dpt-large by default.
However, with recent models like Depth Anything, it might make sense to update the default model.
For reference, DPT-large (also called DPT 3.0) was released in 2021, we do have better models in... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28762/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28762/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28761 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28761/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28761/comments | https://api.github.com/repos/huggingface/transformers/issues/28761/events | https://github.com/huggingface/transformers/issues/28761 | 2,106,008,347 | I_kwDOCUB6oc59hyMb | 28,761 | requests.exceptions.SSLError: HTTPSConnectionPool(host='api-inference.huggingface.co', port=443) | {
"login": "shoang22",
"id": 54875725,
"node_id": "MDQ6VXNlcjU0ODc1NzI1",
"avatar_url": "https://avatars.githubusercontent.com/u/54875725?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shoang22",
"html_url": "https://github.com/shoang22",
"followers_url": "https://api.github.com/users/sho... | [] | closed | false | null | [] | [
"Fixed by removing os.environ[\"*_PROXY\"] lines and setting `verify=False` in `requests.post()`"
] | 1,706 | 1,706 | 1,706 | NONE | null | ### System Info
- `transformers` version: 4.30.2
- Platform: Linux-5.4.0-1103-aws-x86_64-with-debian-buster-sid
- Python version: 3.7.16
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.4.0 but is ignored because of PyTorch version too old.
- PyTorch version (GPU?): 1.8.0 (True)
- Tensorflow version ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28761/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28761/timeline | completed | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.