url stringlengths 62 66 | repository_url stringclasses 1
value | labels_url stringlengths 76 80 | comments_url stringlengths 71 75 | events_url stringlengths 69 73 | html_url stringlengths 50 56 | id int64 377M 2.15B | node_id stringlengths 18 32 | number int64 1 29.2k | title stringlengths 1 487 | user dict | labels list | state stringclasses 2
values | locked bool 2
classes | assignee dict | assignees list | comments list | created_at int64 1.54k 1.71k | updated_at int64 1.54k 1.71k | closed_at int64 1.54k 1.71k โ | author_association stringclasses 4
values | active_lock_reason stringclasses 2
values | body stringlengths 0 234k โ | reactions dict | timeline_url stringlengths 71 75 | state_reason stringclasses 3
values | draft bool 2
classes | pull_request dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/transformers/issues/24618 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24618/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24618/comments | https://api.github.com/repos/huggingface/transformers/issues/24618/events | https://github.com/huggingface/transformers/pull/24618 | 1,784,177,542 | PR_kwDOCUB6oc5Ua4O- | 24,618 | precompiled_charsmap checking before adding to the normalizers' list for XLNetTokenizerFast conversion. | {
"login": "shahad-mahmud",
"id": 29411624,
"node_id": "MDQ6VXNlcjI5NDExNjI0",
"avatar_url": "https://avatars.githubusercontent.com/u/29411624?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shahad-mahmud",
"html_url": "https://github.com/shahad-mahmud",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Hey @ArthurZucker I have incorporated the changes so that it supports all the models. \r\n\r\nIt is failing in one test case and it seems the test case is not related to this PR. From details I see that it fails due to the `module 'P... | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
There is a small change to check the `precompiled_charsmap` during the conversion of a slow tokenizer to `XLNetTokenizerFast`. It will check if the `precompiled_charsmap` is empty before initializing `normalizers.Precompiled` from the tokenizers library. If a [Sentencepiece](https://github.co... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24618/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24618/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24618",
"html_url": "https://github.com/huggingface/transformers/pull/24618",
"diff_url": "https://github.com/huggingface/transformers/pull/24618.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24618.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24617 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24617/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24617/comments | https://api.github.com/repos/huggingface/transformers/issues/24617/events | https://github.com/huggingface/transformers/issues/24617 | 1,784,168,634 | I_kwDOCUB6oc5qWEC6 | 24,617 | Seems some Bart models from facebook are removed | {
"login": "com3dian",
"id": 57277626,
"node_id": "MDQ6VXNlcjU3Mjc3NjI2",
"avatar_url": "https://avatars.githubusercontent.com/u/57277626?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/com3dian",
"html_url": "https://github.com/com3dian",
"followers_url": "https://api.github.com/users/com... | [] | closed | false | null | [] | [
"They're back up now! ๐ค",
"Closing as this has been resolved! "
] | 1,688 | 1,688 | 1,688 | NONE | null | ### System Info
No response.
### Who can help?
@ArthurZucker @YouJiacheng @sgugger @stevhliu @MKhalusova
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own t... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24617/reactions",
"total_count": 3,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 3,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24617/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24616 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24616/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24616/comments | https://api.github.com/repos/huggingface/transformers/issues/24616/events | https://github.com/huggingface/transformers/issues/24616 | 1,784,161,160 | I_kwDOCUB6oc5qWCOI | 24,616 | XLNetTokenizerFast conversion fails with identity normalization in Sentencepiece tokenizer | {
"login": "shahad-mahmud",
"id": 29411624,
"node_id": "MDQ6VXNlcjI5NDExNjI0",
"avatar_url": "https://avatars.githubusercontent.com/u/29411624?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shahad-mahmud",
"html_url": "https://github.com/shahad-mahmud",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"To my mind, the bug can be fixed with a checking of the precompiled charmap like the following code snippet:\r\n\r\n```python\r\nprecompiled_charsmap = proto.normalizer_spec.precompiled_charsmap\r\n \r\nif precompiled_charsmap:\r\n list_normalizers.append(normalizers.Precompiled(precompiled_charsmap))\r\... | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.25.1
- Platform: Linux-5.19.0-46-generic-x86_64-with-glibc2.17
- Python version: 3.8.13
- Huggingface_hub version: 0.15.1
- PyTorch version (GPU?): 1.12.1+cu102 (False)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU?/TPU?): 0.6.3 (cpu)
- Jax ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24616/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24616/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24615 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24615/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24615/comments | https://api.github.com/repos/huggingface/transformers/issues/24615/events | https://github.com/huggingface/transformers/issues/24615 | 1,784,154,098 | I_kwDOCUB6oc5qWAfy | 24,615 | Cannot load BART model | {
"login": "Onkar-2803",
"id": 60955023,
"node_id": "MDQ6VXNlcjYwOTU1MDIz",
"avatar_url": "https://avatars.githubusercontent.com/u/60955023?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Onkar-2803",
"html_url": "https://github.com/Onkar-2803",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"It seems like Facebook just disappeared from HuggingFace. Still waiting for something back...",
"Yeah, no models & datasets visible.",
"https://huggingface.co/facebook/bart-large is back up now ๐ค ",
"This issue has been automatically marked as stale because it has not had recent activity. If you think this ... | 1,688 | 1,690 | 1,690 | NONE | null | Trying to load the BART model as specified on the [website](https://huggingface.co/docs/transformers/model_doc/bart#mask-filling:~:text=Mask%20Filling-,The%20facebook,-/bart%2Dbase%20and) with the following code:
`model = BartForConditionalGeneration.from_pretrained("facebook/bart-large", forced_bos_token_id=0`
Err... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24615/reactions",
"total_count": 4,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 4
} | https://api.github.com/repos/huggingface/transformers/issues/24615/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24614 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24614/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24614/comments | https://api.github.com/repos/huggingface/transformers/issues/24614/events | https://github.com/huggingface/transformers/pull/24614 | 1,784,116,851 | PR_kwDOCUB6oc5UarEi | 24,614 | [DOC] Clarify relationshi load_best_model_at_end and save_total_limit | {
"login": "BramVanroy",
"id": 2779410,
"node_id": "MDQ6VXNlcjI3Nzk0MTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/2779410?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BramVanroy",
"html_url": "https://github.com/BramVanroy",
"followers_url": "https://api.github.com/users... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Can you just do a quick rebase/merge on the main branch? I think the issue in the tests (due to a release of Pillow apparently) is fixed on main."
] | 1,688 | 1,689 | 1,689 | COLLABORATOR | null | Clarify the relationship between `load_best_model_at_end` and `save_total_limit`. Hope this is clear.
As discussed on Slack @sgugger
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24614/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24614/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24614",
"html_url": "https://github.com/huggingface/transformers/pull/24614",
"diff_url": "https://github.com/huggingface/transformers/pull/24614.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24614.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24613 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24613/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24613/comments | https://api.github.com/repos/huggingface/transformers/issues/24613/events | https://github.com/huggingface/transformers/issues/24613 | 1,783,910,645 | I_kwDOCUB6oc5qVFD1 | 24,613 | Fine-tune T5 on SQuAD | {
"login": "h1326889",
"id": 138305300,
"node_id": "U_kgDOCD5fFA",
"avatar_url": "https://avatars.githubusercontent.com/u/138305300?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/h1326889",
"html_url": "https://github.com/h1326889",
"followers_url": "https://api.github.com/users/h1326889/... | [] | closed | false | null | [] | [
"I didn't verify manually, but I think you have to modify \r\n\r\nhttps://github.com/huggingface/transformers/blob/fc7ce2ebc52eccd8158a7feeeee11eb44f964937/examples/pytorch/question-answering/run_seq2seq_qa.py#L695-L706\r\n\r\nin order to save the prediction (generation).",
"This issue has been automatically mark... | 1,688 | 1,691 | 1,691 | NONE | null | ### System Info
I was trying to use the official command to evaluate T5 on SQuAD data, but where can I find the prediction file that contains the actual answer T5 generated?
python run_seq2seq_qa.py \
--model_name_or_path t5-small \
--dataset_name squad \
--context_column context \
--question_column que... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24613/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24613/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24612 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24612/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24612/comments | https://api.github.com/repos/huggingface/transformers/issues/24612/events | https://github.com/huggingface/transformers/issues/24612 | 1,783,821,193 | I_kwDOCUB6oc5qUvOJ | 24,612 | ValueError: An instance of tokenizer class BioGptTokenizer cannot be converted in a Fast tokenizer instance. No converter was found. | {
"login": "TekeshwarHirwani",
"id": 79913769,
"node_id": "MDQ6VXNlcjc5OTEzNzY5",
"avatar_url": "https://avatars.githubusercontent.com/u/79913769?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/TekeshwarHirwani",
"html_url": "https://github.com/TekeshwarHirwani",
"followers_url": "https://... | [
{
"id": 1314768611,
"node_id": "MDU6TGFiZWwxMzE0NzY4NjEx",
"url": "https://api.github.com/repos/huggingface/transformers/labels/wontfix",
"name": "wontfix",
"color": "ffffff",
"default": true,
"description": null
}
] | closed | false | null | [] | [
"Hi @TekeshwarHirwani, thanks for raising this issue. \r\n\r\nIndeed, there doesn't exist a convert yet for this tokenizer. Would you like to add it? You can find examples of [converters here](https://github.com/huggingface/transformers/blob/main/src/transformers/convert_slow_tokenizer.py), and it will need to be a... | 1,688 | 1,692 | 1,692 | NONE | null | ### System Info
ValueError: An instance of tokenizer class BioGptTokenizer cannot be converted in a Fast tokenizer instance. No converter was found.
I am using microsoft/biogpt for token classification ner task script(https://github.com/huggingface/transformers/blob/main/examples/pytorch/token-classification/run_n... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24612/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24612/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24611 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24611/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24611/comments | https://api.github.com/repos/huggingface/transformers/issues/24611/events | https://github.com/huggingface/transformers/pull/24611 | 1,783,721,677 | PR_kwDOCUB6oc5UZTKb | 24,611 | translate the English documentation into Chinese | {
"login": "liteli1987gmail",
"id": 59245973,
"node_id": "MDQ6VXNlcjU5MjQ1OTcz",
"avatar_url": "https://avatars.githubusercontent.com/u/59245973?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/liteli1987gmail",
"html_url": "https://github.com/liteli1987gmail",
"followers_url": "https://api... | [] | closed | false | null | [] | [
"Hi @liteli1987gmail, thanks for opening this PR and starting the Chinese translation effort! \r\n\r\nIs there a corresponding github issue for this translation? We recommend opening an issue (following [this template](https://github.com/huggingface/transformers/blob/f4e4b4d0e2dc248433e808594f7595292037d891/.github... | 1,688 | 1,691 | 1,691 | CONTRIBUTOR | null | # Aim
Aims to translate the English documentation into Chinese, making it easier for Chinese developers to read and reducing the difficulty of accessing the documentation for them.
zh_translate:
@chenglu
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24611/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24611/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24611",
"html_url": "https://github.com/huggingface/transformers/pull/24611",
"diff_url": "https://github.com/huggingface/transformers/pull/24611.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24611.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24610 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24610/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24610/comments | https://api.github.com/repos/huggingface/transformers/issues/24610/events | https://github.com/huggingface/transformers/issues/24610 | 1,783,481,004 | I_kwDOCUB6oc5qTcKs | 24,610 | PreTrainedTokenizerFast - whitespace merge skipped | {
"login": "cmp-nct",
"id": 78893154,
"node_id": "MDQ6VXNlcjc4ODkzMTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/78893154?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cmp-nct",
"html_url": "https://github.com/cmp-nct",
"followers_url": "https://api.github.com/users/cmp-nc... | [] | closed | false | null | [] | [
"The behavior switches to what I expected if you disable pre_tokenizer->use_regex which ignores the rank and contains quite a bit of english grammar rules.\r\nNot sure if that regex snake should really be used by default, given the international use of tokenizers. (ironically TII has chosen it despite being in an a... | 1,688 | 1,688 | 1,688 | NONE | null | ### System Info
@ArthurZucker
Most likely I'm wrong, been digging through tokenization for 10 hours in a row and quite new to the topic.
Vocab: https://huggingface.co/tiiuae/falcon-40b/blob/main/tokenizer.json
String: `"Hello World"`
Two spaces are in the merge list right on top at line 19
" W" is in line 128... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24610/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24610/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24609 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24609/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24609/comments | https://api.github.com/repos/huggingface/transformers/issues/24609/events | https://github.com/huggingface/transformers/pull/24609 | 1,783,384,109 | PR_kwDOCUB6oc5UYGU5 | 24,609 | Fix model referenced and results in documentation. Model mentioned was inaccessible | {
"login": "rafaelpadilla",
"id": 31217453,
"node_id": "MDQ6VXNlcjMxMjE3NDUz",
"avatar_url": "https://avatars.githubusercontent.com/u/31217453?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rafaelpadilla",
"html_url": "https://github.com/rafaelpadilla",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
This is a very small change on the documentation.
The mentioned model (`MariaK/detr-resnet-50_finetuned_cppe5`) was either removed or set to private. So I could not reproduce the shown example.
I basically reference the same model but from another user, which provides a slightly better re... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24609/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24609/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24609",
"html_url": "https://github.com/huggingface/transformers/pull/24609",
"diff_url": "https://github.com/huggingface/transformers/pull/24609.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24609.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24608 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24608/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24608/comments | https://api.github.com/repos/huggingface/transformers/issues/24608/events | https://github.com/huggingface/transformers/issues/24608 | 1,783,342,783 | I_kwDOCUB6oc5qS6a_ | 24,608 | CUDA error: an illegal memory access was encountered | {
"login": "johnchienbronci",
"id": 27708347,
"node_id": "MDQ6VXNlcjI3NzA4MzQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/27708347?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/johnchienbronci",
"html_url": "https://github.com/johnchienbronci",
"followers_url": "https://api... | [] | closed | false | null | [] | [
"What's your deepspeed version. Probably try to upgrade it and check again.\r\n\r\nYou can follow [this issue page](https://github.com/microsoft/DeepSpeed/issues/3373).\r\n",
"ds_report\r\n```\r\nDeepSpeed general environment info:\r\ntorch install path ............... ['/home/ubuntu/.local/lib/python3.10/site-pa... | 1,688 | 1,691 | 1,691 | NONE | null | I encountered some errors when running the run_speech_recognition_ctc_streaming.sh by `deepspeed` ( `torchrun --nproc_per_node 1 ... `) and his issue consistently occurs with my custom corpora.
Does anyone have any ideas? (I can fine-tune successfully using the Common Voice corpus)
environment:
gpu number: 1
expo... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24608/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24608/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24607 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24607/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24607/comments | https://api.github.com/repos/huggingface/transformers/issues/24607/events | https://github.com/huggingface/transformers/issues/24607 | 1,783,289,006 | I_kwDOCUB6oc5qStSu | 24,607 | `logging_dir` is not being generated. | {
"login": "vanbasten23",
"id": 5279639,
"node_id": "MDQ6VXNlcjUyNzk2Mzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5279639?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vanbasten23",
"html_url": "https://github.com/vanbasten23",
"followers_url": "https://api.github.com/us... | [] | closed | false | null | [] | [
"Hi @vanbasten23, \r\n\r\nDo you have tensorboard installed in your environment?\r\n\r\nCould you share the the running environment: run `transformers-cli env` in the terminal and copy-paste the output?",
"> Do you have tensorboard installed in your environment?\r\n\r\nThanks. It turns out once I installed tensor... | 1,688 | 1,689 | 1,689 | NONE | null | ### System Info
Hi. I'm using huggingface model `bert base` on cloud TPU but it couldn't generate the `--logging_dir` that I expected.
### Who can help?
@sgugger
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [X] An officially supported task i... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24607/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24607/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24606 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24606/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24606/comments | https://api.github.com/repos/huggingface/transformers/issues/24606/events | https://github.com/huggingface/transformers/issues/24606 | 1,783,205,632 | I_kwDOCUB6oc5qSY8A | 24,606 | RuntimeError: Could not infer dtype of NoneType | {
"login": "TekeshwarHirwani",
"id": 79913769,
"node_id": "MDQ6VXNlcjc5OTEzNzY5",
"avatar_url": "https://avatars.githubusercontent.com/u/79913769?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/TekeshwarHirwani",
"html_url": "https://github.com/TekeshwarHirwani",
"followers_url": "https://... | [] | closed | false | null | [] | [
"Hi @TekeshwarHirwani \r\n\r\nThe files under [transformers](https://github.com/huggingface/transformers/tree/main)/[examples](https://github.com/huggingface/transformers/tree/main/examples)/[legacy](https://github.com/huggingface/transformers/tree/main/examples/legacy) is no longer maintained: (from the README fil... | 1,688 | 1,688 | 1,688 | NONE | null | ### System Info
I was using microsoft/biogpt and gpt2 model on old script of run_ner.py that is (https://github.com/huggingface/transformers/blob/main/examples/legacy/token-classification/run_ner.py ) since both have slow tokenizer and they both encountered same error that is
RuntimeError: Could not infer dtype... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24606/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24606/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24605 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24605/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24605/comments | https://api.github.com/repos/huggingface/transformers/issues/24605/events | https://github.com/huggingface/transformers/pull/24605 | 1,783,175,660 | PR_kwDOCUB6oc5UXYpt | 24,605 | Fix model referenced and results in documentation. Model mentioned was inaccessible. | {
"login": "rafaelpadilla",
"id": 31217453,
"node_id": "MDQ6VXNlcjMxMjE3NDUz",
"avatar_url": "https://avatars.githubusercontent.com/u/31217453?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rafaelpadilla",
"html_url": "https://github.com/rafaelpadilla",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24605/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24605/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24605",
"html_url": "https://github.com/huggingface/transformers/pull/24605",
"diff_url": "https://github.com/huggingface/transformers/pull/24605.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24605.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24604 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24604/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24604/comments | https://api.github.com/repos/huggingface/transformers/issues/24604/events | https://github.com/huggingface/transformers/issues/24604 | 1,783,136,819 | I_kwDOCUB6oc5qSIIz | 24,604 | Contradictory information in documentation about the ability to push qunatized models to hub | {
"login": "amdnsr",
"id": 33130717,
"node_id": "MDQ6VXNlcjMzMTMwNzE3",
"avatar_url": "https://avatars.githubusercontent.com/u/33130717?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amdnsr",
"html_url": "https://github.com/amdnsr",
"followers_url": "https://api.github.com/users/amdnsr/fo... | [] | closed | false | null | [] | [
"cc @younesbelkada ",
"Hi @amdnsr \r\nThanks for the issue\r\nas explained in the mentioned paragraphs, it is possible to push 8bit quantized weights only if you use the latest transformers + bitsandbytes. However, pushing 4bit weights is currently not supported",
"This issue has been automatically marked as st... | 1,688 | 1,691 | 1,691 | NONE | null | ### System Info
Using Google Colab and the main branch of the transformers library on GitHub.
### Who can help?
@sgugger @stevhliu @MKhalusova
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQuA... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24604/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24604/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24603 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24603/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24603/comments | https://api.github.com/repos/huggingface/transformers/issues/24603/events | https://github.com/huggingface/transformers/pull/24603 | 1,783,076,358 | PR_kwDOCUB6oc5UXCuD | 24,603 | Make warning disappear for remote code in pipelines | {
"login": "sgugger",
"id": 35901082,
"node_id": "MDQ6VXNlcjM1OTAxMDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/35901082?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sgugger",
"html_url": "https://github.com/sgugger",
"followers_url": "https://api.github.com/users/sgugge... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,688 | 1,688 | COLLABORATOR | null | # What does this PR do?
Currently, loading a pipeline with a model that has its code on the Hub will result in a warning that the model is not in the right auto class. This PR adds the custom class in the auto mapping so that this warning is not triggered.
Related to #24598 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24603/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24603/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24603",
"html_url": "https://github.com/huggingface/transformers/pull/24603",
"diff_url": "https://github.com/huggingface/transformers/pull/24603.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24603.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24602 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24602/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24602/comments | https://api.github.com/repos/huggingface/transformers/issues/24602/events | https://github.com/huggingface/transformers/issues/24602 | 1,783,010,814 | I_kwDOCUB6oc5qRpX- | 24,602 | Support gradient checkpointing for ESM models | {
"login": "mahdip72",
"id": 42680708,
"node_id": "MDQ6VXNlcjQyNjgwNzA4",
"avatar_url": "https://avatars.githubusercontent.com/u/42680708?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mahdip72",
"html_url": "https://github.com/mahdip72",
"followers_url": "https://api.github.com/users/mah... | [
{
"id": 2392046359,
"node_id": "MDU6TGFiZWwyMzkyMDQ2MzU5",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20Second%20Issue",
"name": "Good Second Issue",
"color": "dd935a",
"default": false,
"description": "Issues that are more difficult to do than \"Good First... | closed | false | null | [] | [
"cc @Rocketknight1 ",
"Any updates?",
"It's on the to-do list, but I'm afraid there are competing priorities at the moment!",
"Let's open it up for anyone in the community who might want to tackle it :) ",
"Hi @amyeroberts @Rocketknight1 I would like to work on this ",
"@sanjeevk-os Great! Once you have t... | 1,688 | 1,695 | 1,695 | NONE | null | Would you please add `gradient_checkpointing_enable()` feature for ESM models?
These models currently are the best available pre-trained protein language models for researchers.
Many thanks. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24602/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24602/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24601 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24601/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24601/comments | https://api.github.com/repos/huggingface/transformers/issues/24601/events | https://github.com/huggingface/transformers/pull/24601 | 1,782,781,471 | PR_kwDOCUB6oc5UWGFw | 24,601 | add link to accelerate doc | {
"login": "SunMarc",
"id": 57196510,
"node_id": "MDQ6VXNlcjU3MTk2NTEw",
"avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SunMarc",
"html_url": "https://github.com/SunMarc",
"followers_url": "https://api.github.com/users/SunMar... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,689 | 1,689 | MEMBER | null | # What does this PR do?
This PR modifies the quantization doc to include a link to accelerate documentation if the user wants to quantize their own pytorch model. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24601/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24601/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24601",
"html_url": "https://github.com/huggingface/transformers/pull/24601",
"diff_url": "https://github.com/huggingface/transformers/pull/24601.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24601.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24600 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24600/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24600/comments | https://api.github.com/repos/huggingface/transformers/issues/24600/events | https://github.com/huggingface/transformers/issues/24600 | 1,782,723,317 | I_kwDOCUB6oc5qQjL1 | 24,600 | IndexError: index -1 is out of bounds for dimension 1 with size 0 | {
"login": "diaojunxian",
"id": 19700467,
"node_id": "MDQ6VXNlcjE5NzAwNDY3",
"avatar_url": "https://avatars.githubusercontent.com/u/19700467?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/diaojunxian",
"html_url": "https://github.com/diaojunxian",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"cc @gante @sanchit-gandhi ",
"Hey @diaojunxian ๐ \r\n\r\nYour reproducer contains private data, which means we can't easily reproduce on our end -- would you be able to share the audio file with us OR rewrite the reproducer from public data?\r\n\r\nAt a first glance, because of the thrown exception (`IndexError... | 1,688 | 1,688 | 1,688 | NONE | null | ### System Info
PC: M2
transformers== 4.31.0.dev0
refer: https://github.com/openai/whisper/discussions/1478
meet the error:
```
in <module>:9 โ
โ ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24600/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24600/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24599 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24599/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24599/comments | https://api.github.com/repos/huggingface/transformers/issues/24599/events | https://github.com/huggingface/transformers/pull/24599 | 1,782,699,187 | PR_kwDOCUB6oc5UVzx7 | 24,599 | Use protobuf 4 | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"I have checked to make sure `protobuf==4.23.3` is installed and used in the CI.",
"@Narsil mentioned we should keep the old/new version files, and determine which one to use (by the protobuf version numbers?).\r\n\r\nLet me know more details about this please.",
"_The documentation is not available anymore as ... | 1,688 | 1,689 | 1,688 | COLLABORATOR | null | # What does this PR do?
I move forward to generate the new `src/transformers/utils/sentencepiece_model_pb2.py` using the protocol buffer compiler. No test failure but have a quality check fails. I can probably removed the undefined part `_TRAINERSPEC` which doesn't seem used. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24599/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24599/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24599",
"html_url": "https://github.com/huggingface/transformers/pull/24599",
"diff_url": "https://github.com/huggingface/transformers/pull/24599.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24599.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24598 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24598/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24598/comments | https://api.github.com/repos/huggingface/transformers/issues/24598/events | https://github.com/huggingface/transformers/issues/24598 | 1,782,578,710 | I_kwDOCUB6oc5qP_4W | 24,598 | Falcon-40b-instruct on Runpod | {
"login": "Mrin7",
"id": 134509550,
"node_id": "U_kgDOCARz7g",
"avatar_url": "https://avatars.githubusercontent.com/u/134509550?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Mrin7",
"html_url": "https://github.com/Mrin7",
"followers_url": "https://api.github.com/users/Mrin7/followers",
... | [] | closed | false | null | [] | [
"Hi @Mrin7, thanks for raising this issue. \r\n\r\nIndeed, this is arising because of [this check](https://github.com/huggingface/transformers/blob/78a2b19fc84ed55c65f4bf20a901edb7ceb73c5f/src/transformers/pipelines/text_generation.py#L65) in the pipeline code, and the falcon model isn't registered in `MODEL_FOR_CA... | 1,688 | 1,691 | 1,691 | NONE | null | ### System Info
2 x A100 80GB
32 vCPU 251 GB RAM
### Who can help?
_No response_
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
###... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24598/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24598/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24597 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24597/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24597/comments | https://api.github.com/repos/huggingface/transformers/issues/24597/events | https://github.com/huggingface/transformers/issues/24597 | 1,782,559,200 | I_kwDOCUB6oc5qP7Hg | 24,597 | Test with Pydantic V2 | {
"login": "lig",
"id": 38705,
"node_id": "MDQ6VXNlcjM4NzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/38705?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lig",
"html_url": "https://github.com/lig",
"followers_url": "https://api.github.com/users/lig/followers",
"following... | [] | closed | false | null | [] | [
"Hi @lig \r\n\r\nThanks again for the PR #24596. Really appreciated.\r\n\r\nRegarding using Pydantic V2, I am afraid that the involved places are not directly in `transformers` codebase.\r\n\r\nFor example, in \r\n\r\nhttps://github.com/huggingface/transformers/pull/24596#issuecomment-1615176591\r\n\r\nit shows \r\... | 1,688 | 1,691 | 1,691 | CONTRIBUTOR | null | ### Feature request
Pydantic V2 is about to be release. There is Pydantic 2.0b3 pre-release version available already https://pypi.org/project/pydantic/2.0b3/
Please, test transformers with Pydantic V2.
There is a special tool that could help with migrating the code base to Pydantic V2 https://github.com/pydanti... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24597/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24597/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24596 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24596/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24596/comments | https://api.github.com/repos/huggingface/transformers/issues/24596/events | https://github.com/huggingface/transformers/pull/24596 | 1,782,531,807 | PR_kwDOCUB6oc5UVPhU | 24,596 | Limit Pydantic to V1 in dependencies | {
"login": "lig",
"id": 38705,
"node_id": "MDQ6VXNlcjM4NzA1",
"avatar_url": "https://avatars.githubusercontent.com/u/38705?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lig",
"html_url": "https://github.com/lig",
"followers_url": "https://api.github.com/users/lig/followers",
"following... | [] | closed | false | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [
{
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.githu... | [
"Hi @lig, thanks for opening this PR! \r\n\r\nCould you provide some more information about the kind of issues / breakages expected? I can only see `pydantic` used in one place in the library [here](https://github.com/huggingface/transformers/blob/78a2b19fc84ed55c65f4bf20a901edb7ceb73c5f/src/transformers/commands/s... | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | Pydantic is about to release V2 release which will break a lot of things. This change prevents `transformers` to be used with Pydantic V2 to avoid breaking things.
Also, see #24597
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24596/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24596/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24596",
"html_url": "https://github.com/huggingface/transformers/pull/24596",
"diff_url": "https://github.com/huggingface/transformers/pull/24596.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24596.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24595 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24595/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24595/comments | https://api.github.com/repos/huggingface/transformers/issues/24595/events | https://github.com/huggingface/transformers/pull/24595 | 1,782,525,663 | PR_kwDOCUB6oc5UVOLH | 24,595 | Speed up TF tests by reducing hidden layer counts | {
"login": "Rocketknight1",
"id": 12866554,
"node_id": "MDQ6VXNlcjEyODY2NTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Rocketknight1",
"html_url": "https://github.com/Rocketknight1",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"Would be nice if you can show the timing for one model (before v.s. after) ๐ . Thanks.",
"_The documentation is not available anymore as the PR was closed or merged._",
"@ydshieh testing locally BERT went from 510 seconds -> 220 seconds",
"I don't know if it was @sgugger either - a lot of this code is reall... | 1,688 | 1,688 | 1,688 | MEMBER | null | A lot of our slow TF tests are caused by TF compilation. TF compilation isn't really affected by layer width at all - the main thing is just the number of operations it has to build a graph for. By reducing the number of hidden layers, compilation gets much faster, (hopefully) without interfering with test coverage at ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24595/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24595/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24595",
"html_url": "https://github.com/huggingface/transformers/pull/24595",
"diff_url": "https://github.com/huggingface/transformers/pull/24595.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24595.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24594 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24594/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24594/comments | https://api.github.com/repos/huggingface/transformers/issues/24594/events | https://github.com/huggingface/transformers/pull/24594 | 1,782,466,270 | PR_kwDOCUB6oc5UVBJW | 24,594 | Fix loading dataset docs link in run_translation.py example | {
"login": "SoyGema",
"id": 24204714,
"node_id": "MDQ6VXNlcjI0MjA0NzE0",
"avatar_url": "https://avatars.githubusercontent.com/u/24204714?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SoyGema",
"html_url": "https://github.com/SoyGema",
"followers_url": "https://api.github.com/users/SoyGem... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Thanks for the merge @amyeroberts !"
] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24594/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24594/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24594",
"html_url": "https://github.com/huggingface/transformers/pull/24594",
"diff_url": "https://github.com/huggingface/transformers/pull/24594.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24594.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24593 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24593/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24593/comments | https://api.github.com/repos/huggingface/transformers/issues/24593/events | https://github.com/huggingface/transformers/pull/24593 | 1,782,314,696 | PR_kwDOCUB6oc5UUf47 | 24,593 | Add forward methods to quantizer that also computes commitment loss | {
"login": "hackyon",
"id": 1557853,
"node_id": "MDQ6VXNlcjE1NTc4NTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1557853?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hackyon",
"html_url": "https://github.com/hackyon",
"followers_url": "https://api.github.com/users/hackyon/... | [] | closed | false | null | [] | [
"Much of this was adapted from https://github.com/facebookresearch/encodec/blob/main/encodec/quantization/core_vq.py\r\n\r\nFor reference, a part of the conversation is in one of the specific changes as well:\r\nhttps://github.com/huggingface/transformers/commit/4f697be0b62c4f3b0401ccbd00d1d46aac81906d",
"@Arthur... | 1,688 | 1,704 | 1,698 | CONTRIBUTOR | null | # What does this PR do?
This PR adds the code to compute commitment loss for the quantizer. The loss is only computed in the newly added forward() methods.
This is a small part of the bigger #24295
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if tha... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24593/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24593/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24593",
"html_url": "https://github.com/huggingface/transformers/pull/24593",
"diff_url": "https://github.com/huggingface/transformers/pull/24593.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24593.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24592 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24592/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24592/comments | https://api.github.com/repos/huggingface/transformers/issues/24592/events | https://github.com/huggingface/transformers/pull/24592 | 1,782,294,524 | PR_kwDOCUB6oc5UUbgL | 24,592 | Make (TF) CI faster (test only a random subset of model classes) | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Some of the very slow tests (like `test_saved_model_creation_extended` and `test_xla_fit`) only apply to a few models anyway - they're in `test_modeling_tf_core.py`, so they shouldn't have a big effect on the total test runtime. I mi... | 1,688 | 1,688 | 1,688 | COLLABORATOR | null | # What does this PR do?
Daily CI is currently running in 22h30m. @Rocketknight1 might have a way to bring it back to 19-20 hours.
For some tests, let's test only a (random) subset of the model classes ๐ .
Here is the timing of some very slow tests currently:
```
398.44s call tests/models/bert/test_mod... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24592/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24592/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24592",
"html_url": "https://github.com/huggingface/transformers/pull/24592",
"diff_url": "https://github.com/huggingface/transformers/pull/24592.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24592.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24591 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24591/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24591/comments | https://api.github.com/repos/huggingface/transformers/issues/24591/events | https://github.com/huggingface/transformers/pull/24591 | 1,782,227,232 | PR_kwDOCUB6oc5UUMuD | 24,591 | DeepSpeed/FSDP ckpt saving utils fixes and FSDP training args fixes | {
"login": "pacman100",
"id": 13534540,
"node_id": "MDQ6VXNlcjEzNTM0NTQw",
"avatar_url": "https://avatars.githubusercontent.com/u/13534540?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pacman100",
"html_url": "https://github.com/pacman100",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
1. `_save` function saves `tokenizer` and `training_args.bin` in addition to model.
2. This PR rearranges logic for saving model for DS and FSDP such that the above 2 things are also saved in addition to model ckpt.
3. FIxes https://github.com/huggingface/transformers/issues/24641 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24591/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24591/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24591",
"html_url": "https://github.com/huggingface/transformers/pull/24591",
"diff_url": "https://github.com/huggingface/transformers/pull/24591.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24591.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24590 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24590/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24590/comments | https://api.github.com/repos/huggingface/transformers/issues/24590/events | https://github.com/huggingface/transformers/pull/24590 | 1,782,197,606 | PR_kwDOCUB6oc5UUGP_ | 24,590 | Udate link to RunHouse hardware setup documentation. | {
"login": "BioGeek",
"id": 59344,
"node_id": "MDQ6VXNlcjU5MzQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/59344?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/BioGeek",
"html_url": "https://github.com/BioGeek",
"followers_url": "https://api.github.com/users/BioGeek/follower... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Thanks!! I'll update the one in Accelerate too."
] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
The [hardware setup](https://runhouse-docs.readthedocs-hosted.com/en/main/rh_primitives/cluster.html#hardware-setup) link gives a 404 error. Replaced with a [link](https://runhouse-docs.readthedocs-hosted.com/en/latest/api/python/cluster.html#hardware-setup) that points to the latest version ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24590/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24590/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24590",
"html_url": "https://github.com/huggingface/transformers/pull/24590",
"diff_url": "https://github.com/huggingface/transformers/pull/24590.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24590.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24589 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24589/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24589/comments | https://api.github.com/repos/huggingface/transformers/issues/24589/events | https://github.com/huggingface/transformers/issues/24589 | 1,782,185,014 | I_kwDOCUB6oc5qOfw2 | 24,589 | stuck in the evaluation_loop of trainer.py when training | {
"login": "clinton81",
"id": 24949604,
"node_id": "MDQ6VXNlcjI0OTQ5NjA0",
"avatar_url": "https://avatars.githubusercontent.com/u/24949604?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/clinton81",
"html_url": "https://github.com/clinton81",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"We can't really help without knowing the code you are running.",
"@sgugger\r\n\r\nI have located the problem statement:\r\n```\r\ntrainer.py\r\ndef _pad_across_processes(self, tensor, pad_index=-100):\r\n ....\r\n # Gather all sizes\r\n size = torch.tensor(tensor.shape, device=tensor.device)[None]\r\... | 1,688 | 1,691 | 1,691 | NONE | null | ### System Info
- Ubuntu: 20.04.5
- GPU: A800(80G) x 8
- CUDA: 11.7
- NCCL: 2.14.3
- python: 3.9.16
- deepspeed: 0.9.5
- transformers: 4.30.2
### Who can help?
@sgugger
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `ex... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24589/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24589/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24588 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24588/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24588/comments | https://api.github.com/repos/huggingface/transformers/issues/24588/events | https://github.com/huggingface/transformers/pull/24588 | 1,782,108,424 | PR_kwDOCUB6oc5UTy-J | 24,588 | ๐ [i18n-KO] Translated`tasks/document_question_answering.md` to Korean | {
"login": "jungnerd",
"id": 46880056,
"node_id": "MDQ6VXNlcjQ2ODgwMDU2",
"avatar_url": "https://avatars.githubusercontent.com/u/46880056?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jungnerd",
"html_url": "https://github.com/jungnerd",
"followers_url": "https://api.github.com/users/jun... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"May you please review this PR? ๐ค\r\n@sgugger, @ArthurZucker, @eunseojo"
] | 1,688 | 1,690 | 1,689 | CONTRIBUTOR | null | <!-- PR์ ์ ๋ชฉ์ "๐ [i18n-KO] Translated `<your_file>.mdx` to Korean" ์ผ๋ก ๋ถํ๋๋ฆฝ๋๋ค -->
# What does this PR do?
Translated the `tasks/document_question_answering.md` file of the documentation to Korean.
Thank you in advance for your review.
Part of https://github.com/huggingface/transformers/issues/20179
<!-- ๋ฉ์ธ ์ด์์... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24588/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24588/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24588",
"html_url": "https://github.com/huggingface/transformers/pull/24588",
"diff_url": "https://github.com/huggingface/transformers/pull/24588.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24588.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24587 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24587/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24587/comments | https://api.github.com/repos/huggingface/transformers/issues/24587/events | https://github.com/huggingface/transformers/pull/24587 | 1,782,059,524 | PR_kwDOCUB6oc5UToal | 24,587 | Add Llama Flax Implementation | {
"login": "vvvm23",
"id": 44398246,
"node_id": "MDQ6VXNlcjQ0Mzk4MjQ2",
"avatar_url": "https://avatars.githubusercontent.com/u/44398246?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vvvm23",
"html_url": "https://github.com/vvvm23",
"followers_url": "https://api.github.com/users/vvvm23/fo... | [] | closed | false | null | [] | [
"Very cool @vvvm23! Scanned through the PR and it looks very nice already - happy to do a full review when it's close to completion. Just drop me a line and I'll have a look! ๐ Likewise if you have any questions or queries, I'm on hand to help :)",
"The docs for this PR live [here](https://moon-ci-docs.huggingfa... | 1,688 | 1,701 | 1,701 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24587/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24587/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24587",
"html_url": "https://github.com/huggingface/transformers/pull/24587",
"diff_url": "https://github.com/huggingface/transformers/pull/24587.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24587.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24586 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24586/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24586/comments | https://api.github.com/repos/huggingface/transformers/issues/24586/events | https://github.com/huggingface/transformers/issues/24586 | 1,782,003,460 | I_kwDOCUB6oc5qNzcE | 24,586 | tokenizer = AutoTokenizer.from_pretrained('distilroberta-base') report error | {
"login": "monet-joe",
"id": 20459298,
"node_id": "MDQ6VXNlcjIwNDU5Mjk4",
"avatar_url": "https://avatars.githubusercontent.com/u/20459298?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/monet-joe",
"html_url": "https://github.com/monet-joe",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Please follow the template when reporting issue: share your system info with us. You can run the command `transformers-cli env` and copy-paste its output below.",
"However, I have tried `tokenizer = AutoTokenizer.from_pretrained('distilroberta-base')` and it works perfectly (for me).\r\n\r\nCould you also check ... | 1,688 | 1,700 | 1,688 | NONE | null | ### System Info
OSError
Can't load tokenizer for 'distilroberta-base'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'distilroberta-base' is the correct path to a directory containing all relevant files for a R... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24586/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24586/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24585 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24585/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24585/comments | https://api.github.com/repos/huggingface/transformers/issues/24585/events | https://github.com/huggingface/transformers/pull/24585 | 1,781,859,594 | PR_kwDOCUB6oc5US-ab | 24,585 | [several models] improve readability | {
"login": "stas00",
"id": 10676103,
"node_id": "MDQ6VXNlcjEwNjc2MTAz",
"avatar_url": "https://avatars.githubusercontent.com/u/10676103?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stas00",
"html_url": "https://github.com/stas00",
"followers_url": "https://api.github.com/users/stas00/fo... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"> size ([int] โ a sequence of integers **defining the shape** of the output tensor.\r\n\r\nIt's actually mentioned, but I agree it's a bit less explicit than `torch.tensor(1)`.",
"Gentlemen, sleeping more on it, actually it just ca... | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | Honestly I had no idea what `torch.ones([]) * self.config.logit_scale_init_value` would return - it's not documented either.
~Proposing to change it to a very clear `torch.tensor(1.0)` which leaves no doubt to what it does.~
Proposing to change it to a very clear `torch.tensor(self.config.logit_scale_init_value)`... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24585/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24585/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24585",
"html_url": "https://github.com/huggingface/transformers/pull/24585",
"diff_url": "https://github.com/huggingface/transformers/pull/24585.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24585.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24584 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24584/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24584/comments | https://api.github.com/repos/huggingface/transformers/issues/24584/events | https://github.com/huggingface/transformers/issues/24584 | 1,781,737,196 | I_kwDOCUB6oc5qMybs | 24,584 | fsdp support bool type in trainArgs, use len(args.fsdp) would evoke TypeError when set fsdp=True | {
"login": "duanzhenyu001",
"id": 103398099,
"node_id": "U_kgDOBim60w",
"avatar_url": "https://avatars.githubusercontent.com/u/103398099?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/duanzhenyu001",
"html_url": "https://github.com/duanzhenyu001",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"No, because it has been converted [here](https://github.com/huggingface/transformers/blob/2dc5e1a120176594ed2dcb7d2f02a5dd62266232/src/transformers/training_args.py#L1461).\r\n\r\nPlease do not open issue without a code reproducer of the problem.",
"This issue has been automatically marked as stale because it ha... | 1,688 | 1,691 | 1,691 | NONE | null | https://github.com/huggingface/transformers/blob/2dc5e1a120176594ed2dcb7d2f02a5dd62266232/src/transformers/trainer.py#L433 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24584/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24584/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24583 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24583/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24583/comments | https://api.github.com/repos/huggingface/transformers/issues/24583/events | https://github.com/huggingface/transformers/pull/24583 | 1,781,243,445 | PR_kwDOCUB6oc5UQ5Ga | 24,583 | use tokenizer model max length | {
"login": "rui-ren",
"id": 15321482,
"node_id": "MDQ6VXNlcjE1MzIxNDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/15321482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rui-ren",
"html_url": "https://github.com/rui-ren",
"followers_url": "https://api.github.com/users/rui-re... | [] | closed | false | null | [] | [] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
This PR change the `block_size` to the `tokenizer.model_max_length`, instead of using the `default 1024`.
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure i... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24583/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24583/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24583",
"html_url": "https://github.com/huggingface/transformers/pull/24583",
"diff_url": "https://github.com/huggingface/transformers/pull/24583.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24583.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24582 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24582/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24582/comments | https://api.github.com/repos/huggingface/transformers/issues/24582/events | https://github.com/huggingface/transformers/pull/24582 | 1,781,182,451 | PR_kwDOCUB6oc5UQr0U | 24,582 | Fix annotations | {
"login": "tony9402",
"id": 30228292,
"node_id": "MDQ6VXNlcjMwMjI4Mjky",
"avatar_url": "https://avatars.githubusercontent.com/u/30228292?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tony9402",
"html_url": "https://github.com/tony9402",
"followers_url": "https://api.github.com/users/ton... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
This PR is minor. Just fixed wrong annotations.
All models were tested and confirmed based on Pytorch model.
I think all the codes I modified are made based on the template.
Please check if it is okay to modify the annotation in the template code.
## Before submitting
- [x] This PR f... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24582/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24582/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24582",
"html_url": "https://github.com/huggingface/transformers/pull/24582",
"diff_url": "https://github.com/huggingface/transformers/pull/24582.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24582.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24581 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24581/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24581/comments | https://api.github.com/repos/huggingface/transformers/issues/24581/events | https://github.com/huggingface/transformers/issues/24581 | 1,781,045,478 | I_kwDOCUB6oc5qKJjm | 24,581 | _keys_to_ignore_on_load_unexpected not working with GPT2 model | {
"login": "alex-dima",
"id": 55513673,
"node_id": "MDQ6VXNlcjU1NTEzNjcz",
"avatar_url": "https://avatars.githubusercontent.com/u/55513673?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/alex-dima",
"html_url": "https://github.com/alex-dima",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"The problem stems from PyTorch lightning trying to load the model as far as I can see. Models should be loaded via the `from_pretrained` method we provide. If you are using `.load_state_dict()` it's up to you to clean the state dict you have and make sure it only contains keys the model accepts/",
"This issue ha... | 1,688 | 1,691 | 1,691 | NONE | null | ### System Info
- `transformers` version: 4.30.2
- Platform: macOS-13.2.1-arm64-arm-64bit
- Python version: 3.11.4
- Huggingface_hub version: 0.15.1
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 2.0.1 (False)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU?/TPU?): not installed... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24581/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24581/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24580 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24580/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24580/comments | https://api.github.com/repos/huggingface/transformers/issues/24580/events | https://github.com/huggingface/transformers/pull/24580 | 1,781,016,618 | PR_kwDOCUB6oc5UQJXi | 24,580 | ๐ย [i18n-KO] Translatedย `custom_tools.mdx` to Korean | {
"login": "sim-so",
"id": 96299403,
"node_id": "U_kgDOBb1piw",
"avatar_url": "https://avatars.githubusercontent.com/u/96299403?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sim-so",
"html_url": "https://github.com/sim-so",
"followers_url": "https://api.github.com/users/sim-so/followers"... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"LGTM๐",
"Thanks for the PR, @sim-so! \r\n\r\nThere's since been an update on main to all of our documentation files. Could you update the extension from `.mdx` to `.md` to match please?",
"Thanks for letting me know about the ch... | 1,688 | 1,689 | 1,689 | CONTRIBUTOR | null | # What does this PR do?
Translated the `custom_tools.mdx` file of the documentation to Korean.
Thank you in advance for your review.
Part of https://github.com/huggingface/transformers/issues/20179
## Before reviewing
- [x] Check for missing / redundant translations (๋ฒ์ญ ๋๋ฝ/์ค๋ณต ๊ฒ์ฌ)
- [x] Grammar Check (๋ง์ถค๋ฒ ๊ฒ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24580/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24580/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24580",
"html_url": "https://github.com/huggingface/transformers/pull/24580",
"diff_url": "https://github.com/huggingface/transformers/pull/24580.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24580.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24579 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24579/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24579/comments | https://api.github.com/repos/huggingface/transformers/issues/24579/events | https://github.com/huggingface/transformers/issues/24579 | 1,781,001,591 | I_kwDOCUB6oc5qJ-13 | 24,579 | Datasets in run_translation.py | {
"login": "SoyGema",
"id": 24204714,
"node_id": "MDQ6VXNlcjI0MjA0NzE0",
"avatar_url": "https://avatars.githubusercontent.com/u/24204714?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/SoyGema",
"html_url": "https://github.com/SoyGema",
"followers_url": "https://api.github.com/users/SoyGem... | [] | closed | false | null | [] | [
"cc @Rocketknight1 since this is a TensorFlow example.",
"Hey @Rocketknight1 ๐ I think we crossed in #24341 . Thanks for the Notebook repository discovery . \r\nWas a nice quick fix !\r\n\r\nIยดve given another try to some vector thoughts posted in the issue.\r\n* Regarding **reproducibility**. Read the scrip... | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | ### System Info
Hello there! ๐
I'm following along the [run_translation.py ](https://github.com/huggingface/transformers/blob/main/examples/tensorflow/translation/run_translation.py) example.
Thanks for making it! It expands gratefully from the translation docs [tutorial ](https://huggingface.co/docs/transformer... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24579/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24579/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24578 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24578/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24578/comments | https://api.github.com/repos/huggingface/transformers/issues/24578/events | https://github.com/huggingface/transformers/pull/24578 | 1,780,980,274 | PR_kwDOCUB6oc5UQBWV | 24,578 | fix peft ckpts not being pushed to hub | {
"login": "pacman100",
"id": 13534540,
"node_id": "MDQ6VXNlcjEzNTM0NTQw",
"avatar_url": "https://avatars.githubusercontent.com/u/13534540?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pacman100",
"html_url": "https://github.com/pacman100",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
1. Currently, when ckpts are saved every `save_steps` and `push_to_hub=True`, PEFT ckpts aren't being pushed to hub.
Reason:
every `save_steps` , the ckpts are being written to local `checkpoint-xx` folders. Now, in the trainer's function `_push_from_checkpoint` , it will copy the model fil... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24578/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24578/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24578",
"html_url": "https://github.com/huggingface/transformers/pull/24578",
"diff_url": "https://github.com/huggingface/transformers/pull/24578.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24578.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24577 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24577/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24577/comments | https://api.github.com/repos/huggingface/transformers/issues/24577/events | https://github.com/huggingface/transformers/pull/24577 | 1,780,950,537 | PR_kwDOCUB6oc5UP68d | 24,577 | Add imageArray | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_24577). All of your documentation changes will be reflected on that endpoint.",
"@ydshieh Adding you as a first reviewer as you're always able to give good SWE advice :) This is quite a big design decision, so will be follo... | 1,688 | 1,692 | 1,692 | COLLABORATOR | null | # What does this PR do?
Adds a new class `ImageArray` for use as part of the image processing pipeline. It acts as an array container, which we can use to store information about the image e.g. the data format. This is the recommended way to create 'array-like' numpy objects with persistent attributes: https://numpy... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24577/reactions",
"total_count": 2,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24577/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24577",
"html_url": "https://github.com/huggingface/transformers/pull/24577",
"diff_url": "https://github.com/huggingface/transformers/pull/24577.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24577.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24576 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24576/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24576/comments | https://api.github.com/repos/huggingface/transformers/issues/24576/events | https://github.com/huggingface/transformers/pull/24576 | 1,780,920,986 | PR_kwDOCUB6oc5UP0XW | 24,576 | Fix ESM models buffers | {
"login": "sgugger",
"id": 35901082,
"node_id": "MDQ6VXNlcjM1OTAxMDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/35901082?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sgugger",
"html_url": "https://github.com/sgugger",
"followers_url": "https://api.github.com/users/sgugge... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_24576). All of your documentation changes will be reflected on that endpoint."
] | 1,688 | 1,688 | 1,688 | COLLABORATOR | null | # What does this PR do?
Apparently the keys are important to be loaded from the state dict even if we create them at init. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24576/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24576/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24576",
"html_url": "https://github.com/huggingface/transformers/pull/24576",
"diff_url": "https://github.com/huggingface/transformers/pull/24576.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24576.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24575 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24575/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24575/comments | https://api.github.com/repos/huggingface/transformers/issues/24575/events | https://github.com/huggingface/transformers/issues/24575 | 1,780,919,448 | I_kwDOCUB6oc5qJqyY | 24,575 | ๐ Text Generation docs rework | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [
"Hello there @gante ! ๐\r\nFirst and foremost, thanks for opening a discussion about this .\r\n\r\nWould like to glimpse a couple of vector thoughts about point 1, as point 2 and 3 seem consistent and structured enough\r\n\r\n### 1. Designing a \"home page\" for text generation docs\r\n\r\nAs a user , the underly... | 1,688 | 1,704 | 1,704 | MEMBER | null | # What is this?
This is an issue to discuss and track the rework of the docs for text generation. Comments and feedback are appreciated, as always ๐ค
# Current issues
1. Our [main reference for text generation](https://huggingface.co/blog/how-to-generate) is not in the docs and is quite outdated
2. The docs ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24575/reactions",
"total_count": 7,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 7,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24575/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24574 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24574/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24574/comments | https://api.github.com/repos/huggingface/transformers/issues/24574/events | https://github.com/huggingface/transformers/pull/24574 | 1,780,702,906 | PR_kwDOCUB6oc5UPEis | 24,574 | Revert "Fix typing annotations for FSDP and DeepSpeed in TrainingArguments" | {
"login": "sgugger",
"id": 35901082,
"node_id": "MDQ6VXNlcjM1OTAxMDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/35901082?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sgugger",
"html_url": "https://github.com/sgugger",
"followers_url": "https://api.github.com/users/sgugge... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_24574). All of your documentation changes will be reflected on that endpoint."
] | 1,688 | 1,688 | 1,688 | COLLABORATOR | null | Reverts huggingface/transformers#24549 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24574/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24574/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24574",
"html_url": "https://github.com/huggingface/transformers/pull/24574",
"diff_url": "https://github.com/huggingface/transformers/pull/24574.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24574.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24573 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24573/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24573/comments | https://api.github.com/repos/huggingface/transformers/issues/24573/events | https://github.com/huggingface/transformers/pull/24573 | 1,780,543,089 | PR_kwDOCUB6oc5UOhZv | 24,573 | Check all objects are equally in the main `__init__` file | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"We cannot remove things from the main init, as it would be a breaking change. The `BertLayer` and the likes should never have been made public like this but it's too late now. And we shouldn't add the corresponding TF/Flax objects ei... | 1,688 | 1,688 | 1,688 | COLLABORATOR | null | # What does this PR do?
Add one more check in `check_repo.py` to further ensure objects are in the main `__init__`. (using our pytorch objects as the reference)
### Actions to take
(Do you agree @sgugger ?)
- The following should be added to the main `__init__`:
```bash
TFAutoModelForAudioClassification s... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24573/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24573/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24573",
"html_url": "https://github.com/huggingface/transformers/pull/24573",
"diff_url": "https://github.com/huggingface/transformers/pull/24573.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24573.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24572 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24572/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24572/comments | https://api.github.com/repos/huggingface/transformers/issues/24572/events | https://github.com/huggingface/transformers/pull/24572 | 1,780,535,572 | PR_kwDOCUB6oc5UOfvi | 24,572 | Docs: 4 bit doc corrections | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,688 | 1,688 | MEMBER | null | # What does this PR do?
Some 4-bit references were written with "8" instead of "4" | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24572/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24572/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24572",
"html_url": "https://github.com/huggingface/transformers/pull/24572",
"diff_url": "https://github.com/huggingface/transformers/pull/24572.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24572.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24571 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24571/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24571/comments | https://api.github.com/repos/huggingface/transformers/issues/24571/events | https://github.com/huggingface/transformers/pull/24571 | 1,780,533,902 | PR_kwDOCUB6oc5UOfXT | 24,571 | Fix annotations | {
"login": "tony9402",
"id": 30228292,
"node_id": "MDQ6VXNlcjMwMjI4Mjky",
"avatar_url": "https://avatars.githubusercontent.com/u/30228292?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tony9402",
"html_url": "https://github.com/tony9402",
"followers_url": "https://api.github.com/users/ton... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,688 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
I found wrong annotations in `MBart`, `Pegasus` model.
Fixed wrong annotation
- (seq_len, batch, embed_dim) -> (batch, seq_len, embed_dim)
## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you rea... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24571/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24571/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24571",
"html_url": "https://github.com/huggingface/transformers/pull/24571",
"diff_url": "https://github.com/huggingface/transformers/pull/24571.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24571.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24570 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24570/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24570/comments | https://api.github.com/repos/huggingface/transformers/issues/24570/events | https://github.com/huggingface/transformers/pull/24570 | 1,780,468,543 | PR_kwDOCUB6oc5UORKK | 24,570 | Removal of deprecated vision methods and specify deprecation versions | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"cc @sgugger Just wanting to double check it's OK to remove these deprecated methods now before I merge in "
] | 1,688 | 1,688 | 1,688 | COLLABORATOR | null | # What does this PR do?
* Removes a bunch of properties, methods and logic which had deprecation warnings for a few versions ago.
* Adds some specific version deprecations for methods that didn't have a specified version for deprecation
## Before submitting
- [x] This PR fixes a typo or improves the docs (you... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24570/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24570/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24570",
"html_url": "https://github.com/huggingface/transformers/pull/24570",
"diff_url": "https://github.com/huggingface/transformers/pull/24570.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24570.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24569 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24569/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24569/comments | https://api.github.com/repos/huggingface/transformers/issues/24569/events | https://github.com/huggingface/transformers/issues/24569 | 1,780,361,524 | I_kwDOCUB6oc5qHik0 | 24,569 | LlamaTokenizer: Slow implementation opts for whitespace-lead token (different from fast) | {
"login": "lbeurerkellner",
"id": 17903049,
"node_id": "MDQ6VXNlcjE3OTAzMDQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/17903049?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lbeurerkellner",
"html_url": "https://github.com/lbeurerkellner",
"followers_url": "https://api.gi... | [] | closed | false | {
"login": "ArthurZucker",
"id": 48595927,
"node_id": "MDQ6VXNlcjQ4NTk1OTI3",
"avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ArthurZucker",
"html_url": "https://github.com/ArthurZucker",
"followers_url": "https://api.github.c... | [
{
"login": "ArthurZucker",
"id": 48595927,
"node_id": "MDQ6VXNlcjQ4NTk1OTI3",
"avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ArthurZucker",
"html_url": "https://github.com/ArthurZucker",
"followers_url": "... | [
"Thanks for reporting, will have a look",
"Hi @ArthurZucker! Are you currently working on this? If not, I think I could fix it pretty quickly :)",
"Sure! Feel free to take it! ๐ I'll have a look soon otherwise\r\n",
"@ArthurZucker @lbeurerkellner I have done some debugging and I have a few observations. Firs... | 1,688 | 1,689 | 1,689 | NONE | null | ### System Info
- `transformers` version: 4.30.2
- Platform: Linux-5.15.0-75-generic-x86_64-with-glibc2.31
- Python version: 3.10.11
- Huggingface_hub version: 0.14.1
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 2.0.0 (True)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU?/T... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24569/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24569/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24568 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24568/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24568/comments | https://api.github.com/repos/huggingface/transformers/issues/24568/events | https://github.com/huggingface/transformers/issues/24568 | 1,780,178,142 | I_kwDOCUB6oc5qG1ze | 24,568 | Set FSDP `transformer_layer_cls_to_wrap` to `model._no_split_modules` ? | {
"login": "apoorvkh",
"id": 7005565,
"node_id": "MDQ6VXNlcjcwMDU1NjU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7005565?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/apoorvkh",
"html_url": "https://github.com/apoorvkh",
"followers_url": "https://api.github.com/users/apoor... | [] | closed | false | null | [] | [
"cc @pacman100 ",
"Any thoughts about this? Maybe also cc @stas00?",
"Unfortunately I don't have experience with FSDP to contribute to this discussion.",
"@pacman100 Friendly ping",
"Hello @apoorvkh, the code part you highlighted is enabled now only when using FSDP+XLA. For general FSDP, internally everythi... | 1,688 | 1,701 | 1,689 | CONTRIBUTOR | null | ### Feature request
Currently, when training with FSDP, the Trainer expects to receive an `fsdp_config` argument specifying `fsdp_transformer_layer_cls_to_wrap`.
https://github.com/huggingface/transformers/blob/66954ea25e342fd451c26ec1c295da0b8692086b/src/transformers/trainer.py#L1394-L1406
I am wondering if w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24568/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24568/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24567 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24567/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24567/comments | https://api.github.com/repos/huggingface/transformers/issues/24567/events | https://github.com/huggingface/transformers/issues/24567 | 1,780,119,294 | I_kwDOCUB6oc5qGnb- | 24,567 | MT5 data padding not working | {
"login": "hexie1995",
"id": 39319332,
"node_id": "MDQ6VXNlcjM5MzE5MzMy",
"avatar_url": "https://avatars.githubusercontent.com/u/39319332?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hexie1995",
"html_url": "https://github.com/hexie1995",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"cc @ArthurZucker ",
"Thank you. One additional information: I tried to follow step by step the official text summrization tutorial here: https://github.com/huggingface/notebooks/blob/main/examples/summarization.ipynb\r\nBut the same error occurred. Thanks a lot! ",
"Hey! Thanks for reporting could you share th... | 1,688 | 1,699 | 1,697 | NONE | null | ### System Info
Hello,
I am using the latest version of transformers.
I have run into this issue recently and would like to receive some help on it. I am using the MT5 and "google/base" to finetune to my own dataset, while processing the data, I run into the issue where I keep getting error message of dimensi... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24567/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24567/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24566 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24566/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24566/comments | https://api.github.com/repos/huggingface/transformers/issues/24566/events | https://github.com/huggingface/transformers/pull/24566 | 1,780,115,288 | PR_kwDOCUB6oc5UNFIc | 24,566 | Update some torchscript tests after #24505 | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"@sgugger Thanks for the suggestion. I actually copied from the common test file. However, there is \r\n\r\n```python\r\n model_buffers = list(model.buffers())\r\n for non_persistent_buffer in non_persistent_buff... | 1,688 | 1,688 | 1,688 | COLLABORATOR | null | # What does this PR do?
Need to update the logic in some torchscript tests after #24505 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24566/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24566/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24566",
"html_url": "https://github.com/huggingface/transformers/pull/24566",
"diff_url": "https://github.com/huggingface/transformers/pull/24566.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24566.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24565 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24565/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24565/comments | https://api.github.com/repos/huggingface/transformers/issues/24565/events | https://github.com/huggingface/transformers/pull/24565 | 1,780,000,805 | PR_kwDOCUB6oc5UMsWU | 24,565 | โ ๏ธโ ๏ธ[`T5Tokenize`] Fix T5 family tokenizersโ ๏ธโ ๏ธ | {
"login": "ArthurZucker",
"id": 48595927,
"node_id": "MDQ6VXNlcjQ4NTk1OTI3",
"avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ArthurZucker",
"html_url": "https://github.com/ArthurZucker",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Actually switch t5 tests have to be updated! \r\nThis means I have to check if the models were trained with this extra token (if they used HF tokenizer) or not.\r\n- [x] `tests.models.instructblip.test_modeling_instructblip.InstructB... | 1,688 | 1,695 | 1,688 | COLLABORATOR | null | # What does this PR do?
Fixes the `T5Tokenizer` (not the fast one yet). (at the same time adresses part of https://github.com/huggingface/transformers/issues/11531)
When converting `UMT5` I created a reproduction snippet for any t5x model form the original repo. I realized that a very very small variation in the inpu... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24565/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24565/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24565",
"html_url": "https://github.com/huggingface/transformers/pull/24565",
"diff_url": "https://github.com/huggingface/transformers/pull/24565.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24565.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24564 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24564/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24564/comments | https://api.github.com/repos/huggingface/transformers/issues/24564/events | https://github.com/huggingface/transformers/issues/24564 | 1,779,920,514 | I_kwDOCUB6oc5qF26C | 24,564 | InstructBlipProcessor not working with load_in_4bit and load_in_8bit | {
"login": "fraferra",
"id": 5224147,
"node_id": "MDQ6VXNlcjUyMjQxNDc=",
"avatar_url": "https://avatars.githubusercontent.com/u/5224147?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fraferra",
"html_url": "https://github.com/fraferra",
"followers_url": "https://api.github.com/users/frafe... | [] | closed | false | null | [] | [
"cc @younesbelkada ",
"Hi @fraferra \r\nIn https://github.com/huggingface/transformers/pull/24555 I have fixed the a silent issue with processors that you are currently facing, can you try to install transformers from source and run:\r\n\r\n```python\r\nfrom transformers import InstructBlipProcessor, InstructBlip... | 1,687 | 1,690 | 1,688 | NONE | null | ### System Info
transformers @ git+https://github.com/huggingface/transformers@68c92981ff2b804979d2e6107eeefe298d1e5183
Python 3.11.4
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 510.47.03 Driver Version: 510.47.03 CUDA Version: 11.6 |
|--------------------... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24564/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24564/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24563 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24563/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24563/comments | https://api.github.com/repos/huggingface/transformers/issues/24563/events | https://github.com/huggingface/transformers/issues/24563 | 1,779,901,720 | I_kwDOCUB6oc5qFyUY | 24,563 | Dataset features disappear after initlizing Trainer | {
"login": "lxrswdd",
"id": 35613337,
"node_id": "MDQ6VXNlcjM1NjEzMzM3",
"avatar_url": "https://avatars.githubusercontent.com/u/35613337?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lxrswdd",
"html_url": "https://github.com/lxrswdd",
"followers_url": "https://api.github.com/users/lxrswd... | [] | closed | false | null | [] | [
"Yes, the `Trainer` removes any inputs not accepted by your model our your model won't be able to do a forward pass. You can remove (at your own risk) this by setting [`remove_unused_coumns`](https://huggingface.co/docs/transformers/main_classes/trainer#transformers.TrainingArguments.remove_unused_columns) in your ... | 1,687 | 1,691 | 1,691 | NONE | null | ### System Info
- `transformers` version: 4.4.2
- Platform: Linux-5.19.0-41-generic-x86_64-with-glibc2.35
- Python version: 3.11.3
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- Tensorflow version (GPU?): not installed (NA)
- Using GPU in script?: <fill in>
- Using distributed or parallel set-up in script?: <f... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24563/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24563/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24562 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24562/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24562/comments | https://api.github.com/repos/huggingface/transformers/issues/24562/events | https://github.com/huggingface/transformers/issues/24562 | 1,779,811,473 | I_kwDOCUB6oc5qFcSR | 24,562 | eval_loss returning nan | {
"login": "NHendrickson9616",
"id": 119625034,
"node_id": "U_kgDOByFVSg",
"avatar_url": "https://avatars.githubusercontent.com/u/119625034?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NHendrickson9616",
"html_url": "https://github.com/NHendrickson9616",
"followers_url": "https://api.gi... | [] | closed | false | null | [] | [
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease note that issues that do not follow the [contributing guidelines](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md) a... | 1,687 | 1,691 | 1,691 | NONE | null | ### System Info
- `transformers` version: 4.28.0
- Platform: Linux-3.10.0-1160.24.1.el7.x86_64-x86_64-with-glibc2.17
- Python version: 3.9.12
- Huggingface_hub version: 0.14.1
- Safetensors version: not installed
- PyTorch version (GPU?): 2.0.1+cu118 (False)
- Tensorflow version (GPU?): not installed (NA)
- Fla... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24562/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24562/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24561 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24561/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24561/comments | https://api.github.com/repos/huggingface/transformers/issues/24561/events | https://github.com/huggingface/transformers/pull/24561 | 1,779,786,606 | PR_kwDOCUB6oc5UL-yx | 24,561 | llama fp16 torch.max bug fix | {
"login": "prathikr",
"id": 31260940,
"node_id": "MDQ6VXNlcjMxMjYwOTQw",
"avatar_url": "https://avatars.githubusercontent.com/u/31260940?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/prathikr",
"html_url": "https://github.com/prathikr",
"followers_url": "https://api.github.com/users/pra... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"@ArthurZucker I addressed your commment, please have another look. Thank you.",
"@amyeroberts I addressed your comment. Please merge asap, thank you."
] | 1,687 | 1,688 | 1,688 | CONTRIBUTOR | null | This PR explicitly sets the threshold tensor for `torch.max` to the same dtype as that of attn_weights to avoid accidental upcasting during mixed precision training. This unblocks ONNX Runtime integration because, without this fix, the torch onnx exporter receives mismatched types into the `torch.max` operation resulti... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24561/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24561/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24561",
"html_url": "https://github.com/huggingface/transformers/pull/24561",
"diff_url": "https://github.com/huggingface/transformers/pull/24561.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24561.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24560 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24560/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24560/comments | https://api.github.com/repos/huggingface/transformers/issues/24560/events | https://github.com/huggingface/transformers/pull/24560 | 1,779,785,251 | PR_kwDOCUB6oc5UL-gE | 24,560 | Update masked_language_modeling.md | {
"login": "condor-cp",
"id": 40066676,
"node_id": "MDQ6VXNlcjQwMDY2Njc2",
"avatar_url": "https://avatars.githubusercontent.com/u/40066676?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/condor-cp",
"html_url": "https://github.com/condor-cp",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | CONTRIBUTOR | null | Improves masked_language_modeling documentation. See https://github.com/huggingface/transformers/issues/24546
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24560/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24560/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24560",
"html_url": "https://github.com/huggingface/transformers/pull/24560",
"diff_url": "https://github.com/huggingface/transformers/pull/24560.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24560.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24559 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24559/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24559/comments | https://api.github.com/repos/huggingface/transformers/issues/24559/events | https://github.com/huggingface/transformers/pull/24559 | 1,779,774,406 | PR_kwDOCUB6oc5UL8H0 | 24,559 | Fix Typo | {
"login": "tony9402",
"id": 30228292,
"node_id": "MDQ6VXNlcjMwMjI4Mjky",
"avatar_url": "https://avatars.githubusercontent.com/u/30228292?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tony9402",
"html_url": "https://github.com/tony9402",
"followers_url": "https://api.github.com/users/ton... | [] | closed | false | null | [] | [
"Can you check if this is correct @ArthurZucker ?",
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
Fixed wrong annotation
- `(seq_len, BS, model_dim) -> (BS, seq_len, model_dim)` -> `(BS, seq_len, model_dim) -> (seq_len, BS, model_dim)`
## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24559/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24559/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24559",
"html_url": "https://github.com/huggingface/transformers/pull/24559",
"diff_url": "https://github.com/huggingface/transformers/pull/24559.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24559.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24558 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24558/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24558/comments | https://api.github.com/repos/huggingface/transformers/issues/24558/events | https://github.com/huggingface/transformers/issues/24558 | 1,779,626,220 | I_kwDOCUB6oc5qEvDs | 24,558 | Error when setting a high batch-size: `AttributeError: 'NoneType' object has no attribute 'backward'` | {
"login": "orangetin",
"id": 126978607,
"node_id": "U_kgDOB5GKLw",
"avatar_url": "https://avatars.githubusercontent.com/u/126978607?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/orangetin",
"html_url": "https://github.com/orangetin",
"followers_url": "https://api.github.com/users/orange... | [] | closed | false | {
"login": "muellerzr",
"id": 7831895,
"node_id": "MDQ6VXNlcjc4MzE4OTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7831895?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/muellerzr",
"html_url": "https://github.com/muellerzr",
"followers_url": "https://api.github.com/users/mu... | [
{
"login": "muellerzr",
"id": 7831895,
"node_id": "MDQ6VXNlcjc4MzE4OTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7831895?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/muellerzr",
"html_url": "https://github.com/muellerzr",
"followers_url": "https://api... | [
"cc @muellerzr (?)",
"@pacman100 could there be something more I need to check/do related to the deepspeed plugin when doing this that we might be missing? (basically is there a separate param that we should set on the batch size for the train bs here)",
"I can repro this so let me know if you need more logs. I... | 1,687 | 1,704 | 1,704 | NONE | null | ### System Info
Transformers version: latest@github
Accelerate version: latest@github
Deepspeed version: latest@github
### Who can help?
@pacman100 @sgugger
### Information
- [X] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `exam... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24558/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/huggingface/transformers/issues/24558/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24557 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24557/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24557/comments | https://api.github.com/repos/huggingface/transformers/issues/24557/events | https://github.com/huggingface/transformers/pull/24557 | 1,779,417,702 | PR_kwDOCUB6oc5UKrRS | 24,557 | Make PT/Flax tests could be run on GPU | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | COLLABORATOR | null | # What does this PR do?
We don't have jax/flax on our CI runner, so no issue. But when trying to run those tests on a GPU machine with jax/flax installed, we have error. See comment. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24557/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24557/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24557",
"html_url": "https://github.com/huggingface/transformers/pull/24557",
"diff_url": "https://github.com/huggingface/transformers/pull/24557.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24557.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24556 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24556/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24556/comments | https://api.github.com/repos/huggingface/transformers/issues/24556/events | https://github.com/huggingface/transformers/pull/24556 | 1,779,382,865 | PR_kwDOCUB6oc5UKji6 | 24,556 | Update PT/Flax weight conversion after #24030 | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | COLLABORATOR | null | # What does this PR do?
Similar to #24547 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24556/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24556/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24556",
"html_url": "https://github.com/huggingface/transformers/pull/24556",
"diff_url": "https://github.com/huggingface/transformers/pull/24556.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24556.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24555 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24555/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24555/comments | https://api.github.com/repos/huggingface/transformers/issues/24555/events | https://github.com/huggingface/transformers/pull/24555 | 1,779,313,457 | PR_kwDOCUB6oc5UKUFj | 24,555 | [`InstructBlip`] Add instruct blip int8 test | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | CONTRIBUTOR | null | # What does this PR do?
Addresses: https://github.com/huggingface/transformers/pull/24490#discussion_r1242098216
Also fixes an inconsistency with Blip / Blip2 processors in order for users to be able to call `.to()` with both device and dtype argument to cast the input in half precision if necessary. Happy to mov... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24555/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24555/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24555",
"html_url": "https://github.com/huggingface/transformers/pull/24555",
"diff_url": "https://github.com/huggingface/transformers/pull/24555.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24555.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24554 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24554/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24554/comments | https://api.github.com/repos/huggingface/transformers/issues/24554/events | https://github.com/huggingface/transformers/pull/24554 | 1,779,210,981 | PR_kwDOCUB6oc5UJ9gW | 24,554 | Fix processor __init__ bug if image processor undefined | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | COLLABORATOR | null | # What does this PR do?
Fixes a bug which occurs if a processor is initialized with `image_processor=None`. An exception should be raised, saying an image processor should be defined, but at the moment fails because the code references `feature_extractor` which is not defined if it's not in the kwargs.
## Before... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24554/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24554/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24554",
"html_url": "https://github.com/huggingface/transformers/pull/24554",
"diff_url": "https://github.com/huggingface/transformers/pull/24554.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24554.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24553 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24553/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24553/comments | https://api.github.com/repos/huggingface/transformers/issues/24553/events | https://github.com/huggingface/transformers/pull/24553 | 1,779,201,619 | PR_kwDOCUB6oc5UJ7du | 24,553 | Update `EncodecIntegrationTest` | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"> Thanks @ydshieh - just to confirm, these updated values come from running the model on CUDA? (versus the original values, which were obtained on CPU)\r\n\r\nYes, it's on GPU. More specifically, on our CI runner's T4 GPU.",
"Perfe... | 1,687 | 1,688 | 1,687 | COLLABORATOR | null | # What does this PR do?
Some test fail since the addition of this model. This PR just updates the expect output values. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24553/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24553/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24553",
"html_url": "https://github.com/huggingface/transformers/pull/24553",
"diff_url": "https://github.com/huggingface/transformers/pull/24553.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24553.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24552 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24552/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24552/comments | https://api.github.com/repos/huggingface/transformers/issues/24552/events | https://github.com/huggingface/transformers/pull/24552 | 1,779,135,095 | PR_kwDOCUB6oc5UJs4g | 24,552 | Update old existing feature extractor references | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"@ydshieh Thanks for pointing out the extra places I missed. I've updated + other vision files needing the same update."
] | 1,687 | 1,688 | 1,688 | COLLABORATOR | null | # What does this PR do?
Updates a bunch of old references to feature extractors for vision models.
Most of the code isn't public facing in e.g. docs, but is often copied when new models are added.
## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if tha... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24552/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24552/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24552",
"html_url": "https://github.com/huggingface/transformers/pull/24552",
"diff_url": "https://github.com/huggingface/transformers/pull/24552.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24552.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24551 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24551/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24551/comments | https://api.github.com/repos/huggingface/transformers/issues/24551/events | https://github.com/huggingface/transformers/issues/24551 | 1,779,061,904 | I_kwDOCUB6oc5qClSQ | 24,551 | LoRA training adapter_model.bin is 888 bytes always | {
"login": "kallewoof",
"id": 250224,
"node_id": "MDQ6VXNlcjI1MDIyNA==",
"avatar_url": "https://avatars.githubusercontent.com/u/250224?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kallewoof",
"html_url": "https://github.com/kallewoof",
"followers_url": "https://api.github.com/users/kall... | [] | closed | false | null | [] | [
"cc @younesbelkada ",
"I backtracked until I was on the original tloen/alpaca-lora script, using the original dataset on int8 model, and I am still seeing the 888 byte adapter_model.bin file, along with a bunch of other files that you normally don't see in a LoRA output (optimizer.pt, etc).",
"I am closing this... | 1,687 | 1,688 | 1,688 | NONE | null | ### System Info
Ubuntu 22.04
Python 3.10.11
transformers 4.30.2
peft 0.4.0.dev0
accelerate 0.20.3
### Who can help?
@ArthurZucker
@sgugger
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24551/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24551/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24550 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24550/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24550/comments | https://api.github.com/repos/huggingface/transformers/issues/24550/events | https://github.com/huggingface/transformers/pull/24550 | 1,779,016,980 | PR_kwDOCUB6oc5UJSsO | 24,550 | fix type annotations for arguments in training_args | {
"login": "shauray8",
"id": 39147312,
"node_id": "MDQ6VXNlcjM5MTQ3MzEy",
"avatar_url": "https://avatars.githubusercontent.com/u/39147312?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shauray8",
"html_url": "https://github.com/shauray8",
"followers_url": "https://api.github.com/users/sha... | [] | closed | false | null | [] | [
"Fixing CI errors! ",
"_The documentation is not available anymore as the PR was closed or merged._",
"@sgugger I don't particularly understand why this error occurs in examples_flax - ``` argparse.ArgumentError: argument --sharded_ddp: invalid typing.Union[str, bool, typing.List[transformers.trainer_utils.Shar... | 1,687 | 1,689 | 1,689 | CONTRIBUTOR | null | # What does this PR do?
Fixes #24538 which is basically fixing type annotations for `fsdp`, `fsdp_config`, and `sharded_ddp` in training_args.py
## Who can review?
maybe @sgugger | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24550/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24550/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24550",
"html_url": "https://github.com/huggingface/transformers/pull/24550",
"diff_url": "https://github.com/huggingface/transformers/pull/24550.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24550.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24549 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24549/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24549/comments | https://api.github.com/repos/huggingface/transformers/issues/24549/events | https://github.com/huggingface/transformers/pull/24549 | 1,779,010,226 | PR_kwDOCUB6oc5UJRKx | 24,549 | Fix typing annotations for FSDP and DeepSpeed in TrainingArguments | {
"login": "mryab",
"id": 16766985,
"node_id": "MDQ6VXNlcjE2NzY2OTg1",
"avatar_url": "https://avatars.githubusercontent.com/u/16766985?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mryab",
"html_url": "https://github.com/mryab",
"followers_url": "https://api.github.com/users/mryab/follow... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
" argument --deepspeed: invalid Dict value: './ds_config_zero3.json' i am face this after merge, i have change deepspeed to Optional[str] and it worked ",
"Ok, let's revert then as it's a purely cosmetic change."
] | 1,687 | 1,688 | 1,687 | CONTRIBUTOR | null | # What does this PR do?
According to the the docstrings and to the code, options `fsdp_config` and `deepspeed` of `TrainingArguments` accept dictionaries with configs for FSDP and DeepSpeed correspondingly. However, the typing annotations for both of them mention only `str` as valid arguments, which makes typing check... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24549/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24549/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24549",
"html_url": "https://github.com/huggingface/transformers/pull/24549",
"diff_url": "https://github.com/huggingface/transformers/pull/24549.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24549.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24548 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24548/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24548/comments | https://api.github.com/repos/huggingface/transformers/issues/24548/events | https://github.com/huggingface/transformers/issues/24548 | 1,778,981,894 | I_kwDOCUB6oc5qCRwG | 24,548 | VS Code Pylance does not highlight transformers imports | {
"login": "mmlynarik",
"id": 44208384,
"node_id": "MDQ6VXNlcjQ0MjA4Mzg0",
"avatar_url": "https://avatars.githubusercontent.com/u/44208384?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mmlynarik",
"html_url": "https://github.com/mmlynarik",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Sounds like an issue for VsCode or Pylance no?",
"This is probably the result of lazy module loading, or even the simple absence of a `__all__` (as far as I can see). This may not be something fixable within `transformers` but it does result from a design choice. https://github.com/huggingface/transformers/blob/... | 1,687 | 1,693 | 1,693 | NONE | null | ### System Info
When Pylance is used as language server for VSCode, it does not highlight `transformers` imports even though library is correctly installed. Classes imports and library name itself are gray instead of yellow, see the enclosed figure. I'm not sure if it relates to Pylance itself, but it would be nice ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24548/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24548/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24547 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24547/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24547/comments | https://api.github.com/repos/huggingface/transformers/issues/24547/events | https://github.com/huggingface/transformers/pull/24547 | 1,778,893,644 | PR_kwDOCUB6oc5UI3eY | 24,547 | Update PT/TF weight conversion after #24030 | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | COLLABORATOR | null | # What does this PR do?
Update PT/TF weight conversion due to the change in #24030.
(can do PT/Flax too in the same PR, but request a review first anyway)
### Code snippet to show issues and verify this PR's effect
(Failing for `main + nightly torch`. Pass for `PR + nightly torch` and `main/PR + stable torc... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24547/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24547/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24547",
"html_url": "https://github.com/huggingface/transformers/pull/24547",
"diff_url": "https://github.com/huggingface/transformers/pull/24547.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24547.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24546 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24546/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24546/comments | https://api.github.com/repos/huggingface/transformers/issues/24546/events | https://github.com/huggingface/transformers/issues/24546 | 1,778,822,285 | I_kwDOCUB6oc5qBqyN | 24,546 | DataCollatorForLanguageModeling call of tokenizer.pad causes crash | {
"login": "condor-cp",
"id": 40066676,
"node_id": "MDQ6VXNlcjQwMDY2Njc2",
"avatar_url": "https://avatars.githubusercontent.com/u/40066676?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/condor-cp",
"html_url": "https://github.com/condor-cp",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"This data collator is not meant to be used with labels in your data. It builts the labels from the input IDs (either by masking random tokens or copying the inputs).",
"I understand thank you. Then this line in the documentation is misleading, since it prepares a 'labels' feature (which works in the example beca... | 1,687 | 1,707 | 1,687 | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.30.2
- Platform: Linux-5.19.0-45-generic-x86_64-with-glibc2.35
- Python version: 3.10.6
- Huggingface_hub version: 0.15.1
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24546/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24546/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24545 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24545/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24545/comments | https://api.github.com/repos/huggingface/transformers/issues/24545/events | https://github.com/huggingface/transformers/issues/24545 | 1,778,712,381 | I_kwDOCUB6oc5qBP89 | 24,545 | open_llama tokenization modules import | {
"login": "npapasarantopoulos",
"id": 115629120,
"node_id": "U_kgDOBuRcQA",
"avatar_url": "https://avatars.githubusercontent.com/u/115629120?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/npapasarantopoulos",
"html_url": "https://github.com/npapasarantopoulos",
"followers_url": "https://... | [] | closed | false | null | [] | [
"There is not a single line in the library trying that import, so it looks like an issue on `freezegun` more than on Transformers.",
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease not... | 1,687 | 1,701 | 1,693 | NONE | null | ### System Info
I stumbled upon this issue, which is not an issue with the OpenLLaMa implementation; I did not try to use OpenLLaMA.
I am importing `transformers.pipeline` in a project including tests using [freezegun](https://github.com/spulec/freezegun) to freeze dates. It seems like freezegun recursively checks a... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24545/reactions",
"total_count": 6,
"+1": 5,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 1,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24545/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24544 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24544/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24544/comments | https://api.github.com/repos/huggingface/transformers/issues/24544/events | https://github.com/huggingface/transformers/issues/24544 | 1,778,709,403 | I_kwDOCUB6oc5qBPOb | 24,544 | Issue while training Donut model for parsing with custom decoder and tokenizer | {
"login": "akashlp27",
"id": 52736048,
"node_id": "MDQ6VXNlcjUyNzM2MDQ4",
"avatar_url": "https://avatars.githubusercontent.com/u/52736048?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akashlp27",
"html_url": "https://github.com/akashlp27",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Hi @akashlp27 \r\n\r\nAs per our [issues guidelines](https://github.com/huggingface/transformers/blob/main/ISSUES.md), we reserve GitHub issues for bugs in the repository and/or feature requests. For any other matters, we'd like to invite you to use our [forum](https://discuss.huggingface.co/) ๐ค\r\n\r\nHowever, y... | 1,687 | 1,691 | 1,691 | NONE | null | Hey all, I was trying to train donut model for parsing, which contains Arabic(only) information, in order to achieve this i had collected `Arabic corpus` from various sources and then trained,
1. `Mbart Tokenizer` for arabic corpus.
2. `Mbart decoder` with the same dataset.
Initially the model was training well me... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24544/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24544/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24543 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24543/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24543/comments | https://api.github.com/repos/huggingface/transformers/issues/24543/events | https://github.com/huggingface/transformers/pull/24543 | 1,778,650,062 | PR_kwDOCUB6oc5UIC7a | 24,543 | [`gpt2-int8`] Add gpt2-xl int8 test | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Can confirm all the tests pass now (with the accelerate PR mentioned above)"
] | 1,687 | 1,687 | 1,687 | CONTRIBUTOR | null | # What does this PR do?
Addresses: https://github.com/huggingface/transformers/pull/24504#discussion_r1243813429
Currently the test is failing because of the following reason (that I need to explore and as discussed offline @sgugger):
1- If a buffer is defined as `persistent=False` in the modeling file
2- and ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24543/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24543/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24543",
"html_url": "https://github.com/huggingface/transformers/pull/24543",
"diff_url": "https://github.com/huggingface/transformers/pull/24543.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24543.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24542 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24542/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24542/comments | https://api.github.com/repos/huggingface/transformers/issues/24542/events | https://github.com/huggingface/transformers/issues/24542 | 1,778,388,573 | I_kwDOCUB6oc5qAA5d | 24,542 | Memory leak after repeated inference | {
"login": "huu3301",
"id": 44219645,
"node_id": "MDQ6VXNlcjQ0MjE5NjQ1",
"avatar_url": "https://avatars.githubusercontent.com/u/44219645?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huu3301",
"html_url": "https://github.com/huu3301",
"followers_url": "https://api.github.com/users/huu330... | [] | closed | false | null | [] | [
"Hi @huu3301 \r\n\r\nPlease format the code snippet properly (with proper indent too). See for example\r\n\r\n<img width=\"332\" alt=\"Screenshot 2023-06-27 111112\" src=\"https://github.com/huggingface/transformers/assets/2521628/ec2852fb-695a-456b-b09f-8f99ef0bdd30\">\r\n\r\nRegarding your question about leak:\r\... | 1,687 | 1,687 | 1,687 | NONE | null | ### System Info
- `transformers` version: 4.30.2
- Platform: Linux-3.10.0-1160.90.1.el7.x86_64-x86_64-with-glibc2.17
- Python version: 3.8.13
- Huggingface_hub version: 0.14.1
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- Tensorflow version (GPU?): 2.12.0 (True)
- Flax version (CPU... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24542/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24542/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24541 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24541/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24541/comments | https://api.github.com/repos/huggingface/transformers/issues/24541/events | https://github.com/huggingface/transformers/pull/24541 | 1,778,374,028 | PR_kwDOCUB6oc5UHHac | 24,541 | Unpin DeepSpeed and require DS >= 0.9.3 | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | COLLABORATOR | null | # What does this PR do?
From @pacman100
> (for accelerate) the minimum DeepSpeed version now is 0.9.3
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24541/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24541/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24541",
"html_url": "https://github.com/huggingface/transformers/pull/24541",
"diff_url": "https://github.com/huggingface/transformers/pull/24541.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24541.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24540 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24540/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24540/comments | https://api.github.com/repos/huggingface/transformers/issues/24540/events | https://github.com/huggingface/transformers/issues/24540 | 1,778,270,143 | I_kwDOCUB6oc5p_j-_ | 24,540 | Issue Loading 4-bit and 8-bit language models: ValueError: `.to` is not supported for `4-bit` or `8-bit` models. Please use the model as it is, since the model has already been set to the correct devices and casted to the correct `dtype`. | {
"login": "DJT777",
"id": 47899472,
"node_id": "MDQ6VXNlcjQ3ODk5NDcy",
"avatar_url": "https://avatars.githubusercontent.com/u/47899472?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/DJT777",
"html_url": "https://github.com/DJT777",
"followers_url": "https://api.github.com/users/DJT777/fo... | [] | closed | false | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [
{
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url"... | [
"Hi @DJT777 \r\nThanks for the report\r\nAre you using the main branch of accelerate + single GPU? If that's the case https://github.com/huggingface/accelerate/pull/1652 should solve the issue. Will try to reproduce later without that fix",
"I wasn't able to test it using that commit. However running everything w... | 1,687 | 1,698 | 1,687 | NONE | null | ### System Info
### System Info
I'm running into an issue where I'm not able to load a 4-bit or 8-bit quantized version of Falcon or LLaMa models. This was working a couple of weeks ago. This is running on Colab. I'm wondering if anyone knows of a fix, or why this is no longer working when it was 2-3 weeks ago arou... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24540/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/huggingface/transformers/issues/24540/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24539 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24539/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24539/comments | https://api.github.com/repos/huggingface/transformers/issues/24539/events | https://github.com/huggingface/transformers/issues/24539 | 1,778,265,924 | I_kwDOCUB6oc5p_i9E | 24,539 | 4-Bit and 8-Bit Models not being loaded | {
"login": "DJT777",
"id": 47899472,
"node_id": "MDQ6VXNlcjQ3ODk5NDcy",
"avatar_url": "https://avatars.githubusercontent.com/u/47899472?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/DJT777",
"html_url": "https://github.com/DJT777",
"followers_url": "https://api.github.com/users/DJT777/fo... | [] | closed | false | null | [] | [
"Hello I know it's a bit off-topic. I'm actually never inferred a model than runs in either 4-bit and 8-bit, but i'm really wondering. Does the model will inference much slower if we infer it in 8-bit quantized model or will be much faster than the fp16/fp32 models?\r\n\r\nThank you in advance if you have this kind... | 1,687 | 1,687 | 1,687 | NONE | null | ### System Info
I'm running into an issue where I'm not able to load a 4-bit or 8-bit quantized version of Falcon or LLaMa models. This was working a couple of weeks ago. This is running on Colab. I'm wondering if anyone knows of a fix, or why this is no longer working when it was 2-3 weeks ago around June 8th.
- `... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24539/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24539/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24538 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24538/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24538/comments | https://api.github.com/repos/huggingface/transformers/issues/24538/events | https://github.com/huggingface/transformers/issues/24538 | 1,778,239,773 | I_kwDOCUB6oc5p_ckd | 24,538 | Incorrect typing of `fsdp`, `fsdp_config`, and `sharded_ddp` in `TrainingArguments` | {
"login": "O-T-O-Z",
"id": 60617932,
"node_id": "MDQ6VXNlcjYwNjE3OTMy",
"avatar_url": "https://avatars.githubusercontent.com/u/60617932?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/O-T-O-Z",
"html_url": "https://github.com/O-T-O-Z",
"followers_url": "https://api.github.com/users/O-T-O-... | [] | closed | false | null | [] | [
"We do not support any automatic type checker and our type annotations are only here to give documentation. We welcome PRs to make them more exact as long as it's not at the cost of code readability but the bottomline is that you shouldn't use a type-checker with hard errors on Transformers.",
"@sgugger So should... | 1,687 | 1,689 | 1,689 | NONE | null | ### System Info
- `transformers` version: 4.29.2
- Platform: macOS-14.0-arm64-arm-64bit
- Python version: 3.10.6
- Huggingface_hub version: 0.15.1
- Safetensors version: not installed
- PyTorch version (GPU?): 1.13.0.dev20220902 (False)
- Tensorflow version (GPU?): 2.9.0 (True)
- Flax version (CPU?/GPU?/TPU?)... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24538/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24538/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24537 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24537/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24537/comments | https://api.github.com/repos/huggingface/transformers/issues/24537/events | https://github.com/huggingface/transformers/issues/24537 | 1,778,104,540 | I_kwDOCUB6oc5p-7jc | 24,537 | Finetuning Whisper with multi-languages | {
"login": "LYPinASR",
"id": 112866899,
"node_id": "U_kgDOBro2Uw",
"avatar_url": "https://avatars.githubusercontent.com/u/112866899?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LYPinASR",
"html_url": "https://github.com/LYPinASR",
"followers_url": "https://api.github.com/users/LYPinASR/... | [] | closed | false | null | [] | [] | 1,687 | 1,687 | 1,687 | NONE | null | ### Feature request
Finetuning Whisper with multi-languages
### Motivation
Finetuning Whisper with multi-languages
### Your contribution
Finetuning Whisper with multi-languages | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24537/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24537/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24536 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24536/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24536/comments | https://api.github.com/repos/huggingface/transformers/issues/24536/events | https://github.com/huggingface/transformers/issues/24536 | 1,778,047,886 | I_kwDOCUB6oc5p-tuO | 24,536 | Add Classifier-Free Guidance sampling | {
"login": "Vermeille",
"id": 1108219,
"node_id": "MDQ6VXNlcjExMDgyMTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1108219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Vermeille",
"html_url": "https://github.com/Vermeille",
"followers_url": "https://api.github.com/users/Ve... | [] | closed | false | null | [] | [
"cc @gante \r\nBut let's see if the community requests this added feature before implementing it in the library proper :-)",
"Hey @Vermeille ๐ \r\n\r\nI have the impression that our MusicGen PR (still open, expected to get merged soon) introduces the bulk of the logic to make it happen -- see [this file](https:/... | 1,687 | 1,693 | 1,691 | CONTRIBUTOR | null | EDIT: ===========================
As I see many people copy pasting this initial code that was meant to be a basis for discussion, here is a cleaner version (yet not perfect! We're still doing improvement rounds with the huggingface team to improve it! Check the state of the PR until it's not merged! https://github.co... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24536/reactions",
"total_count": 11,
"+1": 8,
"-1": 0,
"laugh": 3,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24536/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24535 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24535/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24535/comments | https://api.github.com/repos/huggingface/transformers/issues/24535/events | https://github.com/huggingface/transformers/pull/24535 | 1,778,001,304 | PR_kwDOCUB6oc5UF3me | 24,535 | Finishing tidying keys to ignore on load | {
"login": "sgugger",
"id": 35901082,
"node_id": "MDQ6VXNlcjM1OTAxMDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/35901082?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sgugger",
"html_url": "https://github.com/sgugger",
"followers_url": "https://api.github.com/users/sgugge... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_24535). All of your documentation changes will be reflected on that endpoint."
] | 1,687 | 1,687 | 1,687 | COLLABORATOR | null | # What does this PR do?
A couple of tests are failing on main due to #24505 (and PRs merged between the start of the work on this branch and its merge). This should fix all of them.
Note: will merge as soon as CI is green to make main green again. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24535/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24535/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24535",
"html_url": "https://github.com/huggingface/transformers/pull/24535",
"diff_url": "https://github.com/huggingface/transformers/pull/24535.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24535.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24534 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24534/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24534/comments | https://api.github.com/repos/huggingface/transformers/issues/24534/events | https://github.com/huggingface/transformers/issues/24534 | 1,777,918,796 | I_kwDOCUB6oc5p-ONM | 24,534 | `AutoModelForCausalLM.from_config` doesn't handle `revision="79ec93c"` correctly | {
"login": "ibeltagy",
"id": 2287797,
"node_id": "MDQ6VXNlcjIyODc3OTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/2287797?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ibeltagy",
"html_url": "https://github.com/ibeltagy",
"followers_url": "https://api.github.com/users/ibelt... | [] | closed | false | null | [] | [
"You should pass `code_revision` and not `revision` in your second call: you are loading the model code for that revision, not the weights.",
"Works. Thank you."
] | 1,687 | 1,687 | 1,687 | CONTRIBUTOR | null | ### System Info
To reproduce:
```
from transformers import AutoModelForCausalLM, AutoConfig
config = AutoConfig.from_pretrained("mosaicml/mpt-7b", trust_remote_code=True, revision="79ec93c")
config.n_layers = 0
config.d_model = 16
config.n_heads = 4
model = AutoModelForCausalLM.from_config(config, trust_rem... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24534/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24534/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24533 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24533/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24533/comments | https://api.github.com/repos/huggingface/transformers/issues/24533/events | https://github.com/huggingface/transformers/issues/24533 | 1,777,746,507 | I_kwDOCUB6oc5p9kJL | 24,533 | [BUG] Protobuf not being correctly installed | {
"login": "yinweisu",
"id": 21029745,
"node_id": "MDQ6VXNlcjIxMDI5NzQ1",
"avatar_url": "https://avatars.githubusercontent.com/u/21029745?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/yinweisu",
"html_url": "https://github.com/yinweisu",
"followers_url": "https://api.github.com/users/yin... | [] | closed | false | null | [] | [
"Transformers is only compatible with protobuf<4.0 because packages we depend on (sentencepiece if I recall correctly) do not support protobuf 4 yet. There is little we can do on our side until they support it.\r\n\r\ncc @ydshieh in case I said something wrong.",
"Hi @yinweisu \r\n\r\nYou can uninstall `protobuf`... | 1,687 | 1,688 | 1,688 | NONE | null | ### System Info
`transformers==4.30.2`
Protobuf not being installed along with transformers even when it's specified in `setup.py`.
This can be an issue if the environment already installs latest version of protobuf, which is not compatible with tranformers
### Who can help?
_No response_
### Information
- [ ] T... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24533/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24533/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24532 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24532/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24532/comments | https://api.github.com/repos/huggingface/transformers/issues/24532/events | https://github.com/huggingface/transformers/pull/24532 | 1,777,586,658 | PR_kwDOCUB6oc5UEciO | 24,532 | Allow backbones not in backbones_supported - Maskformer Mask2Former | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Hi @amyeroberts, thanks for this feature.\r\nOnce Mask2FormerModel is instantiated using e.g. a FocalNetConfig or a SwinConfig as its backbone_config, is it possible to load pre-trained weights from one of the corresponding image cla... | 1,687 | 1,704 | 1,687 | COLLABORATOR | null | # What does this PR do?
Updates configuration creation to allow backbone configs to be pased in which aren't listed in `backbones_supported` - downgrading the exception raised to a warning.
Tested with:
```python
from transformers import (
Mask2FormerConfig,
MaskFormerConfig,
Mask2FormerMode... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24532/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24532/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24532",
"html_url": "https://github.com/huggingface/transformers/pull/24532",
"diff_url": "https://github.com/huggingface/transformers/pull/24532.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24532.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24531 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24531/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24531/comments | https://api.github.com/repos/huggingface/transformers/issues/24531/events | https://github.com/huggingface/transformers/issues/24531 | 1,777,516,560 | I_kwDOCUB6oc5p8sAQ | 24,531 | Document QA Pipeline Suddenly Down? | {
"login": "FFFiend",
"id": 96851409,
"node_id": "U_kgDOBcXV0Q",
"avatar_url": "https://avatars.githubusercontent.com/u/96851409?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/FFFiend",
"html_url": "https://github.com/FFFiend",
"followers_url": "https://api.github.com/users/FFFiend/follow... | [] | closed | false | null | [] | [
"Please follow the issue template and paste the result of `transformers-cli env`. It looks like you don't have PyTorch installed in your environment but it's hard to be sure without that. The document QA pipeline requires torch, it doesn't have an implementation in TensorFlow.",
"Resolved!! Thank you ๐ "
] | 1,687 | 1,687 | 1,687 | NONE | null | ### System Info
Transformers 4.29.2, MacOS, Python 3.9.6 64-bit,
I just have this piece of code:
```
query_pipeline = pipeline(
"document-question-answering",
model="impira/layoutlm-document-qa"
)
```
and on this Python version it gives me:
```
RuntimeError: Failed to import transfo... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24531/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24531/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24530 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24530/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24530/comments | https://api.github.com/repos/huggingface/transformers/issues/24530/events | https://github.com/huggingface/transformers/pull/24530 | 1,777,513,182 | PR_kwDOCUB6oc5UEMAZ | 24,530 | Fix Typo | {
"login": "tony9402",
"id": 30228292,
"node_id": "MDQ6VXNlcjMwMjI4Mjky",
"avatar_url": "https://avatars.githubusercontent.com/u/30228292?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tony9402",
"html_url": "https://github.com/tony9402",
"followers_url": "https://api.github.com/users/ton... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | CONTRIBUTOR | null | # What does this PR do?
Fixed wrong annotation
- `(seq_len, batch, embed_dim)` -> `(batch, seq_len, embed_dim)`
## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingf... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24530/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24530/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24530",
"html_url": "https://github.com/huggingface/transformers/pull/24530",
"diff_url": "https://github.com/huggingface/transformers/pull/24530.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24530.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24529 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24529/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24529/comments | https://api.github.com/repos/huggingface/transformers/issues/24529/events | https://github.com/huggingface/transformers/pull/24529 | 1,777,355,502 | PR_kwDOCUB6oc5UDpYK | 24,529 | Fixed OwlViTModel inplace operations | {
"login": "pasqualedem",
"id": 45567509,
"node_id": "MDQ6VXNlcjQ1NTY3NTA5",
"avatar_url": "https://avatars.githubusercontent.com/u/45567509?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pasqualedem",
"html_url": "https://github.com/pasqualedem",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"@pasqualedem Could you apply the commit suggestions, then we can merge ๐ Thanks.",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_24529). All of your documentation changes will be reflec... | 1,687 | 1,688 | 1,688 | CONTRIBUTOR | null | # What does this PR do?
This PR replaces the "/=" operator in OwlViTModel which causes an error in the backward pass with the non-inplace version.
Fixes #24525
#24525
## Who can review?
@ydshieh
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24529/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24529/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24529",
"html_url": "https://github.com/huggingface/transformers/pull/24529",
"diff_url": "https://github.com/huggingface/transformers/pull/24529.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24529.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24528 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24528/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24528/comments | https://api.github.com/repos/huggingface/transformers/issues/24528/events | https://github.com/huggingface/transformers/pull/24528 | 1,777,288,687 | PR_kwDOCUB6oc5UDau2 | 24,528 | Add `finetuned_from` property in the autogenerated model card | {
"login": "sgugger",
"id": 35901082,
"node_id": "MDQ6VXNlcjM1OTAxMDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/35901082?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sgugger",
"html_url": "https://github.com/sgugger",
"followers_url": "https://api.github.com/users/sgugge... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"What did you have in mind exactly? The only text added is \r\n```\r\n\"This model is a fine-tuned version of f\" [{self.finetuned_from}](https://huggingface.co/{self.finetuned_from}) on \"\r\n```\r\nwhich doesn't contain the `finetun... | 1,687 | 1,688 | 1,688 | COLLABORATOR | null | # What does this PR do?
We already extract the info but it wasn't properly put in the metadata. This PR adds it.
cc @julien-c @osanseviero for the exact name of the tag to use. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24528/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24528/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24528",
"html_url": "https://github.com/huggingface/transformers/pull/24528",
"diff_url": "https://github.com/huggingface/transformers/pull/24528.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24528.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24527 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24527/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24527/comments | https://api.github.com/repos/huggingface/transformers/issues/24527/events | https://github.com/huggingface/transformers/pull/24527 | 1,777,240,276 | PR_kwDOCUB6oc5UDQFM | 24,527 | Update `huggingface_hub` commit sha | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_24527). All of your documentation changes will be reflected on that endpoint."
] | 1,687 | 1,687 | 1,687 | COLLABORATOR | null | # What does this PR do?
To use `timeout=10.0` in [this commit](https://github.com/huggingface/huggingface_hub/commit/e4a419bf6bbaa95d14704cc781d3e81a49cef413).
The goal is to make sure the fix from infra team really works. But once verified, we can keep it as `10.0`. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24527/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24527/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24527",
"html_url": "https://github.com/huggingface/transformers/pull/24527",
"diff_url": "https://github.com/huggingface/transformers/pull/24527.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24527.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24526 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24526/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24526/comments | https://api.github.com/repos/huggingface/transformers/issues/24526/events | https://github.com/huggingface/transformers/pull/24526 | 1,777,235,668 | PR_kwDOCUB6oc5UDPCb | 24,526 | Find module name in an OS-agnostic fashion | {
"login": "sgugger",
"id": 35901082,
"node_id": "MDQ6VXNlcjM1OTAxMDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/35901082?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sgugger",
"html_url": "https://github.com/sgugger",
"followers_url": "https://api.github.com/users/sgugge... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"https://github.com/huggingface/transformers/blob/8a968e572c335d82c87dc3708fe0a9da79664d64/src/transformers/dynamic_module_utils.py#L274\r\nThis line should be change also~",
"Good point, it's added."
] | 1,687 | 1,687 | 1,687 | COLLABORATOR | null | # What does this PR do?
Splitting on `os.path.sep` to get the filename is not fully-compatible on Windows as the OS recognizes a local path written as `folder/file.ext`, but `os.path.sep` is `\\`. Hopefully this way is better.
Fixes #24517 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24526/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24526/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24526",
"html_url": "https://github.com/huggingface/transformers/pull/24526",
"diff_url": "https://github.com/huggingface/transformers/pull/24526.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24526.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24525 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24525/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24525/comments | https://api.github.com/repos/huggingface/transformers/issues/24525/events | https://github.com/huggingface/transformers/issues/24525 | 1,777,166,985 | I_kwDOCUB6oc5p7WqJ | 24,525 | Backward pass error during OWL-ViT finetuning | {
"login": "pasqualedem",
"id": 45567509,
"node_id": "MDQ6VXNlcjQ1NTY3NTA5",
"avatar_url": "https://avatars.githubusercontent.com/u/45567509?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pasqualedem",
"html_url": "https://github.com/pasqualedem",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"@pasqualedem \r\n\r\nWould you like to open a PR to fix it ? ๐ค ",
"Could you share your scripts for owlvit finetuning? Thanks @pasqualedem "
] | 1,687 | 1,702 | 1,688 | CONTRIBUTOR | null | ### System Info
Google Colab
### Who can help?
@ArthurZucker
@amyeroberts
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X] My own task or dataset (give details below)
### Repro... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24525/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24525/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24524 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24524/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24524/comments | https://api.github.com/repos/huggingface/transformers/issues/24524/events | https://github.com/huggingface/transformers/issues/24524 | 1,777,151,541 | I_kwDOCUB6oc5p7S41 | 24,524 | model.generate single CPU core bottleneck | {
"login": "dhcracchiolo",
"id": 47190143,
"node_id": "MDQ6VXNlcjQ3MTkwMTQz",
"avatar_url": "https://avatars.githubusercontent.com/u/47190143?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dhcracchiolo",
"html_url": "https://github.com/dhcracchiolo",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"cc @gante ",
"Hey @dhcracchiolo ๐ \r\n\r\nGood timing on your question, we are precisely exploring what we can do to speed up LLaMA within python + PyTorch + `.generate` API, in [this repo](https://github.com/fxmarty/accelerated-pytorch-transformers-generation). \r\n\r\nIn a nutshell, the model is CPU bound, as... | 1,687 | 1,692 | 1,691 | NONE | null | ### System Info
I'm running inference on a GPU EC2 instance using CUDA. After doing a little profiling I noticed the model.generate method was the clear bottleneck. Upon closer inspection running htop showed that during this method call only a single cpu core is used and is maxed out to 100%. I've made sure sure al... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24524/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24524/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24523 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24523/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24523/comments | https://api.github.com/repos/huggingface/transformers/issues/24523/events | https://github.com/huggingface/transformers/pull/24523 | 1,777,134,541 | PR_kwDOCUB6oc5UC5UV | 24,523 | Falcon port | {
"login": "Rocketknight1",
"id": 12866554,
"node_id": "MDQ6VXNlcjEyODY2NTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Rocketknight1",
"html_url": "https://github.com/Rocketknight1",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"Update: Slightly delayed because there are some breaking architecture changes between the different Falcon checkpoints - I'm merging the various layers and using config variables to switch between the behaviours.",
"_The documentation is not available anymore as the PR was closed or merged._",
"feel free to pi... | 1,687 | 1,689 | 1,689 | MEMBER | null | This PR adds the Falcon model to the main library. It's still a work in progress, and integration tests / model checkpoints still need to be added!
TODO:
- [x] Migrate custom code checkpoints to the new architecture
- [x] Confirm tokenizer can be loaded correctly with `AutoTokenizer` for all checkpoints
- [x] Upl... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24523/reactions",
"total_count": 4,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 4,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24523/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24523",
"html_url": "https://github.com/huggingface/transformers/pull/24523",
"diff_url": "https://github.com/huggingface/transformers/pull/24523.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24523.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24522 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24522/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24522/comments | https://api.github.com/repos/huggingface/transformers/issues/24522/events | https://github.com/huggingface/transformers/issues/24522 | 1,776,918,915 | I_kwDOCUB6oc5p6aGD | 24,522 | LLamaTokenizer padding_side='left' | {
"login": "davidmrau",
"id": 20661461,
"node_id": "MDQ6VXNlcjIwNjYxNDYx",
"avatar_url": "https://avatars.githubusercontent.com/u/20661461?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/davidmrau",
"html_url": "https://github.com/davidmrau",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Please ask questions like this on the [forums](https://discuss.huggingface.co/) as we keep issues for bugs and feature requests only.\r\n\r\nAll decoder models use padding on the left side since they can't properly generate the next token after a sentence if it ends with pad tokens. Llama is a decoder model, so fo... | 1,687 | 1,687 | 1,687 | NONE | null | Trying to Fine-tune the LLama model I encountered that the LLama tokenizer adds padding tokens on the left side by default. I expect the padding to be added to the right side. Is this a bug or supposed to be like this?
https://github.com/huggingface/transformers/blob/6fe8d198e3e30b709a7d233240f273804b886dcc/src/... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24522/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24522/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/24521 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24521/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24521/comments | https://api.github.com/repos/huggingface/transformers/issues/24521/events | https://github.com/huggingface/transformers/pull/24521 | 1,776,915,730 | PR_kwDOCUB6oc5UCI6I | 24,521 | Fix LR scheduler based on bs from auto bs finder | {
"login": "muellerzr",
"id": 7831895,
"node_id": "MDQ6VXNlcjc4MzE4OTU=",
"avatar_url": "https://avatars.githubusercontent.com/u/7831895?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/muellerzr",
"html_url": "https://github.com/muellerzr",
"followers_url": "https://api.github.com/users/mu... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._",
"cc @mzamini92",
"> cc @mzamini92\r\n\r\nyup that works. ๐ ",
"@muellerzr I think there might be a problem with this PR, after building from source, the following snippet gives me a learning rate of 0 before the end of training:\... | 1,687 | 1,689 | 1,687 | CONTRIBUTOR | null | # What does this PR do?
This PR presents an alternative to https://github.com/huggingface/transformers/pull/23038, since we can't actually modify the schedulers realistically in Accelerate, this sets the correct "total batch size" based on the new bs being used, which gets trickled down to the creation of the schedu... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24521/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24521/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24521",
"html_url": "https://github.com/huggingface/transformers/pull/24521",
"diff_url": "https://github.com/huggingface/transformers/pull/24521.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24521.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24520 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24520/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24520/comments | https://api.github.com/repos/huggingface/transformers/issues/24520/events | https://github.com/huggingface/transformers/pull/24520 | 1,776,892,363 | PR_kwDOCUB6oc5UCDmL | 24,520 | set model to training mode before accelerate.prepare | {
"login": "sywangyi",
"id": 36058628,
"node_id": "MDQ6VXNlcjM2MDU4NjI4",
"avatar_url": "https://avatars.githubusercontent.com/u/36058628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sywangyi",
"html_url": "https://github.com/sywangyi",
"followers_url": "https://api.github.com/users/syw... | [] | closed | false | null | [] | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | 1,687 | 1,687 | 1,687 | CONTRIBUTOR | null | - trainer: @sgugger
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24520/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24520/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/24520",
"html_url": "https://github.com/huggingface/transformers/pull/24520",
"diff_url": "https://github.com/huggingface/transformers/pull/24520.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/24520.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/24519 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/24519/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/24519/comments | https://api.github.com/repos/huggingface/transformers/issues/24519/events | https://github.com/huggingface/transformers/issues/24519 | 1,776,796,747 | I_kwDOCUB6oc5p58RL | 24,519 | I have a question in the source code called modeling_llama.py | {
"login": "park1200656",
"id": 20066633,
"node_id": "MDQ6VXNlcjIwMDY2NjMz",
"avatar_url": "https://avatars.githubusercontent.com/u/20066633?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/park1200656",
"html_url": "https://github.com/park1200656",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"Hey @park1200656 ๐ \r\n\r\nSome operations degrade the quality of the outputs if not performed at a certain minimum precision. The softmax in the attention layer and the variance accumulation in RMSNorm performed in FP32 are two examples of that :) Related read: [this issue](https://github.com/huggingface/transfo... | 1,687 | 1,691 | 1,691 | NONE | null | ### System Info
@ArthurZucker @gante
path : "src/transformers/models/llama/modeling_llama.py"
Line 85 and 232 of this code contains float32 as a constant.
I think, it looks like a bug. Or is there another reason?
Thanks.
### Who can help?
_No response_
### Information
- [ ] The official example scripts
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/24519/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/24519/timeline | completed | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.