url stringlengths 62 66 | repository_url stringclasses 1
value | labels_url stringlengths 76 80 | comments_url stringlengths 71 75 | events_url stringlengths 69 73 | html_url stringlengths 50 56 | id int64 377M 2.15B | node_id stringlengths 18 32 | number int64 1 29.2k | title stringlengths 1 487 | user dict | labels list | state stringclasses 2
values | locked bool 2
classes | assignee dict | assignees list | comments list | created_at int64 1.54k 1.71k | updated_at int64 1.54k 1.71k | closed_at int64 1.54k 1.71k ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 2
values | body stringlengths 0 234k ⌀ | reactions dict | timeline_url stringlengths 71 75 | state_reason stringclasses 3
values | draft bool 2
classes | pull_request dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/transformers/issues/28557 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28557/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28557/comments | https://api.github.com/repos/huggingface/transformers/issues/28557/events | https://github.com/huggingface/transformers/pull/28557 | 2,086,242,029 | PR_kwDOCUB6oc5kUNpJ | 28,557 | Fix duplicate & unnecessary flash attention warnings | {
"login": "fxmarty",
"id": 9808326,
"node_id": "MDQ6VXNlcjk4MDgzMjY=",
"avatar_url": "https://avatars.githubusercontent.com/u/9808326?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fxmarty",
"html_url": "https://github.com/fxmarty",
"followers_url": "https://api.github.com/users/fxmarty/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28557). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"@amyeroberts Thank you. `logger.warning_once` works, however it does not in case w... | 1,705 | 1,708 | 1,706 | COLLABORATOR | null | Complete the fixes from https://github.com/huggingface/transformers/pull/28142, that finally closes https://github.com/huggingface/transformers/issues/28052
With this PR:
* no log is shown when loading from `from_config` with a good `torch_dtype` is set (fp16, bf16), while previously erronous logs were shown (https... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28557/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28557/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28557",
"html_url": "https://github.com/huggingface/transformers/pull/28557",
"diff_url": "https://github.com/huggingface/transformers/pull/28557.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28557.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28556 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28556/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28556/comments | https://api.github.com/repos/huggingface/transformers/issues/28556/events | https://github.com/huggingface/transformers/pull/28556 | 2,086,192,123 | PR_kwDOCUB6oc5kUCyF | 28,556 | Feature Update [added `initial_prompt` support for automatic-speech-recognition whisper pipeline] | {
"login": "Biswajit2902",
"id": 10162006,
"node_id": "MDQ6VXNlcjEwMTYyMDA2",
"avatar_url": "https://avatars.githubusercontent.com/u/10162006?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Biswajit2902",
"html_url": "https://github.com/Biswajit2902",
"followers_url": "https://api.github.c... | [] | open | false | null | [] | [
"Hi thank you your code saved my day! I think line 535 needs to modify a bit `prompt_tensor = torch.tensor(generate_kwargs[\"prompt_ids\"], dtype=out[\"tokens\"].dtype).cuda() if is_torch_cuda_available else torch.tensor(generate_kwargs[\"prompt_ids\"], dtype=out[\"tokens\"].dtype)`, and add `is_torch_cuda_availabl... | 1,705 | 1,707 | null | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28556/reactions",
"total_count": 2,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 2,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28556/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28556",
"html_url": "https://github.com/huggingface/transformers/pull/28556",
"diff_url": "https://github.com/huggingface/transformers/pull/28556.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28556.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28555 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28555/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28555/comments | https://api.github.com/repos/huggingface/transformers/issues/28555/events | https://github.com/huggingface/transformers/pull/28555 | 2,086,171,345 | PR_kwDOCUB6oc5kT-Ur | 28,555 | Fix max_new_tokens for assistant model in assistant generation | {
"login": "jmamou",
"id": 19263306,
"node_id": "MDQ6VXNlcjE5MjYzMzA2",
"avatar_url": "https://avatars.githubusercontent.com/u/19263306?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jmamou",
"html_url": "https://github.com/jmamou",
"followers_url": "https://api.github.com/users/jmamou/fo... | [] | closed | false | null | [] | [
"It seems that it has been solved yesterday by @ofirzaf https://github.com/huggingface/transformers/pull/28508#issuecomment-1892870681"
] | 1,705 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
During assistant generation, at each iteration, assistant model generate `num_assistant_tokens` tokens.
If the maximum numbers of tokens to generate is limited by `max_len`, in the case that `max_len-cur_len` is less than `num_assistant_tokens`, it will be more efficient for the assistant... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28555/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28555/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28555",
"html_url": "https://github.com/huggingface/transformers/pull/28555",
"diff_url": "https://github.com/huggingface/transformers/pull/28555.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28555.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28554 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28554/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28554/comments | https://api.github.com/repos/huggingface/transformers/issues/28554/events | https://github.com/huggingface/transformers/pull/28554 | 2,086,068,129 | PR_kwDOCUB6oc5kToJn | 28,554 | `intial_prompt` support for automatic-speech-recognition (whisper) pipeline | {
"login": "Biswajit2902",
"id": 10162006,
"node_id": "MDQ6VXNlcjEwMTYyMDA2",
"avatar_url": "https://avatars.githubusercontent.com/u/10162006?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Biswajit2902",
"html_url": "https://github.com/Biswajit2902",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28554/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28554/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28554",
"html_url": "https://github.com/huggingface/transformers/pull/28554",
"diff_url": "https://github.com/huggingface/transformers/pull/28554.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28554.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28553 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28553/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28553/comments | https://api.github.com/repos/huggingface/transformers/issues/28553/events | https://github.com/huggingface/transformers/issues/28553 | 2,086,028,169 | I_kwDOCUB6oc58VkOJ | 28,553 | llama 2 conversion script unknown error | {
"login": "liboliba",
"id": 51449526,
"node_id": "MDQ6VXNlcjUxNDQ5NTI2",
"avatar_url": "https://avatars.githubusercontent.com/u/51449526?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/liboliba",
"html_url": "https://github.com/liboliba",
"followers_url": "https://api.github.com/users/lib... | [] | open | false | null | [] | [
"Hi @liboliba, thanks for raising an issue! \r\n\r\nSo that we can best help you, please make sure to follow the [issue template](https://github.com/huggingface/transformers/blob/main/.github/ISSUE_TEMPLATE/bug-report.yml) including: \r\n* The running environment: run `transformers-cli env` in the terminal and copy... | 1,705 | 1,708 | null | NONE | null | ### System Info
Hi,
I have downloaded llama 2 weights and installed the transformer package. I plan to use it under transformer package and applied the conversion script.
The conversion script does not work:
python src/transformers/models/llama/convert_llama_weights_to_hf.py \
--input_dir /path/to/downloaded... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28553/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28553/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28552 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28552/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28552/comments | https://api.github.com/repos/huggingface/transformers/issues/28552/events | https://github.com/huggingface/transformers/pull/28552 | 2,086,011,975 | PR_kwDOCUB6oc5kTb95 | 28,552 | Fix SDPA tests | {
"login": "fxmarty",
"id": 9808326,
"node_id": "MDQ6VXNlcjk4MDgzMjY=",
"avatar_url": "https://avatars.githubusercontent.com/u/9808326?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fxmarty",
"html_url": "https://github.com/fxmarty",
"followers_url": "https://api.github.com/users/fxmarty/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28552). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Thank you @amyeroberts "
] | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | @ydshieh testing on a T4 (& cpu), all tests pass now. Most of the failing ones were due to the fact that we run the CI on a T4 GPU, that does not support bf16. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28552/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28552/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28552",
"html_url": "https://github.com/huggingface/transformers/pull/28552",
"diff_url": "https://github.com/huggingface/transformers/pull/28552.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28552.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28551 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28551/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28551/comments | https://api.github.com/repos/huggingface/transformers/issues/28551/events | https://github.com/huggingface/transformers/pull/28551 | 2,085,796,120 | PR_kwDOCUB6oc5kSswv | 28,551 | [Makefile] Exclude research projects from format | {
"login": "patrickvonplaten",
"id": 23423619,
"node_id": "MDQ6VXNlcjIzNDIzNjE5",
"avatar_url": "https://avatars.githubusercontent.com/u/23423619?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/patrickvonplaten",
"html_url": "https://github.com/patrickvonplaten",
"followers_url": "https://... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | MEMBER | null | # What does this PR do?
When running `make style` from root, the research folder files are changed even though they are outdated. This PR makes sure we exclude the deprecated research folder all together.
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28551/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28551/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28551",
"html_url": "https://github.com/huggingface/transformers/pull/28551",
"diff_url": "https://github.com/huggingface/transformers/pull/28551.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28551.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28550 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28550/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28550/comments | https://api.github.com/repos/huggingface/transformers/issues/28550/events | https://github.com/huggingface/transformers/issues/28550 | 2,085,781,875 | I_kwDOCUB6oc58UoFz | 28,550 | Tr-OCR Large Checkpoint model diverges | {
"login": "nogifeet",
"id": 72322393,
"node_id": "MDQ6VXNlcjcyMzIyMzkz",
"avatar_url": "https://avatars.githubusercontent.com/u/72322393?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nogifeet",
"html_url": "https://github.com/nogifeet",
"followers_url": "https://api.github.com/users/nog... | [] | open | false | null | [] | [
"Hi @nogifeet, thanks for raising this issue! \r\n\r\nHmmm, I'm not sure what's happening here. However, I don't think there's an issue in the code itself. \r\n\r\nClearly the larger model isn't generating the eos token. However, the processing and generation configs for the models are equivalent, and the only diff... | 1,705 | 1,706 | null | NONE | null | ### System Info
Transformers Version -- 4.35.2
Python Version -- 3.10.12 [GCC 11.4.0]
Environment -- Google Colab
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` fold... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28550/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28550/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28558 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28558/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28558/comments | https://api.github.com/repos/huggingface/transformers/issues/28558/events | https://github.com/huggingface/transformers/issues/28558 | 2,086,245,243 | I_kwDOCUB6oc58WZN7 | 28,558 | Optional files still require token for `huggingface-cli` downloaded gated repo | {
"login": "scruel",
"id": 16933298,
"node_id": "MDQ6VXNlcjE2OTMzMjk4",
"avatar_url": "https://avatars.githubusercontent.com/u/16933298?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/scruel",
"html_url": "https://github.com/scruel",
"followers_url": "https://api.github.com/users/scruel/fo... | [
{
"id": 3817266200,
"node_id": "MDU6TGFiZWwzODE3MjY2MjAw",
"url": "https://api.github.com/repos/huggingface/transformers/labels/bug",
"name": "bug",
"color": "d73a4a",
"default": true,
"description": null
}
] | closed | false | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [
{
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.githu... | [
"@scruel it is expected that `.no_exist` is not populated when using `huggingface-cli download --resume-download meta-llama/Llama-2-7b-hf`. In fact, the \"no exists\" folder is only populated when `transformers` (or any script/library) tries to download a file that does not exist on the repo. `transformers` uses th... | 1,705 | 1,706 | 1,706 | CONTRIBUTOR | null | ### Describe the bug
For functions `from_XXX`, it will create empty files into `.no_exist` directory if repo have some files missed, however the CLI tool `huggingface-cli download` won't do so, which caused inconsistency issues.
### Reproduction
1. `export HF_TOKEN=XXX`
2. `huggingface-cli download --resume-d... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28558/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28558/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28549 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28549/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28549/comments | https://api.github.com/repos/huggingface/transformers/issues/28549/events | https://github.com/huggingface/transformers/issues/28549 | 2,085,743,538 | I_kwDOCUB6oc58Ueuy | 28,549 | Fine tuning whisper and whisper lora with prompts | {
"login": "kenfus",
"id": 47979198,
"node_id": "MDQ6VXNlcjQ3OTc5MTk4",
"avatar_url": "https://avatars.githubusercontent.com/u/47979198?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kenfus",
"html_url": "https://github.com/kenfus",
"followers_url": "https://api.github.com/users/kenfus/fo... | [] | open | false | null | [] | [
"Hi @kenfus, thanks for raising an issue! \r\n\r\nThis is a question best placed in our [forums](https://discuss.huggingface.co/). We try to reserve the github issues for feature requests and bug reports.\r\n\r\ncc @sanchit-gandhi @ylacombe ",
"Hey, thank you!\r\n\r\nI have added a question to this post: https://... | 1,705 | 1,708 | null | NONE | null | ### Feature request
Currently, I am successfully able to fine-tune whisper and whisper Lora with timestamps, thank you for that!
Now, I would like to fine tune whisper with prompts, as Openai has trained it. There is not too much documentation, so maybe it's already in? Currently, my dataset has the following col... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28549/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28549/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28548 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28548/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28548/comments | https://api.github.com/repos/huggingface/transformers/issues/28548/events | https://github.com/huggingface/transformers/issues/28548 | 2,085,696,927 | I_kwDOCUB6oc58UTWf | 28,548 | Pipeline batching with ZeroShotImageClassificationPipeline outputs less items per iteration than expected | {
"login": "ryan-caesar-ramos",
"id": 65334734,
"node_id": "MDQ6VXNlcjY1MzM0NzM0",
"avatar_url": "https://avatars.githubusercontent.com/u/65334734?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ryan-caesar-ramos",
"html_url": "https://github.com/ryan-caesar-ramos",
"followers_url": "https... | [] | closed | false | null | [] | [
"Batch_size is transparent. The model will run the inference batched, but the pipeline still outputs results one by one, meaning you can modify the batch_size according to the actual hardware you are using without actually needing to unpack results manually (it also allows running next batch, before you even finish... | 1,705 | 1,705 | 1,705 | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-6.5.0-14-generic-x86_64-with-glibc2.35
- Python version: 3.11.5
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.0
- Accelerate version: 0.24.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.1+cu121 (True)
- Tensorflo... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28548/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28548/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28547 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28547/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28547/comments | https://api.github.com/repos/huggingface/transformers/issues/28547/events | https://github.com/huggingface/transformers/pull/28547 | 2,085,630,838 | PR_kwDOCUB6oc5kSJcn | 28,547 | [`PEFT`] make the trainer support resume checkpoint from a named adapter #28531 | {
"login": "chenbin11200",
"id": 5245644,
"node_id": "MDQ6VXNlcjUyNDU2NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5245644?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chenbin11200",
"html_url": "https://github.com/chenbin11200",
"followers_url": "https://api.github.com... | [] | open | false | null | [] | [
"cc @younesbelkada ",
"> Makes sense, thank you ! Can you also run the styling checks? `make fixup`\r\n\r\nHi @younesbelkada , I have made the styling checks. If there is still something missing, please informe me :D",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28... | 1,705 | 1,708 | null | NONE | null | # What does this PR do?
Fixes # 28531
In peft>=0.5.0, when one initialize the PeftModel with a adapter name, like
```python
peft_model = get_peft_model(model=base_model,
peft_config=peft_config,
adapter_name='my_lora_model_name',
```
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28547/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28547/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28547",
"html_url": "https://github.com/huggingface/transformers/pull/28547",
"diff_url": "https://github.com/huggingface/transformers/pull/28547.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28547.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28546 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28546/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28546/comments | https://api.github.com/repos/huggingface/transformers/issues/28546/events | https://github.com/huggingface/transformers/issues/28546 | 2,085,555,311 | I_kwDOCUB6oc58Twxv | 28,546 | How to use fp32 and qLora to fine-tune models | {
"login": "guoyunqingyue",
"id": 77528622,
"node_id": "MDQ6VXNlcjc3NTI4NjIy",
"avatar_url": "https://avatars.githubusercontent.com/u/77528622?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/guoyunqingyue",
"html_url": "https://github.com/guoyunqingyue",
"followers_url": "https://api.githu... | [] | open | false | null | [] | [
"Hi @guoyunqingyue, thanks for raising an issue! \r\n\r\nMy first suggest would be to update your version of transformers, as there have been many recent updates to weight loading and quantization in the codebase: `pip install -U transformers`. \r\n\r\nSo that we can be best help you, please make sure to follow the... | 1,705 | 1,708 | null | NONE | null | ### System Info
I'm using transformers version 4.32.0 and I want to fine-tune the Qwen/Qwen-VL-Chat-Int4 model, but my 1080ti GPU doesn't support fp16. When I want to use "training_args.fp16 = False" to modify the parameters, the error "dataclasses.FrozenInstanceError: cannot assign to field fp16" will be reported. I ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28546/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28546/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28545 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28545/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28545/comments | https://api.github.com/repos/huggingface/transformers/issues/28545/events | https://github.com/huggingface/transformers/issues/28545 | 2,085,330,571 | I_kwDOCUB6oc58S56L | 28,545 | Download reconfiguration | {
"login": "LOVE-YOURSELF-1",
"id": 71559440,
"node_id": "MDQ6VXNlcjcxNTU5NDQw",
"avatar_url": "https://avatars.githubusercontent.com/u/71559440?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/LOVE-YOURSELF-1",
"html_url": "https://github.com/LOVE-YOURSELF-1",
"followers_url": "https://api... | [] | open | false | null | [] | [
"Hi @LOVE-YOURSELF-1, thanks for opening this feature request! \r\n\r\nIf you want to download a specific file from the hub, you can use `hf_hub_download` from `huggingface_hub`. \r\n\r\nIf you are using the auto classes, they will only download what's necessary. For example: \r\n\r\n```\r\nfrom transformers import... | 1,705 | 1,708 | null | NONE | null | ### Feature request
Download reconfiguration
### Motivation
Separate out the download of the pretrained function for model、configuration and tokenizer.
### Your contribution
Do you think it is necessary？ | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28545/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28545/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28544 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28544/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28544/comments | https://api.github.com/repos/huggingface/transformers/issues/28544/events | https://github.com/huggingface/transformers/issues/28544 | 2,085,205,752 | I_kwDOCUB6oc58Sbb4 | 28,544 | Early stopping patience does not work when resuming from checkpoint | {
"login": "Ubadub",
"id": 1286898,
"node_id": "MDQ6VXNlcjEyODY4OTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/1286898?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Ubadub",
"html_url": "https://github.com/Ubadub",
"followers_url": "https://api.github.com/users/Ubadub/foll... | [] | open | false | null | [] | [
"IMO, the problem can be generalised through the TrainingArguments parameter `save_only_model` ([link](https://github.com/huggingface/transformers/blob/v4.36.1/src/transformers/training_args.py#L307)):\r\n\r\nIts definition states: \"...when this is true, you won't be able to resume training from checkpoint.\".\r\n... | 1,705 | 1,706 | null | CONTRIBUTOR | null | ### System Info
- `transformers` version: 4.33.3
- Platform: Linux-4.18.0-348.23.1.el8_5.x86_64-x86_64-with-glibc2.28
- Python version: 3.9.16
- Huggingface_hub version: 0.16.2
- Safetensors version: 0.3.1
- Accelerate version: 0.24.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.0.post101 (Fa... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28544/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28544/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28543 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28543/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28543/comments | https://api.github.com/repos/huggingface/transformers/issues/28543/events | https://github.com/huggingface/transformers/issues/28543 | 2,085,134,751 | I_kwDOCUB6oc58SKGf | 28,543 | IsADirectoryError: [Errno 21] Is a directory: 'my-company/my-llm' | {
"login": "gventuri",
"id": 15671184,
"node_id": "MDQ6VXNlcjE1NjcxMTg0",
"avatar_url": "https://avatars.githubusercontent.com/u/15671184?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gventuri",
"html_url": "https://github.com/gventuri",
"followers_url": "https://api.github.com/users/gve... | [] | closed | false | null | [] | [
"Hey! Make sure you are logged in to the hub on `my-company` . For me this works: \r\n```python \r\n>>> from transformers import AutoModel\r\n>>> model = AutoModel.from_pretrained(\"bert-base-uncase\")\r\n>>> model.push_to_hub(\"ArthurZ/my-llm\")\r\nCommitInfo(commit_url='https://huggingface.co/ArthurZ/my-llm/commi... | 1,705 | 1,705 | 1,705 | NONE | null | ### System Info
- `transformers` version: 4.37.0.dev0
- Platform: Linux-5.15.0-89-generic-x86_64-with-glibc2.31
- Python version: 3.10.11
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: 0.27.0.dev0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (True)
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28543/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28543/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28542 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28542/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28542/comments | https://api.github.com/repos/huggingface/transformers/issues/28542/events | https://github.com/huggingface/transformers/pull/28542 | 2,084,992,834 | PR_kwDOCUB6oc5kQBBB | 28,542 | [docs] DeepSpeed | {
"login": "stevhliu",
"id": 59462357,
"node_id": "MDQ6VXNlcjU5NDYyMzU3",
"avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/stevhliu",
"html_url": "https://github.com/stevhliu",
"followers_url": "https://api.github.com/users/ste... | [] | closed | false | null | [] | [
"First draft wrapped up!\r\n\r\n1. It is easier to find `HfDeepSpeedConfig` now\r\n2. Prebuilding troubleshooting steps are in `debugging.md`\r\n3. Testing the DeepSpeed integration is moved to `testing.md`\r\n4. The main DeepSpeed guide is refactored to flow better. For example, installation > memory requirements ... | 1,705 | 1,706 | 1,706 | MEMBER | null | Refactors the [DeepSpeed API page](https://huggingface.co/docs/transformers/main/en/main_classes/deepspeed#deepspeed-integration) to make it easier to find and view `HfDeepSpeedConfig`, the only actual API reference on this doc. The rest of the DeepSpeed content will go to the Efficient Training Techniques section as a... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28542/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28542/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28542",
"html_url": "https://github.com/huggingface/transformers/pull/28542",
"diff_url": "https://github.com/huggingface/transformers/pull/28542.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28542.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28541 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28541/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28541/comments | https://api.github.com/repos/huggingface/transformers/issues/28541/events | https://github.com/huggingface/transformers/issues/28541 | 2,084,552,019 | I_kwDOCUB6oc58P71T | 28,541 | LLM fine-tuning with deepspeed | {
"login": "vallabh001",
"id": 88985147,
"node_id": "MDQ6VXNlcjg4OTg1MTQ3",
"avatar_url": "https://avatars.githubusercontent.com/u/88985147?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vallabh001",
"html_url": "https://github.com/vallabh001",
"followers_url": "https://api.github.com/use... | [] | open | false | null | [] | [
"Hi @vallabh001, thanks for raising an issue! \r\n\r\nSo that we can best help you, please make sure to follow the [issue template](https://github.com/huggingface/transformers/blob/main/.github/ISSUE_TEMPLATE/bug-report.yml) and provide:\r\n* The full error traceback\r\n* A minimal code snippet we can use to reprod... | 1,705 | 1,708 | null | NONE | null | I was trying to fine-tune llama2 by referring this [blog](https://www.philschmid.de/instruction-tune-llama-2l), but the training time is very high (in days). So, I was thinking of using deepspeed optimization for the training process. However, there is no proper documentation for fine-tuning llm's using deepspeed.
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28541/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28541/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28540 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28540/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28540/comments | https://api.github.com/repos/huggingface/transformers/issues/28540/events | https://github.com/huggingface/transformers/pull/28540 | 2,084,533,824 | PR_kwDOCUB6oc5kOY9P | 28,540 | Remove CaptureLogger | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28540). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Closing for now as we need some funky logs for the no logs case whilst we still su... | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
Replace our custom CaptureLogger class with the python library `unittest.TestCase().assertLogs`.
Makes testing for no logs being raised more robust - asserts no logs rather than string matching.
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss t... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28540/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28540/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28540",
"html_url": "https://github.com/huggingface/transformers/pull/28540",
"diff_url": "https://github.com/huggingface/transformers/pull/28540.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28540.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28539 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28539/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28539/comments | https://api.github.com/repos/huggingface/transformers/issues/28539/events | https://github.com/huggingface/transformers/issues/28539 | 2,084,510,356 | I_kwDOCUB6oc58PxqU | 28,539 | `load_best_model_at_end` is inconsistent with evaluation (and save) logic at end of training | {
"login": "antoine-lizee",
"id": 2957716,
"node_id": "MDQ6VXNlcjI5NTc3MTY=",
"avatar_url": "https://avatars.githubusercontent.com/u/2957716?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/antoine-lizee",
"html_url": "https://github.com/antoine-lizee",
"followers_url": "https://api.github.... | [] | open | false | null | [] | [
"### Notes\r\n\r\nI realize that this issue probably doesn't arise if the strategy is `epoch`.\r\n\r\nIt seems that using N + epsilon as the `num_train_epochs` would go around this problem in a very hacky way (and evaluate / save the model that corresponds to the first step after the desired epoch that is a multipl... | 1,705 | 1,708 | null | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-5.10.201-191.748.amzn2.x86_64-x86_64-with-glibc2.26
- Python version: 3.10.13
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.3.3
- Accelerate version: 0.26.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1 (True)
- T... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28539/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28539/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28538 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28538/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28538/comments | https://api.github.com/repos/huggingface/transformers/issues/28538/events | https://github.com/huggingface/transformers/pull/28538 | 2,084,408,051 | PR_kwDOCUB6oc5kN9vs | 28,538 | [`gradient_checkpointing`] default to use it for torch 2.3 | {
"login": "ArthurZucker",
"id": 48595927,
"node_id": "MDQ6VXNlcjQ4NTk1OTI3",
"avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ArthurZucker",
"html_url": "https://github.com/ArthurZucker",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"Why do we use reentrant gc by default? It said the non-reentrant gc can be more advantageous than the reentrant version: https://pytorch.org/docs/2.0/checkpoint.html#torch.utils.checkpoint.checkpoint",
"@hiyouga the use_reentrant=True is used by default in PT anyway so if you set it to `None`, `use_reentrant` wi... | 1,705 | 1,708 | 1,708 | COLLABORATOR | null | # What does this PR do?
Fixes #28536 in preparation for next torch release | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28538/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28538/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28538",
"html_url": "https://github.com/huggingface/transformers/pull/28538",
"diff_url": "https://github.com/huggingface/transformers/pull/28538.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28538.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28537 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28537/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28537/comments | https://api.github.com/repos/huggingface/transformers/issues/28537/events | https://github.com/huggingface/transformers/pull/28537 | 2,084,372,239 | PR_kwDOCUB6oc5kN15A | 28,537 | Fixes default value of `softmax_scale` in `PhiFlashAttention2`. | {
"login": "gugarosa",
"id": 4120639,
"node_id": "MDQ6VXNlcjQxMjA2Mzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/4120639?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gugarosa",
"html_url": "https://github.com/gugarosa",
"followers_url": "https://api.github.com/users/gugar... | [] | closed | false | null | [] | [
"The `loss=0.0` error while fine-tuning with FP16 is another issue and I do have an ugly fix, but will look into it with more patience (and use a separate PR).",
"No problems! Thanks for the merge!",
"Thanks very much @gugarosa for the deep dive and the fix! ",
"The docs for this PR live [here](https://moon-c... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
- Phi has never used `softmax_scale=1.0` with Flash-Attention, so the default is being moved to `None`. This tentatively fixes any issue regarding fine-tuning Phi-based checkpoints when Flash-Attention 2 is turned on.
- Documentation is also updated to reflect the official Phi checkpoints.... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28537/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 1,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28537/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28537",
"html_url": "https://github.com/huggingface/transformers/pull/28537",
"diff_url": "https://github.com/huggingface/transformers/pull/28537.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28537.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28536 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28536/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28536/comments | https://api.github.com/repos/huggingface/transformers/issues/28536/events | https://github.com/huggingface/transformers/issues/28536 | 2,084,363,783 | I_kwDOCUB6oc58PN4H | 28,536 | Gradient checkpointing throws use_reentrant warning on PyTorch 2.1 | {
"login": "rosario-purple",
"id": 123594463,
"node_id": "U_kgDOB13m3w",
"avatar_url": "https://avatars.githubusercontent.com/u/123594463?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rosario-purple",
"html_url": "https://github.com/rosario-purple",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"Thanks for raising! given that we had #27020, this should be fairly easy to fix! cc @younesbelkada ",
"@ArthurZucker is this still outstanding?",
"Will merge the PR today"
] | 1,705 | 1,708 | 1,708 | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.35
- Python version: 3.10.13
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.0
- Accelerate version: 0.25.0
- Accelerate config: - compute_environment: LOCAL_MACHINE
- distributed_type... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28536/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28536/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28535 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28535/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28535/comments | https://api.github.com/repos/huggingface/transformers/issues/28535/events | https://github.com/huggingface/transformers/pull/28535 | 2,084,210,365 | PR_kwDOCUB6oc5kNR55 | 28,535 | Allow add_tokens for ESM | {
"login": "Rocketknight1",
"id": 12866554,
"node_id": "MDQ6VXNlcjEyODY2NTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Rocketknight1",
"html_url": "https://github.com/Rocketknight1",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28535). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,705 | 1,705 | MEMBER | null | The tokenizer code for ESM forces all added tokens to be special tokens, presumably because the authors felt that the list of amino acids in proteins was constant and therefore that there wouldn't be a need to actually expand the core vocabulary. However, there are definitely use-cases for expanding the vocabulary - se... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28535/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28535/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28535",
"html_url": "https://github.com/huggingface/transformers/pull/28535",
"diff_url": "https://github.com/huggingface/transformers/pull/28535.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28535.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28534 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28534/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28534/comments | https://api.github.com/repos/huggingface/transformers/issues/28534/events | https://github.com/huggingface/transformers/issues/28534 | 2,084,136,856 | I_kwDOCUB6oc58OWeY | 28,534 | run_glue_no_trainer.py script crashes on Mistral model due to tokenizer issue | {
"login": "rosario-purple",
"id": 123594463,
"node_id": "U_kgDOB13m3w",
"avatar_url": "https://avatars.githubusercontent.com/u/123594463?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rosario-purple",
"html_url": "https://github.com/rosario-purple",
"followers_url": "https://api.github.c... | [
{
"id": 2392046359,
"node_id": "MDU6TGFiZWwyMzkyMDQ2MzU5",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20Second%20Issue",
"name": "Good Second Issue",
"color": "dd935a",
"default": false,
"description": "Issues that are more difficult to do than \"Good First... | open | false | null | [] | [
"Adding these lines seems to fix it, not sure if this is the best/most general solution though:\r\n\r\n```\r\n tokenizer = AutoTokenizer.from_pretrained(\r\n args.model_name_or_path, use_fast=not args.use_slow_tokenizer, trust_remote_code=args.trust_remote_code\r\n )\r\n tokenizer.pad_token = tokeni... | 1,705 | 1,708 | null | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-5.15.0-91-generic-x86_64-with-glibc2.35
- Python version: 3.10.13
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.0
- Accelerate version: 0.25.0
- Accelerate config: - compute_environment: LOCAL_MACHINE
- distributed_ty... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28534/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28534/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28533 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28533/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28533/comments | https://api.github.com/repos/huggingface/transformers/issues/28533/events | https://github.com/huggingface/transformers/pull/28533 | 2,083,951,133 | PR_kwDOCUB6oc5kMYb8 | 28,533 | Fix attention mask creation for GPTNeo | {
"login": "michaelbenayoun",
"id": 25418079,
"node_id": "MDQ6VXNlcjI1NDE4MDc5",
"avatar_url": "https://avatars.githubusercontent.com/u/25418079?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/michaelbenayoun",
"html_url": "https://github.com/michaelbenayoun",
"followers_url": "https://api... | [] | open | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28533). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,706 | null | MEMBER | null | # What does this PR do?
It seems that #26486 broke the way the attention mask was created. It creates a causal attention mask by default, but there is already a causal attention mask in the `GPTNeoSelfAttention` modules, resulting in `NaN`s.
I am not sure the solution is perfect, so opened to suggestions. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28533/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28533/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28533",
"html_url": "https://github.com/huggingface/transformers/pull/28533",
"diff_url": "https://github.com/huggingface/transformers/pull/28533.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28533.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28532 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28532/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28532/comments | https://api.github.com/repos/huggingface/transformers/issues/28532/events | https://github.com/huggingface/transformers/issues/28532 | 2,083,781,693 | I_kwDOCUB6oc58M_w9 | 28,532 | Inconsistent check for is_accelerate_available() in transformers.training_args | {
"login": "faph",
"id": 8397805,
"node_id": "MDQ6VXNlcjgzOTc4MDU=",
"avatar_url": "https://avatars.githubusercontent.com/u/8397805?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/faph",
"html_url": "https://github.com/faph",
"followers_url": "https://api.github.com/users/faph/followers",
... | [] | closed | false | null | [] | [
"I think this is already fixed here: https://github.com/huggingface/transformers/blob/002566f398cd6dbf7053a89c26646ac45be540f4/src/transformers/training_args.py#L1830",
"Hi @faph, thanks for raising this issue! \r\n\r\nYes, as you identified, a fix was added with #28171 which will be part of the next release. ",
... | 1,705 | 1,705 | 1,705 | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-4.18.0-477.21.1.el8_8.x86_64-x86_64-with-glibc2.28
- Python version: 3.11.2
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.4.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1+cu117... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28532/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28532/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28531 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28531/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28531/comments | https://api.github.com/repos/huggingface/transformers/issues/28531/events | https://github.com/huggingface/transformers/issues/28531 | 2,083,735,951 | I_kwDOCUB6oc58M0mP | 28,531 | A named Peft Model doesn't work with resume_from_checkpoint=True | {
"login": "chenbin11200",
"id": 5245644,
"node_id": "MDQ6VXNlcjUyNDU2NDQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/5245644?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/chenbin11200",
"html_url": "https://github.com/chenbin11200",
"followers_url": "https://api.github.com... | [] | open | false | null | [] | [
"A PR is attached, if it is necessary: https://github.com/huggingface/transformers/pull/28547",
"Also cc @younesbelkada for PEFT",
"Thanks @amyeroberts @chenbin11200 - the PR makes sense to me ! I left a single comment ",
"This issue has been automatically marked as stale because it has not had recent activit... | 1,705 | 1,708 | null | NONE | null | ### System Info
transformers==4.36.2
peft==0.5.0
### Who can help?
_No response_
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X] My own task or dataset (give details below)
#... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28531/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28531/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28530 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28530/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28530/comments | https://api.github.com/repos/huggingface/transformers/issues/28530/events | https://github.com/huggingface/transformers/issues/28530 | 2,083,730,860 | I_kwDOCUB6oc58MzWs | 28,530 | Early stopping required metric_for_best_model, but did not find eval_f1 so early stopping is disabled | {
"login": "ManishChandra12",
"id": 17062142,
"node_id": "MDQ6VXNlcjE3MDYyMTQy",
"avatar_url": "https://avatars.githubusercontent.com/u/17062142?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ManishChandra12",
"html_url": "https://github.com/ManishChandra12",
"followers_url": "https://api... | [] | open | false | null | [] | [
"Hi @ManishChandra12, thanks for raising an issue! \r\n\r\nIn the provided snippet, you don't appear to be passing `compute_metrics` to the `Trainer` class, as required. ",
"Hi @amyeroberts. Thanks for the quick response.\r\n\r\nThe error persists even when I pass ```compute_metrics``` to ```Trainer```.\r\n\r\nPS... | 1,705 | 1,708 | null | NONE | null | ### System Info
- `transformers` version: 4.35.2
- Platform: Linux-3.10.0-1160.49.1.el7.x86_64-x86_64-with-glibc2.17
- Python version: 3.8.18
- Huggingface_hub version: 0.19.4
- Safetensors version: 0.4.1
- Accelerate version: 0.25.0
- Accelerate config: not found
- PyTorch version (GPU?): 1.13.1+cu116 (Tr... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28530/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28530/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28529 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28529/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28529/comments | https://api.github.com/repos/huggingface/transformers/issues/28529/events | https://github.com/huggingface/transformers/issues/28529 | 2,083,589,686 | I_kwDOCUB6oc58MQ42 | 28,529 | Error while fetching adapter layer from huggingface library | {
"login": "Muskanb",
"id": 35324348,
"node_id": "MDQ6VXNlcjM1MzI0MzQ4",
"avatar_url": "https://avatars.githubusercontent.com/u/35324348?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Muskanb",
"html_url": "https://github.com/Muskanb",
"followers_url": "https://api.github.com/users/Muskan... | [] | closed | false | null | [] | [
"Hi @Muskanb, thanks for raising an issue! \r\n\r\nIs the error occurring when calling `LlamaForCausalLM.from_pretrained` or `pa_extractor.load_adapter`? ",
"Hey @amyeroberts, Thanks for responding. It occurs while calling ` pa_extractor.load_adapter`",
"hi @Muskanb what are your transformers & peft versions? "... | 1,705 | 1,708 | 1,708 | NONE | null | ### System Info
```
pa_extractor = LlamaForCausalLM.from_pretrained(LLAMA_MODEL_NAME,
token=HF_ACCESS_TOKEN,
max_length=LLAMA2_MAX_LENGTH,
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28529/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28529/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28528 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28528/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28528/comments | https://api.github.com/repos/huggingface/transformers/issues/28528/events | https://github.com/huggingface/transformers/issues/28528 | 2,083,582,439 | I_kwDOCUB6oc58MPHn | 28,528 | The generation speed on NPU is too slow | {
"login": "hhllxx1121",
"id": 96508996,
"node_id": "U_kgDOBcCcRA",
"avatar_url": "https://avatars.githubusercontent.com/u/96508996?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hhllxx1121",
"html_url": "https://github.com/hhllxx1121",
"followers_url": "https://api.github.com/users/hhllx... | [] | open | false | null | [] | [
"cc @gante ",
"Hi @hhllxx1121 👋 \r\n\r\nSee this issue and its comments: https://github.com/huggingface/transformers/issues/28075",
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease n... | 1,705 | 1,708 | null | NONE | null | The generation speed on NPU device is too slow，The first conversation takes about 5 minutes, and it may be faster next. May I ask if there is any error? Below is my code demo
```python
import torch
import torch_npu
from transformers import LlamaForCausalLM, LlamaTokenizer, TextStreamer
tokenizer = LlamaTok... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28528/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28528/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28527 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28527/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28527/comments | https://api.github.com/repos/huggingface/transformers/issues/28527/events | https://github.com/huggingface/transformers/pull/28527 | 2,083,559,986 | PR_kwDOCUB6oc5kLAk3 | 28,527 | [`TokenizationRoformerFast`] Fix the save and loading | {
"login": "ArthurZucker",
"id": 48595927,
"node_id": "MDQ6VXNlcjQ4NTk1OTI3",
"avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ArthurZucker",
"html_url": "https://github.com/ArthurZucker",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
Fixes #28164, the pre tokenizer state was not correctly set after saving a fast tokenizer only. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28527/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28527/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28527",
"html_url": "https://github.com/huggingface/transformers/pull/28527",
"diff_url": "https://github.com/huggingface/transformers/pull/28527.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28527.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28526 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28526/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28526/comments | https://api.github.com/repos/huggingface/transformers/issues/28526/events | https://github.com/huggingface/transformers/pull/28526 | 2,083,550,366 | PR_kwDOCUB6oc5kK-cX | 28,526 | Fix labels encoding in RobertaForSequenceClassification when problem_type="multi_label_classification" | {
"login": "DamienAllonsius",
"id": 11852475,
"node_id": "MDQ6VXNlcjExODUyNDc1",
"avatar_url": "https://avatars.githubusercontent.com/u/11852475?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/DamienAllonsius",
"html_url": "https://github.com/DamienAllonsius",
"followers_url": "https://api... | [] | closed | false | null | [] | [
"@amyeroberts thanks a lot for your answer, I'll close this PR then. \r\n\r\nFor the record, I have actually tried to pass one hot labels: \r\n```\r\ndef one_hot_label(batch):\r\n batch[\"label\"] = [torch.functional.F.one_hot(torch.tensor(label), num_classes=18).double() for label in batch[\"label\"]]\r... | 1,705 | 1,705 | 1,705 | NONE | null |
# What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28526/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28526/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28526",
"html_url": "https://github.com/huggingface/transformers/pull/28526",
"diff_url": "https://github.com/huggingface/transformers/pull/28526.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28526.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28525 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28525/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28525/comments | https://api.github.com/repos/huggingface/transformers/issues/28525/events | https://github.com/huggingface/transformers/issues/28525 | 2,083,493,702 | I_kwDOCUB6oc58L5dG | 28,525 | [Whisper] TFWhisperFromPretrained : Can we run transcription by using the call method instead of generate from the transformers class | {
"login": "monowaranjum",
"id": 19803082,
"node_id": "MDQ6VXNlcjE5ODAzMDgy",
"avatar_url": "https://avatars.githubusercontent.com/u/19803082?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/monowaranjum",
"html_url": "https://github.com/monowaranjum",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"Hi @monowaranjum, thanks for raising an issue! \r\n\r\nThe supported way to save and load models is using the `model.save_pretrained(checkpoint)` and `ModelClass.from_pretrained(checkpoint)` methods. Is there a reason you're using the keras methods instead? ",
"Hi @monowaranjum, just to expand on @amyeroberts's ... | 1,705 | 1,705 | 1,705 | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-6.5.0-14-generic-x86_64-with-glibc2.35
- Python version: 3.11.7
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.3.3
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2+cu121 (False)
- Te... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28525/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28525/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28524 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28524/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28524/comments | https://api.github.com/repos/huggingface/transformers/issues/28524/events | https://github.com/huggingface/transformers/issues/28524 | 2,083,465,489 | I_kwDOCUB6oc58LykR | 28,524 | Exception in inference when using the pipeline with output_scores=True to get logits | {
"login": "andersonm-ibm",
"id": 63074550,
"node_id": "MDQ6VXNlcjYzMDc0NTUw",
"avatar_url": "https://avatars.githubusercontent.com/u/63074550?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andersonm-ibm",
"html_url": "https://github.com/andersonm-ibm",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"@amyeroberts For reference.\r\n\r\nThis is totally OK, pipelines are not supposed to support every option models do. Use the example code if you want more control over the generation.\r\n\r\nClosing for now since this is normal behavior."
] | 1,705 | 1,705 | 1,705 | NONE | null | ### System Info
- `transformers` version: 4.29.1
- Python version: 3.10.13
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 2.0.0+cu117 (True)
### Who can help?
@Narsil
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28524/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28524/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28523 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28523/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28523/comments | https://api.github.com/repos/huggingface/transformers/issues/28523/events | https://github.com/huggingface/transformers/issues/28523 | 2,083,462,217 | I_kwDOCUB6oc58LxxJ | 28,523 | Huggingface Agents Error 422: {'error': 'Input validation error: `max_new_tokens` must be <= 192 | {
"login": "dashapetr",
"id": 54349415,
"node_id": "MDQ6VXNlcjU0MzQ5NDE1",
"avatar_url": "https://avatars.githubusercontent.com/u/54349415?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dashapetr",
"html_url": "https://github.com/dashapetr",
"followers_url": "https://api.github.com/users/... | [] | open | false | null | [] | [
"Hey! Thanks, you are probably right. Would you like to open a PR to change this and make it more friendly? "
] | 1,705 | 1,708 | null | NONE | null | ### System Info
Transformers v4.29.0, v4.36.2
### Who can help?
@ArthurZucker, @younesbelkada
### Information
- [X] The official example scripts
- [X] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28523/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28523/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28522 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28522/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28522/comments | https://api.github.com/repos/huggingface/transformers/issues/28522/events | https://github.com/huggingface/transformers/pull/28522 | 2,083,404,188 | PR_kwDOCUB6oc5kKdzb | 28,522 | [`SpeechT5Tokenization`] Add copied from and fix the `convert_tokens_to_string` to match the fast decoding scheme | {
"login": "ArthurZucker",
"id": 48595927,
"node_id": "MDQ6VXNlcjQ4NTk1OTI3",
"avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ArthurZucker",
"html_url": "https://github.com/ArthurZucker",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28522). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
Fixes #26547 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28522/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28522/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28522",
"html_url": "https://github.com/huggingface/transformers/pull/28522",
"diff_url": "https://github.com/huggingface/transformers/pull/28522.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28522.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28521 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28521/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28521/comments | https://api.github.com/repos/huggingface/transformers/issues/28521/events | https://github.com/huggingface/transformers/pull/28521 | 2,083,219,859 | PR_kwDOCUB6oc5kJ0te | 28,521 | Add is_model_supported for fx | {
"login": "inisis",
"id": 46103969,
"node_id": "MDQ6VXNlcjQ2MTAzOTY5",
"avatar_url": "https://avatars.githubusercontent.com/u/46103969?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/inisis",
"html_url": "https://github.com/inisis",
"followers_url": "https://api.github.com/users/inisis/fo... | [] | closed | false | null | [] | [
"> Hi @inisis, thanks for opening this PR!\r\n> \r\n> A word of caution - functions like these (not importable from the top-level of transformers, not part of the public documentation) are subject to change and not guaranteed to never be renamed, have modified behaviour or deleted. In fact - this PR does just that!... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28521/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28521/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28521",
"html_url": "https://github.com/huggingface/transformers/pull/28521",
"diff_url": "https://github.com/huggingface/transformers/pull/28521.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28521.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28520 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28520/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28520/comments | https://api.github.com/repos/huggingface/transformers/issues/28520/events | https://github.com/huggingface/transformers/pull/28520 | 2,083,197,751 | PR_kwDOCUB6oc5kJvxu | 28,520 | [ `TokenizationUtils`] Fix `add_special_tokens` when the token is already there | {
"login": "ArthurZucker",
"id": 48595927,
"node_id": "MDQ6VXNlcjQ4NTk1OTI3",
"avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ArthurZucker",
"html_url": "https://github.com/ArthurZucker",
"followers_url": "https://api.github.c... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
Fixes #27888 : the method was missing a check that was overwriting the special token list. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28520/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28520/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28520",
"html_url": "https://github.com/huggingface/transformers/pull/28520",
"diff_url": "https://github.com/huggingface/transformers/pull/28520.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28520.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28519 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28519/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28519/comments | https://api.github.com/repos/huggingface/transformers/issues/28519/events | https://github.com/huggingface/transformers/issues/28519 | 2,083,084,349 | I_kwDOCUB6oc58KVg9 | 28,519 | AttributeError: module 'transformers_modules.Qwen-72B-Chat.tokenization_qwen' has no attribute 'QWenTokenizer' | {
"login": "pydaxing",
"id": 129026999,
"node_id": "U_kgDOB7DLtw",
"avatar_url": "https://avatars.githubusercontent.com/u/129026999?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/pydaxing",
"html_url": "https://github.com/pydaxing",
"followers_url": "https://api.github.com/users/pydaxing/... | [] | open | false | null | [] | [
"Hi @pydaxing, thanks for raising an issue! \r\n\r\nSo that we can best help you, could you make sure to follow the issue template and provide: \r\n* The running environment: run `transformers-cli env` in the terminal and copy-paste the output\r\n* A minimal code reproducer\r\n* The full error traceback",
"This i... | 1,705 | 1,707 | null | NONE | null | ### System Info
AttributeError: module 'transformers_modules.Qwen-72B-Chat.tokenization_qwen' has no attribute 'QWenTokenizer'
### Who can help?
AttributeError: module 'transformers_modules.Qwen-72B-Chat.tokenization_qwen' has no attribute 'QWenTokenizer'
### Information
- [ ] The official example scripts
- [ ] My... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28519/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28519/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28518 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28518/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28518/comments | https://api.github.com/repos/huggingface/transformers/issues/28518/events | https://github.com/huggingface/transformers/issues/28518 | 2,082,976,347 | I_kwDOCUB6oc58J7Jb | 28,518 | KOSMOS-2 Entities giving null | {
"login": "andysingal",
"id": 20493493,
"node_id": "MDQ6VXNlcjIwNDkzNDkz",
"avatar_url": "https://avatars.githubusercontent.com/u/20493493?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/andysingal",
"html_url": "https://github.com/andysingal",
"followers_url": "https://api.github.com/use... | [] | open | false | null | [] | [
"Hi @andysingal. To use Kosmos-2 for image grounding, you have to add a special `<grounding>` token before the prompt, as they do in the [paper](https://arxiv.org/abs/2306.14824). Also you can use `<phrase>` token to get bboxes of specific phrases in the format `prev_prompt_text <phrase>the_object</phrase>`\r\n\r\n... | 1,705 | 1,707 | null | NONE | null | ### System Info
google colab, T4
```
!pip install -q git+https://github.com/huggingface/transformers.git accelerate bitsandbytes
```
### Who can help?
@amy
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (su... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28518/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28518/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28517 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28517/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28517/comments | https://api.github.com/repos/huggingface/transformers/issues/28517/events | https://github.com/huggingface/transformers/pull/28517 | 2,082,922,067 | PR_kwDOCUB6oc5kI1nz | 28,517 | Exclude the load balancing loss of padding tokens in Mixtral-8x7B | {
"login": "khaimt",
"id": 145790391,
"node_id": "U_kgDOCLCVtw",
"avatar_url": "https://avatars.githubusercontent.com/u/145790391?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khaimt",
"html_url": "https://github.com/khaimt",
"followers_url": "https://api.github.com/users/khaimt/follower... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28517). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"> Thanks for the update. Can you add a good test to make sure this behaves as expe... | 1,705 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
This PR implements excluding the load balancing loss of padding tokens in Mixtral-8x7B
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28517/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28517/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28517",
"html_url": "https://github.com/huggingface/transformers/pull/28517",
"diff_url": "https://github.com/huggingface/transformers/pull/28517.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28517.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28516 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28516/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28516/comments | https://api.github.com/repos/huggingface/transformers/issues/28516/events | https://github.com/huggingface/transformers/issues/28516 | 2,082,719,913 | I_kwDOCUB6oc58I8ip | 28,516 | EarlyStoppingCallback Not Working with Accelerate | {
"login": "superleesa",
"id": 88019950,
"node_id": "MDQ6VXNlcjg4MDE5OTUw",
"avatar_url": "https://avatars.githubusercontent.com/u/88019950?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/superleesa",
"html_url": "https://github.com/superleesa",
"followers_url": "https://api.github.com/use... | [] | open | false | null | [] | [
"Actually, the problem occurred even after removing the EarlyStoppingCallback..... ",
"cc @muellerzr @pacman100 ",
"The weirdest part is that the error always occurs at a training step between 229~235. I was thinking that this is due to a deadlock caused by evaluation / saving but even if I set the the evaluati... | 1,705 | 1,707 | null | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-5.15.0-1042-gcp-x86_64-with-glibc2.38
- Python version: 3.11.7
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.4.1
- Accelerate version: 0.25.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2+cu121 (True)
- Tensorfl... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28516/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28516/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28515 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28515/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28515/comments | https://api.github.com/repos/huggingface/transformers/issues/28515/events | https://github.com/huggingface/transformers/issues/28515 | 2,082,611,854 | I_kwDOCUB6oc58IiKO | 28,515 | AttributeError: 'LlamaForCausalLM' object has no attribute 'merge_and_unload' | {
"login": "tshrjn",
"id": 8372098,
"node_id": "MDQ6VXNlcjgzNzIwOTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/8372098?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tshrjn",
"html_url": "https://github.com/tshrjn",
"followers_url": "https://api.github.com/users/tshrjn/foll... | [] | open | false | null | [] | [
"Hi @tshrjn, thanks for raising an issue! \r\n\r\nIt looks like this is an issue on how the transformers model is wrapped on unsloth's side. Our model's don't natively have a `merge_and_upload` method. ",
"@amyeroberts Thanks for taking a look. \n\nThis might be a PEFT library issue. The docs for which states the... | 1,705 | 1,707 | null | NONE | null | ### System Info
- `transformers` version: 4.37.0.dev0
- Platform: Linux-5.4.0-155-generic-x86_64-with-glibc2.31
- Python version: 3.10.12
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.4.1
- Accelerate version: 0.26.1
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0+cu121 (True)
- ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28515/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28515/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28514 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28514/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28514/comments | https://api.github.com/repos/huggingface/transformers/issues/28514/events | https://github.com/huggingface/transformers/pull/28514 | 2,082,547,057 | PR_kwDOCUB6oc5kHlXS | 28,514 | Config: warning when saving generation kwargs in the model config | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28514). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"@amyeroberts PR comments addressed!\r\n\r\n@amyeroberts @ArthurZucker What do you ... | 1,705 | 1,705 | 1,705 | MEMBER | null | # What does this PR do?
## Context
`generate` is ideally controlled by a `GenerationConfig`. However, to remain retrocompatible, a `PretrainedConfig` may control `generate` in the following conditions:
1. `generate` does not receive a `generation_config` argument; AND
2. `model.generation_config._from_model_con... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28514/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28514/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28514",
"html_url": "https://github.com/huggingface/transformers/pull/28514",
"diff_url": "https://github.com/huggingface/transformers/pull/28514.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28514.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28513 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28513/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28513/comments | https://api.github.com/repos/huggingface/transformers/issues/28513/events | https://github.com/huggingface/transformers/pull/28513 | 2,082,412,751 | PR_kwDOCUB6oc5kHIwg | 28,513 | Exclude the load balancing loss of padding tokens in Mixtral-8x7B | {
"login": "khaimt",
"id": 145790391,
"node_id": "U_kgDOCLCVtw",
"avatar_url": "https://avatars.githubusercontent.com/u/145790391?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khaimt",
"html_url": "https://github.com/khaimt",
"followers_url": "https://api.github.com/users/khaimt/follower... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null |
# What does this PR do?
This PR implements excluding the load balancing loss of padding tokens in Mixtral-8x7B
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28513/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28513/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28513",
"html_url": "https://github.com/huggingface/transformers/pull/28513",
"diff_url": "https://github.com/huggingface/transformers/pull/28513.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28513.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28512 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28512/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28512/comments | https://api.github.com/repos/huggingface/transformers/issues/28512/events | https://github.com/huggingface/transformers/issues/28512 | 2,082,400,458 | I_kwDOCUB6oc58HujK | 28,512 | AMP autocast not invoked with CUDA 11.8 build of Pytorch | {
"login": "haixpham",
"id": 32718796,
"node_id": "MDQ6VXNlcjMyNzE4Nzk2",
"avatar_url": "https://avatars.githubusercontent.com/u/32718796?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/haixpham",
"html_url": "https://github.com/haixpham",
"followers_url": "https://api.github.com/users/hai... | [] | open | false | null | [] | [
"cc @pacman100 @muellerzr "
] | 1,705 | 1,708 | null | NONE | null | ### System Info
pytorch 2.1 + CUDA 11.8
transformers 4.36.2
accelerate 0.26.0
### Who can help?
@pacman100 , @muellerz
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28512/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28512/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28511 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28511/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28511/comments | https://api.github.com/repos/huggingface/transformers/issues/28511/events | https://github.com/huggingface/transformers/pull/28511 | 2,082,340,540 | PR_kwDOCUB6oc5kG5aK | 28,511 | Add a use_safetensors arg to TFPreTrainedModel.from_pretrained() | {
"login": "Rocketknight1",
"id": 12866554,
"node_id": "MDQ6VXNlcjEyODY2NTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Rocketknight1",
"html_url": "https://github.com/Rocketknight1",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28511). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,705 | 1,705 | MEMBER | null | PyTorch's `from_pretrained()` method has a `use_safetensors` argument. Our TF code doesn't, and just always tries safetensors if available. This PR adds the argument to match the PyTorch API. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28511/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28511/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28511",
"html_url": "https://github.com/huggingface/transformers/pull/28511",
"diff_url": "https://github.com/huggingface/transformers/pull/28511.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28511.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28510 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28510/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28510/comments | https://api.github.com/repos/huggingface/transformers/issues/28510/events | https://github.com/huggingface/transformers/issues/28510 | 2,082,098,659 | I_kwDOCUB6oc58Gk3j | 28,510 | With deepspeed zero3 enabled, loading from_pretrained() and resize_token_embeddings() do not work correctly | {
"login": "haixpham",
"id": 32718796,
"node_id": "MDQ6VXNlcjMyNzE4Nzk2",
"avatar_url": "https://avatars.githubusercontent.com/u/32718796?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/haixpham",
"html_url": "https://github.com/haixpham",
"followers_url": "https://api.github.com/users/hai... | [] | open | false | null | [] | [
"Not sure if this helps, but I'm also having trouble reproducing accuracy of CodeLlama 13B-I trained with Zero2 using Zero3. ",
"Meet the same problem when using [this snippet](https://github.com/huggingface/accelerate/blob/cea6aaa1161d45f7f23ef33fcc3b0a5999ebb5a1/examples/by_feature/deepspeed_with_config_support... | 1,705 | 1,707 | null | NONE | null | ### System Info
torch 2.1.1 - CUDA 12.1
transformers 4.36.2
accelerate 0.26.0
deepspeed 0.12.3
### Who can help?
@pacman100
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28510/reactions",
"total_count": 3,
"+1": 3,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28510/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28509 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28509/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28509/comments | https://api.github.com/repos/huggingface/transformers/issues/28509/events | https://github.com/huggingface/transformers/pull/28509 | 2,081,998,273 | PR_kwDOCUB6oc5kFvWH | 28,509 | SiLU activation wrapper for safe importing | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"@ydshieh The same capturelogger errors arose again. A cheeky re-run (with ssh) made them pass, so merging as they're not related to this PR"
] | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
The custom implementation of `SiLUActivation` was removed in #27136. This causes two issues:
1. Users unable to unpickle objects - c.f. #28177
2. Users unable to import the class - c.f. #28496
For 1. - the unpickling of modified transformers models through torch.load isn't something... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28509/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28509/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28509",
"html_url": "https://github.com/huggingface/transformers/pull/28509",
"diff_url": "https://github.com/huggingface/transformers/pull/28509.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28509.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28508 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28508/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28508/comments | https://api.github.com/repos/huggingface/transformers/issues/28508/events | https://github.com/huggingface/transformers/pull/28508 | 2,081,991,253 | PR_kwDOCUB6oc5kFtya | 28,508 | Fix `_speculative_sampling` implementation | {
"login": "ofirzaf",
"id": 18296312,
"node_id": "MDQ6VXNlcjE4Mjk2MzEy",
"avatar_url": "https://avatars.githubusercontent.com/u/18296312?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ofirzaf",
"html_url": "https://github.com/ofirzaf",
"followers_url": "https://api.github.com/users/ofirza... | [] | closed | false | null | [] | [
"I was thinking about changing `max_new_tokens` inside the `get_candidates` method so we won't generate more tokens than `max_length - 1`:\r\n```python\r\nmax_new_tokens = min(int(self.num_assistant_tokens), self.generation_config.max_length - new_cur_len - 1)\r\n```\r\nThis will help avoid checking in several plac... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28508/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28508/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28508",
"html_url": "https://github.com/huggingface/transformers/pull/28508",
"diff_url": "https://github.com/huggingface/transformers/pull/28508.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28508.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28507 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28507/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28507/comments | https://api.github.com/repos/huggingface/transformers/issues/28507/events | https://github.com/huggingface/transformers/pull/28507 | 2,081,721,163 | PR_kwDOCUB6oc5kEzd5 | 28,507 | Correct model_type in PretrainedConfig's to_dict | {
"login": "fxmarty",
"id": 9808326,
"node_id": "MDQ6VXNlcjk4MDgzMjY=",
"avatar_url": "https://avatars.githubusercontent.com/u/9808326?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fxmarty",
"html_url": "https://github.com/fxmarty",
"followers_url": "https://api.github.com/users/fxmarty/... | [] | closed | false | null | [] | [
"Thanks for opening this PR @fxmarty! \r\n\r\nThe reason this happens at the moment is that `model_type` is intended to be a class attribute, not an instance attribute i.e. to be consistent and shared for all instances of the config object and not modified instance to instance. What's the motivation for modifying i... | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | As per title, now
```python
from transformers import AutoConfig, PretrainedConfig
cfg = AutoConfig.from_pretrained("bert-base-uncased")
config = PretrainedConfig.from_dict(cfg.to_dict())
config.model_type = "my-model"
print(config.to_dict()["model_type"])
```
rightfully yields `my-model`, while it use t... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28507/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28507/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28507",
"html_url": "https://github.com/huggingface/transformers/pull/28507",
"diff_url": "https://github.com/huggingface/transformers/pull/28507.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28507.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28506 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28506/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28506/comments | https://api.github.com/repos/huggingface/transformers/issues/28506/events | https://github.com/huggingface/transformers/pull/28506 | 2,081,718,248 | PR_kwDOCUB6oc5kEy0M | 28,506 | Use `weights_only` only if torch >= 1.13 | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28506). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"failing tests are known flaky"
] | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
Fix https://github.com/huggingface/transformers/pull/27282#issuecomment-1887859328
cc @julien-c | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28506/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28506/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28506",
"html_url": "https://github.com/huggingface/transformers/pull/28506",
"diff_url": "https://github.com/huggingface/transformers/pull/28506.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28506.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28505 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28505/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28505/comments | https://api.github.com/repos/huggingface/transformers/issues/28505/events | https://github.com/huggingface/transformers/issues/28505 | 2,081,624,681 | I_kwDOCUB6oc58ExJp | 28,505 | Exclude the load balancing loss of padding tokens in Mixtral-8x7B | {
"login": "khaimt",
"id": 145790391,
"node_id": "U_kgDOCLCVtw",
"avatar_url": "https://avatars.githubusercontent.com/u/145790391?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/khaimt",
"html_url": "https://github.com/khaimt",
"followers_url": "https://api.github.com/users/khaimt/follower... | [
{
"id": 2392046359,
"node_id": "MDU6TGFiZWwyMzkyMDQ2MzU5",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20Second%20Issue",
"name": "Good Second Issue",
"color": "dd935a",
"default": false,
"description": "Issues that are more difficult to do than \"Good First... | closed | false | null | [] | [
"cc @ArthurZucker ",
"feel free to open a PR for this! Otherwise will mark it as a good second issue 🤗 ",
"I would like to work on this issue, i will go through the linked file today and ask any questions i have.",
"I was looking at the code.\r\nBelow is what the model outputs\r\n`return MoeModelOutputWithPa... | 1,705 | 1,706 | 1,706 | CONTRIBUTOR | null | ### Feature request
The auxiliary loss in Mixtral-MoE shouldn't **include the loss from padding tokens**.
### Motivation
I think it is better to change the function
[load_balancing_loss_func](https://github.com/huggingface/transformers/blob/main/src/transformers/models/mixtral/modeling_mixtral.py#L77) by adding a... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28505/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 1,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28505/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28504 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28504/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28504/comments | https://api.github.com/repos/huggingface/transformers/issues/28504/events | https://github.com/huggingface/transformers/pull/28504 | 2,081,337,584 | PR_kwDOCUB6oc5kDgar | 28,504 | Allow to train dinov2 with different dtypes like bf16 | {
"login": "StarCycle",
"id": 33491471,
"node_id": "MDQ6VXNlcjMzNDkxNDcx",
"avatar_url": "https://avatars.githubusercontent.com/u/33491471?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/StarCycle",
"html_url": "https://github.com/StarCycle",
"followers_url": "https://api.github.com/users/... | [] | closed | false | null | [] | [
"Hi @StarCycle, thanks for this contribution! \r\n\r\nCould you share a small code snippet to show how you're training the model in the PR description and the error? This helps us for anyone coming back to this PR in the future.",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transfor... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | I want to train dinov2 with bf16 but I get the following error in https://github.com/huggingface/transformers/blob/bc72b4e2cdcbc80d5f56731f35dbc9c18b4c8de6/src/transformers/models/dinov2/modeling_dinov2.py#L635:
```
RuntimeError: Input type (float) and bias type (c10::BFloat16) should be the same
```
Since the ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28504/reactions",
"total_count": 6,
"+1": 3,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 3,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28504/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28504",
"html_url": "https://github.com/huggingface/transformers/pull/28504",
"diff_url": "https://github.com/huggingface/transformers/pull/28504.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28504.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28503 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28503/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28503/comments | https://api.github.com/repos/huggingface/transformers/issues/28503/events | https://github.com/huggingface/transformers/pull/28503 | 2,081,147,575 | PR_kwDOCUB6oc5kC3Xh | 28,503 | Add sudachi_projection option to BertJapaneseTokenizer | {
"login": "hiroshi-matsuda-rit",
"id": 40782025,
"node_id": "MDQ6VXNlcjQwNzgyMDI1",
"avatar_url": "https://avatars.githubusercontent.com/u/40782025?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hiroshi-matsuda-rit",
"html_url": "https://github.com/hiroshi-matsuda-rit",
"followers_url": ... | [] | closed | false | null | [] | [
"Example model for sudachi_projection option:\r\nhttps://huggingface.co/hiroshi-matsuda-rit/bert-base-sudachitra-v11/blob/main/tokenizer_config.json#L16",
"Nice 🔥 Feel free to ping me for a review! ",
"The errors which were raised from the test cases for jumanpp and mecab-unidic in local environment were not r... | 1,705 | 1,707 | 1,707 | CONTRIBUTOR | null | # What does this PR do?
A new feature of SudachiPy v0.6.8 allows normalization of words based on Japanese morphological analysis.
https://github.com/WorksApplications/sudachi.rs/issues/230
This morphology-based normalization functionality, named "projection" in SudachiPy, makes Japanese sub-tokenization more e... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28503/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28503/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28503",
"html_url": "https://github.com/huggingface/transformers/pull/28503",
"diff_url": "https://github.com/huggingface/transformers/pull/28503.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28503.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28502 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28502/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28502/comments | https://api.github.com/repos/huggingface/transformers/issues/28502/events | https://github.com/huggingface/transformers/issues/28502 | 2,081,119,761 | I_kwDOCUB6oc58C14R | 28,502 | Tokenizer should be serializable | {
"login": "hk6an6",
"id": 2327624,
"node_id": "MDQ6VXNlcjIzMjc2MjQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/2327624?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hk6an6",
"html_url": "https://github.com/hk6an6",
"followers_url": "https://api.github.com/users/hk6an6/foll... | [] | closed | false | null | [] | [
"It seems the problem goes away if I change from `paraphrase-distilroberta-base-v1` to `paraphrase-distilroberta-base-v2`. Could it be that the tokenizer_config for v1 is incompatible with json.dumps?",
"Hey! This seems to be related to `sentence-transfromers`, as tokenizers are serializable. \r\nCould you provid... | 1,705 | 1,705 | 1,705 | NONE | null | ### System Info
- transformers.__version__: '4.36.1'
- platform: macOS 14.2.1 (23C71)
- Python version: Python 3.11.6
### Who can help?
@ArthurZucker
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [x] An officially supported task in the `examples` folder (such as G... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28502/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28502/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28501 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28501/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28501/comments | https://api.github.com/repos/huggingface/transformers/issues/28501/events | https://github.com/huggingface/transformers/issues/28501 | 2,081,085,913 | I_kwDOCUB6oc58CtnZ | 28,501 | remote tokenizers trust remote code prompt doesn't not work as expected | {
"login": "mzbac",
"id": 7523197,
"node_id": "MDQ6VXNlcjc1MjMxOTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/7523197?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mzbac",
"html_url": "https://github.com/mzbac",
"followers_url": "https://api.github.com/users/mzbac/follower... | [] | closed | false | null | [] | [
"Hey, `AutoTokenizer.from_pretrained('Qwen/Qwen-1_8B', trust_remote_code = True)` should be used as this model is not natively supported",
"Otherwise, yes we should prompt the user for that cc @Rocketknight1 if you can have a look! ",
"> Hey, `AutoTokenizer.from_pretrained('Qwen/Qwen-1_8B', trust_remote_code = ... | 1,705 | 1,705 | 1,705 | NONE | null | ### System Info
transformers: 4.36.2
### Who can help?
@ArthurZucker
### Information
- [X] The official example scripts
- [X] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
### Reproducti... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28501/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28501/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28500 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28500/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28500/comments | https://api.github.com/repos/huggingface/transformers/issues/28500/events | https://github.com/huggingface/transformers/pull/28500 | 2,080,999,703 | PR_kwDOCUB6oc5kCWrW | 28,500 | Log a warning when best model is not loaded | {
"login": "akwako",
"id": 31602350,
"node_id": "MDQ6VXNlcjMxNjAyMzUw",
"avatar_url": "https://avatars.githubusercontent.com/u/31602350?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/akwako",
"html_url": "https://github.com/akwako",
"followers_url": "https://api.github.com/users/akwako/fo... | [] | open | false | null | [] | [
"Hi @amyeroberts, \r\n\r\nThank you for your reply and feedback!\r\n\r\nAs far as I can tell, the main issue is when `max_steps` < `args.save_steps`, and only when `save_strategy=\"steps\"`. Since `max_steps` is computed in the `_inner_training_loop`, I have added a check there to make sure training fails fast, as ... | 1,705 | 1,707 | null | NONE | null | Specifying "load_best_model_at_end=True" in TrainingArguments should ensure that the best model is always loaded at end of training. However, this is not always the case: When best_model_checkpoint is None, the best model is not loaded, and the user may be unaware of this behavior.
Add a warning to the log to let th... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28500/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28500/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28500",
"html_url": "https://github.com/huggingface/transformers/pull/28500",
"diff_url": "https://github.com/huggingface/transformers/pull/28500.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28500.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28499 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28499/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28499/comments | https://api.github.com/repos/huggingface/transformers/issues/28499/events | https://github.com/huggingface/transformers/issues/28499 | 2,080,927,400 | I_kwDOCUB6oc58CG6o | 28,499 | activation_checkpointing error when using --fsdp | {
"login": "getao",
"id": 12735658,
"node_id": "MDQ6VXNlcjEyNzM1NjU4",
"avatar_url": "https://avatars.githubusercontent.com/u/12735658?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/getao",
"html_url": "https://github.com/getao",
"followers_url": "https://api.github.com/users/getao/follow... | [] | open | false | null | [] | [
"Hi @getao, thanks for raising an issue! \r\n\r\nCould you provide a minimal reproducer for this error. Specifically the full CLI command used to launch the training job? \r\n\r\ncc @muellerzr @pacman100 ",
"Sure.\r\n\r\n```\r\ndef main():\r\n parser = transformers.HfArgumentParser((ModelArguments, DataArgumen... | 1,705 | 1,707 | null | NONE | null | ### System Info
transformers == 4.36.2
pytorch == 2.1.0
### Who can help?
When using deepspeed to enable activation checkpointing, everything goes well. However, when I switch to torchrun with the native pytorch fsdp integrated into the huggingface: https://huggingface.co/docs/transformers/main/main_classes/trainer... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28499/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28499/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28498 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28498/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28498/comments | https://api.github.com/repos/huggingface/transformers/issues/28498/events | https://github.com/huggingface/transformers/pull/28498 | 2,080,667,469 | PR_kwDOCUB6oc5kBSdl | 28,498 | add dataloader prefetch factor in training args and trainer | {
"login": "qmeeus",
"id": 25608944,
"node_id": "MDQ6VXNlcjI1NjA4OTQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/25608944?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/qmeeus",
"html_url": "https://github.com/qmeeus",
"followers_url": "https://api.github.com/users/qmeeus/fo... | [] | closed | false | null | [] | [
"cc @muellerzr ",
"Thanks for the suggestions @amyeroberts ! I included them in the PR and synced the branch to the latest commits\r\n\r\nHave a nice day\r\n"
] | 1,705 | 1,707 | 1,706 | CONTRIBUTOR | null | What does this PR do?
I added an option to the trainer to prefetch batches during data loading.
When training a model with heavy transformations and an iterable dataset, the dataloader might struggle to deliver fast enough for the GPU. I've found that prefetching batches helps to solve this issue.
The option is im... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28498/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28498/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28498",
"html_url": "https://github.com/huggingface/transformers/pull/28498",
"diff_url": "https://github.com/huggingface/transformers/pull/28498.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28498.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28497 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28497/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28497/comments | https://api.github.com/repos/huggingface/transformers/issues/28497/events | https://github.com/huggingface/transformers/pull/28497 | 2,080,667,462 | PR_kwDOCUB6oc5kBSdf | 28,497 | Improving Training Performance and Scalability Documentation | {
"login": "HamzaFB",
"id": 24733081,
"node_id": "MDQ6VXNlcjI0NzMzMDgx",
"avatar_url": "https://avatars.githubusercontent.com/u/24733081?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/HamzaFB",
"html_url": "https://github.com/HamzaFB",
"followers_url": "https://api.github.com/users/HamzaF... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28497). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Thanks!"
] | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | This PR improves the docs.
A strategy for improving Memory Performance for Large Models (Billions of parameters) is PEFT.
Actual documentation does not mention it.
This PR adds PEFT and provides an example as to why this reduces memory needs. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28497/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28497/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28497",
"html_url": "https://github.com/huggingface/transformers/pull/28497",
"diff_url": "https://github.com/huggingface/transformers/pull/28497.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28497.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28496 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28496/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28496/comments | https://api.github.com/repos/huggingface/transformers/issues/28496/events | https://github.com/huggingface/transformers/issues/28496 | 2,080,646,687 | I_kwDOCUB6oc58BCYf | 28,496 | No name 'SiLUActivation' in module 'transformers.activations' | {
"login": "qxpBlog",
"id": 96739096,
"node_id": "U_kgDOBcQfGA",
"avatar_url": "https://avatars.githubusercontent.com/u/96739096?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/qxpBlog",
"html_url": "https://github.com/qxpBlog",
"followers_url": "https://api.github.com/users/qxpBlog/follow... | [] | open | false | null | [] | [
"Hi @qxpBlog, thanks for raising this issue! \r\n\r\nCould you share a minimal code reproducer for this error and a full traceback of the error? ",
"@amyeroberts this question appear on the eighth line(i think that this version of transformers exclude the module):\r\nimport os\r\nimport sys\r\nimport argparse\r\n... | 1,705 | 1,707 | null | NONE | null | ### System Info
No name 'SiLUActivation' in module 'transformers.activations'
why i meet this problem , my version of transformers is 4.37.0.dev0
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28496/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28496/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28495 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28495/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28495/comments | https://api.github.com/repos/huggingface/transformers/issues/28495/events | https://github.com/huggingface/transformers/pull/28495 | 2,080,589,832 | PR_kwDOCUB6oc5kBDN2 | 28,495 | improve dev setup comments and hints | {
"login": "4imothy",
"id": 40186632,
"node_id": "MDQ6VXNlcjQwMTg2NjMy",
"avatar_url": "https://avatars.githubusercontent.com/u/40186632?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/4imothy",
"html_url": "https://github.com/4imothy",
"followers_url": "https://api.github.com/users/4imoth... | [] | closed | false | null | [] | [
"For the failing tests, you'll need to update the expected strings. "
] | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
Changes 'pip install -e .[dev]' -> \`pip install -e '.[dev]'\` in multiple comments and hints.
New command runs on both *zsh* and *bash*, previously it did not work on *zsh*.
## Before submitting
- [X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28495/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28495/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28495",
"html_url": "https://github.com/huggingface/transformers/pull/28495",
"diff_url": "https://github.com/huggingface/transformers/pull/28495.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28495.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28494 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28494/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28494/comments | https://api.github.com/repos/huggingface/transformers/issues/28494/events | https://github.com/huggingface/transformers/pull/28494 | 2,080,434,260 | PR_kwDOCUB6oc5kAlMw | 28,494 | Generate: consolidate output classes | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | MEMBER | null | # What does this PR do?
Does some cleanup that's been on my mind for a while 🧹
We had a bunch of classes that were a copy of each other, named after each internal generation method. This PR consolidates them. As a result, the documentation becomes more concise and with less risk of suffering from incomplete upda... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28494/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28494/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28494",
"html_url": "https://github.com/huggingface/transformers/pull/28494",
"diff_url": "https://github.com/huggingface/transformers/pull/28494.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28494.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28493 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28493/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28493/comments | https://api.github.com/repos/huggingface/transformers/issues/28493/events | https://github.com/huggingface/transformers/pull/28493 | 2,080,413,740 | PR_kwDOCUB6oc5kAhZ4 | 28,493 | Generate: fix candidate device placement | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | MEMBER | null | # What does this PR do?
#27775 was merged, and the branch was not synced with #27995 (already on `main`) -- the two branches together result in CI failures. Fortunately, the fix is simple :) | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28493/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28493/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28493",
"html_url": "https://github.com/huggingface/transformers/pull/28493",
"diff_url": "https://github.com/huggingface/transformers/pull/28493.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28493.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28492 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28492/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28492/comments | https://api.github.com/repos/huggingface/transformers/issues/28492/events | https://github.com/huggingface/transformers/pull/28492 | 2,080,118,727 | PR_kwDOCUB6oc5j_lMO | 28,492 | Fixing Issue #17488. Add changes to make the error thrown consistent in both decode and encode functions of Tokenizer | {
"login": "bayllama",
"id": 142558246,
"node_id": "U_kgDOCH9EJg",
"avatar_url": "https://avatars.githubusercontent.com/u/142558246?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/bayllama",
"html_url": "https://github.com/bayllama",
"followers_url": "https://api.github.com/users/bayllama/... | [] | closed | false | null | [] | [
"cc @ArthurZucker ",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28492). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,708 | 1,708 | CONTRIBUTOR | null | **Fixing Issue #17488. Add changes to make the error thrown consistent in both decode and encode functions of Tokenizer**
# What does this PR do?
This PR is with regards to fixing the issue to make both the encode and decode function return the same error when an unexpected argument is passed to the function. Below... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28492/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28492/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28492",
"html_url": "https://github.com/huggingface/transformers/pull/28492",
"diff_url": "https://github.com/huggingface/transformers/pull/28492.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28492.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28491 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28491/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28491/comments | https://api.github.com/repos/huggingface/transformers/issues/28491/events | https://github.com/huggingface/transformers/issues/28491 | 2,080,104,945 | I_kwDOCUB6oc57--Hx | 28,491 | Inconsistent in batch generation results | {
"login": "qlwang25",
"id": 38132016,
"node_id": "MDQ6VXNlcjM4MTMyMDE2",
"avatar_url": "https://avatars.githubusercontent.com/u/38132016?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/qlwang25",
"html_url": "https://github.com/qlwang25",
"followers_url": "https://api.github.com/users/qlw... | [] | closed | false | null | [] | [
"Hi @qlwang25 👋 \r\n\r\nHave a look at [this comment](https://github.com/huggingface/transformers/issues/25420#issuecomment-1775317535), which I believe answers your question :) ",
"Thank you very much for your reply. \r\nThe reason is ```torch type``` instead of ```padding```. Just changing it to ```torch.bfloa... | 1,705 | 1,705 | 1,705 | NONE | null | ### System Info
load model code
```
model_path = "../../../pre-trained_models/h2oai-llama2-7b-chat"
tokenizer = LlamaTokenizer.from_pretrained(model_path)
config = LlamaConfig.from_pretrained(model_path)
config.max_length = 512
with init_empty_weights():
model = LlamaForCausalLM._from_config(config, torch_... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28491/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28491/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28490 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28490/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28490/comments | https://api.github.com/repos/huggingface/transformers/issues/28490/events | https://github.com/huggingface/transformers/issues/28490 | 2,080,102,592 | I_kwDOCUB6oc57-9jA | 28,490 | [AutoGPTQ] The notebook tutorial of AutoGPTQ is not working. | {
"login": "DjangoPeng",
"id": 16943353,
"node_id": "MDQ6VXNlcjE2OTQzMzUz",
"avatar_url": "https://avatars.githubusercontent.com/u/16943353?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/DjangoPeng",
"html_url": "https://github.com/DjangoPeng",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"cc @SunMarc - let me know if you want me to have a look at this one",
"I had the similar issue too. It would be great if someone can take a look at this.\r\n\r\nThere is a builder error on \"allenai--c4\" when I use the following code snippet:\r\n\r\n```python\r\n\r\nraw_datasets = load_dataset(\r\n \"all... | 1,705 | 1,708 | 1,707 | NONE | null | ### System Info
System Info:
- `transformers` version: 4.37.0.dev0
- Platform: Linux-4.4.0-210-generic-x86_64-with-glibc2.23
- Python version: 3.11.5
- Huggingface_hub version: 0.20.1
- Safetensors version: 0.4.0
- Accelerate version: 0.26.1
- Accelerate config: not found
- PyTorch version (GPU): 2.1.2+cu... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28490/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28490/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28489 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28489/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28489/comments | https://api.github.com/repos/huggingface/transformers/issues/28489/events | https://github.com/huggingface/transformers/pull/28489 | 2,080,052,597 | PR_kwDOCUB6oc5j_WtM | 28,489 | Fixed minor typos | {
"login": "rishit5",
"id": 24509842,
"node_id": "MDQ6VXNlcjI0NTA5ODQy",
"avatar_url": "https://avatars.githubusercontent.com/u/24509842?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rishit5",
"html_url": "https://github.com/rishit5",
"followers_url": "https://api.github.com/users/rishit... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
Fixed typos in readme files.
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28489/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28489/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28489",
"html_url": "https://github.com/huggingface/transformers/pull/28489",
"diff_url": "https://github.com/huggingface/transformers/pull/28489.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28489.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28488 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28488/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28488/comments | https://api.github.com/repos/huggingface/transformers/issues/28488/events | https://github.com/huggingface/transformers/issues/28488 | 2,079,974,478 | I_kwDOCUB6oc57-eRO | 28,488 | fine tuning the updated Phi-2 with flash-attn-2 produces very high loss > 2 | {
"login": "abacaj",
"id": 7272343,
"node_id": "MDQ6VXNlcjcyNzIzNDM=",
"avatar_url": "https://avatars.githubusercontent.com/u/7272343?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/abacaj",
"html_url": "https://github.com/abacaj",
"followers_url": "https://api.github.com/users/abacaj/foll... | [] | open | false | null | [] | [
"I experienced the same thing! Over 3 epochs same set up just updated code and flash attention, the loss went from 6 to 2. And on the old code without flash attention it was .60 to ~.29 . Very strange.",
"cc @younesbelkada @ArthurZucker ",
"Hi @abacaj, as per @pacman100 guidelines in https://github.com/huggingf... | 1,705 | 1,708 | null | NONE | null | ### System Info
The updated code of phi-2 produces a high loss, I have tried fp16, bf16, deepspeed and fsdp the result is the same -> loss starts at 2 and keeps going higher. Setting `use_flash_attention_2=False` fixes this or using the old phi-2 modeling file.
torch==2.1.2
flash-attn==2.4.2
transformers==4.37.0.... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28488/reactions",
"total_count": 2,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/huggingface/transformers/issues/28488/timeline | reopened | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28487 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28487/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28487/comments | https://api.github.com/repos/huggingface/transformers/issues/28487/events | https://github.com/huggingface/transformers/issues/28487 | 2,079,721,297 | I_kwDOCUB6oc579gdR | 28,487 | add support for custom pipeline | {
"login": "not-lain",
"id": 70411813,
"node_id": "MDQ6VXNlcjcwNDExODEz",
"avatar_url": "https://avatars.githubusercontent.com/u/70411813?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/not-lain",
"html_url": "https://github.com/not-lain",
"followers_url": "https://api.github.com/users/not... | [
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request",
"name": "Feature request",
"color": "FBCA04",
"default": false,
"description": "Request for a new feature"
}
] | closed | false | null | [] | [
"also it would be cool to use something like this : \r\n```python\r\n# Use a pipeline as a high-level helper\r\nfrom transformers import pipeline\r\n\r\npipe = pipeline(\"custom\", model=\"model_id\", trust_remote_code=True)\r\n```",
"Hi @not-lain, thanks for raising this! \r\n\r\nYou might be interested in [usin... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | ### Feature request
is it possible to add a support for custom pipelines.
something like this
```
| - config.json
| - custom_config.py
| - custom_architecture.py
| - custom_pipeline.py
```
### Motivation
i was following this documentation https://huggingface.co/docs/transformers/add_new_pipeline and i can't ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28487/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28487/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28486 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28486/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28486/comments | https://api.github.com/repos/huggingface/transformers/issues/28486/events | https://github.com/huggingface/transformers/pull/28486 | 2,079,348,302 | PR_kwDOCUB6oc5j884U | 28,486 | [ASR Pipe] Update init to set model type and subsequently call parent init method | {
"login": "sanchit-gandhi",
"id": 93869735,
"node_id": "U_kgDOBZhWpw",
"avatar_url": "https://avatars.githubusercontent.com/u/93869735?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sanchit-gandhi",
"html_url": "https://github.com/sanchit-gandhi",
"followers_url": "https://api.github.com... | [] | closed | false | null | [] | [
"The problem with the current solution is that it's a patch over a larger issue: the ASR pipeline is a child of `Pipeline` but doesn't share the `__init__`. So, if there's any new logic added to `Pipeline` which relies on attributes being set or new kwargs this will still fail. \r\n\r\nIt also doesn't make sense fo... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
Fixes #28162 by overriding the init method of the ASR pipeline class. We first set the model type, then call the parent init method.
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28486/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28486/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28486",
"html_url": "https://github.com/huggingface/transformers/pull/28486",
"diff_url": "https://github.com/huggingface/transformers/pull/28486.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28486.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28485 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28485/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28485/comments | https://api.github.com/repos/huggingface/transformers/issues/28485/events | https://github.com/huggingface/transformers/pull/28485 | 2,079,326,176 | PR_kwDOCUB6oc5j838y | 28,485 | [Whisper Tok] Move token ids to CPU when computing offsets | {
"login": "sanchit-gandhi",
"id": 93869735,
"node_id": "U_kgDOBZhWpw",
"avatar_url": "https://avatars.githubusercontent.com/u/93869735?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sanchit-gandhi",
"html_url": "https://github.com/sanchit-gandhi",
"followers_url": "https://api.github.com... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
Fixes #28097 by moving token ids in pytorch on GPU to the CPU before converting to numpy.
| {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28485/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28485/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28485",
"html_url": "https://github.com/huggingface/transformers/pull/28485",
"diff_url": "https://github.com/huggingface/transformers/pull/28485.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28485.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28484 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28484/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28484/comments | https://api.github.com/repos/huggingface/transformers/issues/28484/events | https://github.com/huggingface/transformers/pull/28484 | 2,079,242,765 | PR_kwDOCUB6oc5j8lU4 | 28,484 | Dataloader prefetch batch | {
"login": "qmeeus",
"id": 25608944,
"node_id": "MDQ6VXNlcjI1NjA4OTQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/25608944?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/qmeeus",
"html_url": "https://github.com/qmeeus",
"followers_url": "https://api.github.com/users/qmeeus/fo... | [] | closed | false | null | [] | [
"Hi @qmeeus - thanks for opening a PR! \r\n\r\nAt the moment, there's a very large diff including unrelated changes to those in the PR description. Could you make sure to resolve all conflicts and include the latest updates in `main` using `rebase` or `merge` into this branch? ",
"> ed changes to those in the PR ... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
I added an option to the trainer to prefetch batches during data loading.
When training a model with heavy transformations and an iterable dataset, the dataloader might struggle to deliver fast enough for the GPU. I've found that prefetching batches helps to solve this issue.
The option is im... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28484/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28484/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28484",
"html_url": "https://github.com/huggingface/transformers/pull/28484",
"diff_url": "https://github.com/huggingface/transformers/pull/28484.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28484.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28483 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28483/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28483/comments | https://api.github.com/repos/huggingface/transformers/issues/28483/events | https://github.com/huggingface/transformers/pull/28483 | 2,079,209,690 | PR_kwDOCUB6oc5j8d9P | 28,483 | TF: purge `TFTrainer` | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28483). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,705 | 1,705 | MEMBER | null | # What does this PR do?
Removes `TFTrainer` and all its traces. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28483/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28483/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28483",
"html_url": "https://github.com/huggingface/transformers/pull/28483",
"diff_url": "https://github.com/huggingface/transformers/pull/28483.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28483.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28482 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28482/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28482/comments | https://api.github.com/repos/huggingface/transformers/issues/28482/events | https://github.com/huggingface/transformers/pull/28482 | 2,079,041,827 | PR_kwDOCUB6oc5j74gO | 28,482 | Don't set `finetuned_from` if it is a local path | {
"login": "ydshieh",
"id": 2521628,
"node_id": "MDQ6VXNlcjI1MjE2Mjg=",
"avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ydshieh",
"html_url": "https://github.com/ydshieh",
"followers_url": "https://api.github.com/users/ydshieh/... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
Fix `base_model` issue in #28286 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28482/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28482/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28482",
"html_url": "https://github.com/huggingface/transformers/pull/28482",
"diff_url": "https://github.com/huggingface/transformers/pull/28482.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28482.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28481 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28481/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28481/comments | https://api.github.com/repos/huggingface/transformers/issues/28481/events | https://github.com/huggingface/transformers/pull/28481 | 2,078,977,415 | PR_kwDOCUB6oc5j7qDm | 28,481 | Fix/speecht5 bug | {
"login": "NimaYaqmuri",
"id": 62163525,
"node_id": "MDQ6VXNlcjYyMTYzNTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/62163525?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NimaYaqmuri",
"html_url": "https://github.com/NimaYaqmuri",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"To observe the issue addressed by this PR, visit the [Hugging Face SpeechT5 Fine-Tuning Tutorial](https://huggingface.co/learn/audio-course/chapter6/fine-tuning). During training, you encounter a concatenation error due to incorrect dimensions.",
"Thanks for your advice! I'm going to tweak the `generate_speech` ... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
Fixes a Critical Issue in SpeechT5 Speech Decoder Prenet and Enhances Test Suite
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/trans... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28481/reactions",
"total_count": 3,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 3,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28481/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28481",
"html_url": "https://github.com/huggingface/transformers/pull/28481",
"diff_url": "https://github.com/huggingface/transformers/pull/28481.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28481.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28480 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28480/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28480/comments | https://api.github.com/repos/huggingface/transformers/issues/28480/events | https://github.com/huggingface/transformers/pull/28480 | 2,078,963,133 | PR_kwDOCUB6oc5j7m67 | 28,480 | chore: Just fix some typo | {
"login": "hugo-syn",
"id": 61210734,
"node_id": "MDQ6VXNlcjYxMjEwNzM0",
"avatar_url": "https://avatars.githubusercontent.com/u/61210734?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hugo-syn",
"html_url": "https://github.com/hugo-syn",
"followers_url": "https://api.github.com/users/hug... | [] | closed | false | null | [] | [
"Hi @hugo-syn thanks for opening a PR! There doesn't seem to be any changes in this PR? ",
"Indeed, I don't understand. I've synchronized the main repo and my changes don't appear here, but I can see them on my fork. ",
"The typo fixes in b30d46622e7b3f839fb93cde269dfc797319979b have already been applied to th... | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
Just fix some typo
## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-re... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28480/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28480/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28480",
"html_url": "https://github.com/huggingface/transformers/pull/28480",
"diff_url": "https://github.com/huggingface/transformers/pull/28480.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28480.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28479 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28479/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28479/comments | https://api.github.com/repos/huggingface/transformers/issues/28479/events | https://github.com/huggingface/transformers/pull/28479 | 2,078,880,947 | PR_kwDOCUB6oc5j7UzI | 28,479 | Improved type hinting for all attention parameters | {
"login": "nakranivaibhav",
"id": 67785830,
"node_id": "MDQ6VXNlcjY3Nzg1ODMw",
"avatar_url": "https://avatars.githubusercontent.com/u/67785830?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nakranivaibhav",
"html_url": "https://github.com/nakranivaibhav",
"followers_url": "https://api.gi... | [] | closed | false | null | [] | [
"I had no space between the \",\" and \"...\" That failed the formatting. \r\nYeah @Rocketknight1 makes sense doing that to hidden states too, since it is the same as attentions, depends on num of layers. I can do that too",
"Looks good to me, pinging @ArthurZucker for core maintainer review!",
"@amyeroberts I ... | 1,705 | 1,706 | 1,706 | CONTRIBUTOR | null | # What does this PR do?
The type hinting for all attention parameters has been changed to 'Optional[Tuple[torch.FloatTensor,...]] = None' to reflect a tuple of arbitrary size.
Fixes #28345
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read t... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28479/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28479/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28479",
"html_url": "https://github.com/huggingface/transformers/pull/28479",
"diff_url": "https://github.com/huggingface/transformers/pull/28479.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28479.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28478 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28478/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28478/comments | https://api.github.com/repos/huggingface/transformers/issues/28478/events | https://github.com/huggingface/transformers/pull/28478 | 2,078,735,350 | PR_kwDOCUB6oc5j60kp | 28,478 | Generate: deprecate old public functions | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28478). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,705 | 1,705 | MEMBER | null | # What does this PR do?
Schedules for deprecation old public functions -- these functions are not used anywhere in the code base, and haven't been since I've been in charge of `generate`. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28478/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28478/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28478",
"html_url": "https://github.com/huggingface/transformers/pull/28478",
"diff_url": "https://github.com/huggingface/transformers/pull/28478.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28478.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28477 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28477/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28477/comments | https://api.github.com/repos/huggingface/transformers/issues/28477/events | https://github.com/huggingface/transformers/pull/28477 | 2,078,710,190 | PR_kwDOCUB6oc5j6vBn | 28,477 | Generate: refuse to save bad generation config files | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28477). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,705 | 1,705 | MEMBER | null | # What does this PR do?
This PR converts a warning into an exception. This warning stated that it would be converted to an exception in v4.34 | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28477/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 1,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28477/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28477",
"html_url": "https://github.com/huggingface/transformers/pull/28477",
"diff_url": "https://github.com/huggingface/transformers/pull/28477.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28477.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28476 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28476/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28476/comments | https://api.github.com/repos/huggingface/transformers/issues/28476/events | https://github.com/huggingface/transformers/issues/28476 | 2,078,647,827 | I_kwDOCUB6oc575aYT | 28,476 | How to avoid the peak RAM memory usage of a model when I want to load to GPU | {
"login": "JoanFM",
"id": 19825685,
"node_id": "MDQ6VXNlcjE5ODI1Njg1",
"avatar_url": "https://avatars.githubusercontent.com/u/19825685?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/JoanFM",
"html_url": "https://github.com/JoanFM",
"followers_url": "https://api.github.com/users/JoanFM/fo... | [] | closed | false | null | [] | [
"Hey 🤗 thanks for opening an issue! I am not sure you can prevent CPU usage (transfer from SSD to GPU), not sure anything supports it. However device_map = \"auto\" should always allow you to load the model without going over the ram usage. \r\nThe peak can come from `torch. set_default_dtype(torch.float16)` and ... | 1,705 | 1,707 | 1,707 | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-5.10.201-191.748.amzn2.x86_64-x86_64-with-glibc2.31
- Python version: 3.10.13
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.4.1
- Accelerate version: 0.26.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.0 (True)
- T... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28476/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
} | https://api.github.com/repos/huggingface/transformers/issues/28476/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28475 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28475/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28475/comments | https://api.github.com/repos/huggingface/transformers/issues/28475/events | https://github.com/huggingface/transformers/pull/28475 | 2,078,570,207 | PR_kwDOCUB6oc5j6P4D | 28,475 | Docs: add model paths | {
"login": "gante",
"id": 12240844,
"node_id": "MDQ6VXNlcjEyMjQwODQ0",
"avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/gante",
"html_url": "https://github.com/gante",
"followers_url": "https://api.github.com/users/gante/follow... | [] | closed | false | null | [] | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28475). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,705 | 1,705 | 1,705 | MEMBER | null | # What does this PR do?
As reported by @sayakpaul: some models had placeholder paths. This PR corrects it. | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28475/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28475/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28475",
"html_url": "https://github.com/huggingface/transformers/pull/28475",
"diff_url": "https://github.com/huggingface/transformers/pull/28475.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28475.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28474 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28474/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28474/comments | https://api.github.com/repos/huggingface/transformers/issues/28474/events | https://github.com/huggingface/transformers/pull/28474 | 2,078,491,706 | PR_kwDOCUB6oc5j5-0S | 28,474 | filter out callable attributes from tokenizer_config in save_pretrained | {
"login": "shuttie",
"id": 999061,
"node_id": "MDQ6VXNlcjk5OTA2MQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/999061?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shuttie",
"html_url": "https://github.com/shuttie",
"followers_url": "https://api.github.com/users/shuttie/fo... | [] | closed | false | null | [] | [
"This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.\n\nPlease note that issues that do not follow the [contributing guidelines](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md) a... | 1,705 | 1,708 | 1,708 | NONE | null | # What does this PR do?
Fixes https://github.com/huggingface/transformers/issues/28472
As discussed in the upstream bug report, `add_special_token` can be both kwargs parameter passed to the `from_pretrained` and a method in `SpecialTokensMixin.add_special_tokens`. Not sure that it's the best way for doing this, ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28474/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28474/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28474",
"html_url": "https://github.com/huggingface/transformers/pull/28474",
"diff_url": "https://github.com/huggingface/transformers/pull/28474.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28474.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28473 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28473/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28473/comments | https://api.github.com/repos/huggingface/transformers/issues/28473/events | https://github.com/huggingface/transformers/pull/28473 | 2,078,438,756 | PR_kwDOCUB6oc5j5zXV | 28,473 | feat: support indicating prefix token of chat template | {
"login": "congchan",
"id": 18083731,
"node_id": "MDQ6VXNlcjE4MDgzNzMx",
"avatar_url": "https://avatars.githubusercontent.com/u/18083731?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/congchan",
"html_url": "https://github.com/congchan",
"followers_url": "https://api.github.com/users/con... | [] | open | false | null | [] | [
"cc @Rocketknight1 ",
"Hi @congchan - firstly, apologies for taking so long to get to this one - it slipped past me the first time I was pinged! This seems like a clean PR, but I'm not sure we can accept it as-is: The list of special tokens that we have specific code for is very short, and I think this would make... | 1,705 | 1,707 | null | NONE | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28473/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28473/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28473",
"html_url": "https://github.com/huggingface/transformers/pull/28473",
"diff_url": "https://github.com/huggingface/transformers/pull/28473.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28473.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28472 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28472/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28472/comments | https://api.github.com/repos/huggingface/transformers/issues/28472/events | https://github.com/huggingface/transformers/issues/28472 | 2,078,425,643 | I_kwDOCUB6oc574kIr | 28,472 | Tokenizer.save_pretrained fails when add_special_tokens=True|False | {
"login": "shuttie",
"id": 999061,
"node_id": "MDQ6VXNlcjk5OTA2MQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/999061?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/shuttie",
"html_url": "https://github.com/shuttie",
"followers_url": "https://api.github.com/users/shuttie/fo... | [] | closed | false | null | [] | [
"It is indeed related to that PR, but it is also related to the fact that `add_special_tokens` even if saved, is not used when doing an encode pass. Thus it's better to error out than save it IMO as it won't be checked when encoding. I'll have a look at the PR ",
"This issue has been automatically marked as stale... | 1,705 | 1,708 | 1,708 | NONE | null | ### System Info
transformers-4.34
python-3.11
### Who can help?
@ArthurZucker
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X] My own task or dataset (give details below)
### R... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28472/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28472/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28471 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28471/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28471/comments | https://api.github.com/repos/huggingface/transformers/issues/28471/events | https://github.com/huggingface/transformers/pull/28471 | 2,078,363,551 | PR_kwDOCUB6oc5j5jQl | 28,471 | Fix torch.ones usage in xlnet | {
"login": "sungho-ham",
"id": 19978686,
"node_id": "MDQ6VXNlcjE5OTc4Njg2",
"avatar_url": "https://avatars.githubusercontent.com/u/19978686?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sungho-ham",
"html_url": "https://github.com/sungho-ham",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28471/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28471/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28471",
"html_url": "https://github.com/huggingface/transformers/pull/28471",
"diff_url": "https://github.com/huggingface/transformers/pull/28471.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28471.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28470 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28470/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28470/comments | https://api.github.com/repos/huggingface/transformers/issues/28470/events | https://github.com/huggingface/transformers/issues/28470 | 2,078,272,669 | I_kwDOCUB6oc573-yd | 28,470 | Running a `forward` pass before `generate` with AWQ fused modules breaks it | {
"login": "IlyasMoutawwakil",
"id": 57442720,
"node_id": "MDQ6VXNlcjU3NDQyNzIw",
"avatar_url": "https://avatars.githubusercontent.com/u/57442720?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/IlyasMoutawwakil",
"html_url": "https://github.com/IlyasMoutawwakil",
"followers_url": "https://... | [] | open | false | {
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url": "https://api.githu... | [
{
"login": "younesbelkada",
"id": 49240599,
"node_id": "MDQ6VXNlcjQ5MjQwNTk5",
"avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/younesbelkada",
"html_url": "https://github.com/younesbelkada",
"followers_url"... | [
"cc @younesbelkada and @fxmarty, if they use static cache then that is expected. I might fix it in #27931 ",
"cc @younesbelkada 🤗 "
] | 1,705 | 1,707 | null | MEMBER | null | ### System Info
- `transformers` version: 4.36.2
- Platform: Linux-5.4.0-166-generic-x86_64-with-glibc2.35
- Python version: 3.10.12
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.4.1
- Accelerate version: 0.26.1
- Accelerate config: - compute_environment: LOCAL_MACHINE
- distributed_type... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28470/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28470/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28469 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28469/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28469/comments | https://api.github.com/repos/huggingface/transformers/issues/28469/events | https://github.com/huggingface/transformers/issues/28469 | 2,078,206,863 | I_kwDOCUB6oc573uuP | 28,469 | `dataloader_persistent_workers=True` causes fork-bomb due to repeated creation of `eval_dataloader` | {
"login": "naba89",
"id": 12119806,
"node_id": "MDQ6VXNlcjEyMTE5ODA2",
"avatar_url": "https://avatars.githubusercontent.com/u/12119806?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/naba89",
"html_url": "https://github.com/naba89",
"followers_url": "https://api.github.com/users/naba89/fo... | [] | open | false | null | [] | [
"gentle ping: @muellerzr @pacman100"
] | 1,705 | 1,707 | null | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: macOS-10.16-x86_64-i386-64bit
- Python version: 3.10.13
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.4.1
- Accelerate version: 0.26.1
- Accelerate config: - compute_environment: LOCAL_MACHINE
- distributed_type: NO
- ... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28469/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28469/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28468 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28468/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28468/comments | https://api.github.com/repos/huggingface/transformers/issues/28468/events | https://github.com/huggingface/transformers/issues/28468 | 2,078,022,384 | I_kwDOCUB6oc573Brw | 28,468 | Train LLaMA 2 with PEFT(LoRA) + Deepspeed Zero3 on v100 * 8, raise assert param.ds_status == ZeroParamStatus.AVAILABLE | {
"login": "ZetangForward",
"id": 123983104,
"node_id": "U_kgDOB2PVAA",
"avatar_url": "https://avatars.githubusercontent.com/u/123983104?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ZetangForward",
"html_url": "https://github.com/ZetangForward",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"Hey, would you mind updating to the latest version of transformers, test again and also share the output of `transformers-cli env`",
"> ransformers-cli env\r\n\r\nHi， sorry for the late reply. Sure, I update the transformers version, and here is my transformers version:\r\n\r\n```\r\nPython 3.10.13 (main, Sep 1... | 1,705 | 1,708 | 1,708 | NONE | null | ### System Info
Huggingface Version == 4.31.0
## Environment
Deepspeed Zero3 Config:
```
{
"zero_optimization": {
"stage": 3,
"offload_optimizer": {
"device": "cpu",
"pin_memory": true
},
"offload_param": {
"device": "cpu",
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28468/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28468/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28467 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28467/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28467/comments | https://api.github.com/repos/huggingface/transformers/issues/28467/events | https://github.com/huggingface/transformers/issues/28467 | 2,078,016,506 | I_kwDOCUB6oc573AP6 | 28,467 | ImportError: cannot import name 'is_g2p_en_available' from 'transformers.utils' (/usr/local/lib/python3.10/dist-packages/transformers/utils/__init__.py) | {
"login": "kli017",
"id": 14877573,
"node_id": "MDQ6VXNlcjE0ODc3NTcz",
"avatar_url": "https://avatars.githubusercontent.com/u/14877573?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kli017",
"html_url": "https://github.com/kli017",
"followers_url": "https://api.github.com/users/kli017/fo... | [] | open | false | null | [] | [
"I don't know which section this is, but thefunction is defined here: \r\nhttps://github.com/huggingface/transformers/blob/07f5cdcac14b672ea6934b16da432518717f5b74/src/transformers/utils/import_utils.py#L448\r\n\r\nit was merged to transformers last week, so can't be there for earlier versions. Can you share a smal... | 1,705 | 1,706 | null | NONE | null | ### System Info
env: colab
python=3.10
trasformers=4.37.0.dev0
### Who can help?
_No response_
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give deta... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28467/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28467/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28466 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28466/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28466/comments | https://api.github.com/repos/huggingface/transformers/issues/28466/events | https://github.com/huggingface/transformers/issues/28466 | 2,077,979,494 | I_kwDOCUB6oc5723Nm | 28,466 | LlamaForCausalLM does not support Flash Attention 2.0 yet | {
"login": "Patrick-Ni",
"id": 59468866,
"node_id": "MDQ6VXNlcjU5NDY4ODY2",
"avatar_url": "https://avatars.githubusercontent.com/u/59468866?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Patrick-Ni",
"html_url": "https://github.com/Patrick-Ni",
"followers_url": "https://api.github.com/use... | [] | closed | false | null | [] | [
"make sure you are using the latest version of transformers and not a code on the hub! 🤗 closing as this was added in #25598"
] | 1,705 | 1,705 | 1,705 | NONE | null | The model was loaded with use_flash_attention_2=True, which is deprecated and may be removed in a future release. Please use `attn_implementation="flash_attention_2"` instead.
Traceback (most recent call last):
File "/root/paddlejob/workspace/env_run/benchmark/generation/main.py", line 116, in <module>
main()
... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28466/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28466/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28465 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28465/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28465/comments | https://api.github.com/repos/huggingface/transformers/issues/28465/events | https://github.com/huggingface/transformers/pull/28465 | 2,077,920,592 | PR_kwDOCUB6oc5j4EEy | 28,465 | Update README.md | {
"login": "kit1980",
"id": 420184,
"node_id": "MDQ6VXNlcjQyMDE4NA==",
"avatar_url": "https://avatars.githubusercontent.com/u/420184?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kit1980",
"html_url": "https://github.com/kit1980",
"followers_url": "https://api.github.com/users/kit1980/fo... | [] | closed | false | null | [] | [] | 1,705 | 1,705 | 1,705 | CONTRIBUTOR | null | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28465/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28465/timeline | null | true | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28465",
"html_url": "https://github.com/huggingface/transformers/pull/28465",
"diff_url": "https://github.com/huggingface/transformers/pull/28465.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28465.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28463 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28463/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28463/comments | https://api.github.com/repos/huggingface/transformers/issues/28463/events | https://github.com/huggingface/transformers/issues/28463 | 2,077,796,716 | I_kwDOCUB6oc572Kls | 28,463 | Mixtral inference on multi gpu is broken with 4.37.0dev (995a7ce) | {
"login": "nepeee",
"id": 13850451,
"node_id": "MDQ6VXNlcjEzODUwNDUx",
"avatar_url": "https://avatars.githubusercontent.com/u/13850451?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/nepeee",
"html_url": "https://github.com/nepeee",
"followers_url": "https://api.github.com/users/nepeee/fo... | [] | closed | false | null | [] | [
"Reverting back to nvidia driver 535.154.05 / cuda 12.2 seems to fixed the issue.",
"Thanks for providing the solution"
] | 1,705 | 1,706 | 1,705 | NONE | null | ### System Info
Ubuntu 22.04 RTX 3090 + RTX 3080TI transformers 4.37.0dev (995a7ce)
### Who can help?
@ArthurZucker
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28463/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28463/timeline | completed | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28462 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28462/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28462/comments | https://api.github.com/repos/huggingface/transformers/issues/28462/events | https://github.com/huggingface/transformers/issues/28462 | 2,077,558,874 | I_kwDOCUB6oc571Qha | 28,462 | Move layer_idx from a layer property to function argument. | {
"login": "siddartha-RE",
"id": 55106295,
"node_id": "MDQ6VXNlcjU1MTA2Mjk1",
"avatar_url": "https://avatars.githubusercontent.com/u/55106295?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/siddartha-RE",
"html_url": "https://github.com/siddartha-RE",
"followers_url": "https://api.github.c... | [
{
"id": 2648621985,
"node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request",
"name": "Feature request",
"color": "FBCA04",
"default": false,
"description": "Request for a new feature"
}
] | open | false | null | [] | [
"I don't mind taking a look at a PR, feel free to ping me! 🤗 "
] | 1,705 | 1,705 | null | CONTRIBUTOR | null | ### Feature request
Currently the layer_idx is recorded in the attention module of each `LlamaDecoderLayer`. This has the unfortunate side effect that the layers cannot easily be moved around or reused within the layer list. It seems simple enough to pass in the layer index as part of loop over layers in the forward p... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28462/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28462/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28461 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28461/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28461/comments | https://api.github.com/repos/huggingface/transformers/issues/28461/events | https://github.com/huggingface/transformers/issues/28461 | 2,077,408,711 | I_kwDOCUB6oc570r3H | 28,461 | Pytorch can have its default dtype permanently set to the "wrong" value if there is an exception when loading a model | {
"login": "Taytay",
"id": 1330693,
"node_id": "MDQ6VXNlcjEzMzA2OTM=",
"avatar_url": "https://avatars.githubusercontent.com/u/1330693?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Taytay",
"html_url": "https://github.com/Taytay",
"followers_url": "https://api.github.com/users/Taytay/foll... | [
{
"id": 3081136536,
"node_id": "MDU6TGFiZWwzMDgxMTM2NTM2",
"url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20Difficult%20Issue",
"name": "Good Difficult Issue",
"color": "684CC7",
"default": false,
"description": ""
}
] | open | false | null | [] | [
"thanks for the deep investigation the proposed solution! \r\nI think having a context manager that handles that looks like a valid solution and might cover all edge cases including yours - I would be curious to hear what you think @amyeroberts @ArthurZucker ?\r\nI think that @Taytay is right here in the sense that... | 1,705 | 1,707 | null | NONE | null | ### System Info
I just ran into the most head-scratching issue. My data collator was crashing because a tensor it made was in half precision (fp16). I couldn't figure out why, but then I realized my `torch.get_default_dtype()` was `torch.float16`!
Then I realized it's because my model code threw an exception in a p... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28461/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28461/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28460 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28460/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28460/comments | https://api.github.com/repos/huggingface/transformers/issues/28460/events | https://github.com/huggingface/transformers/pull/28460 | 2,077,385,630 | PR_kwDOCUB6oc5j2OXG | 28,460 | Fix docstrings and update docstring checker error message | {
"login": "Rocketknight1",
"id": 12866554,
"node_id": "MDQ6VXNlcjEyODY2NTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Rocketknight1",
"html_url": "https://github.com/Rocketknight1",
"followers_url": "https://api.githu... | [] | closed | false | null | [] | [
"Okay there's something more deeply wrong with the docstring checker than I realized - the new docstring is definitely more correct, but is failing checks in the CI! Will investigate.",
"Quick re-review request @ArthurZucker, I'm going to update the error message in this PR too!"
] | 1,704 | 1,705 | 1,705 | MEMBER | null | While I was making fixes to the docstring checker, I found another issue - this one seems to be intermittent, and I'm not sure why it only fails tests sometimes. Still, it's definitely wrong, so this fix should hopefully avoid issues in future! | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28460/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28460/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28460",
"html_url": "https://github.com/huggingface/transformers/pull/28460",
"diff_url": "https://github.com/huggingface/transformers/pull/28460.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28460.patch",
"merged_at... |
https://api.github.com/repos/huggingface/transformers/issues/28459 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28459/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28459/comments | https://api.github.com/repos/huggingface/transformers/issues/28459/events | https://github.com/huggingface/transformers/issues/28459 | 2,077,372,971 | I_kwDOCUB6oc570jIr | 28,459 | `get_imports` failing to respect conditionals on imports | {
"login": "jamesbraza",
"id": 8990777,
"node_id": "MDQ6VXNlcjg5OTA3Nzc=",
"avatar_url": "https://avatars.githubusercontent.com/u/8990777?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jamesbraza",
"html_url": "https://github.com/jamesbraza",
"followers_url": "https://api.github.com/users... | [] | open | false | null | [] | [
"For reference, this only happens when `trust_remote_code=True`. Thus, we switched from using `if is_flash_attn_2_available():` to a `try/except` block when trying to import the `flash_attn` package.\r\n\r\nSeems to be working!",
"Thanks @gugarosa for finding a workaround, that works because `get_imports` include... | 1,704 | 1,706 | null | NONE | null | ### System Info
- `transformers` version: 4.36.2
- Platform: macOS-13.5.2-arm64-arm-64bit
- Python version: 3.11.7
- Huggingface_hub version: 0.20.2
- Safetensors version: 0.4.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.1.2 (False)
- Tensorflow version (GPU?... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28459/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28459/timeline | null | null | null |
https://api.github.com/repos/huggingface/transformers/issues/28458 | https://api.github.com/repos/huggingface/transformers | https://api.github.com/repos/huggingface/transformers/issues/28458/labels{/name} | https://api.github.com/repos/huggingface/transformers/issues/28458/comments | https://api.github.com/repos/huggingface/transformers/issues/28458/events | https://github.com/huggingface/transformers/pull/28458 | 2,077,343,501 | PR_kwDOCUB6oc5j2FPX | 28,458 | Mark two logger tests as flaky | {
"login": "amyeroberts",
"id": 22614925,
"node_id": "MDQ6VXNlcjIyNjE0OTI1",
"avatar_url": "https://avatars.githubusercontent.com/u/22614925?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/amyeroberts",
"html_url": "https://github.com/amyeroberts",
"followers_url": "https://api.github.com/... | [] | closed | false | null | [] | [
"@ydshieh Sure, will add! ",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_28458). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] | 1,704 | 1,705 | 1,705 | COLLABORATOR | null | # What does this PR do?
Two tests which capture and check the logger's output occasionally fail.
```
FAILED tests/test_modeling_utils.py::ModelUtilsTest::test_model_from_pretrained_with_different_pretrained_model_name - AssertionError: False is not true
FAILED tests/test_modeling_utils.py::ModelUtilsTest::test... | {
"url": "https://api.github.com/repos/huggingface/transformers/issues/28458/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} | https://api.github.com/repos/huggingface/transformers/issues/28458/timeline | null | false | {
"url": "https://api.github.com/repos/huggingface/transformers/pulls/28458",
"html_url": "https://github.com/huggingface/transformers/pull/28458",
"diff_url": "https://github.com/huggingface/transformers/pull/28458.diff",
"patch_url": "https://github.com/huggingface/transformers/pull/28458.patch",
"merged_at... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.