repo stringclasses 15
values | pull_number int64 147 18.3k | instance_id stringlengths 14 31 | issue_numbers listlengths 1 3 | base_commit stringlengths 40 40 | patch stringlengths 289 585k | test_patch stringlengths 355 6.82M | problem_statement stringlengths 25 49.4k | hints_text stringlengths 0 58.9k | created_at timestamp[us, tz=UTC]date 2014-08-08 22:09:38 2024-06-28 03:13:12 | version stringclasses 110
values | PASS_TO_PASS listlengths 0 4.82k | FAIL_TO_PASS listlengths 1 1.06k | language stringclasses 4
values | image_urls listlengths 0 4 | website links listlengths 0 4 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
python/mypy | 15,050 | python__mypy-15050 | [
"15088"
] | 084581839b3f39766154aa81e8019bec6cee416e | diff --git a/mypy/plugins/attrs.py b/mypy/plugins/attrs.py
--- a/mypy/plugins/attrs.py
+++ b/mypy/plugins/attrs.py
@@ -2,15 +2,18 @@
from __future__ import annotations
-from typing import Iterable, List, cast
+from collections import defaultdict
+from functools import reduce
+from typing import Iterable, List, Map... | diff --git a/test-data/unit/check-attr.test b/test-data/unit/check-attr.test
--- a/test-data/unit/check-attr.test
+++ b/test-data/unit/check-attr.test
@@ -1970,6 +1970,81 @@ reveal_type(ret) # N: Revealed type is "Any"
[typing fixtures/typing-medium.pyi]
+[case testEvolveGeneric]
+import attrs
+from typing import... | Generic type parameters to Argument 1 of `attrs.evolve` only unify under very specific circumstances (mypy 1.2)
<!--
If you're not sure whether what you're experiencing is a mypy bug, please see the "Question and Help" form instead.
Please consider:
- checking our common issues page: https://mypy.readthedocs.io/en... | 2023-04-13T18:23:05Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-attr.test::testAttrsCmpEqOrderValues",
"mypy/test/testcheck.py::TypeCheckSuite::check-attr.test::testAttrsNextGenDetect",
"mypy/test/testcheck.py::TypeCheckSuite::check-attr.test::testAttrsDefaultErrors",
"mypy/test/testcheck.py::TypeCheckSuite::check-attr.test::... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-attr.test::testEvolveGeneric",
"mypy/test/testcheck.py::TypeCheckSuite::check-attr.test::testEvolveUnion",
"mypy/test/testcheck.py::TypeCheckSuite::check-attr.test::testEvolveUnionOfTypeVar",
"mypy/test/testcheck.py::TypeCheckSuite::check-attr.test::testEvolveTyp... | Python | [] | [] | |
python/mypy | 15,123 | python__mypy-15123 | [
"12923"
] | 15fbd539b08a99d13c410b4683b13891274091bb | diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
--- a/mypy/checkexpr.py
+++ b/mypy/checkexpr.py
@@ -3918,6 +3918,12 @@ def visit_assert_type_expr(self, expr: AssertTypeExpr) -> Type:
always_allow_any=True,
)
target_type = expr.type
+ proper_source_type = get_proper_type(source_t... | diff --git a/test-data/unit/check-expressions.test b/test-data/unit/check-expressions.test
--- a/test-data/unit/check-expressions.test
+++ b/test-data/unit/check-expressions.test
@@ -937,6 +937,8 @@ reveal_type(returned) # N: Revealed type is "builtins.int"
assert_type(a, str) # E: Expression is of type "int", not "... | `assert_type()` says an int is not an int
The following code:
```python
from typing_extensions import assert_type
assert_type(42, int)
```
fails to typecheck with the following message:
```
assert-type01.py:3: error: Expression is of type "int", not "int"
```
**Your Environment**
- Mypy version us... | Lol, it's probably `Literal[42]`. So bad error message, but there should probably still be an error? Jelle will confirm.
Yeah, pyright also gives an error `error: "assert_type" mismatch: expected "int" but received "Literal[42]"`
Implementation hints: 42 has type `Instance` with the `last_known_value` attribute set to ... | 2023-04-25T05:02:38Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testNoneAsRvalue",
"mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testNonBooleanOr",
"mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testChainedCompResTyp",
"mypy/test/testcheck.py::TypeCheckSuite::check-expres... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testAssertType"
] | Python | [] | [] |
python/mypy | 15,128 | python__mypy-15128 | [
"15192"
] | 00f3913b314994b4b391a2813a839c094482b632 | diff --git a/mypy/subtypes.py b/mypy/subtypes.py
--- a/mypy/subtypes.py
+++ b/mypy/subtypes.py
@@ -439,7 +439,7 @@ def visit_instance(self, left: Instance) -> bool:
# dynamic base classes correctly, see #5456.
return not isinstance(self.right, NoneType)
right = self.right
- if ... | diff --git a/mypy/test/testtypes.py b/mypy/test/testtypes.py
--- a/mypy/test/testtypes.py
+++ b/mypy/test/testtypes.py
@@ -611,10 +611,7 @@ def test_simplified_union_with_mixed_str_literals(self) -> None:
[fx.lit_str1, fx.lit_str2, fx.lit_str3_inst],
UnionType([fx.lit_str1, fx.lit_str2, fx.lit... | Segfault when manipulating a recursive union
**Bug Report**
Running mypy on the following program produces a segfault.
**To Reproduce**
```python
from typing import Literal, TypeAlias, Union
Expr: TypeAlias = Union[
tuple[Literal["const"], int],
tuple[Literal["neg"], "Expr"],
]
def eval(e... | 2023-04-25T16:21:43Z | 1.4 | [
"mypy/test/testtypes.py::TypesSuite::test_type_alias_expand_once",
"mypy/test/testtypes.py::TypeOpsSuite::test_expand_naked_type_var",
"mypy/test/testtypes.py::TypesSuite::test_any",
"mypy/test/testtypes.py::TypeOpsSuite::test_is_proper_subtype_invariance",
"mypy/test/testtypes.py::TypesSuite::test_type_var... | [
"mypy/test/testtypes.py::TypeOpsSuite::test_simplified_union_with_mixed_str_literals",
"mypy/test/testcheck.py::TypeCheckSuite::check-type-aliases.test::testRecursiveAliasTuple"
] | Python | [] | [
"https://mypy-play.net/?mypy=latest&python=3.11&gist=51e21382324203063b7a6373c7cf1405"
] | |
python/mypy | 15,139 | python__mypy-15139 | [
"13027"
] | 16b936c15b074db858729ed218248ef623070e03 | diff --git a/mypy/messages.py b/mypy/messages.py
--- a/mypy/messages.py
+++ b/mypy/messages.py
@@ -2517,7 +2517,8 @@ def format_literal_value(typ: LiteralType) -> str:
else:
return "<nothing>"
elif isinstance(typ, TypeType):
- return f"Type[{format(typ.item)}]"
+ type_name = "ty... | diff --git a/test-data/unit/check-lowercase.test b/test-data/unit/check-lowercase.test
--- a/test-data/unit/check-lowercase.test
+++ b/test-data/unit/check-lowercase.test
@@ -42,3 +42,10 @@ x = 3 # E: Incompatible types in assignment (expression has type "int", variabl
x = {3}
x = 3 # E: Incompatible types in assig... | Inconsistency in use `builtin.type` and `typing.Type` in error messages
Consider this example:
```py
x: type[type]
reveal_type(x) # Revealed type is "Type[builtins.type]"
reveal_type(type[type]) # Value of type "Type[type]" is not indexable
# Revealed type is "Any"
```
Here im using onl... | Here the best option seems to be to use `builtins.type` when using `reveal_type()` (since it generally prefers more verbose types). In other contexts we'd use `type[type]` on Python 3.9 and later and `Type[type]` on Python 3.8 and earlier, to be consistent with error messages work in general . So this is the desired ou... | 2023-04-26T04:16:53Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-lowercase.test::testListLowercaseSettingOff",
"mypy/test/testcheck.py::TypeCheckSuite::check-lowercase.test::testSetLowercaseSettingOff",
"mypy/test/testcheck.py::TypeCheckSuite::check-lowercase.test::testDictLowercaseSettingOff",
"mypy/test/testcheck.py::TypeChe... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-lowercase.test::testTypeLowercaseSettingOff"
] | Python | [] | [] |
python/mypy | 15,155 | python__mypy-15155 | [
"15060"
] | 6b1fc865902bf2b845d3c58b6b9973b5a412241f | diff --git a/mypy/applytype.py b/mypy/applytype.py
--- a/mypy/applytype.py
+++ b/mypy/applytype.py
@@ -75,7 +75,6 @@ def apply_generic_arguments(
report_incompatible_typevar_value: Callable[[CallableType, Type, str, Context], None],
context: Context,
skip_unsatisfied: bool = False,
- allow_erased_call... | diff --git a/test-data/unit/check-generics.test b/test-data/unit/check-generics.test
--- a/test-data/unit/check-generics.test
+++ b/test-data/unit/check-generics.test
@@ -2698,3 +2698,16 @@ def func(var: T) -> T:
reveal_type(func(1)) # N: Revealed type is "builtins.int"
[builtins fixtures/tuple.pyi]
+
+[case testG... | Crash type-checking overloaded function
<!--
Use this form only if mypy reports an "INTERNAL ERROR" and/or gives a traceback.
Please include the traceback and all other messages below (use `mypy --show-traceback`).
-->
**Crash Report**
Crash typing code that previously on older mypy versions worked fine. N... | Thanks for the report! I think this bisects to https://github.com/python/mypy/pull/14178 | 2023-04-28T23:16:19Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-generics.test::testTypeApplicationCrash",
"mypy/test/testcheck.py::TypeCheckSuite::check-generics.test::testTypeCheckingGenericFunctionBody",
"mypy/test/testcheck.py::TypeCheckSuite::check-generics.test::testMultipleGenericTypeParametersAndSubtyping",
"mypy/test/... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-generics.test::testGenericLambdaGenericMethodNoCrash"
] | Python | [] | [] |
python/mypy | 15,157 | python__mypy-15157 | [
"15004"
] | 6b1fc865902bf2b845d3c58b6b9973b5a412241f | diff --git a/mypy/semanal.py b/mypy/semanal.py
--- a/mypy/semanal.py
+++ b/mypy/semanal.py
@@ -3647,7 +3647,7 @@ def analyze_lvalue(
has_explicit_value=has_explicit_value,
)
elif isinstance(lval, MemberExpr):
- self.analyze_member_lvalue(lval, explicit_type, is_final)
+... | diff --git a/test-data/unit/check-dataclasses.test b/test-data/unit/check-dataclasses.test
--- a/test-data/unit/check-dataclasses.test
+++ b/test-data/unit/check-dataclasses.test
@@ -2037,3 +2037,16 @@ Foo(
present_5=5,
)
[builtins fixtures/dataclasses.pyi]
+
+[case testProtocolNoCrash]
+from typing import Proto... | AssertionError: Internal error: too many class plugin hook passes
**Crash Report**
See the traceback.
**Traceback**
```
Traceback (most recent call last):
File "D:\dro\bin\WPy64-31090\python-3.10.9.amd64\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File... | Here's a smaller reproducer:
```python
from dataclasses import dataclass
from typing import Protocol
@dataclass
class TargetSettings(Protocol):
min: int
def __post_init__(self) -> None:
self.min = int(self.min)
```
Combining `@dataclass` and `Protocol` is a strange thing to do and I'm ... | 2023-04-29T19:20:43Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesDefaults",
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassOrderingWithoutEquality",
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesBasic",
"mypy/test/testcheck.py::Ty... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testProtocolNoCrash"
] | Python | [] | [] |
python/mypy | 15,159 | python__mypy-15159 | [
"15018"
] | 6b1fc865902bf2b845d3c58b6b9973b5a412241f | diff --git a/mypy/typeanal.py b/mypy/typeanal.py
--- a/mypy/typeanal.py
+++ b/mypy/typeanal.py
@@ -1110,7 +1110,13 @@ def visit_type_type(self, t: TypeType) -> Type:
return TypeType.make_normalized(self.anal_type(t.item), line=t.line)
def visit_placeholder_type(self, t: PlaceholderType) -> Type:
- ... | diff --git a/test-data/unit/check-recursive-types.test b/test-data/unit/check-recursive-types.test
--- a/test-data/unit/check-recursive-types.test
+++ b/test-data/unit/check-recursive-types.test
@@ -897,3 +897,29 @@ Example = NamedTuple("Example", [("rec", List["Example"])])
e: Example
reveal_type(e) # N: Revealed t... | Internal Error with recursive TypeAlias + TypeVar when in function scope
**Crash Report**
I declared a recursive `TypeAlias` inside a function, and bound a `TypeVar` to that `TypeAlias`. Using the `TypeVar` seems to cause the crash (if I don't reference the `TypeVar` then mypy points out "Recursive types are not all... | 2023-04-30T20:46:05Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveAliasViaBaseClass2",
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveAliasImported",
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveAliasBasic",
"mypy/test/tes... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveBoundFunctionScopeNoCrash",
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testForwardBoundFunctionScopeWorks"
] | Python | [] | [] | |
python/mypy | 15,184 | python__mypy-15184 | [
"12677"
] | 13f35ad0915e70c2c299e2eb308968c86117132d | diff --git a/mypy/messages.py b/mypy/messages.py
--- a/mypy/messages.py
+++ b/mypy/messages.py
@@ -1656,12 +1656,8 @@ def redundant_cast(self, typ: Type, context: Context) -> None:
)
def assert_type_fail(self, source_type: Type, target_type: Type, context: Context) -> None:
- self.fail(
- ... | diff --git a/test-data/unit/check-assert-type-fail.test b/test-data/unit/check-assert-type-fail.test
new file mode 100644
--- /dev/null
+++ b/test-data/unit/check-assert-type-fail.test
@@ -0,0 +1,28 @@
+[case testAssertTypeFail1]
+import typing
+import array as arr
+class array:
+ pass
+def f(si: arr.array[int]):
+ ... | assert_type: Use fully qualified types when names are ambiguous
On current master, this code:
```python
from typing import TypeVar
import typing
import typing_extensions
U = TypeVar("U", int, typing_extensions.SupportsIndex)
def f(si: U) -> U:
return si
def caller(si: typing.SupportsIndex):
typ... | I don't know if this is the exact same bug or not, but I just discovered that this code:
```python
from typing_extensions import assert_type
assert_type(42, int)
```
fails to typecheck with mypy (both 0.960 and commit 1636a0549670e1b75e2987c16ef26ebf91dfbde9) with the following message:
```
assert-type01... | 2023-05-04T15:43:32Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-assert-type-fail.test::testAssertTypeFail3"
] | [
"mypy/test/testcheck.py::TypeCheckSuite::check-assert-type-fail.test::testAssertTypeFail1",
"mypy/test/testcheck.py::TypeCheckSuite::check-assert-type-fail.test::testAssertTypeFail2"
] | Python | [] | [] |
python/mypy | 15,208 | python__mypy-15208 | [
"15195"
] | 7832e1f4ec5edf5f814c91f323c2d4ccc3022603 | diff --git a/mypy/stubgen.py b/mypy/stubgen.py
--- a/mypy/stubgen.py
+++ b/mypy/stubgen.py
@@ -1002,6 +1002,7 @@ def visit_class_def(self, o: ClassDef) -> None:
def get_base_types(self, cdef: ClassDef) -> list[str]:
"""Get list of base classes for a class."""
base_types: list[str] = []
+ p... | diff --git a/test-data/unit/stubgen.test b/test-data/unit/stubgen.test
--- a/test-data/unit/stubgen.test
+++ b/test-data/unit/stubgen.test
@@ -2932,6 +2932,18 @@ class Y(TypedDict, total=False):
a: int
b: str
+[case testTypeddictClassWithKeyword]
+from typing import TypedDict
+class MyDict(TypedDict, total=... | Stubgen does not copy total attribute from TypedDict
**Bug Report**
When using stubgen the `total` attribute of `TypedDict` is lost.
**To Reproduce**
Assuming the following example
```python
from typing import TypedDict
class MyDict(TypedDict, total=False):
foo: str
bar: int
```
After runn... | 2023-05-07T18:47:46Z | 1.4 | [
"mypy/test/teststubgen.py::StubgenPythonSuite::stubgen.test::testEmptyFile",
"mypy/test/teststubgen.py::StubgenPythonSuite::stubgen.test::testMultipleAssignment",
"mypy/test/teststubgen.py::StubgenPythonSuite::stubgen.test::testInitTypeAnnotationPreserved",
"mypy/test/teststubgen.py::StubgenPythonSuite::stubg... | [
"mypy/test/teststubgen.py::StubgenPythonSuite::stubgen.test::testTypeddictClassWithKeyword"
] | Python | [] | [] | |
python/mypy | 15,219 | python__mypy-15219 | [
"15062"
] | 905c2cbcc233727cbf42d9f3ac78849318482af2 | diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
--- a/mypy/checkexpr.py
+++ b/mypy/checkexpr.py
@@ -151,11 +151,13 @@
UninhabitedType,
UnionType,
UnpackType,
+ flatten_nested_tuples,
flatten_nested_unions,
get_proper_type,
get_proper_types,
has_recursive_types,
is_named_ins... | diff --git a/test-data/unit/check-typevar-tuple.test b/test-data/unit/check-typevar-tuple.test
--- a/test-data/unit/check-typevar-tuple.test
+++ b/test-data/unit/check-typevar-tuple.test
@@ -570,3 +570,237 @@ call(A().func3, 0, 1, 2)
call(A().func3)
[builtins fixtures/tuple.pyi]
+
+[case testVariadicAliasBasicTuple... | Cannot create generic type aliases with TypeVarTuple
The support for `TypeVarTuple` is still experimental, so maybe this kind of error is expected, but I thought I could report it anyway.
**To Reproduce**
The following example is [directly from the PEP](https://peps.python.org/pep-0646/#aliases):
```python
fr... | 2023-05-10T23:01:50Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-typevar-tuple.test::testTypeVarTupleIsNotValidAliasTarget",
"mypy/test/testcheck.py::TypeCheckSuite::check-typevar-tuple.test::testTypeVarTupleGenericClassWithFunctions",
"mypy/test/testcheck.py::TypeCheckSuite::check-typevar-tuple.test::testTypeVarTupleBasic",
"... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-typevar-tuple.test::testVariadicAliasBasicCallable",
"mypy/test/testcheck.py::TypeCheckSuite::check-typevar-tuple.test::testVariadicAliasBasicTuple",
"mypy/test/testcheck.py::TypeCheckSuite::check-typevar-tuple.test::testVariadicAliasBasicInstance",
"mypy/test/te... | Python | [] | [] | |
python/mypy | 15,297 | python__mypy-15297 | [
"15296"
] | 781dc8f82adacce730293479517fd0fb5944c255 | diff --git a/mypy/semanal.py b/mypy/semanal.py
--- a/mypy/semanal.py
+++ b/mypy/semanal.py
@@ -1008,7 +1008,21 @@ def is_expected_self_type(self, typ: Type, is_classmethod: bool) -> bool:
return self.is_expected_self_type(typ.item, is_classmethod=False)
if isinstance(typ, UnboundType):
... | diff --git a/test-data/unit/check-selftype.test b/test-data/unit/check-selftype.test
--- a/test-data/unit/check-selftype.test
+++ b/test-data/unit/check-selftype.test
@@ -1665,6 +1665,23 @@ class C:
return cls()
[builtins fixtures/classmethod.pyi]
+[case testTypingSelfRedundantAllowed_pep585]
+# flags: --py... | Incomplete handling of PEP 585, difference between typing.Type[...] and builtins.type[...]
**Bug Report**
Incomplete implementation of PEP 585. There are cases where explicit annotations of the first argument of class methods (or `__new__`) are handled correctly for `typing.Type[...]` but *not* for `builtins.type[..... | 2023-05-24T13:39:18Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testSelfTypeInstance",
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testSelfTypeClone",
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testSelfTypeProperSupertypeAttribute",
"mypy/test/testcheck.py::TypeCheckSuite::c... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testTypingSelfRedundantAllowed_pep585",
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testTypingSelfRedundantWarning_pep585"
] | Python | [] | [] | |
python/mypy | 15,327 | python__mypy-15327 | [
"15255"
] | 85e6719691ffe85be55492c948ce6c66cd3fd8a0 | diff --git a/mypy/errorcodes.py b/mypy/errorcodes.py
--- a/mypy/errorcodes.py
+++ b/mypy/errorcodes.py
@@ -14,7 +14,7 @@
sub_code_map: dict[str, set[str]] = defaultdict(set)
-@mypyc_attr(serializable=True)
+@mypyc_attr(allow_interpreted_subclasses=True)
class ErrorCode:
def __init__(
self,
diff --gi... | diff --git a/test-data/unit/check-custom-plugin.test b/test-data/unit/check-custom-plugin.test
--- a/test-data/unit/check-custom-plugin.test
+++ b/test-data/unit/check-custom-plugin.test
@@ -1014,3 +1014,15 @@ reveal_type(MyClass.foo_staticmethod) # N: Revealed type is "def (builtins.int)
[file mypy.ini]
\[mypy]
pl... | Crash with custom plugin and `ErrorCode`
**Crash Report**
Cross posting it here for better visibility. The original post: https://github.com/python/mypy/pull/15218#issuecomment-1545670500
The crash / regression (in dev) is caused by the change in #15218.
The example below is with a custom plugin. However this does... | 2023-05-30T21:26:31Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-custom-plugin.test::testFunctionPluginPyProjectTOML",
"mypy/test/testcheck.py::TypeCheckSuite::check-custom-plugin.test::testFunctionPluginFile",
"mypy/test/testcheck.py::TypeCheckSuite::check-custom-plugin.test::testTwoPluginsMixedTypePyProjectTOML",
"mypy/test/... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-custom-plugin.test::testCustomErrorCodePlugin"
] | Python | [] | [] | |
python/mypy | 15,347 | python__mypy-15347 | [
"15343"
] | 78339b97dc911c8c6841184eaddbbc30d0e406da | diff --git a/mypy/build.py b/mypy/build.py
--- a/mypy/build.py
+++ b/mypy/build.py
@@ -55,7 +55,6 @@
DecodeError,
decode_python_encoding,
get_mypy_comments,
- get_top_two_prefixes,
hash_digest,
is_stub_package_file,
is_sub_path,
@@ -91,12 +90,7 @@
from mypy.plugins.default import Defau... | diff --git a/test-data/unit/check-modules.test b/test-data/unit/check-modules.test
--- a/test-data/unit/check-modules.test
+++ b/test-data/unit/check-modules.test
@@ -3121,26 +3121,28 @@ import google.cloud
from google.cloud import x
[case testErrorFromGoogleCloud]
-import google.cloud
+import google.cloud # E: Ca... | types-google-cloud-ndb is recommended incorrectly
**Bug Report**
this stub package only provides the `google.cloud.ndb.*` namespace -- however it is suggested for any missing google import
**To Reproduce**
```python
from google.cloud.exceptions import NotFound
```
**Expected Behavior**
it should not ... | 2023-06-01T21:35:47Z | 1.6 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-modules.test::testAccessingUnknownModuleFromOtherModule",
"mypy/test/testcheck.py::TypeCheckSuite::check-modules.test::testConditionalFunctionDefinitionAndImports",
"mypy/test/testcheck.py::TypeCheckSuite::check-modules.test::testAccessImportedDefinitions0",
"myp... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-modules.test::testErrorFromGoogleCloud",
"mypy/test/testcheck.py::TypeCheckSuite::check-modules.test::testMissingSubmoduleOfInstalledStubPackage"
] | Python | [] | [] | |
python/mypy | 15,353 | python__mypy-15353 | [
"15080"
] | 781dc8f82adacce730293479517fd0fb5944c255 | diff --git a/mypy/checker.py b/mypy/checker.py
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -1164,11 +1164,10 @@ def check_func_def(
isinstance(defn, FuncDef)
and ref_type is not None
and i == 0
- and not defn.is_static
... | diff --git a/test-data/unit/check-selftype.test b/test-data/unit/check-selftype.test
--- a/test-data/unit/check-selftype.test
+++ b/test-data/unit/check-selftype.test
@@ -509,6 +509,58 @@ class E:
def __init_subclass__(cls) -> None:
reveal_type(cls) # N: Revealed type is "Type[__main__.E]"
+[case testS... | Quirk with @staticmethod decorator on __new__
**Bug Report**
(To be fair, this might be a slight quirk in PEP 673 rather than a bug mypy's implementation).
Certain dunderscored methods are implicitly static, such as `__new__`. Personally, I prefer to be explicit and so I would like to decorate such methods with `... | 2023-06-02T13:41:45Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testSelfTypeInstance",
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testSelfTypeOverrideCompatibilityGeneric",
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testSelfTypePropertyUnion",
"mypy/test/testcheck.py::TypeC... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-selftype.test::testSelfTypeNew_explicit"
] | Python | [] | [] | |
python/mypy | 15,366 | python__mypy-15366 | [
"15264"
] | 21c5439dccfc6fc21f126200b95b0552f503d5da | diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
--- a/mypy/checkexpr.py
+++ b/mypy/checkexpr.py
@@ -2166,15 +2166,7 @@ def check_arg(
if isinstance(caller_type, DeletedType):
self.msg.deleted_as_rvalue(caller_type, context)
# Only non-abstract non-protocol class can be given where Type... | diff --git a/test-data/unit/check-abstract.test b/test-data/unit/check-abstract.test
--- a/test-data/unit/check-abstract.test
+++ b/test-data/unit/check-abstract.test
@@ -196,6 +196,24 @@ x: Type[B]
f(x) # OK
[out]
+[case testAbstractTypeInADict]
+from typing import Dict, Type
+from abc import abstractmethod
+
+cl... | False-negative `type-abstract` in dictionary initialization
**Bug Report**
`type-abstract` is falsely missing when initializing a dictionary.
**To Reproduce**
```python
"""False-negative `type-abstract`."""
from abc import abstractmethod
class Class:
@abstractmethod
def method(self) -> None:
... | 2023-06-04T07:41:59Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testInstantiatingClassThatImplementsAbstractMethod",
"mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testImplementingAbstractMethodWithMultipleBaseClasses",
"mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testInstantiation... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testAbstractTypeInADict"
] | Python | [] | [
"https://mypy-play.net/?mypy=latest&python=3.11&gist=2f58d30cce7e6ddadfc2b0f28ef68395"
] | |
python/mypy | 15,392 | python__mypy-15392 | [
"15389"
] | fe0714acc7d890fe0331054065199097076f356e | diff --git a/mypy/messages.py b/mypy/messages.py
--- a/mypy/messages.py
+++ b/mypy/messages.py
@@ -2989,8 +2989,9 @@ def _real_quick_ratio(a: str, b: str) -> float:
def best_matches(current: str, options: Collection[str], n: int) -> list[str]:
+ if not current:
+ return []
# narrow down options chea... | diff --git a/test-data/unit/check-typeddict.test b/test-data/unit/check-typeddict.test
--- a/test-data/unit/check-typeddict.test
+++ b/test-data/unit/check-typeddict.test
@@ -2873,3 +2873,15 @@ foo({"foo": {"e": "foo"}}) # E: Type of TypedDict is ambiguous, none of ("A", "
# E: Argument 1 ... | Accessing null key in TypedDict cause an internal error
The last line of the following code, d[''], attempts to access an empty key. However, since the key is empty (''), it should raise a KeyError with Python because empty keys are not defined in the A class. Mypy reports an internal error.
mypy_example.py
```
... | 2023-06-08T04:33:41Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-typeddict.test::testCannotCreateTypedDictWithDuplicateKey2",
"mypy/test/testcheck.py::TypeCheckSuite::check-typeddict.test::testTypedDictAcceptsIntForFloatDuckTypes",
"mypy/test/testcheck.py::TypeCheckSuite::check-typeddict.test::testCanCreateTypedDictWithSubclass2... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-typeddict.test::testTypedDictMissingEmptyKey"
] | Python | [] | [] | |
python/mypy | 15,395 | python__mypy-15395 | [
"4165"
] | f54c3096b7d328dc59dd85af3a8ba28739dcfed0 | diff --git a/mypy/semanal.py b/mypy/semanal.py
--- a/mypy/semanal.py
+++ b/mypy/semanal.py
@@ -1337,6 +1337,8 @@ def analyze_property_with_multi_part_definition(self, defn: OverloadedFuncDef) -
first_item.var.is_settable_property = True
# Get abstractness from t... | diff --git a/test-data/unit/check-abstract.test b/test-data/unit/check-abstract.test
--- a/test-data/unit/check-abstract.test
+++ b/test-data/unit/check-abstract.test
@@ -735,7 +735,44 @@ class A(metaclass=ABCMeta):
def x(self) -> int: pass
@x.setter
def x(self, x: int) -> None: pass
-[out]
+
+[case test... | Abstract Properties & `Overloaded method has both abstract and non-abstract variants`
# Expected Behaviour
- Ability to type check abstract property `getters` and `setters`
- The intention is to have an interface-like design using properties
# Actual Behaviour & Repro Case
## Python Code
```python
from abc impo... | It seems that version 0.750 still have this bug. Do you have any ideas how to solve it?
~~`py-evm` uses [this workaround](https://github.com/ethereum/py-evm/pull/1885/commits/0d79bb6c56f4835ef9242cbad18a51ef86e77011) for now.~~
Here's a link that works to the py-evm workaround:
https://github.com/ethereum/py-evm/blo... | 2023-06-08T20:16:28Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testInstantiatingClassThatImplementsAbstractMethod",
"mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testImplementingAbstractMethodWithExtension",
"mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testInstantiationAbstractsI... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testReadWriteDeleteAbstractProperty"
] | Python | [] | [] |
python/mypy | 15,402 | python__mypy-15402 | [
"15351"
] | 4baf672a8fe19bb78bcb99ec706e3aa0f7c8605c | diff --git a/mypy/typeops.py b/mypy/typeops.py
--- a/mypy/typeops.py
+++ b/mypy/typeops.py
@@ -76,12 +76,18 @@ def is_recursive_pair(s: Type, t: Type) -> bool:
isinstance(get_proper_type(t), (Instance, UnionType))
or isinstance(t, TypeAliasType)
and t.is_recursive
+ # T... | diff --git a/test-data/unit/check-recursive-types.test b/test-data/unit/check-recursive-types.test
--- a/test-data/unit/check-recursive-types.test
+++ b/test-data/unit/check-recursive-types.test
@@ -937,3 +937,12 @@ x: A[int, str]
if last is not None:
reveal_type(last) # N: Revealed type is "Tuple[builtins.int, ... | Segfault/RecursionError when using tuple, one item literal and self-referencing type
**Crash Report**
When creating self referencing `NotFilter = tuple[Literal["not"], "NotFilter"]` mypy crashes (segfault on 1.3.0 or max recursion depth on master) if first item in tuple is `Literal` with one item.
It works for a... | Hmm out of curiosity I tried more "real" example
```python
from typing import Literal, Any, TypeAlias
Filter: TypeAlias = "EqFilter" | "NotFilter"
EqFilter: TypeAlias = tuple[Literal["="], str, Any]
NotFilter: TypeAlias = tuple[Literal["not"], Filter]
```
If fails (segfault) on 1.3.0 but passes on master... | 2023-06-09T09:22:05Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveAliasImported",
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveAliasViaBaseClass2",
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveAliasBasic",
"mypy/test/tes... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveAliasLiteral"
] | Python | [] | [
"https://mypy-play.net/?mypy=master&python=3.11&flags=show-traceback&gist=a94f47abe57191f27391b5d961ead067"
] |
python/mypy | 15,403 | python__mypy-15403 | [
"15378"
] | 4baf672a8fe19bb78bcb99ec706e3aa0f7c8605c | diff --git a/mypy/semanal.py b/mypy/semanal.py
--- a/mypy/semanal.py
+++ b/mypy/semanal.py
@@ -375,7 +375,7 @@ class SemanticAnalyzer(
missing_names: list[set[str]]
# Callbacks that will be called after semantic analysis to tweak things.
patches: list[tuple[int, Callable[[], None]]]
- loop_depth = 0 ... | diff --git a/test-data/unit/check-statements.test b/test-data/unit/check-statements.test
--- a/test-data/unit/check-statements.test
+++ b/test-data/unit/check-statements.test
@@ -2212,3 +2212,17 @@ main:1: error: Module "typing" has no attribute "_FutureFeatureFixture"
main:1: note: Use `from typing_extensions import ... | 'break' in nested function causes an internal error
The following example presents a nest function definition. In the inner function, this code uses the 'break' keywords, Mypy reports an internal error.
example.py
```
def foo():
for x in range(10):
def inner():
break
```
### The expec... | 2023-06-09T10:32:11Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-statements.test::testIfStatement",
"mypy/test/testcheck.py::TypeCheckSuite::check-statements.test::testReturnValue",
"mypy/test/testcheck.py::TypeCheckSuite::check-statements.test::testRaiseClassObjectCustomInit",
"mypy/test/testcheck.py::TypeCheckSuite::check-st... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-statements.test::testNoCrashOnBreakOutsideLoopFunction",
"mypy/test/testcheck.py::TypeCheckSuite::check-statements.test::testNoCrashOnBreakOutsideLoopClass"
] | Python | [] | [] | |
python/mypy | 15,407 | python__mypy-15407 | [
"15246",
"15319"
] | 3cedd2725c9e8f6ec3dac5e72bf65bddbfccce4c | diff --git a/mypy/build.py b/mypy/build.py
--- a/mypy/build.py
+++ b/mypy/build.py
@@ -116,7 +116,10 @@
"types",
"typing_extensions",
"mypy_extensions",
- "_importlib_modulespec",
+ "_typeshed",
+ "_collections_abc",
+ "collections",
+ "collections.abc",
"sys",
"abc",
}
@@ -659,... | diff --git a/test-data/unit/check-flags.test b/test-data/unit/check-flags.test
--- a/test-data/unit/check-flags.test
+++ b/test-data/unit/check-flags.test
@@ -2174,3 +2174,13 @@ def f(x: bytes, y: bytearray, z: memoryview) -> None:
x in y
x in z
[builtins fixtures/primitives.pyi]
+
+[case testNoCrashFollowIm... | Mypy 1.3.0 crashes when using dictionary unpacking
**Crash Report**
Mypy 1.3.0 crashes with an internal error when it encounters dictionary unpacking, e.g. `**mydict`.
**Traceback**
From `1.3.0`:
```
mypy_unpacking_crash.py:7: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.r... | Simpler repro: run mypy on this snippet:
```py
from typing import Any
def get_annotations(cls: type) -> dict[str, Any]:
"""Return a dict of all annotations for a class and its parents."""
annotations: dict[str, Any] = {}
for ancestor in cls.__mro__:
annotations = {**annotations, **getattr... | 2023-06-09T21:21:04Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testUnannotatedFunction",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testPerFileIncompleteDefsBasicPyProjectTOML",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testDisallowUntypedDecoratorsCallableInstance",
"mypy/test/te... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testNoCrashFollowImportsForStubs"
] | Python | [] | [] |
python/mypy | 15,413 | python__mypy-15413 | [
"9656"
] | e7b917ec7532206b996542570f4b68a33c3ff771 | diff --git a/mypy/checker.py b/mypy/checker.py
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -4270,6 +4270,7 @@ def check_return_stmt(self, s: ReturnStmt) -> None:
isinstance(return_type, Instance)
and return_type.type.fullname == "builtins.object"
... | diff --git a/test-data/unit/check-flags.test b/test-data/unit/check-flags.test
--- a/test-data/unit/check-flags.test
+++ b/test-data/unit/check-flags.test
@@ -2184,3 +2184,14 @@ def f(x: bytes, y: bytearray, z: memoryview) -> None:
follow_imports = skip
follow_imports_for_stubs = true
[builtins fixtures/dict.pyi]
+
... | Warn Return Any now applies to small lambdas
**Bug Report**
Suppose we have the follow code:
```python
from typing import Any
x: Any = [1, 2, 3]
sorted([0, 2, 1], key=lambda i: x[i])
```
With `mypy 0.790`, I get an error:
```
$ mypy --warn-return-any scratch.py
scratch.py:4: error: Returning Any from fu... | Thanks for posting your repro! The thing that's changed between 0.782 and 0.790 is the definition of `sorted`. `key` used to be a function that returned `Any`, but is now marked as a function that returns a `SupportsLessThan`.
This makes it similar to #9590 where itertools.groupby takes a function that returns a typev... | 2023-06-11T11:27:21Z | 1.4 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testUnannotatedFunction",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testSubclassingAnyMultipleBaseClasses",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testUnannotatedArgument",
"mypy/test/testcheck.py::TypeCheckSuite::... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testReturnAnyLambda"
] | Python | [] | [] |
python/mypy | 15,425 | python__mypy-15425 | [
"6462"
] | efe84d492bd77f20c777b523f2e681d1f83f7ac4 | diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
--- a/mypy/checkexpr.py
+++ b/mypy/checkexpr.py
@@ -4,8 +4,9 @@
import itertools
import time
+from collections import defaultdict
from contextlib import contextmanager
-from typing import Callable, ClassVar, Iterator, List, Optional, Sequence, cast
+from typing im... | diff --git a/test-data/unit/check-parameter-specification.test b/test-data/unit/check-parameter-specification.test
--- a/test-data/unit/check-parameter-specification.test
+++ b/test-data/unit/check-parameter-specification.test
@@ -570,7 +570,7 @@ reveal_type(f(n)) # N: Revealed type is "def (builtins.int, builtins.byt... | TypedDict update() does not accept TypedDict with compatible subset keys
```
from mypy_extensions import TypedDict
A = TypedDict(
'A', {
'foo': int,
'bar': int,
}
)
B = TypedDict(
'B', {
'foo': int,
}
)
a = A({'foo': 1, 'bar': 2})
b = B({'foo': 2})
a.update({... | This is a pretty subtle issue. The `update` call is arguably not type safe. In a more complex program, the argument could be a value of a subtype of `B` that has the key `'bar'` with a list value, for example. This would break type safety, as `a['bar']` would be a list instead of an integer.
However, the same reaso... | 2023-06-12T23:53:49Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-parameter-specification.test::testUnboundParamSpec",
"mypy/test/testcheck.py::TypeCheckSuite::check-parameter-specification.test::testBasicParamSpec",
"mypy/test/testcheck.py::TypeCheckSuite::check-parameter-specification.test::testParamSpecClassWithAny",
"mypy/t... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-parameter-specification.test::testParamSpecConcatenateNamedArgs",
"mypy/test/testcheck.py::TypeCheckSuite::check-typeddict.test::testTypedDictStrictUpdate",
"mypy/test/testcheck.py::TypeCheckSuite::check-typeddict.test::testTypedDictFlexibleUpdateUnionExtra",
"my... | Python | [] | [] |
python/mypy | 15,449 | python__mypy-15449 | [
"7186"
] | 4012c50382641aa4a15fcb7155f281469bc7a5fa | diff --git a/mypy/errors.py b/mypy/errors.py
--- a/mypy/errors.py
+++ b/mypy/errors.py
@@ -20,8 +20,27 @@
# Show error codes for some note-level messages (these usually appear alone
# and not as a comment for a previous error-level message).
SHOW_NOTE_CODES: Final = {codes.ANNOTATION_UNCHECKED}
+
+# Do not add notes... | diff --git a/test-data/unit/check-flags.test b/test-data/unit/check-flags.test
--- a/test-data/unit/check-flags.test
+++ b/test-data/unit/check-flags.test
@@ -2195,3 +2195,18 @@ cb(lambda x: a) # OK
fn = lambda x: a
cb(fn)
+
+[case testShowErrorCodeLinks]
+# flags: --show-error-codes --show-error-code-links
+
+x: ... | Add static links for error codes
It would be great to provide a link with a bit more detailed explanation for every error code. For example:
```
main.py:10: error [bad_variance]: Invariant type variable 'T' used in protocol where covariant one is expected
main.py:10: note: See https://mypy-lang.org/error/bad_varianc... | I want to work on this issue. can you tell me where are these errors messages.
@Shivansh-khare you can grep for them in source code, most of them (maybe all?) appear in `messages.py` I think.
@JelleZijlstra Can I hard code it with msg variable or add error_note_function for every error msg as done with incompatible_arg... | 2023-06-15T22:15:09Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testSubclassingAnyMultipleBaseClasses",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testUnannotatedFunction",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testAsyncUnannotatedReturn",
"mypy/test/testcheck.py::TypeCheckSuit... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testShowErrorCodeLinks"
] | Python | [] | [] |
python/mypy | 15,490 | python__mypy-15490 | [
"11886",
"11013"
] | 304997bfb85200fb521ac727ee0ce3e6085e5278 | diff --git a/mypy/nodes.py b/mypy/nodes.py
--- a/mypy/nodes.py
+++ b/mypy/nodes.py
@@ -2801,6 +2801,25 @@ def accept(self, visitor: ExpressionVisitor[T]) -> T:
return visitor.visit_temp_node(self)
+# Special attributes not collected as protocol members by Python 3.12
+# See typing._SPECIAL_NAMES
+EXCLUDED_... | diff --git a/test-data/unit/check-protocols.test b/test-data/unit/check-protocols.test
--- a/test-data/unit/check-protocols.test
+++ b/test-data/unit/check-protocols.test
@@ -2789,6 +2789,70 @@ class A(Protocol):
[builtins fixtures/tuple.pyi]
+[case testProtocolSlotsIsNotProtocolMember]
+# https://github.com/pytho... | Should `__class_getitem__` be considered part of the interface of Protocol classes?
In https://github.com/python/typeshed/pull/5869, `__class_getitem__` was added to the stub for `os.PathLike`. The method exists on the class at runtime; however, the addition of the method caused regressions in mypy 0.920. `PathLike` is... | How it works right now:
```python
from typing import Protocol, runtime_checkable
@runtime_checkable
class ClassGetItem(Protocol):
def __class_getitem__(cls, val) -> object: # or `types.GenericAlias`
pass
class Example:
pass
def func(klass: ClassGetItem):
pass
print(issubclass(E... | 2023-06-21T19:04:27Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-protocols.test::testCannotInstantiateProtocol",
"mypy/test/testcheck.py::TypeCheckSuite::check-protocols.test::testIndependentProtocolSubtyping",
"mypy/test/testcheck.py::TypeCheckSuite::check-protocols.test::testProtocolVarianceWithCallableAndList",
"mypy/test/t... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-protocols.test::testProtocolSlotsAndRuntimeCheckable",
"mypy/test/testcheck.py::TypeCheckSuite::check-protocols.test::testProtocolWithClassGetItem",
"mypy/test/testcheck.py::TypeCheckSuite::check-protocols.test::testProtocolSlotsIsNotProtocolMember"
] | Python | [] | [] |
python/mypy | 15,491 | python__mypy-15491 | [
"15489"
] | 7d031beb017450ac990c97e288d064290e3be55f | diff --git a/mypy/fastparse.py b/mypy/fastparse.py
--- a/mypy/fastparse.py
+++ b/mypy/fastparse.py
@@ -521,7 +521,14 @@ def translate_stmt_list(
return [block]
stack = self.class_and_function_stack
- if self.strip_function_bodies and len(stack) == 1 and stack[0] == "F":
+ # Fast ca... | diff --git a/test-data/unit/check-async-await.test b/test-data/unit/check-async-await.test
--- a/test-data/unit/check-async-await.test
+++ b/test-data/unit/check-async-await.test
@@ -945,17 +945,21 @@ async def bar(x: Union[A, B]) -> None:
[typing fixtures/typing-async.pyi]
[case testAsyncIteratorWithIgnoredErrors]... | [1.4] Regression with AsyncGenerator
**Bug Report**
I can't seem to find a minimal reproducer, but whenever using watchfiles.awatch(), mypy produces the error:
`error: "Coroutine[Any, Any, AsyncGenerator[set[tuple[Change, str]], None]]" has no attribute "__aiter__" (not async iterable) [attr-defined]`
As can be... | Source code is just annotated with `AsyncGenerator`:
https://github.com/samuelcolvin/watchfiles/blob/main/watchfiles/main.py#L137
Hmmm I wonder if related to #14150
Yeah, I think so, cc @JukkaL (btw, thanks again for the change, it's a huge perf win for various codebases at work)
```
λ cat main.py
from third_part... | 2023-06-21T21:28:15Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-async-await.test::testAsyncDefReturnWithoutValue",
"mypy/test/testcheck.py::TypeCheckSuite::check-async-await.test::testAsyncDefPass",
"mypy/test/testcheck.py::TypeCheckSuite::check-async-await.test::testAwaitIteratorError",
"mypy/test/testcheck.py::TypeCheckSuit... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-async-await.test::testAsyncIteratorWithIgnoredErrors"
] | Python | [] | [] |
python/mypy | 15,506 | python__mypy-15506 | [
"15496"
] | 2d8ad8ef240df262be80d9359e9f5892ea1f9ad3 | diff --git a/mypy/checkpattern.py b/mypy/checkpattern.py
--- a/mypy/checkpattern.py
+++ b/mypy/checkpattern.py
@@ -468,7 +468,7 @@ def visit_class_pattern(self, o: ClassPattern) -> PatternType:
name = type_info.type.str_with_options(self.options)
else:
name = type_info.nam... | diff --git a/test-data/unit/check-python310.test b/test-data/unit/check-python310.test
--- a/test-data/unit/check-python310.test
+++ b/test-data/unit/check-python310.test
@@ -1958,3 +1958,23 @@ def redefinition_bad(a: int):
...
[builtins fixtures/primitives.pyi]
+
+[case testPatternMatchingClassPatternL... | error: Expected type in class pattern; found "Any" (cannot be ignored, error without line number)
Found a strange bug today: https://mypy-play.net/?mypy=master&python=3.11&gist=5069b99b248041428036a717e52a3476
```python
from pandas import DataFrame, Series
from typing import TypeVar
T = TypeVar("T", Series, Dat... | 2023-06-23T13:37:47Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchSequencePatternAlreadyNarrowerBoth",
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchValuePatternUnreachable",
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchCapturePatternType",
"mypy/test... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testPatternMatchingClassPatternLocation"
] | Python | [] | [
"https://mypy-play.net/?mypy=master&python=3.11&gist=5069b99b248041428036a717e52a3476"
] | |
python/mypy | 15,629 | python__mypy-15629 | [
"15618"
] | ebfea94c9f1dc081f8f3f0de9e78a5c83ff8af40 | diff --git a/mypy/checker.py b/mypy/checker.py
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -1194,9 +1194,10 @@ def check_func_def(
elif isinstance(arg_type, TypeVarType):
# Refuse covariant parameter type variables
# TODO: check recursively for i... | diff --git a/test-data/unit/check-dataclasses.test b/test-data/unit/check-dataclasses.test
--- a/test-data/unit/check-dataclasses.test
+++ b/test-data/unit/check-dataclasses.test
@@ -744,6 +744,17 @@ s: str = a.bar() # E: Incompatible types in assignment (expression has type "in
[builtins fixtures/dataclasses.pyi]
... | Crash when iterating a Tuple list of @dataclass Protocol
<!--
Use this form only if mypy reports an "INTERNAL ERROR" and/or gives a traceback.
Please include the traceback and all other messages below (use `mypy --show-traceback`).
-->
**Crash Report**
MyPy crashes when trying to validate a code bit enumer... | This is a valid crash report (since mypy should never crash on syntactically valid Python code). But the quick fix is "don't do that" — it doesn't really make much sense to add `@dataclass` to a protocol :)
> This is a valid crash report (since mypy should never crash on syntactically valid Python code). But the quick ... | 2023-07-09T12:01:10Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesBasic",
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassUntypedGenericInheritance",
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesFields",
"mypy/test/testcheck.py::Ty... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testProtocolNoCrashOnJoining",
"mypy/test/testdeps.py::GetDependenciesSuite::deps.test::testDataclassDepsOldVersion",
"mypy/test/testdeps.py::GetDependenciesSuite::deps.test::testDataclassDeps"
] | Python | [] | [] |
python/mypy | 15,642 | python__mypy-15642 | [
"15639"
] | 67cc05926b037243b71e857a394318c3a09d1daf | diff --git a/mypy/plugins/attrs.py b/mypy/plugins/attrs.py
--- a/mypy/plugins/attrs.py
+++ b/mypy/plugins/attrs.py
@@ -294,6 +294,7 @@ def attr_class_maker_callback(
ctx: mypy.plugin.ClassDefContext,
auto_attribs_default: bool | None = False,
frozen_default: bool = False,
+ slots_default: bool = False... | diff --git a/test-data/unit/check-plugin-attrs.test b/test-data/unit/check-plugin-attrs.test
--- a/test-data/unit/check-plugin-attrs.test
+++ b/test-data/unit/check-plugin-attrs.test
@@ -1631,6 +1631,24 @@ reveal_type(A.__attrs_init__) # N: Revealed type is "def (self: __main__.A, b:
[case testAttrsClassWithSlots]
i... | Better support for default arguments to new-style attrs API
**Bug Report**
attrs.define has `slots=True` by default. Mypy does not use the default value when analysing
**To Reproduce**
```python
# demo.py
import attr
@attr.define
class A:
x: int
def __init__(self, x :int) -> None:
self.x = ... | 2023-07-12T05:30:57Z | 1.5 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsCmpEqOrderValues",
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsNextGenDetect",
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsDefaultErrors",
"mypy/test/testcheck.py::TypeCheck... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsClassWithSlots"
] | Python | [] | [] | |
python/mypy | 15,700 | python__mypy-15700 | [
"15658"
] | b6b6624655826985f75dfd970e2c29f7690ce323 | diff --git a/mypy/plugins/attrs.py b/mypy/plugins/attrs.py
--- a/mypy/plugins/attrs.py
+++ b/mypy/plugins/attrs.py
@@ -803,7 +803,7 @@ def _make_frozen(ctx: mypy.plugin.ClassDefContext, attributes: list[Attribute])
else:
# This variable belongs to a super class so create new Var so we
... | diff --git a/test-data/unit/check-plugin-attrs.test b/test-data/unit/check-plugin-attrs.test
--- a/test-data/unit/check-plugin-attrs.test
+++ b/test-data/unit/check-plugin-attrs.test
@@ -2250,3 +2250,27 @@ c = attrs.assoc(c, name=42) # E: Argument "name" to "assoc" of "C" has incompat
[builtins fixtures/plugin_attr... | Mypy errors out with attrs, generics and inheritance
<!--
If you're not sure whether what you're experiencing is a mypy bug, please see the "Question and Help" form instead.
Please consider:
- checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html
- searching our issue tracker: ... | Thanks for the version range. `git bisect` points to 20b0b9b460cd11a4755f70ae08823fa6a8f5fbd4 (merged in #12590) as to where it starts (@JukkaL for insights).
FWIW, replacing `attr.frozen` with `attrs.mutable` or `attrs.define` also "fixes" it 😕 | 2023-07-18T05:28:52Z | 1.6 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsCmpEqOrderValues",
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsNextGenDetect",
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsDefaultErrors",
"mypy/test/testcheck.py::TypeCheck... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testFrozenInheritFromGeneric"
] | Python | [] | [] |
python/mypy | 15,722 | python__mypy-15722 | [
"15345"
] | d2022a0007c0eb176ccaf37a9aa54c958be7fb10 | diff --git a/mypy/binder.py b/mypy/binder.py
--- a/mypy/binder.py
+++ b/mypy/binder.py
@@ -42,13 +42,6 @@ def __init__(self, id: int, conditional_frame: bool = False) -> None:
self.types: dict[Key, Type] = {}
self.unreachable = False
self.conditional_frame = conditional_frame
-
- # Sho... | diff --git a/test-data/unit/check-unreachable-code.test b/test-data/unit/check-unreachable-code.test
--- a/test-data/unit/check-unreachable-code.test
+++ b/test-data/unit/check-unreachable-code.test
@@ -1446,3 +1446,19 @@ def f() -> None:
Foo()['a'] = 'a'
x = 0 # This should not be reported as unreachable
[b... | intentionally empty generator marked as unreachable
<!--
If you're not sure whether what you're experiencing is a mypy bug, please see the "Question and Help" form instead.
Please consider:
- checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html
- searching our issue tracker: h... | Uum... I couldn't reproduce this bug.
- mypy: 1.3.0
- with `--warn-unreachable` flag
- w/o `mypy.ini`
- python 3.10.5
```bash
❯ mypy --warn-unreachable t.py
Success: no issues found in 1 source file
❯ cat t.py
from typing import Generator
def f() -> Generator[None, None, None]:
yield from ()
... | 2023-07-20T03:01:49Z | 1.6 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-unreachable-code.test::testUnreachabilityAndElifPY3",
"mypy/test/testcheck.py::TypeCheckSuite::check-unreachable-code.test::testTypeCheckingConditional",
"mypy/test/testcheck.py::TypeCheckSuite::check-unreachable-code.test::testConditionalTypeAliasPY3",
"mypy/tes... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-unreachable-code.test::testIntentionallyEmptyGeneratorFunction_None",
"mypy/test/testcheck.py::TypeCheckSuite::check-unreachable-code.test::testIntentionallyEmptyGeneratorFunction"
] | Python | [] | [] |
python/mypy | 15,845 | python__mypy-15845 | [
"10757"
] | cfd01d9f7fdceb5eb8e367e8f1a6a1efb5ede38c | diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
--- a/mypy/checkexpr.py
+++ b/mypy/checkexpr.py
@@ -529,13 +529,6 @@ def visit_call_expr_inner(self, e: CallExpr, allow_none_return: bool = False) ->
callee_type = get_proper_type(
self.accept(e.callee, type_context, always_allow_any=True, is_call... | diff --git a/test-data/unit/check-flags.test b/test-data/unit/check-flags.test
--- a/test-data/unit/check-flags.test
+++ b/test-data/unit/check-flags.test
@@ -2077,6 +2077,61 @@ y = 1
f(reveal_type(y)) # E: Call to untyped function "f" in typed context \
# N: Revealed type is "builtins.int"
+[case... | disallow_untyped_calls in module does not override global section
**Bug Report**
Since updating numpy from version "1.20.3" to version "1.21.0" we are getting the following errors:
`error: Call to untyped function "load" in typed context`
We want to suppress errors about untyped calls from numpy - but not glob... | I am affected by the same problem, using these versions:
`Python 3.9.5`
```
mypy==0.910
mypy-extensions==0.4.3
numpy==1.21.1
pkg_resources==0.0.0
toml==0.10.2
typing-extensions==3.10.0.0
```
I am affected by the same problem. Any progress on this?
As an additional data point: I have the same problem (with se... | 2023-08-10T20:53:10Z | 1.6 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testUnannotatedFunction",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testSubclassingAnyMultipleBaseClasses",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testAsyncUnannotatedReturn",
"mypy/test/testcheck.py::TypeCheckSuit... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testDisallowUntypedCallsAllowListFlags",
"mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testDisallowUntypedCallsAllowListConfig"
] | Python | [] | [] |
python/mypy | 15,882 | python__mypy-15882 | [
"12534",
"15878"
] | 14418bc3d2c38b9ea776da6029e9d9dc6650b7ea | diff --git a/mypy/checker.py b/mypy/checker.py
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -4944,7 +4944,7 @@ def visit_match_stmt(self, s: MatchStmt) -> None:
self.push_type_map(pattern_map)
self.push_type_map(pattern_type.captures)
if g is not ... | diff --git a/test-data/unit/check-python310.test b/test-data/unit/check-python310.test
--- a/test-data/unit/check-python310.test
+++ b/test-data/unit/check-python310.test
@@ -1372,7 +1372,7 @@ match m:
reveal_type(m) # N: Revealed type is "__main__.Medal"
[case testMatchNarrowUsingPatternGuardSpecialCase]
... | Guard clause prevents `match` from seeing that all paths return
**Bug Report**
In a `match` statement in which all `case`s include a return statement, _mypy_ 0.942 falsely reports "Missing return statement [return]" if at least one `case` includes a guard clause.
**To Reproduce**
```
def func(e) -> int:
... | 2023-08-16T03:03:10Z | 1.6 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchCapturePatternType",
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchSequencePatternAlreadyNarrowerBoth",
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchValuePatternUnreachable",
"mypy/test... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchNarrowUsingPatternGuardSpecialCase",
"mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchGuardReachability"
] | Python | [] | [
"https://mypy-play.net/?mypy=1.5.0&python=3.11&gist=122ad20737777670f775c802a36251d9"
] | |
python/mypy | 15,920 | python__mypy-15920 | [
"15851"
] | 2c1fd97986064161c542956bb3d9d5043dc0a480 | diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
--- a/mypy/checkexpr.py
+++ b/mypy/checkexpr.py
@@ -4271,6 +4271,9 @@ def visit_assert_type_expr(self, expr: AssertTypeExpr) -> Type:
allow_none_return=True,
always_allow_any=True,
)
+ if self.chk.current_node_deferred:
+ ... | diff --git a/test-data/unit/check-expressions.test b/test-data/unit/check-expressions.test
--- a/test-data/unit/check-expressions.test
+++ b/test-data/unit/check-expressions.test
@@ -1045,6 +1045,23 @@ def reduce_it(s: Scalar) -> Scalar:
assert_type(reduce_it(True), Scalar)
[builtins fixtures/tuple.pyi]
+[case test... | false positive: `functools.lru_cache()` breaks `assert_type(..., SomeEnum)`
**Bug Report**
Interactions between `@functools.lru_cache` and `Enum`s confuse `assert_type()`, resulting in a false positives.
Return values from functions which are decorated by `functools.lru_cache()` and have return type `SomeEnum` ar... | @JelleZijlstra, are you sure this one's a typeshed issue? It looks like mypy's revealing the correct type with the `reveal_type()` calls, but is then giving a different answer when you try to assert that type using `assert_type()`. That sounds like a mypy issue to me
I minimized it a bit:
```python
from __future__ ... | 2023-08-21T11:21:24Z | 1.6 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testNoneAsRvalue",
"mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testNonBooleanOr",
"mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testChainedCompResTyp",
"mypy/test/testcheck.py::TypeCheckSuite::check-expres... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testAssertTypeWithDeferredNodes"
] | Python | [] | [
"https://mypy-play.net/?mypy=latest&python=3.11&gist=e9d9c7c6848bc5ef0b62ae97bc007d17"
] |
python/mypy | 15,926 | python__mypy-15926 | [
"5858"
] | 7141d6bcff9e26e774e88712015ca6bbe8307c9e | diff --git a/mypy/checkmember.py b/mypy/checkmember.py
--- a/mypy/checkmember.py
+++ b/mypy/checkmember.py
@@ -2,7 +2,7 @@
from __future__ import annotations
-from typing import TYPE_CHECKING, Callable, Sequence, cast
+from typing import TYPE_CHECKING, Callable, Optional, Sequence, cast
from mypy import meet, m... | diff --git a/test-data/unit/check-functions.test b/test-data/unit/check-functions.test
--- a/test-data/unit/check-functions.test
+++ b/test-data/unit/check-functions.test
@@ -3158,3 +3158,20 @@ class C(A, B):
class D(A, B):
def f(self, z: int) -> str: pass # E: Method "f" is not using @override but is overriding... | lru_cache annotation doesn't work as a property
So I originally reported it in [typeshed/#2659](https://github.com/python/typeshed/issues/2569) but was told this can't be fixed there and it is mypy limitation so repporting it here.
----
I have following code:
```python
#! /usr/bin/env python
import time
f... | Duplicates https://github.com/python/mypy/issues/1362 and https://github.com/python/mypy/issues/1608
@probablyodd well its a bit different. If you set `# type: ignore` to `@property` in this case,
mypy will completely ignore existence of this decorator and treat such methods as common callable methods. Mypy will just... | 2023-08-22T08:27:46Z | 1.6 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-functions.test::testDefaultArgumentsWithSubtypes",
"mypy/test/testcheck.py::TypeCheckSuite::check-functions.test::testCallableDataAttribute",
"mypy/test/testcheck.py::TypeCheckSuite::check-functions.test::testReturnEmptyTuple",
"mypy/test/testcheck.py::TypeCheckS... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-functions.test::testCallableProperty"
] | Python | [] | [] |
python/mypy | 15,976 | python__mypy-15976 | [
"15975"
] | d7b24514d7301f86031b7d1e2215cf8c2476bec0 | diff --git a/mypy/plugins/attrs.py b/mypy/plugins/attrs.py
--- a/mypy/plugins/attrs.py
+++ b/mypy/plugins/attrs.py
@@ -893,6 +893,11 @@ def _add_attrs_magic_attribute(
def _add_slots(ctx: mypy.plugin.ClassDefContext, attributes: list[Attribute]) -> None:
+ if any(p.slots is None for p in ctx.cls.info.mro[1:-1])... | diff --git a/test-data/unit/check-dataclasses.test b/test-data/unit/check-dataclasses.test
--- a/test-data/unit/check-dataclasses.test
+++ b/test-data/unit/check-dataclasses.test
@@ -1519,6 +1519,22 @@ class Some:
self.y = 1 # E: Trying to assign name "y" that is not in "__slots__" of type "__main__.Some"
[b... | attrs & dataclasses false positive error with slots=True when subclassing from non-slots base class
<!--
If you're not sure whether what you're experiencing is a mypy bug, please see the "Question and Help" form instead.
Please consider:
- checking our common issues page: https://mypy.readthedocs.io/en/stable/comm... | Looks like the logic is to ignore `__slots__` if anyone in the MRO doesn't have it:
https://github.com/python/mypy/blob/6f650cff9ab21f81069e0ae30c92eae94219ea63/mypy/semanal.py#L4645-L4648 | 2023-08-28T04:20:29Z | 1.6 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesBasic",
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testClassmethodShadowingFieldDoesNotCrash",
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesMultiInit",
"mypy/test/testcheck.... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassWithSlotsDerivedFromNonSlot",
"mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsClassWithSlotsDerivedFromNonSlots"
] | Python | [] | [
"https://mypy-play.net/?mypy=latest&python=3.11&gist=9abddb20dc0419557e8bc07c93e41d25"
] |
python/mypy | 16,053 | python__mypy-16053 | [
"8283"
] | d77310ae61e8e784aae46b2011f35900b9392e15 | diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
--- a/mypy/checkexpr.py
+++ b/mypy/checkexpr.py
@@ -1476,6 +1476,7 @@ def check_call(
callable_node: Expression | None = None,
callable_name: str | None = None,
object_type: Type | None = None,
+ original_type: Type | None = None,
... | diff --git a/test-data/unit/check-overloading.test b/test-data/unit/check-overloading.test
--- a/test-data/unit/check-overloading.test
+++ b/test-data/unit/check-overloading.test
@@ -6650,3 +6650,27 @@ def d(x: int) -> int: ...
def d(f: int, *, x: int) -> str: ...
def d(*args, **kwargs): ...
[builtins fixtures/tuple... | Invalid type inferred when overloading __call__ with generic self-type
Seems like mypy uses the first overloaded `__call__` signature when using self-type. There is no problem with overloading another dunder method (I tried `__get__`) or with regular overload (`__call__` but without self-type). If use another method n... | Yeah, this looks like a bug.
@ilevkivskyi Any idea if this would be hard to fix?
`__call__` is special-cased in `checkmember.py`, it may be not easy to fix. I don't remember why, but last time I tried it, I didn't find a quick solution.
Just confirming that this is still an issue as I lost a lot of time to it today... | 2023-09-05T21:37:20Z | 1.7 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-overloading.test::testOverloadNotImportedNoCrash",
"mypy/test/testcheck.py::TypeCheckSuite::check-overloading.test::testCovariantOverlappingOverloadSignaturesWithSomeSameArgTypes",
"mypy/test/testcheck.py::TypeCheckSuite::check-overloading.test::testOverloadedFunct... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-overloading.test::testOverloadCallableGenericSelf"
] | Python | [] | [] |
python/mypy | 16,061 | python__mypy-16061 | [
"16060"
] | ed9b8990025a81a12e32bec59f2f3bfab3d7c71b | diff --git a/mypy/errorcodes.py b/mypy/errorcodes.py
--- a/mypy/errorcodes.py
+++ b/mypy/errorcodes.py
@@ -261,3 +261,10 @@ def __hash__(self) -> int:
# This is a catch-all for remaining uncategorized errors.
MISC: Final = ErrorCode("misc", "Miscellaneous other checks", "General")
+
+UNSAFE_OVERLOAD: Final[ErrorCod... | diff --git a/test-data/unit/check-errorcodes.test b/test-data/unit/check-errorcodes.test
--- a/test-data/unit/check-errorcodes.test
+++ b/test-data/unit/check-errorcodes.test
@@ -1072,3 +1072,17 @@ A.f = h # type: ignore[assignment] # E: Unused "type: ignore" comment, use nar
[case testUnusedIgnoreEnableCode]
# fla... | Introduce error category [unsafe-overload].
**Feature**
Specifically, consider this [example from the documentation](https://mypy.readthedocs.io/en/stable/more_types.html#type-checking-the-variants) [[mypy-play]](https://mypy-play.net/?mypy=latest&python=3.11&gist=e3ef44b3191567e27dc1b2887c4e722e):
```python
fro... | Seems fine to me, please submit a PR. In general we should minimize use of the "misc" error code.
One concern is about backward incompatibility: users who use `# type: ignore[misc]` will have to change their code. Not sure if we have a stance about that. | 2023-09-06T20:15:07Z | 1.7 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-errorcodes.test::testErrorCodeSyntaxError3",
"mypy/test/testcheck.py::TypeCheckSuite::check-errorcodes.test::testErrorCodeWarnUnusedIgnores1",
"mypy/test/testcheck.py::TypeCheckSuite::check-errorcodes.test::testErrorCodeMissingWhenRequired",
"mypy/test/testcheck.... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-errorcodes.test::testErrorCodeUnsafeOverloadError"
] | Python | [] | [
"https://mypy-play.net/?mypy=latest&python=3.11&gist=e3ef44b3191567e27dc1b2887c4e722e"
] |
python/mypy | 16,080 | python__mypy-16080 | [
"16057"
] | 49419835045b09c98b545171abb10384b6ecf6a9 | diff --git a/mypy/checker.py b/mypy/checker.py
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -1076,6 +1076,8 @@ def check_func_item(
if name == "__exit__":
self.check__exit__return_type(defn)
+ # TODO: the following logic should move to the dataclasses plugin
+ # https://github.c... | diff --git a/test-data/unit/check-dataclasses.test b/test-data/unit/check-dataclasses.test
--- a/test-data/unit/check-dataclasses.test
+++ b/test-data/unit/check-dataclasses.test
@@ -2280,6 +2280,10 @@ reveal_type(a2) # N: Revealed type is "__main__.A[builtins.int]"
[builtins fixtures/tuple.pyi]
+[case testPostIn... | __post_init__() causes INTERNAL ERROR
**Crash Report**
When I code with `def __post_init__()`, mypy reports INTERNAL ERROR.
**To Reproduce**
Here is a minimal code snippet to reproduce the crash:
```
def __post_init__(self):
self._a = a
```
Print the code in the `file.py` and execute `mypy file.py`.
... | Looks like this is a recent regression. The code doesn't cause mypy to crash using mypy 1.4.1: https://mypy-play.net/?mypy=1.4.1&python=3.11&gist=ca0d08947e4e0659f5b8d4d794752422
But does with mypy 1.5.0 or mypy 1.5.1: https://mypy-play.net/?mypy=1.5.1&python=3.11&gist=4d266591df6934e48c26bc0f3fa61634 | 2023-09-09T22:27:54Z | 1.7 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesOrderingKwOnlyWithSentinel",
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesBasic",
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesMultiInitDefaults",
"mypy/test/te... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testPostInitNotMethod"
] | Python | [] | [] |
python/mypy | 16,203 | python__mypy-16203 | [
"16202"
] | 181cbe88f1396f2f52770f59b6bbb13c6521980a | diff --git a/mypy/checker.py b/mypy/checker.py
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -6237,7 +6237,7 @@ def check_subtype(
assert call is not None
if not is_subtype(subtype, call, options=self.options):
self.msg.note_call(supertype, call, context, code=msg... | diff --git a/test-data/unit/check-async-await.test b/test-data/unit/check-async-await.test
--- a/test-data/unit/check-async-await.test
+++ b/test-data/unit/check-async-await.test
@@ -165,6 +165,33 @@ async def f() -> None:
[out]
main:4: error: "List[int]" has no attribute "__aiter__" (not async iterable)
+[case tes... | 'Maybe you forgot to use "await"?' has wrong error code
```python
from typing import AsyncGenerator
async def f() -> AsyncGenerator[str, None]:
raise Exception("fooled you")
async def g() -> None:
async for y in f(): # type: ignore[attr-defined]
print(y)
```
```
% mypy ~/py/tmp/async... | 2023-09-29T16:29:36Z | 1.7 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-async-await.test::testAsyncDefPass",
"mypy/test/testcheck.py::TypeCheckSuite::check-async-await.test::testAwaitIteratorError",
"mypy/test/testcheck.py::TypeCheckSuite::check-async-await.test::testAsyncDefReturnWithoutValue",
"mypy/test/testcheck.py::TypeCheckSuit... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-async-await.test::testAsyncForErrorCanBeIgnored"
] | Python | [] | [] | |
python/mypy | 16,330 | python__mypy-16330 | [
"15148"
] | 090a414ba022f600bd65e7611fa3691903fd5a74 | diff --git a/mypy/checker.py b/mypy/checker.py
--- a/mypy/checker.py
+++ b/mypy/checker.py
@@ -5232,6 +5232,15 @@ def _make_fake_typeinfo_and_full_name(
pretty_names_list = pretty_seq(
format_type_distinctly(*base_classes, options=self.options, bare=True), "and"
)
+
+ new_errors = ... | diff --git a/test-data/unit/check-narrowing.test b/test-data/unit/check-narrowing.test
--- a/test-data/unit/check-narrowing.test
+++ b/test-data/unit/check-narrowing.test
@@ -1020,6 +1020,105 @@ else:
reveal_type(true_or_false) # N: Revealed type is "Literal[False]"
[builtins fixtures/primitives.pyi]
+
+[case ... | (🎁) Intersections with `@final` types should trigger unreachable errors
```py
from typing import final
@final
class A: ...
class B: ...
a: A
assert isinstance(a, B)
reveal_type(a) # note: Revealed type is "__main__.<subclass of "A" and "B">"
print("hi") # no unreachable error
```
- Relates to #12163
| "Intersections with `@final` types should trigger unreachable errors"… (unless `A` already inherits from `B` of course :smile:) | 2023-10-26T15:55:50Z | 1.7 | [
"mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testNarrowingParentsWithGenerics",
"mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testNarrowingTypedDictParentMultipleKeys",
"mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testNarrowingParentsHierarchy",
"mypy/test/... | [
"mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testNarrowingIsInstanceFinalSubclass",
"mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testNarrowingIsInstanceFinalSubclassWithUnions",
"mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testNarrowingIsSubclassFinalSubclas... | Python | [] | [] |
netty/netty | 10,009 | netty__netty-10009 | [
"9986"
] | 2a5118f824afefa53f1cd199cf56dee0746b8688 | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java
+++ b/codec-http2/src/main/ja... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java
+++ b/codec-http2/src/test/java/... | DefaultHttp2ConnectionDecoder triggers stream channel closes more eagerly than it should
### Expected behavior
When a Http2FrameCodec receives a GOAWAY the stream channels with ID's greater than the last seen will get notified of the GOAWAY so they can bubble up a retryable signal.
### Actual behavior
The connecti... | @bryce-anderson will you look into a proper fix ?
@normanmaurer, yes. I suspect it will be either really easy or really hard.
@bryce-anderson ok cool... let me know once you have something to review. | 2020-02-07T17:34:24Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.Http2ConnectionRoundtripTest"
] | Java | [] | [] |
netty/netty | 10,321 | netty__netty-10321 | [
"10320"
] | 0375e6e01b0b6412c2369a8d3e2a990f41a9edfa | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecoder.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpConte... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java
+++ b/codec-http/src/test/java/io/netty/handler/codec/ht... | More values other than chunked defined in Transfer-Encoding header leads to decode failure
According to https://tools.ietf.org/html/rfc7230#page-29, people can specify multiple values for `Transfer-Encoding` HTTP header, like: `Transfer-Encoding: gzip, chunked`, but Netty does not recognize it as a chunked request in ... | 2020-05-27T01:19:13Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.HttpContentDecoderTest"
] | Java | [] | [] | |
netty/netty | 10,453 | netty__netty-10453 | [
"10449",
"10360",
"10449"
] | 0601389766e2feec82c1d6d9e1834a3930c82caa | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java
+++ b/codec-http/src/main/java/i... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/DiskFileUploadTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/DiskFileUploadTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/DiskFileUploadTest.java
+++ b/codec-http/src/test/java/io/nett... | FileUpload.get() created by a HttpPostMultipartRequestDecoder returns incomplete array on 4.1.51
### Expected behavior
UploadFile.get() should return the full byte array uploaded.
### Actual behavior
It appears that although `fileUpload.length()` returns the correct value, the byte array from `get()` returns o... | @normanmaurer Might it be linked to recent changes, such as in https://github.com/netty/netty/blob/c4754cf7b890e7169b2438567fa2f881728715ed/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractDiskHttpData.java#L167
I saw a few days ago a remark on the possibility that this call might not write all... | 2020-08-04T19:57:01Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.multipart.DiskFileUploadTest"
] | Java | [] | [] |
netty/netty | 10,473 | netty__netty-10473 | [
"10416"
] | f58223982ce8d9ed056c3d127972222966d0ebd1 | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java
+++ b/codec-http2/src/main/java/io/netty/handle... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriterTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriterTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriterTest.java
+++ b/codec-http2/src/test/java/io/... | Http2: writing valid PRIORITY frame fails with misleading error message
### Expected behavior
* Writing valid PRIORITY frame with `streamDependency=0` succeeds
* PRIORITY frame validation message contains actual cause of error
### Actual behavior
Writing PRIORITY frame with `streamDependency=0`
```
http2Handle... | @ejona86 can you have a look ?
I'll send out a PR.
The `verifyStreamId()` check for `streamDependency` should be a `verifyStreamOrConnectionId()`:
https://github.com/netty/netty/blob/f58223982ce8d9ed056c3d127972222966d0ebd1/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java#L273-L27... | 2020-08-11T15:32:36Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.DefaultHttp2FrameWriterTest"
] | Java | [] | [] |
netty/netty | 10,775 | netty__netty-10775 | [
"10670"
] | b63e2dfb1baa7dbe3da381458f6d9ab004777090 | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
+++ b/codec-http2/src/main/java/io/netty/handler/c... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionHandlerTest.java
+++ b/codec-http2/src/test/java/io/net... | http2: wrong Last-Stream-Id for connection error during header parsing
### Expected behavior
A channel error occurring during HEADERS decoding triggers a GOAWAY that includes the stream id including the stream for the header being processed.
### Actual behavior
Streams are allocated within `DefaultHttp2Connect... | @ejona86 this is the best I can think of as well... I guess this is "good enough" ?
I think it will be good enough. I'll work on a fix after I'm back in the office on the 26th.
ok cool... ping me once I should review some code
I don't see a good way to update `incrementExpectedStreamId()` from `DefaultHttp2FramReader... | 2020-11-04T17:00:40Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.Http2ConnectionHandlerTest",
"org.io.netty.handler.codec.http2.Http2ControlFrameLimitEncoderTest"
] | Java | [] | [] |
netty/netty | 10,844 | netty__netty-10844 | [
"10837"
] | 44f85bba5f47df885dbbe5243d008220bfbab5ca | diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java
--- a/common/src/main/java/io/netty/util/internal/Hidden.java
+++ b/common/src/main/java/io/netty/util/internal/Hidden.java
@@ -111,6 +111,10 @@ public void applyTo(BlockHound.Builder builder) ... | diff --git a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java b/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java
--- a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java... | Blocking call found with Spring Webflux and r2dbc-mysql driver.
### Overview
Hi,
So I am using Spring Webflux 5.3.1(which internally uses Netty) and I am integrating it with a MySql R2DBC driver(r2dbc-mysql) to make a reactive application.
It works fine and everything looks good.
But when I tried to use BlockHoun... | We tell block hound to permit blocking calls in `SSLEngine.wrap`: https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/Hidden.java#L108-L112
Does block hound also bark when you use a different `SSLEngine`, like `ReferenceCountedOpenSslEngine`?
@chrisvest Isn't it related to `unwrap` an... | 2020-12-06T11:59:35Z | 4.1 | [] | [
"org.io.netty.util.internal.NettyBlockHoundIntegrationTest"
] | Java | [] | [] |
netty/netty | 10,988 | netty__netty-10988 | [
"10896"
] | ab8b8ae81b24439ff94085f3f4bd060c172c1712 | diff --git a/buffer/src/main/java/io/netty/buffer/PoolSubpage.java b/buffer/src/main/java/io/netty/buffer/PoolSubpage.java
--- a/buffer/src/main/java/io/netty/buffer/PoolSubpage.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolSubpage.java
@@ -115,7 +115,13 @@ boolean free(PoolSubpage<T> head, int bitmapIdx) {
... | diff --git a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java b/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java
--- a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java
+++ b/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java
@@ -632,8 +632,8 ... | When subpage.elemSize == 8192, the free subpage operation is not work
### Actual behavior
allocate N * 8192 subpage, free part of them, but subpage still esixt in two-way linked list
### Minimal yet complete reproducer code (or URL to code)
```
io.netty.buffer.PoolSubpage#free {
if (numAvail ++ == 0) { // n... | @ZzxyNn are you interested in providing a PR (with a fix and maybe also a test case) ?
@normanmaurer
```
int oneLength = 16,twoLength = 256;
// int elemSize = 4096; // normal
int elemSize = 8192; // unnormal
ByteBuf[] ones = new ByteBuf[oneLength];
ByteBuf[] twos = new ByteBuf[twoLength];
//allocate
for (int ... | 2021-02-03T04:16:08Z | 4.1 | [] | [
"org.io.netty.buffer.PooledByteBufAllocatorTest"
] | Java | [] | [] |
netty/netty | 11,009 | netty__netty-11009 | [
"11004"
] | ecd7dc3516b5a9fc612330f2dd617576569a256b | diff --git a/common/src/main/java/io/netty/util/internal/Hidden.java b/common/src/main/java/io/netty/util/internal/Hidden.java
--- a/common/src/main/java/io/netty/util/internal/Hidden.java
+++ b/common/src/main/java/io/netty/util/internal/Hidden.java
@@ -119,6 +119,18 @@ public void applyTo(BlockHound.Builder builder) ... | diff --git a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java b/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java
--- a/transport-blockhound-tests/src/test/java/io/netty/util/internal/NettyBlockHoundIntegrationTest.java... | Unexpected WebClient blocks reported by BlockHound
I'm new to webflux so I posted a [question on stackoverflow](https://stackoverflow.com/questions/66091050/why-is-webclient-blocking-in-this-web-flux-app) thinking I was doing something wrong in my code, but after seeing [this issue](https://github.com/netty/netty/issue... | 2021-02-09T08:58:21Z | 4.1 | [] | [
"org.io.netty.util.internal.NettyBlockHoundIntegrationTest"
] | Java | [] | [] | |
netty/netty | 11,106 | netty__netty-11106 | [
"11101"
] | 4f316b7cbd8af2bbf47319c82941a6f80afcb609 | diff --git a/buffer/src/main/java/io/netty/buffer/PoolArena.java b/buffer/src/main/java/io/netty/buffer/PoolArena.java
--- a/buffer/src/main/java/io/netty/buffer/PoolArena.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolArena.java
@@ -41,7 +41,6 @@ enum SizeClass {
final int numSmallSubpagePools;
final ... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractPooledByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractPooledByteBufTest.java
--- a/buffer/src/test/java/io/netty/buffer/AbstractPooledByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/AbstractPooledByteBufTest.java
@@ -125,4 +125,18 @@ ... | direct memory allocation error in PooledByteBufAllocator when setting directMemoryCacheAlignment to "1"
Define a `PooledByteBufAllocator` and set ·directMemoryCacheAlignment· to "1" and try to allocate some `ByteBuf` like
```java
PooledByteBufAllocator pooledByteBufAllocator = new PooledByteBufAllocator(
Pla... | @alalag1 Oof! Nice catch. We'll take a look. | 2021-03-22T16:38:12Z | 4.1 | [] | [
"org.io.netty.buffer.PooledAlignedBigEndianDirectByteBufTest",
"org.io.netty.buffer.AlignedPooledByteBufAllocatorTest",
"org.io.netty.buffer.PoolArenaTest"
] | Java | [] | [] |
netty/netty | 11,145 | netty__netty-11145 | [
"11143"
] | 16b40d8a37937fd6e73858db2f05bd1e778a1d6f | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/AbstractMemoryHttpData.java
+++ b/codec-http/src/main/... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java
+++ b/codec-ht... | HttpPostMultipartRequestDecoder may not add content to an existing upload after being offered data
### Expected behavior
Once a file upload object exists in the multipart request decoder, but not finished, offering more data to the decoder should populate the buffer of the file object
### Actual behavior
The b... | @jameskleeh
From the beginning: https://github.com/fredericBregier/netty/blob/6daeb0cc51d8689805c1a657e61d395450afec47/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java#L1160
It tries to find out the `delimiter` in the full buffer (multiple chunks up to now):
- if... | 2021-04-07T06:52:01Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.multipart.HttpPostRequestDecoderTest"
] | Java | [] | [] |
netty/netty | 11,663 | netty__netty-11663 | [
"11652"
] | a329857ec20cc1b93ceead6307c6849f93b3f101 | diff --git a/transport-native-unix-common/src/main/c/netty_unix_socket.c b/transport-native-unix-common/src/main/c/netty_unix_socket.c
--- a/transport-native-unix-common/src/main/c/netty_unix_socket.c
+++ b/transport-native-unix-common/src/main/c/netty_unix_socket.c
@@ -764,12 +764,13 @@ static jint netty_unix_socket_b... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/LinuxSocketTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/LinuxSocketTest.java
--- a/transport-native-epoll/src/test/java/io/netty/channel/epoll/LinuxSocketTest.java
+++ b/transport-native-epoll/src/test/java/io/netty/chan... | Issues on UDS path binding
I think there are couple issues relate to the UDS path binding logic:
1. In the JNI `netty_unix_socket_bindDomainSocket` method, when the upper level passes in a [longer-than-limit UDS path](https://github.com/netty/netty/blob/d58d8a1df832a5185193368e589cb4a488709ffe/transport-native-unix-... | Sounds good . Will provide more feedback on the PR | 2021-09-07T17:01:45Z | 4.1 | [] | [
"org.io.netty.channel.epoll.LinuxSocketTest"
] | Java | [] | [] |
netty/netty | 11,706 | netty__netty-11706 | [
"11700"
] | 23405e2000427e9cad104913e7071d8d08e91a3c | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -474,7 +474,7 @@ private static long compareUintBigEndian(
private st... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
--- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
@@ -5943,6 +5943,16 @@ public void explicitLi... | ByteBuf.order() seems to have wrong behavior
Found unexpected behavior when calling
```java
Unpooled.buffer(1024).order(ByteOrder.LITTLE_ENDIAN).writeShortLE(message)
```
since netty 4.1.54.Final.
The `order()` method has already been deprecated, but nevertheless it shouldn't be broken.
### Expected behavio... | Actually your this test has bug in line 26, 27.
> Actually your this test has bug in line 26, 27.
@forchid The test where line 26 and 27 are is passing. What bug does it have? The issue is that the other test is failing.
> The test where line 26 and 27 are is passing. What bug does it have? The issue is that the ot... | 2021-09-23T11:47:19Z | 4.1 | [] | [
"org.io.netty.buffer.UnpooledTest"
] | Java | [] | [] |
netty/netty | 11,934 | netty__netty-11934 | [
"11933"
] | c08beb543a6b8db0c7f3cee225042361b4025e4c | diff --git a/common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java b/common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java
--- a/common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java
+++ b/common/src/main/java/io/netty/util/internal/InternalThreadLocalMap.java
@@ -4... | diff --git a/common/src/test/java/io/netty/util/concurrent/FastThreadLocalTest.java b/common/src/test/java/io/netty/util/concurrent/FastThreadLocalTest.java
--- a/common/src/test/java/io/netty/util/concurrent/FastThreadLocalTest.java
+++ b/common/src/test/java/io/netty/util/concurrent/FastThreadLocalTest.java
@@ -16,17... | `FastThreadLocal.set(V)` method throws `NegativeArraySizeException` after called more than (1 << 30) times of `new FastThreadLocal()`
### Expected behavior
The `FastThreadLocal.set(V)` method should still work after called more than (1 << 30) and less than (Integer.MAX_VALUE) times of `new FastThreadLocal()`.
###... | 2021-12-17T12:55:14Z | 4.1 | [] | [
"org.io.netty.util.concurrent.FastThreadLocalTest"
] | Java | [] | [] | |
netty/netty | 11,966 | netty__netty-11966 | [
"11965"
] | 9ab5e9180253e85eacdb978d436c087615c6e3b1 | diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
--- a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
+++ b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
@@ -162,6 +162,8 ... | diff --git a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
--- a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
+++ b/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
@... | WebSocket server loss one frame, maybe caused by ByteToMessageDecoder trigger a unexpected read() when readCompleted fired
We're creating a relay-like application with WebSocket. When the WebSocket client sends an upgrade request to the server, the server sets the channel's autoRead to false (or config child channel au... | 2022-01-02T13:29:06Z | 4.1 | [] | [
"org.io.netty.handler.codec.ByteToMessageDecoderTest"
] | Java | [] | [] | |
netty/netty | 11,970 | netty__netty-11970 | [
"11963"
] | bdcf3988c20c9c0dae92850b36ae63d5ddc5b502 | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -279,7 +279,7 @@ public static int indexOf(ByteBuf needle, ByteBuf haystac... | diff --git a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
--- a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
+++ b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java
@@ -132,13 +132,13 @@ public void testIndexOf() {
fi... | the result of `ByteBufUtil.indexOf(ByteBuf needle, ByteBuf haystack)` wrong
### Expected behavior
```
ByteBuf haystack = Unpooled.copiedBuffer("+PONG\r\n", CharsetUtil.UTF_8);
ByteBuf needle = Unpooled.copiedBuffer("\r\n", CharsetUtil.UTF_8);
haystack.readByte();
int index = Byte... | Thanks for the report, preparing a fix. | 2022-01-05T00:59:30Z | 4.1 | [] | [
"org.io.netty.buffer.ByteBufUtilTest"
] | Java | [] | [] |
netty/netty | 11,990 | netty__netty-11990 | [
"11984"
] | d60ea595bcd2399530d8becbced45df0b9b22aa5 | diff --git a/buffer/src/main/java/io/netty/buffer/PoolChunk.java b/buffer/src/main/java/io/netty/buffer/PoolChunk.java
--- a/buffer/src/main/java/io/netty/buffer/PoolChunk.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolChunk.java
@@ -19,6 +19,7 @@
import java.util.ArrayDeque;
import java.util.Deque;
import java... | diff --git a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java b/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java
--- a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java
+++ b/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java
@@ -30,7 +30,9 @@... | PooledByteBufAllocator.pinnedDirectMemory is sometimes returning 0 even if some direct buffers are used
I'm trying to monitor the estimate of memory that is used by in-use direct buffers.
To do so, I'm trying to use the PooledByteBufAllocator.pinnedDirectMemory() method but sometimes, it seems that this method is retu... | @chrisvest can you have a look at this one ?
I got the test running and showing the expected failure. It disappears if I add a `alloc.trimCurrentThreadCache();` after the `release()` loop. The accounting is done in a bad place, where we might either miss out on activity happening at the cache layer, or we'll have the s... | 2022-01-11T17:18:05Z | 4.1 | [] | [
"org.io.netty.buffer.PooledByteBufAllocatorTest"
] | Java | [] | [] |
netty/netty | 12,664 | netty__netty-12664 | [
"12663"
] | a1d30767aae00a4dbc8415f6c78ad65e96a60eef | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDecoderTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostMultiPartRequestDeco... | Parsing multipart/form-data requests with form-data content-type including optional parameters uses last parameter as content-type
### Expected behavior
When passed a content type header with optional parameter, content type should be correctly set and optional parameters should be attributes.
e.g.
contnet-type... | 2022-08-03T10:22:09Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.multipart.HttpPostMultiPartRequestDecoderTest"
] | Java | [] | [] | |
netty/netty | 12,924 | netty__netty-12924 | [
"12909"
] | cfcc5144578d3f998d353cc3c3b448fc56333e0d | diff --git a/codec/src/main/java/io/netty/handler/codec/compression/BrotliEncoder.java b/codec/src/main/java/io/netty/handler/codec/compression/BrotliEncoder.java
--- a/codec/src/main/java/io/netty/handler/codec/compression/BrotliEncoder.java
+++ b/codec/src/main/java/io/netty/handler/codec/compression/BrotliEncoder.ja... | diff --git a/codec/src/test/java/io/netty/handler/codec/compression/BrotliEncoderTest.java b/codec/src/test/java/io/netty/handler/codec/compression/BrotliEncoderTest.java
--- a/codec/src/test/java/io/netty/handler/codec/compression/BrotliEncoderTest.java
+++ b/codec/src/test/java/io/netty/handler/codec/compression/Brot... | Broken BrotliDecoder
### Expected behavior
Transparent stream compression
### Actual behavior
<details>
<summary>io.netty.handler.codec.compression.DecompressionException: Brotli stream corrupted</summary>
```
io.netty.handler.codec.compression.DecompressionException: Brotli stream corrupted
at io.netty.han... | @hyperxpro can you have a look ?
Thanks for the heads up. There is a major bug in Encoder.
PR coming soon. | 2022-10-21T16:15:40Z | 4.1 | [] | [
"org.io.netty.handler.codec.compression.BrotliEncoderTest"
] | Java | [] | [] |
netty/netty | 12,988 | netty__netty-12988 | [
"12981"
] | 76296425f4ee199de6dc3e3e03c40173cc5aa7de | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
+++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
@... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java
+++ b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDe... | HPACK dynamic table size update must happen at the beginning of the header block
### Expected behavior
HPACK decoder accepts dynamic table size update at the beginning of the block.
Cf RFC 7531, section 4.2
### Actual behavior
HPACK decoder tolerates dynamic table size update anywhere in the block
`io.ne... | I can contribute a fix for this. | 2022-11-11T09:32:53Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.HpackDecoderTest"
] | Java | [] | [] |
netty/netty | 13,114 | netty__netty-13114 | [
"13113"
] | 0097c2b72521c422d42bf8c45273db05a7ff068c | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrame.java
+++ b/codec-http/src/main/java/i... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrameTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrameTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/CloseWebSocketFrameTest.java
+++ b/codec-http/src... | CloseWebSocketFrame statusCode() get unexpected results
Set the CloseWebSocketFrame code to 60000, and the result obtained by statusCode() is negative;
The WebSocket protocol states that Code is a 2-byte unsigned integer (in network byte order)，But netty acquisition is obtained by signs.
![image](https://user-ima... | @zhangjinying can you do a PR with the change and a test ?
> @zhangjinying can you do a PR with the change and a test ?
👌 | 2023-01-10T14:15:52Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.websocketx.CloseWebSocketFrameTest"
] | Java | [] | [] |
netty/netty | 13,146 | netty__netty-13146 | [
"13104"
] | 9541bc17e0c637ec77ccc3d6b67a19a0d024f925 | diff --git a/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java b/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java
--- a/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java
+++ b/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java
@@ -141,8 +141,10 @@ ... | diff --git a/handler/src/test/java/io/netty/handler/flow/FlowControlHandlerTest.java b/handler/src/test/java/io/netty/handler/flow/FlowControlHandlerTest.java
--- a/handler/src/test/java/io/netty/handler/flow/FlowControlHandlerTest.java
+++ b/handler/src/test/java/io/netty/handler/flow/FlowControlHandlerTest.java
@@ -4... | FlowControlHandler is passing read events when auto-reading is turned off
### Expected behavior
Not passing read events onto the pipeline (calling ctx.read() which results in reading from the client socket) when the queue is not empty and auto-reading is turned off for the channel. I would suggest that the expected be... | @ivanangelov can you do a PR with the suggested changes and a unit test ? We love contributions | 2023-01-23T21:03:04Z | 4.1 | [] | [
"org.io.netty.handler.flow.FlowControlHandlerTest"
] | Java | [] | [] |
netty/netty | 13,209 | netty__netty-13209 | [
"13208"
] | cfcdd93db5fd9af6254144caad68f4ed29a3dc64 | diff --git a/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java b/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
--- a/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
+++ b/codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java
@@ -1013,7 +1013,11 @@ protected void val... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java
+++ b/codec-http/src/test/java/io/netty/handler/codec/ht... | Display which header failed validation
### Expected behavior
Currently if a HeaderValue fails validation we get an IllegalArgumentException which has the message `a header value contains prohibited character {some_invalid_character} at index {index}`. Seeing this in production makes it hard to debug which header is ... | 2023-02-10T09:22:22Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.DefaultHttpHeadersTest"
] | Java | [] | [] | |
netty/netty | 13,227 | netty__netty-13227 | [
"13218"
] | 3de03282d558d7b7e2c282b31db73335f0f498b1 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/MixedFileUpload.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/MixedFileUpload.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/MixedFileUpload.java
+++ b/codec-http/src/main/java/io/netty/handler... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/MixedTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/MixedTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/MixedTest.java
+++ b/codec-http/src/test/java/io/netty/handler/codec/http/multip... | MixedFileUpload does not always create DiskFileUpload under the specified baseDir
### Expected behavior
`MixedFileUpload` should always used the specified `baseDir` to create `DiskFileUpload`.
### Actual behavior
If the `DiskFileUpload` is created in the `MixedFileUpload` constructor then `basedDire` & `delete... | Interested in doing a PR?
Yes definitely, I should be able to push a PR in the following days | 2023-02-17T14:46:39Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.multipart.MixedTest"
] | Java | [] | [] |
netty/netty | 13,274 | netty__netty-13274 | [
"13273"
] | ebfc79c85deb8ba6fda54b8cb7fa925573076b21 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDe... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java
+++ b/codec-http/src/test/java/io/netty/handler/codec... | HttpObjectDecoder.getChunkedSize trips over whitespace
### Expected behavior
the chunked size is calculated correctly
### Actual behavior
java.lang.NumberFormatException is thrown
### Steps to reproduce
See code below.
Please be aware that I'm not at all familiar with the netty code. Added a few comments ... | @franz1981 PTAL... I think this might be related to a change of yours
The `StringUtil.decodeHexNibble(hex[0 + 3])` call will be `StringUtil.decodeHexNibble(32)` which returns `-1`. Forgot to mention that above.
mmm I don't follow it sorry...
@lars-n are you able to make this to be triggered by actual HTTP data?
The ... | 2023-03-13T22:49:48Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.HttpResponseDecoderTest"
] | Java | [] | [] |
netty/netty | 13,312 | netty__netty-13312 | [
"13307"
] | ccc5e01f0444301561f055b02cd7c1f3e875bca7 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java
+++ b/codec-http/src/main/java/io/netty/handler/codec... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java
+++ b/codec-http/src/test/java/io/netty/handler/codec/ht... | Extend decompression of HttpContentDecompressor.java
### Actual behaviour
At the moment the [HttpContentDecompressor.java](https://github.com/netty/netty/blob/cf5c467f4ead5ba5e1e36f5c4903af78bd49c35c/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentDecompressor.java#LL58C9-L73) support:
- deflate
... | Extend the `HttpContentDecompressor` and override the `newContentDecoder` for Snappy and delegate the rest to `super#newContentDecoder`.
> Extend the `HttpContentDecompressor` and override the `newContentDecoder` for Snappy and delegate the rest to `super#newContentDecoder`.
Thanks for the guidance @hyperxpro, I ass... | 2023-03-30T19:36:44Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.HttpContentDecoderTest"
] | Java | [] | [] |
netty/netty | 13,452 | netty__netty-13452 | [
"13328"
] | bf8e77974c4e470be002415ea04ca567ded6d9b7 | diff --git a/transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.java b/transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.java
--- a/transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.java
+++ b/transport/src/main/java/io/netty/channel/nio/SelectedSelectionKeySet.ja... | diff --git a/transport/src/test/java/io/netty/channel/nio/SelectedSelectionKeySetTest.java b/transport/src/test/java/io/netty/channel/nio/SelectedSelectionKeySetTest.java
--- a/transport/src/test/java/io/netty/channel/nio/SelectedSelectionKeySetTest.java
+++ b/transport/src/test/java/io/netty/channel/nio/SelectedSelect... | Possible issues with SelectedSelectionKeySet in non-linux operating systems
`SelectedSelectionKeySet` doesn't implement `contains()` method. Or at least it returns always false. This may create issues in non-linux operating systems.
To give you more context, in my work, like you do, we try to not produce garbage by ... | Good find, we'll take a look. | 2023-06-15T18:49:43Z | 4.1 | [] | [
"org.io.netty.channel.nio.SelectedSelectionKeySetTest"
] | Java | [] | [] |
netty/netty | 13,546 | netty__netty-13546 | [
"13540"
] | 6f1646fe3aaa5c53f1f1376e049c71e69030dc40 | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java
+++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java
@... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java
+++ b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEn... | Unexpected characters are synthesized by DefaultHttp2HeadersDecoder when Huffman encoding is enabled in HpackEncoder
### What happened?
1. Create a header `DefaultHttp2Headers` with a certain value that exceeds certain size and contain non-ASCII characters,
2. Encode the header using `DefaultHttp2HeadersEncoder`.
3... | I have reproduced it and found that the decoded value is **not equal** to the original value whenever the `enableHuffmanEncoding` is true or false. And I found a comment in `HpackEncoder.java`: Only **ASCII** is allowed in http2 headers(https://tools.ietf.org/html/rfc7540#section-8.1.2), so if there exists unexpected c... | 2023-08-13T06:41:56Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.HpackHuffmanTest",
"org.io.netty.handler.codec.http2.HpackEncoderTest"
] | Java | [] | [] |
netty/netty | 13,998 | netty__netty-13998 | [
"13981"
] | 93caaeb84f9c51214bfc0040fcd5c0d3be23bf91 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder.java
++... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoderTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostStandardRequestDecoder... | JSON in POST request treated as body attribute in HttpPostStandardRequestDecoder
### Expected behavior
JSON in POST request shouldn't be counted as body attribute in `HttpPostStandardRequestDecoder`, as in releases `<4.1.108-Final` (checked on `4.1.107.Final` and `4.1.106.Final`)
### Actual behavior
JSON in PO... | 2024-04-23T13:28:05Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.multipart.HttpPostStandardRequestDecoderTest"
] | Java | [] | [] | |
netty/netty | 14,086 | netty__netty-14086 | [
"14069"
] | 4f19ecfbb4f14c092fc74643d38152f2d034cf43 | diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandlerCoalescingBufferQueue.java b/handler/src/main/java/io/netty/handler/ssl/SslHandlerCoalescingBufferQueue.java
--- a/handler/src/main/java/io/netty/handler/ssl/SslHandlerCoalescingBufferQueue.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SslHandlerCoalescingBufferQueueTest.java b/handler/src/test/java/io/netty/handler/ssl/SslHandlerCoalescingBufferQueueTest.java
--- a/handler/src/test/java/io/netty/handler/ssl/SslHandlerCoalescingBufferQueueTest.java
+++ b/handler/src/test/java/io/netty/handler/ss... | SslHandler doesn't support a use case where the input ByteBuf is shared across multiple threads
### Expected behavior
There should be a way to pass shared ByteBuf instances to a ChannelPipeline that contains SslHandler. A ByteBuf instance might be cached and that's why it's shared.
An alternative is to document ... | Passing the same `ByteBuf` instance to different `ChannelPipeline` is not supported at all. This is not really a limitation of the `SslHandler` but just the fact that `ByteBuf` is not thread-safe at all and once you pass a `ByteBuf` its ownership transfers.
> Passing the same `ByteBuf` instance to different `ChannelPip... | 2024-05-30T12:20:02Z | 4.1 | [] | [
"org.io.netty.handler.ssl.SslHandlerCoalescingBufferQueueTest"
] | Java | [] | [] |
netty/netty | 14,093 | netty__netty-14093 | [
"12919"
] | 4f19ecfbb4f14c092fc74643d38152f2d034cf43 | diff --git a/buffer/src/main/java/io/netty/buffer/AbstractUnpooledSlicedByteBuf.java b/buffer/src/main/java/io/netty/buffer/AbstractUnpooledSlicedByteBuf.java
--- a/buffer/src/main/java/io/netty/buffer/AbstractUnpooledSlicedByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/AbstractUnpooledSlicedByteBuf.java
@@ -2... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
--- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
@@ -2137,6 +2137,52 @@ public void testRetain... | ByteBuf slice duplicates are not slices
### Expected behavior
A `ByteBuf` duplicated slice remains a slice.
### Actual behavior
A `ByteBuf` duplicated slice is a duplicate and not a slice anymore.
### Steps to reproduce
Duplicating a sliced `ByteBuf` is enough.
### Minimal yet complete reproducer code... | I would expect as well that It won't be expanded too
It might be illogical or unexpected, but it is specified to behave this way. The javadocs for `duplicate()` say that it returns…
```
A buffer whose readable content is equivalent to the buffer returned by {@link #slice()}.
However this buffer will share the ca... | 2024-06-03T05:48:43Z | 4.1 | [] | [
"org.io.netty.buffer.ReadOnlyByteBufTest"
] | Java | [] | [] |
netty/netty | 14,141 | netty__netty-14141 | [
"14137"
] | 217df76c40be0f9d4f82e8cf05d68ea07a23f42f | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java
@@ -547,7 +547,11 @@ publ... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java
+++ b/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java
@@ -379,6... | Malformed ipv6 through proxy
### Expected behavior
The CONNECT request send an well-formed ipv6
CONNECT [2001:0000:130F:0000:0000:09C0:876A:130B]:443
simple bracket
### Actual behavior
The CONNECT request send an malformed ipv6
CONNECT [[2001:0000:130F:0000:0000:09C0:876A:130B]]:443
double bracket
### Ste... | @dbeau35 we love PRs | 2024-06-24T10:48:53Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.HttpUtilTest"
] | Java | [] | [] |
netty/netty | 14,147 | netty__netty-14147 | [
"14046"
] | 967be496c6d9733062883344faec538b1854d2a8 | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java
+++ b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddress... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsAddressResolverGroupTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsAddressResolverGroupTest.java
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsAddressResolverGroupTest.java
+++ b/resolver-dns/src/test/java/io/netty/resolver/dn... | DNSResolve: DNS Cache Not Working in Certain Scenarios
1. In k8s environment, the concatenation of the hostname and searchDomain, can cause the DNS cache to become ineffective. I think if searchDomains are concatenated during DNS resolution, we should iterate through and concatenate all searchDomains to obtain the cach... | You are welcome to try fixing it. I recommend first making sure it's still a bug in the latest version. Then see if you can capture it in an automated test. Also feel free to discuss the ideas you have for how to fix it.
> You are welcome to try fixing it. I recommend first making sure it's still a bug in the latest v... | 2024-06-28T03:13:12Z | 4.1 | [] | [
"org.io.netty.resolver.dns.DnsAddressResolverGroupTest"
] | Java | [] | [] |
netty/netty | 7,531 | netty__netty-7531 | [
"7514"
] | c9668ce40f80f73763165a8bfe70969de830204c | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
+++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
@... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java
+++ b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDe... | hpackdecoder doesn't account for header overhead
Http/2 says for max header list size:
> SETTINGS_MAX_HEADER_LIST_SIZE (0x6): This advisory setting informs a
> peer of the maximum size of header list that the sender is
> prepared to accept, in octets. The value is based on the
> uncompresse... | @mosesn are you planing to work on a PR / unit test ?
Not right now, maybe in the next couple months? It's not causing us a problem, it just made debugging an issue we ran into a bit harder.
@mosesn got it
I may have a go at it. Sounds simple enough 😝
@madgnome yay :) | 2017-12-21T10:59:59Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.HpackDecoderTest"
] | Java | [] | [] |
netty/netty | 7,612 | netty__netty-7612 | [
"7607"
] | 27ff15319c2e566c44e333b9bd59cf210c130c2f | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
+++ b/codec-http2/src/main/java/io/netty/handler/codec/http... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
+++ b/codec-http2/src/test/java/io/netty/handle... | Http2MultiplexCodec leaks ping payloads
### Expected behavior
The payload of a PingFrame would be released or passed somewhere into the application for consumption.
### Actual behavior
It appears that `Http2PingFrame`s are dropped on the floor in the [`Http2MultiplexCodec.onHttp2Frame`](https://github.com/nett... | 2018-01-23T15:33:59Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.Http2MultiplexCodecTest"
] | Java | [] | [] | |
netty/netty | 7,824 | netty__netty-7824 | [
"7823"
] | 8d78893a76a8c14c18b304ffe1fce2dc43ed4206 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java
+++ b/codec-http/src/main/java/io/netty/handler/co... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java
+++ b/codec-http/src/test/java/io/nett... | HttpClientUpgradeHandler may clobber existing connection headers
### Expected behavior
`Connection` headers on a request that goes through the `HttpClientUpgradeHandler` should be preserved.
### Actual behavior
They are clobbered by the `Connection: Upgrade` header.
### Minimal yet complete reproducer code (or ... | The problem is pretty simple, it is that we're using `.set(CONNECTION, value)` [here](https://github.com/netty/netty/blob/4.1/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java#L280) where we should probably be using `.add(CONNECTION, value)`.
I'll open a PR, and if it turns out I've ... | 2018-03-30T20:35:47Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.HttpClientUpgradeHandlerTest"
] | Java | [] | [] |
netty/netty | 7,848 | netty__netty-7848 | [
"7847"
] | f8ff834f037e51b7119630bdb7713a29c18b8e31 | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
+++ b/codec-http2/src/main/java/io/netty/handler/c... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
+++ b/codec-http2/src/test/java/io/net... | Http2ConnectionHandler doesn't set the correct header state for streams generated from upgrades
### Expected behavior
When stream 1 is created from a h2c upgrade, the resultant stream should signal that it has sent the headers for the client, and that it has received the headers for the server.
### Actual behavio... | 2018-04-05T22:29:51Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.DefaultHttp2ConnectionTest"
] | Java | [] | [] | |
netty/netty | 7,975 | netty__netty-7975 | [
"7973"
] | 7f59896fba28ca1b14e13d2c7b3ba60f7af74027 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java
+++ b/co... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00Test.j... | WebsocketClientHandshaker can fail if multiple X-Websocket-Key headers are present on the upgrade request
### Expected behavior
A websockets handshake should not fail if a `X-Websockets-Key` header exists in the custom headers passed to the handshaker.
### Actual behavior
The handshake fails if the server pick... | One way to fix this could be to add the custom headers _first_, and the call `HttpHeaders#set` for each of the websocket-specific headers. It would require some re-ordering of calls in `WebSocketClientHandshaker13#newHandshakeRequest` (and variants).
One downside to this approach is that is would overwrite any heade... | 2018-05-26T23:29:35Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker13Test",
"org.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker07Test",
"org.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker00Test",
"org.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker08Test"... | Java | [] | [] |
netty/netty | 8,021 | netty__netty-8021 | [
"8018"
] | 3e3e5155b9bb4375fc4c95ac53c5c2ed8e8c5446 | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
+++ b/codec-http2/src/main/java/io/netty/handler/codec/http... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
+++ b/codec-http2/src/test/java/io/netty/handle... | Http2MultiplexCodec.DefaultHttp2StreamChannel.Http2ChannelUnsafe has a different order of close events than other channel implementation
The `HttpObjectAggregator`, when it encounters a too-large-message, [does the following](https://github.com/netty/netty/blob/4.1/codec-http/src/main/java/io/netty/handler/codec/http/H... | Presuming I haven't messed this up, I'd love to get this fixed before 4.1.26 since it would make it really difficult to use symmetric pipelines for our HTTP/2 and HTTP/1.x clients.
This sounds like a bug... interested in working on a PR?
Absolutely, just wanted confirmation that I wasn't just using it wrong. 😄
Just t... | 2018-06-13T19:41:16Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.Http2MultiplexCodecTest"
] | Java | [] | [] |
netty/netty | 8,046 | netty__netty-8046 | [
"8043"
] | 4a8d3a274cbad54daa652d6e9e082b4c1c843f84 | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
+++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
@... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java
+++ b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDe... | Invalid HTTP2 pseudo-headers kill the session instead of being treated as malformed
### Expected behavior
When a peer receives invalid pseudo headers the request or response should be treated as malformed as prescribed in section [8.1.2.1](https://http2.github.io/http2-spec/#rfc.section.8.1.2.1). This entails a stre... | This is causing minor issues for us migrating to version of Netty that included the commit associated with PR https://github.com/netty/netty/pull/7500. Those problems include killing connections in production (relatively infrequent, but happens enough to be noticed) and some failing tests. We can work around it by vali... | 2018-06-22T16:30:14Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.HpackDecoderTest"
] | Java | [] | [] |
netty/netty | 8,454 | netty__netty-8454 | [
"8429"
] | d4b1202e62e52dc9b5619e666f5b0033d8a32bc9 | diff --git a/codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java b/codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java
--- a/codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java
+++ b/codec/src/main/java/io/netty/handler/codec/MessageToMessageEncoder.java
@@ -2... | diff --git a/codec/src/test/java/io/netty/handler/codec/MessageToMessageEncoderTest.java b/codec/src/test/java/io/netty/handler/codec/MessageToMessageEncoderTest.java
--- a/codec/src/test/java/io/netty/handler/codec/MessageToMessageEncoderTest.java
+++ b/codec/src/test/java/io/netty/handler/codec/MessageToMessageEncode... | ChannelOption for FIRE_EXCEPTION_ON_FAILURE?
I want to be able to react to *any* outbound channel failure.
I can add a handler to the tail of my pipeline that will call `promise.addListener(ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE)` for every outbound event, but this is not sufficient.
Specifically, in the... | @Bennett-Lynch that's a good question.. I like the idea of the `ChannelOption` but I would need to investigate if this is easily doable without breaking any API (I suspect it should be doable).
@Bennett-Lynch https://github.com/netty/netty/pull/8448 PTAL | 2018-11-01T17:17:23Z | 4.1 | [] | [
"org.io.netty.handler.codec.MessageToMessageEncoderTest"
] | Java | [] | [] |
netty/netty | 8,471 | netty__netty-8471 | [
"8434"
] | 28f9136824499d7bca318f4496339d82fb42c46a | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoder.java
+++ b/codec-http2/src/main/ja... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionEncoderTest.java
+++ b/codec-http2... | HTTP/2 MultiplexCodec sends a RST_STREAM if the HEADERS fail to write due to HPACK issue
### Expected behavior
If the stream fails to write the headers due to a HPACK issue such as being larger than the MAX_HEADER_LIST_SIZE it should not send a RST_STREAM frame.
### Actual behavior
Sends a RST_STREAM frame.
... | @ejona86 @Scottmitch @carl-mastrangelo thoughts ?
While I agree that we shouldn't be sending RST_STREAM if the headers frame fails, I think "first frame" may be an over-simplification. At the very least, that would not be true for server-side. It took me hours to convince myself that https://github.com/netty/netty/pull... | 2018-11-06T17:49:27Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.DefaultHttp2ConnectionEncoderTest"
] | Java | [] | [] |
netty/netty | 8,482 | netty__netty-8482 | [
"8480"
] | 8a24df88a4ff5519176767aee01bf6186015d471 | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.java
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodec.java
+++ b/codec-http2... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodecTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2StreamFrameToHttpObjectCodecTest.java
+++ b... | Http2StreamFrameToHttpObjectCodec is marked @Sharable but is mutated by channel specific state
### Expected behavior
The `Http2StreamFrameToHttpObjectCodec` is either _not_ `@Sharable` _or_ it doesn't mutate its `scheme` field when added to a pipeline as it currently does [here](https://github.com/netty/netty/blob/4... | @bryce-anderson ouch... yes this is not good :( That said I suspect there will most likely not a lot of problems in real world use-cases as you either use SSL or not for all Channel (sharing between different parent Channels seems very unlikely).
That said we should fix. I guess an attribute on the parent channel sh... | 2018-11-08T21:31:50Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.Http2StreamFrameToHttpObjectCodecTest"
] | Java | [] | [] |
netty/netty | 8,611 | netty__netty-8611 | [
"6473"
] | a0c3081d8264b3e16d98a87a90250f26c6d9ed53 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/Combin... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java
+++ b/codec-http/src/test/java/io/netty/handler/codec... | CombinedHttpHeaders indiscriminately combines all headers
### Expected behavior
`CombinedHttpHeaders` combines all headers per name, even if they shouldn't be combined, like for example the `Set-Cookie` header (per [RFC-7230, section 3.2.2](https://tools.ietf.org/html/rfc7230#section-3.2.2)). In fact, there's only a... | thanks for reporting @ddossot !
@ddossot <3 | 2018-11-30T08:46:04Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.CombinedHttpHeadersTest"
] | Java | [] | [] |
netty/netty | 8,848 | netty__netty-8848 | [
"8846"
] | 737519314153f9146eaf532cd4e945a621cf3fa5 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java
+++ b/codec-http/src/main/java/io/netty/handler/co... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/CleartextHttp2ServerUpgradeHandlerTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/CleartextHttp2ServerUpgradeHandlerTest.java
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/CleartextHttp2ServerUpgradeHandlerTest.java
++... | When more than one connection header is present in h2c upgrade request, upgrade fails
### Expected behavior
$subject occurs, with this change https://github.com/netty/netty/pull/7824. (@bryce-anderson and @normanmaurer )
Now that more than one connection header is allowed with this https://github.com/netty/netty/pu... | @arukshani sounds about right... Are you interested in providing a PR to fix it ? /cc @bryce-anderson
Yup. Will send a PR with the fix @normanmaurer | 2019-02-06T15:11:03Z | 4.1 | [] | [
"org.io.netty.handler.codec.http2.CleartextHttp2ServerUpgradeHandlerTest"
] | Java | [] | [] |
netty/netty | 9,020 | netty__netty-9020 | [
"8912"
] | e63c596f24d2aa0a52f2a8132ad1283952b45aea | diff --git a/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java b/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
--- a/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
+++ b/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
@@ -129,6 +129,7 ... | diff --git a/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java b/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java
--- a/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java
+++ b/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java
@... | Handling slow clients / detecting idleness
### Expected behavior
When using `IdleStateHandler` with `observeOutput=true` the `IdleStateEvent.WRITER_IDLE` or `IdleStateEvent.ALL_IDLE` should not trigger because of slow clients.
This is same issue as in #6150.
### Actual behavior
The `IdleStateHandler` triggers `... | I mean the idleStateHandler triggers when a channel has not performed a read or write action([in the doc](https://netty.io/4.0/api/io/netty/handler/timeout/IdleStateHandler.html))!
You specify that when the channel is not read for 10 seconds then trigger and in the client, you only read all 10 seconds (without subtr... | 2019-04-07T14:54:56Z | 4.1 | [] | [
"org.io.netty.handler.timeout.IdleStateHandlerTest"
] | Java | [] | [] |
netty/netty | 9,098 | netty__netty-9098 | [
"9092"
] | ec62af01c7af372d853bd1a2d2d981a897263b6d | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
--- a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
+++ b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerCo... | diff --git a/transport/src/test/java/io/netty/channel/embedded/EmbeddedChannelTest.java b/transport/src/test/java/io/netty/channel/embedded/EmbeddedChannelTest.java
--- a/transport/src/test/java/io/netty/channel/embedded/EmbeddedChannelTest.java
+++ b/transport/src/test/java/io/netty/channel/embedded/EmbeddedChannelTes... | EmbeddedChannel Close Regression with 4.1.35.Final
In one of my unit tests I have code like:
```java
final Throwable expectedCause = new Exception("something failed");
EmbeddedChannel channel = new EmbeddedChannel(new ChannelOutboundHandlerAdapter() {
@Override
public void close(ChannelHandle... | Nope will look into it next week.
Does it work when calling channel.close() ?
> Am 26.04.2019 um 14:40 schrieb Michael Nitschinger <notifications@github.com>:
>
> In one of my unit tests I have code like:
>
> final Throwable expectedCause = new Exception("something failed");
> EmbeddedChannel channel = new ... | 2019-04-27T10:44:21Z | 4.1 | [] | [
"org.io.netty.channel.embedded.EmbeddedChannelTest"
] | Java | [] | [] |
netty/netty | 9,270 | netty__netty-9270 | [
"9269"
] | 517a93d87d5c65e3c4bedf4a77183583991f32e1 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java
+++ b/codec-http/src/main/... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoderTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoderTest.java
+++ b/codec-ht... | HttpPostRequestEncoder will overwrite the original filename when switching to mixed mode
### Expected behavior
The `HttpPostRequestEncoder` preserves the original filename of file uploads sharing the same name encoded in mixed mode.
### Actual behavior
The `HttpPostRequestEncoder` overwrites the original filename... | 2019-06-23T21:36:48Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.multipart.HttpPostRequestEncoderTest"
] | Java | [] | [] | |
netty/netty | 9,312 | netty__netty-9312 | [
"9134"
] | b02ee1106f81a97334c076e5510d7f90d4f4e224 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13.java
+++ b/co... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.j... | WebSocketClientHandshaker13 Invalid Handshake
### Expected behavior
Origin Header should be sent on handshake
### Actual behavior
Sec-WebSocket-Origin Header is sent instead which is not a client handshake but rather a server to client origin handshake per the Specification
| @davydotcom do you have a reproducer ?
Use websocket client in netty in any way and it’s very easily reproduced code is wrong in handshaker
Sent from my iPhone
> On May 8, 2019, at 3:12 AM, Norman Maurer <notifications@github.com> wrote:
>
> @davydotcom do you have a reproducer ?
>
> —
> You are receiving this beca... | 2019-07-01T20:12:41Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker13Test",
"org.io.netty.handler.codec.http.websocketx.WebSocketClientHandshaker07Test"
] | Java | [] | [] |
netty/netty | 9,477 | netty__netty-9477 | [
"9475"
] | 97361fa2c89da57e88762aaca9e2b186e8c148f5 | diff --git a/common/src/main/java/io/netty/util/AsciiString.java b/common/src/main/java/io/netty/util/AsciiString.java
--- a/common/src/main/java/io/netty/util/AsciiString.java
+++ b/common/src/main/java/io/netty/util/AsciiString.java
@@ -532,7 +532,7 @@ public boolean contentEqualsIgnoreCase(CharSequence string) {
... | diff --git a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
--- a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
+++ b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java
@@ -37,6 +37,15 @@
public class ... | AsciiString contentEqualsIgnoreCase fails when arrayOffset is non-zero
### Expected behavior
AsciiString.contentEqualsIgnoreCase is expected to work.
### Actual behavior
AsciiString.contentEqualsIgnoreCase may return true for non-matching strings of equal length
### Steps to reproduce
Create AsciiString with n... |
[asciistring.diff.gz](https://github.com/netty/netty/files/3511592/asciistring.diff.gz)
Thanks @atcurtis, good catch! Could you submit a PR with your fix and unit test? | 2019-08-17T03:25:10Z | 4.1 | [] | [
"org.io.netty.util.AsciiStringCharacterTest"
] | Java | [] | [] |
netty/netty | 9,647 | netty__netty-9647 | [
"9634"
] | bd8cea644a07890f5bada18ddff0a849b58cd861 | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
+++ b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
@@ -50,7 +50,... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java
+++ b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.ja... | DNS Resolver leaking direct memory
### Expected behavior
DNS resolver does not leak direct memory when buffers are freed correctly.
### Actual behavior
Memory is leaked, JVM runs out of direct memory.
```
[error] Exception in thread "main" io.netty.resolver.dns.DnsNameResolverException: [/10.0.2.3:53] fail... | @dziemba could you also try running it with `-Dio.netty.leakDetection.level=paranoid`? | 2019-10-08T23:23:49Z | 4.1 | [] | [
"org.io.netty.resolver.dns.DnsNameResolverTest"
] | Java | [] | [] |
netty/netty | 9,670 | netty__netty-9670 | [
"9668"
] | 2e5dd288008d4e674f53beaf8d323595813062fb | diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
--- a/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
+++ b/codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java
@@ -81,7 +81,7 @@... | diff --git a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
--- a/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
+++ b/codec/src/test/java/io/netty/handler/codec/ByteToMessageDecoderTest.java
@... | remove handler cause ByteToMessageDecoder out disorder
### remove handler cause ByteToMessageDecoder out disorder
I input byte stream [1,2,3,4,5], when i read `4` then remove ByteToMessageDecoder,
the out is stream [1,2,3,5,4]
Here are the test cases，the cases will fail
```
@Test
public void t... | @normanmaurer thanks | 2019-10-15T13:15:10Z | 4.1 | [] | [
"org.io.netty.handler.codec.ByteToMessageDecoderTest"
] | Java | [] | [] |
netty/netty | 9,691 | netty__netty-9691 | [
"9667"
] | 247a4db470d58c5087fb4f2388a18be42b0ce9d0 | diff --git a/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java b/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java
--- a/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java
+++ b/handler/src/main/java/io/netty/handler/flow/FlowControlHandler.java
@@ -154,9 +154,13 @@ ... | diff --git a/handler/src/test/java/io/netty/handler/flow/FlowControlHandlerTest.java b/handler/src/test/java/io/netty/handler/flow/FlowControlHandlerTest.java
--- a/handler/src/test/java/io/netty/handler/flow/FlowControlHandlerTest.java
+++ b/handler/src/test/java/io/netty/handler/flow/FlowControlHandlerTest.java
@@ -2... | FlowControllerHandler swallows read-complete event when auto-read is disabled
### Expected behavior
IdleStateHandler should trigger read-timeout events when registered after FlowControlHandler.
### Actual behavior
IdleStateHandler does NOT trigger read-timeout event.
### Steps to reproduce
Server pipelin... | @ursaj sounds legit. Want to do a PR ? | 2019-10-18T20:02:24Z | 4.1 | [] | [
"org.io.netty.handler.flow.FlowControlHandlerTest"
] | Java | [] | [] |
netty/netty | 9,692 | netty__netty-9692 | [
"9673"
] | 95230e01da5d9cf2447a9d09d4c42bf42eb7d479 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java
+++ b/codec-ht... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshakerTest.java
++... | Origin header is always sent from WebSocket client
### Expected behavior
No 'Origin' header sent by default.
A way to set custom 'Origin' header when it is needed.
### Actual behavior
'Origin' header is set.
'Origin' header is auto-resolved into meaningless value. In my case - IP of the intermediate proxy be... | Hi, @ursaj. I agree that `Origin` and `Sec-WebSocket-Origin` is not required according the spec https://tools.ietf.org/html/rfc6455#section-1.3 `Origin/Sec-WebSocket-Origin header field is sent by browser clients; for non-browser clients, this header field may be sent if it makes sense in the context of those clients`... | 2019-10-18T20:54:40Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.websocketx.WebSocketHandshakeHandOverTest"
] | Java | [] | [] |
netty/netty | 9,940 | netty__netty-9940 | [
"9939"
] | ac69c877f1a9857fd8a97c704c882414e66c4920 | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketServerExtensionHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketServerExtensionHandler.java
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/extensions/... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketServerExtensionHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/extensions/WebSocketServerExtensionHandlerTest.java
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/ext... | WebSocketServerExtensionHandler not removed from pipeline if client has not selected any extensions
### Expected behavior
After successful WebSocket handshake `WebSocketServerExtensionHandler` should be removed from pipeline to keep it short as possible.
### Actual behavior
If client has not selected any extension... | 2020-01-10T15:20:40Z | 4.1 | [] | [
"org.io.netty.handler.codec.http.websocketx.extensions.WebSocketServerExtensionHandlerTest"
] | Java | [] | [] | |
tqdm/tqdm | 1,040 | tqdm__tqdm-1040 | [
"450"
] | e835860982dac417ddb351452544d6e07baeb5b8 | diff --git a/tqdm/notebook.py b/tqdm/notebook.py
--- a/tqdm/notebook.py
+++ b/tqdm/notebook.py
@@ -184,6 +184,16 @@ def display(self, msg=None, pos=None,
except AttributeError:
self.container.visible = False
+ @property
+ def colour(self):
+ if hasattr(self, 'container'):
+ ... | diff --git a/tqdm/tests/tests_tqdm.py b/tqdm/tests/tests_tqdm.py
--- a/tqdm/tests/tests_tqdm.py
+++ b/tqdm/tests/tests_tqdm.py
@@ -15,7 +15,7 @@
from tqdm import tqdm
from tqdm import trange
-from tqdm import TqdmDeprecationWarning
+from tqdm import TqdmDeprecationWarning, TqdmWarning
from tqdm.std import Bar
fro... | Colored Progress Bars
With a few tweaks in the code I managed to add a color argument to tqdm.
Is this already an implemented feature ? Anyone likes it ?
| colours seem a bit distracting. If you do want them:
```python
from tqdm import trange
from colorama import Fore
for i in trange(int(7e7),
bar_format="{l_bar}%s{bar}%s{r_bar}" % (Fore.BLUE, Fore.RESET)):
pass
```
Both above mentioned methods are not working with notebook, any idea why?
notebooks ... | 2020-09-27T17:21:23Z | 4.49 | [
"tqdm/tests/tests_tqdm.py::test_format_interval",
"tqdm/tests/tests_tqdm.py::test_format_num",
"tqdm/tests/tests_tqdm.py::test_format_meter",
"tqdm/tests/tests_tqdm.py::test_ansi_escape_codes",
"tqdm/tests/tests_tqdm.py::test_si_format",
"tqdm/tests/tests_tqdm.py::test_bar_formatspec",
"tqdm/tests/tests... | [
"tqdm/tests/tests_tqdm.py::test_colour"
] | Python | [] | [] |
tqdm/tqdm | 1,041 | tqdm__tqdm-1041 | [
"450",
"1032"
] | 3f7e8e9642388e73cabca34c975b9c005bc6d8b3 | diff --git a/tqdm/notebook.py b/tqdm/notebook.py
--- a/tqdm/notebook.py
+++ b/tqdm/notebook.py
@@ -106,14 +106,11 @@ def status_printer(_, total=None, desc=None, ncols=None):
if ncols is None:
pbar.layout.width = "20px"
+ ltext = HTML()
+ rtext = HTML()
if desc:
- ... | diff --git a/tqdm/tests/tests_perf.py b/tqdm/tests/tests_perf.py
--- a/tqdm/tests/tests_perf.py
+++ b/tqdm/tests/tests_perf.py
@@ -293,13 +293,13 @@ def test_manual_overhead_hard():
total = int(1e5)
with closing(MockIO()) as our_file:
- t = tqdm(total=total * 10, file=our_file, leave=True, miniters=1... | Colored Progress Bars
With a few tweaks in the code I managed to add a color argument to tqdm.
Is this already an implemented feature ? Anyone likes it ?
notebook: fix description width for unk... | colours seem a bit distracting. If you do want them:
```python
from tqdm import trange
from colorama import Fore
for i in trange(int(7e7),
bar_format="{l_bar}%s{bar}%s{r_bar}" % (Fore.BLUE, Fore.RESET)):
pass
```
| 2020-09-27T19:38:45Z | 4.49 | [
"tqdm/tests/tests_perf.py::test_iter_overhead",
"tqdm/tests/tests_perf.py::test_manual_overhead",
"tqdm/tests/tests_perf.py::test_lock_args",
"tqdm/tests/tests_perf.py::test_iter_overhead_hard",
"tqdm/tests/tests_perf.py::test_manual_overhead_hard",
"tqdm/tests/tests_perf.py::test_iter_overhead_simplebar_... | [
"tqdm/tests/tests_tqdm.py::test_colour",
"tqdm/tests/tests_tqdm.py::test_closed"
] | Python | [] | [] |
tqdm/tqdm | 227 | tqdm__tqdm-227 | [
"284",
"282"
] | cd9be03c3ee2a7e14d3e2c90976c092de17265f9 | diff --git a/mkdocs.py b/mkdocs.py
new file mode 100644
--- /dev/null
+++ b/mkdocs.py
@@ -0,0 +1,58 @@
+from __future__ import print_function
+import tqdm
+from textwrap import dedent
+from io import open as io_open
+from os import path
+
+HEAD_ARGS = """
+Parameters
+----------
+"""
+HEAD_RETS = """
+Returns
+-------
... | diff --git a/tqdm/tests/tests_tqdm.py b/tqdm/tests/tests_tqdm.py
--- a/tqdm/tests/tests_tqdm.py
+++ b/tqdm/tests/tests_tqdm.py
@@ -69,16 +69,16 @@ def pos_line_diff(res_list, expected_list, raise_nonempty=True):
Return differences between two bar output lists.
To be used with `RE_pos`
"""
- l = len(re... | Allow bar_format without total or len(iterable)
(This builds on https://github.com/tqdm/tqdm/pull/283 to allow me to test it locally.)
This PR is a solution to my issue here: https://github.com/tqdm/tqdm/issues/282 .
Allow bar_format without total
Thanks for `tqdm`! It's a wonderful tool.
In order to use `bar_forma... | ## [Current coverage](https://codecov.io/gh/tqdm/tqdm/pull/284?src=pr) is 90.49% (diff: 100%)
> Merging [#284](https://codecov.io/gh/tqdm/tqdm/pull/284?src=pr) into [master](https://codecov.io/gh/tqdm/tqdm/branch/master?src=pr) will decrease coverage by **1.27%**
``` diff
@@ master #284 diff @@
==... | 2016-08-06T13:37:53Z | 4.30 | [
"tqdm/tests/tests_tqdm.py::test_format_interval",
"tqdm/tests/tests_tqdm.py::test_format_num",
"tqdm/tests/tests_tqdm.py::test_format_meter",
"tqdm/tests/tests_tqdm.py::test_ansi_escape_codes",
"tqdm/tests/tests_tqdm.py::test_si_format",
"tqdm/tests/tests_tqdm.py::test_all_defaults",
"tqdm/tests/tests_t... | [
"tqdm/tests/tests_tqdm.py::test_nototal"
] | Python | [] | [] |
tqdm/tqdm | 250 | tqdm__tqdm-250 | [
"249"
] | 86292e571a77d42daebad80edab0001710c11ef5 | diff --git a/examples/simple_examples.py b/examples/simple_examples.py
--- a/examples/simple_examples.py
+++ b/examples/simple_examples.py
@@ -28,8 +28,22 @@
pass
# Comparison to https://code.google.com/p/python-progressbar/
-from progressbar.progressbar import ProgressBar
-for i in ProgressBar()(_range(int(1e8... | diff --git a/tqdm/tests/tests_tqdm.py b/tqdm/tests/tests_tqdm.py
--- a/tqdm/tests/tests_tqdm.py
+++ b/tqdm/tests/tests_tqdm.py
@@ -382,9 +382,9 @@ def test_max_interval():
total = 100
bigstep = 10
smallstep = 5
- timer = DiscreteTimer()
# Test without maxinterval
+ timer = DiscreteTimer()
... | tqdm hangs up with highly irregular iterations speed
This is basically the same issue as #54, but that one is closed. The problem still persists, consider this example:
``` python
for i in tqdm.trange(1000):
if i > 500:
sleep(10)
```
It updates first time after the first 10-sec iteration, and the second t... | This is not how `maxinterval` works (even if I would like it very much!): `maxinterval` kicks in only after the last refresh being longer than the `maxinterval` threshold and then readjust the internal parameters so that next refresh will be every 10 seconds (hopefully).
In your particular example, yes at iteration 50... | 2016-08-28T10:34:11Z | 4.9 | [
"tqdm/tests/tests_tqdm.py::test_format_interval",
"tqdm/tests/tests_tqdm.py::test_format_meter",
"tqdm/tests/tests_tqdm.py::test_si_format",
"tqdm/tests/tests_tqdm.py::test_all_defaults",
"tqdm/tests/tests_tqdm.py::test_iterate_over_csv_rows",
"tqdm/tests/tests_tqdm.py::test_file_output",
"tqdm/tests/te... | [
"tqdm/tests/tests_tqdm.py::test_dynamic_min_iters",
"tqdm/tests/tests_tqdm.py::test_max_interval"
] | Python | [] | [] |
tqdm/tqdm | 292 | tqdm__tqdm-292 | [
"276",
"539",
"292"
] | a4b9c86db548b2d0dbb5af7a6bbdc26ab47e1eec | diff --git a/tqdm/_tqdm.py b/tqdm/_tqdm.py
--- a/tqdm/_tqdm.py
+++ b/tqdm/_tqdm.py
@@ -853,7 +853,7 @@ def __len__(self):
return self.total if self.iterable is None else \
(self.iterable.shape[0] if hasattr(self.iterable, "shape")
else len(self.iterable) if hasattr(self.iterable, "__... | diff --git a/tqdm/tests/tests_synchronisation.py b/tqdm/tests/tests_synchronisation.py
--- a/tqdm/tests/tests_synchronisation.py
+++ b/tqdm/tests/tests_synchronisation.py
@@ -1,11 +1,11 @@
from __future__ import division
-from tqdm import tqdm
-from tests_tqdm import with_setup, pretest, posttest, StringIO, closing
+f... | Specify `tqdm_notebook` bar width
Thanks to the maintainers for this incredible tool!
I'm wondering how to specify the width of a progress bar in a Jupyter notebook, since the default is pretty small. The `tqdm_notebook` function doesn't seem to respect the `ncols` or `dynamic_ncols` keyword arguments of `tqdm`.
Is ... | Unluckily, no it doesn't seem to be possible with ipywidgets, as there is no argument to specify the width of the progress bar. I guess the progress bar gets resized depending on cell size, thus on screen size, but I'm not sure about that.
If you want this feature you [may try to ask them directly](https://github.com/... | 2016-10-17T01:04:02Z | 4.22 | [
"tqdm/tests/tests_synchronisation.py::test_monitor_thread",
"tqdm/tests/tests_synchronisation.py::test_monitoring_and_cleanup",
"tqdm/tests/tests_synchronisation.py::test_monitoring_multi"
] | [
"tqdm/tests/tests_synchronisation.py::test_imap"
] | Python | [] | [] |
tqdm/tqdm | 329 | tqdm__tqdm-329 | [
"422"
] | 17072850f467748f57b1072beb8ecac56242c78a | diff --git a/examples/parallel_bars.py b/examples/parallel_bars.py
new file mode 100644
--- /dev/null
+++ b/examples/parallel_bars.py
@@ -0,0 +1,29 @@
+from __future__ import print_function
+from time import sleep
+from tqdm import tqdm
+from multiprocessing import Pool, freeze_support, Lock
+
+
+L = list(range(9))
+
+... | diff --git a/tqdm/tests/tests_tqdm.py b/tqdm/tests/tests_tqdm.py
--- a/tqdm/tests/tests_tqdm.py
+++ b/tqdm/tests/tests_tqdm.py
@@ -1125,28 +1125,27 @@ def test_position():
@with_setup(pretest, posttest)
def test_set_description():
- """Test set description"""
- with closing(StringIO()) as our_file:
- with... | Redirect both sys.stdout and sys.stderr
I have a function from another library that occasionally prints to both stdout and stderr. I cannot hack the source code of that function.
While [the example](https://stackoverflow.com/questions/36986929/redirect-print-command-in-python-script-through-tqdm-write) shows how to... | 2016-12-28T19:54:35Z | 4.17 | [
"tqdm/tests/tests_tqdm.py::test_format_interval",
"tqdm/tests/tests_tqdm.py::test_format_meter",
"tqdm/tests/tests_tqdm.py::test_si_format",
"tqdm/tests/tests_tqdm.py::test_all_defaults",
"tqdm/tests/tests_tqdm.py::test_iterate_over_csv_rows",
"tqdm/tests/tests_tqdm.py::test_file_output",
"tqdm/tests/te... | [
"tqdm/tests/tests_tqdm.py::test_file_redirection"
] | Python | [] | [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.