issue_owner_repo
listlengths
2
2
issue_body
stringlengths
0
261k
issue_title
stringlengths
1
925
issue_comments_url
stringlengths
56
81
issue_comments_count
int64
0
2.5k
issue_created_at
stringlengths
20
20
issue_updated_at
stringlengths
20
20
issue_html_url
stringlengths
37
62
issue_github_id
int64
387k
2.91B
issue_number
int64
1
131k
[ "WebAssembly", "wabt" ]
Binaryen set a good precedent here, it would be better to be more careful about the types that we use for manipulating wasm binaries.
Use Index/Address/Offset types instead of size_t/int, etc.
https://api.github.com/repos/WebAssembly/wabt/issues/322/comments
0
2017-02-27T21:57:53Z
2017-05-23T03:38:37Z
https://github.com/WebAssembly/wabt/issues/322
210,619,734
322
[ "WebAssembly", "wabt" ]
This would be a useful tag as NodeJS nightly and stable browsers are still expecting this version.
Tag binary_0xd
https://api.github.com/repos/WebAssembly/wabt/issues/321/comments
1
2017-02-27T09:56:24Z
2017-02-27T10:42:33Z
https://github.com/WebAssembly/wabt/issues/321
210,435,958
321
[ "WebAssembly", "wabt" ]
As mentioned by @dschuff [here](https://github.com/WebAssembly/wabt/issues/308#issuecomment-280735411), we'll want to reconsider the wabt API for C++. The easiest thing would be to have an internal IR, similar to the one we already have in ast.h. We can then have functions that parse text/binary format and produce t...
New Wabt API
https://api.github.com/repos/WebAssembly/wabt/issues/316/comments
0
2017-02-24T01:22:38Z
2022-05-19T01:25:28Z
https://github.com/WebAssembly/wabt/issues/316
209,934,031
316
[ "WebAssembly", "wabt" ]
See comment here: https://github.com/WebAssembly/wabt/pull/309#discussion_r102598479
Add static_assert to ensure that Bison stack is trivially copyable
https://api.github.com/repos/WebAssembly/wabt/issues/314/comments
0
2017-02-24T00:15:06Z
2017-03-07T00:51:31Z
https://github.com/WebAssembly/wabt/issues/314
209,923,902
314
[ "WebAssembly", "wabt" ]
I've been thinking about it, and pretty much everybody has said it is a hassle using C. I like it, but that's a silly reason to keep it this way, as maintainability suffers greatly when I'm the only one who wants to hack on the code :) I'd like to start moving toward using C++ incrementally. Here are some thoughts o...
Move to C++
https://api.github.com/repos/WebAssembly/wabt/issues/308/comments
13
2017-02-17T18:36:50Z
2017-09-04T20:01:02Z
https://github.com/WebAssembly/wabt/issues/308
208,521,805
308
[ "WebAssembly", "wabt" ]
Earlier, I was surprised to find that `wasm2wast` does not validate the binary, but `wast2wasm` does, unless you ask it not to. `wasmdump` also does not. So we should probably reconcile these behaviors somehow. Probably `wasmdump` should not validate, since its purpose is to show a low-level view of the binary. Probabl...
Validation behavior for wabt tools
https://api.github.com/repos/WebAssembly/wabt/issues/306/comments
5
2017-02-16T00:42:47Z
2017-06-29T17:29:23Z
https://github.com/WebAssembly/wabt/issues/306
207,977,142
306
[ "WebAssembly", "wabt" ]
I hit this when working on binaryen's type system change fuzz testcases, it hits > wasm2wast: /home/alon/Dev/wabt/src/binary-reader-ast.c:291: WabtResult on_function_signature(uint32_t, uint32_t, void *): Assertion `index < ctx->module->funcs.capacity' failed.
Assertion on wasm file
https://api.github.com/repos/WebAssembly/wabt/issues/304/comments
2
2017-02-15T21:57:46Z
2017-02-16T19:03:05Z
https://github.com/WebAssembly/wabt/issues/304
207,941,257
304
[ "WebAssembly", "wabt" ]
The debate about validating code after unconditional branches/unreachable (https://github.com/WebAssembly/design/pull/894) hasn't really been resolved, and part of the debate hinges on its effect on producers, so it would be nice if wabt had a validation mode (or even just a prototype PR) to reject such structurally-un...
validation mode for structurally-unreachable code
https://api.github.com/repos/WebAssembly/wabt/issues/299/comments
1
2017-01-31T21:01:57Z
2017-02-15T23:13:57Z
https://github.com/WebAssembly/wabt/issues/299
204,422,242
299
[ "WebAssembly", "wabt" ]
When running `./wast2wasm third_party\testsuite\labels.wast --spec --no-check-assert-invalid-and-malformed -o bug\labels.json` I get the following error `Assertion failed: var->type == WASM_VAR_TYPE_INDEX, file E:\Projects\wabt\src\binary-writer.c, line 316` This started when the spec test were updated. The fai...
Wast2Wasm: Assertion failed: var->type == WASM_VAR_TYPE_INDEX
https://api.github.com/repos/WebAssembly/wabt/issues/292/comments
0
2017-01-25T21:22:52Z
2017-01-26T23:34:03Z
https://github.com/WebAssembly/wabt/issues/292
203,226,120
292
[ "WebAssembly", "wabt" ]
With this binary: ``` $ hexdump -C t.o 00000000 00 61 73 6d 0d 00 00 00 01 84 80 80 80 00 01 60 |.asm...........`| 00000010 00 00 03 82 80 80 80 00 01 00 06 86 80 80 80 00 |................| 00000020 01 7f 01 41 00 0b 07 90 80 80 80 00 02 03 62 61 |...A..........ba| 00000030 72 00 00 06 64 5f 67 6c 6f ...
wasm2wast prints incorrect name for global export
https://api.github.com/repos/WebAssembly/wabt/issues/286/comments
0
2017-01-22T00:26:22Z
2017-01-26T06:41:57Z
https://github.com/WebAssembly/wabt/issues/286
202,349,524
286
[ "WebAssembly", "wabt" ]
wasmdump -v prints functions with their function-index-space indices, which includes imports: ``` IMPORT: - func[0] sig=8 <- env.__syscall6 - func[1] sig=8 <- env.__syscall140 - func[2] sig=12 <- env.sbrk - func[3] sig=13 <- env.abort FUNCTION: - func[4] sig=0 - func[5] sig=1 - func[6] sig=1 ``` Ho...
function-section index versus function-index-space index
https://api.github.com/repos/WebAssembly/wabt/issues/277/comments
1
2017-01-17T22:49:56Z
2017-01-18T19:08:56Z
https://github.com/WebAssembly/wabt/issues/277
201,428,988
277
[ "WebAssembly", "wabt" ]
Often the string slices that are using the hash are part of the input file, or otherwise not individually free-able, but WasmBindingHash currently assumes it can/should destroy all the names when it is destroyed. A simple flag in the binding data structure would be enough for most cases since I imagine this is an ...
Make ownership of string names in WasmBindingHash optional
https://api.github.com/repos/WebAssembly/wabt/issues/275/comments
1
2017-01-13T19:38:50Z
2017-03-27T21:36:49Z
https://github.com/WebAssembly/wabt/issues/275
200,712,743
275
[ "WebAssembly", "wabt" ]
right now there is a mix of pass-by-pointer and pass-by-value. I guess we should probably be consistent and try to pass by pointer or const pointer whereever possible, even through the structure is small.
We should be consistent about how we pass WasmStringSlice
https://api.github.com/repos/WebAssembly/wabt/issues/274/comments
2
2017-01-13T19:36:46Z
2017-07-25T21:38:35Z
https://github.com/WebAssembly/wabt/issues/274
200,712,224
274
[ "WebAssembly", "wabt" ]
With the change in d3c6c973d9c5fe13ad1066d5de47470a41b54943, wasm2wast etc. seem to handle the end of the reloc section differently. With this binary: ``` $ hexdump -C t.o 00000000 00 61 73 6d 0d 00 00 00 01 84 80 80 80 00 01 60 |.asm...........`| 00000010 00 00 02 8e 80 80 80 00 01 03 65 6e 76 06 70 72 |.......
decoding the end of the reloc section
https://api.github.com/repos/WebAssembly/wabt/issues/272/comments
8
2017-01-11T17:06:17Z
2017-01-17T21:19:27Z
https://github.com/WebAssembly/wabt/issues/272
200,151,167
272
[ "WebAssembly", "wabt" ]
@dschuff and I couldn't find a way to dump the contents of a custom section by name. Did we just miss it?
Dump raw contents of a single custom section?
https://api.github.com/repos/WebAssembly/wabt/issues/267/comments
1
2017-01-06T22:41:09Z
2017-01-10T14:23:37Z
https://github.com/WebAssembly/wabt/issues/267
199,308,668
267
[ "WebAssembly", "wabt" ]
Hello. Could you add support to freebsd build? I have tried to make but unsuccessful. # git clone --recursive https://github.com/WebAssembly/wabt # cd wabt/ # gmake mkdir -p out/clang/Debug/ cd out/clang/Debug/ && cmake -G "Unix Makefiles" /tmp/wabt/ -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAK...
Add support to Freebsd build
https://api.github.com/repos/WebAssembly/wabt/issues/262/comments
3
2017-01-03T17:06:03Z
2017-01-04T19:34:36Z
https://github.com/WebAssembly/wabt/issues/262
198,520,424
262
[ "WebAssembly", "wabt" ]
Now that WebAssembly.LinkError is a thing: https://github.com/WebAssembly/design/blob/master/JS.md#constructor-properties-of-the-webassembly-object this code should probably go from: ``` function assert_unlinkable(bytes) { let mod = module(bytes); try { new WebAssembly.Instance(mod, registry) } catch (e) ...
assert_unlinkable should check for LinkError instead of type error
https://api.github.com/repos/WebAssembly/wabt/issues/259/comments
0
2016-12-27T18:50:08Z
2017-01-03T20:04:22Z
https://github.com/WebAssembly/wabt/issues/259
197,743,027
259
[ "WebAssembly", "wabt" ]
The following code (from a test written for pre-0xa wast) causes the validator to assert: ``` (module (func $foo (param f32) (call $foo (f32.const 0.0)))) ``` ``` assertion failed: (var->type == WASM_VAR_TYPE_INDEX), function check_var, file /Users/dschuff/code/WAOT/third_party/wabt/src/validator.c, line 1...
Assertion failure in validator
https://api.github.com/repos/WebAssembly/wabt/issues/258/comments
2
2016-12-27T05:48:34Z
2017-01-07T00:00:09Z
https://github.com/WebAssembly/wabt/issues/258
197,650,278
258
[ "WebAssembly", "wabt" ]
I'm compiling the memory.wast test from the spec to JS code: https://github.com/WebAssembly/spec/blob/b055d01ea1dfdd7a5231ae779095435f836de97f/interpreter/test/memory.wast The output I get is this: https://gist.github.com/saambarati/74490ce6882d121ffd5933f288e9e69d If you look at the 3rd, 4th, and 5th call to a...
It doesn't appear that the data section is being generated for a particular wast file when running run-gen-spec-test.py
https://api.github.com/repos/WebAssembly/wabt/issues/256/comments
4
2016-12-24T18:46:15Z
2016-12-27T18:45:05Z
https://github.com/WebAssembly/wabt/issues/256
197,473,585
256
[ "WebAssembly", "wabt" ]
I'm running wasmdump on what I believe is a malformed binary: ``` /Projects/wabt$ hexdump -C x.o 00000000 00 61 73 6d 0d 00 00 00 01 84 80 80 80 00 01 60 |.asm...........`| 00000010 00 00 02 90 80 80 80 00 01 03 65 6e 76 09 73 6f |..........env.so| 00000020 6d 65 74 68 69 6e 67 03 03 82 80 80 80 00 01 00...
Error message isn't printed due to invalid conversions through void*
https://api.github.com/repos/WebAssembly/wabt/issues/233/comments
2
2016-12-03T03:29:09Z
2016-12-05T15:13:22Z
https://github.com/WebAssembly/wabt/issues/233
193,262,454
233
[ "WebAssembly", "wabt" ]
Since 0xd, the names section names anything in the function index space, which includes imports as well as locally-defined functions. Wabt and v8 haven't been updated to handle this yet, but Spidermonkey and Binaryen have.
Update Names section for 0xd
https://api.github.com/repos/WebAssembly/wabt/issues/215/comments
2
2016-11-11T19:38:10Z
2016-11-14T20:09:32Z
https://github.com/WebAssembly/wabt/issues/215
188,834,289
215
[ "WebAssembly", "wabt" ]
I was investigating some breakage from https://github.com/WebAssembly/binaryen/pull/831 (v8 isn't up to date with the Names section changes) and found that wasmdump doesn't print the header for the names section when it's present. Looking at the code, it looks like the intention is that it should, and it's not immediat...
wasmdump doesn't seem to dump Names section
https://api.github.com/repos/WebAssembly/wabt/issues/214/comments
3
2016-11-11T19:34:57Z
2016-11-19T00:20:14Z
https://github.com/WebAssembly/wabt/issues/214
188,833,654
214
[ "WebAssembly", "wabt" ]
I see the new spec json format is more oriented toward running in wasminterp. I was wondering if there is anything left to help running in a javascript host ? I ask mainly for int64 where the only solution I can think of is to generate a module on the fly with the int64 hardcoded value that will import the function I...
Spec JSON new format question
https://api.github.com/repos/WebAssembly/wabt/issues/203/comments
3
2016-11-03T23:28:03Z
2016-11-30T18:31:58Z
https://github.com/WebAssembly/wabt/issues/203
187,217,056
203
[ "WebAssembly", "wabt" ]
It would be nice if we could call wasm-interp with a specific function and arguments
wasm-interp arguments
https://api.github.com/repos/WebAssembly/wabt/issues/198/comments
1
2016-10-31T21:47:32Z
2023-03-19T18:48:41Z
https://github.com/WebAssembly/wabt/issues/198
186,406,405
198
[ "WebAssembly", "wabt" ]
Currently we allow an empty expression for something like `(module (global i32))`, but this is illegal. @sbc100
read_init_expr should not allow an empty expression
https://api.github.com/repos/WebAssembly/wabt/issues/188/comments
0
2016-10-25T20:58:57Z
2016-11-10T22:43:20Z
https://github.com/WebAssembly/wabt/issues/188
185,232,230
188
[ "WebAssembly", "wabt" ]
We should have a windows continuous build with GH integration. An external contributor wrote a build file for Binaryen (https://github.com/WebAssembly/binaryen/pull/623) and I set up a WebAssembly AppVeyor account to run it; we can probably just copy from that.
We should have an AppVeyor build
https://api.github.com/repos/WebAssembly/wabt/issues/186/comments
2
2016-10-25T15:57:52Z
2016-11-03T23:23:54Z
https://github.com/WebAssembly/wabt/issues/186
185,160,092
186
[ "WebAssembly", "wabt" ]
OpCodes for float math were changed shortly after the initial reordering. https://github.com/WebAssembly/design/pull/828/files I started the pull together a PR to fix that, but I don't know how to easily fix all the baselines that depends on the opcodes' value
Float opcode ordering
https://api.github.com/repos/WebAssembly/wabt/issues/185/comments
1
2016-10-25T08:06:45Z
2016-10-25T20:11:22Z
https://github.com/WebAssembly/wabt/issues/185
185,046,107
185
[ "WebAssembly", "wabt" ]
run wasm2wast with -v on any (AFACS) binary, and it will crash: ``` $ out/clang/Debug/wast2wasm f.wast -o f.wasm $ out/clang/Debug/wasm2wast f.wasm (module (memory (;0;) 17) (export "memory" (memory 0))) $ out/clang/Debug/wasm2wast f.wasm -v begin_module begin_memory_section on_memory_count(1) on_memory(index...
wasm2wast crashes when using -v flag
https://api.github.com/repos/WebAssembly/wabt/issues/181/comments
2
2016-10-24T17:52:09Z
2016-10-24T20:07:32Z
https://github.com/WebAssembly/wabt/issues/181
184,909,678
181
[ "WebAssembly", "wabt" ]
For most sections that size must be none zero. I had a binary with a TYPE section of size zero that generated the following error: ``` $ ../wabt/out/wasmdump -h -v ../tmp.wasm TYPE start=0x0000000a end=0x0000000a (size=0000000000) - count: 3 error: @0x0000000c: unexpected type form ``` Ideally it would ha...
binary parser should error out when section size is 0
https://api.github.com/repos/WebAssembly/wabt/issues/177/comments
1
2016-10-20T22:06:38Z
2016-11-10T22:43:10Z
https://github.com/WebAssembly/wabt/issues/177
184,352,715
177
[ "WebAssembly", "wabt" ]
dschuff's feedback: ``` if (ctx->options->headers) { + printf("%-12s start=%#010" PRIzx " end=%#010" PRIzx " (size=%#010" PRIzx ``` I think the size would probably be more readable in decimal than hex. Actually, maybe start and end, too? IIRC the JS engines report byte offsets in Decimal in error messages stacktra...
wasmdump cleanup
https://api.github.com/repos/WebAssembly/wabt/issues/167/comments
3
2016-10-17T23:46:31Z
2016-12-01T00:18:59Z
https://github.com/WebAssembly/wabt/issues/167
183,556,613
167
[ "WebAssembly", "wabt" ]
Currently you can give it an empty file, or one that just contains comments. I noticed this when passing it the .txt files from the test directory which contain comments only.
wast2wasm should error/warn on empty input
https://api.github.com/repos/WebAssembly/wabt/issues/160/comments
1
2016-10-10T21:39:34Z
2017-01-03T23:41:03Z
https://github.com/WebAssembly/wabt/issues/160
182,122,005
160
[ "WebAssembly", "wabt" ]
If the build breaks and no one is around to hear it, does anyone fix it?
Add emscripten builder for Travis
https://api.github.com/repos/WebAssembly/wabt/issues/158/comments
5
2016-10-07T23:08:59Z
2018-01-27T08:26:16Z
https://github.com/WebAssembly/wabt/issues/158
181,785,337
158
[ "WebAssembly", "wabt" ]
I'm worried I might break it as it stands :) Also, it should probably be added to the top level Makefile so it ends up on the `out` directory?
Add tests for `wasmopcodecnt`
https://api.github.com/repos/WebAssembly/wabt/issues/156/comments
0
2016-10-07T22:59:39Z
2016-10-10T18:54:17Z
https://github.com/WebAssembly/wabt/issues/156
181,784,284
156
[ "WebAssembly", "wabt" ]
https://wasm-stat.us/builders/linux/builds/11742/steps/musl/logs/stdio Reverting #148 locally lets it build again. The musl.wast looks like ``` (module (memory $0 1) (data ...) ... (type ...) ... (import ...) ... (export ...) ... (table 19 19 anyfunc) (elem ...) (func ...) ... ) `...
wast2wasm doesn't parse musl.wast
https://api.github.com/repos/WebAssembly/wabt/issues/152/comments
2
2016-10-06T22:52:24Z
2016-10-06T23:13:34Z
https://github.com/WebAssembly/wabt/issues/152
181,545,246
152
[ "WebAssembly", "wabt" ]
I tried to build [emscripten's hello world wast](https://gist.github.com/kripken/661d24692e183f423390e39263607157) into wasm, but I get errors like ``` a.out.wast:65:3: global can only be defined in terms of a previously defined global. (global $STACKTOP (mut i32) (get_global $STACKTOP$asm2wasm$import)) ^^^^^^^^^^...
Global usage error
https://api.github.com/repos/WebAssembly/wabt/issues/143/comments
1
2016-10-03T23:38:30Z
2016-10-04T16:15:57Z
https://github.com/WebAssembly/wabt/issues/143
180,773,952
143
[ "WebAssembly", "wabt" ]
All of the internal tests are written using the old style, but should be converted to the new style, e.g.: old style: ``` (func (result i32) (local i32) (block i32 (i32.add (i32.const 1) (get_local 0)))) ``` new style: ``` (func (result i32) (local i32) block i32 i32.const 1 get_local 0 i32....
Convert tests from AST format to new "flat" format
https://api.github.com/repos/WebAssembly/wabt/issues/139/comments
14
2016-09-30T23:24:21Z
2016-12-02T01:09:09Z
https://github.com/WebAssembly/wabt/issues/139
180,421,721
139
[ "WebAssembly", "wabt" ]
See https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#control-flow-operators-described-here
br_table entries are LEB128
https://api.github.com/repos/WebAssembly/wabt/issues/133/comments
0
2016-09-29T23:54:04Z
2016-09-30T22:38:47Z
https://github.com/WebAssembly/wabt/issues/133
180,191,116
133
[ "WebAssembly", "wabt" ]
See https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#function-bodies
Require end opcode on functions
https://api.github.com/repos/WebAssembly/wabt/issues/132/comments
0
2016-09-29T23:53:30Z
2016-10-01T04:10:50Z
https://github.com/WebAssembly/wabt/issues/132
180,191,054
132
[ "WebAssembly", "wabt" ]
Described [here](https://github.com/WebAssembly/spec/pull/330), though not in the design repo anywhere.
br_if should return its value
https://api.github.com/repos/WebAssembly/wabt/issues/131/comments
0
2016-09-29T23:52:27Z
2016-09-30T23:57:41Z
https://github.com/WebAssembly/wabt/issues/131
180,190,934
131
[ "WebAssembly", "wabt" ]
I don't think we currently are?
We should build in C99 mode
https://api.github.com/repos/WebAssembly/wabt/issues/119/comments
3
2016-09-28T20:54:22Z
2017-02-22T19:30:16Z
https://github.com/WebAssembly/wabt/issues/119
179,885,864
119
[ "WebAssembly", "wabt" ]
That will mean that we can use `make install` to do things like install into the waterfall build.
We should have CMake install targets for the WABT binaries
https://api.github.com/repos/WebAssembly/wabt/issues/118/comments
4
2016-09-28T20:52:18Z
2016-09-30T18:44:54Z
https://github.com/WebAssembly/wabt/issues/118
179,885,360
118
[ "WebAssembly", "wabt" ]
sexpr-wasm-prototype is a very old name for the project, and doesn't really reflect what it is or does. Any ideas for a better name?
Rename the project?
https://api.github.com/repos/WebAssembly/wabt/issues/101/comments
13
2016-09-15T20:37:33Z
2016-10-03T17:52:32Z
https://github.com/WebAssembly/wabt/issues/101
177,283,521
101
[ "WebAssembly", "wabt" ]
@sbc100 mentioned that we should probably rename the binaries for clarity: sexpr-wasm -> wast2wasm wasm-wast -> wasm2wast
Rename sexpr-wasm binaries
https://api.github.com/repos/WebAssembly/wabt/issues/100/comments
3
2016-09-15T20:36:48Z
2016-09-21T21:46:44Z
https://github.com/WebAssembly/wabt/issues/100
177,283,348
100
[ "WebAssembly", "wabt" ]
Seems like other folks must have this issue, but a quick search doesn't turn up anything.
MSAN build stopped working on Travis
https://api.github.com/repos/WebAssembly/wabt/issues/99/comments
0
2016-09-06T16:37:32Z
2022-05-19T01:21:58Z
https://github.com/WebAssembly/wabt/issues/99
175,293,959
99
[ "WebAssembly", "wabt" ]
This file crashes the prototype. [crash_sexpre_proto.wast.txt](https://github.com/WebAssembly/sexpr-wasm-prototype/files/454160/crash_sexpre_proto.wast.txt) It crashes with ``` crash_sexpre_proto.wast:3569:37: memory exhausted (else (if (i32.eq (get_local $jump_dest) (i32.const 16940)) ``` The file...
memory exhaustion crash
https://api.github.com/repos/WebAssembly/wabt/issues/98/comments
1
2016-09-04T23:30:04Z
2016-09-06T02:27:15Z
https://github.com/WebAssembly/wabt/issues/98
174,975,494
98
[ "WebAssembly", "wabt" ]
Are there any plans to introduce support for macros? Something similar to Lisp's `defmacro` perhaps, with both the `'` and `~` modifiers. It would make life a bit easier writing `wast`. It won't be of course (easily) possible to turn `wasm` back to its original form with macros.
Macros
https://api.github.com/repos/WebAssembly/wabt/issues/92/comments
4
2016-07-18T19:08:30Z
2022-05-19T01:21:43Z
https://github.com/WebAssembly/wabt/issues/92
166,169,213
92
[ "WebAssembly", "wabt" ]
For the following function `(func $return-nop (return (nop)))` (https://github.com/WebAssembly/testsuite/blob/master/functions.wast) There is a conflict between the function type and return arity. The type of the function is ``` ; type 0 000000f: 40 ; function form 0000010: 0...
Return nop arity
https://api.github.com/repos/WebAssembly/wabt/issues/82/comments
5
2016-06-07T00:13:47Z
2016-08-04T08:07:54Z
https://github.com/WebAssembly/wabt/issues/82
158,803,290
82
[ "WebAssembly", "wabt" ]
Build on MSVC fails due to missing decl for memcpy. Line 94 at src/wasm-config.h.in, ``` #elif COMPILER_IS_MSVC #define WASM_UNUSED #define WASM_WARN_UNUSED _Check_return_ #define WASM_INLINE __inline #define WASM_STATIC_ASSERT(x) _STATIC_ASSERT(x) #define WASM_UNLIKELY(x) (x) #define WASM_LIKELY(x) (x) #define WASM_...
Windows build failing due to missing include header
https://api.github.com/repos/WebAssembly/wabt/issues/81/comments
1
2016-06-06T17:56:38Z
2016-06-17T18:26:31Z
https://github.com/WebAssembly/wabt/issues/81
158,736,723
81
[ "WebAssembly", "wabt" ]
One thing we've recently been thinking a lot about on Chakra is our testing story for WebAssembly. I think it would be ideal if we could use this as a submodule, and have our testing build wasts using sexpr-wasm on the fly. This would allow us to run WebAssembly tests through our CI without needing to check in a whole ...
Non-community group submodules
https://api.github.com/repos/WebAssembly/wabt/issues/79/comments
7
2016-05-27T20:30:19Z
2016-06-17T20:36:59Z
https://github.com/WebAssembly/wabt/issues/79
157,285,165
79
[ "WebAssembly", "wabt" ]
Just noticed this.
Check call arity against function signature in wasm-binary-reader-ast
https://api.github.com/repos/WebAssembly/wabt/issues/72/comments
3
2016-05-11T16:58:12Z
2016-09-21T21:47:24Z
https://github.com/WebAssembly/wabt/issues/72
154,292,686
72
[ "WebAssembly", "wabt" ]
The following is valid wast but crashes in wasm-interp. ``` (module (func $tst1 (block (block $l (br $l (i32.const 1)) (nop)) (nop))) (export "tst" $tst1) ) ```
wasm-interp: block-break type crash.
https://api.github.com/repos/WebAssembly/wabt/issues/65/comments
1
2016-04-05T13:49:27Z
2016-04-16T09:16:38Z
https://github.com/WebAssembly/wabt/issues/65
145,994,722
65
[ "WebAssembly", "wabt" ]
It looks like this prototype is still using the old `if`. For example this ``` (if (i32.const 1) (br 0) ) ``` gets turned into ``` (if (i32.const 1) (block (br 0)) ) ``` [related](https://github.com/WebAssembly/spec/issues/270#issuecomment-203959770)
legacy if
https://api.github.com/repos/WebAssembly/wabt/issues/62/comments
1
2016-03-31T14:49:58Z
2016-03-31T18:26:46Z
https://github.com/WebAssembly/wabt/issues/62
144,923,779
62
[ "WebAssembly", "wabt" ]
I have a flavor of bison installed, so the new build procedure tries to use it. Trouble is, it's an older version and cannot consume wasm-bison-parser.y: sexpr-wasm-prototype/src/wasm-bison-parser.y:101.20-33: error: syntax error, unexpected {...} make[2]: **\* [wasm-bison-parser.c] Error 1 Is there a way to force us...
Is there a way to force use of prebuilt wasm-bison-parser.[ch] files?
https://api.github.com/repos/WebAssembly/wabt/issues/54/comments
3
2016-03-14T17:55:22Z
2016-03-14T19:08:58Z
https://github.com/WebAssembly/wabt/issues/54
140,749,254
54
[ "WebAssembly", "wabt" ]
the following `(module (func (loop $a (br $a))) (export "" 0))` `(module (func (loop $a $b (br $a))) (export "" 0))` Should generate the same output However, the first outputs `br 0` (infinite loop) and the second outputs `br 1` (all is good)
br without continue label
https://api.github.com/repos/WebAssembly/wabt/issues/53/comments
5
2016-03-13T10:09:35Z
2016-03-14T06:27:06Z
https://github.com/WebAssembly/wabt/issues/53
140,471,397
53
[ "WebAssembly", "wabt" ]
Add check if you forget to run `git submodule update --init`
https://api.github.com/repos/WebAssembly/wabt/issues/52/comments
1
2016-03-11T20:18:58Z
2017-06-29T17:24:54Z
https://github.com/WebAssembly/wabt/issues/52
140,281,143
52
[ "WebAssembly", "wabt" ]
I get ``` Downloading https://storage.googleapis.com/webassembly/v8-native-prototype/7ee0c81f107ab72d6e46d94e0a1d01be7ae56d34/d8... curl: (22) The requested URL returned error: 404 Not Found ```
scripts/download-d8.sh seems broken
https://api.github.com/repos/WebAssembly/wabt/issues/51/comments
5
2016-03-11T19:54:28Z
2016-03-11T20:12:34Z
https://github.com/WebAssembly/wabt/issues/51
140,275,944
51
[ "WebAssembly", "wabt" ]
Currently if d8 is broken, I just run manually: ``` out/sexpr-wasm <broken test> -o foo.wasm gdb --args <d8> test/wasm.js -- foo.wasm ``` Probably should describe this process in the README. Maybe make it more convenient?
Easier method to debug broken d8 tests
https://api.github.com/repos/WebAssembly/wabt/issues/44/comments
0
2016-03-07T18:45:36Z
2016-06-17T18:32:27Z
https://github.com/WebAssembly/wabt/issues/44
139,058,288
44
[ "WebAssembly", "wabt" ]
Similar to `run-d8.py`, which uses `--d8-executable` for this.
Add flag to `run-tests.py` to use a different d8
https://api.github.com/repos/WebAssembly/wabt/issues/43/comments
1
2016-03-07T18:42:26Z
2016-03-21T22:49:13Z
https://github.com/WebAssembly/wabt/issues/43
139,057,506
43
[ "WebAssembly", "wabt" ]
Add flag to display commands used to run d8 via `run-d8.py`
https://api.github.com/repos/WebAssembly/wabt/issues/42/comments
1
2016-03-07T18:41:41Z
2016-08-05T03:16:06Z
https://github.com/WebAssembly/wabt/issues/42
139,057,368
42
[ "WebAssembly", "wabt" ]
sexpr-wasm doesn't handle the new `select` syntax, which @kripken [added to binaryen](https://github.com/WebAssembly/binaryen/commit/14cc71b380005d3b2c5289ebfd20f5bf82ff4c79). This breaks the waterfall. /cc @dschuff
Handle new `select` syntax
https://api.github.com/repos/WebAssembly/wabt/issues/39/comments
1
2016-03-03T13:45:19Z
2016-03-03T17:01:30Z
https://github.com/WebAssembly/wabt/issues/39
138,181,091
39
[ "WebAssembly", "wabt" ]
From the example in the Readme ``` var buffer = readbuffer('test.wasm'); var module = _WASMEXP_.instantiateModule(buffer, {}); ``` `module` comes out undefined at the end here. It should export `test`
not working on agianst V8 version 5.1.0 (candidate)
https://api.github.com/repos/WebAssembly/wabt/issues/38/comments
2
2016-03-01T18:21:50Z
2016-03-01T19:00:46Z
https://github.com/WebAssembly/wabt/issues/38
137,649,040
38
[ "WebAssembly", "wabt" ]
Updating sexpr-wasm in a pre-built repo causes the following error: ``` sexpr directory already exists subprocess.check_call(`git fetch`, cwd=`/b/build/slave/linux/build/src/src/work/sexpr-wasm-prototype`) subprocess.check_call(`git checkout origin/master`, cwd=`/b/build/slave/linux/build/src/src/work/sexpr-wasm-proto...
Dirty repo
https://api.github.com/repos/WebAssembly/wabt/issues/35/comments
4
2016-02-27T19:46:21Z
2016-03-13T09:06:00Z
https://github.com/WebAssembly/wabt/issues/35
136,960,094
35
[ "WebAssembly", "wabt" ]
As in: https://github.com/WebAssembly/design/pull/495 I'm adding support for it in: https://github.com/WebAssembly/binaryen/pull/182
Support start
https://api.github.com/repos/WebAssembly/wabt/issues/34/comments
7
2016-02-04T13:29:27Z
2016-02-24T01:05:42Z
https://github.com/WebAssembly/wabt/issues/34
131,347,565
34
[ "WebAssembly", "wabt" ]
The following test from the spec seems to conflict with the v8 encoding which can only have one export per function. Should sexp-wasm signal an error on this? Should the spec be changed to make this invalid? `(module (func (i32.const 1)) (export "a" 0) (export "b" 0))`
Multiple exports per function being accepted?
https://api.github.com/repos/WebAssembly/wabt/issues/33/comments
4
2016-02-04T12:20:15Z
2016-03-21T22:50:25Z
https://github.com/WebAssembly/wabt/issues/33
131,329,498
33
[ "WebAssembly", "wabt" ]
The following code fails to encode with sexp-wasm with: t60.wast:7:37: label variable out of range (max 1) If an explicit label is added to the `tableswitch` it succeeds. I've seen other cases where this changes the depths. Does v8 always have an implicit block for a `tableswitch`? If so then adding an explicit label ...
tableswitch block depth?
https://api.github.com/repos/WebAssembly/wabt/issues/32/comments
2
2016-02-03T10:45:39Z
2016-02-03T20:08:41Z
https://github.com/WebAssembly/wabt/issues/32
130,988,121
32
[ "WebAssembly", "wabt" ]
It would be nice if this error message also printed out the import's name: ``` foo.wast:72385:11: too many parameters to function in call_import. got 4, expected 3 foo.wast:72398:9: too few parameters to function in call_import. got 1, expected 2 ``` Right now I hack around it with grep / cut / xargs / head / tail an...
Improve error message: too many / too few parameters to function call in call_import
https://api.github.com/repos/WebAssembly/wabt/issues/31/comments
0
2016-01-30T09:34:31Z
2016-01-30T20:22:32Z
https://github.com/WebAssembly/wabt/issues/31
129,965,975
31
[ "WebAssembly", "wabt" ]
The load access byte on the i64.load below is zero, suggesting it is aligned, but would the natural alignment for a 64 bit load be 8 and not 2, so should it be setting the un-aligned bit in the load access byte? ``` (module (memory 65536 65536) (func $f1 (result i64) (i64.load align=2 (i32.const 0)))) ``` ``` ; fu...
Possible incorrect alignment encoding for a 64 bit access.
https://api.github.com/repos/WebAssembly/wabt/issues/30/comments
1
2016-01-29T10:16:48Z
2016-01-29T16:55:09Z
https://github.com/WebAssembly/wabt/issues/30
129,724,121
30
[ "WebAssembly", "wabt" ]
The following FP number doesn't parse: `1.e+300`. Error: `unexpected token "1.e+300"` The problem is `.e` if I change it to `1.0e+300` it works.
FP parsing fail
https://api.github.com/repos/WebAssembly/wabt/issues/29/comments
5
2016-01-28T03:12:39Z
2016-01-28T18:49:31Z
https://github.com/WebAssembly/wabt/issues/29
129,318,635
29
[ "WebAssembly", "wabt" ]
I'm testing a program which encounters the following sexpr-wasm error: ``` invalid literal "nan:0x7ff8000000000000" invalid literal "nan:0x7fc00000" invalid literal "nan:0x7ff8000000000000" invalid literal "nan:0x7fc00000" invalid literal "nan:0x7ff8000000000000" invalid literal "nan:0x7fc00000" invalid literal "nan:0...
Invalid NaN literal
https://api.github.com/repos/WebAssembly/wabt/issues/28/comments
12
2016-01-28T03:07:54Z
2016-01-31T08:28:01Z
https://github.com/WebAssembly/wabt/issues/28
129,317,459
28
[ "WebAssembly", "wabt" ]
I get the following error: ``` foo.wast:2:11: invalid initial memory size "0\00\" foo.wast:2:17: invalid max memory size "0\00\00\00" ``` With this input file, it looks like the last segment makes it sad but I have not clue why. Everything seems properly quoted and escaped. It's happy if I remove all the nulls from t...
invalid initial memory size "0\00\"
https://api.github.com/repos/WebAssembly/wabt/issues/27/comments
1
2016-01-28T02:59:32Z
2016-01-28T05:21:00Z
https://github.com/WebAssembly/wabt/issues/27
129,315,846
27
[ "WebAssembly", "wabt" ]
Another issue, similar to the `br` optional value issues. ``` (module (memory 4) (export "test1" $test1) (func $test1 (return)) (export "test2" $test2) (func $test2 (return (nop))) (export "test3" $test3) (func $test3 (return (i32.const 1))) ) ``` ``` 0000011: 0000 ...
Return operator result expression arity issues.
https://api.github.com/repos/WebAssembly/wabt/issues/26/comments
1
2016-01-26T09:05:17Z
2016-01-26T16:51:20Z
https://github.com/WebAssembly/wabt/issues/26
128,764,944
26
[ "WebAssembly", "wabt" ]
The following code emits a single `unreachable` operator which does not appear correct. When $i1 is zero this function would return 1. ``` (module (func (param $i1 i32) (result i32) (if_else (get_local $i1) (block (unreachable)) (i32.const 1)))) ``` ``` 0000004: 02 ...
Incorrect code emitted involving unreachable code.
https://api.github.com/repos/WebAssembly/wabt/issues/25/comments
2
2016-01-24T21:20:41Z
2016-01-24T22:04:54Z
https://github.com/WebAssembly/wabt/issues/25
128,425,901
25
[ "WebAssembly", "wabt" ]
Seems odd that the v8 encoding requires a nop opcode as fill in br and br_if but sexpr-wasm-prototype will not accept a nop value in the same place? uncompr.wast:109:11: arity mismatch of br_if value. label expects void, but br value is non-empty
br not accepting a nop?
https://api.github.com/repos/WebAssembly/wabt/issues/20/comments
2
2016-01-17T12:07:01Z
2016-03-21T22:51:22Z
https://github.com/WebAssembly/wabt/issues/20
127,090,837
20
[ "WebAssembly", "wabt" ]
Some of the torture tests fail with this because s2wasm emits them in the opposite order as wasmate, e.g.: ``` (f64.store align=1 offset=8 (i32.const 0) (f64.const 0)) ``` It would be good to also update store-offset.txt adn load-offset.txt, as well as make sure that the spec repo has the same tests. s2wasm_known_gc...
sexpr-wasm can't commute align= offset=
https://api.github.com/repos/WebAssembly/wabt/issues/17/comments
2
2016-01-05T19:36:52Z
2016-02-24T01:06:51Z
https://github.com/WebAssembly/wabt/issues/17
125,035,075
17
[ "WebAssembly", "wabt" ]
Anyone else seeing this error? make: **\* No rule to make target `out', needed by`out/wasm.o'. Stop. Presumably it's due to the trailing slash in the rule "out/: I've only seen this on a couple systems, and it may be file system dependent as even on those systems I don't see this if working in a directory on a dif...
make: no rule to make target 'out'
https://api.github.com/repos/WebAssembly/wabt/issues/15/comments
3
2015-12-24T00:18:40Z
2016-02-24T01:07:07Z
https://github.com/WebAssembly/wabt/issues/15
123,739,454
15
[ "WebAssembly", "wabt" ]
Specifically: ``` (block $inner ;; 0 (br $inner) (br $outer))))))) ``` -> ``` 0000013: 01 ; OPCODE_BLOCK 0000014: 02 ; num expressions 0000015: 06 ; OPCODE_BR ...
br-block-named.txt is incorrect
https://api.github.com/repos/WebAssembly/wabt/issues/13/comments
5
2015-12-21T20:27:55Z
2016-01-18T21:30:48Z
https://github.com/WebAssembly/wabt/issues/13
123,351,295
13
[ "WebAssembly", "wabt" ]
Failed to parse [this file](https://github.com/WebAssembly/wasm-to-llvm-prototype/blob/master/perf_tests/matrix/mul/mul.wast) ./test.wasm:[90:19: unexpected token "i32.div"](https://github.com/WebAssembly/wasm-to-llvm-prototype/blob/master/perf_tests/matrix/mul/mul.wast#L90) If I change them all of the i32.div to i32...
failed to parse file
https://api.github.com/repos/WebAssembly/wabt/issues/12/comments
2
2015-12-19T23:56:15Z
2015-12-20T01:15:14Z
https://github.com/WebAssembly/wabt/issues/12
123,117,229
12
[ "WebAssembly", "wabt" ]
This happens when given any *.wasm file ``` Starting program: /home/null/code/WASM/sexpr-wasm-prototype/out/sexpr-wasm ../test.wasm *** Error in `/home/null/code/WASM/sexpr-wasm-prototype/out/sexpr-wasm': realloc(): invalid pointer: 0x00007ffff7fc1548 *** ======= Backtrace: ========= /usr/lib/libc.so.6(+0x72055)[0x7ff...
Runtime Error
https://api.github.com/repos/WebAssembly/wabt/issues/10/comments
8
2015-12-19T00:39:43Z
2015-12-21T20:56:58Z
https://github.com/WebAssembly/wabt/issues/10
123,049,208
10
[ "WebAssembly", "wabt" ]
test ``` (module (import $print_i32 "stdio" "print" (param i32)) (memory 2000000 (segment 8 "0") (segment 16 "world")) (export "test" 0) (func (result i32) (call $print_i32 (i32.const 66)) (i32.add (i32.const 0xFFF6789b) (i32.const 2)))) ``` result `test.wasm:6:11: undefined function variable "$print_...
imports dont seem to work
https://api.github.com/repos/WebAssembly/wabt/issues/9/comments
2
2015-11-23T12:08:57Z
2015-11-24T13:40:09Z
https://github.com/WebAssembly/wabt/issues/9
118,368,138
9
[ "WebAssembly", "wabt" ]
here is my test code ``` (module (func (result i32) (i32.add (i32.const 624485) (i32.const 2)))) ``` LEB of 624485 [should be 0xE58E26](https://en.wikipedia.org/wiki/LEB128#Unsigned_LEB128) But from the prototype if get ``` ; function 0 .... 0000014: 0a ; OPCODE_I32_C...
LEB128 question
https://api.github.com/repos/WebAssembly/wabt/issues/8/comments
4
2015-11-20T19:13:34Z
2015-11-20T21:45:05Z
https://github.com/WebAssembly/wabt/issues/8
118,107,165
8
[ "WebAssembly", "wabt" ]
I have a test that generated the following code, and fed it into sexpr-wasm (module (func $foomore(call $foo (i32.const 0x0)) ) (func $foo (param i32)(nop)) ) Note the lack of space between $foomore and its opening paren. Sometime between rev 64fb062d and rev 7601228b this stopped being accepted by the parser, whi...
Whitespace between function name token and left paren
https://api.github.com/repos/WebAssembly/wabt/issues/6/comments
2
2015-10-13T19:28:18Z
2015-10-14T00:28:29Z
https://github.com/WebAssembly/wabt/issues/6
111,252,358
6
[ "WebAssembly", "wabt" ]
The spec interpreter reports assertion errors with line numbers from the source. This would be really handy for debugging codegen issues (e.g. in a test suite with hundreds of assertions, which one is failing?). Currently WAOT just tracks and prints the count (i.e. "assertion number X failed") but a line number would b...
Provide a way to get SourceLocations
https://api.github.com/repos/WebAssembly/wabt/issues/4/comments
4
2015-10-10T22:46:12Z
2015-10-19T07:30:00Z
https://github.com/WebAssembly/wabt/issues/4
110,821,326
4