author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 16.04.2020 23:07:29 | 14,400 | 567e460ce203ccfd0fca5dda6378fd2bbb629bf1 | [native] identifier-utils.js and getFetchableURI | [
{
"change_type": "MODIFY",
"old_path": "native/media/blob-utils.js",
"new_path": "native/media/blob-utils.js",
"diff": "@@ -11,6 +11,8 @@ import {\ntype FileDataInfo,\n} from 'lib/utils/file-utils';\n+import { getFetchableURI } from './identifier-utils';\n+\nexport type ReactNativeBlob = Blob & {\nd... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] identifier-utils.js and getFetchableURI |
129,187 | 16.04.2020 23:27:46 | 14,400 | 2532899846d2d2d62308252f6e7971545043299e | [server] Rework saveToDisk | [
{
"change_type": "MODIFY",
"old_path": "native/media/save-image.js",
"new_path": "native/media/save-image.js",
"diff": "@@ -9,7 +9,7 @@ import md5 from 'md5';\nimport { fileInfoFromData, readableFilename } from 'lib/utils/file-utils';\nimport { blobToDataURI, dataURIToIntArray } from './blob-utils';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rework saveToDisk |
129,187 | 16.04.2020 23:31:31 | 14,400 | b23ab011eb822a611f21b0f392ac26ddd92fef93 | [native] Deal with react-native-fs platform inconsistencies in reporting dirs | [
{
"change_type": "MODIFY",
"old_path": "native/media/save-image.js",
"new_path": "native/media/save-image.js",
"diff": "@@ -71,7 +71,7 @@ async function saveImageAndroid(\nreturn \"don't have permission :(\";\n}\n- const saveFolder = `${filesystem.PicturesDirectoryPath}/SquadCal`;\n+ const saveFolde... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Deal with react-native-fs platform inconsistencies in reporting dirs |
129,187 | 17.04.2020 13:21:22 | 14,400 | 1bc139968f5ec6787afa52288b69ca18418fd8e6 | [native] Reassign localUploadIDs on retry if not in pendingUploads | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -72,6 +72,10 @@ import { displayActionResultModal } from '../navigation/action-result-modal';\nimport { fetchFileSize } from '../media/file-uti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reassign localUploadIDs on retry if not in pendingUploads |
129,187 | 17.04.2020 13:29:48 | 14,400 | 040133c345f9bc94790667ad2dd050613ff60989 | [server] Delete uploads in a message when deleting the message | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/message-deleters.js",
"new_path": "server/src/deleters/message-deleters.js",
"diff": "@@ -4,10 +4,12 @@ import { dbQuery, SQL } from '../database';\nasync function deleteOrphanedMessages(): Promise<void> {\nawait dbQuery(SQL`\n- DELETE m, i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete uploads in a message when deleting the message |
129,187 | 17.04.2020 17:23:12 | 14,400 | f15f8a1ca9a07b80d77cccd85c254e229fc23b80 | [server] Update server image processing to match native | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"dependencies\": {\n\"JSONStream\": \"^1.3.5\",\n\"apn\": \"git+https://github.com/node-apn/node-apn.git#3.0.0\",\n- \"buffer-image-size\": \"^0.6.4\",\n\"common-tags\": \"^1.7.2\",\n\"cookie-p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update server image processing to match native |
129,187 | 17.04.2020 17:48:02 | 14,400 | 63fc41e1705cb61c133b648330d975532a71fbfc | Return new Dimensions back from uploadMultimedia | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/upload-actions.js",
"new_path": "lib/actions/upload-actions.js",
"diff": "@@ -33,7 +33,11 @@ async function uploadMultimedia(\n},\n);\nconst [uploadResult] = response.results;\n- return { id: uploadResult.id, uri: uploadResult.uri };\n+ return {\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Return new Dimensions back from uploadMultimedia |
129,187 | 17.04.2020 20:33:18 | 14,400 | d31a8d4df0dc757a9be7cc9691c5ad7a44f27fdf | [web] Display EXIF-oriented images correctly | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-state-container.react.js",
"new_path": "web/chat/chat-input-state-container.react.js",
"diff": "@@ -27,6 +27,7 @@ import _omit from 'lodash/fp/omit';\nimport _groupBy from 'lodash/fp/groupBy';\nimport _partition from 'lodash/fp/partition';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display EXIF-oriented images correctly |
129,187 | 17.04.2020 21:04:24 | 14,400 | 1c57b0e194aa84fb0b1b62e68bfb8e4b0254cc44 | [web] Update Flow | [
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "\"clean-webpack-plugin\": \"^3.0.0\",\n\"concurrently\": \"^5.0.0\",\n\"css-loader\": \"^3.2.0\",\n- \"flow-bin\": \"^0.98.0\",\n+ \"flow-bin\": \"^0.105.0\",\n\"mini-css-extract-plugin\": \"^0.8.0\",... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Update Flow |
129,187 | 17.04.2020 21:05:04 | 14,400 | d3391e90ec18db4c3f0ff159c99eedb04b56cb60 | [web] Handle ChatMessageList inverted scrolling better | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -10,6 +10,10 @@ div.activeContainer {\nborder: 2px solid #5989D6;\nmargin-left: 402px;\n}\n+div.firefoxMessageContainer {\n+ overflow-y: scroll;\n+ height: 100%;\n+}\ndi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Handle ChatMessageList inverted scrolling better |
129,187 | 17.04.2020 23:04:30 | 14,400 | 56484f93dde8515a755bb598cdff20b976338273 | [native] Fix width of single image messages | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -107,9 +107,8 @@ const styles = StyleSheet.create({\nmarginRight: 7,\n},\ncontent: {\n- flex: 1,\n- flexDirection: 'row',\nalignItems: 'center',\n+ flexDir... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix width of single image messages |
129,187 | 17.04.2020 23:19:04 | 14,400 | c759e0069bd70de1fcd39ddfb74a64e2cfe5e7b0 | [native] Don't try fetching ph-upload blobs
Misreports TIFF as JPEG on iOS | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-utils.js",
"new_path": "native/media/media-utils.js",
"diff": "@@ -12,7 +12,6 @@ import { Image } from 'react-native';\nimport invariant from 'invariant';\nimport { pathFromURI, readableFilename } from 'lib/utils/file-utils';\n-import { prom... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't try fetching ph-upload blobs
Misreports TIFF as JPEG on iOS |
129,187 | 18.04.2020 00:00:20 | 14,400 | ce471ab5afeae1fbf92eba473caaa8a063213914 | Add webp and tiff support | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/file-utils.js",
"new_path": "lib/utils/file-utils.js",
"diff": "@@ -9,6 +9,8 @@ const mimeTypesToMediaTypes = Object.freeze({\n'image/jpeg': 'photo',\n'image/gif': 'photo',\n'image/heic': 'photo',\n+ 'image/webp': 'photo',\n+ 'image/tiff': 'photo',\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add webp and tiff support |
129,187 | 18.04.2020 00:00:35 | 14,400 | 7fe0df59a91e6b1a77e47d394c78a89fbdc523e5 | [web] Catch exceptions in validateFile | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-state-container.react.js",
"new_path": "web/chat/chat-input-state-container.react.js",
"diff": "@@ -354,11 +354,19 @@ class ChatInputStateContainer extends React.PureComponent<Props, State> {\n);\nasync appendFiles(threadID: string, files: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Catch exceptions in validateFile |
129,187 | 18.04.2020 02:19:28 | 14,400 | 9fbe415077838675e2ea6a59e4784046bb291d48 | [web] Consistent order for pendingUploads | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-state-container.react.js",
"new_path": "web/chat/chat-input-state-container.react.js",
"diff": "@@ -26,6 +26,7 @@ import _keyBy from 'lodash/fp/keyBy';\nimport _omit from 'lodash/fp/omit';\nimport _groupBy from 'lodash/fp/groupBy';\nimport ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Consistent order for pendingUploads |
129,187 | 18.04.2020 02:19:53 | 14,400 | f731d64eb3da9f657dc3682d042d131bc8ffb89f | [native] Fix resize config passed to expo-image-manipulator | [
{
"change_type": "MODIFY",
"old_path": "native/media/image-utils.js",
"new_path": "native/media/image-utils.js",
"diff": "@@ -46,9 +46,9 @@ async function processImage(\nif (fitInside) {\nconst fitInsideRatio = fitInside.width / fitInside.height;\nif (dimensions.width / dimensions.height > fitInside... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix resize config passed to expo-image-manipulator |
129,187 | 18.04.2020 14:58:04 | 14,400 | 4a364e038e40bce1ed129329a42abd574a5970aa | [native] Don't crash when encountering images with a 0 dimension | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message.react.js",
"new_path": "native/chat/multimedia-message.react.js",
"diff": "@@ -82,15 +82,15 @@ function multimediaMessageContentSizes(\nconst [media] = messageInfo.media;\nconst { height, width } = media.dimensions;\n- let imageH... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't crash when encountering images with a 0 dimension |
129,187 | 18.04.2020 16:30:45 | 14,400 | c01a07fe7df500d1d8d4237b992b257e61975487 | Use react-native-fs to read MIME type | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -105,14 +105,14 @@ export type VideoProbeMediaMissionStep = {|\nformat: ?string,\n|};\n-export type BlobDataAnalysisMediaMissionStep = {|\n- step: 'blob_data_analysis',\n+export typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use react-native-fs to read MIME type |
129,187 | 18.04.2020 16:58:42 | 14,400 | 5824ad6bf1f37a25eaf3db7d636834680dc1333f | [native] Return two Promises from processMedia
Makes it easier to do post-processing for the `MediaMissionReport` | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -69,7 +69,6 @@ import {\n} from './input-state';\nimport { processMedia } from '../media/media-utils';\nimport { displayActionResultModal } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Return two Promises from processMedia
Makes it easier to do post-processing for the `MediaMissionReport` |
129,187 | 18.04.2020 17:19:14 | 14,400 | 6f6a6436eed8d15a455ce7fde96303c53451994e | [native] Fix ThreadEntity linking in RobotextMessage | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message.react.js",
"new_path": "native/chat/message.react.js",
"diff": "@@ -107,6 +107,7 @@ class Message extends React.PureComponent<Props> {\nmessage = (\n<RobotextMessage\nitem={this.props.item}\n+ navigation={this.props.navigation}\nfocused={th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix ThreadEntity linking in RobotextMessage |
129,187 | 19.04.2020 15:02:53 | 14,400 | 141aa2cc5cc7963ec6012913c3e89383a25f8768 | [native] Don't block file size check on asset info fetch if we already have localURI | [
{
"change_type": "MODIFY",
"old_path": "native/media/file-utils.js",
"new_path": "native/media/file-utils.js",
"diff": "@@ -68,48 +68,85 @@ async function fetchFileInfo(\nresult: MediaMissionFailure | FetchFileInfoResult,\n|}> {\nconst steps = [];\n- let uri = inputURI,\n- orientation;\n+ let assetI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't block file size check on asset info fetch if we already have localURI |
129,187 | 19.04.2020 15:23:39 | 14,400 | fb9c862b0e07a2e28b85bc965669ca7ba07dbd7c | [native] Allow fetchFileInfo to handle MIME | [
{
"change_type": "MODIFY",
"old_path": "native/media/file-utils.js",
"new_path": "native/media/file-utils.js",
"diff": "@@ -14,55 +14,18 @@ import base64 from 'base-64';\nimport { pathFromURI, fileInfoFromData } from 'lib/utils/file-utils';\n-async function fetchFileSize(\n- uri: string,\n-): Promis... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Allow fetchFileInfo to handle MIME |
129,187 | 19.04.2020 22:37:55 | 14,400 | 2734516e005d70eef961da2b6eff6fcbc41661ee | [native] Refactor saveImage logic for performance | [
{
"change_type": "MODIFY",
"old_path": "native/media/blob-utils.js",
"new_path": "native/media/blob-utils.js",
"diff": "@@ -48,4 +48,4 @@ function stringToIntArray(str: string): Uint8Array {\nreturn array;\n}\n-export { blobToDataURI, dataURIToIntArray };\n+export { blobToDataURI, dataURIToIntArray,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Refactor saveImage logic for performance |
129,187 | 19.04.2020 23:19:34 | 14,400 | 6fb2c9f80f11a70f1bb441dd83b0ac54607b2537 | [web] Skip canvas draw if no EXIF rotation needed | [
{
"change_type": "MODIFY",
"old_path": "web/utils/media-utils.js",
"new_path": "web/utils/media-utils.js",
"diff": "@@ -41,15 +41,15 @@ async function processFile(\nexifRotate: boolean,\n): Promise<ProcessFileResult> {\nconst initialURI = URL.createObjectURL(file);\n+ if (!exifRotate) {\n+ const { w... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Skip canvas draw if no EXIF rotation needed |
129,187 | 20.04.2020 00:17:18 | 14,400 | 4eb08408fb26aab713d352915a7c192b7cc4886e | [web] Fix chat scrolling behavior for Firefox
Using ugly CSS hack | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -10,10 +10,6 @@ div.activeContainer {\nborder: 2px solid #5989D6;\nmargin-left: 402px;\n}\n-div.firefoxMessageContainer {\n- overflow-y: scroll;\n- height: 100%;\n-}\ndi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix chat scrolling behavior for Firefox
Using ugly CSS hack
https://github.com/philipwalton/flexbugs/issues/108
https://bugzilla.mozilla.org/show_bug.cgi?id=1042151 |
129,187 | 20.04.2020 14:12:27 | 14,400 | de29fbbb3017bb60e3f0602b1214112625d1d156 | [native] OverlayableScrollViewState -> ScrollViewModalState | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -13,10 +13,10 @@ import {\nmessageListNavPropType,\n} from './message-list-types';\nimport {\n- type OverlayableScrollViewState,\n- overlayableScrollViewStatePropT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] OverlayableScrollViewState -> ScrollViewModalState |
129,187 | 20.04.2020 15:29:05 | 14,400 | 5e631e00f84b6d35b445edcaadb027765b8b8bb0 | [native] scrollDisabled -> scrollViewModalState | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -48,12 +48,7 @@ import {\ntype ChatMessageInfoItemWithHeight,\n} from './message.react';\nimport ListLoadingIndicator from '../components/list-loading-indicator.re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] scrollDisabled -> scrollViewModalState |
129,187 | 20.04.2020 21:29:47 | 14,400 | 47f7e619af218366b7ffbef00afa091ebacc0a6a | [native]
Corresponding bugfix in `MultimediaModal` to avoid starting values at 0 and then dividing by them | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -311,7 +311,7 @@ PODS:\n- React\n- RNKeychain (4.0.1):\n- React\n- - RNReanimated (1.3.0):\n+ - RNReanimated (1.8.0):\n- React\n- RNScreens (1.0.0-alpha.17):\n- React\n@@ -638,7 +638,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] react-native-reanimated@1.8.0
Corresponding bugfix in `MultimediaModal` to avoid starting values at 0 and then dividing by them |
129,187 | 20.04.2020 22:24:29 | 14,400 | c2ca0318f933c566e1e5e99f5c1c185f44cd91cc | [native] Consider scrollBlockingChatModal anywhere in stack in scrollBlockingChatModalsClosedSelector | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/nav-selectors.js",
"new_path": "native/navigation/nav-selectors.js",
"diff": "@@ -109,8 +109,13 @@ const scrollBlockingChatModalsClosedSelector: (\nreturn true;\n}\nconst appRoute = assertNavigationRouteNotLeafNode(currentRootSubroute);\n- co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Consider scrollBlockingChatModal anywhere in stack in scrollBlockingChatModalsClosedSelector |
129,187 | 20.04.2020 22:25:04 | 14,400 | f047e37fdcb01c9bbaf06edb7f9076b2aa433d86 | [native] Handle ActionResultModal after MultimediaModal dismiss in MultimediaMessageMultimedia | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "@@ -44,6 +44,32 @@ import InlineMultimedia from './inline-multimedia.react';\nimport { multimediaTooltipHeight } from './multimedia-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Handle ActionResultModal after MultimediaModal dismiss in MultimediaMessageMultimedia |
129,187 | 20.04.2020 22:44:21 | 14,400 | baf51ce07f7f2fd20a118f1183171496424dde0a | [native] Fix tap gestures in MultimediaModal on Android | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -258,12 +258,8 @@ class MultimediaModal extends React.PureComponent<Props, State> {\nthis.singleTapHandler,\nthis.doubleTapHandler,\n];\n- beforeDoubleTa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix tap gestures in MultimediaModal on Android |
129,187 | 20.04.2020 23:29:49 | 14,400 | 94f82b19f54bcb803b7cf7e94d98e4f80ee9859f | [native] Fetch final URI in final processMedia check | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-utils.js",
"new_path": "native/media/media-utils.js",
"diff": "@@ -177,7 +177,7 @@ async function processMediaMission(\nconst {\nsteps: finalFileInfoSteps,\nresult: finalFileInfoResult,\n- } = await fetchFileInfo(mediaInput.uri, mediaInput.m... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fetch final URI in final processMedia check |
129,187 | 21.04.2020 13:05:25 | 14,400 | dece3045e1e5aeaee7916a09f7db4d8e54137262 | Support ArrayBuffer in fileInfoFromData | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/file-utils.js",
"new_path": "lib/utils/file-utils.js",
"diff": "@@ -30,7 +30,9 @@ export type FileDataInfo = {|\nmime: ?string,\nmediaType: ?MediaType,\n|};\n-function fileInfoFromData(data: Uint8Array | Buffer): FileDataInfo {\n+function fileInfoFro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Support ArrayBuffer in fileInfoFromData |
129,187 | 21.04.2020 15:04:31 | 14,400 | 27fb2e89ab8ea3a8e79a68dc128270584e8c5aea | [web] Unset upload if it fails | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -301,8 +301,15 @@ class ChatInputBar extends React.PureComponent<Props> {\n}\n};\n- onMultimediaFileChange = (event: SyntheticInputEvent<HTMLInputElement>) => {\n- t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Unset upload if it fails |
129,187 | 21.04.2020 16:30:12 | 14,400 | 6c345059b9f5c3a39812b414d765f427248375dd | [native] Fix MediaGalleryKeyboard eslint errors
Introduced by `react-native-reanimated` upgrade | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "@@ -77,6 +77,7 @@ class MediaGalleryKeyboard extends React.PureComponent<Props, State> {\nfetchingPhotos = false;\nflatList: ?FlatList<MediaLibr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix MediaGalleryKeyboard eslint errors
Introduced by `react-native-reanimated` upgrade |
129,187 | 21.04.2020 16:30:38 | 14,400 | bfbaa382f02e73935a6618cedac5c96401a54962 | [native] Temporary expo-media-library changes for release
Don't include videos and sort by creation time | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "@@ -212,8 +212,8 @@ class MediaGalleryKeyboard extends React.PureComponent<Props, State> {\n} = await MediaLibrary.getAssetsAsync({\nfirst: 20,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Temporary expo-media-library changes for release
Don't include videos and sort by creation time |
129,187 | 21.04.2020 16:33:18 | 14,400 | 8c6079a0145cd0f4475b75a5848f77d4ee2ad6e9 | [native] codeVersion -> 48 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -131,8 +131,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 48 |
129,187 | 22.04.2020 11:44:34 | 14,400 | dcbd73ddf0043097a1a602fdaf3c11e1e254d974 | Measure photo_capture totalTime/userTime from selection instead of capture | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -172,6 +172,7 @@ export type PhotoCapture = {|\ndimensions: Dimensions,\nfilename: string,\nuri: string,\n+ captureTime: number, // ms timestamp\nselectTime: number, // ms timestamp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Measure photo_capture totalTime/userTime from selection instead of capture |
129,187 | 22.04.2020 14:40:02 | 14,400 | b1604abbb93e79a77ebbd5a3b99c681335956bd3 | getImageProcessingPlan takes object as input | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/image-utils.js",
"new_path": "lib/utils/image-utils.js",
"diff": "@@ -11,30 +11,39 @@ const convertToPNG = new Set([\n'image/bmp',\n]);\n-type ImageProcessingPlan = {|\n+type Input = {|\n+ inputMIME: string,\n+ inputDimensions: Dimensions, // post EX... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | getImageProcessingPlan takes object as input |
129,187 | 22.04.2020 15:36:00 | 14,400 | 58325478fbb2dccae982cc06e0a90151ca395839 | [lib] Fix VideoProbeMediaMissionStep format property | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -102,7 +102,7 @@ export type VideoProbeMediaMissionStep = {|\npath: string,\next: ?string,\ncodec: ?string,\n- format: ?string,\n+ format: ?$ReadOnlyArray<string>,\n|};\nexport type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix VideoProbeMediaMissionStep format property |
129,187 | 22.04.2020 15:36:57 | 14,400 | 0c12c225941bfc89ff08f94b097b50844e8fa7dc | [native] Include x264/x265 in Android ffmpeg build
iOS doesn't need it because it has hardware-accelerated support via VideoToolbox | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -173,6 +173,13 @@ android {\n}\n}\n+\n+ packagingOptions {\n+ pickFirst 'lib/x86/libc++_shared.so'\n+ pickFirst 'lib/x86_64/libc++_shared.so'\n+ pickFirst 'lib/armeabi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Include x264/x265 in Android ffmpeg build
iOS doesn't need it because it has hardware-accelerated support via VideoToolbox |
129,187 | 22.04.2020 15:39:45 | 14,400 | bc09eb68122d4171ad36e50ef7a19df07c2a9512 | [lib] Cap ffmpeg transcode outputPath to 255 chars | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/video-utils.js",
"new_path": "lib/utils/video-utils.js",
"diff": "@@ -28,9 +28,11 @@ function getVideoProcessingPlan(input: Input): ?Plan {\nreturn null;\n}\n- const mp4Name = replaceExtension(inputFilename, 'mp4');\n- const uuid = getUUID();\n- cons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Cap ffmpeg transcode outputPath to 255 chars |
129,187 | 22.04.2020 17:06:18 | 14,400 | 58aacd4bad7f6cd257e96a245dbb0642376ae49f | [native] ffmpeg class | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/media/ffmpeg.js",
"diff": "+// @flow\n+\n+import { RNFFmpeg, RNFFprobe, RNFFmpegConfig } from 'react-native-ffmpeg';\n+\n+if (!__DEV__) {\n+ RNFFmpegConfig.disableLogs();\n+ RNFFmpegConfig.disableStatistics();\n+}\n+\n+class FFmpeg {\n+ a... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] ffmpeg class |
129,187 | 22.04.2020 18:08:12 | 14,400 | 4e84524dd41dbe124edf6b119db1405ee276cc04 | [native] Limit simultaneous ffmpeg calls | [
{
"change_type": "MODIFY",
"old_path": "native/media/ffmpeg.js",
"new_path": "native/media/ffmpeg.js",
"diff": "@@ -7,8 +7,86 @@ if (!__DEV__) {\nRNFFmpegConfig.disableStatistics();\n}\n+const maxSimultaneousCalls = {\n+ process: 4,\n+ probe: 1,\n+};\n+\n+type CallCounter = typeof maxSimultaneousCal... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Limit simultaneous ffmpeg calls |
129,187 | 22.04.2020 18:45:55 | 14,400 | 41c2fad8860620e90f677e722942828de05c108c | [lib] Get the ffmpeg command right | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/video-utils.js",
"new_path": "lib/utils/video-utils.js",
"diff": "@@ -33,7 +33,18 @@ function getVideoProcessingPlan(input: Input): ?Plan {\n'mp4',\n);\nconst outputPath = `${outputDirectory}${outputFilename}`;\n- const ffmpegCommand = `-i ${inputPat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get the ffmpeg command right |
129,187 | 22.04.2020 18:54:08 | 14,400 | e6a6f3d2ab1650dbc05e35271435ed118f57bbf0 | [lib] Shared maxDimensions for all media | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/image-utils.js",
"new_path": "lib/utils/image-utils.js",
"diff": "import type { Dimensions } from '../types/media-types';\n-const maxDimensions = Object.freeze({ width: 3000, height: 2000 });\n+import { maxDimensions } from './media-utils';\n+const {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Shared maxDimensions for all media |
129,187 | 22.04.2020 19:00:27 | 14,400 | 6a981cc59acb97d6bedd23e7a22484d121696a20 | [lib] Only skip video processing if file is less than 10MB | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/video-utils.js",
"new_path": "lib/utils/video-utils.js",
"diff": "@@ -9,7 +9,7 @@ const { height: maxHeight, width: maxWidth } = maxDimensions;\ntype Input = {|\ninputPath: string,\ninputHasCorrectContainerAndCodec: boolean,\n- inputFileSize: number,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Only skip video processing if file is less than 10MB |
129,187 | 22.04.2020 19:29:21 | 14,400 | e49bded95bf2ad559d046a958181ff8a648ca56b | [native] Pass MediaSelection directly into processMedia | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -477,39 +477,11 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nuserTime = Date.now() - start;\n};\n- let mediaInfo;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Pass MediaSelection directly into processMedia |
129,187 | 22.04.2020 19:38:43 | 14,400 | 4bc5917a831eb4d6ebebc86c256333354c82d26e | Decide ffmpeg output video CRF based on duration | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -135,7 +135,7 @@ export type MediaLibrarySelection =\nselectTime: number, // ms timestamp\nsendTime: number, // ms timestamp\nretries: number,\n- playableDuration: number,\n+ durati... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Decide ffmpeg output video CRF based on duration |
129,187 | 23.04.2020 14:31:25 | 14,400 | 153a3537ab097d01a8cff6b1cc742e18799e13d6 | [native] ClearableTextInput | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -71,6 +71,7 @@ import {\nconnectNav,\ntype NavContextType,\n} from '../navigation/navigation-context';\n+import ClearableTextInput from '../components/clearabl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] ClearableTextInput |
129,187 | 23.04.2020 15:55:12 | 14,400 | 244a74e840b8dfbd709410cdf9bb41332fe3a717 | [native] Fix up ChatInputBar send button
Avoiding `LayoutAnimation` now that we have `ClearableTextInput` and increasing the tap target | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -36,7 +36,6 @@ import {\nView,\nTextInput,\nTouchableOpacity,\n- LayoutAnimation,\nPlatform,\nText,\nActivityIndicator,\n@@ -123,6 +122,8 @@ class ChatInputBar... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up ChatInputBar send button
Avoiding `LayoutAnimation` now that we have `ClearableTextInput` and increasing the tap target |
129,187 | 23.04.2020 16:59:11 | 14,400 | 247458919e21bd831b61519bbb642634415e90a0 | [native] ClearableTextInput.getValueAndReset | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -387,7 +387,6 @@ class ChatInputBar extends React.PureComponent<Props, State> {\n</Animated.View>\n<ClearableTextInput\nvalue={this.state.text}\n- sendMessage=... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] ClearableTextInput.getValueAndReset |
129,187 | 23.04.2020 17:11:35 | 14,400 | 96038f35fba41b7e32a933fe51929ca5ddee1249 | [native] Start hiding send button immediately onSend | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -170,6 +170,15 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nreturn ChatInputBar.systemKeyboardShowing(this.props);\n}\n+ updateSendButton... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Start hiding send button immediately onSend |
129,187 | 23.04.2020 17:28:47 | 14,400 | be5607801378717be088349a9fb619fff4b8d22d | [native] ClearableTextInput for Android | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/components/clearable-text-input.react.ios.js",
"diff": "+// @flow\n+\n+import type { KeyPressEvent } from '../types/react-native';\n+\n+import * as React from 'react';\n+import { TextInput, View, StyleSheet } from 'react-native';\n+\n+imp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] ClearableTextInput for Android |
129,187 | 23.04.2020 20:06:51 | 14,400 | 5efbbc8e3fbca8f738cec1b6074e6457fb0a9125 | [native] Final ClearableTextInput fixes | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -451,7 +451,8 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nclearableTextInput,\n'clearableTextInput should be sent in onSend',\n);\n- con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Final ClearableTextInput fixes |
129,187 | 24.04.2020 19:28:45 | 14,400 | bb0578f2ccfe3ded96155a6a4939302945662dcf | [native] Don't change tabs when back button is pressed on Android | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -49,6 +49,7 @@ const TabNavigator = createBottomTabNavigator(\ninitialRouteName: CalendarRouteName,\nlazy: false,\ntabBarComponent: TabBar,\n+ backBe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't change tabs when back button is pressed on Android |
129,187 | 24.04.2020 19:29:39 | 14,400 | b05f5df146f3f413e6bd58d3ecef3af65236dd85 | [native] Don't finish SplashActivity until MainActivity is started | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/java/org/squadcal/SplashActivity.java",
"new_path": "native/android/app/src/main/java/org/squadcal/SplashActivity.java",
"diff": "@@ -22,8 +22,8 @@ public class SplashActivity extends AppCompatActivity {\nprivate void forwardIntent(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't finish SplashActivity until MainActivity is started |
129,187 | 24.04.2020 19:31:11 | 14,400 | fa0ab162fb330e4a07a95df636806e9c06417e3d | [native] Add editTextBackground for all styles.xml | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/res/values-w481dp-xxhdpi/styles.xml",
"new_path": "native/android/app/src/main/res/values-w481dp-xxhdpi/styles.xml",
"diff": "<resources>\n<style name=\"AppTheme\" parent=\"Theme.AppCompat.Light.NoActionBar\">\n+ <item name=\"androi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add editTextBackground for all styles.xml |
129,187 | 24.04.2020 21:07:41 | 14,400 | 8f96d948843f2c2e9f1ace107cb9973177ba9bca | [native] Use waitForInteractions to decide when to hide SplashScreen on Android | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -38,6 +38,7 @@ import KeyboardStateContainer from '../keyboard/keyboard-state-container.react';\nimport PushHandler from '../push/push-handler.react'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use waitForInteractions to decide when to hide SplashScreen on Android |
129,187 | 25.04.2020 00:45:39 | 14,400 | fce34c1eb0212f30713d88b5a052bed70c0388d0 | [native] Update video dimensions after transcode | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -103,6 +103,7 @@ export type VideoProbeMediaMissionStep = {|\next: ?string,\ncodec: ?string,\nformat: ?$ReadOnlyArray<string>,\n+ dimensions: ?Dimensions,\n|};\nexport type ReadFile... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update video dimensions after transcode |
129,187 | 25.04.2020 00:46:10 | 14,400 | 0e76c06be63196f376ed328d351f9ec580edc579 | [native] ffmpeg options for h264_videotoolbox | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/video-utils.js",
"new_path": "lib/utils/video-utils.js",
"diff": "// @flow\n+import invariant from 'invariant';\n+\nimport { replaceExtension } from './file-utils';\nimport { getUUID } from './uuid';\nimport { maxDimensions } from './media-utils';\n@... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] ffmpeg options for h264_videotoolbox |
129,187 | 25.04.2020 15:41:28 | 14,400 | a8b3a12b25ce969e8199394ae493cabdfd27c133 | [native] Treat animated GIFs as videos
Also lets `ffprobe` determine duration for videos since `expo-media-library` won't have it for animated GIFs | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -100,7 +100,8 @@ export type VideoProbeMediaMissionStep = {|\nexceptionMessage: ?string,\ntime: number, // ms\npath: string,\n- ext: ?string,\n+ validFormat: boolean,\n+ duration: ?... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Treat animated GIFs as videos
Also lets `ffprobe` determine duration for videos since `expo-media-library` won't have it for animated GIFs |
129,187 | 25.04.2020 19:11:30 | 14,400 | facc9e558a96b339199b79b29eb2ef8fb99c3363 | Limit videos to 180 seconds | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -283,6 +283,11 @@ export type MediaMissionFailure =\nreason: 'http_upload_failed',\nexceptionMessage: ?string,\n|}\n+ | {|\n+ success: false,\n+ reason: 'video_too_long',\n+ duratio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Limit videos to 180 seconds |
129,187 | 25.04.2020 19:24:45 | 14,400 | 1732de009df3331947fe81dd51d2d917eb0db404 | [native] Delete unused temporary files in processVideo | [
{
"change_type": "MODIFY",
"old_path": "native/media/video-utils.js",
"new_path": "native/media/video-utils.js",
"diff": "@@ -109,6 +109,9 @@ async function processVideo(\nexceptionMessage = e.message;\n}\n}\n+ if (!success) {\n+ filesystem.unlink(outputPath);\n+ }\nsteps.push({\nstep: 'video_ffmpeg... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delete unused temporary files in processVideo |
129,187 | 25.04.2020 19:33:20 | 14,400 | 92918d7af3e16215a6debb54ada7d6f05ee791b9 | [native] Avoid upscaling dimensions with h264_videotoolbox | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/video-utils.js",
"new_path": "lib/utils/video-utils.js",
"diff": "// @flow\n+import type { Dimensions } from '../types/media-types';\n+\nimport invariant from 'invariant';\nimport { replaceExtension } from './file-utils';\n@@ -14,6 +16,7 @@ type Inpu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid upscaling dimensions with h264_videotoolbox |
129,187 | 25.04.2020 19:56:31 | 14,400 | 79ce38d184f647bf434a2c30433235075f7fb936 | [native] Unlink departingURI when Multimedia unmounted | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia.react.js",
"new_path": "native/media/multimedia.react.js",
"diff": "@@ -72,6 +72,13 @@ class Multimedia extends React.PureComponent<Props, State> {\n}\n}\n+ componentWillUnmount() {\n+ const { departingURI, unlinkDepartingURI } = this.s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Unlink departingURI when Multimedia unmounted |
129,187 | 25.04.2020 23:25:57 | 14,400 | d56625e50bfc37e6dd2d7cd172c5ac6be037af56 | Add loop to Video MediaInfo | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -28,6 +28,7 @@ export type Video = {|\nuri: string,\ntype: 'video',\ndimensions: Dimensions,\n+ loop?: boolean,\n// stored on native only during creation in case retry needed after ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add loop to Video MediaInfo |
129,187 | 26.04.2020 00:47:31 | 14,400 | cf23e490a7b3e8d2535797d50680e687f0bf16a1 | Pipe loop through server/client flow | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/upload-actions.js",
"new_path": "lib/actions/upload-actions.js",
"diff": "@@ -9,22 +9,31 @@ export type MultimediaUploadCallbacks = $Shape<{|\nabortHandler: (abort: () => void) => void,\nuploadBlob: UploadBlob,\n|}>;\n+export type MultimediaUploadE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Pipe loop through server/client flow |
129,187 | 26.04.2020 16:05:15 | 14,400 | 2fb1d9373342269470e23bdab8fcc3a67eb87f68 | [native] Support for rendering animated GIFs on Android
Using Facebook Fresco | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -194,6 +194,11 @@ dependencies {\nimplementation \"com.facebook.react:react-native:+\" // From node_modules\nimplementation \"androidx.multidex:multidex:2.0.1\"\n+ imp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Support for rendering animated GIFs on Android
Using Facebook Fresco |
129,187 | 27.04.2020 12:47:56 | 14,400 | 89c0146c8ef43dd3a7dc2154d7b587c81244d6e3 | [native] Update expo-media-library patch | [
{
"change_type": "MODIFY",
"old_path": "patches/expo-media-library+8.1.0.patch",
"new_path": "patches/expo-media-library+8.1.0.patch",
"diff": "@@ -94,10 +94,10 @@ index bfe25f3..edde485 100644\nPermissions permissionsManager = mModuleRegistry.getModule(Permissions.class);\nif (permissionsManager ==... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update expo-media-library patch |
129,187 | 27.04.2020 14:44:37 | 14,400 | 26128e19380b59f9534700bb53565a36b8319637 | [native] Don't use mediaType before it's set in processMedia | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-utils.js",
"new_path": "native/media/media-utils.js",
"diff": "@@ -92,6 +92,7 @@ async function processMediaMission(\n});\n};\n+ const possiblyPhoto = selection.step.startsWith('photo_');\nconst mediaNativeID = selection.mediaNativeID\n? sel... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't use mediaType before it's set in processMedia |
129,187 | 27.04.2020 14:50:24 | 14,400 | 90e941e5508d5972d35a87adc671a2a28720630e | [native] saveImage only needs URI | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-tooltip-modal.react.js",
"new_path": "native/chat/multimedia-tooltip-modal.react.js",
"diff": "@@ -14,7 +14,7 @@ type CustomProps = {\n};\nfunction onPressSave(props: CustomProps) {\n- return intentionalSaveImage(props.mediaInfo);\n+ ret... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] saveImage only needs URI |
129,187 | 27.04.2020 14:53:37 | 14,400 | d296c48ffddbb49b4480235229185eb45bb5d67d | [native] saveImage -> saveMedia | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-tooltip-modal.react.js",
"new_path": "native/chat/multimedia-tooltip-modal.react.js",
"diff": "@@ -5,7 +5,7 @@ import type { ChatMultimediaMessageInfoItem } from './multimedia-message.react';\nimport { createTooltip, tooltipHeight } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] saveImage -> saveMedia |
129,187 | 27.04.2020 15:03:25 | 14,400 | cd0fc2425564d2a8fea2ab35047a95287159d1c9 | [native] Move saveMedia for captures to processMedia | [
{
"change_type": "MODIFY",
"old_path": "native/media/camera-modal.react.js",
"new_path": "native/media/camera-modal.react.js",
"diff": "@@ -61,7 +61,6 @@ import ConnectedStatusBar from '../connected-status-bar.react';\nimport { clamp, gestureJustEnded } from '../utils/animation-utils';\nimport Conte... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move saveMedia for captures to processMedia |
129,187 | 27.04.2020 17:38:06 | 14,400 | 819ab2606855a4ef8fe9b327bc45e50e758a2c41 | [native] disposeTempFile | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -130,6 +130,14 @@ export type FrameCountMediaMissionStep = {|\nhasMultipleFrames: ?boolean,\n|};\n+export type DisposeTemporaryFileMediaMissionStep = {|\n+ step: 'dispose_temporary_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] disposeTempFile |
129,187 | 27.04.2020 20:59:40 | 14,400 | 1f914f8f25d52f891d1e2dbe26d43ab9392dcbf5 | [server] Update squadbot's message for MediaMission reports | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/report-creator.js",
"new_path": "server/src/creators/report-creator.js",
"diff": "@@ -163,8 +163,8 @@ function getSquadbotMessage(\n} else if (request.type === reportTypes.MEDIA_MISSION) {\nconst mediaMissionJSON = JSON.stringify(request.me... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update squadbot's message for MediaMission reports |
129,187 | 27.04.2020 23:08:12 | 14,400 | ec888bc67bcb305fb4dc1cd65a982cd22077c9ad | Send MediaMission from intentionalSaveImage | [
{
"change_type": "MODIFY",
"old_path": "lib/types/report-types.js",
"new_path": "lib/types/report-types.js",
"diff": "@@ -89,9 +89,11 @@ export type MediaMissionReportCreationRequest = {|\nplatformDetails: PlatformDetails,\ntime: number, // ms\nmediaMission: MediaMission,\n- uploadServerID: ?string,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Send MediaMission from intentionalSaveImage |
129,187 | 27.04.2020 23:28:56 | 14,400 | 91e9625fd3b934cd5243e4028b268e7e061e3bfe | [native] Only check header of blob for fileType | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/file-utils.js",
"new_path": "lib/utils/file-utils.js",
"diff": "@@ -30,6 +30,8 @@ const mimeTypesToExtensions = Object.freeze({\n'video/quicktime': 'mp4',\n});\n+const bytesNeededForFileTypeCheck = 64;\n+\nexport type FileDataInfo = {|\nmime: ?string... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Only check header of blob for fileType |
129,187 | 28.04.2020 00:36:08 | 14,400 | e8f4af16e1d5e67e896cebc6e0d1c279ac5a9890 | [native] Initial save_media step for intentionalSaveMedia | [
{
"change_type": "MODIFY",
"old_path": "lib/types/media-types.js",
"new_path": "lib/types/media-types.js",
"diff": "@@ -279,6 +279,11 @@ export type MediaMissionStep =\nnewPath: ?string,\n|}\n| DisposeTemporaryFileMediaMissionStep\n+ | {|\n+ step: 'save_media',\n+ uri: string,\n+ time: number, // ms... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Initial save_media step for intentionalSaveMedia |
129,187 | 29.04.2020 01:03:02 | 14,400 | 9e171489252630bba9b510a234f9cb0cc714417d | [native] Use MediaLibrary.requestPermissionsAsync in Android MediaGalleryKeyboard | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "@@ -10,14 +10,7 @@ import type { ViewToken, LayoutEvent } from '../types/react-native';\nimport type { ViewStyle } from '../types/styles';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use MediaLibrary.requestPermissionsAsync in Android MediaGalleryKeyboard |
129,187 | 29.04.2020 01:04:31 | 14,400 | 60da4c583a84db6f08c483e366ff9b6294988160 | [native] Rework android-permissions.js | [
{
"change_type": "MODIFY",
"old_path": "native/media/save-media.js",
"new_path": "native/media/save-media.js",
"diff": "@@ -32,7 +32,7 @@ import {\ncopyFile,\n} from './file-utils';\nimport { displayActionResultModal } from '../navigation/action-result-modal';\n-import { getAndroidPermission } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rework android-permissions.js |
129,187 | 29.04.2020 19:25:39 | 14,400 | 24dd5bd2b9de7ffff06db6aa0d755ebfcc2730d4 | [native] Increase Java heap size for Android build | [
{
"change_type": "MODIFY",
"old_path": "native/android/gradle.properties",
"new_path": "native/android/gradle.properties",
"diff": "# Specifies the JVM arguments used for the daemon process.\n# The setting is particularly useful for tweaking memory settings.\n# Default value: -Xmx10248m -XX:MaxPermS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Increase Java heap size for Android build |
129,187 | 29.04.2020 14:47:38 | 14,400 | 6ca0d2523ecf19f48b07a0e9fd3dd4417d847000 | [native] Fix Hermes path in Android build.gradle
Enabling right now trashes performance, likely because of | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -78,6 +78,7 @@ import com.android.build.OutputFile\nproject.ext.react = [\nentryFile: \"index.js\",\nenableHermes: false, // clean and rebuild if changing\n+ hermesCom... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Hermes path in Android build.gradle
Enabling right now trashes performance, likely because of https://github.com/facebook/hermes/issues/111
https://github.com/facebook/react-native/issues/25986 |
129,187 | 29.04.2020 01:05:15 | 14,400 | 683743be5e006f084c0435be7af34eb8e061e012 | [native] Ask for permissions before opening CameraModal | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -40,6 +40,7 @@ import {\nText,\nActivityIndicator,\nTouchableWithoutFeedback,\n+ PermissionsAndroid,\n} from 'react-native';\nimport Icon from 'react-native-ve... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Ask for permissions before opening CameraModal |
129,187 | 29.04.2020 22:27:54 | 14,400 | bd8bb7643e4f296ccbcc1e6a48891372c9b313e5 | [native] Prevent weirdo Android rendering bug that happens before camera permissions request | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -55,6 +55,7 @@ import { saveDraftActionType } from 'lib/actions/miscellaneous-action-types';\nimport { threadHasPermission, viewerIsMember } from 'lib/shared/t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Prevent weirdo Android rendering bug that happens before camera permissions request |
129,187 | 30.04.2020 00:28:50 | 14,400 | cafb60016c0c9de9b27cf46b34495bc8f17a644a | [native] Don't show sessionInvalidationAlert unless we were logged in before | [
{
"change_type": "MODIFY",
"old_path": "native/redux/redux-setup.js",
"new_path": "native/redux/redux-setup.js",
"diff": "@@ -317,7 +317,12 @@ function reducer(state: AppState = defaultState, action: *) {\n}\nfunction sessionInvalidationAlert(payload: SetSessionPayload) {\n- if (!payload.sessionChan... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't show sessionInvalidationAlert unless we were logged in before |
129,187 | 30.04.2020 12:46:02 | 14,400 | 74490a678c6e9076f6089109ca1ebfc3fad287d6 | [native] Don't hide keyboard events while app is in background
I initially added this behavior over 2 years ago in
I can't figure out why I did or if it's still needed. Maybe I added it to do with `Modal`s at the time? | [
{
"change_type": "MODIFY",
"old_path": "native/keyboard/keyboard-avoiding-view.react.js",
"new_path": "native/keyboard/keyboard-avoiding-view.react.js",
"diff": "@@ -11,7 +11,6 @@ import {\nPlatform,\nView,\nViewPropTypes,\n- AppState,\n} from 'react-native';\nimport PropTypes from 'prop-types';\nim... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't hide keyboard events while app is in background
I initially added this behavior over 2 years ago in bcab1b6fc51f90215aca599dee4b098a21fe06c6
I can't figure out why I did or if it's still needed. Maybe I added it to do with `Modal`s at the time? |
129,187 | 30.04.2020 21:44:10 | 14,400 | 30b319ea41215db1ab8aef3e93647e7cc65d7914 | [native] AndroidLifecycleModule | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -195,6 +195,9 @@ dependencies {\nimplementation \"com.facebook.react:react-native:+\" // From node_modules\nimplementation \"androidx.multidex:multidex:2.0.1\"\n+ impl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] AndroidLifecycleModule |
129,187 | 30.04.2020 22:07:53 | 14,400 | 7c7acc93b55b5f4852963bd8c544de4878dd8632 | [native] LifecycleHandler | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/lifecycle/lifecycle-handler.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { useDispatch } from 'react-redux';\n+import { AppState as NativeAppState } from 'react-native';\n+\n+import {\n+ backgroundActionType... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] LifecycleHandler |
129,187 | 30.04.2020 22:16:30 | 14,400 | 3231310a0af2a9714a7517411244d7b18e6045d9 | [native] addLifecycleListener | [
{
"change_type": "MODIFY",
"old_path": "native/lifecycle/lifecycle-handler.react.js",
"new_path": "native/lifecycle/lifecycle-handler.react.js",
"diff": "import * as React from 'react';\nimport { useDispatch } from 'react-redux';\n-import { AppState as NativeAppState } from 'react-native';\nimport {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] addLifecycleListener |
129,187 | 30.04.2020 22:20:44 | 14,400 | 7a5f479ac9ab297494664a38e02093ce60ecc965 | [native] Move PushHandler to addLifecycleListener | [
{
"change_type": "MODIFY",
"old_path": "native/lifecycle/lifecycle.js",
"new_path": "native/lifecycle/lifecycle.js",
"diff": "@@ -11,4 +11,8 @@ function addLifecycleListener(listener: (state: ?string) => mixed) {\n};\n}\n-export { addLifecycleListener };\n+function getCurrentLifecycleState() {\n+ re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move PushHandler to addLifecycleListener |
129,187 | 30.04.2020 22:23:31 | 14,400 | 8802c176ab16a5020b3d21274bf9ef7fc9ef4a1d | [native] Use AndroidLifecycleModule in lifecycle.js | [
{
"change_type": "MODIFY",
"old_path": "native/lifecycle/lifecycle.js",
"new_path": "native/lifecycle/lifecycle.js",
"diff": "// @flow\n-import { AppState as NativeAppState } from 'react-native';\n+import {\n+ Platform,\n+ AppState as NativeAppState,\n+ DeviceEventEmitter,\n+ NativeModules,\n+} from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use AndroidLifecycleModule in lifecycle.js |
129,187 | 01.05.2020 00:05:26 | 14,400 | df3bed4b67cdcead8d9b692bd6131c6389bca061 | [native] LifecycleEventEmitter | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/lifecycle/lifecycle-event-emitter.js",
"diff": "+// @flow\n+\n+import invariant from 'invariant';\n+import { Platform } from 'react-native';\n+\n+import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport';\n+import * ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] LifecycleEventEmitter |
129,187 | 01.05.2020 00:08:32 | 14,400 | 75eba8fd512b448bb9b39005750ee78d655bb01b | [native] Fix bug where Lifecycle listener subscription wasn't being torn down properly | [
{
"change_type": "MODIFY",
"old_path": "native/lifecycle/lifecycle-handler.react.js",
"new_path": "native/lifecycle/lifecycle-handler.react.js",
"diff": "@@ -33,8 +33,8 @@ const LifecycleHandler = React.memo<{||}>(() => {\n);\nReact.useEffect(() => {\n- const { remove } = addLifecycleListener(onLife... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix bug where Lifecycle listener subscription wasn't being torn down properly |
129,187 | 01.05.2020 16:14:39 | 14,400 | f4a18b1dfcde9b94bf2a7b7cea68b8d03ba5b435 | [native] Prevent ActionResultModal from capturing presses | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/action-result-modal.js",
"new_path": "native/navigation/action-result-modal.js",
"diff": "@@ -12,7 +12,7 @@ function displayActionResultModal(message: string) {\nnavContext.dispatch(\nNavigationActions.navigate({\nrouteName: ActionResultModal... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Prevent ActionResultModal from capturing presses |
129,187 | 01.05.2020 16:29:26 | 14,400 | 0b4b8147d29e48eb942163583cc3391d5b84359b | [native] Extend ActionResultModal lifespan if its text changes | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/action-result-modal.react.js",
"new_path": "native/navigation/action-result-modal.react.js",
"diff": "@@ -9,7 +9,6 @@ import type { AppState } from '../redux/redux-setup';\nimport * as React from 'react';\nimport { View, Text } from 'react-na... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extend ActionResultModal lifespan if its text changes |
129,187 | 01.05.2020 17:06:24 | 14,400 | 57bf35266e68204147194029dee7d1a87a7a16e6 | [native] Prevent phantom SendMediaButton on Android MediaGalleryKeyboard
See code comment | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "@@ -10,7 +10,13 @@ import type { ViewToken, LayoutEvent } from '../types/react-native';\nimport type { ViewStyle } from '../types/styles';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Prevent phantom SendMediaButton on Android MediaGalleryKeyboard
See code comment |
129,187 | 01.05.2020 17:43:38 | 14,400 | 7728db3ef961c1cc59ad28b59ba8fc6eaa7bae0d | [native] Fix Android BackHandler behavior | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/java/org/squadcal/MainActivity.java",
"new_path": "native/android/app/src/main/java/org/squadcal/MainActivity.java",
"diff": "@@ -52,7 +52,7 @@ public class MainActivity extends ReactFragmentActivity {\n}\n@Override\n- public void o... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Android BackHandler behavior |
129,187 | 02.05.2020 18:56:32 | 14,400 | cf95ad61ec82de9bb62d30afc805b68177372e1d | [native] Let CameraModal ask for Android permissions instead of ChatInputBar
Continuing to see really strange render issues having to do with the permissions activity. After several full days of debugging I'm giving up lol | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -40,7 +40,6 @@ import {\nText,\nActivityIndicator,\nTouchableWithoutFeedback,\n- PermissionsAndroid,\n} from 'react-native';\nimport Icon from 'react-native-ve... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Let CameraModal ask for Android permissions instead of ChatInputBar
Continuing to see really strange render issues having to do with the permissions activity. After several full days of debugging I'm giving up lol |
129,187 | 03.05.2020 16:50:25 | 14,400 | 680eb625cd4669996fd4ecb2319cc6ab64a68ac2 | [native] Move capture disposal to InputStateContainer | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -130,6 +130,7 @@ class InputStateContainer extends React.PureComponent<Props, State> {\npendingUploads: {},\n};\nsendCallbacks: Array<() => voi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move capture disposal to InputStateContainer |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.