author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 27.09.2017 15:15:21 | 14,400 | 1b47680098e3100d618f6f824ef82c48c9cb69c1 | MySQL escape the json_encode'd blob, and use the raw name in all payloads | [
{
"change_type": "MODIFY",
"old_path": "server/new_thread.php",
"new_path": "server/new_thread.php",
"diff": "@@ -75,7 +75,8 @@ if ($vis_rules === VISIBILITY_NESTED_OPEN) {\n}\n}\n-$name = $conn->real_escape_string($_POST['name']);\n+$raw_name = $_POST['name'];\n+$name = $conn->real_escape_string($r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | MySQL escape the json_encode'd blob, and use the raw name in all payloads |
129,187 | 27.09.2017 15:52:13 | 14,400 | 8274160365841dac0f66f7d7f1ad94f5f7ef0e0e | Simplify MessageListHeaderTitle logic and make sure forward caret always appears on Android | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-header-title.react.js",
"new_path": "native/chat/message-list-header-title.react.js",
"diff": "@@ -98,24 +98,13 @@ const styles = StyleSheet.create({\nbottom: 0,\n},\ncontainer: {\n- backgroundColor: 'transparent',\n- position: 'absolu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Simplify MessageListHeaderTitle logic and make sure forward caret always appears on Android |
129,187 | 27.09.2017 17:34:05 | 14,400 | 57a5cd7577174169284248e55a6b73b87ec66445 | Thread settings panel boilerplate | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -11,12 +11,17 @@ import {\n} from './chat-thread-list.react';\nimport { MessageList, MessageListRouteName } from './message-list.react';\nimport { AddThread, AddThreadRouteName } ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Thread settings panel boilerplate |
129,187 | 27.09.2017 21:19:37 | 14,400 | 0ab9efa067c026ddc790af93351ecac3134d4f53 | ColorSplotch component | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/thread-picker-thread.react.js",
"new_path": "native/calendar/thread-picker-thread.react.js",
"diff": "@@ -8,6 +8,7 @@ import { Text, View, StyleSheet } from 'react-native';\nimport PropTypes from 'prop-types';\nimport Button from '../components... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | ColorSplotch component |
129,187 | 27.09.2017 21:22:21 | 14,400 | 4ea5dcc9cdf3d48fdd6846156ad3a84d3819fac5 | Show name and color in thread settings panel | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -14,7 +14,7 @@ import { AddThread, AddThreadRouteName } from './add-thread.react';\nimport {\nThreadSettings,\nThreadSettingsRouteName,\n-} from './thread-settings.react';\n+} fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Show name and color in thread settings panel |
129,187 | 28.09.2017 16:13:03 | 14,400 | b7398499dff2e8959b8c13b79a1f5798118f21f7 | Add a bunch of stuff - visibility, members - to thread settings panel, and refine the style a little bit | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/user-selectors.js",
"new_path": "lib/selectors/user-selectors.js",
"diff": "// @flow\nimport type { BaseAppState } from '../types/redux-types';\n-import type { UserInfo } from '../types/user-types';\n+import type { UserInfo, RelativeUserInfo } fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add a bunch of stuff - visibility, members - to thread settings panel, and refine the style a little bit |
129,187 | 29.09.2017 11:35:14 | 14,400 | d0bef5a233a4e1c5203b3810d113734ce38a4234 | Call Calendar.scrollToToday() when the calendar tab gets clicked when already focused | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -76,6 +76,20 @@ type CalendarItemWithHeight =\nitemType: \"footer\",\ndateString: string,\n};\n+type ExtraData = {\n+ focusedEntries: {[key: string]: bool},\n+ vis... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Call Calendar.scrollToToday() when the calendar tab gets clicked when already focused |
129,187 | 29.09.2017 11:35:49 | 14,400 | f83b6636cc49f421959c978390dbf2e249b9aaf9 | Default to the chat screen when opening the app | [
{
"change_type": "MODIFY",
"old_path": "native/navigation-setup.js",
"new_path": "native/navigation-setup.js",
"diff": "@@ -157,7 +157,7 @@ const defaultNavigationState = {\n{\nkey: 'App',\nrouteName: AppRouteName,\n- index: 0,\n+ index: 1,\nroutes: [\n{ key: 'Calendar', routeName: CalendarRouteName... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Default to the chat screen when opening the app |
129,187 | 29.09.2017 14:08:14 | 14,400 | 94692f4ce3f5bc493825499060efc18be5d10838 | Only require personal password for some edit_thread.php calls | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -14,14 +14,13 @@ if (!user_logged_in()) {\n));\n}\n-if (!isset($_POST['thread']) || !isset($_POST['personal_password'])) {\n+if (!isset($_POST['thread'])) {\nasync_end(array(\n'error' =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only require personal password for some edit_thread.php calls |
129,187 | 29.09.2017 15:15:53 | 14,400 | 1ff22b419c22d96f41a3fd12f2eabd30dc5a0cb9 | Factor out SQL logic for message info creation into create_message_infos | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/message-actions.js",
"new_path": "lib/actions/message-actions.js",
"diff": "@@ -66,8 +66,8 @@ async function sendMessage(\n'text': text,\n});\nreturn {\n- id: response.result.id,\n- time: response.result.time,\n+ id: response.new_message_infos[0].i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out SQL logic for message info creation into create_message_infos |
129,187 | 29.09.2017 16:21:38 | 14,400 | 42fbb3e2d7385a98fe6b5c6468ecdf68f69728f1 | Add MESSAGE_TYPE_CHANGE_SETTINGS | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -8,12 +8,13 @@ import { relativeUserInfoPropType } from './user-types';\nimport invariant from 'invariant';\nimport PropTypes from 'prop-types';\n-export type MessageType = 0 | ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add MESSAGE_TYPE_CHANGE_SETTINGS |
129,187 | 29.09.2017 17:53:58 | 14,400 | 8d84c12ebcaf7c1dd6fd4934e56400cfc41f58a8 | Create messages for edit_thread.php calls | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -5,6 +5,7 @@ require_once('config.php');\nrequire_once('auth.php');\nrequire_once('thread_lib.php');\nrequire_once('user_lib.php');\n+require_once('message_lib.php');\nasync_start();\n@... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Create messages for edit_thread.php calls |
129,187 | 29.09.2017 18:03:12 | 14,400 | f36ae51a261d40d2a697d6824fa5df1afc5e4c8e | Don't require ROLE_CREATOR for user adds | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -22,6 +22,11 @@ if (!isset($_POST['thread'])) {\n}\n$user = get_viewer_id();\n$thread = (int)$_POST['thread'];\n+if (!viewer_can_edit_thread($thread)) {\n+ async_end(array(\n+ 'error' =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't require ROLE_CREATOR for user adds |
129,187 | 29.09.2017 18:12:21 | 14,400 | 5f1ca19883f94d9181962e5971d839fee2eade1a | Fix some minor errors (type-related) in my scrollToToday() diff earlier today | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -88,7 +88,7 @@ type ExtraData = {\n// But not this particular piece of sadness, actually. We have to cache the\n// current InnerCalendar ref here so we can access ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix some minor errors (type-related) in my scrollToToday() diff earlier today |
129,187 | 29.09.2017 19:00:43 | 14,400 | 265fa188fc5856ae5a84d0b588a2344e9391254f | RawMessageInfos Redux for CHANGE_THREAD_SETTINGS type and all Redux for ADD_USERS_TO_THREAD | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -30,6 +30,10 @@ async function deleteThread(\nreturn threadID;\n}\n+export type ChangeThreadSettingsResult = {|\n+ threadInfo: ThreadInfo,\n+ newMessageInfos: RawMessageIn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RawMessageInfos Redux for CHANGE_THREAD_SETTINGS type and all Redux for ADD_USERS_TO_THREAD |
129,187 | 29.09.2017 20:27:08 | 14,400 | 5b67ffc3365a97f4a30f2cdb3853fc692eb4f061 | Factor out getUserSearchResults | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/shared/search-utils.js",
"diff": "+// @flow\n+\n+import type { UserInfo } from 'lib/types/user-types';\n+import SearchIndex from 'lib/shared/search-index';\n+\n+function getUserSearchResults(\n+ text: string,\n+ userInfos: {[id: string]: Use... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Factor out getUserSearchResults |
129,187 | 30.09.2017 13:38:04 | 14,400 | c87c383c9eaa531a244bb0c30dc8c7337f6ba1fa | Add react-native-modal and switch ThreadPicker to using it | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -50,6 +50,7 @@ import {\n} from 'lib/utils/action-utils';\nimport { simpleNavID } from 'lib/selectors/nav-selectors';\nimport { registerFetchKey } from 'lib/reduce... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add react-native-modal and switch ThreadPicker to using it |
129,187 | 30.09.2017 13:43:58 | 14,400 | 987db3d3e56161592c2b906155eb1781c28afb71 | ConnectedStatusBar in the whole app (not just Calendar) now | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -22,6 +22,8 @@ import {\nUIManager,\nAppState as NativeAppState,\nLinking,\n+ View,\n+ StyleSheet,\n} from 'react-native';\nimport { addNavigationHelpers } from 'react-navigation';\nimport in... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | ConnectedStatusBar in the whole app (not just Calendar) now |
129,187 | 02.10.2017 16:44:02 | 14,400 | fffb24d04d5a281860ea854adf4f224d15dc639a | Fix loading-selector tracking key logic to match loading-reducer | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/loading-selectors.js",
"new_path": "lib/selectors/loading-selectors.js",
"diff": "@@ -8,6 +8,7 @@ import { createSelector } from 'reselect';\nimport _isEmpty from 'lodash/fp/isEmpty';\nimport _includes from 'lodash/fp/includes';\nimport _memoize ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix loading-selector tracking key logic to match loading-reducer |
129,187 | 02.10.2017 16:45:39 | 14,400 | 9d8c15242190e1013a87541acc86a6a6bebcca81 | Lift margin out of UserList, add loadingStatusPropType, and registerFetchKey(searchUsersActionTypes) | [
{
"change_type": "MODIFY",
"old_path": "lib/types/loading-types.js",
"new_path": "lib/types/loading-types.js",
"diff": "// @flow\n+import PropTypes from 'prop-types';\n+\nexport type LoadingStatus = \"inactive\" | \"loading\" | \"error\";\n+export const loadingStatusPropType = PropTypes.oneOf([\n+ \... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Lift margin out of UserList, add loadingStatusPropType, and registerFetchKey(searchUsersActionTypes) |
129,187 | 02.10.2017 16:54:59 | 14,400 | 048bd8b8217695938d979c2b9d6f2f378cf9d6e8 | Add minHeight, defaultInputWidth to TagInput | [
{
"change_type": "MODIFY",
"old_path": "native/components/tag-input.react.js",
"new_path": "native/components/tag-input.react.js",
"diff": "@@ -33,7 +33,9 @@ const defaultProps = {\ntagColor: '#dddddd',\ntagTextColor: '#777777',\ninputColor: '#777777',\n+ minHeight: 27,\nmaxHeight: 75,\n+ defaultInp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add minHeight, defaultInputWidth to TagInput |
129,187 | 02.10.2017 17:12:07 | 14,400 | 61136d46da1f93a09db6e2fe84f0298fe30b8051 | Make sure edit_thread.php returns ThreadInfo correctly | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -351,7 +351,7 @@ if ($add_member_ids && $next_vis_rules === VISIBILITY_NESTED_OPEN) {\n}\ncreate_user_roles($roles_to_save);\n-$thread_infos = get_thread_infos(\"t.id = {$thread}\");\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure edit_thread.php returns ThreadInfo correctly |
129,187 | 02.10.2017 17:20:31 | 14,400 | 86d19260299f5c3b548696b0bc1e761b6e1050af | Working AddUsersModal for adding users to a thread | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/add-users-modal.react.js",
"diff": "+// @flow\n+\n+import type { AppState } from '../../redux-setup';\n+import type { ThreadInfo } from 'lib/types/thread-types';\n+import { threadInfoPropType } from 'lib/types/thread-types';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Working AddUsersModal for adding users to a thread |
129,187 | 03.10.2017 13:52:43 | 14,400 | bba38cf4432e7723ea988a295edf71a31c1421a5 | Split ThreadSettingsUser and ThreadSettingsAddListItem (previously ThreadSettingsAddUser) | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/settings/thread-settings-add-list-item.react.js",
"diff": "+\n+// @flow\n+\n+import React from 'react';\n+import { View, Text, StyleSheet } from 'react-native';\n+import Icon from 'react-native-vector-icons/Ionicons';\n+\n+import But... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Split ThreadSettingsUser and ThreadSettingsAddListItem (previously ThreadSettingsAddUser) |
129,187 | 03.10.2017 17:37:59 | 14,400 | 884b4e9a275db041bbd8fb7915645617b87819d4 | chatScreenRegistry to allow resetting the chat stack to the first screen | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -62,6 +62,7 @@ import TagInput from '../components/tag-input.react';\nimport UserList from '../components/user-list.react';\nimport LinkButton from '../components/link... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | chatScreenRegistry to allow resetting the chat stack to the first screen |
129,187 | 03.10.2017 17:39:12 | 14,400 | ba66f69ba59f8352ebbdb17855a4b51e9a578d97 | ColorSplotch updates and support for "small" variant | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -12,6 +12,7 @@ import PropTypes from 'prop-types';\nimport Button from '../components/button.react';\nimport MessagePreview from './message-previ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | ColorSplotch updates and support for "small" variant |
129,187 | 03.10.2017 17:41:48 | 14,400 | ef79bd8b92b53d4b642f8e7866eb19498adb0928 | Clickable list of child threads in thread settings | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/thread-selectors.js",
"new_path": "lib/selectors/thread-selectors.js",
"diff": "@@ -112,8 +112,28 @@ const currentDaysToEntries = createSelector(\n},\n);\n+const childThreadInfos = createSelector(\n+ (state: BaseAppState) => state.threadInfos,\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Clickable list of child threads in thread settings |
129,187 | 03.10.2017 18:21:31 | 14,400 | 2f3e57311375d2a52b768cf89bf92fc6a3476490 | Paginate child threads and members in thread settings | [
{
"change_type": "RENAME",
"old_path": "native/chat/settings/thread-settings-add-list-item.react.js",
"new_path": "native/chat/settings/thread-settings-list-action.react.js",
"diff": "-\n// @flow\n+import type {\n+ StyleObj,\n+} from 'react-native/Libraries/StyleSheet/StyleSheetTypes';\n+\nimport Re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Paginate child threads and members in thread settings |
129,187 | 03.10.2017 19:48:42 | 14,400 | 70c11db45735a66405dadc41682671ee19f13eaf | Fix close-modal-by-clicking-background for AddUsersModal | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/add-users-modal.react.js",
"new_path": "native/chat/settings/add-users-modal.react.js",
"diff": "@@ -357,12 +357,12 @@ class AddUsersModal extends React.PureComponent {\nconst styles = StyleSheet.create({\ncontainer: {\nflex: 1,\n- },\n- m... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix close-modal-by-clicking-background for AddUsersModal |
129,187 | 04.10.2017 11:45:37 | 14,400 | 81594e1fe7019f72c94541ebd6ca830bfa1f68af | Fix nested scrolling behavior of Entry on iOS (and bump react-native version) | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -484,10 +484,10 @@ const styles = StyleSheet.create({\ntext: {\nfontSize: 16,\npaddingTop: 5,\n- paddingBottom: 5,\n+ paddingBottom: 4,\npaddingLeft: 10,\npaddingRight: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix nested scrolling behavior of Entry on iOS (and bump react-native version) |
129,187 | 04.10.2017 15:25:12 | 14,400 | 65e0d64c4078fb4ce10cfb26513caba740f8f99e | Stop importing the BaseAppState type in all reducers | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/cookie-reducer.js",
"new_path": "lib/reducers/cookie-reducer.js",
"diff": "// @flow\n-import type { BaseAppState, BaseAction } from '../types/redux-types';\n+import type { BaseAction } from '../types/redux-types';\nexport default function reduceCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Stop importing the BaseAppState type in all reducers |
129,187 | 04.10.2017 15:26:06 | 14,400 | ddcce57fb248ae64f6e6e55bcfb7114cb78767a5 | Introduce "drafts" to Redux state | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/reducers/draft-reducer.js",
"diff": "+// @flow\n+\n+import type { BaseAction } from '../types/redux-types';\n+\n+function reduceDrafts(\n+ state: ?{[key: string]: string},\n+ action: BaseAction,\n+): {[key: string]: string} {\n+ if (!state) ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce "drafts" to Redux state |
129,187 | 04.10.2017 23:52:00 | 14,400 | c9a10ad34efa78d5072455fffe7fb6472ec4a793 | Use Redux-synced ThreadInfo in MessageList | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -102,6 +102,7 @@ type Props = {\nmessageListData: $ReadOnlyArray<ChatMessageItem>,\nviewerID: ?string,\nstartReached: bool,\n+ threadInfo: ThreadInfo,\n// Redux di... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use Redux-synced ThreadInfo in MessageList |
129,187 | 05.10.2017 00:16:37 | 14,400 | bc649d4027e92aa5fe8c7791a0e53897e0fbc826 | Support for editing names | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -64,6 +64,22 @@ async function changeThreadSettings(\n};\n}\n+async function changeSingleThreadSetting(\n+ fetchJSON: FetchJSON,\n+ threadID: string,\n+ field: \"name\" | ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Support for editing names |
129,187 | 05.10.2017 00:21:18 | 14,400 | e8d8cf0261c940816fc567d6adac10c0fd152f2a | Don't bother saving if the thread name is the same as the current one | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -415,7 +415,11 @@ class InnerThreadSettings extends React.PureComponent {\n\"should be set\",\n);\nconst name = this.state.nameEditValue.tr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't bother saving if the thread name is the same as the current one |
129,187 | 05.10.2017 00:22:17 | 14,400 | eff520e7bc4b79b21f0a582a89cfe8501e3ad9f5 | Update the robotext for messageType.CHANGE_SETTINGS | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -96,7 +96,7 @@ function robotextForMessageInfo(\nreturn `${creator} created a child thread named ` +\n`\"<${encodeURI(childName)}|t${messageInfo.childThreadInfo.id}>\"`;\n} el... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update the robotext for messageType.CHANGE_SETTINGS |
129,187 | 05.10.2017 16:07:38 | 14,400 | 5957038930fa75f5047461cac2b590e70436166f | Fix styling of TextInput for name in ThreadSettings | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/save-setting-button.react.js",
"new_path": "native/chat/settings/save-setting-button.react.js",
"diff": "@@ -22,13 +22,12 @@ function SaveSettingButton(props: Props) {\nconst styles = StyleSheet.create({\neditIcon: {\n- paddingLeft: 10,\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix styling of TextInput for name in ThreadSettings |
129,187 | 05.10.2017 18:18:40 | 14,400 | ddc1944dba30b637e8b9bcb7b31bb0bb52a12c44 | Color part of the robotext for a thread-color-changed message | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -96,8 +96,14 @@ function robotextForMessageInfo(\nreturn `${creator} created a child thread named ` +\n`\"<${encodeURI(childName)}|t${messageInfo.childThreadInfo.id}>\"`;\n} e... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Color part of the robotext for a thread-color-changed message |
129,187 | 05.10.2017 18:56:20 | 14,400 | 172046739e565da2c32f6b5045a21a0e420be38b | Use "oldColor" functionality on edit thread and add subthread views | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -227,6 +227,9 @@ class InnerAddThread extends React.PureComponent {\n</View>\n);\n}\n+ const oldColor = this.props.parentThreadInfo\n+ ? this.props.parentThreadInfo.co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use "oldColor" functionality on edit thread and add subthread views |
129,187 | 06.10.2017 14:08:41 | 14,400 | b2f35373ef95e6963c96deddd40b5fe669104512 | Refactor PanelButton to use Button | [
{
"change_type": "MODIFY",
"old_path": "native/account/panel-components.react.js",
"new_path": "native/account/panel-components.react.js",
"diff": "// @flow\nimport type { LoadingStatus } from 'lib/types/loading-types';\n+import { loadingStatusPropType } from 'lib/types/loading-types';\nimport type ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Refactor PanelButton to use Button |
129,187 | 06.10.2017 16:59:56 | 14,400 | f3d6ef62e16b64ecf38bd8e568723414d76cf66c | Implement assertNavigationRouteNotLeafNode and use it in AddThread's connect call | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -61,6 +61,7 @@ import LinkButton from '../components/link-button.react';\nimport { MessageListRouteName } from './message-list.react';\nimport { registerChatScreen } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Implement assertNavigationRouteNotLeafNode and use it in AddThread's connect call |
129,187 | 06.10.2017 17:00:32 | 14,400 | eed578246ad39a0db602722b7548299361adb2db | Make thread name clickable in Entry | [
{
"change_type": "MODIFY",
"old_path": "native/account/panel-components.react.js",
"new_path": "native/account/panel-components.react.js",
"diff": "@@ -110,10 +110,8 @@ const styles = StyleSheet.create({\nsubmitContentContainer: {\nflexDirection: 'row',\nalignItems: 'flex-end',\n- paddingLeft: 18,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make thread name clickable in Entry |
129,187 | 11.10.2017 10:50:34 | 14,400 | 85390d2dc693b5582aa23126734ad2c5f4f7b18d | Create permissions.php and move all viewer_can_ functions there | [
{
"change_type": "MODIFY",
"old_path": "server/auth.php",
"new_path": "server/auth.php",
"diff": "@@ -327,193 +327,3 @@ function set_cookie($name, $value, $expiration_time) {\ntrue // no JS access\n);\n}\n-\n-// null if thread does not exist\n-function viewer_can_see_thread($thread) {\n- global $con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Create permissions.php and move all viewer_can_ functions there |
129,187 | 17.10.2017 20:55:28 | 14,400 | 36d9cd54d6412f3ba8e63ed04c351b1a53207c85 | We can use stock react-navigation now that Flow types are finally fixed up! | [
{
"change_type": "MODIFY",
"old_path": "native/package-lock.json",
"new_path": "native/package-lock.json",
"diff": "\"lockfileVersion\": 1,\n\"requires\": true,\n\"dependencies\": {\n+ \"1PasswordExtension\": {\n+ \"version\": \"git+https://github.com/jjshammas/onepassword-app-extension.git#acf20f71... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | We can use stock react-navigation now that Flow types are finally fixed up! |
129,187 | 18.10.2017 11:28:33 | 14,400 | 3e497360aac52aeb7d991390104fa31dc4ce1891 | Update TagInput to match OSS version more closely | [
{
"change_type": "MODIFY",
"old_path": "native/chat/add-thread.react.js",
"new_path": "native/chat/add-thread.react.js",
"diff": "@@ -63,6 +63,10 @@ import { registerChatScreen } from './chat-screen-registry';\nimport ColorPickerModal from './color-picker-modal.react';\nimport { assertNavigationRout... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update TagInput to match OSS version more closely |
129,187 | 30.10.2017 14:46:59 | 14,400 | 88ea6db905f0024da1b99fc5f35fbc8982141247 | Infer type of Action in reducer and reduceNavInfo
Gets rid of a Flow error | [
{
"change_type": "MODIFY",
"old_path": "native/navigation-setup.js",
"new_path": "native/navigation-setup.js",
"diff": "@@ -183,7 +183,7 @@ const defaultNavInfo: NavInfo = {\nnavigationState: defaultNavigationState,\n};\n-function reduceNavInfo(state: NavInfo, action: Action): NavInfo {\n+function r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Infer type of Action in reducer and reduceNavInfo
Gets rid of a Flow error |
129,187 | 30.10.2017 17:25:47 | 14,400 | 12f2d45d4a61a929063a639763111e471650d148 | Add a temporary "any" for the ref type of View in ColorPicker
Should be fixed in RN 0.50 | [
{
"change_type": "MODIFY",
"old_path": "native/components/color-picker.react.js",
"new_path": "native/components/color-picker.react.js",
"diff": "@@ -76,7 +76,8 @@ class ColorPicker extends React.PureComponent<Props, State> {\n_layout = { width: 0, height: 0 };\n_pageX = 0;\n_pageY = 0;\n- _pickerCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add a temporary "any" for the ref type of View in ColorPicker
Should be fixed in RN 0.50 |
129,187 | 31.10.2017 12:03:50 | 14,400 | c597b5defbb0e2fe5b8892c769ce08a42495980f | Only json_decode a permissions blob once | [
{
"change_type": "MODIFY",
"old_path": "server/permissions.php",
"new_path": "server/permissions.php",
"diff": "@@ -4,6 +4,8 @@ require_once('config.php');\nrequire_once('auth.php');\nrequire_once('thread_lib.php');\n+// Keep in sync with lib/types/thread-types.js\n+\n// If the user can see the thre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only json_decode a permissions blob once |
129,187 | 01.11.2017 11:14:07 | 14,400 | 90a31079d696fdee2d4d1fb10440fdc17ddf73be | Join thread on subscribe
If the user tries to subscribe to a thread that they aren't a member of, but they have permission to join, then add them to the thread first. | [
{
"change_type": "MODIFY",
"old_path": "server/new_thread.php",
"new_path": "server/new_thread.php",
"diff": "@@ -156,7 +156,9 @@ if ($initial_member_ids) {\n}\n$to_save_with_subscribed = array();\nforeach ($to_save as $row_to_save) {\n+ if ($row_to_save['thread_id'] === $id) {\n$row_to_save['subscr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Join thread on subscribe
If the user tries to subscribe to a thread that they aren't a member of, but they have permission to join, then add them to the thread first. |
129,187 | 01.11.2017 11:27:01 | 14,400 | 76764f90953de74da4067cc0dc581b0e14223689 | Two things I forgot from earlier commits
(1) Forgot to update the ThreadInfo accesses in index.php when changing the shape of ThreadInfo
(2) Forgot to update edit_thread.php to only set subscribed if it's the right thread ID | [
{
"change_type": "MODIFY",
"old_path": "server/edit_thread.php",
"new_path": "server/edit_thread.php",
"diff": "@@ -277,7 +277,9 @@ if ($add_member_ids) {\n));\n}\nforeach ($roletype_results['to_save'] as $row_to_save) {\n+ if ($row_to_save['thread_id'] === $thread) {\n$row_to_save['subscribed'] = t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Two things I forgot from earlier commits
(1) Forgot to update the ThreadInfo accesses in index.php when changing the shape of ThreadInfo
(2) Forgot to update edit_thread.php to only set subscribed if it's the right thread ID |
129,187 | 01.11.2017 13:20:05 | 14,400 | 64d8be5ed5bb58d9005fd16ee3b7420c81a65026 | Show description in thread settings and support editing it
Also updated react-navigation to master since there's an Android fix in there, and make the add-child-thread and add-members buttons look at the right permission checks. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/edit-setting-button.react.js",
"new_path": "native/chat/settings/edit-setting-button.react.js",
"diff": "@@ -5,7 +5,7 @@ import type {\n} from 'react-native/Libraries/StyleSheet/StyleSheetTypes';\nimport React from 'react';\n-import { Touc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Show description in thread settings and support editing it
Also updated react-navigation to master since there's an Android fix in there, and make the add-child-thread and add-members buttons look at the right permission checks. |
129,187 | 03.11.2017 12:23:04 | 14,400 | 96068e60ec004e8a4f2a2294822e61d70268d597 | Couple bugfixes for ThreadInfo permissions update in last commit
1. `source` can (and will) be `null` if `value` is `false`
2. Server should make sure `source` is cast to a string | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -84,18 +84,24 @@ export function assertThreadPermissions(\nreturn ourThreadPermissions;\n}\n+type ThreadPermissionInfo =\n+ | {| value: true, source: string |}\n+ | {| value: fals... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Couple bugfixes for ThreadInfo permissions update in last commit
1. `source` can (and will) be `null` if `value` is `false`
2. Server should make sure `source` is cast to a string |
129,187 | 03.11.2017 17:08:23 | 14,400 | 47530e9191a3f6b9a3e384fe47153eac61b60f8d | Update to latest react-navigation | [
{
"change_type": "MODIFY",
"old_path": "native/package-lock.json",
"new_path": "native/package-lock.json",
"diff": "}\n},\n\"react-navigation\": {\n- \"version\": \"git://github.com/react-community/react-navigation.git#ed2fc9a09e2f562ae9d3fc7f5df17c593989db0a\",\n+ \"version\": \"1.0.0-beta.18\",\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update to latest react-navigation |
129,187 | 03.11.2017 17:15:30 | 14,400 | a77f9892028127ad7729ec92dbd12c38a81f5f3b | Minor bugfix for last commit | [
{
"change_type": "MODIFY",
"old_path": "server/thread_lib.php",
"new_path": "server/thread_lib.php",
"diff": "@@ -82,7 +82,7 @@ SQL;\nif ((int)$user_id === $viewer_id) {\n$thread_infos[$thread_id]['currentUser'] = array(\n\"permissions\" => $member['permissions'],\n- \"role\" => $member['roletype'],... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Minor bugfix for last commit |
129,187 | 06.11.2017 23:14:21 | 18,000 | abb3f53518fe2036d15cbe37d828f4746e705884 | Working simple popover tooltip derived from open source component | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -4,12 +4,14 @@ import type { ThreadInfo } from 'lib/types/thread-types';\nimport { threadPermissions } from 'lib/types/thread-typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Working simple popover tooltip derived from open source component |
129,187 | 07.11.2017 12:02:56 | 18,000 | 578141fffe664d791b86aac979da28cf9ddbb2b0 | Fix three server bugs
1. subscribe.php wasn't getting the new roletype, so it was returning a `CurrentUserInfo` that didn't indicate membership
2. `get_thread_infos` was checking an array key's existence without using `isset`
3. `get_thread_infos` was filtering out any anonymous users from the member list | [
{
"change_type": "MODIFY",
"old_path": "server/permissions.php",
"new_path": "server/permissions.php",
"diff": "@@ -129,6 +129,9 @@ function get_info_from_permissions_row($row) {\n\"permissions\" => $blob,\n\"visibility_rules\" => (int)$row['visibility_rules'],\n\"edit_rules\" => (int)$row['edit_rul... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix three server bugs
1. subscribe.php wasn't getting the new roletype, so it was returning a `CurrentUserInfo` that didn't indicate membership
2. `get_thread_infos` was checking an array key's existence without using `isset`
3. `get_thread_infos` was filtering out any anonymous users from the member list |
129,187 | 07.11.2017 12:15:37 | 18,000 | b0f42221bffe48d252b205ea699a1cf1089eb0c2 | Create RelativeMemberInfo and pipe it through to ThreadSettingsUser
Also include anonymous users in `userIDsToRelativeUserInfos`, and add PropTypes to `ThreadSettingsUser`. | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/user-selectors.js",
"new_path": "lib/selectors/user-selectors.js",
"diff": "import type { BaseAppState } from '../types/redux-types';\nimport type { UserInfo, RelativeUserInfo } from '../types/user-types';\n-import type { MemberInfo } from '../ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Create RelativeMemberInfo and pipe it through to ThreadSettingsUser
Also include anonymous users in `userIDsToRelativeUserInfos`, and add PropTypes to `ThreadSettingsUser`. |
129,187 | 07.11.2017 12:17:26 | 18,000 | 9631023545b7afa3d13535292b4b0cdff58431da | Show anonymous users correctly in ThreadSettingsUser
Also moved `stringForUser` to new file message-utils.js | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -30,16 +30,6 @@ function messageID(messageInfo: MessageInfo | RawMessageInfo): string {\nreturn messageInfo.localID;\n}\n-function stringForUser(user: RelativeUserInfo): strin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Show anonymous users correctly in ThreadSettingsUser
Also moved `stringForUser` to new file message-utils.js |
129,187 | 07.11.2017 12:45:05 | 18,000 | 00a63134ec0cc1f3a46f824f986a0a85236f51dc | Fix three bugs in new_thead.php
1. Extraneous comma at end of function args causing syntax error
2. Order of users inconsistent with `get_thread_infos` result
3. Incorrect definition of `$current_user_info['role']` led to it always being `null` | [
{
"change_type": "MODIFY",
"old_path": "server/new_thread.php",
"new_path": "server/new_thread.php",
"diff": "@@ -136,7 +136,7 @@ if ($new_message_infos === null) {\n$creator_results = change_roletype(\n$id,\narray($creator),\n- (int)$roletypes['admins']['id'],\n+ (int)$roletypes['admins']['id']\n);... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix three bugs in new_thead.php
1. Extraneous comma at end of function args causing syntax error
2. Order of users inconsistent with `get_thread_infos` result
3. Incorrect definition of `$current_user_info['role']` led to it always being `null` |
129,187 | 07.11.2017 12:46:19 | 18,000 | c93e220edde960c8a85240c3ab6d8f50c9b332fd | Use keyed object for roles in ThreadInfo instead of array | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -151,7 +151,7 @@ export type ThreadInfo = {|\ncreationTime: number, // millisecond timestamp\nparentThreadID: ?string,\nmembers: MemberInfo[],\n- roles: RoleInfo[],\n+ roles: {[id... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use keyed object for roles in ThreadInfo instead of array |
129,187 | 07.11.2017 12:52:48 | 18,000 | 1f68022accc02d5f5bd63a47b1d07c7e9edd226e | Show which users are admins in ThreadSettings | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -72,11 +72,25 @@ class ThreadSettingsUser extends React.PureComponent<Props> {\n);\n}\n+ let roleInfo = null;\n+ const role = thi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Show which users are admins in ThreadSettings |
129,187 | 07.11.2017 13:07:27 | 18,000 | 8e877deee30f29c4f4859d8a43c32ee36d6f1aa8 | Generate popoverConfig for ThreadSettingsUser based on props | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -11,6 +11,7 @@ import React from 'react';\nimport { View, Text, StyleSheet, Platform } from 'react-native';\nimport Icon from 're... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Generate popoverConfig for ThreadSettingsUser based on props |
129,187 | 07.11.2017 14:31:42 | 18,000 | 9e828a0bb72f200d961080a0a9ca2f99ea0bc964 | Include isDefault in RoleInfo | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -133,6 +133,7 @@ export type RoleInfo = {|\n// This is not a ThreadPermissionsBlob. It can include keys with prefixes, and\n// no sources are listed, as this blob is itself a self... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include isDefault in RoleInfo |
129,187 | 07.11.2017 15:51:01 | 18,000 | 35423222513b5368d3a034af3598ab76bfd5417b | Add REMOVE_MEMBERS and CHANGE_ROLE permissions | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -52,7 +52,9 @@ export type ThreadPermission =\n| \"create_subthreads\"\n| \"join_thread\"\n| \"edit_permissions\"\n- | \"add_members\";\n+ | \"add_members\"\n+ | \"remove_members\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add REMOVE_MEMBERS and CHANGE_ROLE permissions |
129,187 | 07.11.2017 15:57:23 | 18,000 | 8211e868a90e0cd517eb1aa443b812cfc5065728 | List parent admins in ThreadSettings | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -129,6 +129,22 @@ class ThreadSettingsUser extends React.PureComponent<Props, State> {\n<Text style={styles.role}>admin</Text>\n<... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | List parent admins in ThreadSettings |
129,187 | 08.11.2017 14:10:42 | 18,000 | 198ac14498ddb4104275bf2af8066701bfaf9aec | edit_roletype_permissions and script to add new permission types | [
{
"change_type": "MODIFY",
"old_path": "server/permissions.php",
"new_path": "server/permissions.php",
"diff": "@@ -525,7 +525,10 @@ SQL;\n// to_save => array<array(\n// user_id: int,\n// thread_id: int,\n-// permissions: array<permission: string, array(value => bool, source => int)>\n+// permission... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | edit_roletype_permissions and script to add new permission types |
129,187 | 08.11.2017 14:27:27 | 18,000 | 020bdd0d8d870a2a19c949c270036bd6679a27fb | Two bugfixes for ThreadSettingsUser
1. Parent admin check was checking current user's permissions instead of listed user
2. It should be impossible to make an anonymous user the admin of a thread | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -72,7 +72,7 @@ class ThreadSettingsUser extends React.PureComponent<Props, State> {\nresult.push({ label: \"Remove user\", onPres... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Two bugfixes for ThreadSettingsUser
1. Parent admin check was checking current user's permissions instead of listed user
2. It should be impossible to make an anonymous user the admin of a thread |
129,187 | 09.11.2017 14:53:26 | 18,000 | c3977e03c14b757c8091377c46638aa4bd56e379 | Hook up native code for changing users' roles | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -18,6 +18,7 @@ import Icon from 'react-native-vector-icons/FontAwesome';\nimport PropTypes from 'prop-types';\nimport _isEqual fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Hook up native code for changing users' roles |
129,187 | 09.11.2017 15:05:09 | 18,000 | b0acf02b613776dff98cb11dd4553353bb9d1d8d | Show loading spinner when removing users and changing their role | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -13,7 +13,14 @@ import type { DispatchActionPromise } from 'lib/utils/action-utils';\nimport type { ChangeThreadSettingsResult } ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Show loading spinner when removing users and changing their role |
129,187 | 10.11.2017 10:49:40 | 18,000 | 1fbdeb85443c521c74c0e34081b142d7f1d70d58 | Handle messages with null content correctly on backend side | [
{
"change_type": "MODIFY",
"old_path": "server/change_role.php",
"new_path": "server/change_role.php",
"diff": "@@ -71,11 +71,6 @@ $message_info = array(\n'newRole' => (string)$role,\n);\n$new_message_infos = create_message_infos(array($message_info));\n-if ($new_message_infos === null) {\n- async_e... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Handle messages with null content correctly on backend side |
129,187 | 10.11.2017 14:24:39 | 18,000 | c224d4b1c349e0542218ac5a542ee1352c6353fa | Three random bugfixes in regards to ThreadSettingsUser
1. Wait 500ms instead of 400ms to avoid React Native `Modal`/`Alert` iOS issue
2. Use a consistent order for member list (order by user ID, ascending)
3. Don't return users in the member list that aren't actually members and aren't parent admins | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -205,7 +205,7 @@ class ThreadSettingsUser extends React.PureComponent<Props, State> {\nonPressRemoveUser = () => {\nif (Platform.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Three random bugfixes in regards to ThreadSettingsUser
1. Wait 500ms instead of 400ms to avoid React Native `Modal`/`Alert` iOS issue
2. Use a consistent order for member list (order by user ID, ascending)
3. Don't return users in the member list that aren't actually members and aren't parent admins |
129,187 | 11.11.2017 13:27:21 | 18,000 | cd3527e7f3d4671fdcf483ddd83f8d1830dbd8f3 | Make sure server endpoints prevent a thread from becoming admin-less | [
{
"change_type": "MODIFY",
"old_path": "server/leave_thread.php",
"new_path": "server/leave_thread.php",
"diff": "@@ -21,7 +21,27 @@ if (!viewer_is_member($thread)) {\n));\n}\n-$leave_results = change_roletype($thread, array(get_viewer_id()), 0);\n+$viewer_id = get_viewer_id();\n+$other_users_exist ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure server endpoints prevent a thread from becoming admin-less |
129,187 | 11.11.2017 23:32:09 | 18,000 | 00f0d32559dcc00c46aba816f74e2f3a81070841 | Lift member LoadingStatuses so we can consider them in ThreadSettings.canReset | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -39,7 +39,6 @@ import {\nchangeThreadMemberRolesActionTypes,\nchangeThreadMemberRoles,\n} from 'lib/actions/thread-actions';\n-im... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Lift member LoadingStatuses so we can consider them in ThreadSettings.canReset |
129,187 | 12.11.2017 00:04:00 | 18,000 | d39b529a721d9986cbd25d9e3bb1838a340c6d9f | Use upstream react-native-popover-tooltip now since my PR has been merged | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-user.react.js",
"new_path": "native/chat/settings/thread-settings-user.react.js",
"diff": "@@ -26,6 +26,7 @@ import PropTypes from 'prop-types';\nimport _isEqual from 'lodash/fp/isEqual';\nimport { connect } from 'react-red... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use upstream react-native-popover-tooltip now since my PR has been merged |
129,187 | 13.11.2017 11:07:02 | 18,000 | 6e701611ff1b5744c7b2e8e21158d38d0d823c98 | Use `messageType` constant instead of literals in message-types.js | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -8,7 +8,6 @@ import { relativeUserInfoPropType } from './user-types';\nimport invariant from 'invariant';\nimport PropTypes from 'prop-types';\n-export type MessageType = 0 | 1 ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use `messageType` constant instead of literals in message-types.js |
129,187 | 13.11.2017 11:19:57 | 18,000 | efabf8d83d5ef8219573b54a54dffd7b25185a6c | Use constants instead of literals in thread-types.js | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "import PropTypes from 'prop-types';\nimport invariant from 'invariant';\n-export type VisibilityRules = 0 | 1 | 2 | 3 | 4;\nexport const visibilityRules = {\nOPEN: 0,\nCLOSED: 1,\n@@... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use constants instead of literals in thread-types.js |
129,187 | 14.11.2017 09:34:18 | 18,000 | 7a1ee9609977fae076282a60a71e5c5c660d65c0 | get_message_infos should return all threads the viewer is a member of when $input is null | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -40,7 +40,7 @@ define(\"TRUNCATION_EXHAUSTIVE\", \"exhaustive\");\n// should be newer than the specified message. in other words, we use the\n// message ID as the \"cursor\" for paging.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | get_message_infos should return all threads the viewer is a member of when $input is null |
129,187 | 14.11.2017 09:46:12 | 18,000 | bec4171496f8e580edbc7d5173af8f6168ee70c2 | Update threads that get_messages_since fetches messages from
By default it will now be threads that the viewer is a member of. There is also a `$watch_ids` parameter that can add additional threads to follow. | [
{
"change_type": "MODIFY",
"old_path": "server/message_lib.php",
"new_path": "server/message_lib.php",
"diff": "@@ -137,14 +137,34 @@ SQL;\n// this one is used to keep a session updated. You give it a timestamp, and it\n// fetches all of the messages with a newer timestamp. If for a given thread\n//... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update threads that get_messages_since fetches messages from
By default it will now be threads that the viewer is a member of. There is also a `$watch_ids` parameter that can add additional threads to follow. |
129,187 | 14.11.2017 10:03:01 | 18,000 | adcbe8bf4af158c6e741a4d2ffb70e845d4523e0 | Update ping.php to handle `watch_ids` request param | [
{
"change_type": "MODIFY",
"old_path": "server/ping.php",
"new_path": "server/ping.php",
"diff": "@@ -26,19 +26,29 @@ if (\n));\n}\n+list($thread_infos, $thread_users) = get_thread_infos();\n+$watch_ids = isset($_POST['watch_ids']) ? $_POST['watch_ids'] : null;\n+\n$time = round(microtime(true) * 10... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update ping.php to handle `watch_ids` request param |
129,187 | 14.11.2017 11:54:04 | 18,000 | e309cc252e474c128cb437bf017ffb99f32a7930 | Have MessageList and ThreadSettings keep threadWatcher updated | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-watcher.js",
"new_path": "lib/shared/thread-watcher.js",
"diff": "@@ -7,10 +7,6 @@ class ThreadWatcher {\nwatchedIDs: Map<string, number> = new Map();\npendingRemovals: Map<string, number> = new Map();\n- initialize(watchedIDs: Map<string, nu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Have MessageList and ThreadSettings keep threadWatcher updated |
129,187 | 14.11.2017 21:49:54 | 18,000 | c2c729001acef75bd5a3b4dd27ab35806910a6ab | Introduce `$thread_selection_criteria` as a standard interface to message functions on backend | [
{
"change_type": "MODIFY",
"old_path": "server/fetch_messages.php",
"new_path": "server/fetch_messages.php",
"diff": "@@ -10,8 +10,17 @@ $number_per_thread = isset($_POST['number_per_thread'])\n? (int)$_POST['number_per_thread']\n: DEFAULT_NUMBER_PER_THREAD;\n-list($message_infos, $truncation_status... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce `$thread_selection_criteria` as a standard interface to message functions on backend |
129,187 | 15.11.2017 18:10:20 | 18,000 | 843ca054552b6a67c5fc714a64070f2e255b7dbd | Extract removeScreensFromStack from removeModals for use in other places | [
{
"change_type": "MODIFY",
"old_path": "native/navigation-setup.js",
"new_path": "native/navigation-setup.js",
"diff": "@@ -8,6 +8,7 @@ import type {\nNavigationScreenProp,\nNavigationAction,\nNavigationRouter,\n+ NavigationRoute,\n} from 'react-navigation/src/TypeDefinition';\nimport type { PingSuc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extract removeScreensFromStack from removeModals for use in other places |
129,187 | 15.11.2017 19:26:22 | 18,000 | 7ead88a620be8cf8aff66255a4faa4de9f794484 | Fix bug where height for robotext messages was undefined
This was causing a lot of weirdness, took a bit of time to track down... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -414,8 +414,6 @@ class InnerMessageList extends React.PureComponent<Props, State> {\nconst listDataWithHeights = this.state.listDataWithHeights;\nlet flatList = nu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix bug where height for robotext messages was undefined
This was causing a lot of weirdness, took a bit of time to track down... |
129,187 | 15.11.2017 19:39:19 | 18,000 | 0947678fe5a1caa7d689f07137888273b5d5f34a | Call filterChatScreensForThreadInfos whenever threadInfos might get smaller
The only except is `deleteThreadActionTypes`, which isn't actually used in native yet. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -33,13 +33,7 @@ export default function reduceThreadInfos(\n): {[id: string]: ThreadInfo} {\nif (\naction.type === logOutActionTypes.success ||\n- action.type === delete... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Call filterChatScreensForThreadInfos whenever threadInfos might get smaller
The only except is `deleteThreadActionTypes`, which isn't actually used in native yet. |
129,187 | 15.11.2017 19:54:13 | 18,000 | f3c0db1b43b42a2eb33520f21f4ad389b7511710 | Make sure to set MessageList's loadingFromScroll to false after new results are rendered
Apparently I missed a lot of bugs when I originally built chat... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -368,6 +368,19 @@ class InnerMessageList extends React.PureComponent<Props, State> {\n}\n}\n+ componentDidUpdate(prevProps: Props, prevState: State) {\n+ if (!this... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make sure to set MessageList's loadingFromScroll to false after new results are rendered
Apparently I missed a lot of bugs when I originally built chat... |
129,187 | 15.11.2017 20:44:07 | 18,000 | d9fdcfca63424439974dbb957b523fa3cd02c7ea | Delay autofocus for new entries
For some weird af reason, `TextInput` is blurring immediately after an autofocus. I can't figure out why. This "fixes" the problem. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -276,7 +276,6 @@ class Entry extends React.Component<Props, State> {\nonBlur={this.onBlur}\nonFocus={this.onFocus}\nonContentSizeChange={this.onContentSizeChange}\n- aut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Delay autofocus for new entries
For some weird af reason, `TextInput` is blurring immediately after an autofocus. I can't figure out why. This "fixes" the problem. |
129,187 | 16.11.2017 11:36:06 | 28,800 | 6c76d3918287e54be57aa2c494e1aae4a7bd5f7b | Set MessageList.loadingFromScroll to false when startReached = true | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -369,13 +369,14 @@ class InnerMessageList extends React.PureComponent<Props, State> {\n}\ncomponentDidUpdate(prevProps: Props, prevState: State) {\n- if (!this.sta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Set MessageList.loadingFromScroll to false when startReached = true |
129,187 | 16.11.2017 15:47:38 | 28,800 | 44f2d46700714dc190c4f6d5f10885184fe2b2f6 | Only pop the settings panel when leaving a thread you can still see | [
{
"change_type": "MODIFY",
"old_path": "native/navigation-setup.js",
"new_path": "native/navigation-setup.js",
"diff": "@@ -13,6 +13,7 @@ import type {\nimport type { PingSuccessPayload } from 'lib/types/ping-types';\nimport type { AppState } from './redux-setup';\nimport type { SetCookiePayload } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only pop the settings panel when leaving a thread you can still see |
129,187 | 16.11.2017 15:49:55 | 28,800 | 32769bea291b08a7ccf8ef47e6f74ffdbaa35942 | Prepare for an attempt to remove descendant_voiced from admins | [
{
"change_type": "MODIFY",
"old_path": "server/scripts/add_permission_types.php",
"new_path": "server/scripts/add_permission_types.php",
"diff": "@@ -37,10 +37,7 @@ while ($row = $results->fetch_assoc()) {\necho \"Total thread count: \" . count($parents_to_children) . \"\\n\";\n$new_permissions = ar... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Prepare for an attempt to remove descendant_voiced from admins |
129,187 | 20.11.2017 17:41:18 | 28,800 | 9ffee26a1e9af4c563516b2e38a2807417e1e0d6 | Avoid PHP warning when watched_ids is null | [
{
"change_type": "MODIFY",
"old_path": "server/login.php",
"new_path": "server/login.php",
"diff": "@@ -46,7 +46,9 @@ $id = intval($user_row['id']);\ncreate_user_cookie($id);\n$current_as_of = round(microtime(true) * 1000); // in milliseconds\n-$watched_ids = isset($_POST['watched_ids']) ? $_POST['w... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Avoid PHP warning when watched_ids is null |
129,187 | 22.11.2017 00:27:41 | 28,800 | 573abc91511997acf9e1130e5998b55d82dc614c | Silence react-navigation Redux integration Flow error with NavigationScreenProp<any> | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "import type {\nNavigationState,\nPossiblyDeprecatedNavigationAction,\n+ NavigationScreenProp,\n} from 'react-navigation/src/TypeDefinition';\nimport type { Dispatch } from 'lib/types/redux-types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Silence react-navigation Redux integration Flow error with NavigationScreenProp<any> |
129,187 | 22.11.2017 00:28:12 | 28,800 | 6a2e207897461a63c5556adb97cb825c9dce6332 | Update to latest redux-persist 4 to get rid of Flow error
Tried redux-persist 5 but it has all these weird Flow errors... | [
{
"change_type": "MODIFY",
"old_path": "native/package-lock.json",
"new_path": "native/package-lock.json",
"diff": "\"integrity\": \"sha1-4Pmo6N/KfBe+kscSSVijuU6ykR0=\"\n},\n\"redux-persist\": {\n- \"version\": \"4.9.1\",\n- \"resolved\": \"https://registry.npmjs.org/redux-persist/-/redux-persist-4.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update to latest redux-persist 4 to get rid of Flow error
Tried redux-persist 5 but it has all these weird Flow errors... |
129,187 | 22.11.2017 23:11:06 | -32,400 | 71d253291a418c6be01f40aff7e20e7c9747e162 | Update to latest react-navigation fixflow branch | [
{
"change_type": "MODIFY",
"old_path": "native/package-lock.json",
"new_path": "native/package-lock.json",
"diff": "}\n},\n\"react-navigation\": {\n- \"version\": \"1.0.0-beta.20\",\n- \"resolved\": \"https://registry.npmjs.org/react-navigation/-/react-navigation-1.0.0-beta.20.tgz\",\n- \"integrity\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update to latest react-navigation fixflow branch |
129,187 | 23.11.2017 16:59:42 | -32,400 | f79aa941b14c54c8a8fb58807de2ff22e1fc5686 | Forgot to convert a couple "r"s to "m"s in thread_lib.php | [
{
"change_type": "MODIFY",
"old_path": "server/thread_lib.php",
"new_path": "server/thread_lib.php",
"diff": "@@ -35,9 +35,9 @@ LEFT JOIN (\nFROM threads\n) r ON r.thread = t.id\nLEFT JOIN memberships m ON m.role = r.id AND m.thread = t.id\n-LEFT JOIN users u ON u.id = r.user\n+LEFT JOIN users u ON ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Forgot to convert a couple "r"s to "m"s in thread_lib.php |
129,187 | 23.11.2017 17:05:38 | -32,400 | e98412e88d475b85967157634b1f4ea86216e383 | By default return entries from joined threads instead of subscribed threads | [
{
"change_type": "MODIFY",
"old_path": "server/entry_lib.php",
"new_path": "server/entry_lib.php",
"diff": "@@ -52,7 +52,7 @@ function get_entry_infos($input) {\n$home = false;\n$thread = intval($input['nav']);\n}\n- $additional_condition = $home ? \"m.subscribed = 1\" : \"d.thread = $thread\";\n+ $... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | By default return entries from joined threads instead of subscribed threads |
129,187 | 30.11.2017 13:58:34 | -32,400 | 512541af522ef5edd4a6e37dd22ffd6d95f125c6 | get_message_infos and get_messages_since now return associative array | [
{
"change_type": "MODIFY",
"old_path": "native/package-lock.json",
"new_path": "native/package-lock.json",
"diff": "}\n},\n\"react-navigation\": {\n- \"version\": \"git://github.com/react-community/react-navigation.git#24631e300eb0c41f37f91d7d28003e7674cb5b48\",\n+ \"version\": \"git://github.com/re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | get_message_infos and get_messages_since now return associative array |
129,187 | 30.11.2017 16:26:43 | -32,400 | 638325ecc0bdf742bd2c28b478161afb9bbba6d8 | getThreadIDFromParams
Also increases use of `assertNavigationRouteNotLeafNode` in a couple places | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -61,7 +61,10 @@ import { registerFetchKey } from 'lib/reducers/loading-reducer';\nimport Button from '../components/button.react';\nimport { ChatRouteName } from '../cha... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | getThreadIDFromParams
Also increases use of `assertNavigationRouteNotLeafNode` in a couple places |
129,187 | 02.12.2017 17:45:21 | -28,800 | d6f9a421d53ef8c3daa0c23200bbb2190db89807 | Include cookie ID in get_viewer_info | [
{
"change_type": "MODIFY",
"old_path": "server/async_lib.php",
"new_path": "server/async_lib.php",
"diff": "@@ -42,7 +42,7 @@ function async_end($payload) {\n$viewer_info = get_viewer_info();\n// Only include in the raw response since on web we want it to be httponly\nif (isset($_POST['cookie'])) {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include cookie ID in get_viewer_info |
129,187 | 02.12.2017 18:44:22 | -28,800 | 3e00b18cfcfeec6e906a4b31117eb8af0b6af65c | Don't filter out cookie param in bindServerCalls | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/action-utils.js",
"new_path": "lib/utils/action-utils.js",
"diff": "@@ -378,14 +378,14 @@ function bindServerCalls(\n) => {\nconst dispatch = dispatchProps.dispatch;\ninvariant(dispatch, \"should be defined\");\n- const { cookie, ...restStateProps } ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't filter out cookie param in bindServerCalls |
129,187 | 02.12.2017 18:45:59 | -28,800 | c2a71a9280d7fef9860c7e5a8b67ec1dde310d68 | Only call appLoggedIn if appLoggedIn | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -43,12 +43,19 @@ import {\nupdateFocusedThreads,\n} from 'lib/actions/thread-actions';\n-import { handleURLActionType, RootNavigator } from './navigation-setup';\n+import {\n+ handleURLAction... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only call appLoggedIn if appLoggedIn |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.