url stringlengths 58 61 | number int64 1 8.23k | title stringlengths 1 290 | body stringlengths 0 228k ⌀ | state stringclasses 2
values | created_at timestamp[s]date 2020-04-14 10:18:02 2026-05-30 09:38:59 | comments_url stringlengths 67 70 | pull_request dict | is_pull_request bool 2
classes | text stringlengths 2 228k | comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/datasets/issues/6755 | 6,755 | Small typo on the documentation | ### Describe the bug
There is a small typo on https://github.com/huggingface/datasets/blob/d5468836fe94e8be1ae093397dd43d4a2503b926/src/datasets/dataset_dict.py#L938
It should be `caching is enabled`.
### Steps to reproduce the bug
Please visit
https://github.com/huggingface/datasets/blob/d5468836fe94e... | closed | 2024-03-24T21:47:52 | https://api.github.com/repos/huggingface/datasets/issues/6755/comments | null | false | Small typo on the documentation
### Describe the bug
There is a small typo on https://github.com/huggingface/datasets/blob/d5468836fe94e8be1ae093397dd43d4a2503b926/src/datasets/dataset_dict.py#L938
It should be `caching is enabled`.
### Steps to reproduce the bug
Please visit
https://github.com/hugging... | [
"Thanks for reporting @fostiropoulos! I've edited your comment to fix the link to the problematic line.\r\n",
"@mariosasko can i take this up?",
"#self-assign"
] |
https://api.github.com/repos/huggingface/datasets/issues/6754 | 6,754 | Fix cache path to snakecase for `CachedDatasetModuleFactory` and `Cache` | Fix https://github.com/huggingface/datasets/issues/6750#issuecomment-2016678729
I didn't find a guideline on how to run the tests, so i just run the following steps to make sure that this bug is fixed.
1. `python test.py`,
2. then `HF_DATASETS_OFFLINE=1 python test.py`
The `test.py` is
```
import datasets
... | closed | 2024-03-24T06:59:15 | https://api.github.com/repos/huggingface/datasets/issues/6754/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6754",
"html_url": "https://github.com/huggingface/datasets/pull/6754",
"diff_url": "https://github.com/huggingface/datasets/pull/6754.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6754.patch",
"merged_at": "2024-04-15T15:38... | true | Fix cache path to snakecase for `CachedDatasetModuleFactory` and `Cache`
Fix https://github.com/huggingface/datasets/issues/6750#issuecomment-2016678729
I didn't find a guideline on how to run the tests, so i just run the following steps to make sure that this bug is fixed.
1. `python test.py`,
2. then `HF_DATASET... | [
"@lhoestq hi 😃, is there something else I need to do to check this change?",
"I added two tests and passed them on my server.\r\n\r\n```\r\npytest tests/packaged_modules/test_cache.py \r\n========================================================================== test session starts ==============================... |
https://api.github.com/repos/huggingface/datasets/issues/6753 | 6,753 | Type error when importing datasets on Kaggle | ### Describe the bug
When trying to run
```
import datasets
print(datasets.__version__)
```
It generates the following error
```
TypeError: expected string or bytes-like object
```
It looks like It cannot find the valid versions of `fsspec`
though fsspec version is fine when I checked Via command
... | closed | 2024-03-24T03:01:30 | https://api.github.com/repos/huggingface/datasets/issues/6753/comments | null | false | Type error when importing datasets on Kaggle
### Describe the bug
When trying to run
```
import datasets
print(datasets.__version__)
```
It generates the following error
```
TypeError: expected string or bytes-like object
```
It looks like It cannot find the valid versions of `fsspec`
though fsspec... | [
"I have the same problem \r\nIt seems that it only appears when you are using GPU \r\nIt seems to work fine with the 2.17 version though",
"Same here.",
"> I have the same problem\r\n> It seems that it only appears when you are using GPU\r\n> It seems to work fine with the 2.17 version though\r\n\r\nI downgrade... |
https://api.github.com/repos/huggingface/datasets/issues/6752 | 6,752 | Precision being changed from float16 to float32 unexpectedly | ### Describe the bug
I'm loading a HuggingFace Dataset for images.
I'm running a preprocessing (map operation) step that runs a few operations, one of them being conversion to float16. The Dataset features also say that the 'img' is of type float16. Whenever I take an image from that HuggingFace Dataset instance... | open | 2024-03-23T20:53:56 | https://api.github.com/repos/huggingface/datasets/issues/6752/comments | null | false | Precision being changed from float16 to float32 unexpectedly
### Describe the bug
I'm loading a HuggingFace Dataset for images.
I'm running a preprocessing (map operation) step that runs a few operations, one of them being conversion to float16. The Dataset features also say that the 'img' is of type float16. Wh... | [
"This is because of the formatter (`torch` in this case).\r\nIt defaults to `float32`.\r\n\r\nYou can load it in `float16` using `dataset.set_format(\"torch\", dtype=torch.float16)`.",
"I am having a similar issue when _building_ a dataset given `float16`-valued data.\n\n```py\nfrom datasets import Features, Valu... |
https://api.github.com/repos/huggingface/datasets/issues/6751 | 6,751 | Use 'with' operator for some download functions | Some functions in `streaming_download_manager.py` are not closing the file they open which lead to `Unclosed file` warnings in our code. This fixes a few of them. | closed | 2024-03-23T16:32:08 | https://api.github.com/repos/huggingface/datasets/issues/6751/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6751",
"html_url": "https://github.com/huggingface/datasets/pull/6751",
"diff_url": "https://github.com/huggingface/datasets/pull/6751.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6751.patch",
"merged_at": null
} | true | Use 'with' operator for some download functions
Some functions in `streaming_download_manager.py` are not closing the file they open which lead to `Unclosed file` warnings in our code. This fixes a few of them. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6751). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"I was mistaken on the intent of those functions, closing the PR."
] |
https://api.github.com/repos/huggingface/datasets/issues/6750 | 6,750 | `load_dataset` requires a network connection for local download? | ### Describe the bug
Hi all - I see that in the past a network dependency has been mistakenly introduced into `load_dataset` even for local loads. Is it possible this has happened again?
### Steps to reproduce the bug
```
>>> import datasets
>>> datasets.load_dataset("hh-rlhf")
Repo card metadata block was not ... | closed | 2024-03-23T01:06:32 | https://api.github.com/repos/huggingface/datasets/issues/6750/comments | null | false | `load_dataset` requires a network connection for local download?
### Describe the bug
Hi all - I see that in the past a network dependency has been mistakenly introduced into `load_dataset` even for local loads. Is it possible this has happened again?
### Steps to reproduce the bug
```
>>> import datasets
>>> da... | [
"Are you using `HF_DATASETS_OFFLINE=1` ?",
"> Are you using `HF_DATASETS_OFFLINE=1` ?\r\n\r\nThis doesn't work for me. `datasets=2.18.0`\r\n\r\n`test.py`:\r\n```\r\nimport datasets\r\n\r\ndatasets.utils.logging.set_verbosity_info()\r\n\r\nds = datasets.load_dataset('C-MTEB/AFQMC', revision='b44c3b011063adb25877c1... |
https://api.github.com/repos/huggingface/datasets/issues/6749 | 6,749 | Fix fsspec tqdm callback | Following changes at https://github.com/fsspec/filesystem_spec/pull/1497 for `fsspec>=2024.2.0` | closed | 2024-03-22T11:44:11 | https://api.github.com/repos/huggingface/datasets/issues/6749/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6749",
"html_url": "https://github.com/huggingface/datasets/pull/6749",
"diff_url": "https://github.com/huggingface/datasets/pull/6749.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6749.patch",
"merged_at": "2024-03-22T14:45... | true | Fix fsspec tqdm callback
Following changes at https://github.com/fsspec/filesystem_spec/pull/1497 for `fsspec>=2024.2.0` | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6749). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6748 | 6,748 | Strange slicing behavior | ### Describe the bug
I have loaded a dataset, and then slice first 300 samples using `:` ops, however, the resulting dataset is not expected, as the output below:
```bash
len(dataset)=1050324
len(dataset[:300])=2
len(dataset[0:300])=2
len(dataset.select(range(300)))=300
```
### Steps to reproduce the bug
loa... | open | 2024-03-22T01:49:13 | https://api.github.com/repos/huggingface/datasets/issues/6748/comments | null | false | Strange slicing behavior
### Describe the bug
I have loaded a dataset, and then slice first 300 samples using `:` ops, however, the resulting dataset is not expected, as the output below:
```bash
len(dataset)=1050324
len(dataset[:300])=2
len(dataset[0:300])=2
len(dataset.select(range(300)))=300
```
### Steps ... | [
"As explained in the [docs](https://huggingface.co/docs/datasets/v2.18.0/en/access#slicing), slicing a `Dataset` returns a dictionary that maps its column names to their values. So, `len(dataset[:300])=2` is expected, assuming your dataset has 2 columns (the returned dict has 2 keys, but each value in the dict has ... |
https://api.github.com/repos/huggingface/datasets/issues/6747 | 6,747 | chore(deps): bump fsspec | There were a few fixes released recently, some DVC ecosystem packages require newer version of `fsspec`. | closed | 2024-03-21T21:25:49 | https://api.github.com/repos/huggingface/datasets/issues/6747/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6747",
"html_url": "https://github.com/huggingface/datasets/pull/6747",
"diff_url": "https://github.com/huggingface/datasets/pull/6747.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6747.patch",
"merged_at": "2024-03-22T16:28... | true | chore(deps): bump fsspec
There were a few fixes released recently, some DVC ecosystem packages require newer version of `fsspec`. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6747). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6746 | 6,746 | ExpectedMoreSplits error when loading C4 dataset | ### Describe the bug
I encounter bug when running the example command line
```python
python main.py \
--model decapoda-research/llama-7b-hf \
--prune_method wanda \
--sparsity_ratio 0.5 \
--sparsity_type unstructured \
--save out/llama_7b/unstructured/wanda/
```
The bug occurred ... | closed | 2024-03-21T02:53:04 | https://api.github.com/repos/huggingface/datasets/issues/6746/comments | null | false | ExpectedMoreSplits error when loading C4 dataset
### Describe the bug
I encounter bug when running the example command line
```python
python main.py \
--model decapoda-research/llama-7b-hf \
--prune_method wanda \
--sparsity_ratio 0.5 \
--sparsity_type unstructured \
--save out/llama_... | [
"Hi ! We updated the `allenai/c4` repository to allow people to specify which language to load easily (the the [c4 dataset page](https://huggingface.co/datasets/allenai/c4))\r\n\r\nTo fix this issue **you can update** `datasets` and remove the mention of the legacy configuration name \"allenai--c4\":\r\n\r\n```pyth... |
https://api.github.com/repos/huggingface/datasets/issues/6745 | 6,745 | Scraping the whole of github including private repos is bad; kindly stop | ### Feature request
https://github.com/bigcode-project/opt-out-v2 - opt out is not consent. kindly quit this ridiculous nonsense.
### Motivation
[EDITED: insults not tolerated]
### Your contribution
[EDITED: insults not tolerated] | closed | 2024-03-20T20:54:06 | https://api.github.com/repos/huggingface/datasets/issues/6745/comments | null | false | Scraping the whole of github including private repos is bad; kindly stop
### Feature request
https://github.com/bigcode-project/opt-out-v2 - opt out is not consent. kindly quit this ridiculous nonsense.
### Motivation
[EDITED: insults not tolerated]
### Your contribution
[EDITED: insults not tolerated] | [
"It's not twitter here"
] |
https://api.github.com/repos/huggingface/datasets/issues/6744 | 6,744 | Option to disable file locking | ### Feature request
Commands such as `load_dataset` creates file locks with `filelock.FileLock`. It would be good if there was a way to disable this.
### Motivation
File locking doesn't work on all file-systems (in my case NFS mounted Weka). If the `cache_dir` only had small files then it would be possible to point ... | open | 2024-03-20T15:59:45 | https://api.github.com/repos/huggingface/datasets/issues/6744/comments | null | false | Option to disable file locking
### Feature request
Commands such as `load_dataset` creates file locks with `filelock.FileLock`. It would be good if there was a way to disable this.
### Motivation
File locking doesn't work on all file-systems (in my case NFS mounted Weka). If the `cache_dir` only had small files then... | [] |
https://api.github.com/repos/huggingface/datasets/issues/6743 | 6,743 | Allow null values in dict columns | Fix #6738 | closed | 2024-03-19T16:54:22 | https://api.github.com/repos/huggingface/datasets/issues/6743/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6743",
"html_url": "https://github.com/huggingface/datasets/pull/6743",
"diff_url": "https://github.com/huggingface/datasets/pull/6743.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6743.patch",
"merged_at": "2024-03-19T20:05... | true | Allow null values in dict columns
Fix #6738 | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6743). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6742 | 6,742 | Fix missing download_config in get_data_patterns | Reported in https://github.com/huggingface/datasets-server/issues/2607 | closed | 2024-03-19T14:29:25 | https://api.github.com/repos/huggingface/datasets/issues/6742/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6742",
"html_url": "https://github.com/huggingface/datasets/pull/6742",
"diff_url": "https://github.com/huggingface/datasets/pull/6742.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6742.patch",
"merged_at": "2024-03-19T18:15... | true | Fix missing download_config in get_data_patterns
Reported in https://github.com/huggingface/datasets-server/issues/2607 | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6742). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6741 | 6,741 | Fix offline mode with single config | Reported in https://github.com/huggingface/datasets/issues/4760
The cache was not able to reload a dataset with a single config form the cache if the config name is not specificed
For example
```python
from datasets import load_dataset, config
config.HF_DATASETS_OFFLINE = True
load_dataset("openai_human... | closed | 2024-03-19T10:48:32 | https://api.github.com/repos/huggingface/datasets/issues/6741/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6741",
"html_url": "https://github.com/huggingface/datasets/pull/6741",
"diff_url": "https://github.com/huggingface/datasets/pull/6741.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6741.patch",
"merged_at": "2024-03-25T16:23... | true | Fix offline mode with single config
Reported in https://github.com/huggingface/datasets/issues/4760
The cache was not able to reload a dataset with a single config form the cache if the config name is not specificed
For example
```python
from datasets import load_dataset, config
config.HF_DATASETS_OFFLINE ... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6741). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6740 | 6,740 | Support for loading geotiff files as a part of the ImageFolder | ### Feature request
Request for adding rasterio support to load geotiff as a part of ImageFolder, instead of using PIL
### Motivation
As of now, there are many datasets in HuggingFace Hub which are predominantly focussed towards RemoteSensing or are from RemoteSensing. The current ImageFolder (if I have understood c... | closed | 2024-03-18T20:00:39 | https://api.github.com/repos/huggingface/datasets/issues/6740/comments | null | false | Support for loading geotiff files as a part of the ImageFolder
### Feature request
Request for adding rasterio support to load geotiff as a part of ImageFolder, instead of using PIL
### Motivation
As of now, there are many datasets in HuggingFace Hub which are predominantly focussed towards RemoteSensing or are from... | [] |
https://api.github.com/repos/huggingface/datasets/issues/6739 | 6,739 | Transpose images with EXIF Orientation tag | Closes https://github.com/huggingface/datasets/issues/6252 | closed | 2024-03-18T16:43:06 | https://api.github.com/repos/huggingface/datasets/issues/6739/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6739",
"html_url": "https://github.com/huggingface/datasets/pull/6739",
"diff_url": "https://github.com/huggingface/datasets/pull/6739.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6739.patch",
"merged_at": "2024-03-19T15:29... | true | Transpose images with EXIF Orientation tag
Closes https://github.com/huggingface/datasets/issues/6252 | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6739). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6738 | 6,738 | Dict feature is non-nullable while nested dict feature is | When i try to create a `Dataset` object with None values inside a dict column, like this:
```python
from datasets import Dataset, Features, Value
Dataset.from_dict(
{
"dict": [{"a": 0, "b": 0}, None],
}, features=Features(
{"dict": {"a": Value("int16"), "b": Value("int16")}}
)
)
... | closed | 2024-03-18T14:31:47 | https://api.github.com/repos/huggingface/datasets/issues/6738/comments | null | false | Dict feature is non-nullable while nested dict feature is
When i try to create a `Dataset` object with None values inside a dict column, like this:
```python
from datasets import Dataset, Features, Value
Dataset.from_dict(
{
"dict": [{"a": 0, "b": 0}, None],
}, features=Features(
{"dic... | [
"It looks like a bug, by default every feature should be nullable.",
"I've linked a PR with a fix :)",
"@mariosasko awesome thank you!"
] |
https://api.github.com/repos/huggingface/datasets/issues/6737 | 6,737 | Invalid pattern: '**' can only be an entire path component | ### Describe the bug
ValueError: Invalid pattern: '**' can only be an entire path component
when loading any dataset
### Steps to reproduce the bug
import datasets
ds = datasets.load_dataset("TokenBender/code_instructions_122k_alpaca_style")
### Expected behavior
loading the dataset successfully
### Environm... | closed | 2024-03-16T19:28:46 | https://api.github.com/repos/huggingface/datasets/issues/6737/comments | null | false | Invalid pattern: '**' can only be an entire path component
### Describe the bug
ValueError: Invalid pattern: '**' can only be an entire path component
when loading any dataset
### Steps to reproduce the bug
import datasets
ds = datasets.load_dataset("TokenBender/code_instructions_122k_alpaca_style")
### Expecte... | [
"I couldn't reproduce the issue on my side on MacOS, I guess the issue comes from the recent `fsspec` on Windows.\r\n\r\nCan you try downgrading to `fsspec==2023.9.2` for now ? It would also be great to investigate this and see if we need a fix in `datasets` or `fsspec`",
"I had the same issue! \r\nDowngrading t... |
https://api.github.com/repos/huggingface/datasets/issues/6736 | 6,736 | Mosaic Streaming (MDS) Support | ### Feature request
I'm a huge fan of the current HF Datasets `webdataset` integration (especially the built-in streaming support). However, I'd love to upload some robotics and multimodal datasets I've processed for use with [Mosaic Streaming](https://docs.mosaicml.com/projects/streaming/en/stable/), specifically the... | open | 2024-03-16T18:42:04 | https://api.github.com/repos/huggingface/datasets/issues/6736/comments | null | false | Mosaic Streaming (MDS) Support
### Feature request
I'm a huge fan of the current HF Datasets `webdataset` integration (especially the built-in streaming support). However, I'd love to upload some robotics and multimodal datasets I've processed for use with [Mosaic Streaming](https://docs.mosaicml.com/projects/streamin... | [
"Hi ! that would be great :) Though note that `datasets` doesn't implement format-specific resuming when streaming, so in general I think it's better if users can use the mosaic-streaming library to read their MDS datasets. I wonder if they support `hf://` paths though...\n\nAnyway for those interested, the code fo... |
https://api.github.com/repos/huggingface/datasets/issues/6735 | 6,735 | Add `mode` parameter to `Image` feature | Fix https://github.com/huggingface/datasets/issues/6675 | closed | 2024-03-15T17:21:12 | https://api.github.com/repos/huggingface/datasets/issues/6735/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6735",
"html_url": "https://github.com/huggingface/datasets/pull/6735",
"diff_url": "https://github.com/huggingface/datasets/pull/6735.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6735.patch",
"merged_at": "2024-03-18T15:41... | true | Add `mode` parameter to `Image` feature
Fix https://github.com/huggingface/datasets/issues/6675 | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6735). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6734 | 6,734 | Tokenization slows towards end of dataset | ### Describe the bug
Mapped tokenization slows down substantially towards end of dataset.
train set started off very slow, caught up to 20k then tapered off til the end.
what's particularly strange is that the tokenization crashed a few times before due to errors with invalid tokens somewhere or corrupted down... | open | 2024-03-15T03:27:36 | https://api.github.com/repos/huggingface/datasets/issues/6734/comments | null | false | Tokenization slows towards end of dataset
### Describe the bug
Mapped tokenization slows down substantially towards end of dataset.
train set started off very slow, caught up to 20k then tapered off til the end.
what's particularly strange is that the tokenization crashed a few times before due to errors with ... | [
"Hi ! First note that if the dataset is not heterogeneous / shuffled, there might be places in the data with shorter texts that are faster to tokenize.\r\n\r\nMoreover, the way `num_proc` works is by slicing the dataset and passing each slice to a process to run the `map()` function. So at the very end of `map()`, ... |
https://api.github.com/repos/huggingface/datasets/issues/6733 | 6,733 | EmptyDatasetError when loading dataset downloaded with HuggingFace cli | ### Describe the bug
I am using a cluster that does not have access to the internet when given a job. I tried downloading the dataset using the huggingface-cli command and then loading it with load_dataset but I get an error:
```raise EmptyDatasetError(f"The directory at {base_path} doesn't contain any data files... | open | 2024-03-14T16:41:27 | https://api.github.com/repos/huggingface/datasets/issues/6733/comments | null | false | EmptyDatasetError when loading dataset downloaded with HuggingFace cli
### Describe the bug
I am using a cluster that does not have access to the internet when given a job. I tried downloading the dataset using the huggingface-cli command and then loading it with load_dataset but I get an error:
```raise EmptyDat... | [
"Hi! `datasets` is not compatible with `huggingface_hub`'s cache structure, hence the error.\r\n\r\nYou can track https://github.com/huggingface/datasets/issues/5080 to get notified when this is implemented."
] |
https://api.github.com/repos/huggingface/datasets/issues/6731 | 6,731 | Unexpected behavior when using load_dataset with streaming=True in a for loop | ### Describe the bug
### My Code
```
from datasets import load_dataset
res=[]
for i in [0,1]:
di=load_dataset(
"json",
data_files='path_to.json',
split='train',
streaming=True,
).map(lambda x: {"source": i})
res.append(di)
for e in res[... | closed | 2024-03-12T23:26:43 | https://api.github.com/repos/huggingface/datasets/issues/6731/comments | null | false | Unexpected behavior when using load_dataset with streaming=True in a for loop
### Describe the bug
### My Code
```
from datasets import load_dataset
res=[]
for i in [0,1]:
di=load_dataset(
"json",
data_files='path_to.json',
split='train',
streaming=True,
... | [
"This is normal behavior in python when using `lambda`: the `i` defined in your `lambda` refers to the global variable `i` in your loop, and `i` equals to `1` when you run your `for e in res[0]` line.\r\n\r\nYou should pass `fn_kwargs` that will be passed to your `lambda` instead of using the global variable:\r\n\r... |
https://api.github.com/repos/huggingface/datasets/issues/6730 | 6,730 | Deprecate Pandas builder | The Pandas packaged builder is undocumented and relies on `pickle` to read the data, making it **unsafe**. Moreover, I haven't seen a single instance of this builder being used (not even using the GH/Hub search), so we should deprecate it. | closed | 2024-03-12T15:12:13 | https://api.github.com/repos/huggingface/datasets/issues/6730/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6730",
"html_url": "https://github.com/huggingface/datasets/pull/6730",
"diff_url": "https://github.com/huggingface/datasets/pull/6730.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6730.patch",
"merged_at": "2024-03-12T17:36... | true | Deprecate Pandas builder
The Pandas packaged builder is undocumented and relies on `pickle` to read the data, making it **unsafe**. Moreover, I haven't seen a single instance of this builder being used (not even using the GH/Hub search), so we should deprecate it. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6730). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6729 | 6,729 | Support zipfiles that span multiple disks? | See https://huggingface.co/datasets/PhilEO-community/PhilEO-downstream
The dataset viewer gives the following error:
```
Error code: ConfigNamesError
Exception: BadZipFile
Message: zipfiles that span multiple disks are not supported
Traceback: Traceback (most recent call last):
F... | closed | 2024-03-11T21:07:41 | https://api.github.com/repos/huggingface/datasets/issues/6729/comments | null | false | Support zipfiles that span multiple disks?
See https://huggingface.co/datasets/PhilEO-community/PhilEO-downstream
The dataset viewer gives the following error:
```
Error code: ConfigNamesError
Exception: BadZipFile
Message: zipfiles that span multiple disks are not supported
Traceback: Traceback ... | [
"@severo were you able to solve it?",
"No. cc @albertvillanova @lhoestq @polinaeterna for an evaluation of what it would take to support this feature.",
"The underlying issue issue is that the dataset repository has used split ZIP archive files: https://huggingface.co/datasets/PhilEO-community/PhilEO-downstream... |
https://api.github.com/repos/huggingface/datasets/issues/6728 | 6,728 | Issue Downloading Certain Datasets After Setting Custom `HF_ENDPOINT` | ### Describe the bug
This bug is triggered under the following conditions:
- datasets repo ids without organization names trigger errors, such as `bookcorpus`, `gsm8k`, `wikipedia`, rather than in the form of `A/B`.
- If `HF_ENDPOINT` is set and the hostname is not in the form of `(hub-ci.)?huggingface.co`.
- T... | closed | 2024-03-11T09:06:38 | https://api.github.com/repos/huggingface/datasets/issues/6728/comments | null | false | Issue Downloading Certain Datasets After Setting Custom `HF_ENDPOINT`
### Describe the bug
This bug is triggered under the following conditions:
- datasets repo ids without organization names trigger errors, such as `bookcorpus`, `gsm8k`, `wikipedia`, rather than in the form of `A/B`.
- If `HF_ENDPOINT` is set a... | [
"Through debugging, I found a potential solution is to modify the code in the error handling module of `huggingface_hub`: https://github.com/huggingface/huggingface_hub/commit/56d6c798c44e83d2a3167e74c022737d8fcbe822 ",
"@Wauplin ",
"Thanks for investigating and reporting the bug @padeoe! I've opened a PR in `h... |
https://api.github.com/repos/huggingface/datasets/issues/6727 | 6,727 | Using a registry instead of calling globals for fetching feature types | Hello,
When working with bio-data, each feature often has metadata associated with it (e.g. species, lineage, snp position, etc). To store this, I like to use the feature classes with the added `metadata` attribute. However, when saving or loading with custom features, you get an error since that class doesn't exist... | closed | 2024-03-10T17:47:51 | https://api.github.com/repos/huggingface/datasets/issues/6727/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6727",
"html_url": "https://github.com/huggingface/datasets/pull/6727",
"diff_url": "https://github.com/huggingface/datasets/pull/6727.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6727.patch",
"merged_at": "2024-03-13T10:46... | true | Using a registry instead of calling globals for fetching feature types
Hello,
When working with bio-data, each feature often has metadata associated with it (e.g. species, lineage, snp position, etc). To store this, I like to use the feature classes with the added `metadata` attribute. However, when saving or loadin... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6727). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"looks like some files are missing in your google storage",
"cc @mariosasko is it rela... |
https://api.github.com/repos/huggingface/datasets/issues/6726 | 6,726 | Profiling for HF Filesystem shows there are easy performance gains to be made | ### Describe the bug
# Let's make it faster
First, an evidence...
Figure 1: CProfile for loading 3 files from cerebras/SlimPajama-627B train split, and 3 files from test split using streaming=True. X axis is 1106... | open | 2024-03-09T07:08:45 | https://api.github.com/repos/huggingface/datasets/issues/6726/comments | null | false | Profiling for HF Filesystem shows there are easy performance gains to be made
### Describe the bug
# Let's make it faster
First, an evidence...
Figure 1: CProfile for loading 3 files from cerebras/SlimPajama-627B... | [
"FWIW I debugged this while waiting for it to go",
"Oh I forgot to mention you can also cache resolve_pattern, and that seemed to also substantially improves things, if you want to load a dataset twice for whatever reason."
] |
https://api.github.com/repos/huggingface/datasets/issues/6725 | 6,725 | Request for a comparison of huggingface datasets compared with other data format especially webdataset | ### Feature request
Request for a comparison of huggingface datasets compared with other data format especially webdataset
### Motivation
I see huggingface datasets uses Apache Arrow as its backend, it seems to be great, but I'm curious about how it is good compared with other dataset format, like webdataset, what's... | open | 2024-03-08T08:23:01 | https://api.github.com/repos/huggingface/datasets/issues/6725/comments | null | false | Request for a comparison of huggingface datasets compared with other data format especially webdataset
### Feature request
Request for a comparison of huggingface datasets compared with other data format especially webdataset
### Motivation
I see huggingface datasets uses Apache Arrow as its backend, it seems to be ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/6724 | 6,724 | Dataset with loading script does not work in renamed repos | ### Describe the bug
My data repository was first called `BramVanroy/hplt-mono-v1-2` but I then renamed to use underscores instead of dashes. However, it seems that `datasets` retrieves the old repo name when it checks whether the repo contains data loading scripts in this line.
https://github.com/huggingface/dat... | open | 2024-03-07T17:38:38 | https://api.github.com/repos/huggingface/datasets/issues/6724/comments | null | false | Dataset with loading script does not work in renamed repos
### Describe the bug
My data repository was first called `BramVanroy/hplt-mono-v1-2` but I then renamed to use underscores instead of dashes. However, it seems that `datasets` retrieves the old repo name when it checks whether the repo contains data loading ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/6723 | 6,723 | get_dataset_default_config_name docstring | fix https://github.com/huggingface/datasets/pull/6722 | closed | 2024-03-07T17:09:29 | https://api.github.com/repos/huggingface/datasets/issues/6723/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6723",
"html_url": "https://github.com/huggingface/datasets/pull/6723",
"diff_url": "https://github.com/huggingface/datasets/pull/6723.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6723.patch",
"merged_at": "2024-03-07T17:21... | true | get_dataset_default_config_name docstring
fix https://github.com/huggingface/datasets/pull/6722 | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6723). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6722 | 6,722 | Add details in docstring | see https://github.com/huggingface/datasets-server/pull/2554#discussion_r1516516867 | closed | 2024-03-07T17:02:07 | https://api.github.com/repos/huggingface/datasets/issues/6722/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6722",
"html_url": "https://github.com/huggingface/datasets/pull/6722",
"diff_url": "https://github.com/huggingface/datasets/pull/6722.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6722.patch",
"merged_at": null
} | true | Add details in docstring
see https://github.com/huggingface/datasets-server/pull/2554#discussion_r1516516867 | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6722). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update."
] |
https://api.github.com/repos/huggingface/datasets/issues/6721 | 6,721 | Hi,do you know how to load the dataset from local file now? | Hi, if I want to load the dataset from local file, then how to specify the configuration name?
_Originally posted by @WHU-gentle in https://github.com/huggingface/datasets/issues/2976#issuecomment-1333455222_
| open | 2024-03-07T13:58:40 | https://api.github.com/repos/huggingface/datasets/issues/6721/comments | null | false | Hi,do you know how to load the dataset from local file now?
Hi, if I want to load the dataset from local file, then how to specify the configuration name?
_Originally posted by @WHU-gentle in https://github.com/huggingface/datasets/issues/2976#issuecomment-1333455222_
| [
"\r\n@Gera001\r\n# Loading Dataset from Local Files Using 🤗Hugging Face.\r\n\r\nTo load a dataset from local files using the Hugging Face datasets library, you can use the `load_dataset` function.\r\n\r\n```\r\nfrom datasets import load_dataset\r\ndataset = load_dataset('csv', data_files={'train': 'path/to/train.c... |
https://api.github.com/repos/huggingface/datasets/issues/6720 | 6,720 | TypeError: 'str' object is not callable | ### Describe the bug
I am trying to get the HPLT datasets on the hub. Downloading/re-uploading would be too time- and resource consuming so I wrote [a dataset loader script](https://huggingface.co/datasets/BramVanroy/hplt_mono_v1_2/blob/main/hplt_mono_v1_2.py). I think I am very close but for some reason I always get ... | closed | 2024-03-07T11:07:09 | https://api.github.com/repos/huggingface/datasets/issues/6720/comments | null | false | TypeError: 'str' object is not callable
### Describe the bug
I am trying to get the HPLT datasets on the hub. Downloading/re-uploading would be too time- and resource consuming so I wrote [a dataset loader script](https://huggingface.co/datasets/BramVanroy/hplt_mono_v1_2/blob/main/hplt_mono_v1_2.py). I think I am very... | [
"Hi ! I opened a PR to fix an issue in the Features defined in your code\r\n\r\nBasically changing\r\n```python\r\nSequence(\"float32\")\r\n```\r\n\r\nto\r\n```python\r\nSequence(Value(\"float32\"))\r\n```\r\n\r\n\r\nhttps://huggingface.co/datasets/BramVanroy/hplt_mono_v1_2/discussions/1",
"D'oh! Was wondering wh... |
https://api.github.com/repos/huggingface/datasets/issues/6719 | 6,719 | Is there any way to solve hanging of IterableDataset using split by node + filtering during inference | ### Describe the bug
I am using an iterable dataset in a multi-node setup, trying to do training/inference while filtering the data on the fly. I usually do not use `split_dataset_by_node` but it is very slow using the IterableDatasetShard in `accelerate` and `transformers`. When I filter after applying `split_dataset... | open | 2024-03-05T15:55:13 | https://api.github.com/repos/huggingface/datasets/issues/6719/comments | null | false | Is there any way to solve hanging of IterableDataset using split by node + filtering during inference
### Describe the bug
I am using an iterable dataset in a multi-node setup, trying to do training/inference while filtering the data on the fly. I usually do not use `split_dataset_by_node` but it is very slow using th... | [] |
https://api.github.com/repos/huggingface/datasets/issues/6718 | 6,718 | Fix concurrent script loading with force_redownload | I added `lock_importable_file` in `get_dataset_builder_class` and `extend_dataset_builder_for_streaming` to fix the issue, and I also added a test
cc @clefourrier | closed | 2024-03-05T15:04:20 | https://api.github.com/repos/huggingface/datasets/issues/6718/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6718",
"html_url": "https://github.com/huggingface/datasets/pull/6718",
"diff_url": "https://github.com/huggingface/datasets/pull/6718.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6718.patch",
"merged_at": "2024-03-07T13:58... | true | Fix concurrent script loading with force_redownload
I added `lock_importable_file` in `get_dataset_builder_class` and `extend_dataset_builder_for_streaming` to fix the issue, and I also added a test
cc @clefourrier | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6718). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6717 | 6,717 | `remove_columns` method used with a streaming enable dataset mode produces a LibsndfileError on multichannel audio | ### Describe the bug
When loading a HF dataset in streaming mode and removing some columns, it is impossible to load a sample if the audio contains more than one channel. I have the impression that the time axis and channels are swapped or concatenated.
### Steps to reproduce the bug
Minimal error code:
```python
... | open | 2024-03-05T09:33:26 | https://api.github.com/repos/huggingface/datasets/issues/6717/comments | null | false | `remove_columns` method used with a streaming enable dataset mode produces a LibsndfileError on multichannel audio
### Describe the bug
When loading a HF dataset in streaming mode and removing some columns, it is impossible to load a sample if the audio contains more than one channel. I have the impression that the ti... | [
"And it also works well with `dataset = dataset.select_columns([\"audio\"])`",
"Same issue here, disable stream=True fix the problem"
] |
https://api.github.com/repos/huggingface/datasets/issues/6716 | 6,716 | Non-deterministic `Dataset.builder_name` value | ### Describe the bug
I'm not sure if this is a bug, but `print(ds.builder_name)` in the following code sometimes prints out `rotten_tomatoes` instead of `parquet`:
```python
import datasets
for _ in range(100):
ds = datasets.load_dataset("rotten_tomatoes", split="train")
print(ds.builder_name) # pr... | closed | 2024-03-05T09:23:21 | https://api.github.com/repos/huggingface/datasets/issues/6716/comments | null | false | Non-deterministic `Dataset.builder_name` value
### Describe the bug
I'm not sure if this is a bug, but `print(ds.builder_name)` in the following code sometimes prints out `rotten_tomatoes` instead of `parquet`:
```python
import datasets
for _ in range(100):
ds = datasets.load_dataset("rotten_tomatoes", s... | [
"When `rotten_tomatoes` is printed out, the following warning message is also printed out:\r\n\r\n```\r\nYou can avoid this message in future by passing the argument `trust_remote_code=True`.\r\nPassing `trust_remote_code=True` will be mandatory to load this dataset from the next major release of `datasets`.\r\n```... |
https://api.github.com/repos/huggingface/datasets/issues/6715 | 6,715 | Fix sliced ConcatenationTable pickling with mixed schemas vertically | A sliced + pickled ConcatenationTable could end up with a different schema than the original schema, if the slice only contains blocks with only a subset of the columns.
This can lead to issues when saving datasets from a concatenation of datasets with mixed schemas
Reported in https://discuss.huggingface.co/t/da... | closed | 2024-03-04T21:02:07 | https://api.github.com/repos/huggingface/datasets/issues/6715/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6715",
"html_url": "https://github.com/huggingface/datasets/pull/6715",
"diff_url": "https://github.com/huggingface/datasets/pull/6715.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6715.patch",
"merged_at": "2024-03-05T11:17... | true | Fix sliced ConcatenationTable pickling with mixed schemas vertically
A sliced + pickled ConcatenationTable could end up with a different schema than the original schema, if the slice only contains blocks with only a subset of the columns.
This can lead to issues when saving datasets from a concatenation of datasets ... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6715). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6714 | 6,714 | Expand no-code dataset info with datasets-server info | E.g., to have info about a dataset's number of examples for more informative TQDM bars. | closed | 2024-03-04T19:18:10 | https://api.github.com/repos/huggingface/datasets/issues/6714/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6714",
"html_url": "https://github.com/huggingface/datasets/pull/6714",
"diff_url": "https://github.com/huggingface/datasets/pull/6714.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6714.patch",
"merged_at": "2024-03-04T20:22... | true | Expand no-code dataset info with datasets-server info
E.g., to have info about a dataset's number of examples for more informative TQDM bars. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6714). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6713 | 6,713 | Bump huggingface-hub lower version to 0.21.2 | This should fix the version compatibility issue when using `huggingface_hub` < 0.21.2 and latest fsspec (>=2023.12.0).
See my comment: https://github.com/huggingface/datasets/pull/6687#issuecomment-1976493336
>> EDIT: the fix has been released in `huggingface_hub` 0.21.2 - I removed my commits that were using `hugg... | closed | 2024-03-04T13:00:52 | https://api.github.com/repos/huggingface/datasets/issues/6713/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6713",
"html_url": "https://github.com/huggingface/datasets/pull/6713",
"diff_url": "https://github.com/huggingface/datasets/pull/6713.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6713.patch",
"merged_at": "2024-03-04T18:06... | true | Bump huggingface-hub lower version to 0.21.2
This should fix the version compatibility issue when using `huggingface_hub` < 0.21.2 and latest fsspec (>=2023.12.0).
See my comment: https://github.com/huggingface/datasets/pull/6687#issuecomment-1976493336
>> EDIT: the fix has been released in `huggingface_hub` 0.21.2... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6713). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"@lhoestq if you agree, I could make a patch release tomorrow morning.",
"sure :)",
... |
https://api.github.com/repos/huggingface/datasets/issues/6712 | 6,712 | fix CastError pickling | reported in https://discuss.huggingface.co/t/datasetdict-save-to-disk-with-num-proc-1-seems-to-hang-with-error/75595 | closed | 2024-03-04T11:14:18 | https://api.github.com/repos/huggingface/datasets/issues/6712/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6712",
"html_url": "https://github.com/huggingface/datasets/pull/6712",
"diff_url": "https://github.com/huggingface/datasets/pull/6712.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6712.patch",
"merged_at": "2024-03-04T20:17... | true | fix CastError pickling
reported in https://discuss.huggingface.co/t/datasetdict-save-to-disk-with-num-proc-1-seems-to-hang-with-error/75595 | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6712). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6711 | 6,711 | 3x Faster Text Preprocessing | I was preparing some datasets for AI training and noticed that `datasets` by HuggingFace uses the conventional `open` mechanism to read the file and split it into chunks. I thought it can be significantly accelerated, and [started with a benchmark](https://gist.github.com/ashvardanian/55c2052e9f78b05b8d614aa90cb12347):... | open | 2024-03-03T19:03:04 | https://api.github.com/repos/huggingface/datasets/issues/6711/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6711",
"html_url": "https://github.com/huggingface/datasets/pull/6711",
"diff_url": "https://github.com/huggingface/datasets/pull/6711.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6711.patch",
"merged_at": null
} | true | 3x Faster Text Preprocessing
I was preparing some datasets for AI training and noticed that `datasets` by HuggingFace uses the conventional `open` mechanism to read the file and split it into chunks. I thought it can be significantly accelerated, and [started with a benchmark](https://gist.github.com/ashvardanian/55c20... | [
"Unfortunately, that won't improve the performance. StringZilla repository has extensive benchmarks comparing against different built-in functionality of several programming languages. Using `re.finditer` for tokenization is practically the slowest anti-pattern I've encountered in any language. The gap between that... |
https://api.github.com/repos/huggingface/datasets/issues/6710 | 6,710 | Persist IterableDataset epoch in workers | Use shared memory for the IterableDataset epoch.
This way calling `ds.set_epoch()` in the main process will update the epoch in the DataLoader workers as well.
This is useful especially because the epoch is used to compute the `effective_seed` used for shuffling.
I used torch's shared memory in case users want t... | closed | 2024-03-02T12:08:50 | https://api.github.com/repos/huggingface/datasets/issues/6710/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6710",
"html_url": "https://github.com/huggingface/datasets/pull/6710",
"diff_url": "https://github.com/huggingface/datasets/pull/6710.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6710.patch",
"merged_at": "2024-07-01T17:45... | true | Persist IterableDataset epoch in workers
Use shared memory for the IterableDataset epoch.
This way calling `ds.set_epoch()` in the main process will update the epoch in the DataLoader workers as well.
This is useful especially because the epoch is used to compute the `effective_seed` used for shuffling.
I used t... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6710). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6709 | 6,709 | set dev version | null | closed | 2024-03-01T21:01:14 | https://api.github.com/repos/huggingface/datasets/issues/6709/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6709",
"html_url": "https://github.com/huggingface/datasets/pull/6709",
"diff_url": "https://github.com/huggingface/datasets/pull/6709.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6709.patch",
"merged_at": "2024-03-01T21:01... | true | set dev version
| [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6709). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6708 | 6,708 | Release: 2.18.0 | null | closed | 2024-03-01T20:52:17 | https://api.github.com/repos/huggingface/datasets/issues/6708/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6708",
"html_url": "https://github.com/huggingface/datasets/pull/6708",
"diff_url": "https://github.com/huggingface/datasets/pull/6708.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6708.patch",
"merged_at": "2024-03-01T20:56... | true | Release: 2.18.0
| [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6708). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6707 | 6,707 | Silence ruff deprecation messages | null | closed | 2024-03-01T16:52:29 | https://api.github.com/repos/huggingface/datasets/issues/6707/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6707",
"html_url": "https://github.com/huggingface/datasets/pull/6707",
"diff_url": "https://github.com/huggingface/datasets/pull/6707.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6707.patch",
"merged_at": "2024-03-01T17:25... | true | Silence ruff deprecation messages
| [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6707). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6706 | 6,706 | Update ruff | null | closed | 2024-03-01T16:44:58 | https://api.github.com/repos/huggingface/datasets/issues/6706/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6706",
"html_url": "https://github.com/huggingface/datasets/pull/6706",
"diff_url": "https://github.com/huggingface/datasets/pull/6706.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6706.patch",
"merged_at": "2024-03-01T16:52... | true | Update ruff
| [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6706). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6705 | 6,705 | Fix data_files when passing data_dir | This code should not return empty data files
```python
from datasets import load_dataset_builder
revision = "3d406e70bc21c3ca92a9a229b4c6fc3ed88279fd"
b = load_dataset_builder("bigcode/the-stack-v2-dedup", data_dir="data/Dockerfile", revision=revision)
print(b.config.data_files)
```
Previously it would ret... | closed | 2024-03-01T16:38:53 | https://api.github.com/repos/huggingface/datasets/issues/6705/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6705",
"html_url": "https://github.com/huggingface/datasets/pull/6705",
"diff_url": "https://github.com/huggingface/datasets/pull/6705.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6705.patch",
"merged_at": "2024-03-01T18:52... | true | Fix data_files when passing data_dir
This code should not return empty data files
```python
from datasets import load_dataset_builder
revision = "3d406e70bc21c3ca92a9a229b4c6fc3ed88279fd"
b = load_dataset_builder("bigcode/the-stack-v2-dedup", data_dir="data/Dockerfile", revision=revision)
print(b.config.data_f... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6705). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6704 | 6,704 | Improve default patterns resolution | Separate the default patterns that match directories from the ones matching files and ensure directories are checked first (reverts the change from https://github.com/huggingface/datasets/pull/6244, which merged these patterns). Also, ensure that the glob patterns do not overlap to avoid duplicates in the result.
A... | closed | 2024-03-01T16:31:25 | https://api.github.com/repos/huggingface/datasets/issues/6704/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6704",
"html_url": "https://github.com/huggingface/datasets/pull/6704",
"diff_url": "https://github.com/huggingface/datasets/pull/6704.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6704.patch",
"merged_at": "2024-03-15T15:22... | true | Improve default patterns resolution
Separate the default patterns that match directories from the ones matching files and ensure directories are checked first (reverts the change from https://github.com/huggingface/datasets/pull/6244, which merged these patterns). Also, ensure that the glob patterns do not overlap to a... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6704). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Awesome !\r\n\r\nNote that it can still create duplicates if a path matches several dir... |
https://api.github.com/repos/huggingface/datasets/issues/6703 | 6,703 | Unable to load dataset that was saved with `save_to_disk` | ### Describe the bug
I get the following error message: You are trying to load a dataset that was saved using `save_to_disk`. Please use `load_from_disk` instead.
### Steps to reproduce the bug
1. Save a dataset with `save_to_disk`
2. Try to load it with `load_datasets`
### Expected behavior
I am ab... | closed | 2024-03-01T11:59:56 | https://api.github.com/repos/huggingface/datasets/issues/6703/comments | null | false | Unable to load dataset that was saved with `save_to_disk`
### Describe the bug
I get the following error message: You are trying to load a dataset that was saved using `save_to_disk`. Please use `load_from_disk` instead.
### Steps to reproduce the bug
1. Save a dataset with `save_to_disk`
2. Try to load i... | [
"`save_to_disk` uses a special serialization that can only be read using `load_from_disk`.\r\n\r\nContrary to `load_dataset`, `load_from_disk` directly loads Arrow files and uses the dataset directory as cache.\r\n\r\nOn the other hand `load_dataset` does a conversion step to get Arrow files from the raw data files... |
https://api.github.com/repos/huggingface/datasets/issues/6702 | 6,702 | Push samples to dataset on hub without having the dataset locally | ### Feature request
Say I have the following code:
```
from datasets import Dataset
import pandas as pd
new_data = {
"column_1": ["value1", "value2"],
"column_2": ["value3", "value4"],
}
df_new = pd.DataFrame(new_data)
dataset_new = Dataset.from_pandas(df_new)
# add these samples to a remote datase... | closed | 2024-02-29T19:17:12 | https://api.github.com/repos/huggingface/datasets/issues/6702/comments | null | false | Push samples to dataset on hub without having the dataset locally
### Feature request
Say I have the following code:
```
from datasets import Dataset
import pandas as pd
new_data = {
"column_1": ["value1", "value2"],
"column_2": ["value3", "value4"],
}
df_new = pd.DataFrame(new_data)
dataset_new = D... | [
"Hi ! For now I would recommend creating a new Parquet file using `dataset_new.to_parquet()` and upload it to HF using `huggingface_hub` every time you get a new batch of data. You can name the Parquet files `0000.parquet`, `0001.parquet`, etc.\r\n\r\nThough maybe make sure to not upload one file per sample since t... |
https://api.github.com/repos/huggingface/datasets/issues/6701 | 6,701 | Base parquet batch_size on parquet row group size | This allows to stream datasets like [Major-TOM/Core-S2L2A](https://huggingface.co/datasets/Major-TOM/Core-S2L2A) which have row groups with few rows (one row is ~10MB). Previously the cold start would take a lot of time and OOM because it would download many row groups before yielding the first example.
I tried on O... | closed | 2024-02-29T14:53:01 | https://api.github.com/repos/huggingface/datasets/issues/6701/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6701",
"html_url": "https://github.com/huggingface/datasets/pull/6701",
"diff_url": "https://github.com/huggingface/datasets/pull/6701.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6701.patch",
"merged_at": "2024-02-29T15:08... | true | Base parquet batch_size on parquet row group size
This allows to stream datasets like [Major-TOM/Core-S2L2A](https://huggingface.co/datasets/Major-TOM/Core-S2L2A) which have row groups with few rows (one row is ~10MB). Previously the cold start would take a lot of time and OOM because it would download many row groups ... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6701). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6700 | 6,700 | remove_columns is not in-place but the doc shows it is in-place | ### Describe the bug
The doc of `datasets` v2.17.0/v2.17.1 shows that `remove_columns` is in-place. [link](https://huggingface.co/docs/datasets/v2.17.1/en/package_reference/main_classes#datasets.DatasetDict.remove_columns)
In the text classification example of transformers v4.38.1, the columns are not removed.
h... | closed | 2024-02-28T12:36:22 | https://api.github.com/repos/huggingface/datasets/issues/6700/comments | null | false | remove_columns is not in-place but the doc shows it is in-place
### Describe the bug
The doc of `datasets` v2.17.0/v2.17.1 shows that `remove_columns` is in-place. [link](https://huggingface.co/docs/datasets/v2.17.1/en/package_reference/main_classes#datasets.DatasetDict.remove_columns)
In the text classification ... | [
"Good catch! I've opened a PR with a fix in the `transformers` repo.",
"@mariosasko Thanks!\r\n\r\nWill the doc of `datasets` be updated?\r\n\r\nI find some possible mistakes in doc about whether `remove_columns` is in-place.\r\n1. [You can also remove a column using map() with remove_columns but the present meth... |
https://api.github.com/repos/huggingface/datasets/issues/6699 | 6,699 | `Dataset` unexpected changed dict data and may cause error | ### Describe the bug
Will unexpected get keys with `None` value in the parsed json dict.
### Steps to reproduce the bug
```jsonl test.jsonl
{"id": 0, "indexs": {"-1": [0, 10]}}
{"id": 1, "indexs": {"-1": [0, 10]}}
```
```python
dataset = Dataset.from_json('.test.jsonl')
print(dataset[0])
```
Result:
```... | open | 2024-02-28T05:30:10 | https://api.github.com/repos/huggingface/datasets/issues/6699/comments | null | false | `Dataset` unexpected changed dict data and may cause error
### Describe the bug
Will unexpected get keys with `None` value in the parsed json dict.
### Steps to reproduce the bug
```jsonl test.jsonl
{"id": 0, "indexs": {"-1": [0, 10]}}
{"id": 1, "indexs": {"-1": [0, 10]}}
```
```python
dataset = Dataset.from_... | [
"If `test.jsonl` contains more lines like:\r\n```\r\n{\"id\": 0, \"indexs\": {\"-1\": [0, 10]}}\r\n{\"id\": 1, \"indexs\": {\"-1\": [0, 10]}}\r\n{\"id\": 2, \"indexs\": {\"-2\": [0, 10]}}\r\n...\r\n{\"id\": n, \"indexs\": {\"-9999\": [0, 10]}}\r\n```\r\n\r\n`Dataset.from_json` will just raise an error:\r\n```\r\nAn... |
https://api.github.com/repos/huggingface/datasets/issues/6698 | 6,698 | Faster `xlistdir` | Pass `detail=False` to the `fsspec` `listdir` to avoid unnecessarily fetching expensive metadata about the paths. | closed | 2024-02-27T22:55:08 | https://api.github.com/repos/huggingface/datasets/issues/6698/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6698",
"html_url": "https://github.com/huggingface/datasets/pull/6698",
"diff_url": "https://github.com/huggingface/datasets/pull/6698.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6698.patch",
"merged_at": "2024-02-27T23:38... | true | Faster `xlistdir`
Pass `detail=False` to the `fsspec` `listdir` to avoid unnecessarily fetching expensive metadata about the paths. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6698). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"CI failure is unrelated to the changes.",
"<details>\n<summary>Show benchmarks</summa... |
https://api.github.com/repos/huggingface/datasets/issues/6697 | 6,697 | Unable to Load Dataset in Kaggle | ### Describe the bug
Having installed the latest versions of transformers==4.38.1 and datasets==2.17.1 Unable to load the dataset in a kaggle notebook.
Get this Error:
```
---------------------------------------------------------------------------
ValueError Traceback (most recen... | closed | 2024-02-27T18:19:34 | https://api.github.com/repos/huggingface/datasets/issues/6697/comments | null | false | Unable to Load Dataset in Kaggle
### Describe the bug
Having installed the latest versions of transformers==4.38.1 and datasets==2.17.1 Unable to load the dataset in a kaggle notebook.
Get this Error:
```
---------------------------------------------------------------------------
ValueError ... | [
"FWIW, I run `load_dataset(\"llm-blender/mix-instruct\")` and it ran successfully.\r\nCan you clear your cache and try again?\r\n\r\n\r\n### Environment Info\r\n\r\n- `datasets` version: 2.17.0\r\n- Platform: Linux-6.2.6-76060206-generic-x86_64-with-glibc2.35\r\n- Python version: 3.9.13\r\n- `huggingface_hub` versi... |
https://api.github.com/repos/huggingface/datasets/issues/6696 | 6,696 | Make JSON builder support an array of strings | Support JSON file with an array of strings.
Fix #6695. | closed | 2024-02-26T13:18:31 | https://api.github.com/repos/huggingface/datasets/issues/6696/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6696",
"html_url": "https://github.com/huggingface/datasets/pull/6696",
"diff_url": "https://github.com/huggingface/datasets/pull/6696.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6696.patch",
"merged_at": "2024-02-28T06:39... | true | Make JSON builder support an array of strings
Support JSON file with an array of strings.
Fix #6695. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6696). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6695 | 6,695 | Support JSON file with an array of strings | Support loading a dataset from a JSON file with an array of strings.
See: https://huggingface.co/datasets/CausalLM/Refined-Anime-Text/discussions/1 | closed | 2024-02-26T12:35:11 | https://api.github.com/repos/huggingface/datasets/issues/6695/comments | null | false | Support JSON file with an array of strings
Support loading a dataset from a JSON file with an array of strings.
See: https://huggingface.co/datasets/CausalLM/Refined-Anime-Text/discussions/1 | [
"https://huggingface.co/datasets/CausalLM/Refined-Anime-Text/discussions/1 has been fixed, but how can we check if there are other datasets with the same error, in datasets-server's database? I don't know how to get the list of erroneous cache entries, since we only copied `Error code: JobManagerCrashedError`, bu... |
https://api.github.com/repos/huggingface/datasets/issues/6694 | 6,694 | __add__ for Dataset, IterableDataset | It's too cumbersome to write this command every time we perform a dataset merging operation. ```pythonfrom datasets import concatenate_datasets``` We have added a simple `__add__` magic method to each class using `concatenate_datasets.`
```python
from datasets import load_dataset
bookcorpus = load_dataset("bookc... | open | 2024-02-26T01:46:55 | https://api.github.com/repos/huggingface/datasets/issues/6694/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6694",
"html_url": "https://github.com/huggingface/datasets/pull/6694",
"diff_url": "https://github.com/huggingface/datasets/pull/6694.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6694.patch",
"merged_at": null
} | true | __add__ for Dataset, IterableDataset
It's too cumbersome to write this command every time we perform a dataset merging operation. ```pythonfrom datasets import concatenate_datasets``` We have added a simple `__add__` magic method to each class using `concatenate_datasets.`
```python
from datasets import load_datase... | [
"Hi! You can find a reason why we are against this feature in https://github.com/huggingface/datasets/issues/3449. \r\n\r\n> It's too cumbersome to write this command every time we perform a dataset merging operation\r\n\r\nExplicit is better than implicit, so this isn't a good enough reason. \r\n\r\nThanks for the... |
https://api.github.com/repos/huggingface/datasets/issues/6693 | 6,693 | Update the print message for chunked_dataset in process.mdx | Update documentation to align with `Dataset.__repr__` change after #423 | closed | 2024-02-25T18:37:07 | https://api.github.com/repos/huggingface/datasets/issues/6693/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6693",
"html_url": "https://github.com/huggingface/datasets/pull/6693",
"diff_url": "https://github.com/huggingface/datasets/pull/6693.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6693.patch",
"merged_at": "2024-02-25T19:51... | true | Update the print message for chunked_dataset in process.mdx
Update documentation to align with `Dataset.__repr__` change after #423 | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6693). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6692 | 6,692 | Enhancement: Enable loading TSV files in load_dataset() | Fix #6691 | closed | 2024-02-24T11:38:59 | https://api.github.com/repos/huggingface/datasets/issues/6692/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6692",
"html_url": "https://github.com/huggingface/datasets/pull/6692",
"diff_url": "https://github.com/huggingface/datasets/pull/6692.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6692.patch",
"merged_at": null
} | true | Enhancement: Enable loading TSV files in load_dataset()
Fix #6691 | [
"Hi @harsh1504660,\r\n\r\nThanks for your work, but this functionality already exists. See my comment in the corresponding issue: https://github.com/huggingface/datasets/issues/6691#issuecomment-1963449923\r\n\r\nNext time you would like to contribute, I would suggest you take on an issue that is previously validat... |
https://api.github.com/repos/huggingface/datasets/issues/6691 | 6,691 | load_dataset() does not support tsv | ### Feature request
the load_dataset() for local functions support file types like csv, json etc but not of type tsv (tab separated values).
### Motivation
cant easily load files of type tsv, have to convert them to another type like csv then load
### Your contribution
Can try by raising a PR with a little help, c... | closed | 2024-02-24T05:56:04 | https://api.github.com/repos/huggingface/datasets/issues/6691/comments | null | false | load_dataset() does not support tsv
### Feature request
the load_dataset() for local functions support file types like csv, json etc but not of type tsv (tab separated values).
### Motivation
cant easily load files of type tsv, have to convert them to another type like csv then load
### Your contribution
Can try b... | [
"#self-assign",
"Hi @dipsivenkatesh,\r\n\r\nPlease note that this functionality is already implemented. Our CSV builder uses `pandas.read_csv` under the hood, and you can pass the parameter `delimiter=\"\\t\"` to read TSV files.\r\n\r\nSee the list of CSV config parameters in our docs: https://huggingface.co/docs... |
https://api.github.com/repos/huggingface/datasets/issues/6690 | 6,690 | Add function to convert a script-dataset to Parquet | Add function to convert a script-dataset to Parquet and push it to the Hub, analogously to the Space: "Convert a Hugging Face dataset to Parquet" | closed | 2024-02-23T10:28:20 | https://api.github.com/repos/huggingface/datasets/issues/6690/comments | null | false | Add function to convert a script-dataset to Parquet
Add function to convert a script-dataset to Parquet and push it to the Hub, analogously to the Space: "Convert a Hugging Face dataset to Parquet" | [] |
https://api.github.com/repos/huggingface/datasets/issues/6689 | 6,689 | .load_dataset() method defaults to zstandard | ### Describe the bug
Regardless of what method I use, datasets defaults to zstandard for unpacking my datasets.
This is poor behavior, because not only is zstandard not a dependency in the huggingface package (and therefore, your dataset loading will be interrupted while it asks you to install the package), but it ... | closed | 2024-02-22T17:39:27 | https://api.github.com/repos/huggingface/datasets/issues/6689/comments | null | false | .load_dataset() method defaults to zstandard
### Describe the bug
Regardless of what method I use, datasets defaults to zstandard for unpacking my datasets.
This is poor behavior, because not only is zstandard not a dependency in the huggingface package (and therefore, your dataset loading will be interrupted while... | [
"The dataset is made of JSON files compressed using zstandard, as you can see here: https://huggingface.co/datasets/cerebras/SlimPajama-627B/tree/main/test/chunk1\r\n\r\nThat's why it asks for zstandard to be installed.\r\n\r\nThough I'm intrigued that you manage to load the dataset without zstandard installed. May... |
https://api.github.com/repos/huggingface/datasets/issues/6688 | 6,688 | Tensor type (e.g. from `return_tensors`) ignored in map | ### Describe the bug
I don't know if it is a bug or an expected behavior, but the tensor type seems to be ignored after applying map. For example, mapping over to tokenize text with a transformers' tokenizer always returns lists and it ignore the `return_tensors` argument.
If this is an expected behaviour (e.g., fo... | open | 2024-02-22T09:27:57 | https://api.github.com/repos/huggingface/datasets/issues/6688/comments | null | false | Tensor type (e.g. from `return_tensors`) ignored in map
### Describe the bug
I don't know if it is a bug or an expected behavior, but the tensor type seems to be ignored after applying map. For example, mapping over to tokenize text with a transformers' tokenizer always returns lists and it ignore the `return_tensors`... | [
"Hi, this is expected behavior since all the tensors are converted to Arrow data (the storage type behind a Dataset).\r\n\r\nTo get pytorch tensors back, you can set the dataset format to \"torch\":\r\n\r\n```python\r\nds = ds.with_format(\"torch\")\r\n```",
"Thanks. Just one additional question. During the pipel... |
https://api.github.com/repos/huggingface/datasets/issues/6687 | 6,687 | fsspec: support fsspec>=2023.12.0 glob changes | - adds support for the `fs.glob` changes introduced in `fsspec==2023.12.0` and unpins the current upper bound
Should close #6644
Should close #6645
The `test_data_files` glob/pattern tests pass for me in:
- `fsspec==2023.10.0` (the pinned max version in datasets `main`)
- `fsspec==2023.12.0` (#6644)
- `fsspec... | closed | 2024-02-22T08:59:32 | https://api.github.com/repos/huggingface/datasets/issues/6687/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6687",
"html_url": "https://github.com/huggingface/datasets/pull/6687",
"diff_url": "https://github.com/huggingface/datasets/pull/6687.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6687.patch",
"merged_at": "2024-02-29T15:12... | true | fsspec: support fsspec>=2023.12.0 glob changes
- adds support for the `fs.glob` changes introduced in `fsspec==2023.12.0` and unpins the current upper bound
Should close #6644
Should close #6645
The `test_data_files` glob/pattern tests pass for me in:
- `fsspec==2023.10.0` (the pinned max version in datasets `m... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6687). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Looking into the CI failure, this PR is incompatible with `huggingface-hub>=0.20.0`. It... |
https://api.github.com/repos/huggingface/datasets/issues/6686 | 6,686 | Question: Is there any way for uploading a large image dataset? | I am uploading an image dataset like this:
```
dataset = load_dataset(
"json",
data_files={"train": "data/custom_dataset/train.json", "validation": "data/custom_dataset/val.json"},
)
dataset = dataset.cast_column("images", Sequence(Image()))
dataset.push_to_hub("StanfordAIMI/custom_dataset", max_shard_si... | open | 2024-02-21T22:07:21 | https://api.github.com/repos/huggingface/datasets/issues/6686/comments | null | false | Question: Is there any way for uploading a large image dataset?
I am uploading an image dataset like this:
```
dataset = load_dataset(
"json",
data_files={"train": "data/custom_dataset/train.json", "validation": "data/custom_dataset/val.json"},
)
dataset = dataset.cast_column("images", Sequence(Image()))
... | [
"```\r\nimport pandas as pd\r\nfrom datasets import Dataset, Image\r\n\r\n# Read the CSV file\r\ndata = pd.read_csv(\"XXXX.csv\")\r\n\r\n# Create a Hugging Face Dataset\r\ndataset = Dataset.from_pandas(data)\r\ndataset = dataset.cast_column(\"file_name\", Image())\r\n\r\n# Upload to Hugging Face Hub (make sure auth... |
https://api.github.com/repos/huggingface/datasets/issues/6685 | 6,685 | Updated Quickstart Notebook link | Fixed Quickstart Notebook Link in the [Overview notebook](https://github.com/huggingface/datasets/blob/main/notebooks/Overview.ipynb) | closed | 2024-02-21T01:04:18 | https://api.github.com/repos/huggingface/datasets/issues/6685/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6685",
"html_url": "https://github.com/huggingface/datasets/pull/6685",
"diff_url": "https://github.com/huggingface/datasets/pull/6685.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6685.patch",
"merged_at": "2024-02-25T18:48... | true | Updated Quickstart Notebook link
Fixed Quickstart Notebook Link in the [Overview notebook](https://github.com/huggingface/datasets/blob/main/notebooks/Overview.ipynb) | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6685). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6684 | 6,684 | Improve error message for gated datasets on load | Internal Slack discussion: https://huggingface.slack.com/archives/C02V51Q3800/p1708424971135029 | closed | 2024-02-20T10:51:27 | https://api.github.com/repos/huggingface/datasets/issues/6684/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6684",
"html_url": "https://github.com/huggingface/datasets/pull/6684",
"diff_url": "https://github.com/huggingface/datasets/pull/6684.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6684.patch",
"merged_at": "2024-02-20T15:33... | true | Improve error message for gated datasets on load
Internal Slack discussion: https://huggingface.slack.com/archives/C02V51Q3800/p1708424971135029 | [
"Thank you ! Should we also add the link to the dataset page ?",
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6684). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"> Thank you ! Should... |
https://api.github.com/repos/huggingface/datasets/issues/6683 | 6,683 | Fix imagefolder dataset url | null | closed | 2024-02-19T16:26:51 | https://api.github.com/repos/huggingface/datasets/issues/6683/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6683",
"html_url": "https://github.com/huggingface/datasets/pull/6683",
"diff_url": "https://github.com/huggingface/datasets/pull/6683.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6683.patch",
"merged_at": "2024-02-19T17:18... | true | Fix imagefolder dataset url
| [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6683). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6682 | 6,682 | Update GitHub Actions to Node 20 | Update GitHub Actions to Node 20.
Fix #6679. | closed | 2024-02-19T10:10:50 | https://api.github.com/repos/huggingface/datasets/issues/6682/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6682",
"html_url": "https://github.com/huggingface/datasets/pull/6682",
"diff_url": "https://github.com/huggingface/datasets/pull/6682.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6682.patch",
"merged_at": "2024-02-28T06:56... | true | Update GitHub Actions to Node 20
Update GitHub Actions to Node 20.
Fix #6679. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6682). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6681 | 6,681 | Update release instructions | Update release instructions. | closed | 2024-02-19T10:03:08 | https://api.github.com/repos/huggingface/datasets/issues/6681/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6681",
"html_url": "https://github.com/huggingface/datasets/pull/6681",
"diff_url": "https://github.com/huggingface/datasets/pull/6681.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6681.patch",
"merged_at": "2024-02-28T07:17... | true | Update release instructions
Update release instructions. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6681). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6680 | 6,680 | Set dev version | null | closed | 2024-02-19T10:00:31 | https://api.github.com/repos/huggingface/datasets/issues/6680/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6680",
"html_url": "https://github.com/huggingface/datasets/pull/6680",
"diff_url": "https://github.com/huggingface/datasets/pull/6680.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6680.patch",
"merged_at": "2024-02-19T10:00... | true | Set dev version
| [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6680). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6679 | 6,679 | Node.js 16 GitHub Actions are deprecated | `Node.js` 16 GitHub Actions are deprecated. See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
We should update them to Node 20.
See warnings in our CI, e.g.: https://github.com/huggingface/datasets/actions/runs/7957295009?pr=6678
> Node.js 16 actions are deprecat... | closed | 2024-02-19T09:47:37 | https://api.github.com/repos/huggingface/datasets/issues/6679/comments | null | false | Node.js 16 GitHub Actions are deprecated
`Node.js` 16 GitHub Actions are deprecated. See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
We should update them to Node 20.
See warnings in our CI, e.g.: https://github.com/huggingface/datasets/actions/runs/7957295009?p... | [] |
https://api.github.com/repos/huggingface/datasets/issues/6678 | 6,678 | Release: 2.17.1 | null | closed | 2024-02-19T09:24:29 | https://api.github.com/repos/huggingface/datasets/issues/6678/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6678",
"html_url": "https://github.com/huggingface/datasets/pull/6678",
"diff_url": "https://github.com/huggingface/datasets/pull/6678.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6678.patch",
"merged_at": "2024-02-19T09:56... | true | Release: 2.17.1
| [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6678). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6677 | 6,677 | Pass through information about location of cache directory. | If cache directory is set, information is not passed through.
Pass download config in as an arg too. | closed | 2024-02-18T23:48:57 | https://api.github.com/repos/huggingface/datasets/issues/6677/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6677",
"html_url": "https://github.com/huggingface/datasets/pull/6677",
"diff_url": "https://github.com/huggingface/datasets/pull/6677.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6677.patch",
"merged_at": "2024-02-28T18:51... | true | Pass through information about location of cache directory.
If cache directory is set, information is not passed through.
Pass download config in as an arg too. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6677). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6676 | 6,676 | Can't Read List of JSON Files Properly | ### Describe the bug
Trying to read a bunch of JSON files into Dataset class but default approach doesn't work. I don't get why it works when I read it one by one but not when I pass as a list :man_shrugging:
The code fails with
```
ArrowInvalid: JSON parse error: Invalid value. in row 0
UnicodeDecodeError... | open | 2024-02-17T22:58:15 | https://api.github.com/repos/huggingface/datasets/issues/6676/comments | null | false | Can't Read List of JSON Files Properly
### Describe the bug
Trying to read a bunch of JSON files into Dataset class but default approach doesn't work. I don't get why it works when I read it one by one but not when I pass as a list :man_shrugging:
The code fails with
```
ArrowInvalid: JSON parse error: Invali... | [
"Found the issue, if there are other files in the directory, it gets caught into this `*` so essentially it should be `*.json`. Could we possibly to check for list of files to make sure the pattern matches json files and raise error if not?",
"I don't think we should filter for `*.json` as this might silently rem... |
https://api.github.com/repos/huggingface/datasets/issues/6675 | 6,675 | Allow image model (color conversion) to be specified as part of datasets Image() decode | ### Feature request
Typical torchvision / torch Datasets in image applications apply color conversion in the Dataset portion of the code as part of image decode, separately from the image transform stack. This is true for PIL.Image where convert is usually called in dataset, for native torchvision https://pytorch.or... | closed | 2024-02-16T23:43:20 | https://api.github.com/repos/huggingface/datasets/issues/6675/comments | null | false | Allow image model (color conversion) to be specified as part of datasets Image() decode
### Feature request
Typical torchvision / torch Datasets in image applications apply color conversion in the Dataset portion of the code as part of image decode, separately from the image transform stack. This is true for PIL.Ima... | [
"It would be a great addition indeed :)\r\n\r\nThis can be implemented the same way we have `sampling_rate` for Audio(): we just add a new parameter to the Image() type and take this parameter into account in `Image.decode_example`\r\n\r\nEDIT: adding an example of how it can be used:\r\n\r\n```python\r\nds = ds.ca... |
https://api.github.com/repos/huggingface/datasets/issues/6674 | 6,674 | Depprcated Overview.ipynb Link to new Quickstart Notebook invalid | ### Describe the bug
For the dreprecated notebook found [here](https://github.com/huggingface/datasets/blob/main/notebooks/Overview.ipynb). The link to the new notebook is broken.
### Steps to reproduce the bug
Click the [Quickstart notebook](https://github.com/huggingface/notebooks/blob/main/datasets_doc/quicksta... | closed | 2024-02-16T22:51:35 | https://api.github.com/repos/huggingface/datasets/issues/6674/comments | null | false | Depprcated Overview.ipynb Link to new Quickstart Notebook invalid
### Describe the bug
For the dreprecated notebook found [here](https://github.com/huggingface/datasets/blob/main/notebooks/Overview.ipynb). The link to the new notebook is broken.
### Steps to reproduce the bug
Click the [Quickstart notebook](https... | [
"Good catch! Feel free to open a PR to fix the link."
] |
https://api.github.com/repos/huggingface/datasets/issues/6673 | 6,673 | IterableDataset `set_epoch` is ignored when DataLoader `persistent_workers=True` | ### Describe the bug
When persistent workers are enabled, the epoch that's set via the IterableDataset instance held by the training process is ignored by the workers as they are disconnected across processes.
PyTorch samplers for non-iterable datasets have a mechanism to sync this, datasets.IterableDataset does ... | closed | 2024-02-16T21:38:12 | https://api.github.com/repos/huggingface/datasets/issues/6673/comments | null | false | IterableDataset `set_epoch` is ignored when DataLoader `persistent_workers=True`
### Describe the bug
When persistent workers are enabled, the epoch that's set via the IterableDataset instance held by the training process is ignored by the workers as they are disconnected across processes.
PyTorch samplers for no... | [] |
https://api.github.com/repos/huggingface/datasets/issues/6672 | 6,672 | Remove deprecated verbose parameter from CSV builder | Remove deprecated `verbose` parameter from CSV builder.
Note that the `verbose` parameter is deprecated since pandas 2.2.0. See:
- https://github.com/pandas-dev/pandas/pull/56556
- https://github.com/pandas-dev/pandas/pull/57450
Fix #6671. | closed | 2024-02-16T14:26:21 | https://api.github.com/repos/huggingface/datasets/issues/6672/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6672",
"html_url": "https://github.com/huggingface/datasets/pull/6672",
"diff_url": "https://github.com/huggingface/datasets/pull/6672.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6672.patch",
"merged_at": "2024-02-19T09:20... | true | Remove deprecated verbose parameter from CSV builder
Remove deprecated `verbose` parameter from CSV builder.
Note that the `verbose` parameter is deprecated since pandas 2.2.0. See:
- https://github.com/pandas-dev/pandas/pull/56556
- https://github.com/pandas-dev/pandas/pull/57450
Fix #6671. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6672). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"I am merging this PR (so that it is included in the next patch release) to remove the d... |
https://api.github.com/repos/huggingface/datasets/issues/6671 | 6,671 | CSV builder raises deprecation warning on verbose parameter | CSV builder raises a deprecation warning on `verbose` parameter:
```
FutureWarning: The 'verbose' keyword in pd.read_csv is deprecated and will be removed in a future version.
```
See:
- https://github.com/pandas-dev/pandas/pull/56556
- https://github.com/pandas-dev/pandas/pull/57450 | closed | 2024-02-16T14:23:46 | https://api.github.com/repos/huggingface/datasets/issues/6671/comments | null | false | CSV builder raises deprecation warning on verbose parameter
CSV builder raises a deprecation warning on `verbose` parameter:
```
FutureWarning: The 'verbose' keyword in pd.read_csv is deprecated and will be removed in a future version.
```
See:
- https://github.com/pandas-dev/pandas/pull/56556
- https://github.... | [] |
https://api.github.com/repos/huggingface/datasets/issues/6670 | 6,670 | ValueError | ### Describe the bug
ValueError Traceback (most recent call last)
[<ipython-input-11-9b99bc80ec23>](https://localhost:8080/#) in <cell line: 11>()
9 import numpy as np
10 import matplotlib.pyplot as plt
---> 11 from datasets import DatasetDict, Dataset
12 from transf... | closed | 2024-02-16T11:05:17 | https://api.github.com/repos/huggingface/datasets/issues/6670/comments | null | false | ValueError
### Describe the bug
ValueError Traceback (most recent call last)
[<ipython-input-11-9b99bc80ec23>](https://localhost:8080/#) in <cell line: 11>()
9 import numpy as np
10 import matplotlib.pyplot as plt
---> 11 from datasets import DatasetDict, Dataset
12 ... | [
"Hi @prashanth19bolukonda,\r\n\r\nYou have to restart the notebook runtime session after the installation of `datasets`.\r\n\r\nDuplicate of:\r\n- #5923",
"Thank you soo much\r\n\r\nOn Fri, Feb 16, 2024 at 8:14 PM Albert Villanova del Moral <\r\n***@***.***> wrote:\r\n\r\n> Closed #6670 <https://github.com/huggin... |
https://api.github.com/repos/huggingface/datasets/issues/6669 | 6,669 | attribute error when writing trainer.train() | ### Describe the bug
AttributeError Traceback (most recent call last)
Cell In[39], line 2
1 # Start the training process
----> 2 trainer.train()
File /opt/conda/lib/python3.10/site-packages/transformers/trainer.py:1539, in Trainer.train(self, resume_from_checkpoint, trial, ignore... | closed | 2024-02-16T10:40:49 | https://api.github.com/repos/huggingface/datasets/issues/6669/comments | null | false | attribute error when writing trainer.train()
### Describe the bug
AttributeError Traceback (most recent call last)
Cell In[39], line 2
1 # Start the training process
----> 2 trainer.train()
File /opt/conda/lib/python3.10/site-packages/transformers/trainer.py:1539, in Trainer.trai... | [
"Hi! Kaggle notebooks use an outdated version of `datasets`, so you should update the `datasets` installation (with `!pip install -U datasets`) to avoid the error.",
"Thank you for your response\r\n\r\nOn Thu, Feb 29, 2024 at 10:55 PM Mario Šaško ***@***.***>\r\nwrote:\r\n\r\n> Closed #6669 <https://github.com/hu... |
https://api.github.com/repos/huggingface/datasets/issues/6668 | 6,668 | Chapter 6 - Issue Loading `cnn_dailymail` dataset | ### Describe the bug
So I am getting this bug when I try to run cell 4 of the Chapter 6 notebook code:
`dataset = load_dataset("ccdv/cnn_dailymail", version="3.0.0")`
Error Message:
```
---------------------------------------------------------------------------
ValueError Tracebac... | open | 2024-02-16T04:40:56 | https://api.github.com/repos/huggingface/datasets/issues/6668/comments | null | false | Chapter 6 - Issue Loading `cnn_dailymail` dataset
### Describe the bug
So I am getting this bug when I try to run cell 4 of the Chapter 6 notebook code:
`dataset = load_dataset("ccdv/cnn_dailymail", version="3.0.0")`
Error Message:
```
---------------------------------------------------------------------------
... | [
"Here's a snippet that works with the current `datasets`:\n\n```python\ndataset = load_dataset(\"cnn_dailymail\", \"3.0.0\")\n```\n\n(Drop the `version=` part.)"
] |
https://api.github.com/repos/huggingface/datasets/issues/6667 | 6,667 | Default config for squad is incorrect | ### Describe the bug
If you download Squad, it will download the plain_text version, but the config still specifies "default", so if you set the offline mode the cache will try to look it up according to the config_id which is "default" and this will say;
ValueError: Couldn't find cache for squad for config 'default'... | open | 2024-02-16T02:36:55 | https://api.github.com/repos/huggingface/datasets/issues/6667/comments | null | false | Default config for squad is incorrect
### Describe the bug
If you download Squad, it will download the plain_text version, but the config still specifies "default", so if you set the offline mode the cache will try to look it up according to the config_id which is "default" and this will say;
ValueError: Couldn't fin... | [
"you can try: pip install datasets==2.16.1"
] |
https://api.github.com/repos/huggingface/datasets/issues/6665 | 6,665 | Allow SplitDict setitem to replace existing SplitInfo | Fix this code provided by @clefourrier
```python
import datasets
import os
token = os.getenv("TOKEN")
results = datasets.load_dataset("gaia-benchmark/results_public", "2023", token=token, download_mode=datasets.DownloadMode.FORCE_REDOWNLOAD)
results["test"] = datasets.Dataset.from_list([row for row in resu... | closed | 2024-02-15T10:17:08 | https://api.github.com/repos/huggingface/datasets/issues/6665/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6665",
"html_url": "https://github.com/huggingface/datasets/pull/6665",
"diff_url": "https://github.com/huggingface/datasets/pull/6665.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6665.patch",
"merged_at": "2024-03-01T15:56... | true | Allow SplitDict setitem to replace existing SplitInfo
Fix this code provided by @clefourrier
```python
import datasets
import os
token = os.getenv("TOKEN")
results = datasets.load_dataset("gaia-benchmark/results_public", "2023", token=token, download_mode=datasets.DownloadMode.FORCE_REDOWNLOAD)
results["te... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6665). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6664 | 6,664 | Revert the changes in `arrow_writer.py` from #6636 | #6636 broke `write_examples_on_file` and `write_batch` from the class `ArrowWriter`. I'm undoing these changes. See #6663.
Note the current implementation doesn't keep the order of the columns and the schema, thus setting a wrong schema for each column. | closed | 2024-02-15T01:47:33 | https://api.github.com/repos/huggingface/datasets/issues/6664/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6664",
"html_url": "https://github.com/huggingface/datasets/pull/6664",
"diff_url": "https://github.com/huggingface/datasets/pull/6664.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6664.patch",
"merged_at": "2024-02-16T02:31... | true | Revert the changes in `arrow_writer.py` from #6636
#6636 broke `write_examples_on_file` and `write_batch` from the class `ArrowWriter`. I'm undoing these changes. See #6663.
Note the current implementation doesn't keep the order of the columns and the schema, thus setting a wrong schema for each column. | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6664). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"> Hi! We can't revert this as the \"reverted\" implementation has quadratic time comple... |
https://api.github.com/repos/huggingface/datasets/issues/6663 | 6,663 | `write_examples_on_file` and `write_batch` are broken in `ArrowWriter` | ### Describe the bug
`write_examples_on_file` and `write_batch` are broken in `ArrowWriter` since #6636. The order between the columns and the schema is not preserved anymore. So these functions don't work anymore unless the order happens to align well.
### Steps to reproduce the bug
Try to do `write_batch` with any... | closed | 2024-02-15T01:43:27 | https://api.github.com/repos/huggingface/datasets/issues/6663/comments | null | false | `write_examples_on_file` and `write_batch` are broken in `ArrowWriter`
### Describe the bug
`write_examples_on_file` and `write_batch` are broken in `ArrowWriter` since #6636. The order between the columns and the schema is not preserved anymore. So these functions don't work anymore unless the order happens to align ... | [
"Thanks for reporting! I've left some comments on the PR on how to fix this recent change rather than reverting it.",
"> Thanks for reporting! I've left some comments on the PR on how to fix this recent change rather than reverting it.\r\n\r\nI feel that'd be good, but it'd be great to release a hotfix ASAP (a re... |
https://api.github.com/repos/huggingface/datasets/issues/6662 | 6,662 | fix: show correct package name to install biopython | When you try to download a dataset that uses [biopython](https://github.com/biopython/biopython), like `load_dataset("InstaDeepAI/multi_species_genomes")`, you get the error:
```
>>> from datasets import load_dataset
>>> dataset = load_dataset("InstaDeepAI/multi_species_genomes")
/home/j.vangoey/.pyenv/versions/m... | closed | 2024-02-13T14:15:04 | https://api.github.com/repos/huggingface/datasets/issues/6662/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6662",
"html_url": "https://github.com/huggingface/datasets/pull/6662",
"diff_url": "https://github.com/huggingface/datasets/pull/6662.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6662.patch",
"merged_at": "2024-03-01T17:43... | true | fix: show correct package name to install biopython
When you try to download a dataset that uses [biopython](https://github.com/biopython/biopython), like `load_dataset("InstaDeepAI/multi_species_genomes")`, you get the error:
```
>>> from datasets import load_dataset
>>> dataset = load_dataset("InstaDeepAI/multi_... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6662). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6661 | 6,661 | Import error on Google Colab | ### Describe the bug
Cannot be imported on Google Colab, the import throws the following error:
ValueError: pyarrow.lib.IpcWriteOptions size changed, may indicate binary incompatibility. Expected 88 from C header, got 72 from PyObject
### Steps to reproduce the bug
1. `! pip install -U datasets`
2. `import dataset... | closed | 2024-02-13T13:12:40 | https://api.github.com/repos/huggingface/datasets/issues/6661/comments | null | false | Import error on Google Colab
### Describe the bug
Cannot be imported on Google Colab, the import throws the following error:
ValueError: pyarrow.lib.IpcWriteOptions size changed, may indicate binary incompatibility. Expected 88 from C header, got 72 from PyObject
### Steps to reproduce the bug
1. `! pip install -U ... | [
"Hi! This can happen if an incompatible `pyarrow` version (`pyarrow<12.0.0`) has been imported before the `datasets` installation and the Colab session hasn't been restarted afterward. To avoid the error, go to \"Runtime -> Restart session\" after `!pip install -U datasets` and before `import datasets`, or insert t... |
https://api.github.com/repos/huggingface/datasets/issues/6660 | 6,660 | Automatic Conversion for uint16/uint32 to Compatible PyTorch Dtypes | This PR addresses an issue encountered when utilizing uint16 or uint32 datatypes with datasets, followed by attempting to convert these datasets into PyTorch-compatible formats. Currently, doing so results in a TypeError due to incompatible datatype conversion, as illustrated by the following example:
```python
from ... | closed | 2024-02-13T10:24:33 | https://api.github.com/repos/huggingface/datasets/issues/6660/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6660",
"html_url": "https://github.com/huggingface/datasets/pull/6660",
"diff_url": "https://github.com/huggingface/datasets/pull/6660.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6660.patch",
"merged_at": "2024-03-01T18:52... | true | Automatic Conversion for uint16/uint32 to Compatible PyTorch Dtypes
This PR addresses an issue encountered when utilizing uint16 or uint32 datatypes with datasets, followed by attempting to convert these datasets into PyTorch-compatible formats. Currently, doing so results in a TypeError due to incompatible datatype co... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6660). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>... |
https://api.github.com/repos/huggingface/datasets/issues/6659 | 6,659 | Change default compression argument for JsonDatasetWriter | Change default compression type from `None` to "infer", to align with pandas' defaults.
Documentation asks the user to supply `to_json_kwargs` with arguments suitable for pandas' `to_json` method. At the same time, while pandas' by default uses ["infer"](https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.... | closed | 2024-02-11T23:49:07 | https://api.github.com/repos/huggingface/datasets/issues/6659/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6659",
"html_url": "https://github.com/huggingface/datasets/pull/6659",
"diff_url": "https://github.com/huggingface/datasets/pull/6659.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6659.patch",
"merged_at": "2024-03-01T17:44... | true | Change default compression argument for JsonDatasetWriter
Change default compression type from `None` to "infer", to align with pandas' defaults.
Documentation asks the user to supply `to_json_kwargs` with arguments suitable for pandas' `to_json` method. At the same time, while pandas' by default uses ["infer"](http... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6659). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"Can someone check this out?",
"<details>\n<summary>Show benchmarks</summary>\n\nPyArr... |
https://api.github.com/repos/huggingface/datasets/issues/6658 | 6,658 | [Resumable IterableDataset] Add IterableDataset state_dict | A simple implementation of a mechanism to resume an IterableDataset.
It works by restarting at the latest shard and skip samples. It provides fast resuming (though not instantaneous).
Example:
```python
from datasets import Dataset, concatenate_datasets
ds = Dataset.from_dict({"a": range(5)}).to_iterable_d... | closed | 2024-02-11T20:35:52 | https://api.github.com/repos/huggingface/datasets/issues/6658/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/6658",
"html_url": "https://github.com/huggingface/datasets/pull/6658",
"diff_url": "https://github.com/huggingface/datasets/pull/6658.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/6658.patch",
"merged_at": "2024-06-03T19:15... | true | [Resumable IterableDataset] Add IterableDataset state_dict
A simple implementation of a mechanism to resume an IterableDataset.
It works by restarting at the latest shard and skip samples. It provides fast resuming (though not instantaneous).
Example:
```python
from datasets import Dataset, concatenate_datasets... | [
"The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_6658). All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.",
"would be nice to have this feature in the new dataset release!",
"Before finalising t... |
https://api.github.com/repos/huggingface/datasets/issues/6657 | 6,657 | Release not pushed to conda channel | ### Describe the bug
The github actions step to publish the release 2.17.0 to conda channel has failed due to expired token. Can some one please update the anaconda token rerun the failed action? @albertvillanova ?
![image](https://github.com/huggingface/datasets/assets/7138162/1b56ad3d-7643-4778-9cce-4bf531717700... | closed | 2024-02-11T20:05:17 | https://api.github.com/repos/huggingface/datasets/issues/6657/comments | null | false | Release not pushed to conda channel
### Describe the bug
The github actions step to publish the release 2.17.0 to conda channel has failed due to expired token. Can some one please update the anaconda token rerun the failed action? @albertvillanova ?
![image](https://github.com/huggingface/datasets/assets/7138162/... | [
"Thanks for reporting, @atulsaurav.\r\n\r\nWe are investigating the issue. ",
"I can't fix this issue because I do not appear as a team member of the huggingface datasets project: https://anaconda.org/huggingface/datasets\r\n\r\n@lhoestq could you please add `datasets` team members to the corresponding Anaconda p... |
https://api.github.com/repos/huggingface/datasets/issues/6656 | 6,656 | Error when loading a big local json file | ### Describe the bug
When trying to load big json files from a local directory, `load_dataset` throws the following error
```
Traceback (most recent call last):
File "/miniconda3/envs/conda-env/lib/python3.10/site-packages/datasets/builder.py", line 1989, in _prepare_split_single
writer.write_table(table)
... | open | 2024-02-09T15:14:21 | https://api.github.com/repos/huggingface/datasets/issues/6656/comments | null | false | Error when loading a big local json file
### Describe the bug
When trying to load big json files from a local directory, `load_dataset` throws the following error
```
Traceback (most recent call last):
File "/miniconda3/envs/conda-env/lib/python3.10/site-packages/datasets/builder.py", line 1989, in _prepare_spl... | [
"I get similar when dealing with a large jsonl file (6k lines), \r\n\r\n> TypeError: Couldn't cast array of type timestamp[us] to null\r\n\r\nYet when I split it into 1k lines, files, load_dataset works fine!\r\n\r\nhttps://github.com/huggingface/course/issues/692\r\n\r\n",
"What's the proposed solution? :-)"
] |
https://api.github.com/repos/huggingface/datasets/issues/6655 | 6,655 | Cannot load the dataset go_emotions | ### Describe the bug
When I run the following code I get an exception;
`go_emotions = load_dataset("go_emotions")`
> AttributeError Traceback (most recent call last)
Cell In[6], [line 1](vscode-notebook-cell:?execution_count=6&line=1)
----> [1](vscode-notebook-cell:?execution_count=6&l... | open | 2024-02-09T12:15:39 | https://api.github.com/repos/huggingface/datasets/issues/6655/comments | null | false | Cannot load the dataset go_emotions
### Describe the bug
When I run the following code I get an exception;
`go_emotions = load_dataset("go_emotions")`
> AttributeError Traceback (most recent call last)
Cell In[6], [line 1](vscode-notebook-cell:?execution_count=6&line=1)
----> [1](vscod... | [
"Thanks for reporting, @arame.\r\n\r\nI guess you have an old version of `transformers` (that submodule is present in `transformers` since version 3.0.1, since nearly 4 years ago). If you update it, the error should disappear:\r\n```shell\r\npip install -U transformers\r\n```\r\n\r\nOn the other hand, I am wonderin... |
https://api.github.com/repos/huggingface/datasets/issues/6654 | 6,654 | Batched dataset map throws exception that cannot cast fixed length array to Sequence | ### Describe the bug
I encountered a TypeError when batch processing a dataset with Sequence features in datasets package version 2.16.1. The error arises from a mismatch in handling fixed-size list arrays during the map function execution. Debugging pinpoints the issue to an if-statement in datasets/table.py, line 20... | closed | 2024-02-09T11:23:19 | https://api.github.com/repos/huggingface/datasets/issues/6654/comments | null | false | Batched dataset map throws exception that cannot cast fixed length array to Sequence
### Describe the bug
I encountered a TypeError when batch processing a dataset with Sequence features in datasets package version 2.16.1. The error arises from a mismatch in handling fixed-size list arrays during the map function exec... | [
"Hi ! This issue has been fixed by https://github.com/huggingface/datasets/pull/6283\r\n\r\nCan you try again with the new release 2.17.0 ?\r\n\r\n```\r\npip install -U datasets\r\n```\r\n\r\n",
"Amazing! It's indeed fixed now. Thanks!"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.