url stringlengths 58 61 | number int64 1 8.23k | title stringlengths 1 290 | body stringlengths 0 228k ⌀ | state stringclasses 2
values | created_at timestamp[s]date 2020-04-14 10:18:02 2026-05-30 09:38:59 | comments_url stringlengths 67 70 | pull_request dict | is_pull_request bool 2
classes | text stringlengths 2 228k | comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/datasets/issues/3270 | 3,270 | Add os.listdir for streaming | Extend `os.listdir` to support streaming data from remote files. This is often used to navigate in remote ZIP files for example | closed | 2021-11-15T10:14:04 | https://api.github.com/repos/huggingface/datasets/issues/3270/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3270",
"html_url": "https://github.com/huggingface/datasets/pull/3270",
"diff_url": "https://github.com/huggingface/datasets/pull/3270.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3270.patch",
"merged_at": "2021-11-15T10:27... | true | Add os.listdir for streaming
Extend `os.listdir` to support streaming data from remote files. This is often used to navigate in remote ZIP files for example | [] |
https://api.github.com/repos/huggingface/datasets/issues/3269 | 3,269 | coqa NonMatchingChecksumError | ```
>>> from datasets import load_dataset
>>> dataset = load_dataset("coqa")
Downloading: 3.82kB [00:00, 1.26MB/s] ... | closed | 2021-11-15T05:04:07 | https://api.github.com/repos/huggingface/datasets/issues/3269/comments | null | false | coqa NonMatchingChecksumError
```
>>> from datasets import load_dataset
>>> dataset = load_dataset("coqa")
Downloading: 3.82kB [00:00, 1.26MB/s] ... | [
"Hi @ZhaofengWu, thanks for reporting.\r\n\r\nUnfortunately, I'm not able to reproduce your bug:\r\n```python\r\nIn [1]: from datasets import load_dataset\r\n\r\nIn [2]: ds = load_dataset(\"coqa\")\r\nDownloading: 3.82kB [00:00, 1.91MB/s]\r\nDownloading: 1.79kB [00:00, 1.79MB/s]\r\nUsing custom data configuration d... |
https://api.github.com/repos/huggingface/datasets/issues/3268 | 3,268 | Dataset viewer issue for 'liweili/c4_200m' | ## Dataset viewer issue for '*liweili/c4_200m*'
**Link:** *[link to the dataset viewer page](https://huggingface.co/datasets/liweili/c4_200m)*
*Server Error*
```
Status code: 404
Exception: Status404Error
Message: Not found. Maybe the cache is missing, or maybe the ressource does not exist.
```
... | closed | 2021-11-14T17:18:46 | https://api.github.com/repos/huggingface/datasets/issues/3268/comments | null | false | Dataset viewer issue for 'liweili/c4_200m'
## Dataset viewer issue for '*liweili/c4_200m*'
**Link:** *[link to the dataset viewer page](https://huggingface.co/datasets/liweili/c4_200m)*
*Server Error*
```
Status code: 404
Exception: Status404Error
Message: Not found. Maybe the cache is missing, or... | [
"Hi ! I think the issue comes from this [line](https://huggingface.co/datasets/liweili/c4_200m/blob/main/c4_200m.py#L87):\r\n```python\r\npath = filepath + \"/*.tsv*\"\r\n```\r\n\r\nYou can fix this by doing this instead:\r\n```python\r\npath = os.path.join(filepath, \"/*.tsv*\")\r\n```\r\n\r\nHere is why:\r\n\r\nL... |
https://api.github.com/repos/huggingface/datasets/issues/3267 | 3,267 | Replacing .format() and % by f-strings | **Fix #3257**
Replaced _.format()_ and _%_ by f-strings in the following modules :
- [x] **tests**
- [x] **metrics**
- [x] **benchmarks**
- [x] **utils**
- [x] **templates**
Will follow in the next PR the modules left :
- [ ] **src**
Module **datasets** will not be edited as asked by @mariosasko
PS... | closed | 2021-11-13T19:12:02 | https://api.github.com/repos/huggingface/datasets/issues/3267/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3267",
"html_url": "https://github.com/huggingface/datasets/pull/3267",
"diff_url": "https://github.com/huggingface/datasets/pull/3267.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3267.patch",
"merged_at": null
} | true | Replacing .format() and % by f-strings
**Fix #3257**
Replaced _.format()_ and _%_ by f-strings in the following modules :
- [x] **tests**
- [x] **metrics**
- [x] **benchmarks**
- [x] **utils**
- [x] **templates**
Will follow in the next PR the modules left :
- [ ] **src**
Module **datasets** will not b... | [
"Hi ! It looks like most of your changes are just `black` changes. All those changes are not necessary. In particular if you want to use `black`, please use the `make style` command instead. It runs `black` with additional parameters and you shouldn't end up with that many changes\r\n\r\nFeel free to open a new PR ... |
https://api.github.com/repos/huggingface/datasets/issues/3266 | 3,266 | Fix URLs for WikiAuto Manual, jeopardy and definite_pronoun_resolution | [#3264](https://github.com/huggingface/datasets/issues/3264) | closed | 2021-11-13T15:01:34 | https://api.github.com/repos/huggingface/datasets/issues/3266/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3266",
"html_url": "https://github.com/huggingface/datasets/pull/3266",
"diff_url": "https://github.com/huggingface/datasets/pull/3266.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3266.patch",
"merged_at": "2021-12-06T11:16... | true | Fix URLs for WikiAuto Manual, jeopardy and definite_pronoun_resolution
[#3264](https://github.com/huggingface/datasets/issues/3264) | [
"There seems to be problems with datasets metadata, of which I dont have access to. I think one of the datasets is from reddit. Can anyone help?",
"Hello @LashaO , I think the errors were caused by `_DATA_FILES` in `definite_pronoun_resolution.py`. Here are details of the test error.\r\n```\r\nself = BuilderConfi... |
https://api.github.com/repos/huggingface/datasets/issues/3265 | 3,265 | Checksum error for kilt_task_wow | ## Describe the bug
Checksum failed when downloads kilt_tasks_wow. See error output for details.
## Steps to reproduce the bug
```python
import datasets
datasets.load_datasets('kilt_tasks','wow')
```
## Expected results
Download successful
## Actual results
```
Downloading and preparing dataset kilt_ta... | closed | 2021-11-13T12:04:17 | https://api.github.com/repos/huggingface/datasets/issues/3265/comments | null | false | Checksum error for kilt_task_wow
## Describe the bug
Checksum failed when downloads kilt_tasks_wow. See error output for details.
## Steps to reproduce the bug
```python
import datasets
datasets.load_datasets('kilt_tasks','wow')
```
## Expected results
Download successful
## Actual results
```
Download... | [
"Using `dataset = load_dataset(\"kilt_tasks\", \"wow\", ignore_verifications=True)` may fix it, but I do not think it is a elegant solution.",
"Hi @slyviacassell, thanks for reporting.\r\n\r\nYes, there is an issue with the checksum verification. I'm fixing it.\r\n\r\nAnd as you pointed out, in the meantime, you ... |
https://api.github.com/repos/huggingface/datasets/issues/3264 | 3,264 | Downloading URL change for WikiAuto Manual, jeopardy and definite_pronoun_resolution | ## Describe the bug
- WikiAuto Manual
The original manual datasets with the following downloading URL in this [repository](https://github.com/chaojiang06/wiki-auto) was [deleted](https://github.com/chaojiang06/wiki-auto/commit/0af9b066f2b4e02726fb8a9be49283c0ad25367f) by the author.
```
https://github.com/chaoj... | closed | 2021-11-13T11:47:12 | https://api.github.com/repos/huggingface/datasets/issues/3264/comments | null | false | Downloading URL change for WikiAuto Manual, jeopardy and definite_pronoun_resolution
## Describe the bug
- WikiAuto Manual
The original manual datasets with the following downloading URL in this [repository](https://github.com/chaojiang06/wiki-auto) was [deleted](https://github.com/chaojiang06/wiki-auto/commit/0af9... | [
"#take\r\nI am willing to fix this. Links can be replaced for WikiAuto Manual and jeopardy with new ones provided by authors.\r\n\r\nAs for the definite_pronoun_resolution URL, a certificate error seems to be preventing a download. I have the files on my local machine. I can include them in the dataset folder as th... |
https://api.github.com/repos/huggingface/datasets/issues/3263 | 3,263 | FET DATA | ## Adding a Dataset
- **Name:** *name of the dataset*
- **Description:** *short description of the dataset (or link to social media or blog post)*
- **Paper:** *link to the dataset paper if available*
- **Data:** *link to the Github repository or current dataset location*
- **Motivation:** *what are some good reasons t... | closed | 2021-11-13T05:46:06 | https://api.github.com/repos/huggingface/datasets/issues/3263/comments | null | false | FET DATA
## Adding a Dataset
- **Name:** *name of the dataset*
- **Description:** *short description of the dataset (or link to social media or blog post)*
- **Paper:** *link to the dataset paper if available*
- **Data:** *link to the Github repository or current dataset location*
- **Motivation:** *what are some good ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3262 | 3,262 | asserts replaced with exception for image classification task, csv, json | Fixes for csv, json in io module and image_classification task with tests referenced in https://github.com/huggingface/datasets/issues/3171 | closed | 2021-11-12T22:34:59 | https://api.github.com/repos/huggingface/datasets/issues/3262/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3262",
"html_url": "https://github.com/huggingface/datasets/pull/3262",
"diff_url": "https://github.com/huggingface/datasets/pull/3262.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3262.patch",
"merged_at": "2021-11-15T11:08... | true | asserts replaced with exception for image classification task, csv, json
Fixes for csv, json in io module and image_classification task with tests referenced in https://github.com/huggingface/datasets/issues/3171 | [] |
https://api.github.com/repos/huggingface/datasets/issues/3261 | 3,261 | Scifi_TV_Shows: Having trouble getting viewer to find appropriate files | ## Dataset viewer issue for '*Science Fiction TV Show Plots Corpus (Scifi_TV_Shows)*'
**Link:** [link](https://huggingface.co/datasets/lara-martin/Scifi_TV_Shows)
I tried adding both a script (https://huggingface.co/datasets/lara-martin/Scifi_TV_Shows/blob/main/Scifi_TV_Shows.py) and some dummy examples (https:/... | closed | 2021-11-12T19:25:19 | https://api.github.com/repos/huggingface/datasets/issues/3261/comments | null | false | Scifi_TV_Shows: Having trouble getting viewer to find appropriate files
## Dataset viewer issue for '*Science Fiction TV Show Plots Corpus (Scifi_TV_Shows)*'
**Link:** [link](https://huggingface.co/datasets/lara-martin/Scifi_TV_Shows)
I tried adding both a script (https://huggingface.co/datasets/lara-martin/Scif... | [
"Hi ! I think this is because `iter_archive` doesn't support ZIP files yet. See https://github.com/huggingface/datasets/issues/3272\r\n\r\nYou can navigate into the archive this way instead:\r\n```python\r\n# in split_generators\r\ndata_dir = dl_manager.download_and_extract(url)\r\ntrain_filepath = os.path.join(dat... |
https://api.github.com/repos/huggingface/datasets/issues/3260 | 3,260 | Fix ConnectionError in Scielo dataset | This PR:
* allows 403 status code in HEAD requests to S3 buckets to fix the connection error in the Scielo dataset (instead of `url`, uses `response.url` to check the URL of the final endpoint)
* makes the Scielo dataset streamable
Fixes #3255. | closed | 2021-11-12T18:02:37 | https://api.github.com/repos/huggingface/datasets/issues/3260/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3260",
"html_url": "https://github.com/huggingface/datasets/pull/3260",
"diff_url": "https://github.com/huggingface/datasets/pull/3260.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3260.patch",
"merged_at": "2021-11-16T17:55... | true | Fix ConnectionError in Scielo dataset
This PR:
* allows 403 status code in HEAD requests to S3 buckets to fix the connection error in the Scielo dataset (instead of `url`, uses `response.url` to check the URL of the final endpoint)
* makes the Scielo dataset streamable
Fixes #3255. | [
"The CI error is unrelated to the change."
] |
https://api.github.com/repos/huggingface/datasets/issues/3259 | 3,259 | Updating details of IRC disentanglement data | I was pleasantly surprised to find that someone had already added my dataset to the huggingface library, but some details were missing or incorrect. This PR fixes the documentation. | closed | 2021-11-12T17:16:58 | https://api.github.com/repos/huggingface/datasets/issues/3259/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3259",
"html_url": "https://github.com/huggingface/datasets/pull/3259",
"diff_url": "https://github.com/huggingface/datasets/pull/3259.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3259.patch",
"merged_at": "2021-11-18T17:19... | true | Updating details of IRC disentanglement data
I was pleasantly surprised to find that someone had already added my dataset to the huggingface library, but some details were missing or incorrect. This PR fixes the documentation. | [
"Thank you for the cleanup!"
] |
https://api.github.com/repos/huggingface/datasets/issues/3258 | 3,258 | Reload dataset that was already downloaded with `load_from_disk` from cloud storage | `load_from_disk` downloads the dataset to a temporary directory without checking if the dataset has already been downloaded once.
It would be nice to have some sort of caching for datasets downloaded this way. This could leverage the fingerprint of the dataset that was saved in the `state.json` file. | open | 2021-11-12T17:14:59 | https://api.github.com/repos/huggingface/datasets/issues/3258/comments | null | false | Reload dataset that was already downloaded with `load_from_disk` from cloud storage
`load_from_disk` downloads the dataset to a temporary directory without checking if the dataset has already been downloaded once.
It would be nice to have some sort of caching for datasets downloaded this way. This could leverage the f... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3257 | 3,257 | Use f-strings for string formatting | f-strings offer better readability/performance than `str.format` and `%`, so we should use them in all places in our codebase unless there is good reason to keep the older syntax.
> **NOTE FOR CONTRIBUTORS**: To avoid large PRs and possible merge conflicts, do 1-3 modules per PR. Also, feel free to ignore the files ... | closed | 2021-11-12T16:02:15 | https://api.github.com/repos/huggingface/datasets/issues/3257/comments | null | false | Use f-strings for string formatting
f-strings offer better readability/performance than `str.format` and `%`, so we should use them in all places in our codebase unless there is good reason to keep the older syntax.
> **NOTE FOR CONTRIBUTORS**: To avoid large PRs and possible merge conflicts, do 1-3 modules per PR.... | [
"Hi, I would be glad to help with this. Is there anyone else working on it?",
"Hi, I would be glad to work on this too.",
"#self-assign",
"Hi @Carlosbogo,\r\n\r\nwould you be interested in replacing the `.format` and `%` syntax with f-strings in the modules in the `datasets` directory since @Mehdi2402 has ope... |
https://api.github.com/repos/huggingface/datasets/issues/3256 | 3,256 | asserts replaced by exception for text classification task with test. | I have replaced only a single assert in text_classification.py along with a unit test to verify an exception is raised based on https://github.com/huggingface/datasets/issues/3171 .
I would like to first understand the code contribution workflow. So keeping the change to a single file rather than making too many ch... | closed | 2021-11-12T14:05:36 | https://api.github.com/repos/huggingface/datasets/issues/3256/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3256",
"html_url": "https://github.com/huggingface/datasets/pull/3256",
"diff_url": "https://github.com/huggingface/datasets/pull/3256.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3256.patch",
"merged_at": "2021-11-12T14:59... | true | asserts replaced by exception for text classification task with test.
I have replaced only a single assert in text_classification.py along with a unit test to verify an exception is raised based on https://github.com/huggingface/datasets/issues/3171 .
I would like to first understand the code contribution workflow.... | [
"Haha it looks like you got the chance of being reviewed twice at the same time and got the same suggestion twice x)\r\nAnyway it's all good now so we can merge !",
"Thanks for the feedback. "
] |
https://api.github.com/repos/huggingface/datasets/issues/3255 | 3,255 | SciELO dataset ConnectionError | ## Describe the bug
I get `ConnectionError` when I am trying to load the SciELO dataset.
When I try the URL with `requests` I get:
```
>>> requests.head("https://ndownloader.figstatic.com/files/14019287")
<Response [302]>
```
And as far as I understand redirections in `datasets` are not supported for downlo... | closed | 2021-11-12T09:57:14 | https://api.github.com/repos/huggingface/datasets/issues/3255/comments | null | false | SciELO dataset ConnectionError
## Describe the bug
I get `ConnectionError` when I am trying to load the SciELO dataset.
When I try the URL with `requests` I get:
```
>>> requests.head("https://ndownloader.figstatic.com/files/14019287")
<Response [302]>
```
And as far as I understand redirections in `dataset... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3254 | 3,254 | Update xcopa dataset (fix checksum issues + add translated data) | This PR updates the checksums (as reported [here](https://discuss.huggingface.co/t/how-to-load-dataset-locally/11601/2)) of the `xcopa` dataset. Additionally, it adds new configs that hold the translated data of the original set of configs. This data was not available at the time of adding this dataset to the lib. | closed | 2021-11-11T20:51:33 | https://api.github.com/repos/huggingface/datasets/issues/3254/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3254",
"html_url": "https://github.com/huggingface/datasets/pull/3254",
"diff_url": "https://github.com/huggingface/datasets/pull/3254.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3254.patch",
"merged_at": "2021-11-12T10:30... | true | Update xcopa dataset (fix checksum issues + add translated data)
This PR updates the checksums (as reported [here](https://discuss.huggingface.co/t/how-to-load-dataset-locally/11601/2)) of the `xcopa` dataset. Additionally, it adds new configs that hold the translated data of the original set of configs. This data was ... | [
"The CI failures are unrelated to the changes (missing fields in the readme and the CER metric error fixed in #3252)."
] |
https://api.github.com/repos/huggingface/datasets/issues/3253 | 3,253 | `GeneratorBasedBuilder` does not support `None` values | ## Describe the bug
`GeneratorBasedBuilder` does not support `None` values.
## Steps to reproduce the bug
See [this repository](https://github.com/pavel-lexyr/huggingface-datasets-bug-reproduction) for minimal reproduction.
## Expected results
Dataset is initialized with a `None` value in the `value` column.
... | closed | 2021-11-11T19:51:21 | https://api.github.com/repos/huggingface/datasets/issues/3253/comments | null | false | `GeneratorBasedBuilder` does not support `None` values
## Describe the bug
`GeneratorBasedBuilder` does not support `None` values.
## Steps to reproduce the bug
See [this repository](https://github.com/pavel-lexyr/huggingface-datasets-bug-reproduction) for minimal reproduction.
## Expected results
Dataset is i... | [
"Hi,\r\n\r\nthanks for reporting and providing a minimal reproducible example. \r\n\r\nThis line of the PR I've linked in our discussion on the Forum will add support for `None` values:\r\nhttps://github.com/huggingface/datasets/blob/a53de01842aac65c66a49b2439e18fa93ff73ceb/src/datasets/features/features.py#L835\r\... |
https://api.github.com/repos/huggingface/datasets/issues/3252 | 3,252 | Fix failing CER metric test in CI after update | Fixes the [failing CER metric test](https://app.circleci.com/pipelines/github/huggingface/datasets/8644/workflows/79816553-fa2f-4756-b022-d5937f00bf7b/jobs/53298) in CI by adding support for `jiwer==2.3.0`, which was released yesterday. Also, I verified that all the tests in `metrics/cer/test_cer.py` pass after the cha... | closed | 2021-11-11T15:57:16 | https://api.github.com/repos/huggingface/datasets/issues/3252/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3252",
"html_url": "https://github.com/huggingface/datasets/pull/3252",
"diff_url": "https://github.com/huggingface/datasets/pull/3252.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3252.patch",
"merged_at": "2021-11-12T14:06... | true | Fix failing CER metric test in CI after update
Fixes the [failing CER metric test](https://app.circleci.com/pipelines/github/huggingface/datasets/8644/workflows/79816553-fa2f-4756-b022-d5937f00bf7b/jobs/53298) in CI by adding support for `jiwer==2.3.0`, which was released yesterday. Also, I verified that all the tests ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3250 | 3,250 | Add ETHICS dataset | This PR adds the ETHICS dataset, including all 5 sub-datasets.
From https://arxiv.org/abs/2008.02275 | closed | 2021-11-11T03:45:34 | https://api.github.com/repos/huggingface/datasets/issues/3250/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3250",
"html_url": "https://github.com/huggingface/datasets/pull/3250",
"diff_url": "https://github.com/huggingface/datasets/pull/3250.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3250.patch",
"merged_at": null
} | true | Add ETHICS dataset
This PR adds the ETHICS dataset, including all 5 sub-datasets.
From https://arxiv.org/abs/2008.02275 | [
"Thanks for your contribution, @ssss1029. Are you still interested in adding this dataset?\r\n\r\nWe are removing the dataset scripts from this GitHub repo and moving them to the Hugging Face Hub: https://huggingface.co/datasets\r\n\r\nWe would suggest you create this dataset there. Please, feel free to tell us if ... |
https://api.github.com/repos/huggingface/datasets/issues/3249 | 3,249 | Fix streaming for id_newspapers_2018 | To be compatible with streaming, this dataset must use `dl_manager.iter_archive` since the data are in a .tgz file | closed | 2021-11-10T18:55:30 | https://api.github.com/repos/huggingface/datasets/issues/3249/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3249",
"html_url": "https://github.com/huggingface/datasets/pull/3249",
"diff_url": "https://github.com/huggingface/datasets/pull/3249.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3249.patch",
"merged_at": "2021-11-12T14:01... | true | Fix streaming for id_newspapers_2018
To be compatible with streaming, this dataset must use `dl_manager.iter_archive` since the data are in a .tgz file | [] |
https://api.github.com/repos/huggingface/datasets/issues/3248 | 3,248 | Stream from Google Drive and other hosts | Streaming from Google Drive is a bit more challenging than the other host we've been supporting:
- the download URL must be updated to add the confirm token obtained by HEAD request
- it requires to use cookies to keep the connection alive
- the URL doesn't tell any information about whether the file is compressed o... | closed | 2021-11-10T18:32:32 | https://api.github.com/repos/huggingface/datasets/issues/3248/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3248",
"html_url": "https://github.com/huggingface/datasets/pull/3248",
"diff_url": "https://github.com/huggingface/datasets/pull/3248.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3248.patch",
"merged_at": "2021-11-12T17:18... | true | Stream from Google Drive and other hosts
Streaming from Google Drive is a bit more challenging than the other host we've been supporting:
- the download URL must be updated to add the confirm token obtained by HEAD request
- it requires to use cookies to keep the connection alive
- the URL doesn't tell any informati... | [
"I just tried some datasets and noticed that `spider` is not working for some reason (the compression type is not recognized), resulting in FileNotFoundError. I can take a look tomorrow",
"I'm fixing the remaining files based on TAR archives",
"THANKS A LOT"
] |
https://api.github.com/repos/huggingface/datasets/issues/3247 | 3,247 | Loading big json dataset raises pyarrow.lib.ArrowNotImplementedError | ## Describe the bug
When trying to create a dataset from a json file with around 25MB, the following error is raised `pyarrow.lib.ArrowNotImplementedError: Unsupported cast from struct<b: int64, c: int64> to struct using function cast_struct`
Splitting the big file into smaller ones and then loading it with the `lo... | closed | 2021-11-10T11:17:59 | https://api.github.com/repos/huggingface/datasets/issues/3247/comments | null | false | Loading big json dataset raises pyarrow.lib.ArrowNotImplementedError
## Describe the bug
When trying to create a dataset from a json file with around 25MB, the following error is raised `pyarrow.lib.ArrowNotImplementedError: Unsupported cast from struct<b: int64, c: int64> to struct using function cast_struct`
Spli... | [
"Hi,\r\n\r\nthis issue is similar to https://github.com/huggingface/datasets/issues/3093, so you can either use the solution provided there or try to load the data in one chunk (you can control the chunk size by specifying the `chunksize` parameter (`int`) in `load_dataset`).\r\n\r\n@lhoestq Is this worth opening a... |
https://api.github.com/repos/huggingface/datasets/issues/3246 | 3,246 | [tiny] fix typo in stream docs | null | closed | 2021-11-10T10:40:02 | https://api.github.com/repos/huggingface/datasets/issues/3246/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3246",
"html_url": "https://github.com/huggingface/datasets/pull/3246",
"diff_url": "https://github.com/huggingface/datasets/pull/3246.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3246.patch",
"merged_at": "2021-11-10T11:10... | true | [tiny] fix typo in stream docs
| [] |
https://api.github.com/repos/huggingface/datasets/issues/3245 | 3,245 | Fix load_from_disk temporary directory | `load_from_disk` uses `tempfile.TemporaryDirectory()` instead of our `get_temporary_cache_files_directory()` function. This can cause the temporary directory to be deleted before the dataset object is garbage collected.
In practice, it prevents anyone from using methods like `shuffle` on a dataset loaded this way, b... | closed | 2021-11-09T15:15:15 | https://api.github.com/repos/huggingface/datasets/issues/3245/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3245",
"html_url": "https://github.com/huggingface/datasets/pull/3245",
"diff_url": "https://github.com/huggingface/datasets/pull/3245.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3245.patch",
"merged_at": "2021-11-09T15:30... | true | Fix load_from_disk temporary directory
`load_from_disk` uses `tempfile.TemporaryDirectory()` instead of our `get_temporary_cache_files_directory()` function. This can cause the temporary directory to be deleted before the dataset object is garbage collected.
In practice, it prevents anyone from using methods like `s... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3244 | 3,244 | Fix filter method for batched=True | null | closed | 2021-11-09T14:30:59 | https://api.github.com/repos/huggingface/datasets/issues/3244/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3244",
"html_url": "https://github.com/huggingface/datasets/pull/3244",
"diff_url": "https://github.com/huggingface/datasets/pull/3244.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3244.patch",
"merged_at": "2021-11-09T15:52... | true | Fix filter method for batched=True
| [] |
https://api.github.com/repos/huggingface/datasets/issues/3243 | 3,243 | Remove redundant isort module placement | `isort` can place modules by itself from [version 5.0.0](https://pycqa.github.io/isort/docs/upgrade_guides/5.0.0.html#module-placement-changes-known_third_party-known_first_party-default_section-etc) onwards, making the `known_first_party` and `known_third_party` fields in `setup.cfg` redundant (this is why our CI work... | closed | 2021-11-09T13:50:30 | https://api.github.com/repos/huggingface/datasets/issues/3243/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3243",
"html_url": "https://github.com/huggingface/datasets/pull/3243",
"diff_url": "https://github.com/huggingface/datasets/pull/3243.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3243.patch",
"merged_at": "2021-11-12T14:02... | true | Remove redundant isort module placement
`isort` can place modules by itself from [version 5.0.0](https://pycqa.github.io/isort/docs/upgrade_guides/5.0.0.html#module-placement-changes-known_third_party-known_first_party-default_section-etc) onwards, making the `known_first_party` and `known_third_party` fields in `setup... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3242 | 3,242 | Adding ANERcorp-CAMeLLab dataset | null | open | 2021-11-09T12:04:04 | https://api.github.com/repos/huggingface/datasets/issues/3242/comments | null | false | Adding ANERcorp-CAMeLLab dataset
| [
"Adding ANERcorp dataset\r\n\r\n## Adding a Dataset\r\n- **Name:** *ANERcorp-CAMeLLab*\r\n- **Description:** *Since its creation in 2008, the ANERcorp dataset (Benajiba & Rosso, 2008) has been a standard reference used by Arabic named entity recognition researchers around the world. However, over time, this dataset... |
https://api.github.com/repos/huggingface/datasets/issues/3241 | 3,241 | Swap descriptions of v1 and raw-v1 configs of WikiText dataset and fix metadata | Fix #3237, fix #795. | closed | 2021-11-09T10:54:15 | https://api.github.com/repos/huggingface/datasets/issues/3241/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3241",
"html_url": "https://github.com/huggingface/datasets/pull/3241",
"diff_url": "https://github.com/huggingface/datasets/pull/3241.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3241.patch",
"merged_at": "2021-11-09T13:49... | true | Swap descriptions of v1 and raw-v1 configs of WikiText dataset and fix metadata
Fix #3237, fix #795. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3240 | 3,240 | Couldn't reach data file for disaster_response_messages | ## Describe the bug
Following command gives an ConnectionError.
## Steps to reproduce the bug
```python
disaster = load_dataset('disaster_response_messages')
```
## Error
```
ConnectionError: Couldn't reach https://datasets.appen.com/appen_datasets/disaster_response_data/disaster_response_messages_training.... | closed | 2021-11-09T09:26:42 | https://api.github.com/repos/huggingface/datasets/issues/3240/comments | null | false | Couldn't reach data file for disaster_response_messages
## Describe the bug
Following command gives an ConnectionError.
## Steps to reproduce the bug
```python
disaster = load_dataset('disaster_response_messages')
```
## Error
```
ConnectionError: Couldn't reach https://datasets.appen.com/appen_datasets/dis... | [
"It looks like the dataset isn't available anymore on appen.com\r\n\r\nThe CSV files appear to still be available at https://www.kaggle.com/landlord/multilingual-disaster-response-messages though. It says that the data are under the CC0 license so I guess we can host the dataset elsewhere instead ?"
] |
https://api.github.com/repos/huggingface/datasets/issues/3239 | 3,239 | Inconsistent performance of the "arabic_billion_words" dataset | ## Describe the bug
When downloaded from macine 1 the dataset is downloaded and parsed correctly.
When downloaded from machine two (which has a different cache directory),
the following script:
import datasets
from datasets import load_dataset
raw_dataset_elkhair_1 = load_dataset('arabic_billion_words', 'Alitti... | open | 2021-11-09T09:11:00 | https://api.github.com/repos/huggingface/datasets/issues/3239/comments | null | false | Inconsistent performance of the "arabic_billion_words" dataset
## Describe the bug
When downloaded from macine 1 the dataset is downloaded and parsed correctly.
When downloaded from machine two (which has a different cache directory),
the following script:
import datasets
from datasets import load_dataset
raw_d... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3238 | 3,238 | Reuters21578 Couldn't reach | ``## Adding a Dataset
- **Name:** *Reuters21578*
- **Description:** *ConnectionError: Couldn't reach https://kdd.ics.uci.edu/databases/reuters21578/reuters21578.tar.gz*
- **Data:** *https://huggingface.co/datasets/reuters21578*
`from datasets import load_dataset`
`dataset = load_dataset("reuters21578", 'ModLewis... | closed | 2021-11-09T06:08:56 | https://api.github.com/repos/huggingface/datasets/issues/3238/comments | null | false | Reuters21578 Couldn't reach
``## Adding a Dataset
- **Name:** *Reuters21578*
- **Description:** *ConnectionError: Couldn't reach https://kdd.ics.uci.edu/databases/reuters21578/reuters21578.tar.gz*
- **Data:** *https://huggingface.co/datasets/reuters21578*
`from datasets import load_dataset`
`dataset = load_data... | [
"Hi ! The URL works fine on my side today, could you try again ?",
"thank you @lhoestq \r\nit works"
] |
https://api.github.com/repos/huggingface/datasets/issues/3237 | 3,237 | wikitext description wrong | ## Describe the bug
Descriptions of the wikitext datasests are wrong.
## Steps to reproduce the bug
Please see: https://github.com/huggingface/datasets/blob/f6dcafce996f39b6a4bbe3a9833287346f4a4b68/datasets/wikitext/wikitext.py#L50
## Expected results
The descriptions for raw-v1 and v1 should be switched. | closed | 2021-11-09T04:06:52 | https://api.github.com/repos/huggingface/datasets/issues/3237/comments | null | false | wikitext description wrong
## Describe the bug
Descriptions of the wikitext datasests are wrong.
## Steps to reproduce the bug
Please see: https://github.com/huggingface/datasets/blob/f6dcafce996f39b6a4bbe3a9833287346f4a4b68/datasets/wikitext/wikitext.py#L50
## Expected results
The descriptions for raw-v1 and... | [
"Hi @hongyuanmei, thanks for reporting.\r\n\r\nI'm fixing it.",
"Duplicate of:\r\n- #795"
] |
https://api.github.com/repos/huggingface/datasets/issues/3236 | 3,236 | Loading of datasets changed in #3110 returns no examples | ## Describe the bug
Loading of datasets changed in https://github.com/huggingface/datasets/pull/3110 returns no examples:
```python
DatasetDict({
train: Dataset({
features: ['id', 'title', 'abstract', 'full_text', 'qas'],
num_rows: 0
})
validation: Dataset({
features: ['id',... | closed | 2021-11-08T23:29:46 | https://api.github.com/repos/huggingface/datasets/issues/3236/comments | null | false | Loading of datasets changed in #3110 returns no examples
## Describe the bug
Loading of datasets changed in https://github.com/huggingface/datasets/pull/3110 returns no examples:
```python
DatasetDict({
train: Dataset({
features: ['id', 'title', 'abstract', 'full_text', 'qas'],
num_rows: 0
... | [
"Hi @eladsegal, thanks for reporting.\r\n\r\nI am sorry, but I can't reproduce the bug:\r\n```\r\nIn [1]: from datasets import load_dataset\r\n\r\nIn [2]: ds = load_dataset(\"qasper\")\r\nDownloading: 5.11kB [00:00, ?B/s]\r\nDownloading and preparing dataset qasper/qasper (download: 9.88 MiB, generated: 35.11 MiB, ... |
https://api.github.com/repos/huggingface/datasets/issues/3235 | 3,235 | Addd options to use updated bleurt checkpoints | Adds options to use newer recommended checkpoint (as of 2021/10/8) bleurt-20 and its distilled versions.
Updated checkpoints are described in https://github.com/google-research/bleurt/blob/master/checkpoints.md#the-recommended-checkpoint-bleurt-20
This change won't affect the default behavior of metrics/bleurt. ... | closed | 2021-11-08T18:53:54 | https://api.github.com/repos/huggingface/datasets/issues/3235/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3235",
"html_url": "https://github.com/huggingface/datasets/pull/3235",
"diff_url": "https://github.com/huggingface/datasets/pull/3235.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3235.patch",
"merged_at": "2021-11-12T14:05... | true | Addd options to use updated bleurt checkpoints
Adds options to use newer recommended checkpoint (as of 2021/10/8) bleurt-20 and its distilled versions.
Updated checkpoints are described in https://github.com/google-research/bleurt/blob/master/checkpoints.md#the-recommended-checkpoint-bleurt-20
This change won't ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3234 | 3,234 | Avoid PyArrow type optimization if it fails | Adds a new variable, `DISABLE_PYARROW_TYPES_OPTIMIZATION`, to `config.py` for easier control of the Arrow type optimization.
Fix #2206 | closed | 2021-11-08T16:10:27 | https://api.github.com/repos/huggingface/datasets/issues/3234/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3234",
"html_url": "https://github.com/huggingface/datasets/pull/3234",
"diff_url": "https://github.com/huggingface/datasets/pull/3234.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3234.patch",
"merged_at": "2021-11-10T12:04... | true | Avoid PyArrow type optimization if it fails
Adds a new variable, `DISABLE_PYARROW_TYPES_OPTIMIZATION`, to `config.py` for easier control of the Arrow type optimization.
Fix #2206 | [
"That's good to have a way to disable this easily :)\r\nI just find it a bit unfortunate that users would have to experience the error once and then do `DISABLE_PYARROW_TYPES_OPTIMIZATION=1`. Do you know if there's a way to simply fallback on disabling it automatically when it fails ?",
"@lhoestq Actually, I agre... |
https://api.github.com/repos/huggingface/datasets/issues/3233 | 3,233 | Improve repository structure docs | Continuation of the documentation started in https://github.com/huggingface/datasets/pull/3221, taking into account @stevhliu 's comments | closed | 2021-11-08T13:51:35 | https://api.github.com/repos/huggingface/datasets/issues/3233/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3233",
"html_url": "https://github.com/huggingface/datasets/pull/3233",
"diff_url": "https://github.com/huggingface/datasets/pull/3233.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3233.patch",
"merged_at": "2021-11-09T10:02... | true | Improve repository structure docs
Continuation of the documentation started in https://github.com/huggingface/datasets/pull/3221, taking into account @stevhliu 's comments | [] |
https://api.github.com/repos/huggingface/datasets/issues/3232 | 3,232 | The Xsum datasets seems not able to download. | ## Describe the bug
The download Link of the Xsum dataset provided in the repository is [Link](http://bollin.inf.ed.ac.uk/public/direct/XSUM-EMNLP18-Summary-Data-Original.tar.gz). It seems not able to download.
## Steps to reproduce the bug
```python
load_dataset('xsum')
```
## Actual results
``` python
r... | closed | 2021-11-08T11:58:54 | https://api.github.com/repos/huggingface/datasets/issues/3232/comments | null | false | The Xsum datasets seems not able to download.
## Describe the bug
The download Link of the Xsum dataset provided in the repository is [Link](http://bollin.inf.ed.ac.uk/public/direct/XSUM-EMNLP18-Summary-Data-Original.tar.gz). It seems not able to download.
## Steps to reproduce the bug
```python
load_dataset('xsu... | [
"Hi ! On my side the URL is working fine, could you try again ?",
"> Hi ! On my side the URL is working fine, could you try again ?\r\n\r\nI try it again and cannot download the file (might because of my location). Could you please provide another download link(such as google drive)? :>",
"I don't know other ... |
https://api.github.com/repos/huggingface/datasets/issues/3231 | 3,231 | Group tests in multiprocessing workers by test file | By grouping tests by test file, we make sure that all the tests in `test_load.py` are sent to the same worker.
Therefore, the fixture `hf_token` will be called only once (and from the same worker).
Related to: #3200.
Fix #3219. | closed | 2021-11-08T08:46:03 | https://api.github.com/repos/huggingface/datasets/issues/3231/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3231",
"html_url": "https://github.com/huggingface/datasets/pull/3231",
"diff_url": "https://github.com/huggingface/datasets/pull/3231.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3231.patch",
"merged_at": "2021-11-08T08:59... | true | Group tests in multiprocessing workers by test file
By grouping tests by test file, we make sure that all the tests in `test_load.py` are sent to the same worker.
Therefore, the fixture `hf_token` will be called only once (and from the same worker).
Related to: #3200.
Fix #3219. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3230 | 3,230 | Add full tagset to conll2003 README | Even though it is possible to manually get the tagset list with
```python
dset.features[field_name].feature.names
```
I think it is useful to have an overview of the used tagset on the dataset card. This is particularly useful in light of the **dataset viewer**: the tags are encoded, so it is not immediately ob... | closed | 2021-11-08T08:06:04 | https://api.github.com/repos/huggingface/datasets/issues/3230/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3230",
"html_url": "https://github.com/huggingface/datasets/pull/3230",
"diff_url": "https://github.com/huggingface/datasets/pull/3230.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3230.patch",
"merged_at": "2021-11-09T10:40... | true | Add full tagset to conll2003 README
Even though it is possible to manually get the tagset list with
```python
dset.features[field_name].feature.names
```
I think it is useful to have an overview of the used tagset on the dataset card. This is particularly useful in light of the **dataset viewer**: the tags are ... | [
"I also added the missing `pretty_name` tag in the dataset card to fix the CI"
] |
https://api.github.com/repos/huggingface/datasets/issues/3229 | 3,229 | Fix URL in CITATION file | Currently the BibTeX citation parsed from the CITATION file has wrong URL (it shows the repo URL instead of the proceedings paper URL):
```
@inproceedings{Lhoest_Datasets_A_Community_2021,
author = {Lhoest, Quentin and Villanova del Moral, Albert and von Platen, Patrick and Wolf, Thomas and Šaško, Mario and Jernite,... | closed | 2021-11-07T10:04:35 | https://api.github.com/repos/huggingface/datasets/issues/3229/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3229",
"html_url": "https://github.com/huggingface/datasets/pull/3229",
"diff_url": "https://github.com/huggingface/datasets/pull/3229.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3229.patch",
"merged_at": "2021-11-07T10:04... | true | Fix URL in CITATION file
Currently the BibTeX citation parsed from the CITATION file has wrong URL (it shows the repo URL instead of the proceedings paper URL):
```
@inproceedings{Lhoest_Datasets_A_Community_2021,
author = {Lhoest, Quentin and Villanova del Moral, Albert and von Platen, Patrick and Wolf, Thomas and ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3228 | 3,228 | Add CITATION file | Add CITATION file. | closed | 2021-11-07T09:40:19 | https://api.github.com/repos/huggingface/datasets/issues/3228/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3228",
"html_url": "https://github.com/huggingface/datasets/pull/3228",
"diff_url": "https://github.com/huggingface/datasets/pull/3228.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3228.patch",
"merged_at": "2021-11-07T09:51... | true | Add CITATION file
Add CITATION file. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3227 | 3,227 | Error in `Json(datasets.ArrowBasedBuilder)` class | ## Describe the bug
When a json file contains a `text` field that is larger than the block_size, the JSON dataset builder fails.
## Steps to reproduce the bug
Create a folder that contains the following:
```
.
├── testdata
│ └── mydata.json
└── test.py
```
Please download [this file](https://github.com/... | closed | 2021-11-07T05:50:32 | https://api.github.com/repos/huggingface/datasets/issues/3227/comments | null | false | Error in `Json(datasets.ArrowBasedBuilder)` class
## Describe the bug
When a json file contains a `text` field that is larger than the block_size, the JSON dataset builder fails.
## Steps to reproduce the bug
Create a folder that contains the following:
```
.
├── testdata
│ └── mydata.json
└── test.py
```
... | [
"I have additionally identified the source of the error, being that [this condition](https://github.com/huggingface/datasets/blob/fc46bba66ba4f432cc10501c16a677112e13984c/src/datasets/packaged_modules/json/json.py#L124-L126) in the file\r\n`python3.8/site-packages/datasets/packaged_modules/json/json.py` is not bein... |
https://api.github.com/repos/huggingface/datasets/issues/3226 | 3,226 | Fix paper BibTeX citation with proceedings reference | Fix paper BibTeX citation with proceedings reference. | closed | 2021-11-06T19:52:59 | https://api.github.com/repos/huggingface/datasets/issues/3226/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3226",
"html_url": "https://github.com/huggingface/datasets/pull/3226",
"diff_url": "https://github.com/huggingface/datasets/pull/3226.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3226.patch",
"merged_at": "2021-11-07T07:05... | true | Fix paper BibTeX citation with proceedings reference
Fix paper BibTeX citation with proceedings reference. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3225 | 3,225 | Update tatoeba to v2021-07-22 | Tatoeba's latest version is v2021-07-22 | closed | 2021-11-06T15:14:31 | https://api.github.com/repos/huggingface/datasets/issues/3225/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3225",
"html_url": "https://github.com/huggingface/datasets/pull/3225",
"diff_url": "https://github.com/huggingface/datasets/pull/3225.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3225.patch",
"merged_at": "2021-11-12T11:13... | true | Update tatoeba to v2021-07-22
Tatoeba's latest version is v2021-07-22 | [
"How about this? @lhoestq @abhishekkrthakur ",
"Hi ! I think it would be nice if people could still be able to load the old version.\r\nMaybe this can be a parameter ? For example to load the old version they could do\r\n```python\r\nload_dataset(\"tatoeba\", lang1=\"en\", lang2=\"mr\", date=\"v2020-11-09\")\r\n`... |
https://api.github.com/repos/huggingface/datasets/issues/3224 | 3,224 | User-pickling with dynamic sub-classing | This is a continuation of the now closed PR in https://github.com/huggingface/datasets/pull/3206. The discussion there has shaped a new approach to do this.
In this PR, behavior of `pklregister` and `Pickler` is extended. Earlier, users were already able to register custom pickle functions. That is useful if they ha... | closed | 2021-11-06T12:08:24 | https://api.github.com/repos/huggingface/datasets/issues/3224/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3224",
"html_url": "https://github.com/huggingface/datasets/pull/3224",
"diff_url": "https://github.com/huggingface/datasets/pull/3224.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3224.patch",
"merged_at": null
} | true | User-pickling with dynamic sub-classing
This is a continuation of the now closed PR in https://github.com/huggingface/datasets/pull/3206. The discussion there has shaped a new approach to do this.
In this PR, behavior of `pklregister` and `Pickler` is extended. Earlier, users were already able to register custom pic... | [
"@lhoestq Feel free to have a look. The implementation is slightly different from what you suggested. I have opted to overwrite `save` instead of meddling with `save_global`. `save_global` is called very late down in dill/pickle so it is hard to control for what is happening there. I might be wrong. Pickling is mor... |
https://api.github.com/repos/huggingface/datasets/issues/3223 | 3,223 | Update BibTeX entry | Update BibTeX entry. | closed | 2021-11-06T06:41:52 | https://api.github.com/repos/huggingface/datasets/issues/3223/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3223",
"html_url": "https://github.com/huggingface/datasets/pull/3223",
"diff_url": "https://github.com/huggingface/datasets/pull/3223.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3223.patch",
"merged_at": "2021-11-06T07:06... | true | Update BibTeX entry
Update BibTeX entry. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3222 | 3,222 | Add docs for audio processing | This PR adds documentation for the `Audio` feature. It describes:
- The difference between loading `path` and `audio`, as well as use-cases/best practices for each of them.
- Resampling audio files with `cast_column`, and then calling `ds[0]["audio"]` to automatically decode and resample to the desired sampling rat... | closed | 2021-11-05T23:07:59 | https://api.github.com/repos/huggingface/datasets/issues/3222/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3222",
"html_url": "https://github.com/huggingface/datasets/pull/3222",
"diff_url": "https://github.com/huggingface/datasets/pull/3222.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3222.patch",
"merged_at": "2021-11-24T15:35... | true | Add docs for audio processing
This PR adds documentation for the `Audio` feature. It describes:
- The difference between loading `path` and `audio`, as well as use-cases/best practices for each of them.
- Resampling audio files with `cast_column`, and then calling `ds[0]["audio"]` to automatically decode and resamp... | [
"Nice ! love it this way. I guess you can set this PR to \"ready for review\" ?",
"I guess we can merge this one now :)"
] |
https://api.github.com/repos/huggingface/datasets/issues/3221 | 3,221 | Resolve data_files by split name | As discussed in https://github.com/huggingface/datasets/issues/3027 we should automatically infer what file is supposed to go to what split automatically, based on filenames.
I added the support for different kinds of patterns, for both dataset repositories and local directories:
```
Input structure:
... | closed | 2021-11-05T14:07:35 | https://api.github.com/repos/huggingface/datasets/issues/3221/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3221",
"html_url": "https://github.com/huggingface/datasets/pull/3221",
"diff_url": "https://github.com/huggingface/datasets/pull/3221.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3221.patch",
"merged_at": "2021-11-05T17:49... | true | Resolve data_files by split name
As discussed in https://github.com/huggingface/datasets/issues/3027 we should automatically infer what file is supposed to go to what split automatically, based on filenames.
I added the support for different kinds of patterns, for both dataset repositories and local directories:
... | [
"Really cool!\r\nWhen splitting by folder, what do we use for validation set (\"valid\", \"validation\" or both)?",
"> When splitting by folder, what do we use for validation set (\"valid\", \"validation\" or both)?\r\n\r\nBoth are fine :) As soon as it has \"valid\" in it",
"Merging for now, if you have commen... |
https://api.github.com/repos/huggingface/datasets/issues/3220 | 3,220 | Add documentation about dataset viewer feature | Add to the docs more details about the dataset viewer feature in the Hub.
CC: @julien-c
| open | 2021-11-05T08:11:19 | https://api.github.com/repos/huggingface/datasets/issues/3220/comments | null | false | Add documentation about dataset viewer feature
Add to the docs more details about the dataset viewer feature in the Hub.
CC: @julien-c
| [
"In particular, include this somewhere in the docs: https://huggingface.co/docs/hub/datasets-viewer#access-the-parquet-files\r\n\r\nSee https://github.com/huggingface/hub-docs/issues/563"
] |
https://api.github.com/repos/huggingface/datasets/issues/3219 | 3,219 | Eventual Invalid Token Error at setup of private datasets | ## Describe the bug
From time to time, there appear Invalid Token errors with private datasets:
- https://app.circleci.com/pipelines/github/huggingface/datasets/8520/workflows/d44629f2-4749-40f8-a657-50931d0b3434/jobs/52534
```
____________ ERROR at setup of test_load_streaming_private_dataset _____________
... | closed | 2021-11-04T18:50:45 | https://api.github.com/repos/huggingface/datasets/issues/3219/comments | null | false | Eventual Invalid Token Error at setup of private datasets
## Describe the bug
From time to time, there appear Invalid Token errors with private datasets:
- https://app.circleci.com/pipelines/github/huggingface/datasets/8520/workflows/d44629f2-4749-40f8-a657-50931d0b3434/jobs/52534
```
____________ ERROR at se... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3218 | 3,218 | Fix code quality in riddle_sense dataset | Fix trailing whitespace.
Fix #3217. | closed | 2021-11-04T17:43:20 | https://api.github.com/repos/huggingface/datasets/issues/3218/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3218",
"html_url": "https://github.com/huggingface/datasets/pull/3218",
"diff_url": "https://github.com/huggingface/datasets/pull/3218.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3218.patch",
"merged_at": "2021-11-04T17:50... | true | Fix code quality in riddle_sense dataset
Fix trailing whitespace.
Fix #3217. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3217 | 3,217 | Fix code quality bug in riddle_sense dataset | ## Describe the bug
```
datasets/riddle_sense/riddle_sense.py:36:21: W291 trailing whitespace
``` | closed | 2021-11-04T17:40:32 | https://api.github.com/repos/huggingface/datasets/issues/3217/comments | null | false | Fix code quality bug in riddle_sense dataset
## Describe the bug
```
datasets/riddle_sense/riddle_sense.py:36:21: W291 trailing whitespace
``` | [
"To give more context: https://github.com/psf/black/issues/318. `black` doesn't treat this as a bug, but `flake8` does. \r\n"
] |
https://api.github.com/repos/huggingface/datasets/issues/3216 | 3,216 | Pin version exclusion for tensorflow incompatible with keras | Once `tensorflow` version 2.6.2 is released:
- https://github.com/tensorflow/tensorflow/commit/c1867f3bfdd1042f694df7a9870be51ba80543cb
- https://pypi.org/project/tensorflow/2.6.2/
with the patch:
- tensorflow/tensorflow#52927
we can remove the temporary fix we introduced in:
- #3208
Fix #3209. | closed | 2021-11-04T17:38:06 | https://api.github.com/repos/huggingface/datasets/issues/3216/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3216",
"html_url": "https://github.com/huggingface/datasets/pull/3216",
"diff_url": "https://github.com/huggingface/datasets/pull/3216.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3216.patch",
"merged_at": "2021-11-05T10:57... | true | Pin version exclusion for tensorflow incompatible with keras
Once `tensorflow` version 2.6.2 is released:
- https://github.com/tensorflow/tensorflow/commit/c1867f3bfdd1042f694df7a9870be51ba80543cb
- https://pypi.org/project/tensorflow/2.6.2/
with the patch:
- tensorflow/tensorflow#52927
we can remove the tempo... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3215 | 3,215 | Small updates to to_tf_dataset documentation | I added a little more description about `to_tf_dataset` compared to just setting the format | closed | 2021-11-04T17:22:01 | https://api.github.com/repos/huggingface/datasets/issues/3215/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3215",
"html_url": "https://github.com/huggingface/datasets/pull/3215",
"diff_url": "https://github.com/huggingface/datasets/pull/3215.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3215.patch",
"merged_at": "2021-11-04T18:55... | true | Small updates to to_tf_dataset documentation
I added a little more description about `to_tf_dataset` compared to just setting the format | [
"@stevhliu Accepted both suggestions, thanks for the review!"
] |
https://api.github.com/repos/huggingface/datasets/issues/3214 | 3,214 | Add ACAV100M Dataset | ## Adding a Dataset
- **Name:** *ACAV100M*
- **Description:** *contains 100 million videos with high audio-visual correspondence, ideal for self-supervised video representation learning.*
- **Paper:** *https://arxiv.org/abs/2101.10803*
- **Data:** *https://github.com/sangho-vision/acav100m*
- **Motivation:** *The ... | open | 2021-11-04T15:59:58 | https://api.github.com/repos/huggingface/datasets/issues/3214/comments | null | false | Add ACAV100M Dataset
## Adding a Dataset
- **Name:** *ACAV100M*
- **Description:** *contains 100 million videos with high audio-visual correspondence, ideal for self-supervised video representation learning.*
- **Paper:** *https://arxiv.org/abs/2101.10803*
- **Data:** *https://github.com/sangho-vision/acav100m*
- ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3213 | 3,213 | Fix tuple_ie download url | Fix #3204 | closed | 2021-11-04T13:09:07 | https://api.github.com/repos/huggingface/datasets/issues/3213/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3213",
"html_url": "https://github.com/huggingface/datasets/pull/3213",
"diff_url": "https://github.com/huggingface/datasets/pull/3213.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3213.patch",
"merged_at": "2021-11-05T14:16... | true | Fix tuple_ie download url
Fix #3204 | [] |
https://api.github.com/repos/huggingface/datasets/issues/3212 | 3,212 | Sort files before loading | When loading a dataset that consists of several files (e.g. `my_data/data_001.json`, `my_data/data_002.json` etc.) they are not loaded in order when using `load_dataset("my_data")`.
This could lead to counter-intuitive results if, for example, the data files are sorted by date or similar since they would appear in d... | closed | 2021-11-04T11:08:31 | https://api.github.com/repos/huggingface/datasets/issues/3212/comments | null | false | Sort files before loading
When loading a dataset that consists of several files (e.g. `my_data/data_001.json`, `my_data/data_002.json` etc.) they are not loaded in order when using `load_dataset("my_data")`.
This could lead to counter-intuitive results if, for example, the data files are sorted by date or similar si... | [
"This will be fixed by https://github.com/huggingface/datasets/pull/3221"
] |
https://api.github.com/repos/huggingface/datasets/issues/3211 | 3,211 | Fix disable_nullable default value to False | Currently the `disable_nullable` parameter is not consistent across all dataset transforms. For example it is `False` in `map` but `True` in `flatten_indices`.
This creates unexpected behaviors like this
```python
from datasets import Dataset, concatenate_datasets
d1 = Dataset.from_dict({"a": [0, 1, 2, 3]})
d2... | closed | 2021-11-04T10:52:06 | https://api.github.com/repos/huggingface/datasets/issues/3211/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3211",
"html_url": "https://github.com/huggingface/datasets/pull/3211",
"diff_url": "https://github.com/huggingface/datasets/pull/3211.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3211.patch",
"merged_at": "2021-11-04T11:08... | true | Fix disable_nullable default value to False
Currently the `disable_nullable` parameter is not consistent across all dataset transforms. For example it is `False` in `map` but `True` in `flatten_indices`.
This creates unexpected behaviors like this
```python
from datasets import Dataset, concatenate_datasets
d1 ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3210 | 3,210 | ConnectionError: Couldn't reach https://raw.githubusercontent.com/huggingface/datasets/1.15.1/datasets/wmt16/wmt16.py | when I use python examples/pytorch/translation/run_translation.py --model_name_or_path examples/pytorch/translation/opus-mt-en-ro --do_train --do_eval --source_lang en --target_lang ro --dataset_name wmt16 --dataset_config_name ro-en --output_dir /tmp/tst-translation --per_device_tra... | closed | 2021-11-04T10:47:26 | https://api.github.com/repos/huggingface/datasets/issues/3210/comments | null | false | ConnectionError: Couldn't reach https://raw.githubusercontent.com/huggingface/datasets/1.15.1/datasets/wmt16/wmt16.py
when I use python examples/pytorch/translation/run_translation.py --model_name_or_path examples/pytorch/translation/opus-mt-en-ro --do_train --do_eval --source_lang en --target_lang ... | [
"Hi ! Do you have some kind of proxy in your browser that gives you access to internet ?\r\n\r\nMaybe you're having this error because you don't have access to this URL from python ?",
"Hi，do you fixed this error?\r\nI still have this issue when use \"use_auth_token=True\"",
"You don't need authentication to ac... |
https://api.github.com/repos/huggingface/datasets/issues/3209 | 3,209 | Unpin keras once TF fixes its release | Related to:
- #3208 | closed | 2021-11-04T09:15:32 | https://api.github.com/repos/huggingface/datasets/issues/3209/comments | null | false | Unpin keras once TF fixes its release
Related to:
- #3208 | [] |
https://api.github.com/repos/huggingface/datasets/issues/3208 | 3,208 | Pin keras version until TF fixes its release | Fix #3207. | closed | 2021-11-04T09:13:32 | https://api.github.com/repos/huggingface/datasets/issues/3208/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3208",
"html_url": "https://github.com/huggingface/datasets/pull/3208",
"diff_url": "https://github.com/huggingface/datasets/pull/3208.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3208.patch",
"merged_at": "2021-11-04T09:30... | true | Pin keras version until TF fixes its release
Fix #3207. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3207 | 3,207 | CI error: Another metric with the same name already exists in Keras 2.7.0 | ## Describe the bug
Release of TensorFlow 2.7.0 contains an incompatibility with Keras. See:
- keras-team/keras#15579
This breaks our CI test suite: https://app.circleci.com/pipelines/github/huggingface/datasets/8493/workflows/055c7ae2-43bc-49b4-9f11-8fc71f35a25c/jobs/52363
| closed | 2021-11-04T09:04:11 | https://api.github.com/repos/huggingface/datasets/issues/3207/comments | null | false | CI error: Another metric with the same name already exists in Keras 2.7.0
## Describe the bug
Release of TensorFlow 2.7.0 contains an incompatibility with Keras. See:
- keras-team/keras#15579
This breaks our CI test suite: https://app.circleci.com/pipelines/github/huggingface/datasets/8493/workflows/055c7ae2-43bc-... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3206 | 3,206 | [WIP] Allow user-defined hash functions via a registry | Inspired by the discussion on hashing in https://github.com/huggingface/datasets/issues/3178#issuecomment-959016329, @lhoestq suggested that it would be neat to allow users more control over the hashing process. Specifically, it would be great if users can specify specific hashing functions depending on the **class** o... | closed | 2021-11-03T23:25:42 | https://api.github.com/repos/huggingface/datasets/issues/3206/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3206",
"html_url": "https://github.com/huggingface/datasets/pull/3206",
"diff_url": "https://github.com/huggingface/datasets/pull/3206.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3206.patch",
"merged_at": null
} | true | [WIP] Allow user-defined hash functions via a registry
Inspired by the discussion on hashing in https://github.com/huggingface/datasets/issues/3178#issuecomment-959016329, @lhoestq suggested that it would be neat to allow users more control over the hashing process. Specifically, it would be great if users can specify ... | [
"Hi @BramVanroy, thanks for your PR.\r\n\r\nThere was a bug in TensorFlow/Keras. We have made a temporary fix in master branch. Please, merge master into your PR branch, so that the CI tests pass.\r\n\r\n```\r\ngit checkout registry\r\ngit fetch upstream master\r\ngit merge upstream/master\r\n```",
"@albertvillan... |
https://api.github.com/repos/huggingface/datasets/issues/3205 | 3,205 | Add Multidoc2dial Dataset | This PR adds the MultiDoc2Dial dataset introduced in this [paper](https://arxiv.org/pdf/2109.12595v1.pdf ) | closed | 2021-11-03T20:48:31 | https://api.github.com/repos/huggingface/datasets/issues/3205/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3205",
"html_url": "https://github.com/huggingface/datasets/pull/3205",
"diff_url": "https://github.com/huggingface/datasets/pull/3205.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3205.patch",
"merged_at": "2021-11-24T16:55... | true | Add Multidoc2dial Dataset
This PR adds the MultiDoc2Dial dataset introduced in this [paper](https://arxiv.org/pdf/2109.12595v1.pdf ) | [
"@songfeng cc",
"Hi @sivasankalpp, thanks for your PR.\r\n\r\nThere was a bug in TensorFlow/Keras. We have made a temporary fix in our master branch. Please, merge master into your PR branch, so that the CI tests pass.\r\n\r\n```\r\ngit checkout multidoc2dial\r\ngit fetch upstream master\r\ngit merge upstream/mas... |
https://api.github.com/repos/huggingface/datasets/issues/3204 | 3,204 | FileNotFoundError for TupleIE dataste | Hi,
`dataset = datasets.load_dataset('tuple_ie', 'all')`
returns a FileNotFound error. Is the data not available?
Many thanks.
| closed | 2021-11-03T14:56:55 | https://api.github.com/repos/huggingface/datasets/issues/3204/comments | null | false | FileNotFoundError for TupleIE dataste
Hi,
`dataset = datasets.load_dataset('tuple_ie', 'all')`
returns a FileNotFound error. Is the data not available?
Many thanks.
| [
"@mariosasko @lhoestq Could you give me an update on how to load the dataset after the fix?\r\nThanks.",
"Hi @arda-vianai,\r\n\r\nfirst, you can try:\r\n```python\r\nimport datasets\r\ndataset = datasets.load_dataset('tuple_ie', 'all', revision=\"master\")\r\n```\r\nIf this doesn't work, your version of `datasets... |
https://api.github.com/repos/huggingface/datasets/issues/3203 | 3,203 | Updated: DaNE - updated URL for download | It seems that DaNLP has updated their download URLs and it therefore also needs to be updated in here... | closed | 2021-11-03T12:55:13 | https://api.github.com/repos/huggingface/datasets/issues/3203/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3203",
"html_url": "https://github.com/huggingface/datasets/pull/3203",
"diff_url": "https://github.com/huggingface/datasets/pull/3203.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3203.patch",
"merged_at": "2021-11-04T11:46... | true | Updated: DaNE - updated URL for download
It seems that DaNLP has updated their download URLs and it therefore also needs to be updated in here... | [
"Actually it looks like the old URL is still working, and it's also the one that is mentioned in https://github.com/alexandrainst/danlp/blob/master/docs/docs/datasets.md\r\n\r\nWhat makes you think we should use the new URL ?",
"@lhoestq Sorry! I might have jumped to conclusions a bit too fast here... \r\n\r\nI w... |
https://api.github.com/repos/huggingface/datasets/issues/3202 | 3,202 | Add mIoU metric | **Is your feature request related to a problem? Please describe.**
Recently, some semantic segmentation models were added to HuggingFace Transformers, including [SegFormer](https://huggingface.co/transformers/model_doc/segformer.html) and [BEiT](https://huggingface.co/transformers/model_doc/beit.html).
Semantic seg... | closed | 2021-11-03T08:42:32 | https://api.github.com/repos/huggingface/datasets/issues/3202/comments | null | false | Add mIoU metric
**Is your feature request related to a problem? Please describe.**
Recently, some semantic segmentation models were added to HuggingFace Transformers, including [SegFormer](https://huggingface.co/transformers/model_doc/segformer.html) and [BEiT](https://huggingface.co/transformers/model_doc/beit.html).... | [
"Resolved via https://github.com/huggingface/datasets/pull/3745."
] |
https://api.github.com/repos/huggingface/datasets/issues/3201 | 3,201 | Add GSM8K dataset | ## Adding a Dataset
- **Name:** GSM8K (short for Grade School Math 8k)
- **Description:** GSM8K is a dataset of 8.5K high quality linguistically diverse grade school math word problems created by human problem writers.
- **Paper:** https://openai.com/blog/grade-school-math/
- **Data:** https://github.com/openai/gra... | closed | 2021-11-03T08:36:44 | https://api.github.com/repos/huggingface/datasets/issues/3201/comments | null | false | Add GSM8K dataset
## Adding a Dataset
- **Name:** GSM8K (short for Grade School Math 8k)
- **Description:** GSM8K is a dataset of 8.5K high quality linguistically diverse grade school math word problems created by human problem writers.
- **Paper:** https://openai.com/blog/grade-school-math/
- **Data:** https://git... | [
"Closed via https://github.com/huggingface/datasets/pull/4103"
] |
https://api.github.com/repos/huggingface/datasets/issues/3200 | 3,200 | Catch token invalid error in CI | The staging back end sometimes returns invalid token errors when trying to delete a repo.
I modified the fixture in the test that uses staging to ignore this error | closed | 2021-11-02T21:56:26 | https://api.github.com/repos/huggingface/datasets/issues/3200/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3200",
"html_url": "https://github.com/huggingface/datasets/pull/3200",
"diff_url": "https://github.com/huggingface/datasets/pull/3200.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3200.patch",
"merged_at": "2021-11-03T09:41... | true | Catch token invalid error in CI
The staging back end sometimes returns invalid token errors when trying to delete a repo.
I modified the fixture in the test that uses staging to ignore this error | [] |
https://api.github.com/repos/huggingface/datasets/issues/3199 | 3,199 | Bump huggingface_hub | huggingface_hub just released its first minor version, so we need to update the dependency
It was supposed to be part of 1.15.0 but I'm adding it for 1.15.1 | closed | 2021-11-02T21:29:10 | https://api.github.com/repos/huggingface/datasets/issues/3199/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3199",
"html_url": "https://github.com/huggingface/datasets/pull/3199",
"diff_url": "https://github.com/huggingface/datasets/pull/3199.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3199.patch",
"merged_at": "2021-11-02T21:41... | true | Bump huggingface_hub
huggingface_hub just released its first minor version, so we need to update the dependency
It was supposed to be part of 1.15.0 but I'm adding it for 1.15.1 | [] |
https://api.github.com/repos/huggingface/datasets/issues/3198 | 3,198 | Add Multi-Lingual LibriSpeech | Add https://www.openslr.org/94/ | closed | 2021-11-02T18:23:59 | https://api.github.com/repos/huggingface/datasets/issues/3198/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3198",
"html_url": "https://github.com/huggingface/datasets/pull/3198",
"diff_url": "https://github.com/huggingface/datasets/pull/3198.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3198.patch",
"merged_at": "2021-11-04T17:09... | true | Add Multi-Lingual LibriSpeech
Add https://www.openslr.org/94/ | [] |
https://api.github.com/repos/huggingface/datasets/issues/3197 | 3,197 | Fix optimized encoding for arrays | Hi !
#3124 introduced a regression that made the benchmarks CI fail because of a bad array comparison when checking the first encoded element. This PR fixes this by making sure that encoding is applied on all sequence types except lists.
cc @eladsegal fyi (no big deal) | closed | 2021-11-02T15:55:53 | https://api.github.com/repos/huggingface/datasets/issues/3197/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3197",
"html_url": "https://github.com/huggingface/datasets/pull/3197",
"diff_url": "https://github.com/huggingface/datasets/pull/3197.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3197.patch",
"merged_at": "2021-11-02T19:12... | true | Fix optimized encoding for arrays
Hi !
#3124 introduced a regression that made the benchmarks CI fail because of a bad array comparison when checking the first encoded element. This PR fixes this by making sure that encoding is applied on all sequence types except lists.
cc @eladsegal fyi (no big deal) | [] |
https://api.github.com/repos/huggingface/datasets/issues/3196 | 3,196 | QOL improvements: auto-flatten_indices and desc in map calls | This PR:
* automatically calls `flatten_indices` where needed: in `unique` and `save_to_disk` to avoid saving the indices file
* adds descriptions to the map calls
Fix #3040 | closed | 2021-11-02T11:28:50 | https://api.github.com/repos/huggingface/datasets/issues/3196/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3196",
"html_url": "https://github.com/huggingface/datasets/pull/3196",
"diff_url": "https://github.com/huggingface/datasets/pull/3196.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3196.patch",
"merged_at": "2021-11-02T15:41... | true | QOL improvements: auto-flatten_indices and desc in map calls
This PR:
* automatically calls `flatten_indices` where needed: in `unique` and `save_to_disk` to avoid saving the indices file
* adds descriptions to the map calls
Fix #3040 | [] |
https://api.github.com/repos/huggingface/datasets/issues/3195 | 3,195 | More robust `None` handling | PyArrow has explicit support for `null` values, so it makes sense to support Nones on our side as well.
[Colab Notebook with examples](https://colab.research.google.com/drive/1zcK8BnZYnRe3Ao2271u1T19ag9zLEiy3?usp=sharing)
Changes:
* allow None for the features types with special encoding (`ClassLabel, Translatio... | closed | 2021-11-02T11:15:10 | https://api.github.com/repos/huggingface/datasets/issues/3195/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3195",
"html_url": "https://github.com/huggingface/datasets/pull/3195",
"diff_url": "https://github.com/huggingface/datasets/pull/3195.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3195.patch",
"merged_at": "2021-12-09T14:26... | true | More robust `None` handling
PyArrow has explicit support for `null` values, so it makes sense to support Nones on our side as well.
[Colab Notebook with examples](https://colab.research.google.com/drive/1zcK8BnZYnRe3Ao2271u1T19ag9zLEiy3?usp=sharing)
Changes:
* allow None for the features types with special encod... | [
"I also created a PR regarding `disable_nullable` that must be always `False` by default, in order to always allow None values\r\nhttps://github.com/huggingface/datasets/pull/3211",
"@lhoestq I addressed your comments, added tests, did some refactoring to make the implementation cleaner and added support for `Non... |
https://api.github.com/repos/huggingface/datasets/issues/3194 | 3,194 | Update link to Datasets Tagging app in Spaces | Fix #3193. | closed | 2021-11-02T08:13:50 | https://api.github.com/repos/huggingface/datasets/issues/3194/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3194",
"html_url": "https://github.com/huggingface/datasets/pull/3194",
"diff_url": "https://github.com/huggingface/datasets/pull/3194.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3194.patch",
"merged_at": "2021-11-08T10:36... | true | Update link to Datasets Tagging app in Spaces
Fix #3193. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3193 | 3,193 | Update link to datasets-tagging app | Once datasets-tagging has been transferred to Spaces:
- huggingface/datasets-tagging#22
We should update the link in Datasets. | closed | 2021-11-02T07:39:59 | https://api.github.com/repos/huggingface/datasets/issues/3193/comments | null | false | Update link to datasets-tagging app
Once datasets-tagging has been transferred to Spaces:
- huggingface/datasets-tagging#22
We should update the link in Datasets. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3192 | 3,192 | Multiprocessing filter/map (tests) not working on Windows | While running the tests, I found that the multiprocessing examples fail on Windows, or rather they do not complete: they cause a deadlock. I haven't dug deep into it, but they do not seem to work as-is. I currently have no time to tests this in detail but at least the tests seem not to run correctly (deadlocking).
#... | open | 2021-11-01T15:36:08 | https://api.github.com/repos/huggingface/datasets/issues/3192/comments | null | false | Multiprocessing filter/map (tests) not working on Windows
While running the tests, I found that the multiprocessing examples fail on Windows, or rather they do not complete: they cause a deadlock. I haven't dug deep into it, but they do not seem to work as-is. I currently have no time to tests this in detail but at lea... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3191 | 3,191 | Dataset viewer issue for '*compguesswhat*' | ## Dataset viewer issue for '*compguesswhat*'
**Link:** https://huggingface.co/datasets/compguesswhat
File not found
Am I the one who added this dataset ? No
| closed | 2021-11-01T14:16:49 | https://api.github.com/repos/huggingface/datasets/issues/3191/comments | null | false | Dataset viewer issue for '*compguesswhat*'
## Dataset viewer issue for '*compguesswhat*'
**Link:** https://huggingface.co/datasets/compguesswhat
File not found
Am I the one who added this dataset ? No
| [
"```python\r\n>>> import datasets\r\n>>> dataset = datasets.load_dataset('compguesswhat', name='compguesswhat-original',split='train', streaming=True)\r\n>>> next(iter(dataset))\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/home/slesage/hf/datasets-preview-backend/.ve... |
https://api.github.com/repos/huggingface/datasets/issues/3190 | 3,190 | combination of shuffle and filter results in a bug | ## Describe the bug
Hi,
I would like to shuffle a dataset, then filter it based on each existing label. however, the combination of `filter`, `shuffle` seems to results in a bug. In the minimal example below, as you see in the filtered results, the filtered labels are not unique, meaning filter has not worked. Any su... | closed | 2021-11-01T13:07:29 | https://api.github.com/repos/huggingface/datasets/issues/3190/comments | null | false | combination of shuffle and filter results in a bug
## Describe the bug
Hi,
I would like to shuffle a dataset, then filter it based on each existing label. however, the combination of `filter`, `shuffle` seems to results in a bug. In the minimal example below, as you see in the filtered results, the filtered labels ar... | [
"I cannot reproduce this on master and pyarrow==4.0.1.\r\n",
"Hi ! There was a regression in `datasets` 1.12 that introduced this bug. It has been fixed in #3019 in 1.13\r\n\r\nCan you try to update `datasets` and try again ?",
"Thanks a lot, fixes with 1.13"
] |
https://api.github.com/repos/huggingface/datasets/issues/3189 | 3,189 | conll2003 incorrect label explanation | In the [conll2003](https://huggingface.co/datasets/conll2003#data-fields) README, the labels are described as follows
> - `id`: a `string` feature.
> - `tokens`: a `list` of `string` features.
> - `pos_tags`: a `list` of classification labels, with possible values including `"` (0), `''` (1), `#` (2), `$` (3), `(`... | closed | 2021-11-01T11:03:30 | https://api.github.com/repos/huggingface/datasets/issues/3189/comments | null | false | conll2003 incorrect label explanation
In the [conll2003](https://huggingface.co/datasets/conll2003#data-fields) README, the labels are described as follows
> - `id`: a `string` feature.
> - `tokens`: a `list` of `string` features.
> - `pos_tags`: a `list` of classification labels, with possible values including `"... | [
"Hi @BramVanroy,\r\n\r\nsince these fields are of type `ClassLabel` (you can check this with `dset.features`), you can inspect the possible values with:\r\n```python\r\ndset.features[field_name].feature.names # .feature because it's a sequence of labels\r\n```\r\n\r\nand to find the mapping between names and integ... |
https://api.github.com/repos/huggingface/datasets/issues/3188 | 3,188 | conll2002 issues | **Link:** https://huggingface.co/datasets/conll2002
The dataset viewer throws a server error when trying to preview the dataset.
```
Message: Extraction protocol 'train' for file at 'https://raw.githubusercontent.com/teropa/nlp/master/resources/corpora/conll2002/esp.train' is not implemented yet
```
I... | closed | 2021-11-01T09:49:24 | https://api.github.com/repos/huggingface/datasets/issues/3188/comments | null | false | conll2002 issues
**Link:** https://huggingface.co/datasets/conll2002
The dataset viewer throws a server error when trying to preview the dataset.
```
Message: Extraction protocol 'train' for file at 'https://raw.githubusercontent.com/teropa/nlp/master/resources/corpora/conll2002/esp.train' is not implemen... | [
"Hi ! Thanks for reporting :)\r\n\r\nThis is related to https://github.com/huggingface/datasets/issues/2742, I'm working on it. It should fix the viewer for around 80 datasets.\r\n",
"Ah, hadn't seen that sorry.\r\n\r\nThe scrambled \"point of contact\" is a separate issue though, I think.",
"@lhoestq The \"poi... |
https://api.github.com/repos/huggingface/datasets/issues/3187 | 3,187 | Add ChrF(++) (as implemented in sacrebleu) | Similar to my [PR for TER](https://github.com/huggingface/datasets/pull/3153), it feels only right to also include ChrF and friends. These are present in Sacrebleu and are therefore very similar to implement as TER and sacrebleu. I tested the implementation with sacrebleu's tests to verify. You can try this below for y... | closed | 2021-10-31T08:53:58 | https://api.github.com/repos/huggingface/datasets/issues/3187/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3187",
"html_url": "https://github.com/huggingface/datasets/pull/3187",
"diff_url": "https://github.com/huggingface/datasets/pull/3187.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3187.patch",
"merged_at": "2021-11-02T14:31... | true | Add ChrF(++) (as implemented in sacrebleu)
Similar to my [PR for TER](https://github.com/huggingface/datasets/pull/3153), it feels only right to also include ChrF and friends. These are present in Sacrebleu and are therefore very similar to implement as TER and sacrebleu. I tested the implementation with sacrebleu's te... | [] |
https://api.github.com/repos/huggingface/datasets/issues/3186 | 3,186 | Dataset viewer for nli_tr | ## Dataset viewer issue for '*nli_tr*'
**Link:** https://huggingface.co/datasets/nli_tr
Hello,
Thank you for the new dataset preview feature that will help the users to view the datasets online.
We just noticed that the dataset viewer widget in the `nli_tr` dataset shows the error below. The error must be d... | closed | 2021-10-31T03:56:33 | https://api.github.com/repos/huggingface/datasets/issues/3186/comments | null | false | Dataset viewer for nli_tr
## Dataset viewer issue for '*nli_tr*'
**Link:** https://huggingface.co/datasets/nli_tr
Hello,
Thank you for the new dataset preview feature that will help the users to view the datasets online.
We just noticed that the dataset viewer widget in the `nli_tr` dataset shows the error ... | [
"It's an issue with the streaming mode:\r\n\r\n```python\r\n>>> import datasets\r\n>>> dataset = datasets.load_dataset('nli_tr', name='snli_tr',split='test', streaming=True)\r\n>>> next(iter(dataset))\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/home/slesage/hf/datas... |
https://api.github.com/repos/huggingface/datasets/issues/3185 | 3,185 | 7z dataset preview not implemented? | ## Dataset viewer issue for dataset 'samsum'
**Link:** https://huggingface.co/datasets/samsum
Server Error
Status code: 400
Exception: NotImplementedError
Message: Extraction protocol '7z' for file at 'https://arxiv.org/src/1911.12237v2/anc/corpus.7z' is not implemented yet
| closed | 2021-10-30T20:18:27 | https://api.github.com/repos/huggingface/datasets/issues/3185/comments | null | false | 7z dataset preview not implemented?
## Dataset viewer issue for dataset 'samsum'
**Link:** https://huggingface.co/datasets/samsum
Server Error
Status code: 400
Exception: NotImplementedError
Message: Extraction protocol '7z' for file at 'https://arxiv.org/src/1911.12237v2/anc/corpus.7z' is not impl... | [
"It's a bug in the dataset viewer: the dataset cannot be downloaded in streaming mode, but since the dataset is relatively small, the dataset viewer should have fallback to normal mode. Working on a fix.",
"Fixed. https://huggingface.co/datasets/samsum/viewer/samsum/train\r\n\r\n<img width=\"1563\" alt=\"Capture ... |
https://api.github.com/repos/huggingface/datasets/issues/3184 | 3,184 | RONEC v2 | Hi, as we've recently finished with the new RONEC (Romanian Named Entity Corpus), we'd like to update the dataset here as well. It's actually essential as links to V1 are no longer valid.
In reality we'd like to replace completely v1, as v2 is a full re-annotation of v1 with additional data (up to 2x size vs v1).
... | closed | 2021-10-30T10:50:03 | https://api.github.com/repos/huggingface/datasets/issues/3184/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3184",
"html_url": "https://github.com/huggingface/datasets/pull/3184",
"diff_url": "https://github.com/huggingface/datasets/pull/3184.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3184.patch",
"merged_at": "2021-11-02T16:02... | true | RONEC v2
Hi, as we've recently finished with the new RONEC (Romanian Named Entity Corpus), we'd like to update the dataset here as well. It's actually essential as links to V1 are no longer valid.
In reality we'd like to replace completely v1, as v2 is a full re-annotation of v1 with additional data (up to 2x size ... | [
"@lhoestq Thanks for the review. I totally understand what you are saying. Normally, I would definitely agree with you, but in this particular case, the quality of v1 is poor, and the dataset itself is small (at the time we created v1 it was the only RO NER dataset, and its size was limited by the available resourc... |
https://api.github.com/repos/huggingface/datasets/issues/3183 | 3,183 | Add missing docstring to DownloadConfig | Document the `use_etag` and `num_proc` attributes in `DownloadConig`. | closed | 2021-10-29T16:56:35 | https://api.github.com/repos/huggingface/datasets/issues/3183/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3183",
"html_url": "https://github.com/huggingface/datasets/pull/3183",
"diff_url": "https://github.com/huggingface/datasets/pull/3183.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3183.patch",
"merged_at": "2021-11-02T10:25... | true | Add missing docstring to DownloadConfig
Document the `use_etag` and `num_proc` attributes in `DownloadConig`. | [] |
https://api.github.com/repos/huggingface/datasets/issues/3182 | 3,182 | Don't memoize strings when hashing since two identical strings may have different python ids | When hashing an object that has several times the same string, the hashing could return a different hash if the identical strings share the same python `id()` or not.
Here is an example code that shows how the issue can affect the caching:
```python
import json
import pyarrow as pa
from datasets.features import ... | closed | 2021-10-29T16:26:17 | https://api.github.com/repos/huggingface/datasets/issues/3182/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3182",
"html_url": "https://github.com/huggingface/datasets/pull/3182",
"diff_url": "https://github.com/huggingface/datasets/pull/3182.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3182.patch",
"merged_at": "2021-11-02T09:35... | true | Don't memoize strings when hashing since two identical strings may have different python ids
When hashing an object that has several times the same string, the hashing could return a different hash if the identical strings share the same python `id()` or not.
Here is an example code that shows how the issue can affe... | [
"This change slows down the hash computation a little bit but from my tests it doesn't look too impactful. So I think it's fine to merge this."
] |
https://api.github.com/repos/huggingface/datasets/issues/3181 | 3,181 | `None` converted to `"None"` when loading a dataset | ## Describe the bug
When loading a dataset `None` values of the type `NoneType` are converted to `'None'` of the type `str`.
## Steps to reproduce the bug
```python
from datasets import load_dataset
qasper = load_dataset("qasper", split="train", download_mode="reuse_cache_if_exists")
print(qasper[60]["full_text... | closed | 2021-10-29T15:23:53 | https://api.github.com/repos/huggingface/datasets/issues/3181/comments | null | false | `None` converted to `"None"` when loading a dataset
## Describe the bug
When loading a dataset `None` values of the type `NoneType` are converted to `'None'` of the type `str`.
## Steps to reproduce the bug
```python
from datasets import load_dataset
qasper = load_dataset("qasper", split="train", download_mode="... | [
"Hi @eladsegal, thanks for reporting.\r\n\r\n@mariosasko I saw you are already working on this, but maybe my comment will be useful to you.\r\n\r\nAll values are casted to their corresponding feature type (including `None` values). For example if the feature type is `Value(\"bool\")`, `None` is casted to `False`.\r... |
https://api.github.com/repos/huggingface/datasets/issues/3180 | 3,180 | fix label mapping | Fixing label mapping for hlgd.
0 correponds to same event and 1 corresponds to different event
<img width="642" alt="Capture d’écran 2021-10-29 à 10 39 58 AM" src="https://user-images.githubusercontent.com/16107619/139454810-1f225e3d-ad48-44a8-b8b1-9205c9533839.png">
<img width="638" alt="Capture d’écran 2021-10-... | closed | 2021-10-29T14:42:24 | https://api.github.com/repos/huggingface/datasets/issues/3180/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3180",
"html_url": "https://github.com/huggingface/datasets/pull/3180",
"diff_url": "https://github.com/huggingface/datasets/pull/3180.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3180.patch",
"merged_at": "2021-11-02T10:37... | true | fix label mapping
Fixing label mapping for hlgd.
0 correponds to same event and 1 corresponds to different event
<img width="642" alt="Capture d’écran 2021-10-29 à 10 39 58 AM" src="https://user-images.githubusercontent.com/16107619/139454810-1f225e3d-ad48-44a8-b8b1-9205c9533839.png">
<img width="638" alt="Capture... | [
"heck, test failings. moving to draft. will come back to this later today hopefully",
"Thanks for fixing this :)\r\nI just updated the dataset_infos.json and added the missing `pretty_name` tag to the dataset card",
"thank you @lhoestq! running around as always it felt through as a lower priority..."
] |
https://api.github.com/repos/huggingface/datasets/issues/3179 | 3,179 | Cannot load dataset when the config name is "special" | ## Describe the bug
After https://github.com/huggingface/datasets/pull/3159, we can get the config name of "Check/region_1", which is "Check___region_1".
But now we cannot load the dataset (not sure it's related to the above PR though). It's the case for all the similar datasets, listed in https://github.com/hugg... | closed | 2021-10-29T13:30:47 | https://api.github.com/repos/huggingface/datasets/issues/3179/comments | null | false | Cannot load dataset when the config name is "special"
## Describe the bug
After https://github.com/huggingface/datasets/pull/3159, we can get the config name of "Check/region_1", which is "Check___region_1".
But now we cannot load the dataset (not sure it's related to the above PR though). It's the case for all t... | [
"The issue is that the datasets are malformed. Not a bug with the datasets library"
] |
https://api.github.com/repos/huggingface/datasets/issues/3178 | 3,178 | "Property couldn't be hashed properly" even though fully picklable | ## Describe the bug
I am trying to tokenize a dataset with spaCy. I found that no matter what I do, the spaCy language object (`nlp`) prevents `datasets` from pickling correctly - or so the warning says - even though manually pickling is no issue. It should not be an issue either, since spaCy objects are picklable.
... | closed | 2021-10-29T12:56:09 | https://api.github.com/repos/huggingface/datasets/issues/3178/comments | null | false | "Property couldn't be hashed properly" even though fully picklable
## Describe the bug
I am trying to tokenize a dataset with spaCy. I found that no matter what I do, the spaCy language object (`nlp`) prevents `datasets` from pickling correctly - or so the warning says - even though manually pickling is no issue. It s... | [
"After some digging, I found that this is caused by `dill` and using `recurse=True)` when trying to dump the object. The problem also occurs without multiprocessing. I can only find [the following information](https://dill.readthedocs.io/en/latest/dill.html#dill._dill.dumps) about this:\r\n\r\n> If recurse=True, th... |
https://api.github.com/repos/huggingface/datasets/issues/3177 | 3,177 | More control over TQDM when using map/filter with multiple processes | It would help with the clutter in my terminal if tqdm is only shown for rank 0 when using `num_proces>0` in the map and filter methods of datasets.
```python
dataset.map(lambda examples: tokenize(examples["text"]), batched=True, num_proc=6)
```
The above snippet leads to a lot of TQDM bars and depending on your... | closed | 2021-10-29T11:56:16 | https://api.github.com/repos/huggingface/datasets/issues/3177/comments | null | false | More control over TQDM when using map/filter with multiple processes
It would help with the clutter in my terminal if tqdm is only shown for rank 0 when using `num_proces>0` in the map and filter methods of datasets.
```python
dataset.map(lambda examples: tokenize(examples["text"]), batched=True, num_proc=6)
```
... | [
"Hi,\r\n\r\nIt's hard to provide an API that would cover all use-cases with tqdm in this project.\r\n\r\nHowever, you can make it work by defining a custom decorator (a bit hacky tho) as follows:\r\n```python\r\nimport datasets\r\n\r\ndef progress_only_on_rank_0(func):\r\n def wrapper(*args, **kwargs):\r\n ... |
https://api.github.com/repos/huggingface/datasets/issues/3176 | 3,176 | OpenSLR dataset: update generate_examples to properly extract data for SLR83 | Fixed #3168.
The SLR38 indices are CSV files and there wasn't any code in openslr.py to process these files properly. The end result was an empty table.
I've added code to properly process these CSV files. | closed | 2021-10-29T00:59:27 | https://api.github.com/repos/huggingface/datasets/issues/3176/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3176",
"html_url": "https://github.com/huggingface/datasets/pull/3176",
"diff_url": "https://github.com/huggingface/datasets/pull/3176.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3176.patch",
"merged_at": "2021-10-29T10:04... | true | OpenSLR dataset: update generate_examples to properly extract data for SLR83
Fixed #3168.
The SLR38 indices are CSV files and there wasn't any code in openslr.py to process these files properly. The end result was an empty table.
I've added code to properly process these CSV files. | [
"Also fix #3125."
] |
https://api.github.com/repos/huggingface/datasets/issues/3175 | 3,175 | Add docs for `to_tf_dataset` | This PR adds some documentation for new features released in v1.13.0, with the main addition being `to_tf_dataset`:
- Show how to use `to_tf_dataset` in the tutorial, and move `set_format(type='tensorflow'...)` to the Process section (let me know if I'm missing anything @Rocketknight1 😅).
- Add an example for load... | closed | 2021-10-28T20:55:22 | https://api.github.com/repos/huggingface/datasets/issues/3175/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3175",
"html_url": "https://github.com/huggingface/datasets/pull/3175",
"diff_url": "https://github.com/huggingface/datasets/pull/3175.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3175.patch",
"merged_at": "2021-11-03T10:07... | true | Add docs for `to_tf_dataset`
This PR adds some documentation for new features released in v1.13.0, with the main addition being `to_tf_dataset`:
- Show how to use `to_tf_dataset` in the tutorial, and move `set_format(type='tensorflow'...)` to the Process section (let me know if I'm missing anything @Rocketknight1 😅... | [
"This looks great, thank you!",
"Thanks !\r\n\r\nFor some reason the new GIF is 6MB, which is a bit heavy for an image on a website. The previous one was around 200KB though which is perfect. For a good experience we usually expect images to be less than 500KB - otherwise for users with poor connection it takes t... |
https://api.github.com/repos/huggingface/datasets/issues/3174 | 3,174 | Asserts replaced by exceptions (huggingface#3171) | I've replaced two asserts with their proper exceptions following the guidelines described in issue #3171 by following the contributing guidelines.
PS: This is one of my first PRs, hoping I don't break anything! | closed | 2021-10-28T11:55:45 | https://api.github.com/repos/huggingface/datasets/issues/3174/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3174",
"html_url": "https://github.com/huggingface/datasets/pull/3174",
"diff_url": "https://github.com/huggingface/datasets/pull/3174.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3174.patch",
"merged_at": "2021-10-29T13:08... | true | Asserts replaced by exceptions (huggingface#3171)
I've replaced two asserts with their proper exceptions following the guidelines described in issue #3171 by following the contributing guidelines.
PS: This is one of my first PRs, hoping I don't break anything! | [
"Your first PR went smoothly, well done!\r\nYou are welcome to continue contributing to this project.\r\nGràcies, @joseporiolayats! 😉 "
] |
https://api.github.com/repos/huggingface/datasets/issues/3173 | 3,173 | Fix issue with filelock filename being too long on encrypted filesystems | Infer max filename length in filelock on Unix-like systems. Should fix problems on encrypted filesystems such as eCryptfs.
Fix #2924
cc: @lmmx | closed | 2021-10-28T11:28:57 | https://api.github.com/repos/huggingface/datasets/issues/3173/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3173",
"html_url": "https://github.com/huggingface/datasets/pull/3173",
"diff_url": "https://github.com/huggingface/datasets/pull/3173.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3173.patch",
"merged_at": "2021-10-29T09:42... | true | Fix issue with filelock filename being too long on encrypted filesystems
Infer max filename length in filelock on Unix-like systems. Should fix problems on encrypted filesystems such as eCryptfs.
Fix #2924
cc: @lmmx | [] |
https://api.github.com/repos/huggingface/datasets/issues/3172 | 3,172 | `SystemError 15` thrown in `Dataset.__del__` when using `Dataset.map()` with `num_proc>1` | ## Describe the bug
I use `datasets.map` to preprocess some data in my application. The error `SystemError 15` is thrown at the end of the execution of `Dataset.map()` (only with `num_proc>1`. Traceback included bellow.
The exception is raised only when the code runs within a specific context. Despite ~10h spent ... | closed | 2021-10-28T10:29:00 | https://api.github.com/repos/huggingface/datasets/issues/3172/comments | null | false | `SystemError 15` thrown in `Dataset.__del__` when using `Dataset.map()` with `num_proc>1`
## Describe the bug
I use `datasets.map` to preprocess some data in my application. The error `SystemError 15` is thrown at the end of the execution of `Dataset.map()` (only with `num_proc>1`. Traceback included bellow.
The ... | [
"NB: even if the error is raised, the dataset is successfully cached. So restarting the script after every `map()` allows to ultimately run the whole preprocessing. But this prevents to realistically run the code over multiple nodes.",
"Hi,\r\n\r\nIt's not easy to debug the problem without the script. I may be wr... |
https://api.github.com/repos/huggingface/datasets/issues/3171 | 3,171 | Raise exceptions instead of using assertions for control flow | Motivated by https://github.com/huggingface/transformers/issues/12789 in Transformers, one welcoming change would be replacing assertions with proper exceptions. The only type of assertions we should keep are those used as sanity checks.
Currently, there is a total of 87 files with the `assert` statements (located u... | closed | 2021-10-27T18:26:52 | https://api.github.com/repos/huggingface/datasets/issues/3171/comments | null | false | Raise exceptions instead of using assertions for control flow
Motivated by https://github.com/huggingface/transformers/issues/12789 in Transformers, one welcoming change would be replacing assertions with proper exceptions. The only type of assertions we should keep are those used as sanity checks.
Currently, there ... | [
"Adding the remaining tasks for this issue to help new code contributors. \r\n$ cd src/datasets && ack assert -lc \r\n- [x] commands/convert.py:1\r\n- [x] arrow_reader.py:3\r\n- [x] load.py:7\r\n- [x] utils/py_utils.py:2\r\n- [x] features/features.py:9\r\n- [x] arrow_writer.py:7\r\n- [x] search.py:6\r\n- [x] table... |
https://api.github.com/repos/huggingface/datasets/issues/3170 | 3,170 | Preserve ordering in `zip_dict` | Replace `set` with the `unique_values` generator in `zip_dict`.
This PR fixes the problem with the different ordering of the example keys across different Python sessions caused by the `zip_dict` call in `Features.decode_example`. | closed | 2021-10-27T16:07:30 | https://api.github.com/repos/huggingface/datasets/issues/3170/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3170",
"html_url": "https://github.com/huggingface/datasets/pull/3170",
"diff_url": "https://github.com/huggingface/datasets/pull/3170.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3170.patch",
"merged_at": "2021-10-29T13:09... | true | Preserve ordering in `zip_dict`
Replace `set` with the `unique_values` generator in `zip_dict`.
This PR fixes the problem with the different ordering of the example keys across different Python sessions caused by the `zip_dict` call in `Features.decode_example`. | [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.