url stringlengths 58 61 | number int64 1 8.23k | title stringlengths 1 290 | body stringlengths 0 228k ⌀ | state stringclasses 2
values | created_at timestamp[s]date 2020-04-14 10:18:02 2026-05-30 09:38:59 | comments_url stringlengths 67 70 | pull_request dict | is_pull_request bool 2
classes | text stringlengths 2 228k | comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/datasets/issues/119 | 119 | 🐛 Colab : type object 'pyarrow.lib.RecordBatch' has no attribute 'from_struct_array' | I'm trying to load CNN/DM dataset on Colab.
[Colab notebook](https://colab.research.google.com/drive/11Mf7iNhIyt6GpgA1dBEtg3cyMHmMhtZS?usp=sharing)
But I meet this error :
> AttributeError: type object 'pyarrow.lib.RecordBatch' has no attribute 'from_struct_array'
| closed | 2020-05-15T02:27:26 | https://api.github.com/repos/huggingface/datasets/issues/119/comments | null | false | 🐛 Colab : type object 'pyarrow.lib.RecordBatch' has no attribute 'from_struct_array'
I'm trying to load CNN/DM dataset on Colab.
[Colab notebook](https://colab.research.google.com/drive/11Mf7iNhIyt6GpgA1dBEtg3cyMHmMhtZS?usp=sharing)
But I meet this error :
> AttributeError: type object 'pyarrow.lib.RecordBatc... | [
"It's strange, after installing `nlp` on Colab, the `pyarrow` version seems fine from `pip` but not from python :\r\n\r\n```python\r\nimport pyarrow\r\n\r\n!pip show pyarrow\r\nprint(\"version = {}\".format(pyarrow.__version__))\r\n```\r\n\r\n> Name: pyarrow\r\nVersion: 0.17.0\r\nSummary: Python library for Apache ... |
https://api.github.com/repos/huggingface/datasets/issues/118 | 118 | ❓ How to apply a map to all subsets ? | I'm working with CNN/DM dataset, where I have 3 subsets : `train`, `test`, `validation`.
Should I apply my map function on the subsets one by one ?
```python
import nlp
cnn_dm = nlp.load_dataset('cnn_dailymail')
for corpus in ['train', 'test', 'validation']:
cnn_dm[corpus] = cnn_dm[corpus].map(my_f... | closed | 2020-05-15T01:58:52 | https://api.github.com/repos/huggingface/datasets/issues/118/comments | null | false | ❓ How to apply a map to all subsets ?
I'm working with CNN/DM dataset, where I have 3 subsets : `train`, `test`, `validation`.
Should I apply my map function on the subsets one by one ?
```python
import nlp
cnn_dm = nlp.load_dataset('cnn_dailymail')
for corpus in ['train', 'test', 'validation']:
cn... | [
"That's the way!"
] |
https://api.github.com/repos/huggingface/datasets/issues/117 | 117 | ❓ How to remove specific rows of a dataset ? | I saw on the [example notebook](https://colab.research.google.com/github/huggingface/nlp/blob/master/notebooks/Overview.ipynb#scrollTo=efFhDWhlvSVC) how to remove a specific column :
```python
dataset.drop('id')
```
But I didn't find how to remove a specific row.
**For example, how can I remove all sample w... | closed | 2020-05-15T01:25:06 | https://api.github.com/repos/huggingface/datasets/issues/117/comments | null | false | ❓ How to remove specific rows of a dataset ?
I saw on the [example notebook](https://colab.research.google.com/github/huggingface/nlp/blob/master/notebooks/Overview.ipynb#scrollTo=efFhDWhlvSVC) how to remove a specific column :
```python
dataset.drop('id')
```
But I didn't find how to remove a specific row.
... | [
"Hi, you can't do that at the moment.",
"Can you do it by now? Coz it would be awfully helpful!",
"you can convert dataset object to pandas and remove a feature and convert back to dataset .",
"That's what I ended up doing too. but it feels like a workaround to a feature that should be added to the datasets c... |
https://api.github.com/repos/huggingface/datasets/issues/116 | 116 | 🐛 Trying to use ROUGE metric : pyarrow.lib.ArrowInvalid: Column 1 named references expected length 534 but got length 323 | I'm trying to use rouge metric.
I have to files : `test.pred.tokenized` and `test.gold.tokenized` with each line containing a sentence.
I tried :
```python
import nlp
rouge = nlp.load_metric('rouge')
with open("test.pred.tokenized") as p, open("test.gold.tokenized") as g:
for lp, lg in zip(p, g):
... | closed | 2020-05-15T01:12:06 | https://api.github.com/repos/huggingface/datasets/issues/116/comments | null | false | 🐛 Trying to use ROUGE metric : pyarrow.lib.ArrowInvalid: Column 1 named references expected length 534 but got length 323
I'm trying to use rouge metric.
I have to files : `test.pred.tokenized` and `test.gold.tokenized` with each line containing a sentence.
I tried :
```python
import nlp
rouge = nlp.load_... | [
"Can you share your data files or a minimally reproducible example?",
"Sure, [here is a Colab notebook](https://colab.research.google.com/drive/1uiS89fnHMG7HV_cYxp3r-_LqJQvNNKs9?usp=sharing) reproducing the error.\r\n\r\n> ArrowInvalid: Column 1 named references expected length 36 but got length 56",
"This is b... |
https://api.github.com/repos/huggingface/datasets/issues/115 | 115 | AttributeError: 'dict' object has no attribute 'info' | I'm trying to access the information of CNN/DM dataset :
```python
cnn_dm = nlp.load_dataset('cnn_dailymail')
print(cnn_dm.info)
```
returns :
> AttributeError: 'dict' object has no attribute 'info' | closed | 2020-05-15T00:29:47 | https://api.github.com/repos/huggingface/datasets/issues/115/comments | null | false | AttributeError: 'dict' object has no attribute 'info'
I'm trying to access the information of CNN/DM dataset :
```python
cnn_dm = nlp.load_dataset('cnn_dailymail')
print(cnn_dm.info)
```
returns :
> AttributeError: 'dict' object has no attribute 'info' | [
"I could access the info by first accessing the different splits :\r\n\r\n```python\r\nimport nlp\r\n\r\ncnn_dm = nlp.load_dataset('cnn_dailymail')\r\nprint(cnn_dm['train'].info)\r\n```\r\n\r\nInformation seems to be duplicated between the subsets :\r\n\r\n```python\r\nprint(cnn_dm[\"train\"].info == cnn_dm[\"test\... |
https://api.github.com/repos/huggingface/datasets/issues/114 | 114 | Couldn't reach CNN/DM dataset | I can't get CNN / DailyMail dataset.
```python
import nlp
assert "cnn_dailymail" in [dataset.id for dataset in nlp.list_datasets()]
cnn_dm = nlp.load_dataset('cnn_dailymail')
```
[Colab notebook](https://colab.research.google.com/drive/1zQ3bYAVzm1h0mw0yWPqKAg_4EUlSx5Ex?usp=sharing)
gives following error ... | closed | 2020-05-15T00:16:17 | https://api.github.com/repos/huggingface/datasets/issues/114/comments | null | false | Couldn't reach CNN/DM dataset
I can't get CNN / DailyMail dataset.
```python
import nlp
assert "cnn_dailymail" in [dataset.id for dataset in nlp.list_datasets()]
cnn_dm = nlp.load_dataset('cnn_dailymail')
```
[Colab notebook](https://colab.research.google.com/drive/1zQ3bYAVzm1h0mw0yWPqKAg_4EUlSx5Ex?usp=shar... | [
"Installing from source (instead of Pypi package) solved the problem."
] |
https://api.github.com/repos/huggingface/datasets/issues/113 | 113 | Adding docstrings and some doc | Some doc | closed | 2020-05-14T23:14:41 | https://api.github.com/repos/huggingface/datasets/issues/113/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/113",
"html_url": "https://github.com/huggingface/datasets/pull/113",
"diff_url": "https://github.com/huggingface/datasets/pull/113.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/113.patch",
"merged_at": "2020-05-14T23:22:44"... | true | Adding docstrings and some doc
Some doc | [] |
https://api.github.com/repos/huggingface/datasets/issues/112 | 112 | Qa4mre - add dataset | Added dummy data test only for the first config. Will do the rest later.
I had to do add some minor hacks to an important function to make it work.
There might be a cleaner way to handle it - can you take a look @thomwolf ? | closed | 2020-05-14T22:17:51 | https://api.github.com/repos/huggingface/datasets/issues/112/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/112",
"html_url": "https://github.com/huggingface/datasets/pull/112",
"diff_url": "https://github.com/huggingface/datasets/pull/112.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/112.patch",
"merged_at": "2020-05-15T09:16:42"... | true | Qa4mre - add dataset
Added dummy data test only for the first config. Will do the rest later.
I had to do add some minor hacks to an important function to make it work.
There might be a cleaner way to handle it - can you take a look @thomwolf ? | [] |
https://api.github.com/repos/huggingface/datasets/issues/111 | 111 | [Clean-up] remove under construction datastes | closed | 2020-05-14T20:52:13 | https://api.github.com/repos/huggingface/datasets/issues/111/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/111",
"html_url": "https://github.com/huggingface/datasets/pull/111",
"diff_url": "https://github.com/huggingface/datasets/pull/111.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/111.patch",
"merged_at": "2020-05-14T20:52:22"... | true | [Clean-up] remove under construction datastes
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/110 | 110 | fix reddit tifu dummy data | closed | 2020-05-14T20:37:37 | https://api.github.com/repos/huggingface/datasets/issues/110/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/110",
"html_url": "https://github.com/huggingface/datasets/pull/110",
"diff_url": "https://github.com/huggingface/datasets/pull/110.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/110.patch",
"merged_at": "2020-05-14T20:40:13"... | true | fix reddit tifu dummy data
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/109 | 109 | [Reclor] fix reclor | - That's probably one me. Could have made the manual data test more flexible. @mariamabarham | closed | 2020-05-14T20:16:26 | https://api.github.com/repos/huggingface/datasets/issues/109/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/109",
"html_url": "https://github.com/huggingface/datasets/pull/109",
"diff_url": "https://github.com/huggingface/datasets/pull/109.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/109.patch",
"merged_at": "2020-05-14T20:19:08"... | true | [Reclor] fix reclor
- That's probably one me. Could have made the manual data test more flexible. @mariamabarham | [] |
https://api.github.com/repos/huggingface/datasets/issues/108 | 108 | convert can use manual dir as second argument | @mariamabarham | closed | 2020-05-14T16:52:32 | https://api.github.com/repos/huggingface/datasets/issues/108/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/108",
"html_url": "https://github.com/huggingface/datasets/pull/108",
"diff_url": "https://github.com/huggingface/datasets/pull/108.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/108.patch",
"merged_at": "2020-05-14T16:52:42"... | true | convert can use manual dir as second argument
@mariamabarham | [] |
https://api.github.com/repos/huggingface/datasets/issues/107 | 107 | add writer_batch_size to GeneratorBasedBuilder | You can now specify `writer_batch_size` in the builder arguments or directly in `load_dataset` | closed | 2020-05-14T16:35:39 | https://api.github.com/repos/huggingface/datasets/issues/107/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/107",
"html_url": "https://github.com/huggingface/datasets/pull/107",
"diff_url": "https://github.com/huggingface/datasets/pull/107.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/107.patch",
"merged_at": "2020-05-14T16:50:29"... | true | add writer_batch_size to GeneratorBasedBuilder
You can now specify `writer_batch_size` in the builder arguments or directly in `load_dataset` | [
"Awesome that's great!"
] |
https://api.github.com/repos/huggingface/datasets/issues/106 | 106 | Add data dir test command | closed | 2020-05-14T16:18:39 | https://api.github.com/repos/huggingface/datasets/issues/106/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/106",
"html_url": "https://github.com/huggingface/datasets/pull/106",
"diff_url": "https://github.com/huggingface/datasets/pull/106.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/106.patch",
"merged_at": "2020-05-14T16:49:10"... | true | Add data dir test command
| [
"Nice - I think we can merge this. I will update the checksums for `wikihow` then as well"
] | |
https://api.github.com/repos/huggingface/datasets/issues/105 | 105 | [New structure on AWS] Adapt paths | Some small changes so that we have the correct paths. @julien-c | closed | 2020-05-14T15:55:57 | https://api.github.com/repos/huggingface/datasets/issues/105/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/105",
"html_url": "https://github.com/huggingface/datasets/pull/105",
"diff_url": "https://github.com/huggingface/datasets/pull/105.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/105.patch",
"merged_at": "2020-05-14T15:56:27"... | true | [New structure on AWS] Adapt paths
Some small changes so that we have the correct paths. @julien-c | [] |
https://api.github.com/repos/huggingface/datasets/issues/104 | 104 | Add trivia_q | Currently tested only for one config to pass tests. Needs to add more dummy data later. | closed | 2020-05-14T14:27:19 | https://api.github.com/repos/huggingface/datasets/issues/104/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/104",
"html_url": "https://github.com/huggingface/datasets/pull/104",
"diff_url": "https://github.com/huggingface/datasets/pull/104.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/104.patch",
"merged_at": "2020-05-14T20:23:32"... | true | Add trivia_q
Currently tested only for one config to pass tests. Needs to add more dummy data later. | [] |
https://api.github.com/repos/huggingface/datasets/issues/103 | 103 | [Manual downloads] add logic proposal for manual downloads and add wikihow | Wikihow is an example that needs to manually download two files as stated in: https://github.com/mahnazkoupaee/WikiHow-Dataset.
The user can then store these files under a hard-coded name: `wikihowAll.csv` and `wikihowSep.csv` in this case in a directory of his choice, e.g. `~/wikihow/manual_dir`.
The dataset ca... | closed | 2020-05-14T13:30:36 | https://api.github.com/repos/huggingface/datasets/issues/103/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/103",
"html_url": "https://github.com/huggingface/datasets/pull/103",
"diff_url": "https://github.com/huggingface/datasets/pull/103.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/103.patch",
"merged_at": "2020-05-14T14:27:40"... | true | [Manual downloads] add logic proposal for manual downloads and add wikihow
Wikihow is an example that needs to manually download two files as stated in: https://github.com/mahnazkoupaee/WikiHow-Dataset.
The user can then store these files under a hard-coded name: `wikihowAll.csv` and `wikihowSep.csv` in this case i... | [
"> Wikihow is an example that needs to manually download two files as stated in: https://github.com/mahnazkoupaee/WikiHow-Dataset.\r\n> \r\n> The user can then store these files under a hard-coded name: `wikihowAll.csv` and `wikihowSep.csv` in this case in a directory of his choice, e.g. `~/wikihow/manual_dir`.\r\n... |
https://api.github.com/repos/huggingface/datasets/issues/102 | 102 | Run save infos | I replaced the old checksum file with the new `dataset_infos.json` by running the script on almost all the datasets we have. The only one that is still running on my side is the cornell dialog | closed | 2020-05-14T13:27:26 | https://api.github.com/repos/huggingface/datasets/issues/102/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/102",
"html_url": "https://github.com/huggingface/datasets/pull/102",
"diff_url": "https://github.com/huggingface/datasets/pull/102.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/102.patch",
"merged_at": "2020-05-14T15:43:03"... | true | Run save infos
I replaced the old checksum file with the new `dataset_infos.json` by running the script on almost all the datasets we have. The only one that is still running on my side is the cornell dialog | [
"Haha that cornell dialogue dataset - that ran for 3h on my computer as well. The `generate_examples` method in this script is one of the most inefficient code samples I've ever seen :D ",
"Indeed it's been 3 hours already\r\n```73111 examples [3:07:48, 2.40 examples/s]```"
] |
https://api.github.com/repos/huggingface/datasets/issues/101 | 101 | [Reddit] add reddit | - Everything worked fine @mariamabarham. Made my computer nearly crash, but all seems to be working :-) | closed | 2020-05-14T10:25:02 | https://api.github.com/repos/huggingface/datasets/issues/101/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/101",
"html_url": "https://github.com/huggingface/datasets/pull/101",
"diff_url": "https://github.com/huggingface/datasets/pull/101.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/101.patch",
"merged_at": "2020-05-14T10:27:24"... | true | [Reddit] add reddit
- Everything worked fine @mariamabarham. Made my computer nearly crash, but all seems to be working :-) | [] |
https://api.github.com/repos/huggingface/datasets/issues/100 | 100 | Add per type scores in seqeval metric | This PR add a bit more detail in the seqeval metric. Now the usage and output are:
```python
import nlp
met = nlp.load_metric('metrics/seqeval')
references = [['O', 'O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'O'], ['B-PER', 'I-PER', 'O']]
predictions = [['O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'I-MISC', 'O'], ['B-... | closed | 2020-05-14T09:37:52 | https://api.github.com/repos/huggingface/datasets/issues/100/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/100",
"html_url": "https://github.com/huggingface/datasets/pull/100",
"diff_url": "https://github.com/huggingface/datasets/pull/100.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/100.patch",
"merged_at": "2020-05-14T23:21:34"... | true | Add per type scores in seqeval metric
This PR add a bit more detail in the seqeval metric. Now the usage and output are:
```python
import nlp
met = nlp.load_metric('metrics/seqeval')
references = [['O', 'O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'O'], ['B-PER', 'I-PER', 'O']]
predictions = [['O', 'O', 'B-MISC', 'I... | [
"LGTM :-) Some small suggestions to shorten the code a bit :-) ",
"Can you put the kwargs as normal kwargs instead of a dict? (And add them to the kwargs description As well)",
"@thom Is-it what you meant?",
"Yes and there is a dynamically generated doc string in the metric script KWARGS DESCRIPTION"
] |
https://api.github.com/repos/huggingface/datasets/issues/99 | 99 | [Cmrc 2018] fix cmrc2018 | closed | 2020-05-14T08:22:03 | https://api.github.com/repos/huggingface/datasets/issues/99/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/99",
"html_url": "https://github.com/huggingface/datasets/pull/99",
"diff_url": "https://github.com/huggingface/datasets/pull/99.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/99.patch",
"merged_at": "2020-05-14T08:49:41"
} | true | [Cmrc 2018] fix cmrc2018
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/98 | 98 | Webis tl-dr | Add the Webid TL:DR dataset. | closed | 2020-05-14T06:22:18 | https://api.github.com/repos/huggingface/datasets/issues/98/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/98",
"html_url": "https://github.com/huggingface/datasets/pull/98",
"diff_url": "https://github.com/huggingface/datasets/pull/98.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/98.patch",
"merged_at": "2020-05-14T20:54:15"
} | true | Webis tl-dr
Add the Webid TL:DR dataset. | [
"Should that rather be in an organization scope, @thomwolf @patrickvonplaten ?",
"> Should that rather be in an organization scope, @thomwolf @patrickvonplaten ?\r\n\r\nI'm a bit indifferent - both would be fine for me!",
"@jplu - if creating the dummy_data is too tedious, I can do it as well :-) ",
"There is... |
https://api.github.com/repos/huggingface/datasets/issues/97 | 97 | [Csv] add tests for csv dataset script | Adds dummy data tests for csv. | closed | 2020-05-13T23:06:11 | https://api.github.com/repos/huggingface/datasets/issues/97/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/97",
"html_url": "https://github.com/huggingface/datasets/pull/97",
"diff_url": "https://github.com/huggingface/datasets/pull/97.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/97.patch",
"merged_at": "2020-05-13T23:23:15"
} | true | [Csv] add tests for csv dataset script
Adds dummy data tests for csv. | [
"@thomwolf - can you check and merge if ok? "
] |
https://api.github.com/repos/huggingface/datasets/issues/96 | 96 | lm1b | Add lm1b dataset. | closed | 2020-05-13T20:38:44 | https://api.github.com/repos/huggingface/datasets/issues/96/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/96",
"html_url": "https://github.com/huggingface/datasets/pull/96",
"diff_url": "https://github.com/huggingface/datasets/pull/96.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/96.patch",
"merged_at": "2020-05-14T14:13:29"
} | true | lm1b
Add lm1b dataset. | [
"I might have a different version of `isort` than others. It seems like I'm always reordering the imports of others. But isn't really a problem..."
] |
https://api.github.com/repos/huggingface/datasets/issues/95 | 95 | Replace checksums files by Dataset infos json | ### Better verifications when loading a dataset
I replaced the `urls_checksums` directory that used to contain `checksums.txt` and `cached_sizes.txt`, by a single file `dataset_infos.json`. It's just a dict `config_name` -> `DatasetInfo`.
It simplifies and improves how verifications of checksums and splits sizes ... | closed | 2020-05-13T19:36:16 | https://api.github.com/repos/huggingface/datasets/issues/95/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/95",
"html_url": "https://github.com/huggingface/datasets/pull/95",
"diff_url": "https://github.com/huggingface/datasets/pull/95.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/95.patch",
"merged_at": "2020-05-14T08:58:42"
} | true | Replace checksums files by Dataset infos json
### Better verifications when loading a dataset
I replaced the `urls_checksums` directory that used to contain `checksums.txt` and `cached_sizes.txt`, by a single file `dataset_infos.json`. It's just a dict `config_name` -> `DatasetInfo`.
It simplifies and improves ho... | [
"Great! LGTM :-) ",
"> Ok, really clean!\r\n> I like the logic (not a huge fan of using `_asdict_inner` but it makes sense).\r\n> I think it's a nice improvement!\r\n> \r\n> How should we update the files in the repo? Run a big job on a server or on somebody's computer who has most of the datasets already downloa... |
https://api.github.com/repos/huggingface/datasets/issues/94 | 94 | Librispeech | Add librispeech dataset and remove some useless content. | closed | 2020-05-13T16:04:14 | https://api.github.com/repos/huggingface/datasets/issues/94/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/94",
"html_url": "https://github.com/huggingface/datasets/pull/94",
"diff_url": "https://github.com/huggingface/datasets/pull/94.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/94.patch",
"merged_at": "2020-05-13T21:29:02"
} | true | Librispeech
Add librispeech dataset and remove some useless content. | [
"@jplu - I changed this weird archieve - iter method to something simpler. It's only one file to download anyways so I don't see the point of using weird iter methods...It's a huge file though :D 30 million lines of text. Took me quite some time to download :D "
] |
https://api.github.com/repos/huggingface/datasets/issues/93 | 93 | Cleanup notebooks and various fixes | Fixes on dataset (more flexible) metrics (fix) and general clean ups | closed | 2020-05-13T14:58:58 | https://api.github.com/repos/huggingface/datasets/issues/93/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/93",
"html_url": "https://github.com/huggingface/datasets/pull/93",
"diff_url": "https://github.com/huggingface/datasets/pull/93.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/93.patch",
"merged_at": "2020-05-13T15:01:47"
} | true | Cleanup notebooks and various fixes
Fixes on dataset (more flexible) metrics (fix) and general clean ups | [] |
https://api.github.com/repos/huggingface/datasets/issues/92 | 92 | [WIP] add wmt14 | WMT14 takes forever to download :-/
- WMT is the first dataset that uses an abstract class IMO, so I had to modify the `load_dataset_module` a bit. | closed | 2020-05-13T10:42:03 | https://api.github.com/repos/huggingface/datasets/issues/92/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/92",
"html_url": "https://github.com/huggingface/datasets/pull/92",
"diff_url": "https://github.com/huggingface/datasets/pull/92.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/92.patch",
"merged_at": "2020-05-16T11:17:37"
} | true | [WIP] add wmt14
WMT14 takes forever to download :-/
- WMT is the first dataset that uses an abstract class IMO, so I had to modify the `load_dataset_module` a bit. | [] |
https://api.github.com/repos/huggingface/datasets/issues/91 | 91 | [Paracrawl] add paracrawl | - Huge dataset - took ~1h to download
- Also this PR reformats all dataset scripts and adds `datasets` to `make style` | closed | 2020-05-13T10:39:00 | https://api.github.com/repos/huggingface/datasets/issues/91/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/91",
"html_url": "https://github.com/huggingface/datasets/pull/91",
"diff_url": "https://github.com/huggingface/datasets/pull/91.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/91.patch",
"merged_at": "2020-05-13T10:40:14"
} | true | [Paracrawl] add paracrawl
- Huge dataset - took ~1h to download
- Also this PR reformats all dataset scripts and adds `datasets` to `make style` | [] |
https://api.github.com/repos/huggingface/datasets/issues/90 | 90 | Add download gg drive | We can now add datasets that download from google drive | closed | 2020-05-13T09:56:02 | https://api.github.com/repos/huggingface/datasets/issues/90/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/90",
"html_url": "https://github.com/huggingface/datasets/pull/90",
"diff_url": "https://github.com/huggingface/datasets/pull/90.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/90.patch",
"merged_at": "2020-05-13T10:05:31"
} | true | Add download gg drive
We can now add datasets that download from google drive | [
"awesome - so no manual downloaded needed here? ",
"Yes exactly. It works like a standard download"
] |
https://api.github.com/repos/huggingface/datasets/issues/89 | 89 | Add list and inspect methods - cleanup hf_api | Add a bunch of methods to easily list and inspect the processing scripts up-loaded on S3:
```python
nlp.list_datasets()
nlp.list_metrics()
# Copy and prepare the scripts at `local_path` for easy inspection/modification.
nlp.inspect_dataset(path, local_path)
# Copy and prepare the scripts at `local_path` for easy... | closed | 2020-05-13T09:30:15 | https://api.github.com/repos/huggingface/datasets/issues/89/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/89",
"html_url": "https://github.com/huggingface/datasets/pull/89",
"diff_url": "https://github.com/huggingface/datasets/pull/89.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/89.patch",
"merged_at": "2020-05-13T09:33:10"
} | true | Add list and inspect methods - cleanup hf_api
Add a bunch of methods to easily list and inspect the processing scripts up-loaded on S3:
```python
nlp.list_datasets()
nlp.list_metrics()
# Copy and prepare the scripts at `local_path` for easy inspection/modification.
nlp.inspect_dataset(path, local_path)
# Copy an... | [] |
https://api.github.com/repos/huggingface/datasets/issues/88 | 88 | Add wiki40b | This one is a beam dataset that downloads files using tensorflow.
I tested it on a small config and it works fine | closed | 2020-05-13T09:16:01 | https://api.github.com/repos/huggingface/datasets/issues/88/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/88",
"html_url": "https://github.com/huggingface/datasets/pull/88",
"diff_url": "https://github.com/huggingface/datasets/pull/88.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/88.patch",
"merged_at": "2020-05-13T12:31:54"
} | true | Add wiki40b
This one is a beam dataset that downloads files using tensorflow.
I tested it on a small config and it works fine | [
"Looks good to me. I have not really looked too much into the Beam Datasets yet though - so I think you can merge whenever you think is good for Beam datasets :-) "
] |
https://api.github.com/repos/huggingface/datasets/issues/87 | 87 | Add Flores | Beautiful language for sure! | closed | 2020-05-13T08:51:29 | https://api.github.com/repos/huggingface/datasets/issues/87/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/87",
"html_url": "https://github.com/huggingface/datasets/pull/87",
"diff_url": "https://github.com/huggingface/datasets/pull/87.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/87.patch",
"merged_at": "2020-05-13T09:23:33"
} | true | Add Flores
Beautiful language for sure! | [] |
https://api.github.com/repos/huggingface/datasets/issues/86 | 86 | [Load => load_dataset] change naming | Rename leftovers @thomwolf | closed | 2020-05-13T08:43:00 | https://api.github.com/repos/huggingface/datasets/issues/86/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/86",
"html_url": "https://github.com/huggingface/datasets/pull/86",
"diff_url": "https://github.com/huggingface/datasets/pull/86.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/86.patch",
"merged_at": "2020-05-13T08:50:57"
} | true | [Load => load_dataset] change naming
Rename leftovers @thomwolf | [] |
https://api.github.com/repos/huggingface/datasets/issues/85 | 85 | Add boolq | I just added the dummy data for this dataset.
This one was uses `tf.io.gfile.copy` to download the data but I added the support for custom download in the mock_download_manager. I also had to add a `tensorflow` dependency for tests. | closed | 2020-05-13T08:32:27 | https://api.github.com/repos/huggingface/datasets/issues/85/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/85",
"html_url": "https://github.com/huggingface/datasets/pull/85",
"diff_url": "https://github.com/huggingface/datasets/pull/85.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/85.patch",
"merged_at": "2020-05-13T09:09:38"
} | true | Add boolq
I just added the dummy data for this dataset.
This one was uses `tf.io.gfile.copy` to download the data but I added the support for custom download in the mock_download_manager. I also had to add a `tensorflow` dependency for tests. | [
"Awesome :-) Thanks for adding the function to the Mock DL Manager"
] |
https://api.github.com/repos/huggingface/datasets/issues/84 | 84 | [TedHrLr] add left dummy data | closed | 2020-05-13T08:27:20 | https://api.github.com/repos/huggingface/datasets/issues/84/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/84",
"html_url": "https://github.com/huggingface/datasets/pull/84",
"diff_url": "https://github.com/huggingface/datasets/pull/84.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/84.patch",
"merged_at": "2020-05-13T08:29:21"
} | true | [TedHrLr] add left dummy data
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/83 | 83 | New datasets | closed | 2020-05-12T18:22:27 | https://api.github.com/repos/huggingface/datasets/issues/83/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/83",
"html_url": "https://github.com/huggingface/datasets/pull/83",
"diff_url": "https://github.com/huggingface/datasets/pull/83.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/83.patch",
"merged_at": "2020-05-12T18:22:45"
} | true | New datasets
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/82 | 82 | [Datasets] add ted_hrlr | @thomwolf - After looking at `xnli` I think it's better to leave the translation features and add a `translation` key to make them work in our framework.
The result looks like this:
![Screenshot from 2020-05-12 18-34-43](https://user-images.githubusercontent.com/23423619/81721933-ee1faf00-9480-11ea-9e95-d6557cbd0c... | closed | 2020-05-12T16:46:50 | https://api.github.com/repos/huggingface/datasets/issues/82/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/82",
"html_url": "https://github.com/huggingface/datasets/pull/82",
"diff_url": "https://github.com/huggingface/datasets/pull/82.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/82.patch",
"merged_at": "2020-05-13T07:52:52"
} | true | [Datasets] add ted_hrlr
@thomwolf - After looking at `xnli` I think it's better to leave the translation features and add a `translation` key to make them work in our framework.
The result looks like this:
![Screenshot from 2020-05-12 18-34-43](https://user-images.githubusercontent.com/23423619/81721933-ee1faf00-9... | [] |
https://api.github.com/repos/huggingface/datasets/issues/81 | 81 | add tests | Tests for py_utils functions and for the BaseReader used to read from arrow and parquet.
I also removed unused utils functions. | closed | 2020-05-12T16:28:19 | https://api.github.com/repos/huggingface/datasets/issues/81/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/81",
"html_url": "https://github.com/huggingface/datasets/pull/81",
"diff_url": "https://github.com/huggingface/datasets/pull/81.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/81.patch",
"merged_at": "2020-05-13T07:43:56"
} | true | add tests
Tests for py_utils functions and for the BaseReader used to read from arrow and parquet.
I also removed unused utils functions. | [] |
https://api.github.com/repos/huggingface/datasets/issues/80 | 80 | Add nbytes + nexamples check | ### Save size and number of examples
Now when you do `save_checksums`, it also create `cached_sizes.txt` right next to the checksum file.
This new file stores the bytes sizes and the number of examples of each split that has been prepared and stored in the cache. Example:
```
# Cached sizes: <full_config_name> <n... | closed | 2020-05-12T16:18:43 | https://api.github.com/repos/huggingface/datasets/issues/80/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/80",
"html_url": "https://github.com/huggingface/datasets/pull/80",
"diff_url": "https://github.com/huggingface/datasets/pull/80.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/80.patch",
"merged_at": "2020-05-13T07:52:33"
} | true | Add nbytes + nexamples check
### Save size and number of examples
Now when you do `save_checksums`, it also create `cached_sizes.txt` right next to the checksum file.
This new file stores the bytes sizes and the number of examples of each split that has been prepared and stored in the cache. Example:
```
# Cached... | [
"Looks good to me! Should we hard code those numbers in the config classes and make sure that when loading a dataset that the numbers match? "
] |
https://api.github.com/repos/huggingface/datasets/issues/79 | 79 | [Convert] add new pattern | closed | 2020-05-12T16:16:51 | https://api.github.com/repos/huggingface/datasets/issues/79/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/79",
"html_url": "https://github.com/huggingface/datasets/pull/79",
"diff_url": "https://github.com/huggingface/datasets/pull/79.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/79.patch",
"merged_at": "2020-05-12T16:17:09"
} | true | [Convert] add new pattern
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/78 | 78 | [Tests] skip beam dataset tests for now | For now we will skip tests for Beam Datasets | closed | 2020-05-12T16:00:58 | https://api.github.com/repos/huggingface/datasets/issues/78/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/78",
"html_url": "https://github.com/huggingface/datasets/pull/78",
"diff_url": "https://github.com/huggingface/datasets/pull/78.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/78.patch",
"merged_at": "2020-05-12T16:16:22"
} | true | [Tests] skip beam dataset tests for now
For now we will skip tests for Beam Datasets | [
"@lhoestq - I moved the wkipedia file to the \"correct\" folder. ",
"Nice thanks !"
] |
https://api.github.com/repos/huggingface/datasets/issues/77 | 77 | New datasets | closed | 2020-05-12T13:51:59 | https://api.github.com/repos/huggingface/datasets/issues/77/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/77",
"html_url": "https://github.com/huggingface/datasets/pull/77",
"diff_url": "https://github.com/huggingface/datasets/pull/77.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/77.patch",
"merged_at": "2020-05-12T14:02:15"
} | true | New datasets
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/76 | 76 | pin flake 8 | Flake 8's new version does not like our format. Pinning the version for now. | closed | 2020-05-12T11:25:29 | https://api.github.com/repos/huggingface/datasets/issues/76/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/76",
"html_url": "https://github.com/huggingface/datasets/pull/76",
"diff_url": "https://github.com/huggingface/datasets/pull/76.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/76.patch",
"merged_at": "2020-05-12T11:27:34"
} | true | pin flake 8
Flake 8's new version does not like our format. Pinning the version for now. | [] |
https://api.github.com/repos/huggingface/datasets/issues/75 | 75 | WIP adding metrics | Adding the following metrics as identified by @mariamabarham:
1. BLEU: BiLingual Evaluation Understudy: https://github.com/tensorflow/nmt/blob/master/nmt/scripts/bleu.py, https://github.com/chakki-works/sumeval/blob/master/sumeval/metrics/bleu.py (multilingual)
2. GLEU: Google-BLEU: https://github.com/cnap/gec-... | closed | 2020-05-12T09:52:00 | https://api.github.com/repos/huggingface/datasets/issues/75/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/75",
"html_url": "https://github.com/huggingface/datasets/pull/75",
"diff_url": "https://github.com/huggingface/datasets/pull/75.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/75.patch",
"merged_at": "2020-05-13T07:44:10"
} | true | WIP adding metrics
Adding the following metrics as identified by @mariamabarham:
1. BLEU: BiLingual Evaluation Understudy: https://github.com/tensorflow/nmt/blob/master/nmt/scripts/bleu.py, https://github.com/chakki-works/sumeval/blob/master/sumeval/metrics/bleu.py (multilingual)
2. GLEU: Google-BLEU: https://g... | [
"It's all about my metric stuff so I'll probably merge it unless you want to have a look.\r\n\r\nTook the occasion to remove the old doc and requirements.txt"
] |
https://api.github.com/repos/huggingface/datasets/issues/74 | 74 | fix overflow check | I did some tests and unfortunately the test
```
pa_array.nbytes > MAX_BATCH_BYTES
```
doesn't work. Indeed for a StructArray, `nbytes` can be less 2GB even if there is an overflow (it loops...).
I don't think we can do a proper overflow test for the limit of 2GB...
For now I replaced it with a sanity check on... | closed | 2020-05-12T09:38:01 | https://api.github.com/repos/huggingface/datasets/issues/74/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/74",
"html_url": "https://github.com/huggingface/datasets/pull/74",
"diff_url": "https://github.com/huggingface/datasets/pull/74.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/74.patch",
"merged_at": "2020-05-12T10:04:37"
} | true | fix overflow check
I did some tests and unfortunately the test
```
pa_array.nbytes > MAX_BATCH_BYTES
```
doesn't work. Indeed for a StructArray, `nbytes` can be less 2GB even if there is an overflow (it loops...).
I don't think we can do a proper overflow test for the limit of 2GB...
For now I replaced it wit... | [] |
https://api.github.com/repos/huggingface/datasets/issues/73 | 73 | JSON script | Add a JSONS script to read JSON datasets from files. | closed | 2020-05-12T07:11:22 | https://api.github.com/repos/huggingface/datasets/issues/73/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/73",
"html_url": "https://github.com/huggingface/datasets/pull/73",
"diff_url": "https://github.com/huggingface/datasets/pull/73.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/73.patch",
"merged_at": "2020-05-18T06:50:36"
} | true | JSON script
Add a JSONS script to read JSON datasets from files. | [
"The tests for the Wikipedia dataset do not pass anymore with the error:\r\n```\r\nTo be able to use this dataset, you need to install the following dependencies ['mwparserfromhell'] using 'pip install mwparserfromhell' for instance'\r\n```",
"This was an issue on master. You can just rebase from master.",
"Per... |
https://api.github.com/repos/huggingface/datasets/issues/72 | 72 | [README dummy data tests] README to better understand how the dummy data structure works | In this PR a README.md is added to tests to shine more light on how the dummy data structure works. I try to explain the different possible cases. IMO the best way to understand the logic is to checkout the dummy data structure of the different datasets I mention in the README.md since those are the "edge cases".
@... | closed | 2020-05-11T22:19:03 | https://api.github.com/repos/huggingface/datasets/issues/72/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/72",
"html_url": "https://github.com/huggingface/datasets/pull/72",
"diff_url": "https://github.com/huggingface/datasets/pull/72.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/72.patch",
"merged_at": "2020-05-11T22:26:01"
} | true | [README dummy data tests] README to better understand how the dummy data structure works
In this PR a README.md is added to tests to shine more light on how the dummy data structure works. I try to explain the different possible cases. IMO the best way to understand the logic is to checkout the dummy data structure of ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/71 | 71 | Fix arrow writer for big datasets using writer_batch_size | This PR fixes Yacine's bug.
According to [this](https://github.com/apache/arrow/blob/master/docs/source/cpp/arrays.rst#size-limitations-and-recommendations), it is not recommended to have pyarrow arrays bigger than 2Go.
Therefore I set a default batch size of 100 000 examples per batch. In general it shouldn't exce... | closed | 2020-05-11T14:45:36 | https://api.github.com/repos/huggingface/datasets/issues/71/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/71",
"html_url": "https://github.com/huggingface/datasets/pull/71",
"diff_url": "https://github.com/huggingface/datasets/pull/71.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/71.patch",
"merged_at": "2020-05-11T20:00:38"
} | true | Fix arrow writer for big datasets using writer_batch_size
This PR fixes Yacine's bug.
According to [this](https://github.com/apache/arrow/blob/master/docs/source/cpp/arrays.rst#size-limitations-and-recommendations), it is not recommended to have pyarrow arrays bigger than 2Go.
Therefore I set a default batch size o... | [
"After a quick chat with Yacine : the 2Go test may not be sufficient actually, as I'm looking at the size of the array and not the size of the current_rows. If the test doesn't do the job I think I'll remove it and lower the batch size a bit to be sure that it never exceeds 2Go. I'll do more tests later"
] |
https://api.github.com/repos/huggingface/datasets/issues/70 | 70 | adding RACE, QASC, Super_glue and Tiny_shakespear datasets | closed | 2020-05-11T08:07:49 | https://api.github.com/repos/huggingface/datasets/issues/70/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/70",
"html_url": "https://github.com/huggingface/datasets/pull/70",
"diff_url": "https://github.com/huggingface/datasets/pull/70.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/70.patch",
"merged_at": "2020-05-12T13:21:51"
} | true | adding RACE, QASC, Super_glue and Tiny_shakespear datasets
| [
"I think rebasing to master will solve the quality test and the datasets that don't have a testing structure yet because of the manual download - maybe you can put them in `datasets under construction`? Then would also make it easier for me to see how to add tests for them :-) "
] | |
https://api.github.com/repos/huggingface/datasets/issues/69 | 69 | fix cache dir in builder tests | minor fix | closed | 2020-05-10T18:39:21 | https://api.github.com/repos/huggingface/datasets/issues/69/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/69",
"html_url": "https://github.com/huggingface/datasets/pull/69",
"diff_url": "https://github.com/huggingface/datasets/pull/69.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/69.patch",
"merged_at": "2020-05-11T07:19:28"
} | true | fix cache dir in builder tests
minor fix | [
"Nice, is that the reason one cannot rerun the tests without deleting the cache? \r\n",
"Yes exactly. It was not using the temporary dir for tests."
] |
https://api.github.com/repos/huggingface/datasets/issues/68 | 68 | [CSV] re-add csv | Re-adding csv under the datasets under construction to keep circle ci happy - will have to see how to include it in the tests.
@lhoestq noticed that I accidently deleted it in https://github.com/huggingface/nlp/pull/63#discussion_r422263729. | closed | 2020-05-08T17:38:29 | https://api.github.com/repos/huggingface/datasets/issues/68/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/68",
"html_url": "https://github.com/huggingface/datasets/pull/68",
"diff_url": "https://github.com/huggingface/datasets/pull/68.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/68.patch",
"merged_at": "2020-05-08T17:40:46"
} | true | [CSV] re-add csv
Re-adding csv under the datasets under construction to keep circle ci happy - will have to see how to include it in the tests.
@lhoestq noticed that I accidently deleted it in https://github.com/huggingface/nlp/pull/63#discussion_r422263729. | [] |
https://api.github.com/repos/huggingface/datasets/issues/67 | 67 | [Tests] Test files locally | This PR adds a `aws` and a `local` decorator to the tests so that tests now run on the local datasets.
By default, the `aws` is deactivated and `local` is activated and `slow` is deactivated, so that only 1 test per dataset runs on circle ci.
**When local is activated all folders in `./datasets` are tested.**
... | closed | 2020-05-08T15:02:43 | https://api.github.com/repos/huggingface/datasets/issues/67/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/67",
"html_url": "https://github.com/huggingface/datasets/pull/67",
"diff_url": "https://github.com/huggingface/datasets/pull/67.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/67.patch",
"merged_at": "2020-05-08T15:17:00"
} | true | [Tests] Test files locally
This PR adds a `aws` and a `local` decorator to the tests so that tests now run on the local datasets.
By default, the `aws` is deactivated and `local` is activated and `slow` is deactivated, so that only 1 test per dataset runs on circle ci.
**When local is activated all folders in `... | [
"Super nice, good job @patrickvonplaten!"
] |
https://api.github.com/repos/huggingface/datasets/issues/66 | 66 | [Datasets] ReadME | closed | 2020-05-08T13:37:43 | https://api.github.com/repos/huggingface/datasets/issues/66/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/66",
"html_url": "https://github.com/huggingface/datasets/pull/66",
"diff_url": "https://github.com/huggingface/datasets/pull/66.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/66.patch",
"merged_at": "2020-05-08T13:39:22"
} | true | [Datasets] ReadME
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/65 | 65 | fix math dataset and xcopa | - fixes math dataset and xcopa, uploaded both of the to S3 | closed | 2020-05-08T13:33:55 | https://api.github.com/repos/huggingface/datasets/issues/65/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/65",
"html_url": "https://github.com/huggingface/datasets/pull/65",
"diff_url": "https://github.com/huggingface/datasets/pull/65.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/65.patch",
"merged_at": "2020-05-08T13:35:40"
} | true | fix math dataset and xcopa
- fixes math dataset and xcopa, uploaded both of the to S3 | [] |
https://api.github.com/repos/huggingface/datasets/issues/64 | 64 | [Datasets] Make master ready for datasets adding | Add all relevant files so that datasets can now be added on master | closed | 2020-05-08T13:17:00 | https://api.github.com/repos/huggingface/datasets/issues/64/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/64",
"html_url": "https://github.com/huggingface/datasets/pull/64",
"diff_url": "https://github.com/huggingface/datasets/pull/64.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/64.patch",
"merged_at": "2020-05-08T13:17:30"
} | true | [Datasets] Make master ready for datasets adding
Add all relevant files so that datasets can now be added on master | [] |
https://api.github.com/repos/huggingface/datasets/issues/63 | 63 | [Dataset scripts] add all datasets scripts | As mentioned, we can have the canonical datasets in the master. For now I also want to include all the data as present on S3 to make the synchronization easier when uploading new datastes.
@mariamabarham @lhoestq @thomwolf - what do you think?
If this is ok for you, I can sync up the master with the `add_datase... | closed | 2020-05-08T10:50:15 | https://api.github.com/repos/huggingface/datasets/issues/63/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/63",
"html_url": "https://github.com/huggingface/datasets/pull/63",
"diff_url": "https://github.com/huggingface/datasets/pull/63.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/63.patch",
"merged_at": "2020-05-08T11:34:00"
} | true | [Dataset scripts] add all datasets scripts
As mentioned, we can have the canonical datasets in the master. For now I also want to include all the data as present on S3 to make the synchronization easier when uploading new datastes.
@mariamabarham @lhoestq @thomwolf - what do you think?
If this is ok for you, I ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/62 | 62 | [Cached Path] Better error message | IMO returning `None` in this function only leads to confusion and is never helpful. | closed | 2020-05-08T09:39:47 | https://api.github.com/repos/huggingface/datasets/issues/62/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/62",
"html_url": "https://github.com/huggingface/datasets/pull/62",
"diff_url": "https://github.com/huggingface/datasets/pull/62.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/62.patch",
"merged_at": null
} | true | [Cached Path] Better error message
IMO returning `None` in this function only leads to confusion and is never helpful. | [] |
https://api.github.com/repos/huggingface/datasets/issues/61 | 61 | [Load] rename setup_module to prepare_module | rename setup_module to prepare_module due to issues with pytests `setup_module` function.
See: PR #59. | closed | 2020-05-08T08:54:22 | https://api.github.com/repos/huggingface/datasets/issues/61/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/61",
"html_url": "https://github.com/huggingface/datasets/pull/61",
"diff_url": "https://github.com/huggingface/datasets/pull/61.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/61.patch",
"merged_at": "2020-05-08T08:56:16"
} | true | [Load] rename setup_module to prepare_module
rename setup_module to prepare_module due to issues with pytests `setup_module` function.
See: PR #59. | [] |
https://api.github.com/repos/huggingface/datasets/issues/60 | 60 | Update to simplify some datasets conversion | This PR updates the encoding of `Values` like `integers`, `boolean` and `float` to use python casting and avoid having to cast in the dataset scripts, as mentioned here: https://github.com/huggingface/nlp/pull/37#discussion_r420176626
We could also change (not included in this PR yet):
- `supervized_keys` to make t... | closed | 2020-05-07T22:02:24 | https://api.github.com/repos/huggingface/datasets/issues/60/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/60",
"html_url": "https://github.com/huggingface/datasets/pull/60",
"diff_url": "https://github.com/huggingface/datasets/pull/60.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/60.patch",
"merged_at": "2020-05-08T10:18:24"
} | true | Update to simplify some datasets conversion
This PR updates the encoding of `Values` like `integers`, `boolean` and `float` to use python casting and avoid having to cast in the dataset scripts, as mentioned here: https://github.com/huggingface/nlp/pull/37#discussion_r420176626
We could also change (not included in ... | [
"Awesome! ",
"Also we should convert `tf.io.gfile.exists` into `os.path.exists` , `tf.io.gfile.listdir`into `os.listdir` and `tf.io.gfile.glob` into `glob.glob` (will need to add `import glob`)",
"> Also we should convert `tf.io.gfile.exists` into `os.path.exists` , `tf.io.gfile.listdir`into `os.listdir` and `... |
https://api.github.com/repos/huggingface/datasets/issues/59 | 59 | Fix tests | @patrickvonplaten I've broken a bit the tests with #25 while simplifying and re-organizing the `load.py` and `download_manager.py` scripts.
I'm trying to fix them here but I have a weird error, do you think you can have a look?
```bash
(datasets) MacBook-Pro-de-Thomas:datasets thomwolf$ python -m pytest -sv ./test... | closed | 2020-05-07T21:48:09 | https://api.github.com/repos/huggingface/datasets/issues/59/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/59",
"html_url": "https://github.com/huggingface/datasets/pull/59",
"diff_url": "https://github.com/huggingface/datasets/pull/59.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/59.patch",
"merged_at": "2020-05-08T10:46:51"
} | true | Fix tests
@patrickvonplaten I've broken a bit the tests with #25 while simplifying and re-organizing the `load.py` and `download_manager.py` scripts.
I'm trying to fix them here but I have a weird error, do you think you can have a look?
```bash
(datasets) MacBook-Pro-de-Thomas:datasets thomwolf$ python -m pytest ... | [
"I can fix the tests tomorrow :-) ",
"Very weird bug indeed! I think the problem was that when importing `setup_module` we overwrote `pytest's` setup_module function. I think this is the relevant code in pytest: https://github.com/pytest-dev/pytest/blob/9d2eabb397b059b75b746259daeb20ee5588f559/src/_pytest/python.... |
https://api.github.com/repos/huggingface/datasets/issues/58 | 58 | Aborted PR - Fix tests | @patrickvonplaten I've broken a bit the tests with #25 while simplifying and re-organizing the `load.py` and `download_manager.py` scripts.
I'm trying to fix them here but I have a weird error, do you think you can have a look?
```bash
(datasets) MacBook-Pro-de-Thomas:datasets thomwolf$ python -m pytest -sv ./test... | closed | 2020-05-07T21:40:19 | https://api.github.com/repos/huggingface/datasets/issues/58/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/58",
"html_url": "https://github.com/huggingface/datasets/pull/58",
"diff_url": "https://github.com/huggingface/datasets/pull/58.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/58.patch",
"merged_at": null
} | true | Aborted PR - Fix tests
@patrickvonplaten I've broken a bit the tests with #25 while simplifying and re-organizing the `load.py` and `download_manager.py` scripts.
I'm trying to fix them here but I have a weird error, do you think you can have a look?
```bash
(datasets) MacBook-Pro-de-Thomas:datasets thomwolf$ pyth... | [
"Wait I messed up my branch, let me clean this."
] |
https://api.github.com/repos/huggingface/datasets/issues/57 | 57 | Better cached path | ### Changes:
- The `cached_path` no longer returns None if the file is missing/the url doesn't work. Instead, it can raise `FileNotFoundError` (missing file), `ConnectionError` (no cache and unreachable url) or `ValueError` (parsing error)
- Fix requests to firebase API that doesn't handle HEAD requests...
- Allow c... | closed | 2020-05-07T18:36:00 | https://api.github.com/repos/huggingface/datasets/issues/57/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/57",
"html_url": "https://github.com/huggingface/datasets/pull/57",
"diff_url": "https://github.com/huggingface/datasets/pull/57.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/57.patch",
"merged_at": "2020-05-08T13:20:28"
} | true | Better cached path
### Changes:
- The `cached_path` no longer returns None if the file is missing/the url doesn't work. Instead, it can raise `FileNotFoundError` (missing file), `ConnectionError` (no cache and unreachable url) or `ValueError` (parsing error)
- Fix requests to firebase API that doesn't handle HEAD req... | [
"I should have read this PR before doing my own: https://github.com/huggingface/nlp/pull/62 :D \r\nwill close mine. Looks great :-) ",
"> Awesome, this is really nice!\r\n> \r\n> By the way, we should improve the `cached_path` method of the `transformers` repo similarly, don't you think (@patrickvonplaten in part... |
https://api.github.com/repos/huggingface/datasets/issues/56 | 56 | [Dataset] Tester add mock function | need to add an empty `extract()` function to make `hansard` dataset test work. | closed | 2020-05-07T17:51:37 | https://api.github.com/repos/huggingface/datasets/issues/56/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/56",
"html_url": "https://github.com/huggingface/datasets/pull/56",
"diff_url": "https://github.com/huggingface/datasets/pull/56.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/56.patch",
"merged_at": "2020-05-07T17:52:50"
} | true | [Dataset] Tester add mock function
need to add an empty `extract()` function to make `hansard` dataset test work. | [] |
https://api.github.com/repos/huggingface/datasets/issues/55 | 55 | Beam datasets | # Beam datasets
## Intro
Beam Datasets are using beam pipelines for preprocessing (basically lots of `.map` over objects called PCollections).
The advantage of apache beam is that you can choose which type of runner you want to use to preprocess your data. The main runners are:
- the `DirectRunner` to run the p... | closed | 2020-05-07T11:04:32 | https://api.github.com/repos/huggingface/datasets/issues/55/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/55",
"html_url": "https://github.com/huggingface/datasets/pull/55",
"diff_url": "https://github.com/huggingface/datasets/pull/55.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/55.patch",
"merged_at": "2020-05-11T07:20:00"
} | true | Beam datasets
# Beam datasets
## Intro
Beam Datasets are using beam pipelines for preprocessing (basically lots of `.map` over objects called PCollections).
The advantage of apache beam is that you can choose which type of runner you want to use to preprocess your data. The main runners are:
- the `DirectRunner... | [
"Right now the changes are a bit hard to read as the one from #25 are also included. You can wait until #25 is merged before looking at the implementation details",
"Nice!! I tested it a bit and works quite well. I will do a my review once the #25 will be merged because there are several overlaps.\r\n\r\nAt least... |
https://api.github.com/repos/huggingface/datasets/issues/54 | 54 | [Tests] Improved Error message for dummy folder structure | Improved Error message | closed | 2020-05-06T18:11:48 | https://api.github.com/repos/huggingface/datasets/issues/54/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/54",
"html_url": "https://github.com/huggingface/datasets/pull/54",
"diff_url": "https://github.com/huggingface/datasets/pull/54.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/54.patch",
"merged_at": "2020-05-06T18:12:59"
} | true | [Tests] Improved Error message for dummy folder structure
Improved Error message | [] |
https://api.github.com/repos/huggingface/datasets/issues/53 | 53 | [Features] Typo in generate_from_dict | Change `isinstance` test in features when generating features from dict. | closed | 2020-05-06T16:05:23 | https://api.github.com/repos/huggingface/datasets/issues/53/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/53",
"html_url": "https://github.com/huggingface/datasets/pull/53",
"diff_url": "https://github.com/huggingface/datasets/pull/53.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/53.patch",
"merged_at": "2020-05-07T15:28:45"
} | true | [Features] Typo in generate_from_dict
Change `isinstance` test in features when generating features from dict. | [] |
https://api.github.com/repos/huggingface/datasets/issues/52 | 52 | allow dummy folder structure to handle dict of lists | `esnli.py` needs that extension of the dummy data testing. | closed | 2020-05-06T13:54:35 | https://api.github.com/repos/huggingface/datasets/issues/52/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/52",
"html_url": "https://github.com/huggingface/datasets/pull/52",
"diff_url": "https://github.com/huggingface/datasets/pull/52.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/52.patch",
"merged_at": "2020-05-06T13:55:18"
} | true | allow dummy folder structure to handle dict of lists
`esnli.py` needs that extension of the dummy data testing. | [] |
https://api.github.com/repos/huggingface/datasets/issues/51 | 51 | [Testing] Improved testing structure | This PR refactors the test design a bit and puts the mock download manager in the `utils` files as it is just a test helper class.
as @mariamabarham pointed out, creating a dummy folder structure can be quite hard to grasp.
This PR tries to change that to some extent.
It follows the following logic for the `dumm... | closed | 2020-05-06T12:03:07 | https://api.github.com/repos/huggingface/datasets/issues/51/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/51",
"html_url": "https://github.com/huggingface/datasets/pull/51",
"diff_url": "https://github.com/huggingface/datasets/pull/51.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/51.patch",
"merged_at": "2020-05-06T13:20:17"
} | true | [Testing] Improved testing structure
This PR refactors the test design a bit and puts the mock download manager in the `utils` files as it is just a test helper class.
as @mariamabarham pointed out, creating a dummy folder structure can be quite hard to grasp.
This PR tries to change that to some extent.
It foll... | [
"Awesome!\r\nLet's have this in the doc at the end :-)"
] |
https://api.github.com/repos/huggingface/datasets/issues/50 | 50 | [Tests] test only for fast test as a default | Test only for one config on circle ci to speed up testing. Add all config test as a slow test.
@mariamabarham @thomwolf | closed | 2020-05-05T12:59:22 | https://api.github.com/repos/huggingface/datasets/issues/50/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/50",
"html_url": "https://github.com/huggingface/datasets/pull/50",
"diff_url": "https://github.com/huggingface/datasets/pull/50.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/50.patch",
"merged_at": "2020-05-05T13:02:16"
} | true | [Tests] test only for fast test as a default
Test only for one config on circle ci to speed up testing. Add all config test as a slow test.
@mariamabarham @thomwolf | [
"Test failure is not related to change in test file.\r\n"
] |
https://api.github.com/repos/huggingface/datasets/issues/49 | 49 | fix flatten nested | closed | 2020-05-05T11:55:13 | https://api.github.com/repos/huggingface/datasets/issues/49/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/49",
"html_url": "https://github.com/huggingface/datasets/pull/49",
"diff_url": "https://github.com/huggingface/datasets/pull/49.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/49.patch",
"merged_at": "2020-05-05T13:59:25"
} | true | fix flatten nested
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/48 | 48 | [Command Convert] remove tensorflow import | Remove all tensorflow import statements. | closed | 2020-05-05T10:41:00 | https://api.github.com/repos/huggingface/datasets/issues/48/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/48",
"html_url": "https://github.com/huggingface/datasets/pull/48",
"diff_url": "https://github.com/huggingface/datasets/pull/48.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/48.patch",
"merged_at": "2020-05-05T11:13:56"
} | true | [Command Convert] remove tensorflow import
Remove all tensorflow import statements. | [] |
https://api.github.com/repos/huggingface/datasets/issues/47 | 47 | [PyArrow Feature] fix py arrow bool | To me it seems that `bool` can only be accessed with `bool_` when looking at the pyarrow types: https://arrow.apache.org/docs/python/api/datatypes.html. | closed | 2020-05-05T08:56:28 | https://api.github.com/repos/huggingface/datasets/issues/47/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/47",
"html_url": "https://github.com/huggingface/datasets/pull/47",
"diff_url": "https://github.com/huggingface/datasets/pull/47.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/47.patch",
"merged_at": "2020-05-05T10:40:27"
} | true | [PyArrow Feature] fix py arrow bool
To me it seems that `bool` can only be accessed with `bool_` when looking at the pyarrow types: https://arrow.apache.org/docs/python/api/datatypes.html. | [] |
https://api.github.com/repos/huggingface/datasets/issues/46 | 46 | [Features] Strip str key before dict look-up | The dataset `anli.py` currently fails because it tries to look up a key `1\n` in a dict that only has the key `1`. Added an if statement to strip key if it cannot be found in dict. | closed | 2020-05-05T07:31:45 | https://api.github.com/repos/huggingface/datasets/issues/46/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/46",
"html_url": "https://github.com/huggingface/datasets/pull/46",
"diff_url": "https://github.com/huggingface/datasets/pull/46.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/46.patch",
"merged_at": "2020-05-05T08:37:44"
} | true | [Features] Strip str key before dict look-up
The dataset `anli.py` currently fails because it tries to look up a key `1\n` in a dict that only has the key `1`. Added an if statement to strip key if it cannot be found in dict. | [] |
https://api.github.com/repos/huggingface/datasets/issues/45 | 45 | [Load] Separate Module kwargs and builder kwargs. | Kwargs for the `load_module` fn should be passed with `module_xxxx` to `builder_kwargs` of `load` fn.
This is a follow-up PR of: https://github.com/huggingface/nlp/pull/41 | closed | 2020-05-05T07:09:54 | https://api.github.com/repos/huggingface/datasets/issues/45/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/45",
"html_url": "https://github.com/huggingface/datasets/pull/45",
"diff_url": "https://github.com/huggingface/datasets/pull/45.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/45.patch",
"merged_at": null
} | true | [Load] Separate Module kwargs and builder kwargs.
Kwargs for the `load_module` fn should be passed with `module_xxxx` to `builder_kwargs` of `load` fn.
This is a follow-up PR of: https://github.com/huggingface/nlp/pull/41 | [] |
https://api.github.com/repos/huggingface/datasets/issues/44 | 44 | [Tests] Fix tests for datasets with no config | Forgot to fix `None` problem for datasets that have no config this in PR: https://github.com/huggingface/nlp/pull/42 | closed | 2020-05-04T13:25:38 | https://api.github.com/repos/huggingface/datasets/issues/44/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/44",
"html_url": "https://github.com/huggingface/datasets/pull/44",
"diff_url": "https://github.com/huggingface/datasets/pull/44.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/44.patch",
"merged_at": "2020-05-04T13:28:03"
} | true | [Tests] Fix tests for datasets with no config
Forgot to fix `None` problem for datasets that have no config this in PR: https://github.com/huggingface/nlp/pull/42 | [] |
https://api.github.com/repos/huggingface/datasets/issues/43 | 43 | [Checksums] If no configs exist prevent to run over empty list | `movie_rationales` e.g. has no configs. | closed | 2020-05-04T10:39:42 | https://api.github.com/repos/huggingface/datasets/issues/43/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/43",
"html_url": "https://github.com/huggingface/datasets/pull/43",
"diff_url": "https://github.com/huggingface/datasets/pull/43.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/43.patch",
"merged_at": null
} | true | [Checksums] If no configs exist prevent to run over empty list
`movie_rationales` e.g. has no configs. | [
"Whoops I fixed it directly on master before checking that you have done it in this PR. We may close it",
"Yeah, I saw :-) But I think we should add this as well since some datasets have an empty list of configs and then as the code is now it would fail. \r\n\r\nIn this PR, I just make sure that the code jumps in... |
https://api.github.com/repos/huggingface/datasets/issues/42 | 42 | [Tests] allow tests for builders without config | Some dataset scripts have no configs - the tests have to be adapted for this case.
In this case the dummy data will be saved as:
- natural_questions
-> dummy
-> -> 1.0.0 (version num)
-> -> -> dummy_data.zip
| closed | 2020-05-04T10:06:22 | https://api.github.com/repos/huggingface/datasets/issues/42/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/42",
"html_url": "https://github.com/huggingface/datasets/pull/42",
"diff_url": "https://github.com/huggingface/datasets/pull/42.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/42.patch",
"merged_at": "2020-05-04T13:10:48"
} | true | [Tests] allow tests for builders without config
Some dataset scripts have no configs - the tests have to be adapted for this case.
In this case the dummy data will be saved as:
- natural_questions
-> dummy
-> -> 1.0.0 (version num)
-> -> -> dummy_data.zip
| [] |
https://api.github.com/repos/huggingface/datasets/issues/41 | 41 | [Load module] allow kwargs into load module | Currenly it is not possible to force a re-download of the dataset script.
This simple change allows to pass ``force_reload=True`` as ``builder_kwargs`` in the ``load.py`` function. | closed | 2020-05-04T09:42:11 | https://api.github.com/repos/huggingface/datasets/issues/41/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/41",
"html_url": "https://github.com/huggingface/datasets/pull/41",
"diff_url": "https://github.com/huggingface/datasets/pull/41.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/41.patch",
"merged_at": "2020-05-04T19:39:06"
} | true | [Load module] allow kwargs into load module
Currenly it is not possible to force a re-download of the dataset script.
This simple change allows to pass ``force_reload=True`` as ``builder_kwargs`` in the ``load.py`` function. | [] |
https://api.github.com/repos/huggingface/datasets/issues/40 | 40 | Update remote checksums instead of overwrite | When the user uploads a dataset on S3, checksums are also uploaded with the `--upload_checksums` parameter.
If the user uploads the dataset in several steps, then the remote checksums file was previously overwritten. Now it's going to be updated with the new checksums. | closed | 2020-05-04T09:13:14 | https://api.github.com/repos/huggingface/datasets/issues/40/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/40",
"html_url": "https://github.com/huggingface/datasets/pull/40",
"diff_url": "https://github.com/huggingface/datasets/pull/40.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/40.patch",
"merged_at": "2020-05-04T11:51:49"
} | true | Update remote checksums instead of overwrite
When the user uploads a dataset on S3, checksums are also uploaded with the `--upload_checksums` parameter.
If the user uploads the dataset in several steps, then the remote checksums file was previously overwritten. Now it's going to be updated with the new checksums. | [] |
https://api.github.com/repos/huggingface/datasets/issues/39 | 39 | [Test] improve slow testing | closed | 2020-05-04T08:58:33 | https://api.github.com/repos/huggingface/datasets/issues/39/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/39",
"html_url": "https://github.com/huggingface/datasets/pull/39",
"diff_url": "https://github.com/huggingface/datasets/pull/39.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/39.patch",
"merged_at": "2020-05-04T08:59:49"
} | true | [Test] improve slow testing
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/38 | 38 | [Checksums] Error for some datasets | The checksums command works very nicely for `squad`. But for `crime_and_punish` and `xnli`,
the same bug happens:
When running:
```
python nlp-cli nlp-cli test xnli --save_checksums
```
leads to:
```
File "nlp-cli", line 33, in <module>
service.run()
File "/home/patrick/python_bin/nlp/commands... | closed | 2020-05-04T08:00:16 | https://api.github.com/repos/huggingface/datasets/issues/38/comments | null | false | [Checksums] Error for some datasets
The checksums command works very nicely for `squad`. But for `crime_and_punish` and `xnli`,
the same bug happens:
When running:
```
python nlp-cli nlp-cli test xnli --save_checksums
```
leads to:
```
File "nlp-cli", line 33, in <module>
service.run()
File "/... | [
"@lhoestq - could you take a look? It's not very urgent though!",
"Fixed with 06882b4\r\n\r\nNow your command works :)\r\nNote that you can also do\r\n```\r\nnlp-cli test datasets/nlp/xnli --save_checksums\r\n```\r\nSo that it will save the checksums directly in the right directory.",
"Awesome!"
] |
https://api.github.com/repos/huggingface/datasets/issues/37 | 37 | [Datasets ToDo-List] add datasets | ## Description
This PR acts as a dashboard to see which datasets are added to the library and work.
Cicle-ci should always be green so that we can be sure that newly added datasets are functional.
This PR should not be merged.
## Progress
**For the following datasets the test commands**:
```
RUN_SLOW... | closed | 2020-05-04T07:47:39 | https://api.github.com/repos/huggingface/datasets/issues/37/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/37",
"html_url": "https://github.com/huggingface/datasets/pull/37",
"diff_url": "https://github.com/huggingface/datasets/pull/37.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/37.patch",
"merged_at": null
} | true | [Datasets ToDo-List] add datasets
## Description
This PR acts as a dashboard to see which datasets are added to the library and work.
Cicle-ci should always be green so that we can be sure that newly added datasets are functional.
This PR should not be merged.
## Progress
**For the following datasets t... | [
"Note:\r\n```\r\nnlp-cli test datasets/nlp/<your-dataset-folder> --save_checksums --all_configs\r\n```\r\ndirectly saves the checksums in the right place, and runs for all the dataset configurations.",
"@patrickvonplaten can you provide the add the link to the PR for the dummy data? ",
"https://github.com/huggi... |
https://api.github.com/repos/huggingface/datasets/issues/36 | 36 | Metrics - refactoring, adding support for download and distributed metrics | Refactoring metrics to have a similar loading API than the datasets and improving the import system.
# Import system
The import system has ben upgraded. There are now three types of imports allowed:
1. `library` imports (identified as "absolute imports")
```python
import seqeval
```
=> we'll test all the impor... | closed | 2020-05-03T23:00:17 | https://api.github.com/repos/huggingface/datasets/issues/36/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/36",
"html_url": "https://github.com/huggingface/datasets/pull/36",
"diff_url": "https://github.com/huggingface/datasets/pull/36.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/36.patch",
"merged_at": "2020-05-11T08:16:00"
} | true | Metrics - refactoring, adding support for download and distributed metrics
Refactoring metrics to have a similar loading API than the datasets and improving the import system.
# Import system
The import system has ben upgraded. There are now three types of imports allowed:
1. `library` imports (identified as "abso... | [
"Ok, this one seems to be ready to merge.",
"> Really cool, I love it! I would just raise a tiny point, the distributive version of the metrics might not work properly with TF because it is a different way to do, why not to add a \"framework\" detection and raise warning when TF is used, saying something like \"n... |
https://api.github.com/repos/huggingface/datasets/issues/35 | 35 | [Tests] fix typo | @lhoestq - currently the slow test fail with:
```
_____________________________________________________________________________________ DatasetTest.test_load_real_dataset_xnli _____________________________________________________________________________________
... | closed | 2020-05-03T13:23:49 | https://api.github.com/repos/huggingface/datasets/issues/35/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/35",
"html_url": "https://github.com/huggingface/datasets/pull/35",
"diff_url": "https://github.com/huggingface/datasets/pull/35.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/35.patch",
"merged_at": "2020-05-03T13:24:20"
} | true | [Tests] fix typo
@lhoestq - currently the slow test fail with:
```
_____________________________________________________________________________________ DatasetTest.test_load_real_dataset_xnli _____________________________________________________________________________________
... | [] |
https://api.github.com/repos/huggingface/datasets/issues/34 | 34 | [Tests] add slow tests | This PR adds a slow test that downloads the "real" dataset. The test is decorated as "slow" so that it will not automatically run on circle ci.
Before uploading a dataset, one should test that this test passes, manually by running
```
RUN_SLOW=1 pytest tests/test_dataset_common.py::DatasetTest::test_load_real_d... | closed | 2020-05-03T11:01:22 | https://api.github.com/repos/huggingface/datasets/issues/34/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/34",
"html_url": "https://github.com/huggingface/datasets/pull/34",
"diff_url": "https://github.com/huggingface/datasets/pull/34.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/34.patch",
"merged_at": "2020-05-03T12:18:29"
} | true | [Tests] add slow tests
This PR adds a slow test that downloads the "real" dataset. The test is decorated as "slow" so that it will not automatically run on circle ci.
Before uploading a dataset, one should test that this test passes, manually by running
```
RUN_SLOW=1 pytest tests/test_dataset_common.py::Datase... | [] |
https://api.github.com/repos/huggingface/datasets/issues/33 | 33 | Big cleanup/refactoring for clean serialization | This PR cleans many base classes to re-build them as `dataclasses`. We can thus use a simple serialization workflow for `DatasetInfo`, including it's `Features` and `SplitDict` based on `dataclasses` `asdict()`.
The resulting code is a lot shorter, can be easily serialized/deserialized, dataset info are human-readab... | closed | 2020-05-01T23:45:57 | https://api.github.com/repos/huggingface/datasets/issues/33/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/33",
"html_url": "https://github.com/huggingface/datasets/pull/33",
"diff_url": "https://github.com/huggingface/datasets/pull/33.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/33.patch",
"merged_at": "2020-05-03T12:17:33"
} | true | Big cleanup/refactoring for clean serialization
This PR cleans many base classes to re-build them as `dataclasses`. We can thus use a simple serialization workflow for `DatasetInfo`, including it's `Features` and `SplitDict` based on `dataclasses` `asdict()`.
The resulting code is a lot shorter, can be easily serial... | [
"Great! I think when this merged, we can merge sure that Circle Ci stays happy when uploading new datasets. "
] |
https://api.github.com/repos/huggingface/datasets/issues/32 | 32 | Fix map caching notebooks | Previously, caching results with `.map()` didn't work in notebooks.
To reuse a result, `.map()` serializes the functions with `dill.dumps` and then it hashes it.
The problem is that when using `dill.dumps` to serialize a function, it also saves its origin (filename + line no.) and the origin of all the `globals` th... | closed | 2020-05-01T11:55:26 | https://api.github.com/repos/huggingface/datasets/issues/32/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/32",
"html_url": "https://github.com/huggingface/datasets/pull/32",
"diff_url": "https://github.com/huggingface/datasets/pull/32.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/32.patch",
"merged_at": "2020-05-03T12:15:57"
} | true | Fix map caching notebooks
Previously, caching results with `.map()` didn't work in notebooks.
To reuse a result, `.map()` serializes the functions with `dill.dumps` and then it hashes it.
The problem is that when using `dill.dumps` to serialize a function, it also saves its origin (filename + line no.) and the orig... | [] |
https://api.github.com/repos/huggingface/datasets/issues/31 | 31 | [Circle ci] Install a virtual env before running tests | Install a virtual env before running tests to not running into sudo issues when dynamically downloading files.
Same number of tests now pass / fail as on my local computer:
... | closed | 2020-05-01T10:11:17 | https://api.github.com/repos/huggingface/datasets/issues/31/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/31",
"html_url": "https://github.com/huggingface/datasets/pull/31",
"diff_url": "https://github.com/huggingface/datasets/pull/31.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/31.patch",
"merged_at": "2020-05-01T22:06:15"
} | true | [Circle ci] Install a virtual env before running tests
Install a virtual env before running tests to not running into sudo issues when dynamically downloading files.
Same number of tests now pass / fail as on my local computer:
 in `load.py` to `metrics/metric_utils.py`. I made the following changes:
- copy the needed files in a folder`metric_name`
- delete all other files that are not needed
For metrics that require an external... | closed | 2020-05-01T04:13:22 | https://api.github.com/repos/huggingface/datasets/issues/30/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/30",
"html_url": "https://github.com/huggingface/datasets/pull/30",
"diff_url": "https://github.com/huggingface/datasets/pull/30.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/30.patch",
"merged_at": null
} | true | add metrics which require download files from github
To download files from github, I copied the `load_dataset_module` and its dependencies (without the builder) in `load.py` to `metrics/metric_utils.py`. I made the following changes:
- copy the needed files in a folder`metric_name`
- delete all other files that a... | [] |
https://api.github.com/repos/huggingface/datasets/issues/29 | 29 | Hf_api small changes | From Patrick:
```python
from nlp import hf_api
api = hf_api.HfApi()
api.dataset_list()
```
works :-) | closed | 2020-04-30T17:06:43 | https://api.github.com/repos/huggingface/datasets/issues/29/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/29",
"html_url": "https://github.com/huggingface/datasets/pull/29",
"diff_url": "https://github.com/huggingface/datasets/pull/29.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/29.patch",
"merged_at": "2020-04-30T19:51:44"
} | true | Hf_api small changes
From Patrick:
```python
from nlp import hf_api
api = hf_api.HfApi()
api.dataset_list()
```
works :-) | [
"Ok merging! I think it's good now"
] |
https://api.github.com/repos/huggingface/datasets/issues/28 | 28 | [Circle ci] Adds circle ci config | @thomwolf can you take a look and set up circle ci on:
https://app.circleci.com/projects/project-dashboard/github/huggingface
I think for `nlp` only admins can set it up, which I guess is you :-) | closed | 2020-04-30T17:03:35 | https://api.github.com/repos/huggingface/datasets/issues/28/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/28",
"html_url": "https://github.com/huggingface/datasets/pull/28",
"diff_url": "https://github.com/huggingface/datasets/pull/28.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/28.patch",
"merged_at": "2020-04-30T19:51:08"
} | true | [Circle ci] Adds circle ci config
@thomwolf can you take a look and set up circle ci on:
https://app.circleci.com/projects/project-dashboard/github/huggingface
I think for `nlp` only admins can set it up, which I guess is you :-) | [] |
https://api.github.com/repos/huggingface/datasets/issues/27 | 27 | [Cleanup] Removes all files in testing except test_dataset_common | As far as I know, all files in `tests` were old `tfds test files` so I removed them. We can still look them up on the other library. | closed | 2020-04-30T16:45:21 | https://api.github.com/repos/huggingface/datasets/issues/27/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/27",
"html_url": "https://github.com/huggingface/datasets/pull/27",
"diff_url": "https://github.com/huggingface/datasets/pull/27.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/27.patch",
"merged_at": "2020-04-30T17:39:23"
} | true | [Cleanup] Removes all files in testing except test_dataset_common
As far as I know, all files in `tests` were old `tfds test files` so I removed them. We can still look them up on the other library. | [] |
https://api.github.com/repos/huggingface/datasets/issues/26 | 26 | [Tests] Clean tests | the abseil testing library (https://abseil.io/docs/python/quickstart.html) is better than the one I had before, so I decided to switch to that and changed the `setup.py` config file.
Abseil has more support and a cleaner API for parametrized testing I think.
I added a list of all dataset scripts that are currentl... | closed | 2020-04-30T16:38:29 | https://api.github.com/repos/huggingface/datasets/issues/26/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/26",
"html_url": "https://github.com/huggingface/datasets/pull/26",
"diff_url": "https://github.com/huggingface/datasets/pull/26.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/26.patch",
"merged_at": "2020-04-30T20:12:03"
} | true | [Tests] Clean tests
the abseil testing library (https://abseil.io/docs/python/quickstart.html) is better than the one I had before, so I decided to switch to that and changed the `setup.py` config file.
Abseil has more support and a cleaner API for parametrized testing I think.
I added a list of all dataset scrip... | [] |
https://api.github.com/repos/huggingface/datasets/issues/25 | 25 | Add script csv datasets | This is a PR allowing to create datasets from local CSV files. A usage might be:
```python
import nlp
ds = nlp.load(
path="csv",
name="bbc",
dataset_files={
nlp.Split.TRAIN: ["datasets/dummy_data/csv/train.csv"],
nlp.Split.TEST: [""datasets/dummy_data/csv/test.csv""]
},
c... | closed | 2020-04-30T08:28:08 | https://api.github.com/repos/huggingface/datasets/issues/25/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/25",
"html_url": "https://github.com/huggingface/datasets/pull/25",
"diff_url": "https://github.com/huggingface/datasets/pull/25.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/25.patch",
"merged_at": "2020-05-07T21:14:49"
} | true | Add script csv datasets
This is a PR allowing to create datasets from local CSV files. A usage might be:
```python
import nlp
ds = nlp.load(
path="csv",
name="bbc",
dataset_files={
nlp.Split.TRAIN: ["datasets/dummy_data/csv/train.csv"],
nlp.Split.TEST: [""datasets/dummy_data/csv/te... | [
"Very interesting thoughts, we should think deeper about all what you raised indeed.",
"Ok here is a proposal for a more general API and workflow.\r\n\r\n# New `ArrowBasedBuilder`\r\n\r\nFor all the formats that can be directly and efficiently loaded by Arrow (CSV, JSON, Parquet, Arrow), we don't really want to h... |
https://api.github.com/repos/huggingface/datasets/issues/24 | 24 | Add checksums | ### Checksums files
They are stored next to the dataset script in urls_checksums/checksums.txt.
They are used to check the integrity of the datasets downloaded files.
I kept the same format as tensorflow-datasets.
There is one checksums file for all configs.
### Load a dataset
When you do `load("squad")`, i... | closed | 2020-04-29T13:37:29 | https://api.github.com/repos/huggingface/datasets/issues/24/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/24",
"html_url": "https://github.com/huggingface/datasets/pull/24",
"diff_url": "https://github.com/huggingface/datasets/pull/24.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/24.patch",
"merged_at": "2020-04-30T19:52:49"
} | true | Add checksums
### Checksums files
They are stored next to the dataset script in urls_checksums/checksums.txt.
They are used to check the integrity of the datasets downloaded files.
I kept the same format as tensorflow-datasets.
There is one checksums file for all configs.
### Load a dataset
When you do `loa... | [
"Looks good to me :-) \r\n\r\nJust would prefer to get rid of the `_DYNAMICALLY_IMPORTED_MODULE` attribute and replace it by a `get_imported_module()` function. Maybe there is something I'm not seeing here though - what do you think? ",
"> * I'm not sure I understand the general organization of checksums. I see w... |
https://api.github.com/repos/huggingface/datasets/issues/23 | 23 | Add metrics | This PR is a draft for adding metrics (sacrebleu and seqeval are added)
use case examples:
`import nlp`
**sacrebleu:**
```
refs = [['The dog bit the man.', 'It was not unexpected.', 'The man bit him first.'],
['The dog had bit the man.', 'No one was surprised.', 'The man had bitten the dog.']]
sys = ['... | closed | 2020-04-28T18:02:05 | https://api.github.com/repos/huggingface/datasets/issues/23/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/23",
"html_url": "https://github.com/huggingface/datasets/pull/23",
"diff_url": "https://github.com/huggingface/datasets/pull/23.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/23.patch",
"merged_at": null
} | true | Add metrics
This PR is a draft for adding metrics (sacrebleu and seqeval are added)
use case examples:
`import nlp`
**sacrebleu:**
```
refs = [['The dog bit the man.', 'It was not unexpected.', 'The man bit him first.'],
['The dog had bit the man.', 'No one was surprised.', 'The man had bitten the dog.'... | [] |
https://api.github.com/repos/huggingface/datasets/issues/22 | 22 | adding bleu score code | this PR add the BLEU score metric to the lib. It can be tested by running the following code.
` from nlp.metrics import bleu
hyp1 = "It is a guide to action which ensures that the military always obeys the commands of the party"
ref1a = "It is a guide to action that ensures that the military forces always being... | closed | 2020-04-28T13:00:50 | https://api.github.com/repos/huggingface/datasets/issues/22/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/22",
"html_url": "https://github.com/huggingface/datasets/pull/22",
"diff_url": "https://github.com/huggingface/datasets/pull/22.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/22.patch",
"merged_at": null
} | true | adding bleu score code
this PR add the BLEU score metric to the lib. It can be tested by running the following code.
` from nlp.metrics import bleu
hyp1 = "It is a guide to action which ensures that the military always obeys the commands of the party"
ref1a = "It is a guide to action that ensures that the milita... | [] |
https://api.github.com/repos/huggingface/datasets/issues/21 | 21 | Cleanup Features - Updating convert command - Fix Download manager | This PR makes a number of changes:
# Updating `Features`
Features are a complex mechanism provided in `tfds` to be able to modify a dataset on-the-fly when serializing to disk and when loading from disk.
We don't really need this because (1) it hides too much from the user and (2) our datatype can be directly ... | closed | 2020-04-27T23:16:55 | https://api.github.com/repos/huggingface/datasets/issues/21/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/21",
"html_url": "https://github.com/huggingface/datasets/pull/21",
"diff_url": "https://github.com/huggingface/datasets/pull/21.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/21.patch",
"merged_at": "2020-05-01T09:29:46"
} | true | Cleanup Features - Updating convert command - Fix Download manager
This PR makes a number of changes:
# Updating `Features`
Features are a complex mechanism provided in `tfds` to be able to modify a dataset on-the-fly when serializing to disk and when loading from disk.
We don't really need this because (1) it... | [
"For conflicts, I think the mention hint \"This should be modified because it mentions ...\" is missing.",
"Looks great!"
] |
https://api.github.com/repos/huggingface/datasets/issues/20 | 20 | remove boto3 and promise dependencies | With the new download manager, we don't need `promise` anymore.
I also removed `boto3` as in [this pr](https://github.com/huggingface/transformers/pull/3968) | closed | 2020-04-27T07:39:45 | https://api.github.com/repos/huggingface/datasets/issues/20/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/20",
"html_url": "https://github.com/huggingface/datasets/pull/20",
"diff_url": "https://github.com/huggingface/datasets/pull/20.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/20.patch",
"merged_at": "2020-04-27T14:15:45"
} | true | remove boto3 and promise dependencies
With the new download manager, we don't need `promise` anymore.
I also removed `boto3` as in [this pr](https://github.com/huggingface/transformers/pull/3968) | [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.