Support streaming

squad_kor_v2.py

@@ -17,7 +17,6 @@
 
 
 import json
-import os
 
 import datasets
 
@@ -105,44 +104,49 @@ class SquadKorV2(datasets.GeneratorBasedBuilder):
         downloaded_files = dl_manager.download_and_extract(urls_to_download)
 
         return [
-            datasets.SplitGenerator(name=datasets.Split.TRAIN, gen_kwargs={"dirs": downloaded_files["train"]}),
             datasets.SplitGenerator(
-                name=datasets.Split.VALIDATION, gen_kwargs={"dirs": downloaded_files["validation"]}
+                name=datasets.Split.TRAIN,
+                gen_kwargs={
+                    "filepaths": dl_manager.iter_files(downloaded_files["train"]),
+                },
+            ),
+            datasets.SplitGenerator(
+                name=datasets.Split.VALIDATION,
+                gen_kwargs={
+                    "filepaths": dl_manager.iter_files(downloaded_files["validation"]),
+                },
             ),
         ]
 
-    def _generate_examples(self, dirs):
+    def _generate_examples(self, filepaths):
         """Yields examples."""
-
-        for d in dirs:
-            filepaths = sorted(os.scandir(d), key=lambda x: x.name)
-            for filepath in filepaths:
-                with open(filepath.path, encoding="utf-8") as f:
-                    squad = json.load(f)
-                    for example in squad["data"]:
-                        title = example.get("title", "").strip()
-                        url = example.get("url", "").strip()
-                        raw_html = example.get("raw_html", "").strip()
-                        context = example["context"].strip()
-                        for qa in example["qas"]:
-                            question = qa["question"].strip()
-                            answer = qa["answer"]
-                            id_ = qa["id"]
-
-                            answer_start = answer["answer_start"]
-                            html_answer_start = answer["html_answer_start"]
-                            answer_text = answer["text"].strip()
-
-                            yield id_, {
-                                "title": title,
-                                "context": context,
-                                "question": question,
-                                "id": id_,
-                                "answer": {
-                                    "answer_start": answer_start,
-                                    "html_answer_start": html_answer_start,
-                                    "text": answer_text,
-                                },
-                                "url": url,
-                                "raw_html": raw_html,
-                            }
+        for filepath in filepaths:
+            with open(filepath, encoding="utf-8") as f:
+                squad = json.load(f)
+                for example in squad["data"]:
+                    title = example.get("title", "").strip()
+                    url = example.get("url", "").strip()
+                    raw_html = example.get("raw_html", "").strip()
+                    context = example["context"].strip()
+                    for qa in example["qas"]:
+                        question = qa["question"].strip()
+                        answer = qa["answer"]
+                        id_ = qa["id"]
+
+                        answer_start = answer["answer_start"]
+                        html_answer_start = answer["html_answer_start"]
+                        answer_text = answer["text"].strip()
+
+                        yield id_, {
+                            "title": title,
+                            "context": context,
+                            "question": question,
+                            "id": id_,
+                            "answer": {
+                                "answer_start": answer_start,
+                                "html_answer_start": html_answer_start,
+                                "text": answer_text,
+                            },
+                            "url": url,
+                            "raw_html": raw_html,
+                        }