Search is not available for this dataset
hash string | author int32 | committer_date string | timezone int64 | parents string | message string | changes string | language string |
|---|---|---|---|---|---|---|---|
8252c372af84d8f5d2de40674af5eeda96e387e6 | 29 | 2020-11-05 15:08:07-06:00 | 21,600 | ['396af238421458ace5ca9fb0218fd9d02257fdae'] | Provide a way to tell when event handlers are finished
This lets us actually wait for disposal before a graceful exit. | [{'old_path': 'src/common/emitter.ts', 'new_path': 'src/common/emitter.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,4 +1,10 @@\n-import { Callback } from "./types"\n+import { logger } from "@coder/logger"\n+\n+/**\n+ * Event emitter callback. Called with the emitted value and a promise that\n+ * resolves w... | TypeScript |
9e09c1f92b27b4da5c38e56d282f62f646405358 | 29 | 2020-11-05 15:08:08-06:00 | 21,600 | ['8252c372af84d8f5d2de40674af5eeda96e387e6'] | Upgrade to Express 5
Now async routes are handled! | [{'old_path': 'package.json', 'new_path': 'package.json', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -72,7 +72,7 @@\n "body-parser": "^1.19.0",\n "cookie-parser": "^1.4.5",\n "env-paths": "^2.2.0",\n- "express": "^4.17.1",\n+ "express": "^5.0.0-alpha.8",\n "fs-extra": "^9.0.1",\n "http-... | TypeScript |
7b2752a62cd770d411aa9abb30b2082efc312dba | 29 | 2020-11-05 15:08:09-06:00 | 21,600 | ['9e09c1f92b27b4da5c38e56d282f62f646405358'] | Move websocket routes into a separate app
This is mostly so we don't have to do any wacky patching but it also
makes it so we don't have to keep checking if the request is a web
socket request every time we add middleware. | [{'old_path': 'src/node/app.ts', 'new_path': 'src/node/app.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,12 +4,12 @@ import { promises as fs } from "fs"\n import http from "http"\n import * as httpolyglot from "httpolyglot"\n import { DefaultedArgs } from "./cli"\n-import { handleUpgrade } from "./http"\n+i... | TypeScript |
3f1750cf83ac23ef390e997cb039eb3ec30d2f58 | 29 | 2020-11-05 15:08:10-06:00 | 21,600 | ['7b2752a62cd770d411aa9abb30b2082efc312dba'] | Fix destroying response in update again
I added another reject that doesn't destroy the response. | [{'old_path': 'src/node/update.ts', 'new_path': 'src/node/update.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -111,14 +111,13 @@ export class UpdateProvider {\n \n if (response.statusCode >= 300) {\n ++redirects\n- if (redirects > maxRedirects) {\n response.destroy... | TypeScript |
cb991a9143137287321ae48861620565630103d3 | 29 | 2020-11-05 15:19:56-06:00 | 21,600 | ['3f1750cf83ac23ef390e997cb039eb3ec30d2f58'] | Handle errors for JSON requests
Previously it would have just given them the error HTML. | [{'old_path': 'src/node/routes/index.ts', 'new_path': 'src/node/routes/index.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -121,23 +121,29 @@ export const register = async (\n throw new HttpError("Not Found", HttpCode.NotFound)\n })\n \n- const errorHandler: express.ErrorRequestHandler = async (err, req... | TypeScript |
f6c4434191eb529aaa0f86e98365b490bb81a0d8 | 29 | 2020-11-05 16:49:30-06:00 | 21,600 | ['cb991a9143137287321ae48861620565630103d3'] | Tweak proxy fallthrough behavior
It will now redirect all HTML requests. Also it avoids req.accepts since
that's always truthy. | [{'old_path': 'src/node/proxy.ts', 'new_path': 'src/node/proxy.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,7 +1,7 @@\n import { Request, Router } from "express"\n import proxyServer from "http-proxy"\n import { HttpCode, HttpError } from "../common/http"\n-import { authenticated, ensureAuthenticated } fro... | TypeScript |
f7076247f96210ea0049897582a0c8b50bfdfea1 | 29 | 2020-11-05 17:07:32-06:00 | 21,600 | ['f6c4434191eb529aaa0f86e98365b490bb81a0d8'] | Move domain proxy to routes
This matches better with the other routes.
Also add a missing authentication check to the path proxy web socket. | [{'old_path': 'src/node/proxy.ts', 'new_path': 'src/node/proxy.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,10 +1,8 @@\n-import { Request, Router } from "express"\n import proxyServer from "http-proxy"\n-import { HttpCode, HttpError } from "../common/http"\n-import { authenticated, ensureAuthenticated, red... | TypeScript |
959497067c32e265661f1d70c864e793b0e96084 | 29 | 2020-11-05 17:07:58-06:00 | 21,600 | ['f7076247f96210ea0049897582a0c8b50bfdfea1'] | Document HttpError
Also type the status. | [{'old_path': 'src/common/http.ts', 'new_path': 'src/common/http.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,8 +8,12 @@ export enum HttpCode {\n ServerError = 500,\n }\n \n+/**\n+ * Represents an error with a message and an HTTP status code. This code will be\n+ * used in the HTTP response.\n+ */\n expo... | TypeScript |
481df70622e260b8628af76c70933db419ac4f33 | 55 | 2020-11-06 10:11:57-05:00 | 14,400 | ['aa2cfa2c17ebc91e87f2a0df442cecff7fe55e6a'] | ci/dev/test.sh: Pass through args | [{'old_path': 'ci/dev/test.sh', 'new_path': 'ci/dev/test.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,7 +4,7 @@ set -euo pipefail\n main() {\n cd "$(dirname "$0")/../.."\n \n- mocha -r ts-node/register ./test/*.test.ts\n+ mocha -r ts-node/register ./test/*.test.ts "$@"\n }\n \n main "$@"\n'}] | TypeScript |
e08a55d44a1067c54cc845efd54cc31271c3ae08 | 55 | 2020-11-06 10:12:45-05:00 | 14,400 | ['481df70622e260b8628af76c70933db419ac4f33'] | src/node/plugin.ts: Implement new plugin API | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,92 +1,177 @@\n-import { field, logger } from "@coder/logger"\n-import { Express } from "express"\n-import * as fs from "fs"\n import * as path from "path"\n-import * as util from "util"\n-import { ... | TypeScript |
bea185b8b2cf3487e4dc63c95d822bca76d3a030 | 55 | 2020-11-06 10:12:46-05:00 | 14,400 | ['e08a55d44a1067c54cc845efd54cc31271c3ae08'] | plugin: Add basic loading test
Will work on testing overlay next. | [{'old_path': None, 'new_path': 'test/plugin.test.ts', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1,31 @@\n+import { describe } from "mocha"\n+import { PluginAPI } from "../src/node/plugin"\n+import { logger } from "@coder/logger"\n+import * as path from "path"\n+import * as assert from "assert"\n+\n+/**\n+ *... | TypeScript |
30d2962e21468825e545235c3e272c6a7ffefe97 | 55 | 2020-11-06 10:12:46-05:00 | 14,400 | ['82e8a00a0d9dff6bcb4ca754ded9dbe1f42407cd'] | src/node/plugin.ts: Warn on duplicate plugin and only load first | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,11 +8,18 @@ import { version } from "./constants"\n import * as util from "./util"\n const fsp = fs.promises\n \n-// These fields are populated from the plugin\'s package.json.\n interface Plugin e... | TypeScript |
ef971009d9632e333e2428fc3214dd2fa6f9ac02 | 55 | 2020-11-06 10:12:46-05:00 | 14,400 | ['30d2962e21468825e545235c3e272c6a7ffefe97'] | plugin.test.ts: Make it clear iconPath is a path | [{'old_path': 'test/plugin.test.ts', 'new_path': 'test/plugin.test.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -20,7 +20,7 @@ describe("plugin", () => {\n {\n name: "goland",\n version: "4.0.0",\n- iconPath: "icon.svg",\n+ iconPath: "/icon.svg",\n plugi... | TypeScript |
f4d7f000331fe8152bfb95b7552c031e41fb3cd4 | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['ef971009d9632e333e2428fc3214dd2fa6f9ac02'] | plugin.ts: Fixes for @wbobeirne | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -150,9 +150,6 @@ export class PluginAPI {\n if (!packageJSON.version) {\n throw new Error("plugin missing version")\n }\n- if (!packageJSON.description) {\n- throw new Error("plu... | TypeScript |
75e52a37742833679711fca2b48fdf8a04fcb521 | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['f4d7f000331fe8152bfb95b7552c031e41fb3cd4'] | plugin.ts: Fixes for @code-asher | [{'old_path': 'ci/dev/test.sh', 'new_path': 'ci/dev/test.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -4,6 +4,9 @@ set -euo pipefail\n main() {\n cd "$(dirname "$0")/../.."\n \n+ cd test/test-plugin\n+ make -s out/index.js\n+ cd $OLDPWD\n mocha -r ts-node/register ./test/*.test.ts "$@"\n }\n \n'}, {'ol... | TypeScript |
8d3a7721feaa7e319ec6182fbe4806a301b2671a | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['75e52a37742833679711fca2b48fdf8a04fcb521'] | plugin.d.ts: Document plugin priority correctly | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -89,22 +89,22 @@ export class PluginAPI {\n * this.csPluginPath and the built in plugins.\n */\n public async loadPlugins(): Promise<void> {\n- // Built-in plugins.\n- await this._loadPl... | TypeScript |
6638daf6f05a21bf82dab86690635045443a055d | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['8d3a7721feaa7e319ec6182fbe4806a301b2671a'] | plugin.d.ts: Add explicit path field and adjust types to reflect
See my discussion with Will in the PR. | [{'old_path': 'typings/plugin.d.ts', 'new_path': 'typings/plugin.d.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,7 +10,7 @@ import * as express from "express"\n * The homepage of code-server will launch into VS Code. However, there will be an overlay\n * button that when clicked, will show all available ... | TypeScript |
fed545e67d77e5792a0a4ee00aa4a0485ff925eb | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['6638daf6f05a21bf82dab86690635045443a055d'] | plugin.d.ts -> pluginapi.d.ts
More clear. | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3,7 +3,7 @@ import * as express from "express"\n import * as fs from "fs"\n import * as path from "path"\n import * as semver from "semver"\n-import * as pluginapi from "../../typings/plugin"\n+impor... | TypeScript |
afff86ae9cd68f5e8d87e28dc9e78002489874df | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['fed545e67d77e5792a0a4ee00aa4a0485ff925eb'] | plugin.ts: Adjust to implement pluginapi.d.ts correctly | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,11 +10,11 @@ const fsp = fs.promises\n \n interface Plugin extends pluginapi.Plugin {\n /**\n- * These fields are populated from the plugin\'s package.json.\n+ * These fields are populated f... | TypeScript |
e03bbe31497b5581e578e03ebc5abc7a11b43580 | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['afff86ae9cd68f5e8d87e28dc9e78002489874df'] | routes/apps.ts: Implement /api/applications endpoint | [{'old_path': None, 'new_path': 'src/node/routes/apps.ts', 'type': <ModificationType.ADD: 1>, 'diff': '@@ -0,0 +1,12 @@\n+import * as express from "express"\n+import { PluginAPI } from "../plugin"\n+\n+export function router(papi: PluginAPI): express.Router {\n+ const router = express.Router()\n+\n+ router.get("/", a... | TypeScript |
139a28e0ea063120a6adc4880f93f9c4d14bbdd4 | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['e03bbe31497b5581e578e03ebc5abc7a11b43580'] | plugin.ts: Describe private counterpart functions
Addresses Will's comments. | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -110,6 +110,13 @@ export class PluginAPI {\n await this._loadPlugins(path.join(__dirname, "../../plugins"))\n }\n \n+ /**\n+ * _loadPlugins is the counterpart to loadPlugins.\n+ *\n+ * It... | TypeScript |
687094802ec4bb88ed4b07ecdf072e3249dfc7ca | 55 | 2020-11-06 10:12:46-05:00 | 18,000 | ['139a28e0ea063120a6adc4880f93f9c4d14bbdd4'] | plugin.ts: Make application endpoint paths absolute | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -60,6 +60,8 @@ export class PluginAPI {\n // Add plugin key to each app.\n apps.push(\n ...pluginApps.map((app) => {\n+ app = {...app, path: path.join(p.routerPath, app.pa... | TypeScript |
2a13d003d37d97f8650bd15f29baa45cd4fb1d5a | 55 | 2020-11-06 10:12:47-05:00 | 18,000 | ['687094802ec4bb88ed4b07ecdf072e3249dfc7ca'] | plugin.ts: Add homepageURL to plugin and application | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -72,6 +72,7 @@ export class PluginAPI {\n displayName: p.displayName,\n description: p.description,\n routerPath: p.routerPath,\n+ homepageURL: p... | TypeScript |
af73b96313c4d31da917ec46cbee390c7bbb32e9 | 55 | 2020-11-06 10:12:47-05:00 | 18,000 | ['2a13d003d37d97f8650bd15f29baa45cd4fb1d5a'] | routes/apps.ts: Add example output | [{'old_path': 'src/node/routes/apps.ts', 'new_path': 'src/node/routes/apps.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3,6 +3,8 @@ import { PluginAPI } from "../plugin"\n \n /**\n * Implements the /api/applications endpoint\n+ *\n+ * See typings/pluginapi.d.ts for details.\n */\n export function router(pa... | TypeScript |
706bc23f0489bf0fe9a4b844cc36077f52600041 | 55 | 2020-11-06 10:13:01-05:00 | 18,000 | ['af73b96313c4d31da917ec46cbee390c7bbb32e9'] | plugin: Fixes for CI | [{'old_path': 'ci/dev/test.sh', 'new_path': 'ci/dev/test.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -6,7 +6,7 @@ main() {\n \n cd test/test-plugin\n make -s out/index.js\n- cd $OLDPWD\n+ cd "$OLDPWD"\n mocha -r ts-node/register ./test/*.test.ts "$@"\n }\n \n'}, {'old_path': 'src/node/plugin.ts', 'ne... | TypeScript |
8a8159c683c07c8f8e854b7c176077e1b8360c39 | 55 | 2020-11-06 10:13:01-05:00 | 18,000 | ['706bc23f0489bf0fe9a4b844cc36077f52600041'] | plugin: More review fixes
Next commit will address Will's comments about the typings being weird. | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -86,7 +86,7 @@ export class PluginAPI {\n */\n public mount(r: express.Router): void {\n for (const [, p] of this.plugins) {\n- r.use(`/${p.name}`, p.router())\n+ r.use(`/${p.router... | TypeScript |
14f408a837cbdd301545d4241da4e6ecd90857cb | 55 | 2020-11-06 10:13:01-05:00 | 18,000 | ['8a8159c683c07c8f8e854b7c176077e1b8360c39'] | plugin: Plugin modules now export a single top level identifier
Makes typing much easier. Addresse's Will's last comment. | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -189,11 +189,16 @@ export class PluginAPI {\n )\n }\n \n+ const pluginModule = require(dir)\n+ if (!pluginModule.plugin) {\n+ throw new Error("plugin module does not export a plug... | TypeScript |
9453f891df6283747f0b53b7dfb52524bdf346ea | 55 | 2020-11-06 10:13:01-05:00 | 18,000 | ['14f408a837cbdd301545d4241da4e6ecd90857cb'] | plugin.ts: Fix usage of routerPath in mount | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -86,7 +86,7 @@ export class PluginAPI {\n */\n public mount(r: express.Router): void {\n for (const [, p] of this.plugins) {\n- r.use(`/${p.routerPath}`, p.router())\n+ r.use(`${p.r... | TypeScript |
197a09f0c1227a47ea709042ea6c46bb6ded5227 | 55 | 2020-11-06 10:13:01-05:00 | 18,000 | ['9453f891df6283747f0b53b7dfb52524bdf346ea'] | plugin: Test endpoints via supertest
Unfortunately we can't use node-mocks-http to test a express.Router
that has async routes. See https://github.com/howardabrams/node-mocks-http/issues/225
router will just return undefined if the executing handler is async and
so the test will have no way to wait for it to complete... | [{'old_path': 'package.json', 'new_path': 'package.json', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -43,6 +43,7 @@\n "@types/safe-compare": "^1.1.0",\n "@types/semver": "^7.1.0",\n "@types/split2": "^2.1.6",\n+ "@types/supertest": "^2.0.10",\n "@types/tar-fs": "^2.0.0",\n "@types/tar-stre... | TypeScript |
9d39c53c99eb5398ecd0df5a3ef0c0f8b3ec80c7 | 55 | 2020-11-06 14:47:08-05:00 | 18,000 | ['197a09f0c1227a47ea709042ea6c46bb6ded5227'] | plugin: Give test-plugin some html to test overlay | [{'old_path': 'test/plugin.test.ts', 'new_path': 'test/plugin.test.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -5,6 +5,8 @@ import { PluginAPI } from "../src/node/plugin"\n import * as supertest from "supertest"\n import * as express from "express"\n import * as apps from "../src/node/routes/apps"\n+import *... | TypeScript |
277211c4ce0ca66af19c0ffb80a4d64dec4099b5 | 55 | 2020-11-06 14:47:08-05:00 | 18,000 | ['9d39c53c99eb5398ecd0df5a3ef0c0f8b3ec80c7'] | plugin: Make init and applications callbacks optional | [{'old_path': 'src/node/plugin.ts', 'new_path': 'src/node/plugin.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -55,6 +55,9 @@ export class PluginAPI {\n public async applications(): Promise<Application[]> {\n const apps = new Array<Application>()\n for (const [, p] of this.plugins) {\n+ if (!p.a... | TypeScript |
da6000b96f8666cd21e5da108e421a2d66b72e1f | 79 | 2020-11-10 14:00:05-05:00 | 18,000 | ['1eebde56ab6618252dfabcd778715fc685a9d885'] | Add Slack link to issue template (#2282) | [{'old_path': '.github/ISSUE_TEMPLATE/config.yml', 'new_path': '.github/ISSUE_TEMPLATE/config.yml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -2,4 +2,7 @@ blank_issues_enabled: false\n contact_links:\n - name: Question\n url: https://github.com/cdr/code-server/discussions/new?category_id=22503114\n- ab... | TypeScript |
77c2a72cf8b5f0c800a2c8d53b219b877b3b9fe0 | 76 | 2020-11-10 20:07:38+00:00 | 0 | ['f3d7d3f616e38a4418ae82b573310aca42e049ec'] | Bump version and update README | [{'old_path': 'charts/code-server/README.md', 'new_path': 'charts/code-server/README.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,6 +1,6 @@\n # code-server\n \n- ![Type: application](https://img.shields.io/badge/Ty... | TypeScript |
0a01338edd3a618a943567b8b95c7fce37890f9c | 29 | 2020-11-10 16:36:46-06:00 | 21,600 | ['d969a5bd6b62b1cd427d09a80cfab73baa17ec7a'] | Deduplicate child process message dance | [{'old_path': 'src/node/vscode.ts', 'new_path': 'src/node/vscode.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -13,6 +13,7 @@ export class VscodeProvider {\n public readonly serverRootPath: string\n public readonly vsRootPath: string\n private _vscode?: Promise<cp.ChildProcess>\n+ private timeoutInterva... | TypeScript |
71850e312bc981a62af80f96d64c4fef39706b62 | 29 | 2020-11-10 18:14:18-06:00 | 21,600 | ['b8340a2ae9f9a543fe3a34c00e51fe925bf20ecd'] | Avoid setting ?to=/
That's the default so it's extra visual noise. | [{'old_path': 'src/node/routes/domainProxy.ts', 'new_path': 'src/node/routes/domainProxy.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -55,7 +55,7 @@ router.all("*", (req, res, next) => {\n }\n // Redirect all other pages to the login.\n return redirect(req, res, "login", {\n- to: req.... | TypeScript |
4574593664cc4aaab167ef477389b5e88f5baa8f | 29 | 2020-11-10 18:21:20-06:00 | 21,600 | ['71850e312bc981a62af80f96d64c4fef39706b62'] | Refactor vscode init to use async
Hopefully is a bit easier to read. | [{'old_path': 'src/node/routes/vscode.ts', 'new_path': 'src/node/routes/vscode.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -22,18 +22,14 @@ router.get("/", async (req, res) => {\n \n const [content, options] = await Promise.all([\n await fs.readFile(path.join(rootPath, "src/browser/pages/vscode.html"),... | TypeScript |
79478eb89f30752d96ec8726dae8d359e13d369b | 29 | 2020-11-10 18:53:38-06:00 | 21,600 | ['4574593664cc4aaab167ef477389b5e88f5baa8f'] | Clarify some points around the cookie domain
Also add a check that the domain has a dot. This covers the localhost
case as well, so remove that. | [{'old_path': 'src/node/http.ts', 'new_path': 'src/node/http.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -98,27 +98,36 @@ export const redirect = (\n \n /**\n * Get the value that should be used for setting a cookie domain. This will\n- * allow the user to authenticate only once. This will use the highest l... | TypeScript |
72931edcf010c2e6ce9872f7e1ab974f999e09cb | 29 | 2020-11-12 11:16:21-06:00 | 21,600 | ['79478eb89f30752d96ec8726dae8d359e13d369b'] | Fix cleanup after getting message from vscode | [{'old_path': 'src/node/vscode.ts', 'new_path': 'src/node/vscode.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -123,8 +123,19 @@ export class VscodeProvider {\n fn: (message: ipc.VscodeMessage) => message is T,\n ): Promise<T> {\n return new Promise((resolve, _reject) => {\n- const reject = (err... | TypeScript |
31b67062b013ec5039c96e534e52891462edc2b1 | 29 | 2020-11-12 11:17:45-06:00 | 21,600 | ['72931edcf010c2e6ce9872f7e1ab974f999e09cb'] | Remove <type> from onMessage
Turns out that while Typescript can't infer the callback return type
from it, Typescript can do the opposite and infer it from the callback
return type. | [{'old_path': 'src/node/vscode.ts', 'new_path': 'src/node/vscode.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -69,7 +69,7 @@ export class VscodeProvider {\n vscode,\n )\n \n- const message = await this.onMessage<ipc.OptionsMessage>(vscode, (message): message is ipc.OptionsMessage => {\n+ const... | TypeScript |
5499a3d12562f4b5b15cb684f53428a8f68798e6 | 29 | 2020-11-12 11:23:52-06:00 | 21,600 | ['31b67062b013ec5039c96e534e52891462edc2b1'] | Use baseUrl when redirecting from domain proxy
This will make the route more robust since it'll work under more than
just the root. | [{'old_path': 'src/node/routes/domainProxy.ts', 'new_path': 'src/node/routes/domainProxy.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,5 +1,6 @@\n import { Request, Router } from "express"\n import { HttpCode, HttpError } from "../../common/http"\n+import { normalize } from "../../common/util"\n import { au... | TypeScript |
b73ea2fea2bbc80f5f363d9f40d1687d2396b280 | 29 | 2020-11-12 12:03:28-06:00 | 21,600 | ['e1702a1d211273fb19565ba1ba9989d17910919e'] | Unbind message handler itself after getting message
Also switch `once` to `on` since we `off` them later anyway so no point
in making Node do it twice. | [{'old_path': 'src/node/vscode.ts', 'new_path': 'src/node/vscode.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -126,6 +126,7 @@ export class VscodeProvider {\n const cleanup = () => {\n proc.off("error", reject)\n proc.off("exit", onExit)\n+ proc.off("message", onMessage)\n ... | TypeScript |
6f14b8b8dd123ae6b2b969dba3b920c5f81d3f06 | 29 | 2020-11-12 12:07:45-06:00 | 21,600 | ['b73ea2fea2bbc80f5f363d9f40d1687d2396b280'] | Add separate handler for error
Feels like it parallels better with the other handlers. | [{'old_path': 'src/node/vscode.ts', 'new_path': 'src/node/vscode.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -122,9 +122,9 @@ export class VscodeProvider {\n proc: cp.ChildProcess,\n fn: (message: ipc.VscodeMessage) => message is T,\n ): Promise<T> {\n- return new Promise((resolve, _reject) => {... | TypeScript |
9889f30224b8d68e9fbbbded709dbdb408e018ed | 29 | 2020-11-12 12:30:41-06:00 | 21,600 | ['96995b78d1e8eaeb20a0c7f535b60b48b07b35cf'] | Remove unused ts-expect-error from VS Code
I'm not sure why other builds are passing with this still in. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -210,6 +210,18 @@ index da4fa3e9d0443d679dfbab1000b434af2ae01afd..50f3e1144f8057883dea8b91ec2f7073\n }\n \n function processLib() {\n+diff --git a/extensions/typescript-language-features/src/util... | TypeScript |
52ea32f4a7e45c64cef7d654794bbffd7f8debb9 | 55 | 2020-11-13 17:27:52-05:00 | 18,000 | ['affa64c89c74db531284e767e8a09fc443d27506'] | helm: Move chart into ci/helm-chart | [{'old_path': '.github/CODEOWNERS', 'new_path': '.github/CODEOWNERS', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,2 +1,3 @@\n-charts/code-server @Matthew-Beckett @alexgorbatchev \n * @code-asher @nhooyr\n+\n+ci/helm-chart @Matthew-Beckett @alexgorbatchev\n'}, {'old_path': 'charts/code-server/.helmignore', 'new... | TypeScript |
248c2adb2e00fb72514ab55d235a55eaf0ac97e0 | 55 | 2020-11-13 18:38:58-05:00 | 18,000 | ['52ea32f4a7e45c64cef7d654794bbffd7f8debb9'] | helm: Fix README examples
Not sure where --name came from? Maybe an older version of helm.
Ah, it's from v2.16.7 | [{'old_path': 'ci/helm-chart/README.md', 'new_path': 'ci/helm-chart/README.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -10,8 +10,9 @@ This chart is community maintained by [@Matthew-Beckett](https://github.com/Matt\n ## TL;DR;\n \n ```console\n-$ git clone https://github.com/cdr/code-server.git\n-$ helm inst... | TypeScript |
9af3671c05c1f229f90f5c1170f08a4e21cc5b61 | 55 | 2020-11-13 18:38:58-05:00 | 18,000 | ['248c2adb2e00fb72514ab55d235a55eaf0ac97e0'] | helm: Add link in install.md | [{'old_path': 'ci/dev/fmt.sh', 'new_path': 'ci/dev/fmt.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -19,7 +19,9 @@ main() {\n "*.yaml"\n "*.yml"\n )\n- prettier --write --loglevel=warn $(git ls-files "${prettierExts[@]}")\n+ prettier --write --loglevel=warn $(\n+ git ls-files "${prettierExts[@]... | TypeScript |
f4d48bc880b681714ada3dd976e1f05bb55624c4 | 55 | 2020-11-13 18:38:58-05:00 | 18,000 | ['9af3671c05c1f229f90f5c1170f08a4e21cc5b61'] | ci: Remove helm validation action in favour of helm kubeval directly | [{'old_path': '.github/workflows/helm_validation.yaml', 'new_path': None, 'type': <ModificationType.DELETE: 4>, 'diff': '@@ -1,14 +0,0 @@\n-name: Helm Validation\n-\n-on: [pull_request, issues]\n-\n-jobs:\n- validate:\n- runs-on: ubuntu-latest\n- steps:\n- - name: Checkout Repo\n- uses: actions/check... | TypeScript |
40a7c11ce3f0d9c5416eb7d54ab529b80a4847dc | 55 | 2020-11-13 18:44:28-05:00 | 18,000 | ['7afa689285d5208a024eca18a0b22e00d03529a5'] | node/routes: Fix error handling
We should always send HTML if the user agent expects it.
If they do not, they should clearly indicate such via the Accept header.
Closes #2297 | [{'old_path': 'src/node/routes/domainProxy.ts', 'new_path': 'src/node/routes/domainProxy.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -48,8 +48,8 @@ router.all("*", (req, res, next) => {\n // Assume anything that explicitly accepts text/html is a user browsing a\n // page (as opposed to an xhr request... | TypeScript |
a37572d92d0e87d00e521637b3e5a3809f60490d | 55 | 2020-11-13 18:44:28-05:00 | 18,000 | ['40a7c11ce3f0d9c5416eb7d54ab529b80a4847dc'] | ci: Disable no-unused-vars for function args
See previous commit for failure introduced. | [{'old_path': '.eslintrc.yaml', 'new_path': '.eslintrc.yaml', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -19,6 +19,9 @@ extends:\n - prettier/@typescript-eslint # Remove conflicts again.\n \n rules:\n+ # Sometimes you need to add args to implement a function signature even\n+ # if they are unused.\n+ "@type... | TypeScript |
79e8f3dfdbc0fe1d61a0ae387b5f0dc262464c69 | 55 | 2020-11-13 18:44:29-05:00 | 18,000 | ['a37572d92d0e87d00e521637b3e5a3809f60490d'] | ci: Only use helm kubeval if installed | [{'old_path': 'ci/dev/lint.sh', 'new_path': 'ci/dev/lint.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -8,7 +8,9 @@ main() {\n stylelint $(git ls-files "*.css")\n tsc --noEmit\n shellcheck -e SC2046,SC2164,SC2154,SC1091,SC1090,SC2002 $(git ls-files "*.sh")\n+ if command -v helm && helm kubeval --help > ... | TypeScript |
8bf1bf2c9fe8973292327978a05c06c1017603d6 | 55 | 2020-11-13 18:45:13-05:00 | 18,000 | ['79e8f3dfdbc0fe1d61a0ae387b5f0dc262464c69'] | helm: Use upgrade --install everywhere
See @sreya's review | [{'old_path': 'ci/helm-chart/README.md', 'new_path': 'ci/helm-chart/README.md', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -100,7 +100,7 @@ Specify each parameter using the `--set key=value[,key=value]` argument to `helm\n install`. For example,\n \n ```console\n-$ helm install code-server \\\n+$ helm upgrade --... | TypeScript |
f64599b94df56cb6186dd951f4e6c054aa4c7e78 | 55 | 2020-11-16 14:40:06-05:00 | 18,000 | ['9917da068a2d8909ece1b646a6307a073f157b08'] | ci: Update standalone build test
ms-toolsai.jupyter is now a dependency of ms-python and is installed
along with it. | [{'old_path': 'ci/build/test-standalone-release.sh', 'new_path': 'ci/build/test-standalone-release.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,7 +15,8 @@ main() {\n ./release-standalone/bin/code-server --extensions-dir "$EXTENSIONS_DIR" --install-extension ms-python.python\n local installed_extension... | TypeScript |
40e1f066ffba62f84f2ece40d5dfe4a3a7f05955 | 55 | 2020-11-16 16:56:53-05:00 | 18,000 | ['ac09aa6ea8f12fc94f13b8421e574d14c9ec5993'] | ci: Improve release template (#2311) | [{'old_path': 'ci/build/release-github-draft.sh', 'new_path': 'ci/build/release-github-draft.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,7 +15,13 @@ v$VERSION\n \n VS Code v$(vscode_version)\n \n-- Summarize changes here with references to issues\n+# New Features\n+ - ⭐ Summarize new features here with ... | TypeScript |
ccc519ecbd5a7d67c50c6df306bb5397e674977b | 55 | 2020-11-16 16:57:04-05:00 | 18,000 | ['40e1f066ffba62f84f2ece40d5dfe4a3a7f05955'] | ci: Pin nfpm to v1.9.0
Closes #2310 | [{'old_path': 'ci/images/centos7/Dockerfile', 'new_path': 'ci/images/centos7/Dockerfile', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -27,6 +27,6 @@ ENV PATH=/usr/local/go/bin:$GOPATH/bin:$PATH\n # Install Go dependencies\n ENV GO111MODULE=on\n RUN go get mvdan.cc/sh/v3/cmd/shfmt\n-RUN go get github.com/gorelease... | TypeScript |
c6062c3d0a405be3c48ad2d3c8f69196571c88aa | 5 | 2020-11-18 10:41:32-06:00 | -25,200 | ['9ff535eddc9c36f39490c656179da19c3d2dce36'] | Fix log message (#2331) | [{'old_path': 'src/node/entry.ts', 'new_path': 'src/node/entry.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -121,7 +121,7 @@ const main = async (args: DefaultedArgs): Promise<void> => {\n }\n \n if (args.cert) {\n- logger.info(" - Using certificate for HTTPS: ${humanPath(args.cert.value)}")\n+ logg... | TypeScript |
2a3608df533fbac4ec41e0be094614c7684319a7 | 29 | 2020-11-18 12:19:08-06:00 | 21,600 | ['c6062c3d0a405be3c48ad2d3c8f69196571c88aa'] | Skip heartbeat on /healthz endpoint (#2333)
I managed to lose this in the rewrite.
Fixes #2327. | [{'old_path': 'src/node/routes/index.ts', 'new_path': 'src/node/routes/index.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -66,7 +66,11 @@ export const register = async (\n app.use(bodyParser.urlencoded({ extended: true }))\n \n const common: express.RequestHandler = (req, _, next) => {\n+ // /healthz|/... | TypeScript |
d55e06936bab67d1c364fec61dfc5b01c3ff33cc | 29 | 2020-11-18 12:28:42-06:00 | 21,600 | ['2a3608df533fbac4ec41e0be094614c7684319a7'] | Split child and parent wrappers
I think having them combined and relying on if statements was getting
confusing especially if we want to add additional messages with
different payloads (which will soon be the case). | [{'old_path': 'src/node/entry.ts', 'new_path': 'src/node/entry.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -19,7 +19,7 @@ import { coderCloudBind } from "./coder-cloud"\n import { commit, version } from "./constants"\n import { register } from "./routes"\n import { humanPath, isFile, open } from "./util"\n-i... | TypeScript |
247c4ec77623048e0a08a2e785f78e5972d591de | 29 | 2020-11-18 12:28:43-06:00 | 21,600 | ['d55e06936bab67d1c364fec61dfc5b01c3ff33cc'] | Move onMessage so it can be used in the wrappers | [{'old_path': 'src/node/vscode.ts', 'new_path': 'src/node/vscode.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1,4 +1,4 @@\n-import { field, logger } from "@coder/logger"\n+import { logger } from "@coder/logger"\n import * as cp from "child_process"\n import * as net from "net"\n import * as path from "path"\... | TypeScript |
016daf2fdd5056b29b6f80ab9fbeac55b218e2de | 29 | 2020-11-18 13:01:46-06:00 | 21,600 | ['247c4ec77623048e0a08a2e785f78e5972d591de'] | Parse arguments once
Fixes #2316. | [{'old_path': 'src/node/entry.ts', 'new_path': 'src/node/entry.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -154,19 +154,22 @@ const main = async (args: DefaultedArgs): Promise<void> => {\n }\n \n async function entry(): Promise<void> {\n- const cliArgs = parse(process.argv.slice(2))\n- const configArgs = a... | TypeScript |
95ef6dbf2f9eaf999406878d195e3318721c1f3c | 29 | 2020-11-18 13:23:06-06:00 | 21,600 | ['016daf2fdd5056b29b6f80ab9fbeac55b218e2de'] | Remove unused wrapper options
Also move our memory default to the beginning of NODE_OPTIONS so it can
be overidden. The version of the flag with dashes seems to be the more
correct one now so use that instead of underscores.
Related: #2113. | [{'old_path': 'src/node/wrapper.ts', 'new_path': 'src/node/wrapper.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -201,11 +201,6 @@ class ChildProcess extends Process {\n }\n }\n \n-export interface WrapperOptions {\n- maxMemory?: number\n- nodeOptions?: string\n-}\n-\n /**\n * Parent process wrapper that ... | TypeScript |
624cd9d44fe47538015875b46fe2902d54d58df4 | 29 | 2020-11-18 17:10:53-06:00 | 21,600 | ['2a3608df533fbac4ec41e0be094614c7684319a7'] | Fix webview 404s
An extra slash caused a 404 (was /webview//vscode-resource). | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -430,7 +430,7 @@ index 2c64061da7b01aef0bfe3cec851da232ca9461c8..c0ef8faedd406c38bf9c55bbbdbbb060\n \t\t\t// Do nothing. If we can't read the file we have no\n \t\t\t// language pack config.\n dif... | TypeScript |
182791319a6f387b448d0e43c405525f6dce268d | 29 | 2020-11-18 17:15:53-06:00 | 21,600 | ['624cd9d44fe47538015875b46fe2902d54d58df4'] | Fix tar authentication
It was checking the request path but for tars the path is in the query
variable so the request path is irrelevant. | [{'old_path': 'src/node/routes/static.ts', 'new_path': 'src/node/routes/static.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -7,13 +7,33 @@ import * as tarFs from "tar-fs"\n import * as zlib from "zlib"\n import { HttpCode, HttpError } from "../../common/http"\n import { rootPath } from "../constants"\n-import... | TypeScript |
f79bb210ec6e78c135db7b006ae447f37be4ca7e | 4 | 2020-11-19 10:37:51-05:00 | -28,800 | ['2a3608df533fbac4ec41e0be094614c7684319a7'] | login.css: Fix button styling on iOS | [{'old_path': 'src/browser/pages/login.css', 'new_path': 'src/browser/pages/login.css', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -26,7 +26,7 @@ body {\n border: 1px solid #ddd;\n box-sizing: border-box;\n color: black;\n- flex: 1;\n+ width: 100%;\n padding: 16px;\n }\n \n@@ -34,6 +34,16 @@ body {\n ... | TypeScript |
2dc7863ec394aea3a51c0c7a526bedcf846c563e | 55 | 2020-11-19 10:43:26-05:00 | 18,000 | ['30100caf0c444fc32d87bf447d6e28dcf5e28eda'] | login.css: Disable webkit appearance for input elements
Not sure why Safari does these things...
Closes #2247 | [{'old_path': 'src/browser/pages/login.css', 'new_path': 'src/browser/pages/login.css', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -37,3 +37,7 @@ body {\n .login-form > .field > .submit {\n margin-left: 20px;\n }\n+\n+input {\n+ -webkit-appearance: none;\n+}\n'}] | TypeScript |
72caafe8b04e1cbc123d44d757fdc97640e4e6c4 | 29 | 2020-11-19 10:18:15-06:00 | 21,600 | ['08b9e9ad1feb498d80f23c5a87f9f2563a0a2de6'] | Fix service worker not loading (#2335)
I removed this under the impression the default was to allow it anywhere
but that's not the case. Since the service worker was already registered
in my browser I never got the error during testing. | [{'old_path': 'src/node/routes/static.ts', 'new_path': 'src/node/routes/static.ts', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -52,6 +52,11 @@ router.get("/(:commit)(/*)?", async (req, res) => {\n res.header("Cache-Control", "public, max-age=31536000")\n }\n \n+ // Without this the default is to use the d... | TypeScript |
e28c9ab287f2e1802c0d6ef28e950404e591d615 | 29 | 2020-11-19 15:51:23-06:00 | 21,600 | ['b540737b107fa2a41d88f7ebbb054ef017c7a065'] | Update VS Code to 1.51.1 | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -12,12 +12,12 @@ index b7f5b58c8ede171be547c56b61ce76f79a3accc3..856fbd8c67460fe099d7fbee1475e906\n coverage/\n diff --git a/.yarnrc b/.yarnrc\n deleted file mode 100644\n-index 3c6eccfb102f2084d16... | TypeScript |
4d276b88c0b2725ae6a262dbaa3e2f73876f8283 | 29 | 2020-11-19 15:51:27-06:00 | 21,600 | ['e28c9ab287f2e1802c0d6ef28e950404e591d615'] | Add new logger service
The telemetry service depends on this now. I had to move it into
invokeFunction and use accessor.get otherwise getLogger on the service
was undefined.
I also had to move some the extension management service because it
depends on the moved telemetry service. I moved a few other services as
well... | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -2585,10 +2585,10 @@ index 0000000000000000000000000000000000000000..0d9310038c0ca378579652d89bc8ac84\n +}\n diff --git a/src/vs/server/node/server.ts b/src/vs/server/node/server.ts\n new file mode ... | TypeScript |
431137da454a68b758fb0b86a8a7e1fb3371337c | 29 | 2020-11-19 15:51:28-06:00 | 21,600 | ['4d276b88c0b2725ae6a262dbaa3e2f73876f8283'] | Add new (unimplemented) terminal service | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1466,10 +1466,10 @@ index 0000000000000000000000000000000000000000..6ce56bec114a6d8daf5dd3ded945ea78\n +}\n diff --git a/src/vs/server/node/channel.ts b/src/vs/server/node/channel.ts\n new file mod... | TypeScript |
3f7b91e2e2004263b5db704826b749009e5bc751 | 29 | 2020-11-19 15:51:29-06:00 | 21,600 | ['431137da454a68b758fb0b86a8a7e1fb3371337c'] | Implement most of remote terminal service
It works, at least, but there are still some missing parts. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1466,17 +1466,20 @@ index 0000000000000000000000000000000000000000..6ce56bec114a6d8daf5dd3ded945ea78\n +}\n diff --git a/src/vs/server/node/channel.ts b/src/vs/server/node/channel.ts\n new file mod... | TypeScript |
182aca649064bb54e8d00ac02e6667ee7702d0bb | 29 | 2020-11-19 15:51:31-06:00 | 21,600 | ['8311cf5657c7264c71373f1f15e0016da9336364'] | Only replay terminals when detached | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1466,10 +1466,10 @@ index 0000000000000000000000000000000000000000..6ce56bec114a6d8daf5dd3ded945ea78\n +}\n diff --git a/src/vs/server/node/channel.ts b/src/vs/server/node/channel.ts\n new file mod... | TypeScript |
1feb30a7ff18149f94ad171f42edc82a8844cfef | 29 | 2020-11-19 15:51:32-06:00 | 21,600 | ['182aca649064bb54e8d00ac02e6667ee7702d0bb'] | Send back workspace ID and name in terminal list
This makes it re-connect automatically. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1466,7 +1466,7 @@ index 0000000000000000000000000000000000000000..6ce56bec114a6d8daf5dd3ded945ea78\n +}\n diff --git a/src/vs/server/node/channel.ts b/src/vs/server/node/channel.ts\n new file mode ... | TypeScript |
a6f884000995b85cdbec3e857eae893fd59b67b5 | 29 | 2020-11-19 15:51:33-06:00 | 21,600 | ['1feb30a7ff18149f94ad171f42edc82a8844cfef'] | Add timeout for disposing detached terminals | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -1466,10 +1466,10 @@ index 0000000000000000000000000000000000000000..6ce56bec114a6d8daf5dd3ded945ea78\n +}\n diff --git a/src/vs/server/node/channel.ts b/src/vs/server/node/channel.ts\n new file mod... | TypeScript |
8ffe5997965e2be5c30ef5c8ecd9717fb286a61d | 29 | 2020-11-19 15:51:34-06:00 | 21,600 | ['a6f884000995b85cdbec3e857eae893fd59b67b5'] | Add notes on unimplemented terminal events | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1466,10 +1466,10 @@ index 0000000000000000000000000000000000000000..6ce56bec114a6d8daf5dd3ded945ea78\n +}\n diff --git a/src/vs/server/node/channel.ts b/src/vs/server/node/channel.ts\n new file mod... | TypeScript |
d0f6cbb02d73cc80ca42390c87bd6386b4390f00 | 29 | 2020-11-19 15:51:36-06:00 | 21,600 | ['fa59156a2aa30fc9d3e4332046a0dab749f6bc7e'] | Use resolverEnv to get exec path
This is the last unused variable in the create terminal payload. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1466,10 +1466,10 @@ index 0000000000000000000000000000000000000000..6ce56bec114a6d8daf5dd3ded945ea78\n +}\n diff --git a/src/vs/server/node/channel.ts b/src/vs/server/node/channel.ts\n new file mod... | TypeScript |
42390da0978b544679fdcd0be5c4573631d52c34 | 29 | 2020-11-19 15:51:37-06:00 | 21,600 | ['d0f6cbb02d73cc80ca42390c87bd6386b4390f00'] | Don't persist terminals for now | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -1466,10 +1466,10 @@ index 0000000000000000000000000000000000000000..6ce56bec114a6d8daf5dd3ded945ea78\n +}\n diff --git a/src/vs/server/node/channel.ts b/src/vs/server/node/channel.ts\n new file mod... | TypeScript |
2e2d03371f7eda4ab0647b839d7b818c86b3b6e7 | 55 | 2020-11-19 18:03:12-05:00 | 18,000 | ['23ead21b1d9c0d7f4896a400f24e2d31b2e52651'] | ci: Fix typo in release template | [{'old_path': 'ci/build/release-github-draft.sh', 'new_path': 'ci/build/release-github-draft.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,7 +15,7 @@ v$VERSION\n \n VS Code v$(vscode_version)\n \n-# New Features\n+## New Features\n - ⭐ Summarize new features here with references to issues\n \n ## Bug Fix... | TypeScript |
3d7fbec40f820ab6552bfa0d16c2d2efaf663b62 | 29 | 2020-11-20 14:03:07-06:00 | 21,600 | ['96170de191efff45c1c6ac0a40792465fc507296'] | Use file system for settings and fix data home path
It's possible that using browser storage makes more sense with settings
sync, so we might want to revisit this once/if we get settings sync
working. As it currently is though, browser storage just causes jank.
The path was also missing a `User` at the end so I added... | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3797,18 +3797,25 @@ index 85d83f37da179a1e39266cf72a02e971f590308e..0659738b36df1747c9afcabf8d9abf26\n \t\t};\n \n diff --git a/src/vs/workbench/services/environment/browser/environmentService.ts... | TypeScript |
fb835838db90e4a846dc11f1a0c214bc9c5d58b0 | 29 | 2020-11-20 15:35:18-06:00 | 21,600 | ['3d7fbec40f820ab6552bfa0d16c2d2efaf663b62'] | Remove semver-umd link
This is included in the bundle now. | [{'old_path': 'src/browser/pages/vscode.html', 'new_path': 'src/browser/pages/vscode.html', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -32,11 +32,6 @@\n <link rel="apple-touch-icon" href="{{CS_STATIC_BASE}}/src/browser/media/pwa-icon-384.png" />\n <meta name="apple-mobile-web-app-capable" content="yes" /... | TypeScript |
19710ab1442b914566e8825d2221d2658dd09413 | 55 | 2020-11-23 19:06:09-05:00 | 18,000 | ['96170de191efff45c1c6ac0a40792465fc507296'] | vscode: Update product.json
The new fields are from vscodium and make the welcome page
documentation links work correctly.
I also renamed the distribution to "code-server" so that when you're
in a browser, it now says code-server instead of Code OSS. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -264,9 +264,18 @@ index 28f8a69a2a91f9cb9f4dbd73ed3e689b2b3afe84..b5f5b10004d3e36092a30f685938a606\n }\n }\n diff --git a/product.json b/product.json\n-index 7cab6d1b9f3b84bfc703856e93773a293fd1... | TypeScript |
5a38ab95fe0a0da3858254667335df7c1d2db57a | 55 | 2020-11-23 21:16:14-05:00 | 18,000 | ['19710ab1442b914566e8825d2221d2658dd09413'] | vscode: Disable go home button
See https://github.com/cdr/code-server/issues/2328 | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -3712,6 +3712,20 @@ index 021af6e0f8983c492f9cdd048ba2dcae7640bc1d..814dd0ff2fa7737e07833d8092c8f489\n \n \t\tmodule = module.with({ path: ensureSuffix(module.path, '.js') });\n \t\tconst respons... | TypeScript |
303fe2bc4eeeeb62248fdfa909cc68ecc3724bf9 | 55 | 2020-11-23 21:16:14-05:00 | 18,000 | ['5a38ab95fe0a0da3858254667335df7c1d2db57a'] | vscode: Customize welcome page for code-server
- Title/subtitle are now code-server and VS Code version
- Added a list of code-server help links | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -3803,6 +3803,73 @@ index 74f6922e98b4bb6a7fb100f5aac015afe9fc171b..3243a97c2d378013d96ffbe87e9df6dd\n \n .scm-view .monaco-list .monaco-list-row .resource-group > .actions,\n .scm-view .monaco-l... | TypeScript |
fb63c0cd220d3f768e1d8d54741beff5657fc919 | 55 | 2020-11-24 12:13:21-05:00 | 18,000 | ['bb26d2edd3a28eac0ddb070bb176a8c7495de4a0'] | vscode: Show notification when upgrade is available
And link to the release notes. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -769,10 +769,10 @@ index 096b9e23493539c9937940a56e555d95bbae38d9..ef37e614004f550f7b64eacd362f6894\n \tremove(key: string, scope: StorageScope): void {\n diff --git a/src/vs/server/browser/client.... | TypeScript |
f74f1721e69a722ff0a90757ec89e64ed34b4711 | 55 | 2020-11-24 12:42:26-05:00 | 18,000 | ['fb63c0cd220d3f768e1d8d54741beff5657fc919'] | doc: Add note on upgrading into release notes and install.md
Closes #1652
Closes #2221 | [{'old_path': 'ci/build/release-github-draft.sh', 'new_path': 'ci/build/release-github-draft.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -15,6 +15,10 @@ v$VERSION\n \n VS Code v$(vscode_version)\n \n+Upgrading is as easy as installing the new version over the old one. code-server\n+maintains all user data in... | TypeScript |
37c80c9bbd4a01ce0dabbd010b3b73831af9d3db | 55 | 2020-11-24 12:48:22-05:00 | 18,000 | ['be37821ab9dbd88ab4d78805e6e6df228c2426e7'] | vscode: Add missing semicolons
See #2359 | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -769,7 +769,7 @@ index 096b9e23493539c9937940a56e555d95bbae38d9..ef37e614004f550f7b64eacd362f6894\n \tremove(key: string, scope: StorageScope): void {\n diff --git a/src/vs/server/browser/client.ts... | TypeScript |
def81245a425178578318f3ec80d301c4c30f6b9 | 55 | 2020-11-24 13:07:30-05:00 | 18,000 | ['37c80c9bbd4a01ce0dabbd010b3b73831af9d3db'] | vscode: Check updates with absolute path
In case the window location path changes. Not entirely sure if it can
but best to be on the safe side. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -769,10 +769,10 @@ index 096b9e23493539c9937940a56e555d95bbae38d9..ef37e614004f550f7b64eacd362f6894\n \tremove(key: string, scope: StorageScope): void {\n diff --git a/src/vs/server/browser/client.... | TypeScript |
ae65c83cbdb6851335c9a5f01d7629434f6b0972 | 29 | 2020-11-26 17:58:34-05:00 | 21,600 | ['eca444887719bae5bfe1f5a86b6817ce4abb24ab'] | Fix exthost error and warn logging (#2366)
Previously anything that wasn't "log" such as "warn" would end up doing
`logger[logger.warn]`. Would have caught this if I hadn't used `any`...
Fixes #2364. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -2445,10 +2445,10 @@ index 0000000000000000000000000000000000000000..693174ee0d21353c3a08a42fd30eaad1\n +}\n diff --git a/src/vs/server/node/connection.ts b/src/vs/server/node/connection.ts\n new fi... | TypeScript |
5247878d93bcc2815f1b0e6af2da5ac16303bbc5 | 55 | 2020-11-27 08:20:31-05:00 | 18,000 | ['ae65c83cbdb6851335c9a5f01d7629434f6b0972'] | ci: Enable vscode linting
Updates #2359 | [{'old_path': 'ci/dev/lint.sh', 'new_path': 'ci/dev/lint.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -11,6 +11,10 @@ main() {\n if command -v helm && helm kubeval --help > /dev/null; then\n helm kubeval ci/helm-chart\n fi\n+\n+ cd lib/vscode\n+ yarn eslint --max-warnings=0\n+ cd "$OLDPWD"\n }\n \n... | TypeScript |
833314aae8124bd6fc7db3e83f6e7e60a2ee6205 | 55 | 2020-11-27 08:21:44-05:00 | 18,000 | ['5247878d93bcc2815f1b0e6af2da5ac16303bbc5'] | vscode: Make eslint pass
I disabled code-layering and code-import-patterns as I don't think we
can make them easily pass as we reference all sorts of code from both
browser and node files. At least not worth the headache now to refactor
everything. | [{'old_path': 'ci/dev/lint.sh', 'new_path': 'ci/dev/lint.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -13,7 +13,8 @@ main() {\n fi\n \n cd lib/vscode\n- yarn eslint --max-warnings=0\n+ # Run this periodically in vanilla VS code to make sure we don\'t add any more warnings.\n+ yarn eslint --max-warnings... | TypeScript |
4cb8a32f4ca79d7a47be40131c7cddc3462933f4 | 55 | 2020-11-29 21:05:11-05:00 | 18,000 | ['833314aae8124bd6fc7db3e83f6e7e60a2ee6205'] | ci: Fetch vscode node_modules in lint.sh for eslint | [{'old_path': 'ci/steps/fmt.sh', 'new_path': 'ci/steps/fmt.sh', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -7,7 +7,7 @@ main() {\n yarn --frozen-lockfile\n \n git submodule update --init\n- # We do not `yarn vscode` to make test.sh faster.\n+ # We do not `yarn vscode` to make fmt.sh faster.\n # If the pa... | TypeScript |
67e2a99df2799b686a96f0c51f00ff89d68f555c | 84 | 2020-11-30 13:56:40-05:00 | 21,600 | ['0ad7d93ea68ea3c446936635462d11e68f2ba117'] | show popup on third attempt | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -746,6 +746,53 @@ index fdd5890c69f72025b94913380f0d226226e8c8fb..e084236526b38c1144d47b8b3000b367\n \t\t\t(err: any, socket: ISocket | undefined) => {\n \t\t\t\tif (err || !socket) {\n \t\t\t\t\... | TypeScript |
290c533c8ede1902705e6e672aee19539e2604fe | 84 | 2020-11-30 13:56:40-05:00 | 21,600 | ['67e2a99df2799b686a96f0c51f00ff89d68f555c'] | turn off visibleProgress on ConnectionLost | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -746,53 +746,15 @@ index fdd5890c69f72025b94913380f0d226226e8c8fb..e084236526b38c1144d47b8b3000b367\n \t\t\t(err: any, socket: ISocket | undefined) => {\n \t\t\t\tif (err || !socket) {\n \t\t\t\t... | TypeScript |
4eb43751196ed9e72e097674aefd5913a84f2fa1 | 84 | 2020-11-30 13:56:41-05:00 | 21,600 | ['290c533c8ede1902705e6e672aee19539e2604fe'] | one working solution without event suppression | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -746,15 +746,78 @@ index fdd5890c69f72025b94913380f0d226226e8c8fb..e084236526b38c1144d47b8b3000b367\n \t\t\t(err: any, socket: ISocket | undefined) => {\n \t\t\t\tif (err || !socket) {\n \t\t\t\t... | TypeScript |
a898dd34b9555b8f19e6b1bb20f01b90b1b99fb9 | 84 | 2020-11-30 13:56:41-05:00 | 21,600 | ['4eb43751196ed9e72e097674aefd5913a84f2fa1'] | solution with forceDialog for attempt 3 and no change to VisibleProgress class | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -746,7 +746,7 @@ index fdd5890c69f72025b94913380f0d226226e8c8fb..e084236526b38c1144d47b8b3000b367\n \t\t\t(err: any, socket: ISocket | undefined) => {\n \t\t\t\tif (err || !socket) {\n \t\t\t\t\t... | TypeScript |
e5067ba2a98cf19f567bafb5356cb7b5f78cf240 | 84 | 2020-11-30 13:56:41-05:00 | 21,600 | ['fa0853dca6d335c9643f13c1ffeb5251aba05a70'] | separate event domain from UI | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -746,12 +746,12 @@ index fdd5890c69f72025b94913380f0d226226e8c8fb..e084236526b38c1144d47b8b3000b367\n \t\t\t(err: any, socket: ISocket | undefined) => {\n \t\t\t\tif (err || !socket) {\n \t\t\t\t... | TypeScript |
8cb4e2c2268f49a39aa41874839c80d067ed8a2c | 55 | 2020-11-30 13:56:41-05:00 | 18,000 | ['e5067ba2a98cf19f567bafb5356cb7b5f78cf240'] | vscode: Remove background reconnection fixes from patch
I'll have to manually apply as they are not compatible with the latest
VS Code after rebase anymore. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -746,82 +746,6 @@ index fdd5890c69f72025b94913380f0d226226e8c8fb..e084236526b38c1144d47b8b3000b367\n \t\t\t(err: any, socket: ISocket | undefined) => {\n \t\t\t\tif (err || !socket) {\n \t\t\t\t\... | TypeScript |
c35d558352273f4b34b2bf7fa454dc2aeb92cbe3 | 55 | 2020-11-30 13:59:40-05:00 | 18,000 | ['8cb4e2c2268f49a39aa41874839c80d067ed8a2c'] | vscode: Reconnect in the background up to 5 seconds
Based on the previous commits by @mgmachado but simplified.
I also changed the threshold to error after a single attempt as the
connection has likely been borked and the user should be in the know if
they couldn't reconnect after 5 seconds.
Closes #1791 | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -734,7 +734,7 @@ index 3715cbb8e6ee41c3d9b5090918d243b723ae2d00..c65de8ad37e727d66da97a8f8b170cbc\n -\n -\n diff --git a/src/vs/platform/remote/common/remoteAgentConnection.ts b/src/vs/platform/remo... | TypeScript |
27f0f195a8d3c1bc66692e0cf69b752efda4ae84 | 55 | 2020-11-30 15:29:53-05:00 | 18,000 | ['7282ebf436c849963c6d1a42b6f1a6c6738f4a66'] | vscode: Use options.base for update checking
See https://github.com/cdr/code-server/pull/2358#discussion_r529858749 | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -813,7 +813,7 @@ new file mode 100644\n index 0000000000000000000000000000000000000000..ead6a3cd5e98fdde074f19ee5043f152ed407146\n --- /dev/null\n +++ b/src/vs/server/browser/client.ts\n-@@ -0,0 +1,... | TypeScript |
cc18175ce3bde6da56f507a4fb66e6a1e5524f00 | 55 | 2020-11-30 15:30:06-05:00 | 18,000 | ['27f0f195a8d3c1bc66692e0cf69b752efda4ae84'] | cli: Add --disable-update-check flag
Closes #2361 | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -813,7 +813,7 @@ new file mode 100644\n index 0000000000000000000000000000000000000000..ead6a3cd5e98fdde074f19ee5043f152ed407146\n --- /dev/null\n +++ b/src/vs/server/browser/client.ts\n-@@ -0,0 +1,... | TypeScript |
0713fa900bf6af47f60aa3eb0c15f76d1a930ef0 | 55 | 2020-11-30 15:30:19-05:00 | 18,000 | ['cc18175ce3bde6da56f507a4fb66e6a1e5524f00'] | vscode: Fix update check timeouts
Forgot an extra 60 in the check interval and the notification timeout.
Very unfortunate. Check has been allowed every 168 minutes instead of
every week. | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': "@@ -988,7 +988,7 @@ index 0000000000000000000000000000000000000000..ead6a3cd5e98fdde074f19ee5043f152\n +\t\tconst lastNoti = storageService.getNumber('csLastUpdateNotification', StorageScope.GLOBAL);\n... | TypeScript |
261af28f70aa217bc8c4993c07cccb01671840dc | 55 | 2020-11-30 15:39:57-05:00 | 18,000 | ['0713fa900bf6af47f60aa3eb0c15f76d1a930ef0'] | vscode: Fixes for linting | [{'old_path': 'ci/dev/vscode.patch', 'new_path': 'ci/dev/vscode.patch', 'type': <ModificationType.MODIFY: 5>, 'diff': '@@ -810,7 +810,7 @@ index 096b9e23493539c9937940a56e555d95bbae38d9..ef37e614004f550f7b64eacd362f6894\n \tremove(key: string, scope: StorageScope): void {\n diff --git a/src/vs/server/browser/client.ts... | TypeScript |