instance_id stringlengths 17 41 | org stringclasses 19
values | repo stringclasses 19
values | number int64 29 21.7k | state stringclasses 1
value | title stringlengths 9 118 | body stringlengths 10 5.5k | base unknown | resolved_issues unknown | lang stringclasses 4
values | problem_statement stringlengths 51 34.5k | hints stringlengths 1 65.8k ⌀ | pull_url stringlengths 40 64 | issue_urls unknown | test_command stringlengths 66 10.4k ⌀ | fix_patch stringlengths 365 784k | test_patch stringlengths 382 698k | n2p_tests unknown | f2p_tests unknown | p2p_tests unknown | s2p_tests unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
openhab__openhab-android-3021 | openhab | openhab-android | 3,021 | closed | Split PreferencesActivity.kt in smaller files | Fixes #3013
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com> | {
"label": "openhab:main",
"ref": "main",
"sha": "2b164c8b66bc0316a99181325ea9eaa9d36158a3"
} | [
{
"number": 3013,
"title": "Split PreferencesActivity.kt in smaller files",
"body": "The file has grown to big and should be split into multiple smaller files:\r\n* One \"main\" file\r\n* One file per fragment"
}
] | kotlin | Split PreferencesActivity.kt in smaller files
The file has grown to big and should be split into multiple smaller files:
* One "main" file
* One file per fragment
| null | https://github.com/openhab/openhab-android/pull/3021 | [
"https://github.com/openhab/openhab-android/issues/3013"
] | ./gradlew :mobile:testFossBetaDebugUnitTest --tests "org.openhab.habdroid.util.PreferencesUtilTest" | diff --git a/mobile/src/foss/java/org/openhab/habdroid/core/CloudMessagingHelper.kt b/mobile/src/foss/java/org/openhab/habdroid/core/CloudMessagingHelper.kt
index 6308260317..440b4d1f0d 100644
--- a/mobile/src/foss/java/org/openhab/habdroid/core/CloudMessagingHelper.kt
+++ b/mobile/src/foss/java/org/openhab/habdroid/co... | diff --git a/mobile/src/test/java/org/openhab/habdroid/util/PreferencesUtilTest.kt b/mobile/src/test/java/org/openhab/habdroid/util/PreferencesUtilTest.kt
index cb6039b35f..d23fcb4566 100644
--- a/mobile/src/test/java/org/openhab/habdroid/util/PreferencesUtilTest.kt
+++ b/mobile/src/test/java/org/openhab/habdroid/util/... | {
"org.openhab.habdroid.util.PreferencesUtilTest.testIsWeakPassword": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.util.PreferencesUtilTest.testBeautifyHostName": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.util.PreferencesUtilTest... | {} | {} | {} |
openhab__openhab-android-2959 | openhab | openhab-android | 2,959 | closed | Support command options | Fixes #2655
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com> | {
"label": "openhab:main",
"ref": "main",
"sha": "f3df754edb0f47dd31f27f9977d3676196d35e92"
} | [
{
"number": 2655,
"title": "Support of command options",
"body": "Items with command options are currently rendered as a simple switch (commands are so ignored).\r\n\r\nThese items, when associated to a Switch widget, should be rendered similar as items with state options, that is with one button for ea... | kotlin | Support of command options
Items with command options are currently rendered as a simple switch (commands are so ignored).
These items, when associated to a Switch widget, should be rendered similar as items with state options, that is with one button for each command/state.
PS: I was planning to replace few swit... | Is there a difference between "command options" and "item options" (as in #912)?
No real difference in UI perspective.
But for command options, you will not receive state updates because this is used with channels that have no state.
Can you post a rest api response of an item with command options? | https://github.com/openhab/openhab-android/pull/2959 | [
"https://github.com/openhab/openhab-android/issues/2655"
] | ./gradlew :mobile:testFossBetaDebugUnitTest --tests "org.openhab.habdroid.model.ItemTest" | diff --git a/mobile/src/main/java/org/openhab/habdroid/model/Item.kt b/mobile/src/main/java/org/openhab/habdroid/model/Item.kt
index c0cc987668..db58bb994d 100644
--- a/mobile/src/main/java/org/openhab/habdroid/model/Item.kt
+++ b/mobile/src/main/java/org/openhab/habdroid/model/Item.kt
@@ -290,11 +290,20 @@ fun JSONObj... | diff --git a/mobile/src/test/java/org/openhab/habdroid/model/ItemTest.kt b/mobile/src/test/java/org/openhab/habdroid/model/ItemTest.kt
index 61df39b2ec..fe73dd2c89 100644
--- a/mobile/src/test/java/org/openhab/habdroid/model/ItemTest.kt
+++ b/mobile/src/test/java/org/openhab/habdroid/model/ItemTest.kt
@@ -104,6 +104,13... | {
"org.openhab.habdroid.model.ItemTest.testHashCode": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.ItemTest.testEquals": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.ItemTest.getStateAsBoolean_stateON_returnTrue": {
... | {
"org.openhab.habdroid.model.ItemTest.isReadOnly": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.openhab.habdroid.model.ItemTest.getStateAsBoolean_statePositiveInteger_returnTrue": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.ItemTest.getMembers": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.ItemTest.testNoLa... | {} |
openhab__openhab-android-2925 | openhab | openhab-android | 2,925 | closed | Make subtitle in device controls configurable | Fixes #2904
Use the semantic model for getting the location: https://github.com/openhab/openhab-core/issues/2977#issuecomment-1134772074 | {
"label": "openhab:main",
"ref": "main",
"sha": "1baee50328207731213ada3297407d9cfefd04f3"
} | [
{
"number": 2904,
"title": "Android Device Controls: subtitle",
"body": "### Is your feature request related to a problem? Please describe.\r\nAndroid Device Controls, subtitles missing. Opportunity to display useful Information like \"item.name\" missed.\r\n\r\n### Describe the solution you'd like\r\nU... | kotlin | Android Device Controls: subtitle
### Is your feature request related to a problem? Please describe.
Android Device Controls, subtitles missing. Opportunity to display useful Information like "item.name" missed.
### Describe the solution you'd like
Use` .setSubtitle() `to add additional Information like location o... | There aren't many properties that are connected to Items: https://github.com/openhab/openhab-android/blob/main/mobile/src/main/java/org/openhab/habdroid/model/Item.kt#L30-L43
IMO the item name is too technical to be displayed here.
Maybe display the item state, e.g. for temperature?
Temperature and other item sta... | https://github.com/openhab/openhab-android/pull/2925 | [
"https://github.com/openhab/openhab-android/issues/2904"
] | ./gradlew :mobile:testFossBetaDebugUnitTest --tests "org.openhab.habdroid.model.ItemTest" | diff --git a/docs/USAGE.md b/docs/USAGE.md
index 65abf3cba2..a9d745735e 100644
--- a/docs/USAGE.md
+++ b/docs/USAGE.md
@@ -55,6 +55,7 @@ There are a number of strategies available to provide [secure remote access]({{b
* [Send device information to openHAB](#send-device-information-to-openhab), like next alarm clock ti... | diff --git a/mobile/src/test/java/org/openhab/habdroid/model/ItemTest.kt b/mobile/src/test/java/org/openhab/habdroid/model/ItemTest.kt
index d4cff1b4e8..61df39b2ec 100644
--- a/mobile/src/test/java/org/openhab/habdroid/model/ItemTest.kt
+++ b/mobile/src/test/java/org/openhab/habdroid/model/ItemTest.kt
@@ -153,6 +153,16... | {
"org.openhab.habdroid.model.ItemTest.getStateAsBoolean_statePositiveInteger_returnTrue": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.ItemTest.testHashCode": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.ItemTest.testEq... | {} | {} | {} |
streetcomplete__StreetComplete-6152 | streetcomplete | StreetComplete | 6,152 | closed | handle HTTP 413 response from OSM API | fixes #6151
Need to add tests (but not tonight). Is the code itself comprehensible, @Helium314 , @FloEdelmann , @matkoniecz ? | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "2cf9833b8440b009c6060660a51a659055909c1c"
} | [
{
"number": 6151,
"title": "Upload error on too large bounding box",
"body": "I am getting some crash reports.\n\n```\nde.westnordost.streetcomplete.data[https://de.westnordost.streetcomplete.data/].ApiClientException: Client request(POST https://api.openstreetmap.org/api/0.6/changeset/163137077/upload)... | kotlin | Upload error on too large bounding box
I am getting some crash reports.
```
de.westnordost.streetcomplete.data[https://de.westnordost.streetcomplete.data/].ApiClientException: Client request(POST https://api.openstreetmap.org/api/0.6/changeset/163137077/upload) invalid: 413 Payload Too Large. Text: "Changeset bounding... | null | https://github.com/streetcomplete/StreetComplete/pull/6152 | [
"https://github.com/streetcomplete/StreetComplete/issues/6151"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.data.osm.edits.upload.ElementEditUploaderTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/upload/ElementEditUploader.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/upload/ElementEditUploader.kt
index 184e6118c18..5d0644a5386 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/upload/Eleme... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/upload/ElementEditUploaderTest.kt b/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/upload/ElementEditUploaderTest.kt
index a41ed651588..6d904c1f40c 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/uplo... | {
"de.westnordost.streetcomplete.data.osm.edits.upload.ElementEditUploaderTest.passes on conflict exception": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.edits.upload.ElementEditUploaderTest.create new changeset when changeset is too large": {
"run": "... | {} | {} | {} |
streetcomplete__StreetComplete-6075 | streetcomplete | StreetComplete | 6,075 | closed | OsmNoteQuestController: surveyme override and regex test update | Resolves #6052.
* Restructured exclusion of notes that get overridden by #surveyme
* Added RegexOption.DOT_MATCHES_ALL to function NoteComment.containsSurveyRequiredMarker: #surveyme wasn't found at the end of the text added by the user, because SC add "\n\nvia StreetComplete <x.y>" to the text | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "a046481ee83efb460810edf63271ea11e01190ea"
} | [
{
"number": 6052,
"title": "#surveyme in last Note comment should show the Note (even if there are no preceding comments)",
"body": "Back in https://github.com/streetcomplete/StreetComplete/issues/2641 (via https://github.com/streetcomplete/StreetComplete/commit/b3ad39b2130dabdf0db2132dabeb3eaaa2ad48c4)... | kotlin | #surveyme in last Note comment should show the Note (even if there are no preceding comments)
Back in https://github.com/streetcomplete/StreetComplete/issues/2641 (via https://github.com/streetcomplete/StreetComplete/commit/b3ad39b2130dabdf0db2132dabeb3eaaa2ad48c4), it was made that `#surveyme` tag in the last comment ... | This behaviour is coordinated by
https://github.com/streetcomplete/StreetComplete/blob/45a51eb3260babab935c1a56e7e23c4679be581a/app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt#L191-L223
more specifically
https://github.com/streetcomplete/StreetComplete/blob/45... | https://github.com/streetcomplete/StreetComplete/pull/6075 | [
"https://github.com/streetcomplete/StreetComplete/issues/6052"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.data.osmnotes.notequests.OsmNoteQuestControllerTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestController.kt
index ad4fadbd8c7..4894f5b6b80 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/data/osmnotes/n... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestControllerTest.kt b/app/src/test/java/de/westnordost/streetcomplete/data/osmnotes/notequests/OsmNoteQuestControllerTest.kt
index 5b347b3a33a..9200a73b9d3 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/data/os... | {
"de.westnordost.streetcomplete.data.osmnotes.notequests.OsmNoteQuestControllerTest.calls onInvalidated when cleared notes": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osmnotes.notequests.OsmNoteQuestControllerTest.get quest not phrased as question returns n... | {
"de.westnordost.streetcomplete.data.osmnotes.notequests.OsmNoteQuestControllerTest.unhide": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osmnotes.notequests.OsmNoteQuestControllerTest.get note quest with comment from user that contains a survey required marke... | {
"de.westnordost.streetcomplete.data.osmnotes.notequests.OsmNoteQuestControllerTest.getAllHiddenNewerThan": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osmnotes.notequests.OsmNoteQuestControllerTest.get hidden returns null": {
"run": "PASS",
"test": "... | {} |
streetcomplete__StreetComplete-5976 | streetcomplete | StreetComplete | 5,976 | closed | prohibited for pedestrians: clear sidewalk tags when user answers that there is a sidewalk | …t there is a sidewalk (fixes #5952) | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "bc404b2c8f927a261be826e858725b0119c1c88c"
} | [
{
"number": 5952,
"title": "\"Actually, there is a sidewalk, but it is displayed separately on the map.\" - applied answer may be wrong, sidewalk may be only on one side",
"body": "`quest_accessible_for_pedestrians_separate_sidewalk` has\r\n\r\n> Actually, there is a sidewalk, but it is displayed separa... | kotlin | "Actually, there is a sidewalk, but it is displayed separately on the map." - applied answer may be wrong, sidewalk may be only on one side
`quest_accessible_for_pedestrians_separate_sidewalk` has
> Actually, there is a sidewalk, but it is displayed separately on the map.
wording.
If selected https://github.co... | `sidewalk=separate` is invalid tagging, as far as I know.
But yeah, the `sidewalk` tag could just be removed. The wording of the other answer would then also need to be changed to "Actually, there is a sidewalk". However, note that the sidewalk quest is disabled by default.
> sidewalk=separate is invalid tagging, as... | https://github.com/streetcomplete/StreetComplete/pull/5976 | [
"https://github.com/streetcomplete/StreetComplete/issues/5952"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.quests.foot.AddProhibitedForPedestriansTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/quests/foot/AddProhibitedForPedestrians.kt b/app/src/main/java/de/westnordost/streetcomplete/quests/foot/AddProhibitedForPedestrians.kt
index 67799039e50..dae80bb78ff 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/quests/foot/AddProhibitedForPed... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/quests/foot/AddProhibitedForPedestriansTest.kt b/app/src/test/java/de/westnordost/streetcomplete/quests/foot/AddProhibitedForPedestriansTest.kt
index 4766d2bafeb..60f357b2f41 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/quests/foot/AddProhibit... | {
"de.westnordost.streetcomplete.quests.foot.AddProhibitedForPedestriansTest.apply yes answer": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.quests.foot.AddProhibitedForPedestriansTest.apply actually sidewalk answer clears all sidewalk tagging": {
"run": "NONE",... | {} | {} | {} |
streetcomplete__StreetComplete-5931 | streetcomplete | StreetComplete | 5,931 | closed | Add "sign allows cycling on sidewalk, both directions" option to cycleway quest/overlay | Adds the option "None, but sign allows cycling on sidewalk, both directions" to the available road-side cycleway options.
Fixes #5888 | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "b48bb093c2ac255f8a52df494dea1663105b8d9e"
} | [
{
"number": 5888,
"title": "Cycling on sidewalk (in both directions) answer is missing",
"body": "Thanks for adding back the differentiation of cycling on the sidewalk being allowed vs. a shared use sidewalk. (not sure when that happend, but it was missing a while) \r\n\r\nHowever there's an option miss... | kotlin | Cycling on sidewalk (in both directions) answer is missing
Thanks for adding back the differentiation of cycling on the sidewalk being allowed vs. a shared use sidewalk. (not sure when that happend, but it was missing a while)
However there's an option missing:
Cycling on the sidewalk is allowed in both directio... | "Btw: Wouldn't shared use sidewalk not be less confusing here?"
No. Sidewalk is a term specifically referring to a path next to a road. There are plenty of unsegregated cycle tracks that do not follow the route of a road and are thus not "sidewalk" in any sense of the meaning of the word.
> "Btw: Wouldn't shared use... | https://github.com/streetcomplete/StreetComplete/pull/5931 | [
"https://github.com/streetcomplete/StreetComplete/issues/5888"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest" --tests "de.westnordost.streetcomplete.osm.cycleway.CyclewayParserKtTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/Cycleway.kt b/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/Cycleway.kt
index 44b6cd2c1af..a56eaba6727 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/Cycleway.kt
+++ b/app/src/main/java/de/westnordost/str... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreatorKtTest.kt b/app/src/test/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreatorKtTest.kt
index 76e0f0523f5..afed76e8a26 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreatorKtTest.kt
+++... | {
"de.westnordost.streetcomplete.osm.cycleway.CyclewayParserKtTest.busway on right side": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.osm.cycleway.CyclewayParserKtTest.unspecified shared lane on left side": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"... | {
"de.westnordost.streetcomplete.osm.cycleway.CyclewayParserKtTest.lane on right side opposite": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest.apply suggestion lane answer": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"... | {
"de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest.apply separate cycleway answer": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"de.westnordost.streetcomplete.osm.cycleway.CyclewayParserKtTest.busway on both side opposite": {
"run": "PASS",
"test": "PASS",
"fix": "PA... | {} |
streetcomplete__StreetComplete-5818 | streetcomplete | StreetComplete | 5,818 | closed | callOnUpdated if an updated element does not have a local edit | Fixes #5745 as in the latest comments.
(the new test fails without the changes to `MapDataWithEditsSource`) | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "2e213a6def3e5a09a32241ffdf6609c0e87d3125"
} | [
{
"number": 5745,
"title": "Element is not updated after conflict on upload",
"body": "In building mode: after the building has been selected, it does not change color. You have to make the entry again so that the building is displayed as an apartment building, for example. \r\n\r\n**How to Reproduce**\... | kotlin | Element is not updated after conflict on upload
In building mode: after the building has been selected, it does not change color. You have to make the entry again so that the building is displayed as an apartment building, for example.
**How to Reproduce**
Go into the building mode, select a building and change t... | I can't reproduce this problem with version 58.2. Can you record a screen video?
Yes, of course.
https://github.com/user-attachments/assets/539079f2-46d6-4a2c-a093-144cfa2c84db
Thanks! This might be another instance of #5545. Can you try to reproduce it another time and then immediately after go to Menu -> About ... | https://github.com/streetcomplete/StreetComplete/pull/5818 | [
"https://github.com/streetcomplete/StreetComplete/issues/5745"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSource.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSource.kt
index 8b1a2c5c064..4d003048b92 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSour... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSourceTest.kt b/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSourceTest.kt
index 422a3577c76..11cc5e7e7d8 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithE... | {
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getMapDataWithGeometry returns nothing because element was deleted": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getRelationsForElement returns an u... | {
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.does not call onUpdated when all updated elements stayed the same": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getWayComplete returns null because a node of the way was deleted": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getRelationComplete returns incomple... | {} |
streetcomplete__StreetComplete-5686 | streetcomplete | StreetComplete | 5,686 | closed | Multiplatform OSM API client | Resolves #5410
---
Also took the opportunity to make the implementations and naming for all the clients that use the multiplatform Ktor-Client for Http (which is everything now) consistent.
---
I did a bit of performance testing. Unfortunately, the results are **very** unsatisfying.
### Downloading city... | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "8d488a0eb5b4410682b3713e9986391abd6f0e4f"
} | [
{
"number": 5410,
"title": "Multiplatform OSM API client",
"body": "Requires #5408 to be done first.\r\n\r\nThe [OSM API](https://wiki.openstreetmap.org/wiki/API_v0.6) is a HTTP REST API that communicates chiefly in XML. This must be ported to Kotlin multiplatform. \r\n\r\nCurrently, the Java library [`... | kotlin | Multiplatform OSM API client
Requires #5408 to be done first.
The [OSM API](https://wiki.openstreetmap.org/wiki/API_v0.6) is a HTTP REST API that communicates chiefly in XML. This must be ported to Kotlin multiplatform.
Currently, the Java library [`de.westnordost.osmapi`](https://github.com/westnordost/osmapi) ... | I would like to pick this up. I will ping back after some basic implementation.
This is blocked by #5408, i.e. that should be done first.
Because, the thinking is the following:
1. Both the access to the OSM API and the other APIs we are accessing should be done with the same library in order to both reduce the num... | https://github.com/streetcomplete/StreetComplete/pull/5686 | [
"https://github.com/streetcomplete/StreetComplete/issues/5410",
"https://github.com/streetcomplete/StreetComplete/issues/5667",
"https://github.com/streetcomplete/StreetComplete/issues/5548"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.data.user.UserApiParserTest" --tests "de.westnordost.streetcomplete.data.user.statistics.StatisticsApiClientTest" --tests "de.westnordost.streetcomplete.data.osmnotes.edits.NoteEditsUploaderTest" --tests "de.westnordost.streetcomplete.data.osm.edit... | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index ec8ffcc7a89..d4e0f21ea61 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -102,14 +102,6 @@ repositories {
mavenCentral()
}
-configurations {
- all {
- // it's already included in Android
- exclude(group = "net.sf.kxm... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/upload/ElementEditUploaderTest.kt b/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/upload/ElementEditUploaderTest.kt
index 1afbc4b55c8..c557f377339 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/uplo... | {
"de.westnordost.streetcomplete.data.user.UserApiParserTest.parse minimum user info": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.edits.upload.MapDataUpdatesTest.deletes node id and updates all ways containing this id": {
"run": "NONE",
"test": "N... | {} | {} | {} |
streetcomplete__StreetComplete-5463 | streetcomplete | StreetComplete | 5,463 | closed | New Opening Hours Parser | Fixes #5411
Additionally, made it so that opening hours which contain rules that overwrite each other but are otherwise supported are not excluded from re-survey, e.g. `Mo-Fr 08:00-12:00; Tu,Th 14:00-16:00` is likely a tagging mistake. | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "6f2168ac991d4f0bc8d2047929d7082c67b4dcb2"
} | [
{
"number": 5411,
"title": "Multiplatform opening hours parser library",
"body": "For the opening hours quest and the postbox collection times quest, the app needs to parse the OSM opening hours syntax. \r\n\r\nCurrently, the app uses the Java library [`ch.poole.OpeningHoursParser`](https://github.com/s... | kotlin | Multiplatform opening hours parser library
For the opening hours quest and the postbox collection times quest, the app needs to parse the OSM opening hours syntax.
Currently, the app uses the Java library [`ch.poole.OpeningHoursParser`](https://github.com/simonpoole/OpeningHoursParser). Internally, this parser is n... | I am going to reserve this one for myself
Or try to run https://github.com/opening-hours/opening_hours.js
Status update, I advanced quite a bit, but I poured too much time into that, so I'll continue with it later. Preliminary results:
- average parsing time of an opening hours string is more than 10x as fast as the... | https://github.com/streetcomplete/StreetComplete/pull/5463 | [
"https://github.com/streetcomplete/StreetComplete/issues/5411"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.quests.opening_hours.AddOpeningHoursTest" --tests "de.westnordost.streetcomplete.osm.opening_hours.parser.OpeningHoursParserAndGeneratorTest" --tests "de.westnordost.streetcomplete.quests.parking_fee.FeeTest" --tests "de.westnordost.streetcomplete.... | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 4b591db5f74..f6bec0fec69 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -182,7 +182,7 @@ dependencies {
implementation("com.mapzen.tangram:tangram:0.17.1")
// opening hours parser
- implementation("ch.poole:OpeningHoursParser... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/OpeningHoursParsingTest.kt b/app/src/test/java/de/westnordost/streetcomplete/OpeningHoursParsingTest.kt
index b55352aabd0..75b5e3aeaa1 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/OpeningHoursParsingTest.kt
+++ b/app/src/test/java/de/westnordo... | {
"de.westnordost.streetcomplete.quests.postbox_collection_times.AddPostboxCollectionTimesTest.apply no signed times answer": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.quests.opening_hours.AddOpeningHoursTest.apply opening hours answer when there was a different ... | {} | {} | {} |
streetcomplete__StreetComplete-5461 | streetcomplete | StreetComplete | 5,461 | closed | Buildings overlay | https://github.com/streetcomplete/StreetComplete/assets/4661658/95a9fd9f-f70f-42c4-970a-e811c1d926f4
### Building type overlay features:
- buildings are roughly categorized according to function and get their highlight color from there. Additionally, when zooming in, the icon of each building type is displayed.
... | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "0251165118407dcce598b7405580688868e7f043"
} | [
{
"number": 4741,
"title": "Add 'previous choice' option to Street lit overlay",
"body": "**Use case**\r\nCurrently if you're doing a bunch of the \"is this street lit?\" Entries; it is requiring more clicks than I feel like it should be doing\r\n\r\n**Proposed Solution**\r\nI think similar to the quest... | kotlin | Add 'previous choice' option to Street lit overlay
**Use case**
Currently if you're doing a bunch of the "is this street lit?" Entries; it is requiring more clicks than I feel like it should be doing
**Proposed Solution**
I think similar to the quest where you have to select every Street has a cycle way; there sho... | Huh? But the answer can only be yes or no. How would a "last answer" button help? The "yes" and "no" answers are already displayed!
Sorry, I'm referring to this quest
#... | https://github.com/streetcomplete/StreetComplete/pull/5461 | [
"https://github.com/streetcomplete/StreetComplete/issues/4741"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.quests.building_type.AddBuildingTypeTest" --tests "de.westnordost.streetcomplete.osm.building.BuildingTypeParserKtTest" --tests "de.westnordost.streetcomplete.osm.building.BuildingTypeCreatorKtTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/user/achievements/AchievementsModule.kt b/app/src/main/java/de/westnordost/streetcomplete/data/user/achievements/AchievementsModule.kt
index d21aad479f9..5cf5cca484d 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/data/user/achievements/Achi... | diff --git a/app/src/androidTest/res/drawable/ic_building_tower.xml b/app/src/androidTest/res/drawable/ic_building_tower.xml
new file mode 100644
index 00000000000..1128017500a
--- /dev/null
+++ b/app/src/androidTest/res/drawable/ic_building_tower.xml
@@ -0,0 +1,55 @@
+<vector xmlns:android="http://schemas.android.com/... | {
"de.westnordost.streetcomplete.osm.building.BuildingTypeParserKtTest.parse buildings": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.osm.building.BuildingTypeParserKtTest.parse houses with alternative tagging scheme": {
"run": "NONE",
"test": "NONE",
"f... | {} | {} | {} |
streetcomplete__StreetComplete-5273 | streetcomplete | StreetComplete | 5,273 | closed | Simplify feature dictionary handling | Resolves #5219. | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "34e000b1a1ce7b0cbb71fe58653369072307d14e"
} | [
{
"number": 5219,
"title": "Simplify `featureDictionaryFuture` interface in quests",
"body": "Currently, quests that want to use the feature dictionary, accept a `FutureTask<FeatureDictionary>`, e.g.\r\n\r\nhttps://github.com/streetcomplete/StreetComplete/blob/80781a7f45cddf19223c46ed5ff1a35e3964bb0e/ap... | kotlin | Simplify `featureDictionaryFuture` interface in quests
Currently, quests that want to use the feature dictionary, accept a `FutureTask<FeatureDictionary>`, e.g.
https://github.com/streetcomplete/StreetComplete/blob/80781a7f45cddf19223c46ed5ff1a35e3964bb0e/app/src/main/java/de/westnordost/streetcomplete/quests/Quests... | @FloEdelmann there are lots of small things that could be slightly improved. It doesn't make sense to open issue tickets for all of those. A PR is welcome anyway.
Regarding the feature dictionary, it's worth looking what other uses of the feature dictionary there are and whether it makes sense to simplify these, too.
... | https://github.com/streetcomplete/StreetComplete/pull/5273 | [
"https://github.com/streetcomplete/StreetComplete/issues/5219"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.quests.shop_type.CheckShopExistenceTest" --tests "de.westnordost.streetcomplete.quests.existence.CheckExistenceTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/overlays/OverlaysModule.kt b/app/src/main/java/de/westnordost/streetcomplete/overlays/OverlaysModule.kt
index 036074509ab..08f4229dab9 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/overlays/OverlaysModule.kt
+++ b/app/src/main/java/de/westnordo... | diff --git a/app/src/androidTest/java/de/westnordost/streetcomplete/quests/existence/CheckExistenceLabelTest.kt b/app/src/androidTest/java/de/westnordost/streetcomplete/util/NameAndLocationLabelTest.kt
similarity index 83%
rename from app/src/androidTest/java/de/westnordost/streetcomplete/quests/existence/CheckExistenc... | {
"de.westnordost.streetcomplete.quests.existence.CheckExistenceTest.apply answer removes all previous survey keys": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.quests.existence.CheckExistenceTest.isApplicableTo returns true for known places with old amenity=teleph... | {} | {} | {} |
streetcomplete__StreetComplete-5060 | streetcomplete | StreetComplete | 5,060 | closed | remove geometry filtering from sidewalk and cycleway quest | fixes #5000 | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "7dbfc8867e03b06bc361777a4b4ea53322b6fd5d"
} | [
{
"number": 5000,
"title": "Reduce filtering of ways for sidewalk quest",
"body": "As mentioned in #4915, there are quite a few cases where the sidewalk quest is not asked for ways for which I would expect it to be asked, because of too strict filtering. I understood that there is a filter that ensures ... | kotlin | Reduce filtering of ways for sidewalk quest
As mentioned in #4915, there are quite a few cases where the sidewalk quest is not asked for ways for which I would expect it to be asked, because of too strict filtering. I understood that there is a filter that ensures that the sidewalk quest is not asked for ways that are ... | > Examples mentioned include way https://www.openstreetmap.org/way/862062530 that is not quested because of https://www.openstreetmap.org/way/1056791202 that is of insignificant length
What if this short way had actually `footway=crossing` tagged? I guess it could be ignored if it had that tagged.
Anyway, since a... | https://github.com/streetcomplete/StreetComplete/pull/5060 | [
"https://github.com/streetcomplete/StreetComplete/issues/5000"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.quests.cycleway.AddCyclewayTest" --tests "de.westnordost.streetcomplete.quests.sidewalk.AddSidewalkTest" --tests "de.westnordost.streetcomplete.util.math.ElementGeometryMathKtTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt b/app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt
index a9bbe1f7173..9e0b4b2b4aa 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt
+++ b/app/src/main/java/... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/quests/cycleway/AddCyclewayTest.kt b/app/src/test/java/de/westnordost/streetcomplete/quests/cycleway/AddCyclewayTest.kt
index 40b8f7f54f1..23550214349 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/quests/cycleway/AddCyclewayTest.kt
+++ b/app/sr... | {
"de.westnordost.streetcomplete.quests.cycleway.AddCyclewayTest.not applicable to non-road": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.quests.sidewalk.AddSidewalkTest.not applicable to motorways": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
... | {} | {} | {} |
streetcomplete__StreetComplete-4988 | streetcomplete | StreetComplete | 4,988 | closed | always return complete ways on getMapDataWithGeometry | fixes #4980
`MapDataCache` can now fetch nodes if for some reason it's neither in `SpatialCache` nor in `nodeCache`. This can be because of trim (simply clears `nodeCache`), but also for other reasons, e.g. `SpatialCache` removing tiles unexpectedly (see #4985).
Performance:
* `getMatDataWithGeometry` is slower
... | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "fed28e43c5a70d8daa55b78cfbf58cb00603ccb3"
} | [
{
"number": 4980,
"title": "`MapDataController::getMapDataWithGeometry` returns incomplete Ways",
"body": "I think as part of @Helium314 's extensive caching PR or even a bit earlier than than, we made bounding box queries to local map data mimic the behavior of the OpenStreetMap API:\r\n\r\n1. get all ... | kotlin | `MapDataController::getMapDataWithGeometry` returns incomplete Ways
I think as part of @Helium314 's extensive caching PR or even a bit earlier than than, we made bounding box queries to local map data mimic the behavior of the OpenStreetMap API:
1. get all nodes in bounding box
2. get all ways that use any of thes... | Adjusting the cache would most likely need some more work... sure, I would do it.
Currently nodes are only stored in `SpatialCache`, but this won't be feasible if we also want to cache nodes that basically might be anywhere.
My idea is adding some cache (like `wayCache` and `relationCache` for those extra nodes, bu... | https://github.com/streetcomplete/StreetComplete/pull/4988 | [
"https://github.com/streetcomplete/StreetComplete/issues/4980"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.data.osm.mapdata.ElementDaoTest" --tests "de.westnordost.streetcomplete.data.osm.mapdata.MapDataCacheTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/ElementDao.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/ElementDao.kt
index 3fdf0421c08..4e2efdc7399 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/data/osm/mapdata/ElementDao.kt
+++ b/app/src/main/java/... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/data/osm/mapdata/ElementDaoTest.kt b/app/src/test/java/de/westnordost/streetcomplete/data/osm/mapdata/ElementDaoTest.kt
index 4b4ca12c546..fa017a0db85 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/data/osm/mapdata/ElementDaoTest.kt
+++ b/app/sr... | {
"de.westnordost.streetcomplete.data.osm.mapdata.ElementDaoTest.getAllElementsByBbox includes nodes that are not in bbox, but part of ways contained in bbox": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.mapdata.MapDataCacheTest.getRelationsForNode and Way... | {} | {} | {} |
streetcomplete__StreetComplete-4798 | streetcomplete | StreetComplete | 4,798 | closed | Fix #4790 | @Helium314 are you interested in reviewing this? | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "80166c41afc79e35f2335e324dcb39aa113fafcc"
} | [
{
"number": 4790,
"title": "Cycleway quest applies wrong tags",
"body": "Likely this is related to #4774, but this happens in in 51.0 beta1 (from GitHub)\r\n\r\n* Open the cycleway quest for https://www.openstreetmap.org/way/43943837 (`cycleway=lane`)\r\n* see current situation tagged as \"???\" (which ... | kotlin | Cycleway quest applies wrong tags
Likely this is related to #4774, but this happens in in 51.0 beta1 (from GitHub)
* Open the cycleway quest for https://www.openstreetmap.org/way/43943837 (`cycleway=lane`)
* see current situation tagged as "???" (which is expected)
* either: set the available side to "none"
* s... | Uh, this one is a bugger.
`cycleway=lane` on a `oneway=yes` is interpreted to mean
`cycleway:right=lane`
`cycleway:left` not set (`null`)
So, as the left side is `null`, the left side is also not shown in the UI.
However, as only the right side is **changed** by the user, only `cycleway:right=lane` + `cycl... | https://github.com/streetcomplete/StreetComplete/pull/4798 | [
"https://github.com/streetcomplete/StreetComplete/issues/4790"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreator.kt b/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreator.kt
index dbee23c4259..de54fe90137 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreator.kt
+++ b/app/src/main/ja... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreatorKtTest.kt b/app/src/test/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreatorKtTest.kt
index bf195940931..568eecd1d27 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayCreatorKtTest.kt
+++... | {
"de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest.remove oneway bicycle no tag if road is also a oneway for bicycles now": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest.apply advisory lane answer": {
"run": "PA... | {
"de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest.apply cycleway with non-standard direction adds cycleway direction": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest.apply separate cycleway answer": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"de.westnordost.streetcomplete.osm.cycleway.CyclewayCreatorKtTest.apply nothing": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"de... | {} |
streetcomplete__StreetComplete-4768 | streetcomplete | StreetComplete | 4,768 | closed | Support new parking schema (and add staggered parking) | Fixes #4664
Support new parking tagging schema:
- understand the tags from the new `parking:<side>` schema
- still understand old tags from `parking:lane` schema. If both old and new are tagged, new tags take precedence
- when (re)tagging, always tag according to the new schema and clear any tags of the old schem... | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "28201b16b9cfa6c46b2922fa94e0d60e8c65e32d"
} | [
{
"number": 4664,
"title": "Support new street parking tagging scheme",
"body": "The proposal for a [new street parking schema](https://wiki.openstreetmap.org/wiki/Proposed_features/street_parking_revision) will very likely be approved.\r\n\r\nPart of the proposal is to deprecate the old schema. Hence, ... | kotlin | Support new street parking tagging scheme
The proposal for a [new street parking schema](https://wiki.openstreetmap.org/wiki/Proposed_features/street_parking_revision) will very likely be approved.
Part of the proposal is to deprecate the old schema. Hence, in order to not use deprecated tags, the app must use the n... | I just posted the main reasons in #4562 that prevent a / prevents us from a mechanical edit. However, if someone feels challenged to support us in this, we would of course be very happy.
Hopefully, the numbers of the old tagging decrease significantly in near future and may be erased completely after some time (but ... | https://github.com/streetcomplete/StreetComplete/pull/4768 | [
"https://github.com/streetcomplete/StreetComplete/issues/4664"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.osm.street_parking.StreetParkingParserKtTest" --tests "de.westnordost.streetcomplete.osm.street_parking.StreetParkingCreatorKtTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayItem.kt b/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayItem.kt
index 21d189e8c8a..cdf179e8927 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/osm/cycleway/CyclewayItem.kt
+++ b/app/src/main/java/de/wes... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/osm/street_parking/StreetParkingCreatorKtTest.kt b/app/src/test/java/de/westnordost/streetcomplete/osm/street_parking/StreetParkingCreatorKtTest.kt
index 2b282b4b730..d0e1461dc93 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/osm/street_parking/... | {
"de.westnordost.streetcomplete.osm.street_parking.StreetParkingCreatorKtTest.apply parking": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.osm.street_parking.StreetParkingParserKtTest.marked is interpreted as incomplete with old schema": {
"run": "NONE",
"t... | {} | {} | {} |
streetcomplete__StreetComplete-4569 | streetcomplete | StreetComplete | 4,569 | closed | enable display of weekly stats | fixes #2946 | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "8ee2da533ff2633e4f2b2aac36474522cd958d00"
} | [
{
"number": 2946,
"title": "Weekly Scores and Ranks",
"body": "I've played SC with a friend and she was quite disappointed that she can't \"beat\" me, cause I had a headstart of month. \r\n\r\nI was wondering if the game and competition factor wouldn't work better if we had weekly stats instead of epoch... | kotlin | Weekly Scores and Ranks
I've played SC with a friend and she was quite disappointed that she can't "beat" me, cause I had a headstart of month.
I was wondering if the game and competition factor wouldn't work better if we had weekly stats instead of epoch ones.
We currently have a lot of empty real estate on th... | If I'm correct, this might also require modifications to the [web server statistics](https://github.com/streetcomplete/sc-statistics-service), as well as the main app. Anyway, it seems a reasonable idea. I wonder what other statistics one might include.
We could in theory query the OSM profile and get the OSM friends... | https://github.com/streetcomplete/StreetComplete/pull/4569 | [
"https://github.com/streetcomplete/StreetComplete/issues/2946"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.data.user.statistics.StatisticsParserTest" --tests "de.westnordost.streetcomplete.data.user.statistics.StatisticsControllerTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/Prefs.kt b/app/src/main/java/de/westnordost/streetcomplete/Prefs.kt
index f3769f6a9e3..5c2d67930ac 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/Prefs.kt
+++ b/app/src/main/java/de/westnordost/streetcomplete/Prefs.kt
@@ -24,6 +24,7 @@ object Pr... | diff --git a/app/src/androidTest/java/de/westnordost/streetcomplete/data/user/statistics/CountryStatisticsDaoTest.kt b/app/src/androidTest/java/de/westnordost/streetcomplete/data/user/statistics/CountryStatisticsDaoTest.kt
index 67b506b978f..5d6de8c1833 100644
--- a/app/src/androidTest/java/de/westnordost/streetcomplet... | {
"de.westnordost.streetcomplete.data.user.statistics.StatisticsControllerTest.update all": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.user.statistics.StatisticsControllerTest.adding one one day later": {
"run": "PASS",
"test": "NONE",
"fix": "PAS... | {} | {} | {} |
streetcomplete__StreetComplete-4472 | streetcomplete | StreetComplete | 4,472 | closed | Don't call MapDataWithEditsSource listeners if nothing changed | fixes #4077
This is a longer version of what was linked in https://github.com/streetcomplete/StreetComplete/issues/4077#issuecomment-1265693266, but it's not doing more work and I think it's easier to read that way.
| {
"label": "streetcomplete:master",
"ref": "master",
"sha": "003061b8b97d94b67fe0e5da6e50548342167b1e"
} | [
{
"number": 4077,
"title": "Improve performance on upload: Notice if nothing changed",
"body": "## Current behavior\r\n\r\nWhenever the map data changes (download, upload) or the user creates or deletes a local edit, `MapDataWithEditsSource` notifies its listeners about the changed map data. \r\n\r\nMos... | kotlin | Improve performance on upload: Notice if nothing changed
## Current behavior
Whenever the map data changes (download, upload) or the user creates or deletes a local edit, `MapDataWithEditsSource` notifies its listeners about the changed map data.
Most notably amongst the listeners is the `OsmQuestController` whi... | @Helium314, I think you started some implementation in the frame of another ticket already?
I noticed that the solution for this ticket will not only improve performance on upload, but also on the normal usage for most users, as auto-upload after each change is active. So currently after each quest solution/edit for... | https://github.com/streetcomplete/StreetComplete/pull/4472 | [
"https://github.com/streetcomplete/StreetComplete/issues/4077"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSource.kt b/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSource.kt
index 844147c20a8..8e6f803918d 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSour... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSourceTest.kt b/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithEditsSourceTest.kt
index 77b07a834a3..50af86e1703 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/MapDataWithE... | {
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getMapDataWithGeometry returns nothing because element was deleted": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getRelationsForElement returns an u... | {
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getMapDataWithGeometry returns original elements": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getWayComplete returns null because it is not complet... | {
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getWayComplete returns null because a node of the way was deleted": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.edits.MapDataWithEditsSourceTest.getRelationComplete returns incomple... | {} |
streetcomplete__StreetComplete-4471 | streetcomplete | StreetComplete | 4,471 | closed | Migrate to kotlinx-datetime | resolves #4240
On the whole this was rather easy as the kotlinx-datetime API seems to be based on Java's. | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "33663cc4bbbd0a51ad68cbbf25d228a407b9bca0"
} | [
{
"number": 4240,
"title": "Migrate from java.time to kotlinx-datetime",
"body": "A further step to make the core part of StreetComplete platform independent (#1892), usages of `java.time` classes should be replaced with kotlinx-datetime.\r\nI have had a cursory look at v0.4.0 so far and it looks stable... | kotlin | Migrate from java.time to kotlinx-datetime
A further step to make the core part of StreetComplete platform independent (#1892), usages of `java.time` classes should be replaced with kotlinx-datetime.
I have had a cursory look at v0.4.0 so far and it looks stable enough now, though some convenience functions are missin... | hey @westnordost,
I want to pick this up. if it is still in the Unassigned stage.
It is not assigned. Thank you! Or well, @matkoniecz assigned it to you now :-)
I'll just unassign you in case someone else would like to do this. It can be re-assigned when you or someone else actually starts to work on it. | https://github.com/streetcomplete/StreetComplete/pull/4471 | [
"https://github.com/streetcomplete/StreetComplete/issues/4240"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.quests.opening_hours.AddOpeningHoursTest" --tests "de.westnordost.streetcomplete.quests.surface.SurfaceAnswerKtTest" --tests "de.westnordost.streetcomplete.quests.shop_type.CheckShopTypeTest" --tests "de.westnordost.streetcomplete.data.elementfilte... | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 3c0920cae44..d5c9a218c04 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -149,6 +149,9 @@ dependencies {
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:$kotlinxCoroutinesVersion")
implementation("org.jetbrains.kot... | diff --git a/app/src/androidTest/java/de/westnordost/streetcomplete/data/download/tiles/DownloadedTilesDaoTest.kt b/app/src/androidTest/java/de/westnordost/streetcomplete/data/download/tiles/DownloadedTilesDaoTest.kt
index 293aeef8298..2d59655fa10 100644
--- a/app/src/androidTest/java/de/westnordost/streetcomplete/data... | {
"de.westnordost.streetcomplete.data.elementfilter.filters.ElementFilterOverpassKtTest.hasDateTagGreaterThan": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.quests.cycleway.AddCyclewayTest.applicable to road with cycleway that is far away enough": {
"run": "PASS... | {} | {} | {} |
streetcomplete__StreetComplete-4202 | streetcomplete | StreetComplete | 4,202 | closed | Only fetch newest element from API if necessary | fixes #4078
I did *not* yet test whether the modified upload actually works, need to go for a walk first and find something to change.
Related tests are not building, and I failed at making them work, so help would be appreciated. | {
"label": "streetcomplete:master",
"ref": "master",
"sha": "bbe39ed09da2c952c62b56100039b5c7eb3d88a1"
} | [
{
"number": 4078,
"title": "Improve performance on upload: Only fetch newest element from API if necessary",
"body": "## Current Behavior\r\n\r\nOn upload of edits to OSM data,\r\n\r\n1. first the app downloads the newest version of the element the edit refers to,\r\n2. then applies the edit to it local... | kotlin | Improve performance on upload: Only fetch newest element from API if necessary
## Current Behavior
On upload of edits to OSM data,
1. first the app downloads the newest version of the element the edit refers to,
2. then applies the edit to it locally
3. and then uploads the edited element
This means that for... | Some crude sketch:
Current upload (in `ElementEditUploader`):
* download element
* create updates (or throw if element was changed too much)
* try uploading changes
* `ConflictException` if changeset was closed or element was changed between download and upload
* on `ConflictException`, create a new changeset a... | https://github.com/streetcomplete/StreetComplete/pull/4202 | [
"https://github.com/streetcomplete/StreetComplete/issues/4078"
] | ./gradlew :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.data.osm.edits.upload.ElementEditUploaderTest" --tests "de.westnordost.streetcomplete.data.osm.edits.upload.ElementEditsUploaderTest" | diff --git a/app/src/main/java/de/westnordost/streetcomplete/ApplicationConstants.kt b/app/src/main/java/de/westnordost/streetcomplete/ApplicationConstants.kt
index 3edd6461143..c1fffa1e8e5 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/ApplicationConstants.kt
+++ b/app/src/main/java/de/westnordost/street... | diff --git a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/upload/ElementEditUploaderTest.kt b/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/upload/ElementEditUploaderTest.kt
index 2682bafb3ba..778a64f6a3f 100644
--- a/app/src/test/java/de/westnordost/streetcomplete/data/osm/edits/uplo... | {
"de.westnordost.streetcomplete.data.osm.edits.upload.ElementEditsUploaderTest.upload catches conflict exception": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.westnordost.streetcomplete.data.osm.edits.upload.ElementEditsUploaderTest.cancel upload works": {
"run": "PASS",
"test": "NO... | {} | {} | {} |
thunderbird__thunderbird-android-9852 | thunderbird | thunderbird-android | 9,852 | closed | refactor(outbox): enforce always one outbox folder per account and remove outboxFolderId from preferences | Fixes #8049.
This PR is meant to fix the issue where the Outbox gets removed from the database and inbox gets selected as also an outbox, causing the "IllegalStateException: No outbox_state entry for message with id <id>" notification.
This solution focus on:
- Remove the `outboxFolderId` reference from the pref... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "2b8ebd4d4cece92a78dd1dc2c4db7bfc157e39a7"
} | [
{
"number": 8049,
"title": "Annoying notification in status bar keeps reappearing multiple times a day: IllegalStateException: No outbox_state entry for message with id 1218",
"body": "### Checklist\r\n\r\n- [X] I have used the search function to see if someone else has already submitted the same bug re... | kotlin | Annoying notification in status bar keeps reappearing multiple times a day: IllegalStateException: No outbox_state entry for message with id 1218
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detai... | I have the same problem on android 13, thunderbird v 10.0 via fdroid
After updating to the latest beta (13.0b2) these notifications started appearing on my device too!
![Screenshot_2025-09-18-14-34-54-62_c3a231c25ed346e59462e84656a70e50.jpg](https://github.com/user-attachments/assets/131ef5e9-8dfb-48e7-96a5-9dc7cc1f80... | https://github.com/thunderbird/thunderbird-android/pull/9852 | [
"https://github.com/thunderbird/thunderbird-android/issues/8049"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.controller.DefaultMessageCountsProviderTest" --tests "com.fsck.k9.mailstore.folder.DefaultOutboxFolderManagerTest" --tests "com.fsck.k9.preferences.SettingsImporterTest" --tests "com.fsck.k9.notification.SyncNotificationControllerTest" --tests "com.fsck.k9.n... | diff --git a/app-common/src/main/kotlin/net/thunderbird/app/common/account/AccountCreator.kt b/app-common/src/main/kotlin/net/thunderbird/app/common/account/AccountCreator.kt
index 00dfcf00e92..cb1cf9c1173 100644
--- a/app-common/src/main/kotlin/net/thunderbird/app/common/account/AccountCreator.kt
+++ b/app-common/src/... | diff --git a/core/android/account/src/test/kotlin/net/thunderbird/core/android/account/LegacyAccountWrapperTest.kt b/core/android/account/src/test/kotlin/net/thunderbird/core/android/account/LegacyAccountWrapperTest.kt
index 72397c69251..1980c9d9801 100644
--- a/core/android/account/src/test/kotlin/net/thunderbird/core... | {
"com.fsck.k9.notification.SendFailedNotificationControllerTest.testShowSendFailedNotification": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.core.common.cache.TimeLimitedCacheTest.clearExpired should remove only expired entries": {
"run": "NONE",
"test": "NONE",
"fi... | {} | {
"app.k9mail.feature.settings.import.ui.SettingsImportViewModelTest.pickAppButton should only be enabled after app from which we can import has been found": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"net.thunderbird.core.android.account.LegacyAccountWrapperTest.should set defaults": {
"ru... | {} |
thunderbird__thunderbird-android-9831 | thunderbird | thunderbird-android | 9,831 | closed | Rewrite AutocryptHeaderParser and AutocryptGossipHeaderParser in Kotlin | - Fixes #9830
### Summary
This pull request refactors the `AutocryptHeaderParser` and `AutocryptGossipHeaderParser` classes from Java to Kotlin. The conversion enhances code readability, maintains existing functionality, and aligns with Kotlin best practices.
### Key Changes:
- Kotlin Conversion: Both classes ... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "eefc08dfcfee3deda766c42ac60f66ebb187ea61"
} | [
{
"number": 9830,
"title": "Rewrite AutocryptHeaderParser and AutocryptGossipHeaderParser in Kotlin",
"body": "Currently, `AutocryptHeaderParser` and `AutocryptGossipHeaderParser` are implemented in Java. For better Kotlin interoperability and idiomatic code, both classes should be converted to Kotlin w... | kotlin | Rewrite AutocryptHeaderParser and AutocryptGossipHeaderParser in Kotlin
Currently, `AutocryptHeaderParser` and `AutocryptGossipHeaderParser` are implemented in Java. For better Kotlin interoperability and idiomatic code, both classes should be converted to Kotlin with the following improvements:
1. Convert both classe... | null | https://github.com/thunderbird/thunderbird-android/pull/9831 | [
"https://github.com/thunderbird/thunderbird-android/issues/9830"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.autocrypt.AutocryptGossipHeaderParserTest" --tests "com.fsck.k9.autocrypt.AutocryptHeaderParserTest" | diff --git a/legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParser.java b/legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParser.java
deleted file mode 100644
index dfbeb80e841..00000000000
--- a/legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParser.java
... | diff --git a/legacy/core/src/test/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParserTest.kt b/legacy/core/src/test/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParserTest.kt
index 6ca3a1cccaa..29ac387aec4 100644
--- a/legacy/core/src/test/java/com/fsck/k9/autocrypt/AutocryptGossipHeaderParserTest.kt
+++ b/legacy... | {
"com.fsck.k9.autocrypt.AutocryptHeaderParserTest.getValidAutocryptHeader__withUnknownNonCriticalHeader": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.autocrypt.AutocryptHeaderParserTest.getValidAutocryptHeader__withNoHeader__shouldReturnNull": {
"run": "PASS",
"test": "NONE... | {} | {} | {} |
thunderbird__thunderbird-android-9823 | thunderbird | thunderbird-android | 9,823 | closed | fix(smtp): outlook smtp not authenticating when enterprise or educational accounts | Fixes #9160. | {
"label": "thunderbird:main",
"ref": "main",
"sha": "2b8ebd4d4cece92a78dd1dc2c4db7bfc157e39a7"
} | [
{
"number": 9160,
"title": "outlook.com outgoing server fails when enterprise or educational accounts",
"body": "#8024 is still happening for @Hanxyz13. Let's find out why.\n\n@Hanxyz13 could you provide the logs here instead?"
}
] | kotlin | outlook.com outgoing server fails when enterprise or educational accounts
#8024 is still happening for @Hanxyz13. Let's find out why.
@Hanxyz13 could you provide the logs here instead?
| [23_05-10-27-20_935.zip](https://github.com/user-attachments/files/20403111/23_05-10-27-20_935.zip)
I re-tried logging in to outlook at Thunderbird for Android, and recorded the logs, hope it works for you!
@kewisch Fwiw, this issue (detailed in #8024) is also affecting me.
I don't know exactly when the underlying iss... | https://github.com/thunderbird/thunderbird-android/pull/9823 | [
"https://github.com/thunderbird/thunderbird-android/issues/9160"
] | ./gradlew :mail:protocols:smtp:test --tests "com.fsck.k9.mail.transport.smtp.SmtpServerSettingsValidatorTest" :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.ImapServerSettingsValidatorTest" --tests "com.fsck.k9.mail.store.imap.RealImapConnectionTest" | diff --git a/app-thunderbird/src/debug/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt b/app-thunderbird/src/debug/kotlin/net/thunderbird/android/auth/TbOAuthConfigurationFactory.kt
index eccbf45aaf5..f95419d0855 100644
--- a/app-thunderbird/src/debug/kotlin/net/thunderbird/android/auth/TbOAuthConfig... | diff --git a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/ImapServerSettingsValidatorTest.kt b/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/ImapServerSettingsValidatorTest.kt
index dcd55a9826a..b0ff10e5672 100644
--- a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/ImapS... | {
"com.fsck.k9.mail.store.imap.RealImapConnectionTest.open() with empty untagged ID response": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapConnectionTest.open() AUTH EXTERNAL with authentication failure should throw": {
"run": "PASS",
"test": "NONE",
... | {} | {} | {} |
thunderbird__thunderbird-android-9818 | thunderbird | thunderbird-android | 9,818 | closed | feat(message-list): change item layout | Resolves #9654
The design is not covering the `MessageListAppearance` options. We need another round of discussion how to handle these. | {
"label": "thunderbird:main",
"ref": "main",
"sha": "6b1e704e6cd96152e26686dbcd7963017e2074d4"
} | [
{
"number": 9654,
"title": "Replace MessageList items with new UI components",
"body": "The new Composable MessageList item UI should replace the XML-based layouts.\n\nThese changes should be guarded by a feature flag."
}
] | kotlin | Replace MessageList items with new UI components
The new Composable MessageList item UI should replace the XML-based layouts.
These changes should be guarded by a feature flag.
| null | https://github.com/thunderbird/thunderbird-android/pull/9818 | [
"https://github.com/thunderbird/thunderbird-android/issues/9654"
] | ./gradlew :legacy:ui:legacy:testDebugUnitTest --tests "com.fsck.k9.ui.messagelist.MessageListAdapterTest" | diff --git a/app-k9mail/src/debug/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt b/app-k9mail/src/debug/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt
index c1a641f83b2..abcc807ed3c 100644
--- a/app-k9mail/src/debug/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt
+++ b/app-k9mail/src/debug/kotlin/ap... | diff --git a/legacy/ui/legacy/src/test/java/com/fsck/k9/ui/messagelist/MessageListAdapterTest.kt b/legacy/ui/legacy/src/test/java/com/fsck/k9/ui/messagelist/MessageListAdapterTest.kt
index ba843fdcfcb..97da1876546 100644
--- a/legacy/ui/legacy/src/test/java/com/fsck/k9/ui/messagelist/MessageListAdapterTest.kt
+++ b/leg... | {
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withStarsAndUnstarredMessage_shouldNotSetStarViewToSelected": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withThreadCountGreaterOne_shouldShowThreadCountViewWithExpectedValue": {
"run": "P... | {} | {} | {} |
thunderbird__thunderbird-android-9772 | thunderbird | thunderbird-android | 9,772 | closed | fix: correctly handles the server ID when an IMAP prefix is present, ensuring the prefix is not duplicated | Fixes #9567.
Fixes #9771.
## Testing
### Pre-requisites
To test the following changes, you need to have:
- An email from an email provider which DOES enforce IMAP prefixes (returned via `NAMESPACE` command; Email providers that use the dovecot IMAP Servers are good ones to use)
- An email from an email provider... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "b4ba493856af7af75b6ced27a95d3579f33ab4ac"
} | [
{
"number": 9771,
"title": "Special folders gets wiped out when updating from 11.x to 12.x",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\... | kotlin | Special folders gets wiped out when updating from 11.x to 12.x
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
12.1
### Where did... | The problem is the following:
The folder on Dovecot IMAP server is named "INBOX.PANGAEA" (shown in UI as "PANGAEA" on Thunderbird Mobile), but when Thunderbird synchronizes it, the mailserver logs:
2025-09-10T13:56:58.772552+00:00 serv2 dovecot: IMAP(thetaphi): Debug: Mailbox INBOX.INBOX.PANGAEA: Mailbox opened
So b... | https://github.com/thunderbird/thunderbird-android/pull/9772 | [
"https://github.com/thunderbird/thunderbird-android/issues/9771",
"https://github.com/thunderbird/thunderbird-android/issues/9567"
] | ./gradlew :backend:imap:test --tests "net.thunderbird.backend.imap.ImapRemoteFolderCreatorTest" :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.RealImapStoreTest" --tests "com.fsck.k9.mail.store.imap.RealImapFolderTest" | diff --git a/backend/imap/src/main/java/com/fsck/k9/backend/imap/CommandRefreshFolderList.kt b/backend/imap/src/main/java/com/fsck/k9/backend/imap/CommandRefreshFolderList.kt
index 9ae0e96d537..d6b55215e60 100644
--- a/backend/imap/src/main/java/com/fsck/k9/backend/imap/CommandRefreshFolderList.kt
+++ b/backend/imap/sr... | diff --git a/backend/imap/src/test/java/com/fsck/k9/backend/imap/TestImapStore.kt b/backend/imap/src/test/java/com/fsck/k9/backend/imap/TestImapStore.kt
index 098cb8e909c..d868503eed5 100644
--- a/backend/imap/src/test/java/com/fsck/k9/backend/imap/TestImapStore.kt
+++ b/backend/imap/src/test/java/com/fsck/k9/backend/i... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.appendMessages() on closed folder should throw": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_shouldFetchMessageCount": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsc... | {} | {} | {} |
thunderbird__thunderbird-android-9759 | thunderbird | thunderbird-android | 9,759 | closed | Rewrite AutocryptHeader and AutocryptGossipHeader in Kotlin instead of Java | - Fixes #9758
- **Summary** : This PR refactors the existing AutocryptHeader and AutocryptGossipHeader classes from Java into idiomatic Kotlin. The conversion simplifies code, enhances null safety, and leverages Kotlin’s modern language features.
- **Implementation Highlights**:
- `AutocryptHeader.kt`:
... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "c2eafb6ae85f9433a47c9b3500295912e0109459"
} | [
{
"number": 9758,
"title": "Rewrite AutocryptHeader and AutocryptGossipHeader in Kotlin instead of Java",
"body": "We should migrate the `AutocryptHeader` and `AutocryptGossipHeader` to Kotlin to align with the ongoing modernization efforts and Kotlin-first development approach across the codebase."
... | kotlin | Rewrite AutocryptHeader and AutocryptGossipHeader in Kotlin instead of Java
We should migrate the `AutocryptHeader` and `AutocryptGossipHeader` to Kotlin to align with the ongoing modernization efforts and Kotlin-first development approach across the codebase.
| null | https://github.com/thunderbird/thunderbird-android/pull/9759 | [
"https://github.com/thunderbird/thunderbird-android/issues/9758"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.autocrypt.AutocryptHeaderParserTest" | diff --git a/legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeader.java b/legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeader.java
deleted file mode 100644
index 91d9b788365..00000000000
--- a/legacy/core/src/main/java/com/fsck/k9/autocrypt/AutocryptGossipHeader.java
+++ /dev/null
@@ -... | diff --git a/legacy/core/src/test/java/com/fsck/k9/autocrypt/AutocryptHeaderParserTest.java b/legacy/core/src/test/java/com/fsck/k9/autocrypt/AutocryptHeaderParserTest.java
index 4aefaecfcb1..1b2d996d5ff 100644
--- a/legacy/core/src/test/java/com/fsck/k9/autocrypt/AutocryptHeaderParserTest.java
+++ b/legacy/core/src/te... | {
"com.fsck.k9.autocrypt.AutocryptHeaderParserTest.getValidAutocryptHeader__withUnknownNonCriticalHeader": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.autocrypt.AutocryptHeaderParserTest.getValidAutocryptHeader__withNoHeader__shouldReturnNull": {
"run": "PASS",
"test": "NONE... | {} | {} | {} |
thunderbird__thunderbird-android-9716 | thunderbird | thunderbird-android | 9,716 | closed | fix(drawer): crash when opening placeholder folder | Fixes #9644.
- Change the placeholder `MailDisplayFolder` to not have an account ID.
- Ensure that we only trigger `onClick(displayFolder)` in case we have an account ID.
- If tapping on a Placeholder folder, toggle the `isExpanded` state.
> [!NOTE]
> A follow-up ticket will be placed to investigate why the `[... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "64f59d1a3e2f5ceee52d3b5c9619706426243107"
} | [
{
"number": 9644,
"title": "12.0b7 crash. Upon [gmail] folder selection",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\nThunderbird for An... | kotlin | 12.0b7 crash. Upon [gmail] folder selection
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
12.0b7
### Where did you get the app ... | Seems related to #9134 , #9353 and possibly a regression following #9213
The [gmail] folder exists in v11.1 however selecting it doesn't crash the app.
This is the top crash (affects the most users) for 12.0b7
I think I have a simple reproducer that does not require waiting:
1. Add 2 accounts, 1 of them Gmail
2. Ref... | https://github.com/thunderbird/thunderbird-android/pull/9716 | [
"https://github.com/thunderbird/thunderbird-android/issues/9644"
] | ./gradlew :feature:navigation:drawer:dropdown:testDebugUnitTest --tests "net.thunderbird.feature.navigation.drawer.dropdown.domain.usecase.GetDisplayTreeFolderTest" --tests "net.thunderbird.feature.navigation.drawer.dropdown.ui.DrawerViewModelTest" | diff --git a/feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/domain/entity/MailDisplayFolder.kt b/feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/domain/entity/MailDisplayFolder.kt
index ee14c89efd4..07b8a6643d4 ... | diff --git a/feature/navigation/drawer/dropdown/src/test/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/domain/usecase/GetDisplayTreeFolderTest.kt b/feature/navigation/drawer/dropdown/src/test/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/domain/usecase/GetDisplayTreeFolderTest.kt
index 0598feacc... | {
"net.thunderbird.feature.navigation.drawer.dropdown.ui.DrawerViewModelTest.when initial state has drawerConfigWithAccountSelectorEnabled saveDrawerConfig should receive drawerConfigWithAccountSelectorDisabled when OnAccountSelectorClick event is received": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"... | {} | {} | {} |
thunderbird__thunderbird-android-9710 | thunderbird | thunderbird-android | 9,710 | closed | chore(drawer): create drawer's folder tree based on the account's folder path delimiter | Fixes #9691.
- Added `{account_uuid}.folderPathDelimiter` settings
- Store the path delimiter given by the response of the IMAP LIST command whenever the folders get synced, and the current stored path delimiter is different from the command response.
- Added settings migration from version 105 to 106
- Adjust d... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "c50cbdcf791dcc99ab27eb04db7c004d26a865c6"
} | [
{
"number": 9691,
"title": "Subfolders are still shown as Folder.Subfolder",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\nThunderbird for... | kotlin | Subfolders are still shown as Folder.Subfolder
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
11.1
### Where did you get the app... | @da-anda already pointed this out in https://github.com/thunderbird/thunderbird-android/pull/9045#pullrequestreview-3065723035 that the seperator seems to be hardcoded to `/` .
@MarcusWolschon mentioned in https://github.com/thunderbird/thunderbird-android/pull/8956#issuecomment-3152372213 IMAP servers should tell the... | https://github.com/thunderbird/thunderbird-android/pull/9710 | [
"https://github.com/thunderbird/thunderbird-android/issues/9691"
] | ./gradlew :feature:navigation:drawer:dropdown:testDebugUnitTest --tests "net.thunderbird.feature.navigation.drawer.dropdown.domain.usecase.GetDisplayFoldersForAccountTest" --tests "net.thunderbird.feature.navigation.drawer.dropdown.domain.usecase.GetDisplayTreeFolderTest" --tests "net.thunderbird.feature.navigation.dra... | diff --git a/backend/api/src/main/java/com/fsck/k9/backend/api/Backend.kt b/backend/api/src/main/java/com/fsck/k9/backend/api/Backend.kt
index 73d5b9f0616..d9808d4f19f 100644
--- a/backend/api/src/main/java/com/fsck/k9/backend/api/Backend.kt
+++ b/backend/api/src/main/java/com/fsck/k9/backend/api/Backend.kt
@@ -5,6 +5,... | diff --git a/feature/account/storage/legacy/src/test/kotlin/net/thunderbird/feature/account/storage/legacy/mapper/DefaultLegacyAccountWrapperDataMapperTest.kt b/feature/account/storage/legacy/src/test/kotlin/net/thunderbird/feature/account/storage/legacy/mapper/DefaultLegacyAccountWrapperDataMapperTest.kt
index f617a13... | {
"net.thunderbird.feature.navigation.drawer.siderail.domain.usecase.GetDisplayFoldersForAccountTest.should return account folders and unified folders when includeUnifiedFolders is true": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.navigation.drawer.dropdown.ui.DrawerVie... | {} | {} | {} |
thunderbird__thunderbird-android-9705 | thunderbird | thunderbird-android | 9,705 | closed | feat(core): add configstore as key-value store | Resolves #9704 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "32a673732e0c392a8ac46ee4c99e7b7b94237cc9"
} | [
{
"number": 9704,
"title": "Add DataStore to persist key-value based preferences",
"body": "Introduce a new `core:datastore` module to provide a robust, scalable, and flexible data storage solution for core features. \n\n**Acceptance Criteria:**\n\n- Module supports versioning and migration\n- API is do... | kotlin | Add DataStore to persist key-value based preferences
Introduce a new `core:datastore` module to provide a robust, scalable, and flexible data storage solution for core features.
**Acceptance Criteria:**
- Module supports versioning and migration
- API is documented and extensible
- Tests cover migration and versioni... | null | https://github.com/thunderbird/thunderbird-android/pull/9705 | [
"https://github.com/thunderbird/thunderbird-android/issues/9704"
] | ./gradlew :core:configstore:impl-backend:testDebugUnitTest --tests "net.thunderbird.core.configstore.backend.DefaultDataStoreConfigBackendTest" --tests "net.thunderbird.core.configstore.backend.DataStoreConfigBackendFactoryTest" :core:configstore:api:testDebugUnitTest --tests "net.thunderbird.core.configstore.TestConfi... | diff --git a/app-common/build.gradle.kts b/app-common/build.gradle.kts
index 56ef6856522..871afb85bca 100644
--- a/app-common/build.gradle.kts
+++ b/app-common/build.gradle.kts
@@ -27,6 +27,9 @@ dependencies {
implementation(projects.core.logging.implLegacy)
implementation(projects.core.logging.implFile)
+ ... | diff --git a/core/configstore/api/src/commonTest/kotlin/net/thunderbird/core/configstore/BaseConfigStoreMigrationTest.kt b/core/configstore/api/src/commonTest/kotlin/net/thunderbird/core/configstore/BaseConfigStoreMigrationTest.kt
new file mode 100644
index 00000000000..df180bab47e
--- /dev/null
+++ b/core/configstore/... | {
"net.thunderbird.core.configstore.backend.DefaultDataStoreConfigBackendTest.removeKeys should delete specified keys from preferences": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.core.configstore.backend.DefaultDataStoreConfigBackendTest.read should return config with values f... | {} | {} | {} |
thunderbird__thunderbird-android-9642 | thunderbird | thunderbird-android | 9,642 | closed | Extract DisplayCoreSettings and DisplayInboxSettings from DisplaySettings | - Fixes #9641
### Implementation Details
- Introduces two new `DisplaySettings` sub-groups: `DisplayCoreSettings` and `DisplayInboxSettings`.
- Adds corresponding preference managers: `DisplayCoreSettingsPreferenceManager` and `DisplayInboxSettingsPreferenceManager`, along with their implementations.
- Updates t... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "39a6a6d559760d7052fc6c0cc871a8d5bdf6fb64"
} | [
{
"number": 9641,
"title": "Extract DisplayCoreSettings and DisplayInboxSettings from DisplaySettings",
"body": "`DisplaySettings ` currently contains a number of properties.\nTo improve maintainability and prepare for further modularization, this change will introduce two dedicated settings groups:\n... | kotlin | Extract DisplayCoreSettings and DisplayInboxSettings from DisplaySettings
`DisplaySettings ` currently contains a number of properties.
To improve maintainability and prepare for further modularization, this change will introduce two dedicated settings groups:
`DisplayCoreSettings `→ for core display configurations ... | null | https://github.com/thunderbird/thunderbird-android/pull/9642 | [
"https://github.com/thunderbird/thunderbird-android/issues/9641"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.UnifiedInboxConfiguratorTest" | diff --git a/core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/display/DisplaySettings.kt b/core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/display/DisplaySettings.kt
index 1bf3151cc14..4dd6fcab72d 100644
--- a/core/preference/api/src/commonMain/kotlin/net/thunderbird/c... | diff --git a/legacy/core/src/test/java/com/fsck/k9/UnifiedInboxConfiguratorTest.kt b/legacy/core/src/test/java/com/fsck/k9/UnifiedInboxConfiguratorTest.kt
index d6c202f42ad..98f4e140b7d 100644
--- a/legacy/core/src/test/java/com/fsck/k9/UnifiedInboxConfiguratorTest.kt
+++ b/legacy/core/src/test/java/com/fsck/k9/Unified... | {
"com.fsck.k9.UnifiedInboxConfiguratorTest.configureUnifiedInbox should not enable unified inbox when there are more than two accounts": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.UnifiedInboxConfiguratorTest.configureUnifiedInbox should enable unified inbox when there are exactly... | {} | {} | {} |
thunderbird__thunderbird-android-9640 | thunderbird | thunderbird-android | 9,640 | closed | fix(notifications): Respect isQuietTimeEnabled | This PR restores quiet time behaviour from before #9405/TB12. It resolves problems with tests failing between 23:00 and 00:00 and modifies one of the tests, so that such regression will be caught earlier in the future (not only after 23:00).
Fixes #9629
<!-- Please ensure that your pull request meets the followin... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "39a6a6d559760d7052fc6c0cc871a8d5bdf6fb64"
} | [
{
"number": 9629,
"title": "Quiet time always acts as enabled",
"body": "~~**Note:** This issue is based only on code analysis and problems observed in tests. I did not check if it's a problem when using the app.~~ **EDIT:** Tested, see https://github.com/thunderbird/thunderbird-android/issues/9629#issu... | kotlin | Quiet time always acts as enabled
~~**Note:** This issue is based only on code analysis and problems observed in tests. I did not check if it's a problem when using the app.~~ **EDIT:** Tested, see https://github.com/thunderbird/thunderbird-android/issues/9629#issuecomment-3258078905
When Quiet Time is not enabled, no... | The failing tests:
1. use quiet time 23:00 - 00:00
2. create notifications with `silent` argument `false`
3. expect the `.isSilent` property to be `false`
However, notifications are silent if `silent` is `true` or it is quiet time. Since these tests do not change the clock, running them after 23:00 (local time) resul... | https://github.com/thunderbird/thunderbird-android/pull/9640 | [
"https://github.com/thunderbird/thunderbird-android/issues/9629"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.notification.SummaryNotificationDataCreatorTest" | diff --git a/legacy/common/src/main/java/com/fsck/k9/notification/K9NotificationStrategy.kt b/legacy/common/src/main/java/com/fsck/k9/notification/K9NotificationStrategy.kt
index 3bf142cdd79..d84f4f677a6 100644
--- a/legacy/common/src/main/java/com/fsck/k9/notification/K9NotificationStrategy.kt
+++ b/legacy/common/src/... | diff --git a/legacy/core/src/test/java/com/fsck/k9/notification/SummaryNotificationDataCreatorTest.kt b/legacy/core/src/test/java/com/fsck/k9/notification/SummaryNotificationDataCreatorTest.kt
index 3a35507d448..4274f621877 100644
--- a/legacy/core/src/test/java/com/fsck/k9/notification/SummaryNotificationDataCreatorTe... | {
"com.fsck.k9.notification.SummaryNotificationDataCreatorTest.single notification with quiet time disabled": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.SummaryNotificationDataCreatorTest.single notification during quiet time": {
"run": "PASS",
"test": "NONE",
... | {
"com.fsck.k9.notification.SummaryNotificationDataCreatorTest.show delete action for single notification without confirmation": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.notification.SummaryNotificationDataCreatorTest.always show delete action without confirmation": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.notification.SummaryNotificationDataCreatorTest.inbox-style notification during quiet time": {
"run": "PASS",
"test": "... | {} |
thunderbird__thunderbird-android-9628 | thunderbird | thunderbird-android | 9,628 | closed | feat(notifications): add in-app notification scaffold and host | Resolves #9537.
Part of #9312.
Depends on #9624.
- Introduce `InAppNotificationHost` used to properly show, hide and dismiss in-app notifications, listening events from `InAppNotificationReceiver`
- Introduce `InAppNotificationScaffold` acting as a wrapper for `Scaffold` composable, letting any screen which uses ... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "d0dbf97ba4e7b0917dda9c0bef6272e75900ec10"
} | [
{
"number": 9537,
"title": "In-App Error Notifications - Scaffolding - Create InAppNotificationHost",
"body": null
}
] | kotlin | In-App Error Notifications - Scaffolding - Create InAppNotificationHost
| null | https://github.com/thunderbird/thunderbird-android/pull/9628 | [
"https://github.com/thunderbird/thunderbird-android/issues/9537"
] | ./gradlew :feature:notification:api:testDebugUnitTest --tests "net.thunderbird.feature.notification.api.ui.host.InAppNotificationHostStateHolderTest" --tests "net.thunderbird.feature.notification.api.ui.BannerGlobalNotificationHostTest" --tests "net.thunderbird.feature.notification.api.ui.BannerInlineNotificationListHo... | diff --git a/feature/debug-settings/src/main/kotlin/net/thunderbird/feature/debug/settings/SecretDebugSettingsScreen.kt b/feature/debug-settings/src/main/kotlin/net/thunderbird/feature/debug/settings/SecretDebugSettingsScreen.kt
index de310296608..5fed06dedc3 100644
--- a/feature/debug-settings/src/main/kotlin/net/thun... | diff --git a/core/ui/compose/testing/src/main/kotlin/app/k9mail/core/ui/compose/testing/ComposeTest.kt b/core/ui/compose/testing/src/main/kotlin/app/k9mail/core/ui/compose/testing/ComposeTest.kt
index 62849a69d9a..fee2bce9701 100644
--- a/core/ui/compose/testing/src/main/kotlin/app/k9mail/core/ui/compose/testing/Compos... | {
"net.thunderbird.feature.notification.api.ui.BannerInlineNotificationListHostTest.should trigger onOpenErrorNotificationsClick when open error notifications button is clicked": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.notification.api.ui.BannerGlobalNotificationHost... | {} | {} | {} |
thunderbird__thunderbird-android-9562 | thunderbird | thunderbird-android | 9,562 | closed | Fix database migration missing avatar type | Resolves #9547
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "7d0efc59ad5782ffdb670350b01e0736a3b7624d"
} | [
{
"number": 9547,
"title": "Fix migration to ensure avatar type is set",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\nThunderbird for And... | kotlin | Fix migration to ensure avatar type is set
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
12.0b4
### Where did you get the app f... | I have the same problem and did some digging into the code and app data.
When I tried to reproduce the issue in a fresh install (`fossDebug` build from beta branch), everything worked correctly. Only my main install (beta from GitHub, regularly updated since the first release branded as Thunderbird) crashed when click... | https://github.com/thunderbird/thunderbird-android/pull/9562 | [
"https://github.com/thunderbird/thunderbird-android/issues/9547"
] | ./gradlew :legacy:storage:testDebugUnitTest --tests "com.fsck.k9.preferences.migration.StorageMigrationTo28Test" | diff --git a/legacy/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java b/legacy/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java
index ea46efd33f2..6f82d178612 100644
--- a/legacy/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java
+++ b/legacy/storage/src/main/... | diff --git a/legacy/storage/src/test/java/com/fsck/k9/preferences/migration/StorageMigrationTo28Test.kt b/legacy/storage/src/test/java/com/fsck/k9/preferences/migration/StorageMigrationTo28Test.kt
new file mode 100644
index 00000000000..f103e10c59b
--- /dev/null
+++ b/legacy/storage/src/test/java/com/fsck/k9/preference... | {
"com.fsck.k9.preferences.migration.StorageMigrationTo28Test.avatar type should not be set for accounts with existing avatar type": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.preferences.migration.StorageMigrationTo28Test.avatar monogram should be set for accounts with MONOGRAM av... | {} | {} | {} |
thunderbird__thunderbird-android-9509 | thunderbird | thunderbird-android | 9,509 | closed | Migrate K9.isDebugLoggingEnabled to PreferenceDataStore | - Fixes #9456
### Implementation Highlights
- Implemented buildFeature in `core.preference` module and shared BuildConfig's `DEBUG` flag through `expect-actual` pattern in `commonMain`.
- Migrate `K9.isDebugLoggingEnabled` to `PreferenceDataStore`. | {
"label": "thunderbird:main",
"ref": "main",
"sha": "f682fd036540ac7a60a62d64dc4e82ab77873ef4"
} | [
{
"number": 9456,
"title": "Migrate K9.isDebugLoggingEnabled to PreferenceDataStore",
"body": "Goal of this issue is to migrate `isDebugLoggingEnabled ` to `PreferenceDataStore` and replace all direct usage of `K9.isDebugLoggingEnabled` with it throught the application."
}
] | kotlin | Migrate K9.isDebugLoggingEnabled to PreferenceDataStore
Goal of this issue is to migrate `isDebugLoggingEnabled ` to `PreferenceDataStore` and replace all direct usage of `K9.isDebugLoggingEnabled` with it throught the application.
| null | https://github.com/thunderbird/thunderbird-android/pull/9509 | [
"https://github.com/thunderbird/thunderbird-android/issues/9456"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.preferences.SettingsUpgradeHelperTest" --tests "com.fsck.k9.preferences.AccountSettingsUpgraderTest" --tests "com.fsck.k9.mailstore.LocalStoreTest" --tests "com.fsck.k9.message.TextBodyBuilderTest" :legacy:ui:legacy:testDebugUnitTest --tests "com.fsck.k9.ui.... | diff --git a/core/logging/impl-legacy/build.gradle.kts b/core/logging/impl-legacy/build.gradle.kts
index 07efd269856..50d80fc1b10 100644
--- a/core/logging/impl-legacy/build.gradle.kts
+++ b/core/logging/impl-legacy/build.gradle.kts
@@ -8,6 +8,10 @@ android {
kotlin {
sourceSets {
+ androidMain.dependenc... | diff --git a/legacy/core/src/test/java/com/fsck/k9/mailstore/LocalStoreTest.java b/legacy/core/src/test/java/com/fsck/k9/mailstore/LocalStoreTest.java
index db28fd6df0a..13fa3b88c9d 100644
--- a/legacy/core/src/test/java/com/fsck/k9/mailstore/LocalStoreTest.java
+++ b/legacy/core/src/test/java/com/fsck/k9/mailstore/Loc... | {
"com.fsck.k9.mailstore.LocalStoreTest.findPartById__withRootLocalMessage": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mailstore.LocalStoreTest.findPartById__withNestedLocalMessagePart": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.TextBod... | {} | {
"com.fsck.k9.ui.messageview.ViewIntentFinderTest.inferred content type should be preferred over provided default content type": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.ui.messageview.ViewIntentFinderTest.provided non-default content type should be preferred": {
"run": "PAS... | {} |
thunderbird__thunderbird-android-9508 | thunderbird | thunderbird-android | 9,508 | closed | feat(notification): trigger in-app notification using `InAppNotificationNotifier` | Depends on #9500, #9506
Changeset split from #9415.
Resolve #9245.
- Implement the `InAppNotificationCommand` and `InAppNotificationNotifier`
- Add `InAppNotificationEventBus` and `InAppNotificationReceiver` to broadcast the notification over the application without using Android `BroadcastReceiver`.
- Add `InA... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "d8d92d5051e977d241c2c31c298341181f205ea3"
} | [
{
"number": 9245,
"title": "In-App Error Notifications - Create NotificationSender",
"body": "As we are going to have at least two different notification providers (system and in-app), it is important to have a manager to simplify the notification triggering.\n\nThe `NotificationSender` will be responsi... | kotlin | In-App Error Notifications - Create NotificationSender
As we are going to have at least two different notification providers (system and in-app), it is important to have a manager to simplify the notification triggering.
The `NotificationSender` will be responsible for receiving a notification object and triggering th... | Verify if the current implementation of [`NotificationDataStore`](https://github.com/thunderbird/thunderbird-android/blob/main/legacy/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt), [`NotificationController`](https://github.com/thunderbird/thunderbird-android/blob/main/legacy/core/src/main/java/c... | https://github.com/thunderbird/thunderbird-android/pull/9508 | [
"https://github.com/thunderbird/thunderbird-android/issues/9245"
] | ./gradlew :feature:notification:api:testDebugUnitTest --tests "net.thunderbird.feature.notification.api.receiver.compat.InAppNotificationReceiverCompatTest" :feature:notification:impl:testDebugUnitTest --tests "net.thunderbird.feature.notification.impl.command.InAppNotificationCommandTest" --tests "net.thunderbird.feat... | diff --git a/feature/debug-settings/src/debug/kotlin/net/thunderbird/feature/debug/settings/SecretDebugSettingsScreenPreview.kt b/feature/debug-settings/src/debug/kotlin/net/thunderbird/feature/debug/settings/SecretDebugSettingsScreenPreview.kt
index 3a8145fed7f..3040ad5bdb9 100644
--- a/feature/debug-settings/src/debu... | diff --git a/feature/notification/api/src/commonTest/kotlin/net/thunderbird/feature/notification/api/receiver/compat/InAppNotificationReceiverCompatTest.kt b/feature/notification/api/src/commonTest/kotlin/net/thunderbird/feature/notification/api/receiver/compat/InAppNotificationReceiverCompatTest.kt
new file mode 10064... | {
"net.thunderbird.feature.notification.impl.receiver.InAppNotificationNotifierTest.show should publish event when notification is not present in NotificationRegistry": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.notification.impl.command.InAppNotificationCommandTest.exe... | {} | {} | {} |
thunderbird__thunderbird-android-9481 | thunderbird | thunderbird-android | 9,481 | closed | Refactor search to kotlin - part 3 | This finishes the Java to Kotlin rewrite of the search functionality.
The remaining `LocalMessageSearch` was converted to Kotlin and the most important change is replacing `Parcelable` with `Serializable`.
The search module is now a full kmp module and the implemetation has been moved under `impl-legacy` to prepa... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "785fb4dea3ae528c55e49fa35a2e046b5894d88b"
} | [
{
"number": 9229,
"title": "Change feature search to Kotlin",
"body": "The `feature:search` is still written in Java, this needs to be changed to allow further changes to search to finally decouple `MessageList` from `LocalSearch`. This should help to fix the drawer cashes when the local state doesn't m... | kotlin | Change feature search to Kotlin
The `feature:search` is still written in Java, this needs to be changed to allow further changes to search to finally decouple `MessageList` from `LocalSearch`. This should help to fix the drawer cashes when the local state doesn't match the app state.
Additionally it should be split in... | null | https://github.com/thunderbird/thunderbird-android/pull/9481 | [
"https://github.com/thunderbird/thunderbird-android/issues/9229"
] | ./gradlew :feature:widget:unread:testDebugUnitTest --tests "app.k9mail.feature.widget.unread.UnreadWidgetDataProviderTest" :feature:navigation:drawer:siderail:testDebugUnitTest --tests "net.thunderbird.feature.navigation.drawer.siderail.data.UnifiedFolderRepositoryTest" :feature:search:impl-legacy:testDebugUnitTest --t... | diff --git a/feature/navigation/drawer/dropdown/build.gradle.kts b/feature/navigation/drawer/dropdown/build.gradle.kts
index b88f3c7eb8a..77d5f86ff48 100644
--- a/feature/navigation/drawer/dropdown/build.gradle.kts
+++ b/feature/navigation/drawer/dropdown/build.gradle.kts
@@ -18,7 +18,7 @@ dependencies {
implement... | diff --git a/feature/navigation/drawer/dropdown/src/test/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/data/FakeMessageCountsProvider.kt b/feature/navigation/drawer/dropdown/src/test/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/data/FakeMessageCountsProvider.kt
index 2148b31c11f..6e62a2ab1e0 10... | {
"app.k9mail.feature.widget.unread.UnreadWidgetDataProviderTest.unifiedInbox": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.storage.messages.RetrieveFolderOperationsTest.get unread message count from non-existent folder": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
... | {} | {} | {} |
thunderbird__thunderbird-android-9469 | thunderbird | thunderbird-android | 9,469 | closed | feat(avatar): relax the data mapper logic | Relax the data mapper logic by adding a default value instead of throwing exceptions
Fixes #9468 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "eb248fc80ba39778aea1335650546b78caac66d1"
} | [
{
"number": 9468,
"title": "The avatar mapping it too restrictive and should apply defaults",
"body": "The current mapping logic for avatars is to restrictive and needs to provide defaults instead of throwing exceptions."
}
] | kotlin | The avatar mapping it too restrictive and should apply defaults
The current mapping logic for avatars is to restrictive and needs to provide defaults instead of throwing exceptions.
| null | https://github.com/thunderbird/thunderbird-android/pull/9469 | [
"https://github.com/thunderbird/thunderbird-android/issues/9468"
] | ./gradlew :feature:account:storage:legacy:testDebugUnitTest --tests "net.thunderbird.feature.account.storage.legacy.mapper.DefaultAccountAvatarDataMapperTest" | diff --git a/feature/account/storage/legacy/src/main/kotlin/net/thunderbird/feature/account/storage/legacy/mapper/DefaultAccountAvatarDataMapper.kt b/feature/account/storage/legacy/src/main/kotlin/net/thunderbird/feature/account/storage/legacy/mapper/DefaultAccountAvatarDataMapper.kt
index 8a318981902..7bcd58a0524 1006... | diff --git a/feature/account/storage/legacy/src/test/kotlin/net/thunderbird/feature/account/storage/legacy/mapper/DefaultAccountAvatarDataMapperTest.kt b/feature/account/storage/legacy/src/test/kotlin/net/thunderbird/feature/account/storage/legacy/mapper/DefaultAccountAvatarDataMapperTest.kt
index 79a8bf239e6..2bc1fd42... | {
"net.thunderbird.feature.account.storage.legacy.mapper.DefaultAccountAvatarDataMapperTest.toDomain should return default monogram for invalid AvatarDto": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.account.storage.legacy.mapper.DefaultAccountAvatarDataMapperTest.toDto ... | {
"net.thunderbird.feature.account.storage.legacy.mapper.DefaultAccountAvatarDataMapperTest.toDomain should map valid AvatarDto to correct AccountAvatar type": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
thunderbird__thunderbird-android-9423 | thunderbird | thunderbird-android | 9,423 | closed | Migrate K9.isHideUserAgent to PreferenceDataStore | - Fixes #9422
### Implementation Highlights:
- Migrated `isHideUserAgent` from `K9` to `PrivacySettings`.
- Delegated `isHideUserAgent` value updates to `PrivacySettingsManager`.
- Replaced static reference of `isHideUserAgent` with access via `generalSettings.privacySettings.isHideUserAgent`.
- Updated tests ... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "66ab7a09325a56f2143c87ccb14588795d3ca5bb"
} | [
{
"number": 9422,
"title": "Migrate K9.isHideUserAgent to PreferenceDataStore",
"body": "The current implementation in Thunderbird Android directly accesses the static field `K9.isHideUserAgent` to determine whether the **User-Agent** header should be removed from outgoing emails. This approach bypasses... | kotlin | Migrate K9.isHideUserAgent to PreferenceDataStore
The current implementation in Thunderbird Android directly accesses the static field `K9.isHideUserAgent` to determine whether the **User-Agent** header should be removed from outgoing emails. This approach bypasses the modern PreferenceDataStore, which is the preferred... | null | https://github.com/thunderbird/thunderbird-android/pull/9423 | [
"https://github.com/thunderbird/thunderbird-android/issues/9422"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.notification.SendFailedNotificationControllerTest" --tests "com.fsck.k9.notification.NotificationContentCreatorTest" --tests "com.fsck.k9.notification.CertificateErrorNotificationControllerTest" --tests "com.fsck.k9.message.quote.QuoteDateFormatterTest" --te... | diff --git a/core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/privacy/PrivacySettings.kt b/core/preference/api/src/commonMain/kotlin/net/thunderbird/core/preference/privacy/PrivacySettings.kt
index 8ad058942a9..1f871ad4696 100644
--- a/core/preference/api/src/commonMain/kotlin/net/thunderbird/c... | diff --git a/feature/mail/message/list/src/test/kotlin/net/thunderbird/feature/mail/message/list/domain/usecase/BuildSwipeActionsTest.kt b/feature/mail/message/list/src/test/kotlin/net/thunderbird/feature/mail/message/list/domain/usecase/BuildSwipeActionsTest.kt
index 1cf0aecb62f..8f70c61a29b 100644
--- a/feature/mail/... | {
"com.fsck.k9.notification.SendFailedNotificationControllerTest.testShowSendFailedNotification": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.SummaryNotificationDataCreatorTest.inbox-style notification during quiet time": {
"run": "PASS",
"test": "NONE",
"fi... | {} | {} | {} |
thunderbird__thunderbird-android-9399 | thunderbird | thunderbird-android | 9,399 | closed | Propose a solution for #3172, initially covering long URL on mobile phone screens | Fixes #3172
This update improves readability by ensuring that long words and links in email messages wrap properly in the WebView, avoiding horizontal scrolling. In DisplayHtml.kt, the cssStylePre method now includes CSS rules for <a> tags (word-break and overflow-wrap). Additionally, the HTML and CSS generation met... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "682d7e33e72a67349c101a55c9009c661cc7e02b"
} | [
{
"number": 3172,
"title": "Wrap long lines when displaying message (text size gets too small)",
"body": "K9 doesn't warp links, which makes some e-mails very wide:\r\n\r\n**... | kotlin | Wrap long lines when displaying message (text size gets too small)
K9 doesn't warp links, which makes some e-mails very wide:
***
compared to:
:
[mail.zip](https://github.com/k9mail/k-9/files/1709841/mail.zip)
The lines marked with red on the right, have been correctly wrapped by K9.
The divider at the top (this e-mail was forwarded ... | https://github.com/thunderbird/thunderbird-android/pull/9399 | [
"https://github.com/thunderbird/thunderbird-android/issues/3172"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.message.html.DisplayHtmlTest" | diff --git a/legacy/core/src/main/java/com/fsck/k9/message/html/DisplayHtml.kt b/legacy/core/src/main/java/com/fsck/k9/message/html/DisplayHtml.kt
index a912b0940db..d098b20e486 100644
--- a/legacy/core/src/main/java/com/fsck/k9/message/html/DisplayHtml.kt
+++ b/legacy/core/src/main/java/com/fsck/k9/message/html/Displa... | diff --git a/legacy/core/src/test/java/com/fsck/k9/message/html/DisplayHtmlTest.kt b/legacy/core/src/test/java/com/fsck/k9/message/html/DisplayHtmlTest.kt
index 69620ae002c..f26b972da6a 100644
--- a/legacy/core/src/test/java/com/fsck/k9/message/html/DisplayHtmlTest.kt
+++ b/legacy/core/src/test/java/com/fsck/k9/message... | {
"com.fsck.k9.message.html.DisplayHtmlTest.wrapMessageContent_addsPreCSS": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.html.DisplayHtmlTest.wrapMessageContent_setsDirToAuto": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}
} | {
"com.fsck.k9.message.html.DisplayHtmlTest.wrapMessageContent_addsSignatureStyleRules": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.message.html.DisplayHtmlTest.wrapMessageContent_putsMessageContentInBody": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck... | {
"com.fsck.k9.message.html.DisplayHtmlTest.wrapMessageContent_addsViewportMetaElement": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
thunderbird__thunderbird-android-9398 | thunderbird | thunderbird-android | 9,398 | closed | chore(dependency): upgrade kotlinx.datetime to 0.7.0 | Resolves #9397.
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "c286b4abb651dcc0604b0c92aa77cacf1295ce7f"
} | [
{
"number": 9397,
"title": "Updated Kotlinx Datetime to 0.7.0",
"body": "Kotlinx Datetime needs to be updated to 0.7.0. There are some breaking changes listed in the Release notes that could affect our project.\n\nSee also: \n- https://github.com/Kotlin/kotlinx-datetime/releases/tag/v0.7.0\n- [Deprecati... | kotlin | Updated Kotlinx Datetime to 0.7.0
Kotlinx Datetime needs to be updated to 0.7.0. There are some breaking changes listed in the Release notes that could affect our project.
See also:
- https://github.com/Kotlin/kotlinx-datetime/releases/tag/v0.7.0
- [Deprecation of Instant](https://github.com/Kotlin/kotlinx-datetime?t... | null | https://github.com/thunderbird/thunderbird-android/pull/9398 | [
"https://github.com/thunderbird/thunderbird-android/issues/9397"
] | ./gradlew :legacy:ui:legacy:testDebugUnitTest --tests "com.fsck.k9.ui.helper.RelativeDateTimeFormatterTest" --tests "com.fsck.k9.ui.messagelist.MessageListAdapterTest" :core:common:testDebugUnitTest --tests "net.thunderbird.core.common.cache.ExpiringCacheTest" --tests "net.thunderbird.core.common.cache.CacheTest" :core... | diff --git a/app-common/src/main/kotlin/net/thunderbird/app/common/core/AppCommonCoreModule.kt b/app-common/src/main/kotlin/net/thunderbird/app/common/core/AppCommonCoreModule.kt
index f53aa9a9777..92e1c60d6b3 100644
--- a/app-common/src/main/kotlin/net/thunderbird/app/common/core/AppCommonCoreModule.kt
+++ b/app-commo... | diff --git a/core/common/src/commonTest/kotlin/net/thunderbird/core/common/cache/CacheTest.kt b/core/common/src/commonTest/kotlin/net/thunderbird/core/common/cache/CacheTest.kt
index 8409e3ce9ec..ff0ea54c86e 100644
--- a/core/common/src/commonTest/kotlin/net/thunderbird/core/common/cache/CacheTest.kt
+++ b/core/common/... | {
"net.thunderbird.core.common.cache.CacheTest.get should return null with empty cache[InMemoryCache]": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.QuietTimeCheckerTest.startTimeBeforeEndTime_timeIsAfterStartOfQuietTime": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
... | {} | {
"net.thunderbird.core.testing.TestClockTest.should return the current time": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"net.thunderbird.core.testing.TestClockTest.should return the changed time": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"net.thunderbird.core.testing.... | {} |
thunderbird__thunderbird-android-9360 | thunderbird | thunderbird-android | 9,360 | closed | feat(drawer): change drawer layout to dropdown ui | Resolves #9189
Depends on #9358
This changes the drawer ui to a true dropdown ui solution, hidden behind a feature flag.
## Main Features
1. **Unified Folder Support**:
- Added a unified account view that aggregates content from multiple accounts
- Implemented a unified inbox that shows messages fr... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "fe2effc941bad603272812f23e8d4f83066da14d"
} | [
{
"number": 9189,
"title": "Dropdown Drawer - change the account selection UI to dropdown list",
"body": "The account selection should open a dropdown list of accounts instead of the siderail.\n\n<img width=\"300\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/c3c2f9b2-b6a4-411c-af1d-f7... | kotlin | Dropdown Drawer - change the account selection UI to dropdown list
The account selection should open a dropdown list of accounts instead of the siderail.
<img width="300" alt="Image" src="https://github.com/user-attachments/assets/c3c2f9b2-b6a4-411c-af1d-f72fa0f437fe" />
<img width="300" alt="Image" src="https://gith... | null | https://github.com/thunderbird/thunderbird-android/pull/9360 | [
"https://github.com/thunderbird/thunderbird-android/issues/9189"
] | ./gradlew :feature:navigation:drawer:dropdown:testDebugUnitTest --tests "net.thunderbird.feature.navigation.drawer.dropdown.ui.DrawerViewKtTest" --tests "net.thunderbird.feature.navigation.drawer.dropdown.domain.usecase.GetDisplayFoldersForAccountTest" --tests "net.thunderbird.feature.navigation.drawer.dropdown.domain.... | diff --git a/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/icon/Icons.kt b/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/icon/Icons.kt
index b985620483d..20698343286 100644
--- a/core/ui/compose/designsystem/src/main/kotlin/app/k9ma... | diff --git a/feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/FakeData.kt b/feature/navigation/drawer/dropdown/src/debug/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/FakeData.kt
index ed1bf22c95c..029373f7ba2 100644
--- a/feature/navigation/drawer... | {
"net.thunderbird.feature.navigation.drawer.dropdown.ui.DrawerViewKtTest.should register to drawer state and send events to view model": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.navigation.drawer.dropdown.domain.usecase.GetDisplayFoldersForAccountTest.should only emi... | {} | {} | {} |
thunderbird__thunderbird-android-9332 | thunderbird | thunderbird-android | 9,332 | closed | fix(avatar): add missing storage migration to prepopulate the avatar monogram | Fixes #9330
The storage migration was missing, so the new fields couldn't be prepopulated as expected. | {
"label": "thunderbird:main",
"ref": "main",
"sha": "dd7033cb4377822fb842daf467fb3fd861c43360"
} | [
{
"number": 9330,
"title": "App Crashes Upon Navigating to Account Specific General Settings",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\... | kotlin | App Crashes Upon Navigating to Account Specific General Settings
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
12.0-SNAPSHOT
##... | The settings migration should have populated the monogram already. It seems it doesn't work. Need to investigate that.
Thanks for the finding, seems like there are two migrations necessary, one for the settings import/export and one for the preferences storage. I didn't write one for the later one, hence the fields in ... | https://github.com/thunderbird/thunderbird-android/pull/9332 | [
"https://github.com/thunderbird/thunderbird-android/issues/9330"
] | ./gradlew :legacy:storage:testDebugUnitTest --tests "com.fsck.k9.preferences.migration.StorageMigrationTo27Test" :feature:account:avatar:impl:testDebugUnitTest --tests "net.thunderbird.feature.account.avatar.DefaultAvatarMonogramCreatorTest" | diff --git a/app-common/build.gradle.kts b/app-common/build.gradle.kts
index d50b338b77e..2aa99af696c 100644
--- a/app-common/build.gradle.kts
+++ b/app-common/build.gradle.kts
@@ -25,6 +25,8 @@ dependencies {
implementation(projects.core.featureflag)
implementation(projects.core.ui.legacy.theme2.common)
+ ... | diff --git a/feature/account/avatar/impl/src/test/kotlin/net/thunderbird/feature/account/avatar/DefaultAvatarMonogramCreatorTest.kt b/feature/account/avatar/impl/src/test/kotlin/net/thunderbird/feature/account/avatar/DefaultAvatarMonogramCreatorTest.kt
new file mode 100644
index 00000000000..74a3ca93cfb
--- /dev/null
+... | {
"com.fsck.k9.preferences.migration.StorageMigrationTo27Test.avatar monogram should not be added for accounts with MONOGRAM avatar type and existing monogram": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.account.avatar.DefaultAvatarMonogramCreatorTest.create returns cor... | {} | {} | {} |
thunderbird__thunderbird-android-9299 | thunderbird | thunderbird-android | 9,299 | closed | Convert SearchResponse class from Java to Kotlin | - Fixes #9298
### Implementation Details:
- Rewrite the com.fsck.k9.mail.store.imap.SearchResponse class from Java to Kotlin using idiomatic Kotlin conventions.
- Update `com.fsck.k9.mail.store.imap.SearchResponseTest `to use AssertK assertions instead of JUnit assertions.
- Update `com.fsck.k9.mail.store.imap.... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "f4b4818b21f3faf627edb534033b1d5d246b2e4f"
} | [
{
"number": 9298,
"title": "Convert SearchResponse class from Java to Kotlin",
"body": "We should migrate the `com.fsck.k9.mail.store.imap.SearchResponse` class to Kotlin to align with the ongoing modernization efforts and Kotlin-first development approach across the codebase."
}
] | kotlin | Convert SearchResponse class from Java to Kotlin
We should migrate the `com.fsck.k9.mail.store.imap.SearchResponse` class to Kotlin to align with the ongoing modernization efforts and Kotlin-first development approach across the codebase.
| null | https://github.com/thunderbird/thunderbird-android/pull/9299 | [
"https://github.com/thunderbird/thunderbird-android/issues/9298"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.SearchResponseTest" --tests "com.fsck.k9.mail.store.imap.SearchResponseTest" | diff --git a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/SearchResponse.java b/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/SearchResponse.java
deleted file mode 100644
index 3fac2905df5..00000000000
--- a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/SearchResponse.ja... | diff --git a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/SearchResponseTest.java b/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/SearchResponseTest.java
deleted file mode 100644
index ec7bc2c7346..00000000000
--- a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/SearchRes... | {
"com.fsck.k9.mail.store.imap.SearchResponseTest.parse_withMultipleSearchResponses_shouldExtractNumbers": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.SearchResponseTest.parse_withSingleSearchResponseContainingInvalidNumber_shouldReturnEmptyList": {
"run": "PASS"... | {} | {} | {} |
thunderbird__thunderbird-android-9279 | thunderbird | thunderbird-android | 9,279 | closed | feat(drawer): add feature flag for drawer dropdown ui | Enabled for `debug` and `daily`, disabled for `beta` and `release`.
Moves shared code to a dedicated class.
Resolves #9188 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "8dbba4d87ef6de9037a373c787b8bef08693a8c4"
} | [
{
"number": 9188,
"title": "Dropdown Drawer - add feature flag to hoist ui changes",
"body": "Further drawer UI changes should be done on a new module and guarded by a feature flag.\n\nUpdate: no need to create a new module, the changes could be guarded by a feature flag inside the module."
}
] | kotlin | Dropdown Drawer - add feature flag to hoist ui changes
Further drawer UI changes should be done on a new module and guarded by a feature flag.
Update: no need to create a new module, the changes could be guarded by a feature flag inside the module.
| null | https://github.com/thunderbird/thunderbird-android/pull/9279 | [
"https://github.com/thunderbird/thunderbird-android/issues/9188"
] | ./gradlew :feature:navigation:drawer:dropdown:testDebugUnitTest --tests "net.thunderbird.feature.navigation.drawer.dropdown.ui.DrawerViewKtTest" | diff --git a/app-k9mail/src/debug/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt b/app-k9mail/src/debug/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt
index 00fe9f58f7a..c7d99ec832e 100644
--- a/app-k9mail/src/debug/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt
+++ b/app-k9mail/src/debug/kotlin/ap... | diff --git a/feature/navigation/drawer/dropdown/src/test/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerViewKtTest.kt b/feature/navigation/drawer/dropdown/src/test/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerViewKtTest.kt
index ec9150c67d1..2f31ce54a99 100644
--- a/feature/nav... | {
"net.thunderbird.feature.navigation.drawer.dropdown.ui.DrawerViewKtTest.should register to drawer state and send events to view model": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.navigation.drawer.dropdown.ui.DrawerViewKtTest.pull refresh should listen to view model s... | {} | {} | {} |
thunderbird__thunderbird-android-9268 | thunderbird | thunderbird-android | 9,268 | closed | Replace all direct usage of K9.isShowCorrespondentNames with PreferenceDataStore | - Fixes #9267 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "d3b2eaf11af50ed3a8e3f9f383f05d51a905948a"
} | [
{
"number": 9267,
"title": "Replace all direct usage of K9.isShowCorrespondentNames with PreferenceDataStore",
"body": "Goal of this issue is to replace all direct usage of` K9.isShowCorrespondentNames` withPreferenceDataStore's implementation of `GeneralSettingsDataStore`"
}
] | kotlin | Replace all direct usage of K9.isShowCorrespondentNames with PreferenceDataStore
Goal of this issue is to replace all direct usage of` K9.isShowCorrespondentNames` withPreferenceDataStore's implementation of `GeneralSettingsDataStore`
| null | https://github.com/thunderbird/thunderbird-android/pull/9268 | [
"https://github.com/thunderbird/thunderbird-android/issues/9267"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.notification.NotificationContentCreatorTest" --tests "com.fsck.k9.helper.MessageHelperTest" | diff --git a/core/preferences/src/commonMain/kotlin/net/thunderbird/core/preferences/GeneralSettings.kt b/core/preferences/src/commonMain/kotlin/net/thunderbird/core/preferences/GeneralSettings.kt
index db52ec02e0a..f06fd6ca5e5 100644
--- a/core/preferences/src/commonMain/kotlin/net/thunderbird/core/preferences/General... | diff --git a/legacy/core/src/test/java/com/fsck/k9/helper/MessageHelperTest.kt b/legacy/core/src/test/java/com/fsck/k9/helper/MessageHelperTest.kt
index 24fb41e7083..a29c84c4e33 100644
--- a/legacy/core/src/test/java/com/fsck/k9/helper/MessageHelperTest.kt
+++ b/legacy/core/src/test/java/com/fsck/k9/helper/MessageHelpe... | {
"com.fsck.k9.notification.NotificationContentCreatorTest.createFromMessage_withoutSender": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.NotificationContentCreatorTest.createFromMessage_withMessageFromSelf": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}... | {} | {} | {} |
thunderbird__thunderbird-android-9241 | thunderbird | thunderbird-android | 9,241 | closed | Handle UTF8 strings sent using literal syntax | RFC 6855/9755 permits IMAP servers to send UTF8 in strings such as "this", but does not ban sending literals such as {4}
this
instead, and some servers do, and #8772 did not handle that.
Fixes #9212 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "43c90b1c695d1b91a30df192a591dc18588e89ea"
} | [
{
"number": 9212,
"title": "Non-english folder names are displayed incorrectly",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\nK-9 Mail\n\... | kotlin | Non-english folder names are displayed incorrectly
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
K-9 Mail
### App version
Manually builded from branch main from 23.05.2... | Could you try to grab the logs at the time the login process occurs or let us know if your email server supports SMTPUTF8 ? What email provider are you using?
Does this work on Thunderbird for Android 10 and fail on main?
> your email server supports SMTPUTF8?
Yes. If you're interested, here's the `EHLO test` command... | https://github.com/thunderbird/thunderbird-android/pull/9241 | [
"https://github.com/thunderbird/thunderbird-android/issues/9212"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.RealImapStoreTest" --tests "com.fsck.k9.mail.store.imap.ImapResponseParserTest" --tests "com.fsck.k9.mail.store.imap.ImapFolderFetcherTest" --tests "com.fsck.k9.mail.store.imap.RealImapConnectionTest" --tests "com.fsck.k9.mail.store.imap.RealImapF... | diff --git a/backend/imap/src/main/java/com/fsck/k9/backend/imap/CommandRefreshFolderList.kt b/backend/imap/src/main/java/com/fsck/k9/backend/imap/CommandRefreshFolderList.kt
index 3a79960785d..f6f70b3e7bd 100644
--- a/backend/imap/src/main/java/com/fsck/k9/backend/imap/CommandRefreshFolderList.kt
+++ b/backend/imap/sr... | diff --git a/backend/imap/src/test/java/com/fsck/k9/backend/imap/TestImapStore.kt b/backend/imap/src/test/java/com/fsck/k9/backend/imap/TestImapStore.kt
index acd95b9c483..098cb8e909c 100644
--- a/backend/imap/src/test/java/com/fsck/k9/backend/imap/TestImapStore.kt
+++ b/backend/imap/src/test/java/com/fsck/k9/backend/i... | {
"com.fsck.k9.mail.store.imap.ImapResponseParserTest.readStatusResponse() with error response should throw": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapConnectionTest.open() with empty untagged ID response": {
"run": "PASS",
"test": "NONE",
"fix... | {} | {} | {} |
thunderbird__thunderbird-android-9182 | thunderbird | thunderbird-android | 9,182 | closed | Module :legacy:account migration | - Fixes #9181 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "f6de8aea9f8b72ecf20ee6b4aa78add32bb0101b"
} | [
{
"number": 9181,
"title": "Module :legacy:account migration",
"body": "- Create Android module `:core:android:account`\n- Move contents of `:legacy:account` into new module `:core:android:account`\n- Remove `:legacy:account`"
}
] | kotlin | Module :legacy:account migration
- Create Android module `:core:android:account`
- Move contents of `:legacy:account` into new module `:core:android:account`
- Remove `:legacy:account`
| null | https://github.com/thunderbird/thunderbird-android/pull/9182 | [
"https://github.com/thunderbird/thunderbird-android/issues/9181"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.message.MessageBuilderTest" --tests "com.fsck.k9.notification.NotificationDataStoreTest" --tests "com.fsck.k9.preferences.upgrader.CombinedSettingsUpgraderTo96Test" --tests "com.fsck.k9.preferences.upgrader.CombinedSettingsUpgraderTo99Test" --tests "com.fsck... | diff --git a/app-common/build.gradle.kts b/app-common/build.gradle.kts
index 03ae6b8c52c..6d196b5ee79 100644
--- a/app-common/build.gradle.kts
+++ b/app-common/build.gradle.kts
@@ -15,7 +15,7 @@ dependencies {
api(projects.feature.navigation.drawer.api)
implementation(projects.legacy.core)
- implementati... | diff --git a/app-common/src/test/kotlin/net/thunderbird/app/common/account/CommonAccountDefaultsProviderTest.kt b/app-common/src/test/kotlin/net/thunderbird/app/common/account/CommonAccountDefaultsProviderTest.kt
index ed5c374c430..589addc5e0d 100644
--- a/app-common/src/test/kotlin/net/thunderbird/app/common/account/C... | {
"com.fsck.k9.notification.SendFailedNotificationControllerTest.testShowSendFailedNotification": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.PgpMessageBuilderTest.buildSign__withNoDetachedSignatureExtra__shouldFail": {
"run": "NONE",
"test": "NONE",
"fix": "PASS... | {} | {} | {} |
thunderbird__thunderbird-android-9158 | thunderbird | thunderbird-android | 9,158 | closed | Enable creating Archive folder when swipe action is archive and account doesn't have one. | Resolves #7062. | {
"label": "thunderbird:main",
"ref": "main",
"sha": "ed37be97ece14f16889c26577420d0c5f29a6a93"
} | [
{
"number": 7062,
"title": "Not swiping when archive action is set",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.708-SNAPSHOT\... | kotlin | Not swiping when archive action is set
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.708-SNAPSHOT
### Where did you get the app from?
Other
### Android versi... | It's been a while since it was reported but just wanted to chime in to say that it still occurs on K-9 6.801
This issue is occuring on Thunderbird 8.0b2 - swiping to Archive worked for me after installing the beta initially, but the issue appeared on my device in the past couple days. All other actions work with left o... | https://github.com/thunderbird/thunderbird-android/pull/9158 | [
"https://github.com/thunderbird/thunderbird-android/issues/7062"
] | ./gradlew :feature:mail:message:list:testDebugUnitTest --tests "net.thunderbird.feature.mail.message.list.domain.usecase.SetArchiveFolderTest" --tests "net.thunderbird.feature.mail.message.list.domain.usecase.BuildSwipeActionsTest" --tests "net.thunderbird.feature.mail.message.list.FeatureMessageListModuleKtTest" --tes... | diff --git a/app-k9mail/build.gradle.kts b/app-k9mail/build.gradle.kts
index a7842fa86e2..6b22f1fa8e1 100644
--- a/app-k9mail/build.gradle.kts
+++ b/app-k9mail/build.gradle.kts
@@ -138,6 +138,7 @@ dependencies {
implementation(projects.core.ui.compose.theme2.k9mail)
implementation(projects.core.ui.legacy.them... | diff --git a/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt b/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt
index 0d6ad3db23e..ea2bc73753c 100644
--- a/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt
+++ b/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTes... | {
"com.fsck.k9.notification.NotificationContentCreatorTest.createFromMessage_withoutSender": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.mail.message.list.domain.usecase.GetAccountFoldersTest.invoke should return failure when repository throws MessagingException": {
... | {} | {} | {} |
thunderbird__thunderbird-android-9150 | thunderbird | thunderbird-android | 9,150 | closed | Add account name to general settings | Resolves #9149 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "8e2656e44679ce3425aa8cb253463c48e2c5a536"
} | [
{
"number": 9149,
"title": "Account Settings - Show account name in TopAppBar",
"body": "The account settings should display the account name as subtitle in the TopAppBar. This should also be added for the new account settings."
}
] | kotlin | Account Settings - Show account name in TopAppBar
The account settings should display the account name as subtitle in the TopAppBar. This should also be added for the new account settings.
| null | https://github.com/thunderbird/thunderbird-android/pull/9150 | [
"https://github.com/thunderbird/thunderbird-android/issues/9149"
] | ./gradlew :feature:account:settings:impl:testDebugUnitTest --tests "net.thunderbird.feature.account.settings.impl.ui.general.GeneralSettingsViewModelTest" --tests "net.thunderbird.feature.account.settings.impl.domain.usecase.GetAccountNameTest" --tests "net.thunderbird.feature.account.settings.impl.AccountSettingsModul... | diff --git a/feature/account/settings/impl/build.gradle.kts b/feature/account/settings/impl/build.gradle.kts
index e46a95ad25f..85f4ca0dee0 100644
--- a/feature/account/settings/impl/build.gradle.kts
+++ b/feature/account/settings/impl/build.gradle.kts
@@ -18,6 +18,7 @@ dependencies {
implementation(projects.core.... | diff --git a/feature/account/settings/impl/src/test/kotlin/net/thunderbird/feature/account/settings/impl/AccountSettingsModuleKtTest.kt b/feature/account/settings/impl/src/test/kotlin/net/thunderbird/feature/account/settings/impl/AccountSettingsModuleKtTest.kt
index e02d4d9944e..eb4216dd963 100644
--- a/feature/account... | {
"net.thunderbird.feature.account.settings.impl.ui.general.GeneralSettingsViewModelTest.should navigate back when back is pressed": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.account.settings.impl.domain.usecase.GetAccountNameTest.should emit account name when account ... | {} | {} | {} |
thunderbird__thunderbird-android-9137 | thunderbird | thunderbird-android | 9,137 | closed | Fixed Bug - Cannot disable New mail notifcations | - Fixes #9135 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "a8fb859a0fb8c96c2861752cea14013e7c81c3e9"
} | [
{
"number": 9135,
"title": "Cannot disable \"New mail notifcations\" in 11.0b1",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\nThunderbird... | kotlin | Cannot disable "New mail notifcations" in 11.0b1
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
11.0b1
### Where did you get the... | Can confirm, thanks for reporting!
@kewisch please assign this to me. | https://github.com/thunderbird/thunderbird-android/pull/9137 | [
"https://github.com/thunderbird/thunderbird-android/issues/9135"
] | ./gradlew :legacy:storage:testDebugUnitTest --tests "com.fsck.k9.preferences.StorageEditorTest" --tests "com.fsck.k9.preferences.StoragePersisterTest" :legacy:core:testDebugUnitTest --tests "com.fsck.k9.mailstore.K9BackendDefaultStorageTest" | diff --git a/app-common/src/main/kotlin/net/thunderbird/app/common/account/CommonAccountDefaultsProvider.kt b/app-common/src/main/kotlin/net/thunderbird/app/common/account/CommonAccountDefaultsProvider.kt
index 6340304b5fe..ac91610b935 100644
--- a/app-common/src/main/kotlin/net/thunderbird/app/common/account/CommonAcc... | diff --git a/app-common/src/test/kotlin/net/thunderbird/app/common/account/CommonAccountDefaultsProviderTest.kt b/app-common/src/test/kotlin/net/thunderbird/app/common/account/CommonAccountDefaultsProviderTest.kt
index b31bff47e5e..ed5c374c430 100644
--- a/app-common/src/test/kotlin/net/thunderbird/app/common/account/C... | {
"com.fsck.k9.mailstore.K9BackendDefaultStorageTest.writeAndReadExtraString": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.preferences.StoragePersisterTest.doInTransaction_remove": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mailstore.K9BackendDefa... | {} | {} | {} |
thunderbird__thunderbird-android-9130 | thunderbird | thunderbird-android | 9,130 | closed | Bump koin to 4.1.0 | Resolves #9129
Depends on #9128
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "cb47e0a78131c36e8322e0c85581e4af6acc9ab0"
} | [
{
"number": 9129,
"title": "Update Koin to 4.1.0",
"body": "Koin 4.1 will be released soon, for better dependency graph verification we should update as soon as the stable version is available.\n\nSee: https://github.com/InsertKoinIO/koin/releases/tag/4.1.0-Beta8"
}
] | kotlin | Update Koin to 4.1.0
Koin 4.1 will be released soon, for better dependency graph verification we should update as soon as the stable version is available.
See: https://github.com/InsertKoinIO/koin/releases/tag/4.1.0-Beta8
| null | https://github.com/thunderbird/thunderbird-android/pull/9130 | [
"https://github.com/thunderbird/thunderbird-android/issues/9129"
] | ./gradlew :app-thunderbird:testFossDebugUnitTest --tests "net.thunderbird.android.DependencyInjectionTest" :app-k9mail:testFossDebugUnitTest --tests "app.k9mail.DependencyInjectionTest" | diff --git a/app-k9mail/badging/fossRelease-badging.txt b/app-k9mail/badging/fossRelease-badging.txt
index c0c57c1a959..3d8022ec8d1 100644
--- a/app-k9mail/badging/fossRelease-badging.txt
+++ b/app-k9mail/badging/fossRelease-badging.txt
@@ -1,24 +1,10 @@
-package: name='com.fsck.k9' platformBuildVersionName='15' platfo... | diff --git a/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt b/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt
index 1d7197f291e..f94fcc2ad8a 100644
--- a/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt
+++ b/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTes... | {
"net.thunderbird.android.DependencyInjectionTest.testDependencyTree": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.DependencyInjectionTest.testDependencyTree": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}
} | {} | {} | {} |
thunderbird__thunderbird-android-9030 | thunderbird | thunderbird-android | 9,030 | closed | Add account settings profile view | Resolves #8926
<img src="https://github.com/user-attachments/assets/7fc979ed-72f8-4124-aa20-16b36e59b232" width="250em" />
Depends on #9027
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "6b991be5179083b5ba4b320381d2e9296092cf4e"
} | [
{
"number": 8926,
"title": "Account Settings - Account profile view",
"body": "The general settings page should include a preview of the account avatar."
}
] | kotlin | Account Settings - Account profile view
The general settings page should include a preview of the account avatar.
| null | https://github.com/thunderbird/thunderbird-android/pull/9030 | [
"https://github.com/thunderbird/thunderbird-android/issues/8926"
] | ./gradlew :feature:account:settings:impl:testDebugUnitTest --tests "net.thunderbird.feature.account.settings.impl.domain.usecase.UpdateGeneralPreferencesTest" --tests "net.thunderbird.feature.account.settings.impl.domain.usecase.GetGeneralPreferencesTest" | diff --git a/app-common/build.gradle.kts b/app-common/build.gradle.kts
index 9338077e3eb..43746959203 100644
--- a/app-common/build.gradle.kts
+++ b/app-common/build.gradle.kts
@@ -15,6 +15,10 @@ dependencies {
implementation(projects.legacy.account)
implementation(projects.core.featureflags)
+ implement... | diff --git a/core/ui/compose/preference/src/debug/kotlin/net/thunderbird/core/ui/compose/preference/ui/fake/FakePreferenceData.kt b/core/ui/compose/preference/src/debug/kotlin/net/thunderbird/core/ui/compose/preference/ui/fake/FakePreferenceData.kt
index a0aff575e16..f857dbbeea9 100644
--- a/core/ui/compose/preference/... | {
"net.thunderbird.feature.account.settings.impl.domain.usecase.GetGeneralPreferencesTest.should emit NotFound when account profile not found": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.account.settings.impl.domain.usecase.UpdateGeneralPreferencesTest.should update acc... | {} | {} | {} |
thunderbird__thunderbird-android-9026 | thunderbird | thunderbird-android | 9,026 | closed | Add account name setting | This adds the account name setting to the new account settings UI.
Depends on #9025
Resolves #8923 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "df45a07349c20be21bfe04a81970729bc745eb3a"
} | [
{
"number": 8923,
"title": "Account Settings - Add account name setting",
"body": "Add the existing account name setting"
}
] | kotlin | Account Settings - Add account name setting
Add the existing account name setting
| null | https://github.com/thunderbird/thunderbird-android/pull/9026 | [
"https://github.com/thunderbird/thunderbird-android/issues/8923"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.PreferencesTest" :feature:account:settings:impl:testDebugUnitTest --tests "net.thunderbird.feature.account.settings.impl.ui.general.GeneralSettingsStateTest" --tests "net.thunderbird.feature.account.settings.impl.ui.general.GeneralSettingsViewModelTest" --te... | diff --git a/app-common/build.gradle.kts b/app-common/build.gradle.kts
index 0ef3941d31b..9338077e3eb 100644
--- a/app-common/build.gradle.kts
+++ b/app-common/build.gradle.kts
@@ -9,7 +9,7 @@ android {
dependencies {
api(projects.legacy.common)
- implementation(projects.feature.account.core)
+ api(projec... | diff --git a/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt b/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt
index b13839514cc..1d7197f291e 100644
--- a/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTest.kt
+++ b/app-k9mail/src/test/kotlin/app/k9mail/DependencyInjectionTes... | {
"net.thunderbird.feature.account.settings.impl.ui.general.GeneralSettingsViewModelTest.should navigate back when back is pressed": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.feature.account.settings.impl.domain.usecase.GetGeneralPreferencesTest.should emit NotFound when accou... | {
"com.fsck.k9.PreferencesTest.reloading accounts should return same Account instance": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
thunderbird__thunderbird-android-8999 | thunderbird | thunderbird-android | 8,999 | closed | Move logging functionality to core.android.logging module | - Fixes #8975
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "d4f9cb04271d29417fb7a4a9448de6cc120a90f7"
} | [
{
"number": 8975,
"title": "Move com.fsck.k9.logging to core module",
"body": "The `com.fsck.k9.logging` functionality in the `:legacy:core` module should be moved to `:core:android:logging` and the `net.thunderbird.core.android.logging` package.\n\nAlternatively it could be moved to `:core:android:com... | kotlin | Move com.fsck.k9.logging to core module
The `com.fsck.k9.logging` functionality in the `:legacy:core` module should be moved to `:core:android:logging` and the `net.thunderbird.core.android.logging` package.
Alternatively it could be moved to `:core:android:common` and the `net.thunderbird.core.android.logging` packa... | null | https://github.com/thunderbird/thunderbird-android/pull/8999 | [
"https://github.com/thunderbird/thunderbird-android/issues/8975"
] | ./gradlew :legacy:ui:legacy:testDebugUnitTest --tests "com.fsck.k9.ui.settings.general.GeneralSettingsViewModelTest" :core:android:logging:testDebugUnitTest --tests "net.thunderbird.core.android.logging.LogcatLogFileWriterTest" | diff --git a/core/android/logging/build.gradle.kts b/core/android/logging/build.gradle.kts
new file mode 100644
index 00000000000..86a28e09ff0
--- /dev/null
+++ b/core/android/logging/build.gradle.kts
@@ -0,0 +1,12 @@
+plugins {
+ id(ThunderbirdPlugins.Library.android)
+}
+
+android {
+ namespace = "net.thunderbi... | diff --git a/legacy/core/src/test/java/com/fsck/k9/logging/LogcatLogFileWriterTest.kt b/core/android/logging/src/test/kotlin/net/thunderbird/core/android/logging/LogcatLogFileWriterTest.kt
similarity index 98%
rename from legacy/core/src/test/java/com/fsck/k9/logging/LogcatLogFileWriterTest.kt
rename to core/android/lo... | {
"net.thunderbird.core.android.logging.LogcatLogFileWriterTest.processExecutor throws": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"net.thunderbird.core.android.logging.LogcatLogFileWriterTest.write log to contentUri": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck... | {} | {} | {} |
thunderbird__thunderbird-android-8903 | thunderbird | thunderbird-android | 8,903 | closed | Fixes Unified inbox doesn't show up | - Fixes #8757
- Added tests to cover `UnifiedInboxConfigurator`'s functionality
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "2369b9a87cd2663fdec810477f1aae327042b9e7"
} | [
{
"number": 8757,
"title": "Unified inbox doesn't show up",
"body": "- [ ] ### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\nThunderbird for Android\n\... | kotlin | Unified inbox doesn't show up
- [ ] ### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
8.2
### Where did you get the app from?
Goog... | I just experienced something similar. I installed Thunderbird In my Samsung tablet running android 14. I added 3 mailboxes, no unified inbox. I did a force close, still no unified inbox. I had to force close a total of 5 times before the unified inbox showed up.
This is a bug.
Expected behavior: When setting up a sec... | https://github.com/thunderbird/thunderbird-android/pull/8903 | [
"https://github.com/thunderbird/thunderbird-android/issues/8757"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.UnifiedInboxConfiguratorTest" | diff --git a/legacy/core/src/main/java/com/fsck/k9/preferences/UnifiedInboxConfigurator.kt b/legacy/core/src/main/java/com/fsck/k9/preferences/UnifiedInboxConfigurator.kt
index ac2a2e65fce..11b308798fd 100644
--- a/legacy/core/src/main/java/com/fsck/k9/preferences/UnifiedInboxConfigurator.kt
+++ b/legacy/core/src/main/... | diff --git a/legacy/core/src/test/java/com/fsck/k9/UnifiedInboxConfiguratorTest.kt b/legacy/core/src/test/java/com/fsck/k9/UnifiedInboxConfiguratorTest.kt
new file mode 100644
index 00000000000..064bbd13e0f
--- /dev/null
+++ b/legacy/core/src/test/java/com/fsck/k9/UnifiedInboxConfiguratorTest.kt
@@ -0,0 +1,82 @@
+packa... | {} | {
"com.fsck.k9.UnifiedInboxConfiguratorTest.configureUnifiedInbox should not enable unified inbox when there are more than two accounts": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.UnifiedInboxConfiguratorTest.configureUnifiedInbox should not enable unified inbox when there are less than two accounts": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.UnifiedInboxConfiguratorTest.configureUnifiedInbox should enable unified inbox when there are exactly... | {} |
thunderbird__thunderbird-android-8889 | thunderbird | thunderbird-android | 8,889 | closed | Bump AndroidX Activity | Bump AndroidX Activity 1.9.3 -> 1.10.1 and replace custom `LocalActivity` by new official `LocalActivity`
See: https://developer.android.com/jetpack/androidx/releases/activity#1.10.1
Fixes #8938
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "058c23f6d46a2d5093a3fe98078f66638f0ac492"
} | [
{
"number": 8938,
"title": "Bump AndroidX Activity",
"body": "Bump AndroidX Activity to 1.10.1 and replace custom `LocalActivity` by new official `LocalActivity`\n\nSee: https://developer.android.com/jetpack/androidx/releases/activity#1.10.1"
}
] | kotlin | Bump AndroidX Activity
Bump AndroidX Activity to 1.10.1 and replace custom `LocalActivity` by new official `LocalActivity`
See: https://developer.android.com/jetpack/androidx/releases/activity#1.10.1
| null | https://github.com/thunderbird/thunderbird-android/pull/8889 | [
"https://github.com/thunderbird/thunderbird-android/issues/8938"
] | ./gradlew :feature:funding:googleplay:testDebugUnitTest --tests "app.k9mail.feature.funding.googleplay.ui.contribution.ContributionScreenKtTest" | diff --git a/app-k9mail/dependencies/fossReleaseRuntimeClasspath.txt b/app-k9mail/dependencies/fossReleaseRuntimeClasspath.txt
index 9b56e58c0bd..629d8aaf43b 100644
--- a/app-k9mail/dependencies/fossReleaseRuntimeClasspath.txt
+++ b/app-k9mail/dependencies/fossReleaseRuntimeClasspath.txt
@@ -1,6 +1,6 @@
-androidx.activ... | diff --git a/feature/funding/googleplay/src/test/kotlin/app/k9mail/feature/funding/googleplay/ui/contribution/ContributionScreenKtTest.kt b/feature/funding/googleplay/src/test/kotlin/app/k9mail/feature/funding/googleplay/ui/contribution/ContributionScreenKtTest.kt
index 02c978b15ee..d241a886183 100644
--- a/feature/fun... | {} | {
"app.k9mail.feature.funding.googleplay.ui.contribution.ContributionScreenKtTest.should call onBack when back button is pressed": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
thunderbird__thunderbird-android-8846 | thunderbird | thunderbird-android | 8,846 | closed | Fix drawer message count updates | This pull request fixes the update of unread and stared messages counts in the drawer.
It introduces a new `UnifiedFolderRepository` to the navigation drawer feature, along with several related changes to support updating the unread count reliably.
Fixes #8800, #7865
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "e3eab6b5fc72e0b94da103d5850a5dda30b427c3"
} | [
{
"number": 8800,
"title": "Unread message count doesn't change unless refreshed",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\nThunderbi... | kotlin | Unread message count doesn't change unless refreshed
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
8.2
### Where did you get th... | This is not fixed with #8813, seems like there is a delay in propagating the changes to the UI.
We are able to reproduce this behavior. Working on a fix. | https://github.com/thunderbird/thunderbird-android/pull/8846 | [
"https://github.com/thunderbird/thunderbird-android/issues/8800"
] | ./gradlew :feature:widget:unread:testDebugUnitTest --tests "app.k9mail.feature.widget.unread.UnreadWidgetDataProviderTest" :feature:navigation:drawer:testDebugUnitTest --tests "app.k9mail.feature.navigation.drawer.domain.usecase.GetDisplayFoldersForAccountTest" --tests "app.k9mail.feature.navigation.drawer.data.Unified... | diff --git a/feature/navigation/drawer/src/main/kotlin/app/k9mail/feature/navigation/drawer/NavigationDrawerModule.kt b/feature/navigation/drawer/src/main/kotlin/app/k9mail/feature/navigation/drawer/NavigationDrawerModule.kt
index 78ce21ee6e4..899ebadb8c4 100644
--- a/feature/navigation/drawer/src/main/kotlin/app/k9mai... | diff --git a/feature/navigation/drawer/src/test/kotlin/app/k9mail/feature/navigation/drawer/data/FakeMessageCountsProvider.kt b/feature/navigation/drawer/src/test/kotlin/app/k9mail/feature/navigation/drawer/data/FakeMessageCountsProvider.kt
new file mode 100644
index 00000000000..5cd94e1e891
--- /dev/null
+++ b/feature... | {
"app.k9mail.feature.widget.unread.UnreadWidgetDataProviderTest.nonExistentAccount_shouldReturnNull": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.navigation.drawer.data.UnifiedFolderRepositoryTest.should return DisplayUnifiedFolder for unified inbox": {
"run": "NONE",
... | {} | {} | {} |
thunderbird__thunderbird-android-8813 | thunderbird | thunderbird-android | 8,813 | closed | Add settings change notifier | This introduces a new settings change notification system to the project. The main changes include adding a publish/subscribe pattern with a broker and publisher for settings changes, updating existing classes to use this new system, and adding tests for the new functionality.
The drawer is now immediatelly updated ... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "0065813c6644f064d4fa4671512ecb2b7ff25cf0"
} | [
{
"number": 8765,
"title": "Show/Hide star count does not update immediately",
"body": "### Checklist\n\n- [x] I have used the search function to see if someone else has already submitted the same bug report.\n- [x] I will describe the problem with as much detail as possible.\n\n### App\n\nThunderbird f... | kotlin | Show/Hide star count does not update immediately
### Checklist
- [x] I have used the search function to see if someone else has already submitted the same bug report.
- [x] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
10.0-SNAPSHOT
### Where did you ... | Hi! @wmontwe I’ve been investigating the issue and here are my findings:
1.The value for show_starred_count (and other similar settings) is being updated directly via K9.isShowStarredCount in GeneralSettingsDataStore.
2.However, after the change, there doesn't seem to be any UI refresh or reactive update to reflect t... | https://github.com/thunderbird/thunderbird-android/pull/8813 | [
"https://github.com/thunderbird/thunderbird-android/issues/8765"
] | ./gradlew :legacy:preferences:testDebugUnitTest --tests "app.k9mail.legacy.preferences.DefaultSettingsChangeBrokerTest" | diff --git a/legacy/core/src/main/java/com/fsck/k9/preferences/KoinModule.kt b/legacy/core/src/main/java/com/fsck/k9/preferences/KoinModule.kt
index 41de59f552c..0000661227f 100644
--- a/legacy/core/src/main/java/com/fsck/k9/preferences/KoinModule.kt
+++ b/legacy/core/src/main/java/com/fsck/k9/preferences/KoinModule.kt... | diff --git a/legacy/preferences/src/test/java/app/k9mail/legacy/preferences/DefaultSettingsChangeBrokerTest.kt b/legacy/preferences/src/test/java/app/k9mail/legacy/preferences/DefaultSettingsChangeBrokerTest.kt
new file mode 100644
index 00000000000..99399bd450c
--- /dev/null
+++ b/legacy/preferences/src/test/java/app/... | {
"app.k9mail.legacy.preferences.DefaultSettingsChangeBrokerTest.publish should notify subscribers": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.legacy.preferences.DefaultSettingsChangeBrokerTest.unsubscribe should remove subscriber": {
"run": "NONE",
"test": "NONE",
"fix... | {} | {} | {} |
thunderbird__thunderbird-android-8804 | thunderbird | thunderbird-android | 8,804 | closed | Prefill server text field in manual account setup flow | Fixes #7552 that includes:
1. Prefill server text value when server settings are null for both incoming & outgoing server.
2. Update relevant unit tests.
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "65f1bbfa9dce6864a6f032d6c2fbce4588d4f3bd"
} | [
{
"number": 7552,
"title": "[Account setup] Prefill server text field in manual setup flow",
"body": "When the app can't find a configuration, users have to manually specify the server settings. In the past we've suggested a server name (e.g. imap.EMAILDOMAIN). The idea was to save the user time typing ... | kotlin | [Account setup] Prefill server text field in manual setup flow
When the app can't find a configuration, users have to manually specify the server settings. In the past we've suggested a server name (e.g. imap.EMAILDOMAIN). The idea was to save the user time typing the server name when there's a good chance our suggesti... | I don't know if that belongs here, but it would be very handy if tunderbird stores the previous server settings for a specific domain and reuses them when the user adds a different account with the same domain. | https://github.com/thunderbird/thunderbird-android/pull/8804 | [
"https://github.com/thunderbird/thunderbird-android/issues/7552"
] | ./gradlew :feature:account:server:settings:testDebugUnitTest --tests "app.k9mail.feature.account.server.settings.ui.incoming.IncomingServerSettingsStateMapperKtTest" --tests "app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest" | diff --git a/feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/common/EmailExtensions.kt b/feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/common/EmailExtensions.kt
new file mode 100644
index 00000000000..485045c2075
--- /dev/null... | diff --git a/feature/account/server/settings/src/test/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsStateMapperKtTest.kt b/feature/account/server/settings/src/test/kotlin/app/k9mail/feature/account/server/settings/ui/incoming/IncomingServerSettingsStateMapperKtTest.kt
index ccce424... | {
"app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest.should map to state with password from incomingServerSettings and emailDomain With dot prefix as server name when outgoingServerSettings is null": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"app.k9... | {} | {} | {} |
thunderbird__thunderbird-android-8547 | thunderbird | thunderbird-android | 8,547 | closed | Fix drawer not updating on account changes | The `Account` object uses the `uuid` for `equals` and `hasCode` only. This leads to Compose not beeing able to detect change when any other account data was changed. All necessary data is now mapped to `DisplayAccount` to properly allow Compose to detect change.
Fixes #8533 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "8668fabd5cff6cbbe630de653e490be3219ad39f"
} | [
{
"number": 8533,
"title": "Account accent color does not take effect immediately in Thunderbird Android",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.... | kotlin | Account accent color does not take effect immediately in Thunderbird Android
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App
Thunderbird for Android
### App version
8.0
... | null | https://github.com/thunderbird/thunderbird-android/pull/8547 | [
"https://github.com/thunderbird/thunderbird-android/issues/8533"
] | ./gradlew :feature:navigation:drawer:testDebugUnitTest --tests "app.k9mail.feature.navigation.drawer.ui.DrawerViewKtTest" --tests "app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest" --tests "app.k9mail.feature.navigation.drawer.ui.DrawerStateTest" | diff --git a/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt b/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt
index 9d1371d8282..e8f3870c983 100644
--- a/feature/navigation/drawer/src/debug/kotlin/app/... | diff --git a/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/FakeData.kt b/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/FakeData.kt
index 7ab5cde18f6..0d5a03a44e0 100644
--- a/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigatio... | {
"app.k9mail.feature.navigation.drawer.ui.DrawerViewKtTest.pull refresh should listen to view model state": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest.should send OpenAccount effect when OnAccountClick event is received": {
"run"... | {} | {} | {} |
thunderbird__thunderbird-android-8306 | thunderbird | thunderbird-android | 8,306 | closed | Update Turbine 0.13.0 -> 1.1.0 | Update Turbine 0.13.0 -> 1.1.0 and add `runMviTest` to combine `runTest` with `turbineScope`.
Supporting change for #8163
Resolves #7310 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "588033f1aa5b37bec23ddea44d4018af4db1c810"
} | [
{
"number": 7310,
"title": "Bump Turbine testing library and refactor `MviTurbineExtension`",
"body": "The 1.1.0 version of [Turbine](https://github.com/cashapp/turbine/releases/tag/1.1.0) was released and introduced a new `turbineScope` that needs to be used when using `testIn`. This impacts our `MviTu... | kotlin | Bump Turbine testing library and refactor `MviTurbineExtension`
The 1.1.0 version of [Turbine](https://github.com/cashapp/turbine/releases/tag/1.1.0) was released and introduced a new `turbineScope` that needs to be used when using `testIn`. This impacts our `MviTurbineExtension`, which needs to be rewritten to be comp... | null | https://github.com/thunderbird/thunderbird-android/pull/8306 | [
"https://github.com/thunderbird/thunderbird-android/issues/7310"
] | ./gradlew :feature:account:server:settings:testDebugUnitTest --tests "app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsViewModelTest" --tests "app.k9mail.feature.account.server.settings.ui.incoming.IncomingServerSettingsViewModelTest" :feature:account:setup:testDebugUnitTest --tests "app.k9m... | diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 5ede9e867ec..8e45cff5c4e 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -96,7 +96,7 @@ searchPreference = "v2.3.0"
spotlessPlugin = "6.25.0"
timber = "5.0.1"
tokenautocomplete = "4.0.0-beta01-k9mail02"
-turbine = "0.1... | diff --git a/core/ui/compose/testing/src/main/kotlin/app/k9mail/core/ui/compose/testing/mvi/EventStateTestUtil.kt b/core/ui/compose/testing/src/main/kotlin/app/k9mail/core/ui/compose/testing/mvi/EventStateTestUtil.kt
index 2895ed3acdb..d73ff168461 100644
--- a/core/ui/compose/testing/src/main/kotlin/app/k9mail/core/ui/... | {
"app.k9mail.feature.account.server.settings.ui.incoming.IncomingServerSettingsViewModelTest.should change state when UsernameChanged event is received": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.migration.qrcode.ui.QrCodeScannerViewModelTest.user successfully scans one QR... | {} | {} | {} |
thunderbird__thunderbird-android-8305 | thunderbird | thunderbird-android | 8,305 | closed | Don't allow identities without a syntactically valid email address | - Don't allow the user to enter an invalid email address in the *composition defaults* screen.
- Rewrite existing identities to make sure there's a syntactically valid email address.
Fixes #8301
Fixes #8303
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "588033f1aa5b37bec23ddea44d4018af4db1c810"
} | [
{
"number": 8301,
"title": "App crashes when I tap on \"show accounts\" in sidebar",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\... | kotlin | App crashes when I tap on "show accounts" in sidebar
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
8.0b2
### Where did you get the app from?
Google Play
### An... | Thanks for reporting this issue. I was able to reproduce it.
@Chartman123, I was wondering why this was happening and I thought it might be due to one of your accounts having no email set up or a format that our current code can't understand. We attempt to split the email at the @ sign and use the first 2 characters of... | https://github.com/thunderbird/thunderbird-android/pull/8305 | [
"https://github.com/thunderbird/thunderbird-android/issues/8301",
"https://github.com/thunderbird/thunderbird-android/issues/8303"
] | ./gradlew :legacy:storage:testDebugUnitTest --tests "com.fsck.k9.preferences.migration.StorageMigrationTo26Test" | diff --git a/legacy/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java b/legacy/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java
index 04a55d5062e..c5d1c034c29 100644
--- a/legacy/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java
+++ b/legacy/storage/src/main/... | diff --git a/legacy/storage/src/test/java/com/fsck/k9/preferences/migration/StorageMigrationTo26Test.kt b/legacy/storage/src/test/java/com/fsck/k9/preferences/migration/StorageMigrationTo26Test.kt
new file mode 100644
index 00000000000..651d1bb2a63
--- /dev/null
+++ b/legacy/storage/src/test/java/com/fsck/k9/preference... | {
"com.fsck.k9.preferences.migration.StorageMigrationTo26Test.invalid email addresses should be replaced": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.preferences.migration.StorageMigrationTo26Test.valid email addresses with additional spaces should be trimmed": {
"run": "NONE",... | {} | {} | {} |
thunderbird__thunderbird-android-8259 | thunderbird | thunderbird-android | 8,259 | closed | Fix "Sent” folder: Missing space between "To" and address | Hey!
This PR Fixes #8170.
The issue reported has a missing space between the label "To:" and contact information.
I added the space and some unit tests to test the behavior of `MessageHelper.kt`.
See
Looking ... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "49e00c47601f6c9374da8b42ff3e2576d3c8b367"
} | [
{
"number": 8170,
"title": "\"Sent” folder: Missing space between \"To\" and address",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\... | kotlin | "Sent” folder: Missing space between "To" and address
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.804
### Where did you get the app from?
None
### Android ... | Thanks for reporting, can confirm. This should be a super easy fix if all goes well, would you be interested in looking into it?
Hey!
I'm interested in contributing to this issue.
I already found a solution but I don't if a good way to solve it.
I changed the `getRecipientDisplayNames` in `MessageHelper.kt` i... | https://github.com/thunderbird/thunderbird-android/pull/8259 | [
"https://github.com/thunderbird/thunderbird-android/issues/8170"
] | ./gradlew :legacy:core:testDebugUnitTest --tests "com.fsck.k9.helper.MessageHelperTest" | diff --git a/legacy/core/src/main/java/com/fsck/k9/helper/MessageHelper.kt b/legacy/core/src/main/java/com/fsck/k9/helper/MessageHelper.kt
index a36dc77909d..b33eaec36d5 100644
--- a/legacy/core/src/main/java/com/fsck/k9/helper/MessageHelper.kt
+++ b/legacy/core/src/main/java/com/fsck/k9/helper/MessageHelper.kt
@@ -34,... | diff --git a/legacy/core/src/test/java/com/fsck/k9/helper/MessageHelperTest.kt b/legacy/core/src/test/java/com/fsck/k9/helper/MessageHelperTest.kt
index fc7d3a982cf..c07fb629e72 100644
--- a/legacy/core/src/test/java/com/fsck/k9/helper/MessageHelperTest.kt
+++ b/legacy/core/src/test/java/com/fsck/k9/helper/MessageHelpe... | {
"com.fsck.k9.helper.MessageHelperTest.testGetSenderDisplayNameWithoutShowContactNameShouldReturnCorrectOutput": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.helper.MessageHelperTest.testToFriendlyShowsPersonalPartIfItExists": {
"run": "PASS",
"test": "NONE",
"fix": "PAS... | {
"com.fsck.k9.helper.MessageHelperTest.toFriendly_nameStartingWithAtShouldNotTriggerSpoofPrevention": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.helper.MessageHelperTest.testToFriendlyWithoutCorrespondentNames": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
thunderbird__thunderbird-android-8176 | thunderbird | thunderbird-android | 8,176 | closed | Add folder drawer state | The `FolderDrawerState` is introduced to help synchronizing account and folder selection between `FolderDrawer` and `MessageList`. Like with the legacy implementation the `MessageList` will control the the selection state. To support different lifecycles the `FolderDrawer` will only store the current account uuid and f... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "9a3dbad62f77eb66d2519d7920b0d4833f70c2c6"
} | [
{
"number": 8142,
"title": "Fix account and folder selection",
"body": "The exsiting drawer has a complex setup to communicate account and folder changes between itself, the MessageList, MessageFragment and different entry points (widgets, notifications). To simplify the communication flow we decided to... | kotlin | Fix account and folder selection
The exsiting drawer has a complex setup to communicate account and folder changes between itself, the MessageList, MessageFragment and different entry points (widgets, notifications). To simplify the communication flow we decided to introduce a separate view model to keep track of the c... | null | https://github.com/thunderbird/thunderbird-android/pull/8176 | [
"https://github.com/thunderbird/thunderbird-android/issues/8142"
] | ./gradlew :feature:navigation:drawer:testDebugUnitTest --tests "app.k9mail.feature.navigation.drawer.ui.DrawerViewKtTest" --tests "app.k9mail.feature.navigation.drawer.domain.usecase.SyncAccountTest" --tests "app.k9mail.feature.navigation.drawer.ui.DrawerStateTest" --tests "app.k9mail.feature.navigation.drawer.ui.Drawe... | diff --git a/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt b/feature/navigation/drawer/src/debug/kotlin/app/k9mail/feature/navigation/drawer/ui/DrawerContentPreview.kt
index c853fb01ec5..9d1371d8282 100644
--- a/feature/navigation/drawer/src/debug/kotlin/app/... | diff --git a/feature/navigation/drawer/src/test/kotlin/app/k9mail/feature/navigation/drawer/domain/usecase/FakeAccountManager.kt b/feature/navigation/drawer/src/test/kotlin/app/k9mail/feature/navigation/drawer/domain/usecase/FakeAccountManager.kt
new file mode 100644
index 00000000000..23e4d3891b1
--- /dev/null
+++ b/f... | {
"app.k9mail.feature.navigation.drawer.ui.DrawerViewKtTest.pull refresh should listen to view model state": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest.should send OpenAccount effect when OnAccountClick event is received": {
"run"... | {} | {} | {} |
thunderbird__thunderbird-android-8166 | thunderbird | thunderbird-android | 8,166 | closed | Change drawer sync calls | Resolves #8146
Add a syn all accounts button to the side rail.
Depends on #8165 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "de81e257e8bce5e667d14f508eac21a815c196e0"
} | [
{
"number": 8146,
"title": "Improve drawer sync mechanism",
"body": "During review of #8143 it was stated that the `SyncMail` use case could be used wrongly and needs improvement. \n\nAs the `SyncMail` implementation is basically a copy paste from the existing code, it does not distinguish between synci... | kotlin | Improve drawer sync mechanism
During review of #8143 it was stated that the `SyncMail` use case could be used wrongly and needs improvement.
As the `SyncMail` implementation is basically a copy paste from the existing code, it does not distinguish between syncing a single account vs all accounts and at what point in ... | null | https://github.com/thunderbird/thunderbird-android/pull/8166 | [
"https://github.com/thunderbird/thunderbird-android/issues/8146"
] | ./gradlew :feature:navigation:drawer:testDebugUnitTest --tests "app.k9mail.feature.navigation.drawer.domain.usecase.SyncAccountTest" --tests "app.k9mail.feature.navigation.drawer.domain.usecase.SyncMailTest" --tests "app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest" --tests "app.k9mail.feature.navigation.dra... | diff --git a/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/icon/Icons.kt b/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/icon/Icons.kt
index 5e4a5861902..7be1b9d56c2 100644
--- a/core/ui/compose/designsystem/src/main/kotlin/app/k9ma... | diff --git a/feature/navigation/drawer/src/test/kotlin/app/k9mail/feature/navigation/drawer/domain/usecase/FakeMessagingControllerMailChecker.kt b/feature/navigation/drawer/src/test/kotlin/app/k9mail/feature/navigation/drawer/domain/usecase/FakeMessagingControllerMailChecker.kt
new file mode 100644
index 00000000000..4... | {
"app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest.should change state when OnAccountSelectorClick event is received": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.navigation.drawer.ui.DrawerViewModelTest.should change loading state when OnSyncAllAccounts event is ... | {} | {} | {} |
thunderbird__thunderbird-android-8107 | thunderbird | thunderbird-android | 8,107 | closed | Add support for importing settings from another app | 
Requires an app with #8099 merged to test.
Note: `SettingsProvider` checks application IDs and app signatures. So this needs to be tested with properly signed release builds (or the signature check needs to be modified/disable... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "a43527bfbf270d2e0cea63b84e4694f90fa1ccc1"
} | [
{
"number": 8101,
"title": "Extend settings screen to allow importing from other apps",
"body": "We want to allow people to import settings/accounts when switching from one of our apps to another, e.g. from K-9 Mail to Thunderbird for Android. For this we want to extend the \"Import settings\" screen to... | kotlin | Extend settings screen to allow importing from other apps
We want to allow people to import settings/accounts when switching from one of our apps to another, e.g. from K-9 Mail to Thunderbird for Android. For this we want to extend the "Import settings" screen to allow selecting an app to import the settings from.
The... | null | https://github.com/thunderbird/thunderbird-android/pull/8107 | [
"https://github.com/thunderbird/thunderbird-android/issues/8101"
] | ./gradlew :feature:settings:import:testDebugUnitTest --tests "app.k9mail.feature.settings.import.ui.SettingsImportViewModelTest" --tests "app.k9mail.feature.settings.import.ui.ImportAppFetcherTest" | diff --git a/feature/settings/import/src/main/AndroidManifest.xml b/feature/settings/import/src/main/AndroidManifest.xml
index 1303ee5e39f..4db0faac347 100644
--- a/feature/settings/import/src/main/AndroidManifest.xml
+++ b/feature/settings/import/src/main/AndroidManifest.xml
@@ -4,6 +4,14 @@
xmlns:tools="http://s... | diff --git a/feature/settings/import/src/test/kotlin/app/k9mail/feature/settings/import/ui/ImportAppFetcherTest.kt b/feature/settings/import/src/test/kotlin/app/k9mail/feature/settings/import/ui/ImportAppFetcherTest.kt
new file mode 100644
index 00000000000..a0292252fc7
--- /dev/null
+++ b/feature/settings/import/src/t... | {
"app.k9mail.feature.settings.import.ui.SettingsImportViewModelTest.pickAppButton should only be enabled after app from which we can import has been found": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.settings.import.ui.ImportAppFetcherTest.isAtLeastOneAppInstalled() without... | {} | {} | {} |
thunderbird__thunderbird-android-7978 | thunderbird | thunderbird-android | 7,978 | closed | Fix editing server settings with authentication type "None" | Fixes #7682 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "3c6a6f983e6e484368452c06f42da9cea187422d"
} | [
{
"number": 7682,
"title": "Fix support for server settings with authentication type \"None\"",
"body": "Currently we don't have an `AuthType.NONE` value that signifies that no authentication should be used (we support this for outgoing servers). The \"no authentication\" option is currently encoded by ... | kotlin | Fix support for server settings with authentication type "None"
Currently we don't have an `AuthType.NONE` value that signifies that no authentication should be used (we support this for outgoing servers). The "no authentication" option is currently encoded by using an empty username and password. However, the new serv... | This requires changes in the way we import settings files. We currently don't support rewriting old server setting values to a new format. | https://github.com/thunderbird/thunderbird-android/pull/7978 | [
"https://github.com/thunderbird/thunderbird-android/issues/7682"
] | ./gradlew :feature:account:server:settings:testDebugUnitTest --tests "app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest" :mail:protocols:smtp:test --tests "com.fsck.k9.mail.transport.smtp.SmtpTransportTest" :feature:account:common:testDebugUnitTest --tests "app.k9mail.featur... | diff --git a/app/core/src/main/java/com/fsck/k9/preferences/ServerSettingsDescriptions.kt b/app/core/src/main/java/com/fsck/k9/preferences/ServerSettingsDescriptions.kt
index 3c0fdbc14d5..c65fad1d342 100644
--- a/app/core/src/main/java/com/fsck/k9/preferences/ServerSettingsDescriptions.kt
+++ b/app/core/src/main/java/c... | diff --git a/app/core/src/test/java/com/fsck/k9/preferences/upgrader/ServerSettingsUpgraderTo95Test.kt b/app/core/src/test/java/com/fsck/k9/preferences/upgrader/ServerSettingsUpgraderTo95Test.kt
new file mode 100644
index 00000000000..49a6b3594be
--- /dev/null
+++ b/app/core/src/test/java/com/fsck/k9/preferences/upgrad... | {
"com.fsck.k9.mail.transport.smtp.SmtpTransportTest.open() with XOAUTH2 extension should throw on multiple failures": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.transport.smtp.SmtpTransportTest.open() with OAUTHBEARER method": {
"run": "PASS",
"test": "NONE",
"fix... | {} | {
"app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest.should use empty password if neither incomingServerSettings nor outgoingServerSettings contain passwords": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.feature.account.server.settings.ui.... | {} |
thunderbird__thunderbird-android-7891 | thunderbird | thunderbird-android | 7,891 | closed | Fix server settings where username or password contains line break | See https://github.com/thunderbird/thunderbird-android/issues/7855#issuecomment-2139379998 for steps on how to reproduce the crash.
Fixes #7855 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "dc5b130bda37343f26b731292640e09cdd460698"
} | [
{
"number": 7855,
"title": "Last update crashes when starting the app ",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.901\n\n##... | kotlin | Last update crashes when starting the app
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.901
### Where did you get the app from?
Google Play
### Android vers... | Uninstalling and reinstalling worked for me but I had to setup all the accounts again.
Yes, you're right, uninstalling and reinstalling again fixes the issue.
Thank you very much. | https://github.com/thunderbird/thunderbird-android/pull/7891 | [
"https://github.com/thunderbird/thunderbird-android/issues/7855"
] | ./gradlew :app:storage:testDebugUnitTest --tests "com.fsck.k9.preferences.migrations.StorageMigrationTo22Test" | diff --git a/app/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java b/app/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java
index e3f19a5c8af..a3527b4df75 100644
--- a/app/storage/src/main/java/com/fsck/k9/preferences/K9StoragePersister.java
+++ b/app/storage/src/main/java/com/fsc... | diff --git a/app/storage/src/test/java/com/fsck/k9/preferences/PreferencesDatabaseTestHelper.kt b/app/storage/src/test/java/com/fsck/k9/preferences/PreferencesDatabaseTestHelper.kt
new file mode 100644
index 00000000000..da6860d9a87
--- /dev/null
+++ b/app/storage/src/test/java/com/fsck/k9/preferences/PreferencesDataba... | {
"com.fsck.k9.preferences.migrations.StorageMigrationTo22Test.fixServerSettings() should retain values while removing line breaks from username and password": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
}
} | {} | {} | {} |
thunderbird__thunderbird-android-7699 | thunderbird | thunderbird-android | 7,699 | closed | Ignore line breaks in single line text inputs | Fixes #7670 | {
"label": "thunderbird:6.8-MAINT",
"ref": "6.8-MAINT",
"sha": "87947e1e77be83a8277e50c39d49e49d29dbee1a"
} | [
{
"number": 7670,
"title": "Don't allow passwords containing line breaks",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.717\n\n... | kotlin | Don't allow passwords containing line breaks
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.717
### Where did you get the app from?
None
### Android version
... | There is some code and tests on GitHub
https://github.com/Kopano-dev/vmime/blob/431305e11d847d93b6d67da8867d272d872c127a/tests/net/imap/IMAPParserTest.cpp#L68
`AUTH=ATOKEN` maybe means apple token. I have no idea. Seems like they have a difference in the protocol implementation
Are you using a password manager ... | https://github.com/thunderbird/thunderbird-android/pull/7699 | [
"https://github.com/thunderbird/thunderbird-android/issues/7670"
] | ./gradlew :core:ui:compose:designsystem:testDebugUnitTest --tests "app.k9mail.core.ui.compose.designsystem.atom.textfield.TextInputTextFieldTest" --tests "app.k9mail.core.ui.compose.designsystem.atom.textfield.TextFieldOutlinedKtTest" --tests "app.k9mail.core.ui.compose.designsystem.atom.textfield.TextFieldOutlinedEmai... | diff --git a/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldCommon.kt b/core/ui/compose/designsystem/src/main/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldCommon.kt
index f34727a973e..7497bc952d6 100644
--- a/core/ui/compose/designs... | diff --git a/core/ui/compose/designsystem/src/test/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldOutlinedEmailAddressKtTest.kt b/core/ui/compose/designsystem/src/test/kotlin/app/k9mail/core/ui/compose/designsystem/atom/textfield/TextFieldOutlinedEmailAddressKtTest.kt
new file mode 100644
index ... | {
"app.k9mail.core.ui.compose.designsystem.atom.textfield.TextFieldOutlinedPasswordKtTest.should display password when isPasswordVisible = true": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.core.ui.compose.designsystem.atom.textfield.TextFieldOutlinedEmailAddressKtTest.should strip l... | {
"app.k9mail.core.ui.compose.designsystem.atom.textfield.TextFieldOutlinedKtTest.should allow line breaks when isSingleLine = false": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"app.k9mail.core.ui.compose.designsystem.atom.textfield.TextFieldOutlinedEmailAddressKtTest.should call onValueChange... | {
"app.k9mail.core.ui.compose.designsystem.atom.textfield.TextFieldOutlinedKtTest.should call onValueChange when value changes with isSingleLine = true": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.core.ui.compose.designsystem.atom.textfield.TextFieldOutlinedPasswordKtTest.should dis... | {} |
thunderbird__thunderbird-android-7569 | thunderbird | thunderbird-android | 7,569 | closed | Change special folder success to loading and change navigation | Don't allow navigating back to transient special folders screen
Fixes #7553
| {
"label": "thunderbird:main",
"ref": "main",
"sha": "c665fdc0c273c3943c277e916e972609bd5c49f7"
} | [
{
"number": 7553,
"title": "[Account setup] Don't allow navigating back to transient special folders screen",
"body": "When special folders are automatically configured by the server, the user only sees transient screens (\"Fetching list of folders…\" and \"All special folders have been configured autom... | kotlin | [Account setup] Don't allow navigating back to transient special folders screen
When special folders are automatically configured by the server, the user only sees transient screens ("Fetching list of folders…" and "All special folders have been configured automatically by the server"). Currently we allow the user to c... | null | https://github.com/thunderbird/thunderbird-android/pull/7569 | [
"https://github.com/thunderbird/thunderbird-android/issues/7553"
] | ./gradlew :feature:account:setup:testDebugUnitTest --tests "app.k9mail.feature.account.setup.ui.specialfolders.SpecialFoldersScreenKtTest" --tests "app.k9mail.feature.account.setup.ui.specialfolders.SpecialFoldersViewModelTest" --tests "app.k9mail.feature.account.setup.ui.specialfolders.SpecialFoldersStateTest" | diff --git a/feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/navigation/AccountSetupNavHost.kt b/feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/navigation/AccountSetupNavHost.kt
index dc1a996e48e..f493cb07806 100644
--- a/feature/account/setup/src/main/kotlin/app/k9mail/fe... | diff --git a/feature/account/setup/src/test/kotlin/app/k9mail/feature/account/setup/ui/specialfolders/SpecialFoldersScreenKtTest.kt b/feature/account/setup/src/test/kotlin/app/k9mail/feature/account/setup/ui/specialfolders/SpecialFoldersScreenKtTest.kt
index d7ddd0cae0f..8d88bde8833 100644
--- a/feature/account/setup/s... | {
"app.k9mail.feature.account.setup.ui.specialfolders.SpecialFoldersScreenKtTest.should delegate navigation effects": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.account.setup.ui.specialfolders.SpecialFoldersViewModelTest.should delegate form events to form view model": {
... | {} | {} | {} |
thunderbird__thunderbird-android-7489 | thunderbird | thunderbird-android | 7,489 | closed | Change options screen into two screens | Fixes #7334
Fixes #7406 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "b9a7d17bba3419275e44f3935b88076b91998d8b"
} | [
{
"number": 7406,
"title": "Add new account - \"display name\" field confusing name and not optional",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n... | kotlin | Add new account - "display name" field confusing name and not optional
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.712
### Where did you get the app from?
O... | https://github.com/thunderbird/thunderbird-android/pull/7489 | [
"https://github.com/thunderbird/thunderbird-android/issues/7406",
"https://github.com/thunderbird/thunderbird-android/issues/7334"
] | ./gradlew :feature:account:setup:testDebugUnitTest --tests "app.k9mail.feature.account.setup.ui.createaccount.CreateAccountViewModelTest" --tests "app.k9mail.feature.account.setup.ui.options.display.DisplayOptionsViewModelTest" --tests "app.k9mail.feature.account.setup.domain.usecase.CreateAccountTest" --tests "app.k9m... | diff --git a/app-feature-preview/src/main/java/app/k9mail/feature/preview/account/InMemoryAccountStore.kt b/app-feature-preview/src/main/java/app/k9mail/feature/preview/account/InMemoryAccountStore.kt
index 462b75e1987..22d416bbb7f 100644
--- a/app-feature-preview/src/main/java/app/k9mail/feature/preview/account/InMemo... | diff --git a/app/k9mail/src/test/java/com/fsck/k9/account/AccountServerSettingsUpdaterTest.kt b/app/k9mail/src/test/java/com/fsck/k9/account/AccountServerSettingsUpdaterTest.kt
index 861a64b214e..6255ea3ab2e 100644
--- a/app/k9mail/src/test/java/com/fsck/k9/account/AccountServerSettingsUpdaterTest.kt
+++ b/app/k9mail/s... | {
"app.k9mail.feature.account.setup.ui.options.sync.SyncOptionsScreenKtTest.should delegate navigation effects": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.account.common.domain.entity.AuthorizationStateTest.should default to null state": {
"run": "PASS",
"test": "NO... | {} | {} | {} | |
thunderbird__thunderbird-android-7403 | thunderbird | thunderbird-android | 7,403 | closed | IMAP: Add support for untagged COPYUID responses | Fixes #7401 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "f2259c3fb0c63a402c889744bf121196a0a8492e"
} | [
{
"number": 7401,
"title": "After a message is deleted, it does not immediately appear in the Trash folder",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possibl... | kotlin | After a message is deleted, it does not immediately appear in the Trash folder
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.712
### Where did you get the app ... | null | https://github.com/thunderbird/thunderbird-android/pull/7403 | [
"https://github.com/thunderbird/thunderbird-android/issues/7401"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.UidCopyResponseTest" --tests "com.fsck.k9.mail.store.imap.RealImapFolderTest" --tests "com.fsck.k9.mail.store.imap.UidCopyResponseTest" | diff --git a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt b/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt
index 8a54f68b763..84262d4e2f1 100644
--- a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt
+++ b/mail/protocols/... | diff --git a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt b/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
index ee97f2902d1..acb4b80c57d 100644
--- a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
+++ b/mai... | {
"com.fsck.k9.mail.store.imap.UidCopyResponseTest.parse() without OK response should return null": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.moveMessages() should delete messages from source folder but not issue EXPUNGE command": {
"run": "P... | {} | {} | {} |
thunderbird__thunderbird-android-7377 | thunderbird | thunderbird-android | 7,377 | closed | Use password from incoming server for outgoing server if necessary | Once #7376 is merged, when no server settings could be found, we don't ask for the password before entering the incoming server settings screen. In that case we want the password entered there to also be used in the outgoing server settings screen.
Fixes #7360 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "1596adc0c535aea02ab16059d964b1c13475dd53"
} | [
{
"number": 7360,
"title": "Manual account setup ignores password",
"body": "When server settings discovery doesn't return any results, the app is asking for a password and then enters the manual setup flow. \r\nThe password entered in the first screen is currently not used by the incoming and outgoing ... | kotlin | Manual account setup ignores password
When server settings discovery doesn't return any results, the app is asking for a password and then enters the manual setup flow.
The password entered in the first screen is currently not used by the incoming and outgoing server settings screens. However, it should be.
| null | https://github.com/thunderbird/thunderbird-android/pull/7377 | [
"https://github.com/thunderbird/thunderbird-android/issues/7360"
] | ./gradlew :feature:account:server:settings:testDebugUnitTest --tests "app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest" | diff --git a/feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsStateMapper.kt b/feature/account/server/settings/src/main/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsStateMapper.kt
index e33ff408d25..75f211... | diff --git a/feature/account/server/settings/src/test/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsStateMapperKtTest.kt b/feature/account/server/settings/src/test/kotlin/app/k9mail/feature/account/server/settings/ui/outgoing/OutgoingServerSettingsStateMapperKtTest.kt
index 84f5a9d... | {
"app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest.should map from SMTP server settings to state": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest.should map... | {
"app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest.should use password from incomingServerSettings when outgoingServerSettings contains no password": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"app.k9mail.feature.account.server.settings.ui.outgoing... | {
"app.k9mail.feature.account.server.settings.ui.outgoing.OutgoingServerSettingsStateMapperKtTest.should map to state with email as username when server settings are null": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
thunderbird__thunderbird-android-7365 | thunderbird | thunderbird-android | 7,365 | closed | Update authorization state when editing server settings | Fixes #7293 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "9fe2c68cbcd23a8491be7b67d348b63f5b29d708"
} | [
{
"number": 7293,
"title": "Save authorization state when editing server settings",
"body": "Editing server settings could lead to sign in via OAuth 2.0. When saving server settings we also need to persist the auth state."
}
] | kotlin | Save authorization state when editing server settings
Editing server settings could lead to sign in via OAuth 2.0. When saving server settings we also need to persist the auth state.
| null | https://github.com/thunderbird/thunderbird-android/pull/7365 | [
"https://github.com/thunderbird/thunderbird-android/issues/7293"
] | ./gradlew :feature:account:edit:testDebugUnitTest --tests "app.k9mail.feature.account.edit.domain.usecase.SaveServerSettingsTest" :app:k9mail:testDebugUnitTest --tests "com.fsck.k9.account.AccountServerSettingsUpdaterTest" | diff --git a/app-feature-preview/src/main/java/app/k9mail/feature/preview/account/InMemoryAccountStore.kt b/app-feature-preview/src/main/java/app/k9mail/feature/preview/account/InMemoryAccountStore.kt
index f67e89c88f6..462b75e1987 100644
--- a/app-feature-preview/src/main/java/app/k9mail/feature/preview/account/InMemo... | diff --git a/app/k9mail/src/test/java/com/fsck/k9/account/AccountUpdaterTest.kt b/app/k9mail/src/test/java/com/fsck/k9/account/AccountServerSettingsUpdaterTest.kt
similarity index 87%
rename from app/k9mail/src/test/java/com/fsck/k9/account/AccountUpdaterTest.kt
rename to app/k9mail/src/test/java/com/fsck/k9/account/Ac... | {
"app.k9mail.feature.account.edit.domain.usecase.SaveServerSettingsTest.should get account state and update incoming server settings": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.account.AccountServerSettingsUpdaterTest.updateServerSettings() SHOULD return success with updated outg... | {} | {} | {} |
thunderbird__thunderbird-android-7340 | thunderbird | thunderbird-android | 7,340 | closed | Use `EmailAddressParser` for validating email address in account setup | Fixes #7327 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "907e315f7d7f8d23b4755785b51635d80df4ca2c"
} | [
{
"number": 7327,
"title": "Crash when creating a new email account with a & ( Ampersand ) ",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App v... | kotlin | Crash when creating a new email account with a & ( Ampersand )
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.711(37011)
### Where did you get the app from?
F... | null | https://github.com/thunderbird/thunderbird-android/pull/7340 | [
"https://github.com/thunderbird/thunderbird-android/issues/7327"
] | ./gradlew :feature:account:setup:testDebugUnitTest --tests "app.k9mail.feature.account.setup.domain.usecase.ValidateEmailAddressTest" | diff --git a/feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/domain/usecase/ValidateEmailAddress.kt b/feature/account/setup/src/main/kotlin/app/k9mail/feature/account/setup/domain/usecase/ValidateEmailAddress.kt
index 3370de6bedf..061b91daf6b 100644
--- a/feature/account/setup/src/main/kotlin/app... | diff --git a/feature/account/setup/src/test/kotlin/app/k9mail/feature/account/setup/domain/usecase/ValidateEmailAddressTest.kt b/feature/account/setup/src/test/kotlin/app/k9mail/feature/account/setup/domain/usecase/ValidateEmailAddressTest.kt
index c00d35ed701..431cfffdccc 100644
--- a/feature/account/setup/src/test/ko... | {
"app.k9mail.feature.account.setup.domain.usecase.ValidateEmailAddressTest.should fail when email address is blank": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.feature.account.setup.domain.usecase.ValidateEmailAddressTest.should fail when domain contains non-ASCII character": {
... | {} | {} | {} |
thunderbird__thunderbird-android-7299 | thunderbird | thunderbird-android | 7,299 | closed | Add onboarding screen to ask for Android permissions | This removes the old onboarding module and creates several onboarding sub modules.
- `:feature:onboarding:main` contains the navigation logic and binds the various onboarding modules together
- `:feature:onboarding:welcome` contains the welcome screen (`strings.xml` files have moved; so we need to update Weblate to p... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "29b9d1c5163b21fa462c20d352152026b24a7b85"
} | [
{
"number": 6262,
"title": "Ask for contacts permission during onboarding",
"body": "Instead of always requesting the contacts permission in the message list screen, ask during initial app setup (after the first account was successfully created). We want to avoid running into the problem where with brok... | kotlin | Ask for contacts permission during onboarding
Instead of always requesting the contacts permission in the message list screen, ask during initial app setup (after the first account was successfully created). We want to avoid running into the problem where with broken Android versions repeatedly denying the permission p... | this is really annoying
We're currently rewriting the account setup code and are not looking for external contributions implementing this feature. | https://github.com/thunderbird/thunderbird-android/pull/7299 | [
"https://github.com/thunderbird/thunderbird-android/issues/6262"
] | ./gradlew :core:android:permissions:testDebugUnitTest --tests "app.k9mail.core.android.permissions.AndroidPermissionCheckerTest" | diff --git a/app-feature-preview/build.gradle.kts b/app-feature-preview/build.gradle.kts
index 2d1beda7e45..6566d944c12 100644
--- a/app-feature-preview/build.gradle.kts
+++ b/app-feature-preview/build.gradle.kts
@@ -60,7 +60,7 @@ dependencies {
implementation(projects.core.common)
implementation(projects.mai... | diff --git a/core/android/permissions/src/test/kotlin/app/k9mail/core/android/permissions/AndroidPermissionCheckerTest.kt b/core/android/permissions/src/test/kotlin/app/k9mail/core/android/permissions/AndroidPermissionCheckerTest.kt
new file mode 100644
index 00000000000..af2ec34c383
--- /dev/null
+++ b/core/android/pe... | {
"app.k9mail.core.android.permissions.AndroidPermissionCheckerTest.denied POST_NOTIFICATIONS permission": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.core.android.permissions.AndroidPermissionCheckerTest.granted READ_CONTACTS permission[33]": {
"run": "NONE",
"test": "NONE",... | {} | {} | {} |
thunderbird__thunderbird-android-7180 | thunderbird | thunderbird-android | 7,180 | closed | Allow `<style>` tags inside the HTML body | Fixes #7163 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "e84354ca1b961c06e908ca4fbf294ce74b076f61"
} | [
{
"number": 7163,
"title": "MS Xbox Mail issue - Sanitizer deletes stylesheet",
"body": "### Checklist\r\n\r\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\r\n- [X] I will describe the problem with as much detail as possible.\r\n\r\n### App versi... | kotlin | MS Xbox Mail issue - Sanitizer deletes stylesheet
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.7.10
### Where did you get the app from?
Other
#... | > These tables are within the <head> tag which in return also makes the sanitizer create the body (too) early. (compared to the actual body tag in the mail)
This works as intended. The HTML parser creates an `html`, a `head`, and a `body` element when it encounters the first `<table>` tag.
`<style>` tags are sup... | https://github.com/thunderbird/thunderbird-android/pull/7180 | [
"https://github.com/thunderbird/thunderbird-android/issues/7163"
] | ./gradlew :app:html-cleaner:test --tests "app.k9mail.html.cleaner.HtmlSanitizerTest" | diff --git a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt b/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
index 4fb58c28522..9102f3a5ec7 100644
--- a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
+++ b/app/html-cleaner/src/main/java/app/k9mail/htm... | diff --git a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt b/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
index 51f92121374..bd818122e86 100644
--- a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
+++ b/app/html-cleaner/src/test/j... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshInHead": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepAllowedElementsInHeadAndSkipTheRest": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.c... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.should keep 'align' attribute on 'div' element": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshWithUpperCaseAttributeValue": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepUris": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.Htm... | {} |
thunderbird__thunderbird-android-7179 | thunderbird | thunderbird-android | 7,179 | closed | HTML-encode header field values when displaying message/rfc822 parts | When displaying `message/rfc822` parts, the app displays certain header fields (From, To, Subject, etc). But we forgot to HTML-encode these values. So an email address with a display name, e.g. `Sender <sender@domain.example>` was rendered as `Sender` (because everything inside `<>` is treated as an HTML tag).
This ... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "e84354ca1b961c06e908ca4fbf294ce74b076f61"
} | [
{
"number": 7165,
"title": "handling of embedded .eml files - inline vs attachment",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\... | kotlin | handling of embedded .eml files - inline vs attachment
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.7.10
### Where did you get the app from?
Other
### Andro... | Interesting fact: Thunderbird shows embedded .eml files whether they are inline or attachments
Thunderbird also allows me to save the .eml file even when it's inline (K-9 does not)
EDIT:
I just realized that mixing two html mails (inlined) will also make them share their stylesheets which might mess up the layout?... | https://github.com/thunderbird/thunderbird-android/pull/7179 | [
"https://github.com/thunderbird/thunderbird-android/issues/7165"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.mailstore.MessageViewInfoExtractorTest" | diff --git a/app/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfoExtractor.java b/app/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfoExtractor.java
index b98c801464f..8b142e594be 100644
--- a/app/core/src/main/java/com/fsck/k9/mailstore/MessageViewInfoExtractor.java
+++ b/app/core/src/main/java/com/fsc... | diff --git a/app/core/src/test/java/com/fsck/k9/mailstore/MessageViewInfoExtractorTest.java b/app/core/src/test/java/com/fsck/k9/mailstore/MessageViewInfoExtractorTest.java
index 6de424caa23..8d5a057a8a3 100644
--- a/app/core/src/test/java/com/fsck/k9/mailstore/MessageViewInfoExtractorTest.java
+++ b/app/core/src/test/... | {
"com.fsck.k9.mailstore.MessageViewInfoExtractorTest.extractMessage_withCryptoAnnotation_andExtraAttachment": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mailstore.MessageViewInfoExtractorTest.testTextPlusRfc822Message": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
... | {
"com.fsck.k9.mailstore.MessageViewInfoExtractorTest.testTextPlainFormatFlowed": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.mailstore.MessageViewInfoExtractorTest.testSimpleHtmlMessage": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mailstore.MessageViewInfoExtractorTest.testMultipartDigestWithMessages": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mailstore... | {} |
thunderbird__thunderbird-android-7113 | thunderbird | thunderbird-android | 7,113 | closed | Wrap pasted URI in angle brackets | Fixes #6756 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "2985c670982f76cf3c25b54bdb0cd8e6a5a71e2c"
} | [
{
"number": 6756,
"title": "Surround URL pasted from clipboard with angle brackets when composing a message",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same feature request.\n- [X] I will describe the problem with as much detail as p... | kotlin | Surround URL pasted from clipboard with angle brackets when composing a message
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same feature request.
- [X] I will describe the problem with as much detail as possible.
- [X] This issue only contains a request for one ... | @cketti In the case that the user pastes in some texts with a link like `This is a link https://link.com` do we convert the text to `This is a link <https://link.com>` or the angle brackets should only be added when a link is pasted with no other text like `https://link.com`.
Should I also handle linked without the `h... | https://github.com/thunderbird/thunderbird-android/pull/7113 | [
"https://github.com/thunderbird/thunderbird-android/issues/6756"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.message.html.UriMatcherTest" | diff --git a/app/core/src/main/java/com/fsck/k9/message/html/UriMatcher.kt b/app/core/src/main/java/com/fsck/k9/message/html/UriMatcher.kt
index 891bb58524f..b970b83c3bd 100644
--- a/app/core/src/main/java/com/fsck/k9/message/html/UriMatcher.kt
+++ b/app/core/src/main/java/com/fsck/k9/message/html/UriMatcher.kt
@@ -31,... | diff --git a/app/core/src/test/java/com/fsck/k9/message/html/UriMatcherTest.kt b/app/core/src/test/java/com/fsck/k9/message/html/UriMatcherTest.kt
index fd0b02ecd34..16ef2dcdcfa 100644
--- a/app/core/src/test/java/com/fsck/k9/message/html/UriMatcherTest.kt
+++ b/app/core/src/test/java/com/fsck/k9/message/html/UriMatche... | {
"com.fsck.k9.message.html.UriMatcherTest.uriEmbeddedInText": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.html.UriMatcherTest.uriPrecededBySomeText": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.html.UriMatcherTest.simpleUri": {
... | {} | {} | {} |
thunderbird__thunderbird-android-6946 | thunderbird | thunderbird-android | 6,946 | closed | Fix recipients being displayed multiple times | The problem was caused by inconsistent email address equality checks. This change leaves the comparison to `Account.isAnIdentity()`.
Fixes #6933 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "2d0a11aab58df757811f3020c46a9daabf9b4219"
} | [
{
"number": 6933,
"title": "Recipients matching an identity email address with mismatched case are displayed multiple times",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much ... | kotlin | Recipients matching an identity email address with mismatched case are displayed multiple times
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.704
### Where did... | null | https://github.com/thunderbird/thunderbird-android/pull/6946 | [
"https://github.com/thunderbird/thunderbird-android/issues/6933"
] | ./gradlew :app:ui:legacy:testDebugUnitTest --tests "com.fsck.k9.ui.messageview.DisplayRecipientsExtractorTest" | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/DisplayRecipientsExtractor.kt b/app/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/DisplayRecipientsExtractor.kt
index 95a10e4925f..d56e02eadbb 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/ui/messageview/DisplayRecipientsExtractor.kt
+++ b/... | diff --git a/app/ui/legacy/src/test/java/com/fsck/k9/ui/messageview/DisplayRecipientsExtractorTest.kt b/app/ui/legacy/src/test/java/com/fsck/k9/ui/messageview/DisplayRecipientsExtractorTest.kt
index 1ed5ec70658..3ede76992d2 100644
--- a/app/ui/legacy/src/test/java/com/fsck/k9/ui/messageview/DisplayRecipientsExtractorTe... | {
"com.fsck.k9.ui.messageview.DisplayRecipientsExtractorTest.single recipient without name and not a contact": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.ui.messageview.DisplayRecipientsExtractorTest.single recipient is identity address with different local part and domain case": {... | {
"com.fsck.k9.ui.messageview.DisplayRecipientsExtractorTest.three unknown recipients": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.ui.messageview.DisplayRecipientsExtractorTest.single recipient is a contact": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fs... | {
"com.fsck.k9.ui.messageview.DisplayRecipientsExtractorTest.recipients spread across To and Cc header": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
thunderbird__thunderbird-android-6846 | thunderbird | thunderbird-android | 6,846 | closed | Add ID command for IMAP | Fixes #5089
This PR is based on the implementation of `useCompression` and PR #5578.
I have tested this PR on Netease mail, which requires the ID extension. It works as expected. | {
"label": "thunderbird:main",
"ref": "main",
"sha": "6e27fe5c84f7d83e9943e11b0dc0fa3cc1d8a9cf"
} | [
{
"number": 5089,
"title": "Add support for ID command to support 163.com",
"body": "**Is your feature request related to a problem? Please describe.**\r\nI got rejected receiving mails using imap. I was trying to log in to 163 email server when this happens.\r\n\r\n**Describe the solution you'd like**\... | kotlin | Add support for ID command to support 163.com
**Is your feature request related to a problem? Please describe.**
I got rejected receiving mails using imap. I was trying to log in to 163 email server when this happens.
**Describe the solution you'd like**
I was told that the email client app should return its ident... | This code can be used to fool 163 before k9 supports the id command,
com.fsck.k9.mail.store.imap.RealImapConnection#open
```
if (hasCapability("ID")) {
executeSimpleCommand("ID (\"name\" \"k-9\" \"version\" \"6.000\")");
}
```
![image](https://user-images.githubuserconte... | https://github.com/thunderbird/thunderbird-android/pull/6846 | [
"https://github.com/thunderbird/thunderbird-android/issues/5089"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.RealImapStoreTest" --tests "com.fsck.k9.mail.store.imap.RealImapConnectionTest" | diff --git a/app/core/src/main/java/com/fsck/k9/Account.kt b/app/core/src/main/java/com/fsck/k9/Account.kt
index b5ad45f9c8d..0c585eb0f91 100644
--- a/app/core/src/main/java/com/fsck/k9/Account.kt
+++ b/app/core/src/main/java/com/fsck/k9/Account.kt
@@ -232,6 +232,10 @@ class Account(override val uuid: String) : BaseAcc... | diff --git a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapConnectionTest.kt b/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapConnectionTest.kt
index d1d236687a8..b56a1ca1f5d 100644
--- a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapConnectionTest.... | {
"com.fsck.k9.mail.store.imap.RealImapStoreTest.getConnection() with connection in pool and closeAllConnections() should return new ImapConnection instance": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapConnectionTest.open() with NAMESPACE capability should i... | {} | {} | {} |
thunderbird__thunderbird-android-6840 | thunderbird | thunderbird-android | 6,840 | closed | Increase number of active notifications to 9 | This way users can know that when the number 9 is displayed in the group summary, there's more notifications than the 8 they can currently see.
Fixes #6820 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "0d24dcd28aecdecca0fd778919fbdadddfb543a8"
} | [
{
"number": 6820,
"title": "more than 8 new messages always says there are only 8 new messages in notification",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as pos... | kotlin | more than 8 new messages always says there are only 8 new messages in notification
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.511
### Where did you get the ... | Since Android doesn't display more than 8 notifications per group, the app never creates more than 8 system notifications per account. K-9 Mail does keep track of all new messages and will create new system notifications as needed (i.e. when one or more of the existing notifications has been dismissed).
The total nu... | https://github.com/thunderbird/thunderbird-android/pull/6840 | [
"https://github.com/thunderbird/thunderbird-android/issues/6820"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.notification.NotificationDataStoreTest" | diff --git a/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt b/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt
index b9f63f3bba4..f3e80d344e9 100644
--- a/app/core/src/main/java/com/fsck/k9/notification/NotificationDataStore.kt
+++ b/app/core/src/main/java/com/fsck/k9/n... | diff --git a/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt b/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt
index 3e1d869b074..781acaf6554 100644
--- a/app/core/src/test/java/com/fsck/k9/notification/NotificationDataStoreTest.kt
+++ b/app/core/src/test/java/c... | {
"com.fsck.k9.notification.NotificationDataStoreTest.testNewMessagesCount": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.notification.NotificationDataStoreTest.adding notification for message with active notification should update notification": {
"run": "PASS",
"test": "NON... | {
"com.fsck.k9.notification.NotificationDataStoreTest.testGetHolderForLatestNotification": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.notification.NotificationDataStoreTest.remove all notifications": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.not... | {
"com.fsck.k9.notification.NotificationDataStoreTest.testRemoveDoesNotLeakNotificationIds": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
thunderbird__thunderbird-android-6811 | thunderbird | thunderbird-android | 6,811 | closed | Add support for signature delimiters using non-breaking space in HTML parts | Closes #6808 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "549d31ac62134af9723b00ccee460551c4f9f5bb"
} | [
{
"number": 6808,
"title": "Recognize `-- ` as signature delimiter",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same feature request.\n- [X] I will describe the problem with as much detail as possible.\n- [X] This issue only cont... | kotlin | Recognize `-- ` as signature delimiter
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same feature request.
- [X] I will describe the problem with as much detail as possible.
- [X] This issue only contains a request for one single feature, **not** multiple (re... | K-9 Mail currently doesn't try to detect signatures in HTML parts at all. So even if Fastmail were using `-- ` as separator, it wouldn't help.
It does at least strip them on replies (#6279 / https://github.com/thundernest/k-9/blob/main/app/core/src/test/java/com/fsck/k9/message/signature/HtmlSignatureRemoverTest.kt), r... | https://github.com/thunderbird/thunderbird-android/pull/6811 | [
"https://github.com/thunderbird/thunderbird-android/issues/6808"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.message.signature.HtmlSignatureRemoverTest" | diff --git a/app/core/src/main/java/com/fsck/k9/message/signature/HtmlSignatureRemover.kt b/app/core/src/main/java/com/fsck/k9/message/signature/HtmlSignatureRemover.kt
index 07746c20dcb..d7a0de6b472 100644
--- a/app/core/src/main/java/com/fsck/k9/message/signature/HtmlSignatureRemover.kt
+++ b/app/core/src/main/java/c... | diff --git a/app/core/src/test/java/com/fsck/k9/message/signature/HtmlSignatureRemoverTest.kt b/app/core/src/test/java/com/fsck/k9/message/signature/HtmlSignatureRemoverTest.kt
index a8c79c7758e..932f192ae85 100644
--- a/app/core/src/test/java/com/fsck/k9/message/signature/HtmlSignatureRemoverTest.kt
+++ b/app/core/src... | {
"com.fsck.k9.message.signature.HtmlSignatureRemoverTest.should not strip signature inside blockquote tag": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.signature.HtmlSignatureRemoverTest.K-9 Mail signature format": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
... | {
"com.fsck.k9.message.signature.HtmlSignatureRemoverTest.old Thunderbird signature format": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.message.signature.HtmlSignatureRemoverTest.signature between blockquote tags": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.message.signature.HtmlSignatureRemoverTest.signature before blockquote tag": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.message.signature.HtmlSignatureRemoverTest.old K-9 Mail signature format": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
thunderbird__thunderbird-android-6762 | thunderbird | thunderbird-android | 6,762 | closed | IMAP: Ignore errors during LOGIN fallback | From the log in #6744 I reconstructed that the communication with the IMAP server went like this (simplified):
```text
…
C: 2 AUTHENTICATE PLAIN [credentials]
S: 2 NO AUTHENTICATE failed
C: 3 LOGIN [credentials]
S: * BYE IMAP server terminating connection
S: [server closes connection]
```
We have code to f... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "730825bce30a6eef522395d1b4fe3edae78da206"
} | [
{
"number": 6744,
"title": "Not prompting for new password when changed elsewhere",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n... | kotlin | Not prompting for new password when changed elsewhere
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.509
### Where did you get the app from?
Google Play
### A... | K-9 Mail should display an error notification in that case. Can you record a debug log while trying to sync a folder after changing the password outside of K-9 Mail.
See https://github.com/thundernest/k-9/wiki/LoggingErrors
Hi, thanks for having a look. It does not display anything. Log attached, the mailbox with c... | https://github.com/thunderbird/thunderbird-android/pull/6762 | [
"https://github.com/thunderbird/thunderbird-android/issues/6744"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.ResponseTextExtractorTest" --tests "com.fsck.k9.mail.store.imap.RealImapConnectionTest" | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupCheckSettings.kt b/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupCheckSettings.kt
index 1ac11bffd19..96dc2f9cb06 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/activity/setup/AccountSetupCheckSettings.kt
+++ b/app... | diff --git a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapConnectionTest.kt b/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapConnectionTest.kt
index 2cebadbaf5f..d5b019df723 100644
--- a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapConnectionTest.... | {
"com.fsck.k9.mail.store.imap.RealImapConnectionTest.open() AUTH EXTERNAL": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapConnectionTest.open() with NAMESPACE capability should issue NAMESPACE command": {
"run": "PASS",
"test": "NONE",
"fix": "PASS... | {} | {} | {} |
thunderbird__thunderbird-android-6693 | thunderbird | thunderbird-android | 6,693 | closed | Tweak message list design (2) | - Make sure there's space between subject and date
- Add en dash to separate sender name and preview text
- Use different text colors for read and unread messages
- Display date in same style as subject
|Before|After|
|-|-|
|![image](https://user-images.githubusercontent.com/218061/220365973-bbda6a4e-7076-4ff6-... | {
"label": "thunderbird:main",
"ref": "main",
"sha": "bcae08ec106ffee48c2c2d8ddfd0bc93bfa488ef"
} | [
{
"number": 4110,
"title": "Message list appearance",
"body": "Right now the message list looks very dated. To move to a more modern look I suggest the following changes:\n\n- [x] For unread messages display subject, sender (and possibly the date) in bold. See #4189\n- [x] Don't change the background co... | kotlin | Message list appearance
Right now the message list looks very dated. To move to a more modern look I suggest the following changes:
- [x] For unread messages display subject, sender (and possibly the date) in bold. See #4189
- [x] Don't change the background color for unread messages by default, i.e. make 'General set... | Could I also suggest
[ ] Use pastel colours for placeholder contact images
[ ] Shorten grey line between successive messages
to attempt more parity with #1859 (which I presume is the design brief we are heading towards).
In this vein, I don't think that making the sender and subject preview text colour will be ... | https://github.com/thunderbird/thunderbird-android/pull/6693 | [
"https://github.com/thunderbird/thunderbird-android/issues/4110",
"https://github.com/thunderbird/thunderbird-android/issues/6692"
] | ./gradlew :app:ui:legacy:testDebugUnitTest --tests "com.fsck.k9.ui.messagelist.MessageListAdapterTest" | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListAdapter.kt b/app/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListAdapter.kt
index 50166b3af4d..687e6d3435a 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListAdapter.kt
+++ b/app/ui/legacy/src/main/j... | diff --git a/app/ui/legacy/src/test/java/com/fsck/k9/ui/messagelist/MessageListAdapterTest.kt b/app/ui/legacy/src/test/java/com/fsck/k9/ui/messagelist/MessageListAdapterTest.kt
index 1d4f9f810ea..d3ed1221a4c 100644
--- a/app/ui/legacy/src/test/java/com/fsck/k9/ui/messagelist/MessageListAdapterTest.kt
+++ b/app/ui/legac... | {
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withoutSenderAboveSubjectAndNonDefaultFontSize_shouldSetTextSizeOfFirstLineView": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withSenderAboveSubject_shouldShowDisplayNameInFirstLine": {
"r... | {
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.previewWithDefaultFontSize_shouldNotSetTextSizeOfSecondLineView": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withThreadCountOne_shouldHideThreadCountView": {
"run": "PASS",
"test": "F... | {
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withSenderAboveSubjectAndDefaultFontSize_shouldNotSetTextSizeOfFirstLineView": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withoutSenderAboveSubjectAndZeroPreviewLines_shouldShowDisplayNameInS... | {} |
thunderbird__thunderbird-android-6624 | thunderbird | thunderbird-android | 6,624 | closed | Fetch BCC header when only partially downloading a message | Fixes #6622 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "180626c739bf0325d759dca2b277ac6097fec1ac"
} | [
{
"number": 6622,
"title": "BCC header isn't fetched when partial message is downloaded",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App versi... | kotlin | BCC header isn't fetched when partial message is downloaded
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.505
### Where did you get the app from?
None
### An... | null | https://github.com/thunderbird/thunderbird-android/pull/6624 | [
"https://github.com/thunderbird/thunderbird-android/issues/6622"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.RealImapFolderTest" | diff --git a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt b/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt
index a74271c2ef2..472c054a1b9 100644
--- a/mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/RealImapFolder.kt
+++ b/mail/protocols/... | diff --git a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt b/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
index b1beda25bdc..ff3e5b6dfd6 100644
--- a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
+++ b/mai... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.fetch_withBodyFetchProfileAndNoMaximumDownloadSize_shouldIssueRespectiveCommand": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.getMessagesFromUids": {
"run": "PASS",
"test": "NONE",
"fix"... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_readWrite_shouldOpenFolder": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.getUidFromMessageId_withMessageIdHeader_shouldIssueUidSearchCommand": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_withMessagingException_shouldThrowMessagingException": {
"run": "PASS",
... | {} |
thunderbird__thunderbird-android-6618 | thunderbird | thunderbird-android | 6,618 | closed | Add the redesigned message view screen | This merges the `message-view-redesign` branch into `main`. The current state should be stable enough to be included in a beta build.
Closes #6198 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "c93f5ea79923dd656688ed2ce1f6ffe2a4d1b096"
} | [
{
"number": 6198,
"title": "Message view redesign",
"body": "We're currently working on a new design for the message view. A (non-final) preview can be seen below.\r\n\r\n### Current state\r\n\r\n<img src=\"https://user-images.githubusercontent.com/218061/190913295-709ad7d1-5f93-407a-a4b3-1fc2ae91f53c.p... | kotlin | Message view redesign
We're currently working on a new design for the message view. A (non-final) preview can be seen below.
### Current state
<img src="https://user-images.githubusercontent.com/218061/190913295-709ad7d1-5f93-407a-a4b3-1fc2ae91f53c.png" alt="image" width=300>
### Preview
![Message header - ... | What do you think about moving the "Load Images" button above the Line of Death? Granted, showing images is already loading offsite resources, _but_ it's not potentially taking you in your browser to some arbitrary link.
I imagine someone could CSS up a link that looks pretty close (although not exactly) like your b... | https://github.com/thunderbird/thunderbird-android/pull/6618 | [
"https://github.com/thunderbird/thunderbird-android/issues/6198"
] | ./gradlew :app:ui:legacy:testDebugUnitTest --tests "com.fsck.k9.ui.messageview.DisplayRecipientsExtractorTest" --tests "com.fsck.k9.ui.messageview.RecipientLayoutCreatorTest" --tests "com.fsck.k9.view.MessageHeaderTest" :app:core:testDebugUnitTest --tests "com.fsck.k9.message.ReplyActionStrategyTest" --tests "com.fsck.... | diff --git a/app/core/build.gradle b/app/core/build.gradle
index 9c8ca307969..46bba048477 100644
--- a/app/core/build.gradle
+++ b/app/core/build.gradle
@@ -25,6 +25,7 @@ dependencies {
implementation libs.moshi
implementation libs.timber
implementation libs.mime4j.core
+ implementation libs.mime4j.do... | diff --git a/app/core/src/test/java/com/fsck/k9/helper/RealAddressFormatterTest.kt b/app/core/src/test/java/com/fsck/k9/helper/RealAddressFormatterTest.kt
new file mode 100644
index 00000000000..726ee33e6a5
--- /dev/null
+++ b/app/core/src/test/java/com/fsck/k9/helper/RealAddressFormatterTest.kt
@@ -0,0 +1,206 @@
+pack... | {
"com.fsck.k9.helper.RealAddressFormatterTest.identity without a description": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.helper.RealAddressFormatterTest.email address without display name": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_readWrite_shouldOpenFolder": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.getUidFromMessageId_withMessageIdHeader_shouldIssueUidSearchCommand": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_withMessagingException_shouldThrowMessagingException": {
"run": "PASS",
... | {} |
thunderbird__thunderbird-android-6600 | thunderbird | thunderbird-android | 6,600 | closed | Message View Redesign: Add bottom sheet (2) | There are still a few things missing:
- #6597
- #6598
- #6599
But this PR is already way too large. So the rest will be added in follow-up PRs.
https://user-images.githubusercontent.com/218061/214107017-dacc603e-0e7a-44ad-b2a0-fe8eac0e4ad5.mp4
Closes #6393 | {
"label": "thunderbird:message-view-redesign",
"ref": "message-view-redesign",
"sha": "7dd0ed79c4734cb1454ec8a028e6610ac3871496"
} | [
{
"number": 6393,
"title": "Message View Redesign: Add bottom sheet",
"body": "To display details about the sender and all recipients of a message, we want to display a bottom sheet (that can be dragged up to use the full screen height).\r\n\r\n.
![Message header - Bottom Drawer HiFi](https://user-images.githubusercontent.com/218061/195583719-55fc6947-9e34-4add-8... | null | https://github.com/thunderbird/thunderbird-android/pull/6600 | [
"https://github.com/thunderbird/thunderbird-android/issues/6393"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.RealImapFolderTest" :app:storage:testDebugUnitTest --tests "com.fsck.k9.storage.messages.RetrieveMessageOperationsTest" | diff --git a/app/core/build.gradle b/app/core/build.gradle
index 9c8ca307969..46bba048477 100644
--- a/app/core/build.gradle
+++ b/app/core/build.gradle
@@ -25,6 +25,7 @@ dependencies {
implementation libs.moshi
implementation libs.timber
implementation libs.mime4j.core
+ implementation libs.mime4j.do... | diff --git a/app/storage/src/test/java/com/fsck/k9/storage/messages/RetrieveMessageOperationsTest.kt b/app/storage/src/test/java/com/fsck/k9/storage/messages/RetrieveMessageOperationsTest.kt
index 09dccb31d70..09246c3cb30 100644
--- a/app/storage/src/test/java/com/fsck/k9/storage/messages/RetrieveMessageOperationsTest.... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.fetch_withBodyFetchProfileAndNoMaximumDownloadSize_shouldIssueRespectiveCommand": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.getMessagesFromUids": {
"run": "PASS",
"test": "NONE",
"fix"... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_readWrite_shouldOpenFolder": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.getUidFromMessageId_withMessageIdHeader_shouldIssueUidSearchCommand": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_withMessagingException_shouldThrowMessagingException": {
"run": "PASS",
... | {} |
thunderbird__thunderbird-android-6588 | thunderbird | thunderbird-android | 6,588 | closed | Keep `<base>` element | Fixes #6587 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "f3ac66e64296fc82127d984e9e697741e04dd75a"
} | [
{
"number": 6587,
"title": "Relative link and `<base>` tag",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.502\n\n### Where did ... | kotlin | Relative link and `<base>` tag
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.502
### Where did you get the app from?
None
### Android version
doesn't matter... | null | https://github.com/thunderbird/thunderbird-android/pull/6588 | [
"https://github.com/thunderbird/thunderbird-android/issues/6587"
] | ./gradlew :app:html-cleaner:test --tests "app.k9mail.html.cleaner.HtmlSanitizerTest" | diff --git a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/HeadCleaner.kt b/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/HeadCleaner.kt
index d9ac70f810c..1485291428d 100644
--- a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/HeadCleaner.kt
+++ b/app/html-cleaner/src/main/java/app/k9mail/htm... | diff --git a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt b/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
index d60ae8b3812..90250000671 100644
--- a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
+++ b/app/html-cleaner/src/test/j... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshInHead": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.should keep 'kbd' element": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizer... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.should keep 'align' attribute on 'div' element": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshWithUpperCaseAttributeValue": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepUris": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.Htm... | {} |
thunderbird__thunderbird-android-6555 | thunderbird | thunderbird-android | 6,555 | closed | Change `WorkManager` initialization | This should fix #6553. | {
"label": "thunderbird:main",
"ref": "main",
"sha": "a7c4744fe1ba35595deed0ef14fcec3e793fab02"
} | [
{
"number": 6553,
"title": "Crash because WorkManager isn't initialized properly",
"body": "Stack trace retrieved via Google Play Console:\r\n\r\n```text\r\nException java.lang.RuntimeException: Unable to create service androidx.work.impl.background.systemjob.SystemJobService: java.lang.IllegalStateExce... | kotlin | Crash because WorkManager isn't initialized properly
Stack trace retrieved via Google Play Console:
```text
Exception java.lang.RuntimeException: Unable to create service androidx.work.impl.background.systemjob.SystemJobService: java.lang.IllegalStateException: WorkManager needs to be initialized via a ContentProvi... | null | https://github.com/thunderbird/thunderbird-android/pull/6555 | [
"https://github.com/thunderbird/thunderbird-android/issues/6553"
] | ./gradlew :app:k9mail:testDebugUnitTest --tests "com.fsck.k9.DependencyInjectionTest" | diff --git a/app/core/src/main/java/com/fsck/k9/job/K9WorkerFactory.kt b/app/core/src/main/java/com/fsck/k9/job/K9WorkerFactory.kt
index adcb9258812..71af4cbf3da 100644
--- a/app/core/src/main/java/com/fsck/k9/job/K9WorkerFactory.kt
+++ b/app/core/src/main/java/com/fsck/k9/job/K9WorkerFactory.kt
@@ -4,23 +4,16 @@ impor... | diff --git a/app/core/src/test/java/com/fsck/k9/TestApp.kt b/app/core/src/test/java/com/fsck/k9/TestApp.kt
index b365bd4ddc5..7f6f0f88677 100644
--- a/app/core/src/test/java/com/fsck/k9/TestApp.kt
+++ b/app/core/src/test/java/com/fsck/k9/TestApp.kt
@@ -1,6 +1,7 @@
package com.fsck.k9
import android.app.Application
... | {
"com.fsck.k9.DependencyInjectionTest.testDependencyTree": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}
} | {} | {} | {} |
thunderbird__thunderbird-android-6546 | thunderbird | thunderbird-android | 6,546 | closed | Add `GenericUriParser` | Remove support for linkifying `bitcoin:` and `ethereum:` URIs. The time where crypto currencies were a harmless playground for nerds are long gone.
Add a `UriParser` that matches generic URIs. We can use this to support linkifying arbitrary URI schemes. See #6545.
Closes #2265 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "49ac22288654073df0ab393978a630be74347c32"
} | [
{
"number": 2265,
"title": "Add support for linkifying more URI schemes",
"body": "We currently linkify HTTP URLs and Bitcoin URIs when converting plain text to HTML. It'd be nice to have support for additional URI schemes. See #684.\r\n\r\n* `bridge:` - Tor bridge\r\n* `geo:` - Physical location\r\n* `... | kotlin | Add support for linkifying more URI schemes
We currently linkify HTTP URLs and Bitcoin URIs when converting plain text to HTML. It'd be nice to have support for additional URI schemes. See #684.
* `bridge:` - Tor bridge
* `geo:` - Physical location
* `market:` - Link to app in Google Play (previously Android Marke... | I will like to give this a try. Can I work on this?
@karishnu: This issue is probably not suitable for a beginner.
We could add a generic URI ([RFC 3986](https://datatracker.ietf.org/doc/html/rfc3986)) parser and allow the user to specify which URI schemes they want to have linkified. | https://github.com/thunderbird/thunderbird-android/pull/6546 | [
"https://github.com/thunderbird/thunderbird-android/issues/2265"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.message.html.BitcoinUriParserTest" --tests "com.fsck.k9.message.html.EthereumUriParserTest" --tests "com.fsck.k9.message.html.GenericUriParserTest" | diff --git a/app/core/src/main/java/com/fsck/k9/message/html/BitcoinUriParser.java b/app/core/src/main/java/com/fsck/k9/message/html/BitcoinUriParser.java
deleted file mode 100644
index 632231a00a4..00000000000
--- a/app/core/src/main/java/com/fsck/k9/message/html/BitcoinUriParser.java
+++ /dev/null
@@ -1,29 +0,0 @@
-p... | diff --git a/app/core/src/test/java/com/fsck/k9/message/html/BitcoinUriParserTest.java b/app/core/src/test/java/com/fsck/k9/message/html/BitcoinUriParserTest.java
deleted file mode 100644
index 0478024cefe..00000000000
--- a/app/core/src/test/java/com/fsck/k9/message/html/BitcoinUriParserTest.java
+++ /dev/null
@@ -1,7... | {
"com.fsck.k9.message.html.GenericUriParserTest.matrix URIs": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.html.GenericUriParserTest.XMPP URIs": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.html.GenericUriParserTest.mailto URIs": {
... | {} | {} | {} |
thunderbird__thunderbird-android-6486 | thunderbird | thunderbird-android | 6,486 | closed | Add support for search in recipient addresses | Closes #1127 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "de891243f148e81617c32aba9d655ec7806adc99"
} | [
{
"number": 1127,
"title": "Support search in recipient addresses",
"body": "When I search my inbox for, let's say, `current@freebsd` mails with `current@freebsd.org` in CC won't show up.\nWith lists were cross-posting is rather common this is a bit annoying.\n"
}
] | kotlin | Support search in recipient addresses
When I search my inbox for, let's say, `current@freebsd` mails with `current@freebsd.org` in CC won't show up.
With lists were cross-posting is rather common this is a bit annoying.
| Please support searching recipient addresses in the "Sent" folder.
I consider this a a critical usability feature.
Thanks | https://github.com/thunderbird/thunderbird-android/pull/6486 | [
"https://github.com/thunderbird/thunderbird-android/issues/1127"
] | ./gradlew :mail:protocols:imap:test --tests "com.fsck.k9.mail.store.imap.RealImapFolderTest" --tests "com.fsck.k9.mail.store.imap.UidSearchCommandBuilderTest" | diff --git a/app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageList.kt b/app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageList.kt
index 5189ab58d82..ab3cee1bb85 100644
--- a/app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageList.kt
+++ b/app/ui/legacy/src/main/java/com/fsck/k9/activity/MessageList.kt... | diff --git a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt b/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
index c74fccfcbac..0ff0ada4a95 100644
--- a/mail/protocols/imap/src/test/java/com/fsck/k9/mail/store/imap/RealImapFolderTest.kt
+++ b/mai... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.fetch_withBodyFetchProfileAndNoMaximumDownloadSize_shouldIssueRespectiveCommand": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_calledTwice_shouldReuseSameImapConnection": {
"run": "PASS",
... | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.open_readWrite_shouldOpenFolder": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.UidSearchCommandBuilderTest.build_withFullTextSearch": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.mail.store.imap.RealImapFolderTest.getMessagesFromUids": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.store.imap.RealImapFolderTest.moveMessages_withEmptyMessageList_shouldReturnNull": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.... | {} |
thunderbird__thunderbird-android-6482 | thunderbird | thunderbird-android | 6,482 | closed | Message View Redesign: Reply actions in message view | Closes #6388 | {
"label": "thunderbird:message-view-redesign",
"ref": "message-view-redesign",
"sha": "6be4051006259f42b7b179ccc43eb0fe2fba43ae"
} | [
{
"number": 6388,
"title": "Message View Redesign: Add functionality for reply action icon",
"body": "What needs to be done:\r\n- When an identity of the current account is the only recipient, display the \"reply\" icon\r\n- In all other cases display the \"reply all\" icon\r\n- Remove the \"primary act... | kotlin | Message View Redesign: Add functionality for reply action icon
What needs to be done:
- When an identity of the current account is the only recipient, display the "reply" icon
- In all other cases display the "reply all" icon
- Remove the "primary action" from the overflow menu, so we don't display actions twice.
... | null | https://github.com/thunderbird/thunderbird-android/pull/6482 | [
"https://github.com/thunderbird/thunderbird-android/issues/6388"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.message.ReplyActionStrategyTest" | diff --git a/app/core/src/main/java/com/fsck/k9/message/ReplyActionStrategy.kt b/app/core/src/main/java/com/fsck/k9/message/ReplyActionStrategy.kt
new file mode 100644
index 00000000000..a208b982093
--- /dev/null
+++ b/app/core/src/main/java/com/fsck/k9/message/ReplyActionStrategy.kt
@@ -0,0 +1,36 @@
+package com.fsck.... | diff --git a/app/core/src/test/java/com/fsck/k9/message/ReplyActionStrategyTest.kt b/app/core/src/test/java/com/fsck/k9/message/ReplyActionStrategyTest.kt
new file mode 100644
index 00000000000..e366859072e
--- /dev/null
+++ b/app/core/src/test/java/com/fsck/k9/message/ReplyActionStrategyTest.kt
@@ -0,0 +1,111 @@
+pack... | {
"com.fsck.k9.message.ReplyActionStrategyTest.message sent to our identity and others (CC)": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.ReplyActionStrategyTest.message sent to our identity and others (To+CC)": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},... | {} | {} | {} |
thunderbird__thunderbird-android-6435 | thunderbird | thunderbird-android | 6,435 | closed | Don't throw when calling `MessageStore.getMessageServerId()` | Return `null` when the message can no longer be found in the message store.
Fixes #6432 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "ff2e2b902aaf6e800e469ac8947d36fca416d56a"
} | [
{
"number": 6432,
"title": "Crash when attempting to delete a draft message that has already been removed (by another client)",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as muc... | kotlin | Crash when attempting to delete a draft message that has already been removed (by another client)
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.309
### Where d... | null | https://github.com/thunderbird/thunderbird-android/pull/6435 | [
"https://github.com/thunderbird/thunderbird-android/issues/6432"
] | ./gradlew :app:storage:testDebugUnitTest --tests "com.fsck.k9.storage.messages.RetrieveMessageOperationsTest" | diff --git a/app/core/src/main/java/com/fsck/k9/controller/DraftOperations.kt b/app/core/src/main/java/com/fsck/k9/controller/DraftOperations.kt
index b613b650e63..83963f052d2 100644
--- a/app/core/src/main/java/com/fsck/k9/controller/DraftOperations.kt
+++ b/app/core/src/main/java/com/fsck/k9/controller/DraftOperation... | diff --git a/app/storage/src/test/java/com/fsck/k9/storage/messages/RetrieveMessageOperationsTest.kt b/app/storage/src/test/java/com/fsck/k9/storage/messages/RetrieveMessageOperationsTest.kt
index 5825dccec9d..09dccb31d70 100644
--- a/app/storage/src/test/java/com/fsck/k9/storage/messages/RetrieveMessageOperationsTest.... | {
"com.fsck.k9.storage.messages.RetrieveMessageOperationsTest.check if message is present": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.storage.messages.RetrieveMessageOperationsTest.get message flags": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.s... | {
"com.fsck.k9.storage.messages.RetrieveMessageOperationsTest.get oldest message date without any messages in the store": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.storage.messages.RetrieveMessageOperationsTest.get oldest message date": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.storage.messages.RetrieveMessageOperationsTest.get message flags without any flags set": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}... | {} |
thunderbird__thunderbird-android-6424 | thunderbird | thunderbird-android | 6,424 | closed | Keep `<tt>` tags when sanitizing HTML | Fixes #6423 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "3dfa1ccb073d78cfb61cea4a94818879dc20add9"
} | [
{
"number": 6423,
"title": "Render in HTML <tt> with monospaced font",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.202\n\n### ... | kotlin | Render in HTML <tt> with monospaced font
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.202
### Where did you get the app from?
F-Droid
### Android version
1... | null | https://github.com/thunderbird/thunderbird-android/pull/6424 | [
"https://github.com/thunderbird/thunderbird-android/issues/6423"
] | ./gradlew :app:html-cleaner:test --tests "app.k9mail.html.cleaner.HtmlSanitizerTest" | diff --git a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt b/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
index 3bc44effdc7..43a6d827385 100644
--- a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
+++ b/app/html-cleaner/src/main/java/app/k9mail/htm... | diff --git a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt b/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
index 8720a3273d5..d60ae8b3812 100644
--- a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
+++ b/app/html-cleaner/src/test/j... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshInHead": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshWithUpperCaseAttributeValue": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.h... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepAllowedElementsInHeadAndSkipTheRest": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshBetweenHeadAndBody": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app.k... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMultipleMetaRefreshTags": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepFormattingTags": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
thunderbird__thunderbird-android-6360 | thunderbird | thunderbird-android | 6,360 | closed | Clear log buffer before reading EHLO response | Fixes #6063 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "6ab1f230b5c1421290c0fafe33b1035c4131f7ea"
} | [
{
"number": 6063,
"title": "Fix log output of `SmtpResponseParser`",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n2205202769770bc... | kotlin | Fix log output of `SmtpResponseParser`
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
2205202769770bc37feb98414bb8a1ae084b9c98
### Where did you get the app from?... | null | https://github.com/thunderbird/thunderbird-android/pull/6360 | [
"https://github.com/thunderbird/thunderbird-android/issues/6063"
] | ./gradlew :mail:protocols:smtp:test --tests "com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest" | diff --git a/mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.kt b/mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.kt
index a7ceefaa101..5428e12b7e4 100644
--- a/mail/protocols/smtp/src/main/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParser.... | diff --git a/mail/protocols/smtp/src/test/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParserTest.kt b/mail/protocols/smtp/src/test/java/com/fsck/k9/mail/transport/smtp/SmtpResponseParserTest.kt
index a9d4d3e62ba..75923e5f1b7 100644
--- a/mail/protocols/smtp/src/test/java/com/fsck/k9/mail/transport/smtp/SmtpRespons... | {
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.read EHLO response with invalid parameter": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.read EHLO response with invalid keywords": {
"run": "PASS",
"test": "NONE",
"fix":... | {
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.multi-line response with text": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.multi-line response without text on last line": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.fsck.k9.mail.transport.smtp.SmtpResponseParserTest.response with invalid enhanced status code detail": {
"run": "PASS",
"test": "PASS... | {} |
thunderbird__thunderbird-android-6335 | thunderbird | thunderbird-android | 6,335 | closed | Add support for swipe actions to the message list screen | The default actions are currently:
- Swipe right: Toggle selection
- Swipe left: Mark as read/unread
https://user-images.githubusercontent.com/218061/194175023-d3a6f383-8130-4a02-9921-9aa48ee6ac6c.mp4
Closes #1426 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "75e2af6c203531779a059b0935aaa781c17939ac"
} | [
{
"number": 1426,
"title": "Swipe left/right on message to perform action",
"body": "### Expected behaviour\n\nSwipe right on message in the message list may delete message (like in iOS and AquaMail for Android).\n### Actual behaviour\n\nSwipe do nothing. There is no such feature.\n### Steps to reproduc... | kotlin | Swipe left/right on message to perform action
### Expected behaviour
Swipe right on message in the message list may delete message (like in iOS and AquaMail for Android).
### Actual behaviour
Swipe do nothing. There is no such feature.
### Steps to reproduce
1. Just try to swipe on the message in message list. Nothin... | Maybe swipe left to archive, as well.
The Gmail app also has this feature; I find it very useful to quickly sort out messages I don't care about.
NO.
That is the stupidest thing that could possibly ever be added.
I don't need any email to be randomly deleted by an unintentional sideways slip.
And as it happens, t... | https://github.com/thunderbird/thunderbird-android/pull/6335 | [
"https://github.com/thunderbird/thunderbird-android/issues/1426"
] | ./gradlew :app:ui:legacy:testDebugUnitTest --tests "com.fsck.k9.ui.messagelist.MessageListAdapterTest" | diff --git a/app/core/src/main/java/com/fsck/k9/K9.kt b/app/core/src/main/java/com/fsck/k9/K9.kt
index efcf8616e0a..d52f49dc84b 100644
--- a/app/core/src/main/java/com/fsck/k9/K9.kt
+++ b/app/core/src/main/java/com/fsck/k9/K9.kt
@@ -250,6 +250,12 @@ object K9 : EarlyInit {
@JvmStatic
var pgpSignOnlyDialogCoun... | diff --git a/app/ui/legacy/src/test/java/com/fsck/k9/fragment/MessageListAdapterTest.kt b/app/ui/legacy/src/test/java/com/fsck/k9/ui/messagelist/MessageListAdapterTest.kt
similarity index 99%
rename from app/ui/legacy/src/test/java/com/fsck/k9/fragment/MessageListAdapterTest.kt
rename to app/ui/legacy/src/test/java/com... | {
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withoutSenderAboveSubjectAndZeroPreviewLines_shouldShowDisplayNameInSecondLine": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.ui.messagelist.MessageListAdapterTest.withSenderAboveSubjectAndDefaultFontSize_shouldNotSetTextSizeOfFirs... | {} | {} | {} |
thunderbird__thunderbird-android-6280 | thunderbird | thunderbird-android | 6,280 | closed | Fix `HtmlSignatureRemover` | Detecting an email signature in HTML is quite hard, even when the default delimiter `-- ` (dash, dash, space) is used. With these changes we should support more signature formats, including the one currently used by K-9 Mail :see_no_evil:
Fixes #6279 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "58281359a7afe08e09c0ae04cf16048be3f2e62e"
} | [
{
"number": 6279,
"title": "\"Strip signatures on reply\" does not work",
"body": "### Checklist\r\n\r\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\r\n- [X] I will describe the problem with as much detail as possible.\r\n\r\n### App version\r\n... | kotlin | "Strip signatures on reply" does not work
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.202
### Where did you get the app from?
Google Play
### ... | K-9 Mail only detects the standard signature delimiter. That's two dashes followed by a space. Such signatures will also be displayed slightly differently when viewing a message.
Hi,
I repeated the test... | https://github.com/thunderbird/thunderbird-android/pull/6280 | [
"https://github.com/thunderbird/thunderbird-android/issues/6279"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.message.signature.HtmlSignatureRemoverTest" --tests "com.fsck.k9.message.signature.HtmlSignatureRemoverTest" | diff --git a/app/core/src/main/java/com/fsck/k9/helper/jsoup/AdvancedNodeTraversor.java b/app/core/src/main/java/com/fsck/k9/helper/jsoup/AdvancedNodeTraversor.java
index cfcab37a4cc..41cd5e245ff 100644
--- a/app/core/src/main/java/com/fsck/k9/helper/jsoup/AdvancedNodeTraversor.java
+++ b/app/core/src/main/java/com/fsc... | diff --git a/app/core/src/test/java/com/fsck/k9/message/signature/HtmlSignatureRemoverTest.java b/app/core/src/test/java/com/fsck/k9/message/signature/HtmlSignatureRemoverTest.java
deleted file mode 100644
index bf5f6068609..00000000000
--- a/app/core/src/test/java/com/fsck/k9/message/signature/HtmlSignatureRemoverTest... | {
"com.fsck.k9.message.signature.HtmlSignatureRemoverTest.old Thunderbird signature format": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.message.signature.HtmlSignatureRemoverTest.should not strip signature inside blockquote tag": {
"run": "NONE",
"test": "NONE",
"fix": ... | {} | {} | {} |
thunderbird__thunderbird-android-6263 | thunderbird | thunderbird-android | 6,263 | closed | Remove `EmailProvider` :tada: | Finally getting rid of `EmailProvider` should make it easier to implement a fix for:
- #6246.
Closes #3248 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "8cb294fb2571921a176297c4868ef14fb502a70c"
} | [
{
"number": 3248,
"title": "Get rid of EmailProvider",
"body": "Using an internal `ContentProvider` and `CursorLoader` was a failed experiment that lived in production for far too long. Let's get rid of it."
}
] | kotlin | Get rid of EmailProvider
Using an internal `ContentProvider` and `CursorLoader` was a failed experiment that lived in production for far too long. Let's get rid of it.
| null | https://github.com/thunderbird/thunderbird-android/pull/6263 | [
"https://github.com/thunderbird/thunderbird-android/issues/3248"
] | ./gradlew :app:core:testDebugUnitTest --tests "com.fsck.k9.mailstore.K9BackendFolderTest" --tests "com.fsck.k9.mailstore.K9BackendStorageTest" --tests "com.fsck.k9.mailstore.MessageListCacheTest" --tests "com.fsck.k9.cache.EmailProviderCacheTest" --tests "com.fsck.k9.mailstore.MessageListRepositoryTest" :app:storage:te... | diff --git a/app/core/src/main/java/com/fsck/k9/cache/EmailProviderCache.java b/app/core/src/main/java/com/fsck/k9/cache/EmailProviderCache.java
deleted file mode 100644
index cc12fde40c7..00000000000
--- a/app/core/src/main/java/com/fsck/k9/cache/EmailProviderCache.java
+++ /dev/null
@@ -1,156 +0,0 @@
-package com.fsc... | diff --git a/app/core/src/test/java/com/fsck/k9/cache/EmailProviderCacheTest.java b/app/core/src/test/java/com/fsck/k9/cache/EmailProviderCacheTest.java
deleted file mode 100644
index e673c332b31..00000000000
--- a/app/core/src/test/java/com/fsck/k9/cache/EmailProviderCacheTest.java
+++ /dev/null
@@ -1,145 +0,0 @@
-pac... | {
"com.fsck.k9.storage.messages.RetrieveFolderOperationsTest.get non-existent folder should return null": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.fsck.k9.storage.messages.RetrieveFolderOperationsTest.get message count from non-existent folder": {
"run": "PASS",
"test": "NONE",
... | {} | {} | {} |
thunderbird__thunderbird-android-6256 | thunderbird | thunderbird-android | 6,256 | closed | HTML sanitizer updates | Fixes #6240
Fixes #6241 | {
"label": "thunderbird:main",
"ref": "main",
"sha": "9cf73c99d09332a461ecb3830db86bca044bdf2e"
} | [
{
"number": 6241,
"title": "<a> \"name\" attribute is sanitized",
"body": "### Checklist\n\n- [X] I have used the search function to see if someone else has already submitted the same bug report.\n- [X] I will describe the problem with as much detail as possible.\n\n### App version\n\n6.202\n\n### Where... | kotlin | <a> "name" attribute is sanitized
### Checklist
- [X] I have used the search function to see if someone else has already submitted the same bug report.
- [X] I will describe the problem with as much detail as possible.
### App version
6.202
### Where did you get the app from?
Other
### Android version
Havoc OS 4... | https://github.com/thunderbird/thunderbird-android/pull/6256 | [
"https://github.com/thunderbird/thunderbird-android/issues/6241",
"https://github.com/thunderbird/thunderbird-android/issues/6240"
] | ./gradlew :app:html-cleaner:test --tests "app.k9mail.html.cleaner.HtmlSanitizerTest" | diff --git a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt b/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
index 80fa043e840..5697b115c4f 100644
--- a/app/html-cleaner/src/main/java/app/k9mail/html/cleaner/BodyCleaner.kt
+++ b/app/html-cleaner/src/main/java/app/k9mail/htm... | diff --git a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt b/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
index 12ea9e797b9..8720a3273d5 100644
--- a/app/html-cleaner/src/test/java/app/k9mail/html/cleaner/HtmlSanitizerTest.kt
+++ b/app/html-cleaner/src/test/j... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshInHead": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMetaRefreshWithUpperCaseAttributeValue": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"app.k9mail.h... | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepAllowedElementsInHeadAndSkipTheRest": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.should keep 'align' attribute on 'div' element": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldRemoveMultipleMetaRefreshTags": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSanitizerTest.shouldKeepFormattingTags": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"app.k9mail.html.cleaner.HtmlSani... | {} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.