message
stringlengths
6
474
diff
stringlengths
8
5.22k
Add md-nits task Assumes that Ruby is installed
@@ -39,6 +39,10 @@ jobs: run: make -s build_generated - name: make doc-nits run: make doc-nits + - name: make md-nits + run: | + sudo gem install mdl + make md-nits # This checks that we use ANSI C language syntax and semantics. # We are not as strict with libraries, but rather adapt to what's
There are now 22 refs in the test repo We brought in an updated libgit2 whose test repo gained a ref.
@@ -87,7 +87,7 @@ class RepositoryTest < Rugged::TestCase def test_return_all_ref_names refs = @repo.ref_names refs.each {|name| assert name.kind_of?(String)} - assert_equal 21, refs.count + assert_equal 22, refs.count end def test_return_all_tags
When unit tests are executed with --debug, dump VCD waveform
@@ -28,7 +28,6 @@ import shutil sys.path.insert(0, '..') import test_harness -DUMP_WAVEFORM = False DRIVER_PATH = 'obj/driver.cpp' DRIVER_SRC = ''' #include <iostream> @@ -119,7 +118,7 @@ def run_unit_test(filename, _): '--exe', DRIVER_PATH ] - if DUMP_WAVEFORM: + if test_harness.DEBUG: verilator_args.append('--trace')...
Geocoder tweak
@@ -190,10 +190,10 @@ namespace carto { namespace geocoding { } } - sqlFilters.insert(sqlFilters.end(), sqlNullFilters.begin(), sqlNullFilters.end()); if (sqlFilters.empty()) { - sqlFilters.push_back("1=1"); + return; } + sqlFilters.insert(sqlFilters.end(), sqlNullFilters.begin(), sqlNullFilters.end()); std::string sql...
common MAINTENANCE redundant condition
@@ -1831,7 +1831,7 @@ sr_create_module_imps_incs_r(const struct lys_module *ly_mod, const struct lysp_ } /* store all includes */ - includes = (lysp_submod ? lysp_submod->includes : ly_mod->parsed->includes); + includes = ly_mod->parsed->includes; LY_ARRAY_FOR(includes, u) { if ((err_info = sr_store_module_file(ly_mod,...
mmx: fix some uses of CHAR_MIN instead of INT8_MIN
@@ -160,8 +160,8 @@ simde_mm_adds_pi8 (simde__m64 a, simde__m64 b) { for (int i = 0 ; i < 8 ; i++) { if ((((b.i8[i]) > 0) && ((a.i8[i]) > (INT8_MAX - (b.i8[i]))))) { r.i8[i] = INT8_MAX; - } else if ((((b.i8[i]) < 0) && ((a.i8[i]) < (CHAR_MIN - (b.i8[i]))))) { - r.i8[i] = CHAR_MIN; + } else if ((((b.i8[i]) < 0) && ((a.i...
zephyr: corsola: fix Kconfig typo TEST=kingler boots BRANCH=none Tested-by: Eric Yilun Lin
@@ -17,7 +17,7 @@ config BOARD_KINGLER config VARIANT_CORSOLA_DB_DETECTION bool "Corsola Platform Runtime Daughter Board Detection" depends on PLATFORM_EC_USB_PD_TCPC_RUNTIME_CONFIG - depends on PLATFORM_EC_USB_PD_MUX_RUNTIME_CONFIG + depends on PLATFORM_EC_USB_MUX_RUNTIME_CONFIG help Daughter board detection for Type-...
[catboost] Fix gpu tests after r5062463 Note: mandatory check (NEED_CHECK) was skipped
@@ -646,6 +646,7 @@ def test_logloss_with_not_binarized_target(boosting_type): '-i': '10', '-w': '0.03', '-T': '4', + '--target-border': '0.5', '-m': output_model_path, } fit_catboost_gpu(params) @@ -670,6 +671,7 @@ def test_fold_len_mult(): '-w': '0.03', '-T': '4', '--fold-len-multiplier': 1.2, + '--target-border': '0...
Updated function name to correct naming convention.
@@ -111,7 +111,7 @@ next_sector: } int -fcb_getnext_nolock_sector(struct fcb *fcb, struct fcb_entry *loc) +fcb_getnext_sector_nolock(struct fcb *fcb, struct fcb_entry *loc) { int rc; @@ -176,7 +176,7 @@ fcb_getnext_sector(struct fcb *fcb, struct fcb_entry *loc) if (rc && rc != OS_NOT_STARTED) { return FCB_ERR_ARGS; } -...
Don't call strsignal, just print the signal number. The strsignal call is not supported by some machines, so avoid its use.
@@ -882,7 +882,6 @@ static void noteterm (int sig) */ static void spawn_loop(void) { - const char *signame; pid_t *kidpids = NULL; int status; int procs = 0; @@ -978,9 +977,7 @@ static void spawn_loop(void) } /* The loop above can only break on termsig */ - signame = strsignal(termsig); - syslog(LOG_INFO, "terminating ...
Fix implementation of HARD_BREAKPOINT
#if !defined(BUILD_RTM) -inline void HARD_Breakpoint() { }; +inline void HARD_Breakpoint() +{ + __BKPT(0); + while(true) { /*nop*/ } +}; -#define HARD_BREAKPOINT() HardFault_Handler() +#define HARD_BREAKPOINT() HARD_Breakpoint() // #if defined(_DEBUG) // #define DEBUG_HARD_BREAKPOINT() HARD_Breakpoint()
Reading music bank correctly (was also banked)
#include "BankManager.h" #include "gbt_player.h" #include "data_ptrs.h" +#include "BankData.h" void MusicPlay(UBYTE index, UBYTE loop, UBYTE return_bank) { + UBYTE music_bank = ReadBankedUBYTE(16, &music_banks[index]); + PUSH_BANK(return_bank); - gbt_play(music_tracks[index], music_banks[index], 7); + gbt_play(music_tr...
Remove debugging line that snuck in.
@@ -76,7 +76,6 @@ int zmk_keymap_layer_deactivate(u8_t layer) int zmk_keymap_position_state_changed(u32_t position, bool pressed) { - LOG_DBG("Searching %d layers for a binding", ZMK_KEYMAP_LAYERS_LEN); for (int layer = ZMK_KEYMAP_LAYERS_LEN - 1; layer >= zmk_keymap_layer_default; layer--) { if ((zmk_keymap_layer_state...
Guard against omp_get_num_places returning zero
@@ -232,11 +232,11 @@ int get_num_procs(void); #else int get_num_procs(void) { static int nums = 0; - + int ret; #if defined(__GLIBC_PREREQ) cpu_set_t cpuset,*cpusetp; size_t size; - int ret; + #if !__GLIBC_PREREQ(2, 7) int i; #if !__GLIBC_PREREQ(2, 6) @@ -249,7 +249,8 @@ int get_num_procs(void) { #if defined(USE_OPENM...
apps/openssl: clean-up of unused fallback code Remove code in help_main() that duplicates the case when 'openssl' is called with no arguments, which is now handled in main().
@@ -312,12 +312,6 @@ int help_main(int argc, char **argv) DISPLAY_COLUMNS dc; char *new_argv[3]; - if (argc == 0) { - new_argv[0] = "help"; - new_argv[1] = NULL; - return do_cmd(prog_init(), 1, new_argv); - } - prog = opt_init(argc, argv, help_options); while ((o = opt_next()) != OPT_hEOF) { switch (o) {
external/mbedtls: Modify a typo of MBED_TIZENRT Change MBED_TIZNERT to MBED_TIZENRT
@@ -330,7 +330,7 @@ static void sighandler( int signum ) void mbedtls_set_alarm( int seconds ) { -#if !defined(MBED_TIZNERT) +#if !defined(MBED_TIZENRT) mbedtls_timing_alarmed = 0; signal( SIGALRM, sighandler ); alarm( seconds );
[tb] Clean up alignment issues and unused code
@@ -277,7 +277,6 @@ module mempool_tb; to_mempool_req.aw.id = 'h18d; to_mempool_req.aw.addr = addr; to_mempool_req.aw.len = '0; - //to_mempool_req.aw.size = $clog2(AxiDataWidth/8); to_mempool_req.aw.size = 'h2; to_mempool_req.aw.burst = axi_pkg::BURST_INCR; to_mempool_req.aw_valid = 1'b1; @@ -368,24 +367,6 @@ module me...
Apply vdpm changes vitasdk/vdpm#25 makes problems
set -e curl -sL https://github.com/vitasdk/vdpm/raw/master/vdpm -o vdpm chmod +x vdpm -curl -L https://github.com/vitasdk/vdpm/raw/master/install-all.sh | bash > /dev/null +curl -L https://github.com/vitasdk/vdpm/raw/master/include/install-packages.sh -o install-packages.sh +sed -i "s/\.\.\///" install-packages.sh +cur...
Fixed redundant condition 'tkn!=NULL' warning [parser.c:1197].
@@ -1194,7 +1194,7 @@ parse_specifier (GLogItem * logitem, char **str, const char *p, const char *end) if (!(tkn = parse_string (&(*str), end, 1))) tkn = alloc_string ("-"); - if (tkn != NULL && *tkn == '\0') { + if (*tkn == '\0') { free (tkn); tkn = alloc_string ("-"); }
Remove update of plugin.asc
@@ -3,8 +3,6 @@ Ethereum application Plugins : Technical Specifications Ledger Firmware Team <hello@ledger.fr> Specification version 1.0 - 24th of September 2020 -## 2.0 - - Add field in pluginSharedRO, breaking change. ## 1.0 - Initial release
CMake improvements
@@ -159,7 +159,7 @@ endif () ################################################# # SETTINGS FOR UNIX COMPILER -if (${CMAKE_C_COMPILER_ID} MATCHES "Clang" OR ${CMAKE_C_COMPILER_ID} MATCHES "AppleClang" OR ${CMAKE_C_COMPILER_ID} MATCHES "GNU") +if (CMAKE_C_COMPILER_ID MATCHES "Clang" OR CMAKE_C_COMPILER_ID MATCHES "AppleCl...
Update state machine string in OTA demo
@@ -191,13 +191,15 @@ static BaseType_t prxCreateNetworkConnection( void ) static const char * pcStateStr[ eOTA_AgentState_Max ] = { + "Init", "Ready", - "InSelfTest", "RequestingJob", - "ProcessingJob", - "InitFileTransfer", - "ReceivingFile", - "CloseFile", + "WaitingForJob", + "CreatingFile", + "RequestingFileBlock"...
[doc] add link to wiki in doc/outdated/ssl.txt
@@ -21,7 +21,10 @@ Module: core Description =========== -lighttpd supports SSLv2 and SSLv3 if it is compiled against openssl. +lighttpd supports TLS with mod_openssl. + +The latest lighttpd SSL/TLS doc can be found at: +https://redmine.lighttpd.net/projects/lighttpd/wiki/Docs_SSL Configuration ------------- @@ -32,11 +...
Initialize LRU lists in domain of cache lines
@@ -867,63 +867,35 @@ void ocf_lru_dirty_cline(ocf_cache_t cache, struct ocf_part *part, OCF_METADATA_LRU_WR_UNLOCK(cline); } -static ocf_cache_line_t next_phys_invalid(ocf_cache_t cache, - ocf_cache_line_t phys) -{ - ocf_cache_line_t lg; - ocf_cache_line_t collision_table_entries = - ocf_metadata_collision_table_entri...
Fixed segfault with empty routes array.
@@ -616,14 +616,13 @@ nxt_http_route_find(nxt_http_routes_t *routes, nxt_str_t *name) route = &routes->route[0]; end = route + routes->items; - do { + while (route < end) { if (nxt_strstr_eq(&(*route)->name, name)) { return *route; } route++; - - } while (route < end); + } return NULL; } @@ -681,12 +680,11 @@ nxt_http_...
path: string format fix
@@ -219,7 +219,7 @@ static int validatePermission (Key * key, Key * parentKey) if (isError) { - ELEKTRA_SET_ERRORF (207, parentKey, "User %s does not have [%cd s] permission on %s", name, lastCharDel (errorMessage), + ELEKTRA_SET_ERRORF (207, parentKey, "User %s does not have [%s] permission on %s", name, lastCharDel (...
version T13.841: changed Makefile to produce single program xdag
-# cheatcoin: Makefile; T13.656-T13.816; $DVS:time$ +# cheatcoin: Makefile; T13.656-T13.841; $DVS:time$ dnet = ../dnet dfstools = ../dus/programs/dfstools/source @@ -84,13 +84,10 @@ flags = -std=gnu11 -O3 -DDFSTOOLS -DCHEATCOIN -DNDEBUG -g -lpthread -lcrypto -lm all: xdag xdag: $(sources) $(headers) Makefile - gcc -o x...
Correction of an error in the test to update the vector w for solving a nonconvex problem.
@@ -1225,7 +1225,7 @@ void gfc3d_IPM(GlobalFrictionContactProblem* restrict problem, double* restrict /** Correction of w to take into account the dependence on the tangential velocity */ - if (options->iparam[SICONOS_FRICTION_3D_IPM_IPARAM_UPDATE_S] == 0) + if (options->iparam[SICONOS_FRICTION_3D_IPM_IPARAM_UPDATE_S] ...
Tidy up attribute prefix bindings on error (fixes
@@ -2529,8 +2529,10 @@ doContent(XML_Parser parser, return XML_ERROR_NO_MEMORY; poolFinish(&tempPool); result = storeAtts(parser, enc, s, &name, &bindings); - if (result) + if (result != XML_ERROR_NONE) { + freeBindings(parser, bindings); return result; + } poolFinish(&tempPool); if (startElementHandler) { startElement...
luke: remove non-preloaded searchers correctly for Lua 5.3 too.
]] -package.loaders = {package.loaders[1]} -- everything is preloaded +-- Everything is preloaded. +package.searchers = package.searchers or package.loaders +for i = 2, #package.searchers do + package.searchers[i] = nil +end
bin2c: check fread explicit against expected value
@@ -60,7 +60,7 @@ main (int argc, char *argv[]) { return -1; } - if (fread (buf, file_size, 1, f_input) == 0) { + if (fread (buf, file_size, 1, f_input) != 1) { fprintf (stderr, "%s: can't read from %s\n", argv[0], argv[1]); free (buf); fclose (f_input);
Server Stateless Retry packet cannot contain ACK and PADDING frames
@@ -2189,7 +2189,9 @@ static int conn_recv_handshake_pkt(ngtcp2_conn *conn, const uint8_t *pkt, switch (fr.type) { case NGTCP2_FRAME_ACK: - if (hd.type == NGTCP2_PKT_CLIENT_INITIAL) { + switch (hd.type) { + case NGTCP2_PKT_CLIENT_INITIAL: + case NGTCP2_PKT_SERVER_STATELESS_RETRY: return NGTCP2_ERR_PROTO; } /* TODO Assu...
options/ansi: Implement mbsrtowcs()
@@ -12,6 +12,7 @@ namespace { // mbsrtowcs() and wcsrtombs() have an internal state. __mlibc_mbstate mbrlen_state = __MLIBC_MBSTATE_INITIALIZER; __mlibc_mbstate mbrtowc_state = __MLIBC_MBSTATE_INITIALIZER; + __mlibc_mbstate mbsrtowcs_state = __MLIBC_MBSTATE_INITIALIZER; } wint_t btowc(int c) { @@ -84,9 +85,35 @@ size_t...
x86: Fix build We should include <sys/syscall.h> for SYS_rt_sigreturn in x86/Gos-linux.c
@@ -26,6 +26,8 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ #include "unwind_i.h" #include "offsets.h" +#include <sys/syscall.h> + PROTECTED int unw_is_signal_frame (unw_cursor_t *cursor) {
links: enforce valid URI on render Fixes urbit/landscape#280
@@ -67,6 +67,7 @@ export const LinkItem = (props: LinkItemProps): ReactElement => { const size = node.children ? node.children.size : 0; const contents = node.post.contents; const hostname = URLparser.exec(contents[1].url) ? URLparser.exec(contents[1].url)[4] : null; + const href = URLparser.exec(contents[1].url) ? con...
[persistence] refactored the drop_if_empty in item apply functions.
@@ -10397,7 +10397,7 @@ item_apply_list_elem_delete(void *engine, hash_item *it, ret = ENGINE_FAILED; break; } - if (info->ccnt == 0 && drop_if_empty) { + if (drop_if_empty && info->ccnt == 0) { do_item_unlink(it, ITEM_UNLINK_NORMAL); } } while(0); @@ -10454,7 +10454,8 @@ item_apply_set_elem_insert(void *engine, hash_i...
ks: Simplify ksNew(0, KS_END)
@@ -252,14 +252,10 @@ KeySet * ksVNew (size_t alloc, va_list va) /*errno = KDB_ERR_NOMEM;*/ return 0; } + ksInit (keyset); - if (alloc == 0) - { - keyset->alloc = alloc; - keyset->array = 0; - return keyset; - } + if (alloc == 0) return keyset; alloc++; /* for ending null byte */ if (alloc < KEYSET_SIZE)
Eliminate use of deprecated imp module.
@@ -9,7 +9,7 @@ import math import signal import threading import atexit -import imp +import types import re import pprint import time @@ -30,7 +30,6 @@ _py_soext = '.so' _py_dylib = '' try: - import imp import sysconfig import distutils.sysconfig @@ -1412,7 +1411,7 @@ class ApplicationHandler(object): self.target = en...
Add description in X509_STORE manipulation Add memory management description in X509_STORE_add_cert, otherwise users will not be aware that they are leaking memory...
@@ -55,7 +55,9 @@ operate on pointers to B<X509> objects, though. X509_STORE_add_cert() and X509_STORE_add_crl() add the respective object to the B<X509_STORE>'s local storage. Untrusted objects should not be -added in this way. +added in this way. The added object's reference count is incremented by one, +hence the ca...
Fix retry protection key
@@ -79,13 +79,13 @@ const picoquic_version_parameters_t picoquic_supported_versions[] = { { PICOQUIC_V1_VERSION, sizeof(picoquic_cleartext_v1_salt), picoquic_cleartext_v1_salt, - sizeof(picoquic_cleartext_v1_salt), - picoquic_cleartext_v1_salt }, + sizeof(picoquic_retry_protection_v1), + picoquic_retry_protection_v1 },...
revert change from yesterday setting compiler for OSX
@@ -302,10 +302,6 @@ function initialize_build_visit() # See issue #1499 (https://visitbugs.ornl.gov/issues/1499) # use gcc for 10.9 & earlier - export C_COMPILER=${C_COMPILER:-"gcc"} - export CXX_COMPILER=${CXX_COMPILER:-"g++"} - export FC_COMPILER=${FC_COMPILER:-$GFORTRAN} - if [[ ${VER%%.*} < 8 ]] ; then export MACO...
pybricks.experimental.restore_firmware: Require USB. USB power is required to keep the hub on during the final stage of the firmware update process. Fixes
@@ -534,11 +534,11 @@ pbio_error_t pb_flash_restore_firmware(void) { return PBIO_ERROR_INVALID_OP; } - // Check that the hub is plugged in and charging. - if (pbdrv_charger_get_status() != PBDRV_CHARGER_STATUS_CHARGE) { - mp_printf(&mp_plat_print, "Please connect the hub via USB.\n"); - // TODO: Stop here once charging...
make convolutions more flexible
/* Copyright 2014. The Regents of the University of California. + * Copyright 2017. Martin Uecker. * All rights reserved. Use of this source code is governed by * a BSD-style license which can be found in the LICENSE file. * * Authors: - * 2012-10-28 Martin Uecker uecker@eecs.berkeley.edu + * 2012, 2017 Martin Uecker <...
Array: Simplify `elektraArrayValidateName`
*/ int elektraArrayValidateName (const Key * key) { - if (!key) - { - return -1; - } - - const char * current = keyBaseName (key); - - if (!current) - { - return -1; - } - - if (!strcmp (current, "#")) - { - return 0; - } + const char * current; + if (!key || !(current = keyBaseName (key)) || *current != '#') return -1...
BugID:15136123:[WhiteScan] uninitialized remoteipaddr type
@@ -568,7 +568,7 @@ static err_t salnetconn_delete(sal_netconn_t *conn) static err_t salnetconn_connect(sal_netconn_t *conn, int8_t *addr, u16_t port) { sal_conn_t statconn = {0}; - ip_addr_t remoteipaddr; + ip_addr_t remoteipaddr = {0}; #if SAL_PACKET_SEND_MODE_ASYNC struct sal_sock *sock; #endif
os_cputime: Minor comment fix
@@ -88,9 +88,9 @@ extern struct os_cputime_data g_os_cputime; #define CPUTIME_LT(__t1, __t2) ((int32_t) ((__t1) - (__t2)) < 0) /** evaluates to true if t1 is after t2 in time */ #define CPUTIME_GT(__t1, __t2) ((int32_t) ((__t1) - (__t2)) > 0) -/** evaluates to true if t1 is after t2 in time */ -#define CPUTIME_GEQ(__t1...
ip6-nd: correct set-ip6-nd-proxy CLI short_help Type: fix
@@ -113,7 +113,7 @@ set_ip6_nd_proxy_cmd (vlib_main_t * vm, VLIB_CLI_COMMAND (set_ip6_nd_proxy_command, static) = { .path = "set ip6 nd proxy", - .short_help = "set ip6 nd proxy <HOST> <INTERFACE>", + .short_help = "set ip6 nd proxy <interface> [del] <host-ip>", .function = set_ip6_nd_proxy_cmd, }; /* *INDENT-ON* */
asurada: do not set PPC Vconn in board hook PPC Vconn control should have been handled in the set_vconn. TEST=Vconn is still sourcing on asurada BRANCH=none
@@ -475,12 +475,10 @@ void board_set_charge_limit(int port, int supplier, int charge_ma, void board_pd_vconn_ctrl(int port, enum usbpd_cc_pin cc_pin, int enabled) { /* - * We ignore the cc_pin because the polarity should already be set - * correctly in the PPC driver via the pd state machine. + * We ignore the cc_pin a...
Update: Config.h: Less concepts can be matched per cycle, it doesn't affect the capability, wonderful
//Occurrence time distance in which case event belief is preferred over eternal #define EVENT_BELIEF_DISTANCE 20 //Amount of belief concepts to select to be matched to the selected event -#define BELIEF_CONCEPT_MATCH_TARGET 160 +#define BELIEF_CONCEPT_MATCH_TARGET 80 //Adaptation speed of the concept priority threshold...
Work CI-CD Add missing parameter to yaml template. ***NO_CI***
@@ -627,6 +627,8 @@ jobs: repoDirectory: '$(Build.SourcesDirectory)\nf-interpreter' - template: azure-pipelines-templates/download-install-esp32-build-components.yml - template: azure-pipelines-templates/download-install-ninja.yml + parameters: + repoDirectory: '$(Build.SourcesDirectory)\nf-interpreter' - template: azu...
Add legacy behavior for finding Python
@@ -1402,14 +1402,17 @@ if(${TINYSPLINE_BINDING_REQUESTED}) # Python if(${TINYSPLINE_ENABLE_PYTHON}) - if(${TINYSPLINE_PYTHON_VERSION} STREQUAL "2") - # Map legacy variables. - if(DEFINED PYTHON_INCLUDE_DIR) - set(Python2_INCLUDE_DIRS ${PYTHON_INCLUDE_DIR}) - endif() - if(DEFINED PYTHON_LIBRARY) - set(Python2_LIBRARIES...
Print message on unexpected non-drop
@@ -232,10 +232,16 @@ void check_egress_port(fake_cmd_t cmd, int egress_port, LCPARAMS) { } if (lcdata->pkt_idx != last_error_pkt_idx) { + if (cmd.out_port == DROP) { + debug(" " T4LIT(!!,error) " " T4LIT(Packet #%d,packet) "@" T4LIT(core%d,core) ": expected to drop the packet, but got egress port " T4LIT(%d%s,error) "...
Fix: Incorrect bounds in scaling and shifting coeffs
@@ -1374,10 +1374,10 @@ bool colour_scc(int scc_id, int *colour, int c, int stmt_pos, int pv, PlutoProg return true; } - stmt_id = sccs[scc_id].vertices[stmt_pos]; if (options->scc_cluster) { fcg_offset = ddg->sccs[scc_id].fcg_scc_offset; } else { + stmt_id = sccs[scc_id].vertices[stmt_pos]; fcg_offset = ddg->vertices[...
Don't show close button on REPL
@@ -184,7 +184,9 @@ class ConsoleViewController: UIViewController, UITextViewDelegate, InputAssistan override func viewWillAppear(_ animated: Bool) { super.viewWillAppear(animated) + if !(self is REPLViewController) { navigationItem.rightBarButtonItems = [UIBarButtonItem(barButtonSystemItem: .stop, target: self, action...
Documentation: clean-up of isolated README.rst files Clean up of a couple of README.rst files located respectively under hypervisor/ and devicemodel/ to remove obsolete and unmaintained information. Both hold a basic introduction about the folder content and refer to the official documentation website for more detailed...
@@ -3,78 +3,10 @@ ACRN Device Model Introduction ============ -The ACRN Device Model provides **device sharing** capabilities between the Service OS and Guest OSs. It is a component that is used in conjunction with the `ACRN Hypervisor`_ and this is installed within the Service OS. You can find out more about Project A...
Fix wrong macro definition
@@ -76,7 +76,7 @@ extern "C" { #define ESP_DBG_TYPE_TRACE 0x40 /*!< Debug trace messages for program flow */ #define ESP_DBG_TYPE_STATE 0x20 /*!< Debug state messages (such as state machines) */ -#define ESP_DBG_TYPE_ALL (GSM_DBG_TYPE_TRACE | GSM_DBG_TYPE_STATE) /*!< All debug types */ +#define ESP_DBG_TYPE_ALL (ESP_DB...
feat(wifi_provisioning): Optimize memory for wifi scan ap number
@@ -702,16 +702,17 @@ static esp_err_t update_wifi_scan_results(void) goto exit; } - prov_ctx->ap_list[curr_channel] = (wifi_ap_record_t *) calloc(count, sizeof(wifi_ap_record_t)); + uint16_t get_count = MIN(count, MAX_SCAN_RESULTS); + prov_ctx->ap_list[curr_channel] = (wifi_ap_record_t *) calloc(get_count, sizeof(wifi...
odyssey: update config file documentation
@@ -256,26 +256,27 @@ client_max 100 listen { # Bind address. host "*" - +# # Listen port. port 6432 - +# # TCP listen backlog. backlog 128 - -# Enable TLS support. +# +# TLS support. +# +# Supported TLS modes: +# +# "disable" - disable TLS protocol +# "allow" - switch to TLS protocol on request +# "require" - TLS clie...
fix bugged assertion check
@@ -3503,7 +3503,7 @@ PlutoMatrix *pluto_get_new_access_func(const Stmt *stmt, // IF_DEBUG2(printf("New access function is \n")); // IF_DEBUG2(pluto_matrix_print(stdout, newacc)); - assert(newacc->ncols = stmt->trans->nrows+npar+1); + assert(newacc->ncols == stmt->trans->nrows+npar+1); pluto_matrix_free(remap); free(re...
Activate I2Cv1 for ST_NUCLEO64_F401RE_NF board Signed by piwi1263
@@ -70,6 +70,7 @@ foreach(SRC_FILE ${CHIBIOS_PORT_SRCS}) ${CHIBIOS_BOARD} STREQUAL "NETDUINO3_WIFI" OR ${CHIBIOS_BOARD} STREQUAL "I2M_ELECTRON_NF" OR ${CHIBIOS_BOARD} STREQUAL "I2M_OXYGEN_NF" OR + ${CHIBIOS_BOARD} STREQUAL "ST_NUCLEO64_F401RE_NF" OR ${CHIBIOS_BOARD} STREQUAL "ST_NUCLEO64_F411RE_NF" OR ${CHIBIOS_BOARD} ...
Prevent sending io to volume if it not opened
@@ -263,8 +263,10 @@ void ocf_volume_submit_io(struct ocf_io *io) ENV_BUG_ON(!volume->type->properties->ops.submit_io); - if (!volume->opened) + if (!volume->opened) { io->end(io, -OCF_ERR_IO); + return; + } volume->type->properties->ops.submit_io(io); } @@ -275,8 +277,10 @@ void ocf_volume_submit_flush(struct ocf_io *...
Makefile now compiles on Mac
@@ -13,13 +13,13 @@ UNAME=$(shell uname) # Mac OSX ifeq ($(UNAME), Darwin) -DRAWFUNCTIONS_C=redist/RawDrawNull.c -GRAPHICS_LOFI:=redist/RawDrawNull.o +DRAWFUNCTIONS=redist/DrawFunctions.c redist/RawDrawNull.c +GRAPHICS_LOFI:=redist/DrawFunctions.o redist/RawDrawNull.o # Linux / FreeBSD else LDFLAGS:=$(LDFLAGS) -lX11 -D...
Add nme.system.System.exeDirectory
@@ -19,6 +19,7 @@ class System public static var totalMemory(get, null):Int; public static var totalMemoryNumber(get, null):Float; public static var exeName(get, null):String; + public static var exeDirectory(get, null):String; static var args:Array<String>; static public function exit(?inCode:Int) @@ -114,6 +115,16 @@...
fixes typos in http.c
@@ -2909,7 +2909,7 @@ u3_http_ef_that(u3_noun tat) cli_u = _proxy_warc_new(htp_u, (u3_atom)u3k(sip), (u3_atom)u3k(non), (c3_s)por, (c3_o)sec); - // resolve to loopback if networking is disabling + // resolve to loopback if networking is disabled // if ( c3n == u3_Host.ops_u.net ) { cli_u->ipf_w = INADDR_LOOPBACK;
ulp: fix ulp external project args Closes
@@ -47,10 +47,9 @@ function(ulp_embed_binary app_name s_sources exp_dep_srcs) INSTALL_COMMAND "" CMAKE_ARGS -DCMAKE_GENERATOR=${CMAKE_GENERATOR} -DCMAKE_TOOLCHAIN_FILE=${TOOLCHAIN_FLAG} - -DULP_S_SOURCES=${sources} -DULP_APP_NAME=${app_name} + -DULP_S_SOURCES=$<TARGET_PROPERTY:${app_name},ULP_SOURCES> + -DULP_APP_NAME=...
Make: use drone var directly
@@ -10,9 +10,13 @@ SE=arm-none-eabi-size GCC_VERSION = $(shell arm-none-eabi-gcc -dumpversion) GIT_VERSION = unkown -ifneq (,$(wildcard .git/refs/heads/master)) +ifneq ($(DRONE_COMMIT),) + GIT_VERSION = $(DRONE_COMMIT) +else + ifneq ($(wildcard .git/refs/heads/master),) GIT_VERSION = $(shell sh -c 'cat .git/refs/heads/...
chat-hook: rerun fix on OTA
state-2 state-3 state-4 + state-5 == :: ++$ state-5 [%5 state-base] +$ state-4 [%4 state-base] +$ state-3 [%3 state-base] +$ state-2 [%2 state-base] $% [%chat-update update:store] == -- -=| state-4 +=| state-5 =* state - :: %- agent:dbug =/ old !<(versioned-state old-vase) =| cards=(list card) |- - ?: ?=(%4 -.old) + ?:...
Add ROTATE inline RISC-V zbb/zbkb asm for DES
: "cc"); \ ret; \ }) +# elif defined(__riscv_zbb) || defined(__riscv_zbkb) +# if __riscv_xlen == 64 +# define ROTATE(x, n) ({ register unsigned int ret; \ + asm ("roriw %0, %1, %2" \ + : "=r"(ret) \ + : "r"(x), "i"(n)); ret; }) +# endif +# if __riscv_xlen == 32 +# define ROTATE(x, n) ({ register unsigned int ret; \ + a...
Fix Gtest-trace output for illumos/Solaris
@@ -207,7 +207,7 @@ sighandler (int signal, void *siginfo UNUSED, void *context) printf (" @ %lx", (unsigned long) uc->uc_mcontext.mc_eip); #endif #elif UNW_TARGET_X86_64 -#if defined __linux__ +#if defined __linux__ || defined __sun printf (" @ %lx", (unsigned long) uc->uc_mcontext.gregs[REG_RIP]); #elif defined __Fre...
Update changelog for version 0.7.0
## Changelog +### 0.7.0 + +- Tuples from pairs to octuples have been made instances of `FromLuaStack` and + `ToLuaStack`. +- New functions `dostring` and `dofile` are provided to load and run strings and + files in a single step. +- `LuaStatus` was renamed to `Status`, the *Lua* prefix was removed from its + type const...
update ya tool arc call utimes Note: mandatory check (NEED_CHECK) was skipped
}, "arc": { "formula": { - "sandbox_id": [362054312], + "sandbox_id": [362727586], "match": "arc" }, "executable": {
Tests: BOM test.
@@ -83,6 +83,25 @@ class TestConfiguration(TestControl): 'unicode number', ) + def test_json_utf8_bom(self): + self.assertIn( + 'success', + self.conf( + b"""\xEF\xBB\xBF + { + "app": { + "type": "python", + "processes": {"spare": 0}, + "path": "/app", + "module": "wsgi" + } + } + """, + 'applications', + ), + 'UTF-8 B...
Also adjust the version in the .pc
@@ -468,7 +468,7 @@ install (FILES DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/UPNP/ ) -set (VERSION ${UPNP_VERSION_STRING}) +set (VERSION ${PUPNP_VERSION_STRING}) set (prefix ${CMAKE_INSTALL_PREFIX}) set (exec_prefix "\${prefix}") set (libdir "\${exec_prefix}/${CMAKE_INSTALL_LIBDIR}")
Test deeply nested group parsing with a failing allocator
@@ -6831,6 +6831,52 @@ START_TEST(test_alloc_system_notation) #undef MAX_ALLOC_COUNT END_TEST +START_TEST(test_alloc_nested_groups) +{ + const char *text = + "<!DOCTYPE doc [\n" + "<!ELEMENT doc " + /* Sixteen elements per line */ + "(e,(e?,(e?,(e?,(e?,(e?,(e?,(e?,(e?,(e?,(e?,(e?,(e?,(e?,(e?,(e?," + "(e?,(e?,(e?,(e?,(e...
remove spammy azimuth-tracker printfs
=/ m (async:stdio ,block) ^- form:m ;< =json bind:m (request-rpc url `'block number' %eth-block-number ~) - ~& [%block-number json (parse-eth-block-number:rpc:ethereum json)] (get-block-by-number url (parse-eth-block-number:rpc:ethereum json)) :: ++ get-block-by-number ;< state=app-state bind:m (zoom state number.id.la...
fix wrong version header for tls1.3
@@ -2560,8 +2560,14 @@ int mbedtls_ssl_write_record( mbedtls_ssl_context *ssl, uint8_t force_flush ) #endif /* Skip writing the record content type to after the encryption, * as it may change when using the CID extension. */ - - mbedtls_ssl_write_version( ssl->major_ver, ssl->minor_ver, + int minor_ver = ssl->minor_ver...
add DEBUG condition to select debug configuration by default DEBUG_MM_HEAPINFO can be enabled when DEBUG is enabled. warning: (ENABLE_HEAPINFO) selects DEBUG_MM_HEAPINFO which has unmet direct dependencies (DEBUG)
@@ -77,7 +77,7 @@ config ENABLE_HEAPINFO bool "heapinfo" default y depends on !BUILD_PROTECTED - select DEBUG_MM_HEAPINFO + select DEBUG_MM_HEAPINFO if DEBUG ---help--- Show information about memory status per thread
admin/lmod: include lua-libs for centos8
@@ -31,6 +31,7 @@ BuildRequires: lua >= %{luaver} BuildRequires: lua-devel >= %{luaver} %if 0%{?rhel} > 7 +BuildRequires: lua-libs BuildRequires: lua-filesystem BuildRequires: lua-posix BuildRequires: procps-ng
github: update pull request template The current wording is a bit curt. Flesh it out a bit and put in some useful detail.
-Please do not submit a Pull Request via github. Our project makes use of -mailing lists for patch submission and review. For more details please -see https://open-power.github.io/skiboot/ +Hi there, + +The skiboot project (generally) doesn't take contributions via github pull +requests. Contributions should sent to th...
out_opentelemetry: fixed uri sanitizer issue This code works in the same way as the original except it doesn't lose default values. Anything else is just the same.
@@ -94,38 +94,28 @@ static void check_proxy(struct flb_output_instance *ins, } } -static char *sanitize_uri(struct flb_output_instance *ins, - struct opentelemetry_context *ctx, - struct flb_upstream *upstream, - char *check_uri){ - char *uri = NULL; - char *tmp = NULL; - char *tmp_uri = NULL; - int ulen; - - if (ins->...
Little change to process.awk
@@ -38,7 +38,8 @@ END { t=1 error=0 - printf "---------------------- Process %s logs -------------------------------\n", iter + printf "---------------------- Process %s logs ----------------------------\n", iter + printf " (time in usec)\n", iter while (t <= 10) { i=1 min = usec_table[t][1];
firmware: Update to stable RaspberryPi 3B+ support
-RPIFW_DATE ?= "20180313" -SRCREV ?= "af994023ab491420598bfd5648b9dcab956f7e11" +RPIFW_DATE ?= "20180417" +SRCREV ?= "5db8e4e1c63178e200d6fbea23ed4a9bf4656658" RPIFW_SRC_URI ?= "https://github.com/raspberrypi/firmware/archive/${SRCREV}.tar.gz" RPIFW_S ?= "${WORKDIR}/firmware-${SRCREV}" SRC_URI = "${RPIFW_SRC_URI}" -SRC...
[catboost/java] bump version, fix linux-x86_64 library layout in deployed artifact
<groupId>ai.catboost</groupId> <artifactId>catboost-prediction</artifactId> - <version>0.2-SNAPSHOT</version> + <version>0.2.1-SNAPSHOT</version> <packaging>jar</packaging> <name>CatBoost model applier</name> <description>Java module to apply CatBoost models</description>
mangle: remove so many Shrink's
@@ -685,7 +685,12 @@ static void mangle_NegByte(run_t* run, bool printable) { static void mangle_Expand(run_t* run, bool printable) { size_t off = mangle_getOffSet(run); - size_t len = mangle_getLen(run->global->mutate.maxInputSz - off); + size_t len; + if (util_rnd64() % 16) { + len = mangle_getLen(HF_MIN(16, run->glo...
Don't select indentation
@@ -1118,6 +1118,9 @@ fileprivate func parseArgs(_ args: inout [String]) { textView.contentTextView.insertText(lines.joined(separator: "\n")) textView.contentTextView.selectedRange = NSRange(location: nsRange.location, length: textView.contentTextView.selectedRange.location-nsRange.location) + if selected.components(se...
Fix SRCDIR for qemu build RDIR (the initial working directory) is not necessarily the top of the chipyard source tree.
@@ -122,7 +122,7 @@ CC= CXX= module_all riscv-pk --prefix="${RISCV}" --host=riscv64-unknown-elf module_all riscv-tests --prefix="${RISCV}/riscv64-unknown-elf" # Common tools (not in any particular toolchain dir) -SRCDIR="$RDIR/toolchains" module_all qemu --prefix="${RISCV}" --target-list=riscv64-softmmu +SRCDIR="$(pwd)...
Add test coverage for pg_current_logfile() function. There has been no coverage at all up to now. Given Thomas Kellerer's recent report, I suspect this may fail on (some?) Windows machines, but let's find out. Discussion:
@@ -3,7 +3,7 @@ use warnings; use PostgresNode; use TestLib; -use Test::More tests => 4; +use Test::More tests => 5; use Time::HiRes qw(usleep); # Set up node with logging collector @@ -47,6 +47,10 @@ for (my $attempts = 0; $attempts < $max_attempts; $attempts++) like($first_logfile, qr/division by zero/, 'found expect...
fuzz: no need to reset run->dynamicFileSz
@@ -382,7 +382,6 @@ static void fuzz_fuzzLoop(run_t* run) { run->report[0] = '\0'; run->mainWorker = true; run->mutationsPerRun = run->global->mutate.mutationsPerRun; - run->dynamicFileSz = 0; run->tmOutSignaled = false; run->linux.hwCnts.cpuInstrCnt = 0; @@ -416,7 +415,6 @@ static void fuzz_fuzzLoopSocket(run_t* run) ...
more swap for rpi3
@@ -31,9 +31,9 @@ sudo systemctl restart systemd-binfmt Warning, you need a 64bit OS: -If building on the Pi, you will also need a large swap (2 GB+) -and reduce GPU memory to a minimum (e.g. 16 MB) using `raspi-config` -(and reboot) before starting the build: +If building on the Pi, you will also need a large swap (3 ...
Fix EFF Open Audio License removal. The earlier commit changed the html, but not the original TeX source document.
@@ -119,12 +119,9 @@ info) Copyright attribution, e.g., '2001 Nobody's Band' or '1999 Jack Moffitt' \item[LICENSE] - License information, eg, 'All Rights Reserved', 'Any + License information, for example, 'All Rights Reserved', 'Any Use Permitted', a URL to a license such as a Creative Commons license -("www.creativec...
call ENnextH before ENnextQ
@@ -87,8 +87,8 @@ Contributors to this version (listed in order of first contribution): ENrunH(&t); ENrunQ(&qt); // collect results - ENnextQ(&qstep); ENnextH(&tstep); + ENnextQ(&qstep); } while (tstep > 0); ENcloseQ(); ENcloseH();
lib: libco: sync changes for FreeBSD and non-gcc compilers
#define text_section __declspec(allocate(".text")) #elif defined(__APPLE__) && defined(__MACH__) #define text_section __attribute__((section("__TEXT,__text"))) +#elif defined(__clang__) + #define text_section __attribute__((section(".text"))) #else #define text_section __attribute__((section(".text#"))) #endif
Update comment in pack module to cover a more common use case. The KeyValue object is actively being removed so this is no longer the best example. Instead use an example that should outlive the KeyValue object.
@@ -25,10 +25,10 @@ pckWriteStrP(packWrite, NULL, .defaultWrite = true) is not valid since there is NULLs are not stored in a pack and are therefore not typed. A NULL is essentially just a gap in the field IDs. Fields that are frequently NULL are best stored at the end of an object. When using read functions the defaul...
http_client: do not wait for more data on HTTP 204 response status
@@ -346,6 +346,9 @@ static int process_data(struct flb_http_client *c) return FLB_HTTP_OK; } } + else { + return FLB_HTTP_OK; + } } else if (c->resp.headers_end && c->resp.content_length <= 0) { return FLB_HTTP_OK;
Implement rect_inset, rect_union
@@ -115,6 +115,26 @@ Rect* rect_clip(Rect subject, Rect cutting, int* count, bool* occluded) { return clipped; } +Rect rect_union(Rect a, Rect b) { + Rect ret; + ret.origin.x = MIN(rect_min_x(a), rect_min_x(b)); + ret.origin.y = MIN(rect_min_y(a), rect_min_y(b)); + ret.size.width = MAX(a.size.width, b.size.width); + re...
Use unicode representation when comparing query string
@@ -115,7 +115,13 @@ namespace carto { return Op<double>()(v1.get<double>(), v2.get<double>()); } if (v1.is<std::string>() && v2.is<std::string>()) { - return Op<std::string>()(v1.get<std::string>(), v2.get<std::string>()); + std::string str1 = v1.get<std::string>(); + std::wstring wstr1; + utf8::utf8to32(str1.begin(),...
Add __unused to variables that are only used if TU_LOG does something
@@ -134,11 +134,11 @@ typedef union TU_ATTR_PACKED TU_VERIFY_STATIC(sizeof(rp2040_buffer_control_t) == 2, "size is not correct"); -static inline void print_bufctrl16(uint32_t u16) +static inline void print_bufctrl16(uint32_t __unused u16) { - rp2040_buffer_control_t bufctrl; - - bufctrl.u16 = u16; + rp2040_buffer_contr...
fix minor spelling issue by removing contraction
*/ /* Setting configUSING_QEMU results in console output when an LED toggles as -LEDs aren't visible in QEMU. */ +LEDs are not visible in QEMU. */ #define configUSING_QEMU 1 #define configMAX_API_CALL_INTERRUPT_PRIORITY 18
SOVERSION bump to version 5.1.6
@@ -39,7 +39,7 @@ set(SYSREPO_VERSION ${SYSREPO_MAJOR_VERSION}.${SYSREPO_MINOR_VERSION}.${SYSREPO_ # with backward compatible change and micro version is connected with any internal change of the library. set(SYSREPO_MAJOR_SOVERSION 5) set(SYSREPO_MINOR_SOVERSION 1) -set(SYSREPO_MICRO_SOVERSION 5) +set(SYSREPO_MICRO_SO...
[arch][arm64] change CACHE_LINE to 64 for cortex a53,57 and 72
#define PAGE_SIZE (1UL << PAGE_SIZE_SHIFT) #define USER_PAGE_SIZE (1UL << USER_PAGE_SIZE_SHIFT) +#if ARM64_CPU_CORTEX_A53 || ARM64_CPU_CORTEX_A57 || ARM64_CPU_CORTEX_A72 +#define CACHE_LINE 64 +#else #define CACHE_LINE 32 - +#endif