message
stringlengths
6
474
diff
stringlengths
8
5.22k
symtrack example: fixing typo with using undeclared/unused variables
@@ -54,7 +54,7 @@ int main(int argc, char*argv[]) unsigned int num_samples = 200000; // number of samples int dopt; - while ((dopt = getopt(argc,argv,"hk:m:b:s:w:n:t:r:")) != EOF) { + while ((dopt = getopt(argc,argv,"hk:m:b:s:w:n:")) != EOF) { switch (dopt) { case 'h': usage(); return 0; case 'k': k = atoi(optarg); bre...
CI: Run `update` before `install` for valgrind Was hitting a 404 error when installing valgrind (the libc6-dbg dependency specifically), this might fix it.
@@ -45,7 +45,9 @@ jobs: with: submodules: recursive - name: Install Valgrind - run: sudo apt-get install -y valgrind + run: | + sudo apt-get update + sudo apt-get install -y valgrind - name: Build run: make - name: Test
Don't hide I/O errors behind LockErr Only return a LockErr if there's lock contention, not on unrelated I/O errors.
@@ -263,16 +263,14 @@ S_request(LockFileLockIVARS *ivars, String *lock_path) { String *lock_dir_name = SSTR_WRAP_C("locks"); if (!Folder_Exists(ivars->folder, lock_dir_name)) { if (!Folder_MkDir(ivars->folder, lock_dir_name)) { - Err *mkdir_err = (Err*)CERTIFY(Err_get_error(), ERR); - LockErr *err = LockErr_new(Str_new...
X509_NAME_cmp: if canon_enclen is 0 for both names return 0 We do not care whether canon_enc is NULL in this case. Fixes
@@ -269,11 +269,14 @@ int X509_NAME_cmp(const X509_NAME *a, const X509_NAME *b) return -2; } + ret = a->canon_enclen - b->canon_enclen; + if (ret == 0 && a->canon_enclen == 0) + return 0; + if (a->canon_enc == NULL || b->canon_enc == NULL) return -2; - ret = a->canon_enclen - b->canon_enclen; - if (ret == 0 && a->canon...
webterm: do not warn on session creation cancel
@@ -17,8 +17,7 @@ export const useAddSession = () => { const userInput = prompt('Please enter an alpha-numeric session name.'); // user canceled or did not enter a value - if (!userInput) { - alert('A valid name is required to create a new session'); + if (null === userInput) { return; }
Small update to FindFFI.cmake for a different pkg-config behaviour
@@ -34,9 +34,9 @@ if (PkgConfig_FOUND) #use found LIBFFI pkg config info to search for the abs path fo the libffi lib. #Note that the abs path info is not present in the pkg-config results (only the -l and -L arguments) - find_library(FFI_ABS_LIB NAMES ffi PATHS ${LIBFFI_LIBRARY_DIRS} NO_DEFAULT_PATH NO_PACKAGE_ROOT_PA...
Fix a couple of small issues for travis tests.
@@ -50,7 +50,7 @@ int main(int argc,char **argv) // Initialize cosmological parameters ccl_configuration config=default_config; config.transfer_function_method=ccl_boltzmann_class; - ccl_parameters params = ccl_parameters_create(OC, OB, OK, NREL, MNU, MNUTYPE, W0, WA, HH, NORMPS, NS,-1,-1,-1,-1,NULL,NULL, &status); + c...
Remove mandatory generated files on windows too
@@ -360,10 +360,12 @@ clean: libclean {- join("\n\t", map { "-del /Q /F $_" } @PROGRAMS) -} -del /Q /F $(ENGINES) -del /Q /F $(SCRIPTS) + -del /Q /F $(GENERATED_MANDATORY) -del /Q /F $(GENERATED) -del /Q /S /F *.d *.obj *.pdb *.exp *.ilk *.manifest -del /Q /S /F engines\*.lib -del /Q /S /F apps\*.lib apps\*.rc apps\*.r...
Add workaround for old gcc and clang versions Old gcc and clang do not handle constructor arguments, finally fix as discussed there, using the fedora patch
@@ -148,8 +148,15 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #define CONSTRUCTOR __attribute__ ((constructor)) #define DESTRUCTOR __attribute__ ((destructor)) #else +#if __GNUC__ && INIT_PRIORITY && ((GCC_VERSION >= 40300) || (CLANG_VERSION >= 20900)) #define CONSTRUCTOR __attribute__ (...
[mod_magnet] adjust hot path for more inlining
@@ -2372,7 +2372,7 @@ static handler_t magnet_attract(request_st * const r, plugin_data * const p, scr /* pcall will destroy the func value, duplicate it */ /* (sp += 1) */ lua_pushvalue(L, func_ndx); - { + int errfunc = push_traceback(L, 0); int ret = lua_pcall(L, 0, 1, errfunc); lua_remove(L, errfunc); @@ -2381,23 +2...
Fix wtimeout changing logic I'm dumb, and this fixes case where key repeats were causing blocking
@@ -1152,6 +1152,7 @@ int main(int argc, char** argv) { } if (new_timeout != cur_timeout) { wtimeout(stdscr, new_timeout); + cur_timeout = new_timeout; } //struct timespec ts; //ts.tv_sec = 0; @@ -1269,6 +1270,10 @@ int main(int argc, char** argv) { break; } key = wgetch(stdscr); + if (cur_timeout != 0) { + wtimeout(st...
machinarium: set proper write_cb flags during parallel read
@@ -13,7 +13,6 @@ mm_write_cb(mm_fd_t *handle) { mm_io_t *io = handle->on_write_arg; mm_call_t *call = &io->call; - assert(mm_call_is(call, MM_CALL_WRITE)); if (mm_call_is_aborted(call)) return; @@ -29,6 +28,7 @@ mm_write_cb(mm_fd_t *handle) if (errno == EINTR) continue; + if (mm_call_is(call, MM_CALL_WRITE)) call->sta...
af_xdp: fix thread 0 and 1 using one txq slot Type: fix
@@ -216,8 +216,8 @@ VNET_DEVICE_CLASS_TX_FN (af_xdp_device_class) (vlib_main_t * vm, vnet_interface_output_runtime_t *ord = (void *) node->runtime_data; af_xdp_device_t *ad = pool_elt_at_index (rm->devices, ord->dev_instance); u32 thread_index = vm->thread_index; - af_xdp_txq_t *txq = - vec_elt_at_index (ad->txqs, (thr...
OcAppleRamDiskLib: Fix extent allocation condition
@@ -19,7 +19,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <Protocol/AppleRamDisk.h> #include <Library/BaseMemoryLib.h> -#include <Library/DebugLib.h> +#include <Library/OcDebugLogLib.h> #include <Library/MemoryAllocationLib.h> #include <Library/OcAppleRamDiskLib.h> #includ...
Fixed non-auto-reset timers.
@@ -104,18 +104,13 @@ nxt_conn_io_read(nxt_task_t *task, void *obj, void *data) c->socket.read_handler = c->io->read; c->socket.error_handler = state->error_handler; - if (c->read_timer.state == NXT_TIMER_DISABLED - || nxt_fd_event_is_disabled(c->socket.read)) - { - /* Timer may be set or reset. */ - nxt_conn_timer(eng...
fix: change %lu to PRIu64
@@ -30,7 +30,7 @@ void set_role(client *client, const uint64_t guild_id, const uint64_t channel_id if (role->id) { char text[150]; - snprintf(text, sizeof(text), "Succesfully created <@!%lu> role", role->id); + snprintf(text, sizeof(text), "Succesfully created <@!%" PRIu64 "> role", role->id); channel::message::create:...
Remove use of X macro for uturn definition
@@ -730,39 +730,41 @@ BEGIN_DUAL_PHASE_1(track) STUN(1, 0); END_PHASE -#define UTURN_DIRS(_) \ - _(-1, 0, 'N') \ - _(0, -1, 'W') \ - _(0, 1, 'E') \ - _(1, 0, 'S') +static Isz const uturn_data[] = { + // clang-format off + -1, 0, (Isz)'N', + 0, -1, (Isz)'W', + 0, 1, (Isz)'E', + 1, 0, (Isz)'S', + // clang-format on +}; +...
Put TX and RX enable to HAL to be able to use TX IT.
@@ -32,12 +32,9 @@ static uint8_t Transmit_GetLockStatus(void); ******************************************************************************/ void Transmit_SendAck(void) { - LuosHAL_SetTxState(true); - LuosHAL_SetRxState(false); + // Transmit Ack data LuosHAL_ComTransmit((unsigned char *)&ctx.rx.status.unmap, 1); - L...
containerutils: Fix possible memory leak Call free() on variable even when there are errors to avoid leaking it.
@@ -58,13 +58,19 @@ uint64_t get_cgroupid(char *path) { h->handle_bytes = 8; err = name_to_handle_at(AT_FDCWD, path, (struct file_handle *)h, &mount_id, 0); - if (err != 0) - return 0; + if (err != 0) { + ret = 0; + goto out; + } - if (h->handle_bytes != 8) - return 0; + if (h->handle_bytes != 8) { + ret = 0; + goto ou...
add -j=file and PTLSLOG env param to quicly CLI
@@ -1067,6 +1067,23 @@ static void push_req(const char *path, int to_file) memset(reqs + i + 1, 0, sizeof(*reqs)); } +static void setup_ptlslog(const char *fn) +{ + int fd; + if ((fd = open(fn, O_WRONLY | O_CREAT | O_APPEND, 0666)) == -1) { + fprintf(stderr, "failed to open file:%s:%s\n", fn, strerror(errno)); + exit(1...
make warn. msg version agnostic
@@ -7529,8 +7529,7 @@ avtDatabaseMetaData::GetSEGWarningString() const "except to override this behavior and suffer any GUI performance issues.\n" "Unfortunately, if you are running in client-server mode, you will have to\n" "take action to set this enviornment variable on both the server and client\n" - "machines. Thi...
Added new params to config file
################### VISUAL ################### +### Legacy Layout +legacy_layout + ### Display the current CPU information cpu_stats # cpu_temp @@ -86,6 +89,7 @@ position=top-left ### IO read and write for the app (not system) # io_read # io_write +# io_stats ### Display system ram / vram usage # ram @@ -104,7 +108,8 @...
Config: Fixing run_sim
HOSTNAME=`hostname -s`; echo "hostname=$HOSTNAME arguments=$@" TS=`date +%Y%m%d_%H%M%S`; if [ "$TST_TITLE" != "" ];then TS="${TS}_${TST_TITLE}";fi export SNAP_ROOT=${PWD%/hardware/sim*};echo "root=$SNAP_ROOT" # default root, in case its not overwritten - [ -f "${SNAP_ROOT}/.snap_env" ] && . ${SNAP_ROOT}/.snap_env.sh + ...
Remove duplicated progress reporting during heap scan of VACUUM This has been introduced by since progress reporting for VACUUM has been added. As this issue just causes some extra work and is harmless, no backpatch is done. Author: Justin Pryzby Discussion:
@@ -1445,8 +1445,6 @@ lazy_scan_heap(Relation onerel, VacuumParams *params, LVRelStats *vacrelstats, pgstat_progress_update_multi_param(2, hvp_index, hvp_val); /* Remove tuples from heap */ - pgstat_progress_update_param(PROGRESS_VACUUM_PHASE, - PROGRESS_VACUUM_PHASE_VACUUM_HEAP); lazy_vacuum_heap(onerel, vacrelstats);...
Add -verythorough CLI test
@@ -649,7 +649,8 @@ class CLIPTest(CLITestBase): """ Test all valid presets are accepted """ - presets = ["-fastest", "-fast", "-medium", "-thorough", "-exhaustive"] + presets = ["-fastest", "-fast", "-medium", + "-thorough", "-verythorough", "-exhaustive"] imIn = self.get_ref_image_path("LDR", "input", "A") imOut = se...
[Realtek][RTL8721CSM] arch/arm/src/amebad/ : Fix MSP and idle stack not matched issue. Fix MSP and idle stack not matched issue. 1st commit for define g_idle_topstack to MSP which the bootloader set for main stack.
#include "nvic.h" #endif -const uintptr_t g_idle_topstack = (uintptr_t)&_ebss + CONFIG_IDLETHREAD_STACKSIZE; +#define MSP_RAM_HP_NS 0x10004FFC +const uintptr_t g_idle_topstack = MSP_RAM_HP_NS; /**************************************************************************** * Name: _start
ActionTimelineManager tweaks
@@ -46,7 +46,7 @@ public unsafe partial struct Character [FieldOffset(0x818)] public fixed byte EquipSlotData[4 * 10]; [FieldOffset(0x840)] public fixed byte CustomizeData[0x1A]; - [FieldOffset(0x8E0)] public ActionTimelineManager ActionTimelineManager; + [FieldOffset(0x8F0)] public ActionTimelineManager ActionTimeline...
[mod_webdav] compile fix for Mac OSX/11
#include <string.h> #include <unistd.h> /* getpid() linkat() rmdir() unlinkat() */ +#if defined(__APPLE__) && defined(__MACH__) +#ifdef AT_SYMLINK_NOFOLLOW +#ifndef _ATFILE_SOURCE +#define _ATFILE_SOURCE +#endif +#endif +#endif + /* Note: filesystem access race conditions exist without _ATFILE_SOURCE */ #ifndef _ATFILE...
[mod_magnet] remove duplicated NULL checks
@@ -1228,8 +1228,7 @@ static int magnet_reqhdr_get(lua_State *L) { const char * const k = luaL_checklstring(L, 2, &klen); request_st * const r = magnet_get_request(L); const int id = http_header_hkey_get(k, (uint32_t)klen); - const buffer * const vb = http_header_request_get(r, id, k, klen); - magnet_push_buffer(L, NUL...
opensuse: OS_ID field content changed for SUSE
@@ -12,7 +12,7 @@ VAPI_LIBS = \ -L$(VPP_TEST_INSTALL_PATH)/vpp/lib64 \ -lvppinfra -lvlibmemoryclient -lsvm -lpthread -lcheck -lrt -lm -lvapiclient -ifneq ($(filter centos opensuse,$(OS_ID)),$(OS_ID)) +ifneq ($(filter centos opensuse opensuse-tumbleweed opensuse-leap,$(OS_ID)),$(OS_ID)) VAPI_LIBS += -lsubunit endif
noise.c: Minor cleanup.
@@ -248,8 +248,9 @@ bool bb_noise_process_msg( out_packet->data_addr[0] = OP_STATUS_FAILURE; return false; } + const uint8_t cmd = in_packet->data_addr[0]; // If this is a handshake init message, start the handshake. - if (in_packet->data_addr[0] == OP_I_CAN_HAS_HANDSHAKE) { + if (cmd == OP_I_CAN_HAS_HANDSHAKE) { if (!...
errnos: remove chips error definitions
@@ -455,18 +455,6 @@ errors flounder FLOUNDER_ERR_ { }; -// errors generated by chips name service -errors chips CHIPS_ERR_ { - failure GET_SERVICE_REFERENCE "Error getting service reference from name service", - failure GET_SERVICE_IREF "Error getting IREF from name service", - failure UNKNOWN_NAME "Lookup failed: unk...
JNI: Fix JNI detection on macOS Before this commit the JNI plugin would not be included on macOS, if `JAVA_HOME` was not set properly.
include (LibAddMacros) if (DEPENDENCY_PHASE) + if (APPLE) + execute_process (COMMAND "/usr/libexec/java_home" OUTPUT_VARIABLE JAVA_HOME) + string (STRIP ${JAVA_HOME} JAVA_HOME) + endif () + find_package (JNI) if (JNI_FOUND)
make sure, we detect wrong timestamps and out of sequence stored packets and combinations of both
@@ -246,6 +246,8 @@ if(ia->timestampgap > ib->timestampgap) return 1; else if(ia->timestampgap < ib->timestampgap) return -1; if(ia->rcgap > ib->rcgap) return 1; else if(ia->rcgap < ib->rcgap) return -1; +if(ia->rcgap > ib->rcgap) return 1; +else if(ia->rcgap < ib->rcgap) return -1; return 0; } @@ -266,8 +268,6 @@ if(i...
Address - Add :octal-permissions
@@ -1005,6 +1005,9 @@ static Janet os_stat_inode(jstat_t *st) { static Janet os_stat_mode(jstat_t *st) { return janet_wrap_keyword(janet_decode_mode(st->st_mode)); } +static Janet os_stat_int_permissions(jstat_t *st) { + return janet_wrap_integer(janet_perm_to_unix(janet_decode_permissions(st->st_mode))); +} static Jan...
Fix nicoff testing for non l2 case
@@ -93,7 +93,7 @@ fake_cmd_t get_command_object(LCPARAMS, unsigned idx){ fake_cmd_t get_cmd_to_verify(LCPARAMS) { while( get_command_object(LCPARAMS_IN, lcdata->verify_idx).action != FAKE_PKT || - get_command_object(LCPARAMS_IN, lcdata->verify_idx).in_port == 0) { + strlen(get_command_object(LCPARAMS_IN, lcdata->verify...
doc: update visibility proposal is in
@@ -726,9 +726,25 @@ description= who is allowed to edit this configuration setting? [visibility] status= idea type= enum + critical + important user + advanced developer + debug + disabled description= who should see this configuration setting? + This is the equivalent of priority in debconf. + If no visibility is giv...
netcmd: fix compilation error caused by resolving merge conflicts
@@ -87,27 +87,34 @@ extern int netdb_main(int argc, char *argv[]); static void nic_display_state(void) { + struct ifreq *ifr; + struct sockaddr_in *sin; + struct sockaddr *sa; struct ifconf ifcfg; + int ret = -1; int fd; int numreqs = 3; int num_nic = 0; - fd = socket(AF_INET, SOCK_DGRAM, 0); if (fd < 0) { ndbg("fail %...
fix eager_delay test, and allow large OS pages even without eager commit enabled
@@ -326,7 +326,8 @@ static mi_segment_t* mi_segment_alloc(size_t required, mi_page_kind_t page_kind, size_t page_size = (page_kind == MI_PAGE_HUGE ? segment_size : (size_t)1 << page_shift); // Try to get it from our thread local cache first - bool eager = mi_option_is_enabled(mi_option_eager_commit) && (tld->count < (s...
IPSec: fix IPv6 policy deleting
@@ -370,9 +370,9 @@ ipsec_add_del_policy (vlib_main_t * vm, ipsec_policy_t * policy, int is_add) } } } + } pool_put (spd->policies, vp); break; - } })); /* *INDENT-ON* */ }
windows: Fix line wrapping behaviour on the REPL. This enables going back to previous wrapped lines using backspace or left arrow: instead of just sticking to the beginning of a line, the cursor will move a line up.
@@ -106,12 +106,23 @@ void mp_hal_set_interrupt_char(char c) { } void mp_hal_move_cursor_back(uint pos) { + if (!pos) { + return; + } assure_conout_handle(); CONSOLE_SCREEN_BUFFER_INFO info; GetConsoleScreenBufferInfo(con_out, &info); info.dwCursorPosition.X -= (short)pos; - if (info.dwCursorPosition.X < 0) { + // Move...
BugID:16846667: Remove return from write
@@ -93,7 +93,6 @@ _ssize_t _write_r(struct _reent *ptr, int fd, const void *buf, size_t nbytes) uart_stdio.port = 0; hal_uart_send(&uart_stdio, buf, nbytes, AOS_WAIT_FOREVER); - hal_uart_send(&uart_stdio, (void *)"\r", 1, AOS_WAIT_FOREVER); return nbytes; }
second pass at updating changelog
@@ -6,19 +6,19 @@ title: Changelog ## AppScope 0.7 -2021-06-11 - Maintenance Pre-Release +2021-06-15 - Maintenance Pre-Release This pre-release addresses the following issues: -- **Improvement**: [#286](https://github.com/criblio/appscope/issues/286) Add support for TLS over TCP connections, and add new TLS-related env...
[aergo.name] The state check of "aergo.name" is corrected
@@ -93,7 +93,9 @@ func openContract(bs *state.BlockState) (*state.ContractState, error) { //GetAddress is resolve name for mempool func GetAddress(scs *state.ContractState, name []byte) []byte { - if len(name) == types.AddressLength || bytes.Equal(name, []byte(types.AergoSystem)) { + if len(name) == types.AddressLength...
Regenerate Version.hpp with today's build date
#define MAT_VERSION_HPP // WARNING: DO NOT MODIFY THIS FILE! // This file has been automatically generated, manual changes will be lost. -#define BUILD_VERSION_STR "3.5.25.1" -#define BUILD_VERSION 3,5,25,1 +#define BUILD_VERSION_STR "3.5.57.1" +#define BUILD_VERSION 3,5,57,1 #ifndef RESOURCE_COMPILER_INVOKED #include ...
notifications: fix broken pagination Fixes urbit/landscape#788
@@ -4,6 +4,11 @@ import { dateToDa, decToUd } from '../lib/util'; import { NotifIndex, IndexedNotification, Association, GraphNotifDescription } from '@urbit/api'; import { BigInteger } from 'big-integer'; import { getParentIndex } from '../lib/notification'; +import useHarkState from '../state/hark'; + +function getHa...
give server thread a few seconds to shutdown normally before killing it
@@ -161,7 +161,7 @@ int session_setup_test( } } if (!connected) { - printf("giving up connection to test server"); + printf("giving up connection to test server\n"); goto cleanup; } @@ -219,6 +219,7 @@ int session_setup_test( &tspec, NULL, sid_ret, &err_ret)) { + printf("OWPSessionRequest returned error\n "); goto clea...
KeyToMeta: Handle return value of `asprintf`
@@ -31,9 +31,12 @@ static Key * createMergingKey (int i) char * name; char * value; char * order; - asprintf (&name, "user/convertkey%d", i); - asprintf (&value, "meta line %d", i); - asprintf (&order, "%i", i); + if (asprintf (&name, "user/convertkey%d", i) == -1 || asprintf (&value, "meta line %d", i) == -1 || + aspr...
miniredis: use v2 everywhere
@@ -7,7 +7,7 @@ ALLOW .* -> vendor/cuelang.org/go ALLOW .* -> vendor/github.com/360EntSecGroup-Skylar/excelize/v2 # in-process redis server for tests -ALLOW .* -> vendor/github.com/alicebob/miniredis +ALLOW .* -> vendor/github.com/alicebob/miniredis/v2 # AMQP client with RabbitMQ extensions ALLOW .* -> vendor/github.co...
feat(ci) add GCC problem matcher
@@ -13,5 +13,6 @@ jobs: steps: - uses: actions/checkout@v2 + - uses: ammaraskar/gcc-problem-matcher@master - name: Run tests run: sudo apt-get install libpng-dev; cd tests; python ./build.py
build: use Windows 11 EWDK
@@ -3,9 +3,9 @@ if "%CODEQL_HOME%"=="" set CODEQL_HOME=c:\codeql-home set CODEQL_BIN=%CODEQL_HOME%\codeql\codeql.cmd if not "%EnterpriseWDK%"=="" goto ready -if "%EWDK1903_DIR%"=="" set EWDK1903_DIR=c:\ewdk1903 -call :add_path "%EWDK1903_DIR%\Program Files\Microsoft Visual Studio\2019\BuildTools\VC\Redist\MSVC\14.20.27...
asurada_scp: mask CC_HOSTCMD and CC_IPI out To keep console quiet enough. BRANCH=none TEST=make BOARD=asurada_scp
#ifndef __CROS_EC_BOARD_H #define __CROS_EC_BOARD_H +#define CC_DEFAULT (CC_ALL & ~(CC_MASK(CC_HOSTCMD) | CC_MASK(CC_IPI))) + #define CONFIG_FLASH_SIZE 0x58000 #define CONFIG_LTO #define CONFIG_UART_CONSOLE 0
relay: do not immediately shutdown (and crash) There is two bugs here: 1. the failed worker check was off-by-one (due to code changes for regex_t per thread) 2. the sentinel was written over the last worker
@@ -821,8 +821,8 @@ main(int argc, char * const argv[]) break; } } - workers[id + 0] = NULL; /* sentinel */ - if (id < 1 + workercnt) { + workers[id + 1] = NULL; /* sentinel */ + if (id < workercnt) { logerr("shutting down due to errors\n"); keep_running = 0; }
Add ARCHIVE destination for static libs.
@@ -235,7 +235,9 @@ add_custom_target( # Specify Install targets install(TARGETS picoquicdemo picolog_t picoquic-core picoquic-log picohttp-core RUNTIME DESTINATION bin - LIBRARY DESTINATION lib) + LIBRARY DESTINATION lib + ARCHIVE DESTINATION lib +) install(FILES ${PICOQUIC_CORE_HEADERS}
Crypto: Remove useless `#ifdef` from ReadMe
- infos/needs = - infos/recommends = - infos/placements = postgetstorage presetstorage -#ifdef ELEKTRA_CRYPTO_API_GCRYPT -- infos/status = unittest configurable memleak experimental unfinished discouraged -#else - infos/status = unittest configurable memleak experimental unfinished discouraged -#endif - infos/metadata ...
plain C style math includes
# endif # endif -#if !defined(__cplusplus) #include <math.h> #include <fenv.h> -#else -# include <cmath> -# include <cfenv> -#endif HEDLEY_DIAGNOSTIC_PUSH # if HEDLEY_HAS_WARNING("-Wfloat-equal")
refer to oidc-keychain rather than agent
# Quickstart After [installation](installation/install.md) the agent has to be started. Usually the agent is started on system startup and is then available on all -terminals (see [integration](configuration/integration.md)). However, after -installation the agent has to be started manually. +terminals (see [integratio...
extmod/modbluetooth: Unify error handling in remaining places. Most error handling is done via `bluetooth_handle_errno()` already. Replace the remaining few manual checks with calls to that function.
@@ -267,9 +267,7 @@ STATIC mp_obj_t bluetooth_ble_active(size_t n_args, const mp_obj_t *args) { // Boolean enable/disable argument supplied, set current state. if (mp_obj_is_true(args[1])) { int err = mp_bluetooth_init(); - if (err != 0) { - mp_raise_OSError(err); - } + bluetooth_handle_errno(err); } else { mp_bluetoot...
make the test case fail by setting -DREQUIRES_USM in the makefile. The fail is a segfault. But all indications are that the device is getting a set pointer
@@ -5,7 +5,7 @@ TESTSRC_MAIN = simple_ptr.cpp TESTSRC_AUX = TESTSRC_ALL = $(TESTSRC_MAIN) $(TESTSRC_AUX) -CLANG = clang++ +CLANG = clang++ -DREQUIRES_USM OMP_BIN = $(AOMP)/bin/$(CLANG) CC = $(OMP_BIN) $(VERBOSE) #-ccc-print-phases
fix unitialized return value if no tests in context
@@ -1243,7 +1243,7 @@ static ACVP_RESULT acvp_parse_register (ACVP_CTX *ctx) { * it should be run on a separate thread if needed. */ ACVP_RESULT acvp_process_tests (ACVP_CTX *ctx) { - ACVP_RESULT rv; + ACVP_RESULT rv = ACVP_NO_CTX; ACVP_VS_LIST *vs_entry; if (!ctx) {
examples/pwm: fix printf format warnings
/**************************************************************************** - * examples/pwm/pwm_main.c + * apps/examples/pwm/pwm_main.c * * Copyright (C) 2011-2012, 2015 Gregory Nutt. All rights reserved. * Author: Gregory Nutt <gnutt@nuttx.org> @@ -227,7 +227,7 @@ static void pwm_help(FAR struct pwm_state_s *pwm) #...
Update a typo in README.md.
@@ -91,7 +91,7 @@ Additional `VPLanet` examples can be found at the following GitHub pages: [Juliette Becker](https://github.com/jxcbecker)<br /> [Patrick Barth](https://github.com/pbfeu)<br /> [David Graham](https://github.com/dglezg7)<br /> -[Caitlyn Wilhelm](https://github.com/caitlyn-wilhelm/IceCoverage) +[Caitlyn ...
Add debug enumerator.
@@ -255,6 +255,19 @@ typedef enum PORTING_VITA } e_porting; +// Caskey, Damon V. +// 2019-01-08 +// +// Debugging display options for end user. +typedef enum +{ + DEBUG_DISPLAY_NONE, + DEBUG_DISPLAY_COLLISION_ATTACK = 0x00000001, + DEBUG_DISPLAY_COLLISION_BODY = 0x00000002, + DEBUG_DISPLAY_PROPERTIES = 0x00000004, + DE...
Fixing stubs inclusion for several components
@@ -133,16 +133,11 @@ set(NF_CoreCLR_SRCS nf_rt_native_nanoFramework_Runtime_Native_Rtc_stubs.cpp # Core stubs - Hardware_stub.cpp - InterruptHandler_stub.cpp - NativeEventDispatcher_stub.cpp RPC_stub.cpp BinaryFormatter_stub.cpp # CLR stubs Debugger_stub.cpp - Diagnostics_stub.cpp - Messaging_stub.cpp # Helpers nanopr...
rnndb: add PSEC2 we probably want to move the sec thing somewhere else, because it isn't strictly related to video stuff.
<use-group name="falcon_crypt"/> </array> +<array name="PSEC2" offset="0x87000" stride="0x1000" length="1" variants="GP100-"> + <use-group name="falcon_base"/> +</array> + </domain> </database>
Update OTA Documentation to clarify grammar. The sentence about CONFIG_BOOTLOADER_APP_ROLLBACK_ENABLE was worded strangely. I updated it to better explain the functionality. Closes
@@ -41,7 +41,7 @@ The main purpose of the application rollback is to keep the device working after * The application works fine, :cpp:func:`esp_ota_mark_app_valid_cancel_rollback` marks the running application with the state ``ESP_OTA_IMG_VALID``. There are no restrictions on booting this application. * The application...
parallel-libs/petsc: bump version to v3.9
@@ -26,7 +26,7 @@ Name: %{pname}-%{compiler_family}-%{mpi_family}%{PROJ_DELIM} Summary: Portable Extensible Toolkit for Scientific Computation License: 2-clause BSD Group: %{PROJ_NAME}/parallel-libs -Version: 3.8.3 +Version: 3.9 Release: 1%{?dist} Source0: http://ftp.mcs.anl.gov/pub/petsc/release-snapshots/petsc-%{vers...
Don't trigger fw rebuild on git hash change
@@ -136,6 +136,9 @@ panda_env = Environment( # Common autogenerated includes version = f'const uint8_t gitversion[] = "{get_version(BUILDER, BUILD_TYPE)}";' gitversion = panda_env.Textfile("obj/gitversion.h", [version, ""]) +Ignore('bootstub.o', gitversion) +Ignore('main.o', gitversion) + certs = [get_key_header(n) for...
[autotools] fix typo in -I used --with-pcre2=/path (fixes (thx giliy) x-ref: "[PATCH] --with-pcre2 configured to incorrect path"
@@ -890,7 +890,7 @@ AC_MSG_RESULT([$WITH_PCRE2]) if test "$WITH_PCRE2" != no && test "$WITH_PCRE" = "no"; then if test "$WITH_PCRE2" != yes; then PCRE_LIB="-L$WITH_PCRE2/lib -lpcre2-8" - CPPFLAGS="$CPPFLAGS -I$WITH_PCRE/include" + CPPFLAGS="$CPPFLAGS -I$WITH_PCRE2/include" else PKG_CHECK_MODULES([PCRE2],[libpcre2-8],[ ...
Docs: corrected format for gpmovemirrors input file
<li>Create an input file for the <codeph>gpmovemirrors</codeph> utility with an entry for each mirror that must be moved.<p>The <codeph>gpmovemirrors</codeph> input file has the following - format:<codeblock><varname>contentID</varname>|<varname>address</varname>|<varname>port</varname>|<varname>data_dir</varname> <var...
Fix android platform include order;
#include "platform_windows.c.h" #elif __APPLE__ #include "platform_macos.c.h" +#elif __ANDROID__ +#include "platform_android.c.h" #elif __linux__ #include "platform_linux.c.h" #elif EMSCRIPTEN #include "platform_web.c.h" -#elif __ANDROID__ -#include "platform_android.c.h" #endif
feat: dont check null if it is an array
@@ -1045,8 +1045,11 @@ static void gen_use_default_inject_settings(FILE *fp, struct jc_struct *s) i, act.inject_arg_decor, act.c_name); break; case INJECT_IF_NOT_EMPTY_STR: + if (f->type.decor.tag == DEC_POINTER) fprintf(fp, " if (p->%s != NULL && strlen(p->%s) != 0)\n", act.c_name, act.c_name); + else + fprintf(fp, " ...
npu2: Reset NVLinks on hot reset This effectively fences GPU RAM on GPU reset so the host system does not have to crash every time we stop a KVM guest with a GPU passed through. Suggested-by: Balbir Singh Acked-by: Balbir Singh
@@ -1092,6 +1092,20 @@ static int64_t npu2_get_power_state(struct pci_slot *slot __unused, uint8_t *val static int64_t npu2_hreset(struct pci_slot *slot __unused) { + struct npu2 *p; + int i; + struct npu2_dev *ndev; + + p = phb_to_npu2_nvlink(slot->phb); + NPU2INF(p, "Hreset PHB state\n"); + + for (i = 0; i < p->total...
Fix LB lookup table failed issue
@@ -984,9 +984,14 @@ static int lb_vip_del_port_filter(lb_main_t *lbm, lb_vip_t *vip) key.vip_prefix_index = vip->vip_prefix_index; key.protocol = vip->protocol; key.port = clib_host_to_net_u16(vip->port); + key.rsv = 0; kv.key = key.as_u64; - if(clib_bihash_search_8_8(&lbm->vip_index_per_port, &kv, &value) == 0) + if(...
allow use_weights for BrierScore metric
@@ -2758,9 +2758,6 @@ namespace { TString GetDescription() const override; void GetBestValue(EMetricBestValue* valueType, float* bestValue) const override; double GetFinalError(const TMetricHolder& error) const override; - TBrierScoreMetric() { - UseWeights.MakeIgnored(); - } }; }
lib/sshv2.c: sshv2_start_login_sequence(): recognize `(yes/no/[`
@@ -500,7 +500,8 @@ sshv2_start_login_sequence (gftp_request * request, int fdm, int ptymfd) break; } } - else if (strstr (tempstr, "(yes/no)?") != NULL) + else if (strstr (tempstr, "(yes/no)?") != NULL || + strstr (tempstr, "(yes/no/[") != NULL) { clear_tempstr = 1; if (!gftpui_protocol_ask_yes_no (request, request->h...
Added transitiontime to getAllScenes RestAPI call
@@ -1767,6 +1767,8 @@ int DeRestPluginPrivate::getAllScenes(const ApiRequest &req, ApiResponse &rsp) lights.append(l->lid()); } scene["lights"] = lights; + scene["transitiontime"] = i->transitiontime(); + rsp.map[sceneId] = scene; } }
oops... arithmetics only
@@ -64,6 +64,8 @@ License: MIT #define FIO_HASH_KEY_ISINVALID(key) ((key) == 0) #define FIO_HASH_KEY_COPY(key) (key) #define FIO_HASH_KEY_DESTROY(key) ((void)0) +#elif !defined(FIO_HASH_NO_TEST) +#define FIO_HASH_NO_TEST 1 #endif #ifndef FIO_HASH_INITIAL_CAPACITY @@ -499,7 +501,7 @@ FIO_FUNC inline size_t fio_hash_comp...
BugID:16973243:incorrect return value for write Header platform write error will report error to cloud for OTA APP change incorrect return value for write Header.
static u32 alinknewImg2Addr = 0xFFFFFFFF; char *HeadBuffer = NULL; -#define OTA_HEADER_BUF_SIZE 1460 +#define OTA_HEADER_BUF_SIZE 1024 int alink_size = 0; -#define ALINK_BUF_SIZE 512 u8 alink_signature[9] = {0}; extern const update_file_img_id OtaImgId[2]; uint32_t alink_ota_target_index = OTA_INDEX_2; @@ -56,9 +55,7 @...
Fix flaky test exttab1 The flaky case happens when select an external table with option "fill missing fields". By gdb the qe, this value is not false on QE sometimes. When ProcessCopyOptions, we use intVal(defel->arg) to parse the boolean value, which is not correct. Using defGetBoolean to replace it.
@@ -1521,7 +1521,7 @@ ProcessCopyOptions(CopyState cstate, ereport(ERROR, (errcode(ERRCODE_SYNTAX_ERROR), errmsg("conflicting or redundant options"))); - cstate->fill_missing = intVal(defel->arg); + cstate->fill_missing = defGetBoolean(defel); } else if (strcmp(defel->defname, "newline") == 0) {
Tools: Check error code after decoding referenceValueError
@@ -929,8 +929,10 @@ static int compare_values(grib_runtime_options* options, grib_handle* h1, grib_h packingError2 = 0; err1 = grib_get_double(h1, "referenceValueError", &packingError1); err2 = grib_get_double(h2, "referenceValueError", &packingError2); + if (!err1 && !err2) { value_tolerance = packingError1 > packing...
Update Build and Flash with Eclipse IDE to make terminology consistent
@@ -5,7 +5,11 @@ Build and Flash with Eclipse IDE ESP-IDF V4.0 has a new CMake-based build system as the default build system. -There is a new ESP-IDF Eclipse Plugin that works with the CMake-based build system. Please refer to https://github.com/espressif/idf-eclipse-plugin/blob/master/README.md for further instructio...
Fix delta QP range check assert. Add separate asserts based on bit depth.
@@ -269,8 +269,12 @@ static void encode_transform_coeff(encoder_state_t * const state, if (state->must_code_qp_delta) { const int qp_pred = kvz_get_cu_ref_qp(state, x_cu, y_cu, state->last_qp); const int qp_delta = cur_cu->qp - qp_pred; - assert(KVZ_BIT_DEPTH == 8 && "This range applies only to 8-bit encoding."); + // ...
mesh: Fixes missing recv net_idx copy to context Missing copy net_idx to ctx, this cause tx subnet not found or different with rx subnet, when rx subnet net_idx not zero. This is port of
@@ -604,6 +604,7 @@ bool bt_mesh_net_cred_find(struct bt_mesh_net_rx *rx, struct os_mbuf *in, if (cb(rx, in, out, &bt_mesh.lpn.cred[j])) { rx->new_key = (j > 0); rx->friend_cred = 1U; + rx->ctx.net_idx = rx->sub->net_idx; return true; } } @@ -638,6 +639,7 @@ bool bt_mesh_net_cred_find(struct bt_mesh_net_rx *rx, struct ...
Only adding freertos_config if it exists. Removing auto generation of it from a FREERTOS_CONFIG_FILE_DIRECTORY.
@@ -6,6 +6,8 @@ cmake_minimum_required(VERSION 3.15) # User is responsible for one library target: # freertos_config ,typcially an INTERFACE library # +# DEPRECATED: FREERTOS_CONFIG_FILE_DIRECTORY - but still supported if no freertos_config defined for now. +# May be removed at some point in the future. # User can choo...
CCSDS: set bitsPerValue=0 for constant field
@@ -400,6 +400,9 @@ static int pack_double(grib_accessor* a, const double* val, size_t* len) if ((err = grib_set_long_internal(hand, self->number_of_values, n_vals)) != GRIB_SUCCESS) return err; + bits_per_value = 0; + if ((err = grib_set_long_internal(hand, self->bits_per_value, bits_per_value)) != GRIB_SUCCESS) + ret...
Fix copypaste in vpp_papi/vpp_transport_socket.py
@@ -69,11 +69,10 @@ class VppTransport(object): def connect(self, name, pfx, msg_handler, rx_qlen): - if self.message_thread.daemon is not None: + if self.message_thread is not None: raise RuntimeError( "PAPI socket transport connect: You need to disconnect first.") - self.message_thread.daemon = threading.Thread( - ta...
oc_tls:do not init TLS session unless in RFNOP
@@ -1603,6 +1603,12 @@ write_application_data(oc_tls_peer_t *peer) static void oc_tls_init_connection(oc_message_t *message) { + oc_sec_pstat_t *pstat = oc_sec_get_pstat(message->endpoint.device); + if (pstat->s != OC_DOS_RFNOP) { + oc_message_unref(message); + return; + } + oc_tls_peer_t *peer = oc_tls_get_peer(&messa...
Make the multiplayer example a bit more interesting Adds a sequence number to each message, implements scrolling, and shows a count of messages sent and received.
#include <cstring> +#include <deque> #include "multiplayer.hpp" using namespace blit; -std::vector<std::string> messages; +std::deque<std::string> messages; +unsigned sent_count = 0; +unsigned recv_count = 0; +static constexpr int max_messages = 9; void on_message(const uint8_t *data, uint16_t len) { + if (messages.siz...
Add a keyboard shortcut for setting a breakpoint
@@ -439,7 +439,8 @@ fileprivate func parseArgs(_ args: inout [String]) { override var keyCommands: [UIKeyCommand]? { if textView.contentTextView.isFirstResponder { return [ - UIKeyCommand(input: "c", modifierFlags: [.command, .shift], action: #selector(toggleComment), discoverabilityTitle: Localizable.MenuItems.toggleC...
test: add platone test case test_002InitWallet_0014InitPlatoneWalletWithWrongGenMode fix the issue aitos-io#1176 teambition task id:
@@ -838,6 +838,25 @@ START_TEST(test_002InitWallet_0013InitPlatoneWalletGenerationKey) } END_TEST +START_TEST(test_002InitWallet_0014InitPlatoneWalletWithWrongGenMode) +{ + BoatPlatoneWallet *rtnVal; + BoatPlatoneWalletConfig walletConfig; + + walletConfig.prikeyCtx_config.prikey_genMode = 3; + walletConfig.prikeyCtx_c...
guybrush: Enable BOARD_RESET_AFTER_POWER_ON This was required on Zork. It's also needed on guybrush. TEST=Build BRANCH=None
#define GPIO_PCH_SYS_PWROK GPIO_EC_SOC_PWR_GOOD #define GPIO_SYS_RESET_L GPIO_EC_SYS_RST_L #define GPIO_EN_PWR_A GPIO_EN_PWR_Z1 +/* + * On power-on, H1 releases the EC from reset but then quickly asserts and + * releases the reset a second time. This means the EC sees 2 resets: + * (1) power-on reset, (2) reset-pin res...
Prevent, Amazon Echo, from creating to many api keys in a row
@@ -149,8 +149,6 @@ int DeRestPluginPrivate::createUser(const ApiRequest &req, ApiResponse &rsp) auth.devicetype = map["devicetype"].toString(); - // TODO check for valid devicetype - if (map.contains("username")) // optional (note username = apikey) { if ((map["username"].type() != QVariant::String) || @@ -177,6 +175,...
Fix frequency rounding
@@ -38,17 +38,17 @@ class WithTileFrequency(fMHz: Double, hartId: Option[Int] = None) extends ClockN fMHz) class WithPeripheryBusFrequencyAsDefault extends Config((site, here, up) => { - case DefaultClockFrequencyKey => (site(PeripheryBusKey).dtsFrequency.get / (1000 * 1000)).toDouble + case DefaultClockFrequencyKey =>...
ports/unix/mpconfigport_dev.h: Enable MICROPY_WARNINGS_LOC.
#define MICROPY_ENABLE_DOC_STRING (1) #define MICROPY_ENABLE_SCHEDULER (1) #define MICROPY_READER_VFS (1) +#define MICROPY_WARNINGS_LOC (1) #define MICROPY_MODULE_GETATTR (1) #define MICROPY_PY_DELATTR_SETATTR (1) #define MICROPY_PY_REVERSE_SPECIAL_METHODS (1)
mmx: add simde_x_mm_load{,u}_si64
@@ -1266,6 +1266,22 @@ simde_mm_setzero_si64 (void) { # define _mm_setzero_si64() simde_mm_setzero_si64() #endif +SIMDE_FUNCTION_ATTRIBUTES +simde__m64 +simde_x_mm_load_si64 (const void* mem_addr) { + simde__m64 r; + simde_memcpy(&r, SIMDE_ASSUME_ALIGNED_AS(simde__m64, mem_addr), sizeof(r)); + return r; +} + +SIMDE_FUN...
arch/sim: ignore return value of snd_pcm_pause/resume snd_pcm_pause, snd_pcm_resume failed with -5, -38 errno.
@@ -582,18 +582,13 @@ static int sim_audio_stop(struct audio_lowerhalf_s *dev) static int sim_audio_pause(struct audio_lowerhalf_s *dev) { struct sim_audio_s *priv = (struct sim_audio_s *)dev; - int ret; if (!priv->pcm) { return 0; } - ret = snd_pcm_pause(priv->pcm, 0); - if (ret < 0) - { - return ret; - } + snd_pcm_pa...
Move backup/restore privileges tinc tests to behave
@@ -7,6 +7,29 @@ Feature: Validate command line arguments Then gpcrondump should print no such option: -X error message And gpcrondump should return a return code of 2 + # This test deletes the gpAdminLogs/gpcrondump_*.log files, so it should stay at the top of this file + @wip + Scenario: Full Backup with -B and -l op...
Initialise the GPIO and Button HALs on Cooja startup
#include "dev/pir-sensor.h" #include "dev/vib-sensor.h" #include "dev/moteid.h" +#include "dev/button-hal.h" +#include "dev/gpio-hal.h" #include "sys/node-id.h" #include "services/rpl-border-router/rpl-border-router.h" @@ -166,6 +168,7 @@ set_lladdr(void) void platform_init_stage_one() { + gpio_hal_init(); return; } /*...
Fix meson build version.
project('janet', 'c', default_options : ['c_std=c99', 'b_lundef=false', 'default_library=both'], - version : '1.10.1-dev') + version : '1.10.1') # Global settings janet_path = join_paths(get_option('prefix'), get_option('libdir'), 'janet')