message
stringlengths
6
474
diff
stringlengths
8
5.22k
decision: write assumption about experts
@@ -13,7 +13,12 @@ But substantial decisions must be made in a transparent and participative way. - [Documentation guidelines](/doc/contrib/documentation.md) apply. - During the decision process, the PRs constantly get updated: - Make changes as new commits to the pull request. - - Questions in the PRs are answered by ...
TCPMv2: Update 'pdcable' console command This patchset adds information about cable's Thunderbolt mode response. BRANCH=none TEST=EC command "pdcable <port>" prints out the information about the cable.
@@ -114,6 +114,7 @@ static int command_cable(int argc, char **argv) struct pd_discovery *disc; enum idh_ptype ptype; int cable_rev; + union tbt_mode_resp_cable cable_mode_resp; if (argc < 2) return EC_ERROR_PARAM_COUNT; @@ -134,6 +135,9 @@ static int command_cable(int argc, char **argv) cable_rev = pd_get_vdo_ver(port,...
First pass at updating the Raspberry Pi instructions.
-# Raspberry Pi Build Instructions +# Raspberry Pi Build/Usage Instructions All of this sample code will build on a Raspberry Pi, which can then be used as an inexpensive print server or as part of an automated test framework. -Run the following command to install the software you'll need to build and + +## Prerequisit...
Restore the use of LDCMD when linking applications It is a hack, but it existed in the recently removed Makefile.shared, and its use is documented in fuzz/README.md, so we cannot drop it now. Fixes
@@ -1053,7 +1053,7 @@ EOF return <<"EOF"; $bin$exeext: $objs $deps rm -f $bin$exeext - $cmd $cmdflags \$(LDFLAGS) \$(BIN_LDFLAGS) -o $bin$exeext $objs \\ + \$\${LDCMD:-$cmd} $cmdflags \$(LDFLAGS) \$(BIN_LDFLAGS) -o $bin$exeext $objs \\ \$(PLIB_LDFLAGS) $linklibs \$(EX_LIBS) EOF }
Update cppcheck suppressions...
@@ -6,24 +6,17 @@ cert-API01-C // Don't report non-const casts. Inline suppression comments are not working, // otherwise we'd be more selective... -cert-EXP05-C:device.c -cert-EXP05-C:device-network.c -cert-EXP05-C:device-usb.c -cert-EXP05-C:link.c -cert-EXP05-C:mainloop-subcommands.c -cert-EXP05-C:resource.c -cert-EX...
Travis: Add basic Linux build
@@ -14,6 +14,8 @@ matrix: osx_image: xcode7.3 - os: osx osx_image: xcode6.4 + - os: linux + dist: trusty before_install: - | @@ -41,6 +43,12 @@ before_install: export Qt5_DIR=/usr/local/opt/qt5; brew config; fi + - | + if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then + sudo apt-get -qq update; + sudo apt-get install clang-f...
docs/usocket: getaddrinfo: Describe af/type/proto optional params. These can be optionally specified, but all ports are expected to be able to accept them, at the very least ignore, though handling of "type" param (SOCK_STREAM vs SOCK_DGRAM) is recommended.
@@ -79,19 +79,33 @@ Functions # Create DGRAM UDP socket socket(AF_INET, SOCK_DGRAM) -.. function:: getaddrinfo(host, port) +.. function:: getaddrinfo(host, port, af=0, type=0, proto=0, flags=0) Translate the host/port argument into a sequence of 5-tuples that contain all the - necessary arguments for creating a socket ...
out_syslog: use new upstream prototype for tls handling
@@ -880,7 +880,7 @@ static int cb_syslog_init(struct flb_output_instance *ins, struct flb_config *co } ctx->u = flb_upstream_create(config, ins->host.name, ins->host.port, - io_flags, (void *) &ins->tls); + io_flags, ins->tls); if (!(ctx->u)) { flb_syslog_config_destroy(ctx); return -1;
client session BUGFIX ietf-yang-library model updated and its structure changed
@@ -621,8 +621,7 @@ nc_ctx_fill_yl(struct nc_session *session, ly_module_imp_clb user_clb, void *use } data_rpl = (struct nc_reply_data *)reply; - if (!data_rpl->data || strcmp(data_rpl->data->schema->module->name, "ietf-yang-library") || - strcmp(data_rpl->data->schema->name, "modules-state")) { + if (!data_rpl->data ...
fixed some more memory bugs in poise
@@ -1153,6 +1153,8 @@ void InitializeClimateParams(BODY *body, int iBody, int iVerbose) { body[iBody].bSnowball = 0; body[iBody].dFluxInGlobal = 0; body[iBody].dIceFlowTot = 0; + body[iBody].dIceBalanceTot = 0; + body[iBody].iWriteLat = 0; if (body[iBody].bColdStart) { Toffset = -40.0; @@ -1380,6 +1382,13 @@ void Initi...
dpdk: add function to add/del extra MAC addrs Type: feature Add a callback to install or remove an additional MAC address on a DPDK-managed device. Note that some PMDs don't have support for this so YMMV.
@@ -42,6 +42,29 @@ static char *dpdk_tx_func_error_strings[] = { #undef _ }; +static clib_error_t * +dpdk_add_del_mac_address (vnet_hw_interface_t * hi, + const u8 * address, u8 is_add) +{ + int error; + dpdk_main_t *dm = &dpdk_main; + dpdk_device_t *xd = vec_elt_at_index (dm->devices, hi->dev_instance); + + if (is_add...
Feat:Modify llvm.s,appoint the fibocom_task_entry as thread entry point function
@ /* Define application-specific start/stop entry points for the module. */ - .extern test_dam_app_start + .extern fibocom_task_entry @ /* Define common external refrences. */ @@ -46,7 +46,7 @@ _txm_module_preamble: @ 1 -> MMU protection Enabled .word _txm_module_thread_shell_entry - . + . @ Module Shell Entry Point .p...
[build] autotools use AC_PROG_CC_STDC macro autotools now use AC_PROG_CC_STDC macro instead of -std=gnu99. The default in current modern gcc compilers is -std=gnu11 (Note: src/CMakeLists.txt and SConstruct still specify -std=gnu99)
@@ -62,6 +62,7 @@ AC_DEFUN([TRY_LDFLAGS], dnl Checks for programs. AC_PROG_CC +AC_PROG_CC_STDC AX_PROG_CC_FOR_BUILD AM_PROG_CC_C_O AC_PROG_LD @@ -965,7 +966,6 @@ AM_CONDITIONAL(CHECK_WITH_FASTCGI, test "x$fastcgi_found" = xyes) dnl check for extra compiler options (warning options) if test "${GCC}" = "yes"; then TRY_CF...
admin/meta-packages: include binutils for leap as well
@@ -63,9 +63,9 @@ Requires: OpenIPMI Requires: pdsh%{PROJ_DELIM} Requires: screen Requires: sudo -%if 0%{?rhel} Requires: binutils Requires: binutils-devel +%if 0%{?rhel} Requires: man-db Requires: yum-utils %endif
board/servo_v4/usb_pd_config.h: Format with clang-format BRANCH=none TEST=none Tricium: disable
@@ -193,7 +193,8 @@ static inline void pd_select_polarity(int port, int polarity) if (port == 0) { /* CHG use the right comparator inverted input for COMP2 */ STM32_COMP_CSR = (val & ~STM32_COMP_CMP2INSEL_MASK) | - (polarity ? STM32_COMP_CMP2INSEL_INM4 /* PA4: + (polarity ? + STM32_COMP_CMP2INSEL_INM4 /* PA4: C0_CC2 */...
{AH} ignore samtools idxstats usage test
@@ -266,7 +266,8 @@ class SamtoolsTest(unittest.TestCase): # ignore commands that exit or cause other failures # TODO: check - if reheader or phase is run in testStatements, sort fails # here - if command in ("view", "sort", "bam2fq", "flagstat", "reheader", "stats"): + if command in ("view", "sort", "bam2fq", "flagsta...
catboost: Fix build by removing version control conflict marker Note: mandatory check (NEED_CHECK) was skipped
@@ -588,12 +588,8 @@ const ui8* GetFeatureDataBeginPtr( consecutiveSubsetBegin, featureIdx); } else { -<<<<<<< catboost/libs/algo/index_calcer.cpp - return (**quantizedObjectsData.GetBinaryFeaturesPack((*packedIdx)[featureIdx]->PackIdx).GetSrc()).data(); -======= return (**quantizedObjectsData.GetBinaryFeaturesPack( (*...
[mod_magnet] lighty.c.quotedenc(),dec() funcs lighty.c.quotedenc() and lighty.c.quoteddec() convenience functions to encode and decode MIME quoted-string, e.g. quoted-string formats in HTTP headers.
@@ -935,6 +935,61 @@ static int magnet_hexenc(lua_State *L) { return 1; /* uppercase hex string; use lua s = s:lower() to lowercase */ } +static int magnet_quoteddec(lua_State *L) { + if (lua_isnoneornil(L, -1)) { + lua_pushlstring(L, "", 0); + return 1; + } + const_buffer s = magnet_checkconstbuffer(L, -1); + if (0 ==...
esp32/modnetwork: Add network.(W)LAN.ifconfig('dhcp') support.
@@ -461,6 +461,7 @@ STATIC mp_obj_t esp_ifconfig(size_t n_args, const mp_obj_t *args) { return mp_obj_new_tuple(4, tuple); } else { // set + if (MP_OBJ_IS_TYPE(args[1], &mp_type_tuple) || MP_OBJ_IS_TYPE(args[1], &mp_type_list)) { mp_obj_t *items; mp_obj_get_array_fixed_n(args[1], 4, &items); netutils_parse_ipv4_addr(it...
Extract String literal to static constant
@@ -9,6 +9,9 @@ import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; public class ClipboardManager { + + private static final String PACKAGE_NAME = "com.android.shell"; + private final IInterface manager; private Method getPrimaryClipMethod; private Method setPrimaryClipMethod; @@ -45,7 ...
vere: fix -Y (should not be resolved)
@@ -251,7 +251,7 @@ _main_getopt(c3_i argc, c3_c** argv) break; } case 'Y': { - u3_Host.ops_u.puk_c = _main_repath(optarg); + u3_Host.ops_u.puk_c = strdup(optarg); break; } case 'Z': {
Upgrading to boost1.67
@@ -7,9 +7,11 @@ matrix: addons: apt: sources: + - sourceline: 'ppa:mhier/libboost-latest' - ubuntu-toolchain-r-test packages: - g++-7 + - boost1.67 env: - MATRIX_EVAL="CC=gcc-7 && CXX=g++-7" @@ -27,8 +29,8 @@ before_install: - eval "${MATRIX_EVAL}" install: - - sudo apt-get install -y libboost-test-dev - - sudo apt-ge...
relay: ensure numeric options have numeric arguments Issue revealed that -m silently accepted a bogus option, leading to undefined (faulty) behaviour.
@@ -509,7 +509,9 @@ main(int argc, char * const argv[]) break; case 'L': maxstalls = atoi(optarg); - if (maxstalls < 0 || maxstalls >= (1 << SERVER_STALL_BITS)) { + if (maxstalls < 0 || maxstalls >= (1 << SERVER_STALL_BITS) || + !isdigit(*optarg)) + { fprintf(stderr, "error: maximum stalls needs to be a number " "betwe...
tests: test_pipe.py. Fix missing import. * Fix missing import (does not impact 'make test', fixes issue running under 'make test-shell')
#!/usr/bin/env python from socket import AF_INET, AF_INET6, inet_pton - -from framework import VppTestCase, VppTestRunner -from vpp_interface import VppInterface -from vpp_ip_route import VppIpTable, VppIpRoute, VppRoutePath +import unittest from scapy.packet import Raw from scapy.layers.l2 import Ether from scapy.laye...
RPM spec update.
Name: libneat -Version: 1.0.2~td5 +Version: 1.0.2~rc5.1 Release: 1 Summary: NEAT Project License: BSD Group: Applications/Internet URL: https://github.com/NEAT-project/neat -Source: %{name}-%{version}.tar.gz +Source: %{name}-%{version}.tar.xz AutoReqProv: on BuildRequires: cmake
doc: PG 12 relnotes, add item - pg_test_fsync fix on Windows Reported-by: Laurenz Albe Discussion: Backpatch-through: 12
@@ -2833,6 +2833,20 @@ Author: Andrew Dunstan <andrew@dunslane.net> </para> </listitem> + <listitem> +<!-- +Author: Michael Paquier <michael@paquier.xyz> +2018-09-14 [0ba06e0bf] Allow concurrent-safe open() and fopen() in frontend +2018-09-20 [40cfe8606] Enforce translation mode for Windows frontends to text +--> + + <...
docs: rely on alternative approach to fix munge file permissions
@@ -7,9 +7,6 @@ pool, issue the following: \begin{lstlisting}[language=bash,literate={-}{-}1,keywords={},upquote=true] [sms](*\#*) echo "/etc/slurm/slurm.conf -> /etc/slurm/slurm.conf" >> /install/custom/netboot/compute.synclist [sms](*\#*) echo "/etc/munge/munge.key -> /etc/munge/munge.key" >>/install/custom/netboot/c...
Specify prefix for lcov output. This prevents pages from moving around depending on the subtest.
@@ -1178,6 +1178,7 @@ eval { executeTest( "genhtml ${strLCovFile} --config-file=${strBackRestBase}/test/src/lcov.conf" . + " --prefix=${strBackRestBase}/test/.vagrant/code" . " --output-directory=${strBackRestBase}/test/coverage/c"); foreach my $strCodeModule (sort(keys(%{$hCoverageActual})))
Suggest that BSD users compile with gcc
@@ -68,6 +68,10 @@ configure: LDFLAGS="-L/some/directory" \ ./configure ... +On BSD, you may want to compile with `gcc` instead of `clang` by first installing `gcc`, and then specifying its path in the `CC` environment variable when configuring: + + CC=/usr/local/bin/gcc9 ./configure + Once you have configured things, ...
Fix dealing with array types when getting method parameters
@@ -256,6 +256,12 @@ HRESULT Library_corlib_native_System_Reflection_MethodBase::GetParametersNative_ hbObj = paraTypeHB.Dereference(); hbObj->SetReflection(paramElement.m_cls); + // deal with array types + if (paramElement.m_levels > 0) + { + hbObj->ReflectionData().m_levels = (CLR_UINT16)paramElement.m_levels; + } + ...
ExtendedTools: Fix regression (reported by MarekKnapek)
@@ -307,8 +307,9 @@ VOID EtpProcessDiskPacket( { diskItem->ProcessItem = processItem; PhSetReference(&diskItem->ProcessName, processItem->ProcessName); + + PhReferenceProcessRecord(processItem->Record); diskItem->ProcessRecord = processItem->Record; - PhReferenceProcessRecord(diskItem->ProcessRecord); if (!diskItem->Pr...
doc: incorporate suggestions from
@@ -296,8 +296,8 @@ following 2 checklists: ### Consistency -- [ ] Consistent naming schemes for enums, macros, typedefs and functions (called components below) -- [ ] Similar things are named similarly +- [ ] Consistent naming schemes for enums, macros, typedefs and functions +- [ ] Same things are named the same and ...
Increase column order limiting (https://wj32.org/processhacker/forums/viewtopic.php?t=2798)
@@ -214,7 +214,7 @@ INT_PTR CALLBACK PhpColumnsDlgProc( break; case IDOK: { -#define ORDER_LIMIT 100 +#define ORDER_LIMIT 200 PPH_LIST activeList; ULONG activeCount; ULONG i;
add section on network device to README
@@ -83,6 +83,31 @@ By passing the +blkdev argument on the simulator command line, you can allow the RTL simulation to read and write from a file. Take a look at tests/blkdev.c for an example of how Rocket can program the block device controller. +## Using the network device + +Testchipip also includes a basic ethernet ...
Add Double inside meta visitor of Converter
@@ -14,6 +14,7 @@ auto s_metaVisitor = [](auto... args) { LuaRED<uint32_t, "Uint32">(), LuaRED<uint64_t, "Uint64">(), LuaRED<float, "Float">(), + LuaRED<double, "Double">(), LuaRED<bool, "Bool">(), LuaRED<Quaternion, "Quaternion">(), LuaRED<Vector3, "Vector3">(),
Updated error message and setting origvalue only before transformations
@@ -160,6 +160,7 @@ int elektraMacaddrGet (Plugin * handle ELEKTRA_UNUSED, KeySet * returned, Key * if (rc != VALIDATION_ISINT) { + keySetMeta (cur, "origvalue", keyString (cur)); transformMac (cur); } } @@ -188,12 +189,10 @@ int elektraMacaddrSet (Plugin * handle ELEKTRA_UNUSED, KeySet * returned, Key * { ELEKTRA_SET_...
Fix misbehavior of H09 server on delayed FIN
@@ -964,6 +964,7 @@ int picoquic_h09_server_process_data(picoquic_cnx_t* cnx, } /* if FIN present, process request through http 0.9 */ + if (stream_ctx->ps.hq.status != picohttp_server_stream_status_finished) { if (fin_or_event == picoquic_callback_stream_fin || (stream_ctx->method == 0 && stream_ctx->ps.hq.status == p...
modernize straggling reference to %aver
?- sign [%b %wake *] (on-take-wake:event-core wire error.sign) :: - [%c %done *] (on-aver:event-core wire error.sign) - [%g %done *] (on-aver:event-core wire error.sign) - [%j %done *] (on-aver:event-core wire error.sign) + [%c %done *] (on-done:event-core wire error.sign) + [%g %done *] (on-done:event-core wire error....
Reinstate code setting desired ghost data type
@@ -990,6 +990,10 @@ avtVolumeFilter::ModifyContract(avtContract_p contract) if (atts.GetScaling() == VolumeAttributes::Linear) { + if ((atts.GetRendererType() == VolumeAttributes::RayCasting) && + (atts.GetSampling() == VolumeAttributes::Trilinear)) + ds->SetDesiredGhostDataType(GHOST_ZONE_DATA); + newcontract = new a...
MARS Streams: rename streams (case)
1054 rjtd Tokyo 1055 cwao Montreal 1056 ammc Melbourne -1057 efas European Flood Awareness System (EFAS) -1058 efse European Flood Awareness System (EFAS) seasonal forecasts -1059 efcl European Flood Awareness System (EFAS) climatology +1057 efas European flood awareness system (EFAS) +1058 efse European flood awarenes...
Comment why is used
@@ -540,6 +540,8 @@ class NameCheck(): self.set_return_code(2) raise error finally: + # Put back the original config regardless of there being errors. + # Works also for keyboard interrupts. shutil.move("include/mbedtls/mbedtls_config.h.bak", "include/mbedtls/mbedtls_config.h")
YAML: Remove trailing dot from non-sentences
@@ -187,10 +187,10 @@ static parserType * getNextChar (parserType * parser) static parserType * putBackChar (parserType * parser) { ASSERT_NOT_NULL (parser); - ELEKTRA_ASSERT (parser->buffer - 1 >= parser->bufferBase, "Can not put back more characters than available."); + ELEKTRA_ASSERT (parser->buffer - 1 >= parser->b...
Updated travis yml to reflect latest storage.
@@ -10,23 +10,19 @@ compiler: env: - CONFIGURE_OPTIONS="" - CONFIGURE_OPTIONS="--enable-geoip=legacy --enable-utf8" - - CONFIGURE_OPTIONS="--enable-geoip=legacy --enable-utf8 --enable-tcb=btree --disable-bzip --disable-zlib" - - CONFIGURE_OPTIONS="--enable-geoip=legacy --enable-utf8 --enable-tcb=memhash --disable-bzip ...
remove HSA_XNACK alltogether
@@ -136,9 +136,3 @@ else RUNENV = env $(SET_DEVICE_DEBUG) $(TKILL) endif -ifeq ($(HSA_XNACK),1) -# this causes issues on amd-stg-open, as the flag -offload-arch -# does not exist. it incorrectly becomes -o ffload-arch -# OMP_FLAGS += -offload-usm -echo not settting -offload-usm -endif
Deleting blanks in the line end
@@ -100,7 +100,6 @@ void fill_vnode_array(snapu32_t vex_num, VexNode * vex_array, snapu64_t address { xfer_bytes = read_bulk(src_mem, address + address_xfer_offset, left_bytes, block_buf); - ap_uint<VEX_WIDTH> iii, jjj; for(iii = 0; iii < xfer_bytes/sizeof(VexNode); iii++) @@ -118,7 +117,6 @@ void fill_vnode_array(snap...
common/led_policy_std.c: Format with clang-format BRANCH=none TEST=none
#define POWER_LED_OFF 0 #endif -const enum ec_led_id supported_led_ids[] = { - EC_LED_ID_BATTERY_LED, EC_LED_ID_POWER_LED}; +const enum ec_led_id supported_led_ids[] = { EC_LED_ID_BATTERY_LED, + EC_LED_ID_POWER_LED }; const int supported_led_ids_count = ARRAY_SIZE(supported_led_ids); @@ -108,15 +108,18 @@ int led_set_b...
Document SSL_CIPHER_get_handshake_digest()
=head1 NAME -SSL_CIPHER_get_cipher_nid, SSL_CIPHER_get_digest_nid, SSL_CIPHER_get_kx_nid, -SSL_CIPHER_get_auth_nid, SSL_CIPHER_is_aead, -SSL_CIPHER_get_name, SSL_CIPHER_get_bits, -SSL_CIPHER_get_version, SSL_CIPHER_description +SSL_CIPHER_get_name, +SSL_CIPHER_get_bits, +SSL_CIPHER_get_version, +SSL_CIPHER_description,...
ic-proxy: correct SIGHUP handler Fixed the bug that the SIGHUP handler was installed for SIGINT by mistake, so the ic-proxy bgworkers would die on SIGHUP. By correcting the signal name, now we could let the ic-proxy bgworkers reload the postgresql.conf by executing "gpstop -u".
@@ -406,7 +406,7 @@ ic_proxy_server_main(void) uv_signal_start(&ic_proxy_server_signal_hup, ic_proxy_server_on_signal, SIGHUP); uv_signal_init(&ic_proxy_server_loop, &ic_proxy_server_signal_int); - uv_signal_start(&ic_proxy_server_signal_hup, ic_proxy_server_on_signal, SIGINT); + uv_signal_start(&ic_proxy_server_signal...
server_shutdown: ensure secondaries are stopped if secondaries are still running when we exit shutdown, server_free may result in invalid reads (of freed memory)
@@ -788,6 +788,12 @@ server_shutdown(server *s) if (inqueue != 0) for (i = 0; i < s->secondariescnt; i++) __sync_add_and_fetch(&(s->secondaries[i]->failure), 1); + /* wait for the secondaries to be stopped so we surely don't get + * invalid reads when server_free is called */ + for (i = 0; i < s->secondariescnt; i++) {...
Add boot serial on Mynewt docs
@@ -36,3 +36,17 @@ different TLV structure, so images created by `newt` have to be generated in this new format. That is done by passing the extra parameter `-2` as in: `newt create-image <target> <version> <pubkey> -2` + +# Boot serial functionality with Mynewt + +Building with `BOOT_SERIAL: 1` enables some basic mana...
reduction define
#define S_DISCRETE_INPUT_NDISCRETES 16 #define S_COIL_START 0 #define S_COIL_NCOILS 64 -#define S_REG_INPUT_START (0x0000) -#define S_REG_INPUT_NREGS (0x0006 - 0x0000) +#define S_REG_INPUT_START 0 +#define S_REG_INPUT_NREGS 100 #define S_REG_HOLDING_START 0 -#define S_REG_HOLDING_NREGS (0x004B) +#define S_REG_HOLDING_N...
Clear additional global state between unit test runs Clears out some global state that was being left over between unit tests runs, causing indeterminate results when running multiple tests against data at the global scope.
-- individual test runs. --- + local numBuiltInGlobalBlocks + function api.reset() + if numBuiltInGlobalBlocks == nil then + numBuiltInGlobalBlocks = #api.scope.global.blocks + end + for containerClass in p.container.eachChildClass(p.global) do api.scope.global[containerClass.pluralName] = {} end + + api.scope.current ...
Let graphs take up full content region
@@ -420,12 +420,12 @@ void HudElements::frame_timing(){ ImGui::PlotHistogram(hash, get_time_stat, HUDElements.sw_stats, ARRAY_SIZE(HUDElements.sw_stats->frames_stats), 0, NULL, min_time, max_time, - ImVec2(ImGui::GetContentRegionAvailWidth() * 2.5, 50)); + ImVec2(ImGui::GetContentRegionAvailWidth() * HUDElements.params...
StartupAddressMode wasn't being handled on NetworkInterface get/update
@@ -41,6 +41,7 @@ HRESULT Library_sys_net_native_System_Net_NetworkInformation_NetworkInterface::I pConfig[ FIELD___networkInterfaceType ].SetInteger( (CLR_UINT32)config.InterfaceType); pConfig[ FIELD___specificConfigId ].SetInteger( (CLR_UINT32)config.SpecificConfigId); + pConfig[ FIELD___startupAddressMode ].SetInteg...
fix collections config
++ txt |= txs=(pole @t) ^- config:collections + :: TODO: putting ~ instead of * breaks this but shouldn't + :: ?> ?= $: full-path=@t name=@t desc=@t com=@t sk=@t vis=@t - ~ + * == txs :: - %- (hard config:collections) :* %- need %+ rash full-path.txs ;~ pfix (jest 'full-path: ') :: (rash owner.txs ;~(pfix (jest 'owner:...
cppcheck warning: knownConditionTrueFalse
@@ -1294,9 +1294,9 @@ static int stream_seek(void* data, off_t len) static size_t stream_read(void* data, void* buffer, size_t len, int* err) { stream_struct* s = (stream_struct*)data; - long n = len; + long n = 0; - if (n != len) { + if (len > LONG_MAX) { /* size_t cannot be coded into long */ *err = GRIB_INTERNAL_ERR...
Warning is fixed.
@@ -854,7 +854,7 @@ struct xdag_block* xdag_create_block(struct xdag_field *fields, int inputsCount, int res0 = 1 + inputsCount + outputsCount + 3 * nkeysnum + (outsigkeyind < 0 ? 2 : 0); if (res0 > XDAG_BLOCK_FIELDS) { - return -1; + return NULL; } if (!send_time) {
Fixed buffer size in `ZydisPerfTest`
@@ -331,7 +331,7 @@ static void TestPerformance(const ZyanU8* buffer, ZyanUSize length, ZyanBool min count += ProcessBuffer(&decoder, &formatter, /* cache, */ buffer, length, minimal_mode, format, tokenize, use_cache); } - const char* color[3]; + const char* color[4]; color[0] = minimal_mode ? CVT100_OUT(COLOR_VALUE_G)...
fix division by zero in vna.c
@@ -183,7 +183,7 @@ int main(int argc, char *argv[]) pthread_detach(thread); for(i = 0; i < size; ++i) { - freq = start + (stop - start) * i / (size - 1); + freq = i > 0 ? start + (stop - start) * i / (size - 1) : start; freq *= (1.0 + 1.0e-9 * corr); *rx_freq = (uint32_t)floor(freq / 125.0e6 * (1<<30) + 0.5); }
feat: include add-ons
@@ -51,7 +51,7 @@ BOTZ_SRC := $(patsubst %c, %.bz, $(BOTZ_SRC)) TEST_SRC := $(wildcard test/test-*.cpp test/test-*.c) TEST_EXES := $(filter %.exe, $(TEST_SRC:.cpp=.exe) $(TEST_SRC:.c=.exe)) -LIBDISCORD_CFLAGS := -I./ -I./mujs -I./sqlite3 -I./jsB +LIBDISCORD_CFLAGS := -I./ -I./mujs -I./sqlite3 -I./add-ons LIBDISCORD_LDF...
[core] comment out unused part of http_etag_remix note: etag buffer etag->ptr might be NULL (etag->used = etag->sze = 0) so buffer will need to be extended, not truncated, in that case. buffer_string_set_length() is typically used to truncate strings.
@@ -47,11 +47,15 @@ static void http_etag_remix (buffer * const etag, const char * const str, const uint32_t len) { uint32_t h = dekhash(str, len, len); /*(pass len as initial hash value)*/ + #if 0 /*(currently never elen > 2; always cleared in http_etag_create())*/ uint32_t elen = buffer_string_length(etag); if (elen ...
cleanup complement's help
@@ -16,6 +16,8 @@ void complement_help(void) { cerr << "Usage: " << "bedtools complement" << " [OPTIONS] -i <bed/gff/vcf> -g <genome>" << endl << endl; + cerr << "Options: " << endl; + cerr << "\t-L\t" << "Limit output to solely the chromosomes with records in the input file." << endl << endl; cerr << "Notes: " << endl...
Solve bug in NodeJS Addon API.
# NODEJS_ADDON_API_INCLUDE_DIR - NodeJS Addon API headers path # Prevent vervosity if already included -if(NODEJS_ADDON_API_INCLUDE_DIR) +if(NODEJS_ADDON_API_FOUND) set(NODEJS_ADDON_API_FIND_QUIETLY TRUE) endif() +set(NODEJS_ADDON_API_INCLUDE_DIR "" CACHE PATH "NodeJS Addon API headers path") + # Include package manage...
Fix collision bug at bottom edge of screen
@@ -1021,6 +1021,12 @@ UBYTE SceneNpcAt_b(UBYTE index, UBYTE tx_a, UBYTE ty_a) } tx_b = DIV_8(ACTOR_X(ptr)); ty_b = DIV_8(ACTOR_Y(ptr)); + if (ty_b == 0) + { + // If actor at posY=256 (really 0 since 8bit) convert to correct tile + // since DIV_8 will give tile as 0 rather than 32 + ty_b = 32; + } if ((ty_a == ty_b || ...
gitlab/ci: reverting --track-origins=yes flag for valgrind
@@ -52,7 +52,8 @@ examples-memcheck: stage: test script: - make -j4 examples - - ls examples/*_example | sed -E "s#examples/(.*)#valgrind --tool=memcheck --track-origins=yes --log-file=examples/\1.log ./examples/\1#g" > run_examples_valgrind.sh + # setting --track-origins=yes gives more detail but takes longer than git...
Do not send options multiple times in build_startup_packet() This patch also tweak the related code a bit.
@@ -2238,55 +2238,20 @@ build_startup_packet(const PGconn *conn, char *packet, /* GPSQL: */ if (conn->dboid && conn->dboid[0]) - { - if (packet) - strcpy(packet + packet_len, "dboid"); - packet_len += strlen("dboid") + 1; - if (packet) - strcpy(packet + packet_len, conn->dboid); - packet_len += strlen(conn->dboid) + 1;...
Renamed IXML export
@@ -50,7 +50,7 @@ SET_TARGET_PROPERTIES(ixml_shared PROPERTIES ) INSTALL (TARGETS ixml_shared - EXPORT IXMLCONFIG + EXPORT IXML DESTINATION ${CMAKE_INSTALL_LIBDIR} INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/upnp PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/upnp @@ -88,11 +88,11 @@ TARGET_INCLUDE_DIRECTOR...
Fix CID#1458569
@@ -2321,6 +2321,10 @@ void uvpollable_cb(uv_poll_t *handle, int status, int events) if (status < 0) { nt_log(ctx, NEAT_LOG_DEBUG, "ERROR: %s", uv_strerror(status)); + if (!flow) { + return; + } + #if !defined(USRSCTP_SUPPORT) if (nt_base_stack(pollable_socket->stack) == NEAT_STACK_TCP || nt_base_stack(pollable_socket-...
makefile changes for NOLAPACKE
@@ -51,6 +51,13 @@ else endif +ifeq ($(UNAME),Cygwin) + BUILDTYPE = Cygwin + NOLAPACKE ?= 1 +endif + + + # Paths @@ -179,6 +186,11 @@ TMRI += ismrmrd MODULES_bart += -lismrm endif +ifeq ($(NOLAPACKE),1) +MODULES += -llapacke +endif + + XTARGETS += $(TBASE) $(TFLP) $(TNUM) $(TIO) $(TRECO) $(TCALIB) $(TMRI) $(TSIM) TARGE...
M487 fix project file wrong ggd lib name
<RestoreSysVw>1</RestoreSysVw> </Target> <RunDebugAfterBuild>0</RunDebugAfterBuild> - <TargetSelection>-1</TargetSelection> + <TargetSelection>20</TargetSelection> <SimDlls> <CpuDll></CpuDll> <CpuDllArguments></CpuDllArguments> <GroupName>lib-grenngrass</GroupName> <Files> <File> - <FileName>aws_mqtt_agent.c</FileName>...
usdt.py: improve error messags for enable_probe()
@@ -149,20 +149,18 @@ class USDT(object): if lib.bcc_usdt_enable_probe(self.context, probe.encode('ascii'), fn_name.encode('ascii')) != 0: raise USDTException( - ("failed to enable probe '%s'; a possible cause " + - "can be that the probe requires a pid to enable") % - probe - ) +"""Failed to enable USDT probe '%s': +t...
vmkit: added delay at VMkit monitor startup to wait required modules
#include <stdio.h> #include <stdlib.h> #include <barrelfish/barrelfish.h> +#include <barrelfish/sys_debug.h> #include <barrelfish/nameservice_client.h> #include <barrelfish/terminal.h> #include <vfs/vfs.h> #include <pci/pci.h> #define VFS_MOUNTPOINT "/vm" -#define IMAGEFILE (VFS_MOUNTPOINT "/system-bench.img") +#define...
Advertise support for "fetchable" jobs.
@@ -675,11 +675,24 @@ serverCreatePrinter( }; static const char * const which_jobs[] = { /* which-jobs-supported values */ + "aborted", + "all", + "canceled", "completed", "not-completed", + "pending", + "pending-held", + "processing", + "processing-stopped" + }; + static const char * const which_jobs_proxy[] = + { /* ...
Roll back the previous "pixel swizzler" commit See the previous commit for the rationale.
@@ -15269,7 +15269,7 @@ wuffs_base__pixel_swizzler__bgr_565__index_bgra_nonpremul__src_over( // TODO: unroll. while (n >= 1) { - uint32_t d0 = ( + uint32_t d0 = wuffs_base__color_u16_rgb_565__as__color_u32_argb_premul( wuffs_base__peek_u16le__no_bounds_check(d + (0 * 2))); uint32_t s0 = wuffs_base__peek_u32le__no_bound...
libc/string: fix typo, CONFIGC_ARCH_STPNCPY CONFIG'C'_ is a typo, let's remove 'C'.
* ****************************************************************************/ -#ifndef CONFIGC_ARCH_STPNCPY +#ifndef CONFIG_ARCH_STPNCPY FAR char *stpncpy(FAR char *dest, FAR const char *src, size_t n) { FAR char *end = dest + n; /* End of dest buffer + 1 byte */
Fix setting of compiler definition for RTM
@@ -135,7 +135,7 @@ function(NF_SET_COMPILER_DEFINITIONS TARGET) # set compiler definition for RTM build option if(NF_BUILD_RTM) - target_compile_definitions(${TARGET} PUBLIC BUILD_RTM) + target_compile_definitions(${TARGET} PUBLIC -DBUILD_RTM) endif() # set compiler definition for using Application Domains feature
assert: fix C++ STL container tostr when compiled with older gcc > Until CWG 1558 (a C++11 defect), unused parameters in alias templates were not guaranteed to ensure SFINAE and could be ignored, so earlier compilers require a more complex definition of void_t,
@@ -36,8 +36,11 @@ extern "C" char *cr_user_wcs_tostr(const wchar_t **); namespace criterion { namespace internal { namespace stream_override { -template< class... > -using __void_t = void; +template< class... T> +struct make_void { typedef void type; }; + +template< class... T> +using __void_t = typename make_void<T.....
add odom init
@@ -57,6 +57,14 @@ void setup() odom_pose[1] = 0.0; odom_pose[2] = 0.0; + odom.pose.pose.position.x = odom_pose[0]; + odom.pose.pose.position.y = odom_pose[1]; + odom.pose.pose.position.z = 0; + odom.pose.pose.orientation = tf::createQuaternionFromYaw(odom_pose[2]); + + odom.twist.twist.linear.x = 0.0; + odom.twist.twi...
Maximum offset is now NGTCP2_MAX_VARINT
@@ -2127,7 +2127,7 @@ static ssize_t conn_decrypt_pkt(ngtcp2_conn *conn, uint8_t *dest, static void conn_extend_max_stream_offset(ngtcp2_conn *conn, ngtcp2_strm *strm, size_t datalen) { - if (strm->unsent_max_rx_offset <= UINT64_MAX - datalen) { + if (strm->unsent_max_rx_offset <= NGTCP2_MAX_VARINT - datalen) { strm->u...
Remove pg_regress' --load-language option. We haven't used this option since inventing extensions. As of commit it's actually formally equivalent to --load-extension, so let's just drop it. Discussion:
@@ -76,7 +76,6 @@ char *inputdir = "."; char *outputdir = "."; char *bindir = PGBINDIR; char *launcher = NULL; -static _stringlist *loadlanguage = NULL; static _stringlist *loadextension = NULL; static int max_connections = 0; static int max_concurrent_tests = 0; @@ -1997,16 +1996,6 @@ create_database(const char *dbnam...
[persistence] simple refactoring of construct_item_attr
@@ -238,10 +238,11 @@ static void lrec_attr_print(lrec_attr_info *attr) (attr->mflags & COLL_META_FLAG_READABLE ? 1 : 0)); } -static inline void do_construct_item_attr(char *ptr, int size, item_attr *attr) +static inline void do_construct_item_attr(char *ptr, item_attr *attr) { lrec_attr_info info; - memcpy(&info, (cha...
nat: fix coverity 249178 Zero-initialize the variable Type: fix
@@ -1346,7 +1346,7 @@ nat44_ed_in2out_slow_path_node_fn_inline (vlib_main_t *vm, udp_header_t *udp0; icmp46_header_t *icmp0; snat_session_t *s0 = 0; - clib_bihash_kv_16_8_t kv0, value0; + clib_bihash_kv_16_8_t kv0 = { 0 }, value0; int translation_error = NAT_ED_TRNSL_ERR_SUCCESS; b0 = *b;
Remove array initializer
@@ -111,7 +111,7 @@ static void compute_angular_offsets( promise(weight_count > 0); promise(max_angular_steps > 0); - alignas(ASTCENC_VECALIGN) int isamplev[BLOCK_MAX_WEIGHTS] { 0 }; + alignas(ASTCENC_VECALIGN) int isamplev[BLOCK_MAX_WEIGHTS]; // Precompute isample; arrays are always allocated 64 elements long for (uns...
fpgaflash: include fpgaflash in tools rpm Update CMakeLists.txt so that fpgaflash is included in the tools rpm. The tool will be installed into /usr/bin.
@@ -94,6 +94,7 @@ add_subdirectory(tools/mmlink) add_subdirectory(tools/coreidle) add_subdirectory(tools/fpgaconf) add_subdirectory(tools/fpgabist) +add_subdirectory(tools/fpgaflash) add_subdirectory(tools/fpgainfo) add_subdirectory(tools/c++utils) add_subdirectory(tools/libopae++) @@ -192,6 +193,7 @@ define_pkg(tools ...
check_formatting: skip reformat-source if not available Previously check_formatting is aborted if clang-format is not found. After this commit the behaviour of missing cmake_format is replicated and only the portion that is relying on the command is skipped.
@@ -5,7 +5,6 @@ echo ELEKTRA CHECK FORMATTING echo command -v git >/dev/null 2>&1 || { echo "git command needed for this test, aborting" >&2; exit 0; } -command -v clang-format-5.0 >/dev/null 2>&1 || command -v clang-format >/dev/null 2>&1 || { echo "clang-format command needed for this test, aborting" >&2; exit 0; } c...
api: try to fix link
@@ -3,4 +3,4 @@ This folder contains information for contributors to Elektra. - [Documentation Guidelines](documentation.md) - [Copy on Write](copy_on_write.md) - [mmapstorage](mmapstorage.md) -- [API](api/README.md) Everything related to API design, review, maintenance etc. +- [API](api/) Everything related to API des...
Fix failure to check result of bn_rshift_fixed_top Fixes
@@ -446,8 +446,10 @@ int bn_div_fixed_top(BIGNUM *dv, BIGNUM *rm, const BIGNUM *num, snum->neg = num_neg; snum->top = div_n; snum->flags |= BN_FLG_FIXED_TOP; - if (rm != NULL) - bn_rshift_fixed_top(rm, snum, norm_shift); + + if (rm != NULL && bn_rshift_fixed_top(rm, snum, norm_shift) == 0) + goto err; + BN_CTX_end(ctx)...
print warning if packets with the same time stamp are detected
@@ -260,6 +260,8 @@ FILE *fheapol; FILE *fhnetwork; bool tscleanflag; +bool tssameflag; + int endianess; int pcapreaderrors; unsigned long long int rawpacketcount; @@ -273,6 +275,9 @@ uint8_t myaktnonce[32]; uint8_t filtermac[6]; +uint32_t tv_sec_old; +uint32_t tv_usec_old; + char pcapnghwinfo[1024]; char pcapngosinfo[...
genvif: XID_SOP BRANCH=none TEST=verify XML output Tested-by: Denis Brockus
@@ -1888,9 +1888,13 @@ static void init_vif_component_pd_dual_role_fields( static void init_vif_component_sop_discovery_fields( struct vif_field_t *vif_fields) { - if (IS_ENABLED(CONFIG_USB_PD_TCPMV2)) { char hex_str[10]; + set_vif_field(&vif_fields[XID_SOP], + "XID_SOP", + "0", + "0"); + #if defined(CONFIG_USB_PID) sp...
stm32/mboot: Add documentation for using mboot on PYBv1.x.
@@ -76,3 +76,44 @@ How to use 5. Use either USB DFU or I2C to download firmware. The script mboot.py shows how to communicate with the I2C boot loader interface. It should be run on a pyboard connected via I2C to the target board. + +Example: Mboot on PYBv1.x +------------------------- + +By default mboot is not used o...
external/iotivity: use snprintf instaed of sprintf Replace sprintf to snprintf for safety
@@ -819,7 +819,7 @@ OCStackResult BuildStringFromActionSet(OCActionSet* actionset, char** desc) actionTypeStr = (char *)OICMalloc(1024); if(actionTypeStr != NULL) { - sprintf(actionTypeStr, "%ld %u", actionset->timesteps, actionset->type); + snprintf(actionTypeStr, sizeof(actionTypeStr), "%ld %u", actionset->timesteps,...
Added missing SceLibc exports. The variable is the mspace libc uses for its heap allocations. mspace_create_internal is what is used internally for mspace creation. No limitations on the flags used for creation.
@@ -4439,6 +4439,7 @@ modules: mktime: 0xD1A2DFC3 mspace_calloc: 0x30470BBA mspace_create: 0xCEF7C575 + mspace_create_internal: 0x0B0341EB mspace_create_with_flag: 0x055FCBC9 mspace_destroy: 0x30CBBC66 mspace_free: 0x3CDFD2A3 @@ -4642,6 +4643,7 @@ modules: _Stdout: 0x5D8C1282 _Tolotab: 0xD662E07C _Touptab: 0x36878958 +...
move alua.c from libtcmu to runner This make alua.c runner specific.
@@ -38,7 +38,6 @@ add_library(tcmu SHARED configfs.c api.c - alua.c libtcmu.c libtcmu-register.c tcmuhandler-generated.c @@ -66,7 +65,6 @@ install(TARGETS tcmu LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}) add_library(tcmu_static configfs.c api.c - alua.c libtcmu.c libtcmu-register.c tcmuhandler-generated.c @@ -86,6 +84...
Remove unintended return statements
@@ -1250,7 +1250,6 @@ int Handler::http_send_stop_sending(int64_t stream_id, rv != 0) { std::cerr << "ngtcp2_conn_shutdown_stream_read: " << ngtcp2_strerror(rv) << std::endl; - return -1; if (rv == NGTCP2_ERR_STREAM_NOT_FOUND) { return 0; } @@ -1277,7 +1276,6 @@ int Handler::http_reset_stream(int64_t stream_id, uint64_...
os: Add support for nconfig frontend 'make nconfig' This patch is ported from Nuttx to support 'make nconfig'.
@@ -240,7 +240,7 @@ BIN = $(BIN_DIR)/$(BIN_EXE) memstat: $(BIN) all: memstat -.PHONY: context clean_context check_context export subdir_clean clean subdir_distclean distclean apps_clean apps_distclean force_build applist appupdate +.PHONY: context clean_context check_context config oldconfig menuconfig nconfig qconfig ...
SM5803: Expand charger dump Add some base page registers to charger dump. BRANCH=None TEST=on drawlat, confirm base register section prints
@@ -859,6 +859,17 @@ static int command_sm5803_dump(int argc, char **argv) if (argc > 1) chgnum = atoi(argv[1]); + /* Dump base regs */ + ccprintf("BASE regs\n"); + for (reg = 0x01; reg <= 0x30; reg++) { + if (!main_read8(chgnum, reg, &regval)) + ccprintf("[0x%02X] = 0x%02x\n", reg, regval); + if (reg & 0xf) { + cflush...
Fix Makefile passing build type too late and some other improvements Adds BUILD_DIR config option Adds BUILD_TYPE config option (i.e. Release, Debug, etc). Default set to RelWithDebInfo. Closes
@@ -10,11 +10,14 @@ WITH_SHARED_LIBUV ?= OFF WITH_LUA_ENGINE ?= LuaJIT LUA_BUILD_TYPE ?= Static LUA_COMPAT53_DIR ?= deps/lua-compat-5.3 +BUILD_DIR ?= build +# options: Release, Debug, RelWithDebInfo, MinSizeRel +BUILD_TYPE ?= RelWithDebInfo ifeq ($(WITH_LUA_ENGINE), LuaJIT) - LUABIN=build/luajit + LUABIN=$(BUILD_DIR)/l...
Fix link to libsbp html docs
@@ -46,7 +46,7 @@ a static library `libsbp-static`. ## Usage For now, documentation for libsbp is available with -[libswiftnav](http://docs.swift-nav.com/libswiftnav/group__sbp.html). A +[libswiftnav](https://swift-nav.github.io/libsbp/c/build/docs/html). A separate tutorial for applying SBP is at https://github.com/sw...
hfuzz-cc: remove sanitizer-coverage-block-threshold
@@ -168,8 +168,6 @@ static void commonOpts(int *j, char **args) args[(*j)++] = "-mllvm"; args[(*j)++] = "-sanitizer-coverage-prune-blocks=0"; args[(*j)++] = "-mllvm"; - args[(*j)++] = "-sanitizer-coverage-block-threshold=10000000"; - args[(*j)++] = "-mllvm"; args[(*j)++] = "-sanitizer-coverage-level=3"; }
[KConfig] Change the RT_DFS_ELM_USE_LFN cfg to choice.
@@ -29,15 +29,29 @@ if RT_USING_DFS int "OEM code page" default 437 + choice + prompt "Support long file name" + default RT_DFS_ELM_USE_LFN_0 + + config RT_DFS_ELM_USE_LFN_0 + bool "0: LFN disable" + + config RT_DFS_ELM_USE_LFN_1 + bool "1: LFN with static LFN working buffer" + + config RT_DFS_ELM_USE_LFN_2 + bool "2: ...