message stringlengths 6 474 | diff stringlengths 8 5.22k |
|---|---|
doc BUGFIX fix typo | @@ -1582,7 +1582,7 @@ int sr_oper_get_items_subscribe(sr_session_ctx_t *session, const char *module_na
*/
/**
- * @brief Sysrepo plugin initialization callback name that must exists in every plugin.
+ * @brief Sysrepo plugin initialization callback name that must exist in every plugin.
*/
#define SRP_INIT_CB "sr_plugin... |
DLL_PROXY module and MAPSMOBI_SRCS macro | @@ -716,6 +716,7 @@ module BASE_UNIT {
module LINK_UNIT: BASE_UNIT {
.EXTS=.o .obj
.CMD=LINK_EXE
+ .ALLOWED=EXTRALIBS OBJADDE_GLOBAL
.NODE_TYPE=Program
.PEERDIR_POLICY=as_build_from
.FINAL_TARGET=yes
@@ -1307,7 +1308,6 @@ module DLL_UNIT: LINK_UNIT {
.CMD=LINK_DYN_LIB
.NODE_TYPE=Library
.SYMLINK_POLICY=SO
- .ALLOWED=EX... |
entrycmp_jump_fnv1a: sort keys as numbers if possible
Ensure that we treat numbers the way we document it.
Fixes issue | @@ -169,6 +169,9 @@ entrycmp_jump_fnv1a(const void *l, const void *r)
char *si_l = server_instance(ch_l->server);
char *si_r = server_instance(ch_r->server);
+ char *endp;
+ long val_l;
+ long val_r;
/* order such that servers with explicit instance come first
* (sorted), all servers without instance follow in order of... |
stm32/usbd_hid_interface: Address possible race condition vs. interrupt.
The USB IRQ may fire once USBD_HID_ClearNAK() is called and then change the
last_read_len value. | @@ -94,12 +94,13 @@ int usbd_hid_rx(usbd_hid_itf_t *hid, size_t len, uint8_t *buf, uint32_t timeout)
}
// Copy bytes from device to user buffer
- memcpy(buf, hid->buffer[hid->current_read_buffer], hid->last_read_len);
+ int read_len = hid->last_read_len;
+ memcpy(buf, hid->buffer[hid->current_read_buffer], read_len);
h... |
also consider path response in set_next_wake_time | @@ -236,11 +236,22 @@ protoop_arg_t set_nxt_wake_time(picoquic_cnx_t *cnx)
int nb_paths = (int) get_cnx(cnx, AK_CNX_NB_PATHS, 0);
PROTOOP_PRINTF(cnx, "Last packet size was %d\n", last_pkt_length);
+
+ /* If any receive path requires path response, do it now! */
+ for (int i = (nb_paths > 1); last_pkt_length > 0 && bloc... |
Ensure we explicitly document the modulus for fixed-width arithmetic | @@ -167,6 +167,8 @@ int mbedtls_mpi_core_write_be( const mbedtls_mpi_uint *A,
* return carry;
* ```
*
+ * This function operates modulo `2^(biL*limbs)`.
+ *
* \param[in,out] X The pointer to the (little-endian) array
* representing the bignum to accumulate onto.
* \param[in] A The pointer to the (little-endian) array
@... |
example DOC update example plugin name | @@ -286,7 +286,7 @@ above is just basic and detailed descriptions of all these mechanisms can be fou
Before being concerned with this particular plugin, Sysrepo must be properly built and installed. Having done that,
you must install first the model, then the plugin. For installing the model, you can use [sysrepoctl](@... |
Include mimalloc-redirect.dll with cmake install | @@ -303,6 +303,7 @@ if(MI_BUILD_SHARED)
add_custom_command(TARGET mimalloc POST_BUILD
COMMAND "${CMAKE_COMMAND}" -E copy "${CMAKE_CURRENT_SOURCE_DIR}/bin/mimalloc-redirect${MIMALLOC_REDIRECT_SUFFIX}.dll" $<TARGET_FILE_DIR:mimalloc>
COMMENT "Copy mimalloc-redirect${MIMALLOC_REDIRECT_SUFFIX}.dll to output directory")
+ i... |
VERSION bump to version 0.8.60 | @@ -28,7 +28,7 @@ set(CMAKE_C_FLAGS_DEBUG "-g -O0")
# set version
set(LIBNETCONF2_MAJOR_VERSION 0)
set(LIBNETCONF2_MINOR_VERSION 8)
-set(LIBNETCONF2_MICRO_VERSION 59)
+set(LIBNETCONF2_MICRO_VERSION 60)
set(LIBNETCONF2_VERSION ${LIBNETCONF2_MAJOR_VERSION}.${LIBNETCONF2_MINOR_VERSION}.${LIBNETCONF2_MICRO_VERSION})
set(LI... |
Added proper testing for the calc example | #include "test.h"
+#define P4CALC_ETYPE "1234"
+#define P4CALC_P "50" // 'P'
+#define P4CALC_4 "34" // '4'
+#define P4CALC_VER "01" // v0.1
+#define P4CALC_PLUS "2b" // '+'
+#define P4CALC_MINUS "2d" // '-'
+#define P4CALC_AND "26" // '&'
+#define P4CALC_OR "7c" // '|'
+#define P4CALC_XOR "5e" // '^'
+
fake_cmd_t t4p4s... |
Increase the timeout of isolation2 GlobalShellExecutor
Probably because of the heavy CI load, we observed several timeouts,
increase the timeout value to work around it. | @@ -132,7 +132,7 @@ class GlobalShellExecutor(object):
output = ""
while self.sh_proc.poll() is None:
# If not returns in 10 seconds, consider it as an fatal error.
- r, w, e = select.select([self.master_fd], [], [self.master_fd], 10)
+ r, w, e = select.select([self.master_fd], [], [self.master_fd], 30)
if e:
# Termina... |
Fix calculation of last used music bank | @@ -64,6 +64,7 @@ const compileMusic = async ({
// If current track fits into the current bank then store it
bankedData[bankedData.length - 1].size += musicData.size;
bankedData[bankedData.length - 1].tracks.push(musicData);
+ track.bank = bankedData[bankedData.length - 1].bank;
} else {
// Otherwise switch to new bank... |
Simplify test/util.py:ppp. | @@ -19,15 +19,9 @@ from vpp_papi import mac_pton
def ppp(headline, packet):
""" Return string containing the output of scapy packet.show() call. """
- o = BytesIO()
- old_stdout = sys.stdout
- sys.stdout = o
- print(headline)
- hexdump(packet)
- print("")
- packet.show()
- sys.stdout = old_stdout
- return o.getvalue()
... |
http-client - bugfixes | @@ -69,11 +69,10 @@ on_error(struct neat_flow_operations *opCB)
{
fprintf(stderr, "%s\n", __func__);
struct stat_flow *stat = opCB->userData;
- uv_close((uv_handle_t*)&(stat->timer), NULL);
- int *result = (int*)opCB->userData;
- if (*result != EXIT_FAILURE)
- *result = EXIT_FAILURE;
+ if (stat) {
+ uv_close((uv_handle... |
Fix typos in process.h | @@ -11,18 +11,18 @@ enum {
// Processing failed. The output buffer must be discarded.
CLAP_PROCESS_ERROR = 0,
- // Processing succeed, keep processing.
+ // Processing succeeded, keep processing.
CLAP_PROCESS_CONTINUE = 1,
- // Processing succeed, keep processing if the output is not quiet.
+ // Processing succeeded, k... |
drivers/pipes: fix write busy loop because POLLOUT always ready.
the size of pipes buffer +1 as compensate the full indicator | @@ -441,7 +441,7 @@ ssize_t pipecommon_read(FAR struct file *filep, FAR char *buffer, size_t len)
* FIFO when buffer can accept more than d_polloutthrd bytes.
*/
- if (pipecommon_bufferused(dev) < (dev->d_bufsize - dev->d_polloutthrd))
+ if (pipecommon_bufferused(dev) < (dev->d_bufsize - 1 - dev->d_polloutthrd))
{
poll... |
build: rename dockerize to withDOckerEnv
Other jenkinsfile instructions (withEnv, withCredentials, ...) are named
similarly. | @@ -248,7 +248,7 @@ def test_todo() {
**/*.c, **/*.h, **/*.hpp, **/*.cpp,\
**/CMakeLists.txt, **/Dockerfile*, Jenkinsfile*
'''
- return dockerize(test_name, DOCKER_IMAGES.stretch_doc) {
+ return withDockerEnv(test_name, DOCKER_IMAGES.stretch_doc) {
sh "sloccount --duplicates --wide --details ${WORKSPACE} > sloccount.sc... |
Premultiply R,G and B when using transparency.
X11 uses premultiplied alpha for colors, i.e. white at 50% opacity is
represented as 0x7f7f7f7f, not 0x7fffffff. If we don't compensate for
this, the perceived opacity will increase and high intensity colors
can't be made transparent. | @@ -3485,9 +3485,17 @@ xloadcols(void)
/* set alpha value of bg color */
if (USE_ARGB) {
+ // X11 uses premultiplied alpha values (i.e. 50% opacity white is
+ // 0x7f7f7f7f, not 0x7fffffff), so multiply color by alpha
dc.col[defaultbg].color.alpha = (0xffff * alpha) / OPAQUE; //0xcccc;
- dc.col[defaultbg].pixel &= 0x00... |
interface: inset by safe-area on iOS
Fixes urbit/landscape#242 | @@ -43,7 +43,11 @@ const Root = withState(styled.div`
font-family: ${p => p.theme.fonts.sans};
height: 100%;
width: 100%;
- padding: 0;
+ padding-left: env(safe-area-inset-left, 0px);
+ padding-right: env(safe-area-inset-right, 0px);
+ padding-top: env(safe-area-inset-top, 0px);
+ padding-bottom: env(safe-area-inset-bo... |
Add a FAQ section for Wayland support
The video driver might need to be explicitly set to wayland.
Refs <https://github.com/Genymobile/scrcpy/issues/2554>
Refs <https://github.com/Genymobile/scrcpy/issues/2559> | @@ -153,6 +153,26 @@ You may also need to configure the [scaling behavior]:
[scaling behavior]: https://github.com/Genymobile/scrcpy/issues/40#issuecomment-424466723
+### Issue with Wayland
+
+By default, SDL uses x11 on Linux. The [video driver] can be changed via the
+`SDL_VIDEODRIVER` environment variable:
+
+[video... |
Add check for NF_FEATURE_HAS_CONFIG_BLOCK on network build | @@ -560,6 +560,13 @@ if(USE_NETWORKING_OPTION)
message(STATUS "Support for networking enabled WITHOUT security")
endif()
+ # sanity check for missing configuration block option
+ # which is required for network
+
+ if(NOT NF_FEATURE_HAS_CONFIG_BLOCK)
+ message(FATAL_ERROR "\n\nERROR: network build requires NF_FEATURE_H... |
Fix initial write directory set on windows; | @@ -127,7 +127,7 @@ const char* lovrFilesystemGetSaveDirectory() {
int lovrFilesystemGetSize(const char* path) {
PHYSFS_file* handle = PHYSFS_openRead(path);
if (!handle) {
- return 1;
+ return -1;
}
int length = PHYSFS_fileLength(handle);
@@ -210,12 +210,10 @@ int lovrFilesystemSetIdentity(const char* identity) {
}
}
... |
test MAINTENANCE fix function casting warnings | @@ -400,16 +400,16 @@ test_output_clb(void **state)
assert_int_not_equal(-1, fd2 = open(filepath, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR));
/* manipulate with the handler */
- assert_int_equal(LY_SUCCESS, ly_out_new_clb((ssize_t (*)(void *, const void *, size_t))write, (void*)(intptr_t)fd1, &out));
+ assert_int_equal(LY_S... |
Messed up the addresses here | @@ -22,9 +22,6 @@ namespace FFXIVClientStructs.FFXIV.Client.UI
[FieldOffset(0x3F0)] public Utf8String String3F0;
[FieldOffset(0x458)] public Utf8String String458;
[FieldOffset(0x4C0)] public Utf8String String4C0;
- [FieldOffset(0x590)] public void* vtbl590;
- [FieldOffset(0x2F0)] public void* vtbl598;
- [FieldOffset(0x... |
mesh: Transport tx seg_o overflow
Increases the transport segmentented tx seg_o counter to 6 bits to avoid
overflow when sending 32 segments. The check in the send loop would
previously never be false, which causes segments to repeat
unnecessarily.
this is port of | @@ -78,11 +78,13 @@ static struct seg_tx {
ctl:1,
aszmic:1,
friend_cred:1;
- u8_t seg_o:5,
+ u8_t seg_o:6,/* Segment being sent. 6 bits to
+ * prevent overflow in loop.
+ */
started:1, /* Start cb called */
- sending:1, /* Sending is in progress */
+ sending:1; /* Sending is in progress */
+ u8_t nack_count:5, /* Numbe... |
Solve bug in string for mock loader. | @@ -191,7 +191,7 @@ function_return function_mock_interface_invoke(function func, function_impl impl
{
static const char str[] = "Hello World";
- return value_create_string(str, sizeof(str) / sizeof(str[0]));
+ return value_create_string(str, sizeof(str) - 1);
}
else if (id == TYPE_PTR)
{
|
Simplify some testlib set_limit methods | @@ -290,8 +290,7 @@ int test_main(int argc, char** argv, proc* tests, proc* benches) {
// WUFFS_BASE_HEADER_H is where wuffs_base__io_buffer is defined.
#ifdef WUFFS_BASE_HEADER_H
-static inline wuffs_base__empty_struct wuffs_base__io_reader__set_limit(
- wuffs_base__io_reader* o,
+void wuffs_base__io_reader__set_limit... |
Compile: Remove unused option `GTEST_ROOT` | @@ -428,14 +428,6 @@ Similar to above, but with the plugins. Default is:
It can be also left empty to install plugins next
to other libraries.
-#### `GTEST_ROOT`
-
-Specifies the root of the GoogleTest sources, to be used
-for some of the tests. A `CMakeLists.txt` inside `GTEST_ROOT`
-will be searched as way to detect ... |
Remove obsolete rac.ReaderContext comment | @@ -31,9 +31,6 @@ var (
// ReaderContext contains the decoded Codec-specific metadata (non-primary
// data) associated with a RAC chunk.
-//
-// Like the Reader type, users typically do not refer to this type directly.
-// Instead, they use higher level packages like the sibling "raczlib" package.
type ReaderContext st... |
CBLK: Refuse giving out slots if device is in error | @@ -675,7 +675,7 @@ static int cache_unreserve(struct cache_way *e, off_t lba)
dfprintf(stderr, "[%s] err: LBA=%ld/%ld not consistent!\n",
__func__, lba, e->lba);
e->status = CACHE_BLOCK_UNUSED;
- __backtrace();
+ /* __backtrace(); */
pthread_mutex_unlock(&entry->way_lock);
return -1;
}
@@ -684,7 +684,7 @@ static int c... |
Fix the mem_sec "small arena"
Fix the small arena test to just check for the symptom of the infinite
loop (i.e. initialized set on failure), rather than the actual infinite
loop. This avoids some valgrind errors. | @@ -68,12 +68,15 @@ static int test_sec_mem(void)
TEST_ptr_null(OPENSSL_secure_malloc((size_t)-1));
TEST_true(CRYPTO_secure_malloc_done());
- TEST_info("Possible infinite loop: small arena");
- if (!TEST_false(CRYPTO_secure_malloc_init(16, 16)))
- goto end;
- TEST_false(CRYPTO_secure_malloc_initialized());
- TEST_ptr_n... |
doc: OPAL_PCI_SHPC was never implemented | @@ -65,7 +65,8 @@ The OPAL API is the interface between an Operating System and OPAL.
+---------------------------------------------+--------------+------------------------+----------+-----------------+
| :ref:`OPAL_PCI_EEH_FREEZE_STATUS` | 23 | v1.0 (Initial Release) | POWER8 | |
+-------------------------------------... |
Make ESP32 Bluetooth stack architecture Doc only visible for ESP32 | @@ -18,6 +18,7 @@ ESP-IDF currently supports two host stacks. The Bluedroid based stack (default)
* For usecases involving classic Bluetooth as well as BLE, Bluedroid should be used.
* For BLE-only usecases, using NimBLE is recommended. It is less demanding in terms of code footprint and runtime memory, making it suita... |
armv7: Fixed hal_cpuReschedule not keeping return value | @@ -95,12 +95,17 @@ int hal_cpuCreateContext(cpu_context_t **nctx, void *start, void *kstack, size_t
int hal_cpuReschedule(spinlock_t *spinlock)
{
+ int err;
+
_hal_invokePendSV();
if (spinlock != NULL)
hal_spinlockClear(spinlock);
- return EOK;
+ /* We want to keep r0 from timeintr */
+ __asm__ volatile ("mov %0, r0" ... |
`pthread_mutex_timedlock` never returns `EINTR`
According to posix spec, this function should never return `EINTR`.
This fixes the call to `pthread_mutex_take` so it keeps retrying the
lock and doesn't return `EINTR` | @@ -187,7 +187,7 @@ int pthread_mutex_timedlock(FAR pthread_mutex_t *mutex,
* or default mutex.
*/
- ret = pthread_mutex_take(mutex, abs_timeout, true);
+ ret = pthread_mutex_take(mutex, abs_timeout, false);
/* If we successfully obtained the semaphore, then indicate
* that we own it.
|
testcase/fs : fix fuction name of readdir_r & telldir
it didn't follow tc naming policy, add 'tc' as a prefix | @@ -969,7 +969,7 @@ static void tc_fs_vfs_seekdir(void)
* @precondition tc_fs_vfs_mkdir should be passed
* @postcondition NA
*/
-static void fs_libc_dirent_readdir_r(void)
+static void tc_fs_libc_dirent_readdir_r(void)
{
int ret, count;
DIR *dirp;
@@ -987,9 +987,9 @@ static void fs_libc_dirent_readdir_r(void)
}
count++... |
Add bindings for SDL_GetQueuedAudioSize and SDL_ClearQueuedAudio | @@ -9,6 +9,13 @@ static int SDL_QueueAudio(SDL_AudioDeviceID dev, const void *data, Uint32 len)
{
return -1;
}
+static Uint32 SDL_GetQueuedAudioSize(SDL_AudioDeviceID)
+{
+ return 0;
+}
+static SDL_ClearQueuedAudio(SDL_AudioDeviceID dev)
+{
+}
#endif
#if !(SDL_VERSION_ATLEAST(2,0,5))
@@ -334,6 +341,15 @@ func DequeueAu... |
Fix memory leaks in derive tests. | #include <stdlib.h>
#include <tinyspline.h>
#include "CuTest.h"
+#include "utils.h"
#define EPSILON 0.0001
@@ -293,6 +294,7 @@ void derive_single_parabola_with_custom_knots(CuTest *tc)
&net, &result, &status))
CuAssertDblEquals(tc, ctrlp[0] + slope * (step * i),
result[0], EPSILON);
+ ts_deboornet_free(&net);
free(resu... |
Add Some ... to Test.md | @@ -34,6 +34,7 @@ PS F:\msquic> .\scripts\test.ps1
...
[05/24/2021 08:17:55] 66 test(s) run.
[05/24/2021 08:17:56] F:\msquic\artifacts\bin\windows\x64_Debug_schannel\msquictest.exe (1681 test case(s))
+...
[05/24/2021 08:26:58] 1681 test(s) run.
[05/24/2021 08:26:58] Output can be found in F:\msquic\artifacts\logs\msqu... |
Fixing bug in check_cdd | @@ -29,29 +29,37 @@ using namespace std;
// Custom test to check the minimum number of correct decimal digits between
// the test and the ref vectors.
boost::test_tools::predicate_result check_cdd(std::vector<float>& test,
- std::vector<float>& ref, long cdd_tol)
-{
- float tmp, min_cdd = 100.0;
+ std::vector<float>& r... |
minor update for slider follow animation | @@ -43,7 +43,7 @@ def prepare_slider(diff, scale, skin):
cs = (54.4 - 4.48 * diff["CircleSize"]) * scale
radius_scale = cs * 2 / default_size
- interval = Settings.timeframe / Settings.fps
+ interval = 0.75 * Settings.timeframe / Settings.fps
follow_fadein = 150 # need 150ms to fadein
arrow_frames, sliderb_frames, slid... |
[core] reduce con allocation for small max_conns
reduce con allocation for small server.max_conns
(do not allocate structures that will never be used) | @@ -43,7 +43,7 @@ static connection *connections_get_new_connection(server *srv) {
size_t i;
if (conns->size == 0) {
- conns->size = 128;
+ conns->size = srv->max_conns >= 128 ? 128 : srv->max_conns > 16 ? 16 : srv->max_conns;
conns->ptr = NULL;
conns->ptr = malloc(sizeof(*conns->ptr) * conns->size);
force_assert(NULL ... |
common/mag_cal.c: Format with clang-format
BRANCH=none
TEST=none | @@ -55,30 +55,21 @@ static int moc_eigen_test(struct mag_cal_t *moc)
int eigen_pass;
/* covariance matrix */
- S[0][0] = covariance_element(moc->kasa_fit.acc_xx,
- moc->kasa_fit.acc_x,
- moc->kasa_fit.acc_x,
- inv);
+ S[0][0] = covariance_element(moc->kasa_fit.acc_xx, moc->kasa_fit.acc_x,
+ moc->kasa_fit.acc_x, inv);
S... |
Fix shifting issue in this file, waiting for validation. | @@ -64,43 +64,51 @@ void arm_softmax_q7(const q7_t * vec_in, const uint16_t dim_vec, q7_t * p_out)
{
q31_t sum;
int16_t i;
- q15_t min, max;
- max = -257;
- min = 257;
+ uint8_t shift;
+ q15_t base;
+ base = -257;
+
+ /* We first search for the maximum */
for (i = 0; i < dim_vec; i++)
{
- if (vec_in[i] > max)
- {
- max... |
[account] minor, rename parameter | @@ -145,16 +145,16 @@ func hashBytes(b1 []byte, b2 []byte) []byte {
return h.Sum(nil)
}
-func encrypt(address, key, data []byte) ([]byte, error) {
+func encrypt(base, key, data []byte) ([]byte, error) {
block, err := aes.NewCipher(key)
if err != nil {
return nil, err
}
// Never use more than 2^32 random nonces with a g... |
Fix style issues in mac_sign_verify_multi() | @@ -2721,21 +2721,21 @@ void mac_sign_verify_multi( int key_type_arg,
/* Split data into length(data_part_len) parts. */
mbedtls_test_set_step( 2000 + data_part_len );
- if( !mac_multipart_internal_func( key_type_arg, key_data,
+ if( mac_multipart_internal_func( key_type_arg, key_data,
alg_arg,
input, data_part_len,
ex... |
SOVERSION bump to version 5.6.21 | @@ -54,7 +54,7 @@ set(SYSREPO_VERSION ${SYSREPO_MAJOR_VERSION}.${SYSREPO_MINOR_VERSION}.${SYSREPO_
# with backward compatible change and micro version is connected with any internal change of the library.
set(SYSREPO_MAJOR_SOVERSION 5)
set(SYSREPO_MINOR_SOVERSION 6)
-set(SYSREPO_MICRO_SOVERSION 20)
+set(SYSREPO_MICRO_S... |
libbpf-tools: Allow filelife to run on kernels without CONIFG_SECURITY
security_inode_create does NOT exist if CONIFG_SECURITY is not set.
The tool filelife attaches to security_inode_create unconditionally
and result in attach error. Fix it by checking symbol existence. | @@ -138,6 +138,9 @@ int main(int argc, char **argv)
/* initialize global data (filtering options) */
obj->rodata->targ_tgid = env.pid;
+ if (!kprobe_exists("security_inode_create"))
+ bpf_program__set_autoload(obj->progs.security_inode_create, false);
+
err = filelife_bpf__load(obj);
if (err) {
fprintf(stderr, "failed ... |
Changed HTTP duration to ms from us. | @@ -257,7 +257,7 @@ doHttpHeader(protocol_info *proto)
map->duration = 0;
} else {
map->duration = getDurationNow(post->start_duration, map->start_time);
- map->duration = map->duration / 1000;
+ map->duration = map->duration / 1000000;
}
size_t status = getHttpStatus((char *)map->resp, proto->len);
|
Fix fix code. | @@ -365,12 +365,12 @@ ldns_rr_new_frm_str_internal(ldns_rr **newrr, const char *str,
ldns_buffer_remaining(rd_buf) > 0){
/* skip spaces */
- while (sldns_buffer_remaining(strbuf) > 0 &&
+ while (ldns_buffer_remaining(rd_buf) > 0 &&
*(ldns_buffer_current(rd_buf)) == ' ') {
ldns_buffer_skip(rd_buf, 1);
}
- if (sldns_buff... |
Added csched_sp3_test to non-deterministic suite | @@ -53,6 +53,9 @@ components = {
'cn_tree_test': {},
'csched_noop_test': {},
'csched_sp3_test': {
+ # mapi_malloc_tester isn't reliable in multithreaded environments. Add to
+ # non-deterministic suite
+ 'suites': ['non-deterministic'],
'cases': {
'default': [],
'debug': ['debug'],
|
win32: appveyor - another try with zipping rhosim | @@ -14,7 +14,7 @@ environment:
app_name: RhoSimulator
target_os: win32
target_artefact_path: C:\Ruby23\lib\ruby\gems\2.3.0\gems\rhodes-6.0.0\platform\win32\RhoSimulator\
- target_artefact_file_name: "*"
+ target_artefact_file_name:
- win32_auto_common_spec:
testable_application_repository: https://github.com/rhomobile/... |
PHP SAPI: typo fixed. | @@ -503,7 +503,7 @@ nxt_php_send_headers(sapi_headers_struct *sapi_headers TSRMLS_DC)
"\r\n";
static const u_char default_headers[]
- - "Server: unit/" NXT_VERSION "\r\n"
+ = "Server: unit/" NXT_VERSION "\r\n"
"Connection: close\r\n";
static const u_char http_11[] = "HTTP/1.1 ";
|
LPC55xx: added DAPLink info to gcc vector table. | @@ -32,12 +32,12 @@ __isr_vector:
.long BusFault_Handler /* Bus Fault Handler*/
.long UsageFault_Handler /* Usage Fault Handler*/
.long SecureFault_Handler /* Secure Fault Handler*/
- .long 0 /* Reserved*/
- .long 0 /* Reserved*/
- .long 0 /* Reserved*/
+ .long DAPLINK_BUILD_KEY /* Build type - BL/IF*/
+ .long DAPLINK_... |
is_pure_trans argument is implemented to slightly improve the performance. | @@ -92,7 +92,8 @@ static Symmetry * get_operations(const Cell *primitive,
static Symmetry * reduce_operation(const Cell * primitive,
const Symmetry * symmetry,
const double symprec,
- const double angle_symprec);
+ const double angle_symprec,
+ const int is_pure_trans);
static int search_translation_part(int atoms_foun... |
doc: add params argument to key manager's gen_init call
Fixes | @@ -19,7 +19,8 @@ provider-keymgmt - The KEYMGMT library E<lt>-E<gt> provider functions
void OSSL_FUNC_keymgmt_free(void *keydata);
/* Generation, a more complex constructor */
- void *OSSL_FUNC_keymgmt_gen_init(void *provctx, int selection);
+ void *OSSL_FUNC_keymgmt_gen_init(void *provctx, int selection,
+ const OSSL... |
Add Z to end of timestamp. | @@ -59,7 +59,7 @@ class Framer(object):
-------
str : ISO 8601 format timestamp
"""
- return datetime.datetime.utcnow().isoformat()
+ return datetime.datetime.utcnow().isoformat() + 'Z'
def next(self):
msg = None
|
Modify travis config file
remove 'group' as the definition changed in travis
add 'qemu/tc_64k' build config for check build status | sudo: false
dist: trusty
-group: deprecated-2017Q2
-
language: c
services:
-
- docker
env:
-- BUILD_CONFIG=tash
-- BUILD_CONFIG=nettest
-- BUILD_CONFIG=minimal
-- BUILD_CONFIG=tc
+- BUILD_CONFIG=artik053/tash
+- BUILD_CONFIG=artik053/nettest
+- BUILD_CONFIG=artik053/minimal
+- BUILD_CONFIG=artik053/tc
+- BUILD_CONFIG=q... |
Make aomp+mappings pass for older runtimes as well as new | @@ -336,7 +336,8 @@ int main()
recordError(&errors, "DEVICE NUMBER", i, default_dev, NULL);
//check warp #
- if (warp_id[i] != (MAX_THREADS_PER_TEAM - WARP_SIZE) / WARP_SIZE +1)
+ if ((warp_id[i] != (MAX_THREADS_PER_TEAM - WARP_SIZE) / WARP_SIZE) &&
+ (warp_id[i] != (MAX_THREADS_PER_TEAM - WARP_SIZE) / WARP_SIZE +1))
r... |
stm32l1.c: compiler warning removed | @@ -760,8 +760,10 @@ int _stm32_systickInit(u32 interval)
void _stm32_systickSet(u8 state)
{
- *(stm32_common.stk + stk_ctrl) &= ~(!state);
- *(stm32_common.stk + stk_ctrl) |= !!state;
+ if (state > 0)
+ *(stm32_common.stk + stk_ctrl) |= 1;
+ else
+ *(stm32_common.stk + stk_ctrl) &= ~1;
}
|
Fix bug in HMAC implementation. | ++ hmac-sha512l (cury hmac sha-512l 128 64)
::
++ hmac
- :: boq: block size used by haj
+ :: boq: block size in bytes used by haj
:: out: bytes output by haj
|* [[haj=$-([@u @] @) boq=@u out=@u] [kl=@u key=@] [ml=@u msg=@]]
- :: ensure key and message fit signalled lengths
+ :: ensure key and message fit signaled lengt... |
Rename offset and xsetid tags
There's really no point in having dedicated flags to test these features
(why shouldn't all commands/features get their own tag?) | @@ -752,7 +752,7 @@ start_server {tags {"stream needs:debug"} overrides {appendonly yes stream-node-
}
}
-start_server {tags {"stream xsetid"}} {
+start_server {tags {"stream"}} {
test {XADD can CREATE an empty stream} {
r XADD mystream MAXLEN 0 * a b
assert {[dict get [r xinfo stream mystream] length] == 0}
@@ -811,7 ... |
ExtendedServices: Fix icon sizes | @@ -775,9 +775,11 @@ INT_PTR CALLBACK EspPnPServiceDlgProc(
PhAddListViewGroup(context->ListViewHandle, 1, L"Disconnected");
context->ImageList = PhImageListCreate(
- PhGetSystemMetrics(SM_CXSMICON, dpiValue),
- PhGetSystemMetrics(SM_CYSMICON, dpiValue),
- ILC_MASK | ILC_COLOR32, 1, 1);
+ PhGetDpi(24, dpiValue), // PhG... |
Documentation restructured, Interrupt usage clearified | @@ -751,9 +751,7 @@ WARN_LOGFILE =
# Note: If this tag is empty the current directory is searched.
INPUT = . \
- ../../RTOS2/Include/cmsis_os2.h \
- ../../RTOS2/Include/os_tick.h \
- ../../RTOS2/Source/os_systick.c \
+ ./src/mainpage.txt \
./src/cmsis_os2.txt \
./src/cmsis_os2_Kernel.txt \
./src/cmsis_os2_Thread.txt \
... |
Init timers with pulse of 0
Initialising the timers with a pulse value will cause an unwanted PWM signal between timer init and user code init. | @@ -62,7 +62,7 @@ void MX_TIM3_Init(void)
Error_Handler();
}
sConfigOC.OCMode = TIM_OCMODE_PWM1;
- sConfigOC.Pulse = 5000;
+ sConfigOC.Pulse = 0;
sConfigOC.OCPolarity = TIM_OCPOLARITY_LOW;
sConfigOC.OCFastMode = TIM_OCFAST_DISABLE;
if (HAL_TIM_PWM_ConfigChannel(&htim3, &sConfigOC, TIM_CHANNEL_2) != HAL_OK)
@@ -113,7 +1... |
format: improve pre-commit-check | @@ -69,8 +69,14 @@ if [ -n "$UNFORMATTED_FILES" ]; then
echo "A diff of the formatting changes is stored at:"
echo "$PATCH_FILE"
+ PATCH_SCRIPT="/tmp/elektra-$DATE-reformat.patch.sh"
+ echo 'OLD_DIR=$(pwd)' > "$PATCH_SCRIPT"
+ echo "cd $SRC_ROOT" >> "$PATCH_SCRIPT"
+ echo "git apply $PATCH_FILE" >> "$PATCH_SCRIPT"
+ ec... |
dwalk options | @@ -306,8 +306,8 @@ static void print_usage(void)
printf(" -t, --text - use with -o; write processed list to file in ascii format\n");
printf(" -l, --lite - walk file system without stat\n");
printf(" -s, --sort <fields> - sort output by comma-delimited fields\n");
- printf(" -f, --file_histogram - print default size d... |
testcase/task_manager: Add sleep for waiting to restart the task
Current TC, task_manager tries to stop the task before restarting completely.
So stop callback didn't work.
Add sleep for waiting to restart completely. | @@ -733,6 +733,7 @@ static void utc_task_manager_stop_p(void)
{
int ret;
+ sleep(1);
cb_flag = false;
ret = task_manager_stop(tm_sample_handle, TM_RESPONSE_WAIT_INF);
TC_ASSERT_EQ("task_manager_stop", ret, OK);
@@ -1050,9 +1051,9 @@ int utc_task_manager_main(int argc, char *argv[])
handle_tm_utc = task_manager_register... |
Update: Memory: return on direct find | @@ -87,6 +87,7 @@ bool Memory_getClosestConcept(Event *event, int *returnIndex)
if(Memory_FindConceptBySDR(&event->sdr, event->sdr_hash, &foundSameConcept_i))
{
*returnIndex = foundSameConcept_i;
+ return true;
}
int best_i = -1;
double bestValSoFar = -1;
|
Update d2i_PrivateKey documentation | @@ -50,15 +50,19 @@ If the B<*a> is not NULL when calling d2i_PrivateKey() or d2i_AutoPrivateKey()
(i.e. an existing structure is being reused) and the key format is PKCS#8
then B<*a> will be freed and replaced on a successful call.
+To decode a key with type B<EVP_PKEY_EC>, d2i_PublicKey() requires B<*a> to be
+a non-... |
fixed bug in MP12E2 | @@ -1144,6 +1144,7 @@ while(c >= 0)
return;
}
/*===========================================================================*/
+/*
static void lookfor21(long int cakt, eapdb_t *zeigerakt, unsigned long long int replaycakt)
{
eapdb_t *zeiger;
@@ -1181,6 +1182,7 @@ while(c >= 0)
}
return;
}
+*/
/*=========================... |
fix CFLAGS option, -L -> -I | @@ -65,7 +65,7 @@ module load pmix
--with-pm=no --with-pmi=slurm \
%endif
%if 0%{with_pmix}
- CFLAGS="-L${PMIX_INC}" LIBS="-L${PMIX_LIB} -lpmix" --with-pm=none --with-pmi=slurm \
+ CFLAGS="-I${PMIX_INC}" LIBS="-L${PMIX_LIB} -lpmix" --with-pm=none --with-pmi=slurm \
%endif
|| { cat config.log && exit 1; }
|
Add ethernet type to support NSH over ethernet | @@ -102,7 +102,7 @@ ethernet_type (0x88B7, 802_OUI_EXTENDED)
ethernet_type (0x88c7, 802_11I_PRE_AUTHENTICATION)
ethernet_type (0x88cc, 802_1_LLDP)
ethernet_type (0x88e7, DOT1AH)
-ethernet_type (0x894f, VPATH_3)
+ethernet_type (0x894f, NSH)
ethernet_type (0x9000, LOOPBACK)
ethernet_type (0x9021, RTNET_MAC)
ethernet_type... |
Fix queue locking. | @@ -424,30 +424,17 @@ VioScsiVQLock(
ENTER_FN();
adaptExt = (PADAPTER_EXTENSION)DeviceExtension;
- if (!adaptExt->msix_enabled) {
if (!isr) {
- StorPortAcquireSpinLock(DeviceExtension, InterruptLock, NULL, LockHandle);
- }
- }
- else {
- if (adaptExt->num_queues == 1) {
- if (!isr) {
- ULONG oldIrql = 0;
- StorPortAcqu... |
[core] do not load indexfile, dirlisting if unused
do not load mod_indexfile or mod_dirlisting unless used and enabled
(avoid loading some default modules unless used and enabled) | @@ -320,6 +320,24 @@ static void config_check_module_duplicates (server *srv) {
}
__attribute_pure__
+__attribute_noinline__
+static int config_has_opt_enabled (const server * const srv, const char * const opt, const uint32_t olen) {
+ for (uint32_t i = 0; i < srv->config_context->used; ++i) {
+ const data_config * con... |
bootloader: Fix a wrong offset in image_load after refactoring | @@ -144,7 +144,7 @@ static esp_err_t image_load(esp_image_load_mode_t mode, const esp_partition_pos_
// For secure boot V1 on ESP32, we don't calculate SHA or verify signature on bootloaders.
// (For non-secure boot, we don't verify any SHA-256 hash appended to the bootloader because
// esptool.py may have rewritten th... |
rust: build all features and all targets | @@ -322,7 +322,7 @@ test-rust:
$(call announce-begin,"Running Rust tests")
cd $(SWIFTNAV_ROOT)/rust/sbp && cargo test --verbose
$(call announce-begin,"Building Rust examples")
- cd $(SWIFTNAV_ROOT)/rust/sbp && cargo build --examples --verbose
+ cd $(SWIFTNAV_ROOT)/rust/sbp && cargo build --examples --verbose --all-feat... |
workflows: update unit test runner OS | @@ -24,7 +24,7 @@ on:
jobs:
run-ubuntu-unit-tests:
- runs-on: ubuntu-18.04
+ runs-on: ubuntu-20.04
timeout-minutes: 60
strategy:
fail-fast: false
@@ -50,7 +50,7 @@ jobs:
- name: Setup environment
run: |
sudo apt update
- sudo apt install -yyq gcc-7 g++-7 clang-6.0 libsystemd-dev gcovr libyaml-dev
+ sudo apt install -y ... |
docs: update tools readme | @@ -15,10 +15,10 @@ The graphical user interface (GUI) is called `kdb qt-gui`.
## Web-UI
-For information about the Web-UI, please read [here](web).
+For information about the Web-UI, please read [here](../../doc/tutorials/install-webui.md).
Note that the Web-UI also provides a REST service
-[elektrad](web/elektrad) th... |
libcupsfilters: Let universal() pass FINAL_CONTENT_TYPE to pdftopdf()
pdftopdf() uses the FINAL_CONTENT_TYPE environment variable to
determine whether to log the printed pages and for other things, so
the universal() filter function should pass it through. | @@ -219,7 +219,7 @@ universal(int inputfd, /* I - File descriptor input stream */
if (strcmp(output_type, "pdf")) {
filter = malloc(sizeof(filter_filter_in_chain_t));
filter->function = pdftopdf;
- filter->parameters = NULL;
+ filter->parameters = strdup(output);
filter->name = "pdftopdf";
cupsArrayAdd(filter_chain, fi... |
Allow interrupts in cambus read/write_bytes functions.
* Those are used exclusively by the FIR sensors and not by the main
image sensor, so it's safe (and much faster) to leave interrupts enabled. | @@ -177,48 +177,36 @@ int cambus_writew2(I2C_HandleTypeDef *i2c, uint8_t slv_addr, uint16_t reg_addr,
int cambus_read_bytes(I2C_HandleTypeDef *i2c, uint8_t slv_addr, uint8_t reg_addr, uint8_t *buf, int len)
{
- int ret=0;
- __disable_irq();
if (HAL_I2C_Mem_Read(i2c, slv_addr, reg_addr,
I2C_MEMADD_SIZE_8BIT, buf, len, I... |
Fix envc transfer from host to guest with uhyve | @@ -386,7 +386,7 @@ static int initd(void* arg)
for(i=0; i<uhyve_cmdsize.envc-1; i++)
uhyve_cmdval_phys.envp[i] = (char*) virt_to_phys((size_t) uhyve_cmdval.envp[i]);
// the last element is always NULL
- uhyve_cmdval_phys.envp[uhyve_cmdsize.envc-1] = NULL;
+ uhyve_cmdval.envp[uhyve_cmdsize.envc-1] = NULL;
uhyve_cmdval_... |
Fix description of the translation function | @@ -1281,14 +1281,27 @@ static inline mbedtls_svc_key_id_t mbedtls_ssl_get_opaque_psk(
return( MBEDTLS_SVC_KEY_ID_INIT );
}
-/* Corresponding PSA algorithm for MBEDTLS_CIPHER_NULL */
+/* Corresponding PSA algorithm for MBEDTLS_CIPHER_NULL.
+ * Same value is used fo PSA_ALG_CATEGORY_CIPHER, hence it is
+ * guaranteed to... |
update CHAIN_ID for kusd mainnet | @@ -88,7 +88,7 @@ DEFINES += CHAINID_UPCASE=\"WAN\" CHAINID_COINNAME=\"WAN\" CHAIN_KIND=CHAIN_KIND
APPNAME = "Wanchain"
else ifeq ($(CHAIN),kusd)
APP_LOAD_PARAMS += --path "44'/91927009'"
-DEFINES += CHAINID_UPCASE=\"KUSD\" CHAINID_COINNAME=\"KUSD\" CHAIN_KIND=CHAIN_KIND_KUSD CHAIN_ID=2
+DEFINES += CHAINID_UPCASE=\"KUS... |
Coalesce EOED + client Finished in one UDP packet | @@ -1520,9 +1520,12 @@ static ssize_t conn_write_client_handshake(ngtcp2_conn *conn, uint8_t *dest,
ngtcp2_tstamp ts) {
ngtcp2_ringbuf *rb = &conn->tx_crypto_data;
ngtcp2_crypto_data *cdata;
+ ssize_t nwrite;
+ ssize_t res = 0;
+ for (;;) {
if (ngtcp2_ringbuf_len(rb) == 0) {
- return 0;
+ return res;
}
cdata = ngtcp2_r... |
Fix test_cmp_cli for extended tests
The test_cmp_cli was failing in the extended tests on cross-compiled
mingw builds. This was due to the test not using wine when it should do.
The simplest solution is to just skip the test in this case.
[extended tests] | @@ -34,6 +34,8 @@ plan skip_all => "These tests are not supported in a no-ec build"
plan skip_all => "Tests involving CMP server not available on Windows or VMS"
if $^O =~ /^(VMS|MSWin32)$/;
+plan skip_all => "Tests involving CMP server not available in cross-compile builds"
+ if defined $ENV{EXE_SHELL};
plan skip_all ... |
p9dsu: Describe platform BMC register configuration
Provide the p9dsu-specific BMC configuration values required for the
host kernel to drive the VGA display correctly. | @@ -688,9 +688,17 @@ static const struct bmc_sw_config bmc_sw_smc = {
.ipmi_oem_hiomap_cmd = IPMI_CODE(0x3a, 0x5a),
};
+/* Provided by Eric Chen (SMC) */
+const struct bmc_hw_config p9dsu_bmc_hw = {
+ .scu_revision_id = 0x04030303,
+ .mcr_configuration = 0x11000756,
+ .mcr_scu_mpll = 0x000071c1,
+ .mcr_scu_strap = 0x00... |
store: include internal header | * https://www.openssl.org/source/license.html
*/
-#include <openssl/store.h>
#include <openssl/crypto.h>
+#include "crypto/store.h"
#include "internal/core.h"
#include "internal/namemap.h"
#include "internal/property.h"
|
dnstap debug tool, document string change more clearly. | @@ -474,8 +474,11 @@ static char* q_of_msg(ProtobufCBinaryData message)
if(sldns_wire2str_rrquestion_buf(message.data+12, message.len-12,
buf, sizeof(buf)) != 0) {
/* remove trailing newline, tabs to spaces */
+ /* remove the newline: */
if(buf[0] != 0) buf[strlen(buf)-1]=0;
+ /* remove first tab (before type) */
if(st... |
Don't ignore command-line CFALGS | @@ -33,7 +33,7 @@ else
puts 'using an unknown (old?) compiler... who knows if this will work out... we hope.'
end
-$CFLAGS = '-std=c11 -O3 -Wall -DSERVER_DELAY_IO=1 -DNO_CHILD_REAPER=1'
+$CFLAGS = "-std=c11 -O3 -Wall -DSERVER_DELAY_IO=1 -DNO_CHILD_REAPER=1 #{ENV['CFLAGS']}"
RbConfig::MAKEFILE_CONFIG['CC'] = $CC = ENV['... |
BugID:22029688:Close lower after checking Download flag | @@ -90,9 +90,6 @@ void ota_parse_host_url(char *url, char **host_name, char **host_uri)
int ota_service_start(ota_service_t *ctx)
{
int ret = 0;
-#ifdef AOS_COMP_PWRMGMT
- aos_pwrmgmt_lowpower_suspend(PWRMGMT_OTA);
-#endif
ota_ctx = ctx;
#if defined OTA_CONFIG_SECURE_DL_MODE
ota_wdg.config.timeout = 180000;
@@ -103,6 +... |
Fix possibly uninitialized value
Due to gotos, "ret" may be returned uninitialized. | @@ -308,6 +308,8 @@ scrcpy(const struct scrcpy_options *options) {
return false;
}
+ bool ret = false;
+
bool server_started = false;
bool fps_counter_initialized = false;
bool video_buffer_initialized = false;
@@ -449,7 +451,7 @@ scrcpy(const struct scrcpy_options *options) {
input_manager_init(&input_manager, options... |
Log CreateProcessW() error code on Windows
Refs <https://github.com/Genymobile/scrcpy/issues/2838> | @@ -154,7 +154,9 @@ sc_process_execute_p(const char *const argv[], HANDLE *handle, unsigned flags,
dwCreationFlags, NULL, NULL, &si.StartupInfo, &pi);
free(wide);
if (!ok) {
- if (GetLastError() == ERROR_FILE_NOT_FOUND) {
+ int err = GetLastError();
+ LOGE("CreateProcessW() error %d", err);
+ if (err == ERROR_FILE_NOT_... |
apps: remove internal/cryptlib.h include that isn't used
[extended tests] | * https://www.openssl.org/source/license.html
*/
-#include <internal/cryptlib.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
@@ -110,8 +109,10 @@ static size_t internal_trace_cb(const char *buf, size_t cnt,
switch (cmd) {
case OSSL_TRACE_CTRL_BEGIN:
- if (!ossl_assert(!trace_data->ingroup))
+ if (trace_d... |
Add instrument select keyboard shortcuts to music editor using number keys | -import React, { useCallback, useContext } from "react";
+import React, { useCallback, useContext, useEffect } from "react";
import { useDispatch, useSelector } from "react-redux";
import styled, { ThemeContext } from "styled-components";
import { RootState } from "store/configureStore";
@@ -125,6 +125,44 @@ const Song... |
FIX: do sm_init() after arcus_check_server_mapping(). | @@ -416,7 +416,7 @@ arcus_zk_watcher(zhandle_t *wzh, int type, int state, const char *path, void *cx
}
#ifdef ENABLE_ZK_RECONFIG
- if (!arcus_conf.zk_reconfig) {
+ if (arcus_conf.init && !arcus_conf.zk_reconfig) {
/* enable zookeeper dynamic reconfiguration */
if (arcus_check_zk_reconfig_enabled(zinfo->zh) < 0) {
/* zo... |
Set default pattern for new junctions
Also fix an `ENgetqualtype` function call to include the project pointer | @@ -1512,7 +1512,7 @@ int DLLEXPORT EN_getqualtype(EN_Project *p, int *qualcode, int *tracenode) {
}
int DLLEXPORT EN_getqualinfo(EN_Project *p, int *qualcode, char *chemname, char *chemunits, int *tracenode) {
- ENgetqualtype(qualcode, tracenode);
+ EN_getqualtype(p, qualcode, tracenode);
if (p->quality.Qualflag == TR... |
publish: removed commented out code | ^- (quip card _state)
?- -.del
%add-book
- ::=. tile-num (add tile-num (get-unread data.del))
?: =(our.bol host.del)
=^ cards state
(emit-updates-and-state host.del book.del data.del del sty)
?~ book
[~ sty]
=. read.data.del =(our.bol author.data.del)
- ::=? tile-num.sty !read.data.del
- :: +(tile-num.sty)
=. notes.u.b... |
Correct the argument indices for Source:setCone | @@ -172,9 +172,9 @@ static int l_lovrSourceSeek(lua_State* L) {
static int l_lovrSourceSetCone(lua_State* L) {
Source* source = luax_checktype(L, 1, Source);
- float innerAngle = luax_checkfloat(L, 1);
- float outerAngle = luax_checkfloat(L, 2);
- float outerGain = luax_checkfloat(L, 3);
+ float innerAngle = luax_check... |
Add thermal throttle loss percent field in show dimm hii
This change displays the thermal throttle loss percent field
in show dimm hii page. This field is introduced in the
firmware interface specification v 2.1 and is already displayed
during output of show -a -dimm command. | @@ -421,6 +421,10 @@ UnlatchedLastShutdownStatus::
- PM Idle: Power management idle received
- DDRT Surprise Reset: Surprise reset received
+ThermalThrottleLossPercent::
+ The average performance loss percentage due to thermal throttling
+ in current boot of the DCPMM.
+
LastShutdownTime::
The time the system was last ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.