message
stringlengths
6
474
diff
stringlengths
8
5.22k
Use tostring to read error messages The `tostring` function will only fail if lua runs out of memory. This is more suitable for error message handling than `peek`, which fails if the error object is not a string.
@@ -35,16 +35,13 @@ module Foreign.Lua.Util ( returnError ) where +import Data.ByteString.Char8 (unpack) import Foreign.Lua.Functions import Foreign.Lua.Types -- | Return an error, reading and removing the error message from the stack. returnError :: Lua (Result a) returnError = do - err <- peek (-1) <* pop 1 - return ...
[components][usb] fix compile warning in cdc_vcom.c
@@ -738,7 +738,7 @@ static rt_size_t _vcom_rb_block_put(struct vcom *data, const rt_uint8_t *buf, rt return size; } -static rt_size_t _vcom_tx(struct rt_serial_device *serial, rt_uint8_t *buf, rt_size_t size,rt_uint32_t direction) +static rt_size_t _vcom_tx(struct rt_serial_device *serial, rt_uint8_t *buf, rt_size_t si...
Avoid app memory growth to isolate server memory growth testing.
@@ -10,10 +10,12 @@ require 'rack/lint' # Valid values are "hello", "slow" (debugs env values), "simple" app = 'hello' # This is a simple Hello World Rack application, for benchmarking. +HELLO_RESPONSE = [200, { 'Content-Type'.freeze => 'text/html'.freeze, + 'Content-Length'.freeze => '16'.freeze }.freeze, + ['Hello fr...
Add unit test for VS version check
@@ -76,3 +76,13 @@ Microsoft Visual Studio Solution File, Format Version 12.00 # Visual Studio 2013 ]] end + + + function suite.on2022() + p.action.set("vs2022") + prepare() + test.capture [[ +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio Version 17 + ]] + end
Clean up TCOD_sys_save_screenshot function.
@@ -836,19 +836,18 @@ void TCOD_sys_save_bitmap(void *bitmap, const char *filename) { void TCOD_sys_save_screenshot(const char *filename) { char buf[128]; - if ( filename == NULL ) { - /* generate filename */ int idx = 0; - do { - FILE *f=NULL; + while (!filename) { + /* generate filename */ + FILE *access_file = NULL;...
Clarify the restart operation
@@ -36,7 +36,7 @@ typedef struct clap_param_info { bool is_bypass; // used to merge the plugin and host bypass button. /* value */ - clap_param_type type; + clap_param_type type; // this field is not allowed to change for a given param id clap_param_value min_value; // minimum plain value clap_param_value max_value; //...
dwarf: Avoid a leak for a no-cache failure in create_state_record_for. Avoid a duplicate copy for a cache miss.
@@ -874,46 +874,19 @@ apply_reg_state (struct dwarf_cursor *c, struct dwarf_reg_state *rs) return 0; } -static int -uncached_dwarf_find_save_locs (struct dwarf_cursor *c) -{ - dwarf_state_record_t sr; - int ret; - - if ((ret = fetch_proc_info (c, c->ip, 1)) < 0) - { - put_unwind_info (c, &c->pi); - return ret; - } - - ...
extmod/modiodevices/LUMPDevice: enable read Get the values from the sensor for the currently active mode.
@@ -47,8 +47,45 @@ STATIC mp_obj_t iodevices_LUMPDevice_make_new(const mp_obj_type_t *type, size_t // pybricks.iodevices.LUMPDevice.read STATIC mp_obj_t iodevices_LUMPDevice_read(mp_obj_t self_in) { iodevices_LUMPDevice_obj_t *self = MP_OBJ_TO_PTR(self_in); - (void)self; - return mp_obj_new_int(12345); + + pbio_port_t ...
fixes double free / no http web response
@@ -121,7 +121,6 @@ static int handleRequest(void* cls, struct MHD_Connection* connection) { syslog(LOG_AUTHPRIV | LOG_DEBUG, "Httpserver ipc response is: %s", res); ret = makeResponseFromIPCResponse(connection, res, oidcgen_call, state); } - secFree(res); secFreeArray(cr, 3); secFree(oidcgen_call); return ret;
keystore: fix u2f
@@ -582,14 +582,13 @@ bool keystore_get_u2f_seed(uint8_t* seed_out) if (keystore_is_locked()) { return false; } + uint8_t* bip39_seed = _get_bip39_seed(); + if (bip39_seed == NULL) { + return false; + } const uint8_t message[] = "u2f"; - if (wally_hmac_sha256( - _retained_seed, - sizeof(_retained_seed), - message, - si...
Move switching to handshake transform after sending CCS record
@@ -1239,11 +1239,6 @@ static int ssl_tls13_finalize_write_server_hello( mbedtls_ssl_context *ssl ) return( ret ); } - mbedtls_ssl_set_outbound_transform( ssl, - ssl->handshake->transform_handshake ); - MBEDTLS_SSL_DEBUG_MSG( - 3, ( "switching to handshake transform for outbound data" ) ); - return( ret ); } @@ -1407,6...
Put all observers before overrides
@@ -499,6 +499,16 @@ void FunctionOverride::Override(const std::string& acTypeName, const std::string pContext->Environment = aEnvironment; pContext->Forward = !aAbsolute; + if (aAbsolute || pEntry->Calls.empty()) + { pEntry->Calls.emplace_back(std::move(pContext)); } + else + { + auto pos = std::find_if(pEntry->Calls....
Fix test_unknown_ascii_encoding_ok() to work in builds
@@ -6003,7 +6003,7 @@ START_TEST(test_unknown_ascii_encoding_ok) "<doc>Hello, world</doc>"; XML_SetUnknownEncodingHandler(parser, MiscEncodingHandler, NULL); - run_character_check(text, "Hello, world"); + run_character_check(text, XCS("Hello, world")); } END_TEST
doc: add link to OPMPHM to doc/dev/data-structures.md
@@ -24,7 +24,7 @@ presents the best candidate for lookups O(1). `KeySet` combines the best of both worlds: `KeySet` is implemented as a sorted array and uses -an order-preserving minimal perfect hash map (OPMPHM) for lookups. +an [order-preserving minimal perfect hash map (OPMPHM)](#order-preserving-minimal-perfect-has...
[build] add to autogen.sh hint listing reqd pkgs add hint to autogen.sh listing packages required for build if ./autogen.sh fails
#!/bin/sh # Run this to generate all the initial makefiles, etc. +function errtrace { + echo 1>&2 \ + "build requires autoconf automake libtool m4 pcre pcre-devel pkg-config" +} + +trap errtrace ERR + set -e if [ ! -f configure.ac -o ! -f COPYING ]; then
coverity Incorrect expression
@@ -205,7 +205,7 @@ static int builder_limit_test(void) for (i = 0; i < n; i++) { names[i][0] = 'A' + (i / 26) - 1; - names[i][0] = 'a' + (i % 26) - 1; + names[i][1] = 'a' + (i % 26) - 1; names[i][2] = '\0'; if (!TEST_true(OSSL_PARAM_BLD_push_int(bld, names[i], 3 * i + 1))) goto err;
docs: add contributor notes about running unit tests.
@@ -226,3 +226,42 @@ Generally a PR will target the default `master` branch so the changes will go in Once merged, this does not mean they will automatically go into the next minor release of the current series. A particular set of changes might want to be applied to the current or previous releases so please also subm...
[mechanics] initialize attributes
@@ -47,7 +47,7 @@ protected: /** If false, bodies connected to this body by a joint will not * collide. See also NewtonEulerJointR::_allowSelfCollide */ - bool _allowSelfCollide; + bool _allowSelfCollide = true; public:
nimble/ll: Add missing check for support BLE_LL_CTRL_PHY_UPD_IND This is needed for LL/PAC/SLA/BV-01
@@ -2248,6 +2248,9 @@ ble_ll_ctrl_rx_pdu(struct ble_ll_conn_sm *connsm, struct os_mbuf *om) case BLE_LL_CTRL_PHY_REQ: feature = BLE_LL_FEAT_LE_2M_PHY | BLE_LL_FEAT_LE_CODED_PHY; break; + case BLE_LL_CTRL_MIN_USED_CHAN_IND: + feature = BLE_LL_FEAT_MIN_USED_CHAN; + break; default: feature = 0; break;
test: add EVP_Q_digest tests to evp_test Fixes
@@ -399,9 +399,12 @@ static int digest_update_fn(void *ctx, const unsigned char *buf, size_t buflen) static int digest_test_run(EVP_TEST *t) { DIGEST_DATA *expected = t->data; + EVP_TEST_BUFFER *inbuf; EVP_MD_CTX *mctx; unsigned char *got = NULL; unsigned int got_len; + size_t size; + int xof = 0; OSSL_PARAM params[2];...
add empty section for compile options
@@ -17,10 +17,12 @@ elseif(CMAKE_C_COMPILER_ID MATCHES "Clang") endif() add_compile_options(-Xclang -Wall -Wextra -pedantic ${WARNINGS_AS_ERRORS_FLAG} -Wdocumentation -Wdocumentation-unknown-command -fcomment-block-commands=retval -Wcast-qual -Wunused -Wuninitialized -Wmissing-declarations -Wconversion -Wpointer-arith ...
build windows pipeline in parallel
@@ -37,6 +37,7 @@ jobs: inputs: solution: $(BuildType)/libmimalloc.sln configuration: '$(MSBuildConfiguration)' + msbuildArguments: -m - script: | cd $(BuildType) ctest --verbose --timeout 120
Disable multiple validations for master data directory in gpactivatestandby
@@ -102,24 +102,19 @@ def parseargs(): parser.print_version() parser.exit(0, None) - # check that there isn't a conflict between -d option and MASTER_DATA_DIRECTORY env + + if not options.master_data_dir: + logger.info('Option -d or --master-data-directory not set. Checking environment variable MASTER_DATA_DIRECTORY') ...
Add explicit typecasts.
@@ -888,7 +888,7 @@ int yr_parser_reduce_rule_declaration_phase_1( identifier, &ref)); - rule->identifier = yr_arena2_ref_to_ptr(compiler->arena, &ref); + rule->identifier = (const char*) yr_arena2_ref_to_ptr(compiler->arena, &ref); rule->flags = flags; rule->ns = ns; rule->num_atoms = 0; @@ -958,7 +958,7 @@ int yr_par...
Update out~-help.pd
-#N canvas 694 55 562 511 10; +#N canvas 774 23 562 511 10; #X obj 3 486 cnv 15 552 21 empty \$0-pddp.cnv.footer empty 20 12 0 14 -228856 -66577 0; #X obj 3 254 cnv 3 550 3 empty \$0-pddp.cnv.inlets inlets 8 12 0 13 @@ -359,9 +359,6 @@ isn't loud enough \, if it is too high or even if you're using multiple #X obj 345 1...
zephyr test: syv682c: Use correct port The SYV682c is in the device tree on port 1, so use that port when checking if the SYV682 is version C. TEST=zmake configure --test zephyr/test/drivers BRANCH=none
@@ -27,7 +27,7 @@ static const int syv682x_port = 1; ZTEST(ppc_syv682c, test_board_is_syv682c) { - zassert_true(syv682x_board_is_syv682c(0), NULL); + zassert_true(syv682x_board_is_syv682c(syv682x_port), NULL); } static void check_control_1_default_init(uint8_t control_1)
schema compile UPDATE error check
@@ -3542,6 +3542,7 @@ lys_compile_node_choice_child(struct lysc_ctx *ctx, struct lysp_node *child_p, s } else { /* we need the implicit case first, so create a fake parsed (shorthand) case */ cs_p = calloc(1, sizeof *cs_p); + LY_CHECK_ERR_RET(!cs_p, LOGMEM(ctx->ctx), LY_EMEM); cs_p->nodetype = LYS_CASE; DUP_STRING_GOTO...
prevent double-free of RgbaInputFile::_inputPart
@@ -1301,7 +1301,7 @@ void RgbaInputFile::setLayerName (const string& layerName) { delete _fromYca; - _fromYca = 0; + _fromYca = nullptr; _channelNamePrefix = prefixFromLayerName (layerName, _inputPart->header ()); @@ -1320,6 +1320,8 @@ RgbaInputFile::setPartAndLayer (int part, const string& layerName) delete _fromYca;...
give more time to Github Actions CI Keycloak startup scripts
@@ -9,7 +9,7 @@ while ! curl -k -s https://keycloak:8443/auth/ > /dev/null ; do sleep 2 ; done while ! curl -k -s https://apache:443/auth/ > /dev/null ; do sleep 2 ; done # give Keycloak time to run startup scripts to create clients -sleep 5 +sleep 10 # run headless JMeter for a number of threads/loops and record resul...
Fix wrong tips when the user pass wrong # of arguments to redis.set_repl(). redis.set_repl() needs one arg, but the tips says two.
@@ -1054,7 +1054,7 @@ static int luaRedisSetReplCommand(lua_State *lua) { serverAssert(rctx); /* Only supported inside script invocation */ if (argc != 1) { - luaPushError(lua, "redis.set_repl() requires two arguments."); + luaPushError(lua, "redis.set_repl() requires one argument."); return luaError(lua); }
Support Ping during handshake
@@ -3589,6 +3589,7 @@ int picoquic_decode_frames(picoquic_cnx_t* cnx, picoquic_path_t * path_x, uint8_ } bytes = picoquic_decode_ack_frame(cnx, bytes, bytes_max, current_time, epoch, 1); } else if (epoch != 1 && epoch != 3 && first_byte != picoquic_frame_type_padding + && first_byte != picoquic_frame_type_ping && first...
Loop uniformly in export.
@@ -260,26 +260,24 @@ tagexports(Node *file, int hidelocal) /* tag the traits */ tr = NULL; - k = htkeys(st->tr, &n); - for (j = 0; j < n; j++) { - tr = gettrait(st, k[j]); + for (i = 0; i < ntraittab; i++) { + tr = traittab[i]; if (tr->vis != Visexport) continue; if (hidelocal && tr->ishidden) tr->vis = Vishidden; tr-...
dpdk: port type from speed_capa bitmap on Cisco VIC enic driver now properly exposes speed_capa bitmap so this workaround is not needed anymore. Type: refactor
@@ -80,36 +80,6 @@ port_type_from_speed_capa (struct rte_eth_dev_info *dev_info) return VNET_DPDK_PORT_TYPE_UNKNOWN; } -static dpdk_port_type_t -port_type_from_link_speed (u32 link_speed) -{ - switch (link_speed) - { - case ETH_SPEED_NUM_1G: - return VNET_DPDK_PORT_TYPE_ETH_1G; - case ETH_SPEED_NUM_2_5G: - return VNET_...
[DataBinding] fix bind cell paths issue
@@ -418,6 +418,9 @@ static int luaui_bind_cell (lua_State *L) { NSUInteger section = lua_tonumber(L, -3); NSUInteger row = lua_tonumber(L, -2); NSArray *paths = [luaCore toNativeObject:-1 error:NULL]; + if (paths.count == 0) { + return 1; + } UIView *listView = [dataBind listViewForTag:nKey]; if (!listView) return 1;
pthreads not correctly compiled in (when using cmake)
-cmake_minimum_required(VERSION 2.8) +cmake_minimum_required(VERSION 3.1) project (libbson C) @@ -214,11 +214,17 @@ if (RT_LIBRARY) target_link_libraries (bson_static ${RT_LIBRARY}) endif() -if (UNIX) - find_package (Threads) - target_link_libraries (bson_shared ${CMAKE_THREAD_LIBS_INIT}) - target_link_libraries (bson_...
decisions: fix syntax error
@@ -113,7 +113,7 @@ Explanations of the template are in [EXPLANATIONS.md](../EXPLANATIONS.md). ```mermaid flowchart LR - s((Start)) --> Drafts --> In_Discussion -> In_Progress -> Decided -> Partially_Implemented -> Implemented + s((Start)) --> Drafts --> In_Discussion --> In_Progress --> Decided --> Partially_Implement...
interface: convert s3 store to zustand
@@ -2,6 +2,7 @@ import { useCallback, useMemo, useEffect, useRef, useState } from 'react'; import { S3State } from '../../types/s3-update'; import S3 from 'aws-sdk/clients/s3'; import { dateToDa, deSig } from './util'; +import useS3State from '../state/s3'; export interface IuseS3 { canUpload: boolean; @@ -11,8 +12,9 @...
YAMBi: Simplify unit test macros
@@ -25,17 +25,15 @@ using CppKey = kdb::Key; #define OPEN_PLUGIN(parentName, filepath) \ CppKeySet modules{ 0, KS_END }; \ - CppKeySet config{ 0, KS_END }; \ elektraModulesInit (modules.getKeySet (), 0); \ + CppKeySet config{ 0, KS_END }; \ CppKey parent{ parentName, KEY_VALUE, filepath, KEY_END }; \ - Plugin * plugin ...
board_inspector: more verbose messages It is quite common to meet permissions errors when opening a specific region of /dev/mem due to kernel configurations. This patch adds a bit more logs on this for eaiser debugging.
@@ -310,7 +310,12 @@ class OperationRegion(Object): logging.info(f"Open system memory space {name}: [{hex(offset)}, {hex(offset + length - 1)}]") offset_page_aligned = (offset >> 12) << 12 length_page_aligned = ceil(((offset & 0xFFF) + length) / 0x1000) * 0x1000 + try: mm = mmap.mmap(cls.devmem.fileno(), length_page_al...
Fix msg_repair() msg_repair() seems to have been broken in previous patches. This patch undoes the changes made to it earlier. Revist if removing it causes issues in the future.
@@ -881,8 +881,10 @@ static rstatus_t msg_repair(struct context *ctx, struct conn *conn, return DN_ENOMEM; } - mbuf = STAILQ_LAST(&msg->mhdr, mbuf, next); - mbuf_remove(&msg->mhdr, mbuf); + // This was added to handle a specific case which doesn't seem reproducible + // now. Revisit if things seem off. + //mbuf = STAIL...
makefile.unix Formatting
@@ -43,6 +43,7 @@ ifndef USE_NATIVETOR endif ifneq (${USE_NATIVETOR}, -) DEFS += $(addprefix -I,$(CURDIR)/tor) -DUSE_NATIVETOR=$(USE_NATIVETOR) + @echo "Building with Native Tor Support ..."; endif ifndef USE_UPNP @@ -113,7 +114,6 @@ xLDFLAGS=$(LDHARDENING) $(LDFLAGS) # Tor C Library Sources ifeq (${USE_NATIVETOR}, 1) ...
Debugging: Reduce number of printed messages
@@ -239,9 +239,6 @@ static grib_trie* load_bufr_elements_table(grib_accessor* a, int* err) dictionary = NULL; goto the_end; } - else { - grib_context_log(c, GRIB_LOG_DEBUG, "bufr_elements_table: found def file %s", filename); - } dictionary = (grib_trie*)grib_trie_get(c->lists, dictName); if (dictionary) {
Consolidate usage of backticks for build options There were some build options in the README that were not highlighted. Now all are highlighted.
@@ -174,18 +174,18 @@ Please read `GotoBLAS_01Readme.txt` for older CPU models already supported by th ### Support for multiple targets in a single library -OpenBLAS can be built for multiple targets with runtime detection of the target cpu by specifiying DYNAMIC_ARCH=1 in Makefile.rule, on the gmake command line or as...
Don't derive wrong types for NumArgs, NumResults The classes *Integral* and *Real* don't really make sense for, and neither does *Enum*.
@@ -185,8 +185,8 @@ newtype StackIndex = StackIndex { fromStackIndex :: CInt } -- | The number of arguments expected a function. newtype NumArgs = NumArgs { fromNumArgs :: CInt } - deriving (Enum, Eq, Integral, Num, Ord, Real, Show) + deriving (Eq, Num, Ord, Show) -- | The number of results returned by a function call....
schema BUGFIX resolving prefix in schemas incorrect check could cause not resolving default prefix.
@@ -1026,7 +1026,7 @@ lys_module_find_prefix(const struct lys_module *mod, const char *prefix, size_t struct lys_module *m = NULL; LY_ARRAY_COUNT_TYPE u; - if (!prefix || !ly_strncmp(mod->prefix, prefix, len)) { + if (!len || !ly_strncmp(mod->prefix, prefix, len)) { /* it is the prefix of the module itself */ m = (stru...
mousefilter: giving props
#include "hammer/gui.h" //2016 note: now works with anything, pre v3: only floats - Derek Kwan -//issue: mousefilter_doup called after float method called -//meaning: mousedowns on slider leak through +//props to Thomas Musil's iemlib_anything to figure out how to do handle anythings + +//mousefilter_doup called after ...
Hack 20px left padding into ol to visually match ul's left indent
margin-bottom: 10px; } p, - ol, + /* ol, */ li, code { font-size: 16px; margin: 10px 0; } ol { - padding: 0; + /* padding: 0; */ + padding-left: 20px; + margin: 5px 0; + font-size: 16px; } li { margin: 5px 0; padding: 0; margin: 0; } - li ul { + li ul, li ol { margin: 0; li { list-style-type: none;
fix skinparser casting int to str
@@ -117,7 +117,7 @@ class Skin: general['AllowSliderBallTint'] = self.int(general.get('AllowSliderBallTint', 0)) general['SliderBallFlip'] = self.int(general.get('SliderBallFlip', 0)) general['AnimationFramerate'] = self.int(general.get('AnimationFramerate', 60)) - general['Version'] = self.int(general.get('Version', 1...
Fix timers feature being true on GLES;
@@ -1254,7 +1254,7 @@ void lovrGpuInit(void* (*getProcAddress)(const char*), bool debug) { state.features.dxt = GLAD_GL_EXT_texture_compression_s3tc; state.features.instancedStereo = GLAD_GL_ARB_viewport_array && GLAD_GL_AMD_vertex_shader_viewport_index && GLAD_GL_ARB_fragment_layer_viewport; state.features.multiview =...
install instructions be available in README
@@ -23,6 +23,26 @@ layer handshakes. Documentation and examples can be found at https://zmap.io/. +Installation +------------ + +The latest stable release of ZMap is version 2.1.1 and supports Linux, Mac OS, +and BSD. It can be installed through the built-in package managers on the +following operating systems: + +Debi...
Add an utility to create a directory structure for an Arcadia Python build project and populate it with symlinks to the source files. Pull-request for branch users/somov/pycharm
@@ -184,6 +184,15 @@ def onpy_srcs(unit, *args): evs = [] swigs = [] + dump_dir = unit.get('PYTHON_BUILD_DUMP_DIR') + dump_output = None + if dump_dir: + import thread + pid = os.getpid() + tid = thread.get_ident() + dump_name = '{}-{}.dump'.format(pid, tid) + dump_output = open(os.path.join(dump_dir, dump_name), 'a') ...
board/aleena/led.c: Format with clang-format BRANCH=none TEST=none
@@ -30,16 +30,22 @@ static enum gpio_signal led_blue = GPIO_BAT_LED_2_L; /* Note there is only LED for charge / power */ __override struct led_descriptor led_bat_state_table[LED_NUM_STATES][LED_NUM_PHASES] = { - [STATE_CHARGING_LVL_2] = {{EC_LED_COLOR_AMBER, LED_INDEFINITE} }, - [STATE_CHARGING_FULL_CHARGE] = {{EC_LED_...
server messages CHANGE check for notification presence in a notif tree
@@ -827,6 +827,7 @@ API struct nc_server_notif * nc_server_notif_new(struct lyd_node* event, char *eventtime, NC_PARAMTYPE paramtype) { struct nc_server_notif *ntf; + struct lyd_node *elem; if (!event) { ERRARG("event"); @@ -836,6 +837,34 @@ nc_server_notif_new(struct lyd_node* event, char *eventtime, NC_PARAMTYPE para...
MSR: Only add syntax test if INI is available
@@ -14,8 +14,11 @@ function (add_plugin_shell_test PLUGIN) endif () endfunction () - +# Only add test below if INI plugin is available +list (FIND REMOVED_PLUGINS mini PLUGIN_INDEX_INI) +if (${PLUGIN_INDEX_INI} EQUAL -1) add_s_test (msr_syntax "${CMAKE_SOURCE_DIR}/tests/shell/shell_recorder/tutorial_wrapper/SyntaxCheck...
Recursively add target dependency env
@@ -89,6 +89,16 @@ function _on_run_target(target) _do_run_target(target) end +-- recursively target add env +function _add_target_pkgenvs(target) + for name, values in pairs(target:pkgenvs()) do + os.addenv(name, unpack(values)) + end + for _, dep in ipairs(target:orderdeps()) do + _add_target_pkgenvs(dep) + end +end ...
Don't stop a script before editing another one
@@ -385,9 +385,9 @@ fileprivate func parseArgs(_ args: inout [String]) { } } - if Python.shared.isScriptRunning { + /*if Python.shared.isScriptRunning { Python.shared.stop() - } + }*/ } } @@ -877,7 +877,7 @@ fileprivate func parseArgs(_ args: inout [String]) { /// The View controller is closed and the document is saved...
ixfr-out, extra guard nul on buffer.
@@ -1703,6 +1703,7 @@ int ixfr_read_file_header(struct zone* zone, const char* zfile, /* read about 10 lines, this is where the header is */ while(!(got_old && got_new) && num_lines < 10) { buf[0]=0; + buf[sizeof(buf)-1]=0; if(!fgets(buf, sizeof(buf), in)) { log_msg(LOG_ERR, "could not read %s: %s", ixfrfile, strerror(...
Data skipping tests for IPC
@@ -178,6 +178,43 @@ int main() { rc = hclose(s[1]); errno_assert(rc == 0); + /* Try skipping some data. */ + rc = ipc_pair(s); + errno_assert(rc == 0); + rc = bsend(s[0], "ABCDEFGHIJ", 10, -1); + errno_assert(rc == 0); + rc = brecv(s[1], buf, 3, -1); + errno_assert(rc == 0); + assert(buf[0] == 'A' && buf[1] == 'B' && ...
migration_guide: Mention ERR_GET_FUNC() and function code removal Fixes
@@ -451,6 +451,11 @@ For example when setting an unsupported curve with EVP_PKEY_CTX_set_ec_paramgen_curve_nid() this function call will not fail but later keygen operations with the EVP_PKEY_CTX will fail. +=head4 Removal of function code from the error codes + +The function code part of the error code is now always s...
Rename index to idx for main function in s2nc.c Currently, some compilers would complain variable index shadows a global declaration. Hence rename it.
@@ -264,20 +264,20 @@ int main(int argc, char *const *argv) } const char *next = alpn_protocols; - int index = 0; + int idx = 0; int length = 0; ptr = alpn_protocols; while (*ptr) { if (*ptr == ',') { - protocols[index] = malloc(length + 1); - if (!protocols[index]) { + protocols[idx] = malloc(length + 1); + if (!proto...
More gtest Warning Refactoring
@@ -130,22 +130,18 @@ function Log($msg) { } function LogWrn($msg) { - if ($AZP) { + if ($AZP -and !$ErrorsAsWarnings) { Write-Host "##vso[task.LogIssue type=warning;][$(Get-Date)] $msg" } else { - Write-Host "[$(Get-Date)] $msg" + Write-Warning "[$(Get-Date)] $msg" } } function LogErr($msg) { - if ($AZP) { - if ($Erro...
release: further small fixes in notes
@@ -139,7 +139,9 @@ We updated the behavior, since otherwise the plugin will report memory leaks at ### Yan LR -- The plugin does not modify the (original) parent key any more. As a consequence, setting values at the root of a mountpoint: +A new plugin parsing YAML files using Yan LR. + +- The plugin does not modify th...
Sailfish: add ruby date files to project
@@ -111,6 +111,10 @@ SOURCES += \ <%= @rhoRoot %>/platform/shared/ruby/ext/rho/rhosupport.c \ <%= @rhoRoot %>/platform/shared/ruby/ext/rhoconf/rhoconf_wrap.c \ <%= @rhoRoot %>/platform/shared/ruby/ext/ringtones/ringtones_wrap.c \ +<%= @rhoRoot %>/platform/shared/ruby/ext/date/date_parse.c \ +<%= @rhoRoot %>/platform/sh...
[Kernel] Enable LAPIC and its timer
@@ -29,6 +29,10 @@ void ap_c_entry(void) { } void ap_entry_part2(void) { + printf("Enabling LAPIC...\n"); + local_apic_enable(); + printf("Enabling LAPIC timer...\n"); + local_apic_enable_timer(); while (1) {} }
xive: Keep track of which interrupts were ever enabled In order to speed up xive reset
@@ -381,6 +381,11 @@ struct xive { uint32_t int_hw_bot; /* Bottom of HW allocation */ uint32_t int_ipi_top; /* Highest IPI handed out so far + 1 */ + /* We keep track of which interrupts were ever enabled to + * speed up xive_reset + */ + bitmap_t *int_enabled_map; + /* Embedded source IPIs */ struct xive_src ipis; }; ...
switch back to rx as early as possible
@@ -382,14 +382,15 @@ static uint8_t frsky_d16_handle_packet() { } break; case FRSKY_STATE_RESUME: - if ((cc2500_get_status() & (0x70)) == 0 && (timer_micros() - last_packet_received_time) >= (rx_delay + 3700)) { - last_packet_received_time = timer_micros(); - rx_delay = 5300; - frame_had_packet = 0; - + if ((cc2500_ge...
esp_wifi:added hash key length validation
@@ -339,8 +339,11 @@ int crypto_public_key_decrypt_pkcs1(struct crypto_public_key *key, size_t len; u8 *pos; mbedtls_pk_context *pkey = (mbedtls_pk_context *)key; + len = mbedtls_pk_rsa(*pkey)->MBEDTLS_PRIVATE(len); + if (len != crypt_len) { + return -1; + } - len = *plain_len; if (mbedtls_rsa_public(mbedtls_pk_rsa(*pk...
hark: fix notification archival
@@ -443,9 +443,9 @@ function archive(json: any, state: HarkState): HarkState { ); if(unarchived.length === 0) { console.log('deleting entire timebox'); - state.notifications.delete(time); + state.notifications = state.notifications.delete(time); } else { - state.notifications.set(time, unarchived); + state.notification...
Add PhRunTaskAsInteractiveUser
@@ -1654,6 +1654,14 @@ PhHungWindowFromGhostWindow( _In_ HWND WindowHandle ); +PHLIBAPI +HRESULT +NTAPI +PhRunTaskAsInteractiveUser( + _In_ PWSTR CommandLine, + _In_ PWSTR CurrentDirectory + ); + PHLIBAPI PLDR_DATA_TABLE_ENTRY NTAPI
deprecate engines in 3.0
@@ -600,9 +600,8 @@ my @disable_cascades = ( "cmp" => [ "crmf" ], - # Padlock engine uses low-level AES APIs which are deprecated sub { $disabled{"deprecated-3.0"} } - => [ "padlockeng" ] + => [ "engine" ] ); # Avoid protocol support holes. Also disable all versions below N, if version
in_windows_exporter_metrics: remove reference to event_type flag
@@ -217,5 +217,4 @@ struct flb_input_plugin in_windows_exporter_metrics_plugin = { .cb_pause = in_we_pause, .cb_resume = in_we_resume, .cb_exit = in_we_exit, - .event_type = FLB_INPUT_METRICS };
webterm: improve selection look & feel
@@ -45,7 +45,8 @@ const makeTheme = (dark: boolean): ITheme => { foreground: fg, background: bg, brightBlack: '#7f7f7f', // NOTE slogs - cursor: fg + cursor: fg, + selection: fg }; }; @@ -66,7 +67,9 @@ const termConfig: ITerminalOptions = { bellSound: bel, // // allows text selection by holding modifier (option, or shi...
Add source code URL to macOS credits
{\colortbl;\red255\green255\blue255;\red9\green79\blue209;} {\*\expandedcolortbl;;\cssrgb\c0\c40784\c85490\cname linkColor;} \margl1440\margr1440\vieww9000\viewh8400\viewkind0 -\pard\tx0\tx566\tx1133\tx1700\tx2267\tx2834\tx3401\tx3968\tx4535\tx5102\tx5669\tx6236\tx6803\pardirnatural\partightenfactor0 +\pard\tx0\tx566\t...
imx8x: Fix description of usb boot target
@@ -814,6 +814,6 @@ let bin_rcce_lu = [ "/sbin/" ++ f | f <- [ Str "--bf", In BuildTree "root" "/armv8_imx8x_image.efi" ] - "Boot Barrelfish on a Pandaboard, over a local USB cable" + "Boot Barrelfish on a Colibri board, over a local USB cable" ]
acrn-config: refine mem_size_set function mem_size should be set from xml, it should not be overrided dynamically. Acked-by: Victor Sun
@@ -251,29 +251,10 @@ def wa_usage(uos_type, config): print("echo on > /sys/devices/pci0000:00/0000:00:15.0/power/control", file=config) print("", file=config) -def mem_size_set(names, args, vmid, config): - - uos_type = names['uos_types'][vmid] +def mem_size_set(args, vmid, config): mem_size = args['mem_size'][vmid] -...
Update README.md Fix broken link and a typo
@@ -13,7 +13,7 @@ Because Box64 uses the native versions of some "system" libraries, like libc, li Box64 integrates a DynaRec (dynamic recompiler) for the ARM64 platform, providing a speed boost between 5 to 10 times faster than only using the interpreter. Some high level information on how the Dynarec work can be foun...
Add build tool stuff for portmidi library
@@ -26,6 +26,10 @@ Options: Note: --pie and --static cannot be mixed. -s Print statistics about compile time and binary size. -h or --help Print this message and exit. +Optional Features: + --portmidi Enable hardware MIDI output support with PortMIDI. + Default: not enabled + Note: PortMIDI has memory leaks and bugs. E...
Fix socket timeout for sending & receiving
@@ -685,9 +685,8 @@ HRESULT Library_sys_net_native_System_Net_Sockets_NativeSocket::SendRecvHelper( if (offset + count > arrData->m_numOfElements) NANOCLR_SET_AND_LEAVE(CLR_E_INDEX_OUT_OF_RANGE); - // Infinite Timeout - // !! need to cast to CLR_INT64 otherwise it wont setup a proper timeout infinite - hbTimeout.SetInt...
vm/page free: fix to only merge contiguous pages if it results in a properly aligned region
@@ -97,10 +97,10 @@ page_t *vm_pageAlloc(size_t size, u8 flags) } -void _page_free(page_t *lh) +void _page_free(page_t *p) { - unsigned int idx, i, sidx; - page_t *rh; + unsigned int idx, i; + page_t *lh = p, *rh = p; #if 1 if (lh->flags & PAGE_FREE) { @@ -111,29 +111,41 @@ void _page_free(page_t *lh) } #endif - idx = ...
simple: add WARN()
@@ -314,6 +314,7 @@ static void simple_sched_poll(uint64_t now, int idle_cnt, bitmap_ptr_t idle) } if (unlikely(simple_run_kthread_on_core(sd->p, core))) { + WARN(); bitmap_set(simple_idle_cores, core); simple_mark_congested(sd); }
Update L2 header offset after VLAN tag rewrite
@@ -105,9 +105,11 @@ l2_vtr_process (vlib_buffer_t * b0, vtr_config_t * config) *((u64 *) eth) = temp_8; *((u32 *) (eth + 8)) = temp_4; - /* Update l2_len */ + /* Update l2 parameters */ vnet_buffer (b0)->l2.l2_len += (word) config->push_bytes - (word) config->pop_bytes; + vnet_buffer (b0)->l2_hdr_offset -= + (word) co...
nimble/ll: Improve scanner stop With this patch aux data cleaning and scheduler clean from aux_ptrs is done only when extended scanner was enabled.
@@ -1338,11 +1338,14 @@ ble_ll_scan_sm_stop(int chk_disable) scansm->restart_timer_needed = 0; #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV) + if (scansm->ext_scanning) { OS_ENTER_CRITICAL(sr); ble_ll_scan_clean_cur_aux_data(); OS_EXIT_CRITICAL(sr); ble_ll_sched_rmv_elem_type(BLE_LL_SCHED_TYPE_AUX_SCAN, ble_ll_scan_sched_...
doc/man3: remove a duplicate BIO_do_accept() call The SSL server example in BIO_f_ssl.pod contains two copies of the BIO_do_accept() call. Remove the second one.
@@ -241,12 +241,6 @@ a client and also echoes the request to standard output. exit(1); } - if (BIO_do_accept(acpt) <= 0) { - fprintf(stderr, "Error in connection\n"); - ERR_print_errors_fp(stderr); - exit(1); - } - /* We only want one connection so remove and free accept BIO */ sbio = BIO_pop(acpt); BIO_free_all(acpt);...
ikev2: fix copy-paste error when freeing memory Type: fix
@@ -318,7 +318,7 @@ ikev2_sa_free_all_vec (ikev2_sa_t * sa) vec_free (sa->r_id.data); vec_free (sa->i_auth.data); - if (sa->r_auth.key) + if (sa->i_auth.key) EVP_PKEY_free (sa->i_auth.key); vec_free (sa->r_auth.data); if (sa->r_auth.key)
hslua-classes: fix documentation of Exposable
@@ -12,7 +12,7 @@ Maintainer : Albert Krewinkel <tarleb+hslua@zeitkraut.de> Stability : beta Portability : FlexibleInstances, ForeignFunctionInterface, ScopedTypeVariables -Call haskell functions from Lua, and vice versa. +Call Haskell functions from Lua. -} module HsLua.Class.Exposable ( Exposable (..)
Use u3a_malloc in the jet.
memset(pub_y, 0, 64); memset(sec_y, 0, 64); - mes_y = malloc(mesm_w); + mes_y = u3a_malloc(mesm_w); u3r_bytes(0, mesm_w, mes_y, a); u3r_bytes(0, mess_w, sed_y, b); ed25519_create_keypair(pub_y, sec_y, sed_y); ed25519_sign(sig_y, mes_y, mesm_w, pub_y, sec_y); - free(mes_y); + u3a_free(mes_y); return u3i_bytes(64, sig_y)...
elem-to-react-json for collections
/? 309 -/+ collections +/+ collections, cram, elem-to-react-json /= gas /$ fuel:html /= jon /^ json ++ raw-to-json |= raw=raw-item:collections ^- json + =/ elm=manx elm:(static:cram (ream data.raw)) + =/ rec=json (elem-to-react-json elm) %- pairs:enjs:format - :~ [%data [%s data.raw]] + :~ [%data rec] [%meta (meta-to-j...
BUFR operator 206YYY not working. Debug assertions
@@ -640,12 +640,15 @@ static int expand(grib_accessor* a) if (aDescriptor1->F == 2 && aDescriptor1->X == 6) { Assert(aDescriptor1->type == BUFR_DESCRIPTOR_TYPE_OPERATOR); operator206yyy_width = aDescriptor1->Y; /* Store the width for the following descriptor */ + DebugAssert(operator206yyy_width > 0); } else if (operat...
setupRLimits: set to min of 1024 and rlim_max
@@ -88,7 +88,7 @@ static void setupRLimits(void) { LOG_E("RLIMIT_NOFILE max limit < 1024 (%u). Expect troubles!", (unsigned int)rlim.rlim_max); return; } - rlim.rlim_cur = 1024; // we don't need more and there is no easy and portable way to know the limit + rlim.rlim_cur = MIN(1024, rlim.rlim_max); // we don't need mor...
[mod_webdav] store webdav.opts as bitflags
@@ -315,16 +315,19 @@ typedef struct { #endif } sql_config; +enum { /* opts bitflags */ + MOD_WEBDAV_UNSAFE_PARTIAL_PUT_COMPAT = 0x1 +}; + typedef struct { unsigned short enabled; unsigned short is_readonly; unsigned short log_xml; - unsigned short deprecated_unsafe_partial_put_compat; + unsigned short opts; sql_config...
[bsp/stm32] fix the bug of uart that not define pwm10 and pwm11
@@ -581,6 +581,12 @@ static void pwm_get_channel(void) #ifdef BSP_USING_PWM9_CH4 stm32_pwm_obj[PWM9_INDEX].channel |= 1 << 3; #endif +#ifdef BSP_USING_PWM10_CH1 + stm32_pwm_obj[PWM10_INDEX].channel |= 1 << 0; +#endif +#ifdef BSP_USING_PWM11_CH1 + stm32_pwm_obj[PWM11_INDEX].channel |= 1 << 0; +#endif #ifdef BSP_USING_PW...
max change with editingFinished. And some debug output
@@ -330,7 +330,7 @@ QvisHistogramPlotWindow::CreateWindowContents() connect(minToggle, SIGNAL(toggled(bool)), this, SLOT(minToggled(bool))); minLineEdit = new QLineEdit(central); - connect(minLineEdit, SIGNAL(returnPressed()), + connect(minLineEdit, SIGNAL(editingFinished()), this, SLOT(minProcessText())); limitsLayout...
[persistence] added persistence configuration in engine conf file.
#max_map_size=50000 #max_btree_size=50000 +# +# Persistence configuration +# # use persistence (true or false, default: false) use_persistence=false + +# data file path +#data_path=<data_path> +# +# logs file path +#logs_path=<logs_path> +# +# asynchronous logging +#async_logging=true
network/netmgr: fix svace issue 637298 fix svace issue 637298
@@ -312,7 +312,7 @@ static inline void _free_ifaddrs(struct ifaddrs *addrs) free(ifa->ifa_netmask); } if (ifa->ifa_dstaddr) { - free(ifa->ifa_netmask); + free(ifa->ifa_dstaddr); } prev = ifa; ifa = prev->ifa_next;
Fix argument in SLASET call to zero S fixes in accordance with
* Matrix all zero. Return zero solution. * CALL SLASET( 'F', MAX( M, N ), NRHS, ZERO, ZERO, B, LDB ) - CALL SLASET( 'F', MINMN, 1, ZERO, ZERO, S, 1 ) + CALL SLASET( 'F', MINMN, 1, ZERO, ZERO, S, MINMN ) RANK = 0 GO TO 70 END IF
rms/pbspro: remove centos7.6 patch landed on latest version; revert changes to buildrequires for postgres
@@ -78,6 +78,8 @@ BuildRequires: libedit-devel BuildRequires: libical-devel BuildRequires: ncurses-devel BuildRequires: perl +BuildRequires: postgresql-devel >= 9.1 +BuildRequires: postgresql-contrib >= 9.1 BuildRequires: python-devel >= 2.6 BuildRequires: python-devel < 3.0 BuildRequires: tcl-devel @@ -92,15 +94,11 @@...
Changes to plugin build setup. Moved to single 'KA' directory.
@@ -193,7 +193,7 @@ set( # Block out Houdini plugins that would load Houdini's UI libraries. set( houdini_dso_exclude_pattern - "HOUDINI_DSO_EXCLUDE_PATTERN={ROP_OpenGL,COP2_GPULighting,COP2_GPUFog,COP2_GPUEnvironment,COP2_GPUZComposite,COP2_EnableGPU,SHOP_OGL,SOP_VDBUI,OBJ_ReLight,VEX_OpRender,VGC_H_ROP,ROP_PyPDG}*" +...
Work CD-CI Add missing task to commit changes in changelog. Improve conditions for changelog related tasks. Add succeed conditions to several tasks. ***NO_CI***
@@ -372,6 +372,7 @@ jobs: command: custom custom: tool arguments: install --tool-path . nbgv + condition: succeeded() displayName: Install NBGV tool - task: PowerShell@2 @@ -380,6 +381,7 @@ jobs: script: nbgv cloud -a -c errorActionPreference: 'silentlyContinue' failOnStderr: 'false' + condition: succeeded() displayNam...
Allow build on FreeBSD
#define socklen_t int #endif /* clang-format on */ -#else /* Linux */ +#else /* Linux, FreeBSD */ #include "getopt.h" #include <stdint.h> #include <sys/types.h> #include <unistd.h> +#ifndef SOL_IPV6 /* required on FreeBSD */ +#define SOL_IPV6 IPPROTO_IPV6 +#endif + #ifndef __USE_XOPEN2K #define __USE_XOPEN2K #endif
Find Augeas: Reformat file with `cmake-format`
+# ~~~ # Finds augeas and its libraries # Uses the same semantics as pkg_check_modules, i.e. LIBAUGEAS{_FOUND,_INCLUDE_DIR,_LIBRARIES} # # Author: Martin Briza <mbriza@redhat.com> # # Distributed under the BSD license. See COPYING-CMAKE-SCRIPTS for details. +# ~~~ include (LibFindMacros) -if (LIBAUGEAS_INCLUDE_DIR AND ...