message
stringlengths
6
474
diff
stringlengths
8
5.22k
yaviks: update fan setting Update Fan min rpm to 2500, max rpm to 4100, pwm frequency to 25KHz. BRANCH=none TEST=make sure fan work intended.
fans { compatible = "cros-ec,fans"; fan_0 { - pwms = <&pwm2 PWM_CHANNEL_2 PWM_KHZ(30) PWM_POLARITY_NORMAL>; + pwms = <&pwm2 PWM_CHANNEL_2 PWM_KHZ(25) PWM_POLARITY_NORMAL>; tach = <&tach1>; - rpm_min = <1500>; - rpm_start = <1500>; - rpm_max = <6500>; + rpm_min = <2500>; + rpm_start = <2500>; + rpm_max = <4100>; enable_...
simulator name update
@@ -56,6 +56,8 @@ For instance, to run one of the riscv-tools assembly tests. ./simulator-example-RocketConfig $RISCV/riscv64-unknown-elf/share/riscv-tests/isa/rv64ui-p-simple +.. Note:: in a VCS simulator, the simulator name will be ``simv-example-RocketConfig`` ``instead of simulator-example-RocketConfig``. + Alterna...
cleanup peerfile support code
#include "peerfile.h" +struct peer { + struct peer *next; + char* addr_str; +}; + // Next time to import peers from peer file static time_t peerfile_import_time = 0; // Next time to export peers to peer file static time_t peerfile_export_time = 0; -struct peer { - struct peer *next; - char* addr_str; -}; - -// A list o...
Switch back OPT_MCU_DA1469X to use linear buffers
// Linear buffer in case target MCU is not capable of handling a ring buffer FIFO e.g. no hardware buffer is available or driver is would need to be changed dramatically #if ( CFG_TUSB_MCU == OPT_MCU_MKL25ZXX || /* Intermediate software buffer required */ \ + CFG_TUSB_MCU == OPT_MCU_DA1469X || /* Intermediate software ...
Update Internal CI to Run for Internal PRs
@@ -27,7 +27,12 @@ stages: - stage: build_windows displayName: Build Windows dependsOn: [] - condition: startsWith(variables['Build.SourceBranch'], 'refs/heads/integration/') + condition: | + or + ( + startsWith(variables['Build.SourceBranch'], 'refs/pull'), + startsWith(variables['Build.SourceBranch'], 'refs/heads/int...
test-suite: update opencoarrays test: caf hard-codes paths and cannot be reliably used for impi when we don't control the installed version.
@@ -17,14 +17,23 @@ else AC_MSG_RESULT([no]) fi -# set compilers to use MPI toolchain -F77=caf -FC=caf +# set compilers to use MPI toolchain. +# note that the caf compiler wrapper hard-codes paths to MPI libraries and is +# not recommended for normal usage (instead, use modules and link in libs +# directly). if test "x...
Updated refresh check
@@ -1210,7 +1210,9 @@ static ACVP_RESULT inspect_http_code(ACVP_CTX *ctx, int code) { ACVP_RESULT result = ACVP_TRANSPORT_FAIL; /* Generic failure */ JSON_Value *root_value = NULL; const JSON_Object *obj = NULL; + const JSON_Array *arr = NULL; const char *err_str = NULL; + char *tmp_err_str = NULL; if (code == HTTP_OK)...
Fix test, username is required for GSSAPI
@@ -145,9 +145,10 @@ test_sasl_properties (void) mongoc_cyrus_t sasl; uri = mongoc_uri_new ( - "mongodb://host/?authMechanism=GSSAPI&" + "mongodb://user@host/?authMechanism=GSSAPI&" "authMechanismProperties=SERVICE_NAME:sn,CANONICALIZE_HOST_NAME:TrUe"); + BSON_ASSERT (uri); memset (&sasl, 0, sizeof sasl); _mongoc_sasl_...
Move extern "C" after includes
# define WIN32 #endif -#ifdef __cplusplus -extern "C" { -#endif - #include <stdlib.h> #if defined(_MSC_VER) && (_MSC_VER < 1800) /* MSVC < 2013 does not have inttypes.h because it is not C99 @@ -81,6 +77,10 @@ extern "C" { # define NGTCP2_ALIGN_AFTER(N) __attribute__((aligned(N))) #endif /* !WIN32 */ +#ifdef __cplusplu...
[mediaplanner] yolint: fix migrations.
@@ -196,11 +196,6 @@ migrations: - a.yandex-team.ru/mds/yarl/pkg/rest - a.yandex-team.ru/mds/yarl/pkg/xgrpc - a.yandex-team.ru/mds/yarl/pkg/xgrpc_test - - a.yandex-team.ru/mediaplanner/cmd/backend - - a.yandex-team.ru/mediaplanner/internal/domain - - a.yandex-team.ru/mediaplanner/internal/domain_test - - a.yandex-team....
test-suite: update opencoarrays test string for tests on head node
@@ -5,7 +5,7 @@ load ./common/test_helper_functions || exit 1 source ./common/functions || exit 1 -@test "[libs/OpenCoarrays] hello_multiverse binary runs on head node ($rm/$LMOD_FAMILY_COMPILER/$LMOD_FAMILY_MPI)" { +@test "[libs/OpenCoarrays] hello_multiverse binary runs on head node ($LMOD_FAMILY_COMPILER/$LMOD_FAMIL...
degrow append
@@ -118,7 +118,7 @@ clock tick; #X connect 14 0 9 0; #X restore 492 144 pd start; #X obj 227 146 cyclone/seq seq.mid; -#N canvas 913 241 401 256 inconsistencies 0; +#N canvas 410 267 401 256 inconsistencies 0; #X text 31 24 The [seq] object in cyclone has two extra messages that the original does not have: pause and co...
options/rtdl: actually run own constructors on aarch64 GNU Linux As noted in the comment here and in earlier commits, this is only because we are using an aarch64-linux-gnu toolchain, which thinks we're glibc.
@@ -165,6 +165,11 @@ extern "C" void *interpreterMain(uintptr_t *entry_stack) { const char *execfn = "(executable)"; #ifndef MLIBC_STATIC_BUILD + using ctor_fn = void(*)(void); + + ctor_fn *ldso_ctors = nullptr; + size_t num_ldso_ctors = 0; + auto ldso_base = getLdsoBase(); if(logStartup) { mlibc::infoLogger() << "ldso...
Fix interactive sessions open multiple times
@@ -406,7 +406,7 @@ Client::Client(struct ev_loop *loop, SSL_CTX *ssl_ctx) hs_crypto_ctx_{}, crypto_ctx_{}, sendbuf_{NGTCP2_MAX_PKTLEN_IPV4}, - last_stream_id_(0), + last_stream_id_(UINT64_MAX), nstreams_done_(0), version_(0), tls_alert_(0), @@ -1773,7 +1773,7 @@ int Client::on_extend_max_stream_id(uint64_t max_stream_...
[core] stricter check of HTTP/2 GOAWAY frame size
@@ -459,7 +459,10 @@ h2_recv_goaway (connection * const con, const uint8_t * const s, uint32_t len) { /*(s must be entire GOAWAY frame and len the frame length field)*/ /*assert(s[3] == H2_FTYPE_GOAWAY);*/ - UNUSED(len); + if (len < 8) { /*(GOAWAY frame length must be >= 8)*/ + h2_send_goaway_e(con, H2_E_FRAME_SIZE_ERR...
vat: fix static analysis warning Type: fix Ticket:
@@ -93,8 +93,9 @@ static_always_inline void vat_json_set_string_copy (vat_json_node_t * json, const u8 * str) { u8 *ns = NULL; - vec_validate (ns, strlen ((const char *) str)); - strcpy ((char *) ns, (const char *) str); + int len = strlen ((const char *) str); + vec_validate (ns, len); + strncpy ((char *) ns, (const c...
mambo: fix cpio/initramfs reservation We didn't init cpio_size in the no cpio case. Fixes:
@@ -189,6 +189,7 @@ mysim of addprop $xscom_node byte_array "compatible" $compat # Load any initramfs set cpio_start 0x80000000 set cpio_end $cpio_start +set cpio_size 0 if { [info exists env(SKIBOOT_INITRD)] } { set cpios [split $env(SKIBOOT_INITRD) ","]
OpenWsmanClient: restore accidentally dropped string Restore a string in the error message accidentally dropped in commit ("OpenWsmanClient: replace sprintf with stringstream") Fixes: ("OpenWsmanClient: replace sprintf with stringstream")
@@ -448,6 +448,7 @@ bool CheckWsmanResponse(WsManClient* cl, WsXmlDocH& doc) ws_xml_destroy_doc(doc); std::stringstream ss3; + ss3 << "A Soap Fault was received:" << std::endl; ss3 << "FaultCode: " << code_s << std::endl; ss3 << "FaultSubCode: " + subcode_s << std::endl; ss3 << "FaultReason: " + reason_s<< std::endl;
[fabric][tests]fix test case failed to run aitos-io#1353
@@ -307,7 +307,7 @@ START_TEST(test_004ParmsInit_0015TxSetArgs_Success_argsNull) time(&timesec); rtnVal = BoatHlfabricTxSetTimestamp(&tx_ptr, timesec, 0); ck_assert_int_eq(rtnVal, BOAT_SUCCESS); - rtnVal = BoatHlfabricTxSetArgs(&tx_ptr, NULL); + rtnVal = BoatHlfabricTxSetArgs(&tx_ptr, NULL, NULL); ck_assert_int_eq(rtnV...
Fix TI demo project main.c to perform device initialization before provisioning
@@ -136,6 +136,12 @@ void vApplicationDaemonTaskStartupHook( void ) // Emit some serial port debugging vTaskDelay( mainLOGGING_WIFI_STATUS_DELAY ); + + + + /* Initialize the AWS Libraries system. */ + if( SYSTEM_Init() == pdPASS ) + { /* A simple example to demonstrate key and certificate provisioning in * flash using ...
insignificant changes
@@ -45,6 +45,7 @@ static void chrysler_rx_hook(CAN_FIFOMailBox_TypeDef *to_push) { static int chrysler_tx_hook(CAN_FIFOMailBox_TypeDef *to_send) { + int addr = GET_ADDR(to_send); int tx = 1; // If camera is on bus 0, then nothing can be sent @@ -52,8 +53,6 @@ static int chrysler_tx_hook(CAN_FIFOMailBox_TypeDef *to_send...
Tweak ast.Struct field numbering
@@ -891,12 +891,12 @@ func NewConst(flags Flags, filename string, line uint32, name t.ID, xType *TypeE // implement. const MaxImplements = 63 -// Struct is "struct ID2(List0)" or "struct ID2?(List0)": +// Struct is "struct ID2?(List1)": // - FlagsPublic is "pub" vs "pri" // - FlagsClassy is "ID2" vs "ID2?" // - ID1: <0...
Better memfs
@@ -117,6 +117,8 @@ for directory in dirs: if buffer is not None: buffer.close() +assert fcount <= MAX_FCOUNT, fcount + while fcount < MAX_FCOUNT: opath = get_outfile_name(output_file_base, fcount) print("MEMFS: Generating output:", opath, "(empty)")
Make vspan respect clip rectangle Raycaster uses vspan to draw walls and sprites, and was paying the cost for walls drawn under the HUD. Clip Rect support in vspan allows it to gain a little extra performance by not drawing things you can't see. Don't set a clip Rect larger than the screen...
@@ -534,20 +534,19 @@ namespace blit { float v = uv.y; float vs = float(sc) / float(dc); - if (p.y < 0) { - dc += p.y; - v += (vs * float(-p.y)); - p.y = 0; + if (p.y < clip.y) { + dc += clip.y - p.y; + v += (vs * float(-(p.y - clip.y))); + p.y = clip.y; } if (dc <= 0) { return; } - int16_t max_y = std::min(p.y + dc, b...
wrong change is removed
@@ -928,7 +928,7 @@ int out_balances() xdag_traverse_all_blocks(&d, out_balances_callback); qsort(d.blocks, d.blocksCount, sizeof(struct xdag_field), out_sort_callback); - for(int i = 0; i < d.blocksCount; ++i) { + for(i = 0; i < d.blocksCount; ++i) { xdag_hash2address(d.blocks[i].data, address); printf("%s %20.9Lf\n",...
[examples] int for array
@@ -23,7 +23,7 @@ from siconos.kernel import LagrangianLinearTIDS, NewtonImpactNSL,\ LagrangianLinearTIR, Interaction, Model, MoreauJeanOSI,\ TimeDiscretisation, LCP, TimeStepping -from numpy import eye, empty +from numpy import eye, empty, float64, zeros t0 = 0 # start time T = 10 # end time @@ -101,12 +101,12 @@ boun...
add highlight section about copy-on-write to release notes
@@ -73,6 +73,13 @@ Take a look at the [new docs](../dev/mountpoints.md), if you need to know detail - Removed old global plugins code. _(Maximilian Irlinger @atmaxinger)_ - New backend logic, based on PR #2969 by @vLesk _(@kodebach)_ +### Copy-on-write of `libelektra-core` + +Thanks to _(Maximilian Irlinger @atmaxinger...
fix: Fixed Failure to make demo under CRYPTO_MBEDTLS issue
@@ -155,7 +155,7 @@ BSINT32 BoatPlatONBech32Encode(const BUINT8 *in, BUINT32 inlen, BUINT8 *out, con BUINT8 *base32Data; BUINT8 *expandHRPData; - BUINT32 base32OutLen = base32_encoded_length(inlen); + BUINT32 base32OutLen = (inlen / 5) * 8 + (inlen % 5 * 8 + 4) / 5; BUINT8 *bech32Chk; BUINT32 i;
use maximum txpower for cc2538 radio.
*---------------------------------------------------------------------------*/ /* Constants */ #define CC2538_RF_CCA_THRES_USER_GUIDE 0xF8 -#define CC2538_RF_TX_POWER_RECOMMENDED 0xD5 /* TODO: Check value */ +/** Tx Power register + dbm - value +{ 7, 0xFF }, +{ 5, 0xED }, +{ 3, 0xD5 }, +{ 1, 0xC5 }, +{ 0, 0xB6 }, +{ -1...
rtctime: change to lua_setfieldfor populating the table Looks good.
@@ -180,12 +180,9 @@ static int rtctime_dsleep_aligned (lua_State *L) } -static void add_table_item (lua_State *L, const char *key, int val) -{ - lua_pushstring (L, key); - lua_pushinteger (L, val); - lua_rawset (L, -3); -} +#define ADD_TABLE_ITEM(L, key, val) \ + lua_pushinteger (L, val); \ + lua_setfield (L, -2, key)...
magikarp: initial gpio initial board specific gpio.. BRANCH=none TEST=zmake build magikarp --clobber
gpios = <&gpiod 4 GPIO_OUTPUT_LOW>; enum-name = "GPIO_PACKET_MODE_EN"; }; + ccd_mode_odl { + gpios = <&gpioc 4 GPIO_INPUT>; + enum-name = "GPIO_CCD_MODE_ODL"; + }; }; /* <&gpioe 1 GPIO_INPUT>, /* ec_pen_chg_dis_odl */ <&gpioh 3 GPIO_ODR_HIGH>, - /* ccd_mode_odl */ - <&gpioc 4 GPIO_INPUT>, /* unnamed nc pins */ <&gpioa ...
OpenCoreDevProps: Make DeviceProperties protocol reinstallable
@@ -43,15 +43,15 @@ OcLoadDevPropsSupport ( CHAR16 *UnicodeProperty; EFI_DEVICE_PATH_PROTOCOL *DevicePath; - PropertyDatabase = OcDevicePathPropertyInstallProtocol (FALSE); + PropertyDatabase = OcDevicePathPropertyInstallProtocol (Config->DeviceProperties.ReinstallProtocol); if (PropertyDatabase == NULL) { DEBUG ((DEBU...
Cleand-up _CONF for ROUTES, NEIGHBOR and BUFFER_SIZE modified: platform/avr-rss2/contiki-conf.h
@@ -165,6 +165,16 @@ typedef unsigned short uip_stats_t; #define RDC_CONF_MCU_SLEEP 1 #if NETSTACK_CONF_WITH_IPV6 + +#ifndef NBR_TABLE_CONF_MAX_NEIGHBORS +#define NBR_TABLE_CONF_MAX_NEIGHBORS 20 +#endif +#ifndef UIP_CONF_MAX_ROUTES +#define UIP_CONF_MAX_ROUTES 20 +#endif +#ifndef UIP_CONF_BUFFER_SIZE +#define UIP_CONF_...
clean out I term calculation redundancy
@@ -143,26 +143,13 @@ float pid(int x) { } #endif + //SIMPSON_RULE_INTEGRAL if (!iwindup) { -#ifdef MIDPOINT_RULE_INTEGRAL - // trapezoidal rule instead of rectangular - ierror[x] = ierror[x] + (error[x] + lasterror[x]) * 0.5f * current_ki[x] * looptime; - lasterror[x] = error[x]; -#endif - -#ifdef RECTANGULAR_RULE_INT...
remove a piece of redundant comment introduced in since we blocked the first-arg mechanism on subcommands
@@ -120,10 +120,7 @@ typedef struct { * understand if the command can be executed. */ uint64_t allowed_commands[USER_COMMAND_BITS_COUNT/64]; /* allowed_firstargs is used by ACL rules to block access to a command unless a - * specific argv[1] is given (or argv[2] in case it is applied on a sub-command). - * For example,...
metadata: move check/unit
@@ -1068,6 +1068,13 @@ usedby/plugin= rgbcolor description= "check if value is a valid rgbcolor in hexformat will normalize all values to decimal rrggbbaa" +[check/unit] +type= empty +status = implemented +usedby/plugin= unit +description= "check if unit is a valid unit of memory + will normalize units of memory into b...
Fix code layout in crypto/store/loader_file.c satisfying check-format.pl -l
@@ -1316,10 +1316,10 @@ static int ends_with_dirsep(const char *uri) { if (*uri != '\0') uri += strlen(uri) - 1; -#if defined __VMS +#if defined(__VMS) if (*uri == ']' || *uri == '>' || *uri == ':') return 1; -#elif defined _WIN32 +#elif defined(_WIN32) if (*uri == '\\') return 1; #endif
add velocity constrain
@@ -80,15 +80,8 @@ void Turtlebot3Controller::getRCdata(float *get_cmd_vel) ang_z = ang_z; } - if (lin_x > max_lin_vel_) - { - lin_x = max_lin_vel_; - } - - if (ang_z > max_ang_vel_) - { - ang_z = max_ang_vel_; - } + lin_x = constrain(lin_x, (-1)*max_lin_vel_, max_lin_vel_); + ang_z = constrain(ang_z, (-1)*max_ang_vel_...
pbio/trajectory: Don't stretch zero-length trajectories. There's no point in doing so, and helps us avoid catching divisions by zero.
@@ -298,6 +298,11 @@ pbio_error_t pbio_trajectory_calc_time_new(pbio_trajectory_t *trj, int32_t t0, i void pbio_trajectory_stretch(pbio_trajectory_t *trj, int32_t t1, int32_t t2, int32_t t3) { + if (trj->t3 == trj->t0) { + // This is a stationary maneuver, so there's nothing to recompute. + return; + } + // This recomp...
add textcase package
@@ -33,7 +33,8 @@ tlmgr install \ stmaryrd \ amsmath \ latexmk \ - revtex + revtex \ + textcase # Keep no backups (not required, simply makes cache bigger) tlmgr option -- autobackup 0
spi: catch transfer errors with bkpt
@@ -612,6 +612,10 @@ static void handle_dma_rx_isr(spi_ports_t port) { const dma_stream_def_t *dma_rx = &dma_stream_defs[PORT.dma_rx]; const dma_stream_def_t *dma_tx = &dma_stream_defs[PORT.dma_tx]; + if (dma_is_flag_active_te(dma_tx->port, dma_tx->stream_index) || dma_is_flag_active_te(dma_rx->port, dma_rx->stream_ind...
fix ipc path check
@@ -297,7 +297,7 @@ oidc_error_t ipc_closeConnection(struct connection* con) { * @return @c OIDC_SUCCESS on success */ oidc_error_t ipc_closeAndUnlinkConnection(struct connection* con) { - if (con->server->sun_path != NULL) { + if (con->server->sun_path[0] != '\0') { logger(DEBUG, "Unlinking %s", con->server->sun_path)...
Add /d2ssa-cfg-sink- workaround for MSVC NEON
@@ -204,6 +204,12 @@ macro(astcenc_set_properties NAME) ASTCENC_F16C=0) endif() + # Workaround MSVC codegen bug for NEON builds see: + # https://developercommunity.visualstudio.com/t/inlining-turns-constant-into-register-operand-for/1394798 + target_compile_options(${NAME} + PRIVATE + $<$<CXX_COMPILER_ID:MSVC>:/d2ssa-c...
Make UBSan happy
@@ -36,7 +36,7 @@ kiwi_read32(uint32_t *out, char **pos, uint32_t *size) if (kiwi_unlikely(*size < sizeof(uint32_t))) return -1; unsigned char *ptr = (unsigned char*)*pos; - *out = ptr[0] << 24 | ptr[1] << 16 | + *out = ((uint32_t)ptr[0]) << 24 | ptr[1] << 16 | ptr[2] << 8 | ptr[3]; *size -= sizeof(uint32_t); *pos += s...
decisions: added from discussions
@@ -20,15 +20,38 @@ It was found unexpected that this assert will fail. ### Fewer Keys When doing a second `kdbGet` with a new keyset no keys might be returned, because kdb internally is up-to-date. -Pseudo code example, assuming there is a key `/somewhere/key`: +A unit test by @atmaxinger: ``` -kdbGet (kdb, ks1, keyNe...
Use NX86::HaveRDTSCP() in GetCycleCount() for x86, too.
@@ -68,9 +68,16 @@ Y_FORCE_INLINE ui64 GetCycleCount() noexcept { return ((unsigned long long)lo) | (((unsigned long long)hi) << 32); #elif defined(_i386_) + extern const bool HaveRdtscp; + ui64 x; + if (HaveRdtscp) { __asm__ volatile("rdtscp\n\t" : "=A"(x)::"%ecx"); + } else { + __asm__ volatile("rdtsc\n\t" + : "=A"(x...
fix typo sents -> sends
@@ -633,7 +633,7 @@ memcache developers. General-purpose statistics -------------------------- -Upon receiving the "stats" command without arguments, the server sents +Upon receiving the "stats" command without arguments, the server sends a number of lines which look like this: STAT <name> <value>\r\n
Fix token version check
@@ -83,7 +83,7 @@ PH_TOKEN_ATTRIBUTES PhGetOwnTokenAttributes( BOOLEAN elevated = TRUE; TOKEN_ELEVATION_TYPE elevationType = TokenElevationTypeFull; - if (WindowsVersion >= WINDOWS_8) + if (WindowsVersion >= WINDOWS_8_1) { attributes.TokenHandle = NtCurrentProcessToken(); }
User: Improved UserReadFile error-checking
@@ -65,15 +65,33 @@ UserReadFile ( return NULL; } - fseek (FilePtr, 0, SEEK_END); + if (fseek (FilePtr, 0, SEEK_END) != 0) { + fclose (FilePtr); + return NULL; + } + FileSize = ftell (FilePtr); - fseek (FilePtr, 0, SEEK_SET); + if (FileSize <= 0) { + fclose (FilePtr); + return NULL; + } + + if (fseek (FilePtr, 0, SEEK_...
Documentation updates;
@@ -114,9 +114,6 @@ the command: LD_PRELOAD='/usr/$LIB/libstdc++.so.6 /usr/$LIB/libgcc_s.so.1' ~/.steam/steam/ubuntu12_32/steam-runtime/run.sh lovr ``` -Currently, there are performance issues between SteamVR and OpenGL apps. These are being rapidly -resolved with newer versions of graphics drivers and SteamVR. - WebVR...
Assure msc device block size is not zero
@@ -187,6 +187,11 @@ uint8_t rdwr10_validate_cmd(msc_cbw_t const* cbw) TU_LOG(MSC_DEBUG, " SCSI case 4 Hi > Dn\r\n"); status = MSC_CSW_STATUS_FAILED; } + else if ( SCSI_CMD_READ_10 == cbw->command[0] && cbw->total_bytes / block_count == 0) + { + TU_LOG(MSC_DEBUG, " Computed block size 0\r\n"); + status = MSC_CSW_STATUS...
Rename arguements in get_common_dims. Add comments
@@ -2017,6 +2017,9 @@ int get_min_vertex_from_lp_sol(int scc1, int scc2, PlutoProg *prog, return min; } +/* Returns the list of vertices of the FCG corresponding the dimensions of the + * current scc that can possibly be coloured. Discarded list is the vertices of + * the current scc that are chosen to be not suitable ...
fix release notes formatting
@@ -98,7 +98,7 @@ The text below summarizes updates to the [C (and C++)-based libraries](https://w - Added else error to core for elektraGetCheckUpdateNeeded _(Aydan Ghazani @4ydan)_ - Fix check for valid namespace in keyname creation _(@JakobWonisch)_ -- + ### <<Library1>> - <<TODO>>
mruby Android toolchain
@@ -242,6 +242,8 @@ if(MSVC) set(MRUBY_TOOLCHAIN visualcpp) elseif(APPLE OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang") set(MRUBY_TOOLCHAIN clang) +elseif(ANDROID) + set(MRUBY_TOOLCHAIN android) else() set(MRUBY_TOOLCHAIN gcc) endif()
GRIB2: Local def 60. Remove centuryOfAnalysis
@@ -10,7 +10,7 @@ unsigned[1] minuteOfAnalysis = 0 : dump; constant secondsOfAnalysis = 0; -meta dateOfAnalysis g2date(centuryOfAnalysis,yearOfAnalysis,monthOfAnalysis,dayOfAnalysis) : dump; +meta dateOfAnalysis g2date(yearOfAnalysis,monthOfAnalysis,dayOfAnalysis) : dump; meta timeOfAnalysis time(hourOfAnalysis,minuteO...
Update xpass highlight in build/plugins/_test_const.py.
@@ -312,7 +312,7 @@ class _StatusColorMap(object): 'timeout': Highlight.BAD, 'flaky': Highlight.ALTERNATIVE3, 'xfail': Highlight.WARNING, - 'xpass': Highlight.BAD, + 'xpass': Highlight.WARNING, 'diff': Highlight.BAD, 'internal': Highlight.BAD, 'deselected': Highlight.UNIMPORTANT,
build: simplify helper cmds
@@ -2,42 +2,35 @@ srcs-to-objs = \ $(patsubst $(1)/%.c,$(2)/%.o,$(filter %.c,$($(3)-srcs))) \ $(patsubst $(1)/%.s,$(2)/%.o,$(filter %.s,$($(3)-srcs))) -ifeq ($(Q),@) -quiet = quiet_ -endif +cmd = $(if $(Q),@ echo "$(msg_$(1))";) $(cmd_$(1)) -cmd = @$(if $($(quiet)cmd_$(1)), \ - echo '$($(quiet)cmd_$(1))' &&) $(cmd_$(1)...
Make net/connect special Keeps net/listen from being affected by changes necessary to make bind on connect work (while keeping from breaking the API).
@@ -248,9 +248,7 @@ JANET_NO_RETURN static void janet_sched_accept(JanetStream *stream, JanetFunctio /* Adress info */ static int janet_get_sockettype(Janet *argv, int32_t argc, int32_t n) { - JanetKeyword stype = NULL; - if(janet_checktype(argv[n], JANET_KEYWORD)) - stype = janet_optkeyword(argv, argc, n, NULL); + Jan...
Test with tasty
@@ -193,9 +193,9 @@ test-suite err_prop hs-source-dirs: prelude other-modules: Prelude -test-suite test +test-suite test-hslua type: exitcode-stdio-1.0 - main-is: Spec.hs + main-is: test-hslua.hs hs-source-dirs: test ghc-options: -Wall -threaded if flag(lua501) || flag(luajit) @@ -208,17 +208,17 @@ test-suite test othe...
jenkins: add default value to cmemcheck
@@ -1021,7 +1021,7 @@ def ctest(target = "Test") { /* Helper for ctest to run MemCheck without memleak tagged tests * @param kdbtests If true run tests tagged as kdbtests */ -def cmemcheck(kdbtests) { +def cmemcheck(kdbtests=true) { if(kdbtests) { ctest("MemCheck -LE memleak") } else {
OcAppleKernelLib: Add segment VM protection adaption.
@@ -27,6 +27,9 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include "PrelinkedInternal.h" +#define TEXT_SEG_PROT (MACH_SEGMENT_VM_PROT_READ | MACH_SEGMENT_VM_PROT_EXECUTE) +#define DATA_SEG_PROT (MACH_SEGMENT_VM_PROT_READ | MACH_SEGMENT_VM_PROT_WRITE) + // // Symbols // @@ -1446,6 +...
remade makefile dependencies. (note the make depend just done).
- Fix #4126: RTT_band too low on VSAT links with 600+ms latency, adds the option unknown-server-time-limit to unbound.conf that can be increased to avoid the problem. + - remade makefile dependencies. 24 October 2018: Ralph - Add markdel function to ECS slabhash.
Add option to declare unittests with custom entry points for libraries with global finalizers
@@ -732,6 +732,10 @@ module YT_UNITTEST: UNITTEST_BASE { PEERDIR(mapreduce/yt/library/utlib) } +module UNITTEST_WITH_CUSTOM_ENTRY_POINT: UNITTEST_BASE { + .NODE_TYPE=Program +} + USE_AFL=no ### @usage: FUZZ ()
py/modbuiltins: Slightly simplify code in builtin round().
@@ -457,16 +457,14 @@ STATIC mp_obj_t mp_builtin_round(size_t n_args, const mp_obj_t *args) { return o_in; } #if MICROPY_PY_BUILTINS_FLOAT - mp_int_t num_dig = 0; - if (n_args > 1) { - num_dig = mp_obj_get_int(args[1]); mp_float_t val = mp_obj_get_float(o_in); + if (n_args > 1) { + mp_int_t num_dig = mp_obj_get_int(arg...
mpi-families/mpich: remove application of 8a12577691979dbe3d9281b4c59e38558ab3e777.patch which is included in v3.3.1 release of MPICH
@@ -37,8 +37,7 @@ Group: %{PROJ_NAME}/mpi-families URL: http://www.mpich.org Source0: http://www.mpich.org/static/downloads/%{version}/%{pname}-%{version}.tar.gz Patch0: config.pmix.patch -Patch1: 8a12577691979dbe3d9281b4c59e38558ab3e777.patch -Patch2: node.name.fix.patch +Patch1: node.name.fix.patch # 08/14/19 karl@ic...
Update when getDuration is called per review comment.
@@ -1776,8 +1776,6 @@ reportFD(int fd, enum control_type_t source) static void doRead(int fd, uint64_t initialTime, int success, ssize_t bytes, const char* func) { - uint64_t duration = getDuration(initialTime); - struct fs_info_t *fs = getFSEntry(fd); struct net_info_t *net = getNetEntry(fd); @@ -1788,6 +1786,7 @@ doR...
All extern consts should be global.
@@ -181,7 +181,9 @@ forcelocal(Simp *s, Node *n) static void declarelocal(Simp *s, Node *n) { - if (isconstfn(n)) + if (n->type == Nexpr) + n = decls[n->decl.did]; + if (n->decl.isconst && n->decl.isextern) htput(s->globls, n, asmname(n)); else if (stacknode(n)) forcelocal(s, n);
Install smitools snmp snmp-mibs-downloader Needed for `tests/08-native-runs`
@@ -8,6 +8,7 @@ sudo apt install -y --no-install-recommends \ build-essential doxygen git wget unzip python-serial rlwrap npm \ default-jdk ant srecord python-pip iputils-tracepath uncrustify \ mosquitto mosquitto-clients valgrind \ + smitools snmp snmp-mibs-downloader \ python-magic linux-image-extra-virtual openjdk-8...
Refactor server_start() error handling This avoids cleanup duplication.
@@ -345,32 +345,33 @@ server_start(struct server *server, const char *serial, } if (!push_server(serial)) { - SDL_free(server->serial); - return false; + goto error1; } if (!enable_tunnel_any_port(server, params->port_range)) { - SDL_free(server->serial); - return false; + goto error1; } // server will connect to our s...
ci: enable automatic testing on armv7m7-imxrt117x JIRA:
@@ -118,7 +118,7 @@ jobs: runner_result: ${{ steps.runner.outcome }} strategy: matrix: - target: ['armv7m7-imxrt106x'] + target: ['armv7m7-imxrt106x', 'armv7m7-imxrt117x'] steps: - name: Checkout phoenix-rtos-project
Make next_func_idx an unsigned integer. This prevents an integer overflow that bypasses this check:
@@ -999,7 +999,7 @@ struct YR_STRING_SET_ITERATOR struct YR_ITERATOR { // Index of the next function within the iter_next_func_table global array. - int next_func_idx; + uint8_t next_func_idx; union {
Fix integer overflows with large resolutions Limits video size so that the number of luma and chroma pixels can be stored in an int. Fixes some integer overflows that resulted in segmentation faults.
#include "cfg.h" +#include <limits.h> #include <stdio.h> #include <stdlib.h> #include <string.h> @@ -1176,6 +1177,21 @@ int kvz_config_validate(const kvz_config *const cfg) error = 1; } + if (cfg->width > 0 && cfg->height > 0) { + // We must be able to store the total number of luma and chroma pixels + // in an int32_t...
Enable ECJPAKE in test_crypto_full_no_md () & test_psa_crypto_config_accel_hash_use_psa () components
@@ -1208,7 +1208,6 @@ component_test_crypto_full_no_md () { scripts/config.py crypto_full scripts/config.py unset MBEDTLS_MD_C # Direct dependencies - scripts/config.py unset MBEDTLS_ECJPAKE_C scripts/config.py unset MBEDTLS_HKDF_C scripts/config.py unset MBEDTLS_HMAC_DRBG_C scripts/config.py unset MBEDTLS_PKCS5_C @@ -...
Upgrade to Valhalla 3.1.4
@@ -198,8 +198,8 @@ static const char valhalla_default_config[] = R"({ "max_time_contour": 120 }, "max_alternates": 2, - "max_avoid_locations": 50, - "max_avoid_polygons_length": 10000, + "max_exclude_locations": 50, + "max_exclude_polygons_length": 10000, "max_radius": 200, "max_reachability": 100, "max_timedep_distan...
tests: internal: input_chunk: adjust to new chunkio api
@@ -370,8 +370,8 @@ static int gen_buf(msgpack_sbuffer *mp_sbuf, char *buf, size_t buf_size) return 0; } -static int log_cb(struct cio_ctx *ctx, int level, const char *file, int line, - char *str) +static void log_cb(void *data, int level, const char *file, int line, + const char *str) { if (level == CIO_LOG_ERROR) { f...
Added details to oicmgr.rst
@@ -117,14 +117,13 @@ Yes </table> -| The newtmgr application tool uses CoAP (Constrained Application - Protocol) requests to send commands to oicmgr. -| It sends a CoAP request for **/omgr** as follows: +The newtmgr application tool uses CoAP (Constrained ApplicationProtocol) requests to send commands to oicmgr. +It s...
sr: fixing typo in srv6 End.AS Proxy documentation Type: docs
@@ -73,7 +73,7 @@ restores the segment list ``<S1, S2, S3>`` with a source address `SRC-ADDR` on the packets coming back on interface `IFACE-IN`. ``` -sr localsid address SID behavior end.ad nh S-ADDR oif IFACE-OUT iif IFACE-IN src SRC-ADDR next S1 next S2 next S3 +sr localsid address SID behavior end.as nh S-ADDR oif ...
pyocf: Add missing volume open parameter
@@ -42,7 +42,7 @@ class VolumeOps(Structure): SUBMIT_METADATA = CFUNCTYPE(None, c_void_p) SUBMIT_DISCARD = CFUNCTYPE(None, c_void_p) SUBMIT_WRITE_ZEROES = CFUNCTYPE(None, c_void_p) - OPEN = CFUNCTYPE(c_int, c_void_p) + OPEN = CFUNCTYPE(c_int, c_void_p, c_void_p) CLOSE = CFUNCTYPE(None, c_void_p) GET_MAX_IO_SIZE = CFUNC...
iOS: fix invalid thread for network activity indicator using
@@ -53,7 +53,17 @@ typedef enum { void rho_net_impl_network_indicator(int active) { - [UIApplication sharedApplication].networkActivityIndicatorVisible = active ? YES : NO; + if (active) { + dispatch_async(dispatch_get_main_queue(), ^{ + [UIApplication sharedApplication].networkActivityIndicatorVisible = YES; + }); + }...
Comment Match.__str__ and use format() to simplify calculation
@@ -77,15 +77,16 @@ class Match(): # pylint: disable=too-few-public-methods self.name = name def __str__(self): - ln_str = str(self.pos[0]) - gutter_len = max(4, len(ln_str)) - gutter = (gutter_len - len(ln_str)) * " " + ln_str + """ + Return a formatted code listing representation of the erroneous line. + """ + gutter...
[io] output_contact_info only for bullet backend
@@ -2183,8 +2183,11 @@ class MechanicsHdf5Runner(siconos.io.mechanics_hdf5.MechanicsHdf5): if self._output_contact_forces: self.log(self.output_contact_forces, with_timer)() - if self._output_contact_info: + if self._output_contact_info and backend == 'bullet': self.log(self.output_contact_info, with_timer)() + else: +...
actions: try to use Java 16 and set PATH, JAVA_HOME
@@ -64,6 +64,9 @@ jobs: brew postinstall dbus brew services restart dbus cmake -E make_directory ${{runner.workspace}}/build + export JAVA_HOME=$(/usr/libexec/java_home -v 16) + echo "JAVA_HOME=$JAVA_HOME" >> $GITHUB_ENV + echo "$JAVA_HOME/bin" >> $GITHUB_PATH - name: Configure CMake # Use a bash shell so we can use th...
[p2p] Fix panic (nil pointer reference)
@@ -322,6 +322,9 @@ func (p *BlockProtocol) onGetBlockHeadersResponse(s inet.Stream) { func (p *BlockProtocol) NotifyNewBlock(newBlock message.NotifyNewBlock) bool { // create message data for _, neighbor := range p.ps.GetPeers() { + if neighbor == nil { + continue + } req := &types.NewBlockNotice{MessageData: &types.M...
Add handle check for PhGetHandleInformation
@@ -1409,7 +1409,7 @@ NTSTATUS PhGetHandleInformationEx( PPH_STRING objectName = NULL; PPH_STRING bestObjectName = NULL; - if (Handle == NULL || Handle == NtCurrentProcess() || Handle == NtCurrentThread()) + if (ProcessHandle == NULL || Handle == NULL || Handle == NtCurrentProcess() || Handle == NtCurrentThread()) retu...
[Kernel] Fix the critical issue when scheduler not start
@@ -884,15 +884,18 @@ void rt_exit_critical(void) level = rt_hw_interrupt_disable(); rt_scheduler_lock_nest --; - if (rt_scheduler_lock_nest <= 0) { rt_scheduler_lock_nest = 0; /* enable interrupt */ rt_hw_interrupt_enable(level); + if (rt_current_thread) + { + /* if scheduler is started, do a schedule */ rt_schedule()...
Testing: speed up grib1 test
@@ -34,14 +34,14 @@ localDefinitions=`find ${def_dir}/grib1/ -name 'local.98.*def' | sed -e 's:.*/:: for l1 in $localDefinitions do - ${tools_dir}/grib_set -s localDefinitionNumber=$l1 $temp locx.grib1 - ${tools_dir}/grib_filter $$_f locx.grib1 + ${tools_dir}/grib_set -M -s localDefinitionNumber=$l1 $temp locx.grib1 + ...
Corrected a statement and some grammer for the CRC32 driver readme
@@ -4,5 +4,5 @@ This driver supports all STM32 series. The low level driver code is taken or heavily inspired in the STCube MX HAL drivers from STMicroelectronics. The ChibiOS driver follows the 'standard' template driver model. -**NOTE:** unlike all the other drivers and because all SMT32 chips (until now) have a CRC ...
Fix typo in translation.
"MENU_COPY_SCENE": "Copia Scena", "MENU_PASTE_SCENE": "Incolla Scena", "MENU_DELETE_SCENE": "Elimina Scena", - "MENU_CHECK_FOR_UPDATES": "Controlla Aggiornamnti...", + "MENU_CHECK_FOR_UPDATES": "Controlla Aggiornamenti...", "MENU_PLUGINS": "Plugins", "// 11": "Warnings --------------------------------------------------...
Fix documented error codes
@@ -179,7 +179,7 @@ psa_status_t mbedtls_psa_aead_decrypt( * \retval #PSA_SUCCESS * Success. * \retval #PSA_ERROR_INVALID_ARGUMENT - * \p key is not compatible with \p alg. + * An invalid block length was supplied. * \retval #PSA_ERROR_NOT_SUPPORTED * \p alg is not supported. * \retval #PSA_ERROR_INSUFFICIENT_MEMORY @@...
baseboard/kalista/usb_pd_pdo.c: Format with clang-format BRANCH=none TEST=none
#include "usb_pd.h" #include "usb_pd_pdo.h" -#define PDO_FIXED_FLAGS (PDO_FIXED_UNCONSTRAINED | \ - PDO_FIXED_DATA_SWAP | \ - PDO_FIXED_COMM_CAP) +#define PDO_FIXED_FLAGS \ + (PDO_FIXED_UNCONSTRAINED | PDO_FIXED_DATA_SWAP | PDO_FIXED_COMM_CAP) const uint32_t pd_src_pdo[] = { PDO_FIXED(5000, 3000, PDO_FIXED_FLAGS),
Fixed multiple openssl packages detection.
@@ -100,7 +100,7 @@ ifdef IS_MACOS ifeq ($(CRYPTO_ENGINE_PATH),openssl) # if brew is installed, if openssl is installed - PACKAGELIST = $(shell brew list | grep 'openssl') + PACKAGELIST = $(shell brew list | grep -om1 '^openssl') ifeq ($(PACKAGELIST),openssl) # path to openssl (usually "/usr/local/opt/openssl")
resize set: fix units for floating containers This commit fixes the default size units for floating containers, so that pixels are used if the units are not specified.
@@ -512,34 +512,38 @@ static struct cmd_results *resize_set_floating(struct sway_container *con, calculate_constraints(&min_width, &max_width, &min_height, &max_height); if (width->amount) { - if (width->unit == RESIZE_UNIT_PPT || - width->unit == RESIZE_UNIT_DEFAULT) { + switch (width->unit) { + case RESIZE_UNIT_PPT: ...
HV: add empty else statement for if condition in vlapic.c To meeting MISRA, add empty else {} for corresponding if-else-if {}. Also, remove a DD flow violation in vlapic_free() Acked-by: Eddie Dong
@@ -1211,6 +1211,8 @@ vlapic_process_init_sipi(struct acrn_vcpu* target_vcpu, uint32_t mode, schedule_vcpu(target_vcpu); } } + } else { + /* No other state currently, do nothing */ } return; } @@ -1452,8 +1454,7 @@ vlapic_svr_write_handler(struct acrn_vlapic *vlapic) } static int32_t -vlapic_read(struct acrn_vlapic *vl...
Update WindowsDesktopNetworkInformationImpl.cpp Stop using InternetGetConnectedState. This API is deprecated and may not operate properly.
@@ -55,6 +55,7 @@ namespace PAL_NS_BEGIN { virtual NetworkType GetNetworkType() override { m_type = NetworkType_Unknown; +#if 0 // TODO: implement more robust network type detection logic DWORD flags; DWORD reserved = 0; if (::InternetGetConnectedState(&flags, reserved)) { @@ -68,6 +69,7 @@ namespace PAL_NS_BEGIN { bre...
usb_serial_jtag: add support for esp32c6
@@ -229,7 +229,7 @@ menu "ESP System Settings" config ESP_CONSOLE_USB_SERIAL_JTAG bool "USB Serial/JTAG Controller" select ESPTOOLPY_NO_STUB if IDF_TARGET_ESP32C3 #ESPTOOL-252 - depends on IDF_TARGET_ESP32C3 || IDF_TARGET_ESP32S3 + depends on SOC_USB_SERIAL_JTAG_SUPPORTED config ESP_CONSOLE_UART_CUSTOM bool "Custom UAR...
A working but not super great solution for passing a char ** to library functions
@@ -122,9 +122,21 @@ bool run_command(CNCWrapper * wrapper, void ** handle, lib_function func) freopen("/dev/null", "a", stdout); setbuf(stdout, wrapper->response_packet->output); + //This block is not good. This is generating a Char** from a Char[][] + //After discussion today it seems all parsing should move to the c...
mintingtablemodel fix segfault
@@ -111,10 +111,6 @@ public: std::map<uint256, CWalletTx>::iterator mi = wallet->mapWallet.find(hash); bool inWallet = mi != wallet->mapWallet.end(); - CWalletTx& tx = mi->second; - if (tx.GetCredit(ISMINE_SPENDABLE) + tx.GetDebit(ISMINE_SPENDABLE) == (int64_t)0) - inWallet = false; - // Find bounds of this transaction...
Fix local engine path in gb-studio-cli
@@ -142,7 +142,7 @@ const main = async ( const getEngineFields = async (projectRoot: string) => { const defaultEngineJsonPath = Path.join(engineRoot, "gb", "engine.json"); const localEngineJsonPath = Path.join( - Path.dirname(projectRoot), + projectRoot, "assets", "engine", "engine.json"
Remove uninstall of python in metacall environment for windows.
@@ -76,12 +76,6 @@ function sub-python { (New-Object Net.WebClient).DownloadFile("https://www.python.org/ftp/python/$PythonVersion/python-$PythonVersion-amd64.exe", "$(pwd)\python_installer.exe") # Install Python - where.exe /Q python - if ( $? -eq $True ) { - echo 'Replacing existing Python...' - ./python_installer.ex...
Implement assign statement
@@ -393,7 +393,19 @@ generate_stat = function(stat) error("not implemented yet") elseif tag == ast.Stat.Assign then - error("not implemented yet") + local var_cstats, var_clvalue = generate_var(stat.var) + local exp_cstats, exp_cvalue = generate_exp(stat.exp) + return util.render([[ + ${VAR_STATS} + ${EXP_STATS} + ${LV...