message
stringlengths
6
474
diff
stringlengths
8
5.22k
apps/btshell: Add missing returns in L2CAP connect/disconnect Fix missing error returns.
@@ -135,6 +135,7 @@ cmd_l2cap_connect(int argc, char **argv) conn = parse_arg_uint16("conn", &rc); if (rc != 0) { console_printf("invalid 'conn' parameter\n"); + return rc; } psm = parse_arg_uint16("psm", &rc); @@ -165,12 +166,13 @@ cmd_l2cap_disconnect(int argc, char **argv) conn = parse_arg_uint16("conn", &rc); if (r...
Reject type refinements unless of numeric types
@@ -556,6 +556,12 @@ func (p *parser) parseTypeExpr() (*a.TypeExpr, error) { if err != nil { return nil, err } + if name.IsNumType() && + ((pkg == t.IDBase) || ((pkg == 0) && p.opts.AllowBuiltInNames)) { + // No-op. + } else { + return nil, fmt.Errorf(`parse: cannot refine non-numeric type at %s:%d`, p.filename, p.line...
mesh/adv.c: free os_mbuf in bt_mesh_adv_create_from_pool before return call of os_mbuf_free_chain was unreachable
@@ -232,8 +232,8 @@ struct os_mbuf *bt_mesh_adv_create_from_pool(struct os_mbuf_pool *pool, adv->ref_cnt = 1; ble_npl_event_set_arg(&adv->ev, buf); - return buf; os_mbuf_free_chain(buf); + return buf; } struct os_mbuf *bt_mesh_adv_create(enum bt_mesh_adv_type type, uint8_t xmit,
Fix missing linefeed and param debug.
@@ -31,12 +31,15 @@ struct StorageDriverS3FileRead /*********************************************************************************************************************************** Create a new file **********************************************************************************************************************...
BugID:24381709:fix the buf of time struct
@@ -42,7 +42,7 @@ typedef struct { uint8_t weekday; /**< DEC format:value range from 1 to 7, BCD format:value range from 0x01 to 0x07 */ uint8_t date; /**< DEC format:value range from 1 to 31, BCD format:value range from 0x01 to 0x31 */ uint8_t month; /**< DEC format:value range from 1 to 12, BCD format:value range fro...
Retire Piledriver/Steamroller/Excavator daxpy microkernels as well related to issue
@@ -33,15 +33,16 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. #include "daxpy_microk_nehalem-2.c" #elif defined(BULLDOZER) #include "daxpy_microk_bulldozer-2.c" +/* +these appear to be broken, see issue 1332 #elif defined(STEAMROLLER) || defined(EXCAVATOR) #include "daxpy_microk_steamroll...
Set Android FAKEID Reset Android build cache polluted by
"c_compiler": "$(CLANG)/bin/clang", "cxx_compiler": "$(CLANG)/bin/clang++", "werror_mode": "compiler_specific", - "gcc_version": "6.0" + "gcc_version": "6.0", + "target_opt": [ + "-DANDROID_FAKEID=6667994" + ] } }, "clang6-android-x86_64": { "c_compiler": "$(CLANG)/bin/clang", "cxx_compiler": "$(CLANG)/bin/clang++", "w...
tests/mt_waitset: increase the number of thread pointers having 96 cores x 10 threads should be possible to hold all thread pointers for
const static char *service_name = "mt_waitset_service"; coreid_t my_core_id, num_cores; -struct thread *threads[256]; +struct thread *threads[1024]; static int server_threads = 10; static int client_threads = 1; static int iteration_count = 1000; static int client_counter = 0; -static int64_t server_calls[256]; -static...
Removed slashes to prevent installing at root
@@ -130,9 +130,9 @@ set_property(GLOBAL PROPERTY USE_FOLDERS ON) set(SURVIVE_BUILT_PLUGINS) if(WIN32) - SET(LIB_INSTALL_DIR "" CACHE STRING bin/${CMAKE_GENERATOR_PLATFORM}) + SET(LIB_INSTALL_DIR "" CACHE STRING bin/${CMAKE_GENERATOR_PLATFORM}/) else() - SET(LIB_INSTALL_DIR "" CACHE STRING lib) + SET(LIB_INSTALL_DIR "" ...
Remove firmware concerns from hardware-test
@@ -121,31 +121,6 @@ void render(uint32_t time) { (float)((sin(blit::now() / 100.0f) + 1) / 2.0f) ); - if (dpad_u) { - blit::backlight += 1.0f / 256.0f; - } - if (dpad_d) { - blit::backlight -= 1.0f / 256.0f; - } - blit::backlight = std::fmin(1.0f, std::fmax(0.0f, blit::backlight)); - - if (dpad_r) { - blit::volume += ...
add client hello msg test
@@ -1322,6 +1322,11 @@ if [ -n "${OPENSSL_LEGACY:-}" ]; then O_LEGACY_CLI="$O_LEGACY_CLI -connect localhost:+SRV_PORT" fi +if [ -n "${OPENSSL_NEXT:-}" ]; then + O_NEXT_SRV="$O_NEXT_SRV -accept $SRV_PORT" + O_NEXT_CLI="$O_NEXT_CLI -connect localhost:+SRV_PORT" +fi + if [ -n "${GNUTLS_NEXT_SERV:-}" ]; then G_NEXT_SRV="$G...
Update trunk/arcadia/catboost/pytest/gpu_test_notes.md
-Test were canonized on TeslaK40 +Tests were canonized on TeslaK40 Result could be different on other GPUs -Test should be run in single thread, otherwise could be OOM exception (CatBoost allocates all GPU ram on the start) +Test should be run in single thread, otherwise there could be OOM exception (CatBoost allocates...
[arch][riscv] more interrupt cause debugging strings
#define LOCAL_TRACE 0 static const char *cause_to_string(long cause) { + if (cause >= 0) { switch (cause) { case RISCV_EXCEPTION_IADDR_MISALIGN: return "Instruction address misaligned"; @@ -46,7 +47,30 @@ static const char *cause_to_string(long cause) { case RISCV_EXCEPTION_STORE_PAGE_FAULT: return "Store/AMO page faul...
Reflect name change of lapacke_mangling.h template
@@ -2119,6 +2119,6 @@ foreach (Utils_FILE ${Utils_SRC}) endforeach () set(lapacke_include_dir "${NETLIB_LAPACK_DIR}/LAPACKE/include") -execute_process(COMMAND ${CMAKE_COMMAND} -E copy "${lapacke_include_dir}/lapacke_mangling_with_flags.h" "${lapacke_include_dir}/lapacke_mangling.h") +execute_process(COMMAND ${CMAKE_COM...
Updated docs to add Wavehsare OpenH743I-C to STM32 boards list.
@@ -170,6 +170,7 @@ This code base already had supported for a handful of following boards (sorted a - [STM32 H743zi Nucleo](https://www.st.com/en/evaluation-tools/nucleo-h743zi.html) - [STM32 H743i Evaluation](https://www.st.com/en/evaluation-tools/stm32h743i-eval.html) - [STM32 H745i Discovery](https://www.st.com/en/...
babblesim: Print script errors to stderr
@@ -22,7 +22,7 @@ if [ -z ${BSIM_COMPONENTS_PATH+x} ]; then echo "This board requires the BabbleSim simulator. Please set" \ "the environment variable BSIM_COMPONENTS_PATH to point to its components" \ "folder. More information can be found in" \ - "https://babblesim.github.io/folder_structure_and_env.html" + "https://...
fs/mount: fix logging macro in FS automount
@@ -167,7 +167,7 @@ static void automount_notify(FAR struct automounter_state_s *priv) ret = nxmutex_lock(&priv->lock); if (ret < 0) { - ierr("ERROR: nxmutex_lock failed: %d\n", ret); + ferr("ERROR: nxmutex_lock failed: %d\n", ret); return; } @@ -207,7 +207,7 @@ static int automount_open(FAR struct file *filep) ret = n...
Add circular dependency detection. This detection will not stop compilation, as errors in general do not stop compilation unless exit on error is passed inside an import, but should notify the user something is going on.
[ext loader] (defn- find-prefix [pre] - (or (find-index |(string/has-prefix? pre ($ 0)) module/paths) 0)) + (or (find-index |(and (string? ($ 0)) (string/has-prefix? pre ($ 0))) module/paths) 0)) (array/insert module/paths 0 [(string ":cur:/:all:" ext) loader check-.]) (def all-index (find-prefix ":all:")) (array/inser...
meson_options: fix bool options
@@ -14,7 +14,7 @@ option('with_wayland', type : 'feature', value : 'disabled') option('with_dbus', type : 'feature', value : 'enabled') option('with_dlsym', type : 'feature', value : 'disabled') option('loglevel', type: 'combo', choices : ['trace', 'debug', 'info', 'warn', 'err', 'critical', 'off'], value : 'info', des...
Enables newt resigned images This removes use of key-id when looking for a sign key and tries to validate images using every available key in the bootloader, adding compatibility with "newt resign-image" command which accepts whatever key-id was supplied by the user.
@@ -101,6 +101,7 @@ bootutil_img_validate(struct image_header *hdr, const struct flash_area *fap, MYNEWT_VAL(BOOTUTIL_SIGN_EC256) uint32_t sig_off = 0; uint32_t sig_len = 0; + int i; #endif struct image_tlv tlv; uint8_t buf[256]; @@ -208,10 +209,12 @@ bootutil_img_validate(struct image_header *hdr, const struct flash_a...
Add smarter mouse tracking enable/disable
@@ -1003,11 +1003,22 @@ void app_jump_cursor_to(App_state* a, Usz y, Usz x) { void app_mouse_event(App_state* a, Usz y, Usz x, mmask_t mouse_bstate) { if (mouse_bstate & BUTTON1_RELEASED) { - app_jump_cursor_to(a, y, x); + // hard-disables tracking, but also disables further mouse stuff. + // mousemask() with our origi...
Added i18n configuration dialog labels.
#define FIND_HEAD \ _("Find pattern in all views") +/* Config Dialog */ +#define CONFDLG_HEAD \ + _("Log Format Configuration") +#define CONFDLG_KEY_HINTS \ + _("[SPACE] to toggle - [ENTER] to proceed - [q] to quit") +#define CONFDLG_LOG_FORMAT \ + _("Log Format - [c] to add/edit format") +#define CONFDLG_DATE_FORMAT \...
Minor bug in CMake NodeJS scripts.
# # Check if this loader is enabled -if(NOT OPTION_BUILD_SCRIPTS OR NOT OPTION_BUILD_SCRIPTS_JS) +if(NOT OPTION_BUILD_SCRIPTS OR NOT OPTION_BUILD_SCRIPTS_NODE) return() endif()
fixed transparent windows also having tranparent borders with dwm-fixborders patch
@@ -204,6 +204,8 @@ drw_clr_create(Drw *drw, Clr *dest, const char *clrname) DefaultColormap(drw->dpy, drw->screen), clrname, dest)) die("error, cannot allocate color '%s'", clrname); + + dest->pixel |= 0xff << 24; } /* Wrapper to create color schemes. The caller has to call free(3) on the
Document GPDB 5x client compatibility with Informatica and GPDB 6x
@@ -308,6 +308,8 @@ These Greenplum Database extensions are installed with Greenplum Database - Progress DataDirect ODBC Drivers v7.1.6+7.16.389 - The Progress DataDirect ODBC drivers enable third party applications to connect via a common interface to the Tanzu Greenplum system. - R2B X-LOG v5.x and v6.x - Real-time d...
Correct memory unit ExecChooseHashTableSize takes KB as parameter while global_work_mem returns bytes
@@ -2782,7 +2782,7 @@ initial_cost_hashjoin(PlannerInfo *root, JoinCostWorkspace *workspace, ExecChooseHashTableSize(inner_path_rows, inner_path->parent->width, true, /* useskew */ - global_work_mem(root), + global_work_mem(root) / 1024L, &numbuckets, &numbatches, &num_skew_mcvs); @@ -4691,7 +4691,7 @@ Cost incremental...
Fix minor issues in clib_spinlock_unlock()
@@ -71,12 +71,14 @@ clib_spinlock_lock_if_init (clib_spinlock_t * p) static_always_inline void clib_spinlock_unlock (clib_spinlock_t * p) { - (*p)->lock = 0; #if CLIB_DEBUG > 0 (*p)->frame_address = 0; (*p)->pid = 0; (*p)->thread_index = 0; #endif + /* Make sure all writes are complete before releasing the lock */ + CL...
VERSION bump to version 1.3.18
@@ -27,7 +27,7 @@ endif() # micro version is changed with a set of small changes or bugfixes anywhere in the project. set(SYSREPO_MAJOR_VERSION 1) set(SYSREPO_MINOR_VERSION 3) -set(SYSREPO_MICRO_VERSION 17) +set(SYSREPO_MICRO_VERSION 18) set(SYSREPO_VERSION ${SYSREPO_MAJOR_VERSION}.${SYSREPO_MINOR_VERSION}.${SYSREPO_MI...
remove argument shortcuts makes it easier to parse by console autocompleting script
@@ -139,13 +139,12 @@ const char *kadnode_usage_str = "KadNode - A P2P name resolution daemon.\n" " --service-install KadNode will be started/shut down along with Windows\n" " --service-remove or on request by using the Service Control Manager.\n\n" #endif -" -h, --help Print this help.\n\n" -" -v, --version Print prog...
doc: add license as given by in
@@ -26,3 +26,21 @@ LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +# Files ...
Windows version no longer high cpu while animating
@@ -137,6 +137,8 @@ void SceneInit_b2() actors[i].frames_len = 0; actors[i].frames_len = ReadBankedUBYTE(bank_ptr.bank, scene_load_ptr + 2); actors[i].animate = FALSE; + actors[i].frame_offset = 0; + actors[i].flip = FALSE; actors[i].animate = ReadBankedUBYTE(bank_ptr.bank, scene_load_ptr + 3); actors[i].frame = 0; act...
Added baudrate restriction on uartbb.
@@ -28,4 +28,5 @@ syscfg.defs: value: -1 syscfg.restrictions: - - (UARTBB_0_PIN_TX >= 0 && UARTBB_0_PIN_RX >= 0) + - UARTBB_0_PIN_TX >= 0 && UARTBB_0_PIN_RX >= 0 + - CONSOLE_UART_BAUD <= 19200
aligned signed/unsigned in metrics type
typedef struct pubsub_admin_sender_msg_type_metrics { long bndId; char typeFqn[PUBSUB_AMDIN_METRICS_NAME_MAX]; - int typeId; - long nrOfMessagesSend; - long nrOfMessagesSendFailed; - long nrOfSerializationErrors; + unsigned int typeId; + unsigned long nrOfMessagesSend; + unsigned long nrOfMessagesSendFailed; + unsigned...
[vote] Fix refund time limit calculation
@@ -35,14 +35,18 @@ func executeVoteTx(txBody *types.TxBody, senderState *types.State, return err } } else if voteCmd == 'r' { //unstaking, revert - voting, blockNo, err := getVote(scs, txBody.Account, txBody.Recipient) - if blockNo < limitDuration { //TODO : fix it proper + voting, blockNo, err := getVote(scs, txBody....
When loading sensors from database keep null values in config
@@ -791,6 +791,11 @@ void Sensor::jsonToConfig(const QString &json) if (map.contains(QLatin1String(key))) { + QVariant val = map[key]; + if (val.isNull()) + { + continue; + } item->setValue(map[key]); item->setTimeStamps(dt); }
Replace parsing with outputting
Bugfix - * Fix string representation of DNs when parsing values containing commas, - conforming to RFC 1779. Fixes #769. + * Fix string representation of DNs when outputting values containing commas + and other special characters, conforming to RFC 1779. Fixes #769.
[GB] Run multiple system steps per window event loop
@@ -288,8 +288,10 @@ fn main() { match event { Event::MainEventsCleared => { + for i in 0..128 { gameboy.step(); } + } _ => {} } });
Prevent a missing `on_data` from re-firing the event.
@@ -169,6 +169,11 @@ static void mock_on_ev(intptr_t uuid, protocol_s *protocol) { (void)protocol; } +static void mock_on_data(intptr_t uuid, protocol_s *protocol) { + facil_quite(uuid); + (void)protocol; +} + static void mock_on_close(intptr_t uuid, protocol_s *protocol) { (void)(protocol); (void)(uuid); @@ -1967,7 +1...
Cast void pointers C++ compilers will warn otherwise
@@ -149,8 +149,8 @@ void * lv_memcpy(void * dst, const void * src, size_t len); */ static inline void * lv_memcpy_small(void * dst, const void * src, size_t len) { - uint8_t * d8 = dst; - const uint8_t * s8 = src; + uint8_t * d8 = (uint8_t *)dst; + const uint8_t * s8 = (const uint8_t *)src; while(len) { *d8 = *s8; d8++...
One more try...!
<PropertyGroup Label="UserMacros" /> <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'"> <LinkIncremental>true</LinkIncremental> + <IncludePath>$(VC_IncludePath);$(WindowsSDK_IncludePath);$(ProjectDir)</IncludePath> </PropertyGroup> <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|...
common/fpsensor/fpsensor_crypto.c: Format with clang-format BRANCH=none TEST=./util/compare_build.sh -b fp
@@ -55,8 +55,8 @@ static void hkdf_extract(uint8_t *prk, const uint8_t *salt, size_t salt_size, } static int hkdf_expand_one_step(uint8_t *out_key, size_t out_key_size, - uint8_t *prk, size_t prk_size, - uint8_t *info, size_t info_size) + uint8_t *prk, size_t prk_size, uint8_t *info, + size_t info_size) { uint8_t key_b...
Add isDefined() native function, that returns true if an object is defined, or false otherwise.
@@ -212,6 +212,26 @@ static Value assertNative(VM *vm, int argCount, Value *args) { return NIL_VAL; } +static Value isDefinedNative(VM *vm, int argCount, Value *args) { + if (argCount != 1) { + runtimeError(vm, "isDefined() takes 1 argument (%d given).", argCount); + return EMPTY_VAL; + } + + if (!IS_STRING(args[0])) {...
fix-kdb-complete-heap-overflow: avoid potential overflow when string not found
@@ -354,7 +354,11 @@ bool CompleteCommand::filterCascading (string const & argument, pair<Key, pair<i { // For a cascading key completion, ignore the preceding namespace const string test = current.first.getFullName (); - const int cascadationOffset = test.find ("/"); + int cascadationOffset = test.find ("/"); + if (ca...
Travis: Reformat CMake command
@@ -71,8 +71,17 @@ before_script: ln -s /usr/local/opt/openssl/include/openssl/ /usr/local/include/openssl; fi - > - cmake -GNinja -DBUILD_STATIC=OFF -DPLUGINS="${plugins:-ALL}" -DBINDINGS=ALL -DTOOLS=ALL -DINSTALL_SYSTEM_FILES=OFF - -DCMAKE_INSTALL_PREFIX=$TRAVIS_BUILD_DIR/../install -DKDB_DB_SYSTEM=$TRAVIS_BUILD_DIR/...
[ci skip] Update smartelf2hex to use MemSiz instead of FileSiz elf2hex writes zeros to a segment for which MemSize > FileSize, which adheres to the ELF spec. Thus, we should calculate the total size of the file from the MemSize of the last segment, rather than the FileSize.
@@ -8,7 +8,7 @@ binary=$1 segments=`readelf --segments --wide $binary` entry_hex=`echo -e "$segments" | grep "Entry point" | cut -f3 -d' ' | sed 's/0x//' | tr [:lower:] [:upper:]` entry_dec=`bc <<< "ibase=16;$entry_hex"` -length_hex=`echo "$segments" | grep "LOAD\|TLS" | tail -n 1 | tr -s [:space:] | cut -f4,6 -d' '` +...
examples/png: include sanitizer/msan_interface.h
@@ -16,7 +16,11 @@ extern "C" { #include "pngpriv.h" #include "pngstruct.h" -void __msan_poison(const volatile void *a, size_t size); +#if defined(__clang__) +#if __has_feature(memory_sanitizer) +#include <sanitizer/msan_interface.h> +#endif /* __has_feature(memory_sanitizer) */ +#endif /* defined(__clang__) */ void fa...
optimize get numa node for single node systems
@@ -1046,9 +1046,10 @@ int _mi_os_numa_node_count(void) { int _mi_os_numa_node(mi_os_tld_t* tld) { UNUSED(tld); - int numa_node = mi_os_numa_nodex(); - // never more than the node count and >= 0 int numa_count = _mi_os_numa_node_count(); + if (numa_count<=1) return 0; // optimize on single numa node systems: always nod...
Remove heap memory area
@@ -8,8 +8,12 @@ CFLAGS += \ -DCPU_MKL25Z128VLK4 \ -DCFG_TUSB_MCU=OPT_MCU_MKL25ZXX +LDFLAGS += \ + -Wl,--defsym,__stack_size__=0x400 \ + -Wl,--defsym,__heap_size__=0 + # mcu driver cause following warnings -CFLAGS += -Wno-error=unused-parameter +CFLAGS += -Wno-error=unused-parameter -Wno-error=format MCU_DIR = $(SDK_DI...
test BUGFIX segfault prevention in utests.h
@@ -162,8 +162,10 @@ struct utest_context { { \ char *test_1; \ char *test_2; \ - lyd_print_mem(&test_1, NODE_1, LYD_XML, LYD_PRINT_WITHSIBLINGS | LYD_PRINT_SHRINK); \ - lyd_print_mem(&test_2, NODE_2, LYD_XML, LYD_PRINT_WITHSIBLINGS | LYD_PRINT_SHRINK); \ + assert_int_equal(LY_SUCCESS, lyd_print_mem(&test_1, NODE_1, LY...
nimble/ll: Do LL task sanity check on HCI Reset This allows to catch LL task stack overflows easily.
@@ -1363,6 +1363,20 @@ ble_ll_mbuf_init(struct os_mbuf *m, uint8_t pdulen, uint8_t hdr) ble_hdr->txinfo.hdr_byte = hdr; } +static void +ble_ll_validate_task(void) +{ +#ifdef MYNEWT +#ifndef NDEBUG + struct os_task_info oti; + + os_task_info_get(&g_ble_ll_task, &oti); + + BLE_LL_ASSERT(oti.oti_stkusage < oti.oti_stksize...
driver: als_bh1730: Set last_value |last_value| was never set, so sensor would send same data and never send measurement of 0 lux. BRANCH=many TEST=compile Fixes: ("motion: Add bh1730 as a motion sensor")
@@ -80,11 +80,13 @@ static int bh1730_read_lux(const struct motion_sensor_t *s, intv3_t v) * Return an error when nothing change to prevent filling the * fifo with useless data. */ - if (v[0] == drv_data->last_value) + if (v[0] == drv_data->last_value) { return EC_ERROR_UNCHANGED; - else + } else { + drv_data->last_val...
touch uuid when writing
@@ -2733,6 +2733,7 @@ ssize_t fio_write2_fn(intptr_t uuid, fio_write_args_s options) { fio_unlock(&uuid_data(uuid).sock_lock); if (was_empty) { + uuid_data(uuid).active = fio_data->last_cycle.tv_sec; fio_defer_push_urgent(deferred_on_ready, (void *)uuid, NULL); } return 0;
Add doc for future tests in node reentrancy.
@@ -47,6 +47,14 @@ TEST_F(metacall_node_reentrant_test, DefaultConstructor) "metacall_load_from_memory('node', 'module.exports = { node_memory: () => 4 };');\n" "console.log('Reentrant node_memory result:', metacall('node_memory'));\n"; + /* TODO: This generates a stack overflow in NodeJS land. We should make a better ...
Fix NaN return from mat4 unpacking The caluclated angle is forced to PI if cos(angle) falls outside the [-1, +1] range due to floating point precision error.
#include <string.h> #include <math.h> +#include <float.h> #include "util.h" #pragma once @@ -534,7 +535,12 @@ MAF void mat4_getAngleAxis(mat4 m, float* angle, float* ax, float* ay, float* az diagonal[1] /= sy; diagonal[2] /= sz; vec3_normalize(axis); - *angle = acosf((diagonal[0] + diagonal[1] + diagonal[2] - 1.f) / 2....
Fix tracker field when pasting between patterns Tracker active field is lost on pattern change but pasting will either use last selection origin or 0, Also fixes bug where active channel was not set to 0 on first position
@@ -144,7 +144,7 @@ export const SongTracker = ({ ); useEffect(() => { - if (activeField) { + if (activeField !== undefined) { const newChannelId = Math.floor( (activeField % ROW_SIZE) / CHANNEL_FIELDS ); @@ -598,13 +598,17 @@ export const SongTracker = ({ const onPaste = useCallback(() => { if (pattern) { + const temp...
mdns: fix wrong PTR record count
@@ -1094,6 +1094,7 @@ static uint8_t _mdns_append_service_ptr_answers(uint8_t *packet, uint16_t *index service->proto, flush, bye) <= 0) { return appended_answers; } + appended_answers++; mdns_subtype_t *subtype = service->subtype; while (subtype) {
GlobalShellExecutor checks the whole output as the termination condition GlobalShellExecutor checks `o.endswith(GlobalShellExecutor.BASH_PS1)` before, there is a possibility that the current `o` only has several ending characters of the `GlobalShellExecutor.BASH_PS1`, in that case it never terminates but times out. Thi...
@@ -82,7 +82,7 @@ class ConnectionInfo(object): class GlobalShellExecutor(object): - BASH_PS1 = 'test_sh$>' + BASH_PS1 = 'GlobalShellExecutor>' class ExecutionError(Exception): "" @@ -98,6 +98,7 @@ class GlobalShellExecutor(object): stdin=self.slave_fd, stdout=self.slave_fd, stderr=self.slave_fd, + start_new_session=Tr...
Fix incorrect type passed to va_arg. The type should be size_t, not yr_arena_off_t.
@@ -81,7 +81,9 @@ static int _yr_arena_make_ptr_relocatable( int result = ERROR_SUCCESS; - offset = (yr_arena_off_t) va_arg(offsets, yr_arena_off_t); + // The argument to va_arg is size_t because the offsets passed to this + // function are obtained with offsetof(). + offset = (yr_arena_off_t) va_arg(offsets, size_t); ...
Fix android test case for minVSversion
local p = premake local suite = test.declare("test_android_project") local vc2010 = p.vstudio.vc2010 + local android = p.modules.android -- vc2010.clCompile(cfg) end + local function preparePropertyGroup() + system "android" + local cfg = test.getconfig(prj, "Debug", platform) + vc2010.propertyGroup(cfg) + android.andr...
debug: Display PKN for Packet Number like Wireshark for short header Forget with PR
@@ -175,7 +175,7 @@ void print_pkt_long(ngtcp2_dir dir, const ngtcp2_pkt_hd *hd) { namespace { void print_pkt_short(ngtcp2_dir dir, const ngtcp2_pkt_hd *hd) { - fprintf(outfile, "%s%s%s CID=%016lx PN=%lu\n", pkt_ansi_esc(dir), + fprintf(outfile, "%s%s%s CID=%016lx PKN=%lu\n", pkt_ansi_esc(dir), strpkttype_short(hd->typ...
[swig] ignore SiconosVector iterator types
%ignore operator<<(std::ostream& os, const SiconosVector& bv); %ignore operator<<(std::ostream& os, const BlockVector& bv); %ignore operator std::vector<double>(); -%ignore SiconosVectorIteratorType::operator=(const SiconosVectorIteratorType& it); -%ignore SiconosVectorIteratorType::operator++(); -%ignore SiconosVector...
Use state change for setting `config/ledindication`
@@ -808,12 +808,24 @@ int DeRestPluginPrivate::changeSensorConfig(const ApiRequest &req, ApiResponse & updated = true; } else if (rid.suffix == RConfigLedIndication) // Boolean + { + if (!devManaged) { pendingMask |= R_PENDING_LEDINDICATION; sensor->enableRead(WRITE_LEDINDICATION); sensor->setNextReadTime(WRITE_LEDINDI...
[CLI] Ask password twice when create new account
package cmd import ( + "bytes" "context" + "errors" "fmt" "os" "syscall" - "golang.org/x/crypto/ssh/terminal" - "github.com/aergoio/aergo/account/key" "github.com/aergoio/aergo/types" "github.com/spf13/cobra" + "golang.org/x/crypto/ssh/terminal" ) func init() { @@ -72,7 +73,7 @@ var newCmd = &cobra.Command{ if pw != ""...
chip/stm32/usb_hid.c: Format with clang-format BRANCH=none TEST=none
@@ -41,10 +41,8 @@ void hid_reset(int ep, usb_uint *hid_ep_tx_buf, int tx_len, for (i = 0; i < DIV_ROUND_UP(tx_len, 2); i++) hid_ep_tx_buf[i] = 0; - ep_reg = (ep << 0) /* Endpoint Address */ | - EP_TX_VALID | - (3 << 9) /* interrupt EP */ | - EP_RX_DISAB; + ep_reg = (ep << 0) /* Endpoint Address */ | EP_TX_VALID | + (3...
Patch configure.ac file to take the new contrib/unbound_nochroot.service unit file in consideration. All props to Wouter Wijngaards for this work.
@@ -2047,6 +2047,6 @@ dnl if this is a distro tarball, that was already done by makedist.sh AC_SUBST(version, [VERSION_MAJOR.VERSION_MINOR.VERSION_MICRO]) AC_SUBST(date, [`date +'%b %e, %Y'`]) -AC_CONFIG_FILES([Makefile doc/example.conf doc/libunbound.3 doc/unbound.8 doc/unbound-anchor.8 doc/unbound-checkconf.8 doc/unb...
docs(CONTRIBUTING): remove part that doesn't apply
@@ -30,7 +30,7 @@ When you write new functionality or fix bugs, it is important that you don't fid ### Patch Against Recent Source -Please try to get the latest available sources to make your patches against. It makes the lives of the developers so much easier. The very best is if you get the most up-to-date sources fr...
Patch the `libscope.so` in `scope service`
@@ -119,6 +119,16 @@ func installScope(serviceName string, unameMachine string, unameSysname string, util.CheckErrSprintf(err, "error: failed to extract library; %v", err) } + // patch the library + asset, err := run.Asset("build/ldscope") + util.CheckErrSprintf(err, "error: failed to find ldscope asset; %v", err) + lo...
image tweak
<img align="right" src="/OpenEXR/doc/images/windowExample1.png"> +# OpenEXR + The OpenEXR project provides the specification and reference implementation of the EXR file format, the professional-grade image storage format of the motion picture industry. The purpose of format
Improve docs for -d. As mentioned in this commit brings the docs up to date with the man page and usage statement. Fixes
@@ -57,9 +57,9 @@ Available options are: Print only number of matches. -.. option:: -d <identifier>=<value> +.. option:: -d <identifier>=<value> --define=identifier=value - Define external variable. + Define external variable. This option can be used multiple times. .. option:: --fail-on-warnings
Fix job option defaults.
@@ -204,7 +204,7 @@ papplJobGetPrintOptions( if ((attr = ippFindAttribute(job->attrs, "print-content-optimize", IPP_TAG_KEYWORD)) != NULL) options->print_content_optimize = _papplContentValue(ippGetString(attr, 0, NULL)); else - options->print_content_optimize = PAPPL_CONTENT_AUTO; + options->print_content_optimize = p...
misc/obs: add test-suite for 1.3.8
@@ -63,7 +63,7 @@ mpi_families=["openmpi3","mpich","mvapich2","impi"] standalone = ["charliecloud","clustershell","cmake","docs","easybuild","lmod", - "meta-packages","papi","slurm","valgrind"] + "meta-packages","papi","slurm","test-suite","valgrind"] # define (compiler dependent) packages compiler_dependent = ["hdf5",...
Fix run dialog 'file not found' error
@@ -2228,7 +2228,7 @@ NTSTATUS PhpRunFileProgram( { status = PhpCustomShellExecute( Context->WindowHandle, - fullFileName->Buffer, + PhGetString(fullFileName), PhGetString(argumentsString), TRUE ); @@ -2392,8 +2392,8 @@ NTSTATUS PhpRunFileProgram( { status = PhpCustomShellExecute( Context->WindowHandle, - commandString...
clear EIE INTIE instead of non-existent EIR INTIE
@@ -728,7 +728,7 @@ loop_start: continue; // -> just continue to check again } // the host controller should clear the global enable bit for the interrupt pin before servicing the interrupt - MAC_CHECK_NO_RET(enc28j60_do_bitwise_clr(emac, ENC28J60_EIR, EIE_INTIE) == ESP_OK, + MAC_CHECK_NO_RET(enc28j60_do_bitwise_clr(em...
gibbed says he is a big dum dum
@@ -32,7 +32,7 @@ std::string CName::ToString() const noexcept const auto resolved = internal.ToString(); if (!resolved) return fmt::format("ToCName{{ hash_lo = 0x{0:08X}, hash_hi = 0x{1:08X} }}", hash_lo, hash_hi); - return fmt::format("ToCName{{ hash_lo = 0x{0:08X}, hash_hi = 0x{1:08X} --['{2}']-- }}", hash_lo, hash_...
update deinit name
@@ -11,14 +11,14 @@ scripts_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" # ignore riscv-tools for submodule init recursive # you must do this globally (otherwise riscv-tools deep # in the submodule tree will get pulled anyway -git config --global submodule.riscv-tools.update none +git config ...
parallel-libs/boost: bump to v1.75.0
%define pname boost Summary: Boost free peer-reviewed portable C++ source libraries Name: %{pname}-%{compiler_family}-%{mpi_family}%{PROJ_DELIM} -Version: 1.73.0 +Version: 1.75.0 -%define version_exp 1_73_0 +%define version_exp 1_75_0 Release: 1%{?dist} License: BSL-1.0
external/webclient: Modify WGET return value There is an intermittent case where recv is called one more time after receiving all files. In this case, returning 0 from the recv function is not an error. If all data is received, the return value is changed to WGET_OK.
@@ -1048,8 +1048,14 @@ retry: goto errout; } else if (len == 0) { ndbg("Finish read\n"); + if (mlen.message_len - mlen.sentence_start == mlen.content_len) { + ndbg("download completed successfully\n"); + break; + } else { + ndbg("Error: Receive Fail\n"); goto errout; } + } usleep(1); read_finish = http_parse_message(pa...
doccomment for h2olog.h
#include <bcc/BPF.h> typedef struct st_h2o_tracer_t { + /* + * Where to output the results. Defaults to `stdout`. + */ std::FILE *out; + + /* + * The number of events emitted in `handle_event`. + */ std::size_t count; /*
Change the order of key_exchange determine
@@ -775,20 +775,13 @@ static int ssl_tls13_determine_key_exchange_mode( mbedtls_ssl_context *ssl ) * The PSK-based key exchanges may additionally be used with 0-RTT. * * Our built-in order of preference is - * 1 ) Plain PSK Mode ( psk ) - * 2 ) (EC)DHE-PSK Mode ( psk_ephemeral ) - * 3 ) Certificate Mode ( ephemeral ) +...
original_version can be a reserved version
@@ -989,7 +989,6 @@ static int conn_new(ngtcp2_conn **pconn, const ngtcp2_cid *dcid, assert(callbacks->delete_crypto_cipher_ctx); assert(callbacks->get_path_challenge_data); assert(!server || !ngtcp2_is_reserved_version(client_chosen_version)); - assert(!ngtcp2_is_reserved_version(settings->original_version)); if (mem ...
doc: add explanation about ACRN modes and scenarios Add more explanations about the various ACRN modes of operation and how they are used to construct more complex scenarios.
@@ -37,7 +37,7 @@ ACRN High-Level Architecture The ACRN architecture has evolved since its initial v0.1 release in July 2018. Beginning with the v1.1 release, the ACRN architecture has -flexibility to support partition mode, sharing mode, and a mixed hybrid +flexibility to support *logical partitioning*, *sharing*, and...
Remove author from man pages
@@ -192,7 +192,6 @@ man-local: $(man3_MANS) # Compile the man page document .md.3: $(AM_V_GEN) @PANDOC@ -s -f markdown_github -t man $< -o $@ \ - -M author="Martin Sustrik" \ -M header="libdill Library Functions" \ -M footer="libdill" \ -M title="`echo "$(patsubst %.md,%,$<)(3)" | tr 'a-z' 'A-Z'`"
Remove unnecessary state variables.
@@ -103,23 +103,14 @@ typedef struct st_picoquic_prague_state_t { // double alpha; uint64_t alpha_shifted; uint64_t alpha; - uint64_t acked_bytes_ecn; - uint64_t acked_bytes_total; - uint64_t loss_cwnd; uint64_t residual_ack; uint64_t ssthresh; uint64_t recovery_start; - uint64_t min_rtt; - uint64_t last_rtt[NB_RTT_REN...
Update FreeBSD cirrus CI test to 12.2
@@ -51,9 +51,9 @@ ubuntu_1804_clang10: &ubuntu_1804_clang10 - apt-get install -y autoconf automake make clang-${CLANG_VERSION} libc-dev libevent-dev libssl-dev flex bison - update-alternatives --install /usr/bin/clang clang /usr/bin/clang-${CLANG_VERSION} 10 -freebsd_12_1: &freebsd_12_1 +freebsd_12_2: &freebsd_12_2 fre...
stdio: add __printflike() to ANSI C functions
@@ -248,12 +248,14 @@ int fgetc(FILE *); int fgetpos(FILE * __restrict, fpos_t * __restrict); char *fgets(char * __restrict, int, FILE * __restrict); FILE *fopen(const char * __restrict, const char * __restrict); -int fprintf(FILE * __restrict, const char * __restrict, ...); +int fprintf(FILE * __restrict, const char *...
Die on bad options, and use a \n in the format string.
@@ -26,7 +26,7 @@ const sbfmt = {sb, ap, opts | ("t", ""): fmt = Timefmt | ("D", ""): fmt = Datetimefmt | ("f", opt): fmt = opt - | _: std.fatal("unknown option") + | _: std.die("unknown option\n") ;; ;; datefmt(sb, fmt, d)
Core: Remove useless test
@@ -2135,7 +2135,7 @@ __STATIC_FORCEINLINE int32_t __QSUB( int32_t op1, int32_t op2) return(result); } -#if 1 + #define __PKHBT(ARG1,ARG2,ARG3) \ ({ \ uint32_t __RES, __ARG1 = (ARG1), __ARG2 = (ARG2); \ @@ -2152,13 +2152,7 @@ __STATIC_FORCEINLINE int32_t __QSUB( int32_t op1, int32_t op2) __ASM ("pkhtb %0, %1, %2, asr %...
include/usb_pd_tcpc.h: Format with clang-format BRANCH=none TEST=none
#ifdef TCPCI_I2C_PERIPHERAL /* Convert TCPC address to type-C port number */ -#define TCPC_ADDR_TO_PORT(addr) ((addr) \ - - I2C_STRIP_FLAGS(CONFIG_TCPC_I2C_BASE_ADDR_FLAGS)) +#define TCPC_ADDR_TO_PORT(addr) \ + ((addr)-I2C_STRIP_FLAGS(CONFIG_TCPC_I2C_BASE_ADDR_FLAGS)) /* Check if the i2c address belongs to TCPC */ -#de...
Uninstall: Remove empty Ruby & Python directories
@@ -121,7 +121,14 @@ set (REMOVAL_CANDIDATES "${CMAKE_INSTALL_PREFIX}/lib/lua" "${CMAKE_INSTALL_PREFIX}/lib/pkgconfig" "${CMAKE_INSTALL_PREFIX}/lib/python2.7/site-packages" + "${CMAKE_INSTALL_PREFIX}/lib/python2.7/__pycache__" "${CMAKE_INSTALL_PREFIX}/lib/python2.7" + "${CMAKE_INSTALL_PREFIX}/lib/python${PYTHON_VERSION...
improve hold-tap docs with better homerow example and more about flavors
@@ -21,6 +21,14 @@ By default, the hold-tap is configured to also select the 'hold' functionality i We call this the 'hold-preferred' flavor of hold-taps. While this flavor may work very well for a ctrl/escape key, it's not very well suited for home-row mods or layer-taps. That's why there are two more flavors to choos...
OPENMVPT: Set RTC clock source back to LSE on startup.
#define OMV_OSC_USB_CLKSOURCE RCC_USBCLKSOURCE_HSI48 #define OMV_OSC_RNG_CLKSOURCE RCC_RNGCLKSOURCE_HSI48 #define OMV_OSC_ADC_CLKSOURCE RCC_ADCCLKSOURCE_PLL3 +#define OMV_OSC_RTC_CLKSOURCE RCC_RTCCLKSOURCE_LSE #define OMV_OSC_SPI123_CLKSOURCE RCC_SPI123CLKSOURCE_PLL3 // HSE/HSI/CSI State
fix rpm taring
@@ -457,7 +457,7 @@ deb: create_obj_dir_structure VERSION .PHONY: srctar srctar: @#@(cd ..; tar cf $(BASENAME)/$(SRC_TAR) $(BASENAME)/src $(BASENAME)/Makefile) - @tar cf $(SRC_TAR) src lib Makefile config LICENSE README.MD VERSION --transform='s_^_$(PKG_NAME)-$(VERSION)/_' + @tar cf $(SRC_TAR) src lib Makefile config L...
add file transfer check
@@ -18,6 +18,7 @@ tests_general.append([0, 0, workdir + 'client_http_get -u /cgi-bin/he -v 2 212.2 tests_general.append([0, 0, workdir + 'client_http_get -u /cgi-bin/he -v 2 2a02:c6a0:4015:10::100']) tests_general.append([1, 0, workdir + 'client_http_get -u /cgi-bin/he -v 2 not.resolvable.neat']) tests_general.append([...
relay: unify exit codes on failure
@@ -608,7 +608,7 @@ main(int argc, char * const argv[]) exit(1); } else if (p == 0) { char msg[1024]; - /* child, for again so our intermediate process can die and + /* child, fork again so our intermediate process can die and * its child becomes an orphan to init */ p = fork(); if (p < 0) { @@ -793,19 +793,19 @@ main(...
revert idea_run_plugin
}, "platforms": [{"host": {"os": "LINUX"}, "default": true}] }, + "idea_run_plugin": { + "tools": { + "idea_run_plugin": { "bottle": "idea_run_plugin" } + }, + "platforms": [ + {"host": {"os": "LINUX"}, "default": true}, + {"host": {"os": "FREEBSD"}, "default": true}, + {"host": {"os": "WIN"}, "default": true}, + {"hos...
Disable GSO on first EIO error.
@@ -371,9 +371,13 @@ int picoquic_packet_loop(picoquic_quic_t* quic, (struct sockaddr*)&peer_addr, (struct sockaddr*)&local_addr, if_index, (const char*)send_buffer, (int)send_length, (int)send_msg_size, &sock_err); - if (sock_ret != (int)send_length && last_cnx != NULL) { + if (sock_ret != (int)send_length && sock_ret...
tests CHANGE enhance lys_getnext() tests
@@ -112,7 +112,9 @@ test_getnext(void **state) "leaf b {type string;} leaf-list c {type string;} list d {config false;}" "choice x { leaf e {type string;} case y {leaf f {type string;}}} anyxml g;" "rpc h {input {leaf h-input {type string;}} output {leaf h-output {type string;}}}" - "notification i {leaf i-data {type s...
hoon: comments, modernizes syntax for all +**-co gates
++ z-co |=(dat/@ `tape`['0' 'x' ((x-co 1) dat)]) -- |% + :: +em-co: format in numeric base + :: + :: in .bas, format .min digits of .hol with .par + :: + :: - .hol is processed least-significant digit first + :: - all available digits in .hol will be processed, but + :: .min digits can exceed the number available in .h...
Solve minor bugs with PyNone.
@@ -653,7 +653,7 @@ PyObject * py_loader_impl_value_to_capi(loader_impl impl, type_id id, value v) } else if (id == TYPE_NULL) { - return Py_None; + Py_RETURN_NONE; } else { @@ -837,7 +837,7 @@ PyObject * py_loader_impl_function_type_invoke(PyObject * self, PyObject * args) { log_write("metacall", LOG_LEVEL_ERROR, "Fat...
WIP: Fix openHelp on global error
@@ -3,9 +3,9 @@ import PropTypes from "prop-types"; import { connect } from "react-redux"; import l10n from "../../lib/helpers/l10n"; import Button from "./Button"; -import * as actions from "../../actions"; import { ErrorShape } from "../../reducers/stateShape"; import { SadIcon } from "./Icons"; +import { actions as ...