instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
oasis-open__cti-stix-validator-89 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"stix2validator/errors.py:pretty_error"
],
"edited_modules": [
"stix2validator/errors.py:pretty_error"
]
},
"file": "stix2validator/errors.py"
},
{
"changes": {
... | oasis-open/cti-stix-validator | a607014e3fa500a7678f8b61b278456ca581f9d0 | when spec_version is 2.0 on bundle, do not warn
On a stix bundle that has a spec_version of 2.0, the latest version of the validator returns a warning:
[!] Warning: bundle--59afb48d-0f9c-434d-be6a-69515424b0c3: {101} Custom property 'spec_version' should have a type that starts with 'x_' followed by a source uniqu... | diff --git a/stix2validator/errors.py b/stix2validator/errors.py
index c3e70b7..a0f3f42 100644
--- a/stix2validator/errors.py
+++ b/stix2validator/errors.py
@@ -222,9 +222,9 @@ def pretty_error(error, verbose=False):
"not an allowed value", msg)
elif ('target_ref' in error.schema_path... |
oasis-open__cti-stix-validator-9 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"stix2validator/__init__.py:NoJSONFileFoundError"
],
"edited_entities": [
"stix2validator/__init__.py:ValidationResults.__init__",
"stix2validator/__init__.py:get_json_files",
"stix2validator/__init... | oasis-open/cti-stix-validator | 4e902d017051c805f9d953a5ab11a09580f632e0 | warn instead of error for SHOULD
When providing a custom property, it errors about it (prints in red), instead of warning about it.
[!] course-of-action--d6e1dbd5-104f-4a09-b76c-3531d3398ecb: {103} Custom property 'obs_ref' should have a type that starts with 'x_' followed by a source unique identifier (like a domain ... | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b3ce782..1f505a8 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -1,42 +1,27 @@
-<div>
-<h1>Contributing</h1>
+# Contributing
-<div>
-<h2><a id="openParticipation">Public Participation Invited</a></h2>
+## <a id="openParticipation">Public Participation Invite... |
oasis-open__cti-taxii-client-11 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"taxii2client/__init__.py:_HTTPConnection.get"
],
"edited_modules": [
"taxii2client/__init__.py:_HTTPConnection"
]
},
"file": "taxii2client/__init__.py"
}
] | oasis-open/cti-taxii-client | 405bbbaa58d86371adc401ee4fe8830f429fb6b2 | Accept more flexible content type strings
When checking the content type of packets the client receives, it checks if it is an exact match (https://github.com/oasis-open/cti-taxii-client/blob/master/taxii2client/__init__.py#L481). This fails if for example "; charset=utf-8" is appended to the content type. | diff --git a/taxii2client/__init__.py b/taxii2client/__init__.py
index bee06a1..0efc770 100644
--- a/taxii2client/__init__.py
+++ b/taxii2client/__init__.py
@@ -478,7 +478,7 @@ class _HTTPConnection(object):
resp.raise_for_status()
content_type = resp.headers['Content-Type']
- if content_type... |
oasis-open__cti-taxii-client-31 | [
{
"changes": {
"added_entities": [
"taxii2client/__init__.py:_HTTPConnection.valid_content_type"
],
"added_modules": null,
"edited_entities": [
"taxii2client/__init__.py:Status.refresh",
"taxii2client/__init__.py:Collection.refresh",
"taxii2client/__init__... | oasis-open/cti-taxii-client | 0201af14e578714a297aff795413babc425a2219 | More flexible content-type matching
Building on #10, we should make the content-type matching more robust than just a string's `.startwith()`. | diff --git a/.gitignore b/.gitignore
index 1f8d3e2..f21feea 100644
--- a/.gitignore
+++ b/.gitignore
@@ -46,6 +46,7 @@ nosetests.xml
coverage.xml
*,cover
.hypothesis/
+.pytest_cache/
# Translations
*.mo
diff --git a/taxii2client/__init__.py b/taxii2client/__init__.py
index 85a7b7f..358892f 100644
--- a/taxii2cli... |
oasis-open__cti-taxii-client-32 | [
{
"changes": {
"added_entities": [
"taxii2client/__init__.py:ApiRoot._validate_api_root",
"taxii2client/__init__.py:Server._validate_server"
],
"added_modules": null,
"edited_entities": [
"taxii2client/__init__.py:Status._populate_fields",
"taxii2client/__... | oasis-open/cti-taxii-client | 0201af14e578714a297aff795413babc425a2219 | Verify correct handling of all optional fields.
For example: If the server's API root is without description, the client will throw an exception.
But the description is optional according to the spec, I expected there is no error here. | diff --git a/taxii2client/__init__.py b/taxii2client/__init__.py
index 85a7b7f..1fddedb 100644
--- a/taxii2client/__init__.py
+++ b/taxii2client/__init__.py
@@ -220,23 +220,50 @@ class Status(_TAXIIEndpoint):
self.refresh()
elapsed = time.time() - start_time
- def _populate_fields(self, i... |
oasis-open__cti-taxii-client-44 | [
{
"changes": {
"added_entities": [
"taxii2client/__init__.py:Status._raw",
"taxii2client/__init__.py:Collection._raw",
"taxii2client/__init__.py:ApiRoot._raw",
"taxii2client/__init__.py:Server._raw"
],
"added_modules": null,
"edited_entities": [
"t... | oasis-open/cti-taxii-client | 590746cc70a01bdda74032b8c3feb8d3f0532464 | Provide access to raw TAXII responses
This can probably be behind some sort of "private" interface (like `_raw`), but it would be helpful to have access to the raw JSON bodies on returned responses. | diff --git a/taxii2client/__init__.py b/taxii2client/__init__.py
index b4b0646..5c359cf 100644
--- a/taxii2client/__init__.py
+++ b/taxii2client/__init__.py
@@ -178,7 +178,7 @@ class Status(_TAXIIEndpoint):
# aren't other endpoints to call on the Status object.
def __init__(self, url, conn=None, user=None, ... |
oasis-open__cti-taxii-client-47 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"taxii2client/__init__.py:Collection.add_objects",
"taxii2client/__init__.py:_HTTPConnection.post"
],
"edited_modules": [
"taxii2client/__init__.py:Collection",
"taxii... | oasis-open/cti-taxii-client | 9c8130d5bcf793fde749a3b46bcb822168bcec30 | Funny JSON handling
I first started noticing this while working on the user-agent changes (#45), but this isn't directly related to those changes, so I am making a separate issue for this.
One of the things I added (and forgot to mention in the commit message, oops) was to add parameter documentation to _HTTPConnect... | diff --git a/taxii2client/__init__.py b/taxii2client/__init__.py
index 36e5929..5536a20 100644
--- a/taxii2client/__init__.py
+++ b/taxii2client/__init__.py
@@ -498,7 +498,7 @@ class Collection(_TAXIIEndpoint):
expires, or the operation completes.
Args:
- bundle (str): A STIX bundle with ... |
oasis-open__cti-taxii-client-54 | [
{
"changes": {
"added_entities": [
"taxii2client/__init__.py:Status.custom_properties",
"taxii2client/__init__.py:Collection.custom_properties",
"taxii2client/__init__.py:ApiRoot.custom_properties",
"taxii2client/__init__.py:ApiRoot._populate_fields",
"taxii2client/... | oasis-open/cti-taxii-client | 6e0ab981b7c613e46ab12b2c85567ef921fb7fa0 | ERROR - _populate_fields() got an unexpected keyword argument 'type'
```
server = Server(url, user=self.conf_api["user"], password=self.conf_api["password"], verify=False)
api_root = server.api_roots[0]
collections = api_root.collections
```
These code lines return this exceptions:
> ERROR - _populate_fields() ... | diff --git a/taxii2client/__init__.py b/taxii2client/__init__.py
index 8d5c722..548f279 100644
--- a/taxii2client/__init__.py
+++ b/taxii2client/__init__.py
@@ -217,6 +217,10 @@ class Status(_TAXIIEndpoint):
"""Get the "raw" status response (parsed JSON)."""
return self.__raw
+ @property
+ def... |
oasis-open__cti-taxii-client-55 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"taxii2client/__init__.py:_TAXIIEndpoint.__init__"
],
"edited_modules": [
"taxii2client/__init__.py:_TAXIIEndpoint"
]
},
"file": "taxii2client/__init__.py"
}
] | oasis-open/cti-taxii-client | 1070f8f7364824d8aa62d6cf6a77a8d7bf77e5cb | Check for trailing slash in URLs
```
>>> collection = Collection('http://localhost:5000/trustgroup1/collections/91a7b528-80eb-42ed-a74d-c6fbd5a26116', user='user1', password='Password1')
>>> collection.get_object('indicator--252c7c11-daf2-42bd-843b-be65edca9f61')
Traceback (most recent call last):
File "<stdin>",... | diff --git a/taxii2client/__init__.py b/taxii2client/__init__.py
index 548f279..edd90b5 100644
--- a/taxii2client/__init__.py
+++ b/taxii2client/__init__.py
@@ -159,7 +159,12 @@ class _TAXIIEndpoint(object):
else:
self._conn = _HTTPConnection(user, password, verify)
- self.url = url
+ ... |
oasis-open__cti-taxii-client-68 | [
{
"changes": {
"added_entities": [
"taxii2client/common.py:TokenAuth.__init__",
"taxii2client/common.py:TokenAuth.__call__"
],
"added_modules": [
"taxii2client/common.py:TokenAuth"
],
"edited_entities": [
"taxii2client/common.py:_TAXIIEndpoint.__init... | oasis-open/cti-taxii-client | 0a897aeac01969c681432269a7aed6f0693e4f5f | Question - why does the taxii client not implementing auth using api token?
I know of a few taxii servers requiring auth using api keys.
Is there any plan to implement auth using this?
e.g: `self.my_taxii = Server(url=self.url, verify=self.verify, proxies=self.proxies, token=self.api_key)` | diff --git a/taxii2client/common.py b/taxii2client/common.py
index cfd9d05..f8765d9 100644
--- a/taxii2client/common.py
+++ b/taxii2client/common.py
@@ -137,6 +137,15 @@ def _grab_total_items(resp):
), e)
+class TokenAuth(requests.auth.AuthBase):
+ def __init__(self, key):
+ self.key = key
+
+ ... |
oasis-open__cti-taxii-server-101 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"medallion/backends/taxii/memory_backend.py:MemoryBackend.load_data_from_file",
"medallion/backends/taxii/memory_backend.py:MemoryBackend.save_data_to_file"
],
"edited_modules": [
... | oasis-open/cti-taxii-server | 119d8fc6c742931e1e41632cad780c1743425292 | save_data_to_file() in test_memory_backend fails on Windows
https://github.com/oasis-open/cti-taxii-server/blob/b9441e14b73eefbd5c3b85c6de7a1c4e4db81a8a/medallion/test/test_memory_backend.py#L396-L403
> save_data_to_file(f.name) attempts to open the temporary file, which has already been opened by NamedTemporaryFile... | diff --git a/medallion/backends/taxii/memory_backend.py b/medallion/backends/taxii/memory_backend.py
index 85ce27f..d0871ee 100644
--- a/medallion/backends/taxii/memory_backend.py
+++ b/medallion/backends/taxii/memory_backend.py
@@ -5,6 +5,8 @@ import logging
import os
import re
+from six import string_types
+
fro... |
oasis-open__cti-taxii-server-44 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"medallion/backends/memory_backend.py:MemoryBackend.add_objects"
],
"edited_modules": [
"medallion/backends/memory_backend.py:MemoryBackend"
]
},
"file": "medallion/back... | oasis-open/cti-taxii-server | c99f8dcd93ad5f06174fc2767771acd491bedaaa | BUG: checking new object IDs as existing already always fail
https://github.com/oasis-open/cti-taxii-server/blob/f6398926d866989201e754dca0fec1e1a041acdf/medallion/backends/memory_backend.py#L166
This line will always fail, you're checking that the ID of the object belongs in the array of objects instead of checking... | diff --git a/medallion/backends/memory_backend.py b/medallion/backends/memory_backend.py
index 8da67b0..b07ae14 100644
--- a/medallion/backends/memory_backend.py
+++ b/medallion/backends/memory_backend.py
@@ -163,22 +163,23 @@ class MemoryBackend(Backend):
try:
for new_obj ... |
oauthlib__oauthlib-564 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "oauthlib/common.py"
}
] | oauthlib/oauthlib | 371029906aa6ccc9943120e096a7bbdd0ef6945d | ValueError when query string contains "'"
Similar to Issue #404, `oauthlib.common.urldecode` raises a ValueError if the provided query string contains a "'" character.
```
ValueError: Error trying to decode a non urlencoded string. Found invalid characters: set([u"'"]) in the string: 'url=Schr%C3%B6dinger's%20cat'.... | diff --git a/oauthlib/common.py b/oauthlib/common.py
index f25656f..c1180e6 100644
--- a/oauthlib/common.py
+++ b/oauthlib/common.py
@@ -114,7 +114,7 @@ def decode_params_utf8(params):
return decoded
-urlencoded = set(always_safe) | set('=&;:%+~,*@!()/?')
+urlencoded = set(always_safe) | set('=&;:%+~,*@!()/?\'... |
oauthlib__oauthlib-671 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"oauthlib/oauth2/rfc6749/grant_types/authorization_code.py:AuthorizationCodeGrant.validate_authorization_request"
],
"edited_modules": [
"oauthlib/oauth2/rfc6749/grant_types/authoriza... | oauthlib/oauthlib | b6b4d9fa68afa7a588015722f4d3d359b3a86b1f | OAuthlib API is not returning PKCE new values
**Describe the bug**
The internal method `validate_authorization_request` should return the list of OAuth2 fields in `request_info`. However, this function is not returning the PKCE values.
**Additional context**
OAuth2 Provider - Using PKCE with Authorization Code
... | diff --git a/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py b/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
index 5f03d9c..9b84c4c 100644
--- a/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
+++ b/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
@@ -405,12 +405,15 @@ class Aut... |
oauthlib__oauthlib-680 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"oauthlib/oauth2/rfc6749/parameters.py:parse_authorization_code_response"
],
"edited_modules": [
"oauthlib/oauth2/rfc6749/parameters.py:parse_authorization_code_response"
]
... | oauthlib/oauthlib | d2dcb0f5bb247c9e48fa876e3c99ff3298b3a4c0 | `parse_authorization_code_response` has no error checking
Over at https://github.com/gratipay/gratipay.com/issues/2870 we're finding that [`parse_authorization_code_response`](https://github.com/idan/oauthlib/blob/04631866c058defb480462db1ec13cb7f88780a9/oauthlib/oauth2/rfc6749/parameters.py#L179-L229) sometimes receiv... | diff --git a/oauthlib/oauth2/rfc6749/parameters.py b/oauthlib/oauth2/rfc6749/parameters.py
index 6b9d630..df724ee 100644
--- a/oauthlib/oauth2/rfc6749/parameters.py
+++ b/oauthlib/oauth2/rfc6749/parameters.py
@@ -264,12 +264,15 @@ def parse_authorization_code_response(uri, state=None):
query = urlparse.urlparse(ur... |
oauthlib__oauthlib-771 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"oauthlib/oauth2/rfc6749/grant_types/authorization_code.py:AuthorizationCodeGrant.create_authorization_response"
],
"edited_modules": [
"oauthlib/oauth2/rfc6749/grant_types/authorizat... | oauthlib/oauthlib | 555e3b06022c32e420b3bc0709c66988e91b7670 | OIDC request_type "code token" does not save access token
I was experimenting with `django-oauth-toolkit` and noticed when setting a request type of `code token` the returned access token was not valid because it was not saved into the database. Looking into the issue I believe that during the hybrid flow for `code`, a... | diff --git a/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py b/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
index bf42d88..97aeca9 100644
--- a/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
+++ b/oauthlib/oauth2/rfc6749/grant_types/authorization_code.py
@@ -272,6 +272,8 @@ class Autho... |
oauthlib__oauthlib-790 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"oauthlib/oauth2/rfc6749/endpoints/metadata.py:MetadataEndpoint.create_metadata_response"
],
"edited_modules": [
"oauthlib/oauth2/rfc6749/endpoints/metadata.py:MetadataEndpoint"
... | oauthlib/oauthlib | f6710113fdba6efe3710efdc2e26a08398509cb2 | CORS for metadata endpoint
**Describe the feature**
Return CORS headers for RFC6749 metadata endpoints. This will allow SPAs to fetch the metadata.
**Additional context**
The metadata endpoint is public and has no side effects, so should be safe to expose to all origins (`*`).
I'm willing to submit a PR fo... | diff --git a/docs/installation.rst b/docs/installation.rst
index 0e00e39..61428ce 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -118,7 +118,7 @@ Install from GitHub
-------------------
Alternatively, install it directly from the source repository on
-GitHub. This is the "bleading edge" version,... |
oauthlib__oauthlib-791 | [
{
"changes": {
"added_entities": [
"oauthlib/oauth2/rfc6749/grant_types/authorization_code.py:AuthorizationCodeGrant._create_cors_headers"
],
"added_modules": null,
"edited_entities": [
"oauthlib/oauth2/rfc6749/grant_types/authorization_code.py:AuthorizationCodeGrant.crea... | oauthlib/oauthlib | f6710113fdba6efe3710efdc2e26a08398509cb2 | CORS for token endpoint
**Describe the feature**
Return CORS headers for RFC6749 token endpoint. This will allow SPAs perform an Authentication Code Grant.
Although I cannot think of any reason why it would be problematic to expose to all origins (`*`), for safety we should restrict to a per-client origin list. ... | diff --git a/docs/installation.rst b/docs/installation.rst
index 0e00e39..61428ce 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -118,7 +118,7 @@ Install from GitHub
-------------------
Alternatively, install it directly from the source repository on
-GitHub. This is the "bleading edge" version,... |
octue__twined-68 | [
{
"changes": {
"added_entities": null,
"added_modules": [
".github/workflows/scripts/check-version-consistency.py:NotAReleaseBranchException"
],
"edited_entities": [
".github/workflows/scripts/check-version-consistency.py:release_branch_version_matches_setup_version"
... | octue/twined | 49e5a0b2c808c23b45a86f10048e4ff04809b8fb | Fix version consistency GitHub check so that it doesn't fail on main
The check currently fails on `main` and will fail on any single-word branch name. | diff --git a/.github/workflows/python-ci.yml b/.github/workflows/python-ci.yml
index 9582311..66a5e85 100644
--- a/.github/workflows/python-ci.yml
+++ b/.github/workflows/python-ci.yml
@@ -19,6 +19,7 @@ jobs:
tests:
runs-on: ubuntu-latest
+ if: "!contains(github.event.head_commit.message, '#skip_ci_tests')... |
odin-detector__odin-control-38 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/odin/adapters/adapter.py:request_types"
],
"edited_modules": [
"src/odin/adapters/adapter.py:request_types"
]
},
"file": "src/odin/adapters/adapter.py"
},
{
... | odin-detector/odin-control | dcf318be69193df8e6c1bbd4906a8475a5984e7f | Proxy Adapter does not handle Metadata
The proxy adapter does not pass any request for metadata on to the Proxy Target. It should handle requests for metadata as if it were a normal local request | diff --git a/src/odin/adapters/adapter.py b/src/odin/adapters/adapter.py
index 9bfe128..c20933d 100644
--- a/src/odin/adapters/adapter.py
+++ b/src/odin/adapters/adapter.py
@@ -199,7 +199,6 @@ def request_types(*oargs):
"""Inner method wrapper."""
# Validate the Content-Type header in the requ... |
oduwsdl__MementoEmbed-131 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "docs/source/conf.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mementoembed/fav... | oduwsdl/MementoEmbed | dfff20f4d336e76de33851d77c3f4a4af83a5ed2 | Exception while searching for favicon
MementoEmbed throws an exception for the following URI-M:
* http://wayback.archive-it.org/4887/20141104211213/http://time.com/3502740/ebola-virus-1976/
Here is the log entry:
```
[2018-09-06 14:07:36,093 -0600 ] - ERROR - [ /services/product/socialcard/http://wayback.archive-... | diff --git a/docs/source/conf.py b/docs/source/conf.py
index c7c0614..9892732 100644
--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -26,7 +26,7 @@ author = 'Shawn M. Jones'
# The short X.Y version
version = ''
# The full version, including alpha/beta/rc tags
-release = '0.2018.09.05.234815'
+release = '0.201... |
oduwsdl__MementoEmbed-137 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "docs/source/conf.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mementoembed/mem... | oduwsdl/MementoEmbed | 124675643fd680804b50ab268ebcd60c958dc6a1 | parsing multiple Link: response headers
Martin brought this to my attention. Here's a sample URL:
https://scholarlyorphans.org/memento/20181009212548/https://ianmilligan.ca/
and it returns two different Link headers:
$ curl -IL https://scholarlyorphans.org/memento/20181009212548/https://ianmilligan.ca/
HTTP/... | diff --git a/docs/source/conf.py b/docs/source/conf.py
index 00e7098..230f9e2 100644
--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -26,7 +26,7 @@ author = 'Shawn M. Jones'
# The short X.Y version
version = ''
# The full version, including alpha/beta/rc tags
-release = '0.2018.10.11.153710'
+release = '0.201... |
oduwsdl__MementoEmbed-74 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mementoembed/favicon.py:query_timegate_for_favicon"
],
"edited_modules": [
"mementoembed/favicon.py:query_timegate_for_favicon"
]
},
"file": "mementoembed/favicon.py"
... | oduwsdl/MementoEmbed | a8b4b7ecc7199c311c7b39e37b6857272a33c1b8 | Test with URI-Ms from Perma.cc
To start, try:
* http://perma-archives.org/warc/20180501135244/https://www.flexispy.com/ | diff --git a/mementoembed/favicon.py b/mementoembed/favicon.py
index 2fff1f1..f1e76b8 100644
--- a/mementoembed/favicon.py
+++ b/mementoembed/favicon.py
@@ -112,9 +112,10 @@ def query_timegate_for_favicon(timegate_stem, candidate_favicon_uri, accept_date
r = http_cache.get(favicon_timegate, headers={'accept-date... |
oduwsdl__ipwb-718 | [
{
"changes": {
"added_entities": [
"ipwb/__main__.py:checkArgs_index"
],
"added_modules": [
"ipwb/__main__.py:checkArgs_index"
],
"edited_entities": [
"ipwb/__main__.py:check_args_index",
"ipwb/__main__.py:check_args_replay",
"ipwb/__main__.p... | oduwsdl/ipwb | cce60262a9bdd80847223b85e1f41c495bea6255 | Update to test with go-ipfs 0.7.0
Released September 22, 2020: https://github.com/ipfs/go-ipfs/releases/tag/v0.7.0
Daemon CLI argument not implemented
The -d (daemon address) CLI argument isn't implemented, also stated in the help.
I use an external IPFS daemon with an exposed API behind nginx as a reverse proxy.
... | diff --git a/ipwb/__main__.py b/ipwb/__main__.py
index 8420152..bf8ed43 100644
--- a/ipwb/__main__.py
+++ b/ipwb/__main__.py
@@ -5,10 +5,12 @@ import random # For generating a temp file for stdin
import sys
import tempfile
+from multiaddr import Multiaddr
+from multiaddr import exceptions as multiaddr_exceptions
... |
oduwsdl__ipwb-809 | [
{
"changes": {
"added_entities": [
"ipwb/__main__.py:check_args_index"
],
"added_modules": [
"ipwb/__main__.py:check_args_index"
],
"edited_entities": [
"ipwb/__main__.py:checkArgs_index"
],
"edited_modules": [
"ipwb/__main__.py:checkArgs... | oduwsdl/ipwb | 54a23e2004873297e74845f66ddb5a7299e52636 | When indexing a WARC, a CRITICAL error of a missing function is reported
Latest main branch 54a23e2
go-ipfs 0.9.1
```sh
ipwb index ./samples/warcs/5mementos.warc
2023-08-16 12:19:19,544 [CRITICAL] ipwb: name 'check_args_index' is not defined
``` | diff --git a/ipwb/__main__.py b/ipwb/__main__.py
index bf8ed43..2df1479 100644
--- a/ipwb/__main__.py
+++ b/ipwb/__main__.py
@@ -18,7 +18,7 @@ def main():
check_args(sys.argv)
-def checkArgs_index(args):
+def check_args_index(args):
# args.daemon_address is always set. Either default or by CLI
try:
... |
oemof__oemof-network-31 | [
{
"changes": {
"added_entities": [
"src/oemof/network/network/nodes.py:Bus.__init__",
"src/oemof/network/network/nodes.py:Component.__init__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/oemof/network/network/nodes.py:Bus",
... | oemof/oemof-network | 2c298a7af84feceef8ce049d15c169ca7d28784e | Node subclasses are useless
All subclasses to Node (Bus, Component, Sink, Source, and Transformer) do not implement any additional functionality. I think, we can delete them. | diff --git a/src/oemof/network/network/nodes.py b/src/oemof/network/network/nodes.py
index bc1e1e7..b2690e6 100644
--- a/src/oemof/network/network/nodes.py
+++ b/src/oemof/network/network/nodes.py
@@ -11,6 +11,8 @@ SPDX-FileCopyrightText: Patrik SchΓΆnfeldt <patrik.schoenfeldt@dlr.de>
SPDX-License-Identifier: MIT
"""
... |
oemof__oemof-solph-1101 | [
{
"changes": {
"added_entities": [
"src/oemof/solph/_plumbing.py:_FakeSequence.__init__",
"src/oemof/solph/_plumbing.py:_FakeSequence.size",
"src/oemof/solph/_plumbing.py:_FakeSequence.__getitem__",
"src/oemof/solph/_plumbing.py:_FakeSequence.__repr__",
"src/oemof/s... | oemof/oemof-solph | c2d44e4a1a3baa93e738e8cc1551bfbde36e1494 | Chained sequence yields unexpected result
Casting to sequences can give unexpected results, as it sometimes returns a (fixed length) array, sometimes a (flexible) _Sequence:
```python
# previous implementation
s = sequence(sequence([5]))
s[0] = 5
s[5] = 5
# current implementation
s = sequence(sequence([5]))
... | diff --git a/docs/whatsnew/v0-5-4.rst b/docs/whatsnew/v0-5-4.rst
index 94263513..74ce1207 100644
--- a/docs/whatsnew/v0-5-4.rst
+++ b/docs/whatsnew/v0-5-4.rst
@@ -21,6 +21,8 @@ Bug fixes
Other changes
#############
+* Refined internal sequence generation. (For e.g. constraint formulations,
+ Scalars are internally... |
oemof__oemof-solph-1180 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/oemof/solph/components/_generic_storage.py:GenericInvestmentStorageBlock._create"
],
"edited_modules": [
"src/oemof/solph/components/_generic_storage.py:GenericInvestmentStorageB... | oemof/oemof-solph | f4c061a0bba0701269546e3c54e9cbcb4ee8987b | On dev branch GenericInvestStorageBlock is no longer able to enforce the 'balanced' constraint
**Short description:**
Using the current implementation of the `GenericInvestStorageBlock` in the dev branch, when setting the `balanced` parameter to `True`, the corresponding constraint can not enforce the `storage_content... | diff --git a/docs/usage.rst b/docs/usage.rst
index bae69f77..a4e17d0f 100644
--- a/docs/usage.rst
+++ b/docs/usage.rst
@@ -613,8 +613,7 @@ By calling:
views.node(results, 'your_storage_label')['scalars']
-you get the results of the scalar values of your storage, e.g. the initial
-storage content before time st... |
oemof__oemof-solph-950 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/oemof/solph/components/_link.py:Link.__init__"
],
"edited_modules": [
"src/oemof/solph/components/_link.py:Link"
]
},
"file": "src/oemof/solph/components/_link.py"
... | oemof/oemof-solph | 7f0c885ad38b04835615d11d56fd9c7dd727eb30 | Set `None` as default values for explicit arguments in Link component
Due to the process of building `oemof.tabular.facades`, it's necessary that the Link component uses its default values during its instantiation, as no values are passed. These default values are updated afterward.
Therefore, I will add `None` as ... | diff --git a/src/oemof/solph/components/_link.py b/src/oemof/solph/components/_link.py
index 594b7d2d..68df9248 100644
--- a/src/oemof/solph/components/_link.py
+++ b/src/oemof/solph/components/_link.py
@@ -25,6 +25,7 @@ from pyomo.core.base.block import ScalarBlock
from pyomo.environ import BuildAction
from pyomo.en... |
oemof__tespy-362 | [
{
"changes": {
"added_entities": [
"src/tespy/networks/network.py:Network._add_comps"
],
"added_modules": null,
"edited_entities": [
"src/tespy/networks/network.py:Network.set_defaults",
"src/tespy/networks/network.py:Network.add_conns",
"src/tespy/network... | oemof/tespy | a7918b5f2f3c32c4272222d07e58c0a8a8f3afc7 | get_comps of class Network does not work prior to first solve
### Discussed in https://github.com/oemof/tespy/discussions/359
<div type='discussions-op-text'>
<sup>Originally posted by **GoldenPotatis** September 22, 2022</sup>
Hi!
I'm a new user of TESPy and still learning. I found this small issue and woul... | diff --git a/docs/whats_new/v0-6-1.rst b/docs/whats_new/v0-6-1.rst
index 5632686a..70e889fe 100644
--- a/docs/whats_new/v0-6-1.rst
+++ b/docs/whats_new/v0-6-1.rst
@@ -22,6 +22,14 @@ New Features
:py:class:`tespy.connections.connection.Ref` class
(`Discussion #352 <https://github.com/oemof/tespy/discussions/352>`_... |
ofek__bit-24 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bit/format.py:address_to_public_key_hash"
],
"edited_modules": [
"bit/format.py:address_to_public_key_hash"
]
},
"file": "bit/format.py"
}
] | ofek/bit | 37182647309b54934fb49078d4c7a2fb21d7eb47 | Pay to scripthash
I have no experience with paying to scripthashes except when it's worked automagically for me before.
In #12 it looks like the initial workins of P2SH are being added. I'm not sure how straight forward P2SH is.
But... for the time being shouldn't we throw an exception if we try to `send()` to an... | diff --git a/bit/format.py b/bit/format.py
index 5ff8679..088d990 100644
--- a/bit/format.py
+++ b/bit/format.py
@@ -35,6 +35,8 @@ def verify_sig(signature, data, public_key):
def address_to_public_key_hash(address):
+ # Raise ValueError if we cannot identify the address.
+ get_version(address)
return b... |
ofek__bit-32 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bit/network/fees.py:get_fee_local_cache"
],
"edited_modules": [
"bit/network/fees.py:get_fee_local_cache"
]
},
"file": "bit/network/fees.py"
},
{
"changes": {
... | ofek/bit | 89dcd0a8d05b785691b34a9b28dee157ee419bea | Bug with send(combine=False)
I think there's some weird behavior here.
https://blockchain.info/tx/6519c1977bf0863aed1b70caeaeb521c32fab43e5fd663c310f09cdee63d0ad6?show_adv=true
The fee was super high but I think that was a sideeffect of the main bug. | diff --git a/.gitignore b/.gitignore
index 9367500..ba62003 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
*.log
*.pyc
+*.orig
/.cache
/.idea
/.coverage
diff --git a/bit/network/fees.py b/bit/network/fees.py
index 58a783a..4204400 100644
--- a/bit/network/fees.py
+++ b/bit/network/fees.py
@@ -1,3 +1,4 @@... |
ofek__bit-72 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bit/transaction.py:sign_tx"
],
"edited_modules": [
"bit/transaction.py:sign_tx"
]
},
"file": "bit/transaction.py"
}
] | ofek/bit | 20fc0e7047946c1f28f868008d99d659905c1af6 | Multisig error
What's wrong with that? The code below gives out an error `Traceback (most recent call last):
File "/home/tony/Documents/DLF/Dev/1.py", line 15, in <module>
NetworkAPI.broadcast_tx_testnet(tx_2)
File "/home/tony/.local/lib/python3.7/site-packages/bit/network/services.py", line 533, in broadcas... | diff --git a/bit/transaction.py b/bit/transaction.py
index 6d7c00b..95d0f71 100644
--- a/bit/transaction.py
+++ b/bit/transaction.py
@@ -621,13 +621,19 @@ def sign_tx(private_key, tx, *, unspents):
# Make input parameters for preimage calculation
inputs_parameters = []
+
+ # The TxObj in `tx` will below ... |
ofek__hatch-vcs-17 | [
{
"changes": {
"added_entities": [
"hatch_vcs/version_source.py:VCSVersionSource.construct_setuptools_scm_config"
],
"added_modules": null,
"edited_entities": [
"hatch_vcs/version_source.py:VCSVersionSource.get_version_data"
],
"edited_modules": [
"hat... | ofek/hatch-vcs | 753f5091c4387b05230e2d2037652351c54f1c45 | setuptools-scm "root" parameter is ignored in raw-options
Consider this config in the pyproject.toml:
```toml
[tool.hatch.version]
raw-options = { root = ".." }
source = "vcs"
```
and such source tree:
```
.
βββ .git
βββ package1
| ...
βΒ Β βββ pyproject.toml
βββ package2
| ...
βΒ Β βββ pyprojec... | diff --git a/hatch_vcs/version_source.py b/hatch_vcs/version_source.py
index cc78d37..71d1e37 100644
--- a/hatch_vcs/version_source.py
+++ b/hatch_vcs/version_source.py
@@ -47,13 +47,11 @@ class VCSVersionSource(VersionSourceInterface):
return self.__config_raw_options
- def get_version_data(self):
+ ... |
ofek__pypinfo-107 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pypinfo/core.py:create_config",
"pypinfo/core.py:build_query"
],
"edited_modules": [
"pypinfo/core.py:create_config",
"pypinfo/core.py:build_query"
]
},
... | ofek/pypinfo | a5ce3683b82a551db42686f8512501df8f78642b | Use clustered BigQuery tables for 95% improvements in querying costs
I create daily new tables that heavily improve the costs of going to BigQuery. `pypinfo` could use them:
- https://towardsdatascience.com/python-pypi-stats-in-bigquery-reclustered-d80e583e1bfe
(goes from 200GB queries to 10GB queries)
| diff --git a/pypinfo/core.py b/pypinfo/core.py
index d4de0cb..1075ea9 100644
--- a/pypinfo/core.py
+++ b/pypinfo/core.py
@@ -9,15 +9,8 @@ from google.cloud.bigquery.job import QueryJobConfig
from pypinfo.fields import AGGREGATES, Downloads
-FROM = """\
-FROM
- TABLE_DATE_RANGE(
- [the-psf:pypi.downloads],
- ... |
ofek__pypinfo-109 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "pypinfo/core.py"
}
] | ofek/pypinfo | 0007c10256804650b4787a14a32e38e8f9347bbc | No matching signature for function DATE_ADD for argument types: TIMESTAMP, INTERVAL INT64 DATE_TIME_PART
Hi,
After installation following instructions given in the `README.md`, I tried a simplest call:
```bash
pypinfo requests
```
Unfortunately getting following exception:
```
...
File "/Users/christianr/.v... | diff --git a/pypinfo/core.py b/pypinfo/core.py
index 1075ea9..41bbd8c 100644
--- a/pypinfo/core.py
+++ b/pypinfo/core.py
@@ -10,7 +10,7 @@ from google.cloud.bigquery.job import QueryJobConfig
from pypinfo.fields import AGGREGATES, Downloads
FROM = 'FROM `the-psf.pypi.file_downloads`'
-DATE_ADD = 'DATE_ADD(CURRENT_T... |
ofek__pypinfo-137 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pypinfo/core.py:build_query"
],
"edited_modules": [
"pypinfo/core.py:build_query"
]
},
"file": "pypinfo/core.py"
}
] | ofek/pypinfo | afaa4265a6baced61a3cea9845e0a5ab4cbb6c06 | --where ignores project
These match because `--where 'file.project = "project"'` gets silently overridden:
```console
$ pypinfo --days 1095 --limit 36 --order download_month --where 'details.python = "1.17"' '' month
Served from cache: False
Data processed: 186.48 GiB
Data billed: 186.48 GiB
Estimated cost: $0.92... | diff --git a/pypinfo/core.py b/pypinfo/core.py
index fe4de37..39fb272 100644
--- a/pypinfo/core.py
+++ b/pypinfo/core.py
@@ -138,20 +138,16 @@ def build_query(
for field in fields:
query += f' {field.data} as {field.name},\n'
- query += FROM
-
- query += f'\nWHERE timestamp BETWEEN {start_date} A... |
ofek__pypinfo-49 | [
{
"changes": {
"added_entities": [
"pypinfo/core.py:validate_date",
"pypinfo/core.py:format_date"
],
"added_modules": [
"pypinfo/core.py:validate_date",
"pypinfo/core.py:format_date"
],
"edited_entities": [
"pypinfo/core.py:build_query"
... | ofek/pypinfo | 72ea0a3e5669757e3c625ea2f1f0e3463d11db86 | Allow YYYY-MM-DD dates in --start-date and --end-date
It'd be handy to be able to use `YYYY-MM-DD` dates as the start and end date. For example:
```console
$ pypinfo --start-date 2018-01-01 --end-date 2018-01-31 pillow pyversion
```
Rather than having to work it out:
```console
$ pypinfo --start-date -43 --... | diff --git a/pypinfo/core.py b/pypinfo/core.py
index f1ba663..5c633a4 100644
--- a/pypinfo/core.py
+++ b/pypinfo/core.py
@@ -12,13 +12,17 @@ FROM = """\
FROM
TABLE_DATE_RANGE(
[the-psf:pypi.downloads],
- DATE_ADD(CURRENT_TIMESTAMP(), {}, "day"),
- DATE_ADD(CURRENT_TIMESTAMP(), {}, "day")
+ {},
+ {}... |
ofek__pypinfo-71 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pypinfo/cli.py:pypinfo"
],
"edited_modules": [
"pypinfo/cli.py:pypinfo"
]
},
"file": "pypinfo/cli.py"
},
{
"changes": {
"added_entities": [
"pypin... | ofek/pypinfo | 48d56e690d7667ae5854752c3a2dc07e321d5637 | new option start-month (or: allow incomplete date YYYY-MM)
This is possibly related to #47 as well as #48.
I would like to have statistics for each month, and this is achievable throught `--start-date` and `--end-date` options, but for convenience it would be nice to be able to just specify the month like 2018-10.
... | diff --git a/README.rst b/README.rst
index 5e9b0eb..1a26c1f 100644
--- a/README.rst
+++ b/README.rst
@@ -307,6 +307,39 @@ Downloads between two YYYY-MM-DD dates
| -------------- |
| 9,572,911 |
+Downloads between two YYYY-MM dates
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+- A yyyy-mm ``--start-date`` def... |
ogawa-ros__necstdb-17 | [
{
"changes": {
"added_entities": [
"necstdb/necstdb.py:duplicate_rename",
"necstdb/necstdb.py:necstdb.save_file",
"necstdb/necstdb.py:necstdb.read_file"
],
"added_modules": [
"necstdb/necstdb.py:duplicate_rename"
],
"edited_entities": [
"necs... | ogawa-ros/necstdb | b539dbc8fed02d8715327eb5abefd381a1c80ce7 | Add file copy function
When we want to save config files, we couldn't use this database, because of a difficulty handling string data.
But the functionality is definitely needed, since there are many those files which need to be saved as a part of observation log.
So we'll add a file copying function to `necstdb` cla... | diff --git a/README.md b/README.md
index 0e913a7..a1bf9cb 100644
--- a/README.md
+++ b/README.md
@@ -104,6 +104,15 @@ pip install necstdb
***NOTE:***
Multi-dimensional data are not supported.
+ ***NOTE:***
+ Shape of array or length of string in every data must be the same as the one in data informati... |
ohsu-comp-bio__py-tes-52 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"tes/client.py:HTTPClient._request_params"
],
"edited_modules": [
"tes/client.py:HTTPClient"
]
},
"file": "tes/client.py"
},
{
"changes": {
"added_entities... | ohsu-comp-bio/py-tes | e67ab6ecb2c7c5113f35c7d8bc91ad4ad160c65f | Increase unit test code coverage
According to the most recent code coverage report (on branch [`api-location`](https://github.com/ohsu-comp-bio/py-tes/tree/api-location) in PR #46), there is still a bit of untested code:
```console
Name Stmts Miss Cover Missing
-----------------------------------... | diff --git a/tes/client.py b/tes/client.py
index d3f21a7..5539a34 100644
--- a/tes/client.py
+++ b/tes/client.py
@@ -193,14 +193,14 @@ class HTTPClient(object):
time.sleep(0.5)
def _request_params(
- self, data: Optional[str] = None,
- params: Optional[Dict] = None
+ self, data:... |
olirice__flupy-20 | [
{
"changes": {
"added_entities": [
"src/flupy/fluent.py:Fluent.to_list"
],
"added_modules": null,
"edited_entities": [
"src/flupy/fluent.py:Fluent.shuffle"
],
"edited_modules": [
"src/flupy/fluent.py:Fluent"
]
},
"file": "src/flupy/fluent... | olirice/flupy | 790ba5f6aca1255565f1e1d25d8a35fb3c706cf4 | Discussion regarding Fluent.collect return type
[Previously in in this MR](https://github.com/olirice/flupy/pull/17)
@olirice mentioned that
> Any chance you'd be willing to take a look at Fluent.collect? it currently returns a Collection[T] but I'd love to have it pick up the container type from the container_typ... | diff --git a/docs/api.rst b/docs/api.rst
index 8dfd280..f074abd 100644
--- a/docs/api.rst
+++ b/docs/api.rst
@@ -70,6 +70,7 @@ Summarizing
.. automethod:: flu.last
.. automethod:: flu.head
.. automethod:: flu.tail
+.. automethod:: flu.to_list
.. automethod:: flu.collect
----
diff --git a/src/flupy/fluent.py b/sr... |
olofk__edalize-198 | [
{
"changes": {
"added_entities": [
"edalize/edatool.py:subprocess_run_3_9"
],
"added_modules": [
"edalize/edatool.py:subprocess_run_3_9"
],
"edited_entities": [
"edalize/edatool.py:Edatool._run_scripts",
"edalize/edatool.py:Edatool._run_tool"
]... | olofk/edalize | 232ee15a61c19942fe6f3a79d5a2540470c7d4aa | Getting stdout from tool
It'd be useful to be able to call a tool and get easy access to stdout and stderr from that tool.
Often I'll have a script that processes these to check that everything went OK.
I'd like to modify `Edatool._run_tool` so that it returns a string containing the output from the tool (combine... | diff --git a/README.rst b/README.rst
index 2fe442a..a461276 100644
--- a/README.rst
+++ b/README.rst
@@ -14,7 +14,7 @@ What's this?
Edalize is a Python Library for interacting with EDA tools. It can create project files for supported tools and run them in batch or GUI mode (where supported).
-`Edalize introduction... |
olofk__fusesoc-724 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fusesoc/provider/git.py:Git._checkout_library_version",
"fusesoc/provider/git.py:Git.update_library"
],
"edited_modules": [
"fusesoc/provider/git.py:Git"
]
},
"... | olofk/fusesoc | ea427d4d1c4ff2ce7768b1e97956aaad09a7f9f0 | Library update fails with git provider and fixed sync-version
I've noticed a problem when using fixed library versions in conjunction with libraries, that should be updated. This can reproduced with the current `master` (commit `b604f53d`):
* create a temporary virtual environment and install the latest fusesoc
``... | diff --git a/fusesoc/provider/git.py b/fusesoc/provider/git.py
index 3b03465..bb1af4b 100644
--- a/fusesoc/provider/git.py
+++ b/fusesoc/provider/git.py
@@ -20,7 +20,7 @@ class Git(Provider):
if library.sync_version:
logger.info(
- "Checkout out {} at version {}".format(
+ ... |
omaciel__fauxfactory-103 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fauxfactory/factories/strings.py:gen_alpha",
"fauxfactory/factories/strings.py:gen_alphanumeric",
"fauxfactory/factories/strings.py:gen_cjk",
"fauxfactory/factories/strings.py:ge... | omaciel/fauxfactory | df28434be0baed3e68e9c26986ff67f78b66d5b0 | [Proposal] some extra param to avoid string formatting
While using some string category method user like to matriculate string; they want string `start` with something. Its most common use-case; which, I observed while using `fauxfactory` in daily life. It will reduce lots of indirect string formatting.
```
def gen_a... | diff --git a/fauxfactory/factories/strings.py b/fauxfactory/factories/strings.py
index 5e38b52..67f6e50 100644
--- a/fauxfactory/factories/strings.py
+++ b/fauxfactory/factories/strings.py
@@ -68,28 +68,35 @@ def gen_string(str_type, length=None, validator=None, default=None, tries=10):
@check_len
@check_validation... |
omarryhan__aiogoogle-68 | [
{
"changes": {
"added_entities": [
"aiogoogle/models.py:MediaUpload.run_validation",
"aiogoogle/models.py:MediaUpload.aiter_file",
"aiogoogle/models.py:MediaUpload._aiter_body",
"aiogoogle/models.py:MediaUpload.read_file",
"aiogoogle/models.py:MediaUpload.__str__"
... | omarryhan/aiogoogle | 0343cca9ef62c6719281612fbc254bd8d584a026 | feature request: support for in memory upload/download media
Thanks a lot for this great library!
I would like to use it in a tool that performs automated backups of autodesk bim360 files (but it could be any other storage service) to a google drive folder.
As of now, the only way to use the drive method `files.c... | diff --git a/aiogoogle/models.py b/aiogoogle/models.py
index 083fad4..f620a35 100644
--- a/aiogoogle/models.py
+++ b/aiogoogle/models.py
@@ -1,8 +1,7 @@
from urllib.parse import urlparse, urlunparse, urlencode, parse_qs
import pprint
-from .excs import HTTPError, AuthError
-
+from .excs import HTTPError, AuthError,... |
omise__omise-python-53 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"omise/__init__.py:_as_object"
],
"edited_modules": [
"omise/__init__.py:_as_object"
]
},
"file": "omise/__init__.py"
}
] | omise/omise-python | e00fe8bb9d53a8f7a1546c14994253e0c0fd93fb | Can't access a metadata object
The metadata properly appears when getting an object via `curl`
But accessing metadata via omise client got an error
```
>>> transfer = omise.Transfer.retrieve(transfer_id)
>>> transfer.metadata
*** AttributeError: object
``` | diff --git a/omise/__init__.py b/omise/__init__.py
index 3ab88f0..bce6517 100644
--- a/omise/__init__.py
+++ b/omise/__init__.py
@@ -103,7 +103,7 @@ def _as_object(data):
if isinstance(data, list):
return [_as_object(i) for i in data]
elif isinstance(data, dict):
- class_ = _get_class_for(data... |
omni-us__jsonargparse-132 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/actions.py:_ActionPrintConfig.__init__",
"jsonargparse/actions.py:_ActionPrintConfig.__call__"
],
"edited_modules": [
"jsonargparse/actions.py:_ActionPrintConfig... | omni-us/jsonargparse | d0830889df9a1ca89dd44761ecd4e44049e25b7b | Support `--print_config skip_default`
Add support for `--print_config skip_default` so only the values different to the default are printed.
Two main benefits:
- Removes the manual work of removing the extra arguments from a config. However, this isn't recommended for reproducibility as it's useful to know exactly ... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index e697442..b90bc59 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -10,6 +10,15 @@ only be introduced in major versions with advance notice in the **Deprecated**
section of releases.
+v4.6.0 (2022-04-??)
+-------------------
+
+Added
+^^^^^
+- Dump option to exclude... |
omni-us__jsonargparse-138 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "jsonargparse/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargpars... | omni-us/jsonargparse | 8506d7944478a6f6a2be9840944a86eb454254a9 | Support passing lists of class_path items via command line
When one wants to pass a list of objects to a parser, this works very well using configs:
```python
from typing import List, Optional
from jsonargparse import ActionConfigFile
from pytorch_lightning.utilities.cli import ArgumentParser
class A:
... | diff --git a/.bumpversion.cfg b/.bumpversion.cfg
index d8f280e..474a57c 100644
--- a/.bumpversion.cfg
+++ b/.bumpversion.cfg
@@ -1,5 +1,5 @@
[bumpversion]
-current_version = 4.7.3
+current_version = 4.8.0.dev1
commit = True
tag = True
tag_name = v{new_version}
diff --git a/.sonarcloud.properties b/.sonarcloud.prope... |
omni-us__jsonargparse-175 | [
{
"changes": {
"added_entities": [
"jsonargparse/typehints.py:ActionTypeHint.is_callable_typehint"
],
"added_modules": null,
"edited_entities": [
"jsonargparse/typehints.py:ActionTypeHint.parse_argv_item",
"jsonargparse/typehints.py:adapt_typehints"
],
... | omni-us/jsonargparse | babb93c8d72300acf290e9f9eddb90df5c361fa4 | Cannot override Callable init_args without passing the class_path
## π Bug report
Unlike the class argument, I cannot override `Callable` argument without passing the class_path even it is given previously.
### To reproduce
```python
from jsonargparse import CLI
from typing import Callable
def call():
... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 65a3d33..cba0a11 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -24,6 +24,8 @@ Fixed
- ``default_env`` not forwarded to subcommand parsers, causing environment
variable names to not be shown in subcommand help `pytorch-lightning#12790
<https://github.com/Lightn... |
omni-us__jsonargparse-176 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/typehints.py:ActionTypeHint.is_callable_typehint",
"jsonargparse/typehints.py:ActionTypeHint.parse_argv_item"
],
"edited_modules": [
"jsonargparse/typehints.py:A... | omni-us/jsonargparse | 04383f9d38d4096b7d149c8a4d2d57d21d521438 | Cannot override Callable init_args without passing the class_path
## π Bug report
Unlike the class argument, I cannot override `Callable` argument without passing the class_path even it is given previously.
### To reproduce
```python
from jsonargparse import CLI
from typing import Callable
def call():
... | diff --git a/jsonargparse/typehints.py b/jsonargparse/typehints.py
index b163825..e4f1d2d 100644
--- a/jsonargparse/typehints.py
+++ b/jsonargparse/typehints.py
@@ -235,8 +235,12 @@ class ActionTypeHint(Action):
@staticmethod
- def is_callable_typehint(typehint):
+ def is_callable_typehint(typehint, all_... |
omni-us__jsonargparse-197 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/core.py:ArgumentParser.__init__",
"jsonargparse/core.py:ArgumentParser.set_defaults",
"jsonargparse/core.py:ArgumentParser.error_handler",
"jsonargparse/core.py:Argu... | omni-us/jsonargparse | fe55400e9564dbaf64219603ea1ce9de13a64ee5 | Support for conversion to `torch.Tensor`
## π Bug report
I am encountering a problem using the package with Lightning.
When trying to specify an `init_args` which expects a `torch.Tensor` (for example when specifying the weights of a loss function), an error occurs because torch module expects a tensor, not a li... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 1d800e2..005aa34 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -21,6 +21,8 @@ Fixed
- ``parse_string`` raises ``AttributeError`` when given a simple string.
- Added missing ``return_parser`` deprecation warning when ``CLI`` has
subcommands.
+- Parsing fails for ... |
omni-us__jsonargparse-212 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/namespace.py:Namespace.items"
],
"edited_modules": [
"jsonargparse/namespace.py:Namespace"
]
},
"file": "jsonargparse/namespace.py"
},
{
"changes":... | omni-us/jsonargparse | f37e6388a3fd85afd3ce8067b3495c1dee15956f | Discard `init_args` after `class_path` change causes error
## π Bug report
When composing configs, it appears that overwritten class paths do not properly drop the old `init_args` namespace, causing an error when the new class does not have the same `init_args`.
Here is the error message:
```bash
$ main fit ... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 23e37a4..5692d1a 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -28,6 +28,8 @@ Fixed
- List type with empty list default causes failure `PyLaia#48
<https://github.com/jpuigcerver/PyLaia/issues/48>`__.
- Pure dataclass instance default being considered as a subcla... |
omni-us__jsonargparse-223 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/link_arguments.py:ActionLink.__init__",
"jsonargparse/link_arguments.py:ActionLink.set_target_value"
],
"edited_modules": [
"jsonargparse/link_arguments.py:Actio... | omni-us/jsonargparse | 0d73a844ea6355dfddc49c145e25e7d4f22ffe83 | Link arguments "Target key must be for an individual argument"
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
Certain argument links produce an error. For example, using a subclass of the `LightningCLI` that links the trainer `default_root_dir` to the... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 6a9373a..688ae1c 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -43,6 +43,8 @@ Fixed
- ``fail_untyped=False`` not propagated to subclass ``--*.help`` actions.
- Issues reported by CodeQL.
- Incorrect value when ``Path`` is cast to ``str`` and ``rel_path`` was chang... |
omni-us__jsonargparse-233 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/core.py:ArgumentParser.add_subcommands"
],
"edited_modules": [
"jsonargparse/core.py:ArgumentParser"
]
},
"file": "jsonargparse/core.py"
}
] | omni-us/jsonargparse | 89f88de4d9b93700b755a3cedde401e312f461c6 | Issue with Root Args and config file
## π Bug report
An error
`jsonargparse.util.ParserError: Problem in default config file "/home/main/Tools/.config/config.yaml" :: Configuration check failed :: No action for destination key "prepare.output" to check its value.
`
is raised when trying to parse args
### To re... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 0aef214..58bf380 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -15,6 +15,11 @@ paths are considered internals and can change in minor and patch releases.
v4.20.0 (2023-01-??)
--------------------
+Fixed
+^^^^^
+- ``add_subcommands`` fails when parser has required... |
omni-us__jsonargparse-239 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/cli.py:CLI",
"jsonargparse/cli.py:_add_component_to_parser",
"jsonargparse/cli.py:_run_component"
],
"edited_modules": [
"jsonargparse/cli.py:CLI",
... | omni-us/jsonargparse | fadff045095c6657af7b764c880eefbca5ea829c | CLI does not work with callable component?
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
CLI currently breaks if I pass in a callable instance instead of a function. It would be nice not to break this abstraction.
### To reproduce
```python
from... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 58bf380..b5624a2 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -15,6 +15,11 @@ paths are considered internals and can change in minor and patch releases.
v4.20.0 (2023-01-??)
--------------------
+Added
+^^^^^
+- ``CLI`` support for callable class instances `#238... |
omni-us__jsonargparse-242 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/signatures.py:SignatureArguments._add_signature_parameter",
"jsonargparse/signatures.py:SignatureArguments.add_dataclass_arguments"
],
"edited_modules": [
"jsona... | omni-us/jsonargparse | dc5cdac8c4b1e029efaa2c273ea740e60fcacec7 | Update `fail_untyped` flag to work with dataclasses whose arguments are classese with untyped arguments.
## π Feature request
The `fail_untyped` works with classes and nested classes, but id does not work with dataclasses which have class arguments with untyped arguments in their `__init__`.
### Motivation
Da... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index b5624a2..c80d4ea 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -48,6 +48,7 @@ v4.19.0 (2022-12-27)
Added
^^^^^
+- ``add_dataclass_arguments`` now supports the ``fail_untyped`` parameter
- ``CLI`` now supports the ``fail_untyped`` and ``parser_class`` parameters.... |
omni-us__jsonargparse-248 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "jsonargparse/typehints.py"
}
] | omni-us/jsonargparse | 14b484266115f79040b6a5c555e201daddf54f12 | ``discard_init_args_on_class_path_change`` does not handle nested ``dict`` subclass specs in some contexts
## π Bug report
Firstly, thanks again for all your work maintaining this remarkably valuable package!
While a ``subclass_spec`` can be either a ``dict`` or ``Namespace``
https://github.com/omni-us/jsonargpa... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 4faf1b4..1aafaf5 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,11 +12,14 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
-v4.20.1 (2023-02-??)
+v4.20.1 (2023-... |
omni-us__jsonargparse-253 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/signatures.py:SignatureArguments.add_dataclass_arguments"
],
"edited_modules": [
"jsonargparse/signatures.py:SignatureArguments"
]
},
"file": "jsonargparse... | omni-us/jsonargparse | 1fce98951f6d41064a516719fd7940b3f00ee08b | parser.add_dataclass_arguments doesn't support fields with init=False
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
<!-- A clear and concise description of the bug. -->
If I have a dataclass with protected members (ex: _foo) in a dataclass, meaning ... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 1aafaf5..1b29009 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -17,12 +17,13 @@ v4.20.1 (2023-03-??)
Fixed
^^^^^
-- Allow ``discard_init_args_on_class_path_change`` to handle more nested contexts `#247
- <https://github.com/omni-us/jsonargparse/issues/247>`__.
-... |
omni-us__jsonargparse-254 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/typehints.py:ActionTypeHint.__call__",
"jsonargparse/typehints.py:subclass_spec_as_namespace"
],
"edited_modules": [
"jsonargparse/typehints.py:ActionTypeHint",
... | omni-us/jsonargparse | 3de6d6f4a57567e6a63f9e15f8565c4b537bba45 | CLI modification of dictionary args
## π Documentation improvement
I am struggling to find information on how one should proceed to modify elements from dictionary args.
E.g. consider a class whereby one (for simplicity) input is a dictionary with a couple of keys. How should one proceed to change the value of o... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 1b29009..8bea11a 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -24,6 +24,9 @@ Fixed
contexts `#247 <https://github.com/omni-us/jsonargparse/issues/247>`__.
- Failure with dataclasses that have field with ``init=False`` `#252
<https://github.com/omni-us/jsonarg... |
omni-us__jsonargparse-263 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/loaders_dumpers.py:yaml_load"
],
"edited_modules": [
"jsonargparse/loaders_dumpers.py:yaml_load"
]
},
"file": "jsonargparse/loaders_dumpers.py"
}
] | omni-us/jsonargparse | 3f407662d1228d71e8d46ae76fde0449f2287334 | str argument is mistaken as a dict if it looks like 'Foo:'
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
An init_args str is mistaken as a dict if it is `Foo:`, even though it is typed `str`
### To reproduce
```python
from jsonargparse impor... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 25f63c1..08bd7b9 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -15,13 +15,18 @@ paths are considered internals and can change in minor and patch releases.
v4.21.0 (2023-04-??)
--------------------
+Fixed
+^^^^^
+- `str` parameter in subclass incorrectly parsed as... |
omni-us__jsonargparse-326 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_actions.py:_ActionConfigLoad.instantiate_classes"
],
"edited_modules": [
"jsonargparse/_actions.py:_ActionConfigLoad"
]
},
"file": "jsonargparse/_actions.... | omni-us/jsonargparse | 5798fe31297435e4e9a3f69be2814031cc5c8ee6 | Add hooks for before/after instantiating objects
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Feature request
Add methods `jsonargparse.ArgumentParser` that let the user specify custom code that can be executed before / after an object is instantiated.
##... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 0dac530..5d7a8f2 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -26,6 +26,9 @@ Added
<https://github.com/omni-us/jsonargparse/issues/337#issuecomment-1665055459>`__).
- Improved resolving of nested forward references in types.
- The ``ext_vars`` for an ``ActionJs... |
omni-us__jsonargparse-333 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:ActionTypeHint.get_class_parser"
],
"edited_modules": [
"jsonargparse/_typehints.py:ActionTypeHint"
]
},
"file": "jsonargparse/_typehints.py"... | omni-us/jsonargparse | 0e6b18070e108598bd1b51889c93e34fe62a6d2f | Cannot pass saving check when linking to required value of dataclass parameter of subclass argument
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
<!-- A clear and concise description of the bug. -->
### To reproduce
```python
from dataclasses ... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 24e2e48..75e8529 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.23.1 (2023-07-??)
+---------------... |
omni-us__jsonargparse-346 | [
{
"changes": {
"added_entities": [
"jsonargparse/_cli.py:_add_subcommands"
],
"added_modules": [
"jsonargparse/_cli.py:_add_subcommands"
],
"edited_entities": [
"jsonargparse/_cli.py:CLI"
],
"edited_modules": [
"jsonargparse/_cli.py:CLI"
... | omni-us/jsonargparse | dcfd265ad12f43a09e9db25d552c8bdb6f9304f8 | Add multilevel subcommands support to `CLI`
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Feature request
Currently `jsonargparse.CLI` can handle only one level of subcommands through classes. For example:
```Python
from jsonargparse import CLI
class myc... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index e44b33f..b07579f 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -19,6 +19,9 @@ Added
^^^^^
- New option in ``dump`` for including link targets.
- Support ``decimal.Decimal`` as a type.
+- ``CLI`` now accepts components as a dict, such that the keys define names of
... |
omni-us__jsonargparse-363 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints"
]
},
"file": "jsonargparse/_typehints.py"
}
] | omni-us/jsonargparse | 323b4a50f4e1112b9fe2f126b0a1f0bd0896b8a7 | `default` and `default_factory` do not work in nested list with parse_object
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
<!-- A clear and concise description of the bug. -->
### To reproduce
```python
from dataclasses import dataclass, field... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 65d6bd7..73f7a38 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -19,6 +19,8 @@ Fixed
^^^^^
- Remove private ``linked_targets`` parameter from API Reference (`#317
<https://github.com/omni-us/jsonargparse/issues/317>`__).
+- Dataclass nested in list not setting de... |
omni-us__jsonargparse-364 | [
{
"changes": {
"added_entities": [
"jsonargparse/_parameter_resolvers.py:ParametersVisitor.get_kwargs_pop_or_get_parameter",
"jsonargparse/_parameter_resolvers.py:ParametersVisitor.get_node_origin"
],
"added_modules": null,
"edited_entities": [
"jsonargparse/_para... | omni-us/jsonargparse | cd165e9e0dd8bb497693568ea90c732cf74e12f4 | Instantiation fails with TypeError only when fail_untyped=False
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
I'm trying to instantiate a config class from Huggingface with CLI and it fails when `fail_untyped=False`. The fail_untyped is important bec... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 73f7a38..db9cf3f 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -21,6 +21,9 @@ Fixed
<https://github.com/omni-us/jsonargparse/issues/317>`__).
- Dataclass nested in list not setting defaults (`#357
<https://github.com/omni-us/jsonargparse/issues/357>`__)
+- AST... |
omni-us__jsonargparse-370 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_core.py:ArgumentParser._load_config_parser_mode"
],
"edited_modules": [
"jsonargparse/_core.py:ArgumentParser"
]
},
"file": "jsonargparse/_core.py"
}
] | omni-us/jsonargparse | 6ed515b78d281e10b0cdc4fa3e8ae006fa29ed66 | Unexpected config error when a default config file is empty
## π Bug report
If at least one `default_config_files` is set and this file is empty, a `TypeError: Unexpected config: ` is triggered on `parser.parse_args()`. Even if no argument is mandatory.
### To reproduce
```python
from jsonargparse import Arg... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 46cd745..eccf4d3 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -26,6 +26,9 @@ Fixed
<https://github.com/omni-us/jsonargparse/issues/362>`__).
- ``ActionJsonSchema`` not setting correctly defaults when schema uses
``oneOf``.
+- Recommended ``print_config`` step... |
omni-us__jsonargparse-378 | [
{
"changes": {
"added_entities": [
"jsonargparse/_common.py:is_generic_class",
"jsonargparse/_common.py:get_generic_origin"
],
"added_modules": [
"jsonargparse/_common.py:is_generic_class",
"jsonargparse/_common.py:get_generic_origin"
],
"edited_enti... | omni-us/jsonargparse | 5da03814831aa00fb849887dccd38284eb76030e | Support for generic dataclasses
## π Feature request
Add support for generic dataclasses in `ArgumentParser`.
### Motivation
I often use generic dataclasses as configuration objects in libraries code. When building a CLI application, I would like to reuse these configurations to build a specialized parser.
C... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 3e4a477..7958e8f 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -15,6 +15,11 @@ paths are considered internals and can change in minor and patch releases.
v4.25.0 (2023-09-??)
--------------------
+Added
+^^^^^
+- Support for user-defined generic types (`#366
+ <... |
omni-us__jsonargparse-381 | [
{
"changes": {
"added_entities": [
"jsonargparse/_actions.py:_ActionPrintConfig.is_print_config_requested"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"jsonargparse/_actions.py:_ActionPrintConfig"
]
},
"file": "jsonargparse/_... | omni-us/jsonargparse | 584dca0743750bdf37b1a5a373906ad32c5b790d | Improve the error message when a link function fails
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Feature request
When a link function fails, the error message should give a hint that the error happened when trying to apply a link function.
### Motivation
... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 637df72..a27be8a 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -15,11 +15,19 @@ paths are considered internals and can change in minor and patch releases.
v4.25.0 (2023-09-??)
--------------------
+Fixed
+^^^^^
+- ``--print_config`` fails when parser has shallow ... |
omni-us__jsonargparse-397 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_core.py:ArgumentParser._load_config_parser_mode",
"jsonargparse/_core.py:ArgumentParser.get_defaults"
],
"edited_modules": [
"jsonargparse/_core.py:ArgumentPars... | omni-us/jsonargparse | 863be75d91728f350cb7aa76b1ce139eecf225d7 | Repeated Keys in Nested List
This was my first day trying out this module
I notice that repeated key names may lead to undesirable results. Even if they are separated by level
I have given out some examples I tested out. It really only causes issues for two of them
| diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 81acd96..79e1c54 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.25.1 (2023-10-??)
+---------------... |
omni-us__jsonargparse-399 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_link_arguments.py:ActionLink.__init__",
"jsonargparse/_link_arguments.py:ActionLink.set_target_value"
],
"edited_modules": [
"jsonargparse/_link_arguments.py:Ac... | omni-us/jsonargparse | dd0f9e3767fcf2168c183bb346db9d7324bf7c28 | Question: How to link arguments where target is a list member
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
I'm using PyTorch Lightning and LightningCLI. I have a .yaml specifying a list of trainer callbacks:
```
# trainer.yaml
callbacks:
- class_path: EarlyStoppi... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 79e1c54..ee689ed 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,9 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
-v4.25.1 (2023-10-??)
+v4.26.0 (2023-1... |
omni-us__jsonargparse-405 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_core.py:ArgumentParser._check_value_key"
],
"edited_modules": [
"jsonargparse/_core.py:ArgumentParser"
]
},
"file": "jsonargparse/_core.py"
}
] | omni-us/jsonargparse | 5fc835701e52e864c497806b92ce217f9eb56ed5 | Failure to check choice matches for options when using a configuration yaml or json file.
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
<!-- A clear and concise description of the bug. -->
Using a config file (yaml or json) skips the choice validati... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 2bfec93..6550d69 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -27,6 +27,8 @@ Fixed
- Failures with subcommands and default_config_files when keys are repeated
(`#160 <https://github.com/omni-us/jsonargparse/issues/160>`__).
- Key related errors printing message... |
omni-us__jsonargparse-412 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "jsonargparse/_common.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse... | omni-us/jsonargparse | b571fc1ad8da6016b8bcfe216524eddaf16fb470 | Unable to correctly link two deep level arguments sharing the same root class
I've been working on trying to make this code function in a clean and logical manner, but despite multiple attempts, I'm uncertain whether it's feasible or not, and could not find a similar example online.
I've come across a few issues relat... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 18b805f..b9ee514 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -20,6 +20,8 @@ Fixed
- Failure to parse subclass added via add_argument and required arg as link
target.
- ``choices`` working incorrectly when ``nargs`` is ``+``, ``*`` or number.
+- Unable link two... |
omni-us__jsonargparse-424 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_signatures.py:SignatureArguments._add_signature_arguments",
"jsonargparse/_signatures.py:SignatureArguments._add_signature_parameter"
],
"edited_modules": [
"js... | omni-us/jsonargparse | f84ac2ed3cea1a30b22a5dc15804531c3378693a | Unable to specify a path for a callable parameter of a class
## π Bug report
When define a parameter of a class to be callable type, it is unable to specify a path for this parameter.
### To reproduce
```python
from collections.abc import Callable
from jsonargparse import ArgumentParser
class B:
def... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 4b32e06..9482571 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -20,6 +20,8 @@ Fixed
- Confusing error message when adding signature parameters that conflict with
existing arguments.
- Deprecation warnings not printing the correct file and line of code.
+- ``sub_... |
omni-us__jsonargparse-434 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:ActionTypeHint.is_subclass_typehint"
],
"edited_modules": [
"jsonargparse/_typehints.py:ActionTypeHint"
]
},
"file": "jsonargparse/_typehints... | omni-us/jsonargparse | a9fc1cd60393450eb0a5dd01a25cf29bf3784073 | Issue with argument linking to list of subclass objects
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
I started using the (very cool) feature of linking an argument to a list of subclass objects, as shown in the [documentation](https://jsonargparse.readthedocs.io/en/v4.... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index ca42753..8eb3936 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.27.3 (2024-01-??)
+---------------... |
omni-us__jsonargparse-448 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints",
"jsonargparse/_typehints.py:serialize_class_instance"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints",
... | omni-us/jsonargparse | fe8bc4bb8f69f00d0405d3155980db7051c8c2f8 | CLI fails with `torch.dtype` arguments
## π Bug report
The CLI seems to not be able to handle `torch.dtype` arguments; pretty important for torchvision [ToDtype](https://pytorch.org/vision/main/generated/torchvision.transforms.v2.ToDtype.html?highlight=todtype#torchvision.transforms.v2.ToDtype) transform.
### To... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index a0c825b..391f8eb 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.27.5 (2024-02-??)
+---------------... |
omni-us__jsonargparse-468 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_signatures.py:SignatureArguments._add_signature_arguments",
"jsonargparse/_signatures.py:SignatureArguments._add_signature_parameter"
],
"edited_modules": [
"js... | omni-us/jsonargparse | bca15889489e5f57ad89659da356ecaad4bf09c0 | Dynamic selection of function given an argument fails with an `AttributeError`
## π Bug report
I am trying to setup a CLI system where I have a multitude of subcommands (only 1 in the repro code, `finetune`) and some of them take a `--method` argument that allows selecting a different function.
See https://git... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index b6bc59b..99d9f6a 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -26,6 +26,8 @@ Fixed
produces an invalid string default.
- dataclass single parameter change incorrectly resetting previous values (`#464
<https://github.com/omni-us/jsonargparse/issues/464>`__).
+... |
omni-us__jsonargparse-471 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints"
]
},
"file": "jsonargparse/_typehints.py"
}
] | omni-us/jsonargparse | 14456c21ff7a11ba420f010d2b21bcfdb14977a2 | Overriding a config's argument makes everything else fall back to the base class
## π Bug report
### To reproduce
`repro.py`:
```python
from dataclasses import dataclass
from typing import Optional
@dataclass
class Thing:
foo: int = 1
bar: int = 2
def fn(thing: Optional[Thing] = None):
... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 87a789b..b6bc59b 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -24,6 +24,8 @@ Fixed
<https://github.com/omni-us/jsonargparse/issues/465>`__).
- Optional callable that returns a class instance with a lambda default,
produces an invalid string default.
+- datacl... |
omni-us__jsonargparse-476 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:get_subclass_types"
],
"edited_modules": [
"jsonargparse/_typehints.py:get_subclass_types"
]
},
"file": "jsonargparse/_typehints.py"
}
] | omni-us/jsonargparse | bb83fdc76546743ad0e4e7012715febd965f34ac | `lazy_instance` no longer accepts arguments that go into kwargs
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
The last release of jsonargparse 4.27.6 made our CI fail. We have a test that does the following:
### To reproduce
```
pip install ... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index bdded86..fd6d23f 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,18 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.27.7 (2024-03-??)
+---------------... |
omni-us__jsonargparse-494 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints"
]
},
"file": "jsonargparse/_typehints.py"
},
{
"... | omni-us/jsonargparse | af37f088f257a184f1f9e77812539d8a2e584276 | Support of `TypedDict`s
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
Hi,
Thanks for this great library! Extremely useful!!
## π Feature request
<!-- A clear and concise description of the feature proposal. -->
The idea here would be to support arguments with ty... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 2e9eedc..9d729d7 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.29.0 (2024-04-??)
+---------------... |
omni-us__jsonargparse-502 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "jsonargparse/_common.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse... | omni-us/jsonargparse | 6d4f87bb9b2f9f148d5c2215938d213a9e959f08 | `format_usage()` doesn't work on captured parser
## π Bug report
<!-- A clear and concise description of the bug. -->
`jsonargparse.capture_parser(main).format_usage()` fails with
`LookupError: <ContextVar name='parent_parser' at 0x7f0859cb54e0>`
### To reproduce
```
import jsonargparse
def fun(a: int)... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 429e533..a88cb63 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -23,9 +23,11 @@ Added
Fixed
^^^^^
- Parameter resolving falling back to assumptions resolver for optional
- ``Union`` types.
+ ``Union`` types (`#498 <https://github.com/omni-us/jsonargparse/pull/498... |
omni-us__jsonargparse-508 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:ActionTypeHint.normalize_default",
"jsonargparse/_typehints.py:adapt_typehints"
],
"edited_modules": [
"jsonargparse/_typehints.py:ActionTypeHint",... | omni-us/jsonargparse | ef1a26791cd5a924db2b1721dc904fc3f65591aa | Cannot use optional dataclasses defaulting to not-null in the configuration hierarchy
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
Cannot use optional dataclasses defaulting to not-null in the configuration hierarchy.
### To reproduce
Run scri... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index ef6e802..0f4d636 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -36,6 +36,8 @@ Fixed
- Nested values not validated when type not subclass and nested keys for
subclass (`#503 comment
<https://github.com/omni-us/jsonargparse/issues/503#issuecomment-2119724341>`__... |
omni-us__jsonargparse-518 | [
{
"changes": {
"added_entities": [
"jsonargparse/_typehints.py:is_pathlike"
],
"added_modules": [
"jsonargparse/_typehints.py:is_pathlike"
],
"edited_entities": [
"jsonargparse/_typehints.py:ActionTypeHint.__init__"
],
"edited_modules": [
... | omni-us/jsonargparse | 5e627a20d5432c76ecd704ff04070f806df27a1f | jsonargparse._util._parse_value_or_config
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
I'm using LightningCLI, and not sure if this is due to Lightning or jsonargparse, but...
Specifying the value of a variable as the path to a `.csv` file loads... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 5172ae0..1f93c04 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -23,6 +23,12 @@ Added
(`lightning#13613
<https://github.com/Lightning-AI/pytorch-lightning/discussions/13613>`__)
+Fixed
+^^^^^
+- Parsing incorrectly provides file content when type is a union wi... |
omni-us__jsonargparse-522 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_actions.py:_ActionHelpClassPath.update_init_kwargs"
],
"edited_modules": [
"jsonargparse/_actions.py:_ActionHelpClassPath"
]
},
"file": "jsonargparse/_act... | omni-us/jsonargparse | 1dd26644dc50e2ee748e7ccd23b48a3a2042fda3 | In python 3.11, add_subclass_arguments with list[Class] is not working.
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
Hi all, I'm working on a project that utilizes this great library.
However, I ran into a problem with python 3.11.
```yaml
sche... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 16db672..7245b9e 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -34,6 +34,9 @@ Fixed
(`#523 <https://github.com/omni-us/jsonargparse/pull/523>`__).
- Failing to parse list of dataclasses with nested optional dataclass (`#527
<https://github.com/omni-us/jsonargp... |
omni-us__jsonargparse-527 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_signatures.py:SignatureArguments.add_class_arguments"
],
"edited_modules": [
"jsonargparse/_signatures.py:SignatureArguments"
]
},
"file": "jsonargparse/_... | omni-us/jsonargparse | 3a3c6a0ebfc18901d80c862040deda2d03a81f9d | Cannot parse a list of dataclasses with optional dataclass member
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
I am getting an when parsing a list of `dataclass` objects, where the `dataclass` has an optional member which is another `dataclass`.
... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 232e5aa..16db672 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -32,6 +32,8 @@ Fixed
<https://github.com/omni-us/jsonargparse/issues/517>`__).
- Callable that returns class not using required parameter default from lambda
(`#523 <https://github.com/omni-us/json... |
omni-us__jsonargparse-531 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_cli.py:CLI",
"jsonargparse/_cli.py:_run_component"
],
"edited_modules": [
"jsonargparse/_cli.py:CLI",
"jsonargparse/_cli.py:_run_component"
]
... | omni-us/jsonargparse | 0a4de3112f3ac39d627ca2e7c59014e5f3b3f521 | Add support for async objects in `CLI`
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Feature request
Add support for objects that require asynchronous context for their creation.
### Motivation
Currently I cannot instantiate objects like `aiokafka.AIOKafk... | diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index ecd0090..015027e 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -6,7 +6,7 @@ on:
pull_request:
branches: [ "main" ]
schedule:
- - cron: "57 5 * * 3"
+ - cron: "57 5 * * 3" # M H d m w (Every... |
omni-us__jsonargparse-535 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_util.py:get_import_path"
],
"edited_modules": [
"jsonargparse/_util.py:get_import_path"
]
},
"file": "jsonargparse/_util.py"
}
] | omni-us/jsonargparse | 2bcbd48b2c2de85180b81cd9de8c0b985d49442f | Cannot correctly parse some import paths when using config file for LightningCLI
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
I would like to use CLI with config.yaml file to manage my project. But I found some classes in TorchAudio cannot be correc... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 46a65d7..207108c 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -15,6 +15,11 @@ paths are considered internals and can change in minor and patch releases.
v4.31.0 (2024-06-??)
--------------------
+Fixed
+^^^^^
+- Resolving of import paths for some ``torch`` funct... |
omni-us__jsonargparse-540 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints"
]
},
"file": "jsonargparse/_typehints.py"
}
] | omni-us/jsonargparse | 9feda6f8951b17a7abc32b74d39dcb2f238afecd | `MappingProxyType` not accepted as `Mapping`
## π Bug report
Using a [`MappingProxyType`](https://docs.python.org/3/library/types.html#types.MappingProxyType) as a read only default value for a `Mapping` parameter fails with
```
Expected a <class 'collections.abc.Mapping'>. Got value: {'parameter': 1}
```
#... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 99a4845..dcb418c 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.32.0 (2024-07-??)
+---------------... |
omni-us__jsonargparse-559 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints"
]
},
"file": "jsonargparse/_typehints.py"
}
] | omni-us/jsonargparse | 74c169b6feb07808f41f65da069870e1e0db0203 | Cannot parse pydantic BaseModel as dict value since version4.29
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
### To reproduce
1. Using the CLI function
The code as follows can work normally in version 4.28, but fails in versions 4.29/4.30/4.... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index eeeff79..e531ed7 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.32.1 (2024-08-??)
+---------------... |
omni-us__jsonargparse-56 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/actions.py:_ActionPrintConfig.__init__",
"jsonargparse/actions.py:_ActionPrintConfig.__call__"
],
"edited_modules": [
"jsonargparse/actions.py:_ActionPrintConfig... | omni-us/jsonargparse | d0577d200ba3e37f04a9815d4a9736016d5e0016 | [Feature request] Add arguments description as comments in print_config output
Hello and thank you for the great library !
### Feature request
The `--print_config` feature is useful but limited: this would be great if there was a way to print a config file in YAML format containing comments to describe the argument... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 0457565..b668dce 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -17,6 +17,7 @@ Added
^^^^^
- Path support for fsspec file systems using the 's' mode flag.
- set_config_read_mode function that can enable fsspec for config reading.
+- Option for print_config and dump... |
omni-us__jsonargparse-560 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints"
]
},
"file": "jsonargparse/_typehints.py"
}
] | omni-us/jsonargparse | c634a88f120b96d87f80e079417f0138aabe466f | Appending to dataclass list uses last item as defaults
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
When the type of an argument is list of dataclass instances, the first item in the list uses the dataclass's defaults as expected, but appending furt... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index e531ed7..7fc944c 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -19,6 +19,8 @@ Fixed
^^^^^
- ``dict`` types not correctly forwarding previous nested values when parsing
(`#559 <https://github.com/omni-us/jsonargparse/pull/559>`__).
+- ``List`` type incorrectly us... |
omni-us__jsonargparse-562 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_completions.py:shtab_prepare_action"
],
"edited_modules": [
"jsonargparse/_completions.py:shtab_prepare_action"
]
},
"file": "jsonargparse/_completions.py... | omni-us/jsonargparse | f7aa49f434115f721a16a373c598d5fb9aaa2d5f | Shtab complete: the action.complete of Classes, methods and functions should be `shtab.FILE`
## π Bug report
Currently, the `action.complete` for `shtab` is `FILE` only when it is `ActionConfigFile` or `Pathlike` for `ActionTypeHint`, however, these doesn't cover the action of `_ActionConfigLoad`.
https://github... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 7fc944c..28d4c38 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -21,6 +21,8 @@ Fixed
(`#559 <https://github.com/omni-us/jsonargparse/pull/559>`__).
- ``List`` type incorrectly using defaults from previous item (`#560
<https://github.com/omni-us/jsonargparse/pul... |
omni-us__jsonargparse-564 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:ActionTypeHint.get_class_parser"
],
"edited_modules": [
"jsonargparse/_typehints.py:ActionTypeHint"
]
},
"file": "jsonargparse/_typehints.py"... | omni-us/jsonargparse | 54ff57e6f22c3502fc478238714e8b8ba646fe01 | Parser mode is not inherited by subparsers when adapting typehints
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
The parsing mode is not passed to subparsers created in [`ActionTypeHint.get_class_parser`](https://github.com/omni-us/jsonargparse/blob/... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 28d4c38..614018b 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -23,6 +23,8 @@ Fixed
<https://github.com/omni-us/jsonargparse/pull/560>`__).
- ``--print_shtab`` not adding file completer for ``_ActionConfigLoad`` (`#562
<https://github.com/omni-us/jsonargparse/... |
omni-us__jsonargparse-567 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_actions.py:_ActionHelpClassPath.__init__",
"jsonargparse/_actions.py:_ActionHelpClassPath.update_init_kwargs",
"jsonargparse/_actions.py:_ActionHelpClassPath.__call__",
... | omni-us/jsonargparse | e5ff8bcf25181c51b4082d8a46778308ccac2df0 | Help docstring for Callable does not work as intended
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
When using a `Callable` argument that returns one class out of a union of classes, the help string does not show the docstring of the classes. This bug has been mentioned... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 16f3d81..b9ab9ff 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.32.2 (2024-09-??)
+---------------... |
omni-us__jsonargparse-576 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_postponed_annotations.py:resolve_forward_refs",
"jsonargparse/_postponed_annotations.py:has_subtypes"
],
"edited_modules": [
"jsonargparse/_postponed_annotation... | omni-us/jsonargparse | 1bab38ae7a5fe281c62fe784fc620bbbf259f2e8 | Parsing `TYPE_CHECKING` guarded import doesn't work in combination with `Type`
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
When using the `Type` annotation in conjunction with a `TYPE_CHECKING` guarded import, e.g.
```python
from typing import ... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index e0773fa..3aef282 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -27,6 +27,9 @@ Fixed
- Callable type with subclass return not showing the ``--*.help`` option (`#567
<https://github.com/omni-us/jsonargparse/pull/567>`__).
+- Forward referenced types not compatibl... |
omni-us__jsonargparse-581 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_core.py:ArgumentParser._parse_common",
"jsonargparse/_core.py:ArgumentParser.add_subcommands",
"jsonargparse/_core.py:ArgumentParser.check_config",
"jsonargparse/_c... | omni-us/jsonargparse | 80a5418f5785ae6a0ab17357305b8935ae091008 | Parsing fails with mixture of classes and dataclasses
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
<!-- A clear and concise description of the bug. -->
Validation fails when there is a union of dataclass and regular classes.
### To reproduce (... | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 9ebc945..4a13a54 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -56,6 +56,7 @@ repos:
[
types-PyYAML,
types-requests,
+ types-setuptools,
]
verbose: true
diff --git a/CHANGELOG.rst b... |
omni-us__jsonargparse-592 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints"
]
},
"file": "jsonargparse/_typehints.py"
}
] | omni-us/jsonargparse | 42d7a5c2139583bf8cec1aa79e6afe788f878385 | Empty tuple default value not supported
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
Empty tuples are not supported by the parser.
### To reproduce
```
from dataclasses import dataclass
from jsonargparse import ArgumentParser
@datacla... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index b39e037..ade9d05 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,15 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.33.3 (2024-10-??)
+---------------... |
omni-us__jsonargparse-603 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_core.py:ArgumentParser.merge_config"
],
"edited_modules": [
"jsonargparse/_core.py:ArgumentParser"
]
},
"file": "jsonargparse/_core.py"
},
{
"chan... | omni-us/jsonargparse | 0c7839bcf9f5bee0246642b73c724083006b9a6c | [Question] Is it possible to change the init_args of list elements with giving ActionConfigFile
This is a minimal reproduction. If I have this Python code which implements `jsonargparse.ArgumentParser`
```python
# test.py
from lightning.pytorch.cli import LRSchedulerCallable, ReduceLROnPlateau
from jsonargparse... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 9d94c57..c5db0c5 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -27,6 +27,14 @@ Fixed
- Required and optional ``TypedDict`` keys are now correctly inferred when one
inherits one ``TypedDict`` from another with different totality (`#597
<https://github.com/omni-... |
omni-us__jsonargparse-625 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_core.py:ArgumentParser.parse_object",
"jsonargparse/_core.py:ArgumentParser.merge_config",
"jsonargparse/_core.py:ArgumentParser.default_env"
],
"edited_modules... | omni-us/jsonargparse | 150caf8157fa5fb2e5e30045353784f90853ad69 | Parsing to a list of dataclasses with nested dataclass fails
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
Parsing a configuration to a list of dataclasses which contain nested dataclass fails.
### To reproduce
Run following code:
```python... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 739f9b0..fee10a5 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -12,6 +12,17 @@ The semantic versioning only considers the public API as described in
paths are considered internals and can change in minor and patch releases.
+v4.34.1 (2024-11-??)
+---------------... |
omni-us__jsonargparse-637 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jsonargparse/_typehints.py:adapt_typehints",
"jsonargparse/_typehints.py:implements_protocol"
],
"edited_modules": [
"jsonargparse/_typehints.py:adapt_typehints",
"js... | omni-us/jsonargparse | 0ccac3ad07e0c9d555177b67d770bc3dad70b675 | Callable protocols not being parsed correctly
<!-- If you like this project, please β star it https://github.com/omni-us/jsonargparse/ -->
## π Bug report
Even though bugs related with calling protocol inheritance were resolved in this [PR](https://github.com/omni-us/jsonargparse/pull/599) it seem there are stil... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index fee10a5..b828de2 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -21,6 +21,8 @@ Fixed
<https://github.com/omni-us/jsonargparse/pull/625>`__).
- ``NotRequired`` incorrectly having ``inspect._empty`` as default (`#625
<https://github.com/omni-us/jsonargparse/pull/... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.