instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
zopefoundation__DateTime-61 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/DateTime/DateTime.py:DateTime.greaterThan",
"src/DateTime/DateTime.py:DateTime.greaterThanEqualTo",
"src/DateTime/DateTime.py:DateTime.equalTo",
"src/DateTime/DateTime.py:Dat... | zopefoundation/DateTime | 955f3b920b2020c2407e7d9f4aa24e6ef7d20d9d | `DateTime.DateTime.equalTo` now breaks with string argument
## BUG/PROBLEM REPORT / FEATURE REQUEST
Since DateTime 5.2, using `DateTime.DateTime.equalTo` with something else than a `DateTime` or a number throws `AttributeError`. This is a regression from https://github.com/zopefoundation/DateTime/pull/54 ( cc @fdia... | diff --git a/CHANGES.rst b/CHANGES.rst
index 3ee820c..082d109 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,9 @@ Changelog
- Fix ``UnknownTimeZoneError`` when unpickling ``DateTime.DateTime().asdatetime()``.
(`#58 <https://github.com/zopefoundation/DateTime/issues/58>`_)
+- Repair equality comparison betw... |
zopefoundation__DateTime-62 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/DateTime/DateTime.py:DateTime.__getstate__",
"src/DateTime/DateTime.py:DateTime.__setstate__"
],
"edited_modules": [
"src/DateTime/DateTime.py:DateTime"
]
},
... | zopefoundation/DateTime | e892a9d360abba6e8abe1c4a7e48f52efa9c1e72 | tests fail in 2038
## BUG/PROBLEM REPORT / FEATURE REQUEST
<!--
Please do not report security-related issues here. Report them by email to security@plone.org. The Security Team will contact the relevant maintainer if necessary.
Include tracebacks, screenshots, code of debugging sessions or code that reproduces... | diff --git a/CHANGES.rst b/CHANGES.rst
index b483525..e9e31d1 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -6,6 +6,10 @@ Changelog
- Nothing changed yet.
+- Change pickle format to export the microseconds as an int, to
+ solve a problem with dates after 2038.
+ (`#56 <https://github.com/zopefoundation/DateTime/... |
zopefoundation__DocumentTemplate-18 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/DocumentTemplate/DT_In.py:InClass.sort_sequence"
],
"edited_modules": [
"src/DocumentTemplate/DT_In.py:InClass"
]
},
"file": "src/DocumentTemplate/DT_In.py"
},
... | zopefoundation/DocumentTemplate | 6af41a0957407a40e02210926c63810d7bbe53ff | <dtml-in list_of_dicts mapping sort=name> breaks for duplicate names
Scenario:
```python
list_of_dicts = [{'name': 'a'}, {'name': 'b'}, {'name': 'a'}]
```
In DTML call:
```
<dtml-in list_of_dicts mapping sort=name>
```
It breaks because internally `dtml-in` changes the list to
```python
[('a', {'nam... | diff --git a/CHANGES.rst b/CHANGES.rst
index 18c8924..209e47d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,8 @@ Changelog
- No longer use icons which got deleted in Zope 4.
+- Fix sorting in <dtml-in> for duplicate entries in Python 3.
+
3.0b2 (2017-11-03)
------------------
diff --git a/src/DocumentT... |
zopefoundation__DocumentTemplate-29 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/DocumentTemplate/DT_String.py:String.parse",
"src/DocumentTemplate/DT_String.py:String.parse_block",
"src/DocumentTemplate/DT_String.py:String.parse_close"
],
"edited_mod... | zopefoundation/DocumentTemplate | 44015836dbbea9670ca44a2152d3f10a16512bfb | <dtml-except> breaks on Python 2
Traceback:
```python
src/Zope/src/App/special_dtml.py:203: in _exec
result = render_blocks(self._v_blocks, ns)
.../DocumentTemplate-3.0b4-py2.7.egg/DocumentTemplate/_DocumentTemplate.py:148: in render_blocks
render_blocks_(blocks, rendered, md)
.../DocumentTemplate-3.0b4-p... | diff --git a/CHANGES.rst b/CHANGES.rst
index 570eeab..86e2a22 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,10 +4,21 @@ Changelog
3.0b5 (unreleased)
------------------
+- Fix regression with exception handling in ``<dtml-except>`` with Python 2.
+ (`#25 <https://github.com/zopefoundation/DocumentTemplate/issues... |
zopefoundation__DocumentTemplate-40 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/DocumentTemplate/_DocumentTemplate.py:InstanceDict.__getitem__"
],
"edited_modules": [
"src/DocumentTemplate/_DocumentTemplate.py:InstanceDict"
]
},
"file": "src/Do... | zopefoundation/DocumentTemplate | 4ff3d6e91d933794306a915ef6088ed7d724989b | Changed behavior in acquisition
When trying to port a Zope installation from Zope2 to Zope4, I encountered an error where I am not sure if the behavior is intended and was broken in Zope2 or if it is a regression.
I could reproduce the problematic behavior with DTML Method, DTML Document as well as Z SQL Methods.
... | diff --git a/CHANGES.rst b/CHANGES.rst
index 9bd0e39..5845a28 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,9 @@ Changelog
3.0b6 (unreleased)
------------------
-- Nothing changed yet.
+- Fix regression in ``.DT_Util.InstanceDict`` which broke the acquisition
+ chain of the item it wraps.
+ (`#38 <https:/... |
zopefoundation__DocumentTemplate-49 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/DocumentTemplate/DT_Var.py:bytes_sql_quote",
"src/DocumentTemplate/DT_Var.py:text_sql_quote"
],
"edited_modules": [
"src/DocumentTemplate/DT_Var.py:bytes_sql_quote",
... | zopefoundation/DocumentTemplate | 0982d86726ae3a39949f0565059e93ea697e8fd9 | Error in ZSQLMethod with json fields
In latest version of DocumentTemplate and ZSQLMethod symbol '"' is escaping in dtml-sqlvar statement. And it produce errors in ZSQLMethod with json string in <dtml-sqlvar ... type=string> as a value for field type json.
For example, create ZSQLMethod with one argument named "arg" a... | diff --git a/CHANGES.rst b/CHANGES.rst
index f596197..78d0a26 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,11 @@ Changelog
3.2 (unreleased)
----------------
+- no longer escape double quotes in ``sql_quote`` - that breaks PostgreSQL
+ (`#48 <https://github.com/zopefoundation/DocumentTemplate/issues/48>`_)... |
zopefoundation__DocumentTemplate-55 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/DocumentTemplate/DT_Var.py:bytes_sql_quote",
"src/DocumentTemplate/DT_Var.py:text_sql_quote",
"src/DocumentTemplate/DT_Var.py:sql_quote"
],
"edited_modules": [
"s... | zopefoundation/DocumentTemplate | 03bac32bfffd599bb2d6344163365fa20ff8284f | bytes_sql_quote() returns Bytes, although the content will be part of an SQL query String
In `DocumentTemplate/DT_Var.py`, the helper function `bytes_sql_quote()` is used to remove dangerous content from Bytes when used in SQL queries (edited after correction from @dataflake).
Because this escaped content is returne... | diff --git a/CHANGES.rst b/CHANGES.rst
index d7ab0d5..4646d49 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@ Changelog
3.3 (unreleased)
----------------
+- Restore ``sql_quote`` behavior of always returning native strings
+ (`#54 <https://github.com/zopefoundation/DocumentTemplate/issues/54>`_)
+
3.... |
zopefoundation__Products.BTreeFolder2-13 | [
{
"changes": {
"added_entities": [
"src/Products/BTreeFolder2/BTreeFolder2.py:BTreeFolder2Base.manage_delAllObjects"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/Products/BTreeFolder2/BTreeFolder2.py:BTreeFolder2Base"
]
},
... | zopefoundation/Products.BTreeFolder2 | 016a4eaf465fc7354ce70273620c52b951746def | `Delete all` button
I'd like to have a `Delete all` button at the contents view.
Current use case:
I have to delete all instances of certain btree folders before giving my ZODB to our consultant for GDPR reasons.
Those folders contain lots of instances, which means I have to click `Select all` and `Delete` (whic... | diff --git a/CHANGES.rst b/CHANGES.rst
index 3af34f1..886af29 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,9 @@ Changelog
- Modernize the ZMI template to match the Zope 4 styles
(`#10 <https://github.com/zopefoundation/Products.BTreeFolder2/issues/10>`_)
+- Add ``Delete All Objects`` button to the manage... |
zopefoundation__Products.CMFCore-110 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/CMFCore/Skinnable.py:SkinnableObjectManager.getSkinNameFromRequest"
],
"edited_modules": [
"src/Products/CMFCore/Skinnable.py:SkinnableObjectManager"
]
},
... | zopefoundation/Products.CMFCore | d373299ff3732b37b44a456ff39e2312f2e1d832 | Skinnable method `getSkinNameFromRequest` returns arbitrary values
The `getSkinNameFromRequest` method on the `SkinnableObjectManager` class, which is a base class for the main Portal object in both CMFDefault and CMFPlone, will blindly return any value for skin name if it's fed in via e.g. query string. It doesn't app... | diff --git a/CHANGES.rst b/CHANGES.rst
index ce408bc..1bff259 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@ Products.CMFCore Changelog
2.5.1 (unreleased)
------------------
+- Make sure ``getSkinNameFromRequest`` only returns sane values
+ (`#109 <https://github.com/zopefoundation/Products.CMFCore/iss... |
zopefoundation__Products.CMFCore-143 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/CMFCore/CMFCatalogAware.py:CatalogAware.reindexObjectSecurity"
],
"edited_modules": [
"src/Products/CMFCore/CMFCatalogAware.py:CatalogAware"
]
},
"file": "... | zopefoundation/Products.CMFCore | de9c29eb387c1d1e896519f1bf09bf6f1437b87f | reindexObjectSecurity missing update_metadata parameter (has the effect of full reindex)
## BUG/PROBLEM REPORT
When adding or removing a local role on a section to a user, a full reindex of all the objects in that section takes place, instead of reindexing only the `allowedRolesAndUsers`. This is because the `update... | diff --git a/CHANGES.rst b/CHANGES.rst
index 4dab6fe..858a776 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,7 @@ Products.CMFCore Changelog
----------------
- Drop support for Python 3.7.
+- Fix reindexObjectSecurity to avoid a full reindex of affected objects
3.5 (2024-03-23)
diff --git a/src/Products... |
zopefoundation__Products.GenericSetup-102 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/GenericSetup/context.py:SnapshotExportContext.writeDataFile",
"src/Products/GenericSetup/context.py:SnapshotExportContext._ensureSnapshotsFolder"
],
"edited_modules": [
... | zopefoundation/Products.GenericSetup | 6b2d75c311d10072652164a932031a8a0c3c45b4 | Log file objects accessible to anonyone with View permission on the tool's container
Log file objects stored in Generic Setup Tool instances (and the tool instances themselves) don't have any specific permission settings applied, they just acquire all settings from their container. If anonymous users have e.g. `View` p... | diff --git a/CHANGES.rst b/CHANGES.rst
index 79b05a2..cc2aad0 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,8 @@ Changelog
2.1.1 (unreleased)
------------------
-- Nothing changed yet.
+- Enforce access control on setup tool log files and snapshot files and folders.
+ (`#101 <https://github.com/zopefoundat... |
zopefoundation__Products.GenericSetup-108 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/GenericSetup/content.py:FolderishExporterImporter.import_",
"src/Products/GenericSetup/content.py:CSVAwareFileAdapter.import_",
"src/Products/GenericSetup/content.py:SimpleI... | zopefoundation/Products.GenericSetup | 3544a86f8674969b0a7c0c84e37cb2a4279b8a4c | snapshot comparison broken in Plone 5.2 - Python 3
Run an instance of Plone 5.2 in a Python 3
When you run a snapshot comparison in ZMI - portal_setup you get an error
Seems related to the str - bytes change in python 3, code is expecting bytes, but getting str
example buildout.cfg:
~~~
[buildout]
parts = instanc... | diff --git a/CHANGES.rst b/CHANGES.rst
index b88e9e8..9b97548 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,12 @@ Changelog
2.1.2 (unreleased)
------------------
+- Document and fix behavior of methods that open/read/write filesystem files
+ (`#107 <https://github.com/zopefoundation/Products.GenericSetup/i... |
zopefoundation__Products.GenericSetup-127 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/GenericSetup/upgrade.py:normalize_version"
],
"edited_modules": [
"src/Products/GenericSetup/upgrade.py:normalize_version"
]
},
"file": "src/Products/Gener... | zopefoundation/Products.GenericSetup | 96b5bfe10c1d97d53b1276324ab987a66d40bf30 | Tests are broken
### What I did:
I looked at the test runs in GHA.
e. g. https://github.com/zopefoundation/Products.GenericSetup/actions/runs/4274869009/jobs/7441795588
### What I expect to happen:
Green tests.
### What actually happened:
Tests are broken probably due to changes in newer setuptools vers... | diff --git a/CHANGES.rst b/CHANGES.rst
index 276a65c..c739d53 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@ Changelog
3.0.1 (unreleased)
------------------
+- Fix 126: Handle legacy versions in upgrades also with setuptools 66 or higher.
+ (`#126 <https://github.com/zopefoundation/Products.GenericSetu... |
zopefoundation__Products.MailHost-32 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": [
"src/Products/MailHost/MailHost.py:as_bytes",
"src/Products/MailHost/MailHost.py... | zopefoundation/Products.MailHost | e848f00e922ebded3eec35a8a345cbfd31068cdd | UTF-8 encoded mails are not sent
According to the documentation in `smptlib.sendmail`,
msg may be a string containing characters in the ASCII range, or a byte
string. A string is encoded to bytes using the ascii codec, and lone
\\r and \\n characters are converted to \\r\\n characters.
... | diff --git a/CHANGES.rst b/CHANGES.rst
index ff5b438..e6b9149 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,12 @@ Changelog
4.10 (unreleased)
-----------------
+- We depend on ``zope.sendmail >= 5.1``.
+
+- Support messages with explicit ``Content-Transfer-Encoding: 8bit``
+ (`#30 <https://github.com/zopef... |
zopefoundation__Products.MailHost-36 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/Products/MailHost/MailHost.py"
}
] | zopefoundation/Products.MailHost | b0611ba71eca6aa4d2f1bb48744b59e1f7522ec6 | quoted-printable soft line breaks not always correctly recognized
## BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
https://community.plone.org/t/plone-5-2-3-and-email-encoding-problem/13181
reports a problem which is likely a consequence of Python's quoted-printable implementation's use of `\n` rather than `\r\n` as lin... | diff --git a/CHANGES.rst b/CHANGES.rst
index 5f5d0a9..cf6d820 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@ Changelog
4.11 (unreleased)
-----------------
+- Use standard conforming ``\r\n`` line endings. This may require adaptations in testsSupport messages with line separation `\r\n`
+ (`#35 <https:/... |
zopefoundation__Products.PluggableAuthService-101 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/PluggableAuthService/PluggableAuthService.py:PluggableAuthService._setObject"
],
"edited_modules": [
"src/Products/PluggableAuthService/PluggableAuthService.py:Pluggable... | zopefoundation/Products.PluggableAuthService | 957872ce01ff86a880a8d77044ddfe7e6fc648f9 | Error when importing ZODB User Manager (zexp)
## BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
Importing a ZODB User Manager from zexp throws an error.
### What I did:
I tried to transfer a ZODB User Manager to another Zope instance using Zope's import/export functionality (zexp files). When I try to import, I get ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 1f00e81..49a8358 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,10 @@ Change Log
2.6.4 (unreleased)
------------------
+- Fix method signature of ``PluggableAuthService._setObject``
+ (`#95
+ <https://github.com/zopefoundation/Products.PluggableAuthService/issue... |
zopefoundation__Products.PluggableAuthService-106 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/PluggableAuthService/events.py:userCredentialsUpdatedHandler"
],
"edited_modules": [
"src/Products/PluggableAuthService/events.py:userCredentialsUpdatedHandler"
]
... | zopefoundation/Products.PluggableAuthService | 91dbe5352cb0b4be06c4ccff1ad0b321b168240c | Inconsistent usage of user id vs login/name in plugin method call signature
## BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
### What I did:
I was implementing the `Products.PluggableAuthService.interfaces.plugins.ICredentialsUpdatePlugin` interface for plugin. Specifically I was interpreting the arguments to the `... | diff --git a/CHANGES.rst b/CHANGES.rst
index 2dcac21..c76e86a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,10 @@ Change Log
2.6.5 (unreleased)
------------------
-- Nothing changed yet.
+- Pass the login name as ``updateCredentials``'s ``login`` parameter
+ (not the user id) (`#105
+ <https://github.com... |
zopefoundation__Products.PluggableAuthService-108 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/PluggableAuthService/__init__.py:manage_zmi_logout"
],
"edited_modules": [
"src/Products/PluggableAuthService/__init__.py:manage_zmi_logout"
]
},
"file": "... | zopefoundation/Products.PluggableAuthService | 2a678b5438c29ae16667bff4306824dda1eb08e8 | ZMI logout handler overrides challenge plugin configuration
## BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
### What I did:
In the Zope root `/acl_users`, I deactivated the `HTTPBasicAuthHelper` plugin for the `IChallengePlugin` interface and activated the `CookieAuthHelper` plugin for the `IChallengePlugin` interf... | diff --git a/CHANGES.rst b/CHANGES.rst
index 8a927d0..07285fa 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@ Change Log
2.6.5 (unreleased)
------------------
+- Improve the PAS override for Zope's ``manage_zmi_logout`` (`#107
+ <https://github.com/zopefoundation/Products.PluggableAuthService/issues/107... |
zopefoundation__Products.PluggableAuthService-60 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"Products/PluggableAuthService/events.py:userCredentialsUpdatedHandler"
],
"edited_modules": [
"Products/PluggableAuthService/events.py:userCredentialsUpdatedHandler"
]
},
... | zopefoundation/Products.PluggableAuthService | 5acf9460b732ebffae4ef69a68b17b2df774c228 | ICredentialsUpdatedEvent event handler incorrectly calls updateCredentials
*Products.PluggableAuthService.events.userCredentialsUpdatedHandler* calls updateCredentials explicitly passing the principal object.
```
@adapter(IBasicUser, ICredentialsUpdatedEvent)
def userCredentialsUpdatedHandler(principal, event):
... | diff --git a/CHANGES.rst b/CHANGES.rst
index a99cfed..2d282d5 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,12 +4,15 @@ Change Log
2.3 (unreleased)
----------------
+- Fix broken ICredentialsUpdatedEvent event handler call to updateCredentials.
+ (`#17 <https://github.com/zopefoundation/Products.PluggableAuthSe... |
zopefoundation__Products.Sessions-20 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/Transience/Transience.py:TransientObjectContainer.getTimeoutMinutes"
],
"edited_modules": [
"src/Products/Transience/Transience.py:TransientObjectContainer"
]
... | zopefoundation/Products.Sessions | 471680c425103a67d949f44b231a3ba96377c69a | getTimeoutMinutes() shall return an integer value?
https://github.com/zopefoundation/Products.Sessions/blob/a756218d05eb2403c252b89664f46157ac2f25b2/src/Products/Transience/Transience.py#L924
Hello,
now(?) _getTimeoutMinutes()_ provides a **float**-type, but the ZMI template
https://github.com/zopefoundation/Prod... | diff --git a/CHANGES.rst b/CHANGES.rst
index a4a65ef..bc00d6a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@ Changelog
4.3 (unreleased)
----------------
+- Make sure ``TransientObjectContainer.getTimeoutMinutes`` returns ints
+ (`#17 <https://github.com/zopefoundation/Products.Sessions/issues/17>`_)
+
... |
zopefoundation__Products.Sessions-44 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": [
"src/Products/Sessions/SessionDataManager.py:SessionDataManager.usesDefaultSessionDataCo... | zopefoundation/Products.Sessions | 6b4bc4c22695dddc333de4c2e8d1db2489aaf942 | Update documentation for fixed tempstorage
The `tempstorage` package now has a fixed release (5.2) for the data loss issue.
- [x] depend on `Products.TemporaryFolder >= 6.2`, which requires the fixed `tempstorage` release
- [x] update documentation and remove all warnings about data loss/safety issues | diff --git a/.meta.toml b/.meta.toml
index cfff89a..a1a79c0 100644
--- a/.meta.toml
+++ b/.meta.toml
@@ -15,7 +15,7 @@ with-future-python = false
use-flake8 = true
[coverage]
-fail-under = 89
+fail-under = 93
[isort]
known_first_party = "Products.Transience, Products.TemporaryFolder"
diff --git a/CHANGES.rst b/... |
zopefoundation__Products.SiteErrorLog-14 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/SiteErrorLog/SiteErrorLog.py:SiteErrorLog.getProperties"
],
"edited_modules": [
"src/Products/SiteErrorLog/SiteErrorLog.py:SiteErrorLog"
]
},
"file": "src/... | zopefoundation/Products.SiteErrorLog | 300a3bf9726035bc0a40bfbf434a6e0c5c21bed6 | Py3: ignored exception types gets converted to bytes and back accidentally
Thus adding a b'...' surrounding each time the page is saved. | diff --git a/CHANGES.rst b/CHANGES.rst
index 45d207d..7bc1f90 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -6,6 +6,9 @@ Changelog
- Flake8 the code.
+- Ignored exception types no longer accidentally get converted to bytes and back
+ on Python 3.
+ (`#13 <https://github.com/zopefoundation/Products.SiteErrorLog/i... |
zopefoundation__Products.ZCatalog-104 | [
{
"changes": {
"added_entities": [
"src/Products/ZCatalog/ZCatalog.py:ZCatalog.searchAll"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/Products/ZCatalog/ZCatalog.py:ZCatalog"
]
},
"file": "src/Products/ZCatalog/ZCatalog.p... | zopefoundation/Products.ZCatalog | c4e4cd55e17e2660e81795d4a8dc48278642a726 | "dtml/catalogView.dtml" needs update to changed behavior for "empty" searches
This originally has been #101 .
`searchResults` has recently been changed regarding "empty" searches: formerly, an "empty" search returned all catalogued objects, now, it returns 0 results.
The above mentioned dtml file must be updated ... | diff --git a/CHANGES.rst b/CHANGES.rst
index a114bde..0437fe3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,13 @@ Changelog
5.2 (unreleased)
----------------
+- Add new method ``searchAll`` to perform a search for all documents.
+
+- Document ``getAllBrains`` and ``searchAll`` in the interface.
+
+- Update ... |
zopefoundation__Products.ZCatalog-120 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/ZCatalog/Catalog.py:Catalog.sortResults"
],
"edited_modules": [
"src/Products/ZCatalog/Catalog.py:Catalog"
]
},
"file": "src/Products/ZCatalog/Catalog.py"
... | zopefoundation/Products.ZCatalog | de397aa1ea2f7cdead8ab45f6314305b0fe2dd45 | Wrong sorting when using sort_limit
Scenario: I have a folder full of documents and to make its listing I use the following catalog query:
```python
query = {
'member_id': self.context.id,
'portal_type': 'freitag.article.article',
'sort_on': 'effective',
'... | diff --git a/CHANGES.rst b/CHANGES.rst
index abd4aab..6e8e5c6 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -6,6 +6,9 @@ Changelog
- Fix case where multiple indexes with similar name seperated by ``_`` were interpreted as options.
(`#78 <https://github.com/zopefoundation/Products.ZCatalog/issues/78>`_)
+- Fix rev... |
zopefoundation__Products.ZCatalog-79 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Products/ZCatalog/query.py:IndexQuery.__init__"
],
"edited_modules": [
"src/Products/ZCatalog/query.py:IndexQuery"
]
},
"file": "src/Products/ZCatalog/query.py"
}... | zopefoundation/Products.ZCatalog | 7930d2fa78c1213ab8937bee6ae09ead559c7114 | Query for multiple indexes with similar names broken
/cc @andbag
When constructing a query with similar named indexes like ``workspace`` and ``workspace_root``, the query is broken since: https://github.com/zopefoundation/Products.ZCatalog/pull/67
Since ``workspace_root`` is available in the request, ``_root`` i... | diff --git a/CHANGES.rst b/CHANGES.rst
index cbda9d8..0ae2a95 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -47,6 +47,10 @@ Fixes
- Fix case where index value is changed to None after previously being indexed.
(`#100 <https://github.com/zopefoundation/Products.ZCatalog/issues/100>`_)
+- Fix case where multiple in... |
zopefoundation__Products.ZSQLMethods-35 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Shared/DC/ZRDB/Search.py:manage_addZSearch",
"src/Shared/DC/ZRDB/Search.py:ZQueryIds"
],
"edited_modules": [
"src/Shared/DC/ZRDB/Search.py:manage_addZSearch",
"sr... | zopefoundation/Products.ZSQLMethods | f60100ad00cd04e6bbe6261851329b9d8aa5d730 | object of type map has no len()
## BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
### What I did:
I tried to use `Z Search Interface` via ZMI.
### What I expect to happen:
I expected to get a generated template with a search form.
### What actually happened:
```
Traceback (innermost last):
Module ZPub... | diff --git a/CHANGES.rst b/CHANGES.rst
index 7386660..a9bf8ab 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@ Changelog
3.14 (unreleased)
-----------------
+- Fix `Z Search Interface Interface` creation under Python 3
+ (`#30 <https://github.com/zopefoundation/Products.ZSQLMethods/issues/30>`_)
+
3.1... |
zopefoundation__Products.ZSQLMethods-47 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Shared/DC/ZRDB/DA.py:DA.manage_zmi_test"
],
"edited_modules": [
"src/Shared/DC/ZRDB/DA.py:DA"
]
},
"file": "src/Shared/DC/ZRDB/DA.py"
},
{
"changes": {
... | zopefoundation/Products.ZSQLMethods | 56d78e696347006a344bb771700ca2a0ccc234bb | Adding Z Search Interface generates Internal Server Error
## BUG/PROBLEM REPORT / FEATURE REQUEST
### What I did:
* Added a ZSQLMethod `fullname_sql` with
`select 'Willi Langenenberger' FULLNAME from dual`
* Tested it with the "Test" tab
----------------
+- Fix Z Search Interface Creation
+ (`#46 <https://github.com/zopefoundation/Products.ZSQLMethods/issues/46>`_)
+
- Fix HTML quoting in test forms
... |
zopefoundation__RestrictedPython-134 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/RestrictedPython/transformer.py"
}
] | zopefoundation/RestrictedPython | ebe4c64f56a38f2ef39c14606517781af115a51f | Python 3: builtins instead of __builtins__
As Python 3 has renames `__builtins__` to `builtins` the access to this system dictionary is not restricted by default | diff --git a/src/RestrictedPython/transformer.py b/src/RestrictedPython/transformer.py
index c518ffc..faf45da 100644
--- a/src/RestrictedPython/transformer.py
+++ b/src/RestrictedPython/transformer.py
@@ -70,6 +70,7 @@ ALLOWED_FUNC_NAMES = frozenset([
FORBIDDEN_FUNC_NAMES = frozenset([
'print',
'printed',
+ ... |
zopefoundation__RestrictedPython-135 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/RestrictedPython/Utilities.py:same_type"
],
"edited_modules": [
"src/RestrictedPython/Utilities.py:same_type"
]
},
"file": "src/RestrictedPython/Utilities.py"
}
] | zopefoundation/RestrictedPython | ecf62c5116663990c78795ab8b0969874e1bdb3c | `same_type` should return True resp. False
There is no need to return `1` resp. `0` since Python 2.3 we have `True` and `False`. | diff --git a/src/RestrictedPython/Utilities.py b/src/RestrictedPython/Utilities.py
index ad6a1eb..2abb2db 100644
--- a/src/RestrictedPython/Utilities.py
+++ b/src/RestrictedPython/Utilities.py
@@ -37,8 +37,8 @@ def same_type(arg1, *args):
t = getattr(arg1, '__class__', type(arg1))
for arg in args:
if... |
zopefoundation__RestrictedPython-137 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/RestrictedPython/compile.py:_compile_restricted_mode"
],
"edited_modules": [
"src/RestrictedPython/compile.py:_compile_restricted_mode"
]
},
"file": "src/Restricted... | zopefoundation/RestrictedPython | 42b4be0237f0990f5a2121d0ca7035be53b87305 | Can't handle SyntaxError: can't assign to literal
```
from RestrictedPython import compile_restricted
code = """
1 = 2
"""
compile_restricted(code, '<string>', 'exec')
---------------------------------------------------------------------------
SyntaxError Traceback (most recent... | diff --git a/src/RestrictedPython/compile.py b/src/RestrictedPython/compile.py
index 391d4b5..aee78f6 100644
--- a/src/RestrictedPython/compile.py
+++ b/src/RestrictedPython/compile.py
@@ -60,7 +60,7 @@ def _compile_restricted_mode(
lineno=v.lineno,
type=v.__class__.__name__,
... |
zopefoundation__RestrictedPython-143 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/RestrictedPython/Guards.py:safer_getattr"
],
"edited_modules": [
"src/RestrictedPython/Guards.py:safer_getattr"
]
},
"file": "src/RestrictedPython/Guards.py"
},
... | zopefoundation/RestrictedPython | c055c5229ca14853d23b3402fa5021769160ab85 | `os.popen` Bypass
Hello!
I just wanted to let you guys know that there is a work around for executing `os` module methods without the need of `__import__`. I'm aware that *RestrictedPython* is not a **"sandbox"** or a **"secure environment"**, but since there was **"Problematic code example"** in the docs, I just w... | diff --git a/.gitignore b/.gitignore
index 11314b9..9ef14d5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -60,6 +60,7 @@ secret.cfg
/.ropeproject/
/.project
/.pydevproject
+.mypy_cache/
# Import Data
/*.csv
diff --git a/README.rst b/README.rst
index 2c4a7ce..261d650 100644
--- a/README.rst
+++ b/README.rst
@@ -25,... |
zopefoundation__RestrictedPython-198 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/RestrictedPython/Guards.py"
}
] | zopefoundation/RestrictedPython | a31c5572de8a0e6c4f41ea5a977fc27459917c8e | Adding "bytes" to allowed builtin names
Having `bytes` would allow a sane way of getting at `OFS.Image.File` data in restricted code under Python 3. `str` is inappropriate because it wants to decode the file content using the default UTF-8 encoding that may not match the actual encoding used by file contents.
Callin... | diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst
index 49d2d9d..7bb5c5d 100644
--- a/docs/CHANGES.rst
+++ b/docs/CHANGES.rst
@@ -4,6 +4,9 @@ Changes
5.1a0 (unreleased)
------------------
+- Add support for the ``bytes`` and ``sorted`` builtins
+ (`#186 <https://github.com/zopefoundation/RestrictedPython/issues/186... |
zopefoundation__RestrictedPython-272 | [
{
"changes": {
"added_entities": [
"src/RestrictedPython/transformer.py:RestrictingNodeTransformer.visit_Interactive"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/RestrictedPython/transformer.py:RestrictingNodeTransformer"
]
... | zopefoundation/RestrictedPython | 67f3c1bcb4fad913505d2c34ce7a6835869ff77b | Unable to compile single expressions
## PROBLEM REPORT
Attempted a simple `compile_restricted` using `single`.
```python
x = 50
code = compile_restricted('x + 25', '<string>', 'single')
```
### What I did:
Attempted a simple comparison with `compile()`. Also, compared it with `exec`.
```python
x = 50... | diff --git a/CHANGES.rst b/CHANGES.rst
index 24ed32f..6018a60 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -6,6 +6,7 @@ Changes
- Allow to use the package with Python 3.13 -- Caution: No security
audit has been done so far.
+- Add support for single mode statements / execution.
7.1 (2024-03-14)
diff --git a... |
zopefoundation__RestrictedPython-288 | [
{
"changes": {
"added_entities": [
"src/RestrictedPython/Guards.py:safer_getattr_raise"
],
"added_modules": [
"src/RestrictedPython/Guards.py:safer_getattr_raise"
],
"edited_entities": [
"src/RestrictedPython/Guards.py:safer_getattr"
],
"edited_m... | zopefoundation/RestrictedPython | ea8ede3061d35a895f4e851c855bc54b85594daa | Provide a `safer_getattr` variant with `getattr` compatible signature
We started to advertise `safer_getattr` as a safe `getattr` implementation candidate in a typical `RestrictedPython` environment **BUT** `safer_getattr` has a different signature and semantics than `getattr`: `safer_getattr` has by default the parame... | diff --git a/CHANGES.rst b/CHANGES.rst
index 10fad5c..43226ba 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,13 @@ Changes
- Allow to use the package with Python 3.13 -- Caution: No security
audit has been done so far.
+- Provide new function ``RestrictedPython.Guards.safer_getattr_raise``.
+ It is simila... |
zopefoundation__RestrictedPython-97 | [
{
"changes": {
"added_entities": [
"src/RestrictedPython/Eval.py:default_guarded_getiter"
],
"added_modules": [
"src/RestrictedPython/Eval.py:default_guarded_getiter"
],
"edited_entities": [
"src/RestrictedPython/Eval.py:RestrictionCapableEval.eval"
],... | zopefoundation/RestrictedPython | a63f5c3b600b00cb5bbe779b31e75e94413f8390 | list comprehension expression raises "TypeError: 'NoneType' object is not subscriptable"
Tested with Python 3.6.1 with RestrictedPython 4.0b2:
```
(Pdb) RestrictionCapableEval('[item for item in [1,2]]').eval(context)
*** TypeError: 'NoneType' object is not subscriptable
(Pdb) [item for item in [1,2]]
[1, 2]
```
... | diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst
index 91bc291..9af2e61 100644
--- a/docs/CHANGES.rst
+++ b/docs/CHANGES.rst
@@ -7,6 +7,9 @@ Changes
- Warn when using another Python implementation than CPython as it is not safe to use RestrictedPython with other versions than CPyton.
See https://bitbucket.org/pypy/... |
zopefoundation__ZConfig-19 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ZConfig/datatypes.py:float_conversion"
],
"edited_modules": [
"ZConfig/datatypes.py:float_conversion"
]
},
"file": "ZConfig/datatypes.py"
}
] | zopefoundation/ZConfig | 010cb2b2d4d2cdc8cd327f9f46a987024cac5b67 | Simplify float conversion
See https://github.com/zopefoundation/ZConfig/pull/13#discussion_r100796977 | diff --git a/CHANGES.rst b/CHANGES.rst
index d089805..77d7934 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -13,6 +13,9 @@ Change History for ZConfig
- BaseLoader is now an abstract class that cannot be instantiated.
+- Allow ``nan``, ``inf`` and ``-inf`` values for floats in
+ configurations. See https://github.... |
zopefoundation__ZConfig-24 | [
{
"changes": {
"added_entities": [
"ZConfig/info.py:AbstractType.__iter__",
"ZConfig/info.py:SectionType.__iter__",
"ZConfig/info.py:SectionType.itertypes"
],
"added_modules": null,
"edited_entities": [
"ZConfig/info.py:BaseKeyInfo.prepare_raw_defaults",
... | zopefoundation/ZConfig | a79e6a49c983eba104aff4e0869002437a66426f | zconfig_schema2html should handle component.xml from packages
If you feed it a component file, right now it blows up. If I change the script to do the obvious thing and wrap a `<schema><import package="..."/></schema>` around it, then you get no output. | diff --git a/ZConfig/info.py b/ZConfig/info.py
index 02ced04..758430b 100644
--- a/ZConfig/info.py
+++ b/ZConfig/info.py
@@ -17,6 +17,7 @@ import copy
import ZConfig
from abc import abstractmethod
+from collections import OrderedDict
from functools import total_ordering
from ZConfig._compat import AbstractBaseC... |
zopefoundation__ZConfig-51 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ZConfig/components/logger/handlers.py:FileHandlerFactory.create_loghandler"
],
"edited_modules": [
"ZConfig/components/logger/handlers.py:FileHandlerFactory"
]
},
"file... | zopefoundation/ZConfig | ce8ad23032399376a972df8a69591bc717258ff5 | Support delay parameter for file-based handlers
The *delay* parameter was added for all the file-based handlers from the ``logging`` package in Python 2.6, but ``ZConfig`` was not updated to support that.
We don't need to worry about pre-*delay* versions at this point, and it would be useful to have support for this... | diff --git a/CHANGES.rst b/CHANGES.rst
index 0802c08..4fb65de 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,10 +2,13 @@
Change History for ZConfig
==========================
-3.3.1 (unreleased)
+3.4.0 (unreleased)
------------------
-- Nothing changed yet.
+- The ``logfile`` section type defined by the ``ZCon... |
zopefoundation__ZEO-103 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZEO/__init__.py:connection"
],
"edited_modules": [
"src/ZEO/__init__.py:connection"
]
},
"file": "src/ZEO/__init__.py"
}
] | zopefoundation/ZEO | fdcc27393cf83f3e3b8f350a9b90aa7fb4b81d2f | mistake in writing
`ZEO/src/ZEO/__init__.py`
line 43 `ra
`should be `raise
` | diff --git a/.gitignore b/.gitignore
index 83f9b0d0..fc62ef39 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,3 +9,4 @@ eggs
parts
testing.log
.dir-locals.el
+data.fs*
diff --git a/src/ZEO/__init__.py b/src/ZEO/__init__.py
index 4cf580e7..ba340e4c 100644
--- a/src/ZEO/__init__.py
+++ b/src/ZEO/__init__.py
@@ -40,7 +4... |
zopefoundation__ZODB-170 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZODB/mvccadapter.py:Base.__getattr__",
"src/ZODB/mvccadapter.py:HistoricalStorageAdapter.release"
],
"edited_modules": [
"src/ZODB/mvccadapter.py:Base",
"src/ZODB... | zopefoundation/ZODB | 5056d49e79bc06f6d343973d71c3c3185e18975e | HistoricalStorageAdapter does not forward release to its base
This causes a connection leak on RelStorage.
| diff --git a/CHANGES.rst b/CHANGES.rst
index 039cc6ec..f3f7d1cd 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,8 @@
- Drop support for Python 3.3.
+- Ensure that the ``HistoricalStorageAdapter`` forwards the ``release`` method to
+ its base instance. See `issue 78 <https://github.com/zopefoundation/ZODB/is... |
zopefoundation__ZODB-221 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZODB/utils.py:p64",
"src/ZODB/utils.py:u64"
],
"edited_modules": [
"src/ZODB/utils.py:p64",
"src/ZODB/utils.py:u64"
]
},
"file": "src/ZODB/utils.py"... | zopefoundation/ZODB | 6abde06a07f6447e8cbd3389b5fabf1bb009b5e7 | ZODB.utils.p64 and u64 could be faster and provide better error reports
They currently use `struct.[un]pack(">Q", x)` which parses the format string each time. Using a pre-allocated Struct object can be quite a bit faster
```console
# Python 2.7
$ python -m perf timeit -s 'from struct import pack' 'pack(">Q", 1234... | diff --git a/CHANGES.rst b/CHANGES.rst
index 961120fd..d2d57513 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -17,6 +17,11 @@
- Add support for Python 3.7.
+- Make the internal support functions for dealing with OIDs (``p64``
+ and ``u64``) somewhat faster and raise more informative
+ exceptions on certain types... |
zopefoundation__ZODB-260 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZODB/scripts/repozo.py:parseargs"
],
"edited_modules": [
"src/ZODB/scripts/repozo.py:parseargs"
]
},
"file": "src/ZODB/scripts/repozo.py"
}
] | zopefoundation/ZODB | 334282c34cac6f3dabceb560940d7e881dd6b853 | Repozo/Filestorage: TypeError: expected str, bytes or os.PathLike object, not NoneType
Plone 5.2RC1, ZODB 5.5.1, Python 3.6:
```
dgho@server:~/onkopedia_buildout$ bin/repozo --backup --repository /tmp/foo
Traceback (most recent call last):
File "bin/repozo", line 20, in <module>
sys.exit(ZODB.scripts.rep... | diff --git a/src/ZODB/scripts/repozo.py b/src/ZODB/scripts/repozo.py
index d9422ad2..70d323f5 100755
--- a/src/ZODB/scripts/repozo.py
+++ b/src/ZODB/scripts/repozo.py
@@ -251,6 +251,8 @@ def parseargs(argv):
if options.withverify is not None:
log('--with-verify option is ignored in backup mode')
... |
zopefoundation__ZODB-269 | [
{
"changes": {
"added_entities": [
"src/ZODB/DB.py:TransactionalUndo.close"
],
"added_modules": null,
"edited_entities": [
"src/ZODB/DB.py:TransactionalUndo.__init__",
"src/ZODB/DB.py:TransactionalUndo.tpc_begin",
"src/ZODB/DB.py:TransactionalUndo.tpc_fini... | zopefoundation/ZODB | 79fe4737e3df5916bd4ce48d49b65caf26000cd4 | DB.undo() leaks MVCC storages
I see this [in the relstorage tests](https://github.com/zodb/relstorage/issues/225). That means the underlying database connections leak.
Here's where a storage is allocated by calling `new_instance()`:
```Python traceback
File "//relstorage/src/relstorage/tests/blob/testblob.py",... | diff --git a/CHANGES.rst b/CHANGES.rst
index a8968eb9..3331176d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -13,12 +13,17 @@
- Drop support for Python 3.4.
+- Fix ``DB.undo()`` and ``DB.undoMultiple()`` to close the storage
+ they open behind the scenes when the transaction is committed or
+ rolled back. See `... |
zopefoundation__ZODB-291 | [
{
"changes": {
"added_entities": [
"src/ZODB/mvccadapter.py:MVCCAdapterInstance._lastTransaction"
],
"added_modules": null,
"edited_entities": [
"src/ZODB/mvccadapter.py:MVCCAdapter.new_instance",
"src/ZODB/mvccadapter.py:MVCCAdapter.invalidate",
"src/ZODB... | zopefoundation/ZODB | 12b52a71b4739aeec728603a60298118a2d4e2bc | Race in Connection.open() vs invalidations -> corrupt data
Hello up there,
For wendelin.core v2 I need a way to know at which particular database state application-level ZODB connection is viewing the database. I was looking for that in `Connection.open` / `MVCCAdapter` code and noticed concurrency bug that leads to... | diff --git a/CHANGES.rst b/CHANGES.rst
index 218116b6..43d58729 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,11 @@
5.6.0 (unreleased)
==================
+- Fix race with invalidations when starting a new transaction. The bug
+ affected Storage implementations that rely on mvccadapter, and could result
+ ... |
zopefoundation__ZODB-355 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZODB/FileStorage/fsdump.py:fsdump"
],
"edited_modules": [
"src/ZODB/FileStorage/fsdump.py:fsdump"
]
},
"file": "src/ZODB/FileStorage/fsdump.py"
},
{
"change... | zopefoundation/ZODB | 1fb097b41cae4ca863c8a3664414c9ec0e204393 | `fsstats` no longer matches output of `fsdump`
ZODB==5.6.0
`scripts.fsstats` is supposed to derive statistics from the output of `FileStorage.fsdump`. However, it no longer understands this output.
Transaction records produced by `fsdump` look like
```
Trans #00000 tid=038e1d5f01b145cc time=2011-05-05 07:59:00.... | diff --git a/CHANGES.rst b/CHANGES.rst
index f833ad5e..99fb8070 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,12 @@
5.6.1 (unreleased)
==================
+- Readd transaction size information to ``fsdump`` output;
+ adapt `fsstats` to ``fsdump``'s exchanged order for ``size`` and ``class``
+ information i... |
zopefoundation__Zope-1003 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/webdav/NullResource.py:NullResource.PUT"
],
"edited_modules": [
"src/webdav/NullResource.py:NullResource"
]
},
"file": "src/webdav/NullResource.py"
}
] | zopefoundation/Zope | ba9f5ae81378f0eeeecb0463caf8434b1467ef27 | Webdav _default_PUT_factory not working as expected
### What I did:
After a Zope update (possibly to 5.3 but it could be an earlier one) certain files do not get converted to Zope objects as expected when uploaded via webdav.
### What I expect to happen:
- Files with the extensions 'html' or 'pt' should result i... | diff --git a/CHANGES.rst b/CHANGES.rst
index 89abf2fc4..4f9d5e270 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -11,6 +11,9 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.4 (unreleased)
----------------
+- Enable WebDAV PUT factories to change a newly created object's ID
+ (`#997 <https://github.... |
zopefoundation__Zope-1079 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/App/special_dtml.py:DTMLFile._exec"
],
"edited_modules": [
"src/App/special_dtml.py:DTMLFile"
]
},
"file": "src/App/special_dtml.py"
}
] | zopefoundation/Zope | 40884527b9e7664fd2a39c982c0717eefe4de5da | Bad Content-Type after merging #1075
Some ZMI pages don't render correctly after the last bugfix release because they never set an explicit `Content-Type` header and will now be published with the new default `text/plain`. Examples are:
- [ ] /manage_tabs
- [ ] /manage
There may be more. | diff --git a/CHANGES.rst b/CHANGES.rst
index f45707259..9daa1b66b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,10 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.7.2 (unreleased)
------------------
+- Fix some broken ZMI pages due to the changed default content type
+ from PR https://gi... |
zopefoundation__Zope-1124 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZPublisher/HTTPRequest.py:HTTPRequest.clear",
"src/ZPublisher/HTTPRequest.py:HTTPRequest.processInputs",
"src/ZPublisher/HTTPRequest.py:HTTPRequest.get",
"src/ZPublisher/HTTP... | zopefoundation/Zope | 741d89542aabc6a7d1c2701c5b3059f9d0a7ff54 | query-parameters on post-request no longer supported with new ZopeFieldStorage
## BUG/PROBLEM REPORT / FEATURE REQUEST
First of all: Thanks for your hard work you all do on this project. Zope feels really, really professional maintained at the moment! Every thing is stable and works like a charm. I only got one smal... | diff --git a/CHANGES.rst b/CHANGES.rst
index 425f8a7ec..1f1bc3f88 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,18 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.8.2 (unreleased)
------------------
+- Allow ``ZPublisher`` to handle both a query string and a request body;
+ the request p... |
zopefoundation__Zope-1135 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZPublisher/mapply.py:mapply"
],
"edited_modules": [
"src/ZPublisher/mapply.py:mapply"
]
},
"file": "src/ZPublisher/mapply.py"
}
] | zopefoundation/Zope | b0bb1084379c5c693f9277b3d0ce044cea849dda | Feature request: support Python 3 style signature declarations in `ZPublisher.mapply.mapply`
Python 3 has introduced the `__signature__` attribute to inform a caller about the signature of a callable. This significantly simplifies the implementation of signature preserving decorators.
Unfortunately, `ZPublisher.mapp... | diff --git a/CHANGES.rst b/CHANGES.rst
index 5afe97abc..e99b7b40f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -20,6 +20,15 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
- Update to newest compatible versions of dependencies.
+- Make ``mapply`` ``__signature__`` aware.
+ This allows to publish m... |
zopefoundation__Zope-1142 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZPublisher/HTTPRequest.py:ValueDescriptor.__get__"
],
"edited_modules": [
"src/ZPublisher/HTTPRequest.py:ValueDescriptor"
]
},
"file": "src/ZPublisher/HTTPRequest.p... | zopefoundation/Zope | 345d656557bfc414f70b92637fef33dde747a97d | ZPublisher.HTTPRequest.FORM_MEMORY_LIMIT too low
Hello @d-maurer ,
the choosen data limit for FORM_MEMORY_LIMIT now is limited to only 1 Mb;
https://github.com/zopefoundation/Zope/blob/345d656557bfc414f70b92637fef33dde747a97d/src/ZPublisher/HTTPRequest.py#L54C9-L58
This FORM_MEMORY_LIMIT value was introduced here:... | diff --git a/CHANGES.rst b/CHANGES.rst
index e99b7b40f..c4b17af07 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -29,6 +29,9 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
Note: ``mapply`` still does not support keyword only, var positional
and var keyword parameters.
+- Make Zope's parameters fo... |
zopefoundation__Zope-1156 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZPublisher/WSGIPublisher.py:publish_module"
],
"edited_modules": [
"src/ZPublisher/WSGIPublisher.py:publish_module"
]
},
"file": "src/ZPublisher/WSGIPublisher.py"
... | zopefoundation/Zope | a0f70b6806272523f4d9fafb11ab3ffac1638638 | Username not in access log for error requests
## BUG/PROBLEM REPORT / FEATURE REQUEST
<!--
Please do not report security-related issues here. Report them by email to security@plone.org. The Security Team will contact the relevant maintainer if necessary.
Include tracebacks, screenshots, code of debugging sessi... | diff --git a/CHANGES.rst b/CHANGES.rst
index d9ecaf643..fcd77f56b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -18,6 +18,9 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
- Added image dimensions to SVG file properties
`#1146 <https://github.com/zopefoundation/Zope/pull/1146>`_.
+- Fix username no... |
zopefoundation__Zope-1183 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZPublisher/HTTPRequest.py:ZopeFieldStorage.__init__"
],
"edited_modules": [
"src/ZPublisher/HTTPRequest.py:ZopeFieldStorage"
]
},
"file": "src/ZPublisher/HTTPReques... | zopefoundation/Zope | fe08bae876f13dc1dbc333730eaeb51f264f46a3 | Clarification on Handling Image Uploads via HTTP PUT in Zope5 with WSGI Server
### What I did:
I encountered an issue related to the handling of image uploads when using the HTTP PUT method in Zope5 with a WSGI server. Here are the steps I followed to reproduce the problem:
1. Using a Zope5 installation with the... | diff --git a/CHANGES.rst b/CHANGES.rst
index 0a3cd08e0..9665d0317 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,9 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.8.7 (unreleased)
------------------
+- Support form data in ``PUT`` requests (following the ``multipart`` example).
+ Fixes `#... |
zopefoundation__Zope-1219 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZPublisher/BaseRequest.py:BaseRequest.traverse"
],
"edited_modules": [
"src/ZPublisher/BaseRequest.py:BaseRequest"
]
},
"file": "src/ZPublisher/BaseRequest.py"
}
... | zopefoundation/Zope | 77f7c0d76e39645b14d4ecd31afc577b03ea4495 | Traversal with `..` past the root raises IndexError
## BUG/PROBLEM REPORT / FEATURE REQUEST
### What I did:
1. Start Zope on port 8080
2. Try to load `http://localhost:8080/..` using curl: `curl -v --path-as-is 'http://localhost:8080/..'`
(Note, this is hard to reproduce in a browser because it may normalize ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 9ceb092a4..2d2b8e6ed 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -14,7 +14,10 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
- Update to newest compatible versions of dependencies.
-- Added CC-BY 4.0 license to the Zope logo.
+- Added CC-BY 4.0 licens... |
zopefoundation__Zope-1243 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZPublisher/HTTPRequest.py:HTTPRequest.clear"
],
"edited_modules": [
"src/ZPublisher/HTTPRequest.py:HTTPRequest"
]
},
"file": "src/ZPublisher/HTTPRequest.py"
}
] | zopefoundation/Zope | 78025426ecb021e6296881f20afbf7e1db32a809 | `ResourceWarning` after uploading large files
### What I did:
Upload a file with an html like this that one:
```html
<html>
<form action="/" method="post" enctype="multipart/form-data">
<input type="file" id="f" name="f">
<button type="submit">Upload</button>
</form>
</html>
```
### What I ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 388724654..a57b862b5 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,9 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.11.2 (unreleased)
-------------------
+- Fix a ``ResourceWarning`` emitted when uploading large files.
+ (`#1242 <https://gith... |
zopefoundation__Zope-182 | [
{
"changes": {
"added_entities": [
"src/ZPublisher/HTTPRequest.py:record.__contains__",
"src/ZPublisher/HTTPRequest.py:record.__iter__",
"src/ZPublisher/HTTPRequest.py:record.__len__"
],
"added_modules": null,
"edited_entities": [
"src/ZPublisher/HTTPReque... | zopefoundation/Zope | 571aada50a4c7390e716a7bf027810cac481f632 | Form-value gets turned into a request-record instead of a dict
Form-value gets turned into a request-record instead of a dict
A doctest with a item
<input type="checkbox" value="1" name="index.enabled:records" id="created_enabled" checked="checked" />
fails in Zope 4 since index is transformed to a ZPublis... | diff --git a/CHANGES.rst b/CHANGES.rst
index f0925e1e3..923b94331 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -11,7 +11,10 @@ https://github.com/zopefoundation/Zope/blob/4.0a6/CHANGES.rst
4.0b2 (unreleased)
------------------
-- Nothing changed yet.
+Bugfixes
+++++++++
+
+- Fix special double under methods on `HT... |
zopefoundation__Zope-597 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/Zope2/utilities/finder.py:ZopeFinder.get_zope_conf"
],
"edited_modules": [
"src/Zope2/utilities/finder.py:ZopeFinder"
]
},
"file": "src/Zope2/utilities/finder.py"
... | zopefoundation/Zope | 07e20d235fda0e8555c24cbb424574e9a69241a2 | A couple of questions about default-zpublisher-encoding
When revising #564 @dataflake made me aware of the `default-zpublisher-encoding` option.
I have a couple of questions /annotations about that one.
1. The only documentation about that option seems to be the CHANGES.rst and the NEWS.rst.
Both refer to zope... | diff --git a/CHANGES.rst b/CHANGES.rst
index 8ca82522a..26dcddc03 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -62,6 +62,10 @@ Features
Other changes
+++++++++++++
+- Change naming for the generated WSGI configurations to ``zope.conf`` and
+ ``zope.ini`` to match existing documentation for Zope configurations.
+ ... |
zopefoundation__Zope-830 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ZPublisher/HTTPResponse.py:HTTPResponse.debugError"
],
"edited_modules": [
"src/ZPublisher/HTTPResponse.py:HTTPResponse"
]
},
"file": "src/ZPublisher/HTTPResponse.p... | zopefoundation/Zope | e7ebc337e810d8ae6987a582ae2163d4b0089c18 | The debugError function is too brittle
The actual code
https://github.com/zopefoundation/Zope/blob/5bfcac7fc0c5a620326955571fc69f20e106a884/src/ZPublisher/HTTPResponse.py#L780-L784
breaks when `entry` is not a string.
For example I add an error when `entry`turned out to be a tuple:
```
(Pdb) l
823 # If ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 93908de76..2f2a10596 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,7 +10,8 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
5.0a3 (unreleased)
------------------
-- Nothing changed yet.
+- Improve solidity of the ``debugError`` method.
+ (`#829 <https:... |
zopefoundation__Zope-906 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/OFS/SimpleItem.py:Item_w__name__"
]
},
"file": "src/OFS/SimpleItem.py"
}
] | zopefoundation/Zope | a449b8cd38bb5d8c0ede7c259d58e18e2f06713e | (Export/)Import broken for "OFS.SimpleItem.Item_w__name__" instances
## BUG/PROBLEM REPORT
If an instance of `OFS.SimpleItem.Item_w__name__` (e.g. an `OFS.Image.File` instance) is exported, a subsequent import fails with `BadRequest: ('Empty or invalid id specified', '')`.
The reason: for `Item_w__name__` instances... | diff --git a/CHANGES.rst b/CHANGES.rst
index ea20b1f0a..befdb874b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,10 @@ https://zope.readthedocs.io/en/2.13/CHANGES.html
4.5.2 (unreleased)
------------------
+- Provide a more senseful ``OFS.SimpleItem.Item_w__name__.id``
+ to avoid bugs by use of deprecated... |
zopefoundation__persistent-105 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "persistent/__init__.py"
},
{
"changes": {
"added_entities": [
"persistent/interfaces.py:IExtendedPickleCache.reify",
"persistent... | zopefoundation/persistent | 8e1df28364d8851955f541faecf3ea1924b2798e | is cPickleCache tested?
Looking at the tests in test_picklecache, it looks like they're only testing the Python version.
Am I missing something? | diff --git a/CHANGES.rst b/CHANGES.rst
index c13157e..c68406c 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,10 +1,20 @@
``persistent`` Changelog
========================
-4.4.4 (unreleased)
+4.5.0 (unreleased)
------------------
-- Nothing changed yet.
+- Fully test the C implementation of the PickleCache, an... |
zopefoundation__persistent-127 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"persistent/mapping.py:PersistentMapping.update",
"persistent/mapping.py:PersistentMapping.setdefault",
"persistent/mapping.py:PersistentMapping.pop",
"persistent/mapping.py:Persi... | zopefoundation/persistent | f91227e6a01a7cfcc29beba0d3ea384deecb3bc3 | PersistentMapping.update does not accept keyword arguments
We define the signature as: https://github.com/zopefoundation/persistent/blob/d4f1204d87bec113de5c2457eaa7878ec0f40ab3/persistent/mapping.py#L70
But the actual signature is supposed to be
```python
# Python 3 collections.UserDict.update
def update(se... | diff --git a/CHANGES.rst b/CHANGES.rst
index 175f4ae..48b6cb4 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,9 +4,21 @@
4.5.2 (unreleased)
------------------
-- Fixed ``PersistentList`` to mark itself as changed after calling
+- Fix ``PersistentList`` to mark itself as changed after calling
``clear``. See `PR ... |
zopefoundation__persistent-128 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"persistent/list.py:PersistentList.__delitem__"
],
"edited_modules": [
"persistent/list.py:PersistentList"
]
},
"file": "persistent/list.py"
},
{
"changes": {
... | zopefoundation/persistent | a6a18eaa8f347530646ce413f93f90a584ab2fb2 | PersistentList slicing returns a non-persistent list on python3
Since `__setslice__()` and the likes have been killed in python3 (in favor of `__getitem__(slice(...)`), it seems that PersistentList must be updated, else slices return regular lists and the DB gets dangerously filled with non-persistent mutables:
```p... | diff --git a/CHANGES.rst b/CHANGES.rst
index 48b6cb4..2e16543 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,13 @@
4.5.2 (unreleased)
------------------
+- Fix slicing of ``PersistentList`` to always return instances of the
+ same class. It was broken on Python 3 prior to 3.7.4.
+
+- Fix copying of ``Persi... |
zopefoundation__persistent-140 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"persistent/mapping.py:PersistentMapping.clear"
],
"edited_modules": [
"persistent/mapping.py:PersistentMapping"
]
},
"file": "persistent/mapping.py"
}
] | zopefoundation/persistent | ce84010b4c73556620ae8ca8c289d368d5fa1e04 | AssertionError clearing PersistentMap not added to connection.
```pycon
>>> import persistent.mapping
>>> pm = persistent.mapping.PersistentMapping()
>>> pm['k'] = 'v'
>>> pm.clear()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/jmadden/Projects/GithubSources/persistent/... | diff --git a/CHANGES.rst b/CHANGES.rst
index fa4b521..511e015 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,9 @@
4.6.2 (unreleased)
------------------
-- Nothing changed yet.
+- Fix an ``AssertionError`` clearing a non-empty ``PersistentMapping``
+ that has no connection. See `issue 139
+ <https://github.... |
zopefoundation__persistent-160 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"persistent/persistence.py:Persistent.__setattr__"
],
"edited_modules": [
"persistent/persistence.py:Persistent"
]
},
"file": "persistent/persistence.py"
}
] | zopefoundation/persistent | fc4d4af38764a8a7410fee73e47069b32f5d720b | C/Python difference: Setting __class__ activates in C, doesn't activate in Python
In the C implementation, setting `__class__` of a ghost calls `_p_activate()`, and uses the class methods defined on the original class.
But in the Python implementation, setting `__class__` does *not* call `_p_activate()`; consequent... | diff --git a/CHANGES.rst b/CHANGES.rst
index 124939a..542e403 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -8,6 +8,10 @@
- Add support for Python 3.9.
- Move from Travis CI to Github Actions.
- Supply manylinux wheels for aarch64 (ARM).
+- Fix the pure-Python implementation to activate a ghost object
+ when settin... |
zopefoundation__persistent-161 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"persistent/picklecache.py:_WeakValueDictionary"
]
},
"file": "persistent/picklecache.py"
}
] | zopefoundation/persistent | 6b500fc3f517fb566e8d0b85b756ddf49758c8d8 | AttributeError: '_WeakValueDictionary' object has no attribute '_addr_to_oid'
Seen during test teardown of a large app using CPython in PURE_PYTHON=1 mode
```
From callback for ffi.gc <cdata 'struct CPersistentRingCFFI_struct *' owning 24 bytes>:
Traceback (most recent call last):
File "//persistent/persistent/... | diff --git a/CHANGES.rst b/CHANGES.rst
index 542e403..81a77a8 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -12,6 +12,10 @@
when setting its ``__class__`` and ``__dict__``. This matches the
behaviour of the C implementation. See `issue 155
<https://github.com/zopefoundation/persistent/issues/155>`_.
+- Fix the... |
zopefoundation__persistent-54 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"persistent/persistence.py:Persistent._p_invalidate_deactivate_helper"
],
"edited_modules": [
"persistent/persistence.py:Persistent"
]
},
"file": "persistent/persistence... | zopefoundation/persistent | c6be5f8f03ff6d3f71c0dbefe546ba6ab5cc4c5f | PyPy/Pure-Python: `PickleCache.new_ghost` destroys any information passed to `__new__`
Spurred from the work in #44, with a lengthy description in https://github.com/zopefoundation/persistent/pull/44#issuecomment-256962199
Both dicts and slots are affected and need a test case.
| diff --git a/.gitignore b/.gitignore
index 28c5025..22ebfb9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,3 +15,4 @@ coverage.xml
.installed.cfg
.dir-locals.el
dist
+htmlcov
diff --git a/CHANGES.rst b/CHANGES.rst
index 56aafca..f974c9f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,18 @@
- Fix the hashcode... |
zopefoundation__persistent-83 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"persistent/persistence.py:Persistent.__repr__"
],
"edited_modules": [
"persistent/persistence.py:Persistent"
]
},
"file": "persistent/persistence.py"
},
{
"chan... | zopefoundation/persistent | aa6048a342d91656f3d1be6ff04bd1815e191a04 | pyTimeStamp and TimeStamp have different sub-second precision
I don't think this is correct:
```
>>> from persistent.timestamp import TimeStamp, pyTimeStamp
>>> ts1 = TimeStamp(2001, 2, 3, 4, 5, 6.123456789)
>>> ts2 = pyTimeStamp(2001, 2, 3, 4, 5, 6.123456789)
>>> ts1 == ts2
True
>>> ts1.second() == ts2.second()
False... | diff --git a/CHANGES.rst b/CHANGES.rst
index 956c0a5..469c538 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,12 +4,6 @@
4.3.1 (unreleased)
------------------
-- Change the default representation of ``Persistent`` objects to
- include the representation of their OID and jar, if set. Also add
- the ability for su... |
zopefoundation__persistent-97 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"persistent/persistence.py:Persistent.__repr__"
],
"edited_modules": [
"persistent/persistence.py:Persistent"
]
},
"file": "persistent/persistence.py"
}
] | zopefoundation/persistent | 598f9ab73dbf8b8d70cb706dc6eb53ec8598c8fe | Type name varies in the repr() depending on the presence of the C extension
This manifests in breakage of [BTrees tests](https://travis-ci.org/zopefoundation/BTrees/jobs/415400906) when the C extensions are used (they pass when the pure-Python extensions are available).
This is a somewhat common problem. There's a ... | diff --git a/CHANGES.rst b/CHANGES.rst
index c9272ea..69afaec 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,10 @@
4.4.3 (unreleased)
------------------
-- Nothing changed yet.
+- Fix the repr of the persistent objects to include the module name
+ when using the C extension. This matches the pure-Python beh... |
zopefoundation__transaction-24 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"transaction/_manager.py:TransactionManager.attempts",
"transaction/_manager.py:Attempt.__exit__"
],
"edited_modules": [
"transaction/_manager.py:TransactionManager",
... | zopefoundation/transaction | efd6988269d90c71b5db1aa70263b4a9a60f27dd | Attemps are retried on successful run
I'm not sure if this is a bug or intended behavior. But the attempts function does work as described in the example code in the [documents](http://transaction.readthedocs.io/en/latest/convenience.html#retries):
```
for i in range(3):
try:
with transaction.manager:
... | diff --git a/CHANGES.rst b/CHANGES.rst
index 32b7510..b976f79 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@ Changes
Unreleased
----------
+- Fixed the transaction manager ``attempts`` method. It didn't stop
+ repeating when there wasn't an error.
+
- Corrected ITransaction by removing beforeCommitHoo... |
zopefoundation__transaction-28 | [
{
"changes": {
"added_entities": [
"transaction/_transaction.py:Transaction._extension",
"transaction/_transaction.py:Transaction.user",
"transaction/_transaction.py:Transaction.description"
],
"added_modules": null,
"edited_entities": [
"transaction/_tran... | zopefoundation/transaction | 085ab4fb0521127cd5428db9fd9fdcd3b8eaed10 | Define transaction description and user to be unicode
See:
https://groups.google.com/forum/#!topic/python-transaction/Yn326XwCZ5E | diff --git a/CHANGES.rst b/CHANGES.rst
index 7569466..4a1e878 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,6 +1,29 @@
Changes
=======
+2.0.0 (unreleased)
+------------------
+
+- The transaction ``user`` and ``description`` attributes are now
+ defined to be text (unicode) as apposed to Python the ``str`` type... |
zopefoundation__transaction-81 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"transaction/_compat.py:bytes_",
"transaction/_compat.py:text_"
],
"edited_modules": [
"transaction/_compat.py:bytes_",
"transaction/_compat.py:text_"
]
},
... | zopefoundation/transaction | b1579531afafae7a9b0e85f88e5508ead587ad5f | Support abort hooks (symmetrically to commit hooks)
`transaction` currently supports (before and after) commit hooks. It should symmetrically support abort hooks as well.
I need this feature in `dm.zodb.asynchronous`, more precisely in its `TransactionalScheduler`. This scheduler allows to schedule a function call a... | diff --git a/CHANGES.rst b/CHANGES.rst
index 4077211..e9d4cf3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -18,6 +18,12 @@
if it is only an instance of `BaseException` but not of `Exception`,
such as e.g. a ``SystemExit`` or ``KeyboardInterupt`` exception.
+- Support abort hooks (symmetrically to commit hooks)... |
zopefoundation__zc.lockfile-16 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": [
"src/zc/lockfile/__init__.py:SimpleLockFile.__init__",
"src/zc/lockfile/__init__... | zopefoundation/zc.lockfile | c3ddaf120d390f3db2eb187b251968191d9ee2e1 | Allow reading/writing with acquired lock file
The current implementation of LockFile unconditionally writes some content and truncates the file upon acquiring the lock.
Some use cases, such as in pytest-dev/pytest-services#23, require that the client be able to read the content of the file and write more content to ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 64a5788..8d81187 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,11 +1,16 @@
Change History
***************
-1.5 (unreleased)
+2.0 (unreleased)
================
-- Nothing changed yet.
+- #15: Extracted new ``SimpleLockFile`` that removes implicit behavior
+ writing... |
zopefoundation__zope.app.i18n-8 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
... | zopefoundation/zope.app.i18n | e924fa8930320f00a6b57a51295dc2d893e92032 | Add support for pluralization
zope.i18n 4.5 added support for pluralization, which introduced new methods and new arguments to IMessageCatalog and ITranslationDomain.
zope.app.i18n has local implementations of these interfaces that don't support the new methods/arguments, which breaks zope.app.i18n's test suite. | diff --git a/.coveragerc b/.coveragerc
index f31f86e..f395c3b 100644
--- a/.coveragerc
+++ b/.coveragerc
@@ -6,3 +6,4 @@ exclude_lines =
pragma: no cover
if __name__ == '__main__':
raise NotImplementedError
+ raise NotYetImplementedError
diff --git a/CHANGES.rst b/CHANGES.rst
index 7e4913d..399d9c5 10... |
zopefoundation__zope.app.onlinehelp-6 | [
{
"changes": {
"added_entities": [
"src/zope/app/onlinehelp/__init__.py:_TraversedOnlineHelpProxy.__init__",
"src/zope/app/onlinehelp/__init__.py:_TraversedOnlineHelpProxy.__reduce__"
],
"added_modules": [
"src/zope/app/onlinehelp/__init__.py:_TraversedOnlineHelpProxy"
... | zopefoundation/zope.app.onlinehelp | 0cd750a10af18f630a3dd3560bbd3139a438360e | The ++help namespace is not thread-safe
When you traverse the `++help` namespace, it [mutates a global object](https://github.com/zopefoundation/zope.app.onlinehelp/blob/master/src/zope/app/onlinehelp/__init__.py#L49), which is [clearly an issue if threads are involved](https://github.com/zopefoundation/zope.app.online... | diff --git a/CHANGES.rst b/CHANGES.rst
index f212edd..b9ae31f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,11 +2,18 @@
CHANGES
=========
-4.0.2 (unreleased)
+4.1.0 (unreleased)
==================
-- Nothing changed yet.
+- The help namespace no longer modifies the global help object on
+ traversal. Instead... |
zopefoundation__zope.component-53 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": [
"src/zope/component/persistentregistry.py:PersistentAdapterRegistry._addValueToLeaf",
... | zopefoundation/zope.component | 7e868363ded67a31bb930da7bf3fb7ea45832d19 | Make PersistentAdapterRegistry use PersistentMapping and PersistentList instead of dict and tuple
`PersistentComponents` already uses `PersistentMapping` and `PersistentList` for its internal structures: https://github.com/zopefoundation/zope.component/blob/e7fe69a371afd52781a3c49c130768b607bcff48/src/zope/component/pe... | diff --git a/CHANGES.rst b/CHANGES.rst
index b83b913..3c49567 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -26,6 +26,22 @@
before. See `issue 9
<https://github.com/zopefoundation/zope.component/issues/9>`_.
+- Make ``PersistentAdapterRegistry`` use persistent objects
+ (``PersistentMapping`` and ``PersistentL... |
zopefoundation__zope.component-55 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/component/zcml.py:... | zopefoundation/zope.component | a4f0c3e86a794fa510923352d1fdbc54e0f314e5 | Utilities registered in zcml with a factory do not respect permission attribute
Originally posted at https://github.com/plone-security/Issues/issues/90
Looking through the code in `zcml.py` any time a ZCML registration involves a component with a factory and permission set, the factory will be wrapped in a call to `... | diff --git a/CHANGES.rst b/CHANGES.rst
index f586db3..84a0faa 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,9 +2,12 @@
Changes
=========
-4.7.0 (unreleased)
+5.0.0 (unreleased)
==================
+- Respect permission value for utility factory registrations
+ (`#54 <https://github.com/zopefoundation/zope.co... |
zopefoundation__zope.component-58 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/component/zcml.py:subscriber"
],
"edited_modules": [
"src/zope/component/zcml.py:subscriber"
]
},
"file": "src/zope/component/zcml.py"
}
] | zopefoundation/zope.component | 41cafd34b01555bc5c8bb7fe1b6181a7acf32fe7 | subscriber directive doesn't allow declaring provided interface in Python
In https://bugs.launchpad.net/zope.component/+bug/1025539, @tlotze reported:
> The docs of zope.component (zcml.rst) say:
``` python
"""
Like the <adapter /> directive, the <subscriber /> directive can
figure out from the in-line Python declara... | diff --git a/CHANGES.rst b/CHANGES.rst
index 84a0faa..62a294b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,12 @@
- Add support for Python 3.9
+- Fix the ``<subscriber>`` ZCML directive to allow a missing
+ ``provides=`` attribute when a ``factory=`` is given and the Python
+ object has been decorated ... |
zopefoundation__zope.component-61 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/component/interface.py:provideInterface",
"src/zope/component/interface.py:searchInterfaceUtilities"
],
"edited_modules": [
"src/zope/component/interface.py:provideI... | zopefoundation/zope.component | 950b4a47655ccfbb9016c72add622cc74318a952 | The zcml directive interface registers the interfaces always in the global registry
In https://bugs.launchpad.net/zope.component/+bug/1089340, @agroszer reported:
> Whereas the other registrations use
``` python
sm = zope.component.getSiteManager()
sm.register...
```
`zope.component.interface.provideInterface` does:... | diff --git a/CHANGES.rst b/CHANGES.rst
index 3c49567..7b8a73a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -41,6 +41,14 @@
See `issue 51 <https://github.com/zopefoundation/zope.component/issues/51>`_.
+- Fix ``zope.interface.interface.provideInterface`` and the various
+ search and query methods to use the cur... |
zopefoundation__zope.component-63 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/component/persistentregistry.py:PersistentAdapterRegistry._removeValueFromLeaf"
],
"edited_modules": [
"src/zope/component/persistentregistry.py:PersistentAdapterRegistry"
... | zopefoundation/zope.component | af09e48f234cb61307efeb7e5227108a85a5fd89 | Unsubscribing breaks on unmigrated data
Seems like migrating old tuples breaks:
```
File "/ve/lib/python3.9/site-packages/zope/interface/registry.py", line 272, in unregisterUtility
self._utility_registrations_cache.unregisterUtility(
File "/ve/lib/python3.9/site-packages/zope/interface/registry.py", line... | diff --git a/CHANGES.rst b/CHANGES.rst
index 6df82ea..061ace3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,9 @@
5.0.1 (unreleased)
==================
-- Nothing changed yet.
+- Fix unregistering utilities on old persistent adapter registries.
+ Previously this could raise ``TypeError``. See `issue 62
+ <... |
zopefoundation__zope.componentvocabulary-7 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"setup.py:alltests"
],
"edited_modules": [
"setup.py:alltests"
]
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": nul... | zopefoundation/zope.componentvocabulary | b876ffc5b172710f976bc49aad58998302720998 | Fix DeprecationWarnings
```
zope/componentvocabulary/vocabulary.py:23: DeprecationWarning: IUtilityRegistration is deprecated. Import from zope.interface.interfaces
from zope.component.interfaces import IUtilityRegistration
``` | diff --git a/CHANGES.rst b/CHANGES.rst
index ae85acd..89282ad 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,14 +1,16 @@
-Changes
-=======
+=========
+ Changes
+=========
2.1.1 (unreleased)
-------------------
+==================
- Add support for Python 3.7.
+- Drop support for ``setup.py test``.
2.1.0 (2... |
zopefoundation__zope.configuration-25 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "docs/conf.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/configuration/... | zopefoundation/zope.configuration | 51b58dfb1fadff0a2c40b0b9beb97deb0cf5c9c7 | `includeOverrides` documentation is misleading
In https://bugs.launchpad.net/zope.configuration/+bug/163684, @miohtama reported:
> Both http://apidoc.zope.org/++apidoc++/ZCML/ALL/includeOverrides/index.html and http://apidoc.zope.org/++apidoc++/ZCML/ALL/include/index.html have the same documentation. I guess `includeO... | diff --git a/docs/conf.py b/docs/conf.py
index f74063b..9fffd20 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -11,7 +11,11 @@
# All configuration values have a default; values that are commented out
# serve to show the default.
-import sys, os
+import sys
+import os
+import pkg_resources
+sys.path.append(os.path.... |
zopefoundation__zope.configuration-29 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/configuration/fiel... | zopefoundation/zope.configuration | cd96619be3714183270889b5f0037bebed8cb067 | Dotted name resolver accepts '/' as module name separator
In https://bugs.launchpad.net/zope.configuration/+bug/161984 @ctheune reported:
> It's possible to do something like this:
>
> ``` xml
> <include package="zope/config.config"/>
> ```
>
> This will result in a separate import so that `zope.config.config` and `... | diff --git a/CHANGES.rst b/CHANGES.rst
index 66f0250..3cd9280 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -27,6 +27,20 @@ Changes
doctests on both Python 2 and Python 3. See `issue 21
<https://github.com/zopefoundation/zope.configuration/issues/21>`_.
+- Fix ``GlobalObject`` and ``GlobalInterface`` fields to ... |
zopefoundation__zope.configuration-33 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/configuration/config.py:ConfigurationContext.path"
],
"edited_modules": [
"src/zope/configuration/config.py:ConfigurationContext"
]
},
"file": "src/zope/config... | zopefoundation/zope.configuration | 3d013be0997fc9aae6031bca4b82a9d4f2d8013c | `fields.Path` doesn't handle home directories
In https://bugs.launchpad.net/zope.configuration/+bug/494493, @batlock666 reported:
> The fieldtype Path from zope.configuration.fields doesn't handle home directories, indicated by a ~ in the path. The path ~/some.file will be interpreted as /path/to/some/package/~/some.f... | diff --git a/CHANGES.rst b/CHANGES.rst
index 3cd9280..99874f1 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -16,6 +16,11 @@ Changes
- Drop support for ``python setup.py test``.
+- Make ``zope.configuration.fields.Path`` and
+ ``zope.configuration.config.ConfigurationContext`` expand
+ environment variables and e... |
zopefoundation__zope.configuration-34 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/configuration/config.py:ConfigurationMachine.execute_actions"
],
"edited_modules": [
"src/zope/configuration/config.py:ConfigurationMachine"
]
},
"file": "src/... | zopefoundation/zope.configuration | 6fa6e4824182f63e23d0ee36c06f4af2d5af50b2 | zope.configuration swallowing expat parser errors
In https://bugs.launchpad.net/zope.configuration/+bug/558501, @zopyx reported:
> See https://mail.zope.org/pipermail/zope-cmf/2010-April/029016.html
```
GenericSetup: Install.py komplett abgelöst context.execute_actions()
File "/home/ajung/sandboxes/hu/parts/zope2/... | diff --git a/CHANGES.rst b/CHANGES.rst
index 99874f1..00e185a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -46,6 +46,18 @@ Changes
``fromUnicode``. See `issue 28
<https://github.com/zopefoundation/zope.configuration/issues/28>`_.
+- Add ``ConfigurationMachine.pass_through_exceptions`` to allow
+ customizing t... |
zopefoundation__zope.configuration-37 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/configuration/fields.py:GlobalObject.fromUnicode"
],
"edited_modules": [
"src/zope/configuration/fields.py:GlobalObject"
]
},
"file": "src/zope/configuration/f... | zopefoundation/zope.configuration | abac0539cfae8365ca69b949983f588ec9bbfe52 | Regression in 4.2: GlobalObject fields no longer allow just "."
This shows up in `zope.preference`:
```xml
<configure
xmlns="http://namespaces.zope.org/zope"
xmlns:apidoc="http://namespaces.zope.org/apidoc"
xmlns:zcml="http://namespaces.zope.org/zcml"
i18n_domain="zope"
>
<include packag... | diff --git a/CHANGES.rst b/CHANGES.rst
index 57d0c26..603460c 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,9 @@ Changes
4.2.1 (unreleased)
------------------
-- Nothing changed yet.
+- Fix ``GlobalObject`` (and ``GlobalInterface``) no longer allowing
+ just a single '.'. See `issue 35
+ <https://github.c... |
zopefoundation__zope.configuration-42 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/configuration/fields.py:GlobalObject.fromUnicode"
],
"edited_modules": [
"src/zope/configuration/fields.py:GlobalObject"
]
},
"file": "src/zope/configuration/f... | zopefoundation/zope.configuration | 722d905d52436799f10e5781f56d2e2628703a63 | Regression in 4.2.x: Multiple leading dots for GlobalObject/Interface fail
For example,
```xml
<adapter factory=".adapters._PayeezyPurchaseAttemptFactory"
for="...interfaces.IPurchaseAttempt"
for="nti.store.interfaces.IPurchaseAttempt"
provides=".interfaces.IPayeezyPurchaseAttempt" />
```
results in
... | diff --git a/CHANGES.rst b/CHANGES.rst
index 1a85654..52a1426 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,9 @@ Changes
4.2.2 (unreleased)
------------------
-- Nothing changed yet.
+- Fix ``GlobalObject`` (and ``GlobalInterface``) no longer allowing
+ multiple leading dots. See `issue 41
+ <https://gith... |
zopefoundation__zope.configuration-45 | [
{
"changes": {
"added_entities": [
"src/zope/configuration/config.py:ConfigurationConflictError._with_details"
],
"added_modules": null,
"edited_entities": [
"src/zope/configuration/config.py:ConfigurationMachine.execute_actions",
"src/zope/configuration/config.py... | zopefoundation/zope.configuration | 7c98fbbc5b1b864ce76ef235c8152054eaf6b96f | Exception chaining is excessive
There were some recent zope.schema and/or zope.configuration releases that broke ZODBBrowser (and many other things). This bug is not about that. This bug is about error reporting on Python 3.
Here's the series of chained exception tracebacks I get on Python 3.6 when there's an erro... | diff --git a/CHANGES.rst b/CHANGES.rst
index 93d7bef..19389a2 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,8 @@ Changes
4.2.3 (unreleased)
------------------
-- Nothing changed yet.
+- Simplify exception chaining and nested exception error messages.
+ See `issue 43 <https://github.com/zopefoundation/zope.... |
zopefoundation__zope.container-19 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/container/constraints.py:checkObject",
"src/zope/container/constraints.py:checkFactory",
"src/zope/container/constraints.py:ItemTypePrecondition.factory",
"src/zope/cont... | zopefoundation/zope.container | 14b41f52058a21164df92ab1d4f86de6dd90960b | OrderedContainer uses the wrong name in `self._order` and rejects ascii keys under Python 3
It uses `z.c.contained.setitem()` to put the data in `self._data`. That function will decode a `bytes` key if needed before storing it with the provided `__setitem__` function. But OrderedContainer stores the original value, not... | diff --git a/.coveragerc b/.coveragerc
index 524acac..fdbb39f 100644
--- a/.coveragerc
+++ b/.coveragerc
@@ -7,3 +7,4 @@ exclude_lines =
if __name__ == '__main__':
raise NotImplementedError
self.fail
+ raise AssertionError
diff --git a/CHANGES.rst b/CHANGES.rst
index e6ef488..b8dc77a 100644
--- a/CHAN... |
zopefoundation__zope.datetime-7 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/datetime/__init__.py:_calcYMDHMS",
"src/zope/datetime/__init__.py:_calendarday",
"src/zope/datetime/__init__.py:safegmtime",
"src/zope/datetime/__init__.py:safelocaltime... | zopefoundation/zope.datetime | f988d009e5f7e54b4869a6d86d6d452b19403df3 | 32-bit platforms, time.localtime() and guessing a timezone when not provided
This follows from the discussion at https://github.com/zopefoundation/zope.datetime/pull/3#issuecomment-320047726 where I identified a difference in the value produced by `_calendarday` for certain values on Python 2 and Python 3.
In looki... | diff --git a/CHANGES.rst b/CHANGES.rst
index 85f5ed8..826fcfe 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,21 @@
4.2.0 (unreleased)
==================
+- Remove support for guessing the timezone name when a timestamp
+ exceeds the value supported by Python's ``localtime`` function. On
+ platforms with a ... |
zopefoundation__zope.error-4 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/error/error.py:ErrorReportingUtility.raising"
],
"edited_modules": [
"src/zope/error/error.py:ErrorReportingUtility"
]
},
"file": "src/zope/error/error.py"
}... | zopefoundation/zope.error | 37e3820202fb84ecac44f3d23e743e8f032d5577 | ErrorReportingUtility.raising leaks requests
```
if hasattr(request, 'URL'):
url = request.URL
```
URL is URLGetter, not a simple string
That's a huge issue in tests, every request running into an exception leaves the Request around. | diff --git a/CHANGES.rst b/CHANGES.rst
index 6848934..f74b382 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -8,6 +8,8 @@ Changes
- Drop support for Python 2.6.
+- bugfix: fix leak by converting ``request.URL`` to string in
+ ``ErrorReportingUtility``
4.2.0 (2014-12-27)
------------------
diff --git a/src/zope... |
zopefoundation__zope.generations-9 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
... | zopefoundation/zope.generations | 63801e6798ec129c7cf1ae7e59c23291b071ec63 | `evolve` not fully compatible with an explicit TransactionManager
When actually executing user-supplied evolutions, `evolve` is careful to call `transaction.begin()` before executing any actions or committing/aborting.
However, in the earlier stages, there are a few places it calls `commit()` without calling `begin(... | diff --git a/CHANGES.rst b/CHANGES.rst
index 6c2743a..56dfef0 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,10 +2,15 @@
CHANGES
=========
-4.1.1 (unreleased)
+5.0.0 (unreleased)
==================
-- Nothing changed yet.
+- Add support for transaction managers operating in explicit mode.
+ Schema managers w... |
zopefoundation__zope.i18n-39 | [
{
"changes": {
"added_entities": [
"src/zope/i18n/format.py:NumberFormat._grouping_intervals",
"src/zope/i18n/format.py:NumberFormat._group"
],
"added_modules": null,
"edited_entities": [
"src/zope/i18n/format.py:NumberFormat.format",
"src/zope/i18n/format... | zopefoundation/zope.i18n | a706a1fcd827aa0094ef23b86ac47840c16be465 | NumberFormat is not prepared for 'lakh' it always assumes triple grouping
`zope.i18n.format.NumberFormat` assumes that number thousand grouping is always 3, the grouping by 3 is hardcoded.
`zope/i18n/locales/data/en_IN.xml` has the right formatting:
```
<currencyFormat >
<pattern>¤ ##,##,##0.00;-¤ ##,#... | diff --git a/CHANGES.rst b/CHANGES.rst
index ae2374d..e2085c4 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,8 @@
4.6.2 (unreleased)
==================
-- Nothing changed yet.
+- Fix `NumberFormat` to respect the thousand grouping given by the pattern.
+ Triple grouping was hardcoded, which is not true for ... |
zopefoundation__zope.index-23 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/index/text/ricecode.py:decode_deltas"
],
"edited_modules": [
"src/zope/index/text/ricecode.py:decode_deltas"
]
},
"file": "src/zope/index/text/ricecode.py"
}... | zopefoundation/zope.index | 740285a2f27ed23549e09603e5cdb44ac0019671 | Tests can randomly fail
`zope.index.text.ricecode.encode_deltas(a_list)` returns a tuple `(start, deltas)`. Usually `deltas` is an instance of `zope.index.text.ricecode.RiceCode`, but when `len(a_list) == 1)`, `deltas` is a simple `[]`.
This is an awkward API that causes problems: the inverse `decode_deltas(start, ... | diff --git a/CHANGES.rst b/CHANGES.rst
index def94ac..c7bbf74 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,8 @@
4.4.1 (unreleased)
==================
-- Nothing changed yet.
+- Fix ``zope.index.text.ricecode.decode_deltas(..., [])``. See
+ `issue 22 <https://github.com/zopefoundation/zope.index/issues/22... |
zopefoundation__zope.interface-159 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/interface/interfac... | zopefoundation/zope.interface | fec4a51b1ce8526de23c2558bfd26e253c4b6250 | Remove support for "hashing" uninitialized interfaces
Since [this commit in 2011](https://github.com/zopefoundation/zope.interface/commit/05a899a8275bbd6b2e332a4fbfeab4d7e1dc40f8) (zope.interface 3.6.5) we've been emitting a warning if a buggy subclass of `InterfaceClass` attempted to hash itself before completing its ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 77fecbd..1d6923c 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,7 +2,7 @@
Changes
=========
-4.8.0 (unreleased)
+5.0.0 (unreleased)
==================
- Support the ``PURE_PYTHON`` environment variable at runtime instead
@@ -33,11 +33,20 @@
- Likewise, tagged v... |
zopefoundation__zope.interface-160 | [
{
"changes": {
"added_entities": [
"src/zope/interface/declarations.py:_ImmutableDeclaration.__new__",
"src/zope/interface/declarations.py:_ImmutableDeclaration.__reduce__",
"src/zope/interface/declarations.py:_ImmutableDeclaration.__bases__",
"src/zope/interface/declaratio... | zopefoundation/zope.interface | c120080902ea01432bceefa329b8c40a34782552 | `_empty` singleton is mutable
zope.interface.declarations returns a global `_empty` Declaration object in a few cases. But this object is fully mutable: its bases can be set, it can be subscribed and have dependents added. That doesn't seem safe for a global object.
Can we either:
- Stop returning a global objec... | diff --git a/CHANGES.rst b/CHANGES.rst
index 1d6923c..cfb52d4 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,13 @@
5.0.0 (unreleased)
==================
+- Make an internal singleton object returned by APIs like
+ ``implementedBy`` and ``directlyProvidedBy`` immutable. Previously,
+ it was fully mutable an... |
zopefoundation__zope.interface-164 | [
{
"changes": {
"added_entities": [
"src/zope/interface/declarations.py:_ImmutableDeclaration.weakref"
],
"added_modules": null,
"edited_entities": [
"src/zope/interface/declarations.py:_ImmutableDeclaration.changed",
"src/zope/interface/declarations.py:getObjectSp... | zopefoundation/zope.interface | 489328a5afc1430a064db2dba7a7a408591789f9 | Possible problem with _ImmutableDeclaration?
With the current master and Plone there are some failiures. One of them here:
```
Failed example:
IKeyReference(item_c)
Expected:
Traceback (most recent call last):
...
TypeError: ('Could not adapt', <SimpleItem at c>,
<InterfaceClass zope.keyre... | diff --git a/CHANGES.rst b/CHANGES.rst
index ad7140b..ae900d8 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -54,12 +54,18 @@
fields in your subclass before attempting to hash or sort it. See
`issue 157 <https://github.com/zopefoundation/zope.interface/issues/157>`_.
-- Remove unneeded overwrite and call to anyw... |
zopefoundation__zope.interface-172 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/zope/interface/_compat.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zo... | zopefoundation/zope.interface | 0048a56bac299db7c78a9c8e52c5928e4ec06f38 | cannot create an IDict interface that passes verifyObject on cpython and pypy
```python
class IDict(Interface):
def get(k, default=None):
pass
def pop(k, default=None):
pass
```
It doesn't appear possible to describe the dict as an interface using z.i. The only reason it works on CPyt... | diff --git a/CHANGES.rst b/CHANGES.rst
index bf23808..efb7b88 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -81,6 +81,21 @@
`issue 153
<https://github.com/zopefoundation/zope.interface/issues/153>`_.
+- Fix ``verifyClass`` and ``verifyObject`` for builtin types like
+ ``dict`` that have methods taking an optio... |
zopefoundation__zope.interface-173 | [
{
"changes": {
"added_entities": [
"src/zope/interface/exceptions.py:_TargetMixin._prefix"
],
"added_modules": [
"src/zope/interface/exceptions.py:_TargetMixin"
],
"edited_entities": [
"src/zope/interface/exceptions.py:DoesNotImplement.__init__",
"sr... | zopefoundation/zope.interface | cc537c613ba6dd1a076202e2144fdacfccc520d2 | Strange indentation and newlines for Invalid exceptions
While looking at #118, I noticed that the error message produced is quite strangely formatted:
```
BrokenMethodImplementation: The implementation of pop violates its contract
because implementation requires too many arguments.
```
This comes down ... | diff --git a/CHANGES.rst b/CHANGES.rst
index efb7b88..b484a99 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -96,6 +96,18 @@
verify as ``IFullMapping``, ``ISequence`` and ``IReadSequence,``
respectively on all versions of Python.
+- Add human-readable ``__str___`` and ``__repr___`` to ``Attribute``
+ and ``Meth... |
zopefoundation__zope.interface-174 | [
{
"changes": {
"added_entities": [
"src/zope/interface/exceptions.py:_TargetInvalid._get_arg_or_default",
"src/zope/interface/exceptions.py:_TargetInvalid.interface",
"src/zope/interface/exceptions.py:_TargetInvalid.target",
"src/zope/interface/exceptions.py:_TargetInvalid.... | zopefoundation/zope.interface | d6343eeaa7f67838db9de82974898b80938a7aef | verify[Object|Class] should report all errors found
It's painful to work through errors one at a time when all errors could be reported at once. | diff --git a/.travis.yml b/.travis.yml
index dd4c3e0..8b5bd09 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -82,17 +82,22 @@ before_install:
fi
install:
- - pip install -U pip setuptools
- - pip install -U coveralls coverage
- - pip install -U -e ".[test]"
+ # virtualenv 20.0 together with terryfy macOS is ... |
zopefoundation__zope.interface-181 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "docs/conf.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null... | zopefoundation/zope.interface | c931999371b106ca4638a5cfb40fe0e431840358 | `providedBy` does not respect `super`
In https://bugs.launchpad.net/zope.interface/+bug/448712, Dieter Maurer reported:
> In some places, the implementation of a subclass adapter may take advantage of that defined for a base class. In such cases, "super" comes to mind. Unfortunately, "providedBy" (implicitely during i... | diff --git a/.travis.yml b/.travis.yml
index 8b5bd09..d77892f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -27,10 +27,6 @@ jobs:
- sphinx-build -b doctest -d docs/_build/doctrees docs docs/_build/doctest
after_success:
- - name: PyPy C Extensions
- env: PURE_PYTHON=0
- python: pypy
-
... |
zopefoundation__zope.interface-188 | [
{
"changes": {
"added_entities": [
"src/zope/interface/interface.py:Specification._calculate_sro"
],
"added_modules": null,
"edited_entities": [
"src/zope/interface/interface.py:Specification.changed"
],
"edited_modules": [
"src/zope/interface/interfac... | zopefoundation/zope.interface | bd5a749b5b050b422940193d8d2935e7c88aa7cc | Base class with interface interrupts adapter registered for a class
In https://bugs.launchpad.net/zope.interface/+bug/226112, @ctheune reports:
> See the attached patch for a failing test case.
>
> (Patch applicable against zope.interface trunk)
>
> We're not sure whether this is right or wrong but we feel the inten... | diff --git a/CHANGES.rst b/CHANGES.rst
index 44bb335..3d9bb5d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -160,7 +160,7 @@
- Adopt Python's standard `C3 resolution order
<https://www.python.org/download/releases/2.3/mro/>`_ to compute the
- ``__iro___`` and ``__sro___`` of interfaces, with tweaks to support
+ ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.