instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
astropy__astropy-9246 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/io/fits/hdu/compressed.py:CompImageHeader.__new__",
"astropy/io/fits/hdu/compressed.py:CompImageHeader.__init__"
],
"edited_modules": [
"astropy/io/fits/hdu/compresse... | astropy/astropy | 4c46eb6b09c65b6e66db7d1a8a4b2a40224482bc | LombScargle.false_alarm_probability fails for Quantities
Trying to calculate the Lomb Scragle false alarm probability while using Quantities with units throws an error while executing `fap_baluev`, since the exponent argument has units.
(It works ok when using `method='naive'`)
Using Ubuntu 18.04.3, python 3.7.4, a... | diff --git a/CHANGES.rst b/CHANGES.rst
index b606e3c044..c065ceb98f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -210,10 +210,6 @@ astropy.io.fits
- Masked column handling has changed, see ``astropy.table`` entry below. [#8789]
-- ``io.fits.Header`` has been made safe for subclasses for copying and slicing.
- As... |
astropy__astropy-9273 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/units/quantity_helper/converters.py:check_output"
],
"edited_modules": [
"astropy/units/quantity_helper/converters.py:check_output"
]
},
"file": "astropy/units/... | astropy/astropy | a1e72dd7b8eca5fc95c9f40557e8ceaae30d4d81 | Cannot store output from Quantity comparison in array
Not a super-big deal, but the following should not error:
```
import astropy.units as u, numpy as np
q = np.arange(3.) * u.m
comp = np.empty(q.shape, bool)
np.less(q, 0, out=comp)
---------------------------------------------------------------------------
Typ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 3bf050a8f5..8c822c4d18 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -559,6 +559,9 @@ astropy.uncertainty
astropy.units
^^^^^^^^^^^^^
+- Ensure that output from test functions of and comparisons between quantities
+ can be stored into pre-allocated output arrays (using ... |
astropy__astropy-9342 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/units/quantity.py:Quantity.__new__",
"astropy/units/quantity.py:Quantity._to_own_unit"
],
"edited_modules": [
"astropy/units/quantity.py:Quantity"
]
},
... | astropy/astropy | 3df4073df3bdab6fa304d5ee1ce3156960bea143 | masked Quantity fails on astropy master with numpy 1.17.2
Masked `Quantity` started failing with `astropy` master and `numpy 1.17.2`:
```python
>>> import numpy as np
>>> import astropy.units as u
>>> masked_quantity = np.ma.array([1, 2, 3 ,4] * u.kg,
... mask=[True, False, True, ... | diff --git a/astropy/units/quantity.py b/astropy/units/quantity.py
index 7aa4747fce..c8a3778bb8 100644
--- a/astropy/units/quantity.py
+++ b/astropy/units/quantity.py
@@ -369,8 +369,7 @@ class Quantity(np.ndarray):
# check that array contains numbers or long int objects
if (value.dtype.kind in 'OSU' a... |
astropy__astropy-9368 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/time/core.py:_make_array"
],
"edited_modules": [
"astropy/time/core.py:_make_array"
]
},
"file": "astropy/time/core.py"
},
{
"changes": {
"added_e... | astropy/astropy | c59a0085f68071269780adbf7634f0dddd0384e1 | Impossible to input np.longdouble into custom time formats
I am trying to write a custom time format "mjd_long" which accepts and returns np.longdouble values upon conversion, to make nanosecond accuracy easier. Unfortunately during the preparation stage, before values are handed off to the custom code, they are passed... | diff --git a/CHANGES.rst b/CHANGES.rst
index 706f15e95d..baaed90cce 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -369,6 +369,9 @@ astropy.time
- Time formats that do not use ``val2`` now raise ValueError instead of
silently ignoring a provided value. [#9373]
+- Custom time formats can now accept floating-point t... |
astropy__astropy-9377 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/constants/constant.py:ConstantMeta.__new__"
],
"edited_modules": [
"astropy/constants/constant.py:ConstantMeta"
]
},
"file": "astropy/constants/constant.py"
}... | astropy/astropy | c749c33a7303ac481a56638959e0fcf50eff805d | Pickle test on constants all set to xfail
Looking over #5694, I noticed that `constants.tests.test_pickle` runs tests that are all set to fail. This is mostly a reminder to understand why this is, and whether something needs to be changed. | diff --git a/CHANGES.rst b/CHANGES.rst
index 3bfecd1597..5894060123 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -15,6 +15,8 @@ astropy.constants
- Default constants now use CODATA 2018 and IAU 2015 definitions. [#8761]
+- Constants can be pickled and unpickled. [#9377]
+
astropy.convolution
^^^^^^^^^^^^^^^^^^^... |
astropy__astropy-9383 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/constants/constant.py:ConstantMeta.__new__"
],
"edited_modules": [
"astropy/constants/constant.py:ConstantMeta"
]
},
"file": "astropy/constants/constant.py"
}... | astropy/astropy | cf381c4404e4a8f69d470d5b5f057f17aebee56d | np.insert gives UnitConversionError with Numpy 1.17.0 (used to work)
Here is a minimal reproducible code snippet:
```python
import numpy as np
from astropy import units as u
PHOTLAM = u.ph / u.cm / u.cm / u.s / u.AA
flux = np.arange(5) * PHOTLAM
newflux = np.insert(flux, 0, 0)
```
With `astropy 4.0.dev25566` ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 5894060123..3bfecd1597 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -15,8 +15,6 @@ astropy.constants
- Default constants now use CODATA 2018 and IAU 2015 definitions. [#8761]
-- Constants can be pickled and unpickled. [#9377]
-
astropy.convolution
^^^^^^^^^^^^^^^^^^^... |
astropy__astropy-9390 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/io/fits/convenience.py:table_to_hdu"
],
"edited_modules": [
"astropy/io/fits/convenience.py:table_to_hdu"
]
},
"file": "astropy/io/fits/convenience.py"
}
] | astropy/astropy | 15e920374ab54901718242f75d813733c70cb54c | `table_to_hdu` warns about reserved keywords 'NAXIS', 'NAXIS1', but does not ignore them
### Description
When converting a table with existing keys with reserved keywords in `table.meta`, `table_to_hdu` duly warns
`Meta-data keyword NAXIS1 will be ignored since it conflicts with a FITS reserved keyword`
but does not... | diff --git a/CHANGES.rst b/CHANGES.rst
index 5894060123..4f3c41b319 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -438,6 +438,9 @@ astropy.io.misc
astropy.io.fits
^^^^^^^^^^^^^^^
+- Implemented skip (after warning) of header cards with reserved
+ keywords in ``table_to_hdu``. [#9390]
+
astropy.io.registry
^^^^^^... |
astropy__astropy-9408 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/io/fits/convenience.py:table_to_hdu"
],
"edited_modules": [
"astropy/io/fits/convenience.py:table_to_hdu"
]
},
"file": "astropy/io/fits/convenience.py"
},
{... | astropy/astropy | 3f9332a588f303a73803a487181e9529d703bde9 | Inconsistent keyword names for binom_conf_interval and poisson_conf_interval
The functions ``binom_conf_interval`` and ``poisson_conf_interval`` in astropy.stats both have a keyword argument for the confidence level, but one is called ``conf`` and the other one ``conflevel``. Can we consider renaming the most recent on... | diff --git a/CHANGES.rst b/CHANGES.rst
index e399e6a3aa..9e4c13e186 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -364,6 +364,18 @@ astropy.stats
- Renamed the ``a`` parameter to ``data`` in ``median_absolute_deviation``.
[#9011]
+- Renamed the ``conflevel`` keyword to ``confidence_level`` in
+ ``poisson_conf_in... |
astropy__astropy-9513 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astropy/stats/bayesian_blocks.py:FitnessFunc.validate_input"
],
"edited_modules": [
"astropy/stats/bayesian_blocks.py:FitnessFunc"
]
},
"file": "astropy/stats/bayesian_... | astropy/astropy | e2d877ec06745979b844a8d82bc137204726ae72 | Bayesian Blocks type error
Hi,
I'm trying to use the Bayesian Block routine but when I use the 'events' method, I always get this error message:
```
sgra_edges = bayesian_blocks(sgra_time, sgra_counts, sgra_counts_err, fitness='events', p0=0.05)
File "/home/elie/anaconda2/lib/python2.7/site-packages/astrop... | diff --git a/CHANGES.rst b/CHANGES.rst
index 8f95bd98c6..e66b543467 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -700,6 +700,9 @@ astropy.stats
- Fixed a bug where ``bayesian_blocks`` returned a single edge. [#8560]
+- Fixed input data type validation for ``bayesian_blocks`` to work int
+ arrays. [#9513]
+
astr... |
astropy__astroquery-2160 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "astroquery/utils/commons.py"
}
] | astropy/astroquery | 241d896bede51d68dc48d02f3569d532178492ef | Deprecate commons.send_request
Once the last usage of ``commons.send_request`` is removed, see #824, it should be deprecated in favour of ``BaseQuery._request``. | diff --git a/astroquery/utils/commons.py b/astroquery/utils/commons.py
index cba49f2a..de1e3a02 100644
--- a/astroquery/utils/commons.py
+++ b/astroquery/utils/commons.py
@@ -16,7 +16,7 @@ import six
import astropy.units as u
from astropy import coordinates as coord
from collections import OrderedDict
-from astropy.... |
astropy__astroquery-2318 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/esa/hubble/core.py:ESAHubbleClass.get_member_observations",
"astroquery/esa/hubble/core.py:ESAHubbleClass.get_hap_hst_link",
"astroquery/esa/hubble/core.py:ESAHubbleClass.get_... | astropy/astroquery | 525837073d8fecda0610a2cc7c38dc6e6356e76b | SDSS.query_crossid doesn't work for DR<10
Run into this with the test suite, didn't investigate in detail. It likely just needs the URLs fixed. Could you maybe have a look @weaverba137?
```
In [1]: from astroquery import sdss
In [2]: from astropy.coordinates import SkyCoord
...: from astropy.table import Ta... | diff --git a/CHANGES.rst b/CHANGES.rst
index c82d3a62..571a1ef7 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -3,17 +3,10 @@
New Tools and Services
----------------------
-esa.hubble
-^^^^^^^^^^
-- Added new method ``get_hap_hst_link`` and ``get_member_observations`` to get related observations [#2268]
Service... |
astropy__astroquery-2444 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/svo_fps/core.py:SvoFpsClass.get_filter_index"
],
"edited_modules": [
"astroquery/svo_fps/core.py:SvoFpsClass"
]
},
"file": "astroquery/svo_fps/core.py"
}
] | astropy/astroquery | 2543cc26f4ee53a0aaa4c629e814adf8a3ff93d2 | SvoFps.get_filter_index unit conversion issue?
```
wmin = 5000 * units.angstrom
wmax = 7000 * units.angstrom
index_a = svo.get_filter_index(wavelength_eff_min = wmin, \
wavelength_eff_max = wmax, timeout = 180)
```
returns 3026 filters, but changing the units to ... | diff --git a/CHANGES.rst b/CHANGES.rst
index e72116da..aa439514 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -62,6 +62,12 @@ oac
- Fix bug in parsing events that contain html tags (e.g. in their alias
field). [#2423]
+svo_fps
+^^^^^^^
+
+- The wavelength limits in ``get_filter_index()`` can now be specified usin... |
astropy__astroquery-2457 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/alma/tapsql.py:_val_parse"
],
"edited_modules": [
"astroquery/alma/tapsql.py:_val_parse"
]
},
"file": "astroquery/alma/tapsql.py"
}
] | astropy/astroquery | 292ef51b951f58fd802d1ca5ed1b839fff37e1e1 | ALMA: Cannot select multiple science keywords
I attempted this query:
```python
result = Alma().query(payload={'spatial_resolution':'<0.1', 'science_keyword':
['High-mass star formation',
'Disks around high-mass stars']},
public=T... | diff --git a/CHANGES.rst b/CHANGES.rst
index df9d6e56..d951b9a5 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -20,6 +20,11 @@ hsa
Service fixes and enhancements
------------------------------
+alma
+^^^^
+
+- Fixed a regression to handle arrays of string input for the ``query`` methods. [#2094]
+
cadc
^^^^
diff... |
astropy__astroquery-2475 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/alma/core.py:_gen_sql",
"astroquery/alma/core.py:AlmaClass.query_async",
"astroquery/alma/core.py:AlmaClass.is_proprietary"
],
"edited_modules": [
"astroqu... | astropy/astroquery | b1fcfff5bf77255a7d24f17eafe0b9f455d5f598 | Throw an error when unsupported arguments are passed in `astroquery.alma`
A user recently tried to issue this:
```python
from astroquery.alma import Alma
from astropy import units as u
rs = Alma.query_object("V* CW Cha", radius=0.05*u.arcmin, public=True, science=True)
print(len(set(rs['obs_id'])))
```
The `... | diff --git a/CHANGES.rst b/CHANGES.rst
index d951b9a5..3ababeb7 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -24,6 +24,7 @@ alma
^^^^
- Fixed a regression to handle arrays of string input for the ``query`` methods. [#2094]
+- Throws an error when an unsupported ``kwargs`` (or argument) is passed in to a function. ... |
astropy__astroquery-2477 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/sdss/core.py:SDSSClass.query_crossid_async",
"astroquery/sdss/core.py:SDSSClass.query_region_async",
"astroquery/sdss/core.py:SDSSClass.query_specobj_async",
"astroque... | astropy/astroquery | b1fcfff5bf77255a7d24f17eafe0b9f455d5f598 | Make SDSS query region a circle
This issue was discussed in #545, but we opted to do it as a separate fix so the other work in #545 could get in sooner.
Basically, the SDSS region queries (which have a `radius`) keyword in fact search a box instead of a circular region on the sky. That needs to be fixed. I think @we... | diff --git a/CHANGES.rst b/CHANGES.rst
index d951b9a5..2569ee37 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -83,6 +83,11 @@ gaia
With this change the epoch photometry service returns all data associated
to a given source. [#2376]
+sdss
+^^^^
+
+- ``query_region()`` now does a cone search around the specified
... |
astropy__astroquery-2509 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/svo_fps/core.py:SvoFpsClass.get_filter_index"
],
"edited_modules": [
"astroquery/svo_fps/core.py:SvoFpsClass"
]
},
"file": "astroquery/svo_fps/core.py"
}
] | astropy/astroquery | 85b39375ca582d1da79a3d55889a1955546b6e0a | Cannot connect to SVO Filter Profile Service
There seem to be connectivity issues with the SVO Filter Profile Service (FPS). The following code (from the [tutorial](https://astroquery.readthedocs.io/en/latest/svo_fps/svo_fps.html))
```
from astroquery.svo_fps import SvoFps
index = SvoFps.get_filter_index()
```
... | diff --git a/CHANGES.rst b/CHANGES.rst
index 9f01291d..db057364 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -110,6 +110,9 @@ svo_fps
- Queries with invalid parameter names now raise an ``InvalidQueryError``.
[#2446]
+- The default wavelength range used by ``get_filter_index()`` was far too
+ large. The user mu... |
astropy__astroquery-2532 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/sdss/core.py:SDSSClass.get_spectra_async",
"astroquery/sdss/core.py:SDSSClass.get_spectra",
"astroquery/sdss/core.py:SDSSClass.get_images_async",
"astroquery/sdss/core... | astropy/astroquery | 436245056c3e624b08abb0095a1bbec642ed1526 | SDSS: add get_query_payload kwarg back to all methods
With the recent refactoring in #2477 it got refactored out from a few methods, this is a reminder issue that it should be, and systematically, added back to all methods to help with quick debugging. | diff --git a/CHANGES.rst b/CHANGES.rst
index 373f9faf..bcf8521b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -141,6 +141,7 @@ sdss
- The default data release has been changed to DR17. [#2478]
+- Optional keyword arguments are now keyword only. [#2477, #2532]
Infrastructure, Utility and Other Changes and Addi... |
astropy__astroquery-2535 | [
{
"changes": {
"added_entities": [
"astroquery/alma/core.py:AlmaClass.is_datalink_adhoc_service",
"astroquery/alma/core.py:AlmaClass.get_adhoc_service_access_url",
"astroquery/alma/core.py:AlmaClass.get_adhoc_service_parameter"
],
"added_modules": null,
"edited_en... | astropy/astroquery | 8898b5448218dfff004243e1a809816922e82f31 | BUG: alma ignores timeout
The remote tests timeout in the alma module after running for hours (locally it's all good) which highlights the issue that the timeout configitem is not used in the module.
Having a functional timeout would be useful beyond the test suite.
cc @andamian | diff --git a/astroquery/alma/core.py b/astroquery/alma/core.py
index f6106ba2..ecba0bf6 100644
--- a/astroquery/alma/core.py
+++ b/astroquery/alma/core.py
@@ -158,6 +158,9 @@ ALMA_FORM_KEYS = {
# used to lookup the TAP service on an ARC
TAP_SERVICE_PATH = 'tap'
+# standard ID URI to look for when expanding TAR file... |
astropy__astroquery-2625 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"astroquery/jplhorizons/__init__.py:Conf"
]
},
"file": "astroquery/jplhorizons/__init__.py"
},
{
"changes": {
"added_entities": [
"astroq... | astropy/astroquery | a867890164e7130ba2e625341817e355e8c2bb09 | Topographic position disallowed in vectors query but would be useful for tracking
With these example definitions
```
DSN_goldstone = '257@399'
SSN_millstone = {'lon':-71.490967, 'lat':42.617442, 'elevation':0.127}
epochs = {'start': '1998-01-23 06:00:00', 'stop': '1998-01-23 12:00:00', 'step': '1m'}
spacecraft='NE... | diff --git a/CHANGES.rst b/CHANGES.rst
index e5351c15..82633349 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -100,6 +100,9 @@ jplhorizons
- Optional keyword arguments are now keyword only. [#1802]
+- Topocentric coordinates can now be specified for both center and target in observer
+ and vector queries. [#2625]... |
astropy__astroquery-2654 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"astroquery/sdss/__init__.py:Conf"
]
},
"file": "astroquery/sdss/__init__.py"
}
] | astropy/astroquery | 8b24c19057bdd0b51028ac545983149abc87b05a | BUG: SDSS KeyNotFoundException for query_region
Hi, I am having the same problem with:
astroquery 0.4.7.d
python 3.10.9
numpy 1.23.5.
Using (for example) the example in the doc, as any other call:
```
from astropy.coordinates import SkyCoord
from astroquery.sdss import SDSS
pos = SkyCoord('0h8m05.63s +14d... | diff --git a/CHANGES.rst b/CHANGES.rst
index b5e250b5..d684e740 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -151,6 +151,12 @@ oac
- Fix bug in parsing events that contain html tags (e.g. in their alias
field). [#2423]
+sdss
+^^^^
+
+- Switching to https to avoid issues originating in relying on server side
+ r... |
astropy__astroquery-2663 | [
{
"changes": {
"added_entities": [
"astroquery/sdss/core.py:SDSSClass._rectangle_sql"
],
"added_modules": null,
"edited_entities": [
"astroquery/sdss/core.py:SDSSClass.query_region_async",
"astroquery/sdss/core.py:SDSSClass.query_sql_async"
],
"edited_... | astropy/astroquery | 766a4fcd25333968381ec4c3975389327e82ec09 | Re-enable rectangular search for SDSS query_region
#2477 Removed rectangular search from `query_region` in `SDSS` and converted it to a cone search. However, a drawback was not significantly discussed:
- The rectangular search can use a much larger "radius" i.e. field size. The limit for a cone search is 3 arcmin wh... | diff --git a/CHANGES.rst b/CHANGES.rst
index c44aa847..2413c14d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -217,8 +217,8 @@ gaia
sdss
^^^^
-- ``query_region()`` now does a cone search around the specified
- coordinates. [#2477]
+- ``query_region()`` can perform cone search or a rectangular
+ search around the ... |
astropy__astroquery-2966 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "astroquery/utils/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroqu... | astropy/astroquery | 8777126f73696bb63d131a95245d84e83412b3e8 | Dropping python 3.7 support
Before I drop support, would like to see some input from the bigger teams in astroquery. Would you mind if we drop it?
(most big packages are dropping 3.8 (numpy, scipy, etc) in the upcoming releases, and dropped 3.7 a while ago already, and some of the infrastructure packages we use are dr... | diff --git a/CHANGES.rst b/CHANGES.rst
index 6710e9e9..d6d3ac29 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -28,6 +28,11 @@ vizier
Infrastructure, Utility and Other Changes and Additions
-------------------------------------------------------
+- Versions of astropy <5.0 and numpy <1.20 are no longer supported. [#... |
astropy__astroquery-3031 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/mast/cloud.py:CloudAccess.download_file"
],
"edited_modules": [
"astroquery/mast/cloud.py:CloudAccess"
]
},
"file": "astroquery/mast/cloud.py"
},
{
"... | astropy/astroquery | 604f284c1d63ac4ab2dc00c3fc85414786da3db3 | modulate verbosity of astroquery.mast.Observations.download_products()
When using `download_products()` from the astroquery.mast module there is currently no way of modulating the printed output. It currently prints for each downloaded product "Downloading URL ..." (or that file already exists and is not being download... | diff --git a/CHANGES.rst b/CHANGES.rst
index d1e8866b..63bf0c09 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -12,6 +12,7 @@ alma
^^^^
- Added method to return quantities instead of values and regions footprint in alma [#2855]
+
- Added support for frequency_resolution in KHz [#3035]
mpc
@@ -88,8 +89,12 @@ mast... |
astropy__astroquery-3068 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/simbad/core.py:SimbadClass._query"
],
"edited_modules": [
"astroquery/simbad/core.py:SimbadClass"
]
},
"file": "astroquery/simbad/core.py"
}
] | astropy/astroquery | cc25c379de5bbed3ab3d39dc1567cc939ece30f1 | Handling No astronomical object found response
When I run the following script that queries a tiny sky region where Simbad has no object:
```python
from astroquery.simbad import Simbad
from astropy.coordinates import SkyCoord, search_around_sky, Angle
import astropy.units as u
ra = 0
dec = -90
output_table=... | diff --git a/astroquery/simbad/core.py b/astroquery/simbad/core.py
index 1f901aa3..9f16ea12 100644
--- a/astroquery/simbad/core.py
+++ b/astroquery/simbad/core.py
@@ -18,7 +18,7 @@ from astropy.utils.decorators import deprecated_renamed_argument
from astroquery.query import BaseVOQuery
from astroquery.utils import ... |
astropy__astroquery-3105 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/alma/tapsql.py:_gen_pos_sql"
],
"edited_modules": [
"astroquery/alma/tapsql.py:_gen_pos_sql"
]
},
"file": "astroquery/alma/tapsql.py"
}
] | astropy/astroquery | 0667ec801ed66f38f11fcb3eff01d5314d2c9212 | Issue with spatial constraints in Alma.query
The following script:
```python
import matplotlib.pyplot as plt
from astroquery.alma import Alma
from astropy.coordinates import SkyCoord
archive = Alma.query({'spatial_resolution': '0..0.5', 'galactic':'0..360 -2..2'})
coords = SkyCoord(archive['gal_longitude'], arc... | diff --git a/CHANGES.rst b/CHANGES.rst
index aba8224a..79a1cb27 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -22,6 +22,8 @@ alma
- Added support for frequency_resolution in KHz [#3035]
+- Changed the way galactic ranges are used in queries [#3105]
+
ehst
^^^^
diff --git a/astroquery/alma/tapsql.py b/astroquer... |
astropy__astroquery-3116 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/xmatch/core.py:XMatchClass._prepare_sending_table"
],
"edited_modules": [
"astroquery/xmatch/core.py:XMatchClass"
]
},
"file": "astroquery/xmatch/core.py"
... | astropy/astroquery | 88b640990ccb590905c3bc45ebda983c2963b148 | XMatch.query missing cat1 when usign two previously uploaded tables
Hi, I'm trying to match two previously uploaded catalogue this way:
radec_mid = SkyCoord(a_mid, d_mid, unit=(u.deg, u.deg))
columns = ['Gmag', 'BP-RP', 'RAJ2000', 'DEJ2000', 'ra', 'dec', 'pmra', 'mpdec', 'source_id']
custom_visizer = V... | diff --git a/CHANGES.rst b/CHANGES.rst
index b6e9cc50..aba8224a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -217,6 +217,12 @@ mpc
- Rename ``MPC.get_mpc_object_endpoint`` to ``MPC._get_mpc_object_endpoint`` to
indicate that it is a private method. [#3089]
+xmatch
+^^^^^^
+
+- Fix xmatch query for two local tabl... |
astropy__astroquery-3168 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/xmatch/core.py:XMatchClass._prepare_sending_table"
],
"edited_modules": [
"astroquery/xmatch/core.py:XMatchClass"
]
},
"file": "astroquery/xmatch/core.py"
... | astropy/astroquery | aeccd83259aaa9ebdc9a48325791f89789e4324d | BUG: XMatch two Vizier catalogs then no col refs should be added
When matching two catalogs from Vizier no reference columns should be specified, currently we're wrongly raise an exception:
```
In [17]: from astropy import units as u
...: from astroquery.xmatch import XMatch
...: table = XMatch.query_asyn... | diff --git a/CHANGES.rst b/CHANGES.rst
index 80dfdf76..390c5ab8 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -286,6 +286,9 @@ xmatch
- Fix xmatch query for two local tables. The second table was written over the first one,
resulting in a confusing "missing cat1" error. [#3116]
+- Make the error message clearer a... |
astropy__astroquery-3199 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/simbad/core.py:SimbadClass._add_table_to_output"
],
"edited_modules": [
"astroquery/simbad/core.py:SimbadClass"
]
},
"file": "astroquery/simbad/core.py"
}
... | astropy/astroquery | 5019431af2ce05bc51c18f3626e62790f4f5d3a7 | Measurement tables should be joined with a left join in simbad
Right now, we get an empty result if there is no measurements for every objects in a query. This is because the default join is `INNER` while we really want a `LEFT`.
See https://github.com/TOMToolkit/tom_base/issues/1160 for a concrete failing request. | diff --git a/CHANGES.rst b/CHANGES.rst
index 190780db..5e235856 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -13,6 +13,13 @@ ipac.nexsci.nasa_exoplanet_archive
- Fixed InvalidTableError for DI_STARS_EXEP and TD tables. [#3189]
+simbad
+^^^^^^
+
+- fix: when adding a measurement table in the votable_fields, if a m... |
astropy__astroquery-3224 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/ipac/irsa/core.py:IrsaClass.query_region"
],
"edited_modules": [
"astroquery/ipac/irsa/core.py:IrsaClass"
]
},
"file": "astroquery/ipac/irsa/core.py"
}
] | astropy/astroquery | 819280102e2de055ae4680aa151290dc1ef8e4fc | ENH: make `spatial` kwarg case insensitive
It's internal to astroquery, so there is no reason to be strict with the case. It affects the `irsa` module, `heasarc` has the same keyword but it's already been made case insensitive. | diff --git a/CHANGES.rst b/CHANGES.rst
index 7c832fa3..65811f40 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -37,6 +37,8 @@ ipac.irsa
- Adding support for asynchronous queries using the new ``async_job``
keyword. [#3201]
+- Making ``'spatial'`` keyword in ``query_region`` case insensitive. [#3224]
+
ipac.nexsci... |
astropy__astroquery-3275 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"astroquery/heasarc/core.py:HeasarcClass.locate_data",
"astroquery/heasarc/core.py:HeasarcClass.download_data"
],
"edited_modules": [
"astroquery/heasarc/core.py:HeasarcClass"... | astropy/astroquery | f3f44261e811f690690eed8c2073d0a91e9eca81 | `astroquery.heasarc.locate_data` doesn't returns links for some rows
when retrieving the data from `nicermaster` catalog it return the table same as returned by Heasarc browse interface. But some of files dont have download link(checked from browse interface)
retrieving these files from `astroquery.heasarc.locate_da... | diff --git a/CHANGES.rst b/CHANGES.rst
index ae094673..113b7793 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -18,6 +18,8 @@ heasarc
^^^^^^^
- Add support for astropy.table.Row in Heasarc.download_data and Heasarc.locate_data. [#3270]
+- Heasarc.locate_data returns empty rows with an error in the error_message colu... |
astropy__ccdproc-757 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ccdproc/combiner.py:Combiner.__init__"
],
"edited_modules": [
"ccdproc/combiner.py:Combiner"
]
},
"file": "ccdproc/combiner.py"
}
] | astropy/ccdproc | 4e6da3b2ba516cafbe65683d68e26b988dac6a4f | `Combiner` and `combine` should accept a generator as argument
Both `Combine` and `combiner` should accept a generator (e.g. `Combiner(ifo.ccds())`) instead of requiring that the input be a list (e.g. `Combiner ([ccd for ccd in ifc.ccds()])`). This issue was first raised by @janerigby in #754. | diff --git a/AUTHORS.rst b/AUTHORS.rst
index aaf3470..f067a45 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -56,6 +56,7 @@ Alphabetical list of contributors
* Nathan Walker (@walkerna22)
* Benjamin Weiner (@bjweiner)
* Jiyong Youn (@hletrd)
+* Yash Gondhalekar (@Yash-10)
(If you have contributed to the ccdproc pr... |
astropy__ccdproc-762 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ccdproc/combiner.py:combine"
],
"edited_modules": [
"ccdproc/combiner.py:combine"
]
},
"file": "ccdproc/combiner.py"
}
] | astropy/ccdproc | 1a5934c7dd8010cdfdf7fce34850eded775ba055 | ImageFileCollection not integrated into combine and Combiner
The documentation for ccdproc's ImageFileCollection does not explain how to use ImageFileCollections to combine files. In addition, since ImageFileCollection works on a directory, the results of the method ImageFileCollection.files doesn't have the needed pat... | diff --git a/CHANGES.rst b/CHANGES.rst
index d21f3a1..b9f20a2 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,9 @@
New Features
^^^^^^^^^^^^
+- Improve integration of ``ImageFileCollection`` with image combination
+ and document that integration [#762]
+
Other Changes and Additions
^^^^^^^^^^^^^^^^^^^^^^^^... |
astropy__ccdproc-775 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ccdproc/combiner.py:combine"
],
"edited_modules": [
"ccdproc/combiner.py:combine"
]
},
"file": "ccdproc/combiner.py"
}
] | astropy/ccdproc | 91f2c46d19432d4e818bb7201bb41e8d7383616f | Uncertainty and mask not returned from `combine()`
From Tim-Oliver Husser @thusser on slack:
Just took me an hour to find this "feature" in combiner.py:
```python
def _calculate_size_of_image(ccd,
combine_uncertainty_function):
# If uncertainty_func is given for combine this wi... | diff --git a/ccdproc/combiner.py b/ccdproc/combiner.py
index 176d554..a807d65 100644
--- a/ccdproc/combiner.py
+++ b/ccdproc/combiner.py
@@ -709,6 +709,16 @@ def combine(img_list, output_file=None,
if ccd.data.dtype != dtype:
ccd.data = ccd.data.astype(dtype)
+ # If the template image doesn't have an... |
astropy__extension-helpers-48 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"extension_helpers/__init__.py:_finalize_distribution_hook"
],
"edited_modules": [
"extension_helpers/__init__.py:_finalize_distribution_hook"
]
},
"file": "extension_he... | astropy/extension-helpers | 5bb189521db47b216a368e7161d086addd80f005 | Support for `pyproject.toml` configuration
In this https://github.com/astropy/astropy/pull/14361#issuecomment-1419210239, it was requested that `extension-helpers` support something like:
```ini
[extension-helpers]
use_extension_helpers = true
```
configurations, but in the `pyproject.toml` instead of the `set... | diff --git a/CHANGES.rst b/CHANGES.rst
index 0df9e73..6d63f25 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,8 @@
recommends the ``-Qopenmp`` flag rather than ``-fopenmp`` for greater
performance.
+* Add support for enabling extension-helpers from pyproject.toml. [#48]
+
1.0.0 (2022-03-16)
------------... |
astropy__photutils-1068 | [
{
"changes": {
"added_entities": [
"photutils/segmentation/properties.py:SourceProperties._elliptical_aperture",
"photutils/segmentation/properties.py:SourceProperties._prepare_kron_mask",
"photutils/segmentation/properties.py:SourceProperties._prepare_kron_data",
"photutil... | astropy/photutils | 6ba30b7150bd59bb9d5417ac5349846cbd9739c5 | Kron (and Petrosian) photometry
Again, it would probably be nice to use a modified version @kbarbary's `sep` library for speed. `sep.kronrad` currently returns the Kron radius and a flag array, but one really needs something like a masked array of the pixels within the ellipitical Kron aperture where the mask is `True... | diff --git a/CHANGES.rst b/CHANGES.rst
index 9b69b3fa..088ef3e3 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -24,6 +24,11 @@ New Features
- Added quadratic centroid estimator function
(``centroid_quadratic``). [#1067]
+- ``photutils.segmentation``
+
+ - Added Kron radius, flux, flux error, and aperture to
+... |
astropy__photutils-1292 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/background/background_2d.py:Background2D._reshape_data"
],
"edited_modules": [
"photutils/background/background_2d.py:Background2D"
]
},
"file": "photutils/ba... | astropy/photutils | fe8272af6b93138cc2ab8bd6098872a2078b5cca | Background2D pad bug
Hi. I think `Background2D` could fail when using the `pad` edge method.
I expected `bkg2.background_mesh.shape` to be (9, 16) in the following.
```
data1 = np.ones((128, 256))
data2 = np.ones((129, 256))
bkg1 = Background2D(data1, (16, 16))
bkg2 = Background2D(data2, (16, 16))
print(bkg1... | diff --git a/CHANGES.rst b/CHANGES.rst
index 9ae5a60d..2a56b086 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -32,6 +32,12 @@ Bug Fixes
- Fixed a bug in ``aperture_photometry`` where an error was not raised
if the data and error arrays have different units. [#1285].
+- ``photutils.background``
+
+ - Fixed a ... |
astropy__photutils-1297 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/centroids/core.py:centroid_sources"
],
"edited_modules": [
"photutils/centroids/core.py:centroid_sources"
]
},
"file": "photutils/centroids/core.py"
}
] | astropy/photutils | 33375b46ee5d50dedbf7bbd7edf212abbf867b85 | error with `centroid_func`
When using the `error` keyword with a None value, when using a `centroid_func` which support it,
```
import numpy as np
from photutils.centroids import centroid_sources, centroid_2dg
xc, yc = centroid_sources(np.ones((10,10)), 5, 5, error=None, centroid_func=centroid_2dg)
```
`centr... | diff --git a/CHANGES.rst b/CHANGES.rst
index 2a56b086..c7b45790 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -38,6 +38,12 @@ Bug Fixes
would result in incorrect image padding if only one of the axes needed
padding. [#1292]
+- ``photutils.centroid``
+
+ - Fixed a bug in ``centroid_sources`` where setting... |
astropy__photutils-1312 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/segmentation/catalog.py:SourceCatalog.__init__",
"photutils/segmentation/catalog.py:SourceCatalog._validate_array"
],
"edited_modules": [
"photutils/segmentation/ca... | astropy/photutils | ab71f240b0ef610871165a514355d6bbebdc0839 | SourceCatalog: Cannot cast ufunc 'subtract' output from dtype('float64') to dtype('uint16') with casting rule 'same_kind'
Hello,
I'm trying to extract some source properties using the photutils.segmentation.SourceCatalog, however I'm getting the following error for properties corresponding to ADU counts:
`---------... | diff --git a/CHANGES.rst b/CHANGES.rst
index f1fe142f..85fb110c 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -58,6 +58,11 @@ Bug Fixes
``xpeak``, or ``ypeak`` to ``None`` would result in an error.
[#1297]
+- ``photutils.segmentation``
+
+ - Fixed a bug in ``SourceCatalog`` where a ``UFuncTypeError``... |
astropy__photutils-1477 | [
{
"changes": {
"added_entities": [
"photutils/psf/photometry.py:BasicPSFPhotometry.subshape"
],
"added_modules": null,
"edited_entities": [
"photutils/psf/photometry.py:BasicPSFPhotometry.__init__",
"photutils/psf/photometry.py:BasicPSFPhotometry.nstar",
"... | astropy/photutils | 29d92acce49438c9d22bcdae11c12145f93ce613 | PSF Photometry: Need different box size for fitting vs. PSF subtraction.
In the PSF photometry classes, currently the fitshape parameter controls both the box size to fit the PSF to a source and the size of the region to use when subtracting that scaled PSF model. Often, we want to use a fit box centered on the core (w... | diff --git a/CHANGES.rst b/CHANGES.rst
index 2a699374..ea0fea0b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -27,6 +27,9 @@ New Features
- Added a progress bar for fitting PSF photometry [#1426]
+ - Added a ``subshape`` keyword to the PSF-fitting classes to define
+ the shape over which the PSF is subtracte... |
astropy__photutils-1512 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/detection/core.py:StarFinderBase._find_stars"
],
"edited_modules": [
"photutils/detection/core.py:StarFinderBase"
]
},
"file": "photutils/detection/core.py"
... | astropy/photutils | 2f5e0759acc7477cc4c2ed185ce445825771af5a | DAOStarFinder throws an uncaught exception if no sources are detected
Photutils == 1.6.0 or main on github both produce this behavior.
```
from photutils import DAOStarFinder
import numpy as np
from scipy.ndimage import gaussian_filter
sigma = 1.0
data = np.zeros((100, 100))
err = np.ones_like(data)
xcoords... | diff --git a/CHANGES.rst b/CHANGES.rst
index 46113e73..c7d07224 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -51,6 +51,13 @@ Bug Fixes
- Fixed an issue where ``centroid_quadratic`` would sometimes fail if
the input data contained NaNs. [#1495]
+- ``photutils.detection``
+
+ - Fixed an issue with the starfin... |
astropy__photutils-1581 | [
{
"changes": {
"added_entities": [
"photutils/psf/models.py:GriddedPSFModel.copy",
"photutils/psf/models.py:GriddedPSFModel.deepcopy"
],
"added_modules": null,
"edited_entities": [
"photutils/psf/models.py:GriddedPSFModel.__init__"
],
"edited_modules":... | astropy/photutils | 37b64e046dc3aa1da76938cd8c499f71e4d6b9d5 | Memory errors with refactored code
As [noted in another thread](https://github.com/astropy/photutils/pull/1579#issuecomment-1631151173), I'm consistently getting out-of-memory errors when running the new `PSFPhotometry` fitter.
My fitting runs have died at the following stages as ID'd by the progressbar:
```
Fit s... | diff --git a/CHANGES.rst b/CHANGES.rst
index 18cbac6d..66d0b8bc 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -25,7 +25,7 @@ New Features
- Propagate measurement uncertainties in PSF fitting. [#1543]
- Added new ``PSFPhotometry``, ``IterativePSFPhotometry``, and
- ``SourceGrouper`` classes. [#1558]
+ ``So... |
astropy__photutils-1648 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/morphology/core.py:data_properties"
],
"edited_modules": [
"photutils/morphology/core.py:data_properties"
]
},
"file": "photutils/morphology/core.py"
}
] | astropy/photutils | 6feb1204a8388f7cca5f702906d96ea2ac7e335c | Add wcs parameter to photutils.morphology.data_properties()
Hi, a small suggestion to the morphology functionality.
It would be great to allow `data_properties` to take a WCS convention/header, since `data_properties()` returns a `source_catalogue()` with SkyCoordinate attributes. This would allow the user to apply ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 1666af8e..90954215 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,10 @@ General
New Features
^^^^^^^^^^^^
+- ``photutils.morphology``
+
+ - Added a ``wcs`` keyword to ``data_properties``. [#1648]
+
- ``photutils.segmentation``
- The ``SegmentationImage`` ``... |
astropy__photutils-1663 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/detection/core.py:StarFinderBase._find_stars"
],
"edited_modules": [
"photutils/detection/core.py:StarFinderBase"
]
},
"file": "photutils/detection/core.py"
... | astropy/photutils | a50fe171cf1242560cace73d2e04e729a4420fbc | DAOStarFinder to include `minsep_fwhm` ?
Hi, is it possible to include `minsep_fwhm` in the `DAOStarFinder`? It looks to me from the top level that it is a simple implementation that can be copied and pasted from the `IRAFStarFinder`, not sure if it would cause problems in other places though...
In the current `DAOS... | diff --git a/CHANGES.rst b/CHANGES.rst
index 6c62e9fe..ca2f673b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,11 @@ General
New Features
^^^^^^^^^^^^
+- ``photutils.detection``
+
+ - Added a ``min_separation`` keyword to ``DAOStarFinder`` and
+ ``IRAFStarFinder``. [#1663]
+
- ``photutils.morphology``
... |
astropy__photutils-1679 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/psf/griddedpsfmodel.py:GriddedPSFModel.copy"
],
"edited_modules": [
"photutils/psf/griddedpsfmodel.py:GriddedPSFModel"
]
},
"file": "photutils/psf/griddedpsfm... | astropy/photutils | d501ad53210917bad71f870adb98243f0fb60d2f | Forced photometry with fixed position still seems to be fitting a position
Has anybody had this issue?
photutils 1.10.0
astropy 6.0.0
I have a situation where, in some cases, I need to fix the x_0 and y_0 position of my psf and just fit for flux. A snippet of my code:
`pos = Table(names=["x_0", "y_0", "flux_... | diff --git a/CHANGES.rst b/CHANGES.rst
index cbf50db3..5c76dd2b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -26,6 +26,10 @@ Bug Fixes
raise an error with ``PSFPhotometry`` if the fit did not converge.
[#1672]
+ - Fixed an issue where ``GriddedPSFModel`` fixed model parameters were
+ not respected when... |
astropy__photutils-1805 | [
{
"changes": {
"added_entities": [
"photutils/psf/photometry.py:PSFPhotometry._validate_bounds"
],
"added_modules": null,
"edited_entities": [
"photutils/psf/photometry.py:PSFPhotometry.__init__",
"photutils/psf/photometry.py:PSFPhotometry._make_psf_model",
... | astropy/photutils | 1f474ae20fcf1b0a7953d59948a1fd458ba91aa5 | Limit offsets when fitting
As noted in #1799, it is possible to limit the flux to be positive by setting the model flux min to be zero:
```python
dao_psf_model.flux.min = 0
```
which is useful for rejecting negative sources during fitting.
I'd like a mechanism to do the same for `x_0` and `y_0`, but restri... | diff --git a/CHANGES.rst b/CHANGES.rst
index 52be398e..fcc549f1 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,12 @@ General
New Features
^^^^^^^^^^^^
+- ``photutils.psf``
+
+ - Added new ``xy_bounds`` keyword to ``PSFPhotometry`` and
+ ``IterativePSFPhotometry`` to allow one to bound the x and y
+ mo... |
astropy__photutils-1885 | [
{
"changes": {
"added_entities": [
"photutils/detection/daofinder.py:_DAOStarFinderCatalog.daofind_mag"
],
"added_modules": null,
"edited_entities": [
"photutils/detection/daofinder.py:_DAOStarFinderCatalog.__init__",
"photutils/detection/daofinder.py:_DAOStarFind... | astropy/photutils | b8f54da59d68dc9f02be293dbdf0e39bc93ee351 | Rename 'flux' column in tables generated by ``StarFinderBase`` objects
I think it makes sense to rename the ``flux`` column in tables generated by ``StarFinderBase`` objects to something like ``flux_peak_density``. I'm saying this because the name ``flux`` induces users to use those numbers as the initial guesses for t... | diff --git a/CHANGES.rst b/CHANGES.rst
index 4a94f8b7..31501f9c 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -163,6 +163,14 @@ API Changes
``IRAFStarFinder`` has been removed. Also, there will no longer be a
``sky`` column in the output table. [#1884]
+ - The ``DAOStarFinder`` ``flux`` and ``mag`` columns... |
astropy__photutils-1935 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/background/background_2d.py:Background2D._calculate_stats"
],
"edited_modules": [
"photutils/background/background_2d.py:Background2D"
]
},
"file": "photutils... | astropy/photutils | 349a5aa6dc52291b587c4ea8720f5a064272ec1c | Background2D corner-case bug
The 2.0 release inadvertently introduced a corner-case bug in `Background2D` where the input data array could be modified if the `box_size` value equals the `data.shape`. I have a PR in progress to fix this issue, after which I'll make a 2.0.1 release. | diff --git a/CHANGES.rst b/CHANGES.rst
index fd706668..21c4801b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -16,6 +16,9 @@ Bug Fixes
the returned value would not be preserved if the output was a single
value. [#1934]
+ - Fixed an issue in ``Background2D`` where if the ``box_size`` equals
+ the input a... |
astropy__photutils-1943 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/detection/core.py:StarFinderBase._find_stars"
],
"edited_modules": [
"photutils/detection/core.py:StarFinderBase"
]
},
"file": "photutils/detection/core.py"
... | astropy/photutils | dcfe91707566dfb7b2f7e6d0e511132c1d10066a | IRAFStarFinder Error: self.cutout_data_nosub is size (0,)
Hello! I am recieving an unexpected error with IRAFStarFinder. When attempting to select stars and mask them in 5x5 pixel cutouts, there will be one or more instances of the self.cutout_data_nosub being dimension (0,), thus producing a broadcasting error.
I ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 229d05c8..b7729d9e 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -18,6 +18,14 @@ Bug Fixes
using the ``BkgIDWInterpolator`` and when any mesh was excluded,
e.g., due to an input mask. [#1940]
+- ``photutils.detection``
+
+ - Fixed a bug in the star finders (``DA... |
astropy__photutils-1956 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/segmentation/catalog.py:SourceCatalog.to_table"
],
"edited_modules": [
"photutils/segmentation/catalog.py:SourceCatalog"
]
},
"file": "photutils/segmentation/... | astropy/photutils | d73bfb7b311565909da2cc554739617cdf2193ef | Source catalogue to_table method giving RepresenterError
I'm trying to output the results from SourceCatalog into a Qtable with the to_table method using columns that are not the defaults.
(Photutils v 2.0.2)
The output fails giving me the error:
`RepresenterError: ('cannot represent an object', 'eccentricity')`
... | diff --git a/CHANGES.rst b/CHANGES.rst
index d5ad6598..5c692d16 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,13 @@ New Features
Bug Fixes
^^^^^^^^^
+- ``photutils.segmentation``
+
+ - Fixed a bug where the table output from the ``SourceCatalog``
+ ``to_table`` method could have column names with a ``... |
astropy__photutils-1978 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"photutils/detection/daofinder.py:_DAOStarFinderCatalog.apply_filters"
],
"edited_modules": [
"photutils/detection/daofinder.py:_DAOStarFinderCatalog"
]
},
"file": "phot... | astropy/photutils | 3d06161529624d7d3e886bb46d22aa99dcd015b5 | Sources that match sharplo(hi) and roundlo(hi) limits should be included
Currently star finding code filters out sources that have sharpness or roundness match one of the limits for these parameter, see https://github.com/astropy/photutils/blob/c15b004be4ecd1256f8a8db8c9c7a52e795fe3a8/photutils/detection/irafstarfinder... | diff --git a/CHANGES.rst b/CHANGES.rst
index 0bbe6261..b85902d9 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -51,6 +51,11 @@ API Changes
different along the x and y edges if the kernel shape is rectangular.
[#1957]
+ - Detected sources that match interval ends for sharpness, roundness, and
+ maximum pe... |
astropy__photutils-740 | [
{
"changes": {
"added_entities": [
"photutils/psf/photometry.py:BasicPSFPhotometry.set_aperture_radius"
],
"added_modules": null,
"edited_entities": [
"photutils/psf/photometry.py:BasicPSFPhotometry.do_photometry",
"photutils/psf/photometry.py:IterativelySubtracte... | astropy/photutils | 69c06aab63f9774e1bc188cb4636ea6d85e93d1a | About PSF model
Hi,
When I got the PSF model from EPSFBuilder. Could the model be used as the parameter in IterativelySubtractedPSFPhotometry: psf_model? It raise the error lile:
File "/home/yf/.conda/envs/python3/lib/python3.6/site-packages/photutils/aperture/circle.py", line 124, in __init__
if r < 0:
TypeErr... | diff --git a/CHANGES.rst b/CHANGES.rst
index 4fcdb2de..a2bd14aa 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -84,6 +84,9 @@ Bug Fixes
- Fixed a bug that caused photometry to fail on an ``EPSFmodel`` with
multiple stars in a group. [#1135]
+ - Added a fallback ``aperture_radius`` for PSF models without a FWH... |
astropy__pyvo-357 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyvo/dal/tap.py:AsyncTAPJob.query"
],
"edited_modules": [
"pyvo/dal/tap.py:AsyncTAPJob"
]
},
"file": "pyvo/dal/tap.py"
}
] | astropy/pyvo | 861298fbff5395d61af8192b9b739cff911cb025 | AsyncTAPJob's "query" attribute is not robust to case variation among community TAP servers
We have recently noticed that the "query" attribute of AsyncTAPJob (https://pyvo.readthedocs.io/en/latest/api/pyvo.dal.AsyncTAPJob.html#pyvo.dal.AsyncTAPJob.query) does not work with either the Rubin Observatory TAP service or t... | diff --git a/CHANGES.rst b/CHANGES.rst
index 5b9953d..c6ada61 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -19,6 +19,9 @@
- Allow session to be passed through in SSA and DataLink. [#327]
+- pyvo.dal.tap.AsyncTAPJob treats parameter names as case-insensitive when
+ retrieving the query from the job record. [#356]... |
astropy__pyvo-427 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyvo/registry/regtap.py:RegistryResource.region_of_regard",
"pyvo/registry/regtap.py:RegistryResource.search"
],
"edited_modules": [
"pyvo/registry/regtap.py:RegistryResource... | astropy/pyvo | a89748389b66f5f69afc14cb76652060538e42d6 | MAINT: improve test coverage of regtap
Currently, it's only 55% with missing coverage of numerous methods leading to wonder whether hash-based splitting of standardid works as intended for services with IDs including a hash, e.g. the distinction of SIA and SIA2.
https://github.com/astropy/pyvo/blob/main/pyvo/regis... | diff --git a/pyvo/registry/regtap.py b/pyvo/registry/regtap.py
index 4fb5f2c..89f1355 100644
--- a/pyvo/registry/regtap.py
+++ b/pyvo/registry/regtap.py
@@ -25,6 +25,8 @@ from astropy import table
from astropy.utils.decorators import deprecated
from astropy.utils.exceptions import AstropyDeprecationWarning
+import ... |
astropy__pyvo-459 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyvo/dal/params.py:PosQueryParam.get_dal_format",
"pyvo/dal/params.py:PosQueryParam._validate_pos"
],
"edited_modules": [
"pyvo/dal/params.py:PosQueryParam"
]
},
... | astropy/pyvo | b96a95056d378731aa0c2676dcc325264dab7e78 | sia query doesn't accept scalar coordinate
@andamian this looks like a bug in how `pyvo` is handlign the `pos` keyword (or, I don't understand what's expected, but in that case it's clearly a documentation issue)
```python
>>> from astroquery.alma import Alma
>>> from astropy import coordinates
>>> from astropy i... | diff --git a/CHANGES.rst b/CHANGES.rst
index ca48efe..63c634e 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -30,6 +30,8 @@
- Fix handling of nan values for Time properties in SIA2 records. [#463]
+- Fix SIA2 search to accept SkyCoord position inputs. [#459]
+
1.4.1 (2023-03-07)
==================
diff --git a/... |
astropy__pyvo-507 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyvo/dal/adhoc.py:AdhocServiceResultsMixin.__init__",
"pyvo/dal/adhoc.py:DatalinkService.run_sync",
"pyvo/dal/adhoc.py:DatalinkService.create_query",
"pyvo/dal/adhoc.py:DatalinkQ... | astropy/pyvo | 1c4f2facdda9db91a039c298d211119a50adf219 | MAINT: making all optional arguments keyword only
This would point towards the direction of making the API a bit more strict to require being explicit.
https://peps.python.org/pep-3102/ | diff --git a/CHANGES.rst b/CHANGES.rst
index c54b7be..c62162a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,8 @@
Enhancements and Fixes
----------------------
+- Making optional parameters keyword only throughout the public API. [#507]
+
Deprecations and Removals
-------------------------
diff --git a/p... |
astropy__pyvo-557 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyvo/dal/query.py:Record.make_dataset_filename"
],
"edited_modules": [
"pyvo/dal/query.py:Record"
]
},
"file": "pyvo/dal/query.py"
}
] | astropy/pyvo | 7020a9fbfb67a830714f0025c20decdd2af90771 | cachedataset hands through slashes in image titles to the file system
If a SIA service returns a slash as a part of an image title, SIARecord's cachedataset will fail with an error message that will be hard to understand, such as
```
FileNotFoundError: [Errno 2] No such file or directory: './ROSAT_HRI_ROSAT_Soft/Me... | diff --git a/CHANGES.rst b/CHANGES.rst
index f4d6699..56ffb21 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -6,6 +6,8 @@ Bug Fixes
- cachedataset() and friends again produce reasonable file extensions.
[#553]
+- path separators are no longer taken over from image titles to file
+ system paths. [#557]
Enhancem... |
astropy__pyvo-613 | [
{
"changes": {
"added_entities": [
"pyvo/dal/adhoc.py:DatalinkResultsMixin._guess_datalink"
],
"added_modules": null,
"edited_entities": [
"pyvo/dal/adhoc.py:DatalinkRecordMixin.getdatalink"
],
"edited_modules": [
"pyvo/dal/adhoc.py:DatalinkResultsMixi... | astropy/pyvo | 8f5e780102295ff4bff137af32ba61da3bc88579 | getdatalink() exits messily when there isn't a datalink
Most simply,
> import pyvo as vo
> import astropy.coordinates as coord
> coords = coord.SkyCoord.from_name("m51")
> skyview=vo.regsearch(servicetype='sia',keywords=['skyview digitized sky survey'])[0]
> results=skyview.search(pos=coords,radius=0.1)
> resu... | diff --git a/CHANGES.rst b/CHANGES.rst
index 38f1f0e..639286d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -38,6 +38,8 @@ Enhancements and Fixes
- New sub-package discover for global dataset discovery. [#470]
+- Updated getdatalink to be consistent with iter_datalinks. [#613]
+
Deprecations and Removals
-----... |
astropy__pyvo-624 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyvo/dal/query.py:Record.__repr__"
],
"edited_modules": [
"pyvo/dal/query.py:Record"
]
},
"file": "pyvo/dal/query.py"
},
{
"changes": {
"added_entities": ... | astropy/pyvo | 99e0fd93b3c388e18cbef55084992c6dd09095c3 | Bug: DALQueryError caused by interpolated `np.float64`
This might be a bit of a duplicate of https://github.com/astropy/pyvo/issues/568 or at the very least related.
I was following [Markus's pyvo-course](https://codeberg.org/msdemlei/pyvo-course) and hit a `DALQueryError`.
Stripping down Markus's code to a MRE:... | diff --git a/CHANGES.rst b/CHANGES.rst
index ce227a9..fef5c8d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -17,6 +17,8 @@ Bug Fixes
- Fix propagating some previously swallowed exceptions. [#614]
+- Fix string literal generation for SQL query when using numpy >=2.0. [#624]
+
1.6 (2024-11-01)
================
d... |
astropy__reproject-334 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"reproject/mosaicking/wcs_helpers.py:find_optimal_celestial_wcs"
],
"edited_modules": [
"reproject/mosaicking/wcs_helpers.py:find_optimal_celestial_wcs"
]
},
"file": "re... | astropy/reproject | 06cab0da7740482b7ea9beed1e55c8b29ad06f6b | find_optimal_celestial_wcs does not accept GWCS
https://github.com/astropy/reproject/blob/aa23eb13aec929cd3719b8d245362a77a33007c3/reproject/mosaicking/wcs_helpers.py#L92
It complains that GWCS has no attribute `naxis`. | diff --git a/reproject/mosaicking/wcs_helpers.py b/reproject/mosaicking/wcs_helpers.py
index 1769a50c..a3cbcf33 100644
--- a/reproject/mosaicking/wcs_helpers.py
+++ b/reproject/mosaicking/wcs_helpers.py
@@ -3,6 +3,7 @@
import numpy as np
from astropy import units as u
from astropy.coordinates import SkyCoord, frame_... |
astropy__reproject-349 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"reproject/utils.py:_reproject_blocked"
],
"edited_modules": [
"reproject/utils.py:_reproject_blocked"
]
},
"file": "reproject/utils.py"
},
{
"changes": {
... | astropy/reproject | 214544874e838d03ce9b44dacc13621a375df15f | Failure w/astropy-dev from spectral-cube: APE14 issue?
I haven't tracked this all the way down yet, but this looks to me like a problem b/w reproject and astropy-dev?
```
def test_mosaic_cubes(use_memmap, data_adv, use_dask, spectral_block_size):
pytest.importorskip('reproject')
# Read in d... | diff --git a/reproject/utils.py b/reproject/utils.py
index d79b13b1..a098d095 100644
--- a/reproject/utils.py
+++ b/reproject/utils.py
@@ -277,7 +277,12 @@ def _reproject_blocked(
if a.ndim == 0 or block_info is None or block_info == []:
return np.array([a, a])
slices = [slice(*x) for x i... |
astropy__specreduce-114 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specreduce/extract.py:HorneExtract.__call__"
],
"edited_modules": [
"specreduce/extract.py:HorneExtract"
]
},
"file": "specreduce/extract.py"
}
] | astropy/specreduce | ff0ea57975eda53bd2ff4ea106153775893890b4 | HorneExtract: variance of zeros fails
passing zeros into variance results in inf/inf which returns an extracted spectrum of 0s. These should either be handled gracefully or raise an error. (cc @orifox) | diff --git a/specreduce/extract.py b/specreduce/extract.py
index e4f84a5..c77af1e 100644
--- a/specreduce/extract.py
+++ b/specreduce/extract.py
@@ -196,7 +196,10 @@ class HorneExtract(SpecreduceOperation):
variance : `~numpy.ndarray`, optional
(Only used if `image` is not an NDData object.)
... |
astropy__specreduce-141 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specreduce/background.py:Background.__post_init__"
],
"edited_modules": [
"specreduce/background.py:Background"
]
},
"file": "specreduce/background.py"
},
{
"ch... | astropy/specreduce | 44d3533edf9016ee99b1fd722ebba1c177ecba9b | Subpixel aperture widths produce incorrect weights
We realized this while updating `_get_boxcar_weights()` in #125. @kecnry has worked out a solution that looks promising, but the need to test it more extensively means it will probably end up in a different pull request. In the meantime, #125 should produce correct wei... | diff --git a/CHANGES.rst b/CHANGES.rst
index 4ce7192..430d735 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,13 @@ Bug Fixes
- Improved errors/warnings when background region extends beyond bounds of image [#127]
- Fixed boxcar weighting bug that often resulted in peak pixels having weight
above 1 and err... |
astropy__specreduce-144 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specreduce/background.py:Background.__post_init__",
"specreduce/background.py:Background.two_sided",
"specreduce/background.py:Background.one_sided",
"specreduce/background.py:Ba... | astropy/specreduce | 2a63e7d2a132b0afc9d9d1c8b4e3aa386f0ff08a | Background errors out when given an NDData-typed image
This happens because `NDData` images don't have a "first-level" `shape` attribute like numpy `array` and `CCDData` objects do. If `image` is an `NDData` object, you have to go down to `image.data.shape` for the equivalent information.
Is this something we should... | diff --git a/CHANGES.rst b/CHANGES.rst
index 3151580..25cb669 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -13,7 +13,10 @@ API Changes
- Renamed KosmosTrace as FitTrace, a conglomerate class for traces that are fit
to images instead of predetermined [#128]
- The default number of bins for FitTrace is now its asso... |
astropy__specreduce-148 | [
{
"changes": {
"added_entities": [
"specreduce/extract.py:_align_along_trace"
],
"added_modules": [
"specreduce/extract.py:_align_along_trace"
],
"edited_entities": [
"specreduce/extract.py:HorneExtract.__call__"
],
"edited_modules": [
"s... | astropy/specreduce | 05a174daa0c925b3c09b2dc734f0ff2b833b8850 | HorneExtract treatment of non-flat trace
HorneExtract computes the profile by collapsing the spectrum along the dispersion-axis, and then applying that same profile across each "column" from the trace. This will likely result in an artificially broad profile if the trace is not strictly flat. For non-flat traces, we ... | diff --git a/specreduce/extract.py b/specreduce/extract.py
index b792be8..af3020a 100644
--- a/specreduce/extract.py
+++ b/specreduce/extract.py
@@ -117,6 +117,34 @@ def _ap_weight_image(trace, width, disp_axis, crossdisp_axis, image_shape):
return wimage
+def _align_along_trace(img, trace_array, disp_axis=1, ... |
astropy__specutils-1009 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/io/default_loaders/tabular_fits.py:tabular_fits_writer"
],
"edited_modules": [
"specutils/io/default_loaders/tabular_fits.py:tabular_fits_writer"
]
},
"file":... | astropy/specutils | 1c2ba04095460f67c104c25983dd0db14855b03b | Writer needed for cube data
How do we save spectral cubes to file formats that are readable by other applications?
What type of api call do we implement for this?
[🐱](https://jira.stsci.edu/browse/JDAT-2199) | diff --git a/specutils/io/default_loaders/tabular_fits.py b/specutils/io/default_loaders/tabular_fits.py
index c5b21b5d..9dc7ef73 100644
--- a/specutils/io/default_loaders/tabular_fits.py
+++ b/specutils/io/default_loaders/tabular_fits.py
@@ -1,6 +1,7 @@
import numpy as np
from astropy.io import fits
+from astropy.... |
astropy__specutils-1053 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/io/asdf/converters.py:Spectrum1DConverter.to_yaml_tree",
"specutils/io/asdf/converters.py:Spectrum1DConverter.from_yaml_tree"
],
"edited_modules": [
"specutils/io/a... | astropy/specutils | 2a7e5aa95a687976e1c2a9a907267f2ab3ac5d5c | Round-trip mask through ASDF
Originally requested by @rosteen over at #1046 together with WCS, "In reviewing #1042 I noticed that the ASDF converters have never round-tripped the `mask` attribute. We should update the converters to do so."
[🐱](https://jira.stsci.edu/browse/JDAT-3236) | diff --git a/CHANGES.rst b/CHANGES.rst
index 516269a0..b9053c07 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -18,7 +18,8 @@ Other Changes and Additions
- ASDF tag for Spectrum1D is now compatible with ASDF v3.
As a result, minversion of ``asdf`` has been bumped to 2.14.
- Redundant ASDF schema for ``SpectralCoo... |
astropy__specutils-1124 | [
{
"changes": {
"added_entities": [
"specutils/spectra/spectrum_mixin.py:OneDSpectrumMixin.with_flux_unit"
],
"added_modules": null,
"edited_entities": [
"specutils/spectra/spectrum_mixin.py:OneDSpectrumMixin.new_flux_unit"
],
"edited_modules": [
"specu... | astropy/specutils | 2fe4fa25b629e256cdc31367ed1dac428e34dc6a | Spectrum1D.new_flux_unit returns copy but docs says it acts on original object
The docstring on `Spectrum1D.new_flux_unit` say "This is an in-place change to the object." but the code returns a modified deepcopy of the original object. The corresponding methods for the spectral axis, which also return a modified copy,... | diff --git a/specutils/spectra/spectrum_mixin.py b/specutils/spectra/spectrum_mixin.py
index f57a5c59..3f300174 100644
--- a/specutils/spectra/spectrum_mixin.py
+++ b/specutils/spectra/spectrum_mixin.py
@@ -80,10 +80,14 @@ class OneDSpectrumMixin():
"""
return u.Quantity(self.data, unit=self.unit, cop... |
astropy__specutils-1158 | [
{
"changes": {
"added_entities": [
"specutils/spectra/spectrum1d.py:Spectrum1D._return_with_redshift"
],
"added_modules": null,
"edited_entities": [
"specutils/spectra/spectrum1d.py:Spectrum1D.__add__",
"specutils/spectra/spectrum1d.py:Spectrum1D.__sub__",
... | astropy/specutils | c00667833f151a58d4a748268d7bf027535d2023 | Dividing fluxes of a redshifted spectrum
I load a spectrum and then I shift the spectral_axis to a given redshift value
spec = Spectrum.read('myspectrum.fits')
spec.shift_spectrum_to(redshift=2.0)
then I want to divide the fluxes by a given value (i.e 1+z)
spec /= 3.0
Now the fluxes are divided by 3, but ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 82cd03d9..165477ae 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,9 @@ New Features
Bug Fixes
^^^^^^^^^
+- Arithmetic operations on ``Spectrum1D`` objects now preserve spectral axis values that
+ were updated by setting redshift or radial velocity. [#1158]
+
Oth... |
astropy__specutils-1171 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/fitting/continuum.py:fit_continuum"
],
"edited_modules": [
"specutils/fitting/continuum.py:fit_continuum"
]
},
"file": "specutils/fitting/continuum.py"
},
... | astropy/specutils | 016ffc2f318bf487c83700333df73198dc2c2318 | excise_regions() is not inclusive on the first boundary
I am one of the developers for [dysh](https://github.com/GreenBankObservatory/dysh), a project using specutils to perfom single-dish radio telescope calibration and data reduction. Upon testing baseline subtraction, we came across a discrepancy caused by the fact ... | diff --git a/.github/workflows/ci_cron_weekly.yml b/.github/workflows/ci_cron_weekly.yml
index de9dff55..62b2362e 100644
--- a/.github/workflows/ci_cron_weekly.yml
+++ b/.github/workflows/ci_cron_weekly.yml
@@ -39,11 +39,11 @@ jobs:
steps:
- name: Checkout code
- uses: actions/checkout@v4
+ uses: ... |
astropy__specutils-1190 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/manipulation/resample.py:SplineInterpolatedResampler.resample1d"
],
"edited_modules": [
"specutils/manipulation/resample.py:SplineInterpolatedResampler"
]
},
... | astropy/specutils | 36afc8a022cb906d495b362cab9668e8975aa381 | Spline interpolation no longer works for binning on velocity grid
Due to changes added in https://github.com/astropy/specutils/pull/1121, the SplineInterpolatedResampler is no longer suitable for binning a spectrum onto a spectral axis which is uniform in velocity space. Prior to this, the following code would work (e.... | diff --git a/CHANGES.rst b/CHANGES.rst
index 38997558..1420b8d1 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -12,6 +12,9 @@ Bug Fixes
- Fixed automatic format detection for SDSS-V ``SpectrumList`` default loaders. [#1185]
+- Fixed ``SplineInterpolatedResampler`` when input and output spectral axes are different
+... |
astropy__specutils-575 | [
{
"changes": {
"added_entities": [
"specutils/spectra/spectrum_collection.py:SpectrumCollection.__len__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"specutils/spectra/spectrum_collection.py:SpectrumCollection"
]
},
"file": "... | astropy/specutils | ef8a563d51c08393820ef4b578b69d30ae1a44a8 | SpectrumCollection is missing len
I just noticed that if I do ``len(sc)`` where ``sc`` is a `SpectrumCollection`, I get a ``TypeError: object of type 'SpectrumCollection' has no len()``. This is probably just an oversight, but it should presumably return the first element of `.shape`. | diff --git a/specutils/spectra/spectrum_collection.py b/specutils/spectra/spectrum_collection.py
index cbfcc760..c6cfc4ed 100644
--- a/specutils/spectra/spectrum_collection.py
+++ b/specutils/spectra/spectrum_collection.py
@@ -221,6 +221,9 @@ class SpectrumCollection:
"""
return self.flux.shape[:-1]
... |
astropy__specutils-722 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/spectra/spectral_axis.py:SpectralAxis.with_radial_velocity_shift"
],
"edited_modules": [
"specutils/spectra/spectral_axis.py:SpectralAxis"
]
},
"file": "specu... | astropy/specutils | b5f933cee50ab02da9ca8fd72e8e4cf07ce5bab3 | Can't set radial velocity of Spectrum1D object
Trying to set the radial velocity of a Spectrum1D object raises an Attribute error.
This happens only in specutils version 1.1, but not in version 1.0.
Error Message:
```
Exception has occurred: AttributeError
SpectralAxis instance has no attribute 'with_radial_velo... | diff --git a/specutils/spectra/spectral_axis.py b/specutils/spectra/spectral_axis.py
index f10bb060..2a0ef217 100644
--- a/specutils/spectra/spectral_axis.py
+++ b/specutils/spectra/spectral_axis.py
@@ -84,5 +84,5 @@ class SpectralAxis(SpectralCoord):
def with_radial_velocity_shift(self, target_shift=None, observe... |
astropy__specutils-724 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/manipulation/extract_spectral_region.py:_to_edge_pixel",
"specutils/manipulation/extract_spectral_region.py:extract_region"
],
"edited_modules": [
"specutils/manipu... | astropy/specutils | baef76a8f35dd36ed4afca7e69d6ff9eeb3b239c | Function `extract_region` fails with 3D data
When applying `extraction_region` to a `Spectrum1D` instance which was defined with a 3D flux array, the resulting `Spectrum1D` instance is broken.
For example, submiting a Spectrum1D with shape (100, 100, 2500) (2500 being the spatial axis size) to `extract_region`, res... | diff --git a/CHANGES.rst b/CHANGES.rst
index 73da2cd5..6409df4e 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,11 @@ New Features
Bug Fixes
^^^^^^^^^
+- Fix ``extract_region`` behavior and slicing for ``Spectrum1D`` objects
+ that have multi-dimensional flux arrays. Extracting a region that extends
+ beyon... |
astropy__specutils-926 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/manipulation/extract_spectral_region.py:_subregion_to_edge_pixels"
],
"edited_modules": [
"specutils/manipulation/extract_spectral_region.py:_subregion_to_edge_pixels"
... | astropy/specutils | dd34618a8ed7c4dc01626fcb8865369a1aca6942 | spectral_slab crashes when spectral axis is in the unit of pixel
I will have to try to get a minimally reproducible example later. Just posting the traceback now so I don't lose it. This is using spacetelescope/jdaviz#1040 (Collapse plugin) and glue-viz/glue-astronomy#61 on a data cube without WCS (uncalibrated data).
... | diff --git a/CHANGES.rst b/CHANGES.rst
index 3ac05dd7..009685e7 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,13 @@ Bug Fixes
- Fixed cube transpose bug in moment analysis for non-square spatial arrays. [#912]
+- Fixed ``spectral_slab`` crashing when ``spectral_axis`` has unit of pixels and
+ the bounds a... |
astropy__specutils-946 | [
{
"changes": {
"added_entities": [
"specutils/spectra/spectrum1d.py:Spectrum1D.set_redshift_to",
"specutils/spectra/spectrum1d.py:Spectrum1D.set_radial_velocity_to",
"specutils/spectra/spectrum1d.py:Spectrum1D.shift_spectrum_to"
],
"added_modules": null,
"edited_e... | astropy/specutils | 26d34449a06d6191a0d23a538e34ad34722ae1d1 | redshift applied in the wrong direction in Spectrum1D object
Hi, I just tried filling in the redshift value for a Spectrum1D object after the redshift information became available, and the spectral axis was immediately multiplied by (1+z). I would normally expect that the wavelength will be reported in observed frame b... | diff --git a/docs/spectrum1d.rst b/docs/spectrum1d.rst
index 7ca19d9c..822f3965 100644
--- a/docs/spectrum1d.rst
+++ b/docs/spectrum1d.rst
@@ -133,6 +133,49 @@ however, specutils will recognize ``flux`` values input as ``NaN`` and set the
mask to ``True`` for those values unless explicitly overridden.
+Including R... |
astropy__specutils-970 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/analysis/moment.py:_compute_moment"
],
"edited_modules": [
"specutils/analysis/moment.py:_compute_moment"
]
},
"file": "specutils/analysis/moment.py"
},
{... | astropy/specutils | 2489b1e99fe74cd98a4596d83e8f634a24a61552 | Revisit PR 912 that got reverted (moment transpose for order > 1)
Original problem:
* spacetelescope/jdaviz#947
Original fix:
* #912 (reverted by #929 and never released)
* This patches code added in #781
Simple test case presented at https://github.com/astropy/specutils/pull/929#issuecomment-104373984... | diff --git a/CHANGES.rst b/CHANGES.rst
index c027bfd3..026afba5 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,9 @@ New Features
Bug Fixes
^^^^^^^^^
+- Fixed a bug with moment map orders greater than 1 not being able to handle
+ cubes with non-square spatial dimensions. [#970]
+
Other Changes and Additions... |
astropy__specutils-973 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/analysis/width.py:_compute_gaussian_fwhm",
"specutils/analysis/width.py:_compute_gaussian_sigma_width"
],
"edited_modules": [
"specutils/analysis/width.py:_compute_... | astropy/specutils | cac046bfd83ab256076e694413fd1f39aacb6f88 | JWST s3d loader broken for latest cube data
The specutils loader for JWST s3d files is broken for recent NIRSpec IFU cube data cal_ver 1.4.6. It gives the error `ValueError: Spectral axis length (973) must be the same size or one greater (if specifying bin edges) than that of the last flux axis (950)`. I think there... | diff --git a/CHANGES.rst b/CHANGES.rst
index 026afba5..6a81e107 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,8 @@ Bug Fixes
- Fixed a bug with moment map orders greater than 1 not being able to handle
cubes with non-square spatial dimensions. [#970]
+- Added a workaround for reading JWST IFUs with inco... |
astropy__specutils-975 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/spectra/spectrum1d.py:Spectrum1D.redshift",
"specutils/spectra/spectrum1d.py:Spectrum1D.radial_velocity"
],
"edited_modules": [
"specutils/spectra/spectrum1d.py:Spe... | astropy/specutils | a4038efa0a3cfdbaddf7a2e5bd5ef52c3c2969fd | Properly deprecate redshift and radial_velocity setters
As of #946, the setters emit a `UserWarning` that usage is ambiguous. If indeed such usage should not be, uh, used, then the setters should be properly deprecated and then removed after a reasonable deprecation period.
https://github.com/astropy/specutils/blob/... | diff --git a/CHANGES.rst b/CHANGES.rst
index 6a81e107..71babc18 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -15,6 +15,10 @@ Bug Fixes
Other Changes and Additions
^^^^^^^^^^^^^^^^^^^^^^^^^^^
+- The Spectrum1D redshift and radial_velocity attribute setters were deprecated
+ in favor of the more explicit set_redshi... |
astropy__specutils-976 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"specutils/manipulation/resample.py:FluxConservingResampler.resample1d"
],
"edited_modules": [
"specutils/manipulation/resample.py:FluxConservingResampler"
]
},
"file": ... | astropy/specutils | 573c4ad7496f3beb1af3c847a031308be6ad162a | FluxConservingResampler does not properly propagate the uncertainty
The FluxConservingResampler function does not properly propagate the uncertainties. This function, as stated in the documentation (https://specutils.readthedocs.io/en/stable/api/specutils.manipulation.FluxConservingResampler.html#specutils.manipulation... | diff --git a/CHANGES.rst b/CHANGES.rst
index 57103267..f19d7994 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,8 @@ Bug Fixes
- Arithmetic with constants and Spectrum1D now works in either order. [#964]
+- Fixed uncertainty propagation in FluxConservingResampler. [#976]
+
Other Changes and Additions
^^^^^... |
astropy__sphinx-automodapi-142 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"sphinx_automodapi/automodapi.py:_mod_info"
],
"edited_modules": [
"sphinx_automodapi/automodapi.py:_mod_info"
]
},
"file": "sphinx_automodapi/automodapi.py"
}
] | astropy/sphinx-automodapi | bcc41ff14a4a1df24091f1836f7b1e506beca4f6 | :skip: no longer works with standard library objects
Prior to the 0.14 release, it was possible to use `:skip:` on standard library objects that were imported by a module:
```
.. automodapi:: sphinx_automodapi.tests.example_module.stdlib
:skip: time
:skip: Path
```
In 0.14, those `:skip:` directives a... | diff --git a/CHANGES.rst b/CHANGES.rst
index 62b20ed..53fa563 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,8 @@ Changes in sphinx-automodapi
0.15.0 (unreleased)
-------------------
+- Fixed issue with ``:skip:`` introduced by ``:include:`` feature. [#142]
+
0.14.0 (2021-12-22)
-------------------
diff ... |
astropy__sphinx-automodapi-150 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"sphinx_automodapi/automodapi.py:automodapi_replace"
],
"edited_modules": [
"sphinx_automodapi/automodapi.py:automodapi_replace"
]
},
"file": "sphinx_automodapi/automoda... | astropy/sphinx-automodapi | c4aa83731cf785cb8ad1bee982f15b25f316775a | Incompatible with sphinx>4 (submodules of submodules)
Not sure what is happening but we need to make sure it is not a bug here before reporting it upstream to `sphinx`. This is blocking astropy/astropy#11763 .
@larrybradley narrowed down the issue in https://github.com/astropy/astropy/issues/11723#issuecomment-83873... | diff --git a/setup.cfg b/setup.cfg
index 0dfbcc6..4886f2c 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -32,7 +32,7 @@ test =
[options.package_data]
sphinx_automodapi = templates/*/*.rst
-sphinx_automodapi.tests = cases/*/*.*, cases/*/*/*.*, cases/*/*/*/*.*, cases/*/*/*/*/*.*
+sphinx_automodapi.tests = cases/*/*.*, cas... |
astropy__sphinx-automodapi-51 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"sphinx_automodapi/automodsumm.py:process_automodsumm_generation",
"sphinx_automodapi/automodsumm.py:generate_automodsumm_docs"
],
"edited_modules": [
"sphinx_automodapi/autom... | astropy/sphinx-automodapi | a856c2948129929aba83c4b26aee0a31ca530de2 | Sphinx warning: deprecated app.info
With Sphinx v1.8.1, I get these warnings:
> [automodsumm] tools.rst: found 16 automodsumm entries to generate
/home/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/sphinx/application.py:402: RemovedInSphinx20Warning: app.info() is now deprecated. Use sphinx.util.logging i... | diff --git a/.travis.yml b/.travis.yml
index dea55d7..994a60f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -31,10 +31,12 @@ env:
- PYTHON_VERSION=3.4 SPHINX_VERSION=1.3
- PYTHON_VERSION=3.5 SPHINX_VERSION=1.4
- PYTHON_VERSION=3.5 SPHINX_VERSION=1.5
- - PYTHON_VERSION=3.6 SPHINX_VERSION=1.6 CONDA_CHAN... |
atlassian-api__atlassian-python-api-758 | [
{
"changes": {
"added_entities": [
"atlassian/bitbucket/cloud/repositories/__init__.py:WorkspaceRepositories.exists"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"atlassian/bitbucket/cloud/repositories/__init__.py:WorkspaceRepositories"
... | atlassian-api/atlassian-python-api | a863ad779fb7c8199d6ba037fd8189e9710ca7e7 | Bitbucket Cloud lacks the "project_exists" and "repo_exists" methods available for Server
So I'm running into this issue whereby attempting to create a project that already exists returns a 400 from Bitbucket Cloud. This seems makes sense and seems expected because looking at the [Projects class](https://github.com/atl... | diff --git a/atlassian/bitbucket/cloud/repositories/__init__.py b/atlassian/bitbucket/cloud/repositories/__init__.py
index 47a08ed..f7a0050 100644
--- a/atlassian/bitbucket/cloud/repositories/__init__.py
+++ b/atlassian/bitbucket/cloud/repositories/__init__.py
@@ -1,5 +1,6 @@
# coding=utf-8
+from requests import HTT... |
atomicateam__atomica-410 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"atomica/framework.py:ProjectFramework._validate"
],
"edited_modules": [
"atomica/framework.py:ProjectFramework"
]
},
"file": "atomica/framework.py"
},
{
"change... | atomicateam/atomica | 213ecfc4210dd8111877bd51201596ea0207e51e | TimeSeries should deal better with arrays
Under some conditions, arrays need to be converted to lists in order to be added - better to remove this limitation | diff --git a/atomica/framework.py b/atomica/framework.py
index 7c0338b8..7e4c5ddc 100644
--- a/atomica/framework.py
+++ b/atomica/framework.py
@@ -1119,7 +1119,7 @@ class ProjectFramework(object):
message = 'No compartments or characteristics appear in the databook, which means it is not possible t... |
atomistic-machine-learning__schnetpack-39 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/schnetpack/datasets/matproj.py:MaterialsProject.__init__"
],
"edited_modules": [
"src/schnetpack/datasets/matproj.py:MaterialsProject"
]
},
"file": "src/schnetpack/... | atomistic-machine-learning/schnetpack | a47c081a4bd846879e1ef6e059f5f0f7c5e49018 | No inheritance of ASEEnvironmentProvider
https://github.com/atomistic-machine-learning/schnetpack/blob/9caa03c5ca27ab17f02201c4146487c8917521f3/src/schnetpack/environment.py#L55
There are no functional issues, but I think `ASEEnvironmentProvider` should inherit `BaseEnvironmentProvider` like below.
```python
cla... | diff --git a/src/schnetpack/datasets/matproj.py b/src/schnetpack/datasets/matproj.py
index 03fb3ea..d81f8ac 100644
--- a/src/schnetpack/datasets/matproj.py
+++ b/src/schnetpack/datasets/matproj.py
@@ -6,7 +6,7 @@ from ase.db import connect
from ase.units import eV
from schnetpack.data import AtomsData
-from schnetp... |
attwad__python-osc-185 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pythonosc/osc_tcp_server.py:_TCPHandler1_0.handle",
"pythonosc/osc_tcp_server.py:_TCPHandler1_1.handle",
"pythonosc/osc_tcp_server.py:AsyncOSCTCPServer.handle1_0",
"pythonosc/osc... | attwad/python-osc | e50f4813ca20e7f009e13f2c1347fdbdaa82c542 | Dispatcher replies expect List not Tuple on TCP
According to `dispatcher.py` lines [104-116](https://github.com/attwad/python-osc/blob/master/pythonosc/dispatcher.py#L104), one of the ways a callback function may pass a reply back to a client is by returning a message encapsulated thusly: `tuple(<Address>, <ArgValue>)`... | diff --git a/pythonosc/osc_tcp_server.py b/pythonosc/osc_tcp_server.py
index 56e0816..aec674f 100644
--- a/pythonosc/osc_tcp_server.py
+++ b/pythonosc/osc_tcp_server.py
@@ -75,7 +75,7 @@ class _TCPHandler1_0(socketserver.BaseRequestHandler):
)
# resp = _call_handlers_for_packet(data, self.serv... |
attwad__python-osc-67 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pythonosc/osc_message.py:OscMessage._parse_datagram"
],
"edited_modules": [
"pythonosc/osc_message.py:OscMessage"
]
},
"file": "pythonosc/osc_message.py"
},
{
"... | attwad/python-osc | 73777b367ac4327e9fd0b799366959e50266ebc2 | Add support for 64 bits double type
`unhandled type: d` warnings are all that gets returned, no handlers even end up running. | diff --git a/pythonosc/osc_message.py b/pythonosc/osc_message.py
index 911dbcf..b89a0d6 100644
--- a/pythonosc/osc_message.py
+++ b/pythonosc/osc_message.py
@@ -41,6 +41,8 @@ class OscMessage(object):
val, index = osc_types.get_int(self._dgram, index)
elif param == "f": # Float.
val, ind... |
atviriduomenys__spinta-908 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"spinta/manifests/xsd2/helpers.py:XSDReader._post_process_refs"
],
"edited_modules": [
"spinta/manifests/xsd2/helpers.py:XSDReader"
]
},
"file": "spinta/manifests/xsd2/h... | atviriduomenys/spinta | 3fbb15a17e6f01769df43a54d1cb4e6b3dac323a | XSD -> DSA: post_process_refs
When building a model tree, the top level `element` and `complexType` nodes are being turned into models, but the references on properties on other models are not being created. this is being done to avoid too much logic happening at once.
Because of this, we need to revisit each prope... | diff --git a/spinta/manifests/xsd2/helpers.py b/spinta/manifests/xsd2/helpers.py
index e3ebea7e..ca2b7d5b 100644
--- a/spinta/manifests/xsd2/helpers.py
+++ b/spinta/manifests/xsd2/helpers.py
@@ -338,7 +338,25 @@ class XSDReader:
self.models.append(self.resource_model)
def _post_process_refs(self):
-... |
atviriduomenys__spinta-918 | [
{
"changes": {
"added_entities": [
"spinta/manifests/xsd2/helpers.py:XSDReader.process_simple_type_extension",
"spinta/manifests/xsd2/helpers.py:XSDReader.process_complex_type_extension"
],
"added_modules": null,
"edited_entities": [
"spinta/manifests/xsd2/helpers... | atviriduomenys/spinta | d15986b187646578a6c337245faced64ea2aefdd | Write `process_complex_content` method
This always goes together with `extension`, i.e. `extension` is inside `complexContent`.
In addition to this, `complexContent` can have attribute `mixed="true"` (default is `false`) which would mean that this element can also have text. See example in `process_extension` #872 ... | diff --git a/spinta/manifests/xsd2/helpers.py b/spinta/manifests/xsd2/helpers.py
index ca2b7d5b..552f296a 100644
--- a/spinta/manifests/xsd2/helpers.py
+++ b/spinta/manifests/xsd2/helpers.py
@@ -3,7 +3,8 @@ from __future__ import annotations
import logging
import os
from dataclasses import dataclass
-from typing imp... |
atviriduomenys__spinta-928 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"spinta/backends/__init__.py:prepare_dtype_for_response"
],
"edited_modules": [
"spinta/backends/__init__.py:prepare_dtype_for_response"
]
},
"file": "spinta/backends/__... | atviriduomenys/spinta | 93ec409e32bf8b93970aba102670a1f3f29e98e0 | Write `process_simple_content` method
`simpleContent` can be an element that has attributes and text, so it can become a model. the element, described by `simpleContent` can have `text()` also. `simpleContent` is in a few RC documents.
Example of `simpleContent`:
```xml
<xs:schema xmlns:xs="http://www.w3.org/200... | diff --git a/CHANGES.rst b/CHANGES.rst
index 41f126af..198050b9 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -3,7 +3,10 @@ Changes
0.1.79 (unreleased)
===================
+Bug fix:
+- Resolved ambiguity warning messages. (`#895`_).
+.. _#895: https://github.com/atviriduomenys/spinta/issues/895
0.1.78 (2024-10... |
atviriduomenys__spinta-936 | [
{
"changes": {
"added_entities": [
"spinta/manifests/xsd2/helpers.py:XSDReader._get_most_generic_type"
],
"added_modules": null,
"edited_entities": [
"spinta/manifests/xsd2/helpers.py:XSDReader.process_simple_type",
"spinta/manifests/xsd2/helpers.py:XSDReader.proc... | atviriduomenys/spinta | cad336af3d2e76d704b35dd0e674eade6fda433c | Write `process_union` method | diff --git a/spinta/manifests/xsd2/helpers.py b/spinta/manifests/xsd2/helpers.py
index 5c37204a..83a3d100 100644
--- a/spinta/manifests/xsd2/helpers.py
+++ b/spinta/manifests/xsd2/helpers.py
@@ -734,8 +734,9 @@ class XSDReader:
return enum_item
def process_simple_type(self, node: _Element, state: State)... |
audeering__audiofile-106 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"audiofile/core/io.py:convert_to_wav"
],
"edited_modules": [
"audiofile/core/io.py:convert_to_wav"
]
},
"file": "audiofile/core/io.py"
}
] | audeering/audiofile | c3c4c54438db983c111a926422b84d10a3cc583a | Allow outfile in convert_to_wav() to be None
For reference see https://github.com/audeering/audiofile/pull/101#issuecomment-1406171509.
When converting a file to WAV we might want to use the same path as the original file, but just store a WAV file, e.g.
```python
audiofile.convert_to_wav('file.mp4', 'file.wav')... | diff --git a/audiofile/core/io.py b/audiofile/core/io.py
index 41e8998..a38ab55 100644
--- a/audiofile/core/io.py
+++ b/audiofile/core/io.py
@@ -17,11 +17,12 @@ from audiofile.core.utils import (
def convert_to_wav(
infile: str,
- outfile: str,
+ outfile: str = None,
offset: float = 0... |
audeering__audiofile-117 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"audiofile/core/io.py:convert_to_wav"
],
"edited_modules": [
"audiofile/core/io.py:convert_to_wav"
]
},
"file": "audiofile/core/io.py"
}
] | audeering/audiofile | e577593dde37e1abd269b15e75717b96973e1843 | Normalize argument ignored in convert_to_wav()
In https://github.com/audeering/audiofile/pull/99 we switched to use `audiofile.write()` inside `audiofile.convert_to_wav()` and added the `normalize` argument to `audiofile.convert_to_wav()`, but forgot to pass it on to `audiofile.write()`. | diff --git a/audiofile/core/io.py b/audiofile/core/io.py
index 562db86..7a42be9 100644
--- a/audiofile/core/io.py
+++ b/audiofile/core/io.py
@@ -100,7 +100,14 @@ def convert_to_wav(
offset=offset,
duration=duration,
)
- write(outfile, signal, sampling_rate, bit_depth=bit_depth, **kwargs)
+ ... |
audeering__audiofile-72 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"audiofile/core/convert.py:convert_to_wav"
],
"edited_modules": [
"audiofile/core/convert.py:convert_to_wav"
]
},
"file": "audiofile/core/convert.py"
},
{
"chang... | audeering/audiofile | 5f8204803d58456d9a1d4d7c2319264e62152eb7 | Windows tests fail for MP3 files
For unknown reasons we are not able to make `ffmpeg` work for MP3 files inside the Windows tests.
It fails when trying to convert the file, e.g. https://github.com/audeering/audiofile/pull/44/checks?check_run_id=3251320851
For other non SND files like MP4 converting works. | diff --git a/audiofile/core/convert.py b/audiofile/core/convert.py
index 4ed5b91..314f42d 100644
--- a/audiofile/core/convert.py
+++ b/audiofile/core/convert.py
@@ -36,7 +36,8 @@ def convert_to_wav(
offset: start reading at offset in seconds
Raises:
- RuntimeError: if ``file`` is broken or not a ... |
audeering__auglib-24 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"auglib/core/transform.py:PinkNoise._pink_noise"
],
"edited_modules": [
"auglib/core/transform.py:PinkNoise"
]
},
"file": "auglib/core/transform.py"
}
] | audeering/auglib | ef48643f15408b680e09f211054fb487e8d8ece7 | PinkNoise() can fail with wrong signal length of noise
```python
import auglib
import numpy as np
signal = np.ones((1, 30045))
transform = auglib.transform.PinkNoise()
transform(signal)
```
returns
```
ValueError: operands could not be broadcast together with shapes (1,30045) (1,30044)
``` | diff --git a/auglib/core/transform.py b/auglib/core/transform.py
index 808ca87..7387129 100644
--- a/auglib/core/transform.py
+++ b/auglib/core/transform.py
@@ -3261,16 +3261,20 @@ class PinkNoise(Base):
def psd(f):
return 1 / np.where(f == 0, float("inf"), np.sqrt(f))
- white_noise = np.... |
audeering__auglib-35 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"auglib/core/transform.py:Base.__call__"
],
"edited_modules": [
"auglib/core/transform.py:Base"
]
},
"file": "auglib/core/transform.py"
}
] | audeering/auglib | aa87c89d40f9fa5a5afd5a1ace53c029b4a5770b | Handle read-only input signals
A `np.ndarray` can be flagged as read-only with the `writeable` [flag](https://numpy.org/doc/stable/reference/generated/numpy.ndarray.flags.html).
The [example](https://audeering.github.io/auglib/external.html#sox) in the documentation using `sox` for pitch shift creates such a signal.... | diff --git a/auglib/core/transform.py b/auglib/core/transform.py
index 7387129..9f85edb 100644
--- a/auglib/core/transform.py
+++ b/auglib/core/transform.py
@@ -203,6 +203,11 @@ class Base(audobject.Object):
if signal.dtype != DTYPE:
signal = signal.astype(DTYPE)
+ # Ensure si... |
audeering__auglib-36 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"auglib/core/interface.py:Augment._augment_index",
"auglib/core/interface.py:Augment._augment_file",
"auglib/core/interface.py:Augment._augment_file_to_cache",
"auglib/core/interf... | audeering/auglib | a665a49c55b5bccb4b3c91c00424f7082579de8a | Incorrect order of segments for `Augment.augment()`
`Augment.augment()` can return the augmented segments in a different order than the input order.
Example:
```python
import pandas as pd
import audb
import audformat
import auglib
db = audb.load(
"emodb",
media=["wav/03a01Fa.wav", "wav/03a01N... | diff --git a/auglib/core/interface.py b/auglib/core/interface.py
index c7bb2ad..113765b 100644
--- a/auglib/core/interface.py
+++ b/auglib/core/interface.py
@@ -377,111 +377,70 @@ class Augment(audinterface.Process, audobject.Object):
remove_root: str,
description: str,
) -> pd.Index:
- r"... |
auth0__auth0-python-159 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"auth0/v3/management/client_grants.py:ClientGrants.all"
],
"edited_modules": [
"auth0/v3/management/client_grants.py:ClientGrants"
]
},
"file": "auth0/v3/management/clie... | auth0/auth0-python | 2bdd9008b0124b53360c79dd299331a8190d95f9 | ClientGrants.all is missing `client_id` parameter supported by the API
https://auth0.com/docs/api/management/v2#!/Client_Grants/get_client_grants | diff --git a/auth0/v3/management/client_grants.py b/auth0/v3/management/client_grants.py
index 6b37015..719aab3 100644
--- a/auth0/v3/management/client_grants.py
+++ b/auth0/v3/management/client_grants.py
@@ -24,7 +24,7 @@ class ClientGrants(object):
return url + '/' + id
return url
- def all... |
auth0__auth0-python-195 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"auth0/v3/management/rules_configs.py:RulesConfigs.unset"
],
"edited_modules": [
"auth0/v3/management/rules_configs.py:RulesConfigs"
]
},
"file": "auth0/v3/management/ru... | auth0/auth0-python | af5d863ffe75a4a7cd729c9d084cad6b37bd632e | rules_config.unset does not work
### Description
`rules_config.unset` does not work. It returns a 404 for a known existing key. I believe this is because the `key` param is being passed to the auth0 api as a query param when it should be a path param according to the docs.
https://auth0.com/docs/api/management/v2... | diff --git a/auth0/v3/management/rules_configs.py b/auth0/v3/management/rules_configs.py
index cfde7b0..686f101 100644
--- a/auth0/v3/management/rules_configs.py
+++ b/auth0/v3/management/rules_configs.py
@@ -39,10 +39,7 @@ class RulesConfigs(object):
See: https://auth0.com/docs/api/management/v2#!/Rules_Con... |
auth0__auth0-python-273 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"auth0/v3/authentication/token_verifier.py:TokenVerifier.verify"
],
"edited_modules": [
"auth0/v3/authentication/token_verifier.py:TokenVerifier"
]
},
"file": "auth0/v3/... | auth0/auth0-python | fbeab6a9a92ff51f9cdf6e8e5ab2bdeff683dcf3 | Returning boolean on token validator
Hi,
I'm using the token validator of the authentication submodule. It's raising a TokenValidationError if validation failed and returning nothing (so the method returning None by python internals) if validation success.
I'm not sure is it a good idea. If I use this method insi... | diff --git a/auth0/v3/authentication/token_verifier.py b/auth0/v3/authentication/token_verifier.py
index ea411c0..1f44c08 100644
--- a/auth0/v3/authentication/token_verifier.py
+++ b/auth0/v3/authentication/token_verifier.py
@@ -229,6 +229,9 @@ class TokenVerifier():
organization (str, optional): The expec... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.