instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
borgbackup__borg-5238 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.build_parser",
"src/borg/archiver.py:Archiver.get_args"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file": "src/b... | borgbackup/borg | 7033d5054f82f5db05a65c37ffe63b754a659528 | borg recreate and --exclude-if-present flag behavior isn't very clear
## Have you checked borgbackup docs, FAQ, and open Github issues?
Yes
## Is this a BUG / ISSUE report or a QUESTION?
Documentation Bug, IMO
## System information. For client/server mode post info for both machines.
Linux home-desktop 5.3... | diff --git a/docs/usage/notes.rst b/docs/usage/notes.rst
index 59f56c34..0fd58a63 100644
--- a/docs/usage/notes.rst
+++ b/docs/usage/notes.rst
@@ -84,19 +84,12 @@ use this option also for speeding up operations.
``--umask``
~~~~~~~~~~~
-borg uses a safe default umask of 077 (that means the files borg creates have
-... |
borgbackup__borg-5241 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.do_check",
"src/borg/archiver.py:Archiver.do_recreate",
"src/borg/archiver.py:Archiver.build_parser",
"src/borg/archiver.py:Archiver.get_args",
... | borgbackup/borg | 5b5bd9f7f21b9f06b890906bb6b9eb47733c1772 | recreate: drop the "experimental feature" warning?
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/faq.html
and
- open ... | diff --git a/docs/faq.rst b/docs/faq.rst
index 6df7b035..5585d7d0 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -894,7 +894,7 @@ I am having troubles with some network/FUSE/special filesystem, why?
--------------------------------------------------------------------
Borg is doing nothing special in the filesystem... |
borgbackup__borg-5263 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/repository.py:Repository.prepare_txn",
"src/borg/repository.py:Repository.write_index",
"src/borg/repository.py:Repository.check"
],
"edited_modules": [
"src... | borgbackup/borg | 5ebde5cebc3ef572552b368228eaad4d29f0ee39 | master branch: check shadow_index for separate compact_segments()
Seems like the 1.1-maint code builds the `shadow_index` while doing a (borg create) transaction and then uses that in `compact_segments()` (which is done in the same borg run in 1.1).
In master, compact_segments was split into a separate command and u... | diff --git a/src/borg/repository.py b/src/borg/repository.py
index ad9fa66f..b3489c1a 100644
--- a/src/borg/repository.py
+++ b/src/borg/repository.py
@@ -160,6 +160,7 @@ def __init__(self, path, create=False, exclusive=False, lock_wait=None, lock=Tru
# This is an index of shadowed log entries during this tran... |
borgbackup__borg-5472 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.parse_args"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file": "src/borg/archiver.py"
},
{
"changes": {
"ad... | borgbackup/borg | 47e96bc261886053ee216bce39ee06e57ba2fe4c | --timestamp-aware {now}/{utcnow} placeholders
## Have you checked borgbackup docs, FAQ, and open Github issues?
Yes
## Is this a BUG / ISSUE report or a QUESTION?
Feature request
## System information. For client/server mode post info for both machines.
#### Your borg version (borg -V).
```
martin@ma... | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 5a17929f..a5bc3bff 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -4496,6 +4496,8 @@ def parse_args(self, args=None):
self.do_list, self.do_mount, self.do_umount}
if func not in bypass_allowed:
... |
borgbackup__borg-5606 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.do_create"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file": "src/borg/archiver.py"
}
] | borgbackup/borg | 2851a840034507bf652aa880bb1443f7e8094ecf | Specifying the same path twice breaks hardlink during extraction
If you accidentally specify a path to be backed up twice and this path contain hardlinks, you cannot succesfully extract these files
Eg:
```
mkdir /tmp/borgtest /tmp/borgrepo /tmp/borgtest/a /tmp/borgtest/b /tmp/extractlocation
borg init -e none /tm... | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 651dcf3b..5227852f 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -603,6 +603,9 @@ def create_inner(archive, cache, fso):
exclude_caches=args.exclude_caches, exclude_if_present=args.exclude_if_present... |
borgbackup__borg-5614 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/repository.py:Repository.compact_segments"
],
"edited_modules": [
"src/borg/repository.py:Repository"
]
},
"file": "src/borg/repository.py"
}
] | borgbackup/borg | 9c988ee6324eb2ae490e39a210167e7daca015bd | check empty segments lists in shadow_index
while doing #5263, i tried to remove empty segments lists from the shadow_index, but then tests failed.
as they maybe shouldn't remain in there forever, this needs checking again | diff --git a/src/borg/repository.py b/src/borg/repository.py
index 41dbe36f..091f2852 100644
--- a/src/borg/repository.py
+++ b/src/borg/repository.py
@@ -794,6 +794,8 @@ def complete_xfer(intermediate=True):
try:
self.shadow_index[key].remove(segment)
... |
borgbackup__borg-5693 | [
{
"changes": {
"added_entities": [
"src/borg/repository.py:Repository._delete"
],
"added_modules": null,
"edited_entities": [
"src/borg/repository.py:Repository.compact_segments",
"src/borg/repository.py:Repository.put",
"src/borg/repository.py:Repository.... | borgbackup/borg | 2428d9285d7b3c6c25b3c87a5b5211e0044937f0 | do back/forward ports (46)
https://github.com/borgbackup/borg/issues?utf8=%E2%9C%93&q=label%3Abackport%2F1.1-maint
https://github.com/borgbackup/borg/issues?utf8=%E2%9C%93&q=label%3Aforwardport%2Fmaster
do 3 simple/small or 1 bigger/complex forward/backport from there.
---
:moneybag: [there is a bounty for th... | diff --git a/src/borg/repository.py b/src/borg/repository.py
index 297a3eb1..690a8f95 100644
--- a/src/borg/repository.py
+++ b/src/borg/repository.py
@@ -774,6 +774,8 @@ def complete_xfer(intermediate=True):
try:
self.shadow_index[key].remove(segment)
... |
borgbackup__borg-5696 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.do_create"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file": "src/borg/archiver.py"
}
] | borgbackup/borg | 641418d06de6ff0e589c54666108f80881e2caba | Specifying the same path twice breaks hardlink during extraction
If you accidentally specify a path to be backed up twice and this path contain hardlinks, you cannot succesfully extract these files
Eg:
```
mkdir /tmp/borgtest /tmp/borgrepo /tmp/borgtest/a /tmp/borgtest/b /tmp/extractlocation
borg init -e none /tm... | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 011caa86..66bb4a9c 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -551,6 +551,9 @@ def create_inner(archive, cache):
self._process(archive, cache, matcher, args.exclude_caches, args.exclude_if_present,
... |
borgbackup__borg-5713 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:FilesystemObjectProcessors.process_file"
],
"edited_modules": [
"src/borg/archive.py:FilesystemObjectProcessors"
]
},
"file": "src/borg/archive.py"
... | borgbackup/borg | 29686798af622ff89e3a505368e6ffbd15216e27 | add debug output to files cache checking
there are frequently issues like #5646 with people wondering why their files are classified as M)odified and read/chunked again.
we could all some logging that precisely tells:
- a files cache miss (filename key not in files cache)
- a timestamp mismatch (also telling which... | diff --git a/src/borg/archive.py b/src/borg/archive.py
index 0ea94514..202863c8 100644
--- a/src/borg/archive.py
+++ b/src/borg/archive.py
@@ -1320,13 +1320,14 @@ def process_file(self, *, path, parent_fd, name, st, cache, flags=flags_normal):
item.mode = stat.S_IFREG | stat.S_IMODE(item.mode)
... |
borgbackup__borg-6199 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.do_create"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file": "src/borg/archiver.py"
},
{
"changes": {
"add... | borgbackup/borg | d67a1e77330f32e1be285cd30648b5e5c34754fd | Msg "creating archive at ..." does not expand placeholders in archive name
hi,
running bananian OS (debian) i downloaded https://borg.bauerj.eu/bin/borg-1.1.16-armv6
executing backup using #!/bin/bash script
...
$REPOSITORY::'{hostname}'-'{now:%Y-%m-%d_%T}' \
...
Creating archive at "he... | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 8676229d..54896892 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -581,7 +581,7 @@ def create_inner(archive, cache):
dry_run = args.dry_run
t0 = datetime.utcnow()
t0_monotonic = time.monotonic()
- logger.in... |
borgbackup__borg-6523 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:TarfileObjectProcessors.create_helper"
],
"edited_modules": [
"src/borg/archive.py:TarfileObjectProcessors"
]
},
"file": "src/borg/archive.py"
},
... | borgbackup/borg | 22fc6d1bddc91c1bea163d906ce40f85c8744655 | tar import/export: add --format option, pax-borg metadata
Formats:
- GNU (borg 1.1 default)
- PAX
- BORG
The special `BORG` format would use pax format with some pax headers:
- `BORG.item.version` -> `1`
- `BORG.item.meta` -> `complete borg item metadata, serialised`
Intended application of the `borg` format... | diff --git a/docs/usage/tar.rst b/docs/usage/tar.rst
index 34f307cd..ed1dcc0a 100644
--- a/docs/usage/tar.rst
+++ b/docs/usage/tar.rst
@@ -1,7 +1,7 @@
-.. include:: import-tar.rst.inc
-
.. include:: export-tar.rst.inc
+.. include:: import-tar.rst.inc
+
Examples
~~~~~~~~
::
@@ -9,15 +9,49 @@ Examples
# export... |
borgbackup__borg-6527 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver._delete_repository"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file": "src/borg/archiver.py"
},
{
"changes": {
... | borgbackup/borg | abd3b476de9ea6301fc2d892d377b215b087dd84 | scp-style repo URL parsing broken for ip v6 addrs
Reported by @jeanrjc:
Hello, sorry to comment on this issue, but maybe I did not understand something.
The following does not work with borg 1.1.9:
```bash
$ borg check --archives-only backupNC@[2a02:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx]:/media/pi/myCloudDrive/b... | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 83269ff0..e5f8f515 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -1385,37 +1385,19 @@ def _delete_repository(self, args, repository):
if not args.cache_only:
if args.forced == 0: # without --force, we let the user ... |
borgbackup__borg-6528 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/borg/helpers/parseformat.py:Location"
]
},
"file": "src/borg/helpers/parseformat.py"
}
] | borgbackup/borg | e5e360d5b61c2b91e136a0c59319561190685011 | scp-style repo URL parsing broken for ip v6 addrs
Reported by @jeanrjc:
Hello, sorry to comment on this issue, but maybe I did not understand something.
The following does not work with borg 1.1.9:
```bash
$ borg check --archives-only backupNC@[2a02:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx]:/media/pi/myCloudDrive/b... | diff --git a/src/borg/helpers/parseformat.py b/src/borg/helpers/parseformat.py
index ee32abd7..1c2489cd 100644
--- a/src/borg/helpers/parseformat.py
+++ b/src/borg/helpers/parseformat.py
@@ -341,24 +341,33 @@ class Location:
(?P<archive>[^/]+) # archive name must not contain "/... |
borgbackup__borg-6529 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/borg/helpers/parseformat.py:Location"
]
},
"file": "src/borg/helpers/parseformat.py"
}
] | borgbackup/borg | 269b94828458dfcea6c684e925ec61d9d16bd214 | scp-style repo URL parsing broken for ip v6 addrs
Reported by @jeanrjc:
Hello, sorry to comment on this issue, but maybe I did not understand something.
The following does not work with borg 1.1.9:
```bash
$ borg check --archives-only backupNC@[2a02:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:xxxx]:/media/pi/myCloudDrive/b... | diff --git a/docs/faq.rst b/docs/faq.rst
index bbf81f15..b3c3d731 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -569,7 +569,8 @@ Using ``BORG_PASSCOMMAND`` with a properly permissioned file
directory and use permissions to keep anyone else from reading it. For
example, first create a key::
- (umask 0077; h... |
borgbackup__borg-6544 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:Archive._calc_stats",
"src/borg/archive.py:Archive.restore_attrs"
],
"edited_modules": [
"src/borg/archive.py:Archive"
]
},
"file": "src/bor... | borgbackup/borg | 56c27a99d0e1482003003bf1f43c43281c42b457 | 1.2.0 crashes when calculating statistics with older archives containing %
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/... | diff --git a/src/borg/archive.py b/src/borg/archive.py
index 7e16afb9..e8c0a1fb 100644
--- a/src/borg/archive.py
+++ b/src/borg/archive.py
@@ -49,6 +49,7 @@
from .remote import cache_if_remote
from .repository import Repository, LIST_SCAN_LIMIT
+has_lchmod = hasattr(os, 'lchmod')
has_link = hasattr(os, 'link')
... |
borgbackup__borg-6556 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.do_benchmark_cpu"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file": "src/borg/archiver.py"
},
{
"changes": {
... | borgbackup/borg | eba6d5cd1c4237b45273b4496ebbbd4e64783179 | move kdf code
`borg.helpers.passphrase` module has a `Passphrase.kdf` method.
- that's crypto code, so it should rather be below `borg.crypto` package
- all the other code there is just rather simple input / output / env var processing
@hexagonrecursion ^^^
(master branch only) | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 318a8f20..d2a74562 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -46,7 +46,7 @@
from .constants import * # NOQA
from .compress import CompressionSpec
from .crypto.key import key_creator, key_argument_names, tam_required_fil... |
borgbackup__borg-6604 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/borg/constants.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/crypt... | borgbackup/borg | d2c22633e8c7108bd3f828ea9197056c8f9713e8 | switch argon2 keys to chacha20-poly1305 cipher
recently we had chosen to use aes-ctr-hmac-sha256 ciphersuite for the new argon2 keys.
the reasoning for this was:
1. be able to get rid of the low_level.AES class long term
2. we could not use AES-OCB or CHACHA20-POLY1305 because LibreSSL does not have that and we ... | diff --git a/src/borg/constants.py b/src/borg/constants.py
index 208991ee..0b2ef16a 100644
--- a/src/borg/constants.py
+++ b/src/borg/constants.py
@@ -112,8 +112,8 @@
KEY_ALGORITHMS = {
# encrypt-and-MAC, kdf: PBKDF2(HMAC−SHA256), encryption: AES256-CTR, authentication: HMAC-SHA256
'pbkdf2': 'sha256',
- #... |
borgbackup__borg-6616 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.do_benchmark_cpu",
"src/borg/archiver.py:Archiver.build_parser"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file"... | borgbackup/borg | 7fd53903f4a9d485933119eed27702edc6cbc5f6 | FileNotFoundError: [Errno 2] No such file or directory: '/mnt/sshfs/borg-cache/REPOID/txn.active/files'
## Is this a BUG / ISSUE report or a QUESTION?
Bug
## System information. For client/server mode post info for both machines.
#### Your borg version (borg -V).
borg 1.1.17
#### Operating system (distri... | diff --git a/docs/usage/init.rst.inc b/docs/usage/init.rst.inc
index bfcfc40e..5bf1cb64 100644
--- a/docs/usage/init.rst.inc
+++ b/docs/usage/init.rst.inc
@@ -134,27 +134,27 @@ in the upper part of the table, in the lower part is the old and/or unsafe(r) st
.. nanorst: inline-fill
-+-------------------------------... |
borgbackup__borg-6619 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.do_benchmark_cpu",
"src/borg/archiver.py:Archiver.build_parser"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file"... | borgbackup/borg | 7fd53903f4a9d485933119eed27702edc6cbc5f6 | invalid repository
if an old borg detects a repo version > 1 it just says "invalid repository".
it could be a bit more helpful and e.g. tell "you need a new borg release to support repo version X". | diff --git a/docs/usage/init.rst.inc b/docs/usage/init.rst.inc
index bfcfc40e..5bf1cb64 100644
--- a/docs/usage/init.rst.inc
+++ b/docs/usage/init.rst.inc
@@ -134,27 +134,27 @@ in the upper part of the table, in the lower part is the old and/or unsafe(r) st
.. nanorst: inline-fill
-+-------------------------------... |
borgbackup__borg-6682 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:Statistics.show_progress"
],
"edited_modules": [
"src/borg/archive.py:Statistics"
]
},
"file": "src/borg/archive.py"
}
] | borgbackup/borg | a3e99a2b512d3d78d3aa7d4e8d9c652dc67ae745 | borg create: Everything 0 archive_progress at end of backup
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/faq.html
and
... | diff --git a/docs/faq.rst b/docs/faq.rst
index b500ae46..8ef1b82a 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -1080,10 +1080,6 @@ will be slow because it would chunk all the files each time. If you set
BORG_FILES_CACHE_TTL to at least 26 (or maybe even a small multiple of that),
it would be much faster.
-Beside... |
borgbackup__borg-6683 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:Statistics.show_progress"
],
"edited_modules": [
"src/borg/archive.py:Statistics"
]
},
"file": "src/borg/archive.py"
}
] | borgbackup/borg | ae417cccf6a2653c010a1f379f3fdef8e55d7ccd | borg create: Everything 0 archive_progress at end of backup
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/faq.html
and
... | diff --git a/docs/faq.rst b/docs/faq.rst
index 5a14059e..2a70d287 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -1033,10 +1033,6 @@ will be slow because it would chunk all the files each time. If you set
BORG_FILES_CACHE_TTL to at least 26 (or maybe even a small multiple of that),
it would be much faster.
-Beside... |
borgbackup__borg-6684 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:Statistics.show_progress"
],
"edited_modules": [
"src/borg/archive.py:Statistics"
]
},
"file": "src/borg/archive.py"
}
] | borgbackup/borg | c2b6ccf9bbf230e2465f0e18bd2833a573e86f52 | borg create: Everything 0 archive_progress at end of backup
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/faq.html
and
... | diff --git a/docs/faq.rst b/docs/faq.rst
index 88b6792a..fa254c93 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -1006,10 +1006,6 @@ will be slow because it would chunk all the files each time. If you set
BORG_FILES_CACHE_TTL to at least 26 (or maybe even a small multiple of that),
it would be much faster.
-Beside... |
borgbackup__borg-6821 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"setup_docs.py:build_man"
]
},
"file": "setup_docs.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entit... | borgbackup/borg | 677de50364c4762a43b0fda969d8d54c4507c703 | remove legacy crypto modes for new repos
#6463 added shiny nice AEAD crypto modes and also the usage of session keys, which solves the potential issues with the legacy AES-CTR based crypto (mainly about nonce management to avoid nonce reuse).
To get rid of the old stuff quickly, I think we should remove the legacy c... | diff --git a/setup_docs.py b/setup_docs.py
index 2f9dcb35..7d985ebf 100644
--- a/setup_docs.py
+++ b/setup_docs.py
@@ -303,7 +303,6 @@ class build_man(Command):
'key_change-passphrase': 'key',
'key_change-location': 'key',
- 'key_change-algorithm': 'key',
'key_export': 'key',
... |
borgbackup__borg-6986 | [
{
"changes": {
"added_entities": [
"src/borg/remote.py:RemoteRepository.flags",
"src/borg/remote.py:RemoteRepository.flags_many"
],
"added_modules": null,
"edited_entities": [
"src/borg/remote.py:RemoteRepository.list"
],
"edited_modules": [
"s... | borgbackup/borg | 204ecece091d790eae1ea777b1cfe97ef106c495 | repository: add flags support (master branch)
- set flags for some or all chunks (use mask/value method to set/clear one or multiple flags)
- list chunkids that have specific flags (add mask/value to .list method)
See hashindex `NSIndex.iteritems/.flags` and `NSKeyIterator`.
Should work for `Repository` and `Rem... | diff --git a/src/borg/remote.py b/src/borg/remote.py
index 016fda75..962f785f 100644
--- a/src/borg/remote.py
+++ b/src/borg/remote.py
@@ -146,6 +146,8 @@ class RepositoryServer: # pragma: no cover
"commit",
"delete",
"destroy",
+ "flags",
+ "flags_many",
"get",
... |
borgbackup__borg-7057 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:ChunkBuffer.__init__",
"src/borg/archive.py:ArchiveRecreater.create_target"
],
"edited_modules": [
"src/borg/archive.py:ChunkBuffer",
"src/borg/ar... | borgbackup/borg | f49133da04dd08546f49c8d587a351fb2bcb0c16 | `borg recreate` fails with `KeyError: 'sparse'` when using `fixed` chunker
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/... | diff --git a/src/borg/archive.py b/src/borg/archive.py
index 8cd261ad..5d9d9707 100644
--- a/src/borg/archive.py
+++ b/src/borg/archive.py
@@ -349,7 +349,7 @@ def __init__(self, key, chunker_params=ITEMS_CHUNKER_PARAMS):
self.packer = msgpack.Packer()
self.chunks = []
self.key = key
- ... |
borgbackup__borg-7066 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:ChunkBuffer.__init__",
"src/borg/archive.py:ArchiveRecreater.create_target"
],
"edited_modules": [
"src/borg/archive.py:ChunkBuffer",
"src/borg/ar... | borgbackup/borg | b5e88129b44983f7a66f46f6c8b61a190129e4f1 | `borg recreate` fails with `KeyError: 'sparse'` when using `fixed` chunker
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/... | diff --git a/src/borg/archive.py b/src/borg/archive.py
index 9415ac7c..6c28353e 100644
--- a/src/borg/archive.py
+++ b/src/borg/archive.py
@@ -322,7 +322,7 @@ def __init__(self, key, chunker_params=ITEMS_CHUNKER_PARAMS):
self.packer = msgpack.Packer()
self.chunks = []
self.key = key
- ... |
borgbackup__borg-7276 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:Archive.extract_item",
"src/borg/archive.py:FilesystemObjectProcessors.process_symlink",
"src/borg/archive.py:TarfileObjectProcessors.process_symlink"
],
... | borgbackup/borg | 1df7c244c45c06673f1b43ce0db055bec13b54f6 | borg2: symlink source vs. target
there seem to be different naming conventions about symlink source and target.
Let's consider the result of `ln -s A B`.
Convention1: Some say A is the `source` and `B` is the target (which seems a valid PoV, especially when describing the **creation of a new symlink**, because A ... | diff --git a/docs/internals/frontends.rst b/docs/internals/frontends.rst
index 7f2af1e5..ca4d2858 100644
--- a/docs/internals/frontends.rst
+++ b/docs/internals/frontends.rst
@@ -472,8 +472,9 @@ Refer to the *borg list* documentation for the available keys and their meaning.
Example (excerpt) of ``borg list --json-l... |
borgbackup__borg-7300 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/borg/helpers/__init__.py"
},
{
"changes": {
"added_entities": [
"src/borg/helpers/fs.py:join_base_dir"
],
"added_modules... | borgbackup/borg | 653c051851013d5d8f0d3a74b4c05f2affe72607 | borg2: use platformdirs python package?
@RayyanAnsari suggested to use the `platformdirs` python lib ( https://github.com/platformdirs/platformdirs ) and I had a closer look now:
- the code quality seems decent, from an experienced developer
- the amount of code is not much, but also not trivial. it might be also i... | diff --git a/.coafile b/.coafile
index 625090a1..b6300b66 100644
--- a/.coafile
+++ b/.coafile
@@ -13,7 +13,8 @@ file_naming_convention = snake
[all.python]
files = src/borg/**/*.py
-bears = PyDocStyleBear, PyLintBear
+bears = PEP8Bear, PyDocStyleBear, PyLintBear
+pep_ignore = E123,E125,E126,E127,E128,E226,E301,E30... |
borgbackup__borg-7333 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:ArchiveRecreater.process_items"
],
"edited_modules": [
"src/borg/archive.py:ArchiveRecreater"
]
},
"file": "src/borg/archive.py"
},
{
"chang... | borgbackup/borg | 366731ba004e69e6c479a6ce2b5ab1fdbbed3e4f | borg list --dry-run status chars, shall we change them?
Current output (borg <= 2.0):
```
- /some/file # "-" means "not backed up" (due to dry-run)
x /some/other/file # "x" means excluded
```
pstn on IRC found it confusing that they are not related to the exclusion chars (+, -, !).
So, we co... | diff --git a/src/borg/archive.py b/src/borg/archive.py
index a7b457a5..af869871 100644
--- a/src/borg/archive.py
+++ b/src/borg/archive.py
@@ -2341,10 +2341,10 @@ def process_items(self, archive, target):
for item in archive.iter_items():
if not matcher.match(item.path):
- self.pr... |
borgbackup__borg-7407 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver.do_debug_get_obj",
"src/borg/archiver.py:Archiver.do_debug_put_obj",
"src/borg/archiver.py:Archiver.build_parser"
],
"edited_modules": [
... | borgbackup/borg | 6e8c58c125fb325ac10c48245c3a82b0a0a96657 | borg debug put-obj can not put a manifest
borg 1.2-maint branch.
One can only give the repo and the file it shall put, the chunkid gets computed automatically.
In case of the repository manifest chunk, that does not work, because the chunkid must be all-zero (and not computed). | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 15652119..ec717997 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -9,7 +9,6 @@
import configparser
import faulthandler
import functools
- import hashlib
import inspect
import itertools
import json
@@ -2193,2... |
borgbackup__borg-7448 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/helpers/fs.py:get_cache_dir",
"src/borg/helpers/fs.py:get_config_dir"
],
"edited_modules": [
"src/borg/helpers/fs.py:get_cache_dir",
"src/borg/helpers/fs.py:... | borgbackup/borg | 1428ffeae90aea899b70ee0cd96812bf7286d6e0 | wrong cache directories
From a discussion post:
> I noticed that with borg 2 the cache directories do *not* contain the
> name borg which is a bit annoying and i would prefer the old behaviour.
>
> Borg 1.2
> /home/dietmar/.cache/borg/0a2cb8f22adaa78a1863b028f3d1629393ef0fdd99b3b61c11d871de9eaaee8b/README
> ... | diff --git a/src/borg/helpers/fs.py b/src/borg/helpers/fs.py
index 80574655..af729709 100644
--- a/src/borg/helpers/fs.py
+++ b/src/borg/helpers/fs.py
@@ -106,7 +106,7 @@ def get_cache_dir(*, legacy=False):
cache_dir = os.environ.get("BORG_CACHE_DIR", os.path.join(cache_home, "borg"))
else:
cache... |
borgbackup__borg-7465 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver.py:Archiver._import_tar",
"src/borg/archiver.py:Archiver.build_parser"
],
"edited_modules": [
"src/borg/archiver.py:Archiver"
]
},
"file": "sr... | borgbackup/borg | 671c66361d1d39cb501088bd7a8de100d90ba38a | import-tar for multiple or concatenated tar files
## Have you checked borgbackup docs, FAQ, and open GitHub issues?
Yes
## Is this a BUG / ISSUE report or a QUESTION?
Question
## System information. For client/server mode post info for both machines.
#### Your borg version (borg -V).
borg 1.2.3
###... | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 1ff8da07..82ad00e1 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -1763,7 +1763,8 @@ def _import_tar(self, args, repository, manifest, key, cache, tarstream):
log_json=args.log_json, iec=args.iec,
... |
borgbackup__borg-7474 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver/transfer_cmd.py:TransferMixIn.do_transfer"
],
"edited_modules": [
"src/borg/archiver/transfer_cmd.py:TransferMixIn"
]
},
"file": "src/borg/archiver/tr... | borgbackup/borg | 8dc52b23dbf1ebe54e827fc545db01dc4f830d5f | transfer / repo_obj.parse: support assert_id()
`borg transfer` currently tries to be quick and does not decompress the objects it fetches from the src repo.
Because it does not decompress, it also does not call `assert_id(plaintext)` to verify that object contents and object id match.
Guess if the src repo is ful... | diff --git a/src/borg/archiver/transfer_cmd.py b/src/borg/archiver/transfer_cmd.py
index c3fa8c9b..dcde6b88 100644
--- a/src/borg/archiver/transfer_cmd.py
+++ b/src/borg/archiver/transfer_cmd.py
@@ -106,8 +106,11 @@ def do_transfer(self, args, *, repository, manifest, cache, other_repository=Non
... |
borgbackup__borg-7492 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver/create_cmd.py:CreateMixIn.build_parser_create"
],
"edited_modules": [
"src/borg/archiver/create_cmd.py:CreateMixIn"
]
},
"file": "src/borg/archiver/cr... | borgbackup/borg | 6b02c05f2b644320850fb040c2631b3090bb6db6 | Progress output generates extra lines with some filenames
I'm running `borg create --no-files-cache --progress --numeric-owner` in an interactive terminal, and with most filenames, the command shows only one line of progress with some counters and the current filename. However, with some filenames, it seems to go on to... | diff --git a/src/borg/archiver/create_cmd.py b/src/borg/archiver/create_cmd.py
index 93f93107..773632be 100644
--- a/src/borg/archiver/create_cmd.py
+++ b/src/borg/archiver/create_cmd.py
@@ -635,13 +635,13 @@ def build_parser_create(self, subparsers, common_parser, mid_common_parser):
The ``-x`` or ``--one-fil... |
borgbackup__borg-7517 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver/__init__.py:format_tb",
"src/borg/archiver/__init__.py:main"
],
"edited_modules": [
"src/borg/archiver/__init__.py:format_tb",
"src/borg/archiver/__... | borgbackup/borg | 9263705de74cfa26be4e2a6395d1d6ae2ff70428 | highlander options "special effects"
borg has some cli options with `action=Highlander`, which raises an error if there is more than one (see also #6269).
E.g. it does not make sense to give `--umask` more than once (especially not with different values).
But, this error is not raised, if the first of these optio... | diff --git a/src/borg/archiver/__init__.py b/src/borg/archiver/__init__.py
index 51423abd..724afe08 100644
--- a/src/borg/archiver/__init__.py
+++ b/src/borg/archiver/__init__.py
@@ -564,29 +564,6 @@ def sig_trace_handler(sig_no, stack): # pragma: no cover
faulthandler.dump_traceback()
-def format_tb(exc):
- ... |
borgbackup__borg-7521 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/helpers/parseformat.py:ChunkerParams",
"src/borg/helpers/parseformat.py:FilesCacheMode",
"src/borg/helpers/parseformat.py:SortBySpec"
],
"edited_modules": [
... | borgbackup/borg | 9307f804bfc07c7807dbe09f6d83008cc105fdf5 | borg2 throws error for valid(?) chunker parameters
## Have you checked borgbackup docs, FAQ, and open GitHub issues?
Yes
## Is this a BUG / ISSUE report or a QUESTION?
A bug, probably
## System information. For client/server mode post info for both machines.
#### Your borg version (borg -V).
borg-2.0.0b... | diff --git a/src/borg/compress.pyx b/src/borg/compress.pyx
index e120f133..e259c374 100644
--- a/src/borg/compress.pyx
+++ b/src/borg/compress.pyx
@@ -15,6 +15,7 @@ which compressor has been used to compress the data and dispatch to the correct
decompressor.
"""
+from argparse import ArgumentTypeError
import rando... |
borgbackup__borg-7544 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/manifest.py:filter_archives_by_date",
"src/borg/manifest.py:Archives.list"
],
"edited_modules": [
"src/borg/manifest.py:filter_archives_by_date",
"src/borg/m... | borgbackup/borg | 27f2dffdf867697b3bfe8919c61657171851d71d | Borg2: ValueError on date-based matching
## Have you checked borgbackup docs, FAQ, and open GitHub issues?
Yes
## Is this a BUG / ISSUE report or a QUESTION?
BUG
## System information. For client/server mode post info for both machines.
#### Your borg version (borg -V).
borg 2.0.0b5
#### Operating sy... | diff --git a/src/borg/manifest.py b/src/borg/manifest.py
index 4eb9b1e3..c6409f4b 100644
--- a/src/borg/manifest.py
+++ b/src/borg/manifest.py
@@ -39,6 +39,9 @@ def get_first_and_last_archive_ts(archives_list):
timestamps = [x.ts for x in archives_list]
return min(timestamps), max(timestamps)
+ i... |
borgbackup__borg-7583 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/cache.py:SecurityManager.__init__",
"src/borg/cache.py:SecurityManager.destroy"
],
"edited_modules": [
"src/borg/cache.py:SecurityManager"
]
},
"file":... | borgbackup/borg | 852172f5ce12d0a709e2e8884356a9a3378a71b9 | BORG_SECURITY_DIR should be in XDG_HOME_DATA, not XDG_HOME_CONFIG
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/faq.html
... | diff --git a/docs/faq.rst b/docs/faq.rst
index 83d5bfd5..943ae6e7 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -410,13 +410,6 @@ How important is the $HOME/.config/borg directory?
The Borg config directory has content that you should take care of:
-``security`` subdirectory
- Each directory here represents one... |
borgbackup__borg-7615 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver/_common.py:get_repository",
"src/borg/archiver/_common.py:define_common_options"
],
"edited_modules": [
"src/borg/archiver/_common.py:get_repository",
... | borgbackup/borg | 9f51600f206a712cffeaf954cb9939d2aada3e81 | Add UNIX domain socket transport
/kind enhancement
When creating full system backups one must usually run Borg as `root` to avoid permission issues. However, it might be undesirable to store these backups as root, as people often prefer storing backups in known places (like `/var/backups`) owned by dedicated users (... | diff --git a/docs/usage/general/environment.rst.inc b/docs/usage/general/environment.rst.inc
index 8fbd8210..0ac90928 100644
--- a/docs/usage/general/environment.rst.inc
+++ b/docs/usage/general/environment.rst.inc
@@ -150,6 +150,10 @@ Directories and files:
`XDG env var`_ ``XDG_DATA_HOME`` is set, then ``$XDG... |
borgbackup__borg-7712 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/manifest.py:Manifest.load",
"src/borg/manifest.py:Manifest.write"
],
"edited_modules": [
"src/borg/manifest.py:Manifest"
]
},
"file": "src/borg/manifes... | borgbackup/borg | e69568309599bd88313c8e5c756296063a9b7e9b | manifest: move item_keys to config dict
borg2 / master only.
From the docs:
`config` is a general-purpose location for additional metadata. All versions
of Borg preserve its contents (it may have been a better place for `item_keys`,
which is not preserved by unaware Borg versions, releases predating 1.0.4). | diff --git a/setup.cfg b/setup.cfg
index 327a38c7..78762794 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -159,7 +159,7 @@ per_file_ignores =
src/borg/testsuite/__init__.py:E501,F401
src/borg/testsuite/archive.py:E128,W504
src/borg/testsuite/archiver/__init__.py:E128,E501,E722,F401,F405,F811
- src/borg/te... |
borgbackup__borg-7714 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"setup_docs.py:build_man.write_man_header"
],
"edited_modules": [
"setup_docs.py:build_man"
]
},
"file": "setup_docs.py"
},
{
"changes": {
"added_entities"... | borgbackup/borg | 4dfce1cca485ae478c650b7128297d0fde56bbfb | Restore zero'd chunks (`borg check --repair`) by the next `borg create`
/kind enhancement
Borg currently repairs broken repos (e.g. due to failing hardware) by zero'ing missing or otherwise damaged chunks (`borg check --repair`). This is fine because it makes an otherwise broken repo usable again at the cost of loos... | diff --git a/docs/development.rst b/docs/development.rst
index 7f38545d..5db1f6d5 100644
--- a/docs/development.rst
+++ b/docs/development.rst
@@ -146,9 +146,12 @@ follow their `guide about avoiding ruining git blame`_:
Continuous Integration
----------------------
-All pull requests go through `GitHub Actions`_, w... |
borgbackup__borg-7941 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/locking.py:LockRoster.modify",
"src/borg/locking.py:LockRoster.migrate_lock"
],
"edited_modules": [
"src/borg/locking.py:LockRoster"
]
},
"file": "src/... | borgbackup/borg | 7c20bb52d1085a27bc75496c313679a045b058e3 | Non fatal bug in removing lock after archive creation
Hi,
I run borg 1.2.6 like this:
`borg create --verbose --filter AME --list --stats --show-rc --compression auto,lzma,6 --noflags --noacls --noxattrs --exclude-caches "::${BORG_BACKUP_NAME_PREFIX}$(date '+%Y-%m-%d_%H-%M-%S')" "${BORG_BACKUP_SOURCE}" --exclude-f... | diff --git a/src/borg/locking.py b/src/borg/locking.py
index ca64eeb0..59508180 100644
--- a/src/borg/locking.py
+++ b/src/borg/locking.py
@@ -8,7 +8,7 @@
from .helpers import Error, ErrorWithTraceback
from .logger import create_logger
-ADD, REMOVE = "add", "remove"
+ADD, REMOVE, REMOVE2 = "add", "remove", "remove2... |
borgbackup__borg-7942 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/locking.py:LockRoster.modify",
"src/borg/locking.py:LockRoster.migrate_lock"
],
"edited_modules": [
"src/borg/locking.py:LockRoster"
]
},
"file": "src/... | borgbackup/borg | e6d40f63d46b7fa9b4e3f549d66fdc5ffa1fd972 | Non fatal bug in removing lock after archive creation
Hi,
I run borg 1.2.6 like this:
`borg create --verbose --filter AME --list --stats --show-rc --compression auto,lzma,6 --noflags --noacls --noxattrs --exclude-caches "::${BORG_BACKUP_NAME_PREFIX}$(date '+%Y-%m-%d_%H-%M-%S')" "${BORG_BACKUP_SOURCE}" --exclude-f... | diff --git a/src/borg/locking.py b/src/borg/locking.py
index 9a426780..ada8ae87 100644
--- a/src/borg/locking.py
+++ b/src/borg/locking.py
@@ -7,7 +7,7 @@
from .helpers import Error, ErrorWithTraceback
from .logger import create_logger
-ADD, REMOVE = 'add', 'remove'
+ADD, REMOVE, REMOVE2 = 'add', 'remove', 'remove2... |
borgbackup__borg-8107 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:FilesystemObjectProcessors.create_helper",
"src/borg/archive.py:FilesystemObjectProcessors.process_dir_with_fd",
"src/borg/archive.py:FilesystemObjectProcessors.proce... | borgbackup/borg | f94cdee94ac4ce68110574ef14da4b5fed23ed50 | Multiple relative paths for `borg create`
Docs at https://borgbackup.readthedocs.io/en/stable/usage/create.html say:
> Paths are added to the archive as they are given, that means if relative paths are desired, the command has to be run from the correct directory.
And further down, there's an example:
```
# B... | diff --git a/docs/usage/create.rst b/docs/usage/create.rst
index f2ff4966..0bec42ff 100644
--- a/docs/usage/create.rst
+++ b/docs/usage/create.rst
@@ -10,6 +10,9 @@ Examples
# same, but list all files as we process them
$ borg create --list my-documents ~/Documents
+ # Backup /mnt/disk/docs, but strip pa... |
borgbackup__borg-8257 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/cache.py:LocalCache.__init__",
"src/borg/cache.py:LocalCache.wipe_cache"
],
"edited_modules": [
"src/borg/cache.py:LocalCache"
]
},
"file": "src/borg/c... | borgbackup/borg | aada9859ff025d15010ab71352958d4639147fd7 | no automatic rebuild of a deleted chunks file
borg does not tolerate a deleted chunks file (deleted because it was corrupted) due to the integrity checks:
```
u0_a151@localhost ~> ./borgbackup.sh
Fri Jun 5 21:11:53 EDT 2020 Starting backup
Killed stale lock localhost@75173968615802.3665-0.
Removed stale exclu... | diff --git a/src/borg/cache.py b/src/borg/cache.py
index b6cd5c0a..c36572c0 100644
--- a/src/borg/cache.py
+++ b/src/borg/cache.py
@@ -531,7 +531,12 @@ def __init__(
self.security_manager.assert_access_unknown(warn_if_unencrypted, manifest, self.key)
self.create()
- self.open()
+ ... |
borgbackup__borg-8277 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/cache.py:LocalCache.__init__",
"src/borg/cache.py:LocalCache.wipe_cache"
],
"edited_modules": [
"src/borg/cache.py:LocalCache"
]
},
"file": "src/borg/c... | borgbackup/borg | add9cafce6c699fb386f0eb2637318e85fba28f6 | no automatic rebuild of a deleted chunks file
borg does not tolerate a deleted chunks file (deleted because it was corrupted) due to the integrity checks:
```
u0_a151@localhost ~> ./borgbackup.sh
Fri Jun 5 21:11:53 EDT 2020 Starting backup
Killed stale lock localhost@75173968615802.3665-0.
Removed stale exclu... | diff --git a/src/borg/cache.py b/src/borg/cache.py
index 0df8d49d..f6d5baeb 100644
--- a/src/borg/cache.py
+++ b/src/borg/cache.py
@@ -488,7 +488,12 @@ def __init__(self, repository, key, manifest, path=None, sync=True, warn_if_unen
self.security_manager.assert_access_unknown(warn_if_unencrypted, manifest,... |
borgbackup__borg-8389 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archive.py:FilesystemObjectProcessors.process_file"
],
"edited_modules": [
"src/borg/archive.py:FilesystemObjectProcessors"
]
},
"file": "src/borg/archive.py"
... | borgbackup/borg | 275e5e136c83256a5d61fdfacfd8669ef51fcf8f | improve files cache
We can build the files cache by reading the "previous" archive from the repo after we have the "backup series" feature (#8379 is merged), see:
https://github.com/borgbackup/borg/issues/7930#issuecomment-2337704899
Pros:
- saves local disk space of the files cache
- no need to "persist the fi... | diff --git a/docs/faq.rst b/docs/faq.rst
index 20c1c145..e3de4bf9 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -837,50 +837,29 @@ already used.
By default, ctime (change time) is used for the timestamps to have a rather
safe change detection (see also the --files-cache option).
-Furthermore, pathnames recorded i... |
borgbackup__borg-8405 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver/_common.py:get_repository"
],
"edited_modules": [
"src/borg/archiver/_common.py:get_repository"
]
},
"file": "src/borg/archiver/_common.py"
},
{
... | borgbackup/borg | 4d8954ecbb7d36f69af70a7573039e7e35c8faf6 | rclone Integration
Hi,
I'm one of developers of [rclone](https://github.com/rclone/rclone) a command line tool written in golang to interact with various cloud storage providers. I'm wondering if the team here is interested in some sort of integration with rclone.
We have a number of users that users that use borg w... | diff --git a/docs/quickstart.rst b/docs/quickstart.rst
index 918f059c..47c493fc 100644
--- a/docs/quickstart.rst
+++ b/docs/quickstart.rst
@@ -411,6 +411,7 @@ Due to using the `borgstore` project, borg now also supports other kinds of
- sftp: the borg client will directly talk to an sftp server.
This does not req... |
borgbackup__borg-8459 | [
{
"changes": {
"added_entities": [
"src/borg/archiver/prune_cmd.py:default_period_func",
"src/borg/archiver/prune_cmd.py:quarterly_13weekly_period_func",
"src/borg/archiver/prune_cmd.py:quarterly_3monthly_period_func"
],
"added_modules": [
"src/borg/archiver/pru... | borgbackup/borg | ea619e759d15e7fedd9067db79fbbfc79de6866b | prune option keep quarterly
<!--
Thank you for reporting an issue.
*IMPORTANT* - *before* creating a new issue please look around:
- Borgbackup documentation: http://borgbackup.readthedocs.io/en/stable/index.html
- FAQ: https://borgbackup.readthedocs.io/en/stable/faq.html
and
- open issues in Github tracke... | diff --git a/docs/misc/prune-example.txt b/docs/misc/prune-example.txt
index bc6bb209..af749e16 100644
--- a/docs/misc/prune-example.txt
+++ b/docs/misc/prune-example.txt
@@ -100,3 +100,27 @@ example simple. They all work in basically the same way.
The weekly rule is easy to understand roughly, but hard to understan... |
borgbackup__borg-8469 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver/delete_cmd.py:DeleteMixIn.do_delete"
],
"edited_modules": [
"src/borg/archiver/delete_cmd.py:DeleteMixIn"
]
},
"file": "src/borg/archiver/delete_cmd.p... | borgbackup/borg | 3cae96cc993b57b35ffd18a9c3cfb93571323f41 | add a "protected" flag for archives
e.g. as a field in the entries of the manifest like the timestamp.
The use case would be an archive that represents a publication- or a "certification approved"-state. The delete function only needs to check the flag and that return without deleting it. This affects the pruning as w... | diff --git a/src/borg/archiver/delete_cmd.py b/src/borg/archiver/delete_cmd.py
index 5ad81f95..5ff05d33 100644
--- a/src/borg/archiver/delete_cmd.py
+++ b/src/borg/archiver/delete_cmd.py
@@ -22,6 +22,7 @@ def do_delete(self, args, repository):
archive_infos = [manifest.archives.get_one([args.name])]
... |
borgbackup__borg-8575 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/archiver/extract_cmd.py:ExtractMixIn.do_extract"
],
"edited_modules": [
"src/borg/archiver/extract_cmd.py:ExtractMixIn"
]
},
"file": "src/borg/archiver/extract... | borgbackup/borg | 26b2ffc8a0135df18a6b97facae23e495bbe7c99 | No dry-run flags when using borg extract
Using borg 1.4, I checked the use of "flags" when doing a dry-run for different borg commands.
The command `borg extract --dry-run --list` does not print the flags (that are used with e.g. borg create / borg recreate
Instead, `borg extract` prints only the list of items th... | diff --git a/src/borg/archiver/extract_cmd.py b/src/borg/archiver/extract_cmd.py
index d0fafc1d..c7fc4b08 100644
--- a/src/borg/archiver/extract_cmd.py
+++ b/src/borg/archiver/extract_cmd.py
@@ -56,33 +56,50 @@ def do_extract(self, args, repository, manifest, archive):
else:
pi = None
- f... |
borgbackup__borg-8605 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borg/crypto/key.py:FlexiKey.detect"
],
"edited_modules": [
"src/borg/crypto/key.py:FlexiKey"
]
},
"file": "src/borg/crypto/key.py"
},
{
"changes": {
"... | borgbackup/borg | 5b141e2077efc0c5b0c263e270ce7b98b1212c2c | add passphrase debugging option?
Sometimes people have issues when trying to access a borg repo from a new or newly installed host with borg telling them that the passphrase is incorrect.
Besides the obvious root cause of the passphrase really being incorrect, there are also:
- keyboard issues (kbd mapping, deadkey... | diff --git a/src/borg/crypto/key.py b/src/borg/crypto/key.py
index 82ac416c..9f8f99f0 100644
--- a/src/borg/crypto/key.py
+++ b/src/borg/crypto/key.py
@@ -371,10 +371,12 @@ def detect(cls, repository, manifest_data):
passphrase = Passphrase.getpass(prompt)
if key.load(target, p... |
borgbackup__borgstore-26 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borgstore/backends/sftp.py:get_sftp_backend",
"src/borgstore/backends/sftp.py:Sftp.__init__"
],
"edited_modules": [
"src/borgstore/backends/sftp.py:get_sftp_backend",
... | borgbackup/borgstore | 5f5f522922d6e309466ea89eeb22bb7d4aa74f3a | sftp URL's username should be optional
As noticed by @bket there: https://github.com/borgbackup/borg/issues/8373
| diff --git a/src/borgstore/backends/sftp.py b/src/borgstore/backends/sftp.py
index 8da9dbb..1d25e0c 100644
--- a/src/borgstore/backends/sftp.py
+++ b/src/borgstore/backends/sftp.py
@@ -6,6 +6,7 @@ from pathlib import Path
import random
import re
import stat
+from typing import Optional
import paramiko
@@ -16,10... |
borgbackup__borgstore-38 | [
{
"changes": {
"added_entities": [
"src/borgstore/backends/sftp.py:Sftp._get_host_config_from_file",
"src/borgstore/backends/sftp.py:Sftp._get_host_config"
],
"added_modules": null,
"edited_entities": [
"src/borgstore/backends/sftp.py:get_sftp_backend",
"s... | borgbackup/borgstore | 90b4363c1f1262fc1fc7c6120f2ce114876ae797 | SFTP backend does not use local SSH-client's config
Coming from duplicity - which AFAIK also uses paramiko for accessing SFTP endpoints - I expected to be able to log into the SFTP backend the same (or similar) way.
For duplicity using the SFTP backend my URL is rather simple: `sftp://bck-host//storage/backup/duplic... | diff --git a/pyproject.toml b/pyproject.toml
index 1daaf02..2f187d2 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -23,7 +23,7 @@ classifiers = [
license = {text="BSD"}
requires-python = ">=3.9"
dependencies = [
- "paramiko",
+ "paramiko >= 1.9.1", # 1.9.1+ supports multiple IdentityKey entries in .ssh/c... |
borgbackup__borgstore-76 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borgstore/backends/posixfs.py:get_file_backend",
"src/borgstore/backends/posixfs.py:PosixFS.__init__"
],
"edited_modules": [
"src/borgstore/backends/posixfs.py:get_file_b... | borgbackup/borgstore | a9976f38dd03e014bf92fed1d11ba8d38023ef1c | file:// urls and relative paths
See: https://github.com/borgbackup/borg/issues/8372 | diff --git a/src/borgstore/backends/posixfs.py b/src/borgstore/backends/posixfs.py
index a39a964..8c5cfa5 100644
--- a/src/borgstore/backends/posixfs.py
+++ b/src/borgstore/backends/posixfs.py
@@ -17,11 +17,17 @@ from ..constants import TMP_SUFFIX
def get_file_backend(url):
# file:///absolute/path
- # or
- ... |
borgbackup__borgstore-87 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borgstore/backends/posixfs.py:PosixFS.store",
"src/borgstore/backends/posixfs.py:PosixFS.move"
],
"edited_modules": [
"src/borgstore/backends/posixfs.py:PosixFS"
]
... | borgbackup/borgstore | 9ad93e4941e203836bb38533cc2c44a2062165cb | how to deal with nesting directories
Initially, no nesting directories were pre-created and for every `store.store` operation, the code basically always did:
- a `mkdir -p` to make sure the nesting dir is present and
- a file write to that directory
For the `file:` backend, this was not a problem, but for `sftp:` ... | diff --git a/src/borgstore/backends/_base.py b/src/borgstore/backends/_base.py
index 645d2b9..db01f08 100644
--- a/src/borgstore/backends/_base.py
+++ b/src/borgstore/backends/_base.py
@@ -46,6 +46,10 @@ class BackendBase(ABC):
# have to care for ad-hoc directory creation for every store or move call. of course, c... |
borgbackup__borgstore-88 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/borgstore/__main__.py:run_demo"
],
"edited_modules": [
"src/borgstore/__main__.py:run_demo"
]
},
"file": "src/borgstore/__main__.py"
},
{
"changes": {
... | borgbackup/borgstore | 90a44f3cbd416a31370e75c4358c07446f239f9c | Store.list with delete=True vs. =False
Currently, giving True will list normal AND soft-deleted items. As it removes the .del postfix, the caller could not even know what is what.
So:
- False will only list not-deleted objects
- True will only list soft-deleted objects
| diff --git a/README.rst b/README.rst
index 0378e10..4dd8498 100644
--- a/README.rst
+++ b/README.rst
@@ -42,8 +42,8 @@ soft deletion, so the caller doesn't have to care much for that and the Backend
API can be much simpler:
- create/destroy: initialize or remove the whole store.
-- list: flat list of the items in t... |
botblox__botblox-manager-software-36 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"manager/cli.py:create_parser"
],
"edited_modules": [
"manager/cli.py:create_parser"
]
},
"file": "manager/cli.py"
},
{
"changes": {
"added_entities": null... | botblox/botblox-manager-software | 4592b63a22f90c1daec2b950f80b996ebb3cfc38 | Switch not switching after setting up port-based VLAN
I've set up port-based VLAN using the following command:
python3.8 -m manager -D /dev/ttyACM0 vlan --group 1 2 --group 3 4 5
After this command, cables connected to ports 1 and 2 are not able to communicate. When I reset the vlan config, the communication ... | diff --git a/manager/cli.py b/manager/cli.py
index 75a07e1..446b919 100644
--- a/manager/cli.py
+++ b/manager/cli.py
@@ -87,7 +87,7 @@ def create_parser() -> argparse.ArgumentParser:
'vlan',
help='Configure the ports to be in VLAN groups',
)
- vlan_parser_group = vlan_parser.add_mutually_exclu... |
bottlepy__bottle-1232 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bottle.py:Router.match",
"bottle.py:Route._make_callback",
"bottle.py:ConfigDict.load_config",
"bottle.py:WSGIFileWrapper.__init__",
"bottle.py:static_file",
"bot... | bottlepy/bottle | 8294b30341f08da30b10d3d35aadb2fb13beda00 | SyntaxWarning in Python 3.8 tests due to using is to compare literals.
Comparison of literals using "is" now raises SyntaxWarning from Python 3.8 . Use `==` to fix the warnings. This is a good beginner issue.
```
test/test_server.py:56
/home/runner/work/bottle/bottle/test/test_server.py:56: SyntaxWarning: "is" ... | diff --git a/bottle.py b/bottle.py
index df867c1..45e85d1 100755
--- a/bottle.py
+++ b/bottle.py
@@ -474,10 +474,7 @@ class Router(object):
verb = environ['REQUEST_METHOD'].upper()
path = environ['PATH_INFO'] or '/'
- if verb == 'HEAD':
- methods = ['PROXY', verb, 'GET', 'ANY']
- ... |
bottlepy__bottle-1360 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bottle.py:BaseRequest.__setattr__"
],
"edited_modules": [
"bottle.py:BaseRequest"
]
},
"file": "bottle.py"
}
] | bottlepy/bottle | 71bb933649ba009cd537c2e973519d6e024c02a2 | Setting custom request attributes requires name validation
https://github.com/bottlepy/bottle/blob/71bb933649ba009cd537c2e973519d6e024c02a2/bottle.py#L1594-L1599
What about `request.body = 'blah'`?
By the idea it should raise an error, since `body` is read-only property, but it doesn't, it just creates `environ['b... | diff --git a/LICENSE b/LICENSE
index 952e6c3..a4ea15f 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,4 +1,4 @@
-Copyright (c) 2009-2018, Marcel Hellkamp.
+Copyright (c) 2009-2022, Marcel Hellkamp.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation fi... |
bottlepy__bottle-1363 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bottle.py:BaseRequest.__setattr__"
],
"edited_modules": [
"bottle.py:BaseRequest"
]
},
"file": "bottle.py"
}
] | bottlepy/bottle | 71bb933649ba009cd537c2e973519d6e024c02a2 | Update comment for inclusive language
Hi there,
I would like to suggest the updating of bottle.py for inclusive language. It's one small word in one comment here:
https://github.com/bottlepy/bottle/blob/71bb933649ba009cd537c2e973519d6e024c02a2/bottle.py#L1658
At Artsy, we're updating our repositories and depe... | diff --git a/LICENSE b/LICENSE
index 952e6c3..a4ea15f 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,4 +1,4 @@
-Copyright (c) 2009-2018, Marcel Hellkamp.
+Copyright (c) 2009-2022, Marcel Hellkamp.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation fi... |
bottlepy__bottle-1449 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bottle.py:static_file"
],
"edited_modules": [
"bottle.py:static_file"
]
},
"file": "bottle.py"
}
] | bottlepy/bottle | 90d749bef49120396ecc347ea67df98881157030 | static_file is serving gzipped files as uncompressed
When using [`static_file`](https://github.com/bottlepy/bottle/blob/71bb933649ba009cd537c2e973519d6e024c02a2/bottle.py#L2842) without `mimetype` to serve a file compressed with gzip, bottle seems to uncompress it on the fly.
How to reproduce it:
1. create a gzip... | diff --git a/bottle.py b/bottle.py
index b1467a2..283f6bb 100755
--- a/bottle.py
+++ b/bottle.py
@@ -2869,12 +2869,12 @@ def static_file(filename, root,
``If-None-Match``) are answered with ``304 Not Modified`` whenever
possible. ``HEAD`` and ``Range`` requests (used by download managers to
c... |
bottlepy__bottle-787 | [
{
"changes": {
"added_entities": [
"bottle.py:ConfigDict.load_module"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"bottle.py:ConfigDict"
]
},
"file": "bottle.py"
}
] | bottlepy/bottle | 534a2e08ac0ef55dd542a3a83b1118188c6a399b | Ability to load config from module
Currently it is not possible to load config from a Python module (similar to the way Django does it).
I'd like to propose the following;
```py
class ConfigDict(dict):
def load_module(self, module_path):
"""
Load configuration from module path
>... | diff --git a/bottle.py b/bottle.py
index e4b17d8..5287147 100644
--- a/bottle.py
+++ b/bottle.py
@@ -2176,6 +2176,22 @@ class ConfigDict(dict):
self._meta = {}
self._on_change = lambda name, value: None
+ def load_module(self, path, squash):
+ """ Load values from a Python module.
+ ... |
box__box-python-sdk-125 | [
{
"changes": {
"added_entities": [
"boxsdk/auth/developer_token_auth.py:DeveloperTokenAuth.revoke"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"boxsdk/auth/developer_token_auth.py:DeveloperTokenAuth"
]
},
"file": "boxsdk/auth... | box/box-python-sdk | 162fc82c044a044284e01a403ecb8bf43da2d23d | Add a way to revoke OAuth tokens
Using the OAuth2 class you can easily authenticate and refresh tokens but there is not an easy way to revoke the token.
Right now to revoke the token, we would have to do something like:
```python
data = {
'client_id': CLIENT_ID,
'client_secret': CLIENT_SECRET,
'token': re... | diff --git a/HISTORY.rst b/HISTORY.rst
index 5ca5148..ec26cb8 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -6,6 +6,10 @@ Release History
Upcoming
++++++++
+1.5.1 (2016-03-23)
+++++++++++++++++++
+
+- Added a ``revoke()`` method to the ``OAuth2`` class. Calling it will revoke the current access/refresh token pair.
... |
box__box-python-sdk-134 | [
{
"changes": {
"added_entities": [
"boxsdk/auth/oauth2.py:OAuth2._get_and_update_current_tokens",
"boxsdk/auth/oauth2.py:OAuth2._update_current_tokens"
],
"added_modules": null,
"edited_entities": [
"boxsdk/auth/oauth2.py:OAuth2.refresh",
"boxsdk/auth/oaut... | box/box-python-sdk | 3ba6cf1fe50f2f9b3c273d96375dfdc98ea87d3c | BoxSession._renew_session does not set previously refreshed tokens
I am using `CooperativelyManagedOAuth2` so that I can use the same oauth tokens for multiple clients but it seems like refreshed tokens do not get updated in the session if the tokens were refreshed by another client. I have two instances of the oauth c... | diff --git a/HISTORY.rst b/HISTORY.rst
index ec26cb8..e7ca71f 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -6,6 +6,11 @@ Release History
Upcoming
++++++++
+1.5.2
+++++++++++++++++++
+
+- Bugfix so that ``OAuth2`` always has the correct tokens after a call to ``refresh()``.
+
1.5.1 (2016-03-23)
++++++++++++++++++... |
box__box-python-sdk-137 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"boxsdk/auth/jwt_auth.py:JWTAuth.__init__",
"boxsdk/auth/jwt_auth.py:JWTAuth.authenticate_instance"
],
"edited_modules": [
"boxsdk/auth/jwt_auth.py:JWTAuth"
]
},
... | box/box-python-sdk | 481a86227d6d063f2e4e4ae880f4e12cd16dab06 | Private key file throws error when trying load_pem_private_key
I'm running python-3.5.0 on OS X 10.11.5. When trying to use JWT Authorization, creating a JWTAuth object fails with:
```
Traceback (most recent call last):
File "<stdin>", line 6, in <module>
File "/Library/Frameworks/Python.framework/Versions/3.... | diff --git a/HISTORY.rst b/HISTORY.rst
index e7ca71f..25def3f 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -6,7 +6,12 @@ Release History
Upcoming
++++++++
-1.5.2
+1.5.3
+++++++++++++++++++
+
+- Bugfix so that ``JWTAuth`` opens the PEM private key file in ``'rb'`` mode.
+
+1.5.2 (2016-05-19)
++++++++++++++++++
... |
box__box-python-sdk-178 | [
{
"changes": {
"added_entities": [
"boxsdk/auth/jwt_auth.py:JWTAuth.authenticate_user",
"boxsdk/auth/jwt_auth.py:JWTAuth._normalize_user_id"
],
"added_modules": null,
"edited_entities": [
"boxsdk/auth/jwt_auth.py:JWTAuth.__init__",
"boxsdk/auth/jwt_auth.py... | box/box-python-sdk | cc4921422bb070e5547c0c054c1d2c554380dba5 | Change authenticate_app_user method
With service accounts, you can use the method to authenticate as a managed user, not just app users. Should the method name be changed to better reflect this?
Also we should changed the name from Box Developer Edition to Box Platform (or even Box service accounts)
| diff --git a/README.rst b/README.rst
index 21b3f06..b157c9d 100644
--- a/README.rst
+++ b/README.rst
@@ -323,12 +323,12 @@ These users can then be authenticated:
ned_auth = JWTAuth(
client_id='YOUR_CLIENT_ID',
client_secret='YOUR_CLIENT_SECRET',
- enterprise_id='YOUR_ENTERPRISE_ID',
+ ... |
box__box-python-sdk-245 | [
{
"changes": {
"added_entities": [
"boxsdk/auth/jwt_auth.py:JWTAuth.from_settings_dictionary",
"boxsdk/auth/jwt_auth.py:JWTAuth.from_settings_file"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"boxsdk/auth/jwt_auth.py:JWTAuth"
... | box/box-python-sdk | ded623f4b6de0530d8f983d3c3d2cafe646c126b | Add support to load app config file downloaded from dev console
Add support to jwt_auth.py to load a box_config.json file downloaded from the developer console. This would make the python SDK consistent with the node an java sdk's.
node: https://github.com/box/box-node-sdk/blob/3dcfe69ed1354ed85b54eb4b1d4e179c999f4f... | diff --git a/HISTORY.rst b/HISTORY.rst
index 5cf6878..c75fe80 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -105,6 +105,8 @@ Release History
- Added a ``downscope_token()`` method to the ``OAuth2`` class. This generates a token that
has its permissions reduced to the provided scopes and for the optionally provided ... |
box__box-python-sdk-288 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"boxsdk/client/client.py:Client.users",
"boxsdk/client/client.py:Client.groups"
],
"edited_modules": [
"boxsdk/client/client.py:Client"
]
},
"file": "boxsdk/clie... | box/box-python-sdk | c548a6b336e25320fdf924bf85160d4735355617 | Finish making breaking changes to paging APIs
We should be using the new paging wrappers.
Also do one final audit of the new paging wrappers to make sure that the interface is what we want. | diff --git a/HISTORY.rst b/HISTORY.rst
index e39f426..14dd6d2 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -43,6 +43,22 @@ Release History
- Comparing two objects (e.g. a ``File`` and a ``Folder``) that have the same Box ID but different types with ``==``
will now correctly return `False`.
+- The following metho... |
box__box-python-sdk-343 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"boxsdk/config.py:Client"
]
},
"file": "boxsdk/config.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_en... | box/box-python-sdk | 567ea528c8e757fe77399b21a68ccfc94341b68b | Add Box SDK headers to API calls
We should definitely send headers for SDK name and SDK version. Other nice-to-haves to consider:
- Python version
- Requests version | diff --git a/boxsdk/config.py b/boxsdk/config.py
index 203cfc2..371117d 100644
--- a/boxsdk/config.py
+++ b/boxsdk/config.py
@@ -2,6 +2,8 @@
from __future__ import unicode_literals, absolute_import
+from sys import version_info as py_version
+
from . import version
@@ -17,3 +19,9 @@ class Client(object):
... |
box__box-python-sdk-46 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"boxsdk/object/item.py:Item.get_shared_link"
],
"edited_modules": [
"boxsdk/object/item.py:Item"
]
},
"file": "boxsdk/object/item.py"
}
] | box/box-python-sdk | 221ef994e215b78b4049847db9656fcc83d10d79 | Add ability to set expiration date on shared links
`get_shared_link()` only takes access and etag as parameters. The create shared link API supports many other parameters, including unshared_at, permissions, can_download, can_preview.
https://box-content.readme.io/#page-create-a-shared-link-for-a-file | diff --git a/HISTORY.rst b/HISTORY.rst
index b38b2b1..c2dfaf0 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -3,6 +3,13 @@
Release History
---------------
+Upcoming
+++++++++
+
+- Added support for setting shared link expiration dates.
+- Added support for setting shared link permissions.
+
+
1.1.6 (2015-04-17)
++... |
box__box-python-sdk-99 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"boxsdk/client.py:Client.users",
"boxsdk/client.py:Client.search"
],
"edited_modules": [
"boxsdk/client.py:Client"
]
},
"file": "boxsdk/client.py"
},
{
"... | box/box-python-sdk | f365c177f70ce6cfc2d53528ed649cdac20bb43d | The get all users in enterprise API needs to be pageable
Right now it just return a list of :class:`User` | diff --git a/HISTORY.rst b/HISTORY.rst
index b567bfa..9af5bb4 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -6,7 +6,17 @@ Release History
Upcoming
++++++++
-1.3.2
+1.3.3 (2015-12-22)
+++++++++++++++++++
+
+- Added a new class, ``DeveloperTokenClient`` that makes it easy to get started using the SDK with a Box devel... |
boxed__mutmut-170 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mutmut/__init__.py:should_exclude",
"mutmut/__init__.py:check_coverage_data_filepaths",
"mutmut/__init__.py:read_coverage_data"
],
"edited_modules": [
"mutmut/__init_... | boxed/mutmut | cf9c02f618c16815fad433b05d0b45afd9f9967a | Mutmut doesn't work with Coverage 5.0
I really should have tested this with the beta. I just forgot about this feature of mutmut, sloppy! | diff --git a/mutmut/__init__.py b/mutmut/__init__.py
index 4ee49c5..638b2b1 100644
--- a/mutmut/__init__.py
+++ b/mutmut/__init__.py
@@ -456,7 +456,7 @@ def should_exclude(context, config):
covered_lines = config.covered_lines_by_filename[context.filename]
except KeyError:
if config.coverage_data... |
boxed__mutmut-192 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mutmut/__init__.py:Progress.__init__",
"mutmut/__init__.py:Progress.print"
],
"edited_modules": [
"mutmut/__init__.py:Progress"
]
},
"file": "mutmut/__init__.py... | boxed/mutmut | 795b39baba4f95c109e6a8be33c7a4d4ef87df49 | UTF-8 emoji icons fail to display in a Pycharm 2019.2.1 terminal in windows
This was created on a windows 10 environment with Pycharm 2019.2.1.
Running mutmut in the Pycharm native terminal fails to render the emojis indicating killed 🎉, suspicious 🤔, and surviving 🙁 mutants.
For example:
```console
(venv) ... | diff --git a/mutmut/__init__.py b/mutmut/__init__.py
index 78ad464..b77329a 100644
--- a/mutmut/__init__.py
+++ b/mutmut/__init__.py
@@ -910,8 +910,9 @@ def guess_paths_to_mutate():
class Progress(object):
- def __init__(self, total):
+ def __init__(self, total, output_legend):
self.total = total
+ ... |
boxed__mutmut-228 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mutmut/__init__.py:Config.__init__"
],
"edited_modules": [
"mutmut/__init__.py:Config"
]
},
"file": "mutmut/__init__.py"
},
{
"changes": {
"added_entities... | boxed/mutmut | c63ba9ca08ae780ca815ff188ea91417e2dc8868 | Using click's subcommands
As discussed on #55, we should add support for `click`'s subcommand feature: http://click.palletsprojects.com/en/7.x/commands/. This provides greater control on arguments for each individual command, and should be a backwards compatible change. This would also improve extensibility of the CLI. | diff --git a/HISTORY.rst b/HISTORY.rst
index 03768a0..e2c35e3 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -8,6 +8,10 @@ Changelog
* Fixed error where ``mutmut_config.init()`` was not called when running without explicitly having set ``PYTHONPATH``
+* Use ``Click``'s subcommand feature to refactor the command lin... |
boxed__mutmut-233 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mutmut/__init__.py:run_mutation",
"mutmut/__init__.py:Config.__init__",
"mutmut/__init__.py:read_coverage_data"
],
"edited_modules": [
"mutmut/__init__.py:run_mutatio... | boxed/mutmut | cc7e7825a8a2ca0d5abb5f4748aa8c8ccea7f0f7 | Add option to take coverage contexts into account
``coverage.py`` is able to capture [dynamic contexts](https://coverage.readthedocs.io/en/coverage-5.5/contexts.html#dynamic-contexts), which means it can track which test exercised which parts of the code under test.
As ``mutmut`` is already able to read the coverage... | diff --git a/HISTORY.rst b/HISTORY.rst
index e2c35e3..0415fb9 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -12,6 +12,9 @@ Changelog
to check which parameters are relevant to this specific subcommand. The change is backwards compatible, and all existing commands
work the same as before, with the exception of ``mu... |
boxed__mutmut-235 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mutmut/__init__.py:Context.should_mutate",
"mutmut/__init__.py:mutate_node"
],
"edited_modules": [
"mutmut/__init__.py:Context",
"mutmut/__init__.py:mutate_node"
... | boxed/mutmut | 8b7c763a6e2c3354cc8f40c68648dd4415197471 | Bug with --disable-mutation-types and --enable-mutation-types
Hi I have been testing out the new commands since they are quite useful. However I found some bugs related to them.
Here is a testProgram for mutation purpose
```
def testfunction():
array['a'] = 123
```
I run this command after building v... | diff --git a/mutmut/__init__.py b/mutmut/__init__.py
index 003b15a..a736caf 100644
--- a/mutmut/__init__.py
+++ b/mutmut/__init__.py
@@ -533,7 +533,9 @@ class Context(object):
}
return self._pragma_no_mutate_lines
- def should_mutate(self):
+ def should_mutate(self, node):
+ if self... |
boxed__mutmut-239 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mutmut/__init__.py:number_mutation"
],
"edited_modules": [
"mutmut/__init__.py:number_mutation"
]
},
"file": "mutmut/__init__.py"
}
] | boxed/mutmut | cce78241aa116d14c4ae38ecd1b2c84e659126d7 | Generation of unary plus in exponent is un-killable
Hello, thanks for the lovely tool!
mutmut generates mutants like the following, which are identical to the original code and thus un-killable (immortal?):
```diff
--- mvce/mvce.py
+++ mvce/mvce.py
@@ -1,3 +1,3 @@
def multiply_by_1e100(number):
- return ... | diff --git a/mutmut/__init__.py b/mutmut/__init__.py
index a736caf..9af8f48 100644
--- a/mutmut/__init__.py
+++ b/mutmut/__init__.py
@@ -227,11 +227,17 @@ def number_mutation(value, **_):
try:
parsed = int(value, base=base)
+ result = repr(parsed + 1)
except ValueError:
# Since it w... |
boxed__mutmut-363 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mutmut/__main__.py:build_trampoline"
],
"edited_modules": [
"mutmut/__main__.py:build_trampoline"
]
},
"file": "mutmut/__main__.py"
}
] | boxed/mutmut | 20d0a6229fa70f0ddf40a6fbd6c3d345271dfd05 | Incompatibility with Pydantic model which contains a method
For the following minimal example:
```python
from pydantic import BaseModel
class Model(BaseModel):
max_retries: int = 2
def get_max_tries(self) -> int:
return self.max_retries + 1
```
running `mutmut run` produces error:
```
> ... | diff --git a/HISTORY.rst b/HISTORY.rst
index d273cb0..62715e4 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -1,6 +1,11 @@
Changelog
---------
+Unreleased
+~~~~~~~~~~
+
+* Annotate mutant dicts (and fixes compatibility with Pydantic)
+
3.2.3
~~~~~
diff --git a/mutmut/__main__.py b/mutmut/__main__.py
index a3e37e... |
bradleygolden__pytailor-15 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "pytailor/__version__.py"
},
{
"changes": {
"added_entities": [
"pytailor/tailor.py:Tailor.from_envar"
],
"added_modules": nu... | bradleygolden/pytailor | 02c1bc028bc86c18562e8f0ec864787c475cb402 | Rename watch_env_var
watch_env_var is confusingly named. It should be called something like "from_env_var"
For example
```
config.watch_env_var("FOO")
```
could be something like:
```
config.from_environ("FOO")
# or
config.from_env_var("FOO")
# or
config.from_envar("FOO")
```
or perhaps we can get mo... | diff --git a/pytailor/__version__.py b/pytailor/__version__.py
index 57f0c12..8ed71d5 100644
--- a/pytailor/__version__.py
+++ b/pytailor/__version__.py
@@ -7,6 +7,6 @@
# |__| \/ \/
-VERSION = (0, 1, 4)
+VERSION = (0, 1, 5)
__version__ = ".".join(map(str, VERSION))
diff --git a/pytailor/tailor.... |
bradshjg__flask-githubapp-19 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flask_githubapp/core.py:GitHubApp.init_app",
"flask_githubapp/core.py:GitHubApp._flask_view_func",
"flask_githubapp/core.py:GitHubApp._verify_webhook"
],
"edited_modules": [
... | bradshjg/flask-githubapp | aa9c2df54f69fec8279a275dafc6f025b4122778 | Support X-Hub-Signature-256
We should prefer this header and probably fall back to the `X-Hub-Signature` header in the case that it's missing (in the case of maybe old Enterprise Server installations???)
I'm also a little conflicted about the current practice of requiring a secret to be set. I think there are probab... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9d7387b..dffcf2e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
+### Changed
+- `GITHUBAPP_SECRET` can now be set to `False` to skip verifying the signature... |
bradshjg__flask-githubapp-23 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flask_githubapp/core.py:GitHubApp._flask_view_func"
],
"edited_modules": [
"flask_githubapp/core.py:GitHubApp"
]
},
"file": "flask_githubapp/core.py"
}
] | bradshjg/flask-githubapp | 3f5da29cb0740cc92068e0f8c8774bc182e253c4 | Issue when payloads have no action
Gitapps based on this that want to do something with push payloads (for instance) will fail here:
https://github.com/bradshjg/flask-githubapp/blob/master/flask_githubapp/core.py#L170
I know because I have just suffered this! :D
A simple change could be, I think, to do a get wi... | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 33b65fe..4fabdfb 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -3,7 +3,9 @@
name: PyPI release
-on: [release]
+on:
+ release:
+ types: [published]
jobs:
publish:
diff --git a/flask_githuba... |
bradshjg__flask-githubapp-25 | [
{
"changes": {
"added_entities": [
"flask_githubapp/core.py:GitHubApp._validate_request"
],
"added_modules": [
"flask_githubapp/core.py:GitHubAppError",
"flask_githubapp/core.py:GitHubAppValidationError"
],
"edited_entities": [
"flask_githubapp/core.... | bradshjg/flask-githubapp | 4465e4fd69a14e0452a6d38a1fa1c5aa68baf653 | Exception on / [POST]
I'm getting some some errors and I'm not really sure where they're coming from or how to debug. Is this a lib issue or an issue with my setup?
```
Traceback (most recent call last):
File "/app/site-packages/flask/app.py", line 2447, in wsgi_app
response = self.full_dispatch_request()
... | diff --git a/flask_githubapp/core.py b/flask_githubapp/core.py
index 3072a87..661f8d0 100644
--- a/flask_githubapp/core.py
+++ b/flask_githubapp/core.py
@@ -12,6 +12,14 @@ STATUS_FUNC_CALLED = 'HIT'
STATUS_NO_FUNC_CALLED = 'MISS'
+class GitHubAppError(Exception):
+ pass
+
+
+class GitHubAppValidationError(GitHu... |
brandon-rhodes__python-sgp4-73 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"sgp4/exporter.py:export_tle"
],
"edited_modules": [
"sgp4/exporter.py:export_tle"
]
},
"file": "sgp4/exporter.py"
}
] | brandon-rhodes/python-sgp4 | c959af39f32d4ba9a88b8e9cfeed394d77a86e51 | export_tle roundtrip issues
While studying #70, I discovered a roundtrip problem with `export_tle`:
```
>>> lines = """1 46272U 20061A 20311.82207422 .00000083 00000-0 68546-5 0 9999
... 2 46272 97.3995 23.7575 0006827 352.5560 7.5569 15.20743438 9810"""
>>> print(lines)
1 46272U 20061A 20311.822074... | diff --git a/sgp4/exporter.py b/sgp4/exporter.py
index 759c034..32d6baf 100644
--- a/sgp4/exporter.py
+++ b/sgp4/exporter.py
@@ -30,7 +30,10 @@ def export_tle(satrec):
append(satrec.intldesg.ljust(8, " ") + " ")
# Add epoch year and days in YYDDD.DDDDDDDD format
- append(str(satrec.epochyr).zfill(2) + "{... |
brandonschabell__datetransform-2 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"datetransform/transform.py:add_date_features"
],
"edited_modules": [
"datetransform/transform.py:add_date_features"
]
},
"file": "datetransform/transform.py"
},
{
... | brandonschabell/datetransform | 33b75b1948cad92aa4edf91850887f27562b0632 | Make "inplace" optional
Currently the dataframe is edited inplace. Make this an optional argument that defaults to False so a copy of the dataframe is updated. | diff --git a/.travis.yml b/.travis.yml
index 83d257a..5cbb4fb 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,7 +14,7 @@ before_install:
- pip install pytest-cov
install:
- - pip install -e .
+ - pip install -e .[tests]
script:
- pytest --cov-report=xml --cov=datetransform tests/
diff --git a/datetransf... |
brettcannon__mousebender-100 | [
{
"changes": {
"added_entities": [
"mousebender/simple.py:UnsupportedAPIVersion.__init__",
"mousebender/simple.py:APIVersionWarning.__init__",
"mousebender/simple.py:_check_version"
],
"added_modules": [
"mousebender/simple.py:UnsupportedAPIVersion",
"mo... | brettcannon/mousebender | 28e05b408381375a5ce5498359cc01545becc5ae | Support PEP 629 and 700 for HTML responses
It technically doesn't change the outcome, but https://peps.python.org/pep-0700/#specification says HTML is supported, so proper detection of HTML versions is necessary (i.e. https://peps.python.org/pep-0629/ ). | diff --git a/docs/simple.rst b/docs/simple.rst
index 17ddd96..50eaa12 100644
--- a/docs/simple.rst
+++ b/docs/simple.rst
@@ -21,6 +21,15 @@
.. versionadded:: 2022.1.0
+.. autoexception:: UnsupportedAPIVersion
+
+ .. versionadded:: 2023.0.0
+
+
+.. autoexception:: APIVersionWarning
+
+ .. versionadded:: 2023... |
brettcannon__mousebender-107 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mousebender/simple.py:_ArchiveLinkHTMLParser.handle_starttag",
"mousebender/simple.py:from_project_details_html"
],
"edited_modules": [
"mousebender/simple.py:_ArchiveLinkHTM... | brettcannon/mousebender | 2fdb5d89fe7e54e701a3f3d3b30b6b4f38cbd172 | Support PEP 714
https://peps.python.org/pep-0714/ | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f663945..dbfd0c5 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -35,7 +35,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- python_version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
+ python_ve... |
brian-rose__climlab-77 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "climlab/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"climlab/radiatio... | brian-rose/climlab | 4c81da428b91881e394a67b9c3412881c37ed8fd | Interpolation of ozone fails with surface pressures higher than 1056 hPa
Trying to create a radiation model for a massive atmosphere, following method laid out in #39, creates a new error at model initialization time:
First here is the hack to create a domain with altered surface pressure:
```
import numpy as np... | diff --git a/climlab/__init__.py b/climlab/__init__.py
index ab3f7fe..e531af9 100644
--- a/climlab/__init__.py
+++ b/climlab/__init__.py
@@ -7,7 +7,7 @@ Nevertheless also the underlying code of the ``climlab`` architecture
has been documented for a comprehensive understanding and traceability.
'''
-__version__ = '0... |
briancurtin__deprecation-12 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"deprecation.py:deprecated"
],
"edited_modules": [
"deprecation.py:deprecated"
]
},
"file": "deprecation.py"
},
{
"changes": {
"added_entities": [
... | briancurtin/deprecation | 70bb27fef996b214d7b698ed3124fb598220eea9 | deprecation_note brakes docstring processing
While joining the `function.__doc__`-string with the `deprecation_note`-string the indentation isn't handled properly. Let's look at this example:
```python
@deprecated(deprecated_in="0.0.3", removed_in="0.1.0",
current_version="0.0.4",
details=... | diff --git a/deprecation.py b/deprecation.py
index 28a21ee..00598db 100644
--- a/deprecation.py
+++ b/deprecation.py
@@ -10,6 +10,7 @@
# License for the specific language governing permissions and limitations
# under the License.
import functools
+import textwrap
import warnings
from packaging import version
@@ ... |
briancurtin__deprecation-14 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"deprecation.py:DeprecatedWarning.__str__",
"deprecation.py:UnsupportedWarning.__str__"
],
"edited_modules": [
"deprecation.py:DeprecatedWarning",
"deprecation.py:Unsu... | briancurtin/deprecation | 3ad94c2de7c313d0ca20a8ce4c9247a0faaa8018 | DeprecatedWarning.__str__ should handle None arguments better
`DeprecatedWarning.__str__`doesn't play nicely with `None` values, such as what happens when you call `deprecation.deprecated()` with no arguments. This ends up showing up in the interpreter messages when run with `python -Wd`, though it doesn't affect docst... | diff --git a/deprecation.py b/deprecation.py
index 00598db..a64b5b7 100644
--- a/deprecation.py
+++ b/deprecation.py
@@ -9,6 +9,7 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
+import collec... |
briancurtin__deprecation-37 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"deprecation.py:DeprecatedWarning.__init__"
],
"edited_modules": [
"deprecation.py:DeprecatedWarning"
]
},
"file": "deprecation.py"
}
] | briancurtin/deprecation | c9f228e5900f1875ba304f7da57fedf39ecd2dab | args not set on warning
```
>>> warn = deprecation.DeprecatedWarning("depricated", 1, 2)
>>> warn.args
()
```
currently warnings generated through this module do not set the args property. This is making the library incomparable with the latest release of pytest-xdist since they are using those args as a way of ... | diff --git a/deprecation.py b/deprecation.py
index 7a80adc..dbeb39e 100644
--- a/deprecation.py
+++ b/deprecation.py
@@ -56,7 +56,8 @@ class DeprecatedWarning(DeprecationWarning):
self.deprecated_in = deprecated_in
self.removed_in = removed_in
self.details = details
- super(DeprecatedW... |
briancurtin__deprecation-47 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"deprecation.py:DeprecatedWarning.__str__",
"deprecation.py:deprecated"
],
"edited_modules": [
"deprecation.py:DeprecatedWarning",
"deprecation.py:deprecated"
]
... | briancurtin/deprecation | 264e8cd469cdcfc793afedb80d224f48d350a360 | Allow removed_in to be a date
Depending on the versioning scheme used by a project, it can be difficult to tell in advance the version number at which code can be removed. Sometimes, though, it is easier to tell *when* it should be removed. Google Guava, for example, guarantees all methods marked deprecated will be kep... | diff --git a/.gitignore b/.gitignore
index 72364f9..0627077 100644
--- a/.gitignore
+++ b/.gitignore
@@ -87,3 +87,6 @@ ENV/
# Rope project settings
.ropeproject
+
+#Pycharm Files
+.idea/
diff --git a/deprecation.py b/deprecation.py
index ccb7f66..e7903b4 100644
--- a/deprecation.py
+++ b/deprecation.py
@@ -15,6 +15... |
bridgecrewio__checkov-1061 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"checkov/dockerfile/runner.py:Runner.run"
],
"edited_modules": [
"checkov/dockerfile/runner.py:Runner"
]
},
"file": "checkov/dockerfile/runner.py"
}
] | bridgecrewio/checkov | 90323525549fd0344b46db8c9e4952e4511e9efa | Dockerfile scan fails when in directory and used -f
**Describe the bug**
When running directory scan checkov shows Dockerfile failed checks. When scanning file no errors are shown.
**To Reproduce**
Create Dockerfile in directory `test` with content:
```
FROM debian:buster
ENV CHECKOV_VERSION 1.0.775
RUN ex... | diff --git a/checkov/dockerfile/runner.py b/checkov/dockerfile/runner.py
index f0267d36e..c12a3655d 100644
--- a/checkov/dockerfile/runner.py
+++ b/checkov/dockerfile/runner.py
@@ -15,7 +15,7 @@ DOCKER_FILE_MASK = [DOCKERFILE_FILENAME]
class Runner(BaseRunner):
check_type = "dockerfile"
- def run(self, root_... |
bridgecrewio__checkov-1062 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"checkov/main.py:add_parser_args"
],
"edited_modules": [
"checkov/main.py:add_parser_args"
]
},
"file": "checkov/main.py"
},
{
"changes": {
"added_entities... | bridgecrewio/checkov | 90323525549fd0344b46db8c9e4952e4511e9efa | CKV_AZURE_12: Retention policy of 0 is not supported
**Describe the bug**
When setting the `retention_period.days` value on `azurerm_network_watcher_flow_log` to `0`, `CKV_AZURE_12` still fails. `0` is the value to signify indefinite/forever retention.
**To Reproduce**
Steps to reproduce the behavior:
1. Create a... | diff --git a/checkov/main.py b/checkov/main.py
index 7d991aee5..21957bd30 100644
--- a/checkov/main.py
+++ b/checkov/main.py
@@ -173,7 +173,7 @@ def add_parser_args(parser):
action='store_true')
parser.add_argument('--download-external-modules',
help="download exte... |
bridgecrewio__checkov-1147 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"checkov/terraform/checks/data/base_check.py:BaseDataCheck.__init__",
"checkov/terraform/checks/data/base_check.py:BaseDataCheck.scan_entity_conf",
"checkov/terraform/checks/data/base_che... | bridgecrewio/checkov | e3cbb34c9c312a0310b032b7ca4956a10b61a0f7 | TypeError: not all arguments converted during string formatting then creates FP for CKV_AWS_111
**Describe the bug**
Getting TypeError: not all arguments converted during string formatting on scanning the following terraform code with d
```
$ cat main.tf
provider "aws" {
region = "eu-west-2"
}
module... | diff --git a/checkov/terraform/checks/data/base_check.py b/checkov/terraform/checks/data/base_check.py
index 7a33967ed..45f1281c0 100644
--- a/checkov/terraform/checks/data/base_check.py
+++ b/checkov/terraform/checks/data/base_check.py
@@ -1,29 +1,33 @@
from abc import abstractmethod
+from typing import Dict, List, C... |
bridgecrewio__checkov-1172 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"checkov/terraform/plan_parser.py:_is_simple_type",
"checkov/terraform/plan_parser.py:_is_list_of_simple_types",
"checkov/terraform/plan_parser.py:_is_list_of_dicts",
"checkov/ter... | bridgecrewio/checkov | 17c8b4057997ecf0a385606001bd740cdb90375e | Check: CKV_AWS_84: "Ensure Elasticsearch Domain Logging is enabled"
**Describe the bug**
My TF module has enabled logging for all types: "INDEX_SLOW_LOGS, SEARCH_SLOW_LOGS, ES_APPLICATION_LOGS, AUDIT_LOGS", but I still got error:
```
Check: CKV_AWS_84: "Ensure Elasticsearch Domain Logging is enabled"
FAILED for ... | diff --git a/checkov/terraform/plan_parser.py b/checkov/terraform/plan_parser.py
index 755b6537b..94dee6151 100644
--- a/checkov/terraform/plan_parser.py
+++ b/checkov/terraform/plan_parser.py
@@ -1,18 +1,21 @@
-from checkov.terraform.context_parsers.tf_plan import parse
+import itertools
+from typing import Optional, ... |
bridgecrewio__checkov-1457 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"checkov/common/output/report.py:Report.handle_skipped_checks"
],
"edited_modules": [
"checkov/common/output/report.py:Report"
]
},
"file": "checkov/common/output/report... | bridgecrewio/checkov | 415fa65362b1b51b569a2f8348a5981614acf422 | Skip annotations are sometimes ignored in terraform_plan mode
**Describe the bug**
The [handle_skipped_checks loop](https://github.com/bridgecrewio/checkov/blob/2.0.324/checkov/common/output/report.py#L348) removes elements from a list it is iterating on. This can cause some skip annotations to be ignored, making C... | diff --git a/checkov/common/output/report.py b/checkov/common/output/report.py
index dca504de7..1cb7a340b 100644
--- a/checkov/common/output/report.py
+++ b/checkov/common/output/report.py
@@ -338,17 +338,23 @@ class Report:
def handle_skipped_checks(
report: "Report", enriched_resources: Dict[str, Dict[s... |
bridgecrewio__checkov-1613 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"checkov/common/bridgecrew/image_scanning/docker_image_scanning_integration.py:DockerImageScanningIntegration.download_twistcli",
"checkov/common/bridgecrew/image_scanning/docker_image_scanning_i... | bridgecrewio/checkov | fb8a669d577ba6e4faa5bc08974235e446aa49af | Bug: file preview not working with SARIF results uploaded from Checkov to Github
Being able to view the code responsible for a security alert in Github's code scanning feature is crucial for developers. The file preview provides important contextual information for devs that helps them arrive at a fix without a lot of ... | diff --git a/checkov/common/bridgecrew/image_scanning/docker_image_scanning_integration.py b/checkov/common/bridgecrew/image_scanning/docker_image_scanning_integration.py
index 47625b06e..111f7a6f4 100644
--- a/checkov/common/bridgecrew/image_scanning/docker_image_scanning_integration.py
+++ b/checkov/common/bridgecrew... |
bridgecrewio__checkov-211 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"checkov/terraform/checks/resource/aws/IAMPolicyAttachedToGroupOrRoles.py:IAMPolicyAttachedToGroupOrRoles.scan_resource_conf"
],
"edited_modules": [
"checkov/terraform/checks/resource... | bridgecrewio/checkov | 53d4eebf3493703c42035e9efea89fdf8050fb43 | Add new check: IAM Policies should not be attached to a user
Attach policies only to groups or roles
https://www.terraform.io/docs/providers/aws/r/iam_user_policy.html
https://www.terraform.io/docs/providers/aws/r/iam_user_policy_attachment.html
users: https://www.terraform.io/docs/providers/aws/r/iam_policy_atta... | diff --git a/checkov/terraform/checks/resource/aws/IAMPolicyAttachedToGroupOrRoles.py b/checkov/terraform/checks/resource/aws/IAMPolicyAttachedToGroupOrRoles.py
index d853428ee..cef1f82a7 100644
--- a/checkov/terraform/checks/resource/aws/IAMPolicyAttachedToGroupOrRoles.py
+++ b/checkov/terraform/checks/resource/aws/IA... |
bridgecrewio__checkov-2167 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"checkov/common/bridgecrew/platform_integration.py:BcPlatformIntegration.get_id_mapping",
"checkov/common/bridgecrew/platform_integration.py:BcPlatformIntegration.get_ckv_to_bc_id_mapping",
... | bridgecrewio/checkov | 808f3e95d3c6de42e70de5a3789bfef386077573 | Unable to skip CKV_AWS_130
**Describe the bug**
I have a two-tier network infrastructure template written in terraform which basically sets up a VPC network. In there, I have a public subnet block which has parameter `map_public_ip_on_launch` set to **true**. Even after adding `#checkov:skip=CKV_AWS_130:Public IP requ... | diff --git a/checkov/common/bridgecrew/platform_integration.py b/checkov/common/bridgecrew/platform_integration.py
index 66e6f4508..c036a1942 100644
--- a/checkov/common/bridgecrew/platform_integration.py
+++ b/checkov/common/bridgecrew/platform_integration.py
@@ -7,7 +7,7 @@ from concurrent import futures
from json i... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.