instance_id
stringlengths
10
57
file_changes
listlengths
1
15
repo
stringlengths
7
53
base_commit
stringlengths
40
40
problem_statement
stringlengths
11
52.5k
patch
stringlengths
251
7.06M
dag-hammarskjold-library__dlx-368
[ { "changes": { "added_entities": [ "dlx/marc/__init__.py:Auth.resolve_ambiguous" ], "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:Marc.resolve_ambiguous", "dlx/marc/__init__.py:Auth.xlookup_multi" ], "edited_modules": [ "dlx...
dag-hammarskjold-library/dlx
0e791ba9d4e2763bc95a812581f573cc205cd314
Resolving ambiguous authority string values For use in importing records where the xref for authority controlled fields is not provided. The source auth record needs to be determined given only a string value(s), if possible
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index 8935438..59e3e8b 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -1375,10 +1375,6 @@ class Marc(object): #### de-serializations - @classmethod - def resolve_ambiguous(cls, subfields): - pass - def from_mij(self, st...
dag-hammarskjold-library__dlx-375
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/marc/query.py:WildcardRegex.__init__", "dlx/marc/query.py:Query.from_string" ], "edited_modules": [ "dlx/marc/query.py:WildcardRegex", "dlx/marc/query.py:Query" ...
dag-hammarskjold-library/dlx
b7ffeca39f46756062e8018a2f9033b7deb97a2e
Logical field wildcard serarch bugfix The search is not working properly matching strings at the beginning of the value, i.e. `author:german*`. Addresses https://github.com/dag-hammarskjold-library/dlx-rest/issues/1522
diff --git a/dlx/marc/query.py b/dlx/marc/query.py index 9d32951..ec80b96 100644 --- a/dlx/marc/query.py +++ b/dlx/marc/query.py @@ -15,7 +15,7 @@ class InvalidQueryString(Exception): class WildcardRegex(Regex): # for differentiating regex to run against text index vs actual value def __init__(self, string=N...
dag-hammarskjold-library__dlx-377
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/marc/query.py:Query.from_string" ], "edited_modules": [ "dlx/marc/query.py:Query" ] }, "file": "dlx/marc/query.py" }, { "changes": { "added_entities":...
dag-hammarskjold-library/dlx
6373cacd941dfeec2c59cf67ee6b4a3c9108e84b
Fix NOT wildcard search No records should be returned that contain the value in the NOT term Addresses https://github.com/dag-hammarskjold-library/dlx-rest/issues/1518
diff --git a/dlx/marc/query.py b/dlx/marc/query.py index ec80b96..e03499c 100644 --- a/dlx/marc/query.py +++ b/dlx/marc/query.py @@ -130,7 +130,13 @@ class Query(): # regex if isinstance(value, Regex): - matches = DB.handle[f'_index_{tag}'].find({'subfields.value':...
dag-hammarskjold-library__dlx-382
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/marc/query.py:WildcardRegex.__init__", "dlx/marc/query.py:Query.from_string" ], "edited_modules": [ "dlx/marc/query.py:WildcardRegex", "dlx/marc/query.py:Query" ...
dag-hammarskjold-library/dlx
9d309b174ca75aa3e4d7054667bcb81ef4b28d75
Wildcard search bugs Regressions introduced in #377
diff --git a/dlx/marc/query.py b/dlx/marc/query.py index e03499c..f5b8d4c 100644 --- a/dlx/marc/query.py +++ b/dlx/marc/query.py @@ -15,7 +15,7 @@ class InvalidQueryString(Exception): class WildcardRegex(Regex): # for differentiating regex to run against text index vs actual value def __init__(self, string=N...
dag-hammarskjold-library__dlx-386
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/util.py:Table.serialize" ], "edited_modules": [ "dlx/util.py:Table" ] }, "file": "dlx/util.py" } ]
dag-hammarskjold-library/dlx
917d2361e5f6c11a0a4a70917fb13d07d4fec1e9
Double quotes in CSV serialization not properly escaped Bug here https://github.com/dag-hammarskjold-library/dlx/blob/917d2361e5f6c11a0a4a70917fb13d07d4fec1e9/dlx/util.py#L120
diff --git a/dlx/util.py b/dlx/util.py index 940bc29..37de978 100644 --- a/dlx/util.py +++ b/dlx/util.py @@ -114,10 +114,10 @@ class Table(): for field in self.header: if value := record.get(field): - if separator in value or value[0] == '"' or value[-1] == '"'...
dag-hammarskjold-library__dlx-402
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/scripts/init_indexes.py:run" ], "edited_modules": [ "dlx/scripts/init_indexes.py:run" ] }, "file": "dlx/scripts/init_indexes.py" }, { "changes": { "ad...
dag-hammarskjold-library/dlx
5bdb082b8296696afc9c7398822bce8438f59b1e
Handle repeated subfields in CSV/TSV export Currently, in cases of fields with repeated subfield codes, only one of the subfields makes it into the serialization. This is due to the tabular nature of the serialization. - [ ] Concatenate the values of repeated subfields into one string joined by a separator i.e. ";" ...
diff --git a/dlx/scripts/init_indexes.py b/dlx/scripts/init_indexes.py index 7d99357..ad89d0e 100644 --- a/dlx/scripts/init_indexes.py +++ b/dlx/scripts/init_indexes.py @@ -56,7 +56,7 @@ def run(): collation=Config.marc_index_default_collation ) ) - indexes.append(col.creat...
dag-hammarskjold-library__dlx-438
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:Marc.commit", "dlx/marc/__init__.py:Marc.delete", "dlx/marc/__init__.py:Auth.heading_field", "dlx/marc/__init__.py:Auth.list_attached", "dlx/marc/__i...
dag-hammarskjold-library/dlx
fbcdb244752ece01002e7ba73074f88a2bbcb311
Update bib record when tag in linked auth changes Adresses https://github.com/dag-hammarskjold-library/dlx-rest/issues/1262
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index dd8bde5..1a1d638 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -854,6 +854,7 @@ class Marc(object): return ' '.join(all_text) except Exception as err: LOGGER.exception(err) + ra...
dag-hammarskjold-library__dlx-447
[ { "changes": { "added_entities": [ "dlx/marc/__init__.py:History.__init__", "dlx/marc/__init__.py:History.from_query", "dlx/marc/__init__.py:History.find_deleted", "dlx/marc/__init__.py:History.deleted_by_date", "dlx/marc/__init__.py:BibHistory.__init__", "d...
dag-hammarskjold-library/dlx
aa23dfa94855472021b84ce3db49aed315309af1
Search history using marc query documents For finding deleted records and searching within revisions
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index 13505bb..58440ab 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -1,13 +1,13 @@ """dlx.marc""" -import time, re, json, threading, copy +import time, re, json, threading, copy, typing from collections import Counter -from datetime import ...
dag-hammarskjold-library__dlx-457
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": [ "dlx/config.py:Config" ] }, "file": "dlx/config.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities...
dag-hammarskjold-library/dlx
f63f1da04d5392875266b95923970783fef485bb
Add a "user" field to file data Create a field in the file data to record a username of the file uploader
diff --git a/dlx/config.py b/dlx/config.py index cb37c56..ba81b44 100644 --- a/dlx/config.py +++ b/dlx/config.py @@ -288,6 +288,9 @@ class Config(): # the collation used in the MDB CE indexes on the bibs and auths collections marc_index_default_collation = {'locale': 'en', 'strength': 1, 'numericOrdering': Tr...
dag-hammarskjold-library__dlx-466
[ { "changes": { "added_entities": [ "dlx/marc/__init__.py:Datafield.delete_subfield" ], "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:Marc.get_subfields", "dlx/marc/__init__.py:Datafield.get_values" ], "edited_modules": [ "dl...
dag-hammarskjold-library/dlx
8cc574be85dfae5ef58c6a1e06334ba0966a128b
Enable Marc.get_values to return all subfield values if no subfield is specified
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index ace6197..e6aaf89 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -594,7 +594,7 @@ class Marc(object): def get_values(self, tag, *codes, **kwargs): if tag[:2] == '00': return [field.value for field in self.get_field...
dag-hammarskjold-library__dlx-469
[ { "changes": { "added_entities": [ "dlx/marc/__init__.py:Datafield.delete_subfield" ], "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:Marc.get_subfields", "dlx/marc/__init__.py:Marc.commit", "dlx/marc/__init__.py:Datafield.get_values" ...
dag-hammarskjold-library/dlx
0e62948c78b653afae5e9c3f63fea84f2f70f6a1
Bump version to v1.4.20 Clean up/prevent pseudo text index _id field null values and trailing spaces The tailing spaces happen when a subfield in an auth heading field is deleted. null subfield values in the the collections no longer occur, but some are left over from previous functionality and can disrupt search.
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index ace6197..d90cf38 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -594,7 +594,7 @@ class Marc(object): def get_values(self, tag, *codes, **kwargs): if tag[:2] == '00': return [field.value for field in self.get_field...
dag-hammarskjold-library__dlx-508
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:MarcSet.sort_table_header" ], "edited_modules": [ "dlx/marc/__init__.py:MarcSet" ] }, "file": "dlx/marc/__init__.py" } ]
dag-hammarskjold-library/dlx
0c44bf62c67b76c67ca2011a82c1f8ce8a9b035a
Table serialization fails when tag group has 10+ instances Regex needs to be updated here https://github.com/dag-hammarskjold-library/dlx/blob/0c44bf62c67b76c67ca2011a82c1f8ce8a9b035a/dlx/marc/__init__.py#L147
diff --git a/README.md b/README.md index c8a7ddd..457894c 100644 --- a/README.md +++ b/README.md @@ -32,15 +32,15 @@ query = Query.from_string("245__a:'Title' AND 245__b:'subtitle'") # construct a more specific query using a `Condition` query = Query( - Condition('245', {'a': 'Title', 'b': 'subtitle'}) + Conditi...
dag-hammarskjold-library__dlx-512
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/marc/query.py:Query.from_string" ], "edited_modules": [ "dlx/marc/query.py:Query" ] }, "file": "dlx/marc/query.py" } ]
dag-hammarskjold-library/dlx
117817f3321b71ef5061a84aaf99877f514ecb1c
Regex in querystrings not properly matching beginning of strings The following regex in querystrings does not return the proper results: `520:/corn/`. Whereas this search does: `520:/.*corn/`. These should both return the same results. Adresses https://github.com/dag-hammarskjold-library/dlx-rest/issues/1643
diff --git a/dlx/marc/query.py b/dlx/marc/query.py index 47abc1b..b3cf408 100644 --- a/dlx/marc/query.py +++ b/dlx/marc/query.py @@ -109,9 +109,7 @@ class Query(): '''Returns: dlx.query.Condition''' # fully qualified syntax - match = re.match(r'(\d{3})(.)(.)([a-z0-9]):...
dag-hammarskjold-library__dlx-522
[ { "changes": { "added_entities": [ "dlx/marc/__init__.py:Marc.from_table", "dlx/marc/__init__.py:Marc.from_csv" ], "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:MarcSet.sort_table_header" ], "edited_modules": [ "dlx/marc/__i...
dag-hammarskjold-library/dlx
fa26fb035eeac985e6f68a170916c0a2e66e3615
Implement Marc.from_table and Marc.from_csv Currently de-seriazation of tabular data exists for MarcSet, but into individual Marc objects. `.from_table` is for data in the form of abstracted tabular data. `.from_csv` should parse a CSV string into a table object, and then the table object can convert to a Marc object...
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index 56fa524..63659f9 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -1,6 +1,6 @@ """dlx.marc""" -import time, re, json, threading, copy, typing +import time, re, json, csv, threading, copy, typing from collections import Counter from datet...
dag-hammarskjold-library__dlx-523
[ { "changes": { "added_entities": [ "dlx/marc/__init__.py:Marc.from_table", "dlx/marc/__init__.py:Marc.from_csv" ], "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:MarcSet.sort_table_header", "dlx/marc/__init__.py:Marc.get_value" ], ...
dag-hammarskjold-library/dlx
fa26fb035eeac985e6f68a170916c0a2e66e3615
Marc.get_value() returns None if subfield is not in first instance of tag For example a record with the below fields will return None on bib.get_value('069', 'b). It should return "Test2". ``` =069 \\$aTest1 =069 \\$bTest2 ```
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index 56fa524..968aa7d 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -1,6 +1,6 @@ """dlx.marc""" -import time, re, json, threading, copy, typing +import time, re, json, csv, threading, copy, typing from collections import Counter from datet...
dag-hammarskjold-library__dlx-524
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:MarcSet.from_table", "dlx/marc/__init__.py:MarcSet.from_xml_raw", "dlx/marc/__init__.py:MarcSet.from_xml", "dlx/marc/__init__.py:MarcSet.to_table", "...
dag-hammarskjold-library/dlx
437508ae10eb43ed8cb08c095c48aedf231a96b7
Don't add 001 to seriazliations if there is no record ID New and temporary records don't have record IDs. In serialization to MRK, a 001 field with a value of None is being added to these records. The field should not be added at all.
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index 968aa7d..7948e91 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -171,14 +171,12 @@ class MarcSet(): value = table.index[temp_id][field_name] # parse the column header into tag, code and pl...
dag-hammarskjold-library__dlx-534
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx/marc/__init__.py:MarcSet.from_table" ], "edited_modules": [ "dlx/marc/__init__.py:MarcSet" ] }, "file": "dlx/marc/__init__.py" }, { "changes": { "adde...
dag-hammarskjold-library/dlx
aef49b3814de5d0bed103e5642fa3d8ab0ba96ed
Table column header parse bug The regex here is not accounting for "0" in the header name. This causes headers with "0" in the field place to throw an error on parse. i.e. `10.650$a` https://github.com/dag-hammarskjold-library/dlx/blob/9fbb8e0d976be285258b2c5470579e9da23697b5/dlx/marc/__init__.py#L174
diff --git a/dlx/marc/__init__.py b/dlx/marc/__init__.py index 67bbc89..b9c4741 100644 --- a/dlx/marc/__init__.py +++ b/dlx/marc/__init__.py @@ -171,7 +171,7 @@ class MarcSet(): value = table.index[temp_id][field_name] # parse the column header into tag, code and plac...
dag-hammarskjold-library__dlx-dl-123
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx_dl/scripts/export/__init__.py:_561" ], "edited_modules": [ "dlx_dl/scripts/export/__init__.py:_561" ] }, "file": "dlx_dl/scripts/export/__init__.py" }, { "c...
dag-hammarskjold-library/dlx-dl
f59613566132915e35ca8fe19ef7e41eb552a322
Set a language for fft created using field 561 add the language to the fft filed when importing a files using a uri as an identifier. Just like here: https://github.com/dag-hammarskjold-library/dlx-dl/blob/6a6aa2cb377b676761cae6607ef59e2f0264b478/dlx_dl/scripts/export/__init__.py#L537C18-L537C46
diff --git a/dlx_dl/scripts/export/__init__.py b/dlx_dl/scripts/export/__init__.py index e5fdcdc..bd80fbe 100644 --- a/dlx_dl/scripts/export/__init__.py +++ b/dlx_dl/scripts/export/__init__.py @@ -392,6 +392,7 @@ def _561(bib): latest = sorted(files, key=lambda x: x.timestamp, reverse=True)[0] ...
dag-hammarskjold-library__dlx-dl-172
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dlx_dl/scripts/sync/__init__.py:run", "dlx_dl/scripts/sync/__init__.py:get_records_by_date", "dlx_dl/scripts/sync/__init__.py:compare_and_update", "dlx_dl/scripts/sync/__init__.p...
dag-hammarskjold-library/dlx-dl
64a31dbbcde6faba84f0333a78ff15f2d41483e1
Bump version to v1.2.11
diff --git a/dlx_dl/scripts/sync/__init__.py b/dlx_dl/scripts/sync/__init__.py index b255fd5..17a5d92 100644 --- a/dlx_dl/scripts/sync/__init__.py +++ b/dlx_dl/scripts/sync/__init__.py @@ -93,7 +93,13 @@ def get_args(**kwargs): return parser.parse_args() -def run(**kwargs): +def run(**kwargs) -> int: + ...
dalibo__pgtoolkit-120
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "pgtoolkit/service.py:Service.__init__" ], "edited_modules": [ "pgtoolkit/service.py:Service" ] }, "file": "pgtoolkit/service.py" } ]
dalibo/pgtoolkit
a431f15e0d084437bb4f0e17e53cb95f94b42dc4
Service produces syntax error in service file ### Service produces syntax error in service file ``` pg_pass = parse_pgpass(HOMEPGPASS) for line in pg_pass: _service = Service( name=f"{line.database}-{line.username}", parameters={ "dbname": line.database, "host": lin...
diff --git a/pgtoolkit/service.py b/pgtoolkit/service.py index 0b1dbd3..1cd97ef 100644 --- a/pgtoolkit/service.py +++ b/pgtoolkit/service.py @@ -120,10 +120,12 @@ class Service(dict[str, Parameter]): 'mydb' >>> myservice.user = 'myuser' >>> list(sorted(myservice.items())) - [('dbname', 'mydb'), ('host...
dalibo__pgtoolkit-156
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "pgtoolkit/conf.py:parse_value" ], "edited_modules": [ "pgtoolkit/conf.py:parse_value" ] }, "file": "pgtoolkit/conf.py" } ]
dalibo/pgtoolkit
5c45afe24123a1813a62b8abe2759fca83fdc0ae
Boolean values should be accepted even if upper-cased Only the lower-cased variant are considered for boolean conversion: https://github.com/dalibo/pgtoolkit/blob/5c45afe24123a1813a62b8abe2759fca83fdc0ae/pgtoolkit/conf.py#L260 While the PG doc states it should be case insensitive: https://www.postgresql.org...
diff --git a/pgtoolkit/conf.py b/pgtoolkit/conf.py index c72ad7d..76389f4 100644 --- a/pgtoolkit/conf.py +++ b/pgtoolkit/conf.py @@ -257,10 +257,10 @@ def parse_value(raw: str) -> Value: kwargs = {arg: int(m.group("number"))} return timedelta(**kwargs) - if raw in ("true", "yes", "on"): + if r...
dalito__ucumvert-25
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/ucumvert/ucum_pint.py:UcumToPintTransformer.simple_unit" ], "edited_modules": [ "src/ucumvert/ucum_pint.py:UcumToPintTransformer" ] }, "file": "src/ucumvert/ucum_pi...
dalito/ucumvert
67f4b5b29003ec362d6094f022b4776b9d3b857a
Bad conversion : milli international unit per liter Hi, I think there is a problem when converting a IU with a prefix to a Pint unit: Input : `m[IU]/L` (from the UCUM examples list, #403) - Expected output : `milliinternational_unit / liter` - Actual output : `meter * international_unit / liter` Note that `k[IU...
diff --git a/src/ucumvert/ucum_pint.py b/src/ucumvert/ucum_pint.py index 7d1efc2..b6d31ef 100644 --- a/src/ucumvert/ucum_pint.py +++ b/src/ucumvert/ucum_pint.py @@ -152,7 +152,12 @@ class UcumToPintTransformer(Transformer): def simple_unit(self, args): # print("DBGsu>", repr(args), len(args)) if ...
damnever__fmt-16
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "fmt/fmt.py:Expression.__init__", "fmt/fmt.py:Parser._parse_node_str" ], "edited_modules": [ "fmt/fmt.py:Expression", "fmt/fmt.py:Parser" ] }, "file": "f...
damnever/fmt
12cc50185a8ff90db1ac17f862568a4780fee774
datetime format - `f('{datetime(1994, 11, 6, 0, 0, 0):%Y-%m-%d %H:%M:%S}')` - `f('{(lambda: datetime(1994, 11, 6, 0, 0, 0))():%Y-%m-%d %H:%M:%S}')`
diff --git a/fmt/fmt.py b/fmt/fmt.py index 019eab3..8344646 100644 --- a/fmt/fmt.py +++ b/fmt/fmt.py @@ -104,7 +104,7 @@ class Expression(Node): def __init__(self, expr, fmt, name='name'): self._expr = expr self._name = name - self._fmt = fmt.replace(expr, name).replace(' ', '') + s...
dandi__dandi-cli-1415
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/dandiapi.py:BaseRemoteAsset.get_content_url", "dandi/dandiapi.py:RemoteZarrEntry.get_download_file_iter" ], "edited_modules": [ "dandi/dandiapi.py:BaseRemoteAsset", ...
dandi/dandi-cli
2cafb50d896ee8eeb27641b19cfd407c395202e6
Use a dedicated URL-handling library There are various places in the code that would benefit from the use of a modern URL-handling library, such as [furl](https://github.com/gruns/furl), [purl](https://github.com/codeinthehole/purl), or [yarl](https://github.com/aio-libs/yarl). These include: * [x] [`is_same_url()`...
diff --git a/dandi/dandiapi.py b/dandi/dandiapi.py index 95960825..a7169c3a 100644 --- a/dandi/dandiapi.py +++ b/dandi/dandiapi.py @@ -14,13 +14,13 @@ import re from time import sleep, time from types import TracebackType from typing import TYPE_CHECKING, Any, Dict, List, Optional -from urllib.parse import quote_plu...
dandi__dandi-cli-1467
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/cli/cmd_download.py:download" ], "edited_modules": [ "dandi/cli/cmd_download.py:download" ] }, "file": "dandi/cli/cmd_download.py" }, { "changes": { ...
dandi/dandi-cli
c0b64d594fe5f251cff4fb3caf14872c4a6d28ad
download: add --keep-leading-path|-k or some mode for `--download` Inspired by - https://github.com/dandi/dandi-archive/issues/1981 ATM whenever we download an asset, we download file into current directory (besides if path is a glob as I showed in https://github.com/dandi/dandi-archive/issues/1981). That makes it...
diff --git a/dandi/cli/cmd_download.py b/dandi/cli/cmd_download.py index 7a9ebeff..32c1ff66 100644 --- a/dandi/cli/cmd_download.py +++ b/dandi/cli/cmd_download.py @@ -100,6 +100,15 @@ Download files or entire folders from DANDI. default="all", show_default=True, ) +@click.option( + "--preserve-tree", + ...
dandi__dandi-cli-1482
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/metadata/util.py:extract_species" ], "edited_modules": [ "dandi/metadata/util.py:extract_species" ] }, "file": "dandi/metadata/util.py" } ]
dandi/dandi-cli
5faa18a46ffb8dfc1217eb8664200acdd3cb0631
failed to extract metadata: UnboundLocalError: local variable 'value' referenced before assignment When trying to upload a dataset, I get a number of errors regarding a local variable "value" and a failure to extract metadata. Traceback below ``` Traceback (most recent call last): File "/home/nrsc/.local/lib...
diff --git a/dandi/metadata/util.py b/dandi/metadata/util.py index d3f8f95b..23f82b24 100644 --- a/dandi/metadata/util.py +++ b/dandi/metadata/util.py @@ -474,7 +474,7 @@ def extract_species(metadata: dict) -> models.SpeciesType | None: break if value_id is None: raise ValueEr...
dandi__dandi-cli-209
[ { "changes": { "added_entities": [ "dandi/cli/cmd_download.py:ChoiceList.__init__", "dandi/cli/cmd_download.py:ChoiceList.convert", "dandi/cli/cmd_download.py:ChoiceList.get_metavar" ], "added_modules": [ "dandi/cli/cmd_download.py:ChoiceList" ], "ed...
dandi/dandi-cli
59f8d905f8ec603947092bc0475b63edb77c8189
download: add an option to not download the entire dandiset the UX problem is that we do allow to download an arbitrary directory, files, etc. We need an option for a download at dandiset level to not download individual assets, and just get the `dandiset.yaml`. @satra thinks about `--no-assets` option. Could ...
diff --git a/dandi/cli/cmd_download.py b/dandi/cli/cmd_download.py index 32b1b481..e44e1c7d 100644 --- a/dandi/cli/cmd_download.py +++ b/dandi/cli/cmd_download.py @@ -4,6 +4,29 @@ import click from .base import devel_option, map_to_click_exceptions +class ChoiceList(click.ParamType): + name = "choice-list" + + ...
dandi__dandi-cli-330
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "dandi/cli/cmd_download.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_m...
dandi/dandi-cli
37498360bb5190963eae88bbff126b035a283ea0
Interface new implementation (API server) in dandi-cli top-level interfaces A decision was made in https://github.com/dandi/dandi-cli/pull/283 to aim to get `master` in a shape to support interaction with both current girder-based deployed dandiarchive **and** WiP https://github.com/dandi/dandi-api implementations with...
diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 51f7fdf6..c9312dae 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -42,7 +42,7 @@ development command line options. All those options would otherwise be hidden from the user visible (`--help`) interface, unless this env variable is set to non-empty value --...
dandi__dandi-cli-377
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/dandiarchive.py:navigate_url", "dandi/dandiarchive.py:_dandi_url_parser.parse" ], "edited_modules": [ "dandi/dandiarchive.py:navigate_url", "dandi/dandiarchive....
dandi/dandi-cli
351bd29572d274698b52547f81ca5c1de2a42467
dandi-api: improve download functionality TODOs - [x] add support for downloading a specific folder (that was disabled) - [x] replace hardcoded to consider "draft" to be the "latest version" . We should remove that and allow for version to be left unspecified, and then DandiAPIClient code handle it properly (get the ...
diff --git a/dandi/dandiarchive.py b/dandi/dandiarchive.py index 854a1547..8cb0c4eb 100644 --- a/dandi/dandiarchive.py +++ b/dandi/dandiarchive.py @@ -46,25 +46,34 @@ def navigate_url(url): args = asset_id, asset_type elif server_type == "api": client = DandiAPIClient(server_url) + if asse...
dandi__dandi-cli-535
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/dandiarchive.py:navigate_url", "dandi/dandiarchive.py:_dandi_url_parser.parse" ], "edited_modules": [ "dandi/dandiarchive.py:navigate_url", "dandi/dandiarchive....
dandi/dandi-cli
cebdf8614f0dac72d4cc04f29ad0e547eb2ab765
ls: provide ability to list individual asset from a download url ATM: ``` $> dandi ls -f json_pp https://api.dandiarchive.org/api/dandisets/000003/versions/draft/assets/0a748f90-d497-4a9c-822e-9c63811db412/download/ 2021-04-06 12:20:16,926 [ INFO] Logs saved in /home/yoh/.cache/dandi-cli/log/20210406162015Z-19639...
diff --git a/dandi/dandiarchive.py b/dandi/dandiarchive.py index 3729a092..81c0f6b8 100644 --- a/dandi/dandiarchive.py +++ b/dandi/dandiarchive.py @@ -51,7 +51,7 @@ def navigate_url(url): asset_id["version"] = r["most_recent_version"]["version"] args = (asset_id["dandiset_id"], asset_id["version"]...
dandi__dandi-cli-555
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/dandiarchive.py:_dandi_url_parser.parse" ], "edited_modules": [ "dandi/dandiarchive.py:_dandi_url_parser" ] }, "file": "dandi/dandiarchive.py" } ]
dandi/dandi-cli
b8bb48d890f6af6ad769637f42d9fba41478bfe4
downloading multiple assets using paths does not work two issues here: - [ ] download for path does not work - [ ] error logs should perhaps give instructions on how to expand error details. (for example use `-l DEBUG` and then copy and paste the entire log information) ``` $ dandi download 'https://api.dandiarch...
diff --git a/dandi/dandiarchive.py b/dandi/dandiarchive.py index 5f56eacc..55e1f7d8 100644 --- a/dandi/dandiarchive.py +++ b/dandi/dandiarchive.py @@ -198,12 +198,22 @@ class _dandi_url_parser: re.compile( rf"{server_grp}(?P<asset_type>dandiset)s/{dandiset_id_grp}" r"/vers...
dandi__dandi-cli-565
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/dandiarchive.py:_dandi_url_parser.parse" ], "edited_modules": [ "dandi/dandiarchive.py:_dandi_url_parser" ] }, "file": "dandi/dandiarchive.py" }, { "chang...
dandi/dandi-cli
6a5f285c74d8b398f6860b43a270ac1382a65709
automate switching to `-i dandi-api` via `dandiarchive.org/server-info` information ATM that one reports ```json { "version": "1.0.0", "cli-minimal-version": "0.6.0", "cli-bad-versions": [], "services": { "girder": { "url": "https://girder.dandiarchive.org" }, "webui": { "url": "https://gui.dandiarchive.org"...
diff --git a/dandi/dandiarchive.py b/dandi/dandiarchive.py index 8a097af6..f50280df 100644 --- a/dandi/dandiarchive.py +++ b/dandi/dandiarchive.py @@ -139,6 +139,7 @@ class _dandi_url_parser: # - server_type: # - 'girder' - underlying requests should go to girder server # - 'api' - the "n...
dandi__dandi-cli-582
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/cli/base.py:devel_debug_option" ], "edited_modules": [ "dandi/cli/base.py:devel_debug_option" ] }, "file": "dandi/cli/base.py" }, { "changes": { "ad...
dandi/dandi-cli
e564fdb3a964f5170f67e48b0ff9034794f4ca0d
codespell the code base works like charm: ```shell $> codespell dandi dandi/_version.py:280: unparseable ==> unparsable dandi/download.py:100: Activites ==> Activities dandi/models.py:438: alpha-numeric ==> alphanumeric dandi/utils.py:112: tollerance ==> tolerance dandi/utils.py:121: tollerance ==> tolerance da...
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 5cbea257..4e3fa019 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -18,3 +18,8 @@ repos: hooks: - id: isort exclude: ^(dandi/_version\.py|dandi/due\.py|versioneer\.py)$ +- repo: https://github.com/codespell...
dandi__dandi-cli-63
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/utils.py:find_files" ], "edited_modules": [ "dandi/utils.py:find_files" ] }, "file": "dandi/utils.py" } ]
dandi/dandi-cli
21b8505d8aedbdb2f764a727ca7a98e5c36da31e
hidden resource fork files break organize command on mac with external drive Nac users with an external drive are likely to have hidden "resource fork" files that have the prefix "`._`". These files are invisible and can normally be safely ignored, but they break the organize command. These files are difficult for mac ...
diff --git a/dandi/utils.py b/dandi/utils.py index a437d3ad..421dafb2 100644 --- a/dandi/utils.py +++ b/dandi/utils.py @@ -224,6 +224,7 @@ def find_files( regex, paths=os.curdir, exclude=None, + exclude_dotfiles=True, exclude_vcs=True, exclude_datalad=False, dirs=False, @@ -268,6 +269,7...
dandi__dandi-cli-96
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandi/validate.py:validate_dandi_nwb" ], "edited_modules": [ "dandi/validate.py:validate_dandi_nwb" ] }, "file": "dandi/validate.py" } ]
dandi/dandi-cli
2f45a2782cc0a6ba525c4c52d13f9bd6b3f91dc5
validate: crashes if file is not read ok ```shell (git-annex)lena:~/proj/dandi/nwb-datasets[master]bendichter/Gao2018 $> dandi validate *nwb anm00314746_2015-10-20 09:36:04 (1).nwb: ok anm00314746_2015-10-21 11:25:41 (1).nwb: ok anm00314746_2015-10-22 15:17:38 (1).nwb: ok anm00314756_2015-10-20 19:42:1...
diff --git a/dandi/validate.py b/dandi/validate.py index a614bb7a..ff038262 100644 --- a/dandi/validate.py +++ b/dandi/validate.py @@ -51,7 +51,10 @@ def validate_dandi_nwb(filepath): """Provide validation of .nwb file regarding requirements we impose """ # make sure that we have some basic metadata fiel...
dandi__dandi-schema-236
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dandischema/models.py:Contributor.ensure_contact_person_has_email" ], "edited_modules": [ "dandischema/models.py:Contributor" ] }, "file": "dandischema/models.py" }, ...
dandi/dandi-schema
dc15401c895f12186491247533587313a88c010f
Add a top-level `$schema` field to the generated JSON Schemata The JSON Schema spec is frequently updated (sometimes introducing backwards incompatibilities), and so we should [declare the JSON Schema version ("dialect") used by our schemata via a top-level `$schema` field](https://github.com/dandi/dandi-schema/issues/...
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index c79e46e..8fbbe97 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -2,14 +2,14 @@ # See https://pre-commit.com/hooks.html for more hooks repos: - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.6.0 + rev: ...
danielfernau__unifi-protect-video-downloader-380
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "protect_archiver/cli/download.py:download" ], "edited_modules": [ "protect_archiver/cli/download.py:download" ] }, "file": "protect_archiver/cli/download.py" }, { ...
danielfernau/unifi-protect-video-downloader
69006566fe747aef597472e7b67c74e27777554e
Ignores one of the times passing in --start="2020-08-29 18:24:55-0400" --end="2020-08-29 18:26:55-0400" and instead I get video from 2020-08-29 18:24:55-0400 to 2020-08-29 19:00:00-0400 but it seems to randomly (I cannot figure out the pattern...) where it will peg the start time to the hour vs the time I passed in...
diff --git a/poetry.lock b/poetry.lock index 1ff9710..f04e2ad 100644 --- a/poetry.lock +++ b/poetry.lock @@ -1,4 +1,4 @@ -# This file is automatically @generated by Poetry 1.6.1 and should not be changed by hand. +# This file is automatically @generated by Poetry 1.7.1 and should not be changed by hand. [[package]] ...
danielgtaylor__python-betterproto-495
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/betterproto/__init__.py:Message.to_pydict" ], "edited_modules": [ "src/betterproto/__init__.py:Message" ] }, "file": "src/betterproto/__init__.py" } ]
danielgtaylor/python-betterproto
aad7d2ad769fa26a90cc3572320e17093d3b7d48
TypeError in to_pydict with optional fields See https://github.com/danielgtaylor/python-betterproto/issues/475#issuecomment-1512296041 <details> <summary>Outdated</summary> I am using betterproto to load a ton of messages at once from a binary file, however this operation is very slow so I wanted to cache/parse ...
diff --git a/src/betterproto/__init__.py b/src/betterproto/__init__.py index 82a5b14..40be27f 100644 --- a/src/betterproto/__init__.py +++ b/src/betterproto/__init__.py @@ -1373,6 +1373,9 @@ class Message(ABC): value = [i.to_pydict(casing, include_default_values) for i in value] ...
danielgtaylor__python-betterproto-551
[ { "changes": { "added_entities": [ "src/betterproto/lib/google/protobuf/__init__.py:Struct.from_dict", "src/betterproto/lib/google/protobuf/__init__.py:Struct.to_dict" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "src/betterproto/li...
danielgtaylor/python-betterproto
b8a091ae7055dd949d193695a06c9536ad51eea8
Struct, Value well know type not supported https://developers.google.com/protocol-buffers/docs/reference/csharp/class/google/protobuf/well-known-types/struct These should map to `dict[str, any]` and `any`
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e59aac8..8f8b545 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,12 +16,12 @@ jobs: fail-fast: false matrix: os: [Ubuntu, MacOS, Windows] - python-version: ['3.7', '3.8', '3.9', '3.10', '3.11...
danielgtaylor__python-betterproto-594
[ { "changes": { "added_entities": null, "added_modules": [ "src/betterproto/__init__.py:_types_UnionType" ], "edited_entities": [ "src/betterproto/__init__.py:Message._get_field_default_gen" ], "edited_modules": [ "src/betterproto/__init__.py:Message" ...
danielgtaylor/python-betterproto
5fdd0bb24fc43091599a2284a948fc06e1a55edb
pydantic option broken ### Summary Instantiating messages generated with pydantic option throws exceptions. ### Protobuf schema ```proto syntax = "proto3"; package prototest.v1; message One { uint32 message = 1; } message Two { string message = 1; } message Message { oneof message { ...
diff --git a/src/betterproto/__init__.py b/src/betterproto/__init__.py index 050f414..cbafc83 100644 --- a/src/betterproto/__init__.py +++ b/src/betterproto/__init__.py @@ -62,6 +62,13 @@ if TYPE_CHECKING: SupportsWrite, ) +if sys.version_info >= (3, 10): + from types import UnionType as _types_Union...
danjac__pyramid_storage-54
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "pyramid_storage/gcloud.py:GoogleCloudStorage.save_file" ], "edited_modules": [ "pyramid_storage/gcloud.py:GoogleCloudStorage" ] }, "file": "pyramid_storage/gcloud.py" ...
danjac/pyramid_storage
ad4946eb84d90add50835c34727a01d251ea3a36
Switch to boto3 for Amazon S3 backend https://github.com/boto/boto3 See https://github.com/danjac/pyramid_storage/blob/a3fe9f6c00b1032e198b53e69eef0a28f06ec5c6/pyramid_storage/s3.py#L62-L65
diff --git a/docs/index.rst b/docs/index.rst index 7ae5c8a..4cc981f 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -84,7 +84,7 @@ Setting Default Description **aws.access_key** **required** AWS access key **aws.secret_key** **required** AWS secret key **...
danvk__webdiff-180
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "webdiff/unified_diff.py:read_codes", "webdiff/unified_diff.py:add_replaces", "webdiff/unified_diff.py:diff_to_codes" ], "edited_modules": [ "webdiff/unified_diff.py:C...
danvk/webdiff
e8a72fbaff7908eea0dd25a6275bf42aa08e8b4e
Show diffhunk headers `git diff` and GitHub's UI show headers on diffhunks to give you some context, typically the name of the containing function: ``` @@ -218,7 +208,7 @@ class CustomHTTPRequestHandler(BaseHTTPRequestHandler): ``` <img width="1479" alt="image" src="https://github.com/danvk/webdiff/assets/98301...
diff --git a/ts/CodeDiff.tsx b/ts/CodeDiff.tsx index af43419..ddb15aa 100644 --- a/ts/CodeDiff.tsx +++ b/ts/CodeDiff.tsx @@ -104,6 +104,7 @@ export function CodeDiff(props: {filePair: FilePair, diffOptions: Partial<DiffOp } })().catch(e => { alert('Unable to get diff!'); + console.error(e); ...
dapr__python-sdk-272
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dapr/actor/runtime/_reminder_data.py:ActorReminderData.as_dict" ], "edited_modules": [ "dapr/actor/runtime/_reminder_data.py:ActorReminderData" ] }, "file": "dapr/actor...
dapr/python-sdk
04d838965344608f6021621995c50a1a5548f5a3
ReminderData does not honours period value ## Expected Behavior When registering an Actor's reminder it should honour the `period` argument's value, allowing us to schedule reminders. ## Actual Behavior when receive_reminder() is called, `period` argument contains the `due_time` 'svalue. Also, reminder is ca...
diff --git a/dapr/actor/runtime/_reminder_data.py b/dapr/actor/runtime/_reminder_data.py index 2fcddfd..62cd202 100644 --- a/dapr/actor/runtime/_reminder_data.py +++ b/dapr/actor/runtime/_reminder_data.py @@ -74,7 +74,7 @@ class ActorReminderData: return { 'reminderName': self._reminder_name, ...
dapr__python-sdk-293
[ { "changes": { "added_entities": [ "dapr/clients/grpc/_response.py:InvokeMethodResponse.json", "dapr/clients/grpc/_response.py:BindingResponse.json", "dapr/clients/grpc/_response.py:StateResponse.json", "dapr/clients/grpc/_response.py:BulkStateItem.json" ], "add...
dapr/python-sdk
33e7d48ffbed9b175ff095d18247f328e990d4ca
Support default json serializer in DaprClient and add .json helper ## Describe the proposal In [the convenient layer spec](https://github.com/dapr/python-sdk/issues/67), DaprClient doesn't have the default json serializer, but let users to handle JSON serialization. Like the other python pkgs, such as flask, request...
diff --git a/dapr/clients/grpc/_response.py b/dapr/clients/grpc/_response.py index 383a67a..d037a3f 100644 --- a/dapr/clients/grpc/_response.py +++ b/dapr/clients/grpc/_response.py @@ -20,6 +20,8 @@ from dapr.clients.grpc._helpers import ( unpack, ) +import json + class DaprResponse: """A base class for...
dapr__python-sdk-400
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dapr/clients/__init__.py:DaprClient.invoke_method" ], "edited_modules": [ "dapr/clients/__init__.py:DaprClient" ] }, "file": "dapr/clients/__init__.py" }, { "ch...
dapr/python-sdk
d783ed2538bac6b464a5f1678b202e9edf69d7c8
invoke_binding call shouldn't require the data parameter
diff --git a/dapr/clients/__init__.py b/dapr/clients/__init__.py index fb4d223..c871e5f 100644 --- a/dapr/clients/__init__.py +++ b/dapr/clients/__init__.py @@ -89,7 +89,7 @@ class DaprClient(DaprGrpcClient): self, app_id: str, method_name: str, - data: Union[bytes, str...
dapr__python-sdk-402
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dapr/clients/http/dapr_invocation_http_client.py:DaprInvocationHttpClient.invoke_method_async" ], "edited_modules": [ "dapr/clients/http/dapr_invocation_http_client.py:DaprInvocation...
dapr/python-sdk
c57b872bcd263c5a856b8b0caf3e0075cde4fd92
DaprInvocationHttpClient should correctly populate headers in InvokeMethodResponse ## Expected Behavior DaprInvocationHttpClient should correctly populate headers in InvokeMethodResponse ## Actual Behavior DaprInvocationHttpClient does not correctly populate headers in InvokeMethodResponse ## Steps to R...
diff --git a/dapr/clients/http/dapr_invocation_http_client.py b/dapr/clients/http/dapr_invocation_http_client.py index 97b6020..623df62 100644 --- a/dapr/clients/http/dapr_invocation_http_client.py +++ b/dapr/clients/http/dapr_invocation_http_client.py @@ -97,8 +97,12 @@ class DaprInvocationHttpClient: ...
dapr__python-sdk-692
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dapr/clients/health.py:DaprHealth.wait_until_ready" ], "edited_modules": [ "dapr/clients/health.py:DaprHealth" ] }, "file": "dapr/clients/health.py" } ]
dapr/python-sdk
9021b952c686dec424cda07023e8df4e5feb978b
[BUG] DAPR_HEALTH_TIMEOUT as environment variable is not converted to numerical value ## Expected Behavior When passing `DAPR_HEALTH_TIMEOUT` as environment variable it should be converted to a numerical value. ## Actual Behavior docker container with env `DAPR_HEALTH_TIMEOUT=30` ```timestamp="2024-03-22...
diff --git a/dapr/clients/health.py b/dapr/clients/health.py index 120b559..e3daec7 100644 --- a/dapr/clients/health.py +++ b/dapr/clients/health.py @@ -28,7 +28,7 @@ class DaprHealth: headers = {USER_AGENT_HEADER: DAPR_USER_AGENT} if settings.DAPR_API_TOKEN is not None: headers[DAPR_API_...
darosior__python-bip32-10
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "bip32/bip32.py:BIP32.get_extended_pubkey_from_path" ], "edited_modules": [ "bip32/bip32.py:BIP32" ] }, "file": "bip32/bip32.py" } ]
darosior/python-bip32
b3f6696229bada1089f06ec095b3d650276c0d7b
Can't derive master xpubs ```python if _hardened_index_in_path(path): for index in path: if index & HARDENED_INDEX: key, chaincode = \ _derive_hardened_private_child(key, chaincode, index) else: ke...
diff --git a/bip32/bip32.py b/bip32/bip32.py index e66103d..b48af98 100644 --- a/bip32/bip32.py +++ b/bip32/bip32.py @@ -84,6 +84,7 @@ class BIP32: if isinstance(path, str): path = _deriv_path_str_to_list(path) chaincode, key = self.master_chaincode, self.master_privkey + pubkey = ...
dask__dask-10159
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/config.py:update", "dask/config.py:update_defaults" ], "edited_modules": [ "dask/config.py:update", "dask/config.py:update_defaults" ] }, "file": "...
dask/dask
e3aa15e54600659ddc1b7139143a70ef1c1c05c6
`config.update_defaults` doesn't replace previous default values The `update_defaults` function doesn't quite do what the name implies, because it doesn't actually override values that were previously set as defaults: ```python In [1]: import dask.config In [2]: len(dask.config.defaults) Out[2]: 1 In [3]: dask...
diff --git a/dask/config.py b/dask/config.py index c3a1836a7..6aee66f17 100644 --- a/dask/config.py +++ b/dask/config.py @@ -79,7 +79,12 @@ def canonical_name(k: str, config: dict) -> str: return k -def update(old: dict, new: Mapping, priority: Literal["old", "new"] = "new") -> dict: +def update( + old: dic...
dask__dask-1024
[ { "changes": { "added_entities": [ "dask/array/reductions.py:_tree_reduce", "dask/array/reductions.py:make_arg_reduction" ], "added_modules": [ "dask/array/reductions.py:_tree_reduce", "dask/array/reductions.py:make_arg_reduction" ], "edited_entities...
dask/dask
09bda79a79acc261f31a446425efc5dd2fb42b9a
dask.array.argmin fails on 3D input ``` In [29]: da.from_array(np.random.randn(2, 3, 4), chunks=(2, 3, 4)).argmin(axis=0).compute() --------------------------------------------------------------------------- IndexError Traceback (most recent call last) <ipython-input-29-b25ac117010d> ...
diff --git a/dask/array/reductions.py b/dask/array/reductions.py index 3f05e1628..a29003285 100644 --- a/dask/array/reductions.py +++ b/dask/array/reductions.py @@ -1,12 +1,12 @@ from __future__ import absolute_import, division, print_function from functools import partial, wraps -from itertools import product +fro...
dask__dask-1028
[ { "changes": { "added_entities": [ "dask/array/reductions.py:nanarg_agg", "dask/array/reductions.py:_nanargmin", "dask/array/reductions.py:_nanargmax" ], "added_modules": [ "dask/array/reductions.py:nanarg_agg", "dask/array/reductions.py:_nanargmin", ...
dask/dask
6dc9229362f2d3b1dfa466a8a63831c3c832b4be
da.nanargmax fails when it encounters an all-NaN slice in a chunk Follow up on #776 ``` In [1]: import numpy as np In [2]: import dask.array as da In [3]: x = np.array([[1.0, np.nan], [np.nan, 2.0]]) In [4]: da.nanmax(da.from_array(x, chunks=1), axis=1).compute() /Users/shoyer/miniconda/envs/dask-dev/lib/...
diff --git a/dask/array/reductions.py b/dask/array/reductions.py index a29003285..c0b12cd08 100644 --- a/dask/array/reductions.py +++ b/dask/array/reductions.py @@ -466,6 +466,13 @@ def arg_agg(func, argfunc, data, axis=None, **kwargs): return _arg_combine(data, axis, argfunc, keepdims=False)[0] +def nanarg_ag...
dask__dask-10380
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "dask/array/stats.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/cli.py:_reg...
dask/dask
85c99bc20abc382774cfb6e5bf5f2db76ac09378
CLI registration can fail with bad submodule If a package registers an entry point for the CLI but the entrypoint is broken or not importable the CLI cannot work at all. This is a little hard to create an MRE for but I seeing this with `dask-ctl` when updating `textual` to a more recent version. Ther error comes fro...
diff --git a/dask/array/stats.py b/dask/array/stats.py index e5ec8c320..0b0480bae 100644 --- a/dask/array/stats.py +++ b/dask/array/stats.py @@ -144,8 +144,48 @@ def ttest_rel(a, b, axis=0, nan_policy="propagate"): return delayed(Ttest_relResult, nout=2)(t, prob) -@derived_from(scipy.stats) def chisquare(f_ob...
dask__dask-10509
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/config.py:update" ], "edited_modules": [ "dask/config.py:update" ] }, "file": "dask/config.py" } ]
dask/dask
d86545992a7b81fc92a8bd63e0f02c6d95419585
Breaking change of dask config schema https://github.com/dask/dask/pull/10456 introduced a breaking change to the dask config schema by changing `admin.traceback.shorten` from type dict/object to a list/array. Depending on how configs are managed this can cause critical startup failures of servers. One way I foun...
diff --git a/dask/config.py b/dask/config.py index 1ba48faee..e1ea81e83 100644 --- a/dask/config.py +++ b/dask/config.py @@ -126,7 +126,7 @@ def update( k = canonical_name(k, old) if isinstance(v, Mapping): - if k not in old or old[k] is None: + if k not in old or old[k] is Non...
dask__dask-10695
[ { "changes": { "added_entities": [ "dask/dataframe/__init__.py:_dask_expr_enabled", "dask/dataframe/__init__.py:raise_not_implemented_error" ], "added_modules": [ "dask/dataframe/__init__.py:_dask_expr_enabled", "dask/dataframe/__init__.py:raise_not_implemented_...
dask/dask
51f90b62bee920bdd84e9c210fcddbea6c7c43a0
Add a `.__wrapped__` (or similar) attribute for `@dask.delayed`-decorated functions It would be nice if the `@dask.delayed`-decorated function had an attribute that could be called to return the undecorated function. Drawing inspiration from the widely used [`functools.wraps()`](https://docs.python.org/3/library/functo...
diff --git a/.github/workflows/label-prs.yml b/.github/workflows/label-prs.yml index b27f957d9..834bbcd32 100644 --- a/.github/workflows/label-prs.yml +++ b/.github/workflows/label-prs.yml @@ -6,7 +6,7 @@ jobs: label: runs-on: ubuntu-latest steps: - - uses: actions/labeler@v4.3.0 + - uses: actions/la...
dask__dask-10705
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/multi.py:_split_partition" ], "edited_modules": [ "dask/dataframe/multi.py:_split_partition" ] }, "file": "dask/dataframe/multi.py" }, { "changes...
dask/dask
dc59297482a1402ebd4f15bd8cfbdc5e80039468
Unstable grouping result when calling groupby apply on merged dask dataframes with missing values Merging two dataframes together can result in missing values, espeically when doing an outer join. Using `groupby` + `apply` on such merged results seems to produce unstable result especially when grouping by columns of no...
diff --git a/dask/dataframe/multi.py b/dask/dataframe/multi.py index 82d43f315..a46530fd2 100644 --- a/dask/dataframe/multi.py +++ b/dask/dataframe/multi.py @@ -1412,7 +1412,15 @@ def _split_partition(df, on, nsplits): # add a "_partitions" column to perform the split. if not isinstance(on, _Frame): ...
dask__dask-10738
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/core.py:_Frame._drop_duplicates_shuffle", "dask/dataframe/core.py:_Frame.shuffle", "dask/dataframe/core.py:DataFrame.merge", "dask/dataframe/core.py:DataFrame.join...
dask/dask
31b26dfa4bf15f23a7070155ac67e6ba285de76f
Deprecate ``shuffle`` keyword in favour of ``shuffle_method`` for DataFrame methods dask-expr already changed the shuffle keyword to be a bit more explicit, we should deprecate this here to enforce when moving over Get us consistent with the config option as well
diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py index 7cddc42d9..e1e7904a4 100644 --- a/dask/dataframe/core.py +++ b/dask/dataframe/core.py @@ -84,6 +84,7 @@ from dask.utils import ( M, OperatorMethodMixin, _deprecated, + _deprecated_kwarg, apply, derived_from, funcname, @@...
dask__dask-10743
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/core.py:_Frame._drop_duplicates_shuffle", "dask/dataframe/core.py:_Frame.shuffle", "dask/dataframe/core.py:DataFrame.merge", "dask/dataframe/core.py:DataFrame.join...
dask/dask
74e898f0ec712e8317ba86cc3b9d18b6b9922be0
Deprecate fastparquet engine for read_parquet to enable switch to dask-expr dask-expr will only support ``engine="pyarrow"``, so we should deprecate this here to allow users time to switch the engine before we switch to dask-expr or at least know that this change is coming.
diff --git a/continuous_integration/environment-3.10.yaml b/continuous_integration/environment-3.10.yaml index 25a7bf2b1..7b8ee6ef0 100644 --- a/continuous_integration/environment-3.10.yaml +++ b/continuous_integration/environment-3.10.yaml @@ -27,7 +27,7 @@ dependencies: - numpy=1.23 - pandas=1.5 - flask - -...
dask__dask-10750
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/shuffle.py:sort_values", "dask/dataframe/shuffle.py:set_index" ], "edited_modules": [ "dask/dataframe/shuffle.py:sort_values", "dask/dataframe/shuffle....
dask/dask
6d5b994cb58f295c27bd888de0f67c83ed568d3d
Deprecate ``npartitions="auto"`` for set_index and sort_values The docs state that this makes a decision based on memory use > If ‘auto’ then decide by memory use. But that's just wrong ``` if npartitions == "auto": repartition = True npartitions = max(100, df.npartitions) ``` This i...
diff --git a/dask/dataframe/shuffle.py b/dask/dataframe/shuffle.py index 270df6da4..663e18a1a 100644 --- a/dask/dataframe/shuffle.py +++ b/dask/dataframe/shuffle.py @@ -166,6 +166,11 @@ def sort_values( return df.map_partitions(sort_function, **sort_kwargs) if npartitions == "auto": + warnings.wa...
dask__dask-10754
[ { "changes": { "added_entities": [ "dask/dataframe/core.py:Series._view" ], "added_modules": null, "edited_entities": [ "dask/dataframe/core.py:Series.view", "dask/dataframe/core.py:_convert_to_numeric" ], "edited_modules": [ "dask/dataframe/co...
dask/dask
3a91f5ea706d7acc2e836031b430e25d89402091
Deprecate Series.view Same as the others, that's deprecated in pandas for 3.0 so we can move ahead with it already
diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py index e1e7904a4..9ac54c8ae 100644 --- a/dask/dataframe/core.py +++ b/dask/dataframe/core.py @@ -4652,8 +4652,17 @@ Dask Name: {name}, {layers}""".format( token="monotonic_decreasing", ) + @_deprecated( + message=( + ...
dask__dask-10765
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/core.py:validate_key" ], "edited_modules": [ "dask/core.py:validate_key" ] }, "file": "dask/core.py" } ]
dask/dask
63b6bb84015975c8466e80d1d498a293835ae936
Exception from `validate_key` is misleading for composite keys When validating a key tuple with an invalid component, the exception is currently not helpful for identifying the problem and might even be misleading: ```python import numpy as np from dask.core import validate_key validate_key((1, np.int64(2), 3)) ...
diff --git a/dask/core.py b/dask/core.py index ef75ca563..e00e4fb8a 100644 --- a/dask/core.py +++ b/dask/core.py @@ -218,9 +218,26 @@ def iskey(key: object) -> bool: def validate_key(key: object) -> None: - """Validate the format of a dask key.""" - if not iskey(key): - raise TypeError(f"Unexpected ke...
dask__dask-10784
[ { "changes": { "added_entities": [ "dask/base.py:_distributed_available" ], "added_modules": [ "dask/base.py:_distributed_available" ], "edited_entities": [ "dask/base.py:get_scheduler" ], "edited_modules": [ "dask/base.py:get_scheduler" ...
dask/dask
b934d2db6dc5f3a467f6f12754999aebbf486417
Deprecate compute keyword for set_index This is only relevant if you have a disk based shuffle and I don't really know what the advantage of the keyword would be. It seems like something that we should clean up
diff --git a/dask/base.py b/dask/base.py index 465339336..bf06debce 100644 --- a/dask/base.py +++ b/dask/base.py @@ -14,7 +14,7 @@ import warnings from collections import OrderedDict from collections.abc import Callable, Hashable, Iterator, Mapping from concurrent.futures import Executor -from contextlib import cont...
dask__dask-10796
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/core.py:_determine_split_out_shuffle", "dask/dataframe/core.py:_Frame.drop_duplicates", "dask/dataframe/core.py:Index.drop_duplicates" ], "edited_modules": [ ...
dask/dask
3e9ae492934e133547e5eaec5020186fad39898a
Deprecate axis in GroupBy cumulative transformers Deprecate axis in - cumsum - cumprod - cumcount and please skip tests that test this behaviour for dask-expr
diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py index 67e829a52..6f58192a3 100644 --- a/dask/dataframe/core.py +++ b/dask/dataframe/core.py @@ -197,9 +197,9 @@ def _concat(args, ignore_index=False): ) -def _determine_split_out_shuffle(shuffle, split_out): +def _determine_split_out_shuffle(shuffle_...
dask__dask-10800
[ { "changes": { "added_entities": [ "dask/dataframe/core.py:_dummy_numpy_dispatcher" ], "added_modules": [ "dask/dataframe/core.py:_dummy_numpy_dispatcher" ], "edited_entities": [ "dask/dataframe/core.py:_Frame._cum_agg", "dask/dataframe/core.py:Serie...
dask/dask
3b502f1923bfe50a31fa1e6fd605f7942a2227af
Deprecate legacy keywords from reductions Some of those keywords were part of pandas ages ago (before 1.0 was released), so we should rip them out while moving over to dask-expr dtype keyword: - sum - prod - product - mean - var - std - cumsum - cumprod out keyword: - sum - prod - product - max -...
diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py index 6f58192a3..79091a18d 100644 --- a/dask/dataframe/core.py +++ b/dask/dataframe/core.py @@ -7,7 +7,7 @@ from functools import partial, wraps from numbers import Integral, Number from operator import getitem from pprint import pformat -from typing impor...
dask__dask-10803
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": [ "dask/dataframe/core.py:_Frame" ] }, "file": "dask/dataframe/core.py" } ]
dask/dask
981c95b117df662e67c05d91a9d0e56e80b5a0c4
Deprecate axis keyword in rolling https://pandas.pydata.org/docs/dev/reference/api/pandas.DataFrame.rolling.html pandas deprecated the arg as well
diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py index 79091a18d..ca09cb9c8 100644 --- a/dask/dataframe/core.py +++ b/dask/dataframe/core.py @@ -2158,6 +2158,7 @@ Dask Name: {name}, {layers}""" else: return lambda self, other: elemwise(op, self, other) + @_deprecated_kwarg("axis",...
dask__dask-10812
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/routines.py:tensordot" ], "edited_modules": [ "dask/array/routines.py:tensordot" ] }, "file": "dask/array/routines.py" } ]
dask/dask
7373f4b80a6b1764fc6ab2a9726373207a92b2f4
`dask.array.tensordot` bug: negative values in argument `axes` give wrong results. **Describe the issue**: While `numpy.tensordot` accepts negative axes, negative axes in `dask.array.tensordot` give wrong results. **Minimal Complete Verifiable Example**: ```python import numpy as np import dask.array as da ...
diff --git a/dask/array/routines.py b/dask/array/routines.py index 4780f71d7..a56e9179b 100644 --- a/dask/array/routines.py +++ b/dask/array/routines.py @@ -345,6 +345,7 @@ def tensordot(lhs, rhs, axes=2): if concatenate: return intermediate else: + left_axes = [ax if ax >= 0 else lhs.ndim + a...
dask__dask-10827
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/__init__.py:raise_not_implemented_error" ], "edited_modules": [ "dask/dataframe/__init__.py:raise_not_implemented_error" ] }, "file": "dask/dataframe/__i...
dask/dask
e72f93e4942fbc4cc70170cf1192e3dd0a69275a
Deprecate convert_dtype in apply deprecated in pandas, so lets rip it out now before we move to dask-expr
diff --git a/dask/dataframe/__init__.py b/dask/dataframe/__init__.py index b247c4b76..0f64a152d 100644 --- a/dask/dataframe/__init__.py +++ b/dask/dataframe/__init__.py @@ -14,67 +14,82 @@ def _dask_expr_enabled() -> bool: if _dask_expr_enabled(): - from dask_expr import ( - DataFrame, - Index, - ...
dask__dask-10846
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": [ "dask/dataframe/core.py:_Frame" ] }, "file": "dask/dataframe/core.py" }, { "changes": { "added_entities": null, "added_modules": null, ...
dask/dask
16da9a1ed19a2f63cedb9176d1b49c2ccab51786
Deprecate method and limit from fillna both of them are deprecated in pandas, so lets remove before we switch to dask-expr Also lets deprecated downcast from bfill, ffill and fillna
diff --git a/dask/dataframe/core.py b/dask/dataframe/core.py index ca09cb9c8..e5b5a40bb 100644 --- a/dask/dataframe/core.py +++ b/dask/dataframe/core.py @@ -1880,6 +1880,7 @@ Dask Name: {name}, {layers}""" else: return self + @_deprecated_kwarg("method", None, comment="Use ffill or bfill inst...
dask__dask-10888
[ { "changes": { "added_entities": [ "dask/array/routines.py:_isnonzero" ], "added_modules": [ "dask/array/routines.py:_isnonzero" ], "edited_entities": [ "dask/array/routines.py:isnonzero" ], "edited_modules": [ "dask/array/routines.py:isn...
dask/dask
83368b58da67d5847dccf02a5c5fdfe5bb59ab6e
Tests for dummy data generation failing Looks like there are some tests failing for the dummy data generation https://dask.github.io/dask/test_short_report.html https://github.com/dask/dask/actions/runs/7650514559/job/20846717103
diff --git a/continuous_integration/environment-3.10.yaml b/continuous_integration/environment-3.10.yaml index d917a0781..82f301b36 100644 --- a/continuous_integration/environment-3.10.yaml +++ b/continuous_integration/environment-3.10.yaml @@ -23,7 +23,7 @@ dependencies: - pytest-xdist - moto<5 # Optional dep...
dask__dask-10921
[ { "changes": { "added_entities": [ "dask/cli.py:config_set", "dask/cli.py:save_config" ], "added_modules": [ "dask/cli.py:config_set", "dask/cli.py:save_config" ], "edited_entities": [ "dask/cli.py:config_get", "dask/cli.py:config_lis...
dask/dask
76b255e3f3b8b116b6046d03105e3ceae40386b6
Deprecation warning is pretty intense ```python In [1]: import dask In [2]: import dask.dataframe <ipython-input-2-1d704cbd4e0a>:1: DeprecationWarning: The current Dask DataFrame implementation is deprecated. In a future release, Dask DataFrame will use new implementation that contains several improvements inclu...
diff --git a/dask/cli.py b/dask/cli.py index 5ec92e209..f28ea1f33 100644 --- a/dask/cli.py +++ b/dask/cli.py @@ -1,11 +1,12 @@ from __future__ import annotations +import pathlib import warnings from functools import reduce import click import importlib_metadata -from yaml import dump +import yaml import das...
dask__dask-10959
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/_compatibility.py:entry_points" ], "edited_modules": [ "dask/_compatibility.py:entry_points" ] }, "file": "dask/_compatibility.py" }, { "changes": { ...
dask/dask
9531ebe9e8481333f6ae35091b85fd4912fa37e0
Sphinx API documentation for `dask.config` shows the whole config https://docs.dask.org/en/stable/configuration.html#api The rendered signature for `get`, `set`, `refresh` contains a snapshot of the whole dask config, which makes it hard and confusing to read.
diff --git a/continuous_integration/environment-3.12.yaml b/continuous_integration/environment-3.12.yaml index fac2a8f5f..7e112d4a3 100644 --- a/continuous_integration/environment-3.12.yaml +++ b/continuous_integration/environment-3.12.yaml @@ -12,7 +12,6 @@ dependencies: - cloudpickle - partd - fsspec - - im...
dask__dask-10972
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/blockwise.py:_optimize_blockwise" ], "edited_modules": [ "dask/blockwise.py:_optimize_blockwise" ] }, "file": "dask/blockwise.py" }, { "changes": { "...
dask/dask
9c20facdfb5f20e28f0e9259147283f8a7982728
Fix CSV encoding with pandas 1.0 With pandas 1.0.0rc0, the test `dask/dataframe/io/tests/test_csv.py::test_encoding_gh601[utf-16]` is failing ```pytb pytest dask/dataframe/io/tests/test_csv.py -k test_encoding_gh601[utf-16] -v ================================================================================ test se...
diff --git a/dask/blockwise.py b/dask/blockwise.py index 51d822418..1be3c6f3f 100644 --- a/dask/blockwise.py +++ b/dask/blockwise.py @@ -1138,16 +1138,14 @@ def _optimize_blockwise(full_graph, keys=()): blockwise_layers.add(dep) # traverse further to this child's children + ...
dask__dask-11023
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/base.py:is_dask_collection" ], "edited_modules": [ "dask/base.py:is_dask_collection" ] }, "file": "dask/base.py" }, { "changes": { "added_entities": ...
dask/dask
8c2199e3862c6320721815e87ebd5b7ab52457a4
value_counts with NaN sometimes raises ValueError: No objects to concatenate <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrock...
diff --git a/dask/base.py b/dask/base.py index 737ca24f3..ec6c49933 100644 --- a/dask/base.py +++ b/dask/base.py @@ -235,7 +235,7 @@ def is_dask_collection(x) -> bool: return False pkg_name = getattr(type(x), "__module__", "").split(".")[0] - if pkg_name == "dask_expr": + if pkg_name in ("dask_exp...
dask__dask-11118
[ { "changes": { "added_entities": [ "dask/dataframe/groupby.py:_adjust_for_arrow_na" ], "added_modules": [ "dask/dataframe/groupby.py:_adjust_for_arrow_na" ], "edited_entities": [ "dask/dataframe/groupby.py:_finalize_mean", "dask/dataframe/groupby.py:...
dask/dask
017adfb1794cd3debef0b7a4b0e8b6a587da8531
When using PyArrow dtypes, aggregations create NaNs of unexpected type <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrocklin.co...
diff --git a/dask/dataframe/groupby.py b/dask/dataframe/groupby.py index a1350694f..5e6c23a9d 100644 --- a/dask/dataframe/groupby.py +++ b/dask/dataframe/groupby.py @@ -1227,10 +1227,23 @@ def _apply_func_to_columns(df_like, prefix, func): def _finalize_mean(df, sum_column, count_column): - return df[sum_column...
dask__dask-1113
[ { "changes": { "added_entities": [ "dask/array/core.py:Array.copy" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "dask/array/core.py:Array" ] }, "file": "dask/array/core.py" } ]
dask/dask
6e7fea680dc7eaf6f96452e00625e0466c110532
Add a dummy .copy() method on dask arrays? There's no need to copy the data in dask arrays, because they're (currently) immutable. Still, it's common to copy numpy arrays to be on the safe side, so it might be nice to add this for duck-array compatibility.
diff --git a/dask/array/core.py b/dask/array/core.py index b85b5c2c0..a6e10cc55 100644 --- a/dask/array/core.py +++ b/dask/array/core.py @@ -1377,6 +1377,12 @@ class Array(Base): out._chunks = chunks return out + def copy(self): + """ + Copy array. This is a no-op for dask.arrays, ...
dask__dask-11183
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/__init__.py:_dask_expr_enabled" ], "edited_modules": [ "dask/dataframe/__init__.py:_dask_expr_enabled" ] }, "file": "dask/dataframe/__init__.py" } ]
dask/dask
1755a718125ef2ea18e9c079ecf1509b7b6be730
[FEA] Add official mechanism to check if query-planning is enabled in ``dask.dataframe`` The value of the `"dataframe.query-planning"` config currently dictates whether or not `dask.dataframe` will use dask-expr under the hood. However, after `dask.dataframe` is first imported, the value of the `"dataframe.query-planni...
diff --git a/dask/dataframe/__init__.py b/dask/dataframe/__init__.py index 029eef5c5..1a3e128f6 100644 --- a/dask/dataframe/__init__.py +++ b/dask/dataframe/__init__.py @@ -5,19 +5,37 @@ import warnings from packaging.version import Version +# The "dataframe.query-planning" config can only be processed once +DASK_...
dask__dask-11233
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/backends.py:_nonempty_series" ], "edited_modules": [ "dask/dataframe/backends.py:_nonempty_series" ] }, "file": "dask/dataframe/backends.py" }, { ...
dask/dask
6a04b4ed70934b548d25a793eed90f033a690531
Roundtripping timezone-aware DataFrame through parquet doesn't preserve timestamp resolution While diagnosing some of the failures we're seeing over in https://github.com/coiled/dask-bigquery/pull/81, I stumbled across an issue with roundtripping timezone-aware timeseries data through parquet with Dask. Here's a minima...
diff --git a/dask/dataframe/backends.py b/dask/dataframe/backends.py index b2b4b63d9..afdf46522 100644 --- a/dask/dataframe/backends.py +++ b/dask/dataframe/backends.py @@ -436,7 +436,7 @@ def _nonempty_series(s, idx=None): data = [s.iloc[0]] * 2 elif isinstance(dtype, pd.DatetimeTZDtype): entry ...
dask__dask-1126
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/callbacks.py:Callback.__init__" ], "edited_modules": [ "dask/callbacks.py:Callback" ] }, "file": "dask/callbacks.py" } ]
dask/dask
5d94595499ebf0dd7b7bfcccca328f7d0fca7b7e
Callback __init__() overrides subclass callback definitions The `__init__` method in `Callback` is: ``` def __init__(self, start=None, pretask=None, posttask=None, finish=None): self._start = start self._pretask = pretask self._posttask = posttask self._finish = finish ``` w...
diff --git a/dask/callbacks.py b/dask/callbacks.py index 55e7a5a1b..61aba8676 100644 --- a/dask/callbacks.py +++ b/dask/callbacks.py @@ -44,10 +44,14 @@ class Callback(object): """ def __init__(self, start=None, pretask=None, posttask=None, finish=None): - self._start = start - self._pretask =...
dask__dask-11288
[ { "changes": { "added_entities": [ "dask/array/core.py:_as_dtype" ], "added_modules": [ "dask/array/core.py:_as_dtype" ], "edited_entities": [ "dask/array/core.py:asarray", "dask/array/core.py:asanyarray" ], "edited_modules": [ "d...
dask/dask
1ba9c5bf9d0b005b89a04804f29c16e5f0f2dadf
BUG: `array.asarray` does not respect `dtype` arg **Describe the issue**: `dask.array.asarray` does not respect the `dtype` argument. **Minimal Complete Verifiable Example**: ```python >>> import numpy as np >>> import dask.array as da >>> Zm = da.asarray([[1, 2, 3]]) >>> Zm dask.array<array, shape=(1, 3...
diff --git a/dask/array/core.py b/dask/array/core.py index b710fe491..3009dcb11 100644 --- a/dask/array/core.py +++ b/dask/array/core.py @@ -4524,6 +4524,13 @@ def retrieve_from_ooc( return load_dsk +def _as_dtype(a, dtype): + if dtype is None: + return a + else: + return a.astype(dtype) + ...
dask__dask-11291
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/_shuffle.py:shuffle", "dask/array/_shuffle.py:_shuffle" ], "edited_modules": [ "dask/array/_shuffle.py:shuffle", "dask/array/_shuffle.py:_shuffle" ] ...
dask/dask
33f07ecf403a8aa452bf6a9829a8fa72cec142a5
Ensure that array-shuffle with range-like full indexer is a no-op Assume ``` arr = da.from_array(...) arr.shuffle(indexer) ``` where the flattened indexer is basically ``` list(range(0, len(are)) ``` where the sub-lists also match the chunk structure This should be a no-op. This is unlikely to be tr...
diff --git a/dask/array/_shuffle.py b/dask/array/_shuffle.py index 89f435d7b..6e3dd2e4a 100644 --- a/dask/array/_shuffle.py +++ b/dask/array/_shuffle.py @@ -71,6 +71,9 @@ def shuffle(x, indexer: list[list[int]], axis): out_name = f"shuffle-{token}" chunks, layer = _shuffle(x.chunks, indexer, axis, x.name, o...
dask__dask-11300
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/_shuffle.py:concatenate_arrays" ], "edited_modules": [ "dask/array/_shuffle.py:concatenate_arrays" ] }, "file": "dask/array/_shuffle.py" }, { "change...
dask/dask
1ba9c5bf9d0b005b89a04804f29c16e5f0f2dadf
`2024.08.0` array slicing does not preserve masks <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrocklin.com/blog/work/2018/02/2...
diff --git a/dask/array/_shuffle.py b/dask/array/_shuffle.py index 37aacb4bb..89f435d7b 100644 --- a/dask/array/_shuffle.py +++ b/dask/array/_shuffle.py @@ -8,6 +8,7 @@ import numpy as np from dask import config from dask.array.chunk import getitem from dask.array.core import Array, unknown_chunk_message +from dask....
dask__dask-11301
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/_shuffle.py:concatenate_arrays" ], "edited_modules": [ "dask/array/_shuffle.py:concatenate_arrays" ] }, "file": "dask/array/_shuffle.py" }, { "change...
dask/dask
1ba9c5bf9d0b005b89a04804f29c16e5f0f2dadf
Dask 2024.8 started failing when indexing result of numpy.flatnonzero <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrocklin.com...
diff --git a/dask/array/_shuffle.py b/dask/array/_shuffle.py index 37aacb4bb..89f435d7b 100644 --- a/dask/array/_shuffle.py +++ b/dask/array/_shuffle.py @@ -8,6 +8,7 @@ import numpy as np from dask import config from dask.array.chunk import getitem from dask.array.core import Array, unknown_chunk_message +from dask....
dask__dask-11303
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/order.py:order" ], "edited_modules": [ "dask/order.py:order" ] }, "file": "dask/order.py" } ]
dask/dask
67b2852d5f48d46527e3ac9c78122b483aef4057
order: dask order returns suboptimal ordering for xr.rechunk().groupby().reduce("cohorts") @fjetter and I looked into a problematic pattern for xarray this morning and identified that dask order is missbehaving here. dask order is currently returning a suboptimal execution order for the pattern: ``` xarr =. ... ...
diff --git a/dask/order.py b/dask/order.py index 4de05c2b4..62fb678b2 100644 --- a/dask/order.py +++ b/dask/order.py @@ -208,6 +208,9 @@ def order( _sort_keys_cache: dict[Key, tuple[int, int, int, int, str]] = {} + leafs_connected_to_loaded_roots: set[Key] = set() + processed_roots = set() + def sor...
dask__dask-11354
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "dask/_compatibility.py" }, { "changes": { "added_entities": [ "dask/array/core.py:_convert_int_chunk_to_tuple", "dask/array/core...
dask/dask
31d57d34c1c72c551200355a738bf6cf1b1aed78
Improve how normalize_chunks selects chunk sizes if auto is given Specifying auto for a dimension when new chunks are selected like in rechunking allows us to choose a chunk size that we think is a good fit and efficient. This is for now an issue to collect thoughts from others and feedback, I am pretty sure that I...
diff --git a/continuous_integration/environment-mindeps-optional.yaml b/continuous_integration/environment-mindeps-optional.yaml index efb422182..6681cc765 100644 --- a/continuous_integration/environment-mindeps-optional.yaml +++ b/continuous_integration/environment-mindeps-optional.yaml @@ -16,7 +16,7 @@ dependencies:...
dask__dask-11393
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/dataframe/utils.py:check_matching_columns" ], "edited_modules": [ "dask/dataframe/utils.py:check_matching_columns" ] }, "file": "dask/dataframe/utils.py" } ]
dask/dask
e71d4361a57e7990e4a325021e6382877ac9ab49
"Order of columns does not match" error should give an extra info about expected order It is not clear what order we should provide when we see the error "Order of columns does not match": ```python import pandas as pd import dask.dataframe as dd data = { 'id': [1, 1, 1, 2, 2, 2], 'date': pd.to_datetime...
diff --git a/.github/workflows/update-gpuci.yml b/.github/workflows/update-gpuci.yml index b657cb091..bb8c55456 100644 --- a/.github/workflows/update-gpuci.yml +++ b/.github/workflows/update-gpuci.yml @@ -21,7 +21,7 @@ jobs: - name: Get latest cuDF nightly version id: cudf_latest - uses: jacobt...
dask__dask-11437
[ { "changes": { "added_entities": [ "dask/_task_spec.py:GraphNode.dependencies" ], "added_modules": null, "edited_entities": [ "dask/_task_spec.py:Alias.__init__", "dask/_task_spec.py:Alias.dependencies", "dask/_task_spec.py:DataNode.__init__", "das...
dask/dask
786e8f0de0ff1e69b92c28ce3f70c62d640a6294
Deprecate legacy DataFrame implementation We haven't done anything on the old implementation in a while and bugs are only fixed for the new one. I.e. the old version is not compatible with newer pandas releases and will break horribly with pandas 3 for example. I think we should deprecate the mode and remove in a fe...
diff --git a/continuous_integration/environment-3.12.yaml b/continuous_integration/environment-3.12.yaml index 55542bd03..9c9cf358d 100644 --- a/continuous_integration/environment-3.12.yaml +++ b/continuous_integration/environment-3.12.yaml @@ -71,6 +71,7 @@ dependencies: - python-xxhash - mmh3 - jinja2 + - m...
dask__dask-11441
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/base.py:visualize_dsk" ], "edited_modules": [ "dask/base.py:visualize_dsk" ] }, "file": "dask/base.py" }, { "changes": { "added_entities": null, ...
dask/dask
8eac2fa9931a206f3b80e06681e9768423c588f8
Make it easier to enable linear fusion for delayed objects Delayed can be used to express embarrassingly parallel chains of operations. Certain configurations benefit from processing one chain completely before starting a new one (high memory usage for example). This is currently not possible by default because other t...
diff --git a/continuous_integration/environment-3.12.yaml b/continuous_integration/environment-3.12.yaml index 55542bd03..9c9cf358d 100644 --- a/continuous_integration/environment-3.12.yaml +++ b/continuous_integration/environment-3.12.yaml @@ -71,6 +71,7 @@ dependencies: - python-xxhash - mmh3 - jinja2 + - m...
dask__dask-11450
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/_task_spec.py:Alias.__repr__", "dask/_task_spec.py:Task.__init__", "dask/_task_spec.py:Task.__repr__", "dask/_task_spec.py:execute_graph" ], "edited_modules": [ ...
dask/dask
017adfb1794cd3debef0b7a4b0e8b6a587da8531
Slicing an Array with full slices along every dimension should just map the keys ``` ds = xr.open_zarr( "gs://weatherbench2/datasets/era5/1959-2023_01_10-wb13-6h-1440x721.zarr", #consolidated=True ) ds = ds[variables].sel(time=slice("2020-01-01", "2022-12-31")) ``` The dataset has one point per chunk a...
diff --git a/dask/_task_spec.py b/dask/_task_spec.py index 3b563aced..a319ac865 100644 --- a/dask/_task_spec.py +++ b/dask/_task_spec.py @@ -84,7 +84,7 @@ from typing import Any, TypeVar, cast, overload from dask.sizeof import sizeof from dask.typing import Key as KeyType -from dask.utils import is_namedtuple_insta...
dask__dask-11464
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/_task_spec.py:convert_legacy_task", "dask/_task_spec.py:convert_legacy_graph", "dask/_task_spec.py:resolve_aliases", "dask/_task_spec.py:Task.__repr__", "dask/_task_...
dask/dask
a0783a8d46ffa0203906c47c7495a7e5bc09e691
einsum needs more memory when chunking the tensor <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrocklin.com/blog/work/2018/02/2...
diff --git a/dask/_task_spec.py b/dask/_task_spec.py index e02e6cbb1..a79ceb35c 100644 --- a/dask/_task_spec.py +++ b/dask/_task_spec.py @@ -272,7 +272,10 @@ def convert_legacy_task( try: if isinstance(task, (bytes, int, float, str, tuple)): if task in all_keys: - return Alias(...
dask__dask-11479
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/core.py:store" ], "edited_modules": [ "dask/array/core.py:store" ] }, "file": "dask/array/core.py" }, { "changes": { "added_entities": null, ...
dask/dask
b5ed6c5529c347a210cda856f6cf9f1609203e2a
xarray.rolling().construct() and sliding_window_view chunking behaviour Using ``.rolling().construct()`` will inject new dimensions into an array with ``sliding_window_view`` under the hood. NumPy is clever about this by arranging things to be a view of the underlying array and thus not increasing the memory footprint....
diff --git a/dask/array/core.py b/dask/array/core.py index 3065406a9..b288d7d2d 100644 --- a/dask/array/core.py +++ b/dask/array/core.py @@ -1111,6 +1111,7 @@ def store( regions: tuple[slice, ...] | Collection[tuple[slice, ...]] | None = None, compute: bool = True, return_stored: bool = False, + load_...
dask__dask-1150
[ { "changes": { "added_entities": [ "dask/array/random.py:RandomState.multinomial" ], "added_modules": null, "edited_entities": [ "dask/array/random.py:RandomState._wrap" ], "edited_modules": [ "dask/array/random.py:RandomState" ] }, "file...
dask/dask
71e3e413d6e00942de3ff32a3ba378408f2648e9
Multinomial random generator `dask/array/random.py` is missing a multinomial random generator (there is aplaceholder `# multinomial`). Will dask have a multinomial random generator at some point? Does it require a significantly different approach than the other generators?
diff --git a/dask/array/random.py b/dask/array/random.py index 71050b304..9a1b0b364 100644 --- a/dask/array/random.py +++ b/dask/array/random.py @@ -44,8 +44,13 @@ class RandomState(object): self._numpy_state.seed(seed) def _wrap(self, func, *args, **kwargs): + """ Wrap numpy random function to p...
dask__dask-1152
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/core.py:asarray", "dask/array/core.py:is_scalar_for_elemwise", "dask/array/core.py:elemwise" ], "edited_modules": [ "dask/array/core.py:asarray", "...
dask/dask
472ce70b9c19a075764f7614e884b2afc14c44cb
Array astype breaks when given a type instead of a dtype object The code below fails in dask 0.9.0, numpy 1.11.0, toolz 0.7.4, Python 2.7: ```py import numpy as np import dask.array as da a = np.arange(5).astype(np.int32) d = da.from_array(a, (1,)) print(d.dtype) e = d.astype(np.int16) print(e.dtype) print(e...
diff --git a/dask/array/core.py b/dask/array/core.py index a82f73979..2cf8f9573 100644 --- a/dask/array/core.py +++ b/dask/array/core.py @@ -2062,7 +2062,7 @@ def asarray(array): """ if not isinstance(array, Array): name = 'asarray-' + tokenize(array) - if not hasattr(array, 'shape'): + ...
dask__dask-11541
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/core.py:from_zarr" ], "edited_modules": [ "dask/array/core.py:from_zarr" ] }, "file": "dask/array/core.py" }, { "changes": { "added_entities": ...
dask/dask
5b115c4360fec6a4aa6e0edf8ad1d89a87c986dd
bug in dask.array.reshape_blockwise **Minimal Complete Verifiable Example**: ```python import dask.array reshape_blockwise(dask.array.ones((3,)), shape=(3,), chunks=((3,),)) ``` ``` ValueError: Setting chunks is not allowed when reducing the number of dimensions. ``` cc @phofl
diff --git a/dask/array/core.py b/dask/array/core.py index 10736af6f..0a7ebeb1b 100644 --- a/dask/array/core.py +++ b/dask/array/core.py @@ -3754,9 +3754,9 @@ def from_zarr( store = zarr.storage.FSStore(url, **storage_options) else: store = url - z = zarr.open_array(store=s...
dask__dask-11605
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/_task_spec.py:parse_input", "dask/_task_spec.py:NestedContainer.__init__", "dask/_task_spec.py:NestedContainer.to_container" ], "edited_modules": [ "dask/_task_s...
dask/dask
44c75d08f6b693c53315c7926b5681af33696f5d
map_overlap fails if any chunk is smaler than overlap <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrocklin.com/blog/work/2018/...
diff --git a/dask/_task_spec.py b/dask/_task_spec.py index 316f1805a..438fdc3c6 100644 --- a/dask/_task_spec.py +++ b/dask/_task_spec.py @@ -84,7 +84,7 @@ _anom_count = itertools.count() def parse_input(obj: Any) -> object: """Tokenize user input into GraphNode objects - Note: This is similar to `convert_old...
dask__dask-11608
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/_task_spec.py:parse_input", "dask/_task_spec.py:NestedContainer.__init__", "dask/_task_spec.py:NestedContainer.to_container" ], "edited_modules": [ "dask/_task_s...
dask/dask
24c492095a791696ce6611e9d2294274f4592911
`NestedContainer.to_container` method gets tracked individually per NestedContainer object Looking into https://github.com/dask/distributed/issues/8958, I've noticed that for each `NestedContainer` object, its bound `to_container` method is tracked individually by the GC. This accounts for ~500k of 9MM objects in my wo...
diff --git a/dask/_task_spec.py b/dask/_task_spec.py index 316f1805a..438fdc3c6 100644 --- a/dask/_task_spec.py +++ b/dask/_task_spec.py @@ -84,7 +84,7 @@ _anom_count = itertools.count() def parse_input(obj: Any) -> object: """Tokenize user input into GraphNode objects - Note: This is similar to `convert_old...
dask__dask-11609
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/_shuffle.py:_shuffle" ], "edited_modules": [ "dask/array/_shuffle.py:_shuffle" ] }, "file": "dask/array/_shuffle.py" }, { "changes": { "added_e...
dask/dask
076b1f4d59283709127e5f7fe3b0c045127b7a92
Xarray to_dask_dataframe consume more memory on V2024.12.0 compared to V2024.10.0 <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthe...
diff --git a/dask/array/_shuffle.py b/dask/array/_shuffle.py index 2c926d317..5851a4a99 100644 --- a/dask/array/_shuffle.py +++ b/dask/array/_shuffle.py @@ -220,7 +220,7 @@ def _shuffle(chunks, indexer, axis, in_name, out_name, token): intermediates = dict() merges = dict() - dtype = np.min_scalar_type(m...
dask__dask-11611
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/core.py:_should_delegate", "dask/array/core.py:_vindex_array" ], "edited_modules": [ "dask/array/core.py:_should_delegate", "dask/array/core.py:_vindex_arr...
dask/dask
fe465e055293851a1920bd9a318c92d1953a8b65
Dask Array does not yield binary operator priority when used with another type with higher `__array_priority__` <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Min...
diff --git a/continuous_integration/environment-3.10.yaml b/continuous_integration/environment-3.10.yaml index 7e7f8a514..12719c0e2 100644 --- a/continuous_integration/environment-3.10.yaml +++ b/continuous_integration/environment-3.10.yaml @@ -18,6 +18,7 @@ dependencies: - pre-commit - pytest - pytest-cov + ...
dask__dask-11622
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/core.py:auto_chunks" ], "edited_modules": [ "dask/array/core.py:auto_chunks" ] }, "file": "dask/array/core.py" } ]
dask/dask
16b986ef23302dd8179605c973b7744dcdcd5f13
Rechunking an array of specic shape with dtype float32 using `chunks='auto'` creates chunks of size 0 <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug ...
diff --git a/dask/array/core.py b/dask/array/core.py index 7dfff2b0f..898f5a33e 100644 --- a/dask/array/core.py +++ b/dask/array/core.py @@ -3329,7 +3329,8 @@ def auto_chunks(chunks, shape, limit, dtype, previous_chunks=None): new_chunk += c else: ...
dask__dask-11628
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/core.py:_vindex_array" ], "edited_modules": [ "dask/array/core.py:_vindex_array" ] }, "file": "dask/array/core.py" }, { "changes": { "added_ent...
dask/dask
4fb8993ce15831c03ff21575db7fd3acdcac9ebe
einsum's auto-rechunking can drastically overestimate output chunk size <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrocklin.c...
diff --git a/dask/array/core.py b/dask/array/core.py index c2f303c69..4c96f09f1 100644 --- a/dask/array/core.py +++ b/dask/array/core.py @@ -23,8 +23,7 @@ from typing import Any, Literal, TypeVar, Union, cast import numpy as np from numpy.typing import ArrayLike from packaging.version import Version -from tlz import...
dask__dask-11698
[ { "changes": { "added_entities": [ "dask/dataframe/dask_expr/_reductions.py:ValueCounts.shuffle_by_index" ], "added_modules": null, "edited_entities": [ "dask/dataframe/dask_expr/_reductions.py:ValueCounts.split_by" ], "edited_modules": [ "dask/datafra...
dask/dask
d8eb38e97db5a83d893b178a2bb8ec7c34bd8f29
`.value_counts()` failed to aggregate across partitions <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrocklin.com/blog/work/2018/02...
diff --git a/dask/dataframe/dask_expr/_reductions.py b/dask/dataframe/dask_expr/_reductions.py index 5b5f248dd..5ba667896 100644 --- a/dask/dataframe/dask_expr/_reductions.py +++ b/dask/dataframe/dask_expr/_reductions.py @@ -1427,6 +1427,7 @@ class ValueCounts(ReductionConstantDim): reduction_chunk = M.value_count...
dask__dask-11699
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "dask/array/slicing.py:slice_with_newaxes" ], "edited_modules": [ "dask/array/slicing.py:slice_with_newaxes" ] }, "file": "dask/array/slicing.py" }, { "changes":...
dask/dask
d8eb38e97db5a83d893b178a2bb8ec7c34bd8f29
Array slicing with boolean mask and `np.newaxis` stopped working at some point <!-- Please include a self-contained copy-pastable example that generates the issue if possible. Please be concise with code posted. See guidelines below on how to provide a good bug report: - Craft Minimal Bug Reports http://matthewrockli...
diff --git a/dask/array/slicing.py b/dask/array/slicing.py index 0927e2613..473c42646 100644 --- a/dask/array/slicing.py +++ b/dask/array/slicing.py @@ -12,7 +12,7 @@ import numpy as np from tlz import concat, memoize, merge, pluck from dask import core -from dask._task_spec import Alias, Task, TaskRef +from dask._...