instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
elastic__elasticsearch-dsl-py-1459 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch_dsl/query.py:Bool.__invert__"
],
"edited_modules": [
"elasticsearch_dsl/query.py:Bool"
]
},
"file": "elasticsearch_dsl/query.py"
}
] | elastic/elasticsearch-dsl-py | 99b787cc9d013f9e6ba4c9a7ad7f55e387fb0df0 | ~Bool() should return MatchNone()
`Bool()` is the same as `MatchAll()` so inversion should have the same effect and result in `MatchNone()` | diff --git a/elasticsearch_dsl/query.py b/elasticsearch_dsl/query.py
index 48b6ba7..cedd0a7 100644
--- a/elasticsearch_dsl/query.py
+++ b/elasticsearch_dsl/query.py
@@ -180,6 +180,11 @@ class Bool(Query):
)
def __invert__(self):
+ # Because an empty Bool query is treated like
+ # MatchAll ... |
elastic__elasticsearch-dsl-py-1463 | [
{
"changes": {
"added_entities": [
"elasticsearch_dsl/response/__init__.py:UpdateByQueryResponse.success"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"elasticsearch_dsl/response/__init__.py:UpdateByQueryResponse"
]
},
"file":... | elastic/elasticsearch-dsl-py | f856f5dc400de065646bf42d2014dab73ee7ad52 | Wrong information on docs for UpdateByQueryResponse
Docs for `UpdateByQuery` shows that is possible to check the response status with `response.success()`
```python
response = ubq.execute()
print(response.success())
# True
print(response.took)
# 12
```
But when trying to reproduce it raises the foll... | diff --git a/elasticsearch_dsl/response/__init__.py b/elasticsearch_dsl/response/__init__.py
index d35decb..022ab15 100644
--- a/elasticsearch_dsl/response/__init__.py
+++ b/elasticsearch_dsl/response/__init__.py
@@ -113,3 +113,6 @@ class UpdateByQueryResponse(AttrDict):
super(AttrDict, self).__setattr__("_sea... |
elastic__elasticsearch-dsl-py-1464 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/query.py:ScriptScore"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/query.py"
}
] | elastic/elasticsearch-dsl-py | 3e5703f0c8f6f682c7eea3db9413470876cb254f | script_score not working
Using `script_score` throws `ValueError(Q() can only accept dict with a single query...`
```json
{
"query": {
"script_score": {
"query": {
"match_all": {}
},
"script": {
"source": """
double weight = 1;
if (doc['type'].val... | diff --git a/elasticsearch_dsl/query.py b/elasticsearch_dsl/query.py
index cedd0a7..642ce2c 100644
--- a/elasticsearch_dsl/query.py
+++ b/elasticsearch_dsl/query.py
@@ -499,6 +499,11 @@ class Script(Query):
name = "script"
+class ScriptScore(Query):
+ name = "script_score"
+ _param_defs = {"query": {"typ... |
elastic__elasticsearch-dsl-py-1467 | [
{
"changes": {
"added_entities": [
"elasticsearch_dsl/faceted_search.py:_date_interval_month",
"elasticsearch_dsl/faceted_search.py:_date_interval_week",
"elasticsearch_dsl/faceted_search.py:_date_interval_day",
"elasticsearch_dsl/faceted_search.py:_date_interval_hour"
... | elastic/elasticsearch-dsl-py | fac8787b3e26f2e95f3b83fa38c73ddeb9c14afd | Deprecated: Using DateHistogramFacet with intervals seems to be deprecated
Hello there, first of all – thanks for all people contributing to this package.
Declaring documents and setting up faceted search works really, really nicely.
--
When experimenting with the `FacetedSearch` class and `DateHistogramFacet`, ... | diff --git a/docs/faceted_search.rst b/docs/faceted_search.rst
index c2f7e5e..bc17777 100644
--- a/docs/faceted_search.rst
+++ b/docs/faceted_search.rst
@@ -49,7 +49,7 @@ There are several different facets available:
provides an option to split documents into groups based on a value of a field, for example ``TermsFa... |
elastic__elasticsearch-dsl-py-1543 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/aggs.py:MultiTerms"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/aggs.py"
}
] | elastic/elasticsearch-dsl-py | 7874040b4f1346552a77b6f2a16321f2e1a6c722 | Add support for the multi_terms aggregation
Good day!
How can i use [multu-terms aggregation](https://www.elastic.co/guide/en/elasticsearch//reference/master/search-aggregations-bucket-multi-terms-aggregation.html#:~:text=Multi%20Terms%20aggregationedit,and%20will%20consume%20more%20memory.) ?
I have got : `elast... | diff --git a/elasticsearch_dsl/aggs.py b/elasticsearch_dsl/aggs.py
index d307164..3b55a8a 100644
--- a/elasticsearch_dsl/aggs.py
+++ b/elasticsearch_dsl/aggs.py
@@ -296,6 +296,10 @@ class VariableWidthHistogram(Bucket):
return FieldBucketData(self, search, data)
+class MultiTerms(Bucket):
+ name = "mult... |
elastic__elasticsearch-dsl-py-1557 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/query.py:CombinedFields"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/query.py"
}
] | elastic/elasticsearch-dsl-py | 620ddc84e958a42e5a212040731e3645f0f661ff | Add support for "combined_fields" query
Dear team,
could you please consider adding support to the "combind_fields" query? I could see a similar request is raised in #1512, and a PR #1534 for adding the functionality is still open.
Thanks in advance! | diff --git a/docs/search_dsl.rst b/docs/search_dsl.rst
index d76f53f..e15b1ea 100644
--- a/docs/search_dsl.rst
+++ b/docs/search_dsl.rst
@@ -445,7 +445,7 @@ A simple example is below
.. code:: python
from elasticsearch_dsl.query import MoreLikeThis
- from elasticsearch_dsl Search
+ from elasticsearch_dsl ... |
elastic__elasticsearch-dsl-py-1589 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/aggs.py:CategorizeText"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/aggs.py"
}
] | elastic/elasticsearch-dsl-py | acd63a84c1510f67fe621d10d3a79003fc6ea39c | Add support for "categorize_text" bucket aggregation
`elasticsearch_dsl/aggs.py` is missing "categorize_text" bucket aggregation. [Categorize text aggregation](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-categorize-text-aggregation.html) | diff --git a/elasticsearch_dsl/aggs.py b/elasticsearch_dsl/aggs.py
index 69c2d85..96b830e 100644
--- a/elasticsearch_dsl/aggs.py
+++ b/elasticsearch_dsl/aggs.py
@@ -309,6 +309,10 @@ class MultiTerms(Bucket):
name = "multi_terms"
+class CategorizeText(Bucket):
+ name = "categorize_text"
+
+
# metric aggrega... |
elastic__elasticsearch-dsl-py-1591 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/aggs.py:GeohexGrid"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/aggs.py"
}
] | elastic/elasticsearch-dsl-py | f091a234f67514ec05d724b735cd81620d4ee07a | Add support for "geohex_grid" bucket aggregation
`elasticsearch_dsl/aggs.py` is missing "geohex_grid" bucket aggregation which is introduced in [v8.1.0](https://www.elastic.co/guide/en/elasticsearch/reference/8.1/release-notes-8.1.0.html#feature-8.1.0). [Geohex grid aggregation](https://www.elastic.co/guide/en/elastics... | diff --git a/elasticsearch_dsl/aggs.py b/elasticsearch_dsl/aggs.py
index d9412e2..69c2d85 100644
--- a/elasticsearch_dsl/aggs.py
+++ b/elasticsearch_dsl/aggs.py
@@ -209,6 +209,10 @@ class GeohashGrid(Bucket):
name = "geohash_grid"
+class GeohexGrid(Bucket):
+ name = "geohex_grid"
+
+
class GeotileGrid(Buck... |
elastic__elasticsearch-dsl-py-1593 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/aggs.py:IPPrefix"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/aggs.py"
}
] | elastic/elasticsearch-dsl-py | 380b63b132d0e88e58395fe8f6dc10677055f622 | Add support for "ip_prefix" bucket aggregation
`elasticsearch_dsl/aggs.py` is missing "ip_prefix" bucket aggregation which is introduced in [v8.1.0](https://www.elastic.co/guide/en/elasticsearch/reference/8.1/release-notes-8.1.0.html#bug-8.1.0). [IP prefix aggregation](https://www.elastic.co/guide/en/elasticsearch/refe... | diff --git a/elasticsearch_dsl/aggs.py b/elasticsearch_dsl/aggs.py
index 962cfc3..d9412e2 100644
--- a/elasticsearch_dsl/aggs.py
+++ b/elasticsearch_dsl/aggs.py
@@ -232,6 +232,10 @@ class IPRange(Bucket):
name = "ip_range"
+class IPPrefix(Bucket):
+ name = "ip_prefix"
+
+
class Missing(Bucket):
name =... |
elastic__elasticsearch-dsl-py-1595 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/aggs.py:RandomSampler"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/aggs.py"
}
] | elastic/elasticsearch-dsl-py | 619daa1c28e687eab539ae3a052a53f9fb66fe07 | Add support for "random_sampler" bucket aggregation
`elasticsearch_dsl/aggs.py` is missing "random_sampler" bucket aggregation which is introduced in [v8.2.0](https://www.elastic.co/guide/en/elasticsearch/reference/8.2/release-notes-8.2.0.html#feature-8.2.0). [Random sampler aggregation](https://www.elastic.co/guide/en... | diff --git a/elasticsearch_dsl/aggs.py b/elasticsearch_dsl/aggs.py
index 11612fb..962cfc3 100644
--- a/elasticsearch_dsl/aggs.py
+++ b/elasticsearch_dsl/aggs.py
@@ -278,6 +278,10 @@ class DiversifiedSampler(Bucket):
name = "diversified_sampler"
+class RandomSampler(Bucket):
+ name = "random_sampler"
+
+
cl... |
elastic__elasticsearch-dsl-py-1629 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/aggs.py:GeoLine"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/aggs.py"
}
] | elastic/elasticsearch-dsl-py | 35646106563a1bbd58cedc5d8a3b73363c8760b7 | Add support for "geo_line" metrics aggregation
`elasticsearch_dsl/aggs.py` is missing "geo_line" metrics aggregation which is introduced in v7.11.0. [Geo-Line aggregation](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-geo-line.html) | diff --git a/elasticsearch_dsl/aggs.py b/elasticsearch_dsl/aggs.py
index 61a27f3..11612fb 100644
--- a/elasticsearch_dsl/aggs.py
+++ b/elasticsearch_dsl/aggs.py
@@ -329,6 +329,10 @@ class GeoBounds(Agg):
name = "geo_bounds"
+class GeoLine(Agg):
+ name = "geo_line"
+
+
class Max(Agg):
name = "max"
|
elastic__elasticsearch-dsl-py-1631 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/aggs.py:MatrixStats"
],
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/aggs.py"
}
] | elastic/elasticsearch-dsl-py | 6cfbbe1a5d8bab6790b5299bcdfd84bef026edb2 | Add support for "matrix_stats" metrics aggregation
`elasticsearch_dsl/aggs.py` is missing "matrix_stats" metrics aggregation. [Matrix stats aggregation](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-matrix-stats-aggregation.html) | diff --git a/elasticsearch_dsl/aggs.py b/elasticsearch_dsl/aggs.py
index 8f91333..61a27f3 100644
--- a/elasticsearch_dsl/aggs.py
+++ b/elasticsearch_dsl/aggs.py
@@ -333,6 +333,10 @@ class Max(Agg):
name = "max"
+class MatrixStats(Agg):
+ name = "matrix_stats"
+
+
class MedianAbsoluteDeviation(Agg):
na... |
elastic__elasticsearch-dsl-py-1634 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch_dsl/utils.py:DslBase.__init__"
],
"edited_modules": [
"elasticsearch_dsl/utils.py:DslBase"
]
},
"file": "elasticsearch_dsl/utils.py"
}
] | elastic/elasticsearch-dsl-py | 0c0bdb786ba87753f632e279b0866b7fdd5b7837 | Expand__to_dot variable cannot be used to control the behavior
Hello,
This pull request: https://github.com/elastic/elasticsearch-dsl-py/pull/809 moved the default for _expand__to_dot to a variable.
At load time, the default for _expand__to_dot will already be set to True. Overwriting EXPAND__TO_DOT after the impor... | diff --git a/elasticsearch_dsl/utils.py b/elasticsearch_dsl/utils.py
index c362838..3b231d2 100644
--- a/elasticsearch_dsl/utils.py
+++ b/elasticsearch_dsl/utils.py
@@ -252,7 +252,9 @@ class DslBase(metaclass=DslMeta):
f"DSL class `{name}` does not exist in {cls._type_name}."
)
- def ... |
elastic__elasticsearch-dsl-py-1691 | [
{
"changes": {
"added_entities": [
"elasticsearch_dsl/search.py:Search.knn"
],
"added_modules": null,
"edited_entities": [
"elasticsearch_dsl/search.py:Search.__init__",
"elasticsearch_dsl/search.py:Search._clone",
"elasticsearch_dsl/search.py:Search.updat... | elastic/elasticsearch-dsl-py | f0c504538f19d3d70e2fb7d6402071f5fbaafc90 | Does elasticsearch-dsl-py support knn_search?
Great to see that this package now supports 8+ versions of Elasticsearch ❤️
However, when perusing the documentation, I am not yet seeing explicit support to [knn_search similar to the lower-level python client](https://elasticsearch-py.readthedocs.io/en/latest/api.html... | diff --git a/docs/search_dsl.rst b/docs/search_dsl.rst
index 5912f82..2dc1388 100644
--- a/docs/search_dsl.rst
+++ b/docs/search_dsl.rst
@@ -14,6 +14,8 @@ The ``Search`` object represents the entire search request:
* aggregations
+ * k-nearest neighbor searches
+
* sort
* pagination
@@ -352,6 +354,31 @@... |
elastic__elasticsearch-dsl-py-1914 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch_dsl/field.py:Date._deserialize"
],
"edited_modules": [
"elasticsearch_dsl/field.py:Date"
]
},
"file": "elasticsearch_dsl/field.py"
}
] | elastic/elasticsearch-dsl-py | 8a72af97b071d0bf08aaf857289135aedc776924 | Dates get casted to datetimes on retrieved objects, causing parsing errors during updates
I have the following document class, along with a helper method that adapts objects from our existing SQL database:
```python
class EsIdCard(InnerDoc):
id: int
card_number: str
expiration_date: date
@staticmethod... | diff --git a/elasticsearch_dsl/field.py b/elasticsearch_dsl/field.py
index 26f2336..d992ecc 100644
--- a/elasticsearch_dsl/field.py
+++ b/elasticsearch_dsl/field.py
@@ -315,6 +315,9 @@ class Date(Field):
raise ValidationException(
f"Could not parse date from the value ({data!r})", ... |
elastic__elasticsearch-dsl-py-585 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch_dsl/index.py:Index.clone"
],
"edited_modules": [
"elasticsearch_dsl/index.py:Index"
]
},
"file": "elasticsearch_dsl/index.py"
},
{
"changes": {
... | elastic/elasticsearch-dsl-py | d291eb55ef01f6bfa02835dcfd90276d5cd8871e | Index.clone() does not copy Index._analysis
I am not sure if it's intended or not but `Index.clone()` does not copy `_analysis` attribute. | diff --git a/elasticsearch_dsl/index.py b/elasticsearch_dsl/index.py
index 3d6af0e..9237377 100644
--- a/elasticsearch_dsl/index.py
+++ b/elasticsearch_dsl/index.py
@@ -31,7 +31,8 @@ class Index(object):
:arg using: connection alias to use, defaults to ``'default'``
"""
i = Index(name, using=... |
elastic__elasticsearch-dsl-py-603 | [
{
"changes": {
"added_entities": [
"elasticsearch_dsl/aggs.py:Agg.__contains__",
"elasticsearch_dsl/aggs.py:AggBase.__contains__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"elasticsearch_dsl/aggs.py:Agg",
"elasticsearch_d... | elastic/elasticsearch-dsl-py | 7c1dad0f99957db9ebb9bfe10cf72cf1a8ec3fb3 | TypeError unhashable type: 'list'
```
client = Search(using=haystack_connections['default'].get_backend().conn, index='haystack', doc_type='modelresult')
query = \
{
"size": 0,
"query" : {
"constant_score": {
"filter": [
... | diff --git a/.travis.yml b/.travis.yml
index f6456d7..88ce371 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -16,6 +16,10 @@ python:
- "3.3"
- "3.4"
- "3.5"
+ - "3.6"
+ - "3.6-dev"
+ - "3.7-dev"
+ - "nightly"
env:
global:
diff --git a/docs/index.rst b/docs/index.rst
index d19c3ae..6db9555 100644
--- a... |
elastic__elasticsearch-dsl-py-674 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": [
"elasticsearch_dsl/aggs.py:IPRange"
... | elastic/elasticsearch-dsl-py | 7c7a8d486877a25f53e226a1a00f900dfebf43cb | Error with DateHistogramFacet, bucket['key'] is None instead of int()
I am using Doctype with Date() field. When I want to use DateHistogramFacet I get this error:
`TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'`
Error is raised in file faceted_search.py in DateHistogra... | diff --git a/.gitignore b/.gitignore
index 4d5d0eb..d08fec9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,3 +12,4 @@ test_elasticsearch_dsl/htmlcov
docs/_build
.cache
venv
+.idea
diff --git a/Changelog.rst b/Changelog.rst
index 8aa4e7b..d35153a 100644
--- a/Changelog.rst
+++ b/Changelog.rst
@@ -3,6 +3,12 @@
Chang... |
elastic__elasticsearch-dsl-py-752 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch_dsl/analysis.py:CustomAnalysis.__init__"
],
"edited_modules": [
"elasticsearch_dsl/analysis.py:CustomAnalysis"
]
},
"file": "elasticsearch_dsl/analysis.py... | elastic/elasticsearch-dsl-py | 269fef7fa12333f7622c3694df75a1b296d87ae2 | Datetimes dropping miliseconds
The problems causes dates like '1970-01-01T00:17:47.045Z' in ElasticSearch to end up as a datetime like
datetime.datetime(1970, 1, 1, 0, 17, 47)
My expectation is that this value should produce a d... | diff --git a/elasticsearch_dsl/analysis.py b/elasticsearch_dsl/analysis.py
index 8424283..c2abd94 100644
--- a/elasticsearch_dsl/analysis.py
+++ b/elasticsearch_dsl/analysis.py
@@ -19,9 +19,9 @@ class AnalysisBase(object):
class CustomAnalysis(object):
name = 'custom'
- def __init__(self, name, builtin_type=... |
elastic__elasticsearch-dsl-py-759 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch_dsl/analysis.py:CustomAnalysis.__init__"
],
"edited_modules": [
"elasticsearch_dsl/analysis.py:CustomAnalysis"
]
},
"file": "elasticsearch_dsl/analysis.py... | elastic/elasticsearch-dsl-py | 269fef7fa12333f7622c3694df75a1b296d87ae2 | Can't create custom stemming filter
The stemming filter, requires the use a property called `name`, however the the library is using this property.
(https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-stemmer-tokenfilter.html)
This code
```python
light_stemmer_ = token_filter(name="min... | diff --git a/elasticsearch_dsl/analysis.py b/elasticsearch_dsl/analysis.py
index 8424283..c2abd94 100644
--- a/elasticsearch_dsl/analysis.py
+++ b/elasticsearch_dsl/analysis.py
@@ -19,9 +19,9 @@ class AnalysisBase(object):
class CustomAnalysis(object):
name = 'custom'
- def __init__(self, name, builtin_type=... |
elastic__elasticsearch-dsl-py-795 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch_dsl/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edit... | elastic/elasticsearch-dsl-py | 1cb17a0be2cf48c5e4cf5df9ef55d5fc1a202f18 | Search does not support unicode indices
In elasticsearch_dsl/search.py, the `index` function checks to see if the arguments are of type `str` before appending them to the list of search indices. On Python 2, this test fails for unicode strings.
Instead, we can use `six.string_types` for Python 2 and 3 compatibility.... | diff --git a/Changelog.rst b/Changelog.rst
index f29287b..f001879 100644
--- a/Changelog.rst
+++ b/Changelog.rst
@@ -3,13 +3,39 @@
Changelog
=========
-5.4.0 (dev)
+6.0.0 (dev)
-----------
+
+Release compatible with elasticsearch 6.0, changes include:
+
+ * use ``doc`` as default ``DocType`` name, this change incl... |
elastic__elasticsearch-py-1048 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch/connection/base.py:Connection.__eq__"
],
"edited_modules": [
"elasticsearch/connection/base.py:Connection"
]
},
"file": "elasticsearch/connection/base.py"... | elastic/elasticsearch-py | fc78c992ef6ceca157f369186760c8c550fb3bc4 | mark_dead() in ConnectionPool always removes the first connection in the pool
`ConnectionPool`'s `mark_dead()` method is supposed to remove the dead `connection` from the `connections` list:
`self.connections.remove(connection)`
However the equality comparison implementation `__eq__` in the `Connection` class is ... | diff --git a/elasticsearch/connection/base.py b/elasticsearch/connection/base.py
index 8bb93a4b..a3fbd780 100644
--- a/elasticsearch/connection/base.py
+++ b/elasticsearch/connection/base.py
@@ -65,7 +65,7 @@ class Connection(object):
raise TypeError(
"Unsupported equality check for %s and... |
elastic__elasticsearch-py-1117 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch/connection/http_urllib3.py:Urllib3HttpConnection.__init__"
],
"edited_modules": [
"elasticsearch/connection/http_urllib3.py:Urllib3HttpConnection"
]
},
"f... | elastic/elasticsearch-py | 1a1ab99d9a2b0825f5c23db6aedcce75d4cbf794 | A wrong warning is shown when creating a secured elasticsearch ssl (since 7.5.0)
**Elasticsearch version** not relevant:
**`elasticsearch-py` version 7.5.1**:
**When creating a secured elasticsearch ssl connection a warning is shown**:
```
http_urllib3.py:148: UserWarning: When using `ssl_context`, all other S... | diff --git a/elasticsearch/connection/http_urllib3.py b/elasticsearch/connection/http_urllib3.py
index 90292852..6543e0e0 100644
--- a/elasticsearch/connection/http_urllib3.py
+++ b/elasticsearch/connection/http_urllib3.py
@@ -7,10 +7,11 @@ import warnings
import gzip
from base64 import decodestring
-# sentinal val... |
elastic__elasticsearch-py-1387 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "elasticsearch/compat.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearc... | elastic/elasticsearch-py | 852d7730e7d56ea45336da42dad161e80f75b8dc | support for Optimistic concurrency control
<!-- Feature request -->
**When will this project support Optimistic concurrency control in `elasticsearch.helpers.bulk` operation, or has this project already support this feature? **
| diff --git a/elasticsearch/compat.py b/elasticsearch/compat.py
index af77c5d0..c5322b56 100644
--- a/elasticsearch/compat.py
+++ b/elasticsearch/compat.py
@@ -32,6 +32,12 @@ else:
map = map
from queue import Queue
+try:
+ from collections.abs import Mapping
+except ImportError:
+ from collections impo... |
elastic__elasticsearch-py-2427 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch/_sync/client/utils.py:_merge_body_fields_no_duplicates",
"elasticsearch/_sync/client/utils.py:_rewrite_parameters"
],
"edited_modules": [
"elasticsearch/_sync/c... | elastic/elasticsearch-py | 7d4a34b6e3ceceb82396be62682b7e8623c72665 | elasticsearch-py 8.12 breaks the use of `from_` in body parameters
This bug was initially reported in the [Elastic Community Slack](https://www.elastic.co/blog/join-our-elastic-stack-workspace-on-slack). But first, come context.
## Context
Since the early days of the Elasticsearch Python client, [back in July 201... | diff --git a/elasticsearch/_sync/client/utils.py b/elasticsearch/_sync/client/utils.py
index 4febb035..1d1a983a 100644
--- a/elasticsearch/_sync/client/utils.py
+++ b/elasticsearch/_sync/client/utils.py
@@ -298,7 +298,8 @@ def _merge_kwargs_no_duplicates(kwargs: Dict[str, Any], values: Dict[str, Any])
def _merge_bod... |
elastic__elasticsearch-py-569 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch/client/__init__.py:_normalize_hosts"
],
"edited_modules": [
"elasticsearch/client/__init__.py:_normalize_hosts"
]
},
"file": "elasticsearch/client/__init_... | elastic/elasticsearch-py | fe897ebe0d2167e91ea19fa9a81f448a861d58d1 | user:password in hosts are not url decoded
Hello,
If I have a character like "]" in my username or password I must urlencode it or `urlparse` will interpret the host as IPv6. Unfortunately, `urlparse` does not urldecode fragments :
```
The components are not broken up in smaller parts (for example, the network lo... | diff --git a/elasticsearch/client/__init__.py b/elasticsearch/client/__init__.py
index c735b70a..488cf8be 100644
--- a/elasticsearch/client/__init__.py
+++ b/elasticsearch/client/__init__.py
@@ -3,7 +3,7 @@ import logging
from ..transport import Transport
from ..exceptions import TransportError
-from ..compat impor... |
elastic__elasticsearch-py-618 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elasticsearch/client/__init__.py:Elasticsearch.bulk",
"elasticsearch/client/__init__.py:Elasticsearch.msearch",
"elasticsearch/client/__init__.py:Elasticsearch.msearch_template"
],... | elastic/elasticsearch-py | 0397527d12bcb43274ce9054111c5f7f673a7ad6 | Set `application/x-ndjson` content type on bulk requests
As of elastic 5.x, requests to `/_bulk` should set `Content-Type` to `application/x-ndjson`. If not, elastic logs a warning. It looks like this library defaults to `application/json`. To fix, I'm thinking we should accept an optional dict of headers at `https://g... | diff --git a/elasticsearch/client/__init__.py b/elasticsearch/client/__init__.py
index 59858549..834f1d86 100644
--- a/elasticsearch/client/__init__.py
+++ b/elasticsearch/client/__init__.py
@@ -1127,7 +1127,8 @@ class Elasticsearch(object):
if body in SKIP_IN_PATH:
raise ValueError("Empty value p... |
elastic__elasticsearch-py-628 | [
{
"changes": {
"added_entities": [
"elasticsearch/client/__init__.py:Elasticsearch.suggest",
"elasticsearch/client/__init__.py:Elasticsearch.percolate",
"elasticsearch/client/__init__.py:Elasticsearch.mpercolate",
"elasticsearch/client/__init__.py:Elasticsearch.count_percol... | elastic/elasticsearch-py | 4e6f63571105545914c07fa4846f996d6049f44b | 'bytes' object has no attribute 'encode'
File "/root/.local/share/virtualenvs/celery-jR7fJ1bi/lib/python3.5/site-packages/elasticsearch/client/utils.py", line 32, in _escape
return value.encode('utf-8')
AttributeError: 'bytes' object has no attribute 'encode'
It appears that when _escape receives v... | diff --git a/elasticsearch/client/__init__.py b/elasticsearch/client/__init__.py
index 37b74513..05a66d8c 100644
--- a/elasticsearch/client/__init__.py
+++ b/elasticsearch/client/__init__.py
@@ -238,15 +238,15 @@ class Elasticsearch(object):
:arg refresh: If `true` then refresh the affected shards to make this... |
elastic__elasticsearch-py-949 | [
{
"changes": {
"added_entities": [
"elasticsearch/client/__init__.py:Elasticsearch.update_by_query_rethrottle",
"elasticsearch/client/__init__.py:Elasticsearch.delete_by_query_rethrottle",
"elasticsearch/client/__init__.py:Elasticsearch.rank_eval",
"elasticsearch/client/__i... | elastic/elasticsearch-py | 206f5e2754b01789facc0d50dac5177444afd2f6 | .xpack.sql not wired in
the `SqlClient` is not wired into the `xpack` namespace. It is also missing from the docs. | diff --git a/elasticsearch/client/__init__.py b/elasticsearch/client/__init__.py
index 55f10bc4..d6e4ba48 100644
--- a/elasticsearch/client/__init__.py
+++ b/elasticsearch/client/__init__.py
@@ -329,6 +329,11 @@ class Elasticsearch(object):
:arg index: The name of the index
:arg body: The document
... |
elastic__rally-1284 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/async_connection.py:AIOHttpConnection.__init__"
],
"edited_modules": [
"esrally/async_connection.py:AIOHttpConnection"
]
},
"file": "esrally/async_connection.py... | elastic/rally | df8634ecd0df12cc97ed44199a1837f0e5371e61 | max_connections value is misleadingly logged prior to being overridden
<!--
If you are filing a feature request, please remove the above bug
report block and provide responses for all of the below items.
-->
**Describe the feature**:
Currently `esrally` logs the output of the `client_options` parameter at th... | diff --git a/esrally/async_connection.py b/esrally/async_connection.py
index 3609dce9..a236a96c 100644
--- a/esrally/async_connection.py
+++ b/esrally/async_connection.py
@@ -168,7 +168,7 @@ class AIOHttpConnection(elasticsearch.AIOHttpConnection):
ssl_assert_fingerprint=ssl_assert_fingerprint... |
elastic__rally-1469 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/async_connection.py:AIOHttpConnection.__init__"
],
"edited_modules": [
"esrally/async_connection.py:AIOHttpConnection"
]
},
"file": "esrally/async_connection.py... | elastic/rally | 207bb15258cdab397eea3a3e4fd4f08e50766bc5 | Should we force Rally to clean up SSL connections?
During some recent benchmarking work we discovered [that a bug in how Elasticsearch handles the closing of existing SSL connections when TLS 1.3 is used](https://github.com/elastic/elasticsearch/issues/76642) can end up manifesting itself as a memory leak in Rally, and... | diff --git a/docs/command_line_reference.rst b/docs/command_line_reference.rst
index 82bf03ea..34d79f19 100644
--- a/docs/command_line_reference.rst
+++ b/docs/command_line_reference.rst
@@ -181,7 +181,7 @@ Selects the track repository that Rally should use to resolve tracks. By default
``track-revision``
~~~~~~~~~~~... |
elastic__rally-1599 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/metrics.py:extract_user_tags_from_config"
],
"edited_modules": [
"esrally/metrics.py:extract_user_tags_from_config"
]
},
"file": "esrally/metrics.py"
},
{
... | elastic/rally | 630ede8d50a94e8c25207cf0129646ed319f0849 | Alias `--user-tags` to `--user-tag`
Rally currently supports custom user tags via the [--user-tag](https://esrally.readthedocs.io/en/stable/command_line_reference.html?highlight=user-tag#user-tag) cli option.
This doesn't convey the concept that several tags can be user.
In order to not break BWC, I suggest we add ... | diff --git a/docs/adding_tracks.rst b/docs/adding_tracks.rst
index f2e8df9b..8bd6b455 100644
--- a/docs/adding_tracks.rst
+++ b/docs/adding_tracks.rst
@@ -15,6 +15,10 @@ If you already have a cluster with data in it you can use the ``create-track`` s
esrally create-track --track=acme --target-hosts=127.0.0.1:920... |
elastic__rally-1674 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/metrics.py:EsClientFactory.__init__"
],
"edited_modules": [
"esrally/metrics.py:EsClientFactory"
]
},
"file": "esrally/metrics.py"
}
] | elastic/rally | 6915655f2ebf11311db54ebd2014c942110e77e2 | Allow .ini definable in environment variable or pass as command line runtime value instead of persisting it in .ini file
<!--
If you are filing a feature request, please remove the above bug
report block and provide responses for all of the below items.
-->
**Describe the feature**:
Currently, metrics store pa... | diff --git a/docs/configuration.rst b/docs/configuration.rst
index a3d55992..03703e0f 100644
--- a/docs/configuration.rst
+++ b/docs/configuration.rst
@@ -72,7 +72,7 @@ The following settings are applicable only if ``datastore.type`` is set to "elas
* ``datastore.ssl.verification_mode`` (default: "full"): By default t... |
elastic__rally-1828 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/supplier.py:Builder.run"
],
"edited_modules": [
"esrally/mechanic/supplier.py:Builder"
]
},
"file": "esrally/mechanic/supplier.py"
},
{
"change... | elastic/rally | 5e6b1bc869f0406024bd796b825511dc13a6d133 | Return both exit code, and output in process module
In https://github.com/elastic/rally/pull/1591 it became clear that it'd be nice to modify an existing function in our [`process` module](https://github.com/elastic/rally/blob/master/esrally/utils/process.py) to return both the stdout/stderr of the subprocess as well a... | diff --git a/esrally/mechanic/supplier.py b/esrally/mechanic/supplier.py
index d40773cb..0fa2c486 100644
--- a/esrally/mechanic/supplier.py
+++ b/esrally/mechanic/supplier.py
@@ -810,7 +810,7 @@ class Builder:
console.info("Creating installable binary from source files")
self.logger.info("Running buil... |
elastic__rally-425 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/config.py:ConfigFactory.create_config",
"esrally/config.py:migrate"
],
"edited_modules": [
"esrally/config.py:ConfigFactory",
"esrally/config.py:migrate"
... | elastic/rally | 4d05fa88ea0920ec1f3178c3705201a53f6420db | esrally fails after initial config run if JDK9 is not installed
Steps to reproduce:
1. Run `esrally configure` on a system without JDK 9 (but with Gradle installed)
2. Run `esrally`
This will fail with:
"No value for mandatory configuration: section=build, key=gradle.bin" | diff --git a/docs/car.rst b/docs/car.rst
index 5d7f21c2..855d38e8 100644
--- a/docs/car.rst
+++ b/docs/car.rst
@@ -94,6 +94,11 @@ These values are derived by Rally internally based on command line flags and you
If you specify multiple configurations, e.g. ``--car="4gheap,ea"``, Rally will apply them in order. It wil... |
elastic__rally-427 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/mechanic.py:create"
],
"edited_modules": [
"esrally/mechanic/mechanic.py:create"
]
},
"file": "esrally/mechanic/mechanic.py"
},
{
"changes": {
... | elastic/rally | e62d73bd14ae0caaabb1c726e147eefeafc6ebd2 | Allow simpler configuration of cluster configuration
If we want to customize the benchmarked Elasticsearch cluster, we currently need to create a custom team repository which requires git. For simple use cases, we should allow users to just provide a path to a configuration directory (similarly to `--track-path` for tr... | diff --git a/docs/car.rst b/docs/car.rst
index 5d7f21c2..855d38e8 100644
--- a/docs/car.rst
+++ b/docs/car.rst
@@ -94,6 +94,11 @@ These values are derived by Rally internally based on command line flags and you
If you specify multiple configurations, e.g. ``--car="4gheap,ea"``, Rally will apply them in order. It wil... |
elastic__rally-430 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/config.py:ConfigFactory.create_config"
],
"edited_modules": [
"esrally/config.py:ConfigFactory"
]
},
"file": "esrally/config.py"
},
{
"changes": {
... | elastic/rally | 188495b1fdcd8f9e36625ca2b10f1c9659750290 | Allow to use track parameters also in index / template definitions
Currently index definitions are read as is. However, it can be useful to allow track parameters also for index definition files. For consistency, we should allow the same for index templates.
Technically, this means that we will treat index definitio... | diff --git a/esrally/config.py b/esrally/config.py
index a78ebf77..b8e0d79d 100644
--- a/esrally/config.py
+++ b/esrally/config.py
@@ -447,6 +447,7 @@ class ConfigFactory:
# the Elasticsearch directory is just the last path component (relative to the source root directory)
config["source"]["el... |
elastic__rally-433 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/driver/driver.py:Driver.start_benchmark",
"esrally/driver/driver.py:Driver.after_track_prepared"
],
"edited_modules": [
"esrally/driver/driver.py:Driver"
]
... | elastic/rally | fabefdd6464d996e830806bd5725afe49af12ae4 | Add a unique race id
Currently we use a combination of track, challenge, car and race timestamp to select documents in reporting. We can simplify the code (and also make it more robust) by generating a unique id per race and using that instead. | diff --git a/docs/metrics.rst b/docs/metrics.rst
index 99f804b3..9f952e04 100644
--- a/docs/metrics.rst
+++ b/docs/metrics.rst
@@ -11,6 +11,10 @@ Here is a typical metrics record::
{
"environment": "nightly",
+ "trial-timestamp": "20160421T042749Z",
+ "trial-id": "6ebc6e53-ee20-4b0c-... |
elastic__rally-436 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/driver/driver.py:schedule_for"
],
"edited_modules": [
"esrally/driver/driver.py:schedule_for"
]
},
"file": "esrally/driver/driver.py"
},
{
"changes": {
... | elastic/rally | 1ca746a1ef3cbf7c2441e9d6d2bb279795853991 | Index-append operation only indexing bulk-size * clients documents
<!--
*******************************************************************************
Please ask questions in our forum at
https://discuss.elastic.co/c/elasticsearch/rally
GitHub is reserved for bug reports and feature requests only and we w... | diff --git a/esrally/driver/driver.py b/esrally/driver/driver.py
index cfb50622..112471b4 100644
--- a/esrally/driver/driver.py
+++ b/esrally/driver/driver.py
@@ -1230,9 +1230,16 @@ def schedule_for(current_track, task, client_index):
"time period of [%s] seconds." % (task.schedule, task, str(warmu... |
elastic__rally-449 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/config.py:ConfigFactory.create_config",
"esrally/config.py:migrate"
],
"edited_modules": [
"esrally/config.py:Config",
"esrally/config.py:ConfigFactory",
... | elastic/rally | 7aad2e841ca7a2e022447993a83513f24b49c755 | Allow first Rally run from non master branch
Current Rally won't run from a source checkout with [disabled automatic updates](http://esrally.readthedocs.io/en/stable/developing.html?highlight=developing#automatic-updates) if the user is running it for the first time.
This is because the execution of [setup.py](https... | diff --git a/docs/configuration.rst b/docs/configuration.rst
index b4f524ed..08430670 100644
--- a/docs/configuration.rst
+++ b/docs/configuration.rst
@@ -66,7 +66,7 @@ As you can see above, Rally autodetects if git, Gradle and a JDK are installed.
As you can see, Rally tells you that you cannot build Elasticsearch ... |
elastic__rally-451 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/config.py:ConfigFactory.create_config",
"esrally/config.py:migrate"
],
"edited_modules": [
"esrally/config.py:Config",
"esrally/config.py:ConfigFactory",
... | elastic/rally | 7aad2e841ca7a2e022447993a83513f24b49c755 | Require JDK 10 four source builds
When https://github.com/elastic/elasticsearch/pull/29174 gets merged, source builds of Elasticsearch master will require Java 10, at minimum.
We need to modify the existing code to check for a Java 10 installation / and the user and set it when users want to build Elasticsearch from... | diff --git a/docs/configuration.rst b/docs/configuration.rst
index b4f524ed..08430670 100644
--- a/docs/configuration.rst
+++ b/docs/configuration.rst
@@ -66,7 +66,7 @@ As you can see above, Rally autodetects if git, Gradle and a JDK are installed.
As you can see, Rally tells you that you cannot build Elasticsearch ... |
elastic__rally-454 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/track/params.py:BulkIndexParamSource.__init__",
"esrally/track/params.py:BulkIndexParamSource.partition",
"esrally/track/params.py:PartitionBulkIndexParamSource.__init__",
... | elastic/rally | 7a0e577136d44360d61b3b91a0dc00ecc659f016 | Allow to ingest only a subset of the document corpus
For benchmarking smaller configurations (e.g. with very little memory), ingesting a full document corpus with tens of GB may be too much. For these cases we should allow users to provide a track parameter which allows them to define a percentage of the document corpu... | diff --git a/docs/track.rst b/docs/track.rst
index ec849cb1..4fcfefb1 100644
--- a/docs/track.rst
+++ b/docs/track.rst
@@ -308,9 +308,10 @@ bulk
With the operation type ``bulk`` you can execute `bulk requests <http://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html>`_. It supports the following p... |
elastic__rally-461 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/client.py:EsClientFactory.__init__"
],
"edited_modules": [
"esrally/client.py:EsClientFactory"
]
},
"file": "esrally/client.py"
},
{
"changes": {
... | elastic/rally | f245f685dcd625ac4d7f0fa151a885a4366f85a6 | Remove 'index-settings' property
With Rally 0.9.0 we have introduced a new "create-index" operation which allows to define a "settings" property which makes the specific "index-settings" property obsolete. We'll hence remove it. | diff --git a/docs/command_line_reference.rst b/docs/command_line_reference.rst
index dd1855d5..afecc539 100644
--- a/docs/command_line_reference.rst
+++ b/docs/command_line_reference.rst
@@ -82,16 +82,15 @@ Consider the following track snippet showing a single challenge::
{
"name": "index-only",
- "i... |
elastic__rally-462 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/client.py:EsClientFactory.__init__",
"esrally/client.py:EsClientFactory.create"
],
"edited_modules": [
"esrally/client.py:EsClientFactory"
]
},
"file": ... | elastic/rally | f245f685dcd625ac4d7f0fa151a885a4366f85a6 | Upgrade Elasticsearch client to 6.2.0
The Elasticsearch 6.1.1 client adds the ability to set custom HTTP headers which is necessary for some API calls (e.g. `msearch`, see also the [respective Discuss thread](https://discuss.elastic.co/t/msearch-capability/110702/11)).
When we upgrade, we should also reimplement SSL... | diff --git a/docs/command_line_reference.rst b/docs/command_line_reference.rst
index dd1855d5..afecc539 100644
--- a/docs/command_line_reference.rst
+++ b/docs/command_line_reference.rst
@@ -82,16 +82,15 @@ Consider the following track snippet showing a single challenge::
{
"name": "index-only",
- "i... |
elastic__rally-466 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/config.py:migrate"
],
"edited_modules": [
"esrally/config.py:Config",
"esrally/config.py:migrate"
]
},
"file": "esrally/config.py"
},
{
"changes... | elastic/rally | fab6a504616af4b0de6584652e96bd30a466c246 | Don't require git
As Rally allows recently to define tracks as simple files there is no hard requirement that git is installed (but obviously usage is restricted to Rally as load generator with custom tracks). | diff --git a/docs/install.rst b/docs/install.rst
index ef8af7e6..592ad278 100644
--- a/docs/install.rst
+++ b/docs/install.rst
@@ -69,7 +69,12 @@ We recommend that you use `Homebrew <https://brew.sh/>`_::
git
~~~
-``git 1.9`` or better is required. Verify with ``git --version``.
+Git is not required if **all** of t... |
elastic__rally-469 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/driver/runner.py:BulkIndex.__call__",
"esrally/driver/runner.py:BulkIndex.detailed_stats",
"esrally/driver/runner.py:ForceMerge.__call__",
"esrally/driver/runner.py:Query... | elastic/rally | a5408e0d0d07b271b509df8057a7c73303604c10 | Align operation parameter names with runner implementation
For some operations, e.g. `search`, internal parameter names (e.g. `cache`), differ from the internal name (`use_request_cache`) which is confusing to advanced users that look at our internal runners.
Hence, we should align them to avoid this. | diff --git a/docs/adding_tracks.rst b/docs/adding_tracks.rst
index f8bf7bad..5b0b43f5 100644
--- a/docs/adding_tracks.rst
+++ b/docs/adding_tracks.rst
@@ -578,10 +578,6 @@ The data set that is used in the http_logs track starts on 26-04-1998 but we wan
Custom parameter sources
^^^^^^^^^^^^^^^^^^^^^^^^
-.. note::
-
... |
elastic__rally-477 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/launcher.py:ClusterLauncher.__init__",
"esrally/mechanic/launcher.py:ClusterLauncher.start"
],
"edited_modules": [
"esrally/mechanic/launcher.py:ClusterLaunc... | elastic/rally | 6ce036c1e92f9badbe839b85102096a99d0e5b83 | Mechanism needed for benchmarking update-heavy workflows against create-only or index-only
Currently, rally can be configured to generate metadata that contains conflicting ids for 25% of the documents in a corpus. However, the action specified in the metadata is always `index`. Since the performance characteristics of... | diff --git a/docs/telemetry.rst b/docs/telemetry.rst
index 15cf7743..39924664 100644
--- a/docs/telemetry.rst
+++ b/docs/telemetry.rst
@@ -16,12 +16,13 @@ You probably want to gain additional insights from a race. Therefore, we have ad
Available telemetry devices:
- Command Name Descripti... |
elastic__rally-481 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/launcher.py:ClusterLauncher.__init__",
"esrally/mechanic/launcher.py:ClusterLauncher.start"
],
"edited_modules": [
"esrally/mechanic/launcher.py:ClusterLaunc... | elastic/rally | ebc10f53af246b3e34f751c1346aec9ed800981e | Add new post_launch phase for plugin installers
Rally currently provides a `post_install` hook for plugin installers. For additional flexibility we should add a new phase `post_launch` which can also execute API requests after the cluster has been launched. | diff --git a/esrally/mechanic/launcher.py b/esrally/mechanic/launcher.py
index 19e77cf8..a946e177 100644
--- a/esrally/mechanic/launcher.py
+++ b/esrally/mechanic/launcher.py
@@ -31,12 +31,35 @@ def wait_for_rest_layer(es, max_attempts=20):
class ClusterLauncher:
- def __init__(self, cfg, metrics_store, client_... |
elastic__rally-507 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/launcher.py:ClusterLauncher.start"
],
"edited_modules": [
"esrally/mechanic/launcher.py:ClusterLauncher"
]
},
"file": "esrally/mechanic/launcher.py"
... | elastic/rally | 1ceb4dbe3d5c925fbcc63bc4ec8426a653d7c6f3 | Set retry-on-timeout=true for telemetry device connections
As noticed in https://discuss.elastic.co/t/rally-track-report-analysis-follow-up/127266/17 , there are occasions where firewalls drop connections when there is no traffic and for benchmarks that take a long time to finish, [GcTimesSummary](https://github.com/el... | diff --git a/docs/telemetry.rst b/docs/telemetry.rst
index b0cd9849..d24f0d22 100644
--- a/docs/telemetry.rst
+++ b/docs/telemetry.rst
@@ -93,5 +93,6 @@ Supported telemetry parameters:
* ``node-stats-include-thread-pools`` (default: ``true``): A boolean indicating whether thread pool stats should be included.
* ``nod... |
elastic__rally-512 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/metrics.py:list_races",
"esrally/metrics.py:Race.challenge_name",
"esrally/metrics.py:Race.as_dict",
"esrally/metrics.py:Race.to_result_dicts",
"esrally/metrics.p... | elastic/rally | a446d872b6cadc35041d7f15ee05005fa4f7ac4b | Allow to use Rally without knowing about challenges
_Note: This is a follow-up from #455._
### Purpose
In order to make it simpler for new users, "challenges" will become optional in Rally. We will however not get rid of them because it makes sense to keep them to provide structure for more complex tracks.
###... | diff --git a/docs/adding_tracks.rst b/docs/adding_tracks.rst
index 43f9ab18..dde2e4ca 100644
--- a/docs/adding_tracks.rst
+++ b/docs/adding_tracks.rst
@@ -96,6 +96,124 @@ For details on the allowed syntax, see the Elasticsearch documentation on `mappi
Finally, store the track as ``track.json`` in the tutorial direct... |
elastic__rally-514 | [
{
"changes": {
"added_entities": [
"esrally/mechanic/telemetry.py:IndexStats.index_time",
"esrally/mechanic/telemetry.py:IndexStats.primary_shard_stats"
],
"added_modules": null,
"edited_entities": [
"esrally/mechanic/telemetry.py:IndexStats.on_benchmark_start",
... | elastic/rally | fc63d066a0a28fe7a683d4d41acc2ab2bd53d522 | Overhaul confusing index time related metrics
Currently we report various indexing time related metrics like which are based on the indices stats API. However, these numbers are the sum on index level (i.e. sum of all shards). This means that the number is dependent on shard count and will be usually larger than the be... | diff --git a/docs/metrics.rst b/docs/metrics.rst
index 6681f90e..bf24fb91 100644
--- a/docs/metrics.rst
+++ b/docs/metrics.rst
@@ -143,12 +143,12 @@ Rally stores the following metrics:
* ``segments_terms_memory_in_bytes``: Number of bytes used for terms as reported by the indices stats API.
* ``segments_norms_memory_... |
elastic__rally-524 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/config.py:ConfigFile.load",
"esrally/config.py:ConfigFactory.create_config",
"esrally/config.py:migrate"
],
"edited_modules": [
"esrally/config.py:ConfigFile"... | elastic/rally | 54edbccaef684a2a5e202ba37b3fd0ca1b786821 | Password with symbols can cause errors parsing rally.ini file
**Rally version**: 0.11.0
**OS version**: Ubuntu 16.04
**Description of the problem including expected versus actual behavior**:
I specified an Elastic Cloud cluster as the metrics store and picked a password that contained a `$` followed by a charact... | diff --git a/esrally/config.py b/esrally/config.py
index a4a65a81..d9152ec7 100644
--- a/esrally/config.py
+++ b/esrally/config.py
@@ -38,8 +38,8 @@ class ConfigFile:
"""
return os.path.isfile(self.location)
- def load(self, interpolation=configparser.ExtendedInterpolation()):
- config = c... |
elastic__rally-526 | [
{
"changes": {
"added_entities": [
"esrally/mechanic/supplier.py:DistributionRepository.file_name"
],
"added_modules": null,
"edited_entities": [
"esrally/mechanic/supplier.py:ElasticsearchDistributionSupplier.fetch"
],
"edited_modules": [
"esrally/mec... | elastic/rally | 085e3d482717d88dfc2d41aa34502eb108abbfe9 | Rally cannot differentiate between default and OSS distribution after download
**Rally version** (get with `esrally --version`): all versions
**Description of the problem including expected versus actual behavior**:
When we run a benchmark first with the OSS distribution and then one with the default one, Rally r... | diff --git a/esrally/mechanic/supplier.py b/esrally/mechanic/supplier.py
index fa001711..a59d640f 100644
--- a/esrally/mechanic/supplier.py
+++ b/esrally/mechanic/supplier.py
@@ -293,8 +293,8 @@ class ElasticsearchDistributionSupplier:
def fetch(self):
io.ensure_dir(self.distributions_root)
- dis... |
elastic__rally-540 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/telemetry.py:NodeStatsRecorder.record"
],
"edited_modules": [
"esrally/mechanic/telemetry.py:NodeStatsRecorder"
]
},
"file": "esrally/mechanic/telemetr... | elastic/rally | f2557f8476f7ba34c5def1c0126218f19266dee1 | Simplify filtering node-stats-related documents in Kibana
The current structure of node-stats documents does not allow for easy filtering in Kibana because we don't have an explicit property in the documents that allow identify them. Hence, we should add a property (e.g. `"name": "node-stats"`) to clearly indicate that... | diff --git a/esrally/mechanic/telemetry.py b/esrally/mechanic/telemetry.py
index 70166f13..d6c13a1a 100644
--- a/esrally/mechanic/telemetry.py
+++ b/esrally/mechanic/telemetry.py
@@ -483,6 +483,7 @@ class NodeStatsRecorder:
for node_stats in current_sample:
node_name = node_stats["name"]
... |
elastic__rally-544 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/metrics.py:EsClientFactory.__init__"
],
"edited_modules": [
"esrally/metrics.py:EsClientFactory"
]
},
"file": "esrally/metrics.py"
}
] | elastic/rally | 7387ca228ec1f0f7e6dc5f4938cfc62dbc4c5cba | datastore.secure boolean values seem to be case sensitive in rally.ini
Specifying `datastore.secure = true` in `rally.ini` gives the misleading error message:
```
esrally.exceptions.SystemSetupError: ('Could not connect to your Elasticsearch metrics store. Please check that it is running on host [https://<url>] at ... | diff --git a/esrally/metrics.py b/esrally/metrics.py
index c01be1c2..7da700de 100644
--- a/esrally/metrics.py
+++ b/esrally/metrics.py
@@ -9,7 +9,7 @@ from enum import Enum, IntEnum
import tabulate
from esrally import time, exceptions, config, version, paths
-from esrally.utils import console, io, versions
+from es... |
elastic__rally-555 | [
{
"changes": {
"added_entities": [
"esrally/track/loader.py:used_corpora"
],
"added_modules": [
"esrally/track/loader.py:used_corpora"
],
"edited_entities": [
"esrally/track/loader.py:prepare_track"
],
"edited_modules": [
"esrally/track/l... | elastic/rally | 31ac8b0f9eace24cafff7d995daa1285d1443309 | Only load required corpora
Currently Rally is loading all referenced corpora of track, even if they are not needed. As it is possible that we download and extract a significant amount of data (usually several GB if not more), we should investigate whether we can load only the required ones. | diff --git a/esrally/track/loader.py b/esrally/track/loader.py
index 39800a6a..fbe3a076 100644
--- a/esrally/track/loader.py
+++ b/esrally/track/loader.py
@@ -228,6 +228,19 @@ def operation_parameters(t, op):
return params.param_source_for_operation(op.type, t, op.params)
+def used_corpora(t, cfg):
+ co... |
elastic__rally-557 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/telemetry.py:FlightRecorder.instrument_env",
"esrally/mechanic/telemetry.py:FlightRecorder.java_opts"
],
"edited_modules": [
"esrally/mechanic/telemetry.py:F... | elastic/rally | a8f4694a7dd6a7b4098f49d93daf14b4e55a090a | Adjust flight recorder flags for JDK 11
The [open-source release of Java flight recorder](http://openjdk.java.net/jeps/328) is targeted for JDK 11. As a consequence, the JVM flags to activate Java flight recorder will change (it's not a commercial feature anymore). Also, we can remove the licensing warning that we issu... | diff --git a/docs/install.rst b/docs/install.rst
index 1add0799..0389cb11 100644
--- a/docs/install.rst
+++ b/docs/install.rst
@@ -101,9 +101,7 @@ In all other cases, Rally requires ``git 1.9`` or better. Verify with ``git --ve
JDK
~~~
-A JDK is required on all machines where you want to launch Elasticsearch. If yo... |
elastic__rally-575 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/client.py:EsClientFactory.__init__",
"esrally/client.py:EsClientFactory.create"
],
"edited_modules": [
"esrally/client.py:EsClientFactory"
]
},
"file": ... | elastic/rally | 87d762503219463869fba9592e40f4d890f19f3e | es download url below 6.3.0 version is not correct
- rally version: 1.0.1
when rally download es, it's url is "http://xxxx/elasticsearch-oss-6.2.2.tar.gz", but correct url should be "http://xxxx/elasticsearch-6.2.2.tar.gz". The former url is not applied to versions below 6.3.0. | diff --git a/Dockerfile b/Dockerfile
index 3a91b92c..55ae662e 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -5,14 +5,14 @@ ARG NEW_USER
RUN apt-get -y update && \
apt-get install -y curl python3 python3-pip vim openssh-client \
- git make build-essential libssl-dev zlib1g-dev libbz2-dev libreadline-dev libsqli... |
elastic__rally-612 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/driver/runner.py:Query.request_body_query",
"esrally/driver/runner.py:Query.scroll_query"
],
"edited_modules": [
"esrally/driver/runner.py:Query"
]
},
"... | elastic/rally | ddc1e7a8873e5336809b7e6cfe3f434175a08ff3 | Extract total hits as either structured object or number
With https://github.com/elastic/elasticsearch/pull/35849, Elasticsearch will return total hits as an object, e.g.:
```json
{
"hits": {
"total": {
"value": 100,
"relation": "eq"
}
}
}
```
but so far, Rally assumes the followi... | diff --git a/esrally/driver/runner.py b/esrally/driver/runner.py
index d9044ae8..b8007edc 100644
--- a/esrally/driver/runner.py
+++ b/esrally/driver/runner.py
@@ -551,6 +551,7 @@ class Query(Runner):
Always 1 for normal queries and the number of retrieved pages for scroll queries.
* ``unit``: Th... |
elastic__rally-615 | [
{
"changes": {
"added_entities": [
"esrally/mechanic/telemetry.py:IndexStats.index_counts",
"esrally/mechanic/telemetry.py:IndexStats.index_count"
],
"added_modules": null,
"edited_entities": [
"esrally/mechanic/telemetry.py:IndexStats.on_benchmark_stop",
... | elastic/rally | 738959af8f291cc105c82421a9dcc02a639d53e9 | Add total merges and refreshes in summary output
Currently our summary output includes sections like:
```
| All | Total refresh time | | 131.531 | min |
| All | Min refresh time per shard | | 43.0791 | min |
| All | ... | diff --git a/docs/metrics.rst b/docs/metrics.rst
index a7dd0ca6..bdc45bd9 100644
--- a/docs/metrics.rst
+++ b/docs/metrics.rst
@@ -143,13 +143,16 @@ Rally stores the following metrics:
* ``segments_terms_memory_in_bytes``: Number of bytes used for terms as reported by the indices stats API.
* ``segments_norms_memory_... |
elastic__rally-627 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/telemetry.py:NodeStats.on_benchmark_start"
],
"edited_modules": [
"esrally/mechanic/telemetry.py:NodeStats"
]
},
"file": "esrally/mechanic/telemetry.py... | elastic/rally | 4497951696f75078fe05e2def4b95592e074d211 | Warn when enabling node-stats
When `docs` / `completion` is requested via node stats (which is done by the node stats telemetry device) it will trigger additional refreshes in Elasticsearch which will skew results and highly likely make benchmark results invalid. We should document that and maybe even emit a warning wh... | diff --git a/docs/Makefile b/docs/Makefile
index 7333b7a1..dd64bf1e 100644
--- a/docs/Makefile
+++ b/docs/Makefile
@@ -6,6 +6,7 @@ SPHINXOPTS =
SPHINXBUILD = sphinx-build
PAPER =
BUILDDIR = _build
+CUR_RELDIR := $(notdir $(shell pwd))
# User-friendly check for sphinx-build
ifeq ($(shell whic... |
elastic__rally-639 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"esrally/mechanic/launcher.py:ClusterLauncher.start"
],
"edited_modules": [
"esrally/mechanic/launcher.py:ClusterLauncher"
]
},
"file": "esrally/mechanic/launcher.py"
... | elastic/rally | 5b85f0815fff2f70316efb56deb6b1ce7545663b | Add new telemetry device: recovery-stats
We need a new telemetry device that can collect the data available in `_recovery`, see [docs](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-recovery.html).
The `_recovery` stats somewhat resemble the structure of [ccr stats](https://www.elastic.co/gu... | diff --git a/docs/telemetry.rst b/docs/telemetry.rst
index 2711f6d7..1e29c268 100644
--- a/docs/telemetry.rst
+++ b/docs/telemetry.rst
@@ -16,13 +16,14 @@ You probably want to gain additional insights from a race. Therefore, we have ad
Available telemetry devices:
- Command Name Descript... |
elastic__rally-667 | [
{
"changes": {
"added_entities": [
"esrally/driver/runner.py:Sleep.__call__",
"esrally/driver/runner.py:Sleep.__repr__"
],
"added_modules": [
"esrally/driver/runner.py:Sleep"
],
"edited_entities": [
"esrally/driver/runner.py:register_default_runners"... | elastic/rally | 799e0642c27a0067931f305359a615cbf9fe2e20 | Add configurable "sleep" operation
When running benchmarks against nodes that are expected to see few but long-running queries it is possible to combine request timeout with `target-interval` to ensure there is a bit of quiet time between queries. This however results in a longer quiet time for queries that return quic... | diff --git a/docs/command_line_reference.rst b/docs/command_line_reference.rst
index 42858950..6146b16d 100644
--- a/docs/command_line_reference.rst
+++ b/docs/command_line_reference.rst
@@ -64,6 +64,11 @@ Examples::
Selects the track repository that Rally should use to resolve tracks. By default the ``default`` tra... |
elcaminoreal__elcaminoreal-10 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/elcaminoreal/_gather.py:Commands.command",
"src/elcaminoreal/_gather.py:Commands.run",
"src/elcaminoreal/_gather.py:Commands.dependency",
"src/elcaminoreal/_gather.py:Command... | elcaminoreal/elcaminoreal | a76600014ed645b6f92b98bf491f2b49e5625d6d | Allow regular arguments to commands and dependencies
The following should work:
```
@COMMANDS.dependency(
dependencies=['foo', 'bar'],
possible_dependencies=['baz'],
regular=True)
def thing(foo , bar, build_baz):
val = foo()
if val > 5:
val -= build_baz()
return ... | diff --git a/src/elcaminoreal/_gather.py b/src/elcaminoreal/_gather.py
index 63f85a9..cbe7637 100644
--- a/src/elcaminoreal/_gather.py
+++ b/src/elcaminoreal/_gather.py
@@ -24,12 +24,13 @@ class Commands(object):
def command(self,
name=None,
parser=caparg.command(''),
- ... |
eliben__pycparser-236 | [
{
"changes": {
"added_entities": [
"pycparser/c_parser.py:CParser.p_pragmacomp_or_statement"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"pycparser/c_parser.py:CParser"
]
},
"file": "pycparser/c_parser.py"
}
] | eliben/pycparser | 4992410bf8c2d6d7eb94703d0f6f94b5a9acaa0a | Incorrect AST Structure when #pragma follows For loop.
Consider the following code snippet:
```c
for(int i = 0; i < 3; i++)
#pragma omp critical
sum += 1;
```
When compiled without Open MP, the #pragma should be ignored completely, so that the statement ``sum += 1`` should be a descendent of the for ... | diff --git a/pycparser/c_parser.py b/pycparser/c_parser.py
index f01f67f..47d958f 100644
--- a/pycparser/c_parser.py
+++ b/pycparser/c_parser.py
@@ -616,6 +616,59 @@ class CParser(PLYParser):
"""
p[0] = p[1]
+ # A pragma is generally considered a decorator rather than an actual statement.
+ # ... |
eliben__pycparser-255 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pycparser/c_generator.py:CGenerator.visit_NamedInitializer"
],
"edited_modules": [
"pycparser/c_generator.py:CGenerator"
]
},
"file": "pycparser/c_generator.py"
}
] | eliben/pycparser | 168f54c3ae324c3827d22fb90e456653e6fe584a | Constant expressions in designated initializers are not generated back to C
While pycparser correctly parses a constant-expression in a designated initializer (the AST is correct), it fails to write it back when generating C code.
Consider the following code:
```C
void myFunction(void)
{
int array[3] = {[0] = ... | diff --git a/pycparser/c_generator.py b/pycparser/c_generator.py
index 0575b8b..4c86f84 100644
--- a/pycparser/c_generator.py
+++ b/pycparser/c_generator.py
@@ -283,8 +283,8 @@ class CGenerator(object):
for name in n.name:
if isinstance(name, c_ast.ID):
s += '.' + name.name
- ... |
eliben__pycparser-346 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pycparser/ast_transforms.py:fix_switch_cases"
],
"edited_modules": [
"pycparser/ast_transforms.py:fix_switch_cases"
]
},
"file": "pycparser/ast_transforms.py"
}
] | eliben/pycparser | bc2010aea92535cb1d70be9fc1bebeb6eff229d8 | "'NoneType' object is not iterable" seen for switch statement without cases
Seen calling parse_file on a file containing the below snippet (similar code was generated by a preprocessor). This compiles with `gcc`. I think checking if block_items is None may be sufficient.
```c
int main() {
int type = 2;
sw... | diff --git a/pycparser/ast_transforms.py b/pycparser/ast_transforms.py
index ba50966..0aeb88f 100644
--- a/pycparser/ast_transforms.py
+++ b/pycparser/ast_transforms.py
@@ -74,7 +74,8 @@ def fix_switch_cases(switch_node):
# Goes over the children of the Compound below the Switch, adding them
# either direct... |
eliben__pycparser-364 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pycparser/c_parser.py:CParser.p_offsetof_member_designator"
],
"edited_modules": [
"pycparser/c_parser.py:CParser"
]
},
"file": "pycparser/c_parser.py"
}
] | eliben/pycparser | 1166ea11785ce12cdfd5e8bf8b3a69b5e6b76f9c | Incorrect AST structure when parsing `offsetof` expressions.
I am using the latest commit on `master` branch (`1166ea1`).
Take the following code as example:
```c
int x = offsetof(struct A, a.b);
```
The generated parse tree is:
```python
FileAST(ext=[Decl(name='x',
quals=[],
... | diff --git a/README.rst b/README.rst
index df9025c..682abf7 100644
--- a/README.rst
+++ b/README.rst
@@ -161,6 +161,9 @@ See `this blog post
<https://eli.thegreenplace.net/2015/on-parsing-c-type-declarations-and-fake-headers>`_
for more details.
+Note that the fake headers are not included in the ``pip`` package no... |
eliben__pycparser-394 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pycparser/c_generator.py:CGenerator.__init__",
"pycparser/c_generator.py:CGenerator.visit_BinaryOp"
],
"edited_modules": [
"pycparser/c_generator.py:CGenerator"
]
}... | eliben/pycparser | ba80794f1460a87eed2f8f918e47868878f3a5ad | Precedence-aware CGenerator
I ran into the issue that in a code more than 256 variables are summed up. The `CGenerator` turned this into >256 nested BinaryOperators with that many parenthesis, that in turn was something clang did not like (be default).
I wrote a small generator which takes precedence into account fo... | diff --git a/pycparser/c_generator.py b/pycparser/c_generator.py
index 53c26fd..c494176 100644
--- a/pycparser/c_generator.py
+++ b/pycparser/c_generator.py
@@ -14,11 +14,17 @@ class CGenerator(object):
return a value from each visit method, using string accumulation in
generic_visit.
"""
- de... |
eliben__pyelftools-433 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elftools/dwarf/compileunit.py:CompileUnit.iter_DIE_children",
"elftools/dwarf/compileunit.py:CompileUnit._iter_DIE_subtree"
],
"edited_modules": [
"elftools/dwarf/compileunit... | eliben/pyelftools | d37dd02e22c4ae39224962a0d300fb9aba2af683 | unit tests fail when building release 0.27
Hello
I'm building on top of the 0.27 release from pypi
Most of the tests pass but the following two are failing:
```
======================================================================
ERROR: test_parse_shared_library (test.test_ehabi_elf.TestEHABIELF)
----------... | diff --git a/MANIFEST.in b/MANIFEST.in
index e2c7667..b3d07d8 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1,7 +1,7 @@
recursive-include elftools *.py
recursive-include scripts *.py
recursive-include examples *.py *.elf *.out
-recursive-include test *.py *.elf *.arm *.mips *.o
+recursive-include test *.py *.elf *.... |
elyra-ai__elyra-3167 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"elyra/pipeline/airflow/airflow_processor.py:AirflowPipelineProcessor._cc_pipeline",
"elyra/pipeline/airflow/airflow_processor.py:AirflowPipelineProcessor.render_volumes",
"elyra/pipeline... | elyra-ai/elyra | 0dd92899b336951ae79de4dd6f1137d026383db4 | make generic pipelines to DAG rendering work with Airflow 2.x
**Describe the issue**
Currently, even when using generic pipeline editor with python files and notebooks, the rendered DAG is not compatible with Airflow 2..6.0 or higher, or any Airflow 2.x, for that matter :-)
`
Broken DAG: [/opt/airflow/dags/repo/Sven... | diff --git a/docs/source/getting_started/changelog.md b/docs/source/getting_started/changelog.md
index eb8045b7..954fe70e 100644
--- a/docs/source/getting_started/changelog.md
+++ b/docs/source/getting_started/changelog.md
@@ -4,7 +4,11 @@ A summary of new feature highlights is located on the [GitHub release page](http... |
emsig__emg3d-259 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"emg3d/surveys.py:Survey.select"
],
"edited_modules": [
"emg3d/surveys.py:Survey"
]
},
"file": "emg3d/surveys.py"
}
] | emsig/emg3d | 5c1e132e0b0a49185b2ca3df2c4b45b7a4914fab | ENH: Add option to remove empty Tx-Rx-f-pairs
`Survey.select` can be very useful to reduce a dataset. However, currently it will, e.g., keep all receivers if we select a particular source, even if this receiver has no data from that source.
- Should be a keyword to switch off/on (by default on?)
- This only applies... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index dcaddd5..47d1eb7 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -6,6 +6,15 @@ Changelog
""""""""""
+latest
+------
+
+- ``survey``:
+
+ - ``select`` removes now empty source-receiver-frequency pairs. If you want
+ the old behaviour set ``remove_empty=False``.... |
emsig__emg3d-325 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"emg3d/electrodes.py:Dipole.__init__",
"emg3d/electrodes.py:Dipole.__repr__"
],
"edited_modules": [
"emg3d/electrodes.py:Dipole"
]
},
"file": "emg3d/electrodes.p... | emsig/emg3d | 8750f85bfcebaf67ed2e6beff941b960a048a1b3 | `emg3d.TxMagneticDipole` shows wrong coordinates.
```
> src = emg3d.TxMagneticDipole(coordinates=[0.0, 0.0, 0.0, 0.0, -0.5, 0.5])
> src
TxMagneticDipole: 1.0 A;
e1={0.0; 0.7; 0.0} m; e2={-0.7; 0.0; 0.0} m
```
which are just the first two points of it,
```
> src.points
array([[ 0. , 0.70710678, 0. ... | diff --git a/emg3d/electrodes.py b/emg3d/electrodes.py
index 8a31385..e31ec0f 100644
--- a/emg3d/electrodes.py
+++ b/emg3d/electrodes.py
@@ -323,7 +323,7 @@ class Dipole(Wire):
if is_flat:
# Re-arrange for points.
- points = np.array([coordinates[::2], coordinates[1::2]])
... |
emsig__emg3d-349 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"emg3d/fields.py:_dipole_vector"
],
"edited_modules": [
"emg3d/fields.py:_dipole_vector"
]
},
"file": "emg3d/fields.py"
}
] | emsig/emg3d | df030190d0530fbb95bd0bef7e3b4e53e3c80138 | Bug in Dipole and Wire sources
# Horrible bug in Dipole and Wire sources
```python
import emg3d
import numpy as np
import matplotlib.pyplot as plt
from matplotlib.colors import LogNorm
h = np.ones(24)*100
grid = emg3d.TensorMesh([h, h, h], 'CCC')
src_coo = np.array([[-1000, +1000, 0], [+1000, -1000, 0]])
... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index afdab7f..b104b1a 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -6,12 +6,15 @@ Changelog
""""""""""
-latest
-------
+v1.8.5 : Bugfix and pyproject
+-----------------------------
-- Maintenance:
+- Bugfix and maintenance:
- - Changed from ``setup.py`` to ``py... |
en0__dnry-config-4 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dnry/config/yaml/source.py:YamlSource.load"
],
"edited_modules": [
"dnry/config/yaml/source.py:YamlSource"
]
},
"file": "dnry/config/yaml/source.py"
}
] | en0/dnry-config | 296dfdc2eee8f82f0926d102f42db2f5fd8f2efb | Optional flag for yaml files is not obeyed
When trying to add an optional YamlSource where the given yaml file does not exist, the following error is raised:
```expected str, bytes or os.PathLike object, not NoneType```
It appears the YamlSource load method is checking if the source is required or not to raise a ... | diff --git a/dnry/config/yaml/source.py b/dnry/config/yaml/source.py
index 8742b25..23d9e8d 100644
--- a/dnry/config/yaml/source.py
+++ b/dnry/config/yaml/source.py
@@ -17,6 +17,9 @@ class YamlSource(IConfigSource):
paths = ",".join(self.__paths)
raise RuntimeError(f"Configuration Error: None ... |
encode__databases-122 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"databases/core.py:DatabaseURL.database"
],
"edited_modules": [
"databases/core.py:DatabaseURL"
]
},
"file": "databases/core.py"
}
] | encode/databases | 9cb2202c25e8c0c149c535ea21d5b56c4395a584 | How to specify SQLite database fullpath as database URL
When I specify an absolute path of SQLite database file as database url as below, aiosqlite cannot open the database file. (on MacOS)
When I use a relative path like `sqlite:///example.db`, it works fine.
How could I specify the absolute path?
```
database =... | diff --git a/databases/core.py b/databases/core.py
index 9034e5f..b8da05e 100644
--- a/databases/core.py
+++ b/databases/core.py
@@ -362,7 +362,10 @@ class DatabaseURL:
@property
def database(self) -> str:
- return self.components.path.lstrip("/")
+ path = self.components.path
+ if path... |
encode__databases-42 | [
{
"changes": {
"added_entities": [
"databases/core.py:_EmptyNetloc.__bool__",
"databases/core.py:DatabaseURL.netloc"
],
"added_modules": [
"databases/core.py:_EmptyNetloc"
],
"edited_entities": [
"databases/core.py:DatabaseURL.replace"
],
... | encode/databases | 76b04c2a9c37227db859cf4b8f1efeff7fc0b9c1 | Bug: sqlite url replace does not work
Testcase:
```python
def test_replace_database_url_components_sqlite():
u = DatabaseURL("sqlite:///mydatabase.db")
assert u.database == "mydatabase.db"
new = u.replace(database="test_" + u.database)
assert new.database == "test_mydatabase.db"
assert st... | diff --git a/databases/core.py b/databases/core.py
index c9e074f..62a2487 100644
--- a/databases/core.py
+++ b/databases/core.py
@@ -246,6 +246,11 @@ class Transaction:
await self._connection.__aexit__()
+class _EmptyNetloc(str):
+ def __bool__(self) -> bool:
+ return True
+
+
class Database... |
encode__databases-46 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "databases/__init__.py"
},
{
"changes": {
"added_entities": [
"databases/backends/mysql.py:MySQLBackend._get_connection_kwargs"
],
... | encode/databases | 9bee7cb51a21f425c239b1bbb99c7cac043b8977 | Specify pool size during connect
The default asyncpg pool size is 10, it'd be nice to be able to specify the pool size (and other pool options) during initialization through the databases package during the .connect() call:
https://magicstack.github.io/asyncpg/current/api/index.html#asyncpg-api-pool
It seems there'... | diff --git a/README.md b/README.md
index 30cf40e..772ffaf 100644
--- a/README.md
+++ b/README.md
@@ -173,6 +173,19 @@ async def shutdown():
await database.disconnect()
```
+## Connection options
+
+The PostgreSQL and MySQL backends provide a few connection options for SSL
+and for configuring the connection poo... |
encode__httpcore-433 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpcore/_async/connection.py:AsyncHTTPConnection.__init__",
"httpcore/_async/connection.py:AsyncHTTPConnection.handle_async_request",
"httpcore/_async/connection.py:AsyncHTTPConnection.... | encode/httpcore | 1ebb420efb9ba6188458ff31057479813a5df2aa | If start_tls raises exception connection is retained in pool as connecting
I was investigating https://github.com/encode/httpcore/pull/117 since i'm hit with that. But since code has been very much refactored, it doesn't make sense anymore. However something similar may remain.
The following test fails for example. ... | diff --git a/httpcore/_async/connection.py b/httpcore/_async/connection.py
index c86d4ef..2860da9 100644
--- a/httpcore/_async/connection.py
+++ b/httpcore/_async/connection.py
@@ -52,6 +52,7 @@ class AsyncHTTPConnection(AsyncConnectionInterface):
AutoBackend() if network_backend is None else network_backe... |
encode__httpcore-441 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpcore/_async/http2.py:AsyncHTTP2Connection.__init__",
"httpcore/_async/http2.py:AsyncHTTP2Connection.handle_async_request",
"httpcore/_async/http2.py:AsyncHTTP2Connection._receive_str... | encode/httpcore | e4aa75f9ea955628347f836af8a42df9e8977c1b | possibly wrong handling of error_code?
https://github.com/encode/httpx/blob/50d337e807839c21e796fd8b01c67d8a672a9721/httpx/_dispatch/http2.py#L147-L155
IIRC, RFC defines 2 messages that may carry `error_code`:
* RST_STREAM - forcibly close 1 stream
* GOAWAY - close entire connection (gracefully or forcibly)
In ... | diff --git a/httpcore/_async/http2.py b/httpcore/_async/http2.py
index 8f05eb4..025daf0 100644
--- a/httpcore/_async/http2.py
+++ b/httpcore/_async/http2.py
@@ -9,7 +9,11 @@ import h2.events
import h2.exceptions
import h2.settings
-from .._exceptions import ConnectionNotAvailable, RemoteProtocolError
+from .._excep... |
encode__httpcore-631 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpcore/_async/connection_pool.py:AsyncConnectionPool.aclose"
],
"edited_modules": [
"httpcore/_async/connection_pool.py:AsyncConnectionPool"
]
},
"file": "httpcore/_a... | encode/httpcore | 6a97dade2a57283491c7830385d52daccbeaf93b | List in-flight connections
`AsyncConnectionPool.aclose()` raises `RuntimeError: The connection pool was closed while 1 HTTP requests/responses were still in-flight.` if there are any on-going requests.
It would be nice to provide a list of URLs to help me understand what I'm doing wrong. At the moment I'm adding `pr... | diff --git a/httpcore/_async/connection_pool.py b/httpcore/_async/connection_pool.py
index 5541689..e6c4ef6 100644
--- a/httpcore/_async/connection_pool.py
+++ b/httpcore/_async/connection_pool.py
@@ -301,19 +301,11 @@ class AsyncConnectionPool(AsyncRequestInterface):
Close any connections in the pool.
... |
encode__httpcore-641 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpcore/_async/http11.py:AsyncHTTP11Connection.handle_async_request"
],
"edited_modules": [
"httpcore/_async/http11.py:AsyncHTTP11Connection"
]
},
"file": "httpcore/_a... | encode/httpcore | 80ff02f1276eba3cb6b6493b3f0b033a26d6348d | Handle HTTP/1.1 half-closed connections gracefully.
There's an HTTP/1.1 case that can occur where...
* The client starts sending a request.
* The server half-closes the connection.
* The server sends a response, such as an HTTP 413 Content Too Large.
Currently our behaviour here is that we'll see a `WriteError`... | diff --git a/httpcore/_async/http11.py b/httpcore/_async/http11.py
index 7ad3664..32fa3a6 100644
--- a/httpcore/_async/http11.py
+++ b/httpcore/_async/http11.py
@@ -20,6 +20,7 @@ from .._exceptions import (
ConnectionNotAvailable,
LocalProtocolError,
RemoteProtocolError,
+ WriteError,
map_excepti... |
encode__httpcore-668 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpcore/_async/connection.py:AsyncHTTPConnection.__init__",
"httpcore/_async/connection.py:AsyncHTTPConnection._connect"
],
"edited_modules": [
"httpcore/_async/connection.p... | encode/httpcore | 27a10dd5e7b29cbb744830bfa223072ace333d80 | Allow socket options to be configured.
We should add a `socket_options` configuration to the `ConnectionPool` and `HTTPProxy` classes.
This would need to be passed through to the network backends `connect_tcp(...)` and `connect_unix_socket()` methods.
For example the sync case, here...
https://github.com/encod... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9c81df5..30f8d17 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Improve logging with per-module logger names. (#690)
- Resolve race condition during import of `anyio` packa... |
encode__httpcore-974 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "httpcore/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpcore/_async... | encode/httpcore | 0bfcee4cd266775c4d9ce2f89fc1b6afa8afc356 | Add proxy configuration to `httpcore.ConnectionPool`
Proxy configuration is currently supported through two connection pool subclasses...
* `SyncHTTPProxy(...)`
* `SyncSOCKSProxy(...)`
We could instead have proxy configuration on the main class...
```python
pool = httpcore.SyncConnectionPool(
ssl_contex... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f631104..e33b10c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
+## [Unreleased]
+
+- Support `proxy=…`... |
encode__httpx-1002 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/_client.py:BaseClient.redirect_url"
],
"edited_modules": [
"httpx/_client.py:BaseClient"
]
},
"file": "httpx/_client.py"
}
] | encode/httpx | 21d7e16559d9360ae3a5c5cfd23bab8bb85ee4a8 | KeyError occurs when redirect to custom scheme(ex. market://)
# Information
OS platform : mac OS
Python version : 3.7.2
Installed dependencies and versions : `httpx==0.9.3`
Code snippet
```
@property
def port(self) -> int:
port = self._uri_reference.port
if port is None:
... | diff --git a/httpx/_client.py b/httpx/_client.py
index 7248f87..2c56edc 100644
--- a/httpx/_client.py
+++ b/httpx/_client.py
@@ -322,6 +322,10 @@ class BaseClient:
url = URL(location, allow_relative=True)
+ # Check that we can handle the scheme
+ if url.scheme and url.scheme not in ("http", "... |
encode__httpx-1032 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/_content_streams.py:MultipartStream._iter_fields"
],
"edited_modules": [
"httpx/_content_streams.py:MultipartStream"
]
},
"file": "httpx/_content_streams.py"
},... | encode/httpx | 0f7d644b8dba432c5eec08157947a4e551996fa1 | Support for multiple files per POST field
```
async def http_upload():
async with httpx.AsyncClient(verify=False) as client:
data_path = os.path.join(PARENT_PATH, 'data_file/blob/data')
index_path = os.path.join(PARENT_PATH, 'data_file/blob/index')
files = {
"upload_file": ... | diff --git a/docs/advanced.md b/docs/advanced.md
index 76321dd..9d416e6 100644
--- a/docs/advanced.md
+++ b/docs/advanced.md
@@ -464,6 +464,16 @@ MIME header field.
It is safe to upload large files this way. File uploads are streaming by default, meaning that only one chunk will be loaded into memory at a time.
... |
encode__httpx-1034 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/_decoders.py:LineDecoder.decode"
],
"edited_modules": [
"httpx/_decoders.py:LineDecoder"
]
},
"file": "httpx/_decoders.py"
}
] | encode/httpx | 27b0dbc22da1424a020c2bb769c81490f39ce283 | aiter_lines() doesn't return full lines that span multiple chunks
<https://gist.github.com/scr-oath/aa76d200222a0409d09a0d6feb1a13e2> shows an example setup using cherry.py as server that just outputs two lines - the json is big enough to be sent in two chunks; httpx aiter_lines() gets confused and sends data from the ... | diff --git a/httpx/_decoders.py b/httpx/_decoders.py
index 2a2e703..1ea47b0 100644
--- a/httpx/_decoders.py
+++ b/httpx/_decoders.py
@@ -261,7 +261,7 @@ class LineDecoder:
text = text[idx + 1 :]
break
elif next_char is None:
- self.buffer = t... |
encode__httpx-1072 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "httpx/__init__.py"
},
{
"changes": {
"added_entities": [
"httpx/_exceptions.py:HTTPStatusError.__init__"
],
"added_modules":... | encode/httpx | a89d4ad625aedeb1164e309acae4febb06b8cf5c | Raise dedicated exception in `.raise_from_status()`
Refs #949, spun up from #1064.
Currently `Response.raise_from_status()` raises a generic `HTTPError` exception.
The problematic side is that it is not possible to catch it separately without also catching all exceptions originating from HTTPX (since `HTTPError` ... | diff --git a/docs/quickstart.md b/docs/quickstart.md
index 6791578..f194215 100644
--- a/docs/quickstart.md
+++ b/docs/quickstart.md
@@ -267,9 +267,10 @@ We can raise an exception for any Client or Server error responses (4xx or 5xx s
404
>>> not_found.raise_for_status()
Traceback (most recent call last):
- File "/... |
encode__httpx-1075 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/_client.py:BaseClient.__init__",
"httpx/_client.py:BaseClient._build_auth"
],
"edited_modules": [
"httpx/_client.py:BaseClient"
]
},
"file": "httpx/_clien... | encode/httpx | 064160661929089864938a62ae18dcf0cff75737 | aiter_lines() doesn't return full lines that span multiple chunks
<https://gist.github.com/scr-oath/aa76d200222a0409d09a0d6feb1a13e2> shows an example setup using cherry.py as server that just outputs two lines - the json is big enough to be sent in two chunks; httpx aiter_lines() gets confused and sends data from the ... | diff --git a/httpx/_client.py b/httpx/_client.py
index 1ee9352..d4ec7aa 100644
--- a/httpx/_client.py
+++ b/httpx/_client.py
@@ -80,7 +80,7 @@ class BaseClient:
self.timeout = Timeout(timeout)
self.max_redirects = max_redirects
self.trust_env = trust_env
- self.netrc = NetRCInfo()
+ ... |
encode__httpx-139 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/models.py:URL.__eq__"
],
"edited_modules": [
"httpx/models.py:URL"
]
},
"file": "httpx/models.py"
}
] | encode/httpx | 37df46a83b93a0f40f2b8e10282f6f038dd908f6 | API design question - `Response.url`
Currently our `Response.url` attribute exposes a `URL` instance.
This is a breaking change from the requests API where it just exposes a plain string.
It's feasible that we should instead only be exposing plain string URLs, in order to aim for drop-in replacement API compatibi... | diff --git a/httpx/models.py b/httpx/models.py
index 710c030..9cbdc25 100644
--- a/httpx/models.py
+++ b/httpx/models.py
@@ -204,7 +204,7 @@ class URL:
return hash(str(self))
def __eq__(self, other: typing.Any) -> bool:
- return isinstance(other, URL) and str(self) == str(other)
+ return i... |
encode__httpx-144 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "httpx/__version__.py"
},
{
"changes": {
"added_entities": [
"httpx/concurrency.py:Reader.is_connection_dropped"
],
"added_mo... | encode/httpx | 8db36ed6a537fb2efaf6e5da07102ec0065c498c | URL.join behaviour is incorrect.
Our `URL.join` behavior currently isn't as expected. It should be in line with rfc3986#section-5.2, and Python's existing `urljoin`.
It ain't...
```python
>>> httpx.URL('http://www.example.com/some/directory/abc.html').join('../../foo.html')
URL('http://www.example.com/some/dire... | diff --git a/httpx/__version__.py b/httpx/__version__.py
index c5079f7..b2e30d9 100644
--- a/httpx/__version__.py
+++ b/httpx/__version__.py
@@ -1,3 +1,3 @@
__title__ = "httpx"
__description__ = "A next generation HTTP client, for Python 3."
-__version__ = "0.6.7"
+__version__ = "0.6.8"
diff --git a/httpx/concurrency... |
encode__httpx-159 | [
{
"changes": {
"added_entities": [
"httpx/client.py:BaseClient.merge_headers"
],
"added_modules": null,
"edited_entities": [
"httpx/client.py:BaseClient.__init__",
"httpx/client.py:AsyncClient.request",
"httpx/client.py:Client.request"
],
"edit... | encode/httpx | 3ba2e8c328f05b07ee06ae40f99dce7fe1e8292c | Set Headers like Cookies in Client session for all requests
Assuming one can use `Client`/`AsyncClient` as a drop-in replacement for `requests.Session`, I would like to be able to set headers (and cookies) to be sent for each request, for example for token-based authentication.
With `requests`, I can do:
```python
... | diff --git a/docs/api.md b/docs/api.md
index 1c6887c..dbc3d52 100644
--- a/docs/api.md
+++ b/docs/api.md
@@ -20,7 +20,7 @@
>>> response = client.get('https://example.org')
```
-* `def __init__([auth], [cookies], [verify], [cert], [timeout], [pool_limits], [max_redirects], [app], [dispatch])`
+* `def __init__([auth]... |
encode__httpx-161 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/models.py:URL.__init__"
],
"edited_modules": [
"httpx/models.py:URL"
]
},
"file": "httpx/models.py"
}
] | encode/httpx | 66754ad0c58d61d34489294530351aa4b17e217f | Use IDNA 2008 instead of IDNA 2003
Using `str.encode("idna")` uses IDNA 2003 which isn't recommended for modern use. We should be using IDNA 2008 provided by the `idna` module (which is a dependency of `httpx` but I don't think we're using it anywhere?) | diff --git a/httpx/models.py b/httpx/models.py
index df5d071..32e412f 100644
--- a/httpx/models.py
+++ b/httpx/models.py
@@ -89,16 +89,10 @@ class URL:
params: QueryParamTypes = None,
) -> None:
if isinstance(url, str):
- self._uri_reference = rfc3986.api.uri_reference(url)
+ ... |
encode__httpx-167 | [
{
"changes": {
"added_entities": [
"httpx/client.py:BaseClient.merge_headers"
],
"added_modules": null,
"edited_entities": [
"httpx/client.py:BaseClient.__init__",
"httpx/client.py:AsyncClient.request",
"httpx/client.py:Client.request"
],
"edit... | encode/httpx | 3ba2e8c328f05b07ee06ae40f99dce7fe1e8292c | non-ASCII characters filename in multipart/form-data
I tried to send a file with russian letters in the file name, and `httpx` escaped all non-ASCII characters (as I understood it the way specified in [RFC 7578](https://tools.ietf.org/html/rfc7578)). But this is different from `requests` [behavior](https://github.com/p... | diff --git a/docs/api.md b/docs/api.md
index 1c6887c..f5286dd 100644
--- a/docs/api.md
+++ b/docs/api.md
@@ -20,7 +20,7 @@
>>> response = client.get('https://example.org')
```
-* `def __init__([auth], [cookies], [verify], [cert], [timeout], [pool_limits], [max_redirects], [app], [dispatch])`
+* `def __init__([auth]... |
encode__httpx-175 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "httpx/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/models.py:Qu... | encode/httpx | db6731a3d2dc882fc9bd9b9791544a2fba2cb559 | Change QueryParams(key=None) to not emit a parameter
This one I know is [`requests` behaviour](https://github.com/psf/requests/blob/9a2e5df000691ad28613524ca7f80aa28a94a8d5/requests/models.py#L101):
Take a dict:
```py
>>> from httpx import QueryParams
>>> params = {"thing_one": 1, "thing_two": [1,2,3], "thing_thr... | diff --git a/httpx/__init__.py b/httpx/__init__.py
index 8de5276..fd17441 100644
--- a/httpx/__init__.py
+++ b/httpx/__init__.py
@@ -34,6 +34,8 @@ from .interfaces import (
AsyncDispatcher,
BaseReader,
BaseWriter,
+ BaseBackgroundManager,
+ BasePoolSemaphore,
ConcurrencyBackend,
Dispatche... |
encode__httpx-199 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "httpx/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/client.py:Ba... | encode/httpx | ebbc003c55c5a0280208c4d7502bd6038520f29b | Erroneous Infinite Redirect Loop detected
Our redirect loop detection or redirects in general is broken somehow because this shouldn't error out:
```python
from httpx import Client
client = Client()
r = client.request("GET", "https://www.howsmyssl.com/a/check") # Completes successfully
r = client.request("G... | diff --git a/httpx/__init__.py b/httpx/__init__.py
index fd17441..39b44aa 100644
--- a/httpx/__init__.py
+++ b/httpx/__init__.py
@@ -32,10 +32,10 @@ from .exceptions import (
)
from .interfaces import (
AsyncDispatcher,
- BaseReader,
- BaseWriter,
BaseBackgroundManager,
BasePoolSemaphore,
+ Ba... |
encode__httpx-215 | [
{
"changes": {
"added_entities": [
"httpx/config.py:SSLConfig._load_client_certs"
],
"added_modules": null,
"edited_entities": [
"httpx/config.py:SSLConfig.__init__",
"httpx/config.py:SSLConfig.load_ssl_context_verify"
],
"edited_modules": [
"h... | encode/httpx | af907e85e175541289768e61ad21511cfa3ec1b7 | How to configure TLS beyond client certificate and CA root certs?
Typically in requests you can use a __HTTPAdapter__ to hijack and set the SSL context and define what ciphers to use, how does one go about doing the same in __httpx__? | diff --git a/httpx/config.py b/httpx/config.py
index 3d2fe1c..6d427b8 100644
--- a/httpx/config.py
+++ b/httpx/config.py
@@ -7,7 +7,7 @@ import certifi
from .__version__ import __version__
CertTypes = typing.Union[str, typing.Tuple[str, str], typing.Tuple[str, str, str]]
-VerifyTypes = typing.Union[str, bool]
+Veri... |
encode__httpx-222 | [
{
"changes": {
"added_entities": [
"httpx/dispatch/asgi.py:BodyIterator.mark_as_done"
],
"added_modules": null,
"edited_entities": [
"httpx/dispatch/asgi.py:ASGIDispatch.send",
"httpx/dispatch/asgi.py:BodyIterator.done"
],
"edited_modules": [
"... | encode/httpx | 79425b28d092a0e9d2577539a571467395b768c4 | Don't render Authorization, Proxy-Authorization headers, password in URLs
We could render them as `[secure]` when calling `__repr__` so that they're not exposed by logging services. Was wondering what others thought of this idea? | diff --git a/httpx/dispatch/asgi.py b/httpx/dispatch/asgi.py
index 23eebb0..e3b4b0a 100644
--- a/httpx/dispatch/asgi.py
+++ b/httpx/dispatch/asgi.py
@@ -78,7 +78,7 @@ class ASGIDispatch(AsyncDispatcher):
app_exc = None
status_code = None
headers = None
- response_started = asyncio.Even... |
encode__httpx-2354 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/_urls.py:QueryParams.__init__"
],
"edited_modules": [
"httpx/_urls.py:QueryParams"
]
},
"file": "httpx/_urls.py"
}
] | encode/httpx | 3eee17e69e43f74df2c9bfaa442da2feac81363c | httpx is deleting url query parameters that do not explicitly specify a value
The following program
```python
import asyncio
import httpx
async def main():
async with httpx.AsyncClient() as client:
r = await client.get("https://httpbin.org/get?foobar", params={'hello': "world"})
print(r.url... | diff --git a/httpx/_urls.py b/httpx/_urls.py
index cf4df38..1211bbb 100644
--- a/httpx/_urls.py
+++ b/httpx/_urls.py
@@ -540,7 +540,7 @@ class QueryParams(typing.Mapping[str, str]):
items: typing.Sequence[typing.Tuple[str, PrimitiveData]]
if value is None or isinstance(value, (str, bytes)):
... |
encode__httpx-237 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"httpx/client.py:BaseClient.__init__"
],
"edited_modules": [
"httpx/client.py:BaseClient"
]
},
"file": "httpx/client.py"
},
{
"changes": {
"added_entities"... | encode/httpx | a960a2a8fd273960993551f88617f22bfeb85035 | Handle HEAD responses with Brotli decoder
Currently if you receive a response with `Content-Encoding: br` set and no body we get an error because Brotli doesn't like being called on an empty stream. | diff --git a/docs/advanced.md b/docs/advanced.md
index 5ecf5a6..424d397 100644
--- a/docs/advanced.md
+++ b/docs/advanced.md
@@ -42,6 +42,21 @@ assert r.status_code == 200
assert r.text == "Hello World!"
```
+For some more complex cases you might need to customize the WSGI or ASGI
+dispatch. This allows you to:
+
+... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.