instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
frictionlessdata__frictionless-py-569 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "frictionless/config.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/... | frictionlessdata/frictionless-py | 5c96ea7859844a75091a6bf0586bf209ac385d48 | Provide an ability to work with float instead of decimal
# Overview
I tried using `frictionless extract` on a small-ish mostly numeric dataset (~50,000 x 500), and it took a very long time (12.5 mins) to process the data.
Using the API directly was a bit faster, but still slow (2 mins).
I profiled the two dif... | diff --git a/frictionless/config.py b/frictionless/config.py
index 27589796..40900edc 100644
--- a/frictionless/config.py
+++ b/frictionless/config.py
@@ -58,6 +58,7 @@ DEFAULT_DATETIME_PATTERN = "%Y-%m-%dT%H:%M:%S%z"
DEFAULT_DATE_PATTERN = "%Y-%m-%d"
DEFAULT_TIME_PATTERN = "%H:%M:%S%z"
DEFAULT_BARE_NUMBER = True
+D... |
frictionlessdata__frictionless-py-572 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/header.py:Header.__init__"
],
"edited_modules": [
"frictionless/header.py:Header"
]
},
"file": "frictionless/header.py"
}
] | frictionlessdata/frictionless-py | 3cd163e1deff2ffb4aa5cede714eaa8c1c954ac6 | Check.validate_header method doesn't get proper header list
# Overview
I'm currently migrating a project code based on `goodtables-py` to new `frictionless` framework.
I really appreciate the new `frictionless.Check` class that eases custom (extra) checks development. `prepare(self)` and `validate_task` methods he... | diff --git a/frictionless/header.py b/frictionless/header.py
index 5f16f356..e996e4f8 100644
--- a/frictionless/header.py
+++ b/frictionless/header.py
@@ -21,6 +21,7 @@ class Header(list):
assert len(field_positions) in (len(cells), len(schema.fields))
# Set attributes
+ original_cells = cell... |
frictionlessdata__frictionless-py-604 | [
{
"changes": {
"added_entities": [
"frictionless/field.py:Field.rdf_type"
],
"added_modules": null,
"edited_entities": [
"frictionless/field.py:Field.__init__"
],
"edited_modules": [
"frictionless/field.py:Field"
]
},
"file": "frictionles... | frictionlessdata/frictionless-py | c2f42c9fcc8e0311956841a2a74158f95e95364d | Resource/Package don't expose all standard properties
# Overview
E.g. this will fail:
- `Package(name='abcedf', keywords=['meep', 'beep', 'boop'], version='1.0.0')`
- `package.version`
# Tasks
- [x] Identify discrepancies between the specs and the framework
- [x] Add constructor arguments and instance proper... | diff --git a/frictionless/field.py b/frictionless/field.py
index 9e202b21..1fe08c45 100644
--- a/frictionless/field.py
+++ b/frictionless/field.py
@@ -27,6 +27,7 @@ class Field(Metadata):
format? (str): field format e.g. `default`
missing_values? (str[]): missing values
constraints? (dict): c... |
frictionlessdata__frictionless-py-611 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"frictionless/resource.py:Resource"
]
},
"file": "frictionless/resource.py"
}
] | frictionlessdata/frictionless-py | 3c45ffc8f240a8d09440a82ded422fe341141039 | External schema file not recognized as valid JSON object
# Overview
I'm trying to define the `schema` field within a `datapackage.json` for a Tabular Data Resource. As I read [in the spec](https://specs.frictionlessdata.io/tabular-data-resource/#specification), this field can either be a JSON object, or a string POS... | diff --git a/frictionless/resource.py b/frictionless/resource.py
index e18eec71..3c6720f8 100644
--- a/frictionless/resource.py
+++ b/frictionless/resource.py
@@ -1485,8 +1485,8 @@ class Resource(Metadata):
metadata_duplicate = True
metadata_Error = errors.ResourceError
metadata_profile = deepcopy(config... |
frictionlessdata__frictionless-py-672 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/detector.py:Detector.detect_encoding"
],
"edited_modules": [
"frictionless/detector.py:Detector"
]
},
"file": "frictionless/detector.py"
},
{
"chan... | frictionlessdata/frictionless-py | 6c6e212c1aa0916aed19b3a4bb40c01a57eb5650 | Encoding detection for a resource doesn't always work
# Overview
After `loader.buffer` introduction we got some regression in encoding detection. See xfailed tests | diff --git a/frictionless/detector.py b/frictionless/detector.py
index 5fc918b6..7416ec77 100644
--- a/frictionless/detector.py
+++ b/frictionless/detector.py
@@ -1,3 +1,4 @@
+import codecs
import chardet
from copy import copy, deepcopy
from .exception import FrictionlessException
@@ -98,7 +99,7 @@ class Detector:
... |
frictionlessdata__frictionless-py-724 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/helpers.py:deepsafe"
],
"edited_modules": [
"frictionless/helpers.py:deepsafe"
]
},
"file": "frictionless/helpers.py"
},
{
"changes": {
"adde... | frictionlessdata/frictionless-py | 55d71b51b6e0e15e7e6eb4bb5eaa221bae96344c | Fix resource.to_json/yaml when resource.data is not a list
# Overview
ATM it fails e.g. `to_yaml` after transform. In general, think about how to improve UX for resource after transform (they are inline)
| diff --git a/frictionless/helpers.py b/frictionless/helpers.py
index fb22133a..c5c9befa 100644
--- a/frictionless/helpers.py
+++ b/frictionless/helpers.py
@@ -72,18 +72,6 @@ def deepfork(value):
return value
-def deepsafe(value):
- if isinstance(value, dict):
- value = {key: deepsafe(value) for key, ... |
frictionlessdata__frictionless-py-733 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/steps/cell.py:cell_convert.transform_resource",
"frictionless/steps/cell.py:cell_fill.transform_resource",
"frictionless/steps/cell.py:cell_format.transform_resource",
... | frictionlessdata/frictionless-py | 83c97213aa8beaea8f9f3bc74bc48fc6104f71f5 | Reshaping steps pivot/recast/transpose don't work
# Overview
After changing the transform API it doesn't work because we need to infer a schema for a reshaped table manually now | diff --git a/docs/guides/transform-guide.md b/docs/guides/transform-guide.md
index 3a215ba5..2886c82f 100644
--- a/docs/guides/transform-guide.md
+++ b/docs/guides/transform-guide.md
@@ -75,27 +75,28 @@ There are dozens of other available steps that will be covered below.
Transforming a package is not much more diff... |
frictionlessdata__frictionless-py-742 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/file.py:File.__detect"
],
"edited_modules": [
"frictionless/file.py:File"
]
},
"file": "frictionless/file.py"
},
{
"changes": {
"added_entiti... | frictionlessdata/frictionless-py | 1c767b93e8e2b66d50d9b9c8383b1a803841e5a5 | Zipping a package fails if there a sql/ckan/etc resources
# Overview
We need to fix how loader/parser/resource.memory/remote/multipart work. Inicate bigquery/ckan/sql by resource.service?
| diff --git a/frictionless/error.py b/frictionless/error.py
index 5a196f2e..b0a4a104 100644
--- a/frictionless/error.py
+++ b/frictionless/error.py
@@ -6,6 +6,7 @@ from .metadata import Metadata
# effective as it can be very memory consumig. As an option we can store
# raw data without rendering an error template to a... |
frictionlessdata__frictionless-py-748 | [
{
"changes": {
"added_entities": [
"frictionless/plugins/stream.py:ReusableByteStream.__init__",
"frictionless/plugins/stream.py:ReusableByteStream.__getattr__",
"frictionless/plugins/stream.py:ReusableByteStream.read"
],
"added_modules": [
"frictionless/plugins... | frictionlessdata/frictionless-py | 6102ccd36997c0f6da4f3e8e7917cfb80084c2ed | Validation does not work with stream resources
Followup to #737
Example:
```python
from frictionless import Resource, validate_resource
with open("test.csv", "w") as f1:
f1.write("id,name\n1,german\n2,english")
with open('test.csv', 'rb') as f2:
resource = Resource(f2, format='csv')
print(valid... | diff --git a/docs/tutorials/schemes/buffer-tutorial.md b/docs/tutorials/schemes/buffer-tutorial.md
index f6d106a2..d5eac5bf 100644
--- a/docs/tutorials/schemes/buffer-tutorial.md
+++ b/docs/tutorials/schemes/buffer-tutorial.md
@@ -3,41 +3,35 @@ title: Buffer Tutorial
sidebar_label: Buffer
---
-Frictionless supports... |
frictionlessdata__frictionless-py-946 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/package.py:Package.metadata_validate"
],
"edited_modules": [
"frictionless/package.py:Package"
]
},
"file": "frictionless/package.py"
}
] | frictionlessdata/frictionless-py | 02e14a06659f0b2c1b5dd48eda3ae3eaf70018e3 | Resources with duplicate property "name" in datapackage.json files
# Overview
The `frictionless validate` option doesn't return any error if a datapackage.json contains two resources with the same "name" property.
I believe that it could be validated for two reasons:
Frist: Because as pointed in frictionless [... | diff --git a/frictionless/package.py b/frictionless/package.py
index f3cdc7f9..2ce2eb13 100644
--- a/frictionless/package.py
+++ b/frictionless/package.py
@@ -712,6 +712,9 @@ class Package(Metadata):
# Resources
for resource in self.resources:
yield from resource.metadata_errors
+ ... |
frictionlessdata__frictionless-py-952 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/errors/cell.py:CellError.from_row"
],
"edited_modules": [
"frictionless/errors/cell.py:CellError"
]
},
"file": "frictionless/errors/cell.py"
},
{
"... | frictionlessdata/frictionless-py | 1b5a274bba5b736d1d7c4fc4a3eb62e64f56d1c0 | Foreign key errors showing headers instead of row values
# Overview
* Version: **`v4.22.1`**
The foreign key errors returned in the report are the **header** values of the resource instead of the actual **row values**. Also, the message does not provide any hints about the problem: which is the foreign key violat... | diff --git a/frictionless/errors/cell.py b/frictionless/errors/cell.py
index b6dad8f0..c8455e4d 100644
--- a/frictionless/errors/cell.py
+++ b/frictionless/errors/cell.py
@@ -73,9 +73,10 @@ class CellError(RowError):
if field_name == name:
cell = row[field_name]
field_posi... |
frictionlessdata__frictionless-py-970 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/steps/field.py:field_update.transform_resource"
],
"edited_modules": [
"frictionless/steps/field.py:field_update"
]
},
"file": "frictionless/steps/field.py... | frictionlessdata/frictionless-py | 384aa2e1a8d6d7f200c7a8e5dd60a80334e403de | Transform problem while trying to move (`field_move`) a renamed field (`field_update`)
# Overview
Here is a simple test which reproduces the issue:
```python
def test_transform_rename_move_field():
target = transform(
data=[
{"id": 1, "name": "germany", "population": 83},
{"... | diff --git a/frictionless/steps/field.py b/frictionless/steps/field.py
index bb6a6823..c7eacfcb 100644
--- a/frictionless/steps/field.py
+++ b/frictionless/steps/field.py
@@ -313,6 +313,8 @@ class field_update(Step):
function = lambda val, row: simpleeval.simple_eval(formula, names=row)
if functio... |
frictionlessdata__frictionless-py-974 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/error.py:Error.__init__"
],
"edited_modules": [
"frictionless/error.py:Error"
]
},
"file": "frictionless/error.py"
},
{
"changes": {
"added_e... | frictionlessdata/frictionless-py | 10730f5d180d001875942d63c1f7b0339bf0e1fe | 302 redirect
# Overview
Using frictionless (4.21.2) CLI to validate a CSV file available from a 302 redirect URL leads to strange behaviour.
The incriminated URL is <https://demo.data.gouv.fr/fr/datasets/r/d4d78089-f218-40b6-a86a-d7cc4e624b0c>. It redirects to <https://static.data.gouv.fr/resources/donnees-essent... | diff --git a/frictionless/error.py b/frictionless/error.py
index b0a4a104..22d2ea5a 100644
--- a/frictionless/error.py
+++ b/frictionless/error.py
@@ -1,4 +1,5 @@
from .metadata import Metadata
+from . import helpers
# NOTE:
@@ -37,7 +38,7 @@ class Error(Metadata):
self.setinitial("name", self.name)
... |
frictionlessdata__frictionless-py-983 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/resource.py:Resource.__read_row_stream"
],
"edited_modules": [
"frictionless/resource.py:Resource"
]
},
"file": "frictionless/resource.py"
}
] | frictionlessdata/frictionless-py | d62ccf6efbe23020956d35ce396b3cef9af18d42 | Add ForeignKey fields in ForeignKey Error note
# Overview
When a ForeignKey Error is reported there is no way to know which ForiegnKey didn't validate.
Yet one resource can have multiple ForeignKeys attached to it.
It would help to add the Foreign Key Fields in the Error note.
I made a small edit in my local ve... | diff --git a/frictionless/resource.py b/frictionless/resource.py
index df607b68..f4fddd25 100644
--- a/frictionless/resource.py
+++ b/frictionless/resource.py
@@ -981,7 +981,12 @@ class Resource(Metadata):
continue
match = cells in group_lookup.get(group["so... |
frictionlessdata__frictionless-py-985 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"frictionless/file.py:File.__detect"
],
"edited_modules": [
"frictionless/file.py:File"
]
},
"file": "frictionless/file.py"
},
{
"changes": {
"added_entiti... | frictionlessdata/frictionless-py | 62bacb0df17feb61b18152c5042cb0277d4cd1e7 | Consider more flexible field initialization
The `frictionless.Schema` class ignores a list of [anything other than `dict`](https://github.com/frictionlessdata/frictionless-py/blob/bffe82989f0fc782cb51b0c83bf2dee521e55ad8/frictionless/schema.py#L287) for the `fields` keyword. Would you consider accepting any instance of... | diff --git a/frictionless/file.py b/frictionless/file.py
index 849b99b1..3de349ec 100644
--- a/frictionless/file.py
+++ b/frictionless/file.py
@@ -1,5 +1,6 @@
import os
import glob
+from collections.abc import Mapping
from pathlib import Path
from .helpers import cached_property
from . import settings
@@ -148,7 +1... |
frictionlessdata__frictionless-py-998 | [
{
"changes": {
"added_entities": [
"frictionless/field.py:Field.example"
],
"added_modules": null,
"edited_entities": [
"frictionless/field.py:Field.__init__"
],
"edited_modules": [
"frictionless/field.py:Field"
]
},
"file": "frictionless... | frictionlessdata/frictionless-py | 164f611b3a1454893e35c4c70101c2678728818d | Validate fields[].example for Schema
# Overview
Related to https://github.com/frictionlessdata/specs/pull/753
If a field has an `example` key, make sure that the `example` is valid according to the field's type and constraints.
| diff --git a/frictionless/field.py b/frictionless/field.py
index 2d812d86..085df79d 100644
--- a/frictionless/field.py
+++ b/frictionless/field.py
@@ -58,6 +58,7 @@ class Field(Metadata):
float_number=None,
decimal_char=None,
group_char=None,
+ example=None,
# Extra
s... |
frictionlessdata__goodtables-py-197 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"goodtables/presets/table.py:table"
],
"edited_modules": [
"goodtables/presets/table.py:table"
]
},
"file": "goodtables/presets/table.py"
}
] | frictionlessdata/goodtables-py | 25db6e4c20efc0a626323ed3bbef23845acbaf47 | Catch jsontableschema.exceptions.InvalidJSONError
# Overview
For `table` and `datapackage` datasets it has to be caught. See - https://sentry.io/open-knowledge/goodtablesio-production/issues/287753774/ | diff --git a/goodtables/presets/table.py b/goodtables/presets/table.py
index 0248096..940a85d 100644
--- a/goodtables/presets/table.py
+++ b/goodtables/presets/table.py
@@ -39,6 +39,10 @@ def table(source, schema=None, **options):
warnings.append(
'Table schema "%s" has a v... |
frictionlessdata__goodtables-py-224 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"goodtables/validate.py:validate"
],
"edited_modules": [
"goodtables/validate.py:validate"
]
},
"file": "goodtables/validate.py"
}
] | frictionlessdata/goodtables-py | fa0cc77e216a4cabdc581e09ab0a398c40d0ae37 | Posixpath support
Would be great if `goodtables` supported a [pathlib](https://docs.python.org/3/library/pathlib.html) `Posixpath` ...
Not sure, maybe it's only `stream.open` in `inspector.py`? | diff --git a/goodtables/validate.py b/goodtables/validate.py
index 19e85e4..f5d72f2 100644
--- a/goodtables/validate.py
+++ b/goodtables/validate.py
@@ -28,6 +28,15 @@ def validate(source, **options):
settings['custom_checks'] = options.pop('custom_checks', None)
settings = {key: value for key, value in setti... |
frictionlessdata__goodtables-py-315 | [
{
"changes": {
"added_entities": [
"goodtables/inspector.py:_local_file_not_found"
],
"added_modules": [
"goodtables/inspector.py:_local_file_not_found"
],
"edited_entities": [
"goodtables/inspector.py:Inspector.__inspect_table"
],
"edited_module... | frictionlessdata/goodtables-py | 037c7bf35c2dd7c14635c3e1d1b6ef2403c74f9e | Goodtables CLI should fail if received paths doesn't exist
For example:
```
$ goodtables foobar
DATASET
=======
{'error-count': 1,
'preset': 'nested',
'table-count': 1,
'time': 0.002,
'valid': False}
TABLE [1]
=========
{'error-count': 1,
'headers': [],
'ro... | diff --git a/goodtables/inspector.py b/goodtables/inspector.py
index e17e464..8491ace 100644
--- a/goodtables/inspector.py
+++ b/goodtables/inspector.py
@@ -4,6 +4,12 @@ from __future__ import print_function
from __future__ import absolute_import
from __future__ import unicode_literals
+import os
+try:
+ from ur... |
frictionlessdata__goodtables-py-331 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"goodtables/cli.py:validate",
"goodtables/cli.py:init"
],
"edited_modules": [
"goodtables/cli.py:validate",
"goodtables/cli.py:init"
]
},
"file": "goodta... | frictionlessdata/goodtables-py | 58bbf9f3d70a98317c1f2a71cd0f0559a367c3de | Goodtable init command should return 0 on success
It should also use sys.exit() instead of exit() | diff --git a/goodtables/cli.py b/goodtables/cli.py
index 6661cc8..186d227 100644
--- a/goodtables/cli.py
+++ b/goodtables/cli.py
@@ -4,6 +4,8 @@ from __future__ import print_function
from __future__ import absolute_import
from __future__ import unicode_literals
+from sys import exit
+
import click
import goodtabl... |
frictionlessdata__goodtables-py-350 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"goodtables/cells.py:create_cells",
"goodtables/cells.py:create_cell"
],
"edited_modules": [
"goodtables/cells.py:create_cells",
"goodtables/cells.py:create_cell"
... | frictionlessdata/goodtables-py | 9054e6b0f088e822a054c67992d9089f7312387c | Validation report gives blank-header and missing-value, when validating 'structure' for valid csv
# Overview
When trying to validate on the structure (no schema validation involved) for a source csv, we are getting `blank-header` and `missing-value` errors, when the structure of the csv is valid.
Trying to debug ... | diff --git a/goodtables/cells.py b/goodtables/cells.py
index 74763fb..c741a99 100644
--- a/goodtables/cells.py
+++ b/goodtables/cells.py
@@ -27,6 +27,7 @@ def create_cells(headers, schema_fields, values=None, row_number=None):
iterator = zip_longest(headers, schema_fields, values or [], fillvalue=fillvalue)
... |
frispete__keyrings.cryptfile-30 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "keyrings/cryptfile/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"keyri... | frispete/keyrings.cryptfile | c67599dbfd17aa7d36d339da223de023a3c77188 | Pull keyring storage password from an environment variable.
I'm trying to use this backend with PIP but the fact that the storage the password is always prompted for, breaks when pip prompts keyring for the actual password.
Is there a way to provide the storage password without user input? The readme shows an enviro... | diff --git a/CHANGES.md b/CHANGES.md
index 4191b8f..b595910 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -1,3 +1,7 @@
+1.4.1 (unreleased)
+==================
+- Support for pulling the database from from the environment variable `KEYRING_CRYPTFILE_PASSWORD`
+
1.4.0
=====
- Rename master branch to main
diff --git a/RE... |
frispete__keyrings.cryptfile-31 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"keyrings/cryptfile/file_base.py:FileBacked.file_path"
],
"edited_modules": [
"keyrings/cryptfile/file_base.py:FileBacked"
]
},
"file": "keyrings/cryptfile/file_base.py"... | frispete/keyrings.cryptfile | 7a8385066339ee08c6f608c0f8426fba801f4464 | custom the data file path with KEYRING_PROPERTY_* property
Need an env switch to control the output keyring data path to a custom location, such as `KEYRING_PROPERTY_CRYPTFILE_PATH` | diff --git a/CHANGES.md b/CHANGES.md
index b595910..ff5efde 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -1,6 +1,7 @@
1.4.1 (unreleased)
==================
- Support for pulling the database from from the environment variable `KEYRING_CRYPTFILE_PASSWORD`
+- Support for customizing the location of the encrypted file c... |
frmdstryr__magicattr-3 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"magicattr.py:get"
],
"edited_modules": [
"magicattr.py:get"
]
},
"file": "magicattr.py"
}
] | frmdstryr/magicattr | 4531a6bfc64ef9b9b0c2eb01c4a3cf9a5bfd00e9 | Support default values in get()
getattr() supports a default value if the attr doesn't exist. magicattr should mimic that behaviour. | diff --git a/magicattr.py b/magicattr.py
index dc8343e..282e186 100644
--- a/magicattr.py
+++ b/magicattr.py
@@ -17,7 +17,7 @@ _AST_TYPES = (ast.Name, ast.Attribute, ast.Subscript, ast.Call)
_STRING_TYPE = basestring if sys.version_info.major == 2 else str
-def get(obj, attr):
+def get(obj, attr, **kwargs):
"... |
fronzbot__blinkpy-24 | [
{
"changes": {
"added_entities": [
"blinkpy.py:_attempt_reauthorization"
],
"added_modules": [
"blinkpy.py:_attempt_reauthorization"
],
"edited_entities": [
"blinkpy.py:_request",
"blinkpy.py:BlinkCamera.__init__",
"blinkpy.py:BlinkCamera.sna... | fronzbot/blinkpy | b0cb3dda37ba51cf268112f7732ed38bd21fd9eb | Token Checking/Reauthorization
Token expires after 24hrs. Would like to add in a feature where the token are handled behind the scenes in order to be backwards compatible with existing module that rely on blinkpy (such as the home assistant Blink module).
Perhaps when blinkpy calls the _request function we do a toke... | diff --git a/CHANGES.rst b/CHANGES.rst
index cf9e38f..2a95b40 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -3,6 +3,10 @@ Changelog
A list of changes between each release
+0.6.0.dev1 (unreleased)
+^^^^^^^^^^^^^^^^^^
+- Added auto-reauthorization (token refresh) when a request fails due to an expired token
+
0.6.0... |
fronzbot__blinkpy-242 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"blinkpy/api.py:request_login",
"blinkpy/api.py:request_verify"
],
"edited_modules": [
"blinkpy/api.py:request_login",
"blinkpy/api.py:request_verify"
]
},
... | fronzbot/blinkpy | 9bc20cc82ea50a4cc774528eef7519563db55cf2 | New Login Method - blinkpy will stop working May 11th unless fixed!
**Describe the bug**
As of March 30, 2020 (according to the "What's New" section in the Blink App), 2FA will be available for blink. What this means for the blinkpy library is uncertain, but I wouldn't be surprised if current login methods begin to f... | diff --git a/README.rst b/README.rst
index e551b8c..d31f9fe 100644
--- a/README.rst
+++ b/README.rst
@@ -53,7 +53,12 @@ The simplest way to use this package from a terminal is to call ``Blink.start()`
blink = blinkpy.Blink(username='YOUR USER NAME', password='YOUR PASSWORD', refresh_rate=30)
blink.start()
-... |
fronzbot__blinkpy-272 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"blinkpy/blinkpy.py:Blink.setup_camera_list",
"blinkpy/blinkpy.py:Blink.setup_networks",
"blinkpy/blinkpy.py:Blink.download_videos"
],
"edited_modules": [
"blinkpy/bli... | fronzbot/blinkpy | 38fed26742e56e97c90b5103d772a9ca45a1a967 | 'None' responses improperly handled
https://github.com/fronzbot/blinkpy/blob/38fed26742e56e97c90b5103d772a9ca45a1a967/blinkpy/blinkpy.py#L179
If a `None` response is received, need to catch a `TypeError` which seems to not be done anywhere. See also #267 | diff --git a/blinkpy/blinkpy.py b/blinkpy/blinkpy.py
index 1d60d1e..671b380 100644
--- a/blinkpy/blinkpy.py
+++ b/blinkpy/blinkpy.py
@@ -152,7 +152,7 @@ class Blink:
{"name": camera["name"], "id": camera["id"]}
)
return all_cameras
- except KeyError:
+ ex... |
fronzbot__blinkpy-290 | [
{
"changes": {
"added_entities": [
"blinkpy/blinkpy.py:Blink.setup_owls"
],
"added_modules": null,
"edited_entities": [
"blinkpy/blinkpy.py:Blink.__init__",
"blinkpy/blinkpy.py:Blink.setup_post_verify"
],
"edited_modules": [
"blinkpy/blinkpy.py... | fronzbot/blinkpy | 31de65f1553008296c0870aa6fdd9a00d7c4fc13 | Support for Mini
**Is your feature request related to a problem? Please describe.**
I tried the Home Assistant integration, but don't get any devices, so I don't think the mini is supported yet.
**Describe the solution you'd like**
Support for the Blink mini.
**Additional context**
https://www.amazon.com/store... | diff --git a/blinkpy/blinkpy.py b/blinkpy/blinkpy.py
index 9f98f14..6b904f5 100644
--- a/blinkpy/blinkpy.py
+++ b/blinkpy/blinkpy.py
@@ -23,7 +23,7 @@ from dateutil.parser import parse
from slugify import slugify
from blinkpy import api
-from blinkpy.sync_module import BlinkSyncModule
+from blinkpy.sync_module impo... |
fronzbot__blinkpy-331 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"blinkpy/auth.py:Auth.header"
],
"edited_modules": [
"blinkpy/auth.py:Auth"
]
},
"file": "blinkpy/auth.py"
},
{
"changes": {
"added_entities": null,
... | fronzbot/blinkpy | 77959d6d94a76eb12d494c6c9c0f91c51d6b2013 | Error requesting networks
I have been running 0.15 for over a week now and no issues, but yesterday it started to error on self.get_networks()
```
Traceback (most recent call last):
File "scripts/grab-photo.py", line 9, in <module>
blink.start()
File "/var/services/homes/admin/.local/lib/python3.7/site-p... | diff --git a/blinkpy/auth.py b/blinkpy/auth.py
index 7d72645..34c85bb 100644
--- a/blinkpy/auth.py
+++ b/blinkpy/auth.py
@@ -53,7 +53,7 @@ class Auth:
"""Return authorization header."""
if self.token is None:
return None
- return {"Host": self.host, "TOKEN_AUTH": self.token}
+ ... |
fronzbot__blinkpy-37 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"blinkpy.py:Blink.__init__"
],
"edited_modules": [
"blinkpy.py:Blink"
]
},
"file": "blinkpy.py"
},
{
"changes": {
"added_entities": null,
"added_modu... | fronzbot/blinkpy | 2a4b0d3f4b5974c5b57a8723fa5d2d57f441408e | Ignore case when accessing camera name
Currently the camera dictionary can be accessed with the camera name, but case matters. We should ignore case sensitivity here to make it less annoying to access. | diff --git a/CHANGES.rst b/CHANGES.rst
index 3452982..be1cf91 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -6,6 +6,7 @@ A list of changes between each release
0.7.0.dev (development version)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- Fixed style errors for bumped pydocstring and pylint versions
+- Changed Blink.cameras dic... |
fronzbot__blinkpy-401 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"blinkpy/blinkpy.py:Blink.refresh"
],
"edited_modules": [
"blinkpy/blinkpy.py:Blink"
]
},
"file": "blinkpy/blinkpy.py"
},
{
"changes": {
"added_entities": ... | fronzbot/blinkpy | 0842739197bd4d8dc0f9e4f50cfb304410bbfb81 | Exception on blink.refresh
I'm attempting to automate capture from a Blink Mini camera but the `blink.refresh()` command always produces the following error:
```
blink.refresh()
File "/Users/lakario/Library/Python/3.8/lib/python/site-packages/blinkpy/helpers/util.py", line 144, in wrapper
result = method(*a... | diff --git a/blinkpy/blinkpy.py b/blinkpy/blinkpy.py
index 70abd8d..8205458 100644
--- a/blinkpy/blinkpy.py
+++ b/blinkpy/blinkpy.py
@@ -76,21 +76,22 @@ class Blink:
self.no_owls = no_owls
@util.Throttle(seconds=MIN_THROTTLE_TIME)
- def refresh(self, force=False):
+ def refresh(self, force=False, ... |
fronzbot__blinkpy-424 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"blinkpy/auth.py:Auth.header",
"blinkpy/auth.py:Auth.send_auth_key"
],
"edited_modules": [
"blinkpy/auth.py:Auth"
]
},
"file": "blinkpy/auth.py"
}
] | fronzbot/blinkpy | f6118ea4a7ef0d330754dda5ba6267f2797bb84d | Video download problem - "Unauthorized Access","code":101
I have been using Blinkpy to download videos to my PC for almost a year. Last time that I was able to download the video files was about 4 weeks ago. Today when I was trying to download new video files since my last downloading, I found the sizes of the download... | diff --git a/blinkpy/auth.py b/blinkpy/auth.py
index bc61387..c7e997b 100644
--- a/blinkpy/auth.py
+++ b/blinkpy/auth.py
@@ -58,7 +58,11 @@ class Auth:
"""Return authorization header."""
if self.token is None:
return None
- return {"TOKEN_AUTH": self.token, "user-agent": DEFAULT_US... |
fronzbot__blinkpy-429 | [
{
"changes": {
"added_entities": [
"blinkpy/api.py:request_logout"
],
"added_modules": [
"blinkpy/api.py:request_logout"
],
"edited_entities": null,
"edited_modules": null
},
"file": "blinkpy/api.py"
},
{
"changes": {
"added_entities": [
... | fronzbot/blinkpy | f68951fab759636d15a432e7eaf366d0d81cb9a3 | Add logout endpoint
**Is your feature request related to a problem? Please describe.**
If region info or anything gets stale, would be nice to be able to logout and log back in via the library
**Describe the solution you'd like**
Add the logout endpoint: https://github.com/MattTW/BlinkMonitorProtocol/blob/master/a... | diff --git a/blinkpy/api.py b/blinkpy/api.py
index 98fdb4f..0d77646 100644
--- a/blinkpy/api.py
+++ b/blinkpy/api.py
@@ -54,6 +54,12 @@ def request_verify(auth, blink, verify_key):
)
+def request_logout(blink):
+ """Logout of blink servers."""
+ url = f"{blink.urls.base_url}/api/v4/account/{blink.account... |
fronzbot__blinkpy-437 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"blinkpy/blinkpy.py:Blink.download_videos",
"blinkpy/blinkpy.py:Blink._parse_downloaded_items"
],
"edited_modules": [
"blinkpy/blinkpy.py:Blink"
]
},
"file": "bl... | fronzbot/blinkpy | 3c5caae93f2a00eb09427d27747aa83ce91179e1 | Add throttling to video downloads to mitigate risk of account suspension
Hi folks,
I would just like to inform you that Blink has suspended my account after using blinkpy-0.17.0 once to download my videos. I have downloaded my videos before using my own script based on the API calls used in blinkpy. Never had an iss... | diff --git a/README.rst b/README.rst
index 32d867c..7fcd6d9 100644
--- a/README.rst
+++ b/README.rst
@@ -174,13 +174,13 @@ Similar methods exist for individual cameras:
Download videos
----------------
-You can also use this library to download all videos from the server. In order to do this, you must specify a ``... |
fronzbot__blinkpy-526 | [
{
"changes": {
"added_entities": [
"blinkpy/blinkpy.py:Blink.setup_lotus"
],
"added_modules": null,
"edited_entities": [
"blinkpy/blinkpy.py:Blink.setup_camera_list"
],
"edited_modules": [
"blinkpy/blinkpy.py:Blink"
]
},
"file": "blinkpy/... | fronzbot/blinkpy | 43f048cf1320e47a66be5ff82b83c17c247c9dab | Blink Video Doorbell Support
**Describe the bug**
Related to https://github.com/home-assistant/core/issues/58662
Blink recently introduced video doorbells. After installation of hardware and activation on my existing Blink local system, the Video Doorbell does not appear in Home Assistant. No errors were logged by t... | diff --git a/blinkpy/blinkpy.py b/blinkpy/blinkpy.py
index eda5eb3..c316875 100644
--- a/blinkpy/blinkpy.py
+++ b/blinkpy/blinkpy.py
@@ -23,7 +23,7 @@ from dateutil.parser import parse
from slugify import slugify
from blinkpy import api
-from blinkpy.sync_module import BlinkSyncModule, BlinkOwl
+from blinkpy.sync_m... |
fronzbot__blinkpy-877 | [
{
"changes": {
"added_entities": [
"blinkpy/camera.py:BlinkCamera.battery_voltage"
],
"added_modules": null,
"edited_entities": [
"blinkpy/camera.py:BlinkCamera.__init__",
"blinkpy/camera.py:BlinkCamera.attributes",
"blinkpy/camera.py:BlinkCamera.extract_c... | fronzbot/blinkpy | bb4717592a1d297c5769da28edb8851241fc14b0 | Camera battery_level no longer reflects voltage
**Describe the bug**
Previously, the camera config.signals.battery JSON field appeared to reflect the voltage of the XT* camera's battery, in centivolts (i.e. 167 would mean 1.67v) (Note: the doorbell and the MINI cameras appeared to not report voltage).
However, as o... | diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
index 8cb6df4..cadcef8 100644
--- a/CONTRIBUTING.rst
+++ b/CONTRIBUTING.rst
@@ -85,7 +85,7 @@ You can then run all of the tests with the following command:
**Tips**
-If you only want to see if you can pass the local tests, you can run ``tox -e py37`` (or whatever... |
fronzbot__blinkpy-949 | [
{
"changes": {
"added_entities": [
"blinkpy/api.py:request_notification_flags",
"blinkpy/api.py:request_set_notification_flag"
],
"added_modules": [
"blinkpy/api.py:request_notification_flags",
"blinkpy/api.py:request_set_notification_flag"
],
"edite... | fronzbot/blinkpy | 31e53d1964f2d82a3ef55f908b23e9eacf37c341 | Disable Motion Notification While Maintaining Armed Status
**Is your feature request related to a problem? Please describe.**
I like to have videos recorded, but don't need to know every time my dog walks by a camera.
**Describe the solution you'd like**
I would like to be able to disable/"snooze" notifications o... | diff --git a/blinkpy/api.py b/blinkpy/api.py
index c412124..95dc280 100644
--- a/blinkpy/api.py
+++ b/blinkpy/api.py
@@ -166,6 +166,38 @@ async def request_system_disarm(blink, network, **kwargs):
return response
+async def request_notification_flags(blink, **kwargs):
+ """
+ Get system notification flag... |
frostming__marko-123 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"marko/block.py:FencedCode.match",
"marko/block.py:Paragraph.break_paragraph",
"marko/block.py:ListItem.__init__",
"marko/block.py:ListItem.parse_leading",
"marko/block.py... | frostming/marko | f7dfd20d1106bef06e2b7513b15be70ef8786f0a | Crash when parsing "- {NBSP}A"
Code that crashes is:
~~~
parser = Markdown(Parser, MarkdownRenderer)
with open(src_file_path, "r") as txtFile:
result = parser.parse(txtFile.read())
~~~
Markdown file is:
~~~
- A
~~~
Note that there is a unicode character U+00A0 right before the `A` that is a NBSP (non-... | diff --git a/marko/block.py b/marko/block.py
index 22cf1c5..10a2b9d 100644
--- a/marko/block.py
+++ b/marko/block.py
@@ -8,7 +8,7 @@ from typing import Match, Optional, Tuple, Union, cast
from . import inline, patterns
from .element import Element
-from .helpers import Source, is_paired, normalize_label
+from .help... |
frostming__python-cfonts-4 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "cfonts/__version__.py"
},
{
"changes": {
"added_entities": [
"cfonts/core.py:_strip_color"
],
"added_modules": [
"cf... | frostming/python-cfonts | 689ea448083092139fbecc4f7e7406e19843badb | Background colour doesn't span entire line
While kicking the tires, I noticed that my output differed from the tutorial:
I also tried outside of `ipython` from the CLI without any improvement.
- Termin... | diff --git a/.gitignore b/.gitignore
index 3dfcc77..f5f8a5c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,3 +6,4 @@ build/
.mypy_cache/
.pytest_cache/
_build/
+.vscode/
diff --git a/.travis.yml b/.travis.yml
index b9261b5..5c8bfa4 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,7 +5,7 @@ python:
- "3.4"
- "3... |
fsspec__filesystem_spec-1040 | [
{
"changes": {
"added_entities": [
"fsspec/asyn.py:AsyncFileSystem._pipe_file"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"fsspec/asyn.py:AsyncFileSystem"
]
},
"file": "fsspec/asyn.py"
},
{
"changes": {
"added_... | fsspec/filesystem_spec | 837ccdde1ac013f1a53a35d3477579ba57d0a6a5 | AttributeError: 'ZipFileSystem' object has no attribute 'zip'
When creating a `ZipFileSystem` object it is possible that `__init__` fails to create the `ZipFile` for example because of no permission to read. When python garbage collects this object there is an `AttributeError: 'ZipFileSystem' object has no attribute 'z... | diff --git a/fsspec/asyn.py b/fsspec/asyn.py
index 602901b..4563254 100644
--- a/fsspec/asyn.py
+++ b/fsspec/asyn.py
@@ -369,6 +369,9 @@ class AsyncFileSystem(AbstractFileSystem):
continue
raise ex
+ async def _pipe_file(self, path, value, **kwargs):
+ raise NotImplementedError... |
fsspec__filesystem_spec-1047 | [
{
"changes": {
"added_entities": [
"fsspec/spec.py:AbstractFileSystem.read_text",
"fsspec/spec.py:AbstractFileSystem.write_text",
"fsspec/spec.py:AbstractFileSystem.read_bytes",
"fsspec/spec.py:AbstractFileSystem.write_bytes"
],
"added_modules": null,
"edi... | fsspec/filesystem_spec | f4a2a804a706e27ea69f0f18ae580adda9577c43 | cat_file (or equivalent) that returns the contents in text mode
Currently, `cat_file` only returns the contents of the file as bytes. The decoded content as a string would be really useful.
I see two ways to implement this:
1) extend `cat_file()` with `mode`/`encoding`/`errors` kwargs to pass it down to `open`.
2)... | diff --git a/fsspec/spec.py b/fsspec/spec.py
index f37ca14..4cb0d5f 100644
--- a/fsspec/spec.py
+++ b/fsspec/spec.py
@@ -649,6 +649,50 @@ class AbstractFileSystem(metaclass=_Cached):
except: # noqa: E722
return False
+ def read_text(self, path, encoding=None, errors=None, newline=None, **kwa... |
fsspec__filesystem_spec-1094 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/generic.py:GenericFileSystem._cp_file"
],
"edited_modules": [
"fsspec/generic.py:GenericFileSystem"
]
},
"file": "fsspec/generic.py"
},
{
"changes": {
... | fsspec/filesystem_spec | 5d052473ffa0ff9064d41e3db37391d07d74e45f | Generic Filesystem does not await call to async function
**Describe the problem**
In generic.py on line 173, the function _cp_file of GenericFileSystem makes the following call:
`callback.set_size(maybe_await(f1.size))`
maybe_await is a wrapper that decides whether or not it's parameter is a Coroutine, and therefore... | diff --git a/docs/environment.yml b/docs/environment.yml
index b5f5a9d..814bd85 100644
--- a/docs/environment.yml
+++ b/docs/environment.yml
@@ -5,3 +5,4 @@ dependencies:
- python=3.9
- docutils<0.17
- numpydoc
+ - yarl
diff --git a/fsspec/generic.py b/fsspec/generic.py
index 360f59a..2796048 100644
--- a/fss... |
fsspec__filesystem_spec-1202 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/cached.py:WholeFileCacheFileSystem.cat"
],
"edited_modules": [
"fsspec/implementations/cached.py:WholeFileCacheFileSystem"
]
},
"file": "fsspec/i... | fsspec/filesystem_spec | 7c192d8211ab515fae4f96103f3af908616fe67c | bug: FSMap on_error option does not work with simplecache
Recently, I noticed that when I create a FSMap to a `simplecache` FS, the `on_error="omit"` does not work as intended. Here is an example, which is a modified version of `test_getitems_errors` in `/fsspec/tests/test_mapping.py` that I ran with FSSpec version 202... | diff --git a/fsspec/implementations/cached.py b/fsspec/implementations/cached.py
index 4a13834..31fb3ff 100644
--- a/fsspec/implementations/cached.py
+++ b/fsspec/implementations/cached.py
@@ -614,20 +614,28 @@ class WholeFileCacheFileSystem(CachingFileSystem):
getpaths = []
storepaths = []
f... |
fsspec__filesystem_spec-1245 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/utils.py:other_paths"
],
"edited_modules": [
"fsspec/utils.py:other_paths"
]
},
"file": "fsspec/utils.py"
}
] | fsspec/filesystem_spec | 834115f2b91f61d09004beb1bfd46d705a201c2b | Bug in recursive file copy into a destination directory
@ianthomas23
I have found a bug in fsspec `.get('', 'dest/', recursive=True)`
I've pinned the issue down to `fsspec.utils.other_paths`.
```python
In [1]: from fsspec.utils import other_paths
In [2]: out = other_paths(['a','b/','b/c'], 'dest/', is_di... | diff --git a/fsspec/utils.py b/fsspec/utils.py
index e402931..01c4495 100644
--- a/fsspec/utils.py
+++ b/fsspec/utils.py
@@ -369,7 +369,10 @@ def other_paths(paths, path2, is_dir=None, exists=False):
cp = common_prefix(paths)
if exists:
cp = cp.rsplit("/", 1)[0]
- path2 = [p.replac... |
fsspec__filesystem_spec-1273 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/reference.py:ReferenceFileSystem.__init__"
],
"edited_modules": [
"fsspec/implementations/reference.py:ReferenceFileSystem"
]
},
"file": "fsspec/... | fsspec/filesystem_spec | bbce5afb04ca98b52c7399bec4dc40cc50c9a738 | compressed reference files are broken since `fsspec=2023.04.0`
I can't seem to open references stored as compressed JSON files using `fsspec>=2023.04.0`.
## Steps to reproduce
```sh
wget https://github.com/pydata/xarray-data/blob/master/ROMS_example.nc
mamba create -n test python=3.11 ipython fsspec kerchunk h5py... | diff --git a/fsspec/implementations/reference.py b/fsspec/implementations/reference.py
index a17143a..f93fe45 100644
--- a/fsspec/implementations/reference.py
+++ b/fsspec/implementations/reference.py
@@ -620,17 +620,18 @@ class ReferenceFileSystem(AsyncFileSystem):
dic = dict(
**(ref_stor... |
fsspec__filesystem_spec-1302 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/cached.py:WholeFileCacheFileSystem._open",
"fsspec/implementations/cached.py:SimpleCacheFileSystem._open"
],
"edited_modules": [
"fsspec/implementation... | fsspec/filesystem_spec | 348d4ab5794de3b06d9899c1fc2fd2b418fe9109 | using filesystem methods with mapper keys
The mapper interface is really convenient, especially when working with nested urls like
```
zip://directory::https://example.host/path/to/file.zip
```
However, getting open file objects or querying file metadata is not as easy and requires explicit path / url manipulations... | diff --git a/fsspec/implementations/cached.py b/fsspec/implementations/cached.py
index 379cf04..1e3bf4f 100644
--- a/fsspec/implementations/cached.py
+++ b/fsspec/implementations/cached.py
@@ -695,7 +695,7 @@ class WholeFileCacheFileSystem(CachingFileSystem):
data = f.read(block)
... |
fsspec__filesystem_spec-1353 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/core.py:open_files",
"fsspec/core.py:url_to_fs"
],
"edited_modules": [
"fsspec/core.py:open_files",
"fsspec/core.py:url_to_fs"
]
},
"file": "fssp... | fsspec/filesystem_spec | 4eeba2ba2da6ec39ac98fa7e02af53b208446106 | Memory leak in `CachingFileSystem` (possibly caused by `pickle.load` ?)
I've been using `fsspec` caching support:
```python
urlpath = 'gs://mybucket/image.jpg'
fsspec.open(f'filecache::{urlpath}', filecache={'cache_storage': '/tmp/files', 'expiry_time': 604800})
```
I noticed that after opening many files (10k +... | diff --git a/fsspec/core.py b/fsspec/core.py
index 890ca81..6f3652c 100644
--- a/fsspec/core.py
+++ b/fsspec/core.py
@@ -210,7 +210,6 @@ def open_files(
num=1,
protocol=None,
newline=None,
- auto_mkdir=True,
expand=True,
**kwargs,
):
@@ -249,9 +248,6 @@ def open_files(
newline: bytes o... |
fsspec__filesystem_spec-1354 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/core.py:open_files",
"fsspec/core.py:url_to_fs"
],
"edited_modules": [
"fsspec/core.py:open_files",
"fsspec/core.py:url_to_fs"
]
},
"file": "fssp... | fsspec/filesystem_spec | 4eeba2ba2da6ec39ac98fa7e02af53b208446106 | File cache not cleared on program end
I am using fsspec in a Jupyter notebook to remotely access files. I've been using a `CachingFileSystem` to cache files in a local directory. However, the files I'm accessing are very large. Between runs of my notebook, it doesn't appear that the cache gets cleared. This fills up my... | diff --git a/fsspec/core.py b/fsspec/core.py
index 890ca81..6f3652c 100644
--- a/fsspec/core.py
+++ b/fsspec/core.py
@@ -210,7 +210,6 @@ def open_files(
num=1,
protocol=None,
newline=None,
- auto_mkdir=True,
expand=True,
**kwargs,
):
@@ -249,9 +248,6 @@ def open_files(
newline: bytes o... |
fsspec__filesystem_spec-1358 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/core.py:open_files",
"fsspec/core.py:url_to_fs"
],
"edited_modules": [
"fsspec/core.py:open_files",
"fsspec/core.py:url_to_fs"
]
},
"file": "fssp... | fsspec/filesystem_spec | 4eeba2ba2da6ec39ac98fa7e02af53b208446106 | `auto_mkdir` broken in `setitems`
When writing array data to a nested path, I get a FileNotFoundError for the file that is supposed to be written. This is because the parent directory does not exist, althoug fsspec should create it when needed. This is especially a problem with [`zarr`](https://github.com/zarr-develope... | diff --git a/fsspec/core.py b/fsspec/core.py
index 890ca81..6f3652c 100644
--- a/fsspec/core.py
+++ b/fsspec/core.py
@@ -210,7 +210,6 @@ def open_files(
num=1,
protocol=None,
newline=None,
- auto_mkdir=True,
expand=True,
**kwargs,
):
@@ -249,9 +248,6 @@ def open_files(
newline: bytes o... |
fsspec__filesystem_spec-1418 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/core.py:open_local"
],
"edited_modules": [
"fsspec/core.py:open_local"
]
},
"file": "fsspec/core.py"
},
{
"changes": {
"added_entities": null,
... | fsspec/filesystem_spec | 0c829ec586def531604bf3364e6cf7d1a14b9f49 | Inconsistent return type in open_local for string and pathlib.Path
If `open_local` is given a string URL for a local file without globs a string is returned. If the same URL is given as a `pathlib.Path` a list is returned.
```python
import fsspec
from pathlib import Path
url = "/path/to/file"
fsspec.open_loc... | diff --git a/fsspec/asyn.py b/fsspec/asyn.py
index 8dbdc70..ee71c35 100644
--- a/fsspec/asyn.py
+++ b/fsspec/asyn.py
@@ -106,7 +106,7 @@ def sync(loop, func, *args, timeout=None, **kwargs):
def sync_wrapper(func, obj=None):
- """Given a function, make so can be called in async or blocking contexts
+ """Given... |
fsspec__filesystem_spec-1419 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/utils.py:get_protocol"
],
"edited_modules": [
"fsspec/utils.py:get_protocol"
]
},
"file": "fsspec/utils.py"
}
] | fsspec/filesystem_spec | 0c829ec586def531604bf3364e6cf7d1a14b9f49 | can_be_local function not returning True in case of pathlib.Path
If a `pathlib.Path` is given to `fsspec.utils.can_be_local` `False` is returned.
I would expect `True` to be returned.
```python
from pathlib import Path
from fsspec.utils import can_be_local
p = Path("/path/to/file")
can_be_local(p) # -> Fal... | diff --git a/fsspec/utils.py b/fsspec/utils.py
index 34f1ad8..543bd89 100644
--- a/fsspec/utils.py
+++ b/fsspec/utils.py
@@ -436,6 +436,7 @@ def isfilelike(f: Any) -> TypeGuard[IO[bytes]]:
def get_protocol(url: str) -> str:
+ url = stringify_path(url)
parts = re.split(r"(\:\:|\://)", url, 1)
if len(pa... |
fsspec__filesystem_spec-1433 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/reference.py:ReferenceFileSystem._dircache_from_items"
],
"edited_modules": [
"fsspec/implementations/reference.py:ReferenceFileSystem"
]
},
"fil... | fsspec/filesystem_spec | 405406fe067ed8c1c777a4f208da709bcb2f80d2 | Missing sub-directories when listing root in `ReferenceFileSystem`
## Minimal reproduction
```python
import fsspec
from fsspec.implementations.reference import ReferenceFileSystem
print(f"fsspec: {fsspec.__version__}")
fs = ReferenceFileSystem({"a": "A", "B/C/b": "B", "B/C/d": "d", "B/_": "_"})
print(fs.ls(""... | diff --git a/fsspec/implementations/reference.py b/fsspec/implementations/reference.py
index b69e548..cfbd39f 100644
--- a/fsspec/implementations/reference.py
+++ b/fsspec/implementations/reference.py
@@ -985,16 +985,24 @@ class ReferenceFileSystem(AsyncFileSystem):
elif len(part) == 1:
si... |
fsspec__filesystem_spec-1436 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/reference.py:ReferenceFileSystem.cat"
],
"edited_modules": [
"fsspec/implementations/reference.py:ReferenceFileSystem"
]
},
"file": "fsspec/imple... | fsspec/filesystem_spec | 14a778879b6a68b65031ef86e232b9d88c005bab | bug in `ReferenceFileSystem.cat()` scrambles and omits reference mappings
This is an edge case, happens when `ReferenceFileSystem()`'s references do not have a protocol specified and we pass `.cat()` some missing reference(s) and set `oe_error='return` or `oe_error='omit`. See the reproducer below
### Reproducer
`... | diff --git a/fsspec/implementations/reference.py b/fsspec/implementations/reference.py
index cfbd39f..ebd54bc 100644
--- a/fsspec/implementations/reference.py
+++ b/fsspec/implementations/reference.py
@@ -798,20 +798,22 @@ class ReferenceFileSystem(AsyncFileSystem):
out = {}
for proto, paths in proto_... |
fsspec__filesystem_spec-1445 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/archive.py:AbstractArchiveFileSystem.info",
"fsspec/archive.py:AbstractArchiveFileSystem.ls"
],
"edited_modules": [
"fsspec/archive.py:AbstractArchiveFileSystem"
... | fsspec/filesystem_spec | 5cf9cd952c5d276835d3caef9c32fcf69d55b10c | glob("*") not returning any matches with ZipFileSystem
Using `glob("*")` does not return any matches with ZipFileSystem.
Example zipfile: [testdata.zip](https://github.com/fsspec/filesystem_spec/files/13559185/testdata.zip)
```
➜ unzip -l testdata.zip
Archive: testdata.zip
Length Date Time Name
--... | diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst
index a2e0d5c..45aa171 100644
--- a/docs/source/changelog.rst
+++ b/docs/source/changelog.rst
@@ -1,6 +1,13 @@
Changelog
=========
+2023.12.1
+---------
+
+Fixes
+
+- Remove trailing "/" from directory names in zipFS (#1445)
+
2023.12.0
---------
... |
fsspec__filesystem_spec-1452 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/core.py:split_protocol"
],
"edited_modules": [
"fsspec/core.py:split_protocol"
]
},
"file": "fsspec/core.py"
},
{
"changes": {
"added_entities": nu... | fsspec/filesystem_spec | 30e479b2f25020a70293d0ff4dc555388bc7bc33 | Local files with colons in name no longer readable after `2023.12.0` version
Newer `fsspec` versions [2023.12.1](https://github.com/fsspec/filesystem_spec/releases/tag/2023.12.1) and [2023.12.0](https://github.com/fsspec/filesystem_spec/releases/tag/2023.12.0) break the ability to read local files with `:` in the file ... | diff --git a/fsspec/core.py b/fsspec/core.py
index a1e15b2..8bc8e8e 100644
--- a/fsspec/core.py
+++ b/fsspec/core.py
@@ -521,7 +521,7 @@ def split_protocol(urlpath):
if len(protocol) > 1:
# excludes Windows paths
return protocol, path
- if ":" in urlpath and urlpath.find(":") > 1:
... |
fsspec__filesystem_spec-1465 | [
{
"changes": {
"added_entities": [
"fsspec/implementations/dirfs.py:DirFileSystem._pipe_file",
"fsspec/implementations/dirfs.py:DirFileSystem.pipe_file"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"fsspec/implementations/dirfs.py:D... | fsspec/filesystem_spec | dd8cb9bf620be4d9153e854dd1431c23a2be6db0 | `DirFileSystem.write_bytes` raises `NotImplementedError`
I've got a `DirFileSystem` wrapping a `LocalFileSystem` and am seeing a `NotImplementedError` when trying to use `write_bytes`.
```python-traceback
fs.write_bytes(filepath, blob)
Traceback (most recent call last):
File "C:\python\envs\dev-py310\lib\site-... | diff --git a/fsspec/implementations/dirfs.py b/fsspec/implementations/dirfs.py
index a3eac87..b1b3f6d 100644
--- a/fsspec/implementations/dirfs.py
+++ b/fsspec/implementations/dirfs.py
@@ -124,6 +124,12 @@ class DirFileSystem(AsyncFileSystem):
def pipe(self, path, *args, **kwargs):
return self.fs.pipe(sel... |
fsspec__filesystem_spec-1479 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/local.py:LocalFileSystem.ls"
],
"edited_modules": [
"fsspec/implementations/local.py:LocalFileSystem"
]
},
"file": "fsspec/implementations/local.... | fsspec/filesystem_spec | 069e107fa056166fd4e7db75e909ebac85f372fd | `LocalFileSystem.ls()` does not work on filenames
Repro:
```
fs = LocalFileSystem()
fs.touch("a.json")
fs.ls("a.json")
```
I expected this to return a single-entry list with the stat object for `a.json`, but instead it raises a `NotADirectoryError` because `os.scandir()` does not allow file-like inputs:
... | diff --git a/fsspec/implementations/local.py b/fsspec/implementations/local.py
index e7861e2..17f96c1 100644
--- a/fsspec/implementations/local.py
+++ b/fsspec/implementations/local.py
@@ -3,7 +3,6 @@ import io
import logging
import os
import os.path as osp
-import posixpath
import re
import shutil
import stat
@@... |
fsspec__filesystem_spec-1516 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/http.py:HTTPFileSystem._glob"
],
"edited_modules": [
"fsspec/implementations/http.py:HTTPFileSystem"
]
},
"file": "fsspec/implementations/http.py... | fsspec/filesystem_spec | 518984d494e48f007d8aa48de882ed7014da2574 | HTTPFileSystem.glob misses folders on fsspec>2023.10.0
Hello everyone,
Since #1382 was merged HTTPFileSystem's glob is missing folders for patterns ending in `"/*"`.
To reproduce:
```shell
mkdir share
mkdir share/folder1
touch share/file1.txt
python -m http.server -d share 8080
```
execute in another s... | diff --git a/fsspec/implementations/http.py b/fsspec/implementations/http.py
index 2ffb7ed..4580764 100644
--- a/fsspec/implementations/http.py
+++ b/fsspec/implementations/http.py
@@ -451,7 +451,7 @@ class HTTPFileSystem(AsyncFileSystem):
ends_with_slash = path.endswith("/") # _strip_protocol strips traili... |
fsspec__filesystem_spec-1536 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/core.py:get_fs_token_paths"
],
"edited_modules": [
"fsspec/core.py:get_fs_token_paths"
]
},
"file": "fsspec/core.py"
}
] | fsspec/filesystem_spec | 8a542c8c555614ab91fe07ce27a2d3dd3fd6700f | `fsspec.open()` doesn't work with square brackets in a filename
For example, `fsspec.open("filename[test].csv")`.
Is this by design or a bug? (python builtin `open` function works in this case, at least for python 3.11)
| diff --git a/fsspec/core.py b/fsspec/core.py
index 8bc8e8e..c6263a6 100644
--- a/fsspec/core.py
+++ b/fsspec/core.py
@@ -643,7 +643,10 @@ def get_fs_token_paths(
else:
paths = fs._strip_protocol(paths)
if isinstance(paths, (list, tuple, set)):
- paths = expand_paths_if_needed(paths, mode, num,... |
fsspec__filesystem_spec-1594 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/spec.py:AbstractBufferedFile.__eq__"
],
"edited_modules": [
"fsspec/spec.py:AbstractBufferedFile"
]
},
"file": "fsspec/spec.py"
}
] | fsspec/filesystem_spec | 05e88582e22fdf97c4cfc7ffb6ffa7923b1d19b2 | Comparing an AbstractBufferedFile (or subclass) with some objects might raise an exception
The [`__eq__` method of `AbstractBufferedFile`](https://github.com/fsspec/filesystem_spec/blob/95eb5f94d3230fcfa95052eef6cad1d951431ff5/fsspec/spec.py#L1553) assumes that the `other` element of the comparison has the `.mode` attr... | diff --git a/fsspec/spec.py b/fsspec/spec.py
index 9a7e4e8..bcc01f5 100644
--- a/fsspec/spec.py
+++ b/fsspec/spec.py
@@ -1698,7 +1698,12 @@ class AbstractBufferedFile(io.IOBase):
"""Files are equal if they have the same checksum, only in read mode"""
if self is other:
return True
- ... |
fsspec__filesystem_spec-1616 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/reference.py:ReferenceFileSystem._process_references1"
],
"edited_modules": [
"fsspec/implementations/reference.py:ReferenceFileSystem"
]
},
"fil... | fsspec/filesystem_spec | 3675a7cd163a3d7bc82f83e238ddc967f7b145c8 | KeyError when dict values and templates are used in ReferenceFileSystem
#1562 added support for `ReferenceFileSystem` to hold dicts. However, when templates are also present in the input JSON, initializing the file system results in a `KeyError`:
```python
def _process_references1(self, references, template_ove... | diff --git a/fsspec/implementations/reference.py b/fsspec/implementations/reference.py
index 06254fe..6e3de91 100644
--- a/fsspec/implementations/reference.py
+++ b/fsspec/implementations/reference.py
@@ -956,6 +956,8 @@ class ReferenceFileSystem(AsyncFileSystem):
if v.startswith("base64:"):
... |
fsspec__filesystem_spec-1622 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/cached.py:WholeFileCacheFileSystem._open"
],
"edited_modules": [
"fsspec/implementations/cached.py:WholeFileCacheFileSystem"
]
},
"file": "fsspec... | fsspec/filesystem_spec | 54ce0b42d5d791495d615ca9e47f846a848a0c57 | FileNotFoundError when using cache on memory store implementation
Dear all,
I'm struggling finding out why this is not working
When I use caching on a MemoryFileSystem, fsspec raises a FileNotFoundError with the ``open`` method.
Here is a reproducible example, I'm using version 2024.3.1, but this has been going on f... | diff --git a/fsspec/implementations/cached.py b/fsspec/implementations/cached.py
index 2d67052..707e684 100644
--- a/fsspec/implementations/cached.py
+++ b/fsspec/implementations/cached.py
@@ -651,7 +651,8 @@ class WholeFileCacheFileSystem(CachingFileSystem):
def _open(self, path, mode="rb", **kwargs):
pa... |
fsspec__filesystem_spec-1699 | [
{
"changes": {
"added_entities": [
"fsspec/implementations/dirfs.py:DirFileSystem.open_async"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"fsspec/implementations/dirfs.py:DirFileSystem"
]
},
"file": "fsspec/implementations/di... | fsspec/filesystem_spec | b842cf4cc7e4e22caa3110157cec9b4959582993 | DirFileSystem missing `open_async()` method for proper async operation
```python
import asyncio
import fsspec
async def async_test():
dirfs = fsspec.filesystem('dir', path='/tmp', asynchrnous=True)
file = await dirfs.open_async('hello', 'wb')
await file.close()
asyncio.run(async_test())
```
... | diff --git a/fsspec/implementations/dirfs.py b/fsspec/implementations/dirfs.py
index 6a28909..0bee864 100644
--- a/fsspec/implementations/dirfs.py
+++ b/fsspec/implementations/dirfs.py
@@ -370,3 +370,15 @@ class DirFileSystem(AsyncFileSystem):
*args,
**kwargs,
)
+
+ async def open_... |
fsspec__filesystem_spec-831 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/asyn.py:_run_coros_in_chunks"
],
"edited_modules": [
"fsspec/asyn.py:_run_coros_in_chunks"
]
},
"file": "fsspec/asyn.py"
},
{
"changes": {
"added_e... | fsspec/filesystem_spec | cf08ec23ffccc321b51bce2ffdc0186c25f17cc0 | FileNotFoundError [LocalFileSystem] on unix-like root / directory
Hello,
in case of `LocalFileSystem().ls('/')`, a `FileNotFoundError` is being raised.
```python
FileNotFoundError: [Errno 2] No such file or directory: ''
```
This looks quite normal as path is stripped right
https://github.com/fsspec/file... | diff --git a/ci/environment-win.yml b/ci/environment-win.yml
index 7e847e7..af9671e 100644
--- a/ci/environment-win.yml
+++ b/ci/environment-win.yml
@@ -8,7 +8,7 @@ dependencies:
- requests
- zstandard
- python-snappy
- - lz4
+ - lz4<3.1.3
- pyftpdlib
- cloudpickle
- pytest
diff --git a/fsspec/asyn.... |
fsspec__filesystem_spec-926 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/implementations/memory.py:MemoryFileSystem.rmdir",
"fsspec/implementations/memory.py:MemoryFileSystem.exists"
],
"edited_modules": [
"fsspec/implementations/memory.py:... | fsspec/filesystem_spec | e5346c87367addc6e020933cc8631a0262ae500a | fs.ls("/") raises error after fs.rm("/", recursive=True) for memory filesystem
To replicate this error, run this:
```python
import fsspec
fs = fsspec.filesystem("memory")
fs.rm("/", recursive=True)
fs.ls("/")
```
Which results in the following traceback:
```
Traceback (most recent call last):
File "... | diff --git a/fsspec/implementations/memory.py b/fsspec/implementations/memory.py
index 334f9db..9356a56 100644
--- a/fsspec/implementations/memory.py
+++ b/fsspec/implementations/memory.py
@@ -116,6 +116,9 @@ class MemoryFileSystem(AbstractFileSystem):
def rmdir(self, path):
path = self._strip_protocol(... |
fsspec__filesystem_spec-930 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/mapping.py:get_mapper"
],
"edited_modules": [
"fsspec/mapping.py:get_mapper"
]
},
"file": "fsspec/mapping.py"
},
{
"changes": {
"added_entities": n... | fsspec/filesystem_spec | dcd8b22a72c83481d40ab3edbe390ee3fa14ec69 | Make `url` in `get_mapper` optional
Currently when using a reference filesystem, users need to always provide an empty string `""` or `/` as the root url. Is there any reason not to set `""` or `/` as the default, so users can just do `fs.get_mapper()`? | diff --git a/fsspec/mapping.py b/fsspec/mapping.py
index d6346f4..8bad2de 100644
--- a/fsspec/mapping.py
+++ b/fsspec/mapping.py
@@ -187,7 +187,7 @@ def maybe_convert(value):
def get_mapper(
- url,
+ url="",
check=False,
create=False,
missing_exceptions=None,
diff --git a/fsspec/spec.py b/fssp... |
fsspec__filesystem_spec-931 | [
{
"changes": {
"added_entities": [
"fsspec/callbacks.py:TqdmCallback.__init__",
"fsspec/callbacks.py:TqdmCallback.set_size",
"fsspec/callbacks.py:TqdmCallback.relative_update",
"fsspec/callbacks.py:TqdmCallback.__del__"
],
"added_modules": [
"fsspec/call... | fsspec/filesystem_spec | dcd8b22a72c83481d40ab3edbe390ee3fa14ec69 | Docs could use an example for callbacks.
Hi !
Thank you for fsspec ! :heart: 🙏
I think the docs could use an example for callbacks. I've come up with this little hook with `tqdm`, not sure if it's the right way to do it:
```python
import tqdm
import fsspec
class FsspecTqdmCallback(tqdm.tqdm):
"""... | diff --git a/README.md b/README.md
index 411240c..bffc475 100644
--- a/README.md
+++ b/README.md
@@ -40,7 +40,7 @@ environments. First, install conda with tox and tox-conda in a base environment
used to configure a development environment and run tests.
First, setup a development conda environment via ``tox -e {env... |
fsspec__filesystem_spec-966 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"fsspec/implementations/libarchive.py:LibArchiveFileSystem"
]
},
"file": "fsspec/implementations/libarchive.py"
},
{
"changes": {
"added_entities... | fsspec/filesystem_spec | 22b2c5960cc2685acf4e691551150516856bd65f | Archive filesystems do not close file after deletion.
We noticed this undesired behaviour in one of out processes using fsspec:
```python
import fsspec
import psutil
import gc
fs = fsspec.filesystem("tar", fo="./foo.tar")
# here other things happen, eg
# filelist = fs.find("/")
del fs
gc.collect() # ret... | diff --git a/fsspec/implementations/http.py b/fsspec/implementations/http.py
index 0802932..126b410 100644
--- a/fsspec/implementations/http.py
+++ b/fsspec/implementations/http.py
@@ -209,7 +209,6 @@ class HTTPFileSystem(AsyncFileSystem):
kw.update(kwargs)
logger.debug(url)
- # TODO: extract... |
fsspec__filesystem_spec-996 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fsspec/archive.py:AbstractArchiveFileSystem.info"
],
"edited_modules": [
"fsspec/archive.py:AbstractArchiveFileSystem"
]
},
"file": "fsspec/archive.py"
}
] | fsspec/filesystem_spec | b5b7429403447b058147f4c2528259131da064b8 | info('/') doesn't seem to match ls('/') -- zip+http archive
Hi, I notice that the info method doesn't seem to be behaving as I would have expected expected (["returns a single dictionary, with exactly the same information as ``ls`` would with ``detail=True``."](https://github.com/fsspec/filesystem_spec/blob/b5b74294034... | diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
index 3044529..af54daa 100644
--- a/.github/workflows/main.yaml
+++ b/.github/workflows/main.yaml
@@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- TOXENV: [py37, py38, py39, s3fs, gcsfs]
+ TOXENV: [py38, ... |
ftao__python-ifcfg-27 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ifcfg/parser.py:Parser.parse",
"src/ifcfg/parser.py:Parser.alter",
"src/ifcfg/parser.py:WindowsParser.get_patterns",
"src/ifcfg/parser.py:UnixParser.get_patterns",
"s... | ftao/python-ifcfg | 3ae952775f66dc476ddb8f02953714e7676c9cff | ifcfg does not see multiple ip addresses on one interfaces
Hello,
using
```
>>> ifcfg.__version__
'0.13'
```
on a system where eth0 has more than one IP address:
```
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
link/ether b8:27:eb:50:39:69 b... | diff --git a/README.rst b/README.rst
index 68223c5..88220c4 100644
--- a/README.rst
+++ b/README.rst
@@ -23,7 +23,8 @@ Usage
for name, interface in ifcfg.interfaces().items():
# do something with interface
print interface['device']
- print interface['inet']
+ print interface['inet']... |
ftao__python-ifcfg-72 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
... | ftao/python-ifcfg | cbcaf1b5e9c7865577619b0f1cdec5ec5e3c89ad | inet is not populated when returning the ip address with an arrow notation (-->)
Hi,
I have a case where the inet value was being returned ok in version 0.22, but fails to populate when using version 0.23:
```
utun3: flags=8051<UP,POINTOPOINT,RUNNING,MULTICAST> mtu 1500
inet 10.11.11.72 --> 10.11.11.72 netmask... | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index bd0b837..ddfd967 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -8,6 +8,6 @@ repos:
- id: debug-statements
- id: end-of-file-fixer
- repo: https://github.com/pycqa/isort
- rev: 5.10.1
+ rev: 5.12.0
ho... |
ftnext__diy-googledrive-operate-5 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"main.py:main",
"main.py:cp_in_drive",
"main.py:parse_args"
],
"edited_modules": [
"main.py:main",
"main.py:cp_in_drive",
"main.py:parse_args"
]
... | ftnext/diy-googledrive-operate | 313b5fddd79da865e66edf018dc56b8ced186d64 | コピーしてできたファイルの名前をオプショナルで指定できる
指定しない時は今の挙動（copied_元のファイル名） | diff --git a/main.py b/main.py
index 4ffcb3f..04e6958 100644
--- a/main.py
+++ b/main.py
@@ -1,4 +1,5 @@
import argparse
+from typing import Optional
from operate_drive import create_diy_gdrive
from operate_drive.drive import DiyGoogleDrive
@@ -8,7 +9,7 @@ from operate_drive.file import DiyGDriveFile
def main():
... |
ftnext__diy-googledrive-operate-8 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"main.py:main",
"main.py:cp_in_drive",
"main.py:parse_args"
],
"edited_modules": [
"main.py:main",
"main.py:cp_in_drive",
"main.py:parse_args"
]
... | ftnext/diy-googledrive-operate | f8d1042c6516b6a24a7c11f5fba892e39a868f79 | コピーしたファイルが置かれるフォルダをidで指定できる
GoogleドライブのフォルダのURL中の文字列で指定する想定 | diff --git a/main.py b/main.py
index 04e6958..b4d2e18 100644
--- a/main.py
+++ b/main.py
@@ -9,7 +9,9 @@ from operate_drive.file import DiyGDriveFile
def main():
args = parse_args()
- dest_file = cp_in_drive(args.source_id, args.dest_title)
+ dest_file = cp_in_drive(
+ args.source_id, args.dest_tit... |
fujiisoup__py3nj-12 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "doc/conf.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
... | fujiisoup/py3nj | b40b8c5b74405644bd6936c07be267bf832bd49f | Unable to compute some values
```python
py3nj.wigner3j(4, 0, 0, 0, 0, 0)
```
gives an error
```python
IndexError: index 4 is out of bounds for axis 0 with size 1
```
| diff --git a/doc/conf.py b/doc/conf.py
index e2b803b..bd93ae3 100644
--- a/doc/conf.py
+++ b/doc/conf.py
@@ -29,25 +29,26 @@ print("py3nj: %s, %s" % (py3nj.__version__, py3nj.__file__))
# -- General configuration ------------------------------------------------
# If your documentation needs a minimal Sphinx version... |
fujiisoup__py3nj-8 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"py3nj/wigner.py:wigner9j"
],
"edited_modules": [
"py3nj/wigner.py:wigner9j"
]
},
"file": "py3nj/wigner.py"
}
] | fujiisoup/py3nj | df2d4391a9869e61a6c48ea1b1bab0625bc5291c | wigner 9j disagrees with online calculators
I want to know what following 9j symbol evaluates to
{ 3/2 3/2 1
2 2 2
1/2 1/2 1 }
A couple of online calculators say the value is around 0.048:
- http://www-stone.ch.cam.ac.uk/cgi-bin/wigner.cgi?symbol=9j&a=3%2F2&b=3%2F2&c=1&d=2&e=2&f=2&g=1%2F2&h=1%2F2&i=1
... | diff --git a/py3nj/wigner.py b/py3nj/wigner.py
index f9d15c1..01fd012 100644
--- a/py3nj/wigner.py
+++ b/py3nj/wigner.py
@@ -162,11 +162,11 @@ def wigner9j(two_l1, two_l2, two_l3, two_l4, two_l5, two_l6,
two_l1, two_l2, two_l3, two_l4, two_l5, two_l6, two_l7, two_l8, two_l9)
# calculat summation directo... |
fullflu__pydtr-9 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/pydtr/iqlearn/base.py:IqLearnBase._check_model_type",
"src/pydtr/iqlearn/base.py:IqLearnBase.fit",
"src/pydtr/iqlearn/base.py:IqLearnBase.get_params"
],
"edited_modules":... | fullflu/pydtr | 13d59092b7e3d289945611b27951e3011a9d3beb | fix get_params
# WHY
There is a bug in the `get_params` method (`self.models` cannot be sliced) :
```
for t, m in enumerate(self.models[:-1]): <-
```
# TODO
- [ ] fix the function
- [ ] add tests of the function | diff --git a/README.md b/README.md
index 0210681..76d80b4 100644
--- a/README.md
+++ b/README.md
@@ -15,7 +15,7 @@ Pydtr enables you to implement DTR methods easily by using sklearn-based interfa
| Method | Single binary treatment | Multiple treatments | Multinomial treatment ... |
fusion-energy__neutronics_material_maker-20 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"neutronics_material_maker/material.py:Material.from_mixture"
],
"edited_modules": [
"neutronics_material_maker/material.py:Material"
]
},
"file": "neutronics_material_m... | fusion-energy/neutronics_material_maker | 00619e8f53da4bbd01eff10cc7a787f299e0b40e | packing fraction usage
> This value is mutliplied by the density which allows packing_fraction to be taken into account for materials involving an amount of void. Recall that packing_fraction is equal to 1/void fraction
The documentation gives this statement for the packing_fraction parameter but it does not agree w... | diff --git a/neutronics_material_maker/material.py b/neutronics_material_maker/material.py
index fb4e7ab..141ce9b 100644
--- a/neutronics_material_maker/material.py
+++ b/neutronics_material_maker/material.py
@@ -62,8 +62,8 @@ class Material:
with a unique identifier.
packing_fraction: This value ... |
fzakaria__nix-auto-follow-16 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/nix_auto_follow/cli.py:Node.to_dict",
"src/nix_auto_follow/cli.py:LockFile.to_dict",
"src/nix_auto_follow/cli.py:start"
],
"edited_modules": [
"src/nix_auto_follo... | fzakaria/nix-auto-follow | 8994bf9d68e37352fe3eb2d8d506f3b5418fdc9f | Null inputs
The tool adds null inputs to the flake.lock, which I don't think is necessary:
| diff --git a/src/nix_auto_follow/cli.py b/src/nix_auto_follow/cli.py
index f18f7d3..b15d422 100644
--- a/src/nix_auto_follow/cli.py
+++ b/src/nix_auto_follow/cli.py
@@ -24,7 +24,15 @@ class Node:
return cls(inputs, remaining)
def to_dict(self) -> dict[str, Any]:
- return {"inputs": self.inputs, *... |
fzakaria__nix-auto-follow-21 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/nix_auto_follow/cli.py:Node.get_url"
],
"edited_modules": [
"src/nix_auto_follow/cli.py:Node"
]
},
"file": "src/nix_auto_follow/cli.py"
}
] | fzakaria/nix-auto-follow | a76c20cd36fb2b6fa4a58be4c5edf4ae6e143648 | Support git flake type
When checking an input like ``nixpkgs.url = "git+https://github.com/SuperSandro2000/nixpkgs.git?shallow=1&ref=nixos-unstable";`` the following error occurs:
```
Traceback (most recent call last):
File "/nix/store/bw8y4yyjwlz01gvi50q2zzaaqwpg0iig-nix-auto-follow/bin/.auto-follow-wrapped", l... | diff --git a/src/nix_auto_follow/cli.py b/src/nix_auto_follow/cli.py
index d07da12..7a353cb 100644
--- a/src/nix_auto_follow/cli.py
+++ b/src/nix_auto_follow/cli.py
@@ -3,6 +3,7 @@ import json
import sys
from dataclasses import dataclass, field
from typing import Any, TextIO
+from urllib.parse import urlencode
... |
fzakaria__nix-auto-follow-8 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/nix_auto_follow/cli.py:Node.get_url"
],
"edited_modules": [
"src/nix_auto_follow/cli.py:Node"
]
},
"file": "src/nix_auto_follow/cli.py"
}
] | fzakaria/nix-auto-follow | 5fd76160dd8d0e2b9bf231868e6430ddb5177f5a | Check crashing
Note this is on macOS if that matters. I attach my
[flake.lock.txt](https://github.com/user-attachments/files/16479126/flake.lock.txt)
`nix run github:fzakaria/nix-auto-follow -- -c`
gives
```
Node cachix has input nixpkgs pointing to nixpkgs_2 which is not the same as crate2nix's nixpkgs whi... | diff --git a/derivation.nix b/derivation.nix
index faf2089..39e6c0c 100644
--- a/derivation.nix
+++ b/derivation.nix
@@ -32,6 +32,11 @@ in
nativeCheckInputs = with python3Packages;
[pytestCheckHook flake8 mypy isort black]
+ ++ [
+ # FIXME: we are still types-pygments
+ types-colorama
+... |
ga4gh__vrs-python-247 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ga4gh/core/_internal/enderef.py:ga4gh_enref",
"src/ga4gh/core/_internal/enderef.py:ga4gh_deref"
],
"edited_modules": [
"src/ga4gh/core/_internal/enderef.py:ga4gh_enref",
... | ga4gh/vrs-python | ebbc8ef2a65a7c33c3d04abb9c77161f2c3937de | Add more tests for _from_gnomad | diff --git a/src/ga4gh/core/_internal/enderef.py b/src/ga4gh/core/_internal/enderef.py
index aaa7717..16198a3 100644
--- a/src/ga4gh/core/_internal/enderef.py
+++ b/src/ga4gh/core/_internal/enderef.py
@@ -8,9 +8,18 @@ typically be generated from the schema by
build_class_referable_attribute_map() in .models.py.
"""... |
ga4gh__vrs-python-345 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ga4gh/vrs/extras/translator.py:Translator.__init__",
"src/ga4gh/vrs/extras/translator.py:AlleleTranslator._from_beacon",
"src/ga4gh/vrs/extras/translator.py:AlleleTranslator._from_gn... | ga4gh/vrs-python | 253b10c2d04f3db5740fdd5dc9cd8324a4f4c381 | Allow reference sequence validation to be toggled for VCF annotation
Currently, kwargs can be passed into `_from_gnomad` to prevent validation of reference sequences (default `require_validation=True`) but this is not exposed to `VCFAnnotator.annotate()`. It would be great if we could pass in kwargs from VCFAnnotator t... | diff --git a/src/ga4gh/vrs/extras/translator.py b/src/ga4gh/vrs/extras/translator.py
index 1e6969f..dfe0bdc 100644
--- a/src/ga4gh/vrs/extras/translator.py
+++ b/src/ga4gh/vrs/extras/translator.py
@@ -6,7 +6,7 @@ Output formats: VRS (serialized), hgvs, spdi, gnomad (vcf)
"""
from collections.abc import Mapping
-fro... |
ga4gh__vrs-python-346 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ga4gh/vrs/extras/translator.py:Translator.__init__",
"src/ga4gh/vrs/extras/translator.py:AlleleTranslator._from_beacon",
"src/ga4gh/vrs/extras/translator.py:AlleleTranslator._from_gn... | ga4gh/vrs-python | 253b10c2d04f3db5740fdd5dc9cd8324a4f4c381 | ‘NoneType’ object has no attribute ‘root’ when getting HGVS from Python dict
I’m trying to get an hgvs ID from a python dict, but I’m running into problems when it does validation of `vo.state.sequence.root`, here’s the code I’m using…
```
allele = models.Allele(**allele_dict)
_id = translator.translate_to(allele,... | diff --git a/src/ga4gh/vrs/extras/translator.py b/src/ga4gh/vrs/extras/translator.py
index 1e6969f..dfe0bdc 100644
--- a/src/ga4gh/vrs/extras/translator.py
+++ b/src/ga4gh/vrs/extras/translator.py
@@ -6,7 +6,7 @@ Output formats: VRS (serialized), hgvs, spdi, gnomad (vcf)
"""
from collections.abc import Mapping
-fro... |
ga4gh__vrs-python-361 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ga4gh/vrs/extras/translator.py:Translator.__init__",
"src/ga4gh/vrs/extras/translator.py:AlleleTranslator.__init__",
"src/ga4gh/vrs/extras/translator.py:AlleleTranslator._post_proces... | ga4gh/vrs-python | 39fa48421ede0d435584c89c85182a5646bc777c | Add parameter to perform regex check in translate_from methods
I'm working on an issue in the variation normalizer, where we're first going to use the regex in the Translator, get the position to possibly liftover, and then use the translate from method to return the VRS representation. It would be nice to be able use ... | diff --git a/src/ga4gh/vrs/extras/translator.py b/src/ga4gh/vrs/extras/translator.py
index dfe0bdc..f3faa98 100644
--- a/src/ga4gh/vrs/extras/translator.py
+++ b/src/ga4gh/vrs/extras/translator.py
@@ -54,14 +54,12 @@ class Translator:
self,
data_proxy,
default_assembly_name="GRCh38",
- ... |
ga4gh__vrs-python-375 | [
{
"changes": {
"added_entities": [
"src/ga4gh/vrs/dataproxy.py:_DataProxy.validate_ref_seq"
],
"added_modules": [
"src/ga4gh/vrs/dataproxy.py:DataProxyValidationError"
],
"edited_entities": [
"src/ga4gh/vrs/dataproxy.py:_DataProxy.is_valid_ref_seq"
],
... | ga4gh/vrs-python | 2929677822b0189f1574003659cb56b46cb896db | DataProxy.is_valid_ref_seq() return signature simplificiation
I think the return object could be simplified here. If `is_valid` is always false when `err_msg` is anything other than an empty string, and always true if `err_msg` is an empty string, does it add any additional information? Could we rephrase this to simply... | diff --git a/src/ga4gh/vrs/dataproxy.py b/src/ga4gh/vrs/dataproxy.py
index 47732ff..51d70d9 100644
--- a/src/ga4gh/vrs/dataproxy.py
+++ b/src/ga4gh/vrs/dataproxy.py
@@ -22,6 +22,10 @@ import requests
_logger = logging.getLogger(__name__)
+class DataProxyValidationError(Exception):
+ """Class for validation erro... |
ga4gh__vrs-python-387 | [
{
"changes": {
"added_entities": [
"src/ga4gh/vrs/extras/translator.py:CnvTranslator._get_vrs_loc_start_end_val"
],
"added_modules": null,
"edited_entities": [
"src/ga4gh/vrs/extras/translator.py:CnvTranslator._from_hgvs"
],
"edited_modules": [
"src/ga... | ga4gh/vrs-python | a8925b24133f942675f383a1db422db88132013e | Add hgvs parsing support for `Range` based SequenceLocations
The current [hgvs_tools.py](https://github.com/ga4gh/vrs-python/blob/efbce313f501e86f9cc42565568d9d08a1cfaa85/src/ga4gh/vrs/utils/hgvs_tools.py#L16) does not consider the handling of hgvs expressions that have start or end `Range` values. I believe the biocom... | diff --git a/setup.cfg b/setup.cfg
index def13ba..b12ca2e 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -92,7 +92,7 @@ extras =
psycopg2-binary
biocommons.seqrepo>=0.5.1
bioutils>=0.5.2
- hgvs>=1.4
+ hgvs@git+https://github.com/biocommons/hgvs@225-uncertain-ranges
requests
dill~=0.3.7
cl... |
ga4gh__vrs-python-443 | [
{
"changes": {
"added_entities": [
"src/ga4gh/vrs/models.py:Range.validate_range",
"src/ga4gh/vrs/models.py:SequenceLocation.validate_start_end"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/ga4gh/vrs/models.py:Range",
"... | ga4gh/vrs-python | 10157c3fbd242c0217317cb749587a52f1588332 | SequenceLocation allows for negative start/end coordinates
https://github.com/ga4gh/vrs/blob/2.x/schema/vrs/json/SequenceLocation#L77
https://github.com/ga4gh/vrs/blob/2.x/schema/vrs/json/SequenceLocation#L88
We do not do any validation at the moment. We should add validation checks to follow what is stated in th... | diff --git a/src/ga4gh/vrs/models.py b/src/ga4gh/vrs/models.py
index bfe6279..70a85c8 100644
--- a/src/ga4gh/vrs/models.py
+++ b/src/ga4gh/vrs/models.py
@@ -27,7 +27,7 @@ from ga4gh.core import (
from ga4gh.core.pydantic import get_pydantic_root
from canonicaljson import encode_canonical_json
-from pydantic import ... |
gabrielfalcao__HTTPretty-207 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"httpretty/core.py:fakesock"
]
},
"file": "httpretty/core.py"
}
] | gabrielfalcao/HTTPretty | ac839f7b5a1a09e61e343f87cb399d2d8825bfb1 | httpretty crashes if program uses unix sockets
```
def connect(self, address):
self._address = (self._host, self._port) = address
```
Crashes with `too many values to unpack` because unix socket addresses are just files. Working on a PR. | diff --git a/httpretty/core.py b/httpretty/core.py
index 25926a0..a1b2469 100644
--- a/httpretty/core.py
+++ b/httpretty/core.py
@@ -290,9 +290,18 @@ class fakesock(object):
self.type = type
def connect(self, address):
- self._address = (self._host, self._port) = address
... |
gabrik__mvar-python-2 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "example/example.py"
},
{
"changes": {
"added_entities": [
"mvar/mvar.py:MVar.__enter__",
"mvar/mvar.py:MVar.__exit__",
"... | gabrik/mvar-python | 6188ff4e1e6d23a267c988c2fbf5171c1c1f7269 | Potentially dangerous behaviour
Hi there!
An `MVar` is one of the things I miss very much in python, thus I was happy to see there is a library addressing that. Thank you very much for that!
Unfortunately, I've encountered a few problems with the current implementation.
First, and most important: in a many-threa... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 82d11a0..087407b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,9 @@
# Changelog
All notable changes to this project will be documented in this file.
+## [1.0.0] - 2021-02-03
+### Changed
+- **MVar** is redefined to match Haskell's implementation more closely
... |
gaia-dpci__GaiaXPy-105 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/gaiaxpy/core/generic_functions.py:validate_error_correction"
],
"edited_modules": [
"src/gaiaxpy/core/generic_functions.py:validate_error_correction"
]
},
"file": "... | gaia-dpci/GaiaXPy | 7dfb2103bc0e9a410010957dd784c09f72f54cb5 | Error instead of warning when error_correction cannot be applied (GaiaXPy 2.1.1)
The generator tool can only apply error correction over built-in systems (this is systems shipped with the package) as a correction table file is required to correct the errors. In previous versions of the package, trying to apply error co... | diff --git a/src/gaiaxpy/core/generic_functions.py b/src/gaiaxpy/core/generic_functions.py
index 115939d..5bd204c 100644
--- a/src/gaiaxpy/core/generic_functions.py
+++ b/src/gaiaxpy/core/generic_functions.py
@@ -347,12 +347,6 @@ def format_additional_columns(additional_columns: Optional[Union[str, list, dict
... |
gammapy__gammapy-3731 | [
{
"changes": {
"added_entities": [
"gammapy/data/observations.py:Observation.rad_max"
],
"added_modules": null,
"edited_entities": [
"gammapy/data/observations.py:Observation.__init__"
],
"edited_modules": [
"gammapy/data/observations.py:Observation"
... | gammapy/gammapy | 7082581e8f6614d998d25a30da08c9b7018432a6 | Load global RAD_MAX header keyword into RAD_MAX hdu
* The PR #3515 added support for the `RAD_MAX_2D` IRF, stored as the RAD_MAX table in GADF.
* PR #3684 uses this to for energy dependent on region calculation relying on this RAD_MAX
It should be possible to use the mechanisms introduced in #3684 also when us... | diff --git a/gammapy/data/observations.py b/gammapy/data/observations.py
index cfa126665..add34e57c 100644
--- a/gammapy/data/observations.py
+++ b/gammapy/data/observations.py
@@ -35,9 +35,9 @@ class Observation:
Point spread function
bkg : `~gammapy.irf.Background3D`
Background rate model
- ... |
gammapy__gammapy-3837 | [
{
"changes": {
"added_entities": [
"gammapy/data/event_list.py:EventList.select_rad_max"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"gammapy/data/event_list.py:EventList"
]
},
"file": "gammapy/data/event_list.py"
},
{
... | gammapy/gammapy | e9464236ac26fcec555425d947b18daceffd567a | IRF.evaluate fails for IRFs with single energy bin
**Gammapy version**
Current master
**Bug description**
`IRF.evaluate` fails in the interpolation code when there is only a single energy bin, as for example is used with the global RAD_MAX:
**Expected behavior**
Returning the single global value.
... | diff --git a/gammapy/data/event_list.py b/gammapy/data/event_list.py
index 385a378ea..33c01a0ef 100644
--- a/gammapy/data/event_list.py
+++ b/gammapy/data/event_list.py
@@ -769,6 +769,34 @@ class EventList:
mask &= offset < offset_band[1]
return self.select_row_subset(mask)
+ def select_rad_max(s... |
gammapy__gammapy-3911 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gammapy/makers/core.py:Maker.__str__"
],
"edited_modules": [
"gammapy/makers/core.py:Maker"
]
},
"file": "gammapy/makers/core.py"
}
] | gammapy/gammapy | 3f564f66b5d9183d3174c1ea0246821c66d36dde | string representation of various Maker classes may cause a TypeError
This was tested against Gammapy 0.19 and the development version.
In some cases, printing (or using the string representation in another way) of an instance of a `gammapy.makers.Maker` subclass may cause a TypeError.
An example directly from the... | diff --git a/gammapy/makers/core.py b/gammapy/makers/core.py
index 8a84d2897..bf904d392 100644
--- a/gammapy/makers/core.py
+++ b/gammapy/makers/core.py
@@ -26,9 +26,9 @@ class Maker(abc.ABC):
max_len = np.max([len(_) for _ in names]) + 1
for name in names:
- value = getattr(self, name, "... |
gammapy__gammapy-3933 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gammapy/maps/region/geom.py:RegionGeom._rectangle_bbox",
"gammapy/maps/region/geom.py:RegionGeom.from_hdulist",
"gammapy/maps/region/geom.py:RegionGeom.plot_region"
],
"edite... | gammapy/gammapy | a55c6d964613081ab364ba994c899605a0a73c2c | plotting `ConstantSpatialModel`
`Models.plot_regions()/plot_positions()` fails if it contains any `ConstantSpatialModel` (or `ConstantFluxSpatialModel`), with a rather complicated error message. I suppose this is because there is no `position` defined for these models.
It would be nice to have this fixed before the... | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0e69a2253..d29f58780 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -131,7 +131,7 @@ jobs:
make docs-sphinx
- name: test code in docs and docstrings
run: |
- pytest --doctest-glob="*.rst" ... |
gammapy__gammapy-3964 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gammapy/irf/background.py:Background2D.plot_at_energy"
],
"edited_modules": [
"gammapy/irf/background.py:Background3D",
"gammapy/irf/background.py:Background2D"
]
}... | gammapy/gammapy | 2ed120bb84af5e84a948ac2578fda7c7d75800f6 | Mismatched argument list in Background2d.plot_at_energy
`Background2d.plot_at_energy()` fails due to the mismatched argument list between
https://github.com/gammapy/gammapy/blob/109931f0148386b80796a13f263955dfd1ae95ab/gammapy/irf/background.py#L156
and https://github.com/gammapy/gammapy/blob/109931f0148386b80796... | diff --git a/gammapy/irf/background.py b/gammapy/irf/background.py
index 82b07c581..25c47f083 100644
--- a/gammapy/irf/background.py
+++ b/gammapy/irf/background.py
@@ -122,7 +122,7 @@ class Background3D(BackgroundIRF):
tag = "bkg_3d"
required_axes = ["energy", "fov_lon", "fov_lat"]
- default_unit = u.s*... |
gammapy__gammapy-4133 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gammapy/datasets/map.py:MapDataset.info_dict"
],
"edited_modules": [
"gammapy/datasets/map.py:MapDataset"
]
},
"file": "gammapy/datasets/map.py"
},
{
"changes":... | gammapy/gammapy | fa09ca357460d651a8348e72df447ec80649c286 | 3D (Fermi) + 1D (LST/MAGIC PointSkyRegion-style) analysis. Global fit ignores the 1D.
**Gammapy version**
0.20.1
Are you using the latest stable version of Gammapy? (see https://gammapy.org/news.html)
yes
**Bug description**
Issue discussed already in slack (and I should probably have opened this ticket back ... | diff --git a/gammapy/datasets/map.py b/gammapy/datasets/map.py
index 624f81e81..fd94e17d8 100644
--- a/gammapy/datasets/map.py
+++ b/gammapy/datasets/map.py
@@ -1357,11 +1357,12 @@ class MapDataset(Dataset):
counts = 0
background, excess, sqrt_ts = np.nan, np.nan, np.nan
+
if self.counts:
-... |
gammapy__gammapy-5028 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gammapy/modeling/models/cube.py:TemplateNPredModel.write"
],
"edited_modules": [
"gammapy/modeling/models/cube.py:TemplateNPredModel"
]
},
"file": "gammapy/modeling/mod... | gammapy/gammapy | 6321261682b83528858a57baa34fd21b1100b9f4 | Writing of TemplateNPredModel allows no overwrite
The option `overwrite` is not passed to this line https://github.com/gammapy/gammapy/blob/6321261682b83528858a57baa34fd21b1100b9f4/gammapy/modeling/models/cube.py#L1007
As a result an error is raised if the map is already written and one cannot overwrite it even if t... | diff --git a/gammapy/modeling/models/cube.py b/gammapy/modeling/models/cube.py
index 72f034d44..9640cff1e 100644
--- a/gammapy/modeling/models/cube.py
+++ b/gammapy/modeling/models/cube.py
@@ -1004,7 +1004,7 @@ class TemplateNPredModel(ModelBase):
elif os.path.isfile(make_path(self.filename)) and not overwrite... |
gammapy__gammapy-5044 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gammapy/estimators/parameter.py:ParameterEstimator.estimate_ts"
],
"edited_modules": [
"gammapy/estimators/parameter.py:ParameterEstimator"
]
},
"file": "gammapy/estima... | gammapy/gammapy | 9ce6ab1eb9f3c651b1a80a526d7236768c1c7795 | stat_null is not available on FluxPoints objects created with gammapy
**Gammapy version**
present dev, 1.1
**Bug description**
For `FluxPoints` created with gammapy estimators, the quantity `stat_null` is not available.
**To Reproduce**
1. Run the `spectral analysis notebook`. Then, accessing `flux_points.... | diff --git a/gammapy/estimators/parameter.py b/gammapy/estimators/parameter.py
index d9ed6134f..9994a5f9c 100644
--- a/gammapy/estimators/parameter.py
+++ b/gammapy/estimators/parameter.py
@@ -114,6 +114,7 @@ class ParameterEstimator(Estimator):
* "ts" : fit statistic difference with null hypothesis.... |
gammapy__gammapy-5149 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gammapy/estimators/points/sensitivity.py:SensitivityEstimator.run"
],
"edited_modules": [
"gammapy/estimators/points/sensitivity.py:SensitivityEstimator"
]
},
"file": "... | gammapy/gammapy | fdd05df7453c294a8a898e7f790a0da17372f9d2 | Strange warning when running the `SensitivityEstimator`
**Gammapy version**
Current main:
```
Gammapy support for parallelisation with ray is still a prototype and is not fully functional.
System:
python_executable : /home/maxnoe/.local/conda/envs/gammapy-dev/bin/python3.9
python_version :... | diff --git a/gammapy/estimators/points/sensitivity.py b/gammapy/estimators/points/sensitivity.py
index f072a7dc6..3c2730f59 100644
--- a/gammapy/estimators/points/sensitivity.py
+++ b/gammapy/estimators/points/sensitivity.py
@@ -1,5 +1,4 @@
# Licensed under a 3-clause BSD style license - see LICENSE.rst
-import loggin... |
gaogaotiantian__coredumpy-21 | [
{
"changes": {
"added_entities": [
"src/coredumpy/coredumpy.py:Coredumpy.peek"
],
"added_modules": null,
"edited_entities": [
"src/coredumpy/coredumpy.py:Coredumpy.dump"
],
"edited_modules": [
"src/coredumpy/coredumpy.py:Coredumpy"
]
},
"... | gaogaotiantian/coredumpy | 869a0de830be63f0059d0a1ae88a238662eb5028 | Implement peek feature
To quickly get the gist of a dump or even dumps. | diff --git a/README.md b/README.md
index 3d5867a..cb33477 100644
--- a/README.md
+++ b/README.md
@@ -48,6 +48,8 @@ coredumpy.dump(path='coredumpy.dump')
coredumpy.dump(path=lambda: f"coredumpy_{time.time()}.dump")
# Specify a directory to keep the dump
coredumpy.dump(directory='./dumps')
+# Specify the description o... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.