instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
goodmami__wn-174 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wn/_core.py:Synset._get_relations"
],
"edited_modules": [
"wn/_core.py:Synset"
]
},
"file": "wn/_core.py"
}
] | goodmami/wn | 4d9100f2d94fa71f3224414527aaaf66f65b8c7c | Synset.relations() for some lexicons uses synset id as relation name
Compare the difference in the relation name for the `oewn` versus the `omw-fr` lexicons:
```pycon
>>> import wn
>>> wn.synsets('dog', pos='n', lexicon='oewn')[0].relations('hypernym')
{'hypernym': [Synset('oewn-02085998-n'), Synset('oewn-0132003... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4a066dc..e61eab7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,8 @@
`Wordnet` object ([#157], [#168])
* `Sense.word()` now creates a `Word` properly linked to the same
`Wordnet` object ([#157])
+* `Synset.relations()` uses the correct relation type for t... |
goodmami__wn-178 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "wn/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wn/_config.py:WNConfi... | goodmami/wn | 0ddfd89207affc28335ba16c948da70833257e8d | synset.relations fails with a KeyError
Hi! I'm trying to collect a dataset of relations between words in the engilsh WordNet.
However when I run the following code
```python
synset = wn.synset("omw-en31-00128106-n")
synset.relations()
``
it fails with the following traceback:
```
KeyError ... | diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
index f58286e..e0f96d6 100644
--- a/.github/workflows/checks.yml
+++ b/.github/workflows/checks.yml
@@ -10,9 +10,9 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v3
- n... |
google-deepmind__penzai-37 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"penzai/core/named_axes.py:NamedArrayBase.__array__",
"penzai/core/named_axes.py:NamedArrayBase.__jax_array__"
],
"edited_modules": [
"penzai/core/named_axes.py:NamedArrayBase... | google-deepmind/penzai | 098d65b0bfaae8fe6e62c6a383a02f18da195488 | [BUG] Order sensitivity for implicit casting of jax Arrays with infix operators
Adding shapeless Jax arrays to named arrays with infix notation works from the right, but not the left. This does not occur when you nmap the `jnp.add` function directly, so a potential solution might be to replace the `NamedArrayBase` dund... | diff --git a/penzai/core/named_axes.py b/penzai/core/named_axes.py
index 2e74ef4..7974978 100644
--- a/penzai/core/named_axes.py
+++ b/penzai/core/named_axes.py
@@ -867,29 +867,6 @@ class NamedArrayBase(abc.ABC):
index_thunks.append(_StaticThunk(c))
return _jitted_nmapped_getitem(self, tuple(index_thu... |
google-research__arxiv-latex-cleaner-102 | [
{
"changes": {
"added_entities": [
"arxiv_latex_cleaner/__main__.py:if_prefixed"
],
"added_modules": [
"arxiv_latex_cleaner/__main__.py:if_prefixed"
],
"edited_entities": null,
"edited_modules": null
},
"file": "arxiv_latex_cleaner/__main__.py"
},
... | google-research/arxiv-latex-cleaner | 1ba87713e81cc4924b2f8a50e61aba7554689cc2 | ValueError: Unmatched \ifthenelse
Hi, I tried the newest version (1.0.7) and got the following error
```
Traceback (most recent call last):
File "/opt/miniconda3/bin/arxiv_latex_cleaner", line 5, in <module>
from arxiv_latex_cleaner.__main__ import __main__
File "/opt/miniconda3/lib/python3.12/site-package... | diff --git a/README.md b/README.md
index 7121204..4d7ee17 100644
--- a/README.md
+++ b/README.md
@@ -126,7 +126,11 @@ usage: arxiv_latex_cleaner@v1.0.7 [-h] [--resize_images] [--im_size IM_SIZE]
[--images_allowlist IMAGES_ALLOWLIST]
[--keep_bib]
... |
google-research__arxiv-latex-cleaner-29 | [
{
"changes": {
"added_entities": [
"arxiv_latex_cleaner/arxiv_latex_cleaner.py:_remove_iffalse_block"
],
"added_modules": [
"arxiv_latex_cleaner/arxiv_latex_cleaner.py:_remove_iffalse_block"
],
"edited_entities": [
"arxiv_latex_cleaner/arxiv_latex_cleaner.py... | google-research/arxiv-latex-cleaner | 2045634c0b52bad482c9b3a0b507a7add84450e2 | Nested \iffalse \fi block comments.
I used \iffalse ... \fi to block comment in my latex document, and used this modification of the _remove_environment command:
```
def _remove_iffalse(text):
"""Removes '\\iffalse *\\fi' from 'text'."""
"""This has problems with nested \\iffalse \\fi statements"""
return... | diff --git a/arxiv_latex_cleaner/arxiv_latex_cleaner.py b/arxiv_latex_cleaner/arxiv_latex_cleaner.py
index 96dcd0c..bc12ddc 100644
--- a/arxiv_latex_cleaner/arxiv_latex_cleaner.py
+++ b/arxiv_latex_cleaner/arxiv_latex_cleaner.py
@@ -111,6 +111,36 @@ def _remove_environment(text, environment):
text)
+def _rem... |
google-research__arxiv-latex-cleaner-96 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"arxiv_latex_cleaner/arxiv_latex_cleaner.py:_remove_comments_inline"
],
"edited_modules": [
"arxiv_latex_cleaner/arxiv_latex_cleaner.py:_remove_comments_inline"
]
},
"fi... | google-research/arxiv-latex-cleaner | b7a0b3c3d5fe488ac02ab2e745a059d1ab641d7d | [Unexpected Behavior] Comments Not Removed on Lines with "auto-ignore"
While fixing issue #91, I discovered that comments in lines containing the word `auto-ignore` are not being removed as expected. This behavior is not documented in either the README or the help message, which may lead to unexpected outcomes for user... | diff --git a/arxiv_latex_cleaner/arxiv_latex_cleaner.py b/arxiv_latex_cleaner/arxiv_latex_cleaner.py
index 2b83c54..296e698 100644
--- a/arxiv_latex_cleaner/arxiv_latex_cleaner.py
+++ b/arxiv_latex_cleaner/arxiv_latex_cleaner.py
@@ -212,8 +212,10 @@ def _remove_iffalse_block(text):
def _remove_comments_inline(text):... |
google__GiftStick-137 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"auto_forensicate/recipes/disk.py:DiskArtifact.CloseStream",
"auto_forensicate/recipes/disk.py:DiskArtifact.GetDescription",
"auto_forensicate/recipes/disk.py:DiskRecipe._ListAllDisksMac"... | google/GiftStick | 342b0e2b09b88e8cf9e5b6b3b551535bf227a7e8 | Try to upload the "disk list" artifact before failing if no disk is detected
In https://github.com/google/GiftStick/blob/main/auto_forensicate/recipes/disk.py we raise if no "acquire-able" disk is detected, before trying to upload the list of all disks | diff --git a/auto_forensicate/recipes/disk.py b/auto_forensicate/recipes/disk.py
index 1e09f3f..79d47e4 100644
--- a/auto_forensicate/recipes/disk.py
+++ b/auto_forensicate/recipes/disk.py
@@ -133,7 +133,9 @@ class DiskArtifact(base.BaseArtifact):
code = self._ddprocess.returncode
error = self._ddprocess.stde... |
google__budou-16 | [
{
"changes": {
"added_entities": [
"budou/budou.py:Budou._update_punct_direction"
],
"added_modules": null,
"edited_entities": [
"budou/budou.py:Budou._get_chunks_with_api"
],
"edited_modules": [
"budou/budou.py:Budou"
]
},
"file": "budou... | google/budou | cb842ec0a8348245626af79ea755a51b658f7b73 | not proper grouping of comma (読点)
<img width="354" alt="default" src="https://cloud.githubusercontent.com/assets/968152/24842452/bcee80fa-1dd2-11e7-848a-86b683f9dab6.png">
in this case, comma (読点) should be grouped with former word (最終日).
<img width="357" alt="default" src="https://cloud.githubusercontent.com/a... | diff --git a/budou/budou.py b/budou/budou.py
index da1a28f..f547f61 100644
--- a/budou/budou.py
+++ b/budou/budou.py
@@ -26,6 +26,7 @@ from oauth2client.client import GoogleCredentials
import oauth2client.service_account
import re
import six
+import unicodedata
Chunk = collections.namedtuple('Chunk', ['word', 'po... |
google__capirca-266 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"capirca/lib/juniper.py:Juniper._TranslatePolicy"
],
"edited_modules": [
"capirca/lib/juniper.py:Term",
"capirca/lib/juniper.py:Juniper"
]
},
"file": "capirca/li... | google/capirca | 2b1c3519255fa0940a464521197d80187b355570 | Support multiple targets per header
Based on https://github.com/google/capirca/wiki/Policy-format#header-section I was under the impression that a header could have multiple targets, for example:
```
header {
target:: juniper testpol4 inet
target:: juniper testpol6 inet6
}
term default {
comment:: "test"... | diff --git a/capirca/lib/juniper.py b/capirca/lib/juniper.py
index c0a36ad..bfb0286 100644
--- a/capirca/lib/juniper.py
+++ b/capirca/lib/juniper.py
@@ -163,7 +163,8 @@ class Term(aclgenerator.Term):
'daddr': 'ip-destination-address',
'protocol': 'ip-protocol',
... |
google__cloud-forensics-utils-146 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"examples/aws_cli.py:CreateVolumeCopy"
],
"edited_modules": [
"examples/aws_cli.py:CreateVolumeCopy"
]
},
"file": "examples/aws_cli.py"
},
{
"changes": {
"... | google/cloud-forensics-utils | f4328fadfbbf4cfe5b009e9b04b75937477866f1 | Implement a more generic tagging feature for AWS
[`GetTagForResourceType()`](https://github.com/google/cloud-forensics-utils/blob/master/libcloudforensics/providers/aws/internal/common.py#L35) is currently leveraged to apply only the `Name` tag to resources. This functionality should be more generic and allow a user t... | diff --git a/examples/aws_cli.py b/examples/aws_cli.py
index d001c4b..d491596 100644
--- a/examples/aws_cli.py
+++ b/examples/aws_cli.py
@@ -17,6 +17,8 @@
# https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html #pylint: disable=line-too-long
"""Demo CLI tool for AWS."""
+import json
+
fr... |
google__cloud-forensics-utils-166 | [
{
"changes": {
"added_entities": [
"examples/aws_cli.py:ListImages"
],
"added_modules": [
"examples/aws_cli.py:ListImages"
],
"edited_entities": null,
"edited_modules": null
},
"file": "examples/aws_cli.py"
},
{
"changes": {
"added_entiti... | google/cloud-forensics-utils | 15dccb23ed1fc4fd93452962bde3010c7811247d | Starting a forensic VM outside of AWS region us-east-2 errors out
We create an EC2 instance of the analysis VM based on the below AMI.
https://github.com/google/cloud-forensics-utils/blob/40c7c86701413b2d2efc48734bf35279e8a18149/libcloudforensics/providers/aws/internal/common.py#L29
This AMI seems not to exist anym... | diff --git a/examples/aws_cli.py b/examples/aws_cli.py
index 3df2c2d..cf0f704 100644
--- a/examples/aws_cli.py
+++ b/examples/aws_cli.py
@@ -147,3 +147,19 @@ def StartAnalysisVm(args: 'argparse.Namespace') -> None:
print('Name: {0:s}, Started: {1:s}, Region: {2:s}'.format(vm[0].name,
... |
google__cloud-forensics-utils-186 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"examples/aws_cli.py:ListImages"
],
"edited_modules": [
"examples/aws_cli.py:ListImages"
]
},
"file": "examples/aws_cli.py"
},
{
"changes": {
"added_entiti... | google/cloud-forensics-utils | 935ef777447bed8f2ea07a5ed7c13e011095dab0 | Be consistent in type hinting named parameters
Ideally we would have `def foo(bar: Optional[Type] = None) -> ReturnType` for named parameters which default to `None` instead of `def foo(bar: Type = None) -> ReturnType`. As of now we have both across the codebase.
Note: we want to use `Optional` where it makes sense... | diff --git a/examples/aws_cli.py b/examples/aws_cli.py
index e9924af..089aedf 100644
--- a/examples/aws_cli.py
+++ b/examples/aws_cli.py
@@ -149,6 +149,7 @@ def StartAnalysisVm(args: 'argparse.Namespace') -> None:
str(vm[1]),
... |
google__cloud-forensics-utils-187 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"examples/cli.py:Main"
],
"edited_modules": [
"examples/cli.py:Main"
]
},
"file": "examples/cli.py"
},
{
"changes": {
"added_entities": null,
"added_... | google/cloud-forensics-utils | 6202cdecc9a9afdb8c1b1f4c6d5e69c19b6a0d92 | Limit the number of type hinting ignore statemetns
The codebase is riddled with `# type: ignore` statements, which defeats the purpose of using type hinting. Let's see if we can limit the usage of this. | diff --git a/examples/cli.py b/examples/cli.py
index 3bf318b..d1d8392 100644
--- a/examples/cli.py
+++ b/examples/cli.py
@@ -155,11 +155,13 @@ def Main() -> None:
AddParser('gcp', gcp_subparsers, 'copydisk', 'Create a GCP disk copy.',
args=[
('dst_project', 'Destination GCP project.', '... |
google__cloud-forensics-utils-219 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"libcloudforensics/providers/azure/forensics.py:CreateDiskCopy"
],
"edited_modules": [
"libcloudforensics/providers/azure/forensics.py:CreateDiskCopy"
]
},
"file": "libc... | google/cloud-forensics-utils | 5c7e31ebd5429ad704859ef67fbc7c3b1ff67816 | disk_type in CreateDiskCopy should default to the source's disk type
In CreateDisk(Volume)Copy methods, it'd be nice for the disk copy to have the same disk type as the source disk, instead of a default disk type for all copies. | diff --git a/libcloudforensics/providers/azure/forensics.py b/libcloudforensics/providers/azure/forensics.py
index de7d1f8..3c03381 100644
--- a/libcloudforensics/providers/azure/forensics.py
+++ b/libcloudforensics/providers/azure/forensics.py
@@ -30,7 +30,7 @@ def CreateDiskCopy(
resource_group_name: str,
i... |
google__cloud-forensics-utils-221 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"libcloudforensics/providers/aws/forensics.py:CreateVolumeCopy",
"libcloudforensics/providers/aws/forensics.py:StartAnalysisVm"
],
"edited_modules": [
"libcloudforensics/provi... | google/cloud-forensics-utils | 1a3510b6363ca5688cabcff85bc774d13ae18f43 | Add disk type option for CreateVolumeCopy in AWS
Allow users to choose the volume type when making a volume copy, and default to the source volume type if none choses. | diff --git a/libcloudforensics/providers/aws/forensics.py b/libcloudforensics/providers/aws/forensics.py
index 4bc6f4e..1f80d04 100644
--- a/libcloudforensics/providers/aws/forensics.py
+++ b/libcloudforensics/providers/aws/forensics.py
@@ -30,6 +30,7 @@ def CreateVolumeCopy(zone: str,
dst_zone: O... |
google__cloud-forensics-utils-266 | [
{
"changes": {
"added_entities": [
"libcloudforensics/providers/gcp/internal/compute.py:GoogleComputeInstance.Delete",
"libcloudforensics/providers/gcp/internal/compute.py:GoogleComputeDisk.Delete"
],
"added_modules": null,
"edited_entities": [
"libcloudforensics/... | google/cloud-forensics-utils | 375fb7c7be448c225d81a40ae1cb04cbf60ef9ae | Consider adding deleteInstance/deleteDisks
This would be nice to have when implementing CI tests, and we want a way to cleanup stuff | diff --git a/libcloudforensics/errors.py b/libcloudforensics/errors.py
index d6201c4..2edb5cb 100644
--- a/libcloudforensics/errors.py
+++ b/libcloudforensics/errors.py
@@ -60,5 +60,7 @@ class ResourceNotFoundError(LCFError):
class ResourceCreationError(LCFError):
"""Error when an issue with creating a new resour... |
google__cloud-forensics-utils-330 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"libcloudforensics/providers/gcp/internal/compute.py:GoogleCloudCompute.GetOrCreateAnalysisVm"
],
"edited_modules": [
"libcloudforensics/providers/gcp/internal/compute.py:GoogleCloudC... | google/cloud-forensics-utils | d33bbfe4b6d26211660884d59c552cdae410b5d9 | Sanitize CPU number in GCP VM creation
Currently users can specify an arbitrary number of CPUs, but not all of them are valid. It would be good to check this before attempting to create the VM. | diff --git a/libcloudforensics/providers/gcp/internal/compute.py b/libcloudforensics/providers/gcp/internal/compute.py
index e7c9926..7dcb244 100644
--- a/libcloudforensics/providers/gcp/internal/compute.py
+++ b/libcloudforensics/providers/gcp/internal/compute.py
@@ -34,6 +34,13 @@ if TYPE_CHECKING:
logging_utils.Set... |
google__cloud-forensics-utils-332 | [
{
"changes": {
"added_entities": [
"libcloudforensics/providers/azure/internal/common.py:_ParseCredentialsFile",
"libcloudforensics/providers/azure/internal/common.py:_CheckAzureCliCredentials"
],
"added_modules": [
"libcloudforensics/providers/azure/internal/common.py:... | google/cloud-forensics-utils | a849b99e780726969fd3fecf8ccab1d4ddcc5ebd | Add support for AzureCliCredential auth
Add support for `az login` style authentication.
LCF currently uses DefaultAzureCredential which supports AzureCliCredential but the [GetCredentials](https://github.com/google/cloud-forensics-utils/blob/e010499745273e10bda3f030c734a3469c0a0296/libcloudforensics/providers/azur... | diff --git a/.gitignore b/.gitignore
index bc709a3..5fcabb9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,3 +11,6 @@ dist/
# virtualenv
venv/
ENV/
+
+# VSCode
+.vscode/
\ No newline at end of file
diff --git a/libcloudforensics/providers/azure/internal/common.py b/libcloudforensics/providers/azure/internal/common.... |
google__cloud-forensics-utils-335 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"libcloudforensics/providers/gcp/internal/log.py:GoogleCloudLog.__init__",
"libcloudforensics/providers/gcp/internal/log.py:GoogleCloudLog.ListLogs",
"libcloudforensics/providers/gcp/inte... | google/cloud-forensics-utils | 943ebc9af77b45c073536d993fa072e5cf641bc7 | GCP log query should handle searching more than one resource
It would be useful if we were able to execute a single query against all available resources (projects, organizations etc.).
`GoogleCloudLog` currently accepts a single project ID and uses that for where to perform its search. This is probably fine for mos... | diff --git a/libcloudforensics/providers/gcp/internal/log.py b/libcloudforensics/providers/gcp/internal/log.py
index 1a63b7d..3d2dc97 100644
--- a/libcloudforensics/providers/gcp/internal/log.py
+++ b/libcloudforensics/providers/gcp/internal/log.py
@@ -13,7 +13,7 @@
# See the License for the specific language governin... |
google__cloud-forensics-utils-343 | [
{
"changes": {
"added_entities": [
"libcloudforensics/providers/gcp/internal/monitoring.py:GoogleCloudMonitoring._BuildCpuUsageFilter",
"libcloudforensics/providers/gcp/internal/monitoring.py:GoogleCloudMonitoring.GetCpuUsage"
],
"added_modules": null,
"edited_entities": ... | google/cloud-forensics-utils | 5dcbba6e20ffbea1421a45bcc6511103e7c8c44b | Show CPU usage of an instance
Would be awesome to be able to see the CPU usage of an instance to understand if its been breached. | diff --git a/libcloudforensics/providers/gcp/internal/monitoring.py b/libcloudforensics/providers/gcp/internal/monitoring.py
index 2a88ed0..a90644d 100644
--- a/libcloudforensics/providers/gcp/internal/monitoring.py
+++ b/libcloudforensics/providers/gcp/internal/monitoring.py
@@ -15,7 +15,7 @@
"""Google Cloud Monitori... |
google__cloud-forensics-utils-381 | [
{
"changes": {
"added_entities": [
"libcloudforensics/providers/gcp/internal/cloudresourcemanager.py:GoogleCloudResourceManager.__init__"
],
"added_modules": null,
"edited_entities": [
"libcloudforensics/providers/gcp/internal/cloudresourcemanager.py:GoogleCloudResourceMa... | google/cloud-forensics-utils | ab100f1d26bba8aba45eab16e028cbd1228a43c7 | Improve usability of new GCP functionality
Improve structure of objects returned from:
* `GoogleComputeInstance.GetEffectiveFirewallRules`
* `GoogleCloudMonitoring.GetCpuUsage`
| diff --git a/libcloudforensics/providers/gcp/internal/cloudresourcemanager.py b/libcloudforensics/providers/gcp/internal/cloudresourcemanager.py
index 175089f..d908745 100644
--- a/libcloudforensics/providers/gcp/internal/cloudresourcemanager.py
+++ b/libcloudforensics/providers/gcp/internal/cloudresourcemanager.py
@@ ... |
google__cloud-forensics-utils-427 | [
{
"changes": {
"added_entities": [
"libcloudforensics/providers/gcp/internal/cloudresourcemanager.py:GoogleCloudResourceManager.GetIamPolicy"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"libcloudforensics/providers/gcp/internal/cloudresour... | google/cloud-forensics-utils | c5f4d5edd525a702f7d953b4bc3a9ee62be53334 | Add projects.getIamPolicy to GCP cloudresourcemanager module
Will enable listing IAM bindings on GCP projects. API reference https://cloud.google.com/resource-manager/reference/rest/v3/projects/getIamPolicy | diff --git a/libcloudforensics/providers/gcp/internal/cloudresourcemanager.py b/libcloudforensics/providers/gcp/internal/cloudresourcemanager.py
index 94016d2..d138df4 100644
--- a/libcloudforensics/providers/gcp/internal/cloudresourcemanager.py
+++ b/libcloudforensics/providers/gcp/internal/cloudresourcemanager.py
@@ ... |
google__cloud-forensics-utils-440 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"libcloudforensics/errors.py:AmbiguousIdentifierError"
],
"edited_entities": null,
"edited_modules": null
},
"file": "libcloudforensics/errors.py"
},
{
"changes": {
"added_entities": [
"... | google/cloud-forensics-utils | 719093b4a229e5e97c30d93faabb1ccf3b6ee422 | Add support for specifying resources by ID as well as name
Add support for accessing resources by ID as well as name, for example instance ID for GetInstance.
Instance names are treated as project-wide unique identifiers
## Issue Description
Instance names are only unique within a zone, not project wide.
For exampl... | diff --git a/libcloudforensics/errors.py b/libcloudforensics/errors.py
index 38714e8..9256e8f 100644
--- a/libcloudforensics/errors.py
+++ b/libcloudforensics/errors.py
@@ -89,5 +89,10 @@ class TransferCreationError(LCFError):
class TransferExecutionError(LCFError):
"""Error when an issue with running a transfer jo... |
google__cloud-forensics-utils-444 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"libcloudforensics/providers/gcp/internal/compute.py:GoogleCloudCompute.ListInstances",
"libcloudforensics/providers/gcp/internal/compute.py:GoogleCloudCompute.GetInstance"
],
"edited... | google/cloud-forensics-utils | 4a2f66c90b6be28f307c13559a2ff4d541b7c5b3 | Add support for specifying resources by ID as well as name
Add support for accessing resources by ID as well as name, for example instance ID for GetInstance. | diff --git a/libcloudforensics/providers/gcp/internal/compute.py b/libcloudforensics/providers/gcp/internal/compute.py
index 5103574..0c16d10 100644
--- a/libcloudforensics/providers/gcp/internal/compute.py
+++ b/libcloudforensics/providers/gcp/internal/compute.py
@@ -46,6 +46,10 @@ E2_STANDARD_CPU_CORES = [2, 4, 8, 16... |
google__cloud-forensics-utils-489 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"libcloudforensics/providers/azure/internal/compute.py:AZCompute.GetOrCreateAnalysisVm",
"libcloudforensics/providers/azure/internal/compute.py:AZCompute.ListInstanceTypes",
"libcloudfore... | google/cloud-forensics-utils | 2ba6d4a82b68c46c4c7f3322f298b30c4fd8c136 | Azure E2E tests Failing
```azure.core.exceptions.HttpResponseError: (InvalidParameter) Requested operation cannot be performed because the VM size Standard_F4 does not support the storage account type Premium_LRS of disk 'evidence_jenkins_libcloudforensics_e2e_data_disk_snapshot_19dd1340_copy'. Consider updating the VM... | diff --git a/libcloudforensics/providers/azure/internal/compute.py b/libcloudforensics/providers/azure/internal/compute.py
index a88e2c4..e072683 100644
--- a/libcloudforensics/providers/azure/internal/compute.py
+++ b/libcloudforensics/providers/azure/internal/compute.py
@@ -27,7 +27,7 @@ from msrestazure import azure... |
google__dfindexeddb-41 | [
{
"changes": {
"added_entities": [
"dfindexeddb/indexeddb/chromium/record.py:IndexedDBRecord.FromFile",
"dfindexeddb/indexeddb/chromium/record.py:FolderReader.__init__",
"dfindexeddb/indexeddb/chromium/record.py:FolderReader.GetRecords"
],
"added_modules": [
"df... | google/dfindexeddb | b11ed520f174d508353fefc1039b0e4607bfd28e | Add CLI support to parse files as blink values
Add a CLI command to parse large IndexedDB values that are stored external to the leveldb on the filesystem.
## Expected Behavior
```
dfindexeddb blink -s <someblobfile>
```
These should be defined by the ExternalObjectEntry with mime type `application/vnd.blin... | diff --git a/README.md b/README.md
index f386786..2bd5ad0 100644
--- a/README.md
+++ b/README.md
@@ -75,69 +75,42 @@ options:
-h, --help show this help message and exit
```
-To parse IndexedDB records from an sqlite file for Safari, use the following
-command:
+#### Examples:
-```
-dfindexeddb db --format sa... |
google__dfindexeddb-50 | [
{
"changes": {
"added_entities": [
"dfindexeddb/indexeddb/chromium/v8.py:JSArray.__init__",
"dfindexeddb/indexeddb/chromium/v8.py:JSArray.Append",
"dfindexeddb/indexeddb/chromium/v8.py:JSArray.__eq__"
],
"added_modules": null,
"edited_entities": [
"dfindex... | google/dfindexeddb | 785c1dcadc1ce4b23e5028a4ea281a0060602dd9 | JSON serialization in CLI tools not exporting JS values correctly
When testing on a dataset, properties of JS arrays are not being printed when using json/jsonl output modes (however values were correctly displayed in`repr`)
| diff --git a/dfindexeddb/indexeddb/chromium/v8.py b/dfindexeddb/indexeddb/chromium/v8.py
index e178410..b892e83 100644
--- a/dfindexeddb/indexeddb/chromium/v8.py
+++ b/dfindexeddb/indexeddb/chromium/v8.py
@@ -13,6 +13,8 @@
# See the License for the specific language governing permissions and
# limitations under the L... |
google__docker-explorer-31 | [
{
"changes": {
"added_entities": [
"docker_explorer/de.py:DockerExplorer.GetRepositoriesString"
],
"added_modules": null,
"edited_entities": [
"docker_explorer/de.py:DockerExplorer.__init__",
"docker_explorer/de.py:DockerExplorer._SetDockerDirectory",
"doc... | google/docker-explorer | 80376ae9503280241d6c14838a69d026f0987da9 | Better detect overlay/overlay2 layouts
When processing an image that has both and "overlay2" and "overlay" folder it will take the "overlay2" folder by default even though there is no 'mounts' subfolder. | diff --git a/docker_explorer/de.py b/docker_explorer/de.py
index ea8afa3..1e78818 100644
--- a/docker_explorer/de.py
+++ b/docker_explorer/de.py
@@ -24,7 +24,6 @@ import os
from docker_explorer import errors
from docker_explorer.lib import container
-from docker_explorer.lib import storage
from docker_explorer.lib... |
google__docker-explorer-42 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"docker_explorer/de.py:DockerExplorer._SetDockerDirectory",
"docker_explorer/de.py:DockerExplorer.GetAllContainers",
"docker_explorer/de.py:DockerExplorer.GetRepositoriesString"
],
... | google/docker-explorer | 9a1de78c80d260a3cc55b01e318696cd682826a5 | Raise something more explicit when wrong Docker folder is passed
Something along the lines:
```
diff --git a/docker_explorer/lib/container.py b/docker_explorer/lib/container.py
index 5f926e1..5a7df25 100644
--- a/docker_explorer/lib/container.py
+++ b/docker_explorer/lib/container.py
@@ -81,8 +81,14 @@ class... | diff --git a/docker_explorer/de.py b/docker_explorer/de.py
index 705287a..4817867 100644
--- a/docker_explorer/de.py
+++ b/docker_explorer/de.py
@@ -52,11 +52,8 @@ class DockerExplorer(object):
"""
self.docker_directory = docker_path
if not os.path.isdir(self.docker_directory):
- err_message = (
- ... |
google__docker-explorer-43 | [
{
"changes": {
"added_entities": [
"docker_explorer/de.py:DockerExplorer._GetFullContainerID"
],
"added_modules": null,
"edited_entities": [
"docker_explorer/de.py:DockerExplorer.__init__",
"docker_explorer/de.py:DockerExplorer.GetContainer"
],
"edited... | google/docker-explorer | 2fa6d1707b8654252ffee92be71877c5e50ea6cb | Have DE auto complete partial docker ID
ie use `0ddf71064` for
`0ddf710643b47e581dbce3e17677c9a557b82943bacee2dfbc19f178a99ad374` | diff --git a/docker_explorer/de.py b/docker_explorer/de.py
index 4817867..c42b89c 100644
--- a/docker_explorer/de.py
+++ b/docker_explorer/de.py
@@ -41,7 +41,7 @@ class DockerExplorer(object):
self._argument_parser = None
self.container_config_filename = 'config.v2.json'
self.containers_directory = None
... |
google__docker-explorer-57 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"docker_explorer/de.py:DockerExplorer.GetContainersJson"
],
"edited_modules": [
"docker_explorer/de.py:DockerExplorer"
]
},
"file": "docker_explorer/de.py"
}
] | google/docker-explorer | 21f304f33e1300d4dd60dff7f52dc734d0c780f9 | Go from overlayFS ID to container ID
It would be useful to find a way to map an overlayFS ID to the container that actually used it.
e.g. given this path on a server running Docker:
`/mnt/docker/var/lib/docker/overlay2/6688ce711806faead06aae3ff534ab21183a087241d3a890741f0c3b437b179c/diff/var/tmp/malware`
Find ... | diff --git a/docker_explorer/de.py b/docker_explorer/de.py
index d558e9c..286966f 100644
--- a/docker_explorer/de.py
+++ b/docker_explorer/de.py
@@ -257,6 +257,9 @@ class DockerExplorer(object):
container_object.start_timestamp)
container_json['image_name'] = container_object.config_image_name
+ ... |
google__docker-explorer-64 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"docker_explorer/storage.py:OverlayStorage.MakeMountCommands"
],
"edited_modules": [
"docker_explorer/storage.py:OverlayStorage"
]
},
"file": "docker_explorer/storage.py... | google/docker-explorer | e6612da9a4db2fb79711343712350099185de098 | overlay mount error: mount: special device overlay does not exist
> de.py mount 6f51d96cdd2c /root/docker/docker-explorer/mnt
/bin/mount -t overlay overlay -o ro,lowerdir="/var/lib/docker/overlay2/44bbbf57e9be5c160d9addac59b51a83c35d90955b4179ca4d893ae2942ef8e1/diff:/var/lib/docker/overlay2/l/F74KTIZFM3OJPZ44L4Y5OMLQR... | diff --git a/docker_explorer/storage.py b/docker_explorer/storage.py
index 390a212..9e84a68 100644
--- a/docker_explorer/storage.py
+++ b/docker_explorer/storage.py
@@ -211,7 +211,7 @@ class OverlayStorage(BaseStorage):
cmd = [
'/bin/mount', '-t', 'overlay', 'overlay', '-o',
- 'ro,lowerdir="{0:s}... |
google__flax-2842 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"examples/lm1b/temperature_sampler.py:temperature_sample"
],
"edited_modules": [
"examples/lm1b/temperature_sampler.py:temperature_sample"
]
},
"file": "examples/lm1b/te... | google/flax | 398e170b1e14bec7369987af7beafd32405f21ef | lm1b sampler update is out of bound?
Hi,
_Disclaimer: I'm not confident if this is some intended behavior._
I think in the lm1b example, the prediction sampler could write to indices out of bound of the result.
The particular offending line is: https://github.com/google/flax/blob/master/examples/lm1b/temperatur... | diff --git a/examples/lm1b/temperature_sampler.py b/examples/lm1b/temperature_sampler.py
index 2d9804ff..14208d5c 100644
--- a/examples/lm1b/temperature_sampler.py
+++ b/examples/lm1b/temperature_sampler.py
@@ -57,7 +57,7 @@ def temperature_sample(prompt_inputs,
# initial loop PRNGKey
rng0 = prng_key
# loop po... |
google__flax-3529 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/linen/attention.py:dot_product_attention_weights",
"flax/linen/attention.py:dot_product_attention",
"flax/linen/attention.py:MultiHeadDotProductAttention.__call__"
],
"e... | google/flax | 829e004c6d5646f24bd048023a4407e3b4d5aa98 | Feature request: optionally sow attention weight in `dot_product_attention`
### Discussed in https://github.com/google/flax/discussions/2869
<div type='discussions-op-text'>
<sup>Originally posted by **JyChang012** February 13, 2023</sup>
It seems that there is no good way to retrieve attention weight using `Mul... | diff --git a/flax/linen/attention.py b/flax/linen/attention.py
index 99e56552..23f643b4 100644
--- a/flax/linen/attention.py
+++ b/flax/linen/attention.py
@@ -50,6 +50,7 @@ def dot_product_attention_weights(
deterministic: bool = False,
dtype: Optional[Dtype] = None,
precision: PrecisionLike = None,
+ module:... |
google__flax-3537 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/experimental/nnx/nnx/nn/linear.py:Conv.__init__"
],
"edited_modules": [
"flax/experimental/nnx/nnx/nn/linear.py:Conv"
]
},
"file": "flax/experimental/nnx/nnx/nn/li... | google/flax | 51e2cf536f5e0f63a4c7c1c4dccbb2831abf924f | NNX Conv documentation states that kernel size can be an integer for 1D convs.
https://github.com/google/flax/blob/829e004c6d5646f24bd048023a4407e3b4d5aa98/flax/experimental/nnx/nnx/nn/linear.py#L368
The NNX Conv documentation says that you can pass kernel size as an integer for 1D convolutions, however, the very fi... | diff --git a/flax/experimental/nnx/nnx/nn/linear.py b/flax/experimental/nnx/nnx/nn/linear.py
index 6308f579..1c0c0afc 100644
--- a/flax/experimental/nnx/nnx/nn/linear.py
+++ b/flax/experimental/nnx/nnx/nn/linear.py
@@ -371,8 +371,9 @@ class Conv(Module):
Attributes:
features: number of convolution filters.
... |
google__flax-3566 | [
{
"changes": {
"added_entities": [
"flax/experimental/nnx/nnx/graph_utils.py:_SubgraphRepr.__nnx_repr__"
],
"added_modules": [
"flax/experimental/nnx/nnx/graph_utils.py:_SubgraphRepr"
],
"edited_entities": [
"flax/experimental/nnx/nnx/graph_utils.py:graph_un... | google/flax | b468207650e7fd2b9b4b035dbbec6176d9ae3734 | NNX attention layer missing `qkv_features` arg
In Linen, the input arg [`qkv_features`](https://github.com/google/flax/blob/main/flax/linen/attention.py#L431) determines the [head dimension](https://github.com/google/flax/blob/main/flax/linen/attention.py#L436) while the input arg [`out_features`](https://github.com/go... | diff --git a/flax/experimental/nnx/nnx/graph_utils.py b/flax/experimental/nnx/nnx/graph_utils.py
index 3a0f3111..501bb097 100644
--- a/flax/experimental/nnx/nnx/graph_utils.py
+++ b/flax/experimental/nnx/nnx/graph_utils.py
@@ -171,6 +171,17 @@ class _HashableMapping(tp.Mapping[HA, HB], tp.Hashable):
return repr(se... |
google__flax-3669 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/core/scope.py:Scope.make_rng"
],
"edited_modules": [
"flax/core/scope.py:Scope"
]
},
"file": "flax/core/scope.py"
},
{
"changes": {
"added_entities":... | google/flax | 12b3db0cffd521c707ca959818b7ab1a274a98fd | Make `self.make_rng()` callable by using a default RNG stream and have `.init()` and `.apply()` use the default RNG stream if no explicit RNG mapping is passed.
There has been some internal and external (#3506) discussion on making `self.make_rng()` callable by using a default RNG stream and having `.init()` and `.appl... | diff --git a/docs/api_reference/flax.linen/module.rst b/docs/api_reference/flax.linen/module.rst
index 200bd124..302546dc 100644
--- a/docs/api_reference/flax.linen/module.rst
+++ b/docs/api_reference/flax.linen/module.rst
@@ -5,7 +5,7 @@ Module
.. currentmodule:: flax.linen
.. autoclass:: Module
- :members: setu... |
google__flax-3693 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/experimental/nnx/nnx/nn/normalization.py:_compute_stats",
"flax/experimental/nnx/nnx/nn/normalization.py:BatchNorm.__init__",
"flax/experimental/nnx/nnx/nn/normalization.py:BatchNor... | google/flax | c25f546ff4c72c6c85e5225fe8467331720034be | NNX `_compute_stats` function missing `use_fast_variance` and `mask` argument
NNX [`_compute_stats`](https://github.com/google/flax/blob/main/flax/experimental/nnx/nnx/nn/normalization.py#L47) function is missing `use_fast_variance` and `mask` argument, compared to the [Linen equivalent](https://github.com/google/flax/... | diff --git a/flax/experimental/nnx/nnx/nn/normalization.py b/flax/experimental/nnx/nnx/nn/normalization.py
index d9116e77..8826bc83 100644
--- a/flax/experimental/nnx/nnx/nn/normalization.py
+++ b/flax/experimental/nnx/nnx/nn/normalization.py
@@ -14,6 +14,7 @@
import typing as tp
+import jax
import jax.numpy as j... |
google__flax-3731 | [
{
"changes": {
"added_entities": [
"flax/experimental/nnx/nnx/tracers.py:get_all_traces",
"flax/experimental/nnx/nnx/tracers.py:trace_level",
"flax/experimental/nnx/nnx/tracers.py:nnx_trace",
"flax/experimental/nnx/nnx/tracers.py:current_nnx_trace",
"flax/experiment... | google/flax | d1f219ffa7b196c066d00c34a0e976f846323d3f | Unify behavior of strides arg of Conv and ConvTranspose
Currently, `Conv` accepts an int for `strides` which is then broadcast to the correct shape. However, `ConvTranspose` accepts only an optional Sequence, so no broadcasting is done.
For consistency, I think the behavior should be equal, thus ConvTranspose should ... | diff --git a/flax/experimental/nnx/nnx/tracers.py b/flax/experimental/nnx/nnx/tracers.py
index 88266823..f64e8660 100644
--- a/flax/experimental/nnx/nnx/tracers.py
+++ b/flax/experimental/nnx/nnx/tracers.py
@@ -14,6 +14,9 @@
# Taken from flax/core/tracer.py 🏴☠️
+import contextlib
+import dataclasses
+import thre... |
google__flax-4002 | [
{
"changes": {
"added_entities": [
"flax/errors.py:FlaxError.__reduce__"
],
"added_modules": null,
"edited_entities": [
"flax/errors.py:FlaxError.__init__"
],
"edited_modules": [
"flax/errors.py:FlaxError"
]
},
"file": "flax/errors.py"
... | google/flax | fbdc3394f67c973c3502c482d168152437fea3c2 | Exceptions are not pickle-able
### Problem you have encountered:
Flax exceptions can not be pickled. This makes it impossible to trace where/why errors are occurring when calling flax via ray.
### System information
```
Name: flax
Version: 0.8.3
Summary: Flax: A neural network library for JAX designed for f... | diff --git a/flax/errors.py b/flax/errors.py
index 1308af3a..8863ad06 100644
--- a/flax/errors.py
+++ b/flax/errors.py
@@ -56,8 +56,12 @@ class FlaxError(Exception):
)
module_name = self.__class__.__module__
class_name = self.__class__.__name__
- error_msg = f'{message} ({error_page}#{module_name}.{cl... |
google__flax-4029 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/linen/attention.py:MultiHeadDotProductAttention.__call__"
],
"edited_modules": [
"flax/linen/attention.py:MultiHeadDotProductAttention"
]
},
"file": "flax/linen/at... | google/flax | 3b21870822bd2a6d880194799b749bb69534769f | Force `fp32` in `attention.MultiHeadDotProductAttention` for softmax operator
Hi,
As I was trying to implement mixed precision training under Flax for my project, I noticed that the `force_fp32_for_softmax` flag defined in `attention.MultiHeadDotProductAttention` does not get to pass into `dot_product_attention` (th... | diff --git a/flax/linen/attention.py b/flax/linen/attention.py
index b7e9de6c..6e91be99 100644
--- a/flax/linen/attention.py
+++ b/flax/linen/attention.py
@@ -16,6 +16,7 @@
from __future__ import annotations
import functools
+import inspect
import warnings
from typing import Any, Callable, Optional, Union, overlo... |
google__flax-4317 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/nnx/statelib.py:State.replace_by_pure_dict"
],
"edited_modules": [
"flax/nnx/statelib.py:State"
]
},
"file": "flax/nnx/statelib.py"
}
] | google/flax | c1046ad08f885e3ff35e6fdec2bd0b6495e04e22 | Issue on restoring NNX state from Orbax checkpoint as pure dict
Dear team,
I'm having an issue restoring pure dict from nnx.state,
Orbax will change the key has int type into string type.
Is there any way to fix it?
I put a sample code that can reproduce the issue.
```python
from flax import nnx
import orbax.checkpo... | diff --git a/flax/nnx/statelib.py b/flax/nnx/statelib.py
index 59461fc4..3e27937d 100644
--- a/flax/nnx/statelib.py
+++ b/flax/nnx/statelib.py
@@ -179,11 +179,17 @@ class State(MutableMapping[K, V], reprlib.Representable):
def replace_by_pure_dict(self,
pure_dict: dict[str, tp.Any],
... |
google__flax-4351 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/nnx/training/optimizer.py:Optimizer.update"
],
"edited_modules": [
"flax/nnx/training/optimizer.py:Optimizer"
]
},
"file": "flax/nnx/training/optimizer.py"
}
] | google/flax | b8bdafbbc53bfdb7266db18b4a5261eb0fff3625 | Support for optax lbfgs and related optimizers with NNX
I am trying to use L-BFGS and related optimizers with nnx + optax, but running into trouble. It might be that `optax` has a slightly different optimization interface in those cases: https://optax.readthedocs.io/en/latest/api/optimizers.html#lbfgs with a function ... | diff --git a/flax/nnx/training/optimizer.py b/flax/nnx/training/optimizer.py
index fc3b4eeb..4b85d5a3 100644
--- a/flax/nnx/training/optimizer.py
+++ b/flax/nnx/training/optimizer.py
@@ -193,7 +193,7 @@ class Optimizer(Object):
self.opt_state = _wrap_optimizer_state(tx.init(nnx.state(model, wrt)))
self.wrt = ... |
google__flax-4486 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/nnx/bridge/wrappers.py:ToNNX.__call__"
],
"edited_modules": [
"flax/nnx/bridge/wrappers.py:ToNNX"
]
},
"file": "flax/nnx/bridge/wrappers.py"
},
{
"changes"... | google/flax | 969f3cb2f5e057ff6787ab99cc832a9eaade8534 | nnx.bridge.ToNNX does not handle the addition of top-level variables
Repro:
```python
import flax.linen as nn
import flax.nnx as nnx
class LinenModule(nn.Module):
@nn.compact
def __call__(self):
if not self.is_initializing() and self.is_mutable_collection("cache"):
self.put_variable("cach... | diff --git a/flax/nnx/bridge/wrappers.py b/flax/nnx/bridge/wrappers.py
index eed4ba2f..ab673644 100644
--- a/flax/nnx/bridge/wrappers.py
+++ b/flax/nnx/bridge/wrappers.py
@@ -148,7 +148,7 @@ class ToNNX(Module):
out, variables = self.module.init_with_output(_rngs, *args, method=method, **kwargs)
nnx_att... |
google__flax-4490 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/linen/spmd.py:is_cpu_platform",
"flax/linen/spmd.py:_with_sharding_constraint"
],
"edited_modules": [
"flax/linen/spmd.py:is_cpu_platform",
"flax/linen/spmd.py:_... | google/flax | 1ec5ef29777b13c0cfd3f6bad37a72153a45291c | Add nnx.shard_map | diff --git a/docs_nnx/api_reference/flax.nnx/transforms.rst b/docs_nnx/api_reference/flax.nnx/transforms.rst
index 54ba3399..5b4440ed 100644
--- a/docs_nnx/api_reference/flax.nnx/transforms.rst
+++ b/docs_nnx/api_reference/flax.nnx/transforms.rst
@@ -15,6 +15,7 @@ transforms
.. autofunction:: grad
.. autofunction::... |
google__flax-4536 | [
{
"changes": {
"added_entities": [
"flax/nnx/training/metrics.py:Accuracy.__init__"
],
"added_modules": null,
"edited_entities": [
"flax/nnx/training/metrics.py:Accuracy.update"
],
"edited_modules": [
"flax/nnx/training/metrics.py:Accuracy"
]
... | google/flax | 33bf6b6adec5dd7e5981d970972ec5b0fb04cfc2 | Accuracy doesn't work for simple binary classifier
Hello,
This is quite a simple issue but the function `nnx.metric.Accuracy` only works for a network that returns more than one output, i.e.
`super().update(values=(logits.argmax(axis=-1) == labels))`. Not sure if this is by design.
I was playing around with a simp... | diff --git a/.github/workflows/flax_publish.yml b/.github/workflows/flax_publish.yml
index 19aa2dd5..f688e8fc 100644
--- a/.github/workflows/flax_publish.yml
+++ b/.github/workflows/flax_publish.yml
@@ -8,37 +8,24 @@ on:
types: [published]
jobs:
- build_package:
- name: Build package
- runs-on: ubuntu-la... |
google__flax-4580 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/nnx/summary.py:_unflatten_to_simple_structure"
],
"edited_modules": [
"flax/nnx/summary.py:_unflatten_to_simple_structure"
]
},
"file": "flax/nnx/summary.py"
}
] | google/flax | 541385015d1925f50e47530ed838a485c315d58d | `nnx.tabulate` does not support `nnx.Module` with multiple inputs/outputs
Hi! 👋
First of all, thank you for this great project!
I found a small issue with the `nnx.tabulate` function.
Currently, it only supports nnx.Module instances that **take one input and return one output**.
You can check with following simple ... | diff --git a/flax/nnx/summary.py b/flax/nnx/summary.py
index 7f1aed53..7396b2ed 100644
--- a/flax/nnx/summary.py
+++ b/flax/nnx/summary.py
@@ -519,7 +519,12 @@ def _unflatten_to_simple_structure(xs: list[tuple[tuple[tp.Any, ...], tp.Any]]):
else:
cursor[key] = {}
cursor = cursor[key]
- ... |
google__flax-4681 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/nnx/nn/lora.py:LoRA.__call__"
],
"edited_modules": [
"flax/nnx/nn/lora.py:LoRA"
]
},
"file": "flax/nnx/nn/lora.py"
}
] | google/flax | e16cfc44f85a9c4b26f3ebb28249ba49ce3e1527 | nnx.nn.LoRA does not respect dtype argument
Provide as much information as possible. At least, this should include a description of your issue and steps to reproduce the problem. If possible also provide a summary of what steps or workarounds you have already tried.
### System information
Reproduced on Google Colab (C... | diff --git a/flax/nnx/nn/lora.py b/flax/nnx/nn/lora.py
index 76725f0a..36f19d8b 100644
--- a/flax/nnx/nn/lora.py
+++ b/flax/nnx/nn/lora.py
@@ -19,6 +19,7 @@ from flax.nnx import rnglib, variablelib
from flax.nnx.module import Module
from flax.nnx.nn import initializers
from flax.nnx.nn.linear import Linear
+from fla... |
google__flax-4705 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"flax/nnx/nn/linear.py:Einsum.__init__",
"flax/nnx/nn/linear.py:Einsum.__call__"
],
"edited_modules": [
"flax/nnx/nn/linear.py:Einsum"
]
},
"file": "flax/nnx/nn/... | google/flax | 32ad6c57a6f2c09080e9746b903addcb5c2b226c | Adding `dot_general` to `Einsum` Module
Hello! Are there any plans to add a `dot_general` argument to `Einsum`, if not would a PR be accepted?
`Linear` allows injectable dot general, but not `Einsum`. Major reason to not do this is that `jnp.einsum` marks
dot general injection as experimental, but perhaps it could be... | diff --git a/flax/nnx/nn/linear.py b/flax/nnx/nn/linear.py
index 84a875fa..22bfb1e1 100644
--- a/flax/nnx/nn/linear.py
+++ b/flax/nnx/nn/linear.py
@@ -36,6 +36,7 @@ from flax.typing import (
PaddingLike,
LaxPadding,
PromoteDtypeFn,
+ EinsumT,
)
Array = jax.Array
@@ -426,6 +427,8 @@ class Einsum(Module):
... |
google__gae-secure-scaffold-python3-14 | [
{
"changes": {
"added_entities": [
"src/securescaffold/views.py:add_query_to_url"
],
"added_modules": [
"src/securescaffold/views.py:add_query_to_url"
],
"edited_entities": [
"src/securescaffold/views.py:lang_redirect"
],
"edited_modules": [
... | google/gae-secure-scaffold-python3 | 8ec9ffb6895eeb9c99aaa0975231436e86b7abfd | Preserve query params on redirect
## Issue
Currently, any query string set on the redirect path is not preserved when redirected.
## Behaviour
**Current**: `/?foo=bar` -> `/intl/en/`
**Expected**: `/?foo=bar` -> `/intl/en/?foo=bar`
## Setup
```py
# Follows github.com/google/gae-secure-scaffold-python3/blob... | diff --git a/src/securescaffold/views.py b/src/securescaffold/views.py
index b53c0aa..5de1852 100644
--- a/src/securescaffold/views.py
+++ b/src/securescaffold/views.py
@@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+import urllib.parse
from... |
google__github-release-retry-15 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ci/check_headers.py:go"
],
"edited_modules": [
"ci/check_headers.py:go"
]
},
"file": "ci/check_headers.py"
},
{
"changes": {
"added_entities": [
"... | google/github-release-retry | 426300ff66b25191b4bfb17d101342235749ad4f | New GitHub node id format is not supported
It seems that GitHub recently introduced a new format for their node ids. Specifically, release asset node ids used to just be a base64 encoded string. Newer node ids look like this: `"RA_[base64 encoded bytes]"`. It looks like the asset id is still encoded within the node id,... | diff --git a/ci/check_headers.py b/ci/check_headers.py
index 4fa435e..507f057 100755
--- a/ci/check_headers.py
+++ b/ci/check_headers.py
@@ -88,7 +88,7 @@ def exclude_filename(f: str):
def go():
fail = False
copyright_pattern = re.compile(
- r"Copyright 20(18|19|20) The github-release-retry Project Au... |
google__importlab-13 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"importlab/import_finder.py:_resolve_import_2"
],
"edited_modules": [
"importlab/import_finder.py:_resolve_import_2"
]
},
"file": "importlab/import_finder.py"
},
{
... | google/importlab | 17edb0b8aae61e7dc2089fbafbd78504d975c221 | Importlab running under Python 3.6 and analyzing Python 2.7 can't find networkx
Steps I took:
sudo apt-get install python-pip
pip install networkx # puts networkx in ~/.local/lib/python2.7/site-packages/
virtualenv --python=python3.6 .venv3
source .venv3/bin/activate
pip install importlab
echo "import networkx... | diff --git a/importlab/import_finder.py b/importlab/import_finder.py
index 35e11ff..47687d3 100644
--- a/importlab/import_finder.py
+++ b/importlab/import_finder.py
@@ -64,7 +64,10 @@ def _resolve_import_2(name):
path = None
for part in parts[i:]:
try:
- spec = imp.find_module(part, pa... |
google__importlab-17 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"importlab/graph.py:DependencyGraph.__init__",
"importlab/graph.py:DependencyGraph.add_file_recursive"
],
"edited_modules": [
"importlab/graph.py:DependencyGraph"
]
... | google/importlab | 3036fef543721a426ca897bd373e08b0f0c2e13b | Crash when analyzing files of different Python versions
Input:
```
# file a.py
import b
# file b.py
raise 1, 2, 3 # Python 2 syntax
```
Output of -V2.7:
```
$ importlab -V2.7 -P. *.py --tree
Source tree:
+ a.py
+ b.py
```
Output of -V3.6:
```
$ importlab -V3.6 -P. *.py --tree
Traceback (most... | diff --git a/bin/importlab b/bin/importlab
index d263f89..bb2eb30 100755
--- a/bin/importlab
+++ b/bin/importlab
@@ -55,11 +55,13 @@ def main():
if args.tree:
print('Source tree:')
output.print_tree(import_graph)
+ output.maybe_show_unreadable(import_graph)
sys.exit(0)
if a... |
google__importlab-23 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"importlab/resolve.py:infer_module_name"
],
"edited_modules": [
"importlab/resolve.py:infer_module_name"
]
},
"file": "importlab/resolve.py"
}
] | google/importlab | 77f04151272440dacea197b8c4f74aa26fdbe950 | Incorrect inferred module name for __init__.py files
See google/pytype#154 for more detail.
`resolve.infer_module_name` calculates the wrong name for `__init__.py` files. For example, for `foo/bar/__init__.py`, it will return `foo.bar.__init__`. The module name should be `foo.bar`. | diff --git a/importlab/resolve.py b/importlab/resolve.py
index 23314bc..d55f34d 100644
--- a/importlab/resolve.py
+++ b/importlab/resolve.py
@@ -102,6 +102,9 @@ def infer_module_name(filename, fspath):
for f in fspath:
short_name = f.relative_path(filename)
if short_name:
+ # The modul... |
google__latexify_py-143 | [
{
"changes": {
"added_entities": [
"src/latexify/codegen/function_codegen.py:FunctionCodegen._generate_sum_prod",
"src/latexify/codegen/function_codegen.py:FunctionCodegen._generate_matrix"
],
"added_modules": null,
"edited_entities": [
"src/latexify/codegen/funct... | google/latexify_py | 7f13cb6aa7346084617d84a6b51b417c9ed6e49c | NDArray support
Sometimes users want to support NDArrays in this library, e.g., `np.array([[a, b], [c, d]])` to
$$\left( \begin{array}{cc}a&b \\\\ c&d\end{array} \right)$$
This is definitely useful, but often it is not possible to compile:
- Large arrays.
- Arrays with more than 2 dimensions.
I think we c... | diff --git a/src/latexify/codegen/function_codegen.py b/src/latexify/codegen/function_codegen.py
index 9ef24a0..cf83122 100644
--- a/src/latexify/codegen/function_codegen.py
+++ b/src/latexify/codegen/function_codegen.py
@@ -334,18 +334,84 @@ class FunctionCodegen(ast.NodeVisitor):
wrapped = [r"\mathopen{}\lef... |
google__latexify_py-182 | [
{
"changes": {
"added_entities": [
"src/latexify/codegen/expression_codegen.py:ExpressionCodegen._should_remove_multiply_op"
],
"added_modules": null,
"edited_entities": [
"src/latexify/codegen/expression_codegen.py:ExpressionCodegen.visit_BinOp"
],
"edited_mo... | google/latexify_py | 37d47c98b044135fa0e7d33c18774b7e6b816763 | Wrong behavior around multiplication
The current implementation converts `a * b` into $ab$. This only works if the variables have only 1 character and doesn't generate a correct syntax for other cases:
* Long names: `abc * def` --> $abcdef$, which is hard to distinguish from other combination of variables.
* Unary ... | diff --git a/src/latexify/codegen/expression_codegen.py b/src/latexify/codegen/expression_codegen.py
index 9706e74..3c72219 100644
--- a/src/latexify/codegen/expression_codegen.py
+++ b/src/latexify/codegen/expression_codegen.py
@@ -3,6 +3,7 @@
from __future__ import annotations
import ast
+import re
from latexi... |
google__latexify_py-195 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/latexify/codegen/expression_codegen.py:ExpressionCodegen.visit_Call",
"src/latexify/codegen/expression_codegen.py:ExpressionCodegen._wrap_operand"
],
"edited_modules": [
... | google/latexify_py | 1cfb8e78527cb8e13dc647e9c8d91f789a427402 | Counterintuitive (wrong?) parenthesis when combining exp() and powers
## Description
When you latexify something like log((x/c)^2), the rendering you get looks (to me at least) like it's log(x/c)^2:
<img width="333" alt="image" src="https://github.com/google/latexify_py/assets/889526/c4c7a979-d5f1-459c-9957-daecbf6... | diff --git a/src/latexify/codegen/expression_codegen.py b/src/latexify/codegen/expression_codegen.py
index f88869c..9239d72 100644
--- a/src/latexify/codegen/expression_codegen.py
+++ b/src/latexify/codegen/expression_codegen.py
@@ -408,16 +408,22 @@ class ExpressionCodegen(ast.NodeVisitor):
if rule.is_unary... |
google__latexify_py-67 | [
{
"changes": {
"added_entities": [
"src/latexify/latexify_visitor.py:LatexifyVisitor.visit_Index",
"src/latexify/latexify_visitor.py:LatexifyVisitor.convert_nested_subscripts",
"src/latexify/latexify_visitor.py:LatexifyVisitor.visit_Subscript"
],
"added_modules": null,
... | google/latexify_py | 363ffae12ba75930b8100333ecf59ff6d4a42324 | support indicies
Add suppot for indicies
```
import math
import latexify
@latexify.with_latex
def solve(a):
return a[0]
print(solve)
```
to be something like `\mathrm{solve}(a) \triangleq a_0` | diff --git a/.gitignore b/.gitignore
index 42812b2..564c52f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -90,7 +90,7 @@ ipython_config.py
# pyenv
# For a library or package, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
-# .python-vers... |
google__latexify_py-73 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/latexify/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/latexif... | google/latexify_py | 53201176c53d525287af6b3e386b68228a7df87c | Ability to get latex without getting function name
```
import latexify
def solve(a):
return 5 * a
print(latexify.get_latex(solve, no_function=True))
```
to be `5a`, not `\mathrm{solve}(a) \triangleq 5a`
i think it's better to create another function not parameter or set by default | diff --git a/examples/equation.ipynb b/examples/examples.ipynb
similarity index 57%
rename from examples/equation.ipynb
rename to examples/examples.ipynb
index 1acfcb2..1c58beb 100644
--- a/examples/equation.ipynb
+++ b/examples/examples.ipynb
@@ -20,17 +20,16 @@
"output_type": "stream",
"text": [
"-... |
google__mobly-107 | [
{
"changes": {
"added_entities": [
"mobly/controllers/android_device.py:DeviceError.__init__",
"mobly/controllers/android_device.py:AndroidDevice.__repr__",
"mobly/controllers/android_device.py:AndroidDevice.debug_tag"
],
"added_modules": [
"mobly/controllers/an... | google/mobly | b4362eda0c8148644812849cdb9c741e35d5750d | [Android Device] Identify the device in exceptions thrown from a device instance.
Right now we have to manually add the device serial every time we throw an exception from inside AndroidDevice, which is tedious and annoying.
We should have a better way to handle this, perhaps an inner exception class. | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index afe5a79..79d3f16 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -35,6 +35,7 @@ from mobly.controllers.android_device_lib import snippet_client
MOBLY_CONTROLLER_CONFIG_NAME = 'Andr... |
google__mobly-135 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler.__init__",
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler.waitAndGet"
],
"edited_m... | google/mobly | 81f4c8854fdc7b07607efdb7f0da91b9e1b22d12 | Better timeout message in CallbackHandler
Right now the `CallbackHandler`'s timeout msg only includes the `callback_id`, which is an implementation detail that doesn't make too much sense for the user. We should add the name of the call where the event was supposed to originate from. | diff --git a/mobly/controllers/android_device_lib/callback_handler.py b/mobly/controllers/android_device_lib/callback_handler.py
index 399e999..93b13e2 100644
--- a/mobly/controllers/android_device_lib/callback_handler.py
+++ b/mobly/controllers/android_device_lib/callback_handler.py
@@ -42,10 +42,11 @@ class CallbackH... |
google__mobly-140 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler.waitAndGet"
],
"edited_modules": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler"... | google/mobly | b4362eda0c8148644812849cdb9c741e35d5750d | Rpc socket times out before EventHandler.waitAndGet
`json_rpc_base._SOCKET_TIMEOUT` is 60s. Yet `EventHandler.waitAndGet` can take an arbitrary timeout length.
`EventHandler.waitAndGet` makes a call to `EventSnippet.eventWaitAndGet` through the socket, which doesn't return until the event is received or the method i... | diff --git a/mobly/controllers/android_device_lib/callback_handler.py b/mobly/controllers/android_device_lib/callback_handler.py
index 7c648c2..ddcf029 100644
--- a/mobly/controllers/android_device_lib/callback_handler.py
+++ b/mobly/controllers/android_device_lib/callback_handler.py
@@ -18,6 +18,11 @@ import time
f... |
google__mobly-146 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:create"
],
"edited_modules": [
"mobly/controllers/android_device.py:create"
]
},
"file": "mobly/controllers/android_device.py"
},
... | google/mobly | 3bf63583dae310bd2a7a147bbff01b6aa917f72e | controllers/android_device.py throws an exception on android configuration with just string
Seems like an earlier checkin to switch to using base64 string to load configuration might have introduced a bug in mobly/controllers/android_device.create(configs). I was hitting an issue where I specified the android device s... | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index 79d3f16..5675e34 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -16,6 +16,7 @@
from builtins import str
from builtins import open
+from past.builtins import basestring
impor... |
google__mobly-164 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/sniffer_lib/local/local_base.py:SnifferLocalBase.__init__",
"mobly/controllers/sniffer_lib/local/local_base.py:SnifferLocalBase._pre_capture_config"
],
"edited_modu... | google/mobly | 464a16aee403100025085846f0b6a5e29620e5b6 | Flake in unit tests
Reported in #87
https://travis-ci.org/google/mobly/jobs/197104959
=================================== FAILURES ===================================
____________________ UtilsTest.test_start_standing_subproc _____________________
self = <tests.mobly.utils_test.UtilsTest testMethod=test_start_st... | diff --git a/mobly/controllers/sniffer_lib/local/local_base.py b/mobly/controllers/sniffer_lib/local/local_base.py
index 859c242..781e4b6 100644
--- a/mobly/controllers/sniffer_lib/local/local_base.py
+++ b/mobly/controllers/sniffer_lib/local/local_base.py
@@ -54,9 +54,10 @@ class SnifferLocalBase(sniffer.Sniffer):
... |
google__mobly-165 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/sniffer_lib/local/local_base.py:SnifferLocalBase.__init__",
"mobly/controllers/sniffer_lib/local/local_base.py:SnifferLocalBase._pre_capture_config"
],
"edited_modu... | google/mobly | 464a16aee403100025085846f0b6a5e29620e5b6 | Flake in unit tests
Reported in #87
https://travis-ci.org/google/mobly/jobs/197104959
=================================== FAILURES ===================================
____________________ UtilsTest.test_start_standing_subproc _____________________
self = <tests.mobly.utils_test.UtilsTest testMethod=test_start_st... | diff --git a/mobly/controllers/sniffer_lib/local/local_base.py b/mobly/controllers/sniffer_lib/local/local_base.py
index 859c242..781e4b6 100644
--- a/mobly/controllers/sniffer_lib/local/local_base.py
+++ b/mobly/controllers/sniffer_lib/local/local_base.py
@@ -54,9 +54,10 @@ class SnifferLocalBase(sniffer.Sniffer):
... |
google__mobly-17 | [
{
"changes": {
"added_entities": [
"mobly/controllers/android_device_lib/adb.py:list_occupied_adb_ports"
],
"added_modules": [
"mobly/controllers/android_device_lib/adb.py:list_occupied_adb_ports"
],
"edited_entities": null,
"edited_modules": null
},
"... | google/mobly | 213cd2f8b71c9c1699765bf6bcef4777dcacaafe | Mobly unit tests are flaky
Running the unit tests gives different results without code changes:
```
$ python setup.py test
running test
running egg_info
writing requirements to mobly.egg-info/requires.txt
writing mobly.egg-info/PKG-INFO
writing top-level names to mobly.egg-info/top_level.txt
writing dependenc... | diff --git a/mobly/controllers/android_device_lib/adb.py b/mobly/controllers/android_device_lib/adb.py
index 4a57cf0..a3e66ec 100644
--- a/mobly/controllers/android_device_lib/adb.py
+++ b/mobly/controllers/android_device_lib/adb.py
@@ -37,6 +37,28 @@ class AdbError(Exception):
) % (self.cmd, self.ret_... |
google__mobly-194 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:AndroidDevice.debug_tag",
"mobly/controllers/android_device.py:AndroidDevice.start_adb_logcat"
],
"edited_modules": [
"mobly/controllers/a... | google/mobly | 5960e218c4006d8b7681ffe9698cbef160ad112f | logcat is empty for some NBU devices
When starting adb logcat, we use `-b all` to catch all buffers.
But some NBU devices (like HTC Desire 526g+) don't have the buffer option "all", and their adb logcat would only have one line saying "Unable to open log device '/dev/log/all': No such file or directory".
We need ... | diff --git a/docs/tutorial.md b/docs/tutorial.md
index 67f66b0..2c64dae 100644
--- a/docs/tutorial.md
+++ b/docs/tutorial.md
@@ -9,18 +9,13 @@ various devices and you can also use your own custom hardware/equipment.
* A computer with at least 2 USB ports.
* Mobly package and its system dependencies installed on... |
google__mobly-216 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:AndroidDevice.stop_services",
"mobly/controllers/android_device.py:AndroidDevice.load_snippet",
"mobly/controllers/android_device.py:AndroidDevice.loa... | google/mobly | 6344f817976315515f6b183b2394012a8f348e23 | [Snippet Client] Backward compatibility mechanism with older versions of snippet lib
If we make updates to snippet lib and introduce new internal Rpcs or other protocol changes, the client needs to be able to figure out which version of the lib is used and behave accordingly. | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index 3f8e209..33f7309 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -25,9 +25,7 @@ from mobly import logger as mobly_logger
from mobly import signals
from mobly import utils
from mo... |
google__mobly-222 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/snippet_client.py:SnippetClient._start_event_client"
],
"edited_modules": [
"mobly/controllers/android_device_lib/snippet_client.py:SnippetClient... | google/mobly | bb85ca2966791baecca17e2cb251c09ded139d07 | `snippet_client._start_event_client` crashes
because of the extra `host_port` arg.
This crashes all tests that use `@AsyncRpc`.
We should add some unit tests for this... | diff --git a/mobly/controllers/android_device_lib/snippet_client.py b/mobly/controllers/android_device_lib/snippet_client.py
index 1470927..f47308a 100644
--- a/mobly/controllers/android_device_lib/snippet_client.py
+++ b/mobly/controllers/android_device_lib/snippet_client.py
@@ -138,10 +138,8 @@ class SnippetClient(js... |
google__mobly-227 | [
{
"changes": {
"added_entities": [
"mobly/controllers/android_device_lib/snippet_client.py:SnippetClient._read_protocol_line"
],
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/snippet_client.py:SnippetClient.start_app_and_connect",
... | google/mobly | caffb80efb51ec19f73fcb334ada67bdeac1d390 | Snippet crashes on phones that print extra instrumentation output.
Some phones print extra information prior to instrumentation output. On such phones, the snippet crashes. | diff --git a/mobly/controllers/android_device_lib/snippet_client.py b/mobly/controllers/android_device_lib/snippet_client.py
index 4eb15e8..769140f 100644
--- a/mobly/controllers/android_device_lib/snippet_client.py
+++ b/mobly/controllers/android_device_lib/snippet_client.py
@@ -1,11 +1,11 @@
# Copyright 2016 Google ... |
google__mobly-238 | [
{
"changes": {
"added_entities": [
"mobly/records.py:TestResult.is_test_executed"
],
"added_modules": null,
"edited_entities": [
"mobly/records.py:TestResult.add_record",
"mobly/records.py:TestResult.fail_class"
],
"edited_modules": [
"mobly/re... | google/mobly | 310791d8d2faa9f554fddb0a5ce11ae249156bb4 | Properly report skipped test classes
Now that we have a way to reliably get all the tests in a class, including the generated tests, the test report for an aborted class should include entries for all the tests requested, instead of only one entry for the class. | diff --git a/mobly/records.py b/mobly/records.py
index ae550d9..6c5efe2 100644
--- a/mobly/records.py
+++ b/mobly/records.py
@@ -262,11 +262,12 @@ class TestResult(object):
Args:
record: A test record object to add.
"""
+ if record.result == TestResultEnums.TEST_RESULT_SKIP:
+ ... |
google__mobly-246 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/config_parser.py:_validate_test_config",
"mobly/config_parser.py:load_test_config_file",
"mobly/config_parser.py:TestRunConfig.__init__"
],
"edited_modules": [
... | google/mobly | 6760e850a2a5ec0d7ebafac2e3b0de3d261ff803 | New summary output.
The current summary log has limited debug information and is in json.
We need to consider what other useful information we can include in the summary log.
Like information on the invocation status, and device monitoring info.
Also consider using a different format so it's possible to stream t... | diff --git a/mobly/config_parser.py b/mobly/config_parser.py
index 094777a..9d84a3a 100644
--- a/mobly/config_parser.py
+++ b/mobly/config_parser.py
@@ -37,8 +37,8 @@ def _validate_test_config(test_config):
"""
required_key = keys.Config.key_testbed.value
if required_key not in test_config:
- rais... |
google__mobly-248 | [
{
"changes": {
"added_entities": [
"mobly/records.py:TestResult.add_class_error"
],
"added_modules": null,
"edited_entities": [
"mobly/records.py:TestResult.fail_class",
"mobly/records.py:TestResult.json_str"
],
"edited_modules": [
"mobly/recor... | google/mobly | 31dcff279d4808e011f6af8ab0661b9750357cda | Stacktrace is lost in test_summary.json
The reraise in base_test.py in 349-352 here loses the stacktrace:
https://github.com/google/mobly/pull/241
| diff --git a/mobly/records.py b/mobly/records.py
index 6c5efe2..0b67c9d 100644
--- a/mobly/records.py
+++ b/mobly/records.py
@@ -14,6 +14,7 @@
"""This module is where all the record definitions and record containers live.
"""
+import itertools
import json
import logging
import pprint
@@ -283,7 +284,7 @@ class Te... |
google__mobly-258 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler.waitAndGet"
],
"edited_modules": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler"... | google/mobly | c9ba28477626c6f7d5365bec019646f915a5bd2d | Exceptions from `CallbackHandler` should include timeout value
Right now some timeout exceptions thrown by `CallbackHandler` do not include how long the timeout was, making debugging more difficult. | diff --git a/mobly/controllers/android_device_lib/callback_handler.py b/mobly/controllers/android_device_lib/callback_handler.py
index 4207f47..1ab67d8 100644
--- a/mobly/controllers/android_device_lib/callback_handler.py
+++ b/mobly/controllers/android_device_lib/callback_handler.py
@@ -83,13 +83,14 @@ class CallbackH... |
google__mobly-263 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler.waitAndGet"
],
"edited_modules": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler"... | google/mobly | 067621c8fbb771b35cf0a7c6de6c42a6c452321f | Procedure functions triggered incorrectly
If a test throws an exception, and the teardown also throws an exception, `on_fail` is executed twice. | diff --git a/mobly/controllers/android_device_lib/callback_handler.py b/mobly/controllers/android_device_lib/callback_handler.py
index 4207f47..1ab67d8 100644
--- a/mobly/controllers/android_device_lib/callback_handler.py
+++ b/mobly/controllers/android_device_lib/callback_handler.py
@@ -83,13 +83,14 @@ class CallbackH... |
google__mobly-269 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/config_parser.py:_validate_test_config",
"mobly/config_parser.py:load_test_config_file",
"mobly/config_parser.py:TestRunConfig.__init__"
],
"edited_modules": [
... | google/mobly | 6760e850a2a5ec0d7ebafac2e3b0de3d261ff803 | When failure occurs in setup class "begin_time" for skipped tests is null
End time is not null.
Can we either make them equal to each other (i.e. skipped test takes 0 time) or both null? | diff --git a/mobly/config_parser.py b/mobly/config_parser.py
index 094777a..9d84a3a 100644
--- a/mobly/config_parser.py
+++ b/mobly/config_parser.py
@@ -37,8 +37,8 @@ def _validate_test_config(test_config):
"""
required_key = keys.Config.key_testbed.value
if required_key not in test_config:
- rais... |
google__mobly-276 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/snippet_client.py:SnippetClient.start_app_and_connect",
"mobly/controllers/android_device_lib/snippet_client.py:SnippetClient.restore_app_connection",
... | google/mobly | 2172facbb0ad8d1795a63e7b777d5938914cf758 | snippet launching is broken in py3
When trying to launch snippet, it fails with:
```
File "/Users/angli/Developer/mobly/tools/snippet_shell.py", line 43, in _start_services
self._ad.load_snippet(name='snippet', package=self._package)
File "/Users/angli/Developer/mobly/mobly/controllers/android_device.py",... | diff --git a/mobly/controllers/android_device_lib/snippet_client.py b/mobly/controllers/android_device_lib/snippet_client.py
index f7f473b..6d656a4 100644
--- a/mobly/controllers/android_device_lib/snippet_client.py
+++ b/mobly/controllers/android_device_lib/snippet_client.py
@@ -27,8 +27,8 @@ _INSTRUMENTATION_RUNNER_P... |
google__mobly-279 | [
{
"changes": {
"added_entities": [
"mobly/records.py:TestResult.requested_test_names_dict"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"mobly/records.py:TestSummaryEntryType",
"mobly/records.py:TestResult"
]
},
"file"... | google/mobly | 49db9368415e40a3bf0512bddf6c0e3170513a41 | add a prefix document to test_summary.yaml with requested tests
This could be dumped before any test cases are run | diff --git a/mobly/records.py b/mobly/records.py
index 54be008..b6175cd 100644
--- a/mobly/records.py
+++ b/mobly/records.py
@@ -43,8 +43,16 @@ class TestSummaryEntryType(enum.Enum):
The idea is similar to how `TestResult.json_str` categorizes different
sections of a `TestResult` object in the serialized form... |
google__mobly-284 | [
{
"changes": {
"added_entities": [
"mobly/records.py:ExceptionRecord.__init__",
"mobly/records.py:ExceptionRecord.to_dict",
"mobly/records.py:TestResultRecord.details",
"mobly/records.py:TestResultRecord.stacktrace",
"mobly/records.py:TestResultRecord.extras",
... | google/mobly | e5df6ca2918e21233d3d207207964b82319c9f9d | Include stack traces of extra errors
Right now only the stack trace for the main error is recorded in `TeatResultRecord`.
We should store the stack traces for extra errors as well. | diff --git a/mobly/records.py b/mobly/records.py
index 62f130b..16072c1 100644
--- a/mobly/records.py
+++ b/mobly/records.py
@@ -14,6 +14,7 @@
"""This module has classes for test result collection, and test result output.
"""
+import collections
import itertools
import copy
import enum
@@ -119,23 +120,86 @@ clas... |
google__mobly-290 | [
{
"changes": {
"added_entities": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler.callback_id"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"mobly/controllers/android_device_lib/callback_handler.py:CallbackHandler... | google/mobly | da911584e28765037962b7e868e0e19f02fd8351 | `utils._assert_subprocess_running` throws `ValueError`
If the process died, we try to call `p.communicate` to get info from the process.
Then `communicate` would sometimes fail with ValueError saying it's trying to do I/O operation on a closed file. | diff --git a/mobly/controllers/android_device_lib/callback_handler.py b/mobly/controllers/android_device_lib/callback_handler.py
index 1ab67d8..1b0a461 100644
--- a/mobly/controllers/android_device_lib/callback_handler.py
+++ b/mobly/controllers/android_device_lib/callback_handler.py
@@ -60,6 +60,10 @@ class CallbackHa... |
google__mobly-309 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:take_bug_reports"
],
"edited_modules": [
"mobly/controllers/android_device.py:take_bug_reports"
]
},
"file": "mobly/controllers/andr... | google/mobly | 3a72998dfa47c2f7c5f98a9399bfbb2685d1e9e2 | Make it possible to add more info to controller infos
Use case: when testing an Android app, it would be nice to have the app's version be in the controller info of AndroidDevice as well. | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index d2ef961..9fcecbd 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -351,9 +351,10 @@ def take_bug_reports(ads, test_name, begin_time):
Args:
ads: A list of AndroidDevice... |
google__mobly-311 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"mobly/signals.py:TestError"
],
"edited_entities": null,
"edited_modules": null
},
"file": "mobly/signals.py"
}
] | google/mobly | 25b676a196403ef3e1d2f7516008d58d3649d888 | Exceptions in `setup_test` should leave the test in `ERROR` status
Regardless of the type of the exception, `setup_test` error should cause `ERROR` status.
This is different from a test method.
In a test method, an exception based on signals.TestFailure should cause the test to exit with `FAILED` status.
This is... | diff --git a/mobly/signals.py b/mobly/signals.py
index 8899065..85bdc30 100644
--- a/mobly/signals.py
+++ b/mobly/signals.py
@@ -46,6 +46,10 @@ class TestSignal(Exception):
return 'Details=%s, Extras=%s' % (self.details, self.extras)
+class TestError(TestSignal):
+ """Raised when a test has an unexpecte... |
google__mobly-323 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:AndroidDevice.load_snippet"
],
"edited_modules": [
"mobly/controllers/android_device.py:AndroidDevice"
]
},
"file": "mobly/controlle... | google/mobly | 1493710b2fa167349303bc6710dda042dae0b895 | `signals.TestAbortClass` does not work in `setup_test` and `on_xxxx` methods
It is valid to abort the class at any stage of a test.
E.g. If we find out in `on_fail` that a test failed due to a fatal error like snippet_client losing socket connection, it is reasonable for the test to abort all subsequent tests in the... | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index 2be180b..5d7027e 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -725,7 +725,17 @@ class AndroidDevice(object):
' "%s".' % (package, client_name))
clie... |
google__mobly-328 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:AndroidDevice.start_adb_logcat"
],
"edited_modules": [
"mobly/controllers/android_device.py:AndroidDevice"
]
},
"file": "mobly/contr... | google/mobly | 51c912d1a8ffd5ace4a9a744a46498515cf5c145 | `AndroidDevice` adb logcat file name gets truncated
If device model name includes space, the output file name of adb logcat is incorrect.
For example, for model "aqua power hd-4g", we expect `adblog,aqua power hd-4g,usb:3-5.2.3.txt`, but we actually get `adblog,aqua`. | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index 5d7027e..e52e5fd 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -836,10 +836,8 @@ class AndroidDevice(object):
extra_params = self.adb_logcat_param
except Att... |
google__mobly-380 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:AndroidDevice.__init__",
"mobly/controllers/android_device.py:AndroidDevice.update_serial"
],
"edited_modules": [
"mobly/controllers/andro... | google/mobly | 7e5e62af4ab4537bf619f0ee403c05f004c5baf0 | adb call fails if numeric serial numbers are used
If users use devices whose serials are entirely numeric and do not wrap the serial with quotation mark, we get:
```
Traceback (most recent call last):
File ".../mobly/test_runner.py", line 420, in _register_controller
objects = create(controller_config)
F... | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index e4f05de..4eee55b 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -421,7 +421,7 @@ class AndroidDevice(object):
"""
def __init__(self, serial=''):
- self._serial =... |
google__mobly-392 | [
{
"changes": {
"added_entities": [
"mobly/controllers/android_device_lib/adb.py:AdbProxy._execute_and_process_stdout",
"mobly/controllers/android_device_lib/adb.py:AdbProxy._execute_adb_and_process_stdout"
],
"added_modules": null,
"edited_entities": [
"mobly/cont... | google/mobly | a9f2bda0ac5a6a1b11c794522daa8fd97ca0d0b0 | Add timing information for instrumentation tests | diff --git a/mobly/controllers/android_device_lib/adb.py b/mobly/controllers/android_device_lib/adb.py
index 3abcaa9..90dcd0b 100644
--- a/mobly/controllers/android_device_lib/adb.py
+++ b/mobly/controllers/android_device_lib/adb.py
@@ -181,6 +181,47 @@ class AdbProxy(object):
else:
raise AdbError... |
google__mobly-432 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:AndroidDevice.__init__",
"mobly/controllers/android_device.py:AndroidDevice.cat_adb_log"
],
"edited_modules": [
"mobly/controllers/android... | google/mobly | 02b9d84acfe775a6fe73e2b960ba7e47765184d6 | Instrumentation parser output is concatenated in python3.
Python3 outputs newline characters as literals for byte strings.
This causes an issue because `run_instrumentation_test` outputs the raw instrumentation output, which ends up being concatenated since the newlines doesn't properly display with python3.
When f... | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index f1a4636..14828a4 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -436,9 +436,8 @@ class AndroidDevice(object):
self._log_path = os.path.join(self._log_path_base,
... |
google__mobly-433 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:AndroidDevice.__init__",
"mobly/controllers/android_device.py:AndroidDevice.cat_adb_log"
],
"edited_modules": [
"mobly/controllers/android... | google/mobly | 02b9d84acfe775a6fe73e2b960ba7e47765184d6 | AdbLogExcerpts filename is invalid on Windows
Windows filenames should not have colons in them:
https://support.microsoft.com/en-us/help/905231/information-about-the-characters-that-you-cannot-use-in-site-names-fol | diff --git a/mobly/controllers/android_device.py b/mobly/controllers/android_device.py
index f1a4636..14828a4 100644
--- a/mobly/controllers/android_device.py
+++ b/mobly/controllers/android_device.py
@@ -436,9 +436,8 @@ class AndroidDevice(object):
self._log_path = os.path.join(self._log_path_base,
... |
google__mobly-437 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/adb.py:AdbProxy._exec_cmd",
"mobly/controllers/android_device_lib/adb.py:AdbProxy._exec_adb_cmd",
"mobly/controllers/android_device_lib/adb.py:AdbPro... | google/mobly | d8e4c34b46d4bd0f2aa328823e543162933d76c0 | Propagate stderr from adb commands
The current mobly adb proxy does not propagate stderr if ret code is zero.
We thought this was ok since Android has fixed return code issues in M.
But turns out many China manufacturers did not fix this in China devices.
In order to better support China devices and potentially ot... | diff --git a/mobly/controllers/android_device_lib/adb.py b/mobly/controllers/android_device_lib/adb.py
index 432f08e..12c14bd 100644
--- a/mobly/controllers/android_device_lib/adb.py
+++ b/mobly/controllers/android_device_lib/adb.py
@@ -138,7 +138,7 @@ class AdbProxy(object):
def __init__(self, serial=''):
... |
google__mobly-444 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/adb.py:AdbProxy.forward"
],
"edited_modules": [
"mobly/controllers/android_device_lib/adb.py:AdbProxy"
]
},
"file": "mobly/controll... | google/mobly | 8caa5c387b2df47a180e0349fbebe7838b099b83 | `current_test_info` should exist between `setup_class` and `setup_test`
Right now `current_test_info` is None between `setup_class` and `setup_test`, which makes it difficult to use this field consistently.
E.g. if a test relies on this field in `on_fail`, if `setup_class` fails, the logic in `on_fail` would raise a... | diff --git a/mobly/controllers/android_device_lib/adb.py b/mobly/controllers/android_device_lib/adb.py
index 12c14bd..cb5b6b6 100644
--- a/mobly/controllers/android_device_lib/adb.py
+++ b/mobly/controllers/android_device_lib/adb.py
@@ -237,7 +237,8 @@ class AdbProxy(object):
def forward(self, args=None, shell=F... |
google__mobly-445 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device.py:AndroidDevice.__init__"
],
"edited_modules": [
"mobly/controllers/android_device.py:AndroidDevice"
]
},
"file": "mobly/controllers/a... | google/mobly | 8caa5c387b2df47a180e0349fbebe7838b099b83 | Modules missing from API docs
Our [API docs](http://mobly.readthedocs.io/en/stable/)
Is missing some modules like `mobly.runtime_test_info` | diff --git a/docs/mobly.rst b/docs/mobly.rst
index ee4b412..91ecb1b 100644
--- a/docs/mobly.rst
+++ b/docs/mobly.rst
@@ -35,6 +35,14 @@ mobly.config_parser module
:undoc-members:
:show-inheritance:
+mobly.expects module
+--------------------------
+
+.. automodule:: mobly.expects
+ :members:
+ :undoc-... |
google__mobly-453 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/adb.py:AdbProxy._execute_and_process_stdout"
],
"edited_modules": [
"mobly/controllers/android_device_lib/adb.py:AdbProxy"
]
},
"fi... | google/mobly | f1aff6a7f06887424759e3c192b1bf6e13d2a6bf | `_execute_and_process_stdout` should log cmd | diff --git a/mobly/controllers/android_device_lib/adb.py b/mobly/controllers/android_device_lib/adb.py
index 90dcd0b..95d1261 100644
--- a/mobly/controllers/android_device_lib/adb.py
+++ b/mobly/controllers/android_device_lib/adb.py
@@ -203,6 +203,7 @@ class AdbProxy(object):
stderr=subprocess.PIPE,
... |
google__mobly-472 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/config_parser.py:TestRunConfig.__str__"
],
"edited_modules": [
"mobly/config_parser.py:TestRunConfig"
]
},
"file": "mobly/config_parser.py"
},
{
"changes"... | google/mobly | 9c5b19e1b932888d3e347fa529b82f5417b28a5e | Log the contents of config file at the debug level early
This helps in debugging remote user's malformed json/yaml or configs that don't adhere to schema. | diff --git a/mobly/config_parser.py b/mobly/config_parser.py
index aa43c03..b873af0 100644
--- a/mobly/config_parser.py
+++ b/mobly/config_parser.py
@@ -16,6 +16,7 @@ from builtins import str
import copy
import io
+import pprint
import os
import yaml
@@ -189,4 +190,7 @@ class TestRunConfig(object):
ret... |
google__mobly-493 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/config_parser.py:TestRunConfig.__init__",
"mobly/config_parser.py:TestRunConfig.__str__"
],
"edited_modules": [
"mobly/config_parser.py:TestRunConfig"
]
},
... | google/mobly | 566e0b6b8600ef0067575dd4a4ce27540640317c | Move `register_controller` into `base_test`
For historic reasons, `register_controller` lives under `test_runner`.
Back then the consideration was, one day we may want to let controller objects persist across multiple test classes.
This causes multiple organizational problems and incurs complexity.
In hindsight ... | diff --git a/mobly/config_parser.py b/mobly/config_parser.py
index b873af0..2278ca6 100644
--- a/mobly/config_parser.py
+++ b/mobly/config_parser.py
@@ -166,8 +166,6 @@ class TestRunConfig(object):
controller_configs: dict, configs used for instantiating controller
objects.
user_params: d... |
google__mobly-495 | [
{
"changes": {
"added_entities": [
"mobly/records.py:ControllerInfoRecord.__init__",
"mobly/records.py:ControllerInfoRecord.to_dict",
"mobly/records.py:ControllerInfoRecord.__repr__"
],
"added_modules": [
"mobly/records.py:ControllerInfoRecord"
],
"e... | google/mobly | c86a37b358b2a04f5838bb8721ce136db1ba356d | Custom controller info may not be recorded in summary yaml
Controller modules may choose to allow customization of controller info during the test. E.g. `AndroidDevice.add_device_info` adds extra info of the controller objects to the summary yaml.
But `TestRunner` only record the controller info at the controller re... | diff --git a/mobly/records.py b/mobly/records.py
index 051ff9c..171c0ca 100644
--- a/mobly/records.py
+++ b/mobly/records.py
@@ -21,6 +21,7 @@ import io
import logging
import sys
import threading
+import time
import traceback
import yaml
@@ -52,7 +53,7 @@ class TestSummaryEntryType(enum.Enum):
RECORD = 'Rec... |
google__mobly-513 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/service_manager.py:ServiceManager.pause_all",
"mobly/controllers/android_device_lib/service_manager.py:ServiceManager.resume_all"
],
"edited_modu... | google/mobly | 5aa74012449604d732e51637d7775891caab7df2 | Zombie port on host when `AndroidDevice.handle_usb_disconnect` is used
In `AndroidDevice.handle_usb_disconnect`, we never explicitly stop snippet client's port forwarding.
Then during service restoration, a new host port is allocated for the snippet client.
This causes leftover ports in adb port forwarding, which o... | diff --git a/mobly/controllers/android_device_lib/service_manager.py b/mobly/controllers/android_device_lib/service_manager.py
index ce652fb..9853395 100644
--- a/mobly/controllers/android_device_lib/service_manager.py
+++ b/mobly/controllers/android_device_lib/service_manager.py
@@ -106,18 +106,16 @@ class ServiceMana... |
google__mobly-530 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/utils.py:start_standing_subprocess"
],
"edited_modules": [
"mobly/utils.py:start_standing_subprocess"
]
},
"file": "mobly/utils.py"
}
] | google/mobly | e78255672c61f8f091e9eeb09f3b9f46481202d2 | Add env argument to start_standing_subprocess | diff --git a/mobly/utils.py b/mobly/utils.py
index a9f065c..bb2f316 100644
--- a/mobly/utils.py
+++ b/mobly/utils.py
@@ -283,7 +283,7 @@ def concurrent_exec(func, param_list):
return return_vals
-def start_standing_subprocess(cmd, shell=False):
+def start_standing_subprocess(cmd, shell=False, env=None):
... |
google__mobly-531 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/adb.py:AdbError.__init__",
"mobly/controllers/android_device_lib/adb.py:AdbTimeoutError.__init__",
"mobly/controllers/android_device_lib/adb.py:AdbPr... | google/mobly | e78255672c61f8f091e9eeb09f3b9f46481202d2 | `expects` APIs crash in execution stages before the test case
In `setup_class` and `setup_generated_tests`, calling `expects` APIs would cause crashes.
Also in `teardown_class`, `expects` APIs would probably attach errors to the wrong record. | diff --git a/mobly/controllers/android_device_lib/adb.py b/mobly/controllers/android_device_lib/adb.py
index 41af20c..15e2a5c 100644
--- a/mobly/controllers/android_device_lib/adb.py
+++ b/mobly/controllers/android_device_lib/adb.py
@@ -44,13 +44,17 @@ class AdbError(Error):
stdout: byte string, the raw stdout... |
google__mobly-532 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/adb.py:AdbError.__init__",
"mobly/controllers/android_device_lib/adb.py:AdbProxy._exec_cmd"
],
"edited_modules": [
"mobly/controllers/and... | google/mobly | e78255672c61f8f091e9eeb09f3b9f46481202d2 | `AdbError` should have a serial number attr
Our `AdbError` does not include an easily accessible serial number.
When handling an `AdbError`, it is sometimes useful to know which device the command was issued to, especially when you cannot change the code around the adb call directly and have to handle at an upper le... | diff --git a/mobly/controllers/android_device_lib/adb.py b/mobly/controllers/android_device_lib/adb.py
index 41af20c..5e0c36f 100644
--- a/mobly/controllers/android_device_lib/adb.py
+++ b/mobly/controllers/android_device_lib/adb.py
@@ -44,13 +44,17 @@ class AdbError(Error):
stdout: byte string, the raw stdout... |
google__mobly-534 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobly/controllers/android_device_lib/adb.py:AdbError.__init__",
"mobly/controllers/android_device_lib/adb.py:AdbTimeoutError.__init__",
"mobly/controllers/android_device_lib/adb.py:AdbPr... | google/mobly | 95286a01a566e056d44acfa9577a45bc7f37f51d | `AdbError` should have a serial number attr
Our `AdbError` does not include an easily accessible serial number.
When handling an `AdbError`, it is sometimes useful to know which device the command was issued to, especially when you cannot change the code around the adb call directly and have to handle at an upper le... | diff --git a/mobly/controllers/android_device_lib/adb.py b/mobly/controllers/android_device_lib/adb.py
index 5e0c36f..15e2a5c 100644
--- a/mobly/controllers/android_device_lib/adb.py
+++ b/mobly/controllers/android_device_lib/adb.py
@@ -49,7 +49,7 @@ class AdbError(Error):
device.
"""
- def __ini... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.