instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
iterative__dvc-2873 | [
{
"changes": {
"added_entities": [
"dvc/remote/s3.py:RemoteS3.isfile"
],
"added_modules": null,
"edited_entities": [
"dvc/remote/s3.py:RemoteS3.exists",
"dvc/remote/s3.py:RemoteS3.walk_files"
],
"edited_modules": [
"dvc/remote/s3.py:RemoteS3"
... | iterative/dvc | 30848306e86d97e4baf7486c045d5f2fe6e26877 | Cannot add file having name with substring of a folder as prefix in s3
### Steps to reproduce
1. Upload two files in s3: `folder/data/data.csv` and` folder/datasets.md`.
2. Setup remotes and caches.
```sh
dvc remote add -f s3 s3://dvc-temp/folder
dvc remote add -f cache remote://s3/cache
dvc config cache.s3 cache... | diff --git a/dvc/remote/s3.py b/dvc/remote/s3.py
index 8013f9bb9..8dd2bdf48 100644
--- a/dvc/remote/s3.py
+++ b/dvc/remote/s3.py
@@ -5,6 +5,7 @@ import logging
import os
import threading
+from botocore.exceptions import ClientError
from funcy import cached_property, wrap_prop
from dvc.config import Config
@@ -2... |
iterative__dvc-2922 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/checkout.py:CmdCheckout.run",
"dvc/command/checkout.py:add_parser"
],
"edited_modules": [
"dvc/command/checkout.py:CmdCheckout",
"dvc/command/checkout.py:... | iterative/dvc | 75ecc9960d7a61d1a74c194839bb7092ba692a72 | optimize dir checkout
https://github.com/iterative/dvc/issues/2444#issuecomment-530756109 | diff --git a/dvc/command/checkout.py b/dvc/command/checkout.py
index 2802b1b15..3fb208334 100644
--- a/dvc/command/checkout.py
+++ b/dvc/command/checkout.py
@@ -12,6 +12,7 @@ class CmdCheckout(CmdBase):
targets=self.args.targets,
with_deps=self.args.with_deps,
force=self.args.forc... |
iterative__dvc-2974 | [
{
"changes": {
"added_entities": [
"dvc/ignore.py:CleanTree.__init__",
"dvc/ignore.py:CleanTree.dvcignore",
"dvc/ignore.py:CleanTree.tree_root",
"dvc/ignore.py:CleanTree.open",
"dvc/ignore.py:CleanTree.exists",
"dvc/ignore.py:CleanTree.isdir",
"dvc/i... | iterative/dvc | 0a3a9bf58cc2cc84e45c6cf9efc48c59e3ce1b9a | dvc: dvc_walk() and related things are broken by design
A few things:
- when we collect stages in a branch dvcignore is not used at all, i.e. we go into `.dvc` and other ignored dirs
- `dvc_walk()` and `walk_files()` always walk the working dir, but might accept `dvcignore` built from a branch. The results will make ... | diff --git a/dvc/ignore.py b/dvc/ignore.py
index fbfcff3ac..64f79068c 100644
--- a/dvc/ignore.py
+++ b/dvc/ignore.py
@@ -3,9 +3,11 @@ from __future__ import unicode_literals
import logging
import os
+from funcy import cached_property
from pathspec import PathSpec
from pathspec.patterns import GitWildMatchPattern
... |
iterative__dvc-2975 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/analytics.py:send"
],
"edited_modules": [
"dvc/analytics.py:send"
]
},
"file": "dvc/analytics.py"
},
{
"changes": {
"added_entities": [
"dvc/l... | iterative/dvc | e7b3297c2d6ae1ad633cd0435cca81093cac86ff | dvc add absolute_path
`~/repo$ dvc add $HOME/repo/file` should realise that the file is not "external" and add it as a relative path rather than absolute. | diff --git a/dvc/analytics.py b/dvc/analytics.py
index 7c0a69310..76dbc335c 100644
--- a/dvc/analytics.py
+++ b/dvc/analytics.py
@@ -76,7 +76,10 @@ def send(report):
headers = {"content-type": "application/json"}
with open(report, "rb") as fobj:
- requests.post(url, data=fobj, headers=headers, timeou... |
iterative__dvc-3020 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/dependency/repo.py:DependencyREPO._is_git_file",
"dvc/dependency/repo.py:DependencyREPO._copy_if_git_file"
],
"edited_modules": [
"dvc/dependency/repo.py:DependencyREPO"
... | iterative/dvc | cbc7e21593b30402ff53c28a62ddcaa3dd5bf277 | import: Handle non-DVC Git repositories
After https://github.com/iterative/dvc/pull/2889, `dvc import` can also import files that are tracked by Git but not DVC. DVC still requires that they come from a DVC repository rather than any Git repository, although there is no longer need for that. | diff --git a/dvc/dependency/repo.py b/dvc/dependency/repo.py
index 0963e1061..595b836dc 100644
--- a/dvc/dependency/repo.py
+++ b/dvc/dependency/repo.py
@@ -6,7 +6,9 @@ from dvc.utils.compat import FileNotFoundError
from funcy import merge
from .local import DependencyLOCAL
+from dvc.external_repo import cached_clo... |
iterative__dvc-3088 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/version.py:CmdVersion.get_linktype_support_info"
],
"edited_modules": [
"dvc/command/version.py:CmdVersion"
]
},
"file": "dvc/command/version.py"
},
{
... | iterative/dvc | b99c5e4aad6528199ef960d04043f8ffdf3f528c | Hardlinks not correctly detected on SMB network share (NTFS?)
Using DVC version 0.80, with repo and cache both on the same network drive.
Windows setup.
I'm testing the `unprotect` command, but I assume other commands relying on the same check will also exhibit strange failures.
```
PS Q:\dvc-test> dvc --versio... | diff --git a/dvc/command/version.py b/dvc/command/version.py
index aa7d630af..60c6109d3 100644
--- a/dvc/command/version.py
+++ b/dvc/command/version.py
@@ -86,9 +86,9 @@ class CmdVersion(CmdBaseNoRepo):
@staticmethod
def get_linktype_support_info(repo):
links = {
- "reflink": System.refli... |
iterative__dvc-3097 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/get.py:add_parser"
],
"edited_modules": [
"dvc/command/get.py:add_parser"
]
},
"file": "dvc/command/get.py"
},
{
"changes": {
"added_entities"... | iterative/dvc | 84ec0d49a339a6148b1e92d10c78aa308e9c9df8 | get: handle non-DVC repositories
Even though #2977 solved this for `dvc import`, it looks like it is still not supported for `dvc get`. It might be a simple bug or code path is different. We need to fix and add tests for this.
**Version**:
```
VC version: 0.80.0+82cdce
Python version: 3.7.5
Platform: Darwin-18.2... | diff --git a/dvc/command/get.py b/dvc/command/get.py
index 9aba35c0d..22856f1c0 100644
--- a/dvc/command/get.py
+++ b/dvc/command/get.py
@@ -31,7 +31,9 @@ class CmdGet(CmdBaseNoRepo):
def add_parser(subparsers, parent_parser):
- GET_HELP = "Download/copy files or directories from DVC repository."
+ GET_HELP ... |
iterative__dvc-3129 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/version.py:_is_release"
],
"edited_modules": [
"dvc/version.py:_is_release"
]
},
"file": "dvc/version.py"
}
] | iterative/dvc | fe635a5040c9d593cd1bdef3fa31f4df7af85259 | dvc: fix version generatio
Looks like dynamic version got broken https://travis-ci.com/iterative/dvc/jobs/274986530 .
| diff --git a/dvc/version.py b/dvc/version.py
index a1ebd240b..411510f57 100644
--- a/dvc/version.py
+++ b/dvc/version.py
@@ -49,7 +49,7 @@ def _is_release(dir_path, base_version):
["git", "describe", "--tags", "--exact-match"],
cwd=dir_path,
stderr=subprocess.STDOUT,
- )
+ ... |
iterative__dvc-3132 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/remote/config.py:RemoteConfig.modify"
],
"edited_modules": [
"dvc/remote/config.py:RemoteConfig"
]
},
"file": "dvc/remote/config.py"
}
] | iterative/dvc | fe635a5040c9d593cd1bdef3fa31f4df7af85259 | remote: allow modifying only existing entries
**DVC version**: `0.81.0`
Using `dvc remote modify` on a non-existing entry creates an invalid remote configuration, since it creates a remote without a URL.
```bash
dvc init --no-scm
dvc remote modify missing <option> <value>
```
Ideally, raising an error shoul... | diff --git a/dvc/remote/config.py b/dvc/remote/config.py
index 87572bd1d..b409e7eab 100644
--- a/dvc/remote/config.py
+++ b/dvc/remote/config.py
@@ -3,8 +3,7 @@ import os
import posixpath
from urllib.parse import urlparse
-from dvc.config import Config
-from dvc.config import ConfigError
+from dvc.config import Con... |
iterative__dvc-3133 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"dvc/config.py:Config"
]
},
"file": "dvc/config.py"
},
{
"changes": {
"added_entities": [
"dvc/remote/base.py:RemoteBASE._get_checksum_jo... | iterative/dvc | 0be0931fcda067f79233a6e13c2b34c5a7fc62f7 | core.checksum_jobs doesn't work for remotes
https://github.com/iterative/dvc/issues/2891#issuecomment-562812250
| diff --git a/dvc/config.py b/dvc/config.py
index ad2070939..0fd312aa1 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -186,6 +186,7 @@ class Config(object): # pylint: disable=too-many-instance-attributes
SECTION_GDRIVE_CLIENT_SECRET = "gdrive_client_secret"
SECTION_GDRIVE_USER_CREDENTIALS_FILE = "gdrive_us... |
iterative__dvc-3150 | [
{
"changes": {
"added_entities": [
"dvc/dependency/repo.py:DependencyREPO._get_checksum"
],
"added_modules": null,
"edited_entities": [
"dvc/dependency/repo.py:DependencyREPO.status"
],
"edited_modules": [
"dvc/dependency/repo.py:DependencyREPO"
... | iterative/dvc | 0be0931fcda067f79233a6e13c2b34c5a7fc62f7 | status: implement support for import-ed files
See https://github.com/iterative/dvc/pull/2889#discussion_r357950906 for context | diff --git a/dvc/dependency/repo.py b/dvc/dependency/repo.py
index 3e1878f9c..3bcfd3e65 100644
--- a/dvc/dependency/repo.py
+++ b/dvc/dependency/repo.py
@@ -9,8 +9,10 @@ from dvc.external_repo import cached_clone
from dvc.external_repo import external_repo
from dvc.exceptions import NotDvcRepoError
from dvc.exceptio... |
iterative__dvc-3170 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/utils/__init__.py:resolve_output"
],
"edited_modules": [
"dvc/utils/__init__.py:resolve_output"
]
},
"file": "dvc/utils/__init__.py"
}
] | iterative/dvc | bdd1d61803d0962169fc1ae3b9a0ad634497a926 | dvc get can can delete the current directory
First off, I saw it coming, had my stuff backed up etc, so no harm done.
I was trying to test out dvc get to pull models from a different project and the cache must not have been present in the remote:
`models/mlr/production` is defined as the output of a dvc file.
... | diff --git a/dvc/utils/__init__.py b/dvc/utils/__init__.py
index edb77e93b..bf02ecdb2 100644
--- a/dvc/utils/__init__.py
+++ b/dvc/utils/__init__.py
@@ -336,7 +336,7 @@ def env2bool(var, undefined=False):
def resolve_output(inp, out):
from urllib.parse import urlparse
- name = os.path.basename(urlparse(inp).... |
iterative__dvc-3190 | [
{
"changes": {
"added_entities": [
"dvc/api.py:_require_dvc"
],
"added_modules": [
"dvc/api.py:_require_dvc"
],
"edited_entities": [
"dvc/api.py:get_url",
"dvc/api.py:_open",
"dvc/api.py:_make_repo",
"dvc/api.py:prepare_summon"
... | iterative/dvc | 7d65002bf0c1a76879ba4a08571d101eb98b96ba | import/get/api: external repo and cached_clone are problematic
There are several issues with `external_repo()`, `cached_clone()` and code using them - get, import and api stuff:
- there are 3 parallel code paths doing very close things, we add the same features for them, fix the same bugs, essentially do triple work... | diff --git a/dvc/api.py b/dvc/api.py
index 5c3401bbe..e1f87d09c 100644
--- a/dvc/api.py
+++ b/dvc/api.py
@@ -10,7 +10,7 @@ import ruamel.yaml
from voluptuous import Schema, Required, Invalid
from dvc.repo import Repo
-from dvc.exceptions import DvcException, NotDvcRepoError
+from dvc.exceptions import DvcException
... |
iterative__dvc-3200 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"dvc/config.py:Config"
]
},
"file": "dvc/config.py"
},
{
"changes": {
"added_entities": [
"dvc/data_cloud.py:DataCloud._save_pulled_check... | iterative/dvc | d942542c841b054865760afc2b212db10d5b901f | option to have dvc pull trust the remote and not calculate its own MD5 hashes
The dvc pull command takes the time (which can be significant it seems) to calculate its own MD5 hashes. It would be nice if there were an option to tell it to trust the remote and skip this so that it would complete faster. Or it could trus... | diff --git a/dvc/config.py b/dvc/config.py
index 65250c76d..0759395d0 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -198,6 +198,7 @@ class Config(object): # pylint: disable=too-many-instance-attributes
SECTION_REMOTE_ASK_PASSWORD = "ask_password"
SECTION_REMOTE_GSS_AUTH = "gss_auth"
SECTION_REMOTE_N... |
iterative__dvc-3217 | [
{
"changes": {
"added_entities": [
"dvc/command/pipeline.py:CmdPipelineShow._build_graph",
"dvc/command/pipeline.py:CmdPipelineShow._write_dot"
],
"added_modules": null,
"edited_entities": [
"dvc/command/pipeline.py:CmdPipelineShow.__build_graph",
"dvc/com... | iterative/dvc | e9caa44b554daf7f0f21dc2bb9bb0df028369fb1 | pipeline: show: outs: improper DAG
See https://discordapp.com/channels/485586884165107732/485586884165107734/557205322641702912 . We should connect outputs to dependencies here https://github.com/iterative/dvc/blob/0.32.1/dvc/command/pipeline.py#L70 instead of connecting all outputs to all outputs of a dependant stage. | diff --git a/dvc/command/pipeline.py b/dvc/command/pipeline.py
index cbec6abf3..510e1feb1 100644
--- a/dvc/command/pipeline.py
+++ b/dvc/command/pipeline.py
@@ -31,45 +31,50 @@ class CmdPipelineShow(CmdBase):
else:
logger.info(stage.path_in_repo)
- def __build_graph(self, target, comm... |
iterative__dvc-3222 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/api.py:_make_repo"
],
"edited_modules": [
"dvc/api.py:_make_repo"
]
},
"file": "dvc/api.py"
},
{
"changes": {
"added_entities": null,
"added_mod... | iterative/dvc | 49039968f74282bdab3aa05b4582e5d392fc0ccc | api: does not work with git only local repository
```sh
➜ cd "$(mktemp -d)"
➜ git init
Initialized empty Git repository in /tmp/tmp.TGV6SVXYsz/.git/
➜ echo "foo" > foo
➜ git add foo
➜ git -c commit.gpgsign=false commit -m "first"
[master (root-commit) 136fd94] first
1 file changed, 1 insertion(+)
create m... | diff --git a/dvc/api.py b/dvc/api.py
index 2ae39bae7..7efaf524a 100644
--- a/dvc/api.py
+++ b/dvc/api.py
@@ -10,7 +10,7 @@ import ruamel.yaml
from voluptuous import Schema, Required, Invalid
from dvc.repo import Repo
-from dvc.exceptions import DvcException
+from dvc.exceptions import DvcException, NotDvcRepoError
... |
iterative__dvc-3227 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/api.py:_make_repo"
],
"edited_modules": [
"dvc/api.py:_make_repo"
]
},
"file": "dvc/api.py"
},
{
"changes": {
"added_entities": [
"dvc/externa... | iterative/dvc | 1bc39e7e99f131d8d83e5ec681d2560e4bbb9170 | summon api: caching during interactive sessions
```
$ dvc -V
0.80.0+7f92cc
```
In Python session:
```python
>>> import dvc.api
>>> m = dvc.api.summon('resnext101', 'https://github.com/dmpetrov/dvc-pretrained-resnet', 'test_summon', 'resnext101_32x8d.yml')
...
dvc.api.SummonError: extra keys not allowed @ dat... | diff --git a/dvc/api.py b/dvc/api.py
index 7efaf524a..2ae39bae7 100644
--- a/dvc/api.py
+++ b/dvc/api.py
@@ -10,7 +10,7 @@ import ruamel.yaml
from voluptuous import Schema, Required, Invalid
from dvc.repo import Repo
-from dvc.exceptions import DvcException, NotDvcRepoError
+from dvc.exceptions import DvcException
... |
iterative__dvc-3284 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/rwlock.py:_check_blockers"
],
"edited_modules": [
"dvc/rwlock.py:_check_blockers"
]
},
"file": "dvc/rwlock.py"
},
{
"changes": {
"added_entities": nul... | iterative/dvc | 509ce3e16ee6cbae6350c104ce9533c322fccebe | Add a way to suppress dvc changes to .gitignore
At the moment, DVC make changes to the .gitignore after commands like `dvc add`. There are cases, like mine, where it's not needed as .gitignore already exclude whole directory where data is kept.
Add a configuration that allow to suppress dvc changes to .gitignore. | diff --git a/dvc/rwlock.py b/dvc/rwlock.py
index c9d15eae2..6b1d4de14 100644
--- a/dvc/rwlock.py
+++ b/dvc/rwlock.py
@@ -66,10 +66,11 @@ def _infos_to_str(infos):
def _check_blockers(lock, info, *, mode, waiters):
for path_info in waiters:
blockers = [
- info
+ blocker
... |
iterative__dvc-3299 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/diff.py:CmdDiff.run",
"dvc/command/diff.py:add_parser"
],
"edited_modules": [
"dvc/command/diff.py:CmdDiff",
"dvc/command/diff.py:add_parser"
]
... | iterative/dvc | 7821fa6866a492c0675248028039257d292a09ec | term: replace (Git) "reference" for "revision" or "commit"
Revisions are slightly more accurate - https://git-scm.com/docs/revisions
> A revision parameter '<rev>' typically, but not necessarily, names a commit object.
References are the ones living in `.git/refs`: https://git-scm.com/book/en/v2/Git-Internals-Git... | diff --git a/dvc/command/diff.py b/dvc/command/diff.py
index 32ea8220d..650555572 100644
--- a/dvc/command/diff.py
+++ b/dvc/command/diff.py
@@ -95,7 +95,7 @@ class CmdDiff(CmdBase):
def run(self):
try:
- diff = self.repo.diff(self.args.a_ref, self.args.b_ref)
+ diff = self.repo.di... |
iterative__dvc-3309 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/update.py:CmdUpdate.run",
"dvc/command/update.py:add_parser"
],
"edited_modules": [
"dvc/command/update.py:CmdUpdate",
"dvc/command/update.py:add_parser"
... | iterative/dvc | 77f24af727c7ed6225296b20e80fd9e7b56b7460 | dvc: provide granularity for commands that could target specific tracked files
> This can be seen as revisiting feature request #1026
UPDATE: Please scroll down to https://github.com/iterative/dvc/issues/2458#issuecomment-566649020 for most recent, summarized requirement.
Here is the original context also (still re... | diff --git a/dvc/command/update.py b/dvc/command/update.py
index 47df68dd6..73f4d097d 100644
--- a/dvc/command/update.py
+++ b/dvc/command/update.py
@@ -14,7 +14,7 @@ class CmdUpdate(CmdBase):
ret = 0
for target in self.args.targets:
try:
- self.repo.update(target)
+ ... |
iterative__dvc-3315 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/scm/git/__init__.py:Git.remind_to_track"
],
"edited_modules": [
"dvc/scm/git/__init__.py:Git"
]
},
"file": "dvc/scm/git/__init__.py"
}
] | iterative/dvc | 9e7740572c2cb3e9a4b29e884ca95cb99c694b8d | `dvc add` print not quote-wrapped file-paths if they contain spaces
dvc 0.82.8
installed via yum
centos 7
Some of our, khm, windows-users put files in project with spaces in names.
In this case `dvc add`, when prints hint-command `git add blah-blah`, not wrap path with quotes so copy-paste this hint-command not w... | diff --git a/dvc/scm/git/__init__.py b/dvc/scm/git/__init__.py
index 8f05ad029..e70d6f7b0 100644
--- a/dvc/scm/git/__init__.py
+++ b/dvc/scm/git/__init__.py
@@ -3,6 +3,7 @@
import logging
import os
import yaml
+import shlex
from funcy import cached_property
from pathspec.patterns import GitWildMatchPattern
@@ -3... |
iterative__dvc-3316 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/progress.py:Tqdm.__init__"
],
"edited_modules": [
"dvc/progress.py:Tqdm"
]
},
"file": "dvc/progress.py"
},
{
"changes": {
"added_entities": null,
... | iterative/dvc | 77f24af727c7ed6225296b20e80fd9e7b56b7460 | dvc push -q is not completely quiet, shows file transfer tqdm progress bars
Hey guys, love what you've done with DVC.
Had a quick bug that's causing me a little issue. When I use 'dvc push -q' I'm still seeing tqdm progress bars. Wouldn't be a huge issue, but I'm probably pushing 100K 250kb files. This is a local re... | diff --git a/dvc/progress.py b/dvc/progress.py
index d03b037c0..a8ab61951 100644
--- a/dvc/progress.py
+++ b/dvc/progress.py
@@ -55,7 +55,8 @@ class Tqdm(tqdm):
desc : persists after `close()`
level : effective logging level for determining `disable`;
used only if `disable` is unspecifi... |
iterative__dvc-3323 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/external_repo.py:_clone_default_branch"
],
"edited_modules": [
"dvc/external_repo.py:_clone_default_branch"
]
},
"file": "dvc/external_repo.py"
}
] | iterative/dvc | 51a5a4ec3b5fa91c431e10b0d4eb093fbcb88a84 | Speed up dvc status for large projects
**Please provide information about your setup**
DVC version(i.e. `dvc --version`), Platform and method of installation (pip, homebrew, pkg Mac, exe (Windows), DEB(Linux), RPM(Linux))
```
dvc version
DVC version: 0.82.8
Python version: 3.7.6
Platform: Linux-5.0.0-37-gener... | diff --git a/dvc/external_repo.py b/dvc/external_repo.py
index 9ea0d62e2..6bb34f4b5 100644
--- a/dvc/external_repo.py
+++ b/dvc/external_repo.py
@@ -200,7 +200,7 @@ def _clone_default_branch(url, rev):
if clone_path:
git = Git(clone_path)
# Do not pull for known shas, branches and tag... |
iterative__dvc-3325 | [
{
"changes": {
"added_entities": [
"dvc/logger.py:ColorFormatter.formatTime"
],
"added_modules": null,
"edited_entities": [
"dvc/logger.py:ColorFormatter.format"
],
"edited_modules": [
"dvc/logger.py:ColorFormatter"
]
},
"file": "dvc/logg... | iterative/dvc | 0c877710641ff235cde67e98f53861d0cf9d42b3 | loggers: include timestamp to see how long operation takes
In logger output (mostly `dvc command -v`) we need to add time to see operation differences, see how long it took overall, etc. It's very valuable information.
| diff --git a/dvc/logger.py b/dvc/logger.py
index d1cf08e83..ce4a46c04 100644
--- a/dvc/logger.py
+++ b/dvc/logger.py
@@ -59,12 +59,28 @@ class ColorFormatter(logging.Formatter):
def format(self, record):
msg = record.msg.format(*record.args) if record.args else record.msg
exception, stack_trace =... |
iterative__dvc-3329 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/config.py:Config.load"
],
"edited_modules": [
"dvc/config.py:Config"
]
},
"file": "dvc/config.py"
}
] | iterative/dvc | 5b737a0a0b7e4ac3377d84c353be8ac7761685d4 | `dvc` commands fail on non-DVC repository with an exception
```
$ cd "$(mktemp -d)" && dvc
ERROR: the following arguments are required: COMMAND
usage: dvc [-q | -v] [-h] [-V] COMMAND ...
Data Version Control
optional arguments:
-q, --quiet Be quiet.
-v, --verbose Be verbose.
-h, --help Show th... | diff --git a/.travis.yml b/.travis.yml
index 971a2bb9e..514d4bd21 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -81,6 +81,8 @@ jobs:
- name: snapcraft
channel: stable
confinement: classic
+ - name: review-tools
+ channel: stable
- name: lxd
channel: stable
env:
diff --... |
iterative__dvc-3333 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "dvc/output/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/progress.... | iterative/dvc | 77f24af727c7ed6225296b20e80fd9e7b56b7460 | DVC does fails when the md5 hash contains only numbers
The description is in the title. When an md5 hash randomly contains only numbers DVC fails, reporting
ERROR: failed to update 'step_X.dvc'. - DVC-file 'step_X.dvc' format error: expected str for dictionary value @ data['md5']
This should happen on averag... | diff --git a/dvc/output/__init__.py b/dvc/output/__init__.py
index abcf68191..e86deeba5 100644
--- a/dvc/output/__init__.py
+++ b/dvc/output/__init__.py
@@ -1,5 +1,5 @@
from urllib.parse import urlparse
-from voluptuous import Any, Required
+from voluptuous import Any, Required, Lower, Length, Coerce, And, SetTo
fr... |
iterative__dvc-3337 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/update.py:CmdUpdate.run",
"dvc/command/update.py:add_parser"
],
"edited_modules": [
"dvc/command/update.py:CmdUpdate",
"dvc/command/update.py:add_parser"
... | iterative/dvc | 4087b020dbac200afa04586650157bf588870053 | Support revisions in dvc update
```
dvc update --rev hello_world file.dvc
```
it is still not supported but it seems like a very handy alternative to re-importing:
```
dvc import --rev hello_world https://github.com/dmpetrov/dataset file
``` | diff --git a/dvc/command/update.py b/dvc/command/update.py
index 47df68dd6..73f4d097d 100644
--- a/dvc/command/update.py
+++ b/dvc/command/update.py
@@ -14,7 +14,7 @@ class CmdUpdate(CmdBase):
ret = 0
for target in self.args.targets:
try:
- self.repo.update(target)
+ ... |
iterative__dvc-3349 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/repo/__init__.py:locked"
],
"edited_modules": [
"dvc/repo/__init__.py:locked"
]
},
"file": "dvc/repo/__init__.py"
},
{
"changes": {
"added_entities": ... | iterative/dvc | a9161af593a5614fbf6f8dd61e0caa87b6b2a78a | Bug: `dvc add` fails with a modified file (or directory) at the end of a list of files
Using DVC 0.71.0 on RHEL6, installed via `conda`, configured for system-wide hard links (not sure if it's relevant):
```
$ dvc --version
0.71.0
$ cat ~/.config/dvc/config
[cache]
protected = true
type = hardlink
```
I ... | diff --git a/dvc/repo/__init__.py b/dvc/repo/__init__.py
index 36dc6b073..6205e24e5 100644
--- a/dvc/repo/__init__.py
+++ b/dvc/repo/__init__.py
@@ -24,6 +24,7 @@ def locked(f):
@wraps(f)
def wrapper(repo, *args, **kwargs):
with repo.lock, repo.state:
+ repo._reset()
ret = f(r... |
iterative__dvc-3405 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/analytics.py:_scm_in_use"
],
"edited_modules": [
"dvc/analytics.py:_scm_in_use"
]
},
"file": "dvc/analytics.py"
}
] | iterative/dvc | 432e399f44344760a7b135a71970533dd3e18953 | Analytics errors out on SCM creation
After https://github.com/iterative/dvc/pull/3257
`dvc init --no-scm` throws errors which seem to be related to the analytics module. | diff --git a/dvc/analytics.py b/dvc/analytics.py
index f6d404179..eb7f99a12 100644
--- a/dvc/analytics.py
+++ b/dvc/analytics.py
@@ -15,7 +15,8 @@ from dvc.daemon import daemon
from dvc.exceptions import NotDvcRepoError
from dvc.lock import Lock, LockError
from dvc.repo import Repo
-from dvc.scm import SCM
+from dvc... |
iterative__dvc-3428 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/api.py:get_url",
"dvc/api.py:_require_dvc"
],
"edited_modules": [
"dvc/api.py:get_url",
"dvc/api.py:_require_dvc"
]
},
"file": "dvc/api.py"
},
{... | iterative/dvc | ea981ae955c1212eaed52dc84f225731bc516785 | add: empty files add broken when cache mode is hardlinks
## DVC Version
```
DVC version: 0.86.5+f67314.mod
Python version: 3.7.6
Platform: Darwin-18.2.0-x86_64-i386-64bit
Binary: False
Package: None
Cache: reflink - supported, hardlink - supported, symlink - supported
Filesystem type (cache directory): ('ap... | diff --git a/dvc/api.py b/dvc/api.py
index d1312baaf..98763d16a 100644
--- a/dvc/api.py
+++ b/dvc/api.py
@@ -7,31 +7,44 @@ from dvc.external_repo import external_repo
class UrlNotDvcRepoError(DvcException):
- """Thrown if given URL is not a DVC repository.
-
- Args:
- url (str): URL to the repository
... |
iterative__dvc-3472 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/unprotect.py:add_parser"
],
"edited_modules": [
"dvc/command/unprotect.py:add_parser"
]
},
"file": "dvc/command/unprotect.py"
},
{
"changes": {
... | iterative/dvc | 4b5d4d759ac4f90f618cc4317fd635dd93be1ad2 | Pull extrememly slow on ~400GB of data with hot DVC cache
OS: Docker image based off of `tensorflow/tensorflow:latest-gpu-py3`, with Python 3.7.5 as the system Python.
Initial setup:
```
# python --version
Python 3.7.5
# python -m venv .profiling_venv
# source .profiling_venv/bin/activate
# pip install dvc yap... | diff --git a/dvc/command/unprotect.py b/dvc/command/unprotect.py
index eb6dc8876..e9c5df81a 100644
--- a/dvc/command/unprotect.py
+++ b/dvc/command/unprotect.py
@@ -22,7 +22,10 @@ class CmdUnprotect(CmdBase):
def add_parser(subparsers, parent_parser):
- UNPROTECT_HELP = "Unprotect data files or directories."
+ ... |
iterative__dvc-3490 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/data_sync.py:add_parser"
],
"edited_modules": [
"dvc/command/data_sync.py:add_parser"
]
},
"file": "dvc/command/data_sync.py"
},
{
"changes": {
... | iterative/dvc | 205a6058879485f077524c5d808cb01d9fa8a3c4 | Optimize stage collection for large repos
I posted this issue #2666 yesterday which was closed but the patch did not solve my underlying issue. The DAG is constructed using the stages from the `repo.collect_stages()` method. This method is what is very slow for me with a large repo. So I would like to ask again if you ... | diff --git a/dvc/command/data_sync.py b/dvc/command/data_sync.py
index 7be18cc74..a7decd18b 100644
--- a/dvc/command/data_sync.py
+++ b/dvc/command/data_sync.py
@@ -102,7 +102,7 @@ def add_parser(subparsers, _parent_parser):
from dvc.command.status import CmdDataStatus
# Pull
- PULL_HELP = "Pull data fil... |
iterative__dvc-3493 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/gc.py:CmdGC.run"
],
"edited_modules": [
"dvc/command/gc.py:CmdGC"
]
},
"file": "dvc/command/gc.py"
},
{
"changes": {
"added_entities": null,
... | iterative/dvc | 02daaf391afa31fed3c04413049eece6579b227c | gc: `-c` works without scope specifier (-w,a,T etc)
As the title says, `dvc gc -c` works without `-w`/`-T`/`-a` specifiers (i.e. by default, it assumes `-w`).
It'd be good to only get in action when those specifiers are mentioned for `dvc gc -c`.
### Refs:
[Discord discussion](https://discordapp.com/channels/4855... | diff --git a/dvc/command/gc.py b/dvc/command/gc.py
index b4b710ae7..64e634d3a 100644
--- a/dvc/command/gc.py
+++ b/dvc/command/gc.py
@@ -19,7 +19,6 @@ class CmdGC(CmdBase):
all_tags=self.args.all_tags,
all_commits=self.args.all_commits,
workspace=self.args.workspace,
- ... |
iterative__dvc-3495 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/gc.py:CmdGC.run"
],
"edited_modules": [
"dvc/command/gc.py:CmdGC"
]
},
"file": "dvc/command/gc.py"
},
{
"changes": {
"added_entities": null,
... | iterative/dvc | e1334448ea75090e57751fb5ebdc6446d6397c77 | tab completion scripts need more love
Seems to me it's about time we review and update tab completion scripts again (like in #1732)? There are some new and removed commands, options, etc, I think. See also #2983. Some other examples:
- `gc --all-commits` has been hidden from help output (#2681).
- `dvc run --remove... | diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 5582aacbe..b50dcdb9e 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,7 +1,7 @@
-* [ ] ❗ Have you followed the guidelines in the [Contributing to DVC](https://dvc.org/doc/user-guide/contribut... |
iterative__dvc-3507 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/pipeline.py:CmdPipelineShow._build_graph"
],
"edited_modules": [
"dvc/command/pipeline.py:CmdPipelineShow"
]
},
"file": "dvc/command/pipeline.py"
}
] | iterative/dvc | 498ee509da49e23a8588893b15328318e73f15ae | pipeline show: in outputs (--outs) mode prints dependencies
Version:
```
DVC version: 0.88.0+79aa61
Python version: 3.7.6
Platform: Darwin-18.2.0-x86_64-i386-64bit
Binary: False
Package: None
Filesystem type (workspace): ('apfs', '/dev/disk1s1')
```
Issue:
See here:
https://github.com/iterative/dvc.o... | diff --git a/dvc/command/pipeline.py b/dvc/command/pipeline.py
index 027f82954..6aedb086a 100644
--- a/dvc/command/pipeline.py
+++ b/dvc/command/pipeline.py
@@ -48,26 +48,21 @@ class CmdPipelineShow(CmdBase):
elif outs:
for out in stage.outs:
nodes.add(str(out))
- ... |
iterative__dvc-3512 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/external_repo.py:ExternalRepo._fix_upstream"
],
"edited_modules": [
"dvc/external_repo.py:ExternalRepo"
]
},
"file": "dvc/external_repo.py"
}
] | iterative/dvc | 84760dc738ef9788baa94147055710a5abb1bfff | import: does not work from bare git repo
Here's a repro:
```sh
#!/usr/bin/env bash
set -ex
temp=$(mktemp -d)
cd "$temp"
mkdir {repo1,repo2,upstream,dataregistry}
# create artifacts on repo1 and commit
cd repo1
git init && dvc init
dvc run -f output.dvc -o 1 "echo 1 >> 1"
dvc remote add -d local ../datare... | diff --git a/README.rst b/README.rst
index de442da1d..bf975c648 100644
--- a/README.rst
+++ b/README.rst
@@ -307,6 +307,6 @@ Iterative, *DVC: Data Version Control - Git for Data & Models* (2020)
:target: https://doi.org/10.5281/zenodo.3677553
:alt: DOI
-.. |Flowchart| image:: https://dvc.org/static/img/flow.g... |
iterative__dvc-3527 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/remote/local.py:RemoteLOCAL.protect"
],
"edited_modules": [
"dvc/remote/local.py:RemoteLOCAL"
]
},
"file": "dvc/remote/local.py"
},
{
"changes": {
"ad... | iterative/dvc | 42e3b8aa2577b7633407cdd17763d72ed7dfc18c | 0.90.0 requires write permission on cache dir
Since 0.90.0, dvc fetch, dvc checkout and dvc pull all fail with:
$ dvc pull
ERROR: unexpected error - [Errno 30] Read-only file system: '/Volumes/dvc/eac-plv-dataset-iphone5-4k-okr_q4_2019/2c/b5d8b77eb1ac4f56dfbce8aa2f4dfd'
/Volumes/dvc is a read-only NFS mount. U... | diff --git a/dvc/remote/local.py b/dvc/remote/local.py
index 25d409f67..7a93434f3 100644
--- a/dvc/remote/local.py
+++ b/dvc/remote/local.py
@@ -448,13 +448,17 @@ class RemoteLOCAL(RemoteBASE):
try:
os.chmod(path, mode)
except OSError as exc:
- # In share cache scenario, we mig... |
iterative__dvc-3534 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "dvc/config.py"
},
{
"changes": {
"added_entities": [
"dvc/path_info.py:URLInfo._fill_parts"
],
"added_modules": null,
... | iterative/dvc | 9de8d1e0faf6cc9460cd2e1e30835ac64fc6ff4d | diff: compare dirty vs committed workspace by default
By default `dvc diff` compares workspace to HEAD (or to a single commit if only one arg is provided). This is the one of the most important use cases. I would like to see the "uncommitted" (in a DVC-sense - when we update md5) changes to data files and directories:
... | diff --git a/dvc/config.py b/dvc/config.py
index 50cd8feb3..6e1ccd7f5 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -179,6 +179,7 @@ SCHEMA = {
"gdrive_service_account_email": str,
"gdrive_service_account_user_email": str,
"gdrive_service_account_p12_fi... |
iterative__dvc-3537 | [
{
"changes": {
"added_entities": [
"dvc/remote/base.py:RemoteBASE._cache_paths_with_max",
"dvc/remote/base.py:RemoteBASE._max_estimation_size",
"dvc/remote/base.py:RemoteBASE._estimate_cache_size"
],
"added_modules": null,
"edited_entities": [
"dvc/remote/... | iterative/dvc | 0c2e4d0b723a7c2f120db751193463b4939303d7 | remote: short-circuit remote size estimation for large remotes
Follow up to #3501
Original comment:
> one more comment (after watching the demo) - I think what we miss here is also some threshold on how "deep" we want to go with the prefix. Let's imagine we have 256M files and we'd like to push a single file. We... | diff --git a/dvc/remote/base.py b/dvc/remote/base.py
index fc161d015..77975cebb 100644
--- a/dvc/remote/base.py
+++ b/dvc/remote/base.py
@@ -845,30 +845,12 @@ class RemoteBASE(object):
if len(checksums) == 1 or not self.CAN_TRAVERSE:
return self._cache_object_exists(checksums, jobs, name)
- ... |
iterative__dvc-3559 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/data_sync.py:add_parser"
],
"edited_modules": [
"dvc/command/data_sync.py:add_parser"
]
},
"file": "dvc/command/data_sync.py"
},
{
"changes": {
... | iterative/dvc | 55644f376b53dc7d537e1abe219868f15d6c6268 | remote: use progress bar for remote cache query status during `dvc gc`
As noted in #3532
> both local and ssh have their own overridden cache_exists() implementation and neither one uses list_cache_paths() at all during cache_exists(). The only time list_cache_paths() would get called for either local or ssh remotes ... | diff --git a/dvc/command/data_sync.py b/dvc/command/data_sync.py
index a7decd18b..e44e8ea7a 100644
--- a/dvc/command/data_sync.py
+++ b/dvc/command/data_sync.py
@@ -190,13 +190,15 @@ def add_parser(subparsers, _parent_parser):
"--recursive",
action="store_true",
default=False,
- help="... |
iterative__dvc-3576 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/metrics.py:_show_diff"
],
"edited_modules": [
"dvc/command/metrics.py:_show_diff"
]
},
"file": "dvc/command/metrics.py"
}
] | iterative/dvc | a338fad036bd9ac8bdd79ecec964f8c5558609c4 | metrics diff with missing old value
If metrics file(s) has only no old version (it was just created):
```
$ dvc metrics diff HEAD^
WARNING: Metrics file 'metrics/eval.json' does not exist at the reference 'HEAD^'.
WARNING: Metrics file 'metrics/train.json' does not exist at the reference 'HEAD^'.
ERROR: unexpected... | diff --git a/dvc/command/metrics.py b/dvc/command/metrics.py
index 04c2f80ee..5222108b3 100644
--- a/dvc/command/metrics.py
+++ b/dvc/command/metrics.py
@@ -109,7 +109,7 @@ def _show_diff(diff):
from texttable import Texttable
if not diff:
- return "No changes."
+ return ""
table = Text... |
iterative__dvc-3620 | [
{
"changes": {
"added_entities": [
"dvc/utils/fs.py:_unlink"
],
"added_modules": [
"dvc/utils/fs.py:_unlink"
],
"edited_entities": [
"dvc/utils/fs.py:remove"
],
"edited_modules": [
"dvc/utils/fs.py:remove"
]
},
"file": "dvc/... | iterative/dvc | e05157f8e05e856d2e9966c30a3150c26b32b86f | RemoteLOCAL.unprotect modifies cache permissions for symlinked files
**Please provide information about your setup**
dvc --version 0.91.1
The RemoteLOCAL.unprotect function for an output tries to replace the symlink with a copy of the data. First the cache file is copied to a tmp dir, then the link is removed, then... | diff --git a/dvc/utils/fs.py b/dvc/utils/fs.py
index 8bbc097c0..f3bd706c6 100644
--- a/dvc/utils/fs.py
+++ b/dvc/utils/fs.py
@@ -1,3 +1,4 @@
+import sys
import errno
import logging
import os
@@ -129,6 +130,13 @@ def _chmod(func, p, excinfo):
func(p)
+def _unlink(path, onerror):
+ try:
+ os.unlink(... |
iterative__dvc-3665 | [
{
"changes": {
"added_entities": [
"dvc/config.py:Config._to_relpath"
],
"added_modules": null,
"edited_entities": [
"dvc/config.py:Config._save_paths"
],
"edited_modules": [
"dvc/config.py:Config"
]
},
"file": "dvc/config.py"
}
] | iterative/dvc | a2de48bdfbba80a7e41e96a44c67d51ff36f0810 | Config: Cache dir is inconsistant on Unix and Windows
dvc version = 0.93.0
Platform = Ubuntu and Windows 10
On Windows, calling `dvc cache dir ..\xyz` results in an entry in `.dvc/config` like
[cache]
dir = ..\..\xyz
On Linux it results in
[cache]
dir = ../../xyz
This inconsis... | diff --git a/dvc/config.py b/dvc/config.py
index 1fc63acbb..224e1ac28 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -1,16 +1,27 @@
"""DVC config objects."""
-from contextlib import contextmanager
import logging
import os
import re
+from contextlib import contextmanager
+from functools import partial
from urlli... |
iterative__dvc-3677 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/scm/git/__init__.py:Git.is_tracked"
],
"edited_modules": [
"dvc/scm/git/__init__.py:Git"
]
},
"file": "dvc/scm/git/__init__.py"
}
] | iterative/dvc | ae9bc914d64db5fa87c750a7b56816b5a693e37e | dvc add produces /tmp in .dvc/.gitignore
dvc version 0.91.1
installed via pip on ubuntu 18.04
Each dvc add produces extra line '/tmp' in .dvc/.gitignore.
```
% git diff .dvc/.gitignore
diff --git a/.dvc/.gitignore b/.dvc/.gitignore
index 9bd2370..cfd5c3c 100644
--- a/.dvc/.gitignore
+++ b/.dvc/.gitignor... | diff --git a/dvc/scm/git/__init__.py b/dvc/scm/git/__init__.py
index 6b5a3e227..bc230d8dd 100644
--- a/dvc/scm/git/__init__.py
+++ b/dvc/scm/git/__init__.py
@@ -271,11 +271,7 @@ class Git(Base):
return [os.path.join(self.repo.working_dir, fname) for fname in files]
def is_tracked(self, path):
- #... |
iterative__dvc-3689 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/repo/reproduce.py:_reproduce_stages"
],
"edited_modules": [
"dvc/repo/reproduce.py:_reproduce_stages"
]
},
"file": "dvc/repo/reproduce.py"
}
] | iterative/dvc | 6d8499ea6d2affa035e0f577366e6cd4c30075ab | repro: downstream: reproducing in wrong order
DVC version : 0.92.0 (PyPI) + MacOS
It seems `dvc repro --downstream` (could also be the `-f` option) sometimes executes DAGs in the wrong order.
Steps to reproduction:
```sh
dvc run -o 1 -o 2 -f step1.dvc 'touch 1 | touch 2'
dvc run -d 1 -o 3 -f step2.dvc 'touch ... | diff --git a/dvc/repo/reproduce.py b/dvc/repo/reproduce.py
index e77934e89..288bdd39a 100644
--- a/dvc/repo/reproduce.py
+++ b/dvc/repo/reproduce.py
@@ -126,7 +126,8 @@ def _reproduce_stages(
is to derive the evaluation starting from the given stage up to the
ancestors. However, the `networkx.ancestors` retur... |
iterative__dvc-3709 | [
{
"changes": {
"added_entities": [
"dvc/stage/__init__.py:Stage._save_deps"
],
"added_modules": null,
"edited_entities": [
"dvc/stage/__init__.py:Stage.is_cached",
"dvc/stage/__init__.py:Stage.save",
"dvc/stage/__init__.py:Stage._check_missing_deps",
... | iterative/dvc | d998c0a53656f0ca4e4ad549a60a65e7c698d893 | run: params are not checked before running the command
```
$ dvc run -n train1 -d users.csv -p tr_conf.yaml:epochs1,log_file,dropout -M e1/summary.json -m e1/logs.csv -o e1/logs python train.py
.... training is happening
.... 27 hours latter:
60000/60000 [==============================] - 6s 94us/sample - loss: 0.0... | diff --git a/dvc/stage/__init__.py b/dvc/stage/__init__.py
index 6c78c65de..e1c629abd 100644
--- a/dvc/stage/__init__.py
+++ b/dvc/stage/__init__.py
@@ -21,7 +21,6 @@ from .exceptions import (
StagePathNotDirectoryError,
StageCommitError,
StageUpdateError,
- MissingDep,
MissingDataSource,
)
fro... |
iterative__dvc-3711 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/serialize.py:_get_outs",
"dvc/serialize.py:_serialize_params",
"dvc/serialize.py:to_pipeline_file",
"dvc/serialize.py:to_lockfile"
],
"edited_modules": [
... | iterative/dvc | f9088e1c6760b3d11bcb94589b6dca0c15313e75 | lockfile: order of content changes on a repro
Eg: if we change order of `outs` in the pipeline file, and run `repro`, it's smart to detect that nothing was changed. But, if the outs or deps has really changed in the workspace and the stage is run, it will generate the lockfile which generates the content in the order o... | diff --git a/dvc/serialize.py b/dvc/serialize.py
index 976a8fa77..ec004e586 100644
--- a/dvc/serialize.py
+++ b/dvc/serialize.py
@@ -1,3 +1,6 @@
+from collections import OrderedDict
+from functools import partial
+from operator import attrgetter
from typing import TYPE_CHECKING
from funcy import rpartial, lsplit
@@... |
iterative__dvc-3725 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/base.py:CmdBase.__init__"
],
"edited_modules": [
"dvc/command/base.py:CmdBase"
]
},
"file": "dvc/command/base.py"
},
{
"changes": {
"added_ent... | iterative/dvc | 3e1eb6d1e73579815f5d63e7c72fb6624ffb6133 | move temporary files from .dvc to .dvc/tmp
As requested by @dmpetrov in https://github.com/iterative/dvc/issues/3366 , having state db like that in the open might be badly perceived by the users lurking around their repo. We've seen people think badly about dvc because they think we use sqlite db as a core subsystem. L... | diff --git a/dvc/command/base.py b/dvc/command/base.py
index 30f8700c7..21838a922 100644
--- a/dvc/command/base.py
+++ b/dvc/command/base.py
@@ -36,7 +36,7 @@ class CmdBase(object):
self.config = self.repo.config
self.args = args
hardlink_lock = self.config["core"].get("hardlink_lock", False)... |
iterative__dvc-3726 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/data_sync.py:add_parser"
],
"edited_modules": [
"dvc/command/data_sync.py:add_parser"
]
},
"file": "dvc/command/data_sync.py"
},
{
"changes": {
... | iterative/dvc | 4e9b38970a56e0f994ca6f6b44f1b1f550163e73 | status: add --recursive flag
For some reason `dvc status` doesn't have `-R` flag in v 0.93. | diff --git a/dvc/command/data_sync.py b/dvc/command/data_sync.py
index 3091fc915..1c4dac243 100644
--- a/dvc/command/data_sync.py
+++ b/dvc/command/data_sync.py
@@ -334,4 +334,12 @@ def add_parser(subparsers, _parent_parser):
default=False,
help="Show status for all dependencies of the specified targe... |
iterative__dvc-3727 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/diff.py:CmdDiff.run"
],
"edited_modules": [
"dvc/command/diff.py:CmdDiff"
]
},
"file": "dvc/command/diff.py"
},
{
"changes": {
"added_entities... | iterative/dvc | 415a85c6bebf658e3cc6b35ec250897ba94869ea | dvc metrics diff vs dvc diff output consistency
```
dvc diff --show-json HEAD HEAD
```
ouputs nothing
```
dvc metrics diff --show-json HEAD HEAD
```
ouputs {}
without json output :
nothing VS 'No changes.'
**Please provide information about your setup**
dvc 0.87.0
Python 3.6.9
ubuntu 10.04
| diff --git a/dvc/command/diff.py b/dvc/command/diff.py
index c754c1c58..53f439839 100644
--- a/dvc/command/diff.py
+++ b/dvc/command/diff.py
@@ -97,20 +97,15 @@ class CmdDiff(CmdBase):
try:
diff = self.repo.diff(self.args.a_rev, self.args.b_rev)
- if not any(diff.values()):
- ... |
iterative__dvc-3729 | [
{
"changes": {
"added_entities": [
"dvc/output/base.py:BaseOutput.ignore"
],
"added_modules": null,
"edited_entities": [
"dvc/output/base.py:BaseOutput.save"
],
"edited_modules": [
"dvc/output/base.py:BaseOutput"
]
},
"file": "dvc/output/... | iterative/dvc | 505b88afae783374a45f22258b58d560ed2146f9 | dvc run does not include folder in .gitignore
I have a project that has been working properly. It's fundamentally based on pipeline.
Before when I created the pipeline the models folder was added to .gitignore, however now I can't make it ignore the models folder. Here is the pipeline:
```
dvc add data
dvc run ... | diff --git a/dvc/output/base.py b/dvc/output/base.py
index 8b57517f8..442c33c3d 100644
--- a/dvc/output/base.py
+++ b/dvc/output/base.py
@@ -209,6 +209,15 @@ class BaseOutput(object):
def isfile(self):
return self.remote.isfile(self.path_info)
+ def ignore(self):
+ if not self.use_scm_ignore:
... |
iterative__dvc-3748 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "dvc/config.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/remote/s3.py:S3Rem... | iterative/dvc | 2c026066db5292e4c0421716473b7dc58ce48741 | tests: erepo upstream should not be its cache
Setting default remote as [repository cache](https://github.com/iterative/dvc/blob/f9d4ef8abd5427b0ec75f7f3c1211abd8528aa99/tests/conftest.py#L152) inside `erepo` is kinda hacky. This is not a real use case, and some test relay on the `erepo` property (that is automatically... | diff --git a/dvc/config.py b/dvc/config.py
index dde2cb081..1d96d7555 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -151,6 +151,7 @@ SCHEMA = {
Optional("listobjects", default=False): Bool,
Optional("use_ssl", default=True): Bool,
"sse": str,
+ ... |
iterative__dvc-3768 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/update.py:CmdUpdate.run",
"dvc/command/update.py:add_parser"
],
"edited_modules": [
"dvc/command/update.py:CmdUpdate",
"dvc/command/update.py:add_parser"
... | iterative/dvc | 2a16b021ad6f0162d37d392cac16fb655e217f6d | repro: use build cache for deterministic stages
In my experiment I run a few different preprocessing steps which create a different CSV file, then I am modeling this data and also checking different parameters.
When I want to run the same experiment on 4 different machines (`dvc` is connected to the same remote cache)... | diff --git a/dvc/command/update.py b/dvc/command/update.py
index c3ef60ec9..718f08cda 100644
--- a/dvc/command/update.py
+++ b/dvc/command/update.py
@@ -10,12 +10,15 @@ logger = logging.getLogger(__name__)
class CmdUpdate(CmdBase):
def run(self):
ret = 0
- for target in self.args.targets:
- ... |
iterative__dvc-3770 | [
{
"changes": {
"added_entities": [
"dvc/command/pipeline.py:CmdPipelineShow._build_output_graph"
],
"added_modules": null,
"edited_entities": [
"dvc/command/pipeline.py:CmdPipelineShow._build_graph"
],
"edited_modules": [
"dvc/command/pipeline.py:CmdPi... | iterative/dvc | d62a54c7b0fb8bf0f081240d9f578db68b99b3ff | pipeline: show: --outs: DAG has improper edges
- DVC version : 0.92, MacOS, installed via pip.
- Related issue : https://github.com/iterative/dvc/issues/1744 : Seems like the exact same problem but status says closed / merged.
Issue :
In the DAG for `--outs` , all outputs from a connected stage are linked to the ... | diff --git a/dvc/command/pipeline.py b/dvc/command/pipeline.py
index 7049066de..f18e17781 100644
--- a/dvc/command/pipeline.py
+++ b/dvc/command/pipeline.py
@@ -31,6 +31,31 @@ class CmdPipelineShow(CmdBase):
else:
logger.info(stage.addressing)
+ @staticmethod
+ def _build_output_gr... |
iterative__dvc-3779 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/repo/checkout.py:_checkout"
],
"edited_modules": [
"dvc/repo/checkout.py:_checkout"
]
},
"file": "dvc/repo/checkout.py"
},
{
"changes": {
"added_entit... | iterative/dvc | 666e203bbba3a36e2b6c2a6a4015718c36e77374 | refactor: Repo methods with "targets" param should check for str type
Repo contains several methods with `targets` param: `add`, `update`, `status`, `_fetch`, etc. Some of them, like `add` and `update`, check if `targets` param is str:
```
if isinstance(targets, str):
targets = [targets]
```
Probably other... | diff --git a/dvc/repo/checkout.py b/dvc/repo/checkout.py
index ea5f7cdb8..eae723a1b 100644
--- a/dvc/repo/checkout.py
+++ b/dvc/repo/checkout.py
@@ -60,6 +60,9 @@ def _checkout(
stats["deleted"] = [_fspath_dir(u, self.root_dir) for u in unused]
self.state.remove_links(unused)
+ if isinstance(targets, str... |
iterative__dvc-3781 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/repo/imp_url.py:imp_url"
],
"edited_modules": [
"dvc/repo/imp_url.py:imp_url"
]
},
"file": "dvc/repo/imp_url.py"
}
] | iterative/dvc | 666e203bbba3a36e2b6c2a6a4015718c36e77374 | `dvc import -o` fails when source is location within same project
env: dvc v0.94, pip, Ubuntu
When I run the following dvc command:
dvc import -o my/target/loc/ . some/long/path/to/dir
I get this error message:
```
ERROR: failed to import 'some/long/path/to/dir' from '.'. - The path '../../../some/lo... | diff --git a/dvc/repo/imp_url.py b/dvc/repo/imp_url.py
index 73420eb62..5320ea354 100644
--- a/dvc/repo/imp_url.py
+++ b/dvc/repo/imp_url.py
@@ -17,8 +17,12 @@ def imp_url(self, url, out=None, fname=None, erepo=None, locked=True):
out = resolve_output(url, out)
path, wdir, out = resolve_paths(self, out)
- ... |
iterative__dvc-3830 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/plots.py:add_parser"
],
"edited_modules": [
"dvc/command/plots.py:add_parser"
]
},
"file": "dvc/command/plots.py"
},
{
"changes": {
"added_ent... | iterative/dvc | 130b76c7a5d38289d070b77592a326ec223b0ad5 | Plot: link to docs
Link to docs as per @jorgeorpinel review under https://github.com/iterative/dvc/pull/3577, after plot documentation is merged from https://github.com/iterative/dvc.org/pull/1186. | diff --git a/dvc/command/plots.py b/dvc/command/plots.py
index c5aa6e424..babacec8a 100644
--- a/dvc/command/plots.py
+++ b/dvc/command/plots.py
@@ -4,6 +4,7 @@ import os
from dvc.command.base import CmdBase, append_doc_link, fix_subparsers
from dvc.exceptions import DvcException
+from dvc.utils import format_link
... |
iterative__dvc-3836 | [
{
"changes": {
"added_entities": [
"dvc/command/remote.py:CmdRemoteRename._rename_default",
"dvc/command/remote.py:CmdRemoteRename.run"
],
"added_modules": [
"dvc/command/remote.py:CmdRemoteRename"
],
"edited_entities": [
"dvc/command/remote.py:add_p... | iterative/dvc | b52c925d5f5c9648fcf2cb6c3354ed47742001cc | dvc diff ERROR: unexpected error - 'NoneType' object has no attribute 'endswith'
If given rev is not tracked fails. I.E 2f05868ebe3693a7e7afbdd8923c15ce327b179d does not have metrics:
```
dvc diff --show-json 2f05868ebe3693a7e7afbdd8923c15ce327b179d 19b33235917f6b3732de8486b35235ba200e74a2
ERROR: unexpected error ... | diff --git a/dvc/command/remote.py b/dvc/command/remote.py
index 74fa2b677..5a0506c34 100644
--- a/dvc/command/remote.py
+++ b/dvc/command/remote.py
@@ -104,6 +104,35 @@ class CmdRemoteList(CmdRemote):
return 0
+class CmdRemoteRename(CmdRemote):
+ def _rename_default(self, conf):
+ if conf["core"... |
iterative__dvc-3841 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/dependency/repo.py:RepoDependency._get_checksum",
"dvc/dependency/repo.py:RepoDependency.download",
"dvc/dependency/repo.py:RepoDependency.update"
],
"edited_modules": [
... | iterative/dvc | 865d355554b27be5ea49640c14556c46f7906327 | external_repo doesn't respect parent cache and progress bar
Somewhere during the external_repo refactor we've lost the logic that was using parent's cache dir to store cache. Currently, we are using tempdir (yes, in /tmp) to pull data too, which is really bad, as it might not have enough space available. Plus, we don'... | diff --git a/dvc/dependency/repo.py b/dvc/dependency/repo.py
index c53d0d55b..f76344f11 100644
--- a/dvc/dependency/repo.py
+++ b/dvc/dependency/repo.py
@@ -50,13 +50,24 @@ class RepoDependency(LocalDependency):
return external_repo(d["url"], rev=rev)
def _get_checksum(self, locked=True):
+ from ... |
iterative__dvc-3843 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/output/base.py:OutputAlreadyTrackedError.__init__"
],
"edited_modules": [
"dvc/output/base.py:OutputAlreadyTrackedError"
]
},
"file": "dvc/output/base.py"
},
{
... | iterative/dvc | 130b76c7a5d38289d070b77592a326ec223b0ad5 | run-cache: fails for params
```sh
$ echo "train: 1\nlr: 2" > params.yaml
$ dvc run -n test -p train,lr -o params2.yaml "cat params.yaml > params2.yaml"
ERROR: failed to reproduce 'dvc.yaml': 'deps'
```
Verbose log:
```sh
------------------------------------------------------------
Traceback (most recent call l... | diff --git a/dvc/output/base.py b/dvc/output/base.py
index fef7e592c..edaf3bdce 100644
--- a/dvc/output/base.py
+++ b/dvc/output/base.py
@@ -32,8 +32,8 @@ class OutputIsNotFileOrDirError(DvcException):
class OutputAlreadyTrackedError(DvcException):
def __init__(self, path):
msg = f""" output '{path}' is ... |
iterative__dvc-3873 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/stage/cache.py:StageCache._create_stage",
"dvc/stage/cache.py:StageCache._uncached_outs"
],
"edited_modules": [
"dvc/stage/cache.py:StageCache"
]
},
"file":... | iterative/dvc | d53b740f353baa98cd3ed80a3586b7e10dc94c1e | cache: fails for stage with wdir having non-cached outputs
```sh
$ mkdir data
$ echo "hello world > data/foo
$ dvc run -n copy-foo-bar -d foo --wdir data -O bar "cp foo bar"
ERROR: unexpected error - [Errno 2] No such file or directory: '/home/saugat/dvc_try/test_multistage/bar
```
Also, fails when tried to run... | diff --git a/dvc/stage/cache.py b/dvc/stage/cache.py
index 63c326fab..f126d2060 100644
--- a/dvc/stage/cache.py
+++ b/dvc/stage/cache.py
@@ -77,7 +77,7 @@ class StageCache:
return None
- def _create_stage(self, cache):
+ def _create_stage(self, cache, wdir=None):
from dvc.stage import create... |
iterative__dvc-3876 | [
{
"changes": {
"added_entities": [
"dvc/ignore.py:CleanTree._valid_dirname",
"dvc/ignore.py:CleanTree._valid_filename",
"dvc/ignore.py:CleanTree._parents_exist"
],
"added_modules": null,
"edited_entities": [
"dvc/ignore.py:CleanTree.open",
"dvc/ign... | iterative/dvc | 2fecc66cb96442a8bf5d296e71a72766341d6e35 | forbid using subrepo as a target
**Please provide information about your setup**
DVC version(i.e. `dvc --version`), Platform and method of installation (pip, homebrew, pkg Mac, exe (Windows), DEB(Linux), RPM(Linux))
After introducing support for multiple DVC roots in #3257, in case of following setup:
```
.
├── ... | diff --git a/dvc/ignore.py b/dvc/ignore.py
index eefa3bfef..384ba38bd 100644
--- a/dvc/ignore.py
+++ b/dvc/ignore.py
@@ -5,7 +5,9 @@ from funcy import cached_property
from pathspec import PathSpec
from pathspec.patterns import GitWildMatchPattern
+from dvc.path_info import PathInfo
from dvc.scm.tree import BaseTre... |
iterative__dvc-3895 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/plots.py:CmdPlots.run",
"dvc/command/plots.py:add_parser"
],
"edited_modules": [
"dvc/command/plots.py:CmdPlots",
"dvc/command/plots.py:add_parser"
... | iterative/dvc | 8d9435e8ee99b9899cd8d3277ea8cae8cc281154 | brancher: dvcignore does not work as expected for subrepos when using brancher
As noted by @efiop in #3883, in CleanTree when we do
```py
@cached_property
def dvcignore(self):
return DvcIgnoreFilter(self.tree)
```
`DvcIgnoreFilter` will use `WorkingTree.tree_root` or `GitTree.tree_root` as the roo... | diff --git a/dvc/command/plots.py b/dvc/command/plots.py
index b7900a697..ef50de6e7 100644
--- a/dvc/command/plots.py
+++ b/dvc/command/plots.py
@@ -33,6 +33,16 @@ class CmdPlots(CmdBase):
raise NotImplementedError
def run(self):
+ if self.args.show_vega:
+ if not self.args.targets:
+ ... |
iterative__dvc-3940 | [
{
"changes": {
"added_entities": [
"dvc/exceptions.py:NoPlotsError.__init__"
],
"added_modules": [
"dvc/exceptions.py:NoPlotsError"
],
"edited_entities": null,
"edited_modules": null
},
"file": "dvc/exceptions.py"
},
{
"changes": {
"added... | iterative/dvc | ac4f351daf18b3e1ea89a9d6602acf8770a00d6c | plots show: targets are required but help output indicates otherwise [qa]
## Bug Report
Help output indicates `targets` are optional, but an error is thrown if not provided:
```console
λ dvc plots show -h
usage: dvc plots show [-h] [-q | -v] [-t [TEMPLATE]] [-o OUT] [-x X] [-y Y] [--no-csv-header] [--show-json]... | diff --git a/dvc/exceptions.py b/dvc/exceptions.py
index 6ec42da90..32545c5f7 100644
--- a/dvc/exceptions.py
+++ b/dvc/exceptions.py
@@ -178,6 +178,14 @@ class NoMetricsError(DvcException):
)
+class NoPlotsError(DvcException):
+ def __init__(self):
+ super().__init__(
+ "no plots in th... |
iterative__dvc-3992 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/plots.py:add_parser",
"dvc/command/plots.py:_add_props_arguments"
],
"edited_modules": [
"dvc/command/plots.py:add_parser",
"dvc/command/plots.py:_add_pro... | iterative/dvc | c1e5b10cbd8d751c7036e26fe62f58edece0e507 | plots: support yaml
DVC supports JSON and YAML for metrics, but not for plots.
Details: https://github.com/iterative/dvc.org/pull/1382#discussion_r434967192
---
UPDATE by Jorge:
- [ ] Let's remember to update docs when this is figured out 🙂 Either in iterative/dvc.org/pull/1382 or in it's own PR on top of th... | diff --git a/dvc/command/plots.py b/dvc/command/plots.py
index e4d007f60..f495a55b5 100644
--- a/dvc/command/plots.py
+++ b/dvc/command/plots.py
@@ -156,7 +156,7 @@ def add_parser(subparsers, parent_parser):
_add_output_arguments(plots_diff_parser)
plots_diff_parser.set_defaults(func=CmdPlotsDiff)
- PLOT... |
iterative__dvc-3998 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/data_sync.py:add_parser"
],
"edited_modules": [
"dvc/command/data_sync.py:add_parser"
]
},
"file": "dvc/command/data_sync.py"
},
{
"changes": {
... | iterative/dvc | 5efc3bbee2aeaf9f1e624c583228bc034333fa25 | Machine readable format of DVC status
Hi guys, can we have machine readable output format option for `dvc status`, for example:
```
dvc status --json
{
"stages": [
{
"name": "path/to/a.txt.dvc",
"deps_changed": ["path/to/b.txt.dvc"],
"outs_changed": [],
... | diff --git a/dvc/command/data_sync.py b/dvc/command/data_sync.py
index baee9343a..bf384befa 100644
--- a/dvc/command/data_sync.py
+++ b/dvc/command/data_sync.py
@@ -363,5 +363,11 @@ def add_parser(subparsers, _parent_parser):
default=False,
help="Show status of all stages in the specified directory.",... |
iterative__dvc-4001 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/plots.py:_add_props_arguments"
],
"edited_modules": [
"dvc/command/plots.py:_add_props_arguments"
]
},
"file": "dvc/command/plots.py"
},
{
"changes"... | iterative/dvc | f259bc52cdb907226d64f25108dd1e90e783e2f0 | plots modify: change --no-csv-header to --no-header?
> Extracted from https://github.com/iterative/dvc.org/pull/1382#pullrequestreview-425769472
> should it be just --no-header? - @shcheklein
> or --no-table-header since TSV is also supported. This way it remains obvious that it only applies to tabular metric fil... | diff --git a/dvc/command/plots.py b/dvc/command/plots.py
index f495a55b5..00d190269 100644
--- a/dvc/command/plots.py
+++ b/dvc/command/plots.py
@@ -193,11 +193,11 @@ def _add_props_arguments(parser):
parser.add_argument("-x", default=None, help="Field name for x axis.")
parser.add_argument("-y", default=None... |
iterative__dvc-4005 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/repo/tree.py:DvcTree.open",
"dvc/repo/tree.py:RepoTree.open"
],
"edited_modules": [
"dvc/repo/tree.py:DvcTree",
"dvc/repo/tree.py:RepoTree"
]
},
"fi... | iterative/dvc | 4042d5232dc8aa5238f800e917e9b062719d8ec9 | make sure metrics/plots can compare dirty repo with the last commit by default
> Which versions get compared by default? without sending arguments
> I expected the present metrics file to be plotted on top of the last commit but if I manually change this metrics file, the changes are not reflected in the plot.
> On... | diff --git a/dvc/repo/tree.py b/dvc/repo/tree.py
index 361e702ac..b1fb1192c 100644
--- a/dvc/repo/tree.py
+++ b/dvc/repo/tree.py
@@ -61,6 +61,10 @@ class DvcTree(BaseTree):
except OutputNotFoundError as exc:
raise FileNotFoundError from exc
+ # NOTE: this handles both dirty and checkout-e... |
iterative__dvc-4008 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/dvcfile.py:PipelineFile._dump_pipeline_file"
],
"edited_modules": [
"dvc/dvcfile.py:PipelineFile"
]
},
"file": "dvc/dvcfile.py"
},
{
"changes": {
"add... | iterative/dvc | 91a7194e4f7ffea1fca8e684bb70de4cfb36a21b | `plots modify` is not preserving `meta`
I think, I implemented this. But, somehow it's not working. Also need to take a look if comments are preserved. | diff --git a/dvc/dvcfile.py b/dvc/dvcfile.py
index df8a61b7c..023d69517 100644
--- a/dvc/dvcfile.py
+++ b/dvc/dvcfile.py
@@ -208,6 +208,8 @@ class PipelineFile(FileMixin):
if existing_entry:
orig_stage_data = data["stages"][stage.name]
+ if "meta" in orig_stage_data:
+ ... |
iterative__dvc-4018 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/repo/fetch.py:_fetch"
],
"edited_modules": [
"dvc/repo/fetch.py:_fetch"
]
},
"file": "dvc/repo/fetch.py"
},
{
"changes": {
"added_entities": null,
... | iterative/dvc | 87276faef2574dc4119f5fa6a079a81ea9f197f0 | run cache: push/pull is broken
## Bug Report
### Please provide information about your setup
#### Setup:
```console
cd $(mktemp -d)
mkdir {remote,repo}
cd repo
dvc init --no-scm
echo "foo" > foo
dvc run -n copy-foo-bar -d foo -o bar "cp foo bar"
dvc remote add -d remote ../remote
```
Output:
```conso... | diff --git a/dvc/repo/fetch.py b/dvc/repo/fetch.py
index dcab08ec4..fe3cd9c6f 100644
--- a/dvc/repo/fetch.py
+++ b/dvc/repo/fetch.py
@@ -72,7 +72,7 @@ def _fetch(
if failed:
raise DownloadError(failed)
- return downloaded
+ return downloaded + len(used_run_cache)
def _fetch_external(self, rep... |
iterative__dvc-4026 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/metrics.py:_show_diff",
"dvc/command/metrics.py:CmdMetricsDiff.run",
"dvc/command/metrics.py:add_parser"
],
"edited_modules": [
"dvc/command/metrics.py:_s... | iterative/dvc | 45dcb7c27d2778e4c3da9b8d6e50f56ba738b2ea | metrics diff precision
Currently, DVC just uses regular float rounding without any adjustments. Sometimes it does not look good:
```
$ dvc metrics diff
Path Metric Value Change
summary.json train.accuracy 0.9886999726295471 0.00001300000009
summary.json train.loss 0.041... | diff --git a/dvc/command/metrics.py b/dvc/command/metrics.py
index a6c38c030..c2db5dd28 100644
--- a/dvc/command/metrics.py
+++ b/dvc/command/metrics.py
@@ -7,6 +7,9 @@ from dvc.exceptions import BadMetricError, DvcException
logger = logging.getLogger(__name__)
+DEFAULT_PRECISION = 5
+
+
def show_metrics(
me... |
iterative__dvc-4059 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/ignore.py:CleanTree.walk"
],
"edited_modules": [
"dvc/ignore.py:CleanTree"
]
},
"file": "dvc/ignore.py"
},
{
"changes": {
"added_entities": null,
... | iterative/dvc | 5d957b18301efd4f51e594bc9e9d86d1bd951d33 | GitTree.walk() raises an error on a non-existing dir
This is inconsistent with `os.walk()`. | diff --git a/dvc/ignore.py b/dvc/ignore.py
index aa099fdec..2ec841349 100644
--- a/dvc/ignore.py
+++ b/dvc/ignore.py
@@ -229,8 +229,10 @@ class CleanTree(BaseTree):
return False
return True
- def walk(self, top, topdown=True):
- for root, dirs, files in self.tree.walk(top, topdown)... |
iterative__dvc-4066 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/ignore.py:DvcIgnorePatterns.__init__"
],
"edited_modules": [
"dvc/ignore.py:DvcIgnorePatterns"
]
},
"file": "dvc/ignore.py"
}
] | iterative/dvc | 51a8c782aeac0b758adef9a161ae97b17503cb01 | .dvcignore - new lines throw error, expected str instance, NoneType found.
```
DVC version: 1.0.0b2
Python version: 3.7.6
Platform: Ubuntu 18.04.4 LTS
Package: dvc_1.0.0b2_amd64.deb
Filesystem: ceph-fuse
```
- **Issue:** After installing DVC v1.0.0b2, all DVC commands fail with the following error:
` ERROR: une... | diff --git a/dvc/ignore.py b/dvc/ignore.py
index 2ec841349..d11c43053 100644
--- a/dvc/ignore.py
+++ b/dvc/ignore.py
@@ -39,6 +39,7 @@ class DvcIgnorePatterns(DvcIgnore):
for ignore, group in groupby(
regex_pattern_list, lambda x: x[1]
)
+ if ignore ... |
iterative__dvc-4075 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/imp_url.py:CmdImportUrl.run",
"dvc/command/imp_url.py:add_parser"
],
"edited_modules": [
"dvc/command/imp_url.py:CmdImportUrl",
"dvc/command/imp_url.py:ad... | iterative/dvc | a2f1367a9a75849ef6ad7ee23a5bacc18580f102 | Implement `--no-exec` option for `import-url` command
`dvc import-url` creates new `.dvc` file, just as `dvc run`. Sometimes files which would be imported are already present locally and it's quite inconvenient that they should be downloaded again in order to create a pipeline step.
Because of that it would be great... | diff --git a/dvc/command/imp_url.py b/dvc/command/imp_url.py
index 18591891b..aaed48a34 100644
--- a/dvc/command/imp_url.py
+++ b/dvc/command/imp_url.py
@@ -12,7 +12,10 @@ class CmdImportUrl(CmdBase):
def run(self):
try:
self.repo.imp_url(
- self.args.url, out=self.args.out, fn... |
iterative__dvc-4086 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/run.py:add_parser"
],
"edited_modules": [
"dvc/command/run.py:add_parser"
]
},
"file": "dvc/command/run.py"
},
{
"changes": {
"added_entities"... | iterative/dvc | 5cb775308df6de07ac70cc25894f271f552e740a | run: hide --file and --single-stage
## Report
Per https://github.com/iterative/dvc.org/pull/1420#discussion_r442644095:
--file is still in the help output of `dvc run -h`, mentions DVC-file (a concept we are removing), and makes no sense without --single-stage (which is hidden). Please hide both for now.
### P... | diff --git a/dvc/command/run.py b/dvc/command/run.py
index 1a3ac6d6d..e011d625b 100644
--- a/dvc/command/run.py
+++ b/dvc/command/run.py
@@ -159,9 +159,7 @@ def add_parser(subparsers, parent_parser):
metavar="<path>",
)
run_parser.add_argument(
- "--file",
- help="Specify name of the DV... |
iterative__dvc-4108 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/repo/ls.py:_ls"
],
"edited_modules": [
"dvc/repo/ls.py:_ls"
]
},
"file": "dvc/repo/ls.py"
},
{
"changes": {
"added_entities": [
"dvc/repo/tree... | iterative/dvc | 64c1321c9da8206af31c414572d344f85c18cc4c | dvc list doesn't list contents of dvc-tracked folders
## Bug Report
`dvc list` does not ever seem to list folders or subfolders within a dvc file. If there are dvc files tracking single files, then I do see the file in `dvc list`, but if I am tracking an entire folder, I do not get anything. DVC would need to downlo... | diff --git a/dvc/repo/ls.py b/dvc/repo/ls.py
index 9344e8b10..e02d52116 100644
--- a/dvc/repo/ls.py
+++ b/dvc/repo/ls.py
@@ -53,9 +53,9 @@ def _ls(repo, path_info, recursive=None, dvc_only=False):
def onerror(exc):
raise exc
- # use our own RepoTree instance instead of repo.repo_tree since we do not
... |
iterative__dvc-4124 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/utils/diff.py:table"
],
"edited_modules": [
"dvc/utils/diff.py:table"
]
},
"file": "dvc/utils/diff.py"
}
] | iterative/dvc | 35e0dd920614f9f1194c82f61eeaa829f6593fb6 | Newlines after dvc metrics diff
I am working on printing `dvc metrics diff --show-md` into a markdown document, i.e....
`dvc metrics diff --show-md >> doc.md`
and if I don't manually follow this command with a newline:
`echo >> doc.md`
Then everything that follows in `doc.md` gets inserted into the table. Is... | diff --git a/dvc/utils/diff.py b/dvc/utils/diff.py
index b412aafeb..7442564a4 100644
--- a/dvc/utils/diff.py
+++ b/dvc/utils/diff.py
@@ -91,7 +91,7 @@ def table(header, rows, markdown=False):
if not rows and not markdown:
return ""
- return tabulate(
+ ret = tabulate(
rows,
heade... |
iterative__dvc-4125 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/output/local.py:LocalOutput.__init__"
],
"edited_modules": [
"dvc/output/local.py:LocalOutput"
]
},
"file": "dvc/output/local.py"
}
] | iterative/dvc | e4dafb8552d52f8e9d2dd20976de079e891851e4 | PermissionError on file which should be in .dvcignore.
## Bug Report
Getting a permission denied when I try to DVC add a file that is in my dvc ignore.
This is the `.dvcignore` file:
```
*/*/.thumbnail/
*/*/.exports/
```
Last few errors in traceback:
```
File "/home/andrea/projects/myproject/.venv/lib/python3... | diff --git a/dvc/output/local.py b/dvc/output/local.py
index fd2c8b286..8e5ee4b28 100644
--- a/dvc/output/local.py
+++ b/dvc/output/local.py
@@ -5,6 +5,7 @@ from urllib.parse import urlparse
from dvc.exceptions import DvcException
from dvc.istextfile import istextfile
from dvc.output.base import BaseOutput
+from dvc... |
iterative__dvc-4149 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/remote/azure.py:AzureRemoteTree.walk_files"
],
"edited_modules": [
"dvc/remote/azure.py:AzureRemoteTree"
]
},
"file": "dvc/remote/azure.py"
},
{
"changes": ... | iterative/dvc | 07da9f1e5c0be1662dbce7b0667c38c45e2c6b1a | `dvc pull` does not seem to work for files whose md5 starts with `00`
## Bug Report
### Please provide information about your setup
**Output of `dvc version`:**
1.1.1
**Additional Information (if any):**
When I run `dvc pull` on a repo with around 500+ items, all but 4 are retrieved successfully .
I have ... | diff --git a/dvc/remote/azure.py b/dvc/remote/azure.py
index 817fcc6ed..77b831fc1 100644
--- a/dvc/remote/azure.py
+++ b/dvc/remote/azure.py
@@ -121,6 +121,8 @@ class AzureRemoteTree(BaseRemoteTree):
next_marker = blobs.next_marker
def walk_files(self, path_info, **kwargs):
+ if not kwargs.po... |
iterative__dvc-4156 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/dependency/repo.py:RepoDependency._get_checksum"
],
"edited_modules": [
"dvc/dependency/repo.py:RepoDependency"
]
},
"file": "dvc/dependency/repo.py"
},
{
"... | iterative/dvc | fa16b56cbaabad4e91a5e6f056a20aaaebdd4364 | DVC status fails after using add -R
Hey :)
I have a folder of files I added with
$$ dvc add -R raw_data
Then I've imported the folder in other git repo using
$$ dvc import -o data --rev raw-v1 https://...@bitbucket.org/.../raw_data_reg.git raw_data
Then when execute dvc status I get an error message
```
... | diff --git a/dvc/dependency/repo.py b/dvc/dependency/repo.py
index 8566c080b..3ae2a77df 100644
--- a/dvc/dependency/repo.py
+++ b/dvc/dependency/repo.py
@@ -64,7 +64,7 @@ class RepoDependency(LocalDependency):
# We are polluting our repo cache with some dir listing here
if tree.isdir... |
iterative__dvc-4166 | [
{
"changes": {
"added_entities": [
"dvc/cli.py:_find_parser"
],
"added_modules": [
"dvc/cli.py:_find_parser"
],
"edited_entities": [
"dvc/cli.py:DvcParser.error",
"dvc/cli.py:DvcParser.parse_args"
],
"edited_modules": [
"dvc/cli.p... | iterative/dvc | 520e01f11305aba1994df354adef86e6d90180de | .dvcignore is broken on negation when blacklisting all
## Bug Report
### Please provide information about your setup
I am not sure how far this extends to, but a lot of trials for `.dvcignore` failed when I blacklisted all and tried to whitelist some:
```
*
!scripts
```
```
*
!/scripts
```
```
/*
... | diff --git a/dvc/cli.py b/dvc/cli.py
index 70f8e0fdb..44af80d6a 100644
--- a/dvc/cli.py
+++ b/dvc/cli.py
@@ -80,34 +80,36 @@ COMMANDS = [
]
+def _find_parser(parser, cmd_cls):
+ defaults = parser._defaults # pylint: disable=protected-access
+ if not cmd_cls or cmd_cls == defaults.get("func"):
+ parse... |
iterative__dvc-4185 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/dependency/param.py:ParamsDependency.fill_values"
],
"edited_modules": [
"dvc/dependency/param.py:ParamsDependency"
]
},
"file": "dvc/dependency/param.py"
}
] | iterative/dvc | 0899b277c02082ffc24bb732e8a7cf3ef4333948 | dvc status always mark a param as changed
## Bug Report
### Please provide information about your setup
**Output of `dvc version`:**
```console
$ dvc version
DVC version: 1.1.7
Python version: 3.8.3
Platform: Linux-4.19.104-microsoft-standard-x86_64-with-glibc2.10
Binary: False
Package: pip
Supported re... | diff --git a/dvc/dependency/param.py b/dvc/dependency/param.py
index 4df6087f5..12860e347 100644
--- a/dvc/dependency/param.py
+++ b/dvc/dependency/param.py
@@ -45,9 +45,8 @@ class ParamsDependency(LocalDependency):
if not values:
return
for param in self.params:
- value = valu... |
iterative__dvc-4190 | [
{
"changes": {
"added_entities": [
"dvc/config.py:Config._load_config",
"dvc/config.py:Config._save_config"
],
"added_modules": null,
"edited_entities": [
"dvc/config.py:Config.__init__",
"dvc/config.py:Config.load_one",
"dvc/config.py:Config.edit"... | iterative/dvc | 375998c6642c3003aebcf6b25e69360e7cf6f105 | dvc get --rev doesn't work if master is not a dvc repo
## Bug Report
### Please provide information about your setup
**Output of `dvc version`:**
```console
DVC version: 1.1.7
Python version: 3.7.2
Platform: Darwin-18.7.0-x86_64-i386-64bit
Binary: False
Package: pip
Supported remotes: http, https, s3
Ca... | diff --git a/dvc/config.py b/dvc/config.py
index 43bc16516..92cfde7fe 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -232,8 +232,10 @@ class Config(dict):
CONFIG_LOCAL = "config.local"
def __init__(
- self, dvc_dir=None, validate=True
+ self, dvc_dir=None, validate=True, tree=None,
): ... |
iterative__dvc-4196 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/checkout.py:add_parser"
],
"edited_modules": [
"dvc/command/checkout.py:add_parser"
]
},
"file": "dvc/command/checkout.py"
},
{
"changes": {
"... | iterative/dvc | 71c478755399b049101ab9400e7f48dda2a47597 | remove: remove dvc.yaml and dvc.lock if they are empty
https://github.com/iterative/dvc/pull/4074#issuecomment-648097445
```
$ cat dvc.lock
{}
$ cat dvc.yaml
stages: {}
``` | diff --git a/dvc/command/checkout.py b/dvc/command/checkout.py
index ecc750e62..3752342e1 100644
--- a/dvc/command/checkout.py
+++ b/dvc/command/checkout.py
@@ -112,7 +112,9 @@ def add_parser(subparsers, parent_parser):
checkout_parser.add_argument(
"targets",
nargs="*",
- help="DVC-files ... |
iterative__dvc-4204 | [
{
"changes": {
"added_entities": [
"dvc/external_repo.py:BaseExternalRepo.__str__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"dvc/external_repo.py:BaseExternalRepo"
]
},
"file": "dvc/external_repo.py"
},
{
"changes"... | iterative/dvc | c1b04b88fac76ed49b9591288f885e38a9cfe48c | list: granularity not working [qa]
## Bug Report
```console
λ dvc list https://github.com/iterative/example-get-started data/
.gitignore
data.xml
data.xml.dvc
features
prepared
λ dvc list https://github.com/iterative/example-get-started data/data.xml.dvc
data.xml.dvc
λ dvc list https://github.com/iterat... | diff --git a/dvc/external_repo.py b/dvc/external_repo.py
index 5f2232147..809d04b9c 100644
--- a/dvc/external_repo.py
+++ b/dvc/external_repo.py
@@ -72,6 +72,9 @@ class BaseExternalRepo:
_local_cache = None
+ def __str__(self):
+ return self.url
+
@property
def local_cache(self):
i... |
iterative__dvc-4209 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/config.py:Config.__init__"
],
"edited_modules": [
"dvc/config.py:Config"
]
},
"file": "dvc/config.py"
},
{
"changes": {
"added_entities": [
"d... | iterative/dvc | 33abc407a1b4ae6aef3e1e83afe39d57a01d8ec7 | `dvc commit` fails with files imported via `dvc import`
## Bug Report
Hello! I am importing some files in my main repo from another repo using the command `dvc import`.
Upon running `dvc commit` afterward, I get the following error (output of `dvc commit -v`):
```
2020-07-14 18:50:54,511 ERROR: unexpected error -... | diff --git a/dvc/config.py b/dvc/config.py
index 3b083597a..00b450eab 100644
--- a/dvc/config.py
+++ b/dvc/config.py
@@ -249,7 +249,7 @@ class Config(dict):
self.dvc_dir = os.path.abspath(os.path.realpath(dvc_dir))
self.wtree = LocalRemoteTree(None, {"url": self.dvc_dir})
- self.tree = tr... |
iterative__dvc-4246 | [
{
"changes": {
"added_entities": [
"dvc/external_repo.py:_unshallow"
],
"added_modules": [
"dvc/external_repo.py:_unshallow"
],
"edited_entities": [
"dvc/external_repo.py:external_repo",
"dvc/external_repo.py:clean_repos",
"dvc/external_repo.... | iterative/dvc | b77ce02f6b7f66efa9fc73b7146f1c4bf4fa6da3 | 'dvc get' is cloning the full bitbucket repo when only one branch is needed
DVC version : 0.82.2
When using `dvc get` to get data from a large bitbucket repository (with full command `dvc get --rev branchname https://.../gitrepo data/data.csv`), this results in cloning the full git repository, even though only th... | diff --git a/dvc/external_repo.py b/dvc/external_repo.py
index 42df57c69..15332e7de 100644
--- a/dvc/external_repo.py
+++ b/dvc/external_repo.py
@@ -19,6 +19,7 @@ from dvc.exceptions import (
from dvc.path_info import PathInfo
from dvc.repo import Repo
from dvc.repo.tree import RepoTree
+from dvc.scm.base import Clo... |
iterative__dvc-4287 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/experiments.py:_show_experiments"
],
"edited_modules": [
"dvc/command/experiments.py:_show_experiments"
]
},
"file": "dvc/command/experiments.py"
},
{
... | iterative/dvc | fe9ae2c5d1ab94e54ef5620fd2cb1ead16e2d082 | gdrive: failed to pull empty file
CC @imflash217 and @we-taper
https://github.com/iterative/dvc/issues/1376#issuecomment-664004339 | diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py
index 3ec817bc7..ab1daa3c7 100644
--- a/dvc/command/experiments.py
+++ b/dvc/command/experiments.py
@@ -82,29 +82,25 @@ def _show_experiments(all_experiments, console, precision=None):
metric_names, param_names = _collect_names(all_experiments)... |
iterative__dvc-4309 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/remote.py:CmdRemoteModify.run"
],
"edited_modules": [
"dvc/command/remote.py:CmdRemoteModify"
]
},
"file": "dvc/command/remote.py"
},
{
"changes": {... | iterative/dvc | fcf2e3522c4775e8bd7b50581a15c1693e30d124 | remote local config does not see existing remote
## Bug Report
### Please provide information about your setup
**Output of `dvc version`:**
```console
DVC version: 1.1.10+1c9588
Python version: 3.8.4
Platform: macOS-10.15.4-x86_64-i386-64bit
Binary: False
Package: None
Supported remotes: azure, gdrive, g... | diff --git a/dvc/command/remote.py b/dvc/command/remote.py
index db622a378..a3484a7be 100644
--- a/dvc/command/remote.py
+++ b/dvc/command/remote.py
@@ -3,7 +3,7 @@ import logging
from dvc.command.base import append_doc_link, fix_subparsers
from dvc.command.config import CmdConfig
-from dvc.config import ConfigErro... |
iterative__dvc-4353 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/cache/local.py:LocalCache._get_plans",
"dvc/cache/local.py:LocalCache._process"
],
"edited_modules": [
"dvc/cache/local.py:LocalCache"
]
},
"file": "dvc/cac... | iterative/dvc | dea1950ba022ee0a1bfdde357f6a8435d827eb5e | dvc push: when not all files are in local cache, still pushes the hash.dir file, breaking remote repository.
EDIT: Solved. The issue was pushing incomplete datasets from my gpu server to the new storage remotes. It pushed all the files present in the local cache (which is what I wanted) but then it pushed the hash.dir ... | diff --git a/dvc/cache/local.py b/dvc/cache/local.py
index 1db76fb23..ec4d1d267 100644
--- a/dvc/cache/local.py
+++ b/dvc/cache/local.py
@@ -255,6 +255,7 @@ class LocalCache(CloudCache):
path_infos = []
names = []
hashes = []
+ missing = []
for md5, info in Tqdm(
... |
iterative__dvc-4354 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/check_ignore.py:CmdCheckIgnore._interactive_mode"
],
"edited_modules": [
"dvc/command/check_ignore.py:CmdCheckIgnore"
]
},
"file": "dvc/command/check_ignore... | iterative/dvc | dea1950ba022ee0a1bfdde357f6a8435d827eb5e | check-ignore: confusing help message when no matches are found [qa]
## Bug Report
```console
λ dvc check-ignore not/ignored/file
Having any troubles? Hit us up at https://dvc.org/support, we are always happy to help!
```
What troubles? 🙂
### Please provide information about your setup
```console
λ d... | diff --git a/dvc/command/check_ignore.py b/dvc/command/check_ignore.py
index e28f4f19b..97da662a3 100644
--- a/dvc/command/check_ignore.py
+++ b/dvc/command/check_ignore.py
@@ -38,12 +38,11 @@ class CmdCheckIgnore(CmdBase):
def _interactive_mode(self):
ret = 1
while True:
- target = as... |
iterative__dvc-4378 | [
{
"changes": {
"added_entities": [
"dvc/command/experiments.py:_filter_names",
"dvc/command/experiments.py:_parse_list"
],
"added_modules": [
"dvc/command/experiments.py:_filter_names",
"dvc/command/experiments.py:_parse_list"
],
"edited_entities": [... | iterative/dvc | 12c7013062c89a4f9f75d7459a7ed654f3ac174f | Result inconsistency for `__call__`, `is_ignored_file` and `is_ignored_dir`
## Bug Report
### Please provide information about your setup
**Output of `dvc version`:**
```console
$ dvc version
```
master
**Additional Information (if any):**
If applicable, please also provide a `--verbose` output of t... | diff --git a/dvc/command/experiments.py b/dvc/command/experiments.py
index 34fcab00f..e74dcc53b 100644
--- a/dvc/command/experiments.py
+++ b/dvc/command/experiments.py
@@ -2,14 +2,57 @@ import argparse
import io
import logging
from collections import OrderedDict
+from itertools import groupby
+from typing import It... |
iterative__dvc-4379 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/tree/azure.py:AzureTree.__init__",
"dvc/tree/azure.py:AzureTree.blob_service",
"dvc/tree/azure.py:AzureTree.get_etag",
"dvc/tree/azure.py:AzureTree._generate_download_url",
... | iterative/dvc | 12c7013062c89a4f9f75d7459a7ed654f3ac174f | remote: upgrade Azure Blob storage version
Hi!
At the moment `dvc[azure]` has as a requirement `azure = ["azure-storage-blob==2.1.0"]`
Recently there Python SDKs were massively improved to be more Pythonic and efficient. I was wondering if it would be possible to allow for the use of the latest version (12.1). Or... | diff --git a/dvc/tree/azure.py b/dvc/tree/azure.py
index 19f9ecdcb..78ada11b8 100644
--- a/dvc/tree/azure.py
+++ b/dvc/tree/azure.py
@@ -35,16 +35,20 @@ class AzureTree(BaseTree):
container = self._az_config.get("storage", "container_name", None)
self.path_info = self.PATH_CLS(f"azure://{conta... |
iterative__dvc-4386 | [
{
"changes": {
"added_entities": [
"dvc/ignore.py:_no_match"
],
"added_modules": [
"dvc/ignore.py:_no_match"
],
"edited_entities": [
"dvc/ignore.py:DvcIgnoreFilterNoop.check_ignore",
"dvc/ignore.py:DvcIgnoreFilter.check_ignore"
],
"edited... | iterative/dvc | 00925029b4ca63af15a2493717956f1a3b26e907 | better error when output is dvcignored
UPDATE: Skip to https://github.com/iterative/dvc/issues/3538#issuecomment-669603698
---
```
$ dvc version
DVC version: 0.90.2
Python version: 3.7.5
Platform: Windows-10-10.0.18362-SP0
Binary: True
Package: exe
Supported remotes: azure, gdrive, gs, hdfs, http, https, s... | diff --git a/dvc/ignore.py b/dvc/ignore.py
index ea93db805..1c7f731ba 100644
--- a/dvc/ignore.py
+++ b/dvc/ignore.py
@@ -152,6 +152,10 @@ CheckIgnoreResult = namedtuple(
)
+def _no_match(path):
+ return CheckIgnoreResult(path, False, ["::"])
+
+
class DvcIgnoreFilterNoop:
def __init__(self, tree, root_dir... |
iterative__dvc-4465 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/api.py:UrlNotDvcRepoError.__init__",
"dvc/api.py:get_url",
"dvc/api.py:_make_repo"
],
"edited_modules": [
"dvc/api.py:UrlNotDvcRepoError",
"dvc/api.py:get... | iterative/dvc | 4901765cd47d1e742ebe4ea3051d0c93c4239713 | api: get_url does not support links for granular file
`get_url` does not support granular files access.
Eg:
```sh
mkdir dir
echo "foo" > dir/file
dvc add foo
python -c '
import dvc.api
dvc.api.get_url("dir/file"
'
```
throws following exception:
```
OutputNotFoundError: unable to find DVC-file with ... | diff --git a/dvc/api.py b/dvc/api.py
index 1202ebec4..5bf1517af 100644
--- a/dvc/api.py
+++ b/dvc/api.py
@@ -2,35 +2,40 @@ import os
from contextlib import _GeneratorContextManager as GCM
from contextlib import contextmanager
-from dvc.exceptions import DvcException, NotDvcRepoError
+from funcy import reraise
+
+fr... |
iterative__dvc-4469 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/api.py:get_url"
],
"edited_modules": [
"dvc/api.py:get_url"
]
},
"file": "dvc/api.py"
},
{
"changes": {
"added_entities": null,
"added_modules":... | iterative/dvc | de768375ed72ce171daad91c38beb7af387c2cf2 | migrate from travis to github actions | diff --git a/.travis.yml b/.travis.yml
index 1dd401c1b..052574898 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -32,32 +32,6 @@ jobs:
before_install: bash ./scripts/ci/install.sh
install:
script: ./scripts/ci/check_patch.sh
- # test jobs
- - name: "3.7 on Windows"
- stage: test
- os: windows ... |
iterative__dvc-4486 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/cache/local.py:LocalCache.pull"
],
"edited_modules": [
"dvc/cache/local.py:LocalCache"
]
},
"file": "dvc/cache/local.py"
},
{
"changes": {
"added_enti... | iterative/dvc | be2e0778b4a4156a166bfc41ec74b4ac5e66b2a9 | Computing file/dir hashes multiple times (when reportedly only done once reported)
## Bug Report
Performed a dvc init --subdir in an example/DL folder (part of a larger project)
set to use common shared cache
Did not define remote (yet)
created examples/DL/dataset1 and examples/DL/dataset2 sub directories
cd e... | diff --git a/dvc/cache/local.py b/dvc/cache/local.py
index 66cf4a660..d0a9ff894 100644
--- a/dvc/cache/local.py
+++ b/dvc/cache/local.py
@@ -437,7 +437,7 @@ class LocalCache(CloudCache):
@index_locked
def pull(self, named_cache, remote, jobs=None, show_checksums=False):
- return self._process(
+ ... |
iterative__dvc-4488 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/plots.py:CmdPlotsDiff._func",
"dvc/command/plots.py:add_parser"
],
"edited_modules": [
"dvc/command/plots.py:CmdPlotsDiff",
"dvc/command/plots.py:add_pars... | iterative/dvc | be2e0778b4a4156a166bfc41ec74b4ac5e66b2a9 | experiments: provide access to experiment plots
While thinking about #4448 it occurred to me that there's currently no way to use `dvc plots` with experiment revisions. Implementation-wise, we should only need a `dvc exp plots ...` subcommand that runs regular plots in the experiments workspace, the same way that show/... | diff --git a/dvc/command/plots.py b/dvc/command/plots.py
index 8aaf07d8f..2fa779669 100644
--- a/dvc/command/plots.py
+++ b/dvc/command/plots.py
@@ -86,7 +86,12 @@ class CmdPlotsShow(CmdPlots):
class CmdPlotsDiff(CmdPlots):
def _func(self, *args, **kwargs):
- return self.repo.plots.diff(*args, revs=self.... |
iterative__dvc-4517 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/api.py:UrlNotDvcRepoError.__init__",
"dvc/api.py:get_url",
"dvc/api.py:_make_repo"
],
"edited_modules": [
"dvc/api.py:UrlNotDvcRepoError",
"dvc/api.py:get... | iterative/dvc | 4901765cd47d1e742ebe4ea3051d0c93c4239713 | http remote: url query is ignored
## Bug Report
In the .dvc/config file, I provide a query for the http remote
```py
['remote "http"']
url = http://localhost:8080/?param1=value1¶m2=value2
```
When I receive the download/upload request in the server, the query is not received, I only get the file pat... | diff --git a/dvc/api.py b/dvc/api.py
index 1202ebec4..5bf1517af 100644
--- a/dvc/api.py
+++ b/dvc/api.py
@@ -2,35 +2,40 @@ import os
from contextlib import _GeneratorContextManager as GCM
from contextlib import contextmanager
-from dvc.exceptions import DvcException, NotDvcRepoError
+from funcy import reraise
+
+fr... |
iterative__dvc-4538 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dvc/command/repro.py:CmdRepro.run",
"dvc/command/repro.py:add_parser"
],
"edited_modules": [
"dvc/command/repro.py:CmdRepro",
"dvc/command/repro.py:add_parser"
... | iterative/dvc | 9ee5018c633a391aa6389d4433d79634d547feb3 | Make `dvc pull --run-cache` allow `targets` for a granular pull process
Right now, if I do
`dvc pull [target]`
this will pull *only* the `target` I am interested in.
However, if I do `dvc pull --run-cache [targets]`
the `target` is ignored, *everything* is pulled from remote. Not even a warning is thrown that ... | diff --git a/dvc/command/repro.py b/dvc/command/repro.py
index cc5c69e17..7804535b8 100644
--- a/dvc/command/repro.py
+++ b/dvc/command/repro.py
@@ -44,6 +44,7 @@ class CmdRepro(CmdBase):
run_all=self.args.run_all,
jobs=self.args.jobs,
params=self.args.para... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.