instance_id
stringlengths
10
57
file_changes
listlengths
1
15
repo
stringlengths
7
53
base_commit
stringlengths
40
40
problem_statement
stringlengths
11
52.5k
patch
stringlengths
251
7.06M
jdkandersson__OpenAlchemy-64
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "open_alchemy/column_factory/column.py:_handle_string" ], "edited_modules": [ "open_alchemy/column_factory/column.py:_handle_string" ] }, "file": "open_alchemy/column_fa...
jdkandersson/OpenAlchemy
29c90022dce685c1f92fe5973784e0ea5035670b
Support byte As a user I want to define a byte format so that I can store and retrieve base64 encoded values from the database. Support byte as indicated by the appropriate format directive of a string.
diff --git a/CHANGELOG.md b/CHANGELOG.md index e44f4266..cc8553aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Version _next_ +- Add support for _password_ +- Add support for _binary_ - Add support for _byte_ - Add support for _date_ - Move SQLAlchemy relationship construction behind facade d...
jdmoorman__kaczmarz-algorithms-22
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "setup.py" }, { "changes": { "added_entities": [ "src/kaczmarz/_abc.py:Base._select_row_index", "src/kaczmarz/_abc.py:Base._updat...
jdmoorman/kaczmarz-algorithms
87f809cef2e8abbca415542ad62bd642552eac01
Deal with inconsistent systems. We have two options when the system of equations is inconsistent: * Set a default finite value for `maxiter`. * Raise a StopIteration whenever the error increases from one iteration to the next. My preference is the former, since I frequently plot error vs iteration for inconsistent s...
diff --git a/README.md b/README.md index ef25c1e..e41acc2 100644 --- a/README.md +++ b/README.md @@ -111,7 +111,7 @@ For example, to implement a strategy which uses of the equations of your system ... self.n_rows = A.shape[0] ... self.row_index = None ... -... def select_row_index(self, xk): +......
jeanralphaviles__comment_parser-11
[ { "changes": { "added_entities": [ "comment_parser/comment_parser.py:extract_comments_from_str" ], "added_modules": [ "comment_parser/comment_parser.py:extract_comments_from_str" ], "edited_entities": [ "comment_parser/comment_parser.py:extract_comments" ...
jeanralphaviles/comment_parser
30d89191c933a5efe1e800bb3d0ba2d4bfe8b1ee
Extract comments from string? Is there any way of extract comments from a string? I tried this: `comment_parser.extract_comments(a_lis mime='text/x-java-source'')` However, I got: ``` ~/anaconda3/envs/lib/python3.6/site-packages/comment_parser/comment_parser.py in extract_comments(filename, mime) 78 ...
diff --git a/README.md b/README.md index e152862..47bfe3e 100644 --- a/README.md +++ b/README.md @@ -32,8 +32,10 @@ To use, simply run: >>> from comment_parser import comment_parser >>> # Returns a list of comment_parser.parsers.common.Comments >>> comment_parser.extract_comments('/path/to/source_file') +>>> # Or +>...
jendrikseipp__vulture-220
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "vulture/core.py:Vulture.scan", "vulture/core.py:Vulture.visit" ], "edited_modules": [ "vulture/core.py:Vulture" ] }, "file": "vulture/core.py" } ]
jendrikseipp/vulture
899a49e6f08e628caf47e886c5d9917374e522c2
Ignore type checking imports Code like this is common when type annotations in comments are used in Python: ``` from typing import TYPE_CHECKING if TYPE_CHECKING: from typing import Optional, Iterator from abc import xyz ``` These will usually show up as `unused import` as they are only referenced from comme...
diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bae76c..deb0d13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,8 @@ * Consider all files under `test` or `tests` directories test files (Jendrik Seipp). * Ignore `logging.Logger.propagate` attribute (Jendrik Seipp). +* Parse mypy / PEP 484 / PEP 526 `# type:...
jendrikseipp__vulture-340
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "setup.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "vulture/config.py:_parse_to...
jendrikseipp/vulture
b6fae7161611e0b820231d1e80432ee746adee50
Switch to tomli/tomllib for toml parsing Due to https://github.com/uiri/toml/issues/270, vulture won't run for projects with a `pyproject.toml` that contain an array with mixed types. According to https://github.com/python-poetry/poetry/issues/7094#issuecomment-1328127456, this is not an issue in the `tomllib` in Pytho...
diff --git a/.gitignore b/.gitignore index df19119..0ec272f 100644 --- a/.gitignore +++ b/.gitignore @@ -10,3 +10,4 @@ vulture.egg-info/ .pytest_cache/ .tox/ .venv/ +.vscode/ diff --git a/CHANGELOG.md b/CHANGELOG.md index c793814..660b0d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +# next (unreleas...
jerry-git__logplot-11
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "src/logplot/conf.py" }, { "changes": { "added_entities": [ "src/logplot/plot.py:Plot._add_special_entries", "src/logplot/plot.py...
jerry-git/logplot
ed54bd9162bd7bc901c1f448f7ac25cd5d49feaa
Add feature for selecting which series are visible in the plot It'd be nice to be able to filter out certain series to have less noise in the plot. Potential UX: * Similar series are grouped under one toggle (e.g. legend) * User can click the toggle to hide/show the series belonging to that group * Naming of thes...
diff --git a/src/logplot/conf.py b/src/logplot/conf.py index 462fb25..4dd6e2a 100644 --- a/src/logplot/conf.py +++ b/src/logplot/conf.py @@ -4,7 +4,16 @@ import yaml General = namedtuple( - "General", ["log_open_cmd", "default_entry_style", "click_hit_tolerance", "shell"] + "General", + [ + "log_op...
jgieseler__solarmach-22
[ { "changes": { "added_entities": [ "solarmach/__init__.py:SolarMACH.solar_diff_rot" ], "added_modules": null, "edited_entities": [ "solarmach/__init__.py:SolarMACH.__init__", "solarmach/__init__.py:SolarMACH.backmapping", "solarmach/__init__.py:SolarMACH.p...
jgieseler/solarmach
70500e1f16e717312e167834c28fe35f665cbf8e
Plot distance projected to the ecliptic plane instead of radial distance (optionally) At the moment, Solar-MACH shows the configuration plot only with respect to _longitude_ and _radius_. For high latitude orbits (e.g., Solar Orbiter), it might be worthwhile to (optionally) plot the _distance projected to the ecliptic ...
diff --git a/solarmach/__init__.py b/solarmach/__init__.py index 4593855..8fc98e7 100644 --- a/solarmach/__init__.py +++ b/solarmach/__init__.py @@ -92,7 +92,8 @@ class SolarMACH(): Defines the coordinate system used: 'Carrington' (default) or 'Stonyhurst' """ - def __init__(self, date, body_list, vs...
jiaaro__pydub-205
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "pydub/audio_segment.py:AudioSegment.append" ], "edited_modules": [ "pydub/audio_segment.py:AudioSegment" ] }, "file": "pydub/audio_segment.py" }, { "changes": {...
jiaaro/pydub
13c9d045b4afdfbcbfa0d24d24aeba3df2ca64dc
Error when attempting to crossfade with duration longer than one of the files ### Steps to reproduce Create an audio segment from a sound file. Attempt to append a second sound file, with a crossfade duration longer than the actual sound file. ### Expected behavior Either an error message that explains the issue,...
diff --git a/CHANGELOG.md b/CHANGELOG.md index f5785b1..5b92988 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ # v0.20.0 -- Add new parameter `gain_during_overlay` to `pydub.AudioSegment.overlay` which allows users to adjust the volume of the target AudioSegment during the portion of the segment which is...
jitsi__jiwer-108
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/jiwer/alignment.py:visualize_alignment" ], "edited_modules": [ "src/jiwer/alignment.py:visualize_alignment" ] }, "file": "src/jiwer/alignment.py" }, { "chan...
jitsi/jiwer
01e84c3e2dc990c2a2284ab381b36383ed4ef864
utterance ref cannot be empty ? Hello, is there a good reason why an utterance ref is required to be non-empty ? https://github.com/jitsi/jiwer/blob/9db6e4649dfff1e91de5640e224ea51de01b0a50/jiwer/process.py#L158C1-L159C69 IMHO, i'd expect that it can be empty (sclite behavior). It is a valid situation, if the ut...
diff --git a/README.md b/README.md index 3db8e07..be94f9f 100644 --- a/README.md +++ b/README.md @@ -43,6 +43,39 @@ hypothesis = "hello duck" error = wer(reference, hypothesis) ``` + +## A note on empty references + +There is undefined behaviour when you apply an empty reference and hypothesis pair +to the WER form...
jitsi__jiwer-63
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "jiwer/transforms.py:RemovePunctuation.__init__" ], "edited_modules": [ "jiwer/transforms.py:RemovePunctuation" ] }, "file": "jiwer/transforms.py" } ]
jitsi/jiwer
332e6a14840b989942cf3467e4003f2b7d0c24ed
RemovePunctuation does not remove smart/curly quotes RemovePunctuation does not remove the following: ‘ ’ “ ”
diff --git a/README.md b/README.md index 0b1633b..abf8839 100644 --- a/README.md +++ b/README.md @@ -211,9 +211,8 @@ print(jiwer.RemoveWhiteSpace(replace_by_space=True)(sentences)) #### RemovePunctuation -`jiwer.RemovePunctuation()` can be used to filter out punctuation. The punctuation characters are: - -``'!"#$%...
jitsi__jiwer-64
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "jiwer/transforms.py:RemoveSpecificWords.__init__", "jiwer/transforms.py:SubstituteRegexes.__init__", "jiwer/transforms.py:SubstituteRegexes.process_string", "jiwer/transforms.py:...
jitsi/jiwer
332e6a14840b989942cf3467e4003f2b7d0c24ed
RemoveSpecificWords is not functioning as expected Hi! As the title says, the `RemoveSpecificWords` function does not work as I would expect it to. As an example, the following code ``` text = "he asked a helpful question" stop_words = ['a', 'he'] print(jiwer.Compose([ jiwer.ToLowerCase(), ...
diff --git a/README.md b/README.md index 0b1633b..c2ccc60 100644 --- a/README.md +++ b/README.md @@ -176,6 +176,8 @@ print(jiwer.ReduceToSingleSentence()(sentences)) #### RemoveSpecificWords `jiwer.RemoveSpecificWords(words_to_remove: List[str])` can be used to filter out certain words. +As words are replaced with ...
jitsi__jiwer-77
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "jiwer/measures.py:wer", "jiwer/measures.py:mer", "jiwer/measures.py:wip", "jiwer/measures.py:wil", "jiwer/measures.py:cer" ], "edited_modules": [ "jiw...
jitsi/jiwer
6e620ab7ab658955dafef55300a160fd7a636ea8
Version 3.0.0 can produce wrong results Hi, when I use jiwer version 3.0.0 with the following commands: ```python wer_transform = jiwer.Compose( [ jiwer.ToLowerCase(), jiwer.RemoveMultipleSpaces(), jiwer.Strip(), jiwer.ReduceToListOfListOfWords(), ] ) wer = jiw...
diff --git a/jiwer/measures.py b/jiwer/measures.py index 29ba0b9..ba55a6f 100644 --- a/jiwer/measures.py +++ b/jiwer/measures.py @@ -69,7 +69,7 @@ def wer( reference_transform: Union[tr.Compose, tr.AbstractTransform] = wer_default, hypothesis_transform: Union[tr.Compose, tr.AbstractTransform] = wer_default, ...
jjhelmus__pyfive-35
[ { "changes": { "added_entities": [ "pyfive/high_level.py:Group._dereference" ], "added_modules": null, "edited_entities": [ "pyfive/high_level.py:Group.__getitem__" ], "edited_modules": [ "pyfive/high_level.py:Group" ] }, "file": "pyfive/...
jjhelmus/pyfive
bdddda56cfcc51548f8a553bac96adc9919594ad
Access values with path One thing that is not yet possible and that would help a lot. For example, with version 0.2.0: Using Python 2.7.12 (default, Jul 1 2016, 15:12:24) [GCC 5.4.0 20160609] on linux2 > > > import h5py > > > import pyfive > > > > > > f5 = h5py.File('tests/latest.hdf5') > > > f5["group1/subgroup1/d...
diff --git a/pyfive/high_level.py b/pyfive/high_level.py index 11c90ff..973f49d 100644 --- a/pyfive/high_level.py +++ b/pyfive/high_level.py @@ -3,6 +3,7 @@ from collections import Mapping, deque, Sequence import os from io import open # Python 2.7 requires for a Buffered Reader +import posixpath import numpy...
jjhelmus__pyfive-38
[ { "changes": { "added_entities": [ "pyfive/high_level.py:Dataset.value" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "pyfive/high_level.py:Dataset" ] }, "file": "pyfive/high_level.py" } ]
jjhelmus/pyfive
3bb186febb5f9afa8994208f172457b49500ab92
Access values with path One thing that is not yet possible and that would help a lot. For example, with version 0.2.0: Using Python 2.7.12 (default, Jul 1 2016, 15:12:24) [GCC 5.4.0 20160609] on linux2 > > > import h5py > > > import pyfive > > > > > > f5 = h5py.File('tests/latest.hdf5') > > > f5["group1/subgroup1/d...
diff --git a/pyfive/high_level.py b/pyfive/high_level.py index 121b980..7bcaded 100644 --- a/pyfive/high_level.py +++ b/pyfive/high_level.py @@ -321,6 +321,13 @@ class Dataset(object): """ dtype attribute. """ return self._dataobjects.dtype + @property + def value(self): + """ alias for...
jjmccollum__teiphy-68
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "teiphy/collation.py:Collation.__init__", "teiphy/collation.py:Collation.get_readings_by_witness_for_unit", "teiphy/collation.py:Collation.parse_readings_by_witness", "teiphy/coll...
jjmccollum/teiphy
d6cf6bb7e72ea892dc4a360648ab002abe5af3e4
Should teiphy convert all variation units, including trivial ones? Since we decided in #56 that ascertainment bias correction should be handled by the user's phylogenetic software rather by `teiphy`, it is worth asking if `teiphy` should convert _all_ variation units, and not just those with more than one substantive v...
diff --git a/.github/workflows/iqtree.yml b/.github/workflows/iqtree.yml index 9016ce9..a4048d2 100644 --- a/.github/workflows/iqtree.yml +++ b/.github/workflows/iqtree.yml @@ -26,5 +26,5 @@ jobs: sudo apt-get install -y iqtree - name: Phylogenetics Run run: | - iqtree2 -s iqtree_example.nex...
jjmccollum__teiphy-76
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "teiphy/collation.py:Collation.to_beast", "teiphy/collation.py:Collation.to_file" ], "edited_modules": [ "teiphy/collation.py:Collation" ] }, "file": "teiphy/col...
jjmccollum/teiphy
17ef606cb2502cfa23c929f2c3a52c758982905b
Assignment of random starting rate parameter values, new prior distributions, and support for `--seed` option For larger collations with increasingly varied substitution matrices at different sites/variation units, it becomes increasingly likely that at least one of the substitution matrices will be singular under the ...
diff --git a/.github/workflows/beast.yml b/.github/workflows/beast.yml index bfcf37c..118ece7 100644 --- a/.github/workflows/beast.yml +++ b/.github/workflows/beast.yml @@ -26,9 +26,9 @@ jobs: - run: poetry install - name: Testing run: | - poetry run teiphy -t reconstructed -t defective -t ortho...
jlusiardi__tlv8_python-14
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "setup.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "tlv8/__init__.py:_internal_...
jlusiardi/tlv8_python
55cdbf71d41d25c24ba5b05e3f43a4d5e1d32274
Oversized TLV8 might be parsed properly. ``` data = '01ff0601040440371bf8c6cd6a7fb85e77a7b436a1b5300ed2023ca7e23f61303856a57358fd8ac03f288472776854765eb3' \ 'a2fcb4497c8b5497c29c88a574479030ec36b176ae05ff85c337879f0a4146a9cc089e0cb48ba3c9c21af0b206d493b224de' \ 'ee52ff0f9b1d8710db6531748ee6d1d66b8b4a6d...
diff --git a/CHANGES.md b/CHANGES.md index eaf351e..e1f512c 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,6 +1,13 @@ # Changes +## Version 0.9.0 + +Bug Fix: + +- Fix for https://github.com/jlusiardi/tlv8_python/issues/13 (and https://github.com/jlusiardi/homekit_python/issues/194) + which broke pairing with BLE ...
jmcnamara__XlsxWriter-396
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "xlsxwriter/worksheet.py:Worksheet.conditional_format", "xlsxwriter/worksheet.py:Worksheet._write_data_bar" ], "edited_modules": [ "xlsxwriter/worksheet.py:Worksheet" ] ...
jmcnamara/XlsxWriter
7a48769abe7e68c0f3729c4f7c951ad5ca9a0bf8
Feature Request: Add minLength and maxLength to dataBar attributes Attributes minLength and maxLength determine maximum and minimum histogram length in percentage of cell width. Currently those attributes are not set. Default values are 10 and 90 percent. It would be useful to have possibility of setting them manually....
diff --git a/xlsxwriter/worksheet.py b/xlsxwriter/worksheet.py index 3e63ea53..dbe8e63e 100644 --- a/xlsxwriter/worksheet.py +++ b/xlsxwriter/worksheet.py @@ -1880,6 +1880,8 @@ class Worksheet(xmlwriter.XMLwriter): 'min_color': True, 'mid_color': True, 'max_color': True, + ...
jmcnamara__XlsxWriter-956
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "xlsxwriter/worksheet.py:Worksheet.autofit" ], "edited_modules": [ "xlsxwriter/worksheet.py:Worksheet" ] }, "file": "xlsxwriter/worksheet.py" } ]
jmcnamara/XlsxWriter
28a93525cdbf4176a9b58bbb26e7e56e259e4c00
Bug: `TypeError` raised when autofitting an empty worksheet ### Current behavior If you have an empty `Worksheet` and try to autofit, an unexpected `TypeError` is raised. ### Expected behavior Should not raise an exception if there happens to be nothing to autofit. ### Sample code to reproduce ```python ...
diff --git a/xlsxwriter/worksheet.py b/xlsxwriter/worksheet.py index 7e14ff8b..c935f130 100644 --- a/xlsxwriter/worksheet.py +++ b/xlsxwriter/worksheet.py @@ -1835,6 +1835,10 @@ class Worksheet(xmlwriter.XMLwriter): warn("Autofit is not supported in constant_memory mode.") return + # ...
jmespath__jmespath.py-102
[ { "changes": { "added_entities": [ "jmespath/compat.py:with_metaclass", "jmespath/compat.py:metaclass.__new__" ], "added_modules": [ "jmespath/compat.py:with_metaclass", "jmespath/compat.py:metaclass" ], "edited_entities": null, "edited_modules...
jmespath/jmespath.py
a6baa176714c72a68a2b367810b91162b1125f41
Custom functions What are your thoughts about adding a method to register custom functions directly into `RuntimeFunctions` class in `functions.py`? JMESPath is almost good enough to use as a domain specific language for general language transforming objects. You can sneak in literals in the multi-select hash. You c...
diff --git a/README.rst b/README.rst index e7262d4..486783b 100644 --- a/README.rst +++ b/README.rst @@ -96,6 +96,85 @@ of your dict keys. To do this you can use either of these options: ... jmespath.Options(dict_cls=collections.OrderedDict)) +Custom Functions +~~~~~~~~~~~~~~~~ + +The JMESPath l...
jmespath__jmespath.py-126
[ { "changes": { "added_entities": [ "jmespath/visitor.py:_is_comparable" ], "added_modules": [ "jmespath/visitor.py:_is_comparable" ], "edited_entities": [ "jmespath/visitor.py:TreeInterpreter.visit_comparator" ], "edited_modules": [ "jmes...
jmespath/jmespath.py
de035093b7e52c6a6ea4411f41d2aec10d499dcb
0.9.1 date comparisons not working From https://gitter.im/jmespath/chat: ``` aws ec2 describe-snapshots --owner-id self --query 'Snapshots[?StartTime>='2017--02-01']' The above command returns and empty set ( '[]' ) when run with v0.9.1, and a list of appropriate snapshots with run with v0.9.0. ``` I have the same...
diff --git a/jmespath/visitor.py b/jmespath/visitor.py index 75af885..6c7f0c4 100644 --- a/jmespath/visitor.py +++ b/jmespath/visitor.py @@ -1,6 +1,7 @@ import operator from jmespath import functions +from jmespath.compat import string_type def _equals(x, y): @@ -33,6 +34,14 @@ def _is_special_integer_case(x, ...
jmoiron__humanize-104
[ { "changes": { "added_entities": null, "added_modules": [ "src/humanize/time.py:Unit" ], "edited_entities": [ "src/humanize/time.py:date_and_delta", "src/humanize/time.py:naturaldelta", "src/humanize/time.py:naturaltime" ], "edited_modules": [ ...
jmoiron/humanize
d64655aa8f2736b1131ff8a91a128daed7f36cc3
Support milliseconds, microseconds etc. If you run something for a minute, `humanize` is great. If you want to tell the user what you did in that time (100.000 things), and then want to brag about how fast that is (`a moment` per thing?), `humanize` is not super-great any more :)
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index cfc7f74..d885c34 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -28,7 +28,7 @@ repos: - id: isort - repo: https://github.com/pre-commit/pygrep-hooks - rev: v1.4.4 + rev: v1.5.1 hooks: - id: python-c...
jmoiron__humanize-107
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/humanize/time.py:naturaldate" ], "edited_modules": [ "src/humanize/time.py:naturaldate" ] }, "file": "src/humanize/time.py" } ]
jmoiron/humanize
22a0a136e7358f22797c120bbd85acf48822d13e
naturaldate returns ambiguous values ```pycon >>> import humanize >>> from datetime import datetime, timedelta >>> humanize.naturaldate(datetime.now()-timedelta(3)) 'Jan 15' >>> humanize.naturaldate(datetime.now()+timedelta(362)) 'Jan 15' ``` I'd suggest to add the year for all dates that are more than about ...
diff --git a/src/humanize/time.py b/src/humanize/time.py index 7f68ff9..716648a 100644 --- a/src/humanize/time.py +++ b/src/humanize/time.py @@ -196,8 +196,8 @@ def naturalday(value, format="%b %d"): def naturaldate(value): - """Like naturalday, but will append a year for dates that are a year - ago or more....
jmoiron__humanize-121
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/humanize/number.py:apnumber" ], "edited_modules": [ "src/humanize/number.py:apnumber" ] }, "file": "src/humanize/number.py" } ]
jmoiron/humanize
aaca29f35306c48c9965047ac5d39807a33652a7
humanize.apnumber(0) should return zero `humanize.appnumber` returns 0 for 0, while (I think) it should return 'zero': ```pycon >>> import humanize >>> humanize.apnumber(0) '0' >>> humanize.apnumber(1) 'one' >>> humanize.apnumber(2) 'two' >>> ```
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 225fdc9..7fa46ec 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,6 @@ Fixes # Changes proposed in this pull request: - * - * - * +* +* +* diff --git a/.pre-commit-config.yaml...
jmoiron__humanize-122
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/humanize/filesize.py:naturalsize" ], "edited_modules": [ "src/humanize/filesize.py:naturalsize" ] }, "file": "src/humanize/filesize.py" } ]
jmoiron/humanize
aaca29f35306c48c9965047ac5d39807a33652a7
Negative Sizes Only Show In Bytes When using `naturalsize` with negative values (I wish to display a change in file size), you only get bytes: ```python >>> In[4] import humanize >>> In[5] humanize.naturalsize(123456) >>> Out[5]: '123.5 kB' >>> In[6] humanize.naturalsize(-123456) >>> Out[6]: '-123456 Bytes' ``...
diff --git a/src/humanize/filesize.py b/src/humanize/filesize.py index 754a9f3..694e264 100644 --- a/src/humanize/filesize.py +++ b/src/humanize/filesize.py @@ -10,12 +10,20 @@ suffixes = { def naturalsize(value, binary=False, gnu=False, format="%.1f"): - """Format a number of byteslike a human readable filesiz...
jmoiron__humanize-123
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/humanize/number.py:intcomma" ], "edited_modules": [ "src/humanize/number.py:intcomma" ] }, "file": "src/humanize/number.py" } ]
jmoiron/humanize
77d943afaaef5a20b946f09ca2130dddb1dc85da
intcomma() variant needed to handle money When using intcomma on a dollar value like 14308.40, I get '14,308.4'. It would be nice to have a moneycomma(14308.40,2) which gives me '14,308.40'.
diff --git a/src/humanize/number.py b/src/humanize/number.py index f57588e..013448e 100644 --- a/src/humanize/number.py +++ b/src/humanize/number.py @@ -35,11 +35,19 @@ def ordinal(value): return "%d%s" % (value, t[value % 10]) -def intcomma(value): +def intcomma(value, ndigits=None): """Converts an integ...
jmoiron__humanize-137
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "src/humanize/__init__.py" }, { "changes": { "added_entities": [ "src/humanize/time.py:Unit.__lt__", "src/humanize/time.py:_quoti...
jmoiron/humanize
976ad4a342c50958fdc5668f7e84cd271a7ac7cd
function to print timedeltas exactly Hi, I find myself using a function regularly that prints a time delta as "4 hours, 3 minutes, and 15.3 seconds". Is this a function you'd be interested in adding to your library? I'd rather add it to a common library rather than copy and pasting it the whole time. If you want...
diff --git a/README.md b/README.md index 6c0fc1a..3f00987 100644 --- a/README.md +++ b/README.md @@ -70,6 +70,20 @@ readable size or throughput. It is localized to: 'an hour ago' ``` +### Precise time delta + +```pycon +>>> import humanize +>>> import datetime as dt +>>> delta = dt.timedelta(seconds=3633, days=2, m...
jmoiron__humanize-144
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/humanize/time.py:naturaldelta", "src/humanize/time.py:naturaltime" ], "edited_modules": [ "src/humanize/time.py:naturaldelta", "src/humanize/time.py:naturaltime" ...
jmoiron/humanize
55b3e1cef144f34f8f4af6bfc87972ccafd6771d
The package (wrongly) assumes all times are in the local timezone
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index e21eccf..7af3b16 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -6,7 +6,7 @@ repos: args: ["--py36-plus"] - repo: https://github.com/psf/black - rev: 19.10b0 + rev: 20.8b1 hooks: - id: black ...
jmoiron__humanize-170
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/humanize/time.py:precisedelta" ], "edited_modules": [ "src/humanize/time.py:precisedelta" ] }, "file": "src/humanize/time.py" } ]
jmoiron/humanize
9d9de69177154b41b2d6ef412d1487639e99833d
precisedelta with minimum unit seconds fails when seconds is a very small value ### What did you do? Calculated a small delta. ```python import humanize from datetime import timedelta duration_seconds = 1e-06 # A small value, or 0 delta = timedelta(seconds=duration_seconds) output = humanize.precisedelt...
diff --git a/src/humanize/time.py b/src/humanize/time.py index 319d7e4..e40c482 100644 --- a/src/humanize/time.py +++ b/src/humanize/time.py @@ -426,6 +426,20 @@ def precisedelta(value, minimum_unit="seconds", suppress=(), format="%0.2f"): >>> precisedelta(delta, suppress=['seconds', 'milliseconds', 'microseconds'...
jmoiron__humanize-183
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "src/humanize/__init__.py" }, { "changes": { "added_entities": [ "src/humanize/i18n.py:thousands_separator" ], "added_modules...
jmoiron/humanize
0cbd1ababec2dcdd71e57856f9b0cce8c4d21b51
intcomma doesn't support internationalization ### What did you do? I tried to use `intcomma` with the `fr_FR` locale ### What did you expect to happen? A space separated decimal like `10 000 000` ### What actually happened? A comma separated decimal like `10,000,000` ### What versions are you using? ...
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 5320a9e..518e990 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -11,17 +11,17 @@ repos: - id: black args: ["--target-version", "py36"] + - repo: https://github.com/PyCQA/isort + rev: 5.6.4 + hooks: + ...
jmwri__ioccontainer-4
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "ioccontainer/inject.py:InjectDecorator.process_parameter", "ioccontainer/inject.py:_argument_provided", "ioccontainer/inject.py:_is_positional_argument" ], "edited_modules": ...
jmwri/ioccontainer
9155dbf9030df7bd911a5bc93feb397d1f545feb
Inject should override value if None When using the `@inject` decorator, the provided parameter should be overridden if it is `None`. At the moment the provider parameter takes precedence 100% of the time.
diff --git a/ioccontainer/inject.py b/ioccontainer/inject.py index 162f6e1..98ba622 100644 --- a/ioccontainer/inject.py +++ b/ioccontainer/inject.py @@ -50,7 +50,11 @@ def inject_decorator(container: 'Container'): service = container.get(cls) if _is_positional_argument(position, parameter, n...
jmwri__simplejwt-2
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "simplejwt/__init__.py" }, { "changes": { "added_entities": [ "simplejwt/jwt.py:make" ], "added_modules": [ "simplejw...
jmwri/simplejwt
e3edef90eda15e3f4c23bce0465b2def14868d30
Add support for registered claims There are a list of registered claims in [rfc7519](https://tools.ietf.org/html/rfc7519#section-4.1). Simplejwt should support these out of the box.
diff --git a/README.md b/README.md index cc0b04c..2b7b764 100644 --- a/README.md +++ b/README.md @@ -23,6 +23,30 @@ token = encode('secret', {'my_payload': 'some_data'}, 'HS256') | `payload` | `dict` | *N/A* | The payload data contained within the token. | | `alg` | `int` | `HS256` | The algorithm to use to create th...
jmwri__simplejwt-5
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "setup.py" }, { "changes": { "added_entities": [ "simplejwt/jwt.py:Jwt.__init__", "simplejwt/jwt.py:Jwt.issuer", "simplej...
jmwri/simplejwt
6ffffc92a281010ae753dbbb23de0ef697da8797
Create a Jwt object It would be useful to have a `Jwt` object that provides helpers, such as `expired()` etc.
diff --git a/README.md b/README.md index 2b7b764..e8506f6 100644 --- a/README.md +++ b/README.md @@ -7,6 +7,12 @@ A dead simple JWT library. +# Supported algorithms + +* HS256 +* HS384 +* HS512 + # Usage ## Encode Returns a new token. diff --git a/setup.py b/setup.py index 18699b4..d39a525 100644 --- a/setup.py...
jnothman__UpSetPlot-103
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "upsetplot/plotting.py:_process_data", "upsetplot/plotting.py:UpSet.__init__", "upsetplot/plotting.py:UpSet._label_sizes" ], "edited_modules": [ "upsetplot/plotting.py...
jnothman/UpSetPlot
bf50110f1f20c04ce497ccbcaf2b909ca0b22263
show_percentages doesn't sum to 100% I noticed that the percentages above the intersection bars do not sum to 100%. Shouldn't the displayed percentages represent the contribution of each intersection to the whole dataset, and so all percentages sum t 100%? If I run this block using upsetplot 0.4.0: ```python from ...
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 8ef90c2..f533711 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,3 +1,8 @@ +What's new in version 0.4.1 +--------------------------- + +- Fixed the calculation of percentage which was broken in 0.4.0. (:issue:`101`) + What's new in version 0.4 --------------------...
jnothman__UpSetPlot-11
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "upsetplot/plotting.py:UpSetPlot._calculate_text_ncols", "upsetplot/plotting.py:UpSetPlot.plot_matrix", "upsetplot/plotting.py:UpSetPlot.plot_intersections", "upsetplot/plotting.p...
jnothman/UpSetPlot
b8c0c99ee68c07ac0902d0f660570e33a55907b1
Smoke test plotting Make sure plots can run in all environments.
diff --git a/upsetplot/plotting.py b/upsetplot/plotting.py index 3645595..6578ac5 100644 --- a/upsetplot/plotting.py +++ b/upsetplot/plotting.py @@ -1,10 +1,10 @@ -import warnings import itertools import numpy as np import pandas as pd import matplotlib from matplotlib import pyplot as plt +from matplotlib.tight...
jnothman__UpSetPlot-248
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "upsetplot/plotting.py:_process_data" ], "edited_modules": [ "upsetplot/plotting.py:_process_data" ] }, "file": "upsetplot/plotting.py" }, { "changes": { "...
jnothman/UpSetPlot
3bf5ad55c6e25e1a2cf4d02745dc7fac3f81469c
Problems with show_percentages I am using the plot function to make an upset plot with show_percentages=True. When I plot the whole upset plot the % values are calculated correctly, however when I use the min_subset_size=100 parameter, the % calculations change. I don't think the new percentage calculations uses the wh...
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 837abcc..9624e07 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,6 +1,11 @@ What's new in version 0.9 ------------------------- -- Ability to disable totals plot with `totals_plot_elements=0`. + +- Fixes a bug where ``show_percentages`` used the incorrect denomina...
jnothman__UpSetPlot-253
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "upsetplot/plotting.py:_process_data", "upsetplot/plotting.py:UpSet.__init__", "upsetplot/plotting.py:UpSet.style_subsets" ], "edited_modules": [ "upsetplot/plotting.p...
jnothman/UpSetPlot
16ff93055ec5a2b0ee96eea6f089734e94098bab
Specify maximum number of intersections to display Hi, Apologies if this has already been implemented, but after going through the [API documentation](https://upsetplot.readthedocs.io/en/stable/api.html), I'm unable to find an option that limits the number of displayed intersections, which forces me to manually trun...
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 9624e07..27421f4 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -6,6 +6,7 @@ What's new in version 0.9 introduced in version 0.7. (:issue:`248`) - Ability to disable totals plot with `totals_plot_elements=0`. (:issue:`246`) - Ability to set totals y axis label (:...
jnothman__UpSetPlot-264
[ { "changes": { "added_entities": [ "upsetplot/reformat.py:_check_percent" ], "added_modules": [ "upsetplot/reformat.py:_check_percent" ], "edited_entities": [ "upsetplot/reformat.py:_get_subset_mask" ], "edited_modules": [ "upsetplot/refo...
jnothman/UpSetPlot
da64c81a12f5e6c8283e10a4f6cd7a42ccda1491
Express min_subset_size as a percentage / fraction It should be possible to use `min_subset_size="30%"` and similar percentage specification of `max_subset_size`, corresponding to the values displayed with `show_percentages`. From #170
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index a00b4d9..37a37ef 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -8,7 +8,10 @@ What's new in version 0.9 shading of rows in the intersection matrix, and bars in the totals plot. (:issue:`261` with thanks to :user:`Marcel Albus <maralbus>`). - Ability to disable ...
jnothman__UpSetPlot-29
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "upsetplot/plotting.py:UpSet.__init__", "upsetplot/plotting.py:UpSet.make_grid", "upsetplot/plotting.py:UpSet._calculate_text_ncols", "upsetplot/plotting.py:UpSet.plot_matrix" ...
jnothman/UpSetPlot
a272986182e3f1de64ab7d20fd44c59f8b693017
Allow automatic determination of figsize from dot radius in pts User should be able to specify a dot radius and the figure size is calculated from there...
diff --git a/upsetplot/plotting.py b/upsetplot/plotting.py index 89c8506..5203bf3 100644 --- a/upsetplot/plotting.py +++ b/upsetplot/plotting.py @@ -79,26 +79,29 @@ class UpSet: with_lines : bool Whether to show lines joining dots in the matrix, to mark multiple sets being intersected. - inter...
jnothman__UpSetPlot-55
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "upsetplot/data.py:from_memberships" ], "edited_modules": [ "upsetplot/data.py:from_memberships" ] }, "file": "upsetplot/data.py" } ]
jnothman/UpSetPlot
825c8fa74283b18af11eed70938459fbfb248fcc
ValuError sum_over must be False Hi, I am encountering a problem when trying to use upsetplot. When I am running: from upsetplot import from_memberships example = from_memberships( [[], ['set2'], ['set1'], ['set1', 'set2'], ['set0'], ['set0', 'set2'], ['set0', 'set1'], ['set0', 'set1', 'set2'], ], data=[5...
diff --git a/README.rst b/README.rst index 843f2ef..ff45460 100644 --- a/README.rst +++ b/README.rst @@ -94,7 +94,6 @@ membership:: ... data=[56, 283, 1279, 5882, 24, 90, 429, 1957] ... ) >>> example # doctest: +NORMALIZE_WHITESPACE - 0 set0 set1 set2 Fals...
jnothman__UpSetPlot-61
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "upsetplot/__init__.py" }, { "changes": { "added_entities": [ "upsetplot/data.py:from_contents" ], "added_modules": [ ...
jnothman/UpSetPlot
e66934c2e4f89f6a85b52ded959d8d2f620d9902
Feature Request: more intuitive data conversion Currently there are three ways to use your library: 1. generate data via the `generate_data` method 2. construct data via the `from_membership` method 3. be comfortable enough with Pandas to coerce your data to fit the expected shape (for which there is no documenta...
diff --git a/doc/api.rst b/doc/api.rst index 3184e6e..169b341 100644 --- a/doc/api.rst +++ b/doc/api.rst @@ -17,6 +17,8 @@ Plotting Dataset loading and generation ------------------------------ +.. autofunction:: from_contents + .. autofunction:: from_memberships .. autofunction:: generate_data diff --git a/ups...
jnothman__UpSetPlot-66
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "upsetplot/data.py:generate_data", "upsetplot/data.py:from_memberships" ], "edited_modules": [ "upsetplot/data.py:generate_data", "upsetplot/data.py:from_memberships" ...
jnothman/UpSetPlot
3bdac289a44d88749652e38b9d0a773ecc4ac39b
Change nomenclature: use "category" for named sets Use of "set" is confusing, although "named set" is slightly better.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index c2355d2..87c0a95 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,3 +1,20 @@ +What's new in version 0.3 +------------------------- + +- Added `from_contents` to provide an alternative, intuitive way of specifying + category membership of elements. +- Fixed the displ...
jnothman__UpSetPlot-69
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "examples/plot_boston.py" }, { "changes": { "added_entities": [ "upsetplot/plotting.py:_aggregate_data" ], "added_modules": [...
jnothman/UpSetPlot
51ef40df8188022977433d5cf752d971bd37efc7
sum_over should default to False for DataFrame input
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 094af8b..55bd6c1 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,6 +1,9 @@ What's new in version 0.3 ------------------------- +- To improve code legibility and intuitiveness, `sum_over=False` was deprecated + and a `subset_size` parameter was added. It will h...
jnothman__UpSetPlot-71
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "examples/plot_generated.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_...
jnothman/UpSetPlot
b37bd9fb204fa374da8d7c451a25502eeba18aeb
Rename generate_data to generate_counts and default aggregate=TRUE
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 55bd6c1..e176cbb 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,11 +1,13 @@ What's new in version 0.3 ------------------------- +- Added `from_contents` to provide an alternative, intuitive way of specifying + category membership of elements. - To improve cod...
jnothman__UpSetPlot-76
[ { "changes": { "added_entities": [ "upsetplot/plotting.py:_check_index" ], "added_modules": [ "upsetplot/plotting.py:_check_index" ], "edited_entities": [ "upsetplot/plotting.py:_process_data" ], "edited_modules": [ "upsetplot/plotting.py...
jnothman/UpSetPlot
ad83089d04cde701b70e5260d18ea619a2c337fb
Allow truthy/falsy index? I have a pandas dataframe with 1 or 0 as valued for dummied columns. When I try to plot without changing the 1/0 to True/False the figure is missing the dot grid/connections. Is this by design, and is it possible to allow the 1/0? Below is an example to reproduce. The line with the comment ...
diff --git a/upsetplot/plotting.py b/upsetplot/plotting.py index ff693e7..a8b7ba1 100644 --- a/upsetplot/plotting.py +++ b/upsetplot/plotting.py @@ -84,11 +84,29 @@ def _aggregate_data(df, subset_size, sum_over): return df, aggregated +def _check_index(df): + # check all indices are boolean + if not all(...
jnothman__searchgrid-12
[ { "changes": { "added_entities": [ "searchgrid.py:_name_steps", "searchgrid.py:make_pipeline", "searchgrid.py:make_union" ], "added_modules": [ "searchgrid.py:_name_steps", "searchgrid.py:make_pipeline", "searchgrid.py:make_union" ], ...
jnothman/searchgrid
1f1a79f272dceb1afb44ec3228cdab0c52ea9278
Shorthands for gridded pipelines and feature_unions Could have: ```python searchgrid.make_union([OptionalTransformer1(), None], [OptionalTransformer2(), OptionalTransformer3()], Transformer4()) ``` translate to ```python set_grid(FeatureUnion([('optionaltransfor...
diff --git a/README.rst b/README.rst index 980eaa0..c917f94 100644 --- a/README.rst +++ b/README.rst @@ -32,6 +32,12 @@ It provides two main functions: ``GridSearchCV`` object using the parameter space the estimator is annotated with. +Other utilities for constructing search spaces include: + +- `searchgrid.b...
joanvila__aioredlock-77
[ { "changes": { "added_entities": [ "aioredlock/algorithm.py:Aioredlock.get_active_locks" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "aioredlock/algorithm.py:Aioredlock" ] }, "file": "aioredlock/algorithm.py" }, { "ch...
joanvila/aioredlock
cf2ffca3df65decb64de6dd93bcd139244db930e
A function to return number of active locks Would be a nice to have a feature to do that.
diff --git a/aioredlock/algorithm.py b/aioredlock/algorithm.py index bf192ab..51707b7 100644 --- a/aioredlock/algorithm.py +++ b/aioredlock/algorithm.py @@ -238,3 +238,18 @@ class Aioredlock: self._watchdogs.clear() await self.redis.clear_connections() + + async def get_active_locks(self): + ...
joblib__joblib-1149
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "joblib/__init__.py" }, { "changes": { "added_entities": [ "joblib/memory.py:MemorizedFunc._is_in_cache_and_valid", "joblib/memor...
joblib/joblib
9f7edc2f67d1d27757be88168ffe533a916e1032
Expiry of old results I've added a small extra feature that recalculates if a result is older than a certain age. ``` @memory.cache(expires_after=60) def f(x): ... ``` Will recompute if cached result is older than 60 seconds. Code is in this branch: https://github.com/fredludlow/joblib/tree/expires-after Is this o...
diff --git a/CHANGES.rst b/CHANGES.rst index b6c3610..25d3f27 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -32,6 +32,10 @@ In development previous versions of Joblib. https://github.com/joblib/joblib/pull/1374 +- Add ``cache_validation_callback`` in :meth:`joblib.Memory.cache`, to allow + custom cache invalid...
joblib__joblib-1165
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/func_inspect.py:_signature_str", "joblib/func_inspect.py:filter_args" ], "edited_modules": [ "joblib/func_inspect.py:_signature_str", "joblib/func_inspect.py:f...
joblib/joblib
5c7c4566bc2668a435799713fcbf467234f4e984
Use inspect.signature() instead of inspect.getfullargspec() Currently, the implementation of `Memory.cache()` implements the `ignore` option using [`inspect.getfullargspec()`](https://docs.python.org/3/library/inspect.html#inspect.getfullargspec). However, this function does not handle decorated functions correctly; [...
diff --git a/CHANGES.rst b/CHANGES.rst index 5328c2c..93144b3 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,6 +1,13 @@ Latest changes ============== +Development version +------------------- + +- Fix joblib.Memory bug with the ``ignore`` parameter when the cached function + is a decorated function. + https://g...
joblib__joblib-1200
[ { "changes": { "added_entities": [ "joblib/_store_backends.py:StoreBackendMixin.enforce_store_limits" ], "added_modules": null, "edited_entities": [ "joblib/_store_backends.py:StoreBackendMixin.reduce_store_size", "joblib/_store_backends.py:StoreBackendMixin._get_...
joblib/joblib
2303143c041d34267f73a2ded06fccd73547c3fa
Wishlist: more flexible control (not just by size) for clean up Follow up to #1170 . Thank you for the clarifications on logic -- great to know that both `last_access` attribute it stored! In our use case (https://github.com/con/fscacher/) size though is not an issue -- it is just a sheer number of files, and thus i...
diff --git a/CHANGES.rst b/CHANGES.rst index 3decb56..b6c3610 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -4,15 +4,15 @@ Latest changes In development -------------- -- Ensure native byte order for memmap arrays in `joblib.load`. +- Ensure native byte order for memmap arrays in ``joblib.load``. https://github....
joblib__joblib-1254
[ { "changes": { "added_entities": [ "joblib/numpy_pickle.py:NumpyArrayWrapper.safe_get_numpy_array_alignment_bytes" ], "added_modules": null, "edited_entities": [ "joblib/numpy_pickle.py:NumpyArrayWrapper.__init__", "joblib/numpy_pickle.py:NumpyArrayWrapper.write_a...
joblib/joblib
3d805061e7f1b32df7c1cd5b40d272b34d50e487
Alignment issue when passing arrays though mmap Arrays that are transfered to subprocesses though mmap appear not always to be aligned: ```python import joblib import numpy as np def func(x): print(type(x)) print(x.flags) print(x.ctypes.data / 8) if __name__ == '__main__': # Make the arra...
diff --git a/CHANGES.rst b/CHANGES.rst index c5c428a..56c8e76 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -16,6 +16,18 @@ Development version worker processes in case of a crash. https://github.com/joblib/joblib/pull/1269 +- Fix memory alignment bug for pickles containing numpy arrays. + This is especially i...
joblib__joblib-1389
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/func_inspect.py:get_func_name" ], "edited_modules": [ "joblib/func_inspect.py:get_func_name" ] }, "file": "joblib/func_inspect.py" } ]
joblib/joblib
061d4ad3b5bd3bab597a2b22c0e67376fb1e25c8
support python3.11 Release the version supporting python3.11 as soon as possible.
diff --git a/CHANGES.rst b/CHANGES.rst index 6f2dd8a..3f1bf8e 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -27,6 +27,11 @@ In development errors, a new warning has been introduced: `joblib.memory.CacheWarning`. https://github.com/joblib/joblib/pull/1359 +- Avoid (module, name) collisions when caching nested fu...
joblib__joblib-1674
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "joblib/__init__.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/_store_bac...
joblib/joblib
389daf20d1bc874e371b5f95e41a3cc7a7c044ed
Auto-added `.gitignore` in cache directories I am quite sure that nobody wants to add cache to their version control. Therefore, many relevant tools like Mypy, Ruff, or, Pytest automatically adds (within the cache directory) a `.gitignore` file, as simple as: ```gitignore # .cache/.gitignore * ``` I guess this...
diff --git a/CHANGES.rst b/CHANGES.rst index efe8504..77f45bf 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -40,6 +40,9 @@ In development the warnings that are emitted in this case. https://github.com/joblib/joblib/pull/1681 +- The Memory object now automatically creates a .gitignore file in its cache directory...
joblib__joblib-204
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/hashing.py:NumpyHasher.save" ], "edited_modules": [ "joblib/hashing.py:NumpyHasher" ] }, "file": "joblib/hashing.py" } ]
joblib/joblib
21cb6f3fd32b11a9b6bc1528b86bbf83fce7bb1f
Cannot hash datetime64 ``` In [59]: joblib.hashing.hash(numpy.zeros(dtype="<m8[s]", shape=(10,))) --------------------------------------------------------------------------- ValueError Traceback (most recent call last) <ipython-input-59-8b9b8a0f034d> in <module>() ----> 1 joblib.hash...
diff --git a/joblib/hashing.py b/joblib/hashing.py index 564817c..d3d783a 100644 --- a/joblib/hashing.py +++ b/joblib/hashing.py @@ -154,14 +154,21 @@ class NumpyHasher(Hasher): if isinstance(obj, self.np.ndarray) and not obj.dtype.hasobject: # Compute a hash of the object: try: - ...
joblib__joblib-262
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/numpy_pickle.py:NumpyPickler.__init__", "joblib/numpy_pickle.py:NumpyPickler.save" ], "edited_modules": [ "joblib/numpy_pickle.py:NumpyPickler" ] }, "fil...
joblib/joblib
aeb018af545e025654176ffe9ae876bda1bddb89
joblib.dump bug with too large object-type arrays issue from https://github.com/scikit-learn/scikit-learn/issues/4889 The code ```python import joblib import os import numpy as np from gzip import GzipFile from io import BytesIO from urllib2 import urlopen from os.path import join from sklearn.datasets impor...
diff --git a/joblib/numpy_pickle.py b/joblib/numpy_pickle.py index 6d727d6..f2d43eb 100644 --- a/joblib/numpy_pickle.py +++ b/joblib/numpy_pickle.py @@ -215,7 +215,7 @@ class NumpyPickler(Pickler): else: self.file = BytesIO() # Count the number of npy files that we have created: - ...
joblib__joblib-277
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/hashing.py:Hasher.hash" ], "edited_modules": [ "joblib/hashing.py:Hasher" ] }, "file": "joblib/hashing.py" } ]
joblib/joblib
484405ccea3cbcbd95e3cf241f15bf3eeb1aa8b6
Surprising behaviour when one of the cached function arguments is not picklable As reported by @arthurmensch. When one of the arguments is not picklable, the cached function result will only depend on the hash of all the arguments before the non picklable one. A simple snippet to show the problem: ```python import...
diff --git a/joblib/hashing.py b/joblib/hashing.py index f8a9ee6..93bc5e3 100644 --- a/joblib/hashing.py +++ b/joblib/hashing.py @@ -59,7 +59,8 @@ class Hasher(Pickler): try: self.dump(obj) except pickle.PicklingError as e: - warnings.warn('PicklingError while hashing %r: %r' %...
joblib__joblib-283
[ { "changes": { "added_entities": [ "joblib/func_inspect.py:getfullargspec", "joblib/func_inspect.py:_signature_str", "joblib/func_inspect.py:_function_called_str" ], "added_modules": [ "joblib/func_inspect.py:getfullargspec", "joblib/func_inspect.py:_sig...
joblib/joblib
c60d263fcc71ba9f4532010b732cde42e437039b
Replace deprecated usage of inspect.getargspec inspect.getargspec has been deprecated since 3.0 (in favor of inspect.getfullargspec until 3.2 and in favor of inspect.signature since 3.3) and will be removed in 3.6. It also creates visible DeprecationWarning in 3.5.
diff --git a/joblib/func_inspect.py b/joblib/func_inspect.py index cc5cbf6..3eee40b 100644 --- a/joblib/func_inspect.py +++ b/joblib/func_inspect.py @@ -11,11 +11,15 @@ import inspect import warnings import re import os - +import sys from ._compat import _basestring from .logger import pformat from ._memory_helpe...
joblib__joblib-297
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/my_exceptions.py:_mk_exception" ], "edited_modules": [ "joblib/my_exceptions.py:_mk_exception" ] }, "file": "joblib/my_exceptions.py" } ]
joblib/joblib
4a9c63d7984bc5e630722b8bf72c0c720a6bd5c0
Error propagating exceptions on-non subclassable types I was using joblib to run 8 optimizations using nlopt in parallel, and got this error: ``` --------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-1...
diff --git a/CHANGES.rst b/CHANGES.rst index e08fc89..66531c1 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -4,6 +4,11 @@ Latest changes Release 0.9.4 ------------- +Loïc Estève + + FIX for raising non inheritable exceptions in a Parallel call. See + https://github.com/joblib/joblib/issues/269 for more detail...
joblib__joblib-350
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/hashing.py:NumpyHasher.save" ], "edited_modules": [ "joblib/hashing.py:NumpyHasher" ] }, "file": "joblib/hashing.py" } ]
joblib/joblib
6393c7ee293980963541384dc9573e09116f4734
Regression: joblib.hash fails on 0d array ```python import numpy as np import joblib arr = np.array(0) joblib.hash(arr) ``` Works with joblib 0.9.4 and fails on master with the following error: ``` --------------------------------------------------------------------------- ValueError ...
diff --git a/joblib/hashing.py b/joblib/hashing.py index a6e5337..ced817b 100644 --- a/joblib/hashing.py +++ b/joblib/hashing.py @@ -189,7 +189,11 @@ class NumpyHasher(Hasher): if isinstance(obj, self.np.ndarray) and not obj.dtype.hasobject: # Compute a hash of the object # The update...
joblib__joblib-370
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/numpy_pickle.py:NumpyPickler.save" ], "edited_modules": [ "joblib/numpy_pickle.py:NumpyPickler" ] }, "file": "joblib/numpy_pickle.py" } ]
joblib/joblib
40341615cc2600675ce7457d9128fb030f6f89fa
load fails when dump use pickle.HIGHEST_PROTOCOL in Python 3 in master branch a96878e (version 0.10.0.dev0), the following code gives `KeyError` ```py import pickle import numpy as np import joblib a = np.zeros((1, 235), np.uint32) joblib.dump(a, 'tmp.jl', protocol=pickle.HIGHEST_PROTOCOL) joblib.load('tmp.j...
diff --git a/joblib/numpy_pickle.py b/joblib/numpy_pickle.py index 0cb616d..f029582 100644 --- a/joblib/numpy_pickle.py +++ b/joblib/numpy_pickle.py @@ -265,6 +265,14 @@ class NumpyPickler(Pickler): wrapper = self._create_array_wrapper(obj) Pickler.save(self, wrapper) + # A framer...
joblib__joblib-444
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/format_stack.py:_fixed_getframes", "joblib/format_stack.py:format_outer_frames" ], "edited_modules": [ "joblib/format_stack.py:_fixed_getframes", "joblib/forma...
joblib/joblib
aab21b654e853616b31c6e50255b2dcf47af5818
Wrong line pointed to in subprocess traceback test.py ```py from test_module import exception_on_even from joblib import Parallel, delayed if __name__ == '__main__': Parallel(n_jobs=2)(delayed(exception_on_even)(x) for x in [1, 2, 3]) ``` test_module.py ```py def exception_on_even(x): if x % 2 =...
diff --git a/joblib/format_stack.py b/joblib/format_stack.py index 3f3d106..4be93c1 100644 --- a/joblib/format_stack.py +++ b/joblib/format_stack.py @@ -135,15 +135,10 @@ def _fixed_getframes(etb, context=1, tb_offset=0): aux = traceback.extract_tb(etb) assert len(records) == len(aux) for i, (file, lnum,...
joblib__joblib-565
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/_memmapping_reducer.py:ArrayMemmapReducer.__call__" ], "edited_modules": [ "joblib/_memmapping_reducer.py:ArrayMemmapReducer" ] }, "file": "joblib/_memmapping_re...
joblib/joblib
2f85cc02f806943119a63ed0ceb4331010af242b
Writable output numpy arrays hashed to the same memmap I'm using `Parallel` to run jobs that all write to (large) output numpy arrays. I allocate these in advance (as zeros), then pass into the functions that are executing in parallel to be populated. In my case, these are distinct arrays of zeros of the same shape ...
diff --git a/CHANGES.rst b/CHANGES.rst index 278586b..ffc1c0c 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -4,6 +4,11 @@ Latest changes Development ----------- +Elizabeth Sander + Prevent numpy arrays with the same shape and data from hashing to + the same memmap, to prevent jobs with preallocated arrays fro...
joblib__joblib-639
[ { "changes": { "added_entities": [ "joblib/memory.py:Memory.cachedir" ], "added_modules": null, "edited_entities": [ "joblib/memory.py:Memory.__init__" ], "edited_modules": [ "joblib/memory.py:Memory" ] }, "file": "joblib/memory.py" } ]
joblib/joblib
d3e478f2822dde4181927b9efb6064cf00b92996
Memory object does not have a cachedir attribute in master Seems like an oversight from #397. The doc says that cachedir is deprecated but actually it is not set: https://github.com/joblib/joblib/blob/a0e1f69d2be31e9e6be1f5e346988bc04df7ff75/joblib/memory.py#L778-L783 It'd be a good idea to double-check that other ...
diff --git a/joblib/memory.py b/joblib/memory.py index 0f005dd..18b20f5 100644 --- a/joblib/memory.py +++ b/joblib/memory.py @@ -767,7 +767,7 @@ class Memory(Logger): The path of the base directory to use as a data store or None. If None is given, no caching is done and ...
joblib__joblib-708
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "joblib/externals/loky/__init__.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "jo...
joblib/joblib
bb027ab7dfd01ce618c04a9bbac12f7fa1fe2857
Regression in 0.12: different exception type than PicklingError when arguments of Parallel can not be pickled Moved from https://github.com/joblib/joblib/issues/706#issuecomment-400189831. Probably because of the switch from pickle to cloudpickle. ```py import numpy as np import pymc3 as pm rng = np.random.Ra...
diff --git a/joblib/externals/loky/__init__.py b/joblib/externals/loky/__init__.py index 0935619..332adfe 100644 --- a/joblib/externals/loky/__init__.py +++ b/joblib/externals/loky/__init__.py @@ -9,4 +9,4 @@ from .process_executor import BrokenProcessPool # noqa: F401 from .backend.context import cpu_count # noqa...
joblib__joblib-716
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "joblib/__init__.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/func_inspe...
joblib/joblib
6a2f9062dc01e1df013afb3886ffbaa266325764
v0.12: 'MemorizedResult' object has no attribute 'argument_hash' I our test suite I was checking that caching occurred properly by checking that a ``MemorizedResult`` instance would have the same hash after two calls to ``call_and_shelve``. Now the ``argument_hash`` attr is gone, and I replaced ``argument_hash`` wit...
diff --git a/CHANGES.rst b/CHANGES.rst index cb3bf00..3449861 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,6 +1,19 @@ Latest changes =============== +Release 0.12.1 +-------------- + +Thomas Moreau + + Make sure that any exception triggered when serializing jobs in the queue + will be wrapped as a Picklin...
joblib__joblib-746
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "examples/compressors_comparison.py" }, { "changes": { "added_entities": [ "joblib/memory.py:MemorizedResult.__getstate__", "jobl...
joblib/joblib
6ce40a7c1efb2d577b0899e34cf9b787a1971d41
Memory.__reduce__ is broken since cachedir deprecation Memory can't be pickled/unpickled. It defines `__reduce__` to exclude a timestamp from the pickle. But `__reduce__` includes: ``` return (self.__class__, (location, self.backend, self.mmap_mode, compress, self._ve...
diff --git a/CHANGES.rst b/CHANGES.rst index 35f50e2..b048c67 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,13 +1,17 @@ Latest changes =============== -Release 0.12.3 --------------- +master +------ Alexandre Abadie Fix MemorizedResult not picklable (#747). +Loïc Estève + + Fix Memory, MemorizedFu...
joblib__joblib-750
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/func_inspect.py:filter_args" ], "edited_modules": [ "joblib/func_inspect.py:filter_args" ] }, "file": "joblib/func_inspect.py" } ]
joblib/joblib
c492cf3e475bf0df73aa5f589af6bd61cbe8df26
Caching breaks when new (uncached) args are treated as kwargs. Simple fix addressed with PR: https://github.com/joblib/joblib/pull/750
diff --git a/CHANGES.rst b/CHANGES.rst index b048c67..77813d2 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -13,6 +13,12 @@ Loïc Estève Fix Memory, MemorizedFunc and MemorizedResult round-trip pickling + unpickling (#746). +James Collins + + Fixed a regression in Memory when positional arguments are call...
joblib__joblib-752
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/memory.py:MemorizedResult.__init__" ], "edited_modules": [ "joblib/memory.py:MemorizedResult" ] }, "file": "joblib/memory.py" } ]
joblib/joblib
74c357ade50588037cecb6bdceb33fa3f48a3caf
pickling breaks between joblib version 0.11 and 0.12.2 For my script below, will someone please tell me why the result of call_and_shelve() can be pickled in version 0.11, but not in version 0.12.2? Or tell me what I am doing wrong, or if this is a bug... Thanks. ## I have this little script ```python from job...
diff --git a/CHANGES.rst b/CHANGES.rst index 6d01fa4..35f50e2 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,6 +1,14 @@ Latest changes =============== +Release 0.12.3 +-------------- + +Alexandre Abadie + + Fix MemorizedResult not picklable (#747). + + Release 0.12.2 -------------- diff --git a/joblib/memo...
joblib__joblib-765
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/_store_backends.py:StoreBackendMixin.__repr__" ], "edited_modules": [ "joblib/_store_backends.py:StoreBackendBase", "joblib/_store_backends.py:StoreBackendMixin" ...
joblib/joblib
f64e1b8cf286c02d2782c6dd5bf7a42e0518c51d
FileSystemStoreBackend.__repr__ should not return a string Something that tripped me up when working on https://github.com/joblib/joblib/pull/746, is that `FileSystemStoreBackend.__repr__` makes it look like a string. I could not find a good reason for this. Do you remember something about this @aabadie? Here is a s...
diff --git a/README.rst b/README.rst index 472a5fd..1ed63ef 100644 --- a/README.rst +++ b/README.rst @@ -58,6 +58,8 @@ Dependencies - Joblib has an optional dependency on `python-lz4 <https://pypi.python.org/pypi/lz4>`_ as a faster alternative to zlib and gzip for compressed serialization. +- Joblib has an optio...
joblib__joblib-817
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/memory.py:_store_backend_factory" ], "edited_modules": [ "joblib/memory.py:_store_backend_factory" ] }, "file": "joblib/memory.py" } ]
joblib/joblib
7be116a5a6bd4b304c1b0be66bc44fc84cfb0267
Silent failure if Path("...") is passed - BUG The following code shows a silent failure when a Path is passed. ``` from pathlib import Path from joblib import Memory m1 = Memory(Path('../joblib-cache'), verbose=True) m2 = Memory('../joblib-cache', verbose=True) @m1.cache def foo1(x): return x @m2.c...
diff --git a/CHANGES.rst b/CHANGES.rst index 4095118..63054fd 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,6 +1,15 @@ Latest changes =============== +Release 0.13.1 +-------------- + +Pierre Glaser + + Memory now accepts pathlib.Path objects as ``location`` parameter. + Also, a warning is raised if the retu...
joblib__joblib-934
[ { "changes": { "added_entities": [ "joblib/_parallel_backends.py:ParallelBackendBase.in_main_thread" ], "added_modules": null, "edited_entities": [ "joblib/_parallel_backends.py:ParallelBackendBase.__init__", "joblib/_parallel_backends.py:AutoBatchingMixin.__init_...
joblib/joblib
fd585ce36faba338fa1c71949cf29ed8e8f5ea19
not possible to use joblib as background thread when I try to start parallel loop as background thread I'm getting /usr/anaconda3/lib/python3.7/site-packages/joblib/parallel.py:673: UserWarning: Loky-backed parallel loops cannot be nested below threads, setting n_jobs=1 **self._backend_args) [Parallel(n_jobs=8)...
diff --git a/CHANGES.rst b/CHANGES.rst index 4fbd41e..0d12cbb 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -4,6 +4,9 @@ Latest changes Release 0.14.0 -------------- +- Add official support for Python 3.8: fixed protocol number in `Hasher` + and updated tests. + - Warn users that they should never use `joblib.loa...
joblib__joblib-985
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "joblib/parallel.py:effective_n_jobs" ], "edited_modules": [ "joblib/parallel.py:effective_n_jobs" ] }, "file": "joblib/parallel.py" } ]
joblib/joblib
12c2b2bae071a2203edf181bad3e6059cde53463
Wrong number of workers reported by effective_n_jobs I want to highlight something which looks weird to me (not sure yet if this is a bug). I made a snippet which is a pattern that we use in scikit-learn. ```python from joblib import Parallel, delayed, effective_n_jobs, parallel_backend from joblib.parallel import...
diff --git a/CHANGES.rst b/CHANGES.rst index cc0f542..fdfe8d2 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,6 +1,13 @@ Latest changes ============== +Release 0.14.2 +-------------- + +- Fix the number of jobs reported by ``effective_n_jobs`` when ``n_jobs=None`` + called in a parallel backend context. + https:...
joblib__loky-234
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "examples/reuse_executor.py:func_async" ], "edited_modules": [ "examples/reuse_executor.py:func_async" ] }, "file": "examples/reuse_executor.py" }, { "changes": ...
joblib/loky
3999420bc423563edfae5324ce4cd237d6c9639e
Initializer example fails The example from the [Advanced Executor Setup](https://loky.readthedocs.io/en/stable/auto_examples/reuseable_executor.html#sphx-glr-auto-examples-reuseable-executor-py) docs fails with loky 2.5.1. Output: ``` $ python loky_init.py [LokyProcess-1] init Traceback (most recent call last): ...
diff --git a/CHANGES.md b/CHANGES.md index 39ba8a9..3515946 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,13 @@ -### 2.6.1 - XXXX-YY-ZZ - Bugfix release - +### 2.7.0 - XXXX-YY-ZZ + +- The ``resource_tracker`` now comes with built-in support for tracking files + in all OSes. In addition, Python processes can now...
joblib__loky-390
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "loky/backend/context.py:cpu_count" ], "edited_modules": [ "loky/backend/context.py:cpu_count" ] }, "file": "loky/backend/context.py" }, { "changes": { "ad...
joblib/loky
eb6b8441133263d869116c067725270a6015bb4f
loky is broken on windows with max_workers>62 As reported in scikit-learn/scikit-learn#12263, `loky` hangs when using many workers on windows. The following traceback is given: ```python-traceback Exception in thread QueueManagerThread: File "<<elided>>\lib\site-packages\sklearn\externals\joblib\externals\loky...
diff --git a/.azure_pipeline.yml b/.azure_pipeline.yml index 47178e4..1e2648c 100644 --- a/.azure_pipeline.yml +++ b/.azure_pipeline.yml @@ -2,7 +2,7 @@ jobs: - job: linting displayName: Linting pool: - vmImage: ubuntu-20.04 + vmImage: ubuntu-latest steps: - task: UsePythonVersion@0 inputs: ...
joblib__loky-429
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "continuous_integration/install_coverage_subprocess_pth.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_...
joblib/loky
36701db9ed70485809bf0114a1414a88858a59de
DeprecationWarning: This process (pid=...) is multi-threaded, use of fork() may lead to deadlocks in the child. Here is a pure-loky reproducer for the issue reported on the joblib repo under https://github.com/joblib/joblib/issues/1650: ```python from _testcapi import _spawn_pthread_waiter, _end_spawned_pthread from m...
diff --git a/CHANGES.md b/CHANGES.md index 6c46399..6e46295 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,11 @@ ### 3.5.0 - in development +- Avoid raising `DeprecationWarning` related to `os.fork` when running in a + natively multi-threaded process. (#429). + +- Fix a crash when calling commands that access ...
jobovy__galpy-712
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "galpy/actionAngle/actionAngleStaeckel.py:actionAngleStaeckel._evaluate" ], "edited_modules": [ "galpy/actionAngle/actionAngleStaeckel.py:actionAngleStaeckel" ] }, "file...
jobovy/galpy
6a745879491a6fb0fe3bf9ed3f5d3036abf8c6bc
Handle unbound orbits in actionAngle-related functions in new Orbit class In the new Orbit class, pure Python actionAngle-related functions fail for unbound orbits and cause the entire function to fail when Orbit contains multiple objects. Need to catch the unbound orbits without raising an error (see also #371).
diff --git a/galpy/actionAngle/actionAngleStaeckel.py b/galpy/actionAngle/actionAngleStaeckel.py index d1235644..a3732d6c 100644 --- a/galpy/actionAngle/actionAngleStaeckel.py +++ b/galpy/actionAngle/actionAngleStaeckel.py @@ -214,7 +214,13 @@ class actionAngleStaeckel(actionAngle): else: ...
joergbuchwald__ogs6py-44
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "examples/example_THM.py" }, { "changes": { "added_entities": [ "ogs6py/classes/media.py:Media._generate_generic_property", "ogs6...
joergbuchwald/ogs6py
91fd62ff3b856aac6c2f98724199acded0183e2f
extending add_property for new MPL models Hi Joerg, we want to use the following MPL model with OGS6PY. But it is not considered yet. ```python model.media.add_property(medium_id="0", name="permeability", ...
diff --git a/examples/example_THM.py b/examples/example_THM.py index 6430ec3..632afcc 100644 --- a/examples/example_THM.py +++ b/examples/example_THM.py @@ -39,9 +39,32 @@ model.media.add_property(medium_id="0", name="density", type="Linear", ...
joerick__pyinstrument-271
[ { "changes": { "added_entities": [ "pyinstrument/__main__.py:ValueWithRemainingArgs.__init__" ], "added_modules": [ "pyinstrument/__main__.py:ValueWithRemainingArgs" ], "edited_entities": [ "pyinstrument/__main__.py:main" ], "edited_modules": [ ...
joerick/pyinstrument
7b80667760e8a1ca49c0220bc9ed07e6ad059f42
Support `-c` input mode I often want to run pyinstrument on snippets, e.g. just an import or one function call. It would be nice if I could write `pyinstrument -c "import slow_thing"` to profile, instead of having to write a dummy file containing `import slow_thing`.
diff --git a/pyinstrument/__main__.py b/pyinstrument/__main__.py index 4a60fd0..e63df3d 100644 --- a/pyinstrument/__main__.py +++ b/pyinstrument/__main__.py @@ -34,13 +34,25 @@ def main(): parser = optparse.OptionParser(usage=usage, version=version_string) parser.allow_interspersed_args = False - def das...
joerick__pyinstrument-287
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "pyinstrument/renderers/pstatsrenderer.py:PstatsRenderer.render_frame" ], "edited_modules": [ "pyinstrument/renderers/pstatsrenderer.py:PstatsRenderer" ] }, "file": "pyi...
joerick/pyinstrument
f4294a9384281d38927fe117ea371f059a1541d9
pstats renderer total time The sum of `tottime` for all functions from the pstats output correctly matches the total time displayed in the header of `print_stats()` when using the `pstats` module. However, this does not match the duration shown in the HTML output (it is about twice longer). Is this expected? How much s...
diff --git a/pyinstrument/renderers/pstatsrenderer.py b/pyinstrument/renderers/pstatsrenderer.py index 2bb8157..35428b3 100644 --- a/pyinstrument/renderers/pstatsrenderer.py +++ b/pyinstrument/renderers/pstatsrenderer.py @@ -71,7 +71,7 @@ class PstatsRenderer(FrameRenderer): stats[key] = (call_time, number_cal...
john-kurkowski__tldextract-253
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "tldextract/cache.py:DiskCache.__init__", "tldextract/cache.py:DiskCache.get", "tldextract/cache.py:DiskCache.set", "tldextract/cache.py:DiskCache.clear", "tldextract/cach...
john-kurkowski/tldextract
6e2c0e066e4ab60c9dc14608b7a240a818d1eb52
Incorrectly parsing unicode dot Domain angelinablog。com.de is parsed as: - Domain: angelinablog。com - Suffix: de It should be parsed as: - angelinablog - com - de
diff --git a/CHANGELOG.md b/CHANGELOG.md index 22a642b..57c6cb8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,22 @@ After upgrading, update your cache file by deleting it or via `tldextract --update`. +## 3.2.1 (2022-04-11) + +* Bugfixes + * Fix incorrect namespace used for caching function returns ([#25...
john-kurkowski__tldextract-258
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "tldextract/cache.py:DiskCache.run_and_cache" ], "edited_modules": [ "tldextract/cache.py:DiskCache" ] }, "file": "tldextract/cache.py" } ]
john-kurkowski/tldextract
86c82c3a9e3e9a2980a39ce8b77e1ad0bdebcc12
"update" caches public suffix list to wrong directory Hi! First off, I love `tldextract`, thanks for building it! The way we use `tldextract` is slightly special, but used to be fully supported by the public API. Our docker containers don't have internet access, so when we build them, we cache the latest public s...
diff --git a/tldextract/cache.py b/tldextract/cache.py index b714e77..fbd02c9 100644 --- a/tldextract/cache.py +++ b/tldextract/cache.py @@ -7,7 +7,7 @@ import os import os.path import sys from hashlib import md5 -from typing import Callable, Dict, Hashable, List, Optional, TypeVar, Union +from typing import Callabl...
john-kurkowski__tldextract-289
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "tldextract/tldextract.py:_PublicSuffixListTLDExtractor.suffix_index" ], "edited_modules": [ "tldextract/tldextract.py:_PublicSuffixListTLDExtractor" ] }, "file": "tldex...
john-kurkowski/tldextract
4b358ce274cfd2e3b7fb67933433f5a412e7939b
Suffix detection broken for private `uk.com` suffix in version 3.4.3 I _think_ the trie suffix detection in #285 in version 3.4.3 might have broken looking up `uk.com` private suffix (which is included in the bundled snapshot) https://github.com/john-kurkowski/tldextract/blob/6f45fed6c56f377e8a9a77ce43c50712281940d8/t...
diff --git a/tldextract/tldextract.py b/tldextract/tldextract.py index ea20f02..1303dd8 100644 --- a/tldextract/tldextract.py +++ b/tldextract/tldextract.py @@ -411,6 +411,9 @@ class _PublicSuffixListTLDExtractor: Returns len(spl) if no suffix is found. """ + if include_psl_private_domains is...
john-kurkowski__tldextract-292
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "tldextract/remote.py:looks_like_ip" ], "edited_modules": [ "tldextract/remote.py:looks_like_ip" ] }, "file": "tldextract/remote.py" }, { "changes": { "add...
john-kurkowski/tldextract
a871d077f6f8fa27d1efadbfa253d5e4417eee32
IPv4 with non-ASCII dots Should IPv4 addresses with non-ASCII dots be accepted? Example: `http://127\u30020\uff610\u002e1/foo/bar`
diff --git a/tldextract/remote.py b/tldextract/remote.py index 60b8629..ea11b46 100644 --- a/tldextract/remote.py +++ b/tldextract/remote.py @@ -1,9 +1,17 @@ """tldextract helpers for testing and fetching remote resources.""" +from __future__ import annotations + import re -import socket +from collections.abc impor...
john-kurkowski__tldextract-298
[ { "changes": { "added_entities": [ "tldextract/remote.py:looks_like_ipv6" ], "added_modules": [ "tldextract/remote.py:looks_like_ipv6" ], "edited_entities": [ "tldextract/remote.py:lenient_netloc" ], "edited_modules": [ "tldextract/remote...
john-kurkowski/tldextract
570060d9aeba05e0a71c6d4f2262e497e8c11eb8
IPv6 addresses are not handled For URLs using IPv4 addresses, the host address gets extracted correctly using `.domain` but `.fqdn` gives the empty string: ```python >>> tldextract.extract("https://127.0.0.1:1234/foobar").domain '127.0.0.1' >>> tldextract.extract("https://127.0.0.1:1234/foobar").fqdn '' ``` For ...
diff --git a/tldextract/remote.py b/tldextract/remote.py index 3bbf4b0..c710fb1 100644 --- a/tldextract/remote.py +++ b/tldextract/remote.py @@ -4,11 +4,12 @@ from __future__ import annotations import re from collections.abc import Callable +from ipaddress import AddressValueError, IPv6Address from urllib.parse im...
johnnoone__json-spec-23
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/jsonspec/validators/draft04.py:Draft04Validator.validate_dependencies", "src/jsonspec/validators/draft04.py:Draft04Validator.validate_properties", "src/jsonspec/validators/draft04.py...
johnnoone/json-spec
5ff563d9450d33531b0a45a570d57756b355d618
Add details to Missing Property error Please consider the patch below. In reporting a missing property during validation, this include the name of the property in the ValidationError's reason. (Sorry for the inline code. I haven't figured out how to properly submit a patch. The github's issues editor won't let me att...
diff --git a/src/jsonspec/validators/draft04.py b/src/jsonspec/validators/draft04.py index adb6ee9..6d2fc9c 100644 --- a/src/jsonspec/validators/draft04.py +++ b/src/jsonspec/validators/draft04.py @@ -379,8 +379,8 @@ class Draft04Validator(Validator): for key, dependencies in self.attrs.get('dependencies', {})...
johnpaulett__python-hl7-15
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "hl7/containers.py:Message.escape" ], "edited_modules": [ "hl7/containers.py:Message" ] }, "file": "hl7/containers.py" } ]
johnpaulett/python-hl7
253b2071aa376e7f37854b30e38fc6a0ab5c203d
Buggy ASCII escaping If you escape a string containing any ASCII characters, this will lead to a `TypeError`: ``` python import hl7 msg = hl7.Message(separator='\r', separators='\r|^~\&') msg.escape('asdf') ``` ``` plain Traceback (most recent call last): File "hl7/__init__.py", line 630, in escape ...
diff --git a/hl7/containers.py b/hl7/containers.py index 231e3b1..a57f570 100644 --- a/hl7/containers.py +++ b/hl7/containers.py @@ -319,7 +319,7 @@ class Message(Container): elif c in DEFAULT_MAP: rv.append(esc + DEFAULT_MAP[c] + esc) elif ord(c) >= 0x20 and ord(c) <= 0x7E: -...
johnsyweb__python_sparse_list-14
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "sparse_list.py:SparseList.__delitem__", "sparse_list.py:SparseList.pop" ], "edited_modules": [ "sparse_list.py:SparseList" ] }, "file": "sparse_list.py" }, ...
johnsyweb/python_sparse_list
a82747eb58797e0c249431ec794059bd7fb8f850
Invalid implementation of `del my_list[a:b]` Deleting slices does not behave like Python's lists: ```python >>> standard_list = [1,2,3] >>> del standard_list[:2] >>> standard_list [3] >>> sparse_list = SparseList([1,2,3]) >>> del sparse_list[:2] >>> sparse_list [None, None, 3] ```
diff --git a/.travis.yml b/.travis.yml index 1df6b51..08d9ac6 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,11 +1,10 @@ language: python python: - 2.7 - - 3.3 - 3.4 - 3.5 - 3.6 - - 3.7-dev + - 3.7 - nightly - pypy install: pip install -r requirements.txt diff --git a/sparse_list.py b/sparse_l...
johnsyweb__python_sparse_list-17
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "sparse_list.py:SparseList.__delitem__" ], "edited_modules": [ "sparse_list.py:SparseList" ] }, "file": "sparse_list.py" } ]
johnsyweb/python_sparse_list
21a04541305b929dd8203c491c5d98d27f454e50
Deleting an empty slice from a sparse list fails ``` sl = sparse_list.SparseList(xrange(5), None) del sl[3:3] ``` throws `IndexError: range object index out of range` whereas it should just leave the list untouched.
diff --git a/sparse_list.py b/sparse_list.py index c7f6b56..e759c96 100644 --- a/sparse_list.py +++ b/sparse_list.py @@ -79,6 +79,9 @@ class SparseList(object): else: indices = (item, ) + if not indices: + return + offset = 0 for k in sorted(self.elements.ke...
johnthagen__cppcheck-junit-6
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "cppcheck_junit.py:generate_test_suite", "cppcheck_junit.py:generate_single_success_test_suite" ], "edited_modules": [ "cppcheck_junit.py:generate_test_suite", "cppche...
johnthagen/cppcheck-junit
62cf03e4eee1ce80cccc1a9557417fb4b7f436f2
Failing tests not showing up on bamboo. I have added the following steps to my bamboo plan - `cppcheck ... 2> cppcheck-result.xml` - `cppcheck_junit cppcheck-result.xml cppcheck-junit.xml` - JUnit Parser I can see a passing test on the dashboard if cppcheck reports no errrors. If there are errors, however, I ca...
diff --git a/cppcheck_junit.py b/cppcheck_junit.py index 87be9a5..9adfd7e 100755 --- a/cppcheck_junit.py +++ b/cppcheck_junit.py @@ -123,8 +123,9 @@ def generate_test_suite(errors): for file_name, errors in errors.items(): test_case = ElementTree.SubElement(test_suite, ...
joke2k__django-environ-163
[ { "changes": { "added_entities": [ "environ/environ.py:Env.bytes" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "environ/environ.py:Env" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
628ed38e540ec9a6f3aff622953948e54f14a76d
Casting to bytes Add support to cast env vars to bytes.
diff --git a/environ/environ.py b/environ/environ.py index 1365a29..91e93af 100644 --- a/environ/environ.py +++ b/environ/environ.py @@ -146,6 +146,12 @@ class Env(object): """ return self.get_value(var, cast=str, default=default) + def bytes(self, var, default=NOTSET, encoding='utf8'): + ...
joke2k__django-environ-174
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "environ/environ.py:Env.db_url_config" ], "edited_modules": [ "environ/environ.py:Env" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
99d23c94769710009bf6630ac981e5ed0cdc461c
Database url.scheme only works for built-in schemes (backends) I haven't find any issue related to this topic, so sorry in advance if it is something that has been already discussed. According to this code inside ```Env.db_url_config()```: ``` python class Env(object): # [...] @classmethod def db_url...
diff --git a/environ/environ.py b/environ/environ.py index 9a9f906..a1febab 100644 --- a/environ/environ.py +++ b/environ/environ.py @@ -422,8 +422,11 @@ class Env(object): if engine: config['ENGINE'] = engine - if url.scheme in Env.DB_SCHEMES: - config['ENGINE'] = Env.DB_SCHEM...
joke2k__django-environ-211
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": [ "environ/environ.py:Env" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
c2620021614557abe197578f99deeef42af3e082
rediss URLs are not supported If a cache URL scheme is `rediss://`, which is needed in order to connect over TLS, then a KeyError is thrown.
diff --git a/README.rst b/README.rst index 871a822..d71f87c 100644 --- a/README.rst +++ b/README.rst @@ -139,7 +139,7 @@ Supported types - Memory: locmemcache:// - Memcached: memcache:// - Python memory: pymemcache:// - - Redis: rediscache:// + - Redis: rediscache://, redis://, or rediss:// -...
joke2k__django-environ-322
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": [ "environ/environ.py:Env" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
31c8f98343bd871d51c5bf6d73c3573c6cbde72e
Add elasticsearch7 to search scheme
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 11ecc37..b221941 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -13,6 +13,9 @@ Added (`#160 <https://github.com/joke2k/django-environ/issues/160>`_) - Added Elasticsearch5 to search scheme (`#297 <https://github.com/joke2k/django-environ/pull/297>`_) + -...
joke2k__django-environ-325
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "environ/environ.py:_cast" ], "edited_modules": [ "environ/environ.py:_cast" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
192b813fc97fd395cb432eba5d0064a73d4ab9f0
Error with CACHE_URL passwords that end with '=' This is somewhat similar to #194. A cache password that ends with the `=` character raises an error when calling `env.cache`. Even escaping it (`%3D`) will not work. It looks like the `cast` method works by trying to just convert to a value and if that fails with a `V...
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 0e4bd83..335a267 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -17,12 +17,13 @@ Added `#314 <https://github.com/joke2k/django-environ/pull/314>`_. - Provided ability to use ``bytes`` or ``str`` as a default value for ``Env.bytes()``. - Fixed +++++ -- Fixed li...
joke2k__django-environ-329
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "environ/environ.py:Env.read_env" ], "edited_modules": [ "environ/environ.py:Env" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
cbbd6d6d454352e4ff712947502466a84dd8faef
Won't update environ key if it already set imagine a case when we need to update some of the production settings in `production.py` base on `base.py`. ```py from .base import * environ.Env.read_env(env_file="/etc/<app>/.env") DATABASES = { # read os.environ['DATABASE_URL'] and raises ImproperlyConfigured...
diff --git a/docs/tips.rst b/docs/tips.rst index ab3161d..cff0d86 100644 --- a/docs/tips.rst +++ b/docs/tips.rst @@ -195,10 +195,13 @@ Values that being with a ``$`` may be interpolated. Pass ``interpolate=True`` to FOO +Reading env files +================= + .. _multiple-env-files-label: Multiple env files...
joke2k__django-environ-332
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "environ/environ.py:Env.get_value" ], "edited_modules": [ "environ/environ.py:Env" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
972b10392d42bf3688829c129b1cca6cfb558aa5
Support for SOME_VAR=(int, None)? Is there a way to tell environ that `SOME_VAR=` in an env file is fine, and should lead to SOME_VAR being assigned the pythonic `None` when using the `SOME_VAR=(int, None)` format?
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 47d9673..c46d3ff 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -16,6 +16,8 @@ Added - Added option to override existing variables with ``read_env`` `#103 <https://github.com/joke2k/django-environ/issues/103>`_, `#249 <https://github.com/joke2k/django-environ/i...
joke2k__django-environ-358
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "environ/environ.py:_cast_urlstr" ], "edited_modules": [ "environ/environ.py:_cast_urlstr" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
509cf7737363a56e4464962dbae4ab72b801c7b3
Fix _cast_urlstr to use unquote vs unquote_plus Currently, `Env.db_url_config` uses `_cast_urlstr` to url unquote the username and password from database connection URIs. The underlying problem occurs when you try to use a `+` in your postgres password. `_cast_urlstr` uses `unquote_plus`, ([introduced in this PR he...
diff --git a/environ/environ.py b/environ/environ.py index acdfb15..0123c02 100644 --- a/environ/environ.py +++ b/environ/environ.py @@ -21,6 +21,7 @@ import warnings from urllib.parse import ( parse_qs, ParseResult, + unquote, unquote_plus, urlparse, urlunparse, @@ -61,7 +62,7 @@ def _cast...
joke2k__django-environ-361
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "environ/environ.py:Env.get_value" ], "edited_modules": [ "environ/environ.py:Env" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
509cf7737363a56e4464962dbae4ab72b801c7b3
Attach cause to ImproperlyConfigured exception raised for missing environment variables I'd like to propose to add the original exception as the cause of the `ImproperlyConfigured` exception that's raised when an environment variable is missing using `raise ... from ...`: ```py try: value = sel...
diff --git a/environ/environ.py b/environ/environ.py index acdfb15..5eb6b78 100644 --- a/environ/environ.py +++ b/environ/environ.py @@ -365,10 +365,10 @@ class Env: try: value = self.ENVIRON[var] - except KeyError: + except KeyError as exc: if default is self.NOTSET: ...
joke2k__django-environ-419
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "environ/environ.py:Env.__init__", "environ/environ.py:Env._get_value" ], "edited_modules": [ "environ/environ.py:Env" ] }, "file": "environ/environ.py" } ]
joke2k/django-environ
2750dd54e0e4b1b591a31409cfb1dc16a82b958d
`interpolate` flag functionality is not implemented I did `SECRET_KEY = env('DJANGO_SECRET_KEY')` and got the error: ``` django.core.exceptions.ImproperlyConfigured: Set the a&d3*0k#skh)!5o)$))zz9&%hr@-akid5zh--05ei790+wn0$r environment variable ``` This is becuase my `DJANGO_SECRET_KEY` starts with the dollar ...
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index aa7b3ff..8e181b1 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -17,6 +17,8 @@ Added `#468 <https://github.com/joke2k/django-environ/pull/468>`_. - Added capability to handle comments after #, after quoted values, like ``KEY= 'part1 # part2' # comment`` `#475 <...
joke2k__django-environ-450
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "environ/compat.py:choose_rediscache_driver" ], "edited_modules": [ "environ/compat.py:choose_rediscache_driver" ] }, "file": "environ/compat.py" } ]
joke2k/django-environ
bec18530b41745f4ecf1f0a39d690c1e3c41d4a4
0.10.0 regression - cache client_class no longer supported. Prior to 0.10.0 this CACHE_URL would function as expected. `redis://redis:6379/0?client_class=django_redis.client.DefaultClient`. This uses the django_redis package over the built-in Django redis support. This is desirable for a number of reasons, one being ...
diff --git a/environ/compat.py b/environ/compat.py index 0cec1e5..b4ffee4 100644 --- a/environ/compat.py +++ b/environ/compat.py @@ -10,7 +10,6 @@ from pkgutil import find_loader - if find_loader('simplejson'): import simplejson as json else: @@ -28,14 +27,17 @@ else: def choose_rediscache_driver(): ...