instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
jupyter__nbgrader-838 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nbgrader/apps/fetchapp.py:FetchApp.start"
],
"edited_modules": [
"nbgrader/apps/fetchapp.py:FetchApp"
]
},
"file": "nbgrader/apps/fetchapp.py"
}
] | jupyter/nbgrader | 7736f44b18dd8841bf8f5bca56720b58d59baf43 | Add the ability to fetch multiple assignment with one command
As suggested by @mikebolt in #433, adding the ability to fetch multiple assignments with one command would be a nice future enhancement.
> It would also be nice to be able to fetch multiple assignments with one command:
>
> nbgrader fetch --course data301a... | diff --git a/nbgrader/apps/fetchapp.py b/nbgrader/apps/fetchapp.py
index 2c923ff7..5cfc9f88 100644
--- a/nbgrader/apps/fetchapp.py
+++ b/nbgrader/apps/fetchapp.py
@@ -73,16 +73,26 @@ class FetchApp(NbGrader):
def start(self):
super(FetchApp, self).start()
- # set assignemnt and course
- if... |
jupyter__nbgrader-845 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nbgrader/__init__.py:_jupyter_nbextension_paths",
"nbgrader/__init__.py:_jupyter_server_extension_paths"
],
"edited_modules": [
"nbgrader/__init__.py:_jupyter_nbextension_pat... | jupyter/nbgrader | e2f288ce4a11d08db211e67b7c0d2f9ff0c5656a | Disable Assignment List extension on Windows
See https://github.com/conda-forge/nbgrader-feedstock/issues/12
@lgpage | diff --git a/nbgrader/__init__.py b/nbgrader/__init__.py
index 7e68cab9..e7ecd231 100644
--- a/nbgrader/__init__.py
+++ b/nbgrader/__init__.py
@@ -3,17 +3,12 @@ A system for assigning and grading notebooks.
"""
import os
+import sys
from ._version import version_info, __version__
def _jupyter_nbextension_path... |
jupyter__nbgrader-846 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nbgrader/nbgraderformat/v1.py:ValidatorV1._upgrade_v0_to_v1"
],
"edited_modules": [
"nbgrader/nbgraderformat/v1.py:ValidatorV1"
]
},
"file": "nbgrader/nbgraderformat/v1... | jupyter/nbgrader | e2f288ce4a11d08db211e67b7c0d2f9ff0c5656a | UI allows negative points
The UI should probably only allow points within [0-\infty] for graded cells. It currently allows negative points.
| diff --git a/nbgrader/docs/source/contributor_guide/metadata.rst b/nbgrader/docs/source/contributor_guide/metadata.rst
index d74f054d..4ede34a1 100644
--- a/nbgrader/docs/source/contributor_guide/metadata.rst
+++ b/nbgrader/docs/source/contributor_guide/metadata.rst
@@ -73,7 +73,8 @@ The metadata may contain the follow... |
jupyter__nbgrader-867 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nbgrader/converters/base.py:BaseConverter.start"
],
"edited_modules": [
"nbgrader/converters/base.py:BaseConverter"
]
},
"file": "nbgrader/converters/base.py"
},
{
... | jupyter/nbgrader | c647866318ccb67681d832afb8a0579d78fa6786 | Error generating assignment and managing students
Firstly, I apologize if this is not the proper place to report issues like this. I am exploring nbgrader, and have had some trouble getting it to work.
I have installed nbgrader on a local Jupyterhub installation and have been working through the example notebooks.
... | diff --git a/nbgrader/converters/base.py b/nbgrader/converters/base.py
index c4af98b2..5fabe801 100644
--- a/nbgrader/converters/base.py
+++ b/nbgrader/converters/base.py
@@ -66,7 +66,12 @@ class BaseConverter(LoggingConfigurable):
self.exporter = self.exporter_class(parent=self, config=self.config)
f... |
jupyter__nbgrader-873 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nbgrader/api.py:Gradebook.student_dicts"
],
"edited_modules": [
"nbgrader/api.py:Gradebook"
]
},
"file": "nbgrader/api.py"
}
] | jupyter/nbgrader | 9822e38532e0c5a31a26316a16d539d51324c424 | Error generating assignment and managing students
Firstly, I apologize if this is not the proper place to report issues like this. I am exploring nbgrader, and have had some trouble getting it to work.
I have installed nbgrader on a local Jupyterhub installation and have been working through the example notebooks.
... | diff --git a/nbgrader/api.py b/nbgrader/api.py
index cb9b552b..6c79aabc 100644
--- a/nbgrader/api.py
+++ b/nbgrader/api.py
@@ -2318,7 +2318,8 @@ class Gradebook(object):
A list of dictionaries, one per student
"""
- if len(self.assignments) > 0:
+ total_score, = self.db.query(func.... |
jupyter__nbgrader-888 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nbgrader/preprocessors/overwritekernelspec.py:OverwriteKernelspec.preprocess"
],
"edited_modules": [
"nbgrader/preprocessors/overwritekernelspec.py:OverwriteKernelspec"
]
}... | jupyter/nbgrader | 6a5a895fb1de74af4de84f55288421833a655976 | Tests failing due to kernelspec validation on autograding
See #880 and https://travis-ci.org/jupyter/nbgrader/builds/270643170 | diff --git a/nbgrader/preprocessors/overwritekernelspec.py b/nbgrader/preprocessors/overwritekernelspec.py
index cff743e3..f8995051 100644
--- a/nbgrader/preprocessors/overwritekernelspec.py
+++ b/nbgrader/preprocessors/overwritekernelspec.py
@@ -14,9 +14,17 @@ class OverwriteKernelspec(NbGraderPreprocessor):
... |
jupyter__nbgrader-895 | [
{
"changes": {
"added_entities": [
"nbgrader/apps/dbapp.py:DbGenericImportApp.db_update_method_name",
"nbgrader/apps/dbapp.py:DbGenericImportApp.table_class",
"nbgrader/apps/dbapp.py:DbGenericImportApp.primary_key_default",
"nbgrader/apps/dbapp.py:DbGenericImportApp.expecte... | jupyter/nbgrader | fc13b045cc085bb2a5355131b8e0f20dd7607884 | Not importing emails when Importing students from .csv
### Operating system
`Ubuntu 16.04`
### `nbgrader --version`
`nbgrader version 0.5.2`
### Expected behavior
I'm creating the students database from a `csv` file. My csv files has:
`id,last_name,first_name,email` so I expect when I do `nbgrader db st... | diff --git a/nbgrader/apps/dbapp.py b/nbgrader/apps/dbapp.py
index 8bab3443..ee9a543c 100644
--- a/nbgrader/apps/dbapp.py
+++ b/nbgrader/apps/dbapp.py
@@ -6,11 +6,11 @@ import os
import shutil
from textwrap import dedent
-from traitlets import default, Unicode, Bool
+from traitlets import default, Unicode, Bool, Li... |
jupyter__nbgrader-932 | [
{
"changes": {
"added_entities": [
"nbgrader/coursedir.py:CourseDirectory._validate_assignment_id"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"nbgrader/coursedir.py:CourseDirectory"
]
},
"file": "nbgrader/coursedir.py"
}
] | jupyter/nbgrader | 97909fa3e4f358aa3b79e2a079d8a8a595d51119 | Assignment names with a '+' character break autograding
I (perhaps foolishly) created an assignment with a '+' character in its name (the web interface did not complain). Now nbgrader will not autograde submitted assignments. From the log file, I gather that the + character is used as a separator between student id and... | diff --git a/nbgrader/coursedir.py b/nbgrader/coursedir.py
index 26207215..978afb3f 100644
--- a/nbgrader/coursedir.py
+++ b/nbgrader/coursedir.py
@@ -4,7 +4,7 @@ import re
from textwrap import dedent
from traitlets.config import LoggingConfigurable
-from traitlets import Unicode, List, default
+from traitlets impo... |
jupyter__nbgrader-947 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nbgrader/converters/autograde.py:Autograde.init_assignment"
],
"edited_modules": [
"nbgrader/converters/autograde.py:Autograde"
]
},
"file": "nbgrader/converters/autogr... | jupyter/nbgrader | 919c56a9782647a97bd03a0c9d6d0ac5633db0a3 | Have submitted notebooks import from local directory
I had students edit a python file and then submit it along with the notebooks. However, when I run the autograder, nbgrader imports the python file from my source directory instead of the submitted one. This, of course, leads to the test cells that test their impleme... | diff --git a/nbgrader/converters/autograde.py b/nbgrader/converters/autograde.py
index 62327f17..57c662ab 100644
--- a/nbgrader/converters/autograde.py
+++ b/nbgrader/converters/autograde.py
@@ -2,7 +2,7 @@ import os
import shutil
from textwrap import dedent
-from traitlets import Bool, List
+from traitlets import ... |
jupyter__nbgrader-954 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nbgrader/utils.py:find_all_files"
],
"edited_modules": [
"nbgrader/utils.py:find_all_files"
]
},
"file": "nbgrader/utils.py"
}
] | jupyter/nbgrader | bbc694e8ee4c1aa4eeaee0936491ff19b20bad60 | Unexpected behaviour of utils.find_all_files
<!--
Thanks for helping to improve nbgrader!
If you are submitting a bug report or looking for support, please use the below
template so we can efficiently solve the problem.
If you are requesting a new feature, feel free to remove irrelevant pieces of
the issue tem... | diff --git a/nbgrader/utils.py b/nbgrader/utils.py
index 55824f3f..55f440ab 100644
--- a/nbgrader/utils.py
+++ b/nbgrader/utils.py
@@ -194,8 +194,10 @@ def find_all_files(path, exclude=None):
"""Recursively finds all filenames rooted at `path`, optionally excluding
some based on filename globs."""
files ... |
jupyter__nbgrader-959 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "nbgrader/apps/assignapp.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_... | jupyter/nbgrader | 1c823a4410ef3abcdd1a9f50aab5a546c994e4e8 | Allow nbgrader apps to use -f and --force
Currently only --force is supported, which means you have to do:
```
nbgrader autograde ps1 --force
```
rather than
```
nbgrader autograde ps1 -f
```
Both should be supported flags.
| diff --git a/nbgrader/apps/assignapp.py b/nbgrader/apps/assignapp.py
index 85fcf0e8..ebac9e3b 100644
--- a/nbgrader/apps/assignapp.py
+++ b/nbgrader/apps/assignapp.py
@@ -40,6 +40,10 @@ flags.update({
{'BaseConverter': {'force': True}},
"Overwrite an assignment/submission if it already exists."
)... |
jupyterhub__autodoc-traits-33 | [
{
"changes": {
"added_entities": [
"autodoc_traits.py:hastraits_attrgetter"
],
"added_modules": [
"autodoc_traits.py:hastraits_attrgetter"
],
"edited_entities": [
"autodoc_traits.py:ConfigurableDocumenter.get_object_members",
"autodoc_traits.py:Trait... | jupyterhub/autodoc-traits | 25f4494cba46d169e999ce1851bf3518fa3f07ca | autoclass finds traits, but doesn't find their docstrings
### Bug description
When using autoclass (not autoconfigurable), traits with help strings are treated as undocumented. That means they are excluded from `:members:`, but included with `:undoc-members:`. When they are included with `:undoc-members:`, they are ... | diff --git a/autodoc_traits.py b/autodoc_traits.py
index fb11eee..de2d725 100644
--- a/autodoc_traits.py
+++ b/autodoc_traits.py
@@ -4,7 +4,11 @@ sphinx.ext.autodoc extension for classes with configurable traits.
The code here is similar to the official code example in
https://www.sphinx-doc.org/en/master/development... |
jupyterhub__chartpress-112 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chartpress.py:main"
],
"edited_modules": [
"chartpress.py:main"
]
},
"file": "chartpress.py"
}
] | jupyterhub/chartpress | 9e10f56bce6a2ce4104822a342392b1843dd1e2a | --list-images updates Chart.yaml's version
Running `chartpress --list-images` will also update Chart.yaml with a version which I consider unwanted. | diff --git a/chartpress.py b/chartpress.py
index 27906a9..0d0fa08 100755
--- a/chartpress.py
+++ b/chartpress.py
@@ -826,15 +826,16 @@ def main(args=None):
if args.reset:
forced_version = chart.get('resetVersion', '0.0.1-set.by.chartpress')
- # update Chart.yaml with a version
- ch... |
jupyterhub__chartpress-234 | [
{
"changes": {
"added_entities": [
"chartpress.py:_remove_config_arg"
],
"added_modules": [
"chartpress.py:_remove_config_arg"
],
"edited_entities": [
"chartpress.py:_get_all_image_paths",
"chartpress.py:_get_all_chart_paths",
"chartpress.py:... | jupyterhub/chartpress | fc453b7cd9c1d39c348559e83bac59e7a7f9c49f | add a `--file` flag to use a different `chartpress.yaml`
### Proposed change
In projects involving more than one chart, it would be useful to have a `--file` flag such that a specific `chartpress.yaml` file could be targeted, e.g.
```
chartpress --file another-chartpress.yaml
```
### Alternative options
This b... | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 2019e6d..43c6630 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -11,7 +11,7 @@
repos:
# Autoformat: Python code, syntax patterns are modernized
- repo: https://github.com/asottile/pyupgrade
- rev: v3.15.2
+ rev: v3.... |
jupyterhub__chartpress-96 | [
{
"changes": {
"added_entities": [
"chartpress.py:log",
"chartpress.py:check_call"
],
"added_modules": [
"chartpress.py:log",
"chartpress.py:check_call"
],
"edited_entities": [
"chartpress.py:run_cmd",
"chartpress.py:build_images",
... | jupyterhub/chartpress | 38c0e99444b2172bd14f57dfe7c6fa704bf0cb02 | --push-latest-tag by default
### Proposed change
To publish a `latest` image tag by default and make it configurable by a flag.
### Who would use this feature?
It would allow for example a GitHub action setup to do a security scan of the latest image be able to do it without having a lot of code to extract the lat... | diff --git a/chartpress.py b/chartpress.py
index 95fc5ad..23a280b 100755
--- a/chartpress.py
+++ b/chartpress.py
@@ -13,6 +13,7 @@ import pipes
import re
import shutil
import subprocess
+import sys
from tempfile import TemporaryDirectory
import docker
@@ -33,14 +34,26 @@ yaml.preserve_quotes = True ## avoid mang... |
jupyterhub__jupyterhub-3757 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jupyterhub/apihandlers/auth.py:OAuthHandler.make_absolute_redirect_uri"
],
"edited_modules": [
"jupyterhub/apihandlers/auth.py:OAuthHandler"
]
},
"file": "jupyterhub/ap... | jupyterhub/jupyterhub | a2ba55756d036e8007830fbb4b67665d2b30692c | Empty Admin page when the hub is behind nginx proxy
<!-- Thank you for contributing. These HTML comments will not render in the issue, but you can delete them once you've read them if you prefer! -->
### Bug description
<!-- Use this section to clearly and concisely describe the bug. -->
Merry Christmas!
The ... | diff --git a/jupyterhub/apihandlers/auth.py b/jupyterhub/apihandlers/auth.py
index 4d63ec99..2ec2dec0 100644
--- a/jupyterhub/apihandlers/auth.py
+++ b/jupyterhub/apihandlers/auth.py
@@ -16,6 +16,7 @@ from tornado import web
from .. import orm
from .. import roles
from .. import scopes
+from ..utils import get_brows... |
jupyterhub__jupyterhub-4471 | [
{
"changes": {
"added_entities": [
"jupyterhub/app.py:JupyterHub._default_subdomain_hook",
"jupyterhub/app.py:JupyterHub._subdomain_hook"
],
"added_modules": null,
"edited_entities": [
"jupyterhub/app.py:JupyterHub.service_from_orm",
"jupyterhub/app.py:Jup... | jupyterhub/jupyterhub | a66801c4244762b12d1c61559895d5fc4b95b62c | Services are moved to a subdomain if subdomain_host is set
### Bug description
Specifying `c.JupyterHub.subdomain_host` moves the services URL to `//services.<subdomain_host>/services/`. This was a bit tricky to figure out, and I in the end only discovered it by querying the proxy via its API.
#### Expected behav... | diff --git a/jupyterhub/app.py b/jupyterhub/app.py
index 430564bf..4c59e6c0 100644
--- a/jupyterhub/app.py
+++ b/jupyterhub/app.py
@@ -93,6 +93,8 @@ from .utils import (
maybe_future,
print_ps_info,
print_stacks,
+ subdomain_hook_idna,
+ subdomain_hook_legacy,
url_path_join,
)
@@ -739,6 +74... |
jupyterhub__jupyterhub-4480 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jupyterhub/app.py:JupyterHub._get_or_create_user",
"jupyterhub/app.py:JupyterHub.init_groups",
"jupyterhub/app.py:JupyterHub.init_role_creation",
"jupyterhub/app.py:JupyterHub.in... | jupyterhub/jupyterhub | 0e4deec714a30729d11e7d0b1ce359f65faaf6af | Can we override `Authenticator.check_allowed` in jupyterhub/oauthenticator and assume authentication argument be passed?
In [oauthenticator #594](https://github.com/jupyterhub/oauthenticator/pull/594) we are currently planning to override the `check_allowed` as considered and proposed in https://github.com/jupyterhub/o... | diff --git a/jupyterhub/app.py b/jupyterhub/app.py
index 3a5e3371..eab6ef60 100644
--- a/jupyterhub/app.py
+++ b/jupyterhub/app.py
@@ -2041,21 +2041,20 @@ class JupyterHub(Application):
TOTAL_USERS.set(total_users)
- async def _get_or_create_user(self, username):
+ async def _get_or_create_user(self,... |
jupyterhub__jupyterhub-4570 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jupyterhub/scopes.py:_intersect_expanded_scopes"
],
"edited_modules": [
"jupyterhub/scopes.py:_intersect_expanded_scopes"
]
},
"file": "jupyterhub/scopes.py"
}
] | jupyterhub/jupyterhub | 30ed97d153d3e887c15a6d98e637ba2b19d7fb89 | Call to .add on a frozenset in _intersect_expanded_scopes fails
### Bug description
Unexpected frozenset in `jupyterhub.scopes._intersect_expanded_scopes` means that any call (e.g. [here](https://github.com/jupyterhub/jupyterhub/blame/4.0.2/jupyterhub/scopes.py#L269)) to `.add(...)` fails with `AttributeError: 'froz... | diff --git a/jupyterhub/scopes.py b/jupyterhub/scopes.py
index d7b91f16..2f42076a 100644
--- a/jupyterhub/scopes.py
+++ b/jupyterhub/scopes.py
@@ -257,8 +257,12 @@ def _intersect_expanded_scopes(scopes_a, scopes_b, db=None):
}
# resolve hierarchies (group/user/server) in both directions
- ... |
jupyterhub__kubespawner-105 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kubespawner/objects.py:make_pod"
],
"edited_modules": [
"kubespawner/objects.py:make_pod"
]
},
"file": "kubespawner/objects.py"
},
{
"changes": {
"added_e... | jupyterhub/kubespawner | 054f6d61cb23232983ca3db74177b2732f15de14 | Add configuration for annotations on spawned singleuser pods
The spawner supports [configuring extra labels on spawned pods](https://github.com/jupyterhub/kubespawner/blob/06a2e09bc05e873a3e9e8b29d60beceb193fb2b7/kubespawner/spawner.py#L264-L280).
It should also support configuring extra annotations on spawned pods. | diff --git a/kubespawner/objects.py b/kubespawner/objects.py
index e2632b7..29ca165 100644
--- a/kubespawner/objects.py
+++ b/kubespawner/objects.py
@@ -36,12 +36,11 @@ def make_pod(
volumes=[],
volume_mounts=[],
labels={},
+ annotations={},
cpu_limit=None,
cpu_guarantee=None,
mem_limit... |
jupyterhub__kubespawner-122 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kubespawner/objects.py:make_pvc"
],
"edited_modules": [
"kubespawner/objects.py:make_pvc"
]
},
"file": "kubespawner/objects.py"
},
{
"changes": {
"added_e... | jupyterhub/kubespawner | 5c9bf38731e8f5b04b5001d78987b7408ed1ae00 | Long user names used in pod and pvc labels not allowed by k8s
The `hub.jupyter.org/username` label in pod or pvc manifests (e.g. https://github.com/jupyterhub/kubespawner/blob/master/kubespawner/spawner.py#L663) when user name has more than 63 characters will make the creation of the pod fail with a error like this:
... | diff --git a/kubespawner/objects.py b/kubespawner/objects.py
index ae0d42e..2c8201c 100644
--- a/kubespawner/objects.py
+++ b/kubespawner/objects.py
@@ -250,7 +250,8 @@ def make_pvc(
storage_class,
access_modes,
storage,
- labels
+ labels,
+ annotations={}
):
"""
Make a k8s pvc sp... |
jupyterhub__kubespawner-239 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kubespawner/objects.py:make_pod"
],
"edited_modules": [
"kubespawner/objects.py:make_pod"
]
},
"file": "kubespawner/objects.py"
},
{
"changes": {
"added_e... | jupyterhub/kubespawner | 99ef3b46c277e78da5c9f18ab581b0adce83f453 | Support setting affinity items
We should support setting nodeAffinity, podAffinity, podAntiAffinity, and preferred/required for each.
```yaml
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution: # nodeSelector
nodeSelectorTerms: #
# logical AND of the items below
... | diff --git a/kubespawner/objects.py b/kubespawner/objects.py
index f29fe55..1c1944f 100644
--- a/kubespawner/objects.py
+++ b/kubespawner/objects.py
@@ -21,6 +21,9 @@ from kubernetes.client.models import (
V1beta1HTTPIngressRuleValue, V1beta1HTTPIngressPath,
V1beta1IngressBackend,
V1Toleration,
+ V1Af... |
jupyterhub__kubespawner-34 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kubespawner/objects.py:make_pod_spec"
],
"edited_modules": [
"kubespawner/objects.py:make_pod_spec"
]
},
"file": "kubespawner/objects.py"
},
{
"changes": {
... | jupyterhub/kubespawner | dc41368f61d9916fa2972b6c0a944fc2a0a66b01 | Specify container command
Is it possible to specify the container command via config? To use the docker stacks, command must be set to `/usr/local/bin/singleuser.sh`, but I can't see how to do it here. In DockerSpawner, it's passed to `docker.create` | diff --git a/kubespawner/objects.py b/kubespawner/objects.py
index 0d35428..0564574 100644
--- a/kubespawner/objects.py
+++ b/kubespawner/objects.py
@@ -6,6 +6,8 @@ def make_pod_spec(
image_spec,
image_pull_policy,
image_pull_secret,
+ port,
+ cmd,
run_as_uid,
fs_gid,
env,
@@ -34,6 +... |
jupyterhub__kubespawner-38 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kubespawner/objects.py:make_pod_spec"
],
"edited_modules": [
"kubespawner/objects.py:make_pod_spec"
]
},
"file": "kubespawner/objects.py"
}
] | jupyterhub/kubespawner | 477b322b3bebd6d668185912c633eac2c1fee5dd | Specify container command
Is it possible to specify the container command via config? To use the docker stacks, command must be set to `/usr/local/bin/singleuser.sh`, but I can't see how to do it here. In DockerSpawner, it's passed to `docker.create` | diff --git a/kubespawner/objects.py b/kubespawner/objects.py
index c75e80c..16509e4 100644
--- a/kubespawner/objects.py
+++ b/kubespawner/objects.py
@@ -97,7 +97,7 @@ def make_pod_spec(
{
'name': 'notebook',
'image': image_spec,
- 'command': ... |
jupyterhub__kubespawner-84 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "jupyterhub_config.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kubespawner/obj... | jupyterhub/kubespawner | ae1c6d6f58a45c2ba4b9e2fa81d50b16503f9874 | Add support for setting singleuser service account
Currently we disable all service account mounting from inside the pod.
We should allow people to:
1. Specify that the default serviceaccount needs to be mounted
2. Specify that an arbitrary service account should be created and then mounted.
The default would... | diff --git a/jupyterhub_config.py b/jupyterhub_config.py
index cce2c68..e59a17d 100644
--- a/jupyterhub_config.py
+++ b/jupyterhub_config.py
@@ -19,6 +19,7 @@ c.KubeSpawner.singleuser_image_spec = 'yuvipanda/simple-singleuser:v1'
# The spawned containers need to be able to talk to the hub through the proxy!
c.KubeSpa... |
jupyterhub__nativeauthenticator-36 | [
{
"changes": {
"added_entities": [
"nativeauthenticator/nativeauthenticator.py:NativeAuthenticator.add_login_attempt",
"nativeauthenticator/nativeauthenticator.py:NativeAuthenticator.can_try_to_login_again",
"nativeauthenticator/nativeauthenticator.py:NativeAuthenticator.is_blocked... | jupyterhub/nativeauthenticator | e2e78301d0731dabbf229217c80312936359ce67 | Block user after X logins failed
- [ ] Allow blocking user from system
- [ ] Add feature on admin panel to set number of trials
- [ ] Add list of blocked users on admin panel
- [ ] Add verification of number of trials on login | diff --git a/docs/index.rst b/docs/index.rst
index fec3322..ce1b415 100644
--- a/docs/index.rst
+++ b/docs/index.rst
@@ -14,7 +14,7 @@ Indices and tables
==================
.. toctree::
- :maxdepth: 2
+ :maxdepth: 1
:caption: Contents:
quickstart
diff --git a/docs/options.rst b/docs/options.rst
index ... |
jupyterhub__nativeauthenticator-38 | [
{
"changes": {
"added_entities": [
"nativeauthenticator/handlers.py:SignUpHandler.get_result_message"
],
"added_modules": null,
"edited_entities": [
"nativeauthenticator/handlers.py:SignUpHandler.post"
],
"edited_modules": [
"nativeauthenticator/handle... | jupyterhub/nativeauthenticator | 753c53a6d5f5cfcd0e94cff1376759e621f70436 | Add option for Open SignUp
Make an option that all signups are already authorized by default | diff --git a/docs/options.rst b/docs/options.rst
index 2a33fb7..bd4009e 100644
--- a/docs/options.rst
+++ b/docs/options.rst
@@ -35,4 +35,16 @@ You can also define the number of seconds a user must wait before trying again.
.. code-block:: python
- c.Authenticator.secs_before_next_try = 1200
+ c.Authenticato... |
jupyterhub__nativeauthenticator-43 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nativeauthenticator/handlers.py:SignUpHandler.get_result_message"
],
"edited_modules": [
"nativeauthenticator/handlers.py:SignUpHandler"
]
},
"file": "nativeauthenticat... | jupyterhub/nativeauthenticator | 92b1193d5084e67b1bc263fc59650cdec1e03538 | Add username sanitization | diff --git a/docs/index.rst b/docs/index.rst
index 3d2a5de..2c2d480 100644
--- a/docs/index.rst
+++ b/docs/index.rst
@@ -46,7 +46,9 @@ Then, you must create the configuration file for JupyterHub:
And change the default Authenticator class for our Native Authenticator class:
-`c.JupyterHub.authenticator_class = 'na... |
jupyterhub__nativeauthenticator-49 | [
{
"changes": {
"added_entities": [
"nativeauthenticator/nativeauthenticator.py:NativeAuthenticator.delete_user"
],
"added_modules": null,
"edited_entities": [
"nativeauthenticator/nativeauthenticator.py:NativeAuthenticator.get_or_create_user"
],
"edited_module... | jupyterhub/nativeauthenticator | 7b0953c83b4b7d725561808cfa3ab5dbdd97b9a5 | Make delete_user method delete UserInfo as well
As explained on #44 we should overwrite the `delete_user` method to delete a User on UserInfo table as well. | diff --git a/nativeauthenticator/nativeauthenticator.py b/nativeauthenticator/nativeauthenticator.py
index f0e7207..2cff990 100644
--- a/nativeauthenticator/nativeauthenticator.py
+++ b/nativeauthenticator/nativeauthenticator.py
@@ -2,6 +2,7 @@ import bcrypt
import os
from datetime import datetime
from jupyterhub.au... |
jupyterhub__oauthenticator-116 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"oauthenticator/gitlab.py:GitLabOAuthenticator.authenticate"
],
"edited_modules": [
"oauthenticator/gitlab.py:GitLabOAuthenticator"
]
},
"file": "oauthenticator/gitlab.p... | jupyterhub/oauthenticator | ac730b276184640227c2ca999bfccfe7472fca85 | GitLab auth fails for non admin users
Recent changes in GitLab's API have removed the "is_admin" property from most API calls: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10846
Now it is only shown when the request comes from an admin user:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12211
... | diff --git a/oauthenticator/gitlab.py b/oauthenticator/gitlab.py
index 860aa92..5afddb8 100644
--- a/oauthenticator/gitlab.py
+++ b/oauthenticator/gitlab.py
@@ -107,7 +107,7 @@ class GitLabOAuthenticator(OAuthenticator):
username = resp_json["username"]
user_id = resp_json["id"]
- is_admin = ... |
jupyterhub__oauthenticator-449 | [
{
"changes": {
"added_entities": [
"oauthenticator/github.py:GitHubOAuthenticator._build_check_membership_url"
],
"added_modules": null,
"edited_entities": [
"oauthenticator/github.py:GitHubOAuthenticator._check_membership_allowed_organizations"
],
"edited_mod... | jupyterhub/oauthenticator | d8ea0b6f11dbc3dac35aada9d17aef6ccd2da6a4 | [GitHub] We can authorize organizations, but what about teams within them?
Currently GitHub authentication is setup to whitelist individual users or entire organizations:
https://github.com/jupyterhub/oauthenticator/blob/master/oauthenticator/github.py
See here for the implementation:
https://zero-to-jupyterhub.re... | diff --git a/docs/source/github.md b/docs/source/github.md
index d5e2663..170b51e 100644
--- a/docs/source/github.md
+++ b/docs/source/github.md
@@ -39,3 +39,33 @@ To use this expanded user information, you will need to subclass your
current spawner and modify the subclass to read these fields from
`auth_state` and t... |
jupyterhub__oauthenticator-58 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"oauthenticator/bitbucket.py:BitbucketOAuthenticator.authenticate",
"oauthenticator/bitbucket.py:BitbucketOAuthenticator._check_team_whitelist"
],
"edited_modules": [
"oauthen... | jupyterhub/oauthenticator | 856741299a32cffa1575dca8cccaf7b2ce7d20dc | Add team whitelisting for GitHubOAuthenticator and GitLabOAuthenticator
BitBucketOAuthenticator has team whitelisting, so it would seem reasonable to also add this for Gitlab and Github.
I am already working towards submitting a pull request, but am creating this issue here to serve as a centre for discussion and ... | diff --git a/oauthenticator/bitbucket.py b/oauthenticator/bitbucket.py
index 0f4beab..f453e56 100644
--- a/oauthenticator/bitbucket.py
+++ b/oauthenticator/bitbucket.py
@@ -46,6 +46,13 @@ class BitbucketOAuthenticator(OAuthenticator):
help="Automatically whitelist members of selected teams",
)
+ bitb... |
jupyterhub__oauthenticator-594 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"docs/source/how-to/example-oauthenticator.py:MyServiceOAuthenticator.update_auth_model"
],
"edited_modules": [
"docs/source/how-to/example-oauthenticator.py:MyServiceOAuthenticator"
... | jupyterhub/oauthenticator | 93113f7c29a848f9ea8bad6212d9164bc26d3b17 | Admins configured in admin_users lose admin status if admin_groups is not configured
<!-- Thank you for contributing. These HTML comments will not render in the issue, but you can delete them once you've read them if you prefer! -->
### Bug description
I am running a setup with the following configuration (excerp... | diff --git a/docs/source/how-to/example-oauthenticator.py b/docs/source/how-to/example-oauthenticator.py
index 822aecb..c139ee1 100644
--- a/docs/source/how-to/example-oauthenticator.py
+++ b/docs/source/how-to/example-oauthenticator.py
@@ -88,9 +88,9 @@ class MyServiceOAuthenticator(OAuthenticator):
# Updates `au... |
jupyterhub__oauthenticator-625 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"oauthenticator/auth0.py:Auth0OAuthenticator._auth0_subdomain_default",
"oauthenticator/auth0.py:Auth0OAuthenticator._auth0_domain_default"
],
"edited_modules": [
"oauthentica... | jupyterhub/oauthenticator | 752d368bc31312321e8534321a8d5c10c6bef1de | Discussion: don't default to allowing all users?
### Proposed change
Don't default to allowing all users to login.
### Alternative options
Leave unchanged
### Who would use this feature?
Sysadmins who expect a "secure by default" configuration
### (Optional): Suggest a solution
As mentioned in https://github.com/jup... | diff --git a/docs/source/reference/changelog.md b/docs/source/reference/changelog.md
index d4e7da3..610d8d1 100644
--- a/docs/source/reference/changelog.md
+++ b/docs/source/reference/changelog.md
@@ -23,6 +23,8 @@ command line for details.
lists as as they are converted to sets automatically, but anyone reading and... |
jupyterhub__oauthenticator-665 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"oauthenticator/globus.py:GlobusOAuthenticator.check_allowed"
],
"edited_modules": [
"oauthenticator/globus.py:GlobusOAuthenticator"
]
},
"file": "oauthenticator/globus.... | jupyterhub/oauthenticator | d4e07ef50239bd8371843e877eee78c360677f9c | Adding a groups crashes JupyterHub on startup
<!-- Thank you for contributing. These HTML comments will not render in the issue, but you can delete them once you've read them if you prefer! -->
### Bug description
When I create a group with `c.JupyterHub.load_groups `, I get an ` TypeError: 'NoneType' object is n... | diff --git a/oauthenticator/globus.py b/oauthenticator/globus.py
index 4a44720..28ae5d2 100644
--- a/oauthenticator/globus.py
+++ b/oauthenticator/globus.py
@@ -291,6 +291,11 @@ class GlobusOAuthenticator(OAuthenticator):
Overrides the OAuthenticator.check_allowed to also allow users part of
`allowed_... |
jupyterhub__oauthenticator-671 | [
{
"changes": {
"added_entities": [
"oauthenticator/oauth2.py:OAuthLoginHandler._generate_state_id",
"oauthenticator/oauth2.py:OAuthLoginHandler._get_next_url"
],
"added_modules": null,
"edited_entities": [
"oauthenticator/oauth2.py:OAuthLoginHandler.set_state_cook... | jupyterhub/oauthenticator | 2669fc2a7c33c891ce2c4113c40762dcc72753a5 | Don't include next_url in state parameter in Login/Callback
<!-- Thank you for contributing. These HTML comments will not render in the issue, but you can delete them once you've read them if you prefer! -->
This comes up when navigating to some bookmarked URL for some file path, or using an extension like nbgitpull... | diff --git a/oauthenticator/oauth2.py b/oauthenticator/oauth2.py
index ca4147f..bc09dff 100644
--- a/oauthenticator/oauth2.py
+++ b/oauthenticator/oauth2.py
@@ -70,13 +70,16 @@ class OAuthLoginHandler(OAuth2Mixin, BaseHandler):
def _OAUTH_USERINFO_URL(self):
return self.authenticator.userdata_url
- d... |
jupyterhub__oauthenticator-685 | [
{
"changes": {
"added_entities": [
"oauthenticator/cilogon.py:CILogonOAuthenticator._validate_idps"
],
"added_modules": null,
"edited_entities": [
"oauthenticator/cilogon.py:_get_select_idp_param",
"oauthenticator/cilogon.py:CILogonLoginHandler.authorize_redirect"... | jupyterhub/oauthenticator | 9164026e71db57e571adc3a4073053aec3f392f5 | [CILogon] Rename `allowed_idps` to `idps` in a non-breaking way?
I think the name `allowed_idps` causes some confusion in oauthenticator v16, and that it should be non-breakingly renamed to just `idps` with a deprecation warning for users still using the `allowed_idps` name.
With a name like `idps`, there is no hint... | diff --git a/docs/source/tutorials/provider-specific-setup/providers/cilogon.md b/docs/source/tutorials/provider-specific-setup/providers/cilogon.md
index 0c76e3d..1b1bf0b 100644
--- a/docs/source/tutorials/provider-specific-setup/providers/cilogon.md
+++ b/docs/source/tutorials/provider-specific-setup/providers/cilogo... |
jupyterhub__oauthenticator-751 | [
{
"changes": {
"added_entities": [
"oauthenticator/oauth2.py:OAuthenticator._call_modify_auth_state_hook"
],
"added_modules": null,
"edited_entities": [
"oauthenticator/oauth2.py:OAuthenticator.get_user_groups",
"oauthenticator/oauth2.py:OAuthenticator.update_auth... | jupyterhub/oauthenticator | cd00a8d6e5a8a6a97088b4a1e73ccb419f197257 | Managing group information properly when tokens don't include groups claim key?
We are upgrading a custom authenticator based on `GenericOAuthenticator` from 15.x to 16.x (or more likely, the currently in-development 17.0). We need to adapt our usage of `manage_groups` and `allowed_groups`. At this time our tokens do... | diff --git a/oauthenticator/oauth2.py b/oauthenticator/oauth2.py
index c36fb84..e04ea95 100644
--- a/oauthenticator/oauth2.py
+++ b/oauthenticator/oauth2.py
@@ -9,6 +9,7 @@ import json
import os
import uuid
from functools import reduce
+from inspect import isawaitable
from urllib.parse import quote, urlencode, urlp... |
jupyterhub__oauthenticator-758 | [
{
"changes": {
"added_entities": [
"oauthenticator/azuread.py:AzureAdOAuthenticator._auth_state_groups_key_default"
],
"added_modules": null,
"edited_entities": [
"oauthenticator/azuread.py:AzureAdOAuthenticator.update_auth_model"
],
"edited_modules": [
... | jupyterhub/oauthenticator | d2aac2d614729183871a643afdc4711e2b8d5300 | New group config in OAuthenticator overlaps with `allowed_google_groups` for example and may not work - what do we do?
#735 moved group related config in Generic to OAuthenticator, and did a breaking change related to that group config previosly found only in GenericOAuthenticator.
<details><summary>Documentation ab... | diff --git a/docs/source/tutorials/general-setup.md b/docs/source/tutorials/general-setup.md
index 772b4e8..920a312 100644
--- a/docs/source/tutorials/general-setup.md
+++ b/docs/source/tutorials/general-setup.md
@@ -60,7 +60,9 @@ projects' authenticator classes.
- {attr}`.OAuthenticator.allow_all`
- {attr}`.OA... |
jupyterhub__oauthenticator-763 | [
{
"changes": {
"added_entities": [
"oauthenticator/google.py:GoogleOAuthenticator._setup_service",
"oauthenticator/google.py:GoogleOAuthenticator._fetch_member_groups"
],
"added_modules": null,
"edited_entities": [
"oauthenticator/google.py:GoogleOAuthenticator.up... | jupyterhub/oauthenticator | 0df5b8256e9bd896fcceb0ba04b80b9231857350 | Allow authentication via nested groups for Google OAuthenticator
### Proposed change
Allow authentication via nested groups for Google OAuthenticator. Google Workspace now allows nested Google Groups, but the Google OAuthenticator has no option for allowing auth this way.
### Who would use this feature?
This would... | diff --git a/oauthenticator/google.py b/oauthenticator/google.py
index 5d901cd..f06f6ac 100644
--- a/oauthenticator/google.py
+++ b/oauthenticator/google.py
@@ -105,6 +105,14 @@ class GoogleOAuthenticator(OAuthenticator, GoogleOAuth2Mixin):
""",
)
+ include_nested_groups = Bool(
+ config=True,... |
jupyterhub__oauthenticator-764 | [
{
"changes": {
"added_entities": [
"oauthenticator/google.py:GoogleOAuthenticator._get_service_credentials",
"oauthenticator/google.py:GoogleOAuthenticator._is_token_valid",
"oauthenticator/google.py:GoogleOAuthenticator._setup_service_credentials"
],
"added_modules": n... | jupyterhub/oauthenticator | f4da2e8eedeec009f2d1ac749b6da2ee160652b0 | The google authenticator's calls to check groups is done sync, can it be made async?
Quickly written, I can fill this in in more detail later. | diff --git a/oauthenticator/google.py b/oauthenticator/google.py
index f06f6ac..28b76d4 100644
--- a/oauthenticator/google.py
+++ b/oauthenticator/google.py
@@ -14,6 +14,7 @@ from .oauth2 import OAuthenticator
class GoogleOAuthenticator(OAuthenticator, GoogleOAuth2Mixin):
user_auth_state_key = "google_user"
+ ... |
jupyterlab__jupyterlab_server-388 | [
{
"changes": {
"added_entities": [
"jupyterlab_server/config.py:load_config"
],
"added_modules": [
"jupyterlab_server/config.py:load_config"
],
"edited_entities": [
"jupyterlab_server/config.py:get_page_config"
],
"edited_modules": [
"jup... | jupyterlab/jupyterlab_server | 1dcca6107630d6315339cd1e83460e18db57194a | page_config.json should support json5
### Problem
Similar to overrides, `page_config.json` should also support json5 so that comments can be added.
### Proposed Solution
All json configs should always support json5. Maybe we add a common codepath to enforce this? I.e. instead of doing something like [this](htt... | diff --git a/jupyterlab_server/config.py b/jupyterlab_server/config.py
index 51a94b5..6e349c3 100644
--- a/jupyterlab_server/config.py
+++ b/jupyterlab_server/config.py
@@ -9,6 +9,7 @@ from glob import iglob
from itertools import chain
from os.path import join as pjoin
+import json5 # type:ignore
from jupyter_cor... |
just-work__fffw-100 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fffw/encoding/filters.py:Trim.transform"
],
"edited_modules": [
"fffw/encoding/filters.py:Trim"
]
},
"file": "fffw/encoding/filters.py"
}
] | just-work/fffw | 660e60664812b377a9ac43c0a6b9bb807bc7e394 | Trim sets incorrect duration
If Trim end is after EOF, stream output duration is greater than expected. | diff --git a/fffw/encoding/filters.py b/fffw/encoding/filters.py
index 194424c..1f49262 100644
--- a/fffw/encoding/filters.py
+++ b/fffw/encoding/filters.py
@@ -261,6 +261,8 @@ class Trim(AutoFilter):
meta = metadata[0]
scenes = []
streams: List[str] = []
+ start = self.start or TS(0)
... |
just-work__fffw-106 | [
{
"changes": {
"added_entities": [
"fffw/encoding/filters.py:Upload.__post_init__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"fffw/encoding/filters.py:Upload"
]
},
"file": "fffw/encoding/filters.py"
}
] | just-work/fffw | 0b9d1fc797ccced2230bbb429d3c351c1484414e | Filter._clone changes attribute types
`Upload._clone()` method changes `device` type from `Device` to `dict`. After that upload instance become unusable. | diff --git a/fffw/encoding/filters.py b/fffw/encoding/filters.py
index 1f49262..ba3dba6 100644
--- a/fffw/encoding/filters.py
+++ b/fffw/encoding/filters.py
@@ -422,6 +422,12 @@ class Upload(VideoFilter):
extra_hw_frames: int = param(default=64, init=False)
device: Device = param(skip=True)
+ def __post_... |
just-work__fffw-122 | [
{
"changes": {
"added_entities": [
"fffw/graph/meta.py:maybe_parse_duration"
],
"added_modules": [
"fffw/graph/meta.py:maybe_parse_duration"
],
"edited_entities": [
"fffw/graph/meta.py:audio_meta_data",
"fffw/graph/meta.py:video_meta_data"
],
... | just-work/fffw | 614b9148e11e1ee1d7255fd9b138bf07f2628b0b | Wrong MKV duration
In MKV container duration field contains float milliseconds value and in MP4 container it's int.
TS implementation parses int as milliseconds and float as seconds (because of ffmpeg duration meanings).
media info normalizer should perform duration rounding. | diff --git a/fffw/graph/meta.py b/fffw/graph/meta.py
index 5ed0f15..328d1f0 100644
--- a/fffw/graph/meta.py
+++ b/fffw/graph/meta.py
@@ -381,9 +381,28 @@ class AudioMeta(Meta):
assert abs(self.samples - interval * self.sampling_rate) <= 1
+def maybe_parse_duration(value: Union[str, float, int, None]) -> TS... |
just-work__fffw-136 | [
{
"changes": {
"added_entities": [
"fffw/encoding/codecs.py:Copy._remove_edge",
"fffw/encoding/codecs.py:Copy._validate_filter_chain"
],
"added_modules": null,
"edited_entities": [
"fffw/encoding/codecs.py:Copy.connect_edge"
],
"edited_modules": [
... | just-work/fffw | 19f969ee55c1ed08a228af38eab116db2d9aea81 | Copy codec bug
```
source - split(1) - split(3) - Copy x 3
```
In this case Copy codec is connected to split(1) instead of source, followed by some errors.
```
src = edge.input
# Ensure that edge is connected to a source with only split filters
# in between.
source_edge = edg... | diff --git a/fffw/encoding/codecs.py b/fffw/encoding/codecs.py
index cfe68f9..4857c38 100644
--- a/fffw/encoding/codecs.py
+++ b/fffw/encoding/codecs.py
@@ -82,6 +82,53 @@ class Copy(outputs.Codec):
:returns: edge pointing to an input stream
"""
+ # Running parent method for side effects like... |
just-work__fffw-16 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fffw/encoding/codec.py:BaseCodec.render"
],
"edited_modules": [
"fffw/encoding/codec.py:BaseCodec"
]
},
"file": "fffw/encoding/codec.py"
},
{
"changes": {
... | just-work/fffw | 90670cb27204b0fc49c06dabea14ecc17b34ea1c | Invalid naming
`test_filter_graph` fails if disable Yadif filter. This is because of inconsistent naming logic. | diff --git a/.gitignore b/.gitignore
index 1dbc687..eab57e0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -60,3 +60,8 @@ target/
#Ipython Notebook
.ipynb_checkpoints
+
+.idea/
+
+.mypy_cache/
+.dmypy.json
\ No newline at end of file
diff --git a/fffw/encoding/codec.py b/fffw/encoding/codec.py
index 2718fb8..aef4053 1... |
just-work__fffw-174 | [
{
"changes": {
"added_entities": [
"fffw/encoding/outputs.py:Codec.as_pairs"
],
"added_modules": null,
"edited_entities": [
"fffw/encoding/outputs.py:OutputList.__init__",
"fffw/encoding/outputs.py:OutputList.append",
"fffw/encoding/outputs.py:OutputList.e... | just-work/fffw | ee8cf9ba7fd07313aca7dfab0155d0982f65cfa9 | Multiple options specified for stream
```
Multiple -c, -codec, -acodec, -vcodec, -scodec or -dcodec options specified for stream 0, only the last option '-c:v libx264' will be used.
```
since ffmpeg-4.4 (or even earlier) to set different options for different streams in same file, output stream index suffix should... | diff --git a/fffw/encoding/outputs.py b/fffw/encoding/outputs.py
index 968db2f..92e0ba0 100644
--- a/fffw/encoding/outputs.py
+++ b/fffw/encoding/outputs.py
@@ -1,11 +1,12 @@
+from collections import defaultdict
from dataclasses import dataclass
-from itertools import chain
-from typing import List, cast, Optional, It... |
just-work__fffw-27 | [
{
"changes": {
"added_entities": [
"fffw/encoding/ffmpeg.py:FFMPEG.check_buffering"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"fffw/encoding/ffmpeg.py:FFMPEG"
]
},
"file": "fffw/encoding/ffmpeg.py"
},
{
"changes": {... | just-work/fffw | b5d5c86245beb0856bdd234ed1c127db407ba542 | Prevent buffering
Need some way to detect possible frame buffering and automatic input file cloning as a workaround. | diff --git a/fffw/encoding/codecs.py b/fffw/encoding/codecs.py
index 29c0437..bc4814d 100644
--- a/fffw/encoding/codecs.py
+++ b/fffw/encoding/codecs.py
@@ -11,7 +11,7 @@ class VideoCodec(outputs.Codec):
"""
Base class for describing video codecs.
- See `fffw.graph.outputs.Codec` for params definition.
+... |
just-work__fffw-47 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "examples/overlay.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fffw/encoding/ou... | just-work/fffw | bb6d4bc134f17b0813d82eac027b6eb82a8ccbe3 | FFMPEG.add_output shortcuts imisbehaving
```
output = ff > output_file('output.mp4', VideoCodec('libx264'))
stream > output
```
The code above does not work because second line raises "no free codecs" error.
Relates to #43 | diff --git a/examples/overlay.py b/examples/overlay.py
index 800fa90..a7926c7 100644
--- a/examples/overlay.py
+++ b/examples/overlay.py
@@ -11,7 +11,7 @@ overlay = ff.video | Overlay(x=1720, y=100)
# scale logo to 100x100 and pass as top layer to overlay filter
logo | Scale(width=100, height=100) | overlay
-# tell... |
just-work__fffw-50 | [
{
"changes": {
"added_entities": [
"fffw/encoding/vector.py:Vector.metadata"
],
"added_modules": null,
"edited_entities": [
"fffw/encoding/vector.py:Vector.kind"
],
"edited_modules": [
"fffw/encoding/vector.py:Vector"
]
},
"file": "fffw/e... | just-work/fffw | 1418aad2d5c69b3a95e8fa3a2cf1d0ec6cba9091 | Vector should have metadata property
Current stream metadata may be used to compute some parameters for next filters, but Vector instance does not have such property.
Vector.metadata should return Meta instance if there is single stream in this vector and throw an error if vector length is more than one. | diff --git a/fffw/encoding/vector.py b/fffw/encoding/vector.py
index 75ba0be..337da32 100644
--- a/fffw/encoding/vector.py
+++ b/fffw/encoding/vector.py
@@ -1,6 +1,6 @@
from typing import *
-from fffw.graph.meta import AUDIO, VIDEO, StreamType
+from fffw.graph.meta import AUDIO, VIDEO, StreamType, Meta
from fffw.en... |
just-work__fffw-56 | [
{
"changes": {
"added_entities": [
"fffw/graph/meta.py:ts",
"fffw/graph/meta.py:TS.__floordiv__",
"fffw/graph/meta.py:TS.__truediv__",
"fffw/graph/meta.py:TS.__divmod__",
"fffw/graph/meta.py:TS.__int__",
"fffw/graph/meta.py:TS.__repr__",
"fffw/graph/... | just-work/fffw | dbeea7af44b21564453782ab9725ac3d0d1b665d | TS: base class and magic methods
`TS` instance based on `timedelta` is not json serializable, what leads to complicated Celery setup.
1. TS may be based on float and implement datetime/timedelta support via `__sub__`/`__add__` methods
2. TS should also define __repr__ method | diff --git a/fffw/graph/meta.py b/fffw/graph/meta.py
index ea0db03..93c0230 100644
--- a/fffw/graph/meta.py
+++ b/fffw/graph/meta.py
@@ -1,8 +1,13 @@
-import abc
from dataclasses import dataclass
from datetime import timedelta
from enum import Enum
-from typing import List, Union, Any, Optional
+from functools impor... |
just-work__fffw-64 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fffw/encoding/filters.py:Filter._clone"
],
"edited_modules": [
"fffw/encoding/filters.py:Filter"
]
},
"file": "fffw/encoding/filters.py"
}
] | just-work/fffw | fefda959ec043f1869b38026fc3c8a9679bf45bc | Filter with skipped params could not be cloned
`TypeError: __init__() got an unexpected keyword argument 'extra_hw_frames'`
| diff --git a/fffw/encoding/filters.py b/fffw/encoding/filters.py
index bd06ae6..ff1baa2 100644
--- a/fffw/encoding/filters.py
+++ b/fffw/encoding/filters.py
@@ -1,4 +1,4 @@
-from dataclasses import dataclass, replace, asdict, field
+from dataclasses import dataclass, replace, asdict, field, fields
from typing import U... |
just-work__fffw-68 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fffw/encoding/filters.py:Concat.transform"
],
"edited_modules": [
"fffw/encoding/filters.py:Concat"
]
},
"file": "fffw/encoding/filters.py"
}
] | just-work/fffw | ec1451b6347ac0c9a8da3947651d7b15ebf0212d | Concat audio fails validation
Samples count is not summed while concatenating audio.
Looks like concatenating video doesn't sum frames count. | diff --git a/fffw/encoding/filters.py b/fffw/encoding/filters.py
index ff1baa2..1ef1505 100644
--- a/fffw/encoding/filters.py
+++ b/fffw/encoding/filters.py
@@ -3,7 +3,7 @@ from typing import Union, List, cast
from fffw.graph import base
from fffw.encoding import mixins
-from fffw.graph.meta import Meta, VideoMeta,... |
just-work__fffw-70 | [
{
"changes": {
"added_entities": [
"fffw/encoding/filters.py:Split.validate_edge_device",
"fffw/encoding/filters.py:Concat.validate_edge_device"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"fffw/encoding/filters.py:Split",
... | just-work/fffw | 448ed0a0b1dee4640a86e0ecce056f5fb1505c3b | Split and concat should validate against any hardware
splitting and concatenation is supported in every hardware acceleration | diff --git a/fffw/encoding/filters.py b/fffw/encoding/filters.py
index 1ef1505..43ed444 100644
--- a/fffw/encoding/filters.py
+++ b/fffw/encoding/filters.py
@@ -202,6 +202,10 @@ class Split(AutoFilter):
return ''
return str(self.output_count)
+ def validate_edge_device(self, edge: base.Edge) ... |
just-work__fffw-71 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fffw/encoding/filters.py:Split.validate_edge_device",
"fffw/encoding/filters.py:Concat.validate_edge_device"
],
"edited_modules": [
"fffw/encoding/filters.py:Scale",
... | just-work/fffw | a5b5cacad54b502e9ee0ccd539e9dfcd7bf60eec | Split and concat should validate against any hardware
splitting and concatenation is supported in every hardware acceleration | diff --git a/fffw/encoding/filters.py b/fffw/encoding/filters.py
index 43ed444..2564388 100644
--- a/fffw/encoding/filters.py
+++ b/fffw/encoding/filters.py
@@ -157,6 +157,7 @@ class Scale(VideoFilter):
:arg height: resulting video height
"""
filter = "scale"
+ hardware = None # cpu only
width... |
just-work__fffw-80 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fffw/encoding/filters.py:Trim.transform",
"fffw/encoding/filters.py:Concat.transform"
],
"edited_modules": [
"fffw/encoding/filters.py:Trim",
"fffw/encoding/filters.p... | just-work/fffw | d839c61a6d8db8e4d79474125e203df496a46a43 | Support computing frames count for video metadata
It's useful to track encoding progress and to restore partial video metadata | diff --git a/fffw/encoding/filters.py b/fffw/encoding/filters.py
index f42e5b2..194424c 100644
--- a/fffw/encoding/filters.py
+++ b/fffw/encoding/filters.py
@@ -278,8 +278,18 @@ class Trim(AutoFilter):
scenes.append(Scene(stream=scene.stream, start=start,
duration=e... |
just-work__fffw-87 | [
{
"changes": {
"added_entities": [
"fffw/encoding/ffmpeg.py:FFMPEG.inputs",
"fffw/encoding/ffmpeg.py:FFMPEG.outputs"
],
"added_modules": null,
"edited_entities": [
"fffw/encoding/ffmpeg.py:FFMPEG.video",
"fffw/encoding/ffmpeg.py:FFMPEG.audio",
"fff... | just-work/fffw | f5b9a860c6aca1a6c8cf8f5dfde5f84ed8e7aabf | Interface for accessing meta of output files
Now, to get meta info about outputs (ex. total_frames) we have to use getattr and cast. A more comfortable way is required.
Please contact if need more details.
| diff --git a/fffw/encoding/ffmpeg.py b/fffw/encoding/ffmpeg.py
index 248f3ef..23a5790 100644
--- a/fffw/encoding/ffmpeg.py
+++ b/fffw/encoding/ffmpeg.py
@@ -1,9 +1,8 @@
from dataclasses import dataclass
-from typing import List, Optional, Union
+from typing import List, Optional, Union, Tuple
-from fffw.encoding imp... |
just-work__fffw-89 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fffw/encoding/ffmpeg.py:FFMPEG.inputs",
"fffw/encoding/ffmpeg.py:FFMPEG.outputs",
"fffw/encoding/ffmpeg.py:FFMPEG.video",
"fffw/encoding/ffmpeg.py:FFMPEG.audio",
"fffw/en... | just-work/fffw | 05f7e819b81f44bb6b95c970e871d956e5098c07 | Incorrect as_pairs behavior if default is not set
```python
File "/data/encoder/virtualenv/lib/python3.6/site-packages/fffw/wrapper/params.py", line 92, in as_pairs
if f.default == value and f.init:
File "/data/encoder/virtualenv/lib/python3.6/site-packages/fffw/graph/meta.py", line 104, in wrapper
retu... | diff --git a/fffw/encoding/ffmpeg.py b/fffw/encoding/ffmpeg.py
index 23a5790..248f3ef 100644
--- a/fffw/encoding/ffmpeg.py
+++ b/fffw/encoding/ffmpeg.py
@@ -1,8 +1,9 @@
from dataclasses import dataclass
-from typing import List, Optional, Union, Tuple
+from typing import List, Optional, Union
+from fffw.encoding imp... |
just-work__fffw-93 | [
{
"changes": {
"added_entities": [
"fffw/graph/base.py:Dest.transform"
],
"added_modules": null,
"edited_entities": [
"fffw/graph/base.py:Dest.meta"
],
"edited_modules": [
"fffw/graph/base.py:Dest"
]
},
"file": "fffw/graph/base.py"
}
] | just-work/fffw | 8e5e9c2ff766f31a90bf55dcfec2e6ac732b0478 | Codecs should transform meta
I.e. AudioCodec: when changing sampling rate, it should also change samples count.
For VideoCodec frame rate could be changed and frames count (#66) will also change. | diff --git a/fffw/graph/base.py b/fffw/graph/base.py
index e3e9d8b..45dac19 100644
--- a/fffw/graph/base.py
+++ b/fffw/graph/base.py
@@ -59,7 +59,14 @@ class Dest(Traversable):
@property
def meta(self) -> Optional[Meta]:
- return self.get_meta_data(self)
+ metadata = self.get_meta_data(self)
+... |
justanr__marshmallow-annotations-21 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/marshmallow_annotations/registry.py:DefaultTypeRegistry"
]
},
"file": "src/marshmallow_annotations/registry.py"
}
] | justanr/marshmallow-annotations | 0b5348591abedf6fb95c24539aa168a93104a248 | Register default Dictionary[TKey, TValue] converter
Probably similar looking to the default List converter. | diff --git a/docs/quickstart.rst b/docs/quickstart.rst
index c174015..6ab35ef 100644
--- a/docs/quickstart.rst
+++ b/docs/quickstart.rst
@@ -149,6 +149,12 @@ types mapped to marshmallow fields, these fields and their mappings are:
- :class:`~datetime.time` maps to :class:`~marshmallow.fields.Time`
- :class:`~datetime... |
jwg4__flask-selfdoc-44 | [
{
"changes": {
"added_entities": [
"flask_selfdoc/autodoc.py:sort_lexically"
],
"added_modules": [
"flask_selfdoc/autodoc.py:sort_lexically"
],
"edited_entities": [
"flask_selfdoc/autodoc.py:Autodoc.generate"
],
"edited_modules": [
"flask... | jwg4/flask-selfdoc | 9077c8dc834ce3bad548ade3ded2fc3e568f1788 | We should be able to order endpoints lexically. | diff --git a/.travis.yml b/.travis.yml
index d01c143..91ef85d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -28,7 +28,7 @@ install:
- pip install ${DEP}
- pip install flake8
script:
- - python -m unittest discover
+ - python setup.py test
- flake8 --exclude=examples --max-line-length=100
- python -m tes... |
jwplayer__jwplatform-py-20 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"jwplatform/client.py:Client.__init__"
],
"edited_modules": [
"jwplatform/client.py:Client"
]
},
"file": "jwplatform/client.py"
}
] | jwplayer/jwplatform-py | be9d31a94f85b8846c8517b5fe2b065c5d7bfad9 | Client with null kwargs does not use default parameters
Currently jwplatform.Client instantiation only uses default parameters if a kwarg doesn't exist. If the kwarg is `None` this value is still used. It would be expected that `None` values for a kwarg use the default value.
**Current**
```python
>>> import jwpla... | diff --git a/jwplatform/client.py b/jwplatform/client.py
index 18edad5..f00b7e1 100644
--- a/jwplatform/client.py
+++ b/jwplatform/client.py
@@ -61,11 +61,11 @@ class Client(object):
self.__key = key
self.__secret = secret
- self._scheme = kwargs.pop('scheme', 'https')
- self._host = k... |
k4cg__nichtparasoup-127 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/nichtparasoup-server.py"
},
{
"changes": {
"added_entities": [
"src/nichtparasoup/nichtparasoup.py:Crawlers._random_weight"
],... | k4cg/nichtparasoup | d9dda8d8b1e9a96b5b16c4c989a232de472c3f77 | 2.0-dev weighted randomness support | diff --git a/src/nichtparasoup-server.py b/src/nichtparasoup-server.py
index f6c3be0..2040b53 100644
--- a/src/nichtparasoup-server.py
+++ b/src/nichtparasoup-server.py
@@ -51,7 +51,7 @@ if __name__ == "__main__":
nichtparasoup = NichtParasoup()
# TODO: write this foo based on some proper settings
- nich... |
k4cg__nichtparasoup-189 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"nichtparasoup/imagecrawler/pr0gramm.py:Pr0gramm._crawl"
],
"edited_modules": [
"nichtparasoup/imagecrawler/pr0gramm.py:Pr0gramm"
]
},
"file": "nichtparasoup/imagecrawle... | k4cg/nichtparasoup | c343f605d005d0b6f635a4a66d2148d0b7b65022 | Pr0gramm crawler stops after paging
there are reports, that the crawler for Pr0gramm does find new images after a while.
maybe reset is not working?
maybe the paging is broken? | diff --git a/HISTORY.md b/HISTORY.md
index 2c0579e..75e7126 100644
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -4,6 +4,13 @@
## Unreleased
+## 2.3.1
+
+### Fix
+
+* fixed the paging of the `Pr0gramm` ImageCrawler in `promoted=True` mode.
+
+
## 2.3.0
### Breaking changes
diff --git a/nichtparasoup/imagecrawler/pr0gr... |
kaiko-ai__eva-416 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/eva/vision/data/datasets/_utils.py:ranges_to_indices"
],
"edited_modules": [
"src/eva/vision/data/datasets/_utils.py:ranges_to_indices"
]
},
"file": "src/eva/vision... | kaiko-ai/eva | dda22c324b630f55b6b1f01a4c8d65bc7d503c11 | Update `TotalSegmentator2D` to fetch all the slides
Currently we sample every 20th slide from a 3d nifti file. We would like to update the dataset to fetch all | diff --git a/src/eva/vision/data/datasets/_utils.py b/src/eva/vision/data/datasets/_utils.py
index 2d2fe30..1a17d7e 100644
--- a/src/eva/vision/data/datasets/_utils.py
+++ b/src/eva/vision/data/datasets/_utils.py
@@ -1,6 +1,6 @@
"""Dataset related function and helper functions."""
-from typing import List, Tuple
+fr... |
kaizendorks__pymongo_inmemory-90 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "pymongo_inmemory/downloader/_patterns.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
... | kaizendorks/pymongo_inmemory | 71c462574eea7d916cb8cef89e3a336abaea4fbd | Click used in internal tooling published to pypi
It seems like `click` is [only a dev dependency](https://github.com/kaizendorks/pymongo_inmemory/blob/5ee786d266c40f29211c646030b49688ec613004/pyproject.toml#L44), but you import it in [user-facing endpoints](https://github.com/kaizendorks/pymongo_inmemory/blob/5ee786d26... | diff --git a/.github/workflows/pypi-publish.yml b/.github/workflows/pypi-publish.yml
index c3324aa..38849ee 100644
--- a/.github/workflows/pypi-publish.yml
+++ b/.github/workflows/pypi-publish.yml
@@ -25,6 +25,9 @@ jobs:
- name: Unit and functional tests
run: |
poetry run pytest
+ - name... |
kaizendorks__pymongo_inmemory-91 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pymongo_inmemory/context.py:Context.__init__",
"pymongo_inmemory/context.py:Context.__str__"
],
"edited_modules": [
"pymongo_inmemory/context.py:Context"
]
},
"... | kaizendorks/pymongo_inmemory | d20eba3ffc53e21040e6b899bc3dc90092ce324d | pymongo_inmemory does not work in a docker container when /tmp directory is mounted. No bypass available.
**Describe the bug**
I have a complicated CLI docker container that I share with my developers. In it, I have created a kubernetes plugin, `kubectl query` which allows us to load internal data into an in-memory an... | diff --git a/README.md b/README.md
index 1e6b132..18ef7ba 100644
--- a/README.md
+++ b/README.md
@@ -7,6 +7,7 @@ A mongo mocking library with an ephemeral MongoDB running in memory.
## What's new?
### v0.4.0-pre
+
- Tooling enhancements. [[PR #90](https://github.com/kaizendorks/pymongo_inmemory/pull/90)]
### v0... |
kaizendorks__pymongo_inmemory-94 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pymongo_inmemory/_pim.py:MongoClient.__init__"
],
"edited_modules": [
"pymongo_inmemory/_pim.py:MongoClient"
]
},
"file": "pymongo_inmemory/_pim.py"
},
{
"chang... | kaizendorks/pymongo_inmemory | a840985e107156afd9bf1a1cdd4a3372e7e5ad44 | The client loses database name
**Describe the bug**
**To Reproduce**
```
>>> import pymongo_inmemory
>>> client = pymongo_inmemory.MongoClient("mongodb://127.0.0.1/test")
{"t":{"$date":"2023-09-28T10:08:22.707Z"},"s":"I", "c":"CONTROL", "id":5324701, "ctx":"-","msg":"Test storage engine does not support enableMa... | diff --git a/README.md b/README.md
index 0411738..1819c0e 100644
--- a/README.md
+++ b/README.md
@@ -10,6 +10,7 @@ A mongo mocking library with an ephemeral MongoDB running in memory.
- Tooling enhancements. [[PR #90](https://github.com/kaizendorks/pymongo_inmemory/pull/90)]
- Configuration for data directory. [[PR... |
kako-nawao__ffconv-25 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ffconv/stream_processors.py:VideoProcessor._init_stream"
],
"edited_modules": [
"ffconv/stream_processors.py:VideoProcessor"
]
},
"file": "ffconv/stream_processors.py"
... | kako-nawao/ffconv | b93056b5cb13eb62cbc8c3aa0e21c45e908d153f | Height-to-Reference Frames matching error
Sometimes the video height does not match the standard values perfectly (720, 1080, etc), and in those cases the stream processor is deciding incorrectly: a video stream with a height if 704 is trying to limit the frames to 4, when it should do it at 8.
When deciding ref fra... | diff --git a/DESCRIPTION.rst b/DESCRIPTION.rst
index d1b41af..2649378 100644
--- a/DESCRIPTION.rst
+++ b/DESCRIPTION.rst
@@ -1,4 +1,4 @@
ffconv
-=======================
+======
Process media files to match profiles using ffmpeg.
\ No newline at end of file
diff --git a/ffconv/stream_processors.py b/ffconv/stream_pr... |
kako-nawao__ffconv-31 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "ffconv/profiles.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ffconv/stream_pro... | kako-nawao/ffconv | 53a304807ccc8c488ea1e335a5d8d3f7ef45d85f | Do not encode audio with less channels than target
Encoding of audio streams is triggered when the number of channels does not match the target, but it should only do so when the input stream value is greater than the target, not less. A *mono* audio stream, for instance, should not need to be converted for the *roku* ... | diff --git a/ffconv/profiles.py b/ffconv/profiles.py
index dc57c5b..6320b69 100644
--- a/ffconv/profiles.py
+++ b/ffconv/profiles.py
@@ -33,7 +33,7 @@ ROKU = {
'audio': {
'codecs': ['mp3', 'aac', 'flac'],
'container': 'mp3',
- 'channels': 2,
+ 'max_channels': 2,
'quality': ... |
kangasta__fdbk-58 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fdbk/_client_connection.py:ClientConnection.get_topics"
],
"edited_modules": [
"fdbk/_client_connection.py:ClientConnection"
]
},
"file": "fdbk/_client_connection.py"
... | kangasta/fdbk | b591821a2cb507fd7fc1f4b86058e600c2dfee58 | DB connection should support template topics | diff --git a/fdbk/_client_connection.py b/fdbk/_client_connection.py
index d691355..eae4135 100644
--- a/fdbk/_client_connection.py
+++ b/fdbk/_client_connection.py
@@ -36,9 +36,14 @@ class ClientConnection(DBConnection):
if not response.ok:
raise RuntimeError(json.dumps(response.json()))
- d... |
kangasta__fdbk-69 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fdbk/_db_connection.py:DBConnection.get_summary",
"fdbk/_db_connection.py:DBConnection._get_topic_statistics",
"fdbk/_db_connection.py:DBConnection._run_data_tools_for_many",
"fd... | kangasta/fdbk | 010f8e8551468608f33e0b939e677104bc147508 | Data tools should not aggregate data if len(data) < aggregate_to | diff --git a/fdbk/_db_connection.py b/fdbk/_db_connection.py
index a92fd00..af155fe 100644
--- a/fdbk/_db_connection.py
+++ b/fdbk/_db_connection.py
@@ -212,7 +212,8 @@ class DBConnection:
until=None,
limit=None,
aggregate_to=None,
- aggregate_with=None):
+ a... |
kangasta__fdbk-72 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fdbk/_db_connection.py:DBConnection._run_data_tools_for_many"
],
"edited_modules": [
"fdbk/_db_connection.py:DBConnection"
]
},
"file": "fdbk/_db_connection.py"
}
] | kangasta/fdbk | 2bb2f886a860d85c74284053124d92c0d4dd9d07 | Data tools should ignore template topics
Do not add warning for missing data if topic is template topic. | diff --git a/fdbk/_db_connection.py b/fdbk/_db_connection.py
index af155fe..66bcf62 100644
--- a/fdbk/_db_connection.py
+++ b/fdbk/_db_connection.py
@@ -312,6 +312,9 @@ class DBConnection:
aggregate_always,
)
for topic_d in topics.values():
+ if topic_d["type"] == "template":
+... |
kangasta__fdbk-77 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fdbk/data_tools/_utils.py:_get_clean_payload"
],
"edited_modules": [
"fdbk/data_tools/_utils.py:_get_clean_payload"
]
},
"file": "fdbk/data_tools/_utils.py"
}
] | kangasta/fdbk | 6f5506f24efbf04c5cc0c1740152d8bab2921f5e | Data tools should add unit inside value payload instead next to it
Currently seems to work as expected for values when value is not in table. | diff --git a/fdbk/data_tools/_utils.py b/fdbk/data_tools/_utils.py
index 702e1dd..3b3f201 100644
--- a/fdbk/data_tools/_utils.py
+++ b/fdbk/data_tools/_utils.py
@@ -103,6 +103,12 @@ def _get_clean_payload(statistic):
topic_name = payload.pop("topic_name")
payload["payload"]["topic_name"] = topic_name
... |
kangasta__fdbk-90 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fdbk/data_tools/_run.py:run_data_tools"
],
"edited_modules": [
"fdbk/data_tools/_run.py:run_data_tools"
]
},
"file": "fdbk/data_tools/_run.py"
},
{
"changes": {... | kangasta/fdbk | a955ad766618af5f21e475a603ca8513d90ef1ab | Data tools should support custom warnings
Forked from #45.
Add option to status data tool to show warning instead of updating status. This could be a separate `warning` function. | diff --git a/fdbk/data_tools/_run.py b/fdbk/data_tools/_run.py
index 442a1ef..7e7ec06 100644
--- a/fdbk/data_tools/_run.py
+++ b/fdbk/data_tools/_run.py
@@ -94,7 +94,7 @@ def run_data_tools(
instruction.get("field"),
instruction.get("parameters")
)
- except ValueErr... |
kangasta__pullnrun-11 | [
{
"changes": {
"added_entities": [
"pullnrun/_log.py:_http_details",
"pullnrun/_log.py:_s3_details"
],
"added_modules": [
"pullnrun/_log.py:_http_details",
"pullnrun/_log.py:_s3_details"
],
"edited_entities": [
"pullnrun/_log.py:log_to_consol... | kangasta/pullnrun | e5a9e4f337915ad48f0aaaac04956c56220a4d56 | Add details logging for S3 pull and push | diff --git a/pullnrun/_log.py b/pullnrun/_log.py
index 89198bd..02bf8c3 100644
--- a/pullnrun/_log.py
+++ b/pullnrun/_log.py
@@ -1,18 +1,47 @@
+def _http_details(output_dict):
+ type_ = output_dict.get('type', '')
+ status = str(output_dict.get('data', {}).get('status', '')).rjust(4)
+
+ file_ = output_dict.ge... |
kangasta__pullnrun-18 | [
{
"changes": {
"added_entities": [
"pullnrun/_log.py:log_to_url",
"pullnrun/_log.py:Log._log"
],
"added_modules": [
"pullnrun/_log.py:log_to_url"
],
"edited_entities": [
"pullnrun/_log.py:Log.__init__",
"pullnrun/_log.py:Log.__call__",
... | kangasta/pullnrun | 10267083359522e5cac8db10ff7b95738aa7607d | Add logging to remote target | diff --git a/pullnrun/_log.py b/pullnrun/_log.py
index 10ce05b..dd06f9a 100644
--- a/pullnrun/_log.py
+++ b/pullnrun/_log.py
@@ -1,7 +1,9 @@
from os import getenv
from uuid import uuid4
-from pullnrun._utils import get_log_entry, timestamp
+from requests import request
+
+from pullnrun._utils import as_list, get_lo... |
kapouille__mongoquery-4 | [
{
"changes": {
"added_entities": [
"mongoquery/__init__.py:is_non_string_sequence"
],
"added_modules": [
"mongoquery/__init__.py:is_non_string_sequence"
],
"edited_entities": [
"mongoquery/__init__.py:Query._match",
"mongoquery/__init__.py:Query._ext... | kapouille/mongoquery | 759677a81968ec264caa65020777cdae11d8a5e2 | Checks against strings don't work properly
See the following case:
```
>>> import mongoquery
>>> a = {"a": "5", "b": 6}
>>> query = mongoquery.Query({"a": 2})
>>> query.match(a)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/site-packages/mongoquery/_... | diff --git a/mongoquery/__init__.py b/mongoquery/__init__.py
index 9fa9482..83dc2ff 100644
--- a/mongoquery/__init__.py
+++ b/mongoquery/__init__.py
@@ -15,6 +15,10 @@ class _Undefined(object):
pass
+def is_non_string_sequence(entry):
+ return isinstance(entry, Sequence) and not isinstance(entry, string_typ... |
karlicoss__promnesia-277 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/promnesia/cannon.py:Spec.keep_query",
"src/promnesia/cannon.py:transform_split"
],
"edited_modules": [
"src/promnesia/cannon.py:Spec",
"src/promnesia/cannon.py:tr... | karlicoss/promnesia | 90ba0d15ac7d04b365363821adb0f722534086f3 | Handle query parameters without values
Right now, pages on isfdb like `http://www.isfdb.org/cgi-bin/title.cgi?2172` are canonicalized to `http://www.isfdb.org/cgi-bin/title.cgi`, which removes important info from the URL.
I made a somewhat hacky solution, but there is perhaps a more elegant way. The solution is in t... | diff --git a/src/promnesia/cannon.py b/src/promnesia/cannon.py
index a3a303f..b76cb9f 100755
--- a/src/promnesia/cannon.py
+++ b/src/promnesia/cannon.py
@@ -105,11 +105,13 @@ default_qkeep = [
# TODO perhaps, decide if fragment is meaningful (e.g. wiki) or random sequence of letters?
class Spec(NamedTuple):
- qk... |
karllark__dust_extinction-229 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"dust_extinction/shapes.py:FM90",
"dust_extinction/shapes.py:FM90_B3"
]
},
"file": "dust_extinction/shapes.py"
}
] | karllark/dust_extinction | d0d94cffef380516afe536e3301bd5906f134148 | Add reasonable bounds for FM90
Work on MW and SMC has resulted in reasonable default bounds for the FM90 shape model. Should be added to the definition of this model. Can always be overridden.
Code snippet with values:
```
fm90_init.C1.bounds = (-2.0, 3.0)
fm90_init.C2.bounds = (-0.1, 1.0)
fm90_ini... | diff --git a/dust_extinction/shapes.py b/dust_extinction/shapes.py
index 3ae5b8e..33f3cee 100644
--- a/dust_extinction/shapes.py
+++ b/dust_extinction/shapes.py
@@ -233,12 +233,13 @@ class FM90(Fittable1DModel):
n_inputs = 1
n_outputs = 1
- C1 = Parameter(description="linear term: y-intercept", default=0... |
kaste__mockito-python-34 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mockito/mocking.py:Mock.get_original_method",
"mockito/mocking.py:Mock.stub"
],
"edited_modules": [
"mockito/mocking.py:Mock"
]
},
"file": "mockito/mocking.py"
... | kaste/mockito-python | 79ae4340635c8298a79b1d6afc8e6b0b5ce26f88 | Invocation of mocked @classmethod defined in super classes fails.
I recently tried mocking a class method and saw my test failing with a cryptic message
`Fail: TypeError: missing a required argument: 'id'` and an exception somewhere in the python library code.
I grabbed the mockito-python code, did some digging a... | diff --git a/mockito/mocking.py b/mockito/mocking.py
index 82be9b2..0955e19 100644
--- a/mockito/mocking.py
+++ b/mockito/mocking.py
@@ -18,17 +18,14 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
-from collections import deque
-import inspect
import functools
+impor... |
kaste__mockito-python-54 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mockito/mocking.py:Mock.restore_method"
],
"edited_modules": [
"mockito/mocking.py:Mock"
]
},
"file": "mockito/mocking.py"
}
] | kaste/mockito-python | 699294f903025623a241a0259cf4c770614c61f2 | Issue unstubbing random.randint
When trying to monkeypatch random.randint and then later unstubbing the original method does not get reinstated. Example:
```
import sys
sys.version
Out[3]: '3.10.4 (main, Mar 31 2022, 03:38:35) [Clang 12.0.0 ]'
import random
import mockito
mockito.__version__
Out[6]: '1.2.2'
... | diff --git a/mockito/mocking.py b/mockito/mocking.py
index e52db5e..7ac5c8c 100644
--- a/mockito/mocking.py
+++ b/mockito/mocking.py
@@ -180,8 +180,11 @@ class Mock(object):
# the one on its class, so we delete as well.
if (
not original_method
- or not inspect.isclass(self.moc... |
kaste__mockito-python-83 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mockito/invocation.py:return_",
"mockito/invocation.py:raise_",
"mockito/invocation.py:AnswerSelector.thenReturn",
"mockito/invocation.py:AnswerSelector.thenRaise"
],
... | kaste/mockito-python | fc042bc9ff2cb29ee9ac8fdbbb82f9a617d095d6 | TypeError: return_() got multiple values for argument 'value'
Seeing an error arising when using `value` as a keyword argument to a mockito `when`.
In `producer.py`:
```
def send(value):
return value
```
In `mocking_check.py`:
```
from mockito import when
import producer
when(producer).send(v... | diff --git a/mockito/invocation.py b/mockito/invocation.py
index 46f4844..01bf682 100644
--- a/mockito/invocation.py
+++ b/mockito/invocation.py
@@ -18,7 +18,6 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
-import functools
import inspect
import operator
from coll... |
kaste__mockito-python-91 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mockito/mocking.py:mock",
"mockito/mocking.py:Dummy.__getattr__"
],
"edited_modules": [
"mockito/mocking.py:_Dummy",
"mockito/mocking.py:mock",
"mockito/mocki... | kaste/mockito-python | d2901d358de495569f80fbe9e19c88d3e68a7941 | deepcopy doesn't work with mock()
It seems to me `mock()` is transformed to `None` by `deepcopy`:
```
from copy import deepcopy
from mockito import mock
m = mock()
print(f'{m=} {deepcopy(m)=}')
```
Which gives:
```
m=<Dummy id=140252977120144> deepcopy(m)=None
```
Is there some way around this? | diff --git a/docs/recipes.rst b/docs/recipes.rst
index 6a43efa..4cba021 100644
--- a/docs/recipes.rst
+++ b/docs/recipes.rst
@@ -73,3 +73,28 @@ It's basically the same problem, but we need to add support for the context mana
assert res.text == 'Ok'
+Deepcopies
+----------
+
+Python's `deepcopy` is tied to ... |
kaste__mockito-python-93 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mockito/invocation.py:return_",
"mockito/invocation.py:raise_",
"mockito/invocation.py:AnswerSelector.thenReturn",
"mockito/invocation.py:AnswerSelector.thenRaise",
"mock... | kaste/mockito-python | 958b1d8a5bc75eda5a6523c472ddea4ab4900a3f | Feature request: add a `.thenDoNothing()` method to `AnswerSelector`?
The original mockito in Java has that and it's very convenient; can this be implemented in python mockito as well?
I'm a beginner in python but AFAICS this can be implemented as such:
```python
def thenDoNothing(self):
thenAnswer(lambda: ... | diff --git a/CHANGES.txt b/CHANGES.txt
index 3864f5b..d6cd808 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -6,6 +6,9 @@ Release 1.5.5
--------------------------------
- Improved behavior of the ad-hoc methods of mocks. (#92)
+- Make the shortcut `when(mock).foo().thenReturn()` officially work and just assume
+ t... |
kb-press__ndsplines-66 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ndsplines/__init__.py:set_impl"
],
"edited_modules": [
"ndsplines/__init__.py:set_impl"
]
},
"file": "ndsplines/__init__.py"
}
] | kb-press/ndsplines | 90f48580275f10703123daab2d37685391c4281e | `set_impl` should have a default
The `set_impl` function should handle a `name` that is not `"cython"` or `"numpy"` by raising an exception. | diff --git a/ndsplines/__init__.py b/ndsplines/__init__.py
index 86d81e0..08cacac 100644
--- a/ndsplines/__init__.py
+++ b/ndsplines/__init__.py
@@ -3,34 +3,41 @@ from .version import __version__
evaluate_spline = None
+
def set_impl(name):
"""Set bspl implementation to either cython or numpy.
Paramet... |
kblin__ncbi-genome-download-106 | [
{
"changes": {
"added_entities": [
"ncbi_genome_download/core.py:fill_metadata"
],
"added_modules": [
"ncbi_genome_download/core.py:fill_metadata"
],
"edited_entities": [
"ncbi_genome_download/core.py:config_download",
"ncbi_genome_download/core.py:d... | kblin/ncbi-genome-download | a46446733e70b7754b2bcb847cb6be3544ce73bc | metadata option unworking
# version of ncbi-genome-download
`0.2.11`
# command
```
python3 ncbi-genome-download/ncbi-genome-download-runner.py --verbose --genus "Kluyvera" --metadata
-table data.tsv --format fasta -p 10 --retries 1 bacteria
```
# result
All genomes are downloaded but the data.tsv file do... | diff --git a/ncbi_genome_download/core.py b/ncbi_genome_download/core.py
index 69efc2b..c99fd6b 100644
--- a/ncbi_genome_download/core.py
+++ b/ncbi_genome_download/core.py
@@ -192,15 +192,19 @@ def config_download(config):
if config.parallel == 1:
for entry, group in download_candidates:
- ... |
kblin__ncbi-genome-download-25 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ncbi_genome_download/core.py:save_and_check"
],
"edited_modules": [
"ncbi_genome_download/core.py:save_and_check"
]
},
"file": "ncbi_genome_download/core.py"
}
] | kblin/ncbi-genome-download | 07b61f5086322e87b4412480e2bd99bdadc57421 | OSError: [Errno 17] File exists
Been getting this a bit when I restart jobs that failed due to unreachable network:
```
NFO: Starting new HTTPS connection (1): ftp.ncbi.nlm.nih.gov
DEBUG: "GET /genomes/all/GCA_001443705.1_ASM144370v1/GCA_001443705.1_ASM144370v1_genomic.gbff.gz HTTP/1.1" 200 185238057
Traceback (most r... | diff --git a/ncbi_genome_download/core.py b/ncbi_genome_download/core.py
index 2a47d97..f2389df 100644
--- a/ncbi_genome_download/core.py
+++ b/ncbi_genome_download/core.py
@@ -286,6 +286,8 @@ def save_and_check(response, local_file, expected_checksum, symlink_path):
return False
if symlink_path is not ... |
kdunee__pyembeddedfhir-19 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyembeddedfhir/fhir_runner.py:_kill_orphaned_containers",
"pyembeddedfhir/fhir_runner.py:_kill_orphaned_networks",
"pyembeddedfhir/fhir_runner.py:FHIRRunner.__init__",
"pyembedde... | kdunee/pyembeddedfhir | e397c352453b9b910e807037826ff3c03ca3c413 | Resolve outstanding TODOs related to error handling | diff --git a/HISTORY.rst b/HISTORY.rst
index 6220350..3518afd 100755
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -2,6 +2,8 @@
History
=======
+#11 Improved error handling.
+
1.1.2 (2021-11-07)
------------------
diff --git a/pyembeddedfhir/fhir_runner.py b/pyembeddedfhir/fhir_runner.py
index 46cdef0..44ed6f0 100644
... |
kedro-org__kedro-2378 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kedro/framework/cli/utils.py:_split_params"
],
"edited_modules": [
"kedro/framework/cli/utils.py:_split_params"
]
},
"file": "kedro/framework/cli/utils.py"
},
{
... | kedro-org/kedro | 7d7f1dd3e238f2054315df7de631827754e424d9 | [BUG] Passing runtime nested params to `kedro run --params` overwrites params from config files in latest release
Hello team - nice to be back in these discussions :)
## Description
There was a regression in the latest release (0.18.5), which introduced `OmegaConf` for parsing parameters provided to the `kedro run ... | diff --git a/docs/source/development/commands_reference.md b/docs/source/development/commands_reference.md
index 9c80fc0e..64792e4a 100644
--- a/docs/source/development/commands_reference.md
+++ b/docs/source/development/commands_reference.md
@@ -408,7 +408,7 @@ _This command will be deprecated from Kedro version 0.19.... |
kedro-org__kedro-2869 | [
{
"changes": {
"added_entities": [
"kedro/config/omegaconf_config.py:OmegaConfigLoader._register_new_resolvers"
],
"added_modules": null,
"edited_entities": [
"kedro/config/omegaconf_config.py:OmegaConfigLoader.__init__"
],
"edited_modules": [
"kedro/c... | kedro-org/kedro | 73a35bb13675d6c6eae83acdc6da2e501342fc16 | Allow registering of custom resolvers to OmegaConfigLoader through `CONFIG_LOADER_ARGS`
## Description
Allowing users to register custom resolvers will make it easy for users to do more advanced interpolation in their configs.
OmegaConf documentation about custom resolvers - https://omegaconf.readthedocs.io/en/2.3_br... | diff --git a/RELEASE.md b/RELEASE.md
index 2fcf553b..ae0714b8 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -11,6 +11,7 @@
# Upcoming Release 0.18.13
## Major features and improvements
+* Allowed registering of custom resolvers to `OmegaConfigLoader` through `CONFIG_LOADER_ARGS`.
## Bug fixes and other changes
d... |
kedro-org__kedro-2921 | [
{
"changes": {
"added_entities": [
"kedro/config/omegaconf_config.py:OmegaConfigLoader._register_globals_resolver",
"kedro/config/omegaconf_config.py:OmegaConfigLoader._get_globals_value"
],
"added_modules": null,
"edited_entities": [
"kedro/config/omegaconf_confi... | kedro-org/kedro | 74b2a884b232df7f72446cd049dae4aaad04ab88 | Add globals functionality to `OmegaConfigLoader` using custom "globals" resolver
# Description
After the introduction of variable interpolation in `OmegaConfigLoader`, two issues still stand -
* Sharing variables across different configs (catalog, parameters etc)
* Sharing variables across different envs (ba... | diff --git a/RELEASE.md b/RELEASE.md
index 169485d0..bd338add 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -14,6 +14,8 @@
* Allowed registering of custom resolvers to `OmegaConfigLoader` through `CONFIG_LOADER_ARGS`.
* Added support for Python 3.11. This includes tackling challenges like dependency pinning and test ad... |
kedro-org__kedro-3211 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "kedro/framework/cli/starters.py"
}
] | kedro-org/kedro | ad6d68d8c13f9f7cc412bea83ee073afa9b31f53 | Add new `spaceflights` starters to `--starter` flag options
## Description
Users should be able to use the [new `spaceflights` starters](https://github.com/kedro-org/kedro/issues/2838) through `kedro new --starter=...`.
With the starter flag they would get to full project. If they use `--add-ons` instead they can s... | diff --git a/RELEASE.md b/RELEASE.md
index f2f12b30..e4632677 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -3,6 +3,7 @@
## Major features and improvements
* Dropped Python 3.7 support.
* Introduced add-ons to the `kedro new` CLI flow.
+* The new spaceflights starters, `spaceflights-pandas`, `spaceflights-pandas-viz`,... |
kedro-org__kedro-3229 | [
{
"changes": {
"added_entities": [
"kedro/config/omegaconf_config.py:OmegaConfigLoader._destructive_merge",
"kedro/config/omegaconf_config.py:OmegaConfigLoader._soft_merge"
],
"added_modules": null,
"edited_entities": [
"kedro/config/omegaconf_config.py:OmegaConfi... | kedro-org/kedro | fd2151336afb5bf6ed792b336a07a7107e2e6703 | Use soft-merge for certain configuration files for `OmegaConfLoader`
## Description
At the moment all configuration files are merged in a destructive way. This means all fields/keys are overwritten when two files are merged e.g.:
Base catalog file:
```yml
regressor:
type: pickle.PickleDataSet
filepath: data... | diff --git a/RELEASE.md b/RELEASE.md
index d1e99317..f444a298 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -4,6 +4,7 @@
* Dropped Python 3.7 support.
* Introduced add-ons to the `kedro new` CLI flow.
* The new spaceflights starters, `spaceflights-pandas`, `spaceflights-pandas-viz`, `spaceflights-pyspark`, and `spacef... |
kedro-org__kedro-3314 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kedro/pipeline/node.py:Node.__init__"
],
"edited_modules": [
"kedro/pipeline/node.py:Node"
]
},
"file": "kedro/pipeline/node.py"
}
] | kedro-org/kedro | e9fbe441632c6fce291965b957a44e4434d81c90 | Add validation to node tags
## Description
Currently we do not validate or restrict the format of tags that can be added to nodes. This is inconsistent with other user-defined values. As part of #2014 it was agreed that tags should be subject to the same constraints as node names (see: https://github.com/kedro-org/ked... | diff --git a/RELEASE.md b/RELEASE.md
index 00339282..0b67ad73 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -12,6 +12,7 @@
## Bug fixes and other changes
* Added a new field `add-ons` to `pyproject.toml` when a project is created.
* Reduced `spaceflights` data to minimise waiting times during tutorial execution.
+* Ad... |
kedro-org__kedro-3363 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "kedro/framework/cli/starters.py"
}
] | kedro-org/kedro | 1e9f0c96f8cb452e103babaf0ac5a01cb5e65bba | Improving shortname handling of --addons flag
## Description
The shortnames we've allocated for the add ons fluctuate on whether they are plural or not. log vs logs, test vs tests.
At the moment the short names are: `log,test,lint,data,docs,viz`. But many engineers instinctively think of `logs` rather than `log... | diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py
index 6c976d58..4384ebc1 100644
--- a/kedro/framework/cli/starters.py
+++ b/kedro/framework/cli/starters.py
@@ -110,8 +110,11 @@ _OFFICIAL_STARTER_SPECS = {spec.alias: spec for spec in _OFFICIAL_STARTER_SPECS}
TOOLS_SHORTNAME_TO_NUMBER = {
... |
kedro-org__kedro-3370 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kedro/framework/cli/starters.py:_validate_config_file_against_prompts"
],
"edited_modules": [
"kedro/framework/cli/starters.py:_validate_config_file_against_prompts"
]
},
... | kedro-org/kedro | 57854f22209ed8912e481ad742c79c445f56dc99 | Make it possible to create project from config without providing `add_ons` or `example_pipeline`
## Description
Creating a project from config without providing `add_ons` or `example_pipeline` fails.
## Context
`config.yml`:
```yaml
project_name: My First Kedro Project
repo_name: testing-kedro
python_package... | diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py
index 638616c9..6c976d58 100644
--- a/kedro/framework/cli/starters.py
+++ b/kedro/framework/cli/starters.py
@@ -708,10 +708,20 @@ def _validate_config_file_against_prompts(
"""
if config is None:
raise KedroCliError("Confi... |
kedro-org__kedro-3424 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kedro/runner/parallel_runner.py:ParallelRunner._run"
],
"edited_modules": [
"kedro/runner/parallel_runner.py:ParallelRunner"
]
},
"file": "kedro/runner/parallel_runner.... | kedro-org/kedro | db1a81a05f26759180b5a0da4d395ebd52f02662 | Inform users about not using `--async`
## Description
As discussed in https://github.com/kedro-org/kedro/issues/2036#issuecomment-1460425776 there's a possibility that users aren't aware of the `--async` feature. Instead of only logging that the async is enabled when it is, change the logging to mention that async isn... | diff --git a/RELEASE.md b/RELEASE.md
index 401d6efc..f5ddf807 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -3,8 +3,7 @@
## Major features and improvements
## Bug fixes and other changes
-
-## Breaking changes to the API
+* Added logging about not using async mode in `SequentiallRunner` and `ParallelRunner`.
## Do... |
kedro-org__kedro-3439 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kedro/framework/cli/starters.py:new",
"kedro/framework/cli/starters.py:_create_project"
],
"edited_modules": [
"kedro/framework/cli/starters.py:new",
"kedro/framework... | kedro-org/kedro | 543fa8b359160591243eb363328e25a517d9a9bc | Remove redundant hint if user is already using the hint
## Description
<!-- Short description of the problem here. -->
If users use `kedro new --addons all --name all --example y` then the message:
```
To skip the interactive flow you can run `kedro new` with
kedro new --name=<your-project-name> --addons=<your... | diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py
index 0cdfb170..3931b195 100644
--- a/kedro/framework/cli/starters.py
+++ b/kedro/framework/cli/starters.py
@@ -299,6 +299,13 @@ def new( # noqa: PLR0913
_create_project(project_template, cookiecutter_args)
+ if prompts_required... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.