instance_id
stringlengths
10
57
file_changes
listlengths
1
15
repo
stringlengths
7
53
base_commit
stringlengths
40
40
problem_statement
stringlengths
11
52.5k
patch
stringlengths
251
7.06M
matplotlib__matplotlib-19961
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/figure.py:FigureBase.get_tightbbox" ], "edited_modules": [ "lib/matplotlib/figure.py:FigureBase" ] }, "file": "lib/matplotlib/figure.py" } ]
matplotlib/matplotlib
a051169c1b51a36c270b7b696ec86fae8f2f23e8
subfigures missing bbox_inches attribute in inline backend <!--To help us understand and resolve your issue, please fill out the form to the best of your ability.--> <!--You can feel free to delete the sections that do not apply.--> ### Bug report Trying to add subplots to subfigures when using the jupyter inline ...
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py index a9d435eb39..6691e91713 100644 --- a/lib/matplotlib/figure.py +++ b/lib/matplotlib/figure.py @@ -1650,7 +1650,11 @@ default: %(va)s and (b.width != 0 or b.height != 0))] if len(bb) == 0: - return self.bbox_inc...
matplotlib__matplotlib-20009
[ { "changes": { "added_entities": [ "lib/matplotlib/axis.py:Axis.isDefault_majloc", "lib/matplotlib/axis.py:Axis.isDefault_majfmt", "lib/matplotlib/axis.py:Axis.isDefault_minloc", "lib/matplotlib/axis.py:Axis.isDefault_minfmt" ], "added_modules": null, "edi...
matplotlib/matplotlib
a94acb3d2c6829d7ce3a4ef2cc33058c677e0526
Removal of x-shared polar axes causes crash <!--To help us understand and resolve your issue, please fill out the form to the best of your ability.--> <!--You can feel free to delete the sections that do not apply.--> ### Bug report **Bug summary** All's in the title. (Note that x-sharing (which really mea...
diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py index 66443a42e8..82c56470b4 100644 --- a/lib/matplotlib/axis.py +++ b/lib/matplotlib/axis.py @@ -552,6 +552,8 @@ class Ticker: def __init__(self): self._locator = None self._formatter = None + self._locator_is_default = True + ...
matplotlib__matplotlib-20332
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/collections.py:QuadMesh.__init__" ], "edited_modules": [ "lib/matplotlib/collections.py:QuadMesh" ] }, "file": "lib/matplotlib/collections.py" } ]
matplotlib/matplotlib
08f4629d918b60f5c8e0f35f6a24ecad43088752
QuadMesh default for shading inadvertently changed. In #20237 we messed with the signature for QuadMesh. However the default for shading was changed from `'flat'` to `False`, which is not an allowable value. 1. This should be fixed, both in the code and the change note 2. QuadMesh should probably gain a test on ...
diff --git a/doc/api/next_api_changes/deprecations/20237-TH.rst b/doc/api/next_api_changes/deprecations/20237-TH.rst index 2120fb9b9b..435986f94f 100644 --- a/doc/api/next_api_changes/deprecations/20237-TH.rst +++ b/doc/api/next_api_changes/deprecations/20237-TH.rst @@ -3,11 +3,11 @@ QuadMesh signature The ``QuadMesh`...
matplotlib__matplotlib-20373
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/mpl_toolkits/axes_grid1/axes_grid.py:Grid.__init__" ], "edited_modules": [ "lib/mpl_toolkits/axes_grid1/axes_grid.py:Grid" ] }, "file": "lib/mpl_toolkits/axes_grid1...
matplotlib/matplotlib
89ce4fbdd10694520bd0727f5818e04b75ca96e7
Incorrect axes positioning in axes_grid.Grid with direction='column' <!--To help us understand and resolve your issue, please fill out the form to the best of your ability.--> <!--You can feel free to delete the sections that do not apply.--> ### Bug report **Bug summary** Axes of `mpl_toolkits.axes_grid1.axe...
diff --git a/lib/mpl_toolkits/axes_grid1/axes_grid.py b/lib/mpl_toolkits/axes_grid1/axes_grid.py index e3d2939b8a..7720b7bbd6 100644 --- a/lib/mpl_toolkits/axes_grid1/axes_grid.py +++ b/lib/mpl_toolkits/axes_grid1/axes_grid.py @@ -98,7 +98,8 @@ class Grid: If not None, only the first *ngrids* axes in the g...
matplotlib__matplotlib-21597
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/transforms.py:TransformNode.__deepcopy__" ], "edited_modules": [ "lib/matplotlib/transforms.py:TransformNode" ] }, "file": "lib/matplotlib/transforms.py"...
matplotlib/matplotlib
54cf7bc44ade7aa3b664b20b175e21294084bd9c
[Bug]: `ValueError` upon deepcopy of a `Figure` object ### Bug summary A deepcopy of a `Figure` object results in `ValueError: 'Spines' object does not contain a '__deepcopy__' spine`. This issue surfaced in a bug report of `schemdraw`: https://bitbucket.org/cdelker/schemdraw/issues/56/copydeepcopy-drawing-fails ...
diff --git a/lib/matplotlib/gridspec.py b/lib/matplotlib/gridspec.py index a29cfb47b0..980be6a25e 100644 --- a/lib/matplotlib/gridspec.py +++ b/lib/matplotlib/gridspec.py @@ -371,7 +371,7 @@ class GridSpec(GridSpecBase): If not given, all columns will have the same width. height_ratios : array-l...
matplotlib__matplotlib-21741
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/mpl_toolkits/mplot3d/axes3d.py:Axes3D.draw" ], "edited_modules": [ "lib/mpl_toolkits/mplot3d/axes3d.py:Axes3D" ] }, "file": "lib/mpl_toolkits/mplot3d/axes3d.py" }...
matplotlib/matplotlib
73304d2936730939609880cb27068f2777e940c5
[Bug]: unavoidable `DeprecationWarning` when using `Patch3D` ### Bug summary There's currently no nice way to avoid having a deprecation warning issued when using a custom subclass of `Patch3D` during drawing, caused by this helper function: https://github.com/matplotlib/matplotlib/blob/73304d2936730939609880cb27068f2...
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py index 3aaf31610d..e883da3f8b 100644 --- a/lib/mpl_toolkits/mplot3d/axes3d.py +++ b/lib/mpl_toolkits/mplot3d/axes3d.py @@ -12,6 +12,7 @@ Module containing Axes3D, an object which can plot 3D objects on a from collections import defau...
matplotlib__matplotlib-21751
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "examples/misc/coords_report.py:millions" ], "edited_modules": [ "examples/misc/coords_report.py:millions" ] }, "file": "examples/misc/coords_report.py" }, { "ch...
matplotlib/matplotlib
d2ee3d53d089c38a63c257683fd53f73decf1bb0
[Bug]: Regression on `tight_layout` when manually adding axes for colorbars ### Bug summary When creating manual floating axes to fill with colorbars, previous to version 3.5 a call to `fig.tight_layout()` on a figure with manually located axes would simply raise a warning that the figure contains axes incompatbile wi...
diff --git a/.gitattributes b/.gitattributes index a0c2c8627a..0db21d3c86 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,5 +1,4 @@ * text=auto -*.m diff=objc *.ppm binary *.svg binary *.svg linguist-language=true diff --git a/doc/users/explain/event_handling.rst b/doc/users/explain/event_handling.rst index ...
matplotlib__matplotlib-21785
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/backend_bases.py:_check_savefig_extra_args" ], "edited_modules": [ "lib/matplotlib/backend_bases.py:_check_savefig_extra_args" ] }, "file": "lib/matplotl...
matplotlib/matplotlib
25a54a4fef67997c1883ecfbdf5a9065ccc31c3c
[Bug]: ConciseDateFormatter not showing offset ### Bug summary When I create time series plot with too big time range, I can't see offset in lower right corner. ### Code for reproduction ```python import numpy as np import pandas as pd import matplotlib.pyplot as plt LEN = 40000 dt_index = pd.date_range...
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py index e3d1b3efbd..7dbca2e64b 100644 --- a/lib/matplotlib/backend_bases.py +++ b/lib/matplotlib/backend_bases.py @@ -1601,12 +1601,7 @@ def _check_savefig_extra_args(func=None, extra_kwargs=()): r'^savefig|print_[A-Za-z0-9]+|_no_...
matplotlib__matplotlib-21818
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "lib/matplotlib/_api/__init__.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "ed...
matplotlib/matplotlib
2e4189b357e1c6d494cec151f58dce55881a673a
[Bug]: using `set_offsets` on scatter object raises TypeError ### Bug summary `plt.scatter` can accept datetime as arguments, but `set_offsets` method of it's returns cannot. ### Code for reproduction ```python import numpy as np import matplotlib.pyplot as plt x = np.linspace(0, 10) y = np.sin(x) d = x...
diff --git a/lib/matplotlib/_api/__init__.py b/lib/matplotlib/_api/__init__.py index dfd3f6820f..7cfd9027c0 100644 --- a/lib/matplotlib/_api/__init__.py +++ b/lib/matplotlib/_api/__init__.py @@ -3,7 +3,7 @@ Helper functions for managing the Matplotlib API. This documentation is only relevant for Matplotlib developer...
matplotlib__matplotlib-21845
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/figure.py:FigureBase.get_tightbbox" ], "edited_modules": [ "lib/matplotlib/figure.py:FigureBase" ] }, "file": "lib/matplotlib/figure.py" } ]
matplotlib/matplotlib
59732ace84f3e4a0fb94084ee11598c655467d62
[Bug]: Top of plot clipped when using Subfigures without suptitle ### Bug summary When using subfigures without setting a suptitle for the root figure, the top of the plot is clipped out. This includes the suptitle for the top subfigure. ### Code for reproduction ```python def example_plot(ax, fontsize=12, hide_lab...
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py index b301149961..a83a25825b 100644 --- a/lib/matplotlib/figure.py +++ b/lib/matplotlib/figure.py @@ -1648,8 +1648,9 @@ default: %(va)s if (np.isfinite(b.width) and np.isfinite(b.height) and (b.width != 0 or b.height != 0...
matplotlib__matplotlib-21916
[ { "changes": { "added_entities": [ "lib/matplotlib/colors.py:_make_norm_from_scale", "lib/matplotlib/colors.py:Norm.__reduce__", "lib/matplotlib/colors.py:_picklable_norm_constructor" ], "added_modules": [ "lib/matplotlib/colors.py:_make_norm_from_scale", ...
matplotlib/matplotlib
1535cdc3500762088e53178efc22956365dcdac7
[Bug]: make_norm_from_scale should create picklable classes even when used in-line. ### Bug summary The new `matplotlib.colors.make_norm_from_scale` helper dynamically generates a norm class from a scale class. Currently, in the codebase, it is only used as a decorator to create "toplevel" classes (e.g., it is used t...
diff --git a/lib/matplotlib/colors.py b/lib/matplotlib/colors.py index d138443cc7..d3e53e0ef0 100644 --- a/lib/matplotlib/colors.py +++ b/lib/matplotlib/colors.py @@ -1507,9 +1507,26 @@ def make_norm_from_scale(scale_cls, base_norm_cls=None, *, init=None): if init is None: def init(vmin=None, vmax=None,...
matplotlib__matplotlib-22002
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "examples/color/named_colors.py:plot_colortable" ], "edited_modules": [ "examples/color/named_colors.py:plot_colortable" ] }, "file": "examples/color/named_colors.py" ...
matplotlib/matplotlib
e779b97174ff3ab2737fbdffb432ef8689201602
Memory leaks on matplotlib 3.4.2 (and 3.4.0) <!--To help us understand and resolve your issue, please fill out the form to the best of your ability.--> <!--You can feel free to delete the sections that do not apply.--> ### Bug report **Bug summary** Multiple different memory related errors when running as a...
diff --git a/environment.yml b/environment.yml index a64ad92fa7..2e434de2f3 100644 --- a/environment.yml +++ b/environment.yml @@ -47,6 +47,7 @@ dependencies: - nbformat!=5.0.0,!=5.0.1 - pandas!=0.25.0 - pikepdf + - psutil - pre-commit - pydocstyle>=5.1.0 - pytest!=4.6.0,!=5.4.0 diff --git a/examples...
matplotlib__matplotlib-22009
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/legend_handler.py:HandlerPolyCollection._update_prop" ], "edited_modules": [ "lib/matplotlib/legend_handler.py:HandlerPolyCollection" ] }, "file": "lib/m...
matplotlib/matplotlib
ec99c15612f8d8d5267ce4e5a9deb309fad4f5f4
[Bug]: Regression: Setting alpha on legend handle changes patch color ### Bug summary Bug #11702 seems to have reappeared: calling set_alpha on a legend handle causes the color of the patch in the legend to change in a filled area plot. ### Code for reproduction ```python import matplotlib.pyplot as plt import pand...
diff --git a/lib/matplotlib/legend_handler.py b/lib/matplotlib/legend_handler.py index 6cf6b8ec31..86f8b0b7b0 100644 --- a/lib/matplotlib/legend_handler.py +++ b/lib/matplotlib/legend_handler.py @@ -788,6 +788,8 @@ class HandlerPolyCollection(HandlerBase): # Directly set Patch color attributes (must be RGBA tu...
matplotlib__matplotlib-22018
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/cbook/__init__.py:_reshape_2D" ], "edited_modules": [ "lib/matplotlib/cbook/__init__.py:_reshape_2D" ] }, "file": "lib/matplotlib/cbook/__init__.py" } ...
matplotlib/matplotlib
ec99c15612f8d8d5267ce4e5a9deb309fad4f5f4
[Bug]: matplotlib 3.3 changed how plt.hist handles iterables of zero-dimensional arrays. ### Bug summary matplotlib 3.3 changed how `plt.hist` handles iterables of zero-dimensional arrays. This has come up because JAX has no scalar type, and recently changed its iteration protocol to return zero-dimensional JAX arrays...
diff --git a/lib/matplotlib/cbook/__init__.py b/lib/matplotlib/cbook/__init__.py index dcab6b3944..efaabd1e09 100644 --- a/lib/matplotlib/cbook/__init__.py +++ b/lib/matplotlib/cbook/__init__.py @@ -1389,9 +1389,13 @@ def _reshape_2D(X, name): for xi in X: # check if this is iterable, except for strings w...
matplotlib__matplotlib-22066
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/ticker.py:ScalarFormatter.format_data" ], "edited_modules": [ "lib/matplotlib/ticker.py:ScalarFormatter" ] }, "file": "lib/matplotlib/ticker.py" } ]
matplotlib/matplotlib
ac2a14581949bcf869e969f28a21ee479d2fc250
[Bug]: Additive offset with trailing zeros ### Bug summary The significand has trailing zeros. ### Code for reproduction ```python import matplotlib.pyplot as plt fig, ax = plt.subplots() ax.plot([110_000, 110_001]) ``` ### Actual outcome ![grafik](https://user-images.githubusercontent.com/19879328/147680...
diff --git a/lib/matplotlib/ticker.py b/lib/matplotlib/ticker.py index 0d52954ac6..bd9da7437e 100644 --- a/lib/matplotlib/ticker.py +++ b/lib/matplotlib/ticker.py @@ -664,7 +664,7 @@ class ScalarFormatter(Formatter): s = round(value / 10**e, 10) exponent = self._format_maybe_minus_and_locale("%d", e) ...
matplotlib__matplotlib-22244
[ { "changes": { "added_entities": [ "lib/matplotlib/colorbar.py:Colorbar.locator", "lib/matplotlib/colorbar.py:Colorbar.minorlocator", "lib/matplotlib/colorbar.py:Colorbar.formatter", "lib/matplotlib/colorbar.py:Colorbar.minorformatter" ], "added_modules": null, ...
matplotlib/matplotlib
4b3d5134e506f77153718e335e81af4f6962d8ce
[Bug]: Wrong minor colorbar ticks in the presence of BoundaryNorm ### Bug summary The minor colorbar ticks are messed up for matplotlib3.5+. But, it works well for v3.4.3. ### Code for reproduction ```python import matplotlib import numpy as np import matplotlib.pyplot as plt bounds = np.array([0, 0.7, 0.75, 0....
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py index aef5ba352e..b9cd3fe820 100644 --- a/lib/matplotlib/colorbar.py +++ b/lib/matplotlib/colorbar.py @@ -440,9 +440,10 @@ class Colorbar: linewidths=[0.5 * mpl.rcParams['axes.linewidth']]) self.ax.add_collection(self.dividers) ...
matplotlib__matplotlib-22361
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/dates.py:_wrap_in_tex" ], "edited_modules": [ "lib/matplotlib/dates.py:_wrap_in_tex" ] }, "file": "lib/matplotlib/dates.py" } ]
matplotlib/matplotlib
2fe38b56b4a4dd3dc3afef48aaaddbea519f85f7
[Bug]: text.usetex Vs. DateFormatter ### Bug summary When I set `rcParams['text.usetex'] = True`, I can't skip line in date format. For example, I can't use `DateFormatter('%d/%m\n%Y')`. Removing the skip line `\n` it works: `'%d/%m\n%Y' --> '%d/%m/%Y'`. It was working before. It's stopped working since my...
diff --git a/lib/matplotlib/dates.py b/lib/matplotlib/dates.py index 69a04bb672..ad88313006 100644 --- a/lib/matplotlib/dates.py +++ b/lib/matplotlib/dates.py @@ -173,7 +173,6 @@ import datetime import functools import logging import math -import re from dateutil.rrule import (rrule, MO, TU, WE, TH, FR, SA, SU, Y...
matplotlib__matplotlib-22419
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/axes/_base.py:_AxesBase.set_xlim", "lib/matplotlib/axes/_base.py:_AxesBase.set_ylim" ], "edited_modules": [ "lib/matplotlib/axes/_base.py:_AxesBase" ] ...
matplotlib/matplotlib
3804f5e31153d78c49cacdc3d266bd550e5bdf6c
[MNT]: Confusing prompt in docs issue template ### Summary In the docs issue template it prompts for the matplotlib version from python ![image](https://user-images.githubusercontent.com/10111092/152629886-7905183b-ec13-4991-b332-eefa8d20df2f.png) this is confusing because I most interact with the docs via the br...
diff --git a/.github/ISSUE_TEMPLATE/documentation.yml b/.github/ISSUE_TEMPLATE/documentation.yml index f2c34692ed..1fecbab4c3 100644 --- a/.github/ISSUE_TEMPLATE/documentation.yml +++ b/.github/ISSUE_TEMPLATE/documentation.yml @@ -30,10 +30,3 @@ body: * This line should be be changed to say [...] * In...
matplotlib__matplotlib-22578
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/_api/deprecation.py:deprecated" ], "edited_modules": [ "lib/matplotlib/_api/deprecation.py:deprecated" ] }, "file": "lib/matplotlib/_api/deprecation.py" ...
matplotlib/matplotlib
8fe19dc2c2e3dee57230aca186a080af23de64de
[Bug]: Erroneous deprecation warning help message ### Bug summary When using the `matplotlib.dates.epoch2num` function I get a deprecation warning to use `mdates.date2num` instead. I cannot find out where `mdates` is supposed to be, but `matplotlib.dates.date2num` works pretty well. ### Code for reproduction ```pyth...
diff --git a/doc/devel/contributing.rst b/doc/devel/contributing.rst index 287d04fa2f..225219cc58 100644 --- a/doc/devel/contributing.rst +++ b/doc/devel/contributing.rst @@ -316,6 +316,8 @@ Introducing All these helpers take a first parameter *since*, which should be set to the next point release, e.g. "3.x". ...
matplotlib__matplotlib-22594
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/axes/_axes.py:Axes.errorbar" ], "edited_modules": [ "lib/matplotlib/axes/_axes.py:Axes" ] }, "file": "lib/matplotlib/axes/_axes.py" } ]
matplotlib/matplotlib
4a3c5d6a686534aa6f13fd13a1686facf0920287
[Bug]: ValueError: Do not know how to convert "list" to dashes; when using axes errorbar. ### Bug summary When ploting using axes errorbar, if the user defines either a x or y error and dashes at the same time the following error is shown: "ValueError: Do not know how to convert [1, 1] to dashes". The problem disa...
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py index 606f3c83ce..3026e681f7 100644 --- a/lib/matplotlib/axes/_axes.py +++ b/lib/matplotlib/axes/_axes.py @@ -3411,7 +3411,8 @@ class Axes(_AxesBase): for key in ['marker', 'markersize', 'markerfacecolor', 'markeredge...
matplotlib__matplotlib-22627
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/_constrained_layout.py:do_constrained_layout", "lib/matplotlib/_constrained_layout.py:make_layoutgrids" ], "edited_modules": [ "lib/matplotlib/_constrained_lay...
matplotlib/matplotlib
a436253d1d672cd46b0da93acdd868d792f2dbb8
[ENH]: support rect with constrained_layout ("layout only to part of the figure") ### Problem tight_layout supports a rect option ("layout axes so that they fit within this rect instead of filling the entire figure"). It could be nice if constrained_layout also supported that. As an example use case, requested by ...
diff --git a/lib/matplotlib/_constrained_layout.py b/lib/matplotlib/_constrained_layout.py index 891b1ca8b0..db8d8c5fe3 100644 --- a/lib/matplotlib/_constrained_layout.py +++ b/lib/matplotlib/_constrained_layout.py @@ -64,7 +64,7 @@ for more discussion of the algorithm with examples. ################################...
matplotlib__matplotlib-22665
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/colors.py:to_rgba_array" ], "edited_modules": [ "lib/matplotlib/colors.py:to_rgba_array" ] }, "file": "lib/matplotlib/colors.py" } ]
matplotlib/matplotlib
e3c819516689ce436e90cd11b1dd2948e7a5f6f2
Leave color parameter empty should be fine[ENH]: ### Problem Sometimes, I want to leave the facecolor empty to avoid overlap with other point and at the same time, I don't want to use alpha parameter since it will change the color actually. What I want is to ask you if you can remove the warning _"MatplotlibDeprecati...
diff --git a/lib/matplotlib/colors.py b/lib/matplotlib/colors.py index 6d126e6725..ec6abf1dd7 100644 --- a/lib/matplotlib/colors.py +++ b/lib/matplotlib/colors.py @@ -362,9 +362,7 @@ def to_rgba_array(c, alpha=None): pass if isinstance(c, str): - raise ValueError("Using a string of single charact...
matplotlib__matplotlib-23006
[ { "changes": { "added_entities": [ "lib/matplotlib/widgets.py:RangeSlider._update_selection_poly" ], "added_modules": null, "edited_entities": [ "lib/matplotlib/widgets.py:RangeSlider.__init__", "lib/matplotlib/widgets.py:RangeSlider.set_val" ], "edite...
matplotlib/matplotlib
7bb3ff5f2f783520473f0a8df84af0aee74b2f3f
"ab;cd" missing in subplot_mosaic tutorial ### Documentation Link https://matplotlib.org/devdocs/tutorials/provisional/mosaic.html ### Problem As of #18763, "ab;cd" is valid input into subplot_mosaic to generate a 2x2 plot. While the docs were updated, the tutorial wasn't. ### Suggested improvement Add a paragrap...
diff --git a/doc/users/installing/index.rst b/doc/users/installing/index.rst index fffea0301a..ef215ee394 100644 --- a/doc/users/installing/index.rst +++ b/doc/users/installing/index.rst @@ -111,10 +111,18 @@ First you need to install the :ref:`dependencies`. A C compiler is required. Typically, on Linux, you will ...
matplotlib__matplotlib-23438
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/backends/backend_pgf.py:_get_preamble", "lib/matplotlib/backends/backend_pgf.py:LatexManager.__init__", "lib/matplotlib/backends/backend_pgf.py:LatexManager._get_box_metri...
matplotlib/matplotlib
72cee0a46b7df7da8ad605e1b523e72af57edb7e
doc for type of tz parameter is inconsistent throughout dates.py The docs for the tz parameter of various functions and classes in matplotlib.dates is inconsistent: some document it as taking a `tzinfo` value, others a `str` value, some of those declaring it to be of type `tzinfo` also declare its default to be rcParam...
diff --git a/lib/matplotlib/backends/backend_pgf.py b/lib/matplotlib/backends/backend_pgf.py index 5c4ffe9adb..a5c9313682 100644 --- a/lib/matplotlib/backends/backend_pgf.py +++ b/lib/matplotlib/backends/backend_pgf.py @@ -70,6 +70,8 @@ def _get_preamble(): path = pathlib.Path(fm.findfont(family)) ...
matplotlib__matplotlib-23638
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/backends/backend_svg.py:RendererSVG._draw_text_as_text" ], "edited_modules": [ "lib/matplotlib/backends/backend_svg.py:RendererSVG" ] }, "file": "lib/mat...
matplotlib/matplotlib
3feaa5de08f451ee16146731641a5b4b24662844
[Bug]: problem with font property in text elements of svg figures ### Bug summary Starting with 3.5.0, figures exported as SVG without font embedded in the file (i.e. “svg.fonttype” set to “none”) use the `font` CSS shorthand property. The problem is that the font-family generic name is quoted and some viewers don’...
diff --git a/lib/matplotlib/backends/backend_svg.py b/lib/matplotlib/backends/backend_svg.py index bc0f256533..721fb43ee6 100644 --- a/lib/matplotlib/backends/backend_svg.py +++ b/lib/matplotlib/backends/backend_svg.py @@ -1153,10 +1153,48 @@ class RendererSVG(RendererBase): weight = fm.weight_dict[prop.ge...
matplotlib__matplotlib-23746
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/figure.py:FigureBase.colorbar" ], "edited_modules": [ "lib/matplotlib/figure.py:FigureBase" ] }, "file": "lib/matplotlib/figure.py" } ]
matplotlib/matplotlib
86d57976c2e8debcc3ef72d9a13cc06d361499a1
[Bug]: AxesSubplot.get_yticks not returning the actual printed ticks ### Bug summary `get_x/yticks` seems to have some padding but does not return the actual printed ticks. ### Code for reproduction ```python fig, ax = plt.subplots() ax.loglog( range(100), range(100) ) print( ax.get_yticks() ) ``` `...
diff --git a/doc/api/next_api_changes/removals/22081-AL.rst b/doc/api/next_api_changes/removals/22081-AL.rst index b525da4a55..6f971f3df3 100644 --- a/doc/api/next_api_changes/removals/22081-AL.rst +++ b/doc/api/next_api_changes/removals/22081-AL.rst @@ -1,10 +1,7 @@ colorbar defaults to stealing space from the mappab...
matplotlib__matplotlib-26598
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/axis.py:Tick.__init__" ], "edited_modules": [ "lib/matplotlib/axis.py:Tick" ] }, "file": "lib/matplotlib/axis.py" } ]
matplotlib/matplotlib
a63dfaf727fa2ac14faf35f0f404318720bf3183
[Bug]: Tick class instantiation returns an error when labelcolor is a tuple ### Bug summary I have a function that uses custom colouring of different plot axes. When Matplotlib tries to render the figure, I am getting the following error shown below ### Code for reproduction ```python Set the tick label co...
diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py index 0ace31916c..77bd34df69 100644 --- a/lib/matplotlib/axis.py +++ b/lib/matplotlib/axis.py @@ -129,7 +129,7 @@ class Tick(martist.Artist): if labelcolor is None: labelcolor = mpl.rcParams[f"{name}.labelcolor"] - if labelcolor...
matplotlib__matplotlib-26719
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/mpl_toolkits/mplot3d/art3d.py:patch_collection_2d_to_3d" ], "edited_modules": [ "lib/mpl_toolkits/mplot3d/art3d.py:patch_collection_2d_to_3d" ] }, "file": "lib/mpl_...
matplotlib/matplotlib
b71901283457c9cb3cc0a6fc0261a2bba729c823
[Bug]: AttributeError: 'Path3DCollection' object has no attribute '_offset_zordered' (possible regression) ### Bug summary Adding a Line3DCollection to an animation results in Attribute error. ### Code for reproduction ```python import matplotlib.pyplot as plt import matplotlib.animation as animation from matplo...
diff --git a/lib/mpl_toolkits/mplot3d/art3d.py b/lib/mpl_toolkits/mplot3d/art3d.py index ac6e841f50..d2d782123f 100644 --- a/lib/mpl_toolkits/mplot3d/art3d.py +++ b/lib/mpl_toolkits/mplot3d/art3d.py @@ -833,6 +833,7 @@ def patch_collection_2d_to_3d(col, zs=0, zdir='z', depthshade=True): """ if isinstance(col,...
matplotlib__matplotlib-26825
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/cbook.py:safe_first_element", "lib/matplotlib/cbook.py:_safe_first_finite" ], "edited_modules": [ "lib/matplotlib/cbook.py:safe_first_element", "lib/ma...
matplotlib/matplotlib
f97647b8602f236f4e37cfd6a85aec3964888a9b
[Bug]: Legend fails for bar plot with numeric label ### Bug summary It seems a bug was introduced in Matplotlib 3.8, in which numeric labels for bar charts are no longer getting converted to strings. When trying to add a legend, this causes an `AttributeError: 'int' object has no attribute 'startswith'`. ### Code for...
diff --git a/lib/matplotlib/cbook.py b/lib/matplotlib/cbook.py index b56de55953..f02486a0e2 100644 --- a/lib/matplotlib/cbook.py +++ b/lib/matplotlib/cbook.py @@ -1679,20 +1679,10 @@ def safe_first_element(obj): This is a type-independent way of obtaining the first element, supporting both index access and th...
matplotlib__matplotlib-26834
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/mpl_toolkits/mplot3d/axes3d.py:Axes3D.scatter" ], "edited_modules": [ "lib/mpl_toolkits/mplot3d/axes3d.py:Axes3D" ] }, "file": "lib/mpl_toolkits/mplot3d/axes3d.py" ...
matplotlib/matplotlib
bd8198c8b8b1a41c39e7f85ef164f7801682ecd0
[Bug]: `ValueError: The truth value...` when an ndarray is passed to the `color` kwarg of `axes3d.scatter` ### Bug summary Passing a numpy array to the `color` argument of `ax.scatter` results in a `ValueError` when `ax` is initialized with `projection='3d'`. This error began occurring in our CI after the release of...
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py index c519bc6565..0c18bce8eb 100644 --- a/lib/mpl_toolkits/mplot3d/axes3d.py +++ b/lib/mpl_toolkits/mplot3d/axes3d.py @@ -2672,7 +2672,7 @@ class Axes3D(Axes): xs, ys, zs, s, c, color = cbook.delete_masked_points( ...
matplotlib__matplotlib-26908
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": [ "lib/matplotlib/contour.py:ContourSet" ] }, "file": "lib/matplotlib/contour.py" } ]
matplotlib/matplotlib
7d2acfda30077403682d8beef5a3c340ac98a43b
[Doc]: `ContourSet` `allsegs` and `allkinds` after #25247 ### Documentation Link https://matplotlib.org/stable/api/contour_api.html ### Problem It seems that their descriptions are no longer accurate after #25247. For example https://github.com/matplotlib/matplotlib/blob/dceb278bef361f32eb0009dec5bfda41fc27fa3...
diff --git a/lib/matplotlib/contour.py b/lib/matplotlib/contour.py index efea024dc1..2725dd6340 100644 --- a/lib/matplotlib/contour.py +++ b/lib/matplotlib/contour.py @@ -935,9 +935,11 @@ class ContourSet(ContourLabeler, mcoll.Collection): ) allsegs = _api.deprecated("3.8", pending=True)(property(la...
matplotlib__matplotlib-26952
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/backends/backend_macosx.py:FigureManagerMac.__init__" ], "edited_modules": [ "lib/matplotlib/backends/backend_macosx.py:FigureManagerMac" ] }, "file": "l...
matplotlib/matplotlib
e237bbd24b4682aef400547390e045ec75b1041f
[Bug]: colors.LinearSegmentedColormap.from_list does not take two tuples in 3.8.0 ### Bug summary Incrementing from v3.7 to v3.8 the option to specify a start and end value is no longer functioning when two values are specified. It still works when three are specified. ``` ## This works: matplotlib.colors.Lin...
diff --git a/lib/matplotlib/backends/backend_macosx.py b/lib/matplotlib/backends/backend_macosx.py index ecf21b07ae..1d92ec602d 100644 --- a/lib/matplotlib/backends/backend_macosx.py +++ b/lib/matplotlib/backends/backend_macosx.py @@ -147,7 +147,7 @@ class FigureManagerMac(_macosx.FigureManager, FigureManagerBase): ...
matplotlib__matplotlib-27327
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/axes/_axes.py:Axes.errorbar" ], "edited_modules": [ "lib/matplotlib/axes/_axes.py:Axes" ] }, "file": "lib/matplotlib/axes/_axes.py" }, { "changes...
matplotlib/matplotlib
ba32c7e8e263675431b49d6eae71e7fa3945d286
[Bug]: The method for checking whether a color has an alpha value is outdated ### Bug summary In [matplotlib.colors._has_alpha_channel](https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/colors.py#L234), it fails to identify colors with alpha channels in two contexts. 1. It assumes that any color ...
diff --git a/doc/devel/development_setup.rst b/doc/devel/development_setup.rst index cffda17939..14a11add45 100644 --- a/doc/devel/development_setup.rst +++ b/doc/devel/development_setup.rst @@ -211,7 +211,7 @@ Additionally, the following non-Python dependencies must also be installed local .. rst-class:: checklist ...
matplotlib__matplotlib-29411
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lib/matplotlib/axes/_base.py:_AxesBase.__init__" ], "edited_modules": [ "lib/matplotlib/axes/_base.py:_AxesBase" ] }, "file": "lib/matplotlib/axes/_base.py" } ]
matplotlib/matplotlib
ca8079bc64d1c5a736906442adac91f8e52c6dee
[Bug]: Modifying Axes' position also alters the original Bbox object used for initialization ### Bug summary When an Axes is initialized using a Bbox object, changing the Axes' position (for example, via `ax.set_position`) will also alter the original Bbox object. This is because the Axes retains a reference to the Bb...
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py index 23741ccd91..18c57a37db 100644 --- a/lib/matplotlib/axes/_base.py +++ b/lib/matplotlib/axes/_base.py @@ -641,7 +641,7 @@ class _AxesBase(martist.Artist): args = (rect,) subplotspec = None if len(args) == 1 and i...
matplotlib__viscm-75
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "viscm/bezierbuilder/__init__.py:ControlPointBuilder.on_button_press" ], "edited_modules": [ "viscm/bezierbuilder/__init__.py:ControlPointBuilder" ] }, "file": "viscm/be...
matplotlib/viscm
6735c7e86eabd1cae5b2a66ee841362153c0302d
Drop support for Python 3.8 For rationale: https://scientific-python.org/specs/spec-0000/
diff --git a/Makefile b/Makefile index 344a63e..c1cfef0 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ .PHONY: test test: python -m pytest --version - python -m pytest -v test/ + python -m pytest -sv test/ .PHONY: lint diff --git a/README.rst b/README.rst index 020b6a7..90e5d3e 100644 --- a/README.rst +...
matrix-org__python-canonicaljson-34
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "canonicaljson.py:encode_pretty_printed_json", "canonicaljson.py:iterencode_pretty_printed_json" ], "edited_modules": [ "canonicaljson.py:encode_pretty_printed_json", ...
matrix-org/python-canonicaljson
51a36ca61f90ab00527ba5d075e6716a7819f4df
Pretty-printed JSON is ASCII-encoded whereas it is otherwise UTF-8-encoded, causing errors With Synapse, I run into an issue doing an initial sync with curl, because it switches to pretty-printed output: ``` Aug 24 14:14:02 sallie.librepush.net synapse[3123612]: During handling of the above exception, another excep...
diff --git a/CHANGES.md b/CHANGES.md index 0378bae..76aa272 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -3,6 +3,8 @@ Version next * Fix producing non-standard JSON for Infinity, -Infinity, and NaN. This could error when encoding objects into canonical JSON that previously used to work, but were incompatible with...
mattboyer__git-guilt-34
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "git_guilt/guilt.py:GitRunner._get_git_version" ], "edited_modules": [ "git_guilt/guilt.py:GitRunner" ] }, "file": "git_guilt/guilt.py" } ]
mattboyer/git-guilt
58f92d3e37a115596a890ad3e2fe674636c682ee
Git version detection fails on MacOS Here's what a friendly user had to report: > my MACBOOK running latest 10.10.3 comes preinstalled with ``` Laurences-MacBook-Pro:security Laurence$ git version git version 2.3.2 (Apple Git-55) ``` The parsing code that consumes the output of `git version` should be made mo...
diff --git a/git_guilt/guilt.py b/git_guilt/guilt.py index 23a748a..3b400c5 100644 --- a/git_guilt/guilt.py +++ b/git_guilt/guilt.py @@ -78,13 +78,14 @@ class GitRunner(object): raise GitError("Malformed Git version") raw_version = self.run_git(GitRunner._version_args) - if not (raw_v...
matthew-brett__delocate-230
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "delocate/libsana.py:get_dependencies", "delocate/libsana.py:resolve_dynamic_paths", "delocate/libsana.py:search_environment_for_lib", "delocate/libsana.py:_paths_from_var" ...
matthew-brett/delocate
dfb21c8cff605ab4b0d4ee4b40cabe07748b6033
This function does not support separate values per-architecture: 'i386' **Describe the bug** running delocate-wheel for an `arm64`-only wheel with `universal2` python installation: ``` otool: /opt/X11/lib/libSM.6.dylib Traceback (most recent call last): File "/Users/savulesc/Workspace/nrn/nrn_build_venv38_-28500...
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index f1c8432..6ed74d3 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -45,14 +45,14 @@ jobs: tests: needs: [pre-commit, mypy] - runs-on: macos-12 + runs-on: macos-13 ...
matthew-brett__delocate-235
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "delocate/delocating.py:copy_recurse", "delocate/delocating.py:_get_macos_min_version", "delocate/delocating.py:_calculate_minimum_wheel_name" ], "edited_modules": [ "...
matthew-brett/delocate
e90c30c5e2b6923fc137c0c300046752b3e6df98
Fat binaries of static libraries are not supported in the wheel **Describe the bug** The new check to ensure the minimum macOS version of all MachO generates an error when fat binaries of static libraries are included in the wheel. Our python wheel includes JIT compilation support using LLVM. For this we need to bu...
diff --git a/Changelog.md b/Changelog.md index 1e56fe7..0bad98f 100644 --- a/Changelog.md +++ b/Changelog.md @@ -33,6 +33,9 @@ rules on making a good Changelog. [#230](https://github.com/matthew-brett/delocate/pull/230) - `delocate-merge` now supports libraries with missing or unusual extensions. [#228](https://...
matthewwardrop__formulaic-11
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "formulaic/parser/parser.py:FormulaParser.operators", "formulaic/parser/parser.py:FormulaParser.get_tokens" ], "edited_modules": [ "formulaic/parser/parser.py:FormulaParser" ...
matthewwardrop/formulaic
88b985aaf4d3f7138e04c3258542253c5c4f3f62
BUG: Repeated constant-like terms are incorrectly parsed Formulas like `0 + 0 + 1 + x` are incorrectly parsed and result in a DataFrame that looks like: ``` from formulaic import model_matrix from pandas import DataFrame df = DataFrame([[0],[1],[2],[3],[4]],columns=["x"]) dep = model_matrix("0 + 0 + 1 + x", df,...
diff --git a/formulaic/parser/parser.py b/formulaic/parser/parser.py index 34e8a8e..dab6bc2 100644 --- a/formulaic/parser/parser.py +++ b/formulaic/parser/parser.py @@ -36,7 +36,7 @@ class FormulaParser: terms = arg.to_terms() if len(terms) > 1 or list(terms)[0] != '0': raise ...
matthewwardrop__formulaic-123
[ { "changes": { "added_entities": [ "formulaic/formula.py:Formula.__validate_terms" ], "added_modules": null, "edited_entities": [ "formulaic/formula.py:Formula._prepare_item", "formulaic/formula.py:Formula.__validate_prepared_item" ], "edited_modules":...
matthewwardrop/formulaic
d3f41ac2037120ded4f2ea10ca65f14986f80486
Explicitly passed terms should be sorted like parsed terms. When Formula receives a string as input, it sorts the terms when preparing the items. This is inconsistent because none of `Structured`, `List`, or `Set` sort their terms. String formulas should likewise not be sorting their terms to maintain consistency.
diff --git a/formulaic/formula.py b/formulaic/formula.py index 3a9044b..d4e3a41 100644 --- a/formulaic/formula.py +++ b/formulaic/formula.py @@ -137,7 +137,9 @@ class Formula(Structured[List[Term]]): ) if isinstance(item, Structured): - formula_or_terms = Formula(_parser=self._nested_...
matthewwardrop__formulaic-166
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "formulaic/materializers/base.py:FormulaMaterializer.get_model_matrix" ], "edited_modules": [ "formulaic/materializers/base.py:FormulaMaterializer" ] }, "file": "formula...
matthewwardrop/formulaic
02e40e24681c0814aadf6f753bb98c6716b7678e
`model_spec.transform_state` bugged when formula is not correctly written In case the given formula is not correctly written i.e., with extra or forgotten spaces then the `transform_state` dictionary keys does not match and the dictionary results in `{}`. Here is an example: `import numpy as np import pandas as pd ...
diff --git a/formulaic/materializers/base.py b/formulaic/materializers/base.py index 9a097eb..6393769 100644 --- a/formulaic/materializers/base.py +++ b/formulaic/materializers/base.py @@ -186,14 +186,7 @@ class FormulaMaterializer(metaclass=FormulaMaterializerMeta): # the shared transform state pool. ...
matthewwardrop__formulaic-43
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "formulaic/materializers/base.py:FormulaMaterializer._enforce_structure" ], "edited_modules": [ "formulaic/materializers/base.py:FormulaMaterializer" ] }, "file": "formu...
matthewwardrop/formulaic
5e75e05e323cfca9a442b92a9e344f30145fe46c
Bug handling categorical features? I am training a model with a `pd.categorical` feature with categories not following alphabetic order. During prediction I pass this categorical feature as string. When transforming getting the model matrix using `X.model_spec.get_model_matrix(x_string)`, the string feature is transfor...
diff --git a/formulaic/materializers/base.py b/formulaic/materializers/base.py index b28766d..877ffb1 100644 --- a/formulaic/materializers/base.py +++ b/formulaic/materializers/base.py @@ -5,7 +5,7 @@ import itertools import operator from abc import abstractmethod from collections import defaultdict, OrderedDict -fr...
matthewwardrop__formulaic-83
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "formulaic/parser/parser.py:DefaultOperatorResolver.operators" ], "edited_modules": [ "formulaic/parser/parser.py:DefaultOperatorResolver" ] }, "file": "formulaic/parser...
matthewwardrop/formulaic
00a31a8564a42fd3585d4dab91151f454374acc1
RecursionError: maximum recursion depth exceeded for large models Hi :) I ran into the following error. When I try to create a Formula object with more than 246 model terms I get a RecursionError. One can fix this by simply setting the recursion limit to a higher value but I wanted to report this because I think it...
diff --git a/.github/workflows/tox.yml b/.github/workflows/tox.yml index 3e15d72..1b664f4 100644 --- a/.github/workflows/tox.yml +++ b/.github/workflows/tox.yml @@ -3,7 +3,7 @@ name: Run Tox Tests on: push: branches: - - "**" + - "*" jobs: build: diff --git a/formulaic/parser/parser.py b/formul...
matthewwithanm__django-imagekit-574
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "imagekit/generatorlibrary.py:Thumbnail.__init__" ], "edited_modules": [ "imagekit/generatorlibrary.py:Thumbnail" ] }, "file": "imagekit/generatorlibrary.py" }, { ...
matthewwithanm/django-imagekit
92dff0056de25d1248bc2808a9bdf99a6762c92f
Feature Request: Make it possible to specify the format for the thumbnail template tag I want that all my thumbnails use WEBP. Currently I have to create a lot of own generators. It would be nice if the `thumbnail` template tag would accept a format param or/and that I can specify a default format (I always want WEBP)....
diff --git a/docs/configuration.rst b/docs/configuration.rst index 84636ce..f6b6028 100644 --- a/docs/configuration.rst +++ b/docs/configuration.rst @@ -10,6 +10,13 @@ Settings .. currentmodule:: django.conf.settings +.. attribute:: IMAGEKIT_DEFAULT_THUMBNAIL_FORMAT + + :default: ``None`` + + The output form...
matthewwithanm__python-markdownify-110
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.convert_td", "markdownify/__init__.py:MarkdownConverter.convert_th", "markdownify/__init__.py:MarkdownConverter.convert_tr" ], "edit...
matthewwithanm/python-markdownify
57d4f379236fdda75c7359d664ecf4aea8bcb157
Table merge cell horizontally ### Summary `colspan` attribute ignored in conversion, causing problems. ### Description In HTML, the `colspan` attribute of `<td>` and `<th>` extends the cell to span multiple columns. Currently, all cells are handled the same, causing inconsistent numbers of columns on each row o...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index cab4f36..86226d2 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -376,10 +376,16 @@ class MarkdownConverter(object): return '\n\n' + text + '\n\n' def convert_td(self, el, text, convert_as_inline): - return...
matthewwithanm__python-markdownify-114
[ { "changes": { "added_entities": [ "markdownify/__init__.py:MarkdownConverter.convert_caption", "markdownify/__init__.py:MarkdownConverter.convert_figcaption" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "markdownify/__init__.py:Mar...
matthewwithanm/python-markdownify
e4df41225da327aeb1ca5acd87be02518f8f8865
Blank lines are missing around figure and table captions For `<table>` elements, a newline is missing between the `<caption>` element and the first `|` (pipe) character in the table structure: ``` from markdownify import markdownify as md md('TEXT<table><caption>Caption</caption><tr><td>CELL</td></tr></tbody></tab...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index b67c32b..cab4f36 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -369,6 +369,12 @@ class MarkdownConverter(object): def convert_table(self, el, text, convert_as_inline): return '\n\n' + text + '\n' + def conver...
matthewwithanm__python-markdownify-117
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:abstract_inline_conversion" ], "edited_modules": [ "markdownify/__init__.py:abstract_inline_conversion" ] }, "file": "markdownify/__init__.py" ...
matthewwithanm/python-markdownify
74ddc408cca3a8b59c070daffaae34ef2593f9e1
Inline styles within `<pre>`/`<code>` blocks should be ignored Markdown has no provision for inline styles within preformatted content (unless extensions/etc. are used). However, inline styles are incorrectly applied within `<code>` and `<pre>` blocks (note the `**` in these examples): ``` from markdownify impor...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index 86226d2..0945916 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -48,6 +48,8 @@ def abstract_inline_conversion(markup_fn): """ def implementation(self, el, text, convert_as_inline): markup = markup_fn(self) + ...
matthewwithanm__python-markdownify-118
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:abstract_inline_conversion", "markdownify/__init__.py:MarkdownConverter.escape" ], "edited_modules": [ "markdownify/__init__.py:abstract_inline_conver...
matthewwithanm/python-markdownify
74ddc408cca3a8b59c070daffaae34ef2593f9e1
Angle brackets <> aren't escaped. ```py >>> markdownify('text&lt;text&gt;') 'text<text>' ``` In at least some flavours of Markdown, this would need to be `text\<text\>` instead. As an example, GitHub-flavoured Markdown gives text<text> and text\<text\> without and with back...
diff --git a/README.rst b/README.rst index 51888ea..a0cd678 100644 --- a/README.rst +++ b/README.rst @@ -123,6 +123,11 @@ escape_underscores If set to ``False``, do not escape ``_`` to ``\_`` in text. Defaults to ``True``. +escape_misc + If set to ``False``, do not escape miscellaneous punctuation characters +...
matthewwithanm__python-markdownify-120
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.process_tag", "markdownify/__init__.py:MarkdownConverter.underline", "markdownify/__init__.py:MarkdownConverter.convert_hn", "markdownif...
matthewwithanm/python-markdownify
964d89fa8ace65181402f69ca2482d83b84600f8
Inline <p> not handled well Input: Wie nennt man jemanden, der gegen Covid-Politik Proteste organisiert, und sich dann mit einem Covid-Testcenter an der Zitze des Staates labt?<p><a href="https://www.mdr.de/nachrichten/sachsen-anhalt/dessau/bitterfeld/buergermeister-raguhn-jessnitz-loth-afd-100.html">Bürgermeist...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index cd66a39..efb2d15 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -148,7 +148,13 @@ class MarkdownConverter(object): elif isinstance(el, NavigableString): text += self.process_text(el) el...
matthewwithanm__python-markdownify-150
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.process_tag", "markdownify/__init__.py:MarkdownConverter.process_text", "markdownify/__init__.py:MarkdownConverter.underline", "markdown...
matthewwithanm/python-markdownify
964d89fa8ace65181402f69ca2482d83b84600f8
unnecessary /n newlines resulting in a lot of white area in the markdown ```markdown On\_Search - Beckn * Home * Overview * Sp...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index cd66a39..a37f870 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -7,7 +7,8 @@ import six convert_heading_re = re.compile(r'convert_h(\d+)') line_beginning_re = re.compile(r'^', re.MULTILINE) whitespace_re = re.compile(r'[\t ]+...
matthewwithanm__python-markdownify-165
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.convert_a" ], "edited_modules": [ "markdownify/__init__.py:MarkdownConverter" ] }, "file": "markdownify/__init__.py" } ]
matthewwithanm/python-markdownify
6258f5c38b97ab443b4ddf03e6676ce29b392d06
`<a>` tag links should not be constructed inside preformatted tags The conversion for `<a>` tags creates links inside `<code>` and `<pre>` tags: ``````python from markdownify import markdownify as md print(md("<code><a href='http://foo.com/'>foo.com</a></code>")) # `[foo.com](http://foo.com/)` print(md("<pre...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index 3272ce5..0fbb7a5 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -264,6 +264,8 @@ class MarkdownConverter(object): return '\n\n%s\n%s\n\n' % (text, pad_char * len(text)) if text else '' def convert_a(self, el, tex...
matthewwithanm__python-markdownify-167
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.convert_caption" ], "edited_modules": [ "markdownify/__init__.py:MarkdownConverter" ] }, "file": "markdownify/__init__.py" }...
matthewwithanm/python-markdownify
6258f5c38b97ab443b4ddf03e6676ce29b392d06
Add a blank line between table captions and table content Currently, table `<caption>` elements are placed directly adjacent to the table content: ```python import markdownify html = """\ <table> <caption>Table caption</caption> <thead><tr><th>Header 1</th><th>Header 2</th></tr></thead> <tbody><tr><td>Bod...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index 3272ce5..cadd2bd 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -442,7 +442,7 @@ class MarkdownConverter(object): return '\n\n' + text + '\n' def convert_caption(self, el, text, convert_as_inline): - retur...
matthewwithanm__python-markdownify-169
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.convert_a", "markdownify/__init__.py:MarkdownConverter.convert_p", "markdownify/__init__.py:MarkdownConverter.convert_caption" ], "e...
matthewwithanm/python-markdownify
6258f5c38b97ab443b4ddf03e6676ce29b392d06
Support a wrap width value of `None` that explicitly indicates no width limit (unlimited line length) Currently we use a large numerical `wrap_width` value to collapse newlines inside paragraphs: ```python from markdownify import markdownify as md html = "<p>" + "\n".join(["This is some text."] * 10) + "</p>" p...
diff --git a/README.rst b/README.rst index 98473c6..af87f51 100644 --- a/README.rst +++ b/README.rst @@ -143,6 +143,7 @@ wrap, wrap_width If ``wrap`` is set to ``True``, all text paragraphs are wrapped at ``wrap_width`` characters. Defaults to ``False`` and ``80``. Use with ``newline_style=BACKSLASH`` to keep ...
matthewwithanm__python-markdownify-171
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.indent", "markdownify/__init__.py:MarkdownConverter.convert_blockquote", "markdownify/__init__.py:MarkdownConverter.convert_li" ], "...
matthewwithanm/python-markdownify
600f77d2444233b1c5e838b69390cbbf92bde1e1
optimize representation of empty lines in `<li>` and `<blockquote>` content In `<li>`, empty lines still get indenting spaces (spaces replaced with `·` in output): ```python from markdownify import markdownify as md html = """ <ul> <li> <p>1</p> <p>2</p> </li> </ul> """ print(md(html)) # *·1...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index b70a0e5..fd03569 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -5,7 +5,7 @@ import six convert_heading_re = re.compile(r'convert_h(\d+)') -line_beginning_re = re.compile(r'^', re.MULTILINE) +line_with_content_re = re.compi...
matthewwithanm__python-markdownify-173
[ { "changes": { "added_entities": [ "markdownify/__init__.py:MarkdownConverter.convert_dd", "markdownify/__init__.py:MarkdownConverter.convert_dt" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "markdownify/__init__.py:MarkdownConverte...
matthewwithanm/python-markdownify
f73a4353150c2bb99f3dc8c733cb997cb45a6ac7
support HTML definition lists (`<dl>`, `<dt>`, and `<dd>`) Support HTML definition lists, such as: ```html <dl> <dt>term 1</dt> <dd> <p>This is a definition of term 1.</p> </dd> <dt>term 2</dt> <dd> <p>This is a definition of term 2.</p> </dd> </dl> ``` The widely-used Pandoc utilit...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index fd03569..ac53077 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -319,6 +319,38 @@ class MarkdownConverter(object): convert_kbd = convert_code + def convert_dd(self, el, text, convert_as_inline): + text = (text...
matthewwithanm__python-markdownify-178
[ { "changes": { "added_entities": [ "markdownify/__init__.py:MarkdownConverter.convert__document_" ], "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.convert_soup", "markdownify/__init__.py:MarkdownConverter.process_tag", ...
matthewwithanm/python-markdownify
1783995cb2ae2f6a9306c5932c7ec145ce76a900
Missing blank lines above headings or code blocks Headings are supposed to be surrounded by blank lines. However, ```"Some text.\n\n\n<h4>A heading</h4>\n\n<p>\nA paragraph"``` gets converted to: ```'Some text.\n#### A heading\n\nA paragraph\n\n'``` With just one line-break above the heading. The same is t...
diff --git a/README.rst b/README.rst index af87f51..34ed7e0 100644 --- a/README.rst +++ b/README.rst @@ -139,6 +139,11 @@ keep_inline_images_in that should be allowed to contain inline images, for example ``['td']``. Defaults to an empty list. +table_infer_header + Controls handling of tables with no header ro...
matthewwithanm__python-markdownify-184
[ { "changes": { "added_entities": [ "markdownify/__init__.py:_is_block_content_element", "markdownify/__init__.py:_prev_block_content_sibling", "markdownify/__init__.py:_next_block_content_sibling", "markdownify/__init__.py:MarkdownConverter.convert_div" ], "adde...
matthewwithanm/python-markdownify
c52a50e66a916791f825262f60f96a206287bf30
div mis-converted ``` >>> MarkdownConverter().convert('<div>foo</div><div>bar<span>baz</span><span>meow</span></div>') 'foobarbazmeow' ``` Expected: `'foo \nbarbazmeow'`
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index 93a889f..9e4c99f 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -1,4 +1,4 @@ -from bs4 import BeautifulSoup, NavigableString, Comment, Doctype +from bs4 import BeautifulSoup, Comment, Doctype, NavigableString, Tag from textwrap...
matthewwithanm__python-markdownify-200
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:should_remove_whitespace_inside", "markdownify/__init__.py:MarkdownConverter.convert_dt" ], "edited_modules": [ "markdownify/__init__.py:should_remove...
matthewwithanm/python-markdownify
ac5736f0a3ccd072202aa99edcbe3cc31340461b
Definition lists do not insert required newlines If the HTML input does not contain any newlines around definition list tags: ```python import markdownify md = markdownify.MarkdownConverter().convert print(md(""" text<dl><dt>Term 1</dt><dd>Definition 1</dd><dt>Term 2</dt><dd>Definition 2</dd></dl>text """.strip())) ...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index 3763a49..69ec328 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -106,6 +106,7 @@ def should_remove_whitespace_inside(el): return el.name in ('p', 'blockquote', 'article', 'div', 'section', ...
matthewwithanm__python-markdownify-23
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.process_tag", "markdownify/__init__.py:MarkdownConverter.process_text", "markdownify/__init__.py:MarkdownConverter.convert_list" ], ...
matthewwithanm/python-markdownify
f59f9f9a5482f95595654258497366fcca5792e8
ordered list issue Hello :) I encountered a probleme markdownifying ordered lists: given `html = '<ol>\n<li>a</li>\n<li>b</li>\n<li>c</li>\n</ol>'` the ol node list is: `['\n', <li>w</li>, '\n', <li>t</li>, '\n', <li>f</li>, '\n']` as `bullet = '%s.' % (parent.index(el) + 1)`, the result is: ``` : ma...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index eeaaf74..da04ebf 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -6,6 +6,7 @@ import six convert_heading_re = re.compile(r'convert_h(\d+)') line_beginning_re = re.compile(r'^', re.MULTILINE) whitespace_re = re.compile(r'[\t ]+...
matthewwithanm__python-markdownify-34
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "markdownify/__init__.py:MarkdownConverter.process_tag" ], "edited_modules": [ "markdownify/__init__.py:MarkdownConverter" ] }, "file": "markdownify/__init__.py" } ]
matthewwithanm/python-markdownify
77d1e99bd5246193138d7646882f3e72c04ce26f
Exclude comments Currently markdownify allows to parse comments, might not very common to see comments (`<!--` & `-->`) in HTML however when you're working with someones HTML code anything can happen. ### Did write a test to check that: ```python def test_comments(): text = md("<!-- This is a comment -->") ...
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index 6d93e47..5c008d3 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -1,4 +1,4 @@ -from bs4 import BeautifulSoup, NavigableString +from bs4 import BeautifulSoup, NavigableString, Comment import re import six @@ -75,7 +75,9 @@ cla...
matthewwithanm__python-markdownify-36
[ { "changes": { "added_entities": [ "markdownify/__init__.py:MarkdownConverter.convert_table" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "markdownify/__init__.py:MarkdownConverter" ] }, "file": "markdownify/__init__.py" } ]
matthewwithanm/python-markdownify
d4882b86b9c308699fa73dfe79747799f19c5192
Support tables Currently `table`s are not supported. Would be great to see basic support for
diff --git a/markdownify/__init__.py b/markdownify/__init__.py index 88e158e..0b2a620 100644 --- a/markdownify/__init__.py +++ b/markdownify/__init__.py @@ -252,6 +252,23 @@ class MarkdownConverter(object): return '![%s](%s%s)' % (alt, src, title_part) + def convert_table(self, el, text, convert_as_inli...
mattiaverga__PyOngc-17
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "pyongc/ongc.py:listObjects" ], "edited_modules": [ "pyongc/ongc.py:listObjects" ] }, "file": "pyongc/ongc.py" }, { "changes": { "added_entities": null, ...
mattiaverga/PyOngc
4990ca95fa3accc8a82587ebe0e2bf04aeaa1ed3
Multiple values in listObjects() filters Allow some filters like `type` and `constellation` in listObjects() method to accept multiple values (maybe in a comma separated values string or list)
diff --git a/docs/cli/ongc.rst b/docs/cli/ongc.rst index 49f0cf2..e80397b 100644 --- a/docs/cli/ongc.rst +++ b/docs/cli/ongc.rst @@ -86,12 +86,14 @@ If the ouput exceed 20 objects, the user can choose to view the list in a pager. ``--type TEXT`` - Allows to list only objects of a kind. It accepts one of...
mattiaverga__PyOngc-29
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/pyongc/scripts/ongc.py:search" ], "edited_modules": [ "src/pyongc/scripts/ongc.py:search" ] }, "file": "src/pyongc/scripts/ongc.py" } ]
mattiaverga/PyOngc
3ddaf7ffe25ee46f903fae37c5546804eccf5aca
Allow choosing data to output in ongc search Now `ongc search` just outputs a list of Dso.__str__() Would be better to allow the user to choose what data to output and maybe create a csv file instead of txt
diff --git a/Pipfile b/Pipfile index eafa6a1..14af3ed 100644 --- a/Pipfile +++ b/Pipfile @@ -14,6 +14,7 @@ sphinx-rtd-theme = "*" [packages] click = "*" numpy = "*" +pandas = "*" [requires] python_version = "3.10" diff --git a/docs/cli/ongc.rst b/docs/cli/ongc.rst index e80397b..fb7216c 100644 --- a/docs/cli/ong...
mattiaverga__PyOngc-36
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/pyongc/ongc.py:printDetails" ], "edited_modules": [ "src/pyongc/ongc.py:printDetails" ] }, "file": "src/pyongc/ongc.py" } ]
mattiaverga/PyOngc
6df721df52ac1f638fa8bb19f037c6bae032fb31
Error on details view, Python 3.11.0 Hello! I got the following error, while I tried to display the details of the NGC's objects that are shown in the screenshot. I'm currently using Python 3.11.0, with Anaconda. (a different environment), and MacOS 13.2. <img width="894" alt="image" src="https://user-images.g...
diff --git a/src/pyongc/ongc.py b/src/pyongc/ongc.py index 1504fa4..6fe5849 100644 --- a/src/pyongc/ongc.py +++ b/src/pyongc/ongc.py @@ -1547,7 +1547,7 @@ def printDetails(dso: Union[Dso, str]) -> str: obj_string += (f'|{" " * 77}|\n') - redshift = f'{dso.redshift:.6f}' + redshift = f'{dso.redshift:.6f}'...
mattijn__topojson-128
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "topojson/core/hashmap.py:Hashmap._hashmapper" ], "edited_modules": [ "topojson/core/hashmap.py:Hashmap" ] }, "file": "topojson/core/hashmap.py" }, { "changes": ...
mattijn/topojson
04b49beed6e2112bc8911aa9a318db112dd9ebd0
Converting a quantized topojson string to geojson fails to dequantize the coordinates First, thanks a lot for your work on this library, I love how lightweight and easy to use it is! I believe I have encountered an issue however. It appears to be me that much of the library and docs is geared towards converting geo...
diff --git a/docs/example/input-types.md b/docs/example/input-types.md index 7f7e2fd..feb6c32 100644 --- a/docs/example/input-types.md +++ b/docs/example/input-types.md @@ -309,4 +309,30 @@ tp.Topology(dict_in, prequantize=False).to_json() } ``` </div> +</div> + +* * * + +## TopoJSON file loaded as json-dict +A Top...
mattijn__topojson-182
[ { "changes": { "added_entities": [ "topojson/core/cut.py:Cut._get_linestring_types" ], "added_modules": null, "edited_entities": [ "topojson/core/cut.py:Cut._cutter" ], "edited_modules": [ "topojson/core/cut.py:Cut" ] }, "file": "topojson...
mattijn/topojson
db007582f60c13c53624bbfa1ed83fd405b85d76
Creating a topology for data without junctions and shared_coords=False, prequantize=False gives error Creating a topology for data that has no junctions with shared_coords=False, prequantize=False gives the following error: `AttributeError: 'LineString' object has no attribute 'tolist'` ![image](https://user-images...
diff --git a/topojson/core/cut.py b/topojson/core/cut.py index f4b1826..66b9b0a 100644 --- a/topojson/core/cut.py +++ b/topojson/core/cut.py @@ -115,25 +115,35 @@ class Cut(Join): warnings.filterwarnings("ignore", category=ShapelyDeprecationWarning) tree_splitter = STRtree(mp) ...
mattijn__topojson-185
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "topojson/core/cut.py:Cut._cutter", "topojson/core/cut.py:Cut._get_linestring_types" ], "edited_modules": [ "topojson/core/cut.py:Cut" ] }, "file": "topojson/cor...
mattijn/topojson
e36ca0aa31336f7436117bc0d8175df03a9ea1e7
Bug: polygons that entirely fill islands in another polygon are often not dedupped Because they aren't properly dedupped, this situation is created after simplify: ![image](https://user-images.githubusercontent.com/1565789/187953959-8e45dc49-bc0c-4e80-aa57-873f6c26e667.png) I'm working on a fix...
diff --git a/topojson/core/cut.py b/topojson/core/cut.py index 66b9b0a..ea901c0 100644 --- a/topojson/core/cut.py +++ b/topojson/core/cut.py @@ -117,7 +117,9 @@ class Cut(Join): slist = [] # create dict with original geometry type per linestring - linestring_object_types = self._g...
mattijn__topojson-80
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "topojson/core/extract.py:Extract._extract_dictionary" ], "edited_modules": [ "topojson/core/extract.py:Extract" ] }, "file": "topojson/core/extract.py" }, { "ch...
mattijn/topojson
b6508ecf595b474b0d41987c9987487957dd51ab
bounding box not working when using geodata I'm working on using your library including a warper to process postgres geogis data into TopoJson. I'm getting a `"ValueError: not enough values to unpack (expected 4, got 0)"` error when calling `tj = topojson.Topology(geoList)`. geoList content is enclosed as "pretty" an...
diff --git a/topojson/core/extract.py b/topojson/core/extract.py index 5d548f2..71e80cb 100644 --- a/topojson/core/extract.py +++ b/topojson/core/extract.py @@ -570,50 +570,56 @@ class Extract(object): self._key = key self._obj = self._data[self._key] - # detect if object is a sha...
mattjmcnaughton__sdep-30
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "sdep/app.py:Sdep._website_config" ], "edited_modules": [ "sdep/app.py:Sdep" ] }, "file": "sdep/app.py" }, { "changes": { "added_entities": [ "sdep...
mattjmcnaughton/sdep
be2be4bbfbdb2442fa446174055bb6cf61c4125b
Add `index_suffix` and `error_key` as optional fields When telling AWS to have our bucket perform like a website, with this [boto call](http://boto3.readthedocs.io/en/latest/reference/services/s3.html#S3.Client.put_bucket_website), we have the option of specifying which suffix will represent an index file (currently `i...
diff --git a/docs/cli.rst b/docs/cli.rst index ab80b6a..62fcaee 100644 --- a/docs/cli.rst +++ b/docs/cli.rst @@ -61,6 +61,12 @@ options can be set in configuration files: **Optional** +- :command:`INDEX_SUFFIX`: When hosting with Amazon S3, it is necessary to + specify an index suffix, which is appended to all ur...
mattpitkin__psrqpy-80
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "psrqpy/config.py" }, { "changes": { "added_entities": [ "psrqpy/utils.py:get_msp_catalogue" ], "added_modules": [ "p...
mattpitkin/psrqpy
89feaa5175fda85e1860b03b0329260c5ba418b4
Add parsing of the Galactic MSP table Similarly to #9, we could add a function to get and parse [Duncan Lorimer's](https://astro.wvu.edu/people/facultystaff/dlorimer) [Galactic MSP](http://astro.phys.wvu.edu/GalacticMSPs/) [table](http://astro.phys.wvu.edu/GalacticMSPs/GalacticMSPs.txt).
diff --git a/docs/source/index.rst b/docs/source/index.rst index b25f64c..2d89dee 100644 --- a/docs/source/index.rst +++ b/docs/source/index.rst @@ -273,6 +273,9 @@ download and parse: * Paolo Freire's `table of pulsars in globular clusters <http://www.naic.edu/~pfreire/GCpsr.txt>`_ (note that the downloaded table ...
mattwigway__eqsormo-49
[ { "changes": { "added_entities": [ "src/eqsormo/tra/clear_market.py:clear_market_iter" ], "added_modules": [ "src/eqsormo/tra/clear_market.py:clear_market_iter" ], "edited_entities": [ "src/eqsormo/tra/clear_market.py:clear_market", "src/eqsormo/tra/...
mattwigway/eqsormo
84cf1dc42401895f9b902c82dbfa7285c4b60e8f
endogenous attributes Endogenous attributes should be supported. This doesn't matter in estimation, but in sorting, after each iteration, these endogenous attributes need to be updated.
diff --git a/setup.cfg b/setup.cfg index 79a16af..64f7da2 100644 --- a/setup.cfg +++ b/setup.cfg @@ -1,2 +1,4 @@ [flake8] -max-line-length = 120 \ No newline at end of file +max-line-length = 120 +# disable errors about whitespace before func def parens +ignore = E211 \ No newline at end of file diff --git a/src/eqsor...
matwey__pybeam-15
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "pybeam/beam_file.py:BeamFile.__init__", "pybeam/beam_file.py:BeamFile.selectChunkByName", "pybeam/beam_file.py:BeamFile.atoms", "pybeam/beam_file.py:BeamFile.attributes", ...
matwey/pybeam
2dec4d87719d500070bf1cf3090d5a2cc62f8d9b
KeyError: b'CInf' for a BEAM file The following fails: ``` BeamFile('Elixir.IEx.Introspection.beam').compileinfo['source'] KeyError Traceback (most recent call last) <ipython-input-3-7cf8d4bc6f05> in <module> ----> 1 _2.compileinfo['source'] /usr/lib/python3.8/site-packages/...
diff --git a/pybeam/beam_file.py b/pybeam/beam_file.py index eb7b126..6a70fef 100644 --- a/pybeam/beam_file.py +++ b/pybeam/beam_file.py @@ -26,53 +26,49 @@ class BeamFile(object): def __init__(self, f): if not hasattr(f, 'read'): f = open(f, "rb") - self._tree = beam.parse(f.read()) + self._chunks = beam.pa...
maxcountryman__flask-login-815
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/flask_login/login_manager.py:LoginManager._set_cookie" ], "edited_modules": [ "src/flask_login/login_manager.py:LoginManager" ] }, "file": "src/flask_login/login_ma...
maxcountryman/flask-login
423748fbb55bc54d0adbbc849dcf92db7d67daf1
datetime.utcnow and datetime.utcfromtimestamp are deprecated in Python 3.12 **Describe the bug** datetime.utcnow and datetime.utcfromtimestamp are deprecated in Python 3.12 as per the changelog. > [datetime.datetime](https://docs.python.org/3.12/library/datetime.html#datetime.datetime)’s [utcnow()](https://docs.p...
diff --git a/CHANGES.md b/CHANGES.md index e2cb677..accad15 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -10,6 +10,7 @@ Unreleased - Bump to Flask >= 2.3.0. - Bump to Werkzeug >= 2.3.2. - Remove previously deprecated code. #694 +- Use `datetime.now(timezone.utc)` instead of deprecated `datetime.utcnow`. #758 Ver...
maxfischer2781__asyncstdlib-108
[ { "changes": { "added_entities": [ "asyncstdlib/itertools.py:chain._chain_iterator", "asyncstdlib/itertools.py:chain.aclose" ], "added_modules": null, "edited_entities": [ "asyncstdlib/itertools.py:chain.__init__", "asyncstdlib/itertools.py:chain.from_iter...
maxfischer2781/asyncstdlib
d20a48b35e6fd5d360c6a84b53e696684ecb5d98
Change in behavior of chain() between 3.10.5 and 3.10.6. There is a subtle change in behavior introduced in the recent changes to `chain()`. Chain's iterator appears to be escaping from its "scope" when it is interrupted. Here is an example program that produces different output. I'm using Python 3.11.2, but I don't...
diff --git a/asyncstdlib/itertools.py b/asyncstdlib/itertools.py index fc12573..f6f06ee 100644 --- a/asyncstdlib/itertools.py +++ b/asyncstdlib/itertools.py @@ -148,33 +148,54 @@ class chain(AsyncIterator[T]): The resulting iterator consecutively iterates over and yields all values from each of the ``iterable...
maxfischer2781__asyncstdlib-115
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "asyncstdlib/__init__.py" }, { "changes": { "added_entities": [ "asyncstdlib/itertools.py:batched" ], "added_modules": [ ...
maxfischer2781/asyncstdlib
9f3dc40d98e12b3fc82bd31df83254d152c3a137
Match Python 3.12 standard library Python 3.12 is about to update some standard library features suitable for `asyncstdlib`: * [ ] [`itertools`](https://docs.python.org/3.12/whatsnew/3.12.html#itertools) * [ ] [`itertools.batched`](https://docs.python.org/3.12/library/itertools.html#itertools.batched) See [Wha...
diff --git a/asyncstdlib/__init__.py b/asyncstdlib/__init__.py index 2bc35d9..2703d2b 100644 --- a/asyncstdlib/__init__.py +++ b/asyncstdlib/__init__.py @@ -21,6 +21,7 @@ from .functools import reduce, lru_cache, cache, cached_property from .contextlib import closing, contextmanager, nullcontext, ExitStack from .iter...
maxfischer2781__asyncstdlib-12
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "asyncstdlib/itertools.py:islice" ], "edited_modules": [ "asyncstdlib/itertools.py:islice" ] }, "file": "asyncstdlib/itertools.py" } ]
maxfischer2781/asyncstdlib
7d45d075877433a2effb0b3aa9ec949816b892ac
islice consumes too many items The ``stop`` condition of ``islice`` is evaluated by *peeking* at the next item, then discarding it: https://github.com/maxfischer2781/asyncstdlib/blob/7d45d075877433a2effb0b3aa9ec949816b892ac/asyncstdlib/itertools.py#L213-L217 This results in two undesirable behaviours: - if the n...
diff --git a/asyncstdlib/itertools.py b/asyncstdlib/itertools.py index b299840..dfdfd7f 100644 --- a/asyncstdlib/itertools.py +++ b/asyncstdlib/itertools.py @@ -199,22 +199,26 @@ async def islice(iterable: AnyIterable[T], *args: Optional[int]) -> AsyncIterato s = slice(*args) start, stop, step = s.start or 0,...
maxfischer2781__asyncstdlib-14
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "asyncstdlib/asynctools.py:AsyncIteratorBorrow.__init__", "asyncstdlib/asynctools.py:AsyncIteratorBorrow._wrapped_iterator", "asyncstdlib/asynctools.py:AsyncIteratorBorrow.aclose", ...
maxfischer2781/asyncstdlib
1850256467dc3fca67b9139011c56fd3fae69938
Intermediate iterators not cleaned up The ``AsyncIteratorBorrow`` helper creates a wrapper async generator to prevent its underlying iterable from cleanup. The wrapper is never ``aclose``d, which may lead to a resource warning on certain versions of Python. This has no functional effect, but leads to misleading warn...
diff --git a/asyncstdlib/asynctools.py b/asyncstdlib/asynctools.py index 8b7682d..4de42f8 100644 --- a/asyncstdlib/asynctools.py +++ b/asyncstdlib/asynctools.py @@ -26,7 +26,7 @@ class AsyncIteratorBorrow(AsyncGenerator[T, S]): # iterator.__aiter__ is likely to return iterator (e.g. for async def: yield) ...
maxfischer2781__asyncstdlib-150
[ { "changes": { "added_entities": [ "asyncstdlib/functools.py:_FutureCachedValue.__init__", "asyncstdlib/functools.py:_FutureCachedValue.__await__", "asyncstdlib/functools.py:_FutureCachedValue._instance_value", "asyncstdlib/functools.py:_FutureCachedValue._await_impl", ...
maxfischer2781/asyncstdlib
806e85e1808c8d6c8a8b2accff2349b33e601a36
[Feature]: @cached_property that only awaits the wrapped method _once_. ### Describe the feature The `@cached_property` implementation allows for concurrent awaits on the property, with the last call to complete setting the final value: ```python import asyncio import random from asyncstdlib.functools import...
diff --git a/asyncstdlib/functools.py b/asyncstdlib/functools.py index d26b21a..3362ae8 100644 --- a/asyncstdlib/functools.py +++ b/asyncstdlib/functools.py @@ -1,3 +1,4 @@ +from asyncio import iscoroutinefunction from typing import ( Callable, Awaitable, @@ -7,13 +8,15 @@ from typing import ( Generator...
maxfischer2781__asyncstdlib-21
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "asyncstdlib/__init__.py" }, { "changes": { "added_entities": [ "asyncstdlib/builtins.py:_identity", "asyncstdlib/builtins.py:sor...
maxfischer2781/asyncstdlib
eef623202ee91410e33ec6bf7fe194f90cfe96e0
Add sorted built-in The `sorted` built-in seems like it would come useful: ```python sorted_items = await sorted(my_aiter, key=my_key) ``` If it's omitted intentionally, feel free to reject this issue.
diff --git a/asyncstdlib/__init__.py b/asyncstdlib/__init__.py index 8478713..d833165 100644 --- a/asyncstdlib/__init__.py +++ b/asyncstdlib/__init__.py @@ -15,6 +15,7 @@ from .builtins import ( dict, set, tuple, + sorted, ) from .functools import reduce, lru_cache, cache, cached_property from .con...
maxfischer2781__asyncstdlib-24
[ { "changes": { "added_entities": [ "asyncstdlib/builtins.py:_zip_inner", "asyncstdlib/builtins.py:_zip_inner_strict" ], "added_modules": [ "asyncstdlib/builtins.py:_zip_inner", "asyncstdlib/builtins.py:_zip_inner_strict" ], "edited_entities": [ ...
maxfischer2781/asyncstdlib
86ac8c5f6949fa1cf5c80d9586cf84a21eb5d092
Add zip strict flag Python 3.10 / [PEP 618](https://www.python.org/dev/peps/pep-0618/) will add a ``strict`` flag to ``zip``. When ``strict=True``, an exception is raised if the iterables are not of the same length.
diff --git a/asyncstdlib/builtins.py b/asyncstdlib/builtins.py index 4091b8c..06eb44e 100644 --- a/asyncstdlib/builtins.py +++ b/asyncstdlib/builtins.py @@ -134,10 +134,12 @@ async def any(iterable: AnyIterable[T]) -> bool: return False -async def zip(*iterables: AnyIterable[T]) -> AsyncIterator[Tuple[T, ....
maxfischer2781__asyncstdlib-25
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "asyncstdlib/__init__.py" }, { "changes": { "added_entities": [ "asyncstdlib/itertools.py:pairwise" ], "added_modules": [ ...
maxfischer2781/asyncstdlib
b07ce35e46979f8c7edf726b6e5d2d8219735c55
Add itertools.pairwise [Python 3.10 will add ``itertools.pairwise``](https://docs.python.org/3.10/library/itertools.html#itertools.pairwise), which is basically a more specialised cousin of ``itertools.tee``.
diff --git a/asyncstdlib/__init__.py b/asyncstdlib/__init__.py index 14b2178..8a39c89 100644 --- a/asyncstdlib/__init__.py +++ b/asyncstdlib/__init__.py @@ -29,6 +29,7 @@ from .itertools import ( takewhile, starmap, tee, + pairwise, zip_longest, groupby, ) @@ -73,6 +74,7 @@ __all__ = [ ...
maxfischer2781__asyncstdlib-49
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "asyncstdlib/functools.py:CachedProperty._get_attribute" ], "edited_modules": [ "asyncstdlib/functools.py:CachedProperty" ] }, "file": "asyncstdlib/functools.py" } ]
maxfischer2781/asyncstdlib
2b7038d1f3e93c39ef5e6490e3566b79b632febe
Check functools.cached_property return value nesting The handling of the return value in `functools.cached_property` appears to be too deeply/shallowly nested with awaitables. Wrapping of the original method means: - `__wrapped__` is of type `(Self) -> await T` - `value = await self.__wrapped__(instance)` is of typ...
diff --git a/asyncstdlib/functools.py b/asyncstdlib/functools.py index 5bd874c..1e33091 100644 --- a/asyncstdlib/functools.py +++ b/asyncstdlib/functools.py @@ -116,14 +116,9 @@ class CachedProperty: return self._get_attribute(instance) async def _get_attribute(self, instance) -> T: - attributes ...
maxfischer2781__asyncstdlib-60
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "asyncstdlib/__init__.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "asyncstdlib/...
maxfischer2781/asyncstdlib
e26414dfd03390e0498aab0660246a0cf50b05e2
Release 3.10 The [Python 3.10 release schedule](https://www.python.org/dev/peps/pep-0619/) assumes feature freeze for beta 1 @ Monday, 2021-05-03.
diff --git a/asyncstdlib/__init__.py b/asyncstdlib/__init__.py index f972870..79ac930 100644 --- a/asyncstdlib/__init__.py +++ b/asyncstdlib/__init__.py @@ -35,7 +35,7 @@ from .itertools import ( ) from .asynctools import borrow, scoped_iter, await_each, apply, sync -__version__ = "3.9.2" +__version__ = "3.10.0" ...
maxfischer2781__asyncstdlib-82
[ { "changes": { "added_entities": [ "asyncstdlib/_lrucache.py:LRUAsyncCallable.__wrapped__", "asyncstdlib/_lrucache.py:LRUAsyncCallable.cache_discard", "asyncstdlib/_lrucache.py:LRUAsyncBoundCallable.__init__", "asyncstdlib/_lrucache.py:LRUAsyncBoundCallable.__wrapped__", ...
maxfischer2781/asyncstdlib
b3f88f08eb7881c9537b5d4699ea48d787292565
Add a way in functools lru_cache to invalidate just one entry Hello, I want to use this library to cache heavy calls to my database from an API. However, some calls to my API can modify the data stored in the database. I noticed that it was not possible to simply invalidate a particular key from the cache so that it...
diff --git a/asyncstdlib/_lrucache.py b/asyncstdlib/_lrucache.py index 1f94620..780690c 100644 --- a/asyncstdlib/_lrucache.py +++ b/asyncstdlib/_lrucache.py @@ -64,8 +64,12 @@ class LRUAsyncCallable(Protocol[AC]): :py:class:`~typing.Protocol` of a LRU cache wrapping a callable to an awaitable """ - #: Th...
maxfischer2781__asyncstdlib-85
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "asyncstdlib/contextlib.py:_AsyncGeneratorContextManager.__aexit__" ], "edited_modules": [ "asyncstdlib/contextlib.py:_AsyncGeneratorContextManager" ] }, "file": "asyncs...
maxfischer2781/asyncstdlib
c268dbd50331cf1cd163eff4753236b7470631a9
Possible mishandling of GeneratorExit in contextmanager There seems to be an error in `contextmanager.__aexit__` if the wrapped async generator was/is closed already. In this case, `GeneratorExit` kills the wrapped generator which then propagates onwards; however, when `__aexit__` attempts to close the wrapped generato...
diff --git a/asyncstdlib/contextlib.py b/asyncstdlib/contextlib.py index ea8d11d..52a98c7 100644 --- a/asyncstdlib/contextlib.py +++ b/asyncstdlib/contextlib.py @@ -90,7 +90,13 @@ class _AsyncGeneratorContextManager(Generic[T]): raise RuntimeError("generator did not stop after __aexit__") else...
maxfischer2781__asyncstdlib-87
[ { "changes": { "added_entities": [ "asyncstdlib/itertools.py:NoLock.__aenter__", "asyncstdlib/itertools.py:NoLock.__aexit__" ], "added_modules": [ "asyncstdlib/itertools.py:NoLock" ], "edited_entities": [ "asyncstdlib/itertools.py:tee_peer", ...
maxfischer2781/asyncstdlib
eeb76f23e935d1f7e5a12ef68cf5c181fe20f692
`tee()`'s iterators throw RuntimeError when consumed in parallel Thanks for this library, I've been using it on a project recently and found it really useful. The `tee()` function seems to have a bug. If the source is an async generator that awaits in-between yields, and the tee's iterators are consumed in parallel,...
diff --git a/.github/workflows/python-publish.yml b/.github/workflows/python-publish.yml index 3bfabfc..f55528c 100644 --- a/.github/workflows/python-publish.yml +++ b/.github/workflows/python-publish.yml @@ -18,9 +18,9 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: act...
maxfischer2781__bootpeg-13
[ { "changes": { "added_entities": [ "bootpeg/pika/act.py:captures", "bootpeg/pika/act.py:ActionCaptureError.__init__", "bootpeg/pika/act.py:Rule._verify_captures", "bootpeg/pika/act.py:Action.parameters" ], "added_modules": [ "bootpeg/pika/act.py:captures...
maxfischer2781/bootpeg
c0090c9cb553788d0c85a5958c19fa7872f28e7d
Verify Rule+Action captures Both ``Rule`` and ``Action`` can statically derive their provided/supplied arguments. A ``Rule`` should check that its ``Action`` is compatible.
diff --git a/bootpeg/pika/act.py b/bootpeg/pika/act.py index afa59bb..7f8aafd 100644 --- a/bootpeg/pika/act.py +++ b/bootpeg/pika/act.py @@ -4,7 +4,7 @@ Pika bottom-up Peg parser extension to transform parsed source from typing import TypeVar, Any, Dict, Tuple import re -from .peg import Clause, D, Match, MemoTable...
maxhumber__gif-17
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "examples/spiral.py:plot_spiral" ], "edited_modules": [ "examples/spiral.py:plot_spiral" ] }, "file": "examples/spiral.py" }, { "changes": { "added_entitie...
maxhumber/gif
d41ef3ac837fed1bc9f4b8c217c16ee07cbd64b3
Size optimization idea Hi! I have an idea about optimizing gif size: ```python from PIL import Image from pathlib import Path import numpy as np # read list of pngs paths = sorted(Path('.').glob('out*.png')) # open pngs as numpy arrays images = [np.array(Image.open(path)) for path in paths] # stack the...
diff --git a/examples/spiral.py b/examples/spiral.py index 98f9431..ba5b5c3 100644 --- a/examples/spiral.py +++ b/examples/spiral.py @@ -10,7 +10,7 @@ N = 100 @gif.frame def plot_spiral(i): fig = plt.figure(figsize=(5, 3), dpi=100) - ax = fig.gca(projection="3d") + ax = fig.add_subplot(projection="3d") ...
maximkulkin__lollipop-53
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lollipop/types.py:List.load", "lollipop/types.py:List.dump", "lollipop/types.py:Tuple.load", "lollipop/types.py:Tuple.dump", "lollipop/types.py:OneOf.load", "loll...
maximkulkin/lollipop
f7c50ac54610b7965d41f28d0ee5ee5e24dea0ee
Misleading Tuple type Is it on purpose that the Tuple type dumps into / loads from a list instead of a tuple? If yes, I think the naming is a bit misleading… ``` Tuple([String(), Integer(), Boolean()]).load(('foo', 123, False)) Traceback (most recent call last): File "<input>", line 1, in <module> File "site...
diff --git a/lollipop/types.py b/lollipop/types.py index 5f3ac70..3ec8a50 100644 --- a/lollipop/types.py +++ b/lollipop/types.py @@ -1,6 +1,6 @@ from lollipop.errors import ValidationError, ValidationErrorBuilder, \ ErrorMessagesMixin, merge_errors -from lollipop.utils import is_list, is_dict, make_context_aware,...
maximkulkin__lollipop-55
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "lollipop/types.py:Dict.load", "lollipop/types.py:Dict.dump" ], "edited_modules": [ "lollipop/types.py:Dict" ] }, "file": "lollipop/types.py" } ]
maximkulkin/lollipop
360bbc8f9c2b6203ab5af8a3cd051f852ba8dae3
Asymmetry in load/dump for Dict with key_type and dict as values_type I think there is a problem with the Dict type when using both key_type verification and a values_type dictionary: In Dict.dump, the key is used in its original / non-dumped form to lookup the value type. However, in Dict.load, the dumped key is us...
diff --git a/lollipop/types.py b/lollipop/types.py index 3ec8a50..acb7f3b 100644 --- a/lollipop/types.py +++ b/lollipop/types.py @@ -679,16 +679,22 @@ class Dict(Type): errors_builder = ValidationErrorBuilder() result = {} for k, v in iteritems(data): - value_type = self.value_type...
mbillow__python-redpocket-4
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "redpocket/api.py:RedPocket.request", "redpocket/api.py:RedPocket.get_line_details" ], "edited_modules": [ "redpocket/api.py:RedPocket" ] }, "file": "redpocket/a...
mbillow/python-redpocket
0ae02c28feb4a88f0f07032ccc3f691f6fe58507
Retrieve quicker updating data I found that when retrieving data from the `/get-details` endpoint, it appeared to update quicker when `type=api` was included. Without it, the data retrieved appeared to be cached. There was an increase in response time as a side effect, but I took this as a good sign. Call: ```https...
diff --git a/redpocket/api.py b/redpocket/api.py index a69964e..f20da88 100644 --- a/redpocket/api.py +++ b/redpocket/api.py @@ -204,12 +204,15 @@ class RedPocket: self, method: str = "get", url: str = "", + params: dict = None, data: dict = None, _is_retry: bool = Fa...
mblomdahl__qsck-6
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "qsck/__init__.py:deserialize" ], "edited_modules": [ "qsck/__init__.py:deserialize" ] }, "file": "qsck/__init__.py" }, { "changes": { "added_entities": nu...
mblomdahl/qsck
7f4b67ff5ba60e42f4489bff91ac86386532c341
Implement `deserialize` function Hi Mats! Now when we the awesome serializer published and ready as release `qsck==0.1`, how about building upon #4 PR to make a `qsck.deserialize` function as well? Preferably with good usage docs and test coverage, if you would be so kind.. 😸
diff --git a/README.md b/README.md index 99afb17..85f66d2 100644 --- a/README.md +++ b/README.md @@ -5,13 +5,18 @@ qsck Python library for serializing and deserializing a wonky format referred to as ".qs" files. For full format specification, please read through [tests.test_serialize](https://github.com/mblomdahl/qs...
mbr__tinyrpc-91
[ { "changes": { "added_entities": [ "tinyrpc/protocols/__init__.py:default_id_generator" ], "added_modules": [ "tinyrpc/protocols/__init__.py:default_id_generator" ], "edited_entities": null, "edited_modules": null }, "file": "tinyrpc/protocols/__init__...
mbr/tinyrpc
f24c869e45919b31b784c26c6dbd56474e46f9fb
Request ID generator may produce memory leaks There is a private method `JSONRPCProtocol._get_unique_id()` that is responsible for generating unique IDs for RPC client requests: https://github.com/mbr/tinyrpc/blob/2b2857d1947e7019bb01e50badc801194684226b/tinyrpc/protocols/jsonrpc.py#L476 It generates ID's by addit...
diff --git a/docs/protocols.rst b/docs/protocols.rst index 3084121..804f6ab 100644 --- a/docs/protocols.rst +++ b/docs/protocols.rst @@ -88,6 +88,38 @@ API Reference :member-order: bysource +ID Generators +------------- + +By default, the :py:class:`~tinyrpc.protocols.jsonrpc.JSONRPCProtocol` +and :py:class:`...
mbr__tinyrpc-94
[ { "changes": { "added_entities": null, "added_modules": [ "tinyrpc/exc.py:UnexpectedIDError" ], "edited_entities": null, "edited_modules": null }, "file": "tinyrpc/exc.py" }, { "changes": { "added_entities": null, "added_modules": null, "ed...
mbr/tinyrpc
caaef86176364a8793309e928cfabb1a6a953a25
@lnoor, I now see a problem. `JSONRPCProtocol` class doesn't verify response IDs: @lnoor, I now see a problem. `JSONRPCProtocol` class doesn't verify response IDs: https://github.com/mbr/tinyrpc/blob/fb7490ef098d3ec42cb756ae97887300ddbccc65/tinyrpc/protocols/jsonrpc.py#L572 Theoretically it should reject responses ...
diff --git a/tinyrpc/exc.py b/tinyrpc/exc.py index d03d42f..d051896 100644 --- a/tinyrpc/exc.py +++ b/tinyrpc/exc.py @@ -34,6 +34,10 @@ class InvalidReplyError(BadReplyError, ABC): could not be parsed into a response.""" +class UnexpectedIDError (InvalidReplyError, ABC): + """A reply received contained an i...
mc706__changelog-cli-24
[ { "changes": { "added_entities": [ "src/changelog/utils.py:ChangelogUtils.get_unreleased_change_types" ], "added_modules": null, "edited_entities": [ "src/changelog/utils.py:ChangelogUtils.get_changes", "src/changelog/utils.py:ChangelogUtils.get_release_suggestion...
mc706/changelog-cli
a373f3813e442bf45c0eb0a7bcba19669d6953c0
`ChangelogUtils.get_changes` doesn't return all changes it would just return the last line of each section. This worked fine, since nothing else in the code was actually reading the contents, just the existence of a section. IMO, we could: * Change it to return all changes, as I have done in #22 * Change it to...
diff --git a/src/changelog/utils.py b/src/changelog/utils.py index ea09efb..61cb730 100644 --- a/src/changelog/utils.py +++ b/src/changelog/utils.py @@ -1,7 +1,7 @@ import os import re from datetime import date -from typing import cast, Dict, List, Optional +from typing import cast, Dict, List, Optional, Set from...
mc706__changelog-cli-34
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/changelog/commands.py:release" ], "edited_modules": [ "src/changelog/commands.py:release" ] }, "file": "src/changelog/commands.py" } ]
mc706/changelog-cli
c7b6d92cafd7b261f22ecdccbe36434ed8e268a6
The --yes flag on release results in a release type flag being ignored It seems that using the `--yes` flag with release causes the recommended release type to be used rather than one specified by the command. See examples below. It looks like a simple fix - will hopefully raise a PR as soon as I can get my head aro...
diff --git a/CHANGELOG.md b/CHANGELOG.md index a4a3db0..eec5d1f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a Ch * Existing CHANGELOGs will start using these headers after the new run of `changelog release` ### Fixed +*...
mciepluc__cocotb-coverage-70
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "cocotb_coverage/coverage.py:CoverItem.detailed_coverage" ], "edited_modules": [ "cocotb_coverage/coverage.py:CoverItem" ] }, "file": "cocotb_coverage/coverage.py" } ]
mciepluc/cocotb-coverage
9cdc3f0497398c4dc946f31f4a1cd5d6a8e66e9b
Access to `coverage_db['top'].detailed_coverage` field is failed. `CoverItem` class contains `detailed_coverage` property and it can be accessed accordingly to spec. But trying to address it (for instance: `coverage_db['top'].detailed_coverage`) leads to fail. The cause of exception is using `append()` method for a dic...
diff --git a/cocotb_coverage/coverage.py b/cocotb_coverage/coverage.py index 5c903cd..c9bdfe1 100644 --- a/cocotb_coverage/coverage.py +++ b/cocotb_coverage/coverage.py @@ -378,7 +378,7 @@ class CoverItem(object): """ coverage = {} for child in self._children: - coverage.append(chi...
mcmtroffaes__sphinxcontrib-bibtex-260
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": [ "src/sphinxcontrib/bibtex/style/referencing/foot.py:FootReferenceStyle" ] }, "file": "src/sphinxcontrib/bibtex/style/referencing/foot.py" } ]
mcmtroffaes/sphinxcontrib-bibtex
724897e30317df36f65e5568c988f260bf041e21
Add a footnote citation at the end of a sentence It is not uncommon to write a footnote in English like this: > ... curve.¹ As I cannot write the role directly after the `.` in RST I can only write: ```rst ... curve. :footcite:`Name2021` ``` which produces ![note_wrong](https://user-images.githubuserco...
diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 4cc4127..e35f5c0 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -4,6 +4,12 @@ * Allow specific warnings to be suppressed (see issue #255, contributed by stevenrhall). +* Remove space between footnote and author for textual footnote citations in + the default fo...
mdolab__baseclasses-38
[ { "changes": { "added_entities": [ "baseclasses/utils.py:CaseInsensitiveDict._updateMap", "baseclasses/utils.py:CaseInsensitiveDict._getKey", "baseclasses/utils.py:CaseInsensitiveDict.update", "baseclasses/utils.py:CaseInsensitiveSet._updateMap", "baseclasses/utils....
mdolab/baseclasses
6c82a993d67bf773c43757c16f288d035c362b80
Update `caseInsensitveDict` to preserve initial capitalization # Description Currently, keys are cast to lower case on initialization and subsequent addition. We can instead keep those as they are, and just change the string comparison so that they are case insensitive. We should do the same thing for sets also.
diff --git a/baseclasses/utils.py b/baseclasses/utils.py index a83a1e9..fa012ae 100644 --- a/baseclasses/utils.py +++ b/baseclasses/utils.py @@ -5,32 +5,83 @@ class CaseInsensitiveDict(dict): create an instance where keys are not strings. All common Python dictionary operations are supported, and additional o...