instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
mikedh__trimesh-793 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"trimesh/base.py:Trimesh.vertex_neighbors"
],
"edited_modules": [
"trimesh/base.py:Trimesh"
]
},
"file": "trimesh/base.py"
},
{
"changes": {
"added_entitie... | mikedh/trimesh | 7ecffb6302388aebe24508f97c33f50fbf9827fe | pixel out of range in [scene.camera_rays()]
```
scene.camera.resolution = [512, 512]
origins, vectors, pixels = scene.camera_rays()
print(pixels[:3])
```
**output**
```
[[ 0 512]
[ 0 510]
[ 0 509]]
```
the **512** should be **511**
I think that's because in `cameras.ray_pixel_coords` method:
```... | diff --git a/trimesh/base.py b/trimesh/base.py
index 06fc753c..7a6aaae8 100644
--- a/trimesh/base.py
+++ b/trimesh/base.py
@@ -1499,10 +1499,8 @@ class Trimesh(Geometry):
>>> mesh.vertex_neighbors[0]
[1, 2, 3, 4]
"""
- graph = self.vertex_adjacency_graph
- neighbors = [list(grap... |
mikedh__trimesh-835 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"trimesh/exchange/dae.py:_load_texture"
],
"edited_modules": [
"trimesh/exchange/dae.py:_load_texture"
]
},
"file": "trimesh/exchange/dae.py"
},
{
"changes": {
... | mikedh/trimesh | 4cdf8f86acbe3e2841b9803fbd6a1a1d94dad3e9 | Missing texture coordinates while exporting mesh as OBJ
Hi,
I have been trying to export a mesh in .obj format. But, the texture coordinates are missing. The wavefront .obj file consists of `v`, `vn`, `vt` and `f` values. The exported obj has only `v` and `f` values.
I tried to obtain the vertex normals, `vn` t... | diff --git a/README.md b/README.md
index 861fa6a0..828b009f 100644
--- a/README.md
+++ b/README.md
@@ -195,7 +195,7 @@ You can check out the [Github network](https://github.com/mikedh/trimesh/network
Quick recommendation: `GLB` or `PLY`. Every time you replace `OBJ` with `GLB` an angel gets its wings.
-If you want... |
mikedh__trimesh-851 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"trimesh/exchange/dae.py:_parse_material"
],
"edited_modules": [
"trimesh/exchange/dae.py:_parse_material"
]
},
"file": "trimesh/exchange/dae.py"
},
{
"changes":... | mikedh/trimesh | 5abd7553727ab9294d6b9bf475e11c33784ae391 | Exported mesh as .obj appears as solid black color by default
Hi,
I am trying to export a mesh as .obj. The code looks like this:
`export, texture = trimesh.exchange.obj.export_obj(mesh, include_color=True, include_texture=True)`
`with trimesh.util.TemporaryDirectory() as path:`
`obj_path = os.path.join(''... | diff --git a/trimesh/exchange/dae.py b/trimesh/exchange/dae.py
index 681dc1cd..60c1b43b 100644
--- a/trimesh/exchange/dae.py
+++ b/trimesh/exchange/dae.py
@@ -312,7 +312,8 @@ def _parse_material(effect, resolver):
# Compute opacity
if (effect.transparent is not None
and not isinstance(effect.tran... |
mikgroup__sigpy-58 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"sigpy/mri/samp.py:poisson",
"sigpy/mri/samp.py:_poisson"
],
"edited_modules": [
"sigpy/mri/samp.py:poisson",
"sigpy/mri/samp.py:_poisson"
]
},
"file": "... | mikgroup/sigpy | a44d3d3b8b958bb276cd15d614406e14b093842e | RandomState not supported in numba
**Describe the bug**
An [earlier PR](https://github.com/mikgroup/sigpy/pull/55) attempted to resolve an issue where calling `sigpy.mri.samp.poisson` changed the numpy state (#54). However, `numba` only supports a select number of `numpy` operations and no longer supports the `RandomS... | diff --git a/sigpy/mri/samp.py b/sigpy/mri/samp.py
index b2877ec..0bc79ef 100644
--- a/sigpy/mri/samp.py
+++ b/sigpy/mri/samp.py
@@ -30,6 +30,9 @@ def poisson(img_shape, accel, K=30, calib=[0, 0], dtype=np.complex,
SIGGRAPH sketches. 2007.
"""
+ if seed is not None:
+ rand_state = np.random.ge... |
miki725__importanize-22 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "importanize/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"importanize/... | miki725/importanize | 2046972231a37055b5698d80153b08ff35e6864b | comments in import produce invalid syntax
```
from a import b, c # noqa
```
is transformed to:
```
from a import (
b,
c # noqa,
)
```
which is of course invalid syntax | diff --git a/HISTORY.rst b/HISTORY.rst
index 2a6e41e..452409e 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -3,6 +3,13 @@
History
-------
+0.3 (2015-01-18)
+~~~~~~~~~~~~~~~~
+
+* Using tokens to parse Python files. As a result this allows to
+ fix how comments are handled
+ (see `#21 <https://github.com/miki725/i... |
milvus-io__pymilvus-1618 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pymilvus/client/prepare.py:Prepare.alter_collection_request",
"pymilvus/client/prepare.py:Prepare.search_requests_with_expr"
],
"edited_modules": [
"pymilvus/client/prepare.p... | milvus-io/pymilvus | c28ceb17e023463472ce6bc0f96dea48967711d9 | [Bug]: It seems pymilvus==2.2.14 have bug with alter_collection
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Describe the bug
See: https://github.com/matrixji/milvus-lite/actions/runs/5653197188/job/15314820137
```
collection created: demo
Traceback (most recent cal... | diff --git a/pymilvus/client/prepare.py b/pymilvus/client/prepare.py
index 039426ae..512de479 100644
--- a/pymilvus/client/prepare.py
+++ b/pymilvus/client/prepare.py
@@ -233,7 +233,7 @@ class Prepare:
collection_name: str,
properties: Dict,
) -> milvus_types.AlterCollectionRequest:
- kvs ... |
milvus-io__pymilvus-1624 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pymilvus/client/prepare.py:Prepare.alter_collection_request"
],
"edited_modules": [
"pymilvus/client/prepare.py:Prepare"
]
},
"file": "pymilvus/client/prepare.py"
}
] | milvus-io/pymilvus | 8f3ab0c3aead97b4aa6a34244f82990cb95e7d68 | [Bug]: It seems pymilvus==2.2.14 have bug with alter_collection
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Describe the bug
See: https://github.com/matrixji/milvus-lite/actions/runs/5653197188/job/15314820137
```
collection created: demo
Traceback (most recent cal... | diff --git a/pymilvus/client/prepare.py b/pymilvus/client/prepare.py
index f6b4ca22..6e034617 100644
--- a/pymilvus/client/prepare.py
+++ b/pymilvus/client/prepare.py
@@ -234,7 +234,7 @@ class Prepare:
collection_name: str,
properties: Dict,
) -> milvus_types.AlterCollectionRequest:
- kvs ... |
minio__minio-py-1054 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"minio/commonconfig.py:Filter.__init__"
],
"edited_modules": [
"minio/commonconfig.py:Filter"
]
},
"file": "minio/commonconfig.py"
},
{
"changes": {
"added... | minio/minio-py | bac587a450e0b1e63ea643d86f25006da2fcaba2 | Issue setting bucket (and potentially object) tags
I am using minio-py 7.0.0 and receive a MalformedXML S3Error any time I try to set the tags of my bucket. This issue probably occurs with object tags as well, but I have not tested that yet.
The simplified code below follows your API example code but seems to fail. ... | diff --git a/minio/commonconfig.py b/minio/commonconfig.py
index 735dd42..9d43851 100644
--- a/minio/commonconfig.py
+++ b/minio/commonconfig.py
@@ -179,8 +179,6 @@ class Filter:
)
if not valid:
raise ValueError("only one of and, prefix or tag must be provided")
- if prefix is not ... |
minio__minio-py-1186 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "minio/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"minio/deleteobject... | minio/minio-py | daa3fac94639bf77ad2fa5d1ca9aa8bb68731419 | remove_objects generates invalid XML
The `remove_objects` method generates a XML request which includes the following: `<Quiet>True</Quiet>`. I suspect the boolean value should not be capitalized, it should be `true`.
The [AWS documentation for the DeleteObjects call](https://docs.aws.amazon.com/AmazonS3/latest/API/... | diff --git a/Makefile b/Makefile
index 1c61199..ee466b8 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,7 @@ default: tests
getdeps:
@echo "Installing required dependencies"
- @pip install --user --upgrade autopep8 certifi mock pytest pylint urllib3
+ @pip install --user --upgrade autopep8 certifi pytest pylint ur... |
minio__minio-py-1345 | [
{
"changes": {
"added_entities": [
"minio/crypto.py:_get_cipher",
"minio/crypto.py:_mark_as_last",
"minio/crypto.py:_update_nonce_id",
"minio/crypto.py:DecryptReader.__init__",
"minio/crypto.py:DecryptReader.__enter__",
"minio/crypto.py:DecryptReader.__exit_... | minio/minio-py | 3d9234928a17d7038d236d2b40c496fb6587a9f4 | BUG: Encrypted messages above 16k are not decrypted
## Steps to reproduce
1. Prepare minio installation with over 3k buckets with many user/group bindings. Ideally these bindings should contain entities with long names.
2. Call an endpoint responsible for listing entities with respective affiliations
3. An error o... | diff --git a/minio/crypto.py b/minio/crypto.py
index cafdad9..eeb754c 100644
--- a/minio/crypto.py
+++ b/minio/crypto.py
@@ -14,9 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# pylint: disable=too-many-lines,disable=too-many-branches,too-many-state... |
minio__minio-py-414 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "minio/helpers.py"
}
] | minio/minio-py | d15c965c107f49465c710f9ff22c72120014ff2a | Implement AWS China region support
Our Python Client library should also support AWS China region s3.cn-north-1.amazonaws.com.cn
It has been implemented in minio-go, implementation reference: https://github.com/minio/minio-go/commit/190ac7b4b7e7ba8a669553674b748bdcace6c59e | diff --git a/docs/API.md b/docs/API.md
index 0a1f8cf..b5d578d 100644
--- a/docs/API.md
+++ b/docs/API.md
@@ -110,6 +110,7 @@ __Parameters__
| | | ap-northeast-1|
| | | ap-southeast-2|
| | | sa-east-1|
+| | | cn-north-1|
__Example__
diff --git a/minio/helpers.py b/minio/helpers.py
index 071d5d6..c0dd62f 100644
-... |
minio__minio-py-501 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "examples/listen_notification.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mini... | minio/minio-py | cbe6189d5ee7730931252ac6da2e2fe9af1c9b89 | ListenBucketNotification should also support Get and Head
Depends on minio/minio#3916 | diff --git a/docs/API.md b/docs/API.md
index 993c435..2e77e33 100644
--- a/docs/API.md
+++ b/docs/API.md
@@ -240,7 +240,6 @@ __Return Value__
|``object.last_modified`` |_datetime.datetime_ | modified time stamp. |
-
__Example__
```py
@@ -544,14 +543,15 @@ __Parameters__
|``suffix`` | _string_ | Object key s... |
minio__minio-py-591 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"minio/api.py:Minio._complete_multipart_upload"
],
"edited_modules": [
"minio/api.py:Minio"
]
},
"file": "minio/api.py"
},
{
"changes": {
"added_entities":... | minio/minio-py | 41240393e679226942d2300f281602468b20c7b2 | Part order error with fput_object
When trying to upload a 200MB file to minio server with minio-py I'm getting an error.
minio-py version 2.2.5
minio server RELEASE.2017-09-29T19-16-56Z
```
File "/usr/local/lib/python3.6/dist-packages/minio/api.py", line 561, in fput_object
content_type, metadata)
File... | diff --git a/minio/api.py b/minio/api.py
index cb7e207..3c29b3a 100644
--- a/minio/api.py
+++ b/minio/api.py
@@ -1605,7 +1605,12 @@ class Minio(object):
is_non_empty_string(object_name)
is_non_empty_string(upload_id)
- data = xml_marshal_complete_multipart_upload(uploaded_parts)
+ # Or... |
minio__minio-py-761 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "minio/helpers.py"
}
] | minio/minio-py | 3efe9e9286d61e60ad69cd5e1aa0657b219b396c | Minio rejects valid hostnames
The Minio python library rejects hostnames with underscores in them. Since this is a standard separator for docker container names, this causes problems when trying to run Minio as part of a docker compose setup.
For example, with a linked container named `minio_server`, this python ses... | diff --git a/appveyor.yml b/appveyor.yml
index f6ac53e..c301941 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -7,7 +7,7 @@ environment:
install:
# We need wheel installed to build wheels
- - "%PYTHON%\\python.exe -m pip install wheel faker nose"
+ - "%PYTHON%\\python.exe -m pip install wheel faker nose mock"
... |
ministryofjustice__mt940-writer-12 | [
{
"changes": {
"added_entities": [
"mt940_writer.py:TransactionAdditionalInfo.__init__",
"mt940_writer.py:TransactionAdditionalInfo.__str__",
"mt940_writer.py:TransactionAdditionalInfo.__bool__"
],
"added_modules": [
"mt940_writer.py:TransactionAdditionalInfo"
... | ministryofjustice/mt940-writer | 899a25186b9fe12e60f169789de72ade5aa5fbf5 | add support for Tag 86
<img width="651" alt="image" src="https://github.com/ministryofjustice/mt940-writer/assets/20453622/fb184e68-7eaf-4b13-89c4-f6075d2f28b8">
<img width="474" alt="image" src="https://github.com/ministryofjustice/mt940-writer/assets/20453622/6e08494e-b5f5-41f5-8c97-50de4b552165">
| diff --git a/mt940_writer.py b/mt940_writer.py
index b6a3ad9..f3577ac 100644
--- a/mt940_writer.py
+++ b/mt940_writer.py
@@ -58,11 +58,12 @@ class Balance:
class Transaction:
- def __init__(self, date, amount, transaction_type, narrative):
+ def __init__(self, date, amount, transaction_type, narrative, addit... |
minrk__escapism-4 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"escapism.py:escape"
],
"edited_modules": [
"escapism.py:escape"
]
},
"file": "escapism.py"
}
] | minrk/escapism | 35f4c194ad6de2bc3339bb8b0e522dca989143ff | Escaping an underscore adds "5F" to the word
Hi!
I use escapism as it is part of the dockerspawner:
https://github.com/jupyterhub/dockerspawner/blob/master/dockerspawner/dockerspawner.py#L20
I have a string containing an underscore, and after escaping it by an underscore, I have an additional two characters: `5F... | diff --git a/.travis.yml b/.travis.yml
index 8cae354..ccda971 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,6 +3,8 @@ python:
- 2.7
- 3.4
- 3.6
+- 3.7
+- 3.8
cache:
- pip
install:
diff --git a/escapism.py b/escapism.py
index 5517996..e0cd6ce 100644
--- a/escapism.py
+++ b/escapism.py
@@ -13,8 +13,9 @@ no args ... |
minrk__wurlitzer-52 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wurlitzer.py:Wurlitzer._setup_pipe"
],
"edited_modules": [
"wurlitzer.py:Wurlitzer"
]
},
"file": "wurlitzer.py"
}
] | minrk/wurlitzer | 1d03fdb3b26a6e5db80b4ff6d512ea0c672b43b8 | wurlitzer.pipes hang if output from C is very large
<!-- Thank you for contributing. These HTML commments will not render in the issue, but you can delete them once you've read them if you prefer! -->
### Bug description
The following code works for most C function calls, but hangs when the C-side tries to output t... | diff --git a/wurlitzer.py b/wurlitzer.py
index 9a48e19..d786c89 100644
--- a/wurlitzer.py
+++ b/wurlitzer.py
@@ -32,8 +32,9 @@ from queue import Queue
try:
from fcntl import F_SETPIPE_SZ
except ImportError:
- # ref: linux fcntl.h
+ # ref: linux uapi/linux/fcntl.h
F_SETPIPE_SZ = 1024 + 7
+ F_GETPIPE... |
minrk__wurlitzer-81 | [
{
"changes": {
"added_entities": [
"wurlitzer.py:_LogPipe.__init__",
"wurlitzer.py:_LogPipe._log",
"wurlitzer.py:_LogPipe.write",
"wurlitzer.py:_LogPipe.flush",
"wurlitzer.py:_LogPipe.__enter__",
"wurlitzer.py:_LogPipe.__exit__"
],
"added_modules... | minrk/wurlitzer | 40c6d19459ace576a5864e614baad08090ca5148 | Redirect to logger
Would be nice to have a shim that handles redirection to Python loggers. This [SO question]( https://stackoverflow.com/q/19425736 ) seems relevant. | diff --git a/README.md b/README.md
index f719e8e..9641b76 100644
--- a/README.md
+++ b/README.md
@@ -44,6 +44,21 @@ with sys_pipes():
call_some_c_function()
```
+Forward C-level output to Python Logger objects (new in 3.1).
+Each line of output will be a log message.
+
+```python
+from wurlitzer import pipes, S... |
minrk__wurlitzer-83 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wurlitzer.py:Wurlitzer._setup_pipe",
"wurlitzer.py:Wurlitzer.__enter__",
"wurlitzer.py:Wurlitzer.__exit__"
],
"edited_modules": [
"wurlitzer.py:Wurlitzer"
]
... | minrk/wurlitzer | 38caf37f352235a7e5dcbaa847442c6a879d2921 | Wurlitzer hangs when the GIL is taken by C code
Hello,
I had to debug an issue in a library where I use Wurlitzer. The script I was willing to monitor was using http://caffe.berkeleyvision.org/ which involves some C code and a Python API. This C code output a lot of outputs directly from the C code and don't release... | diff --git a/README.md b/README.md
index 9641b76..e365664 100644
--- a/README.md
+++ b/README.md
@@ -59,13 +59,22 @@ with pipes(logger, stderr=STDOUT):
call_some_c_function()
```
+Forward C-level output to a file (avoids GIL issues with a background thread, new in 3.1):
+
+```python
+from wurlitzer import pipes... |
minrk__wurlitzer-85 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wurlitzer.py:sys_pipes"
],
"edited_modules": [
"wurlitzer.py:sys_pipes"
]
},
"file": "wurlitzer.py"
}
] | minrk/wurlitzer | d7f3ed1f11994a3d8309821cbf3ef4757831470d | `sys_pipes()` hangs on mac os
Running the following code causes `sys_pipes()` to hang on mac os.
`__init__.py` file:
```python
from wurlitzer import sys_pipes
print("Before")
with sys_pipes():
print("After sys pipes")
print("Done")
```
Output is:
<img width="841" alt="image" src="https://git... | diff --git a/wurlitzer.py b/wurlitzer.py
index 7e7db95..39089a7 100644
--- a/wurlitzer.py
+++ b/wurlitzer.py
@@ -532,10 +532,29 @@ class _LogPipe(io.BufferedWriter):
def sys_pipes(encoding=_default_encoding, bufsize=None):
"""Redirect C-level stdout/stderr to sys.stdout/stderr
- This is useful of sys.sdout/s... |
minrk__wurlitzer-89 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wurlitzer.py:Wurlitzer._setup_pipe"
],
"edited_modules": [
"wurlitzer.py:Wurlitzer"
]
},
"file": "wurlitzer.py"
}
] | minrk/wurlitzer | 81bfdae82a9a225f2d5b33918d25e8e8a8a271ef | pipes are not redirected back in 3.1.0
```python
import wurlitzer
with open("log", "w") as f, wurlitzer.pipes(f):
print("foo")
print("bar")
```
In 3.0.3, it will print `bar`. But in 3.1.0 it will print nothing and `bar` is also in `log`. Tested on MacOS and Linux. | diff --git a/README.md b/README.md
index 2780dde..e365664 100644
--- a/README.md
+++ b/README.md
@@ -21,7 +21,7 @@ with pipes() as (out, err):
stdout = out.read()
```
-Capture both stdout and stderr in a single StringIO object:
+Capture stdout/stderr in StringIO:
```python
from io import StringIO
diff --git a/w... |
mir-dataset-loaders__mirdata-170 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/utils.py:check_index",
"mirdata/utils.py:validator"
],
"edited_modules": [
"mirdata/utils.py:check_index",
"mirdata/utils.py:validator"
]
},
"fi... | mir-dataset-loaders/mirdata | 19f00606c820f4b7d83da97109584f8687f2665e | utils.validator is undocumented
See: https://github.com/mir-dataset-loaders/mirdata/blob/master/mirdata/utils.py#L106
This is already a to-do in the code, but i figured it deserved its own issue number. | diff --git a/mirdata/utils.py b/mirdata/utils.py
index 009c776..36053df 100644
--- a/mirdata/utils.py
+++ b/mirdata/utils.py
@@ -62,13 +62,12 @@ def log_message(message, silence=False):
print(message)
-def check_index(dataset_index, data_home, silence=False):
+def check_index(dataset_index, data_home):
... |
mir-dataset-loaders__mirdata-212 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/beatles.py:Track.to_jams"
],
"edited_modules": [
"mirdata/beatles.py:Track"
]
},
"file": "mirdata/beatles.py"
},
{
"changes": {
"added_entities": ... | mir-dataset-loaders/mirdata | 3404425f929e9dc106a18ae8bdfd1a255ce3c4d0 | f0s_to_jams is not compliant with pitch_contour namespace
The function `jams_utils.f0s_to_jams` produces a `jam` object whose `Annotation` is marked as `pitch_contour`. However, this `Annotation` is not compliant with the official `pitch_contour` namespace of JAMS. The consequence is that orchset Tracks cannot be expor... | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index f81bf23..504f016 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -14,6 +14,8 @@ Finally, run tox with `tox`. All tests should pass!
## Contributing a new dataset loader
+**IMPORTANT:** when starting your pull request lease use the **new_loader.md template... |
mir-dataset-loaders__mirdata-230 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/dali.py:Track.to_jams",
"mirdata/dali.py:download"
],
"edited_modules": [
"mirdata/dali.py:Track",
"mirdata/dali.py:download"
]
},
"file": "mird... | mir-dataset-loaders/mirdata | bfbe6ccafaf87d85dbd213f1da2bcb2be3e19e9f | dali._load_metadata() points to the wrong path
Follow-up from a discussion with @gabolsgabs
Here are our instructions on how to download DALI:
```
To download this dataset, visit:
https://zenodo.org/record/2577915 and request access.
Once downloaded, unzip the file DALI_v1.0.zip
... | diff --git a/docs/source/datasets.rst b/docs/source/datasets.rst
index ad7daf4..f58837a 100644
--- a/docs/source/datasets.rst
+++ b/docs/source/datasets.rst
@@ -33,8 +33,8 @@ click the link provided in the "Module" column.
| dali_ | DALI | - audio: 📺 | - :ref:`lyrics` | 535... |
mir-dataset-loaders__mirdata-232 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/groove_midi.py:_load_metadata",
"mirdata/groove_midi.py:Track.__init__",
"mirdata/groove_midi.py:Track.to_jams"
],
"edited_modules": [
"mirdata/groove_midi.py... | mir-dataset-loaders/mirdata | bfbe6ccafaf87d85dbd213f1da2bcb2be3e19e9f | Tempo description missing from datasets table
(my fault, introduced in #207 !)
The table of datasets is missing documentation for "tempo", which is referenced in groove_midi
https://mirdata.readthedocs.io/en/latest/source/datasets.html
| diff --git a/docs/source/datasets.rst b/docs/source/datasets.rst
index ad7daf4..f58837a 100644
--- a/docs/source/datasets.rst
+++ b/docs/source/datasets.rst
@@ -33,8 +33,8 @@ click the link provided in the "Module" column.
| dali_ | DALI | - audio: 📺 | - :ref:`lyrics` | 535... |
mir-dataset-loaders__mirdata-240 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/beatles.py:load_audio",
"mirdata/beatles.py:load_beats",
"mirdata/beatles.py:load_chords",
"mirdata/beatles.py:load_key",
"mirdata/beatles.py:load_sections"
... | mir-dataset-loaders/mirdata | b547a988cd5629d9c86fc6c02a59d38345e4b0b1 | `module.load_*` should raise `IOError`, not return `None`
raised by @rabitt in a meeting today
Many of the module-specific loaders, e.g. `orchset.load_melody`, return `None` if the argument does not exist. This can be confusing in the sense that it may suggest that the file exists but that there is no annotation for... | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 9f7e1bb..72888f7 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -255,6 +255,8 @@ def load_audio(audio_path):
# -- for example, the code below. This should be dataset specific!
# -- By default we load to mono
# -- change this if it doesn't make s... |
mir-dataset-loaders__mirdata-247 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/beatles.py:Track.to_jams"
],
"edited_modules": [
"mirdata/beatles.py:Track"
]
},
"file": "mirdata/beatles.py"
},
{
"changes": {
"added_entities": ... | mir-dataset-loaders/mirdata | ec3eb7820885cad4f1586a6bf493b85c431088e9 | Jams object completeness
For ease of contribution, we've implemented a `jams_utils.jams_converter` function which writes jams objects under the hood for each Track object's `.to_jams()` method. This has two benefits:
* contributors do not need to be familiar with the jams api
* each dataset module's code is drastical... | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index c59ed54..05d2dd6 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -208,9 +208,9 @@ class Track(track.Track):
self._data_home, self._track_paths['annotation'][0])
# -- if the user doesn't have a metadata file, load None
- metadata =... |
mir-dataset-loaders__mirdata-249 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/gtzan_genre.py:Track.__init__"
],
"edited_modules": [
"mirdata/gtzan_genre.py:Track"
]
},
"file": "mirdata/gtzan_genre.py"
}
] | mir-dataset-loaders/mirdata | 65a71956100481e5ac0a5e0d7d515c85987e766e | gtzan-genre 'hiphop' vs 'hip-hop'
gtzan_genre uses the genre name 'hiphop', where the jams gtzan_genre schema expects 'hip-hop' so the jams files do not validate.
(Found as part of #241 ) | diff --git a/mirdata/gtzan_genre.py b/mirdata/gtzan_genre.py
index f9806d5..6a55642 100644
--- a/mirdata/gtzan_genre.py
+++ b/mirdata/gtzan_genre.py
@@ -63,6 +63,9 @@ class Track(track.Track):
self._track_paths = DATA.index[track_id]
self.genre = track_id.split(".")[0]
+ if self.genre == 'hip... |
mir-dataset-loaders__mirdata-295 | [
{
"changes": {
"added_entities": [
"mirdata/track.py:MultiTrack.__init__",
"mirdata/track.py:MultiTrack.get_target",
"mirdata/track.py:MultiTrack.get_random_target",
"mirdata/track.py:MultiTrack.get_mix"
],
"added_modules": [
"mirdata/track.py:MultiTrack... | mir-dataset-loaders/mirdata | f8636612821caa78706c0b56def9084ae5ffd711 | Multitrack Datasets
How can we best support multitrack datasets? The current solution is to have each 'Track' be a multitrack with a ton of attributes, but it's clunky and difficult to take full advantage of the multitracks themselves. We're also loosely tying a `Track` to something that can be mapped to a `jams` file/... | diff --git a/mirdata/track.py b/mirdata/track.py
index a503ea7..208174d 100644
--- a/mirdata/track.py
+++ b/mirdata/track.py
@@ -1,18 +1,18 @@
# -*- coding: utf-8 -*-
"""track object utility functions
"""
-
-
import types
+import numpy as np
+
MAX_STR_LEN = 100
class Track(object):
def __repr__(self):
... |
mir-dataset-loaders__mirdata-312 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/beatport_key.py:load_key"
],
"edited_modules": [
"mirdata/beatport_key.py:load_key"
]
},
"file": "mirdata/beatport_key.py"
},
{
"changes": {
"adde... | mir-dataset-loaders/mirdata | 82c024c4c1214f8e0bc9adf80d3e6289c85a1241 | beatport key bad index
I have found an error. Index doesnt have all the keys.
I am sorry. | diff --git a/mirdata/beatport_key.py b/mirdata/beatport_key.py
index ef2d72d..2d6a851 100644
--- a/mirdata/beatport_key.py
+++ b/mirdata/beatport_key.py
@@ -90,7 +90,7 @@ class Track(track.Track):
@utils.cached_property
def key(self):
- """String: key annotation"""
+ """List of String: list of... |
mir-dataset-loaders__mirdata-406 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mirdata/annotations.py:BeatData.__init__",
"mirdata/annotations.py:SectionData.__init__",
"mirdata/annotations.py:NoteData.__init__",
"mirdata/annotations.py:ChordData.__init__",... | mir-dataset-loaders/mirdata | 8b75cc24c6616bc6065d386f18421e76f6e1e3e4 | Convention for missing annotations
Some datasets have tracks with missing annotations. Right now we handle them inconsistently. For example if a beat annotation is missing for a track, some loaders return `None` and some return `BeatData(None, None)`. I'm working on a PR that will add typing to the annotations.py funct... | diff --git a/docs/source/tutorial.rst b/docs/source/tutorial.rst
index 5bed47a..082ca8f 100644
--- a/docs/source/tutorial.rst
+++ b/docs/source/tutorial.rst
@@ -270,6 +270,7 @@ However, to contribute to the library using remote indexes you have to add in ``
``download_utils.RemoteFileMetadata`` dictionary with the rem... |
mir-dataset-loaders__mirdata-72 | [
{
"changes": {
"added_entities": [
"mirdata/beatles.py:Track.__init__",
"mirdata/beatles.py:Track.beats",
"mirdata/beatles.py:Track.chords",
"mirdata/beatles.py:Track.key",
"mirdata/beatles.py:Track.sections"
],
"added_modules": [
"mirdata/beatle... | mir-dataset-loaders/mirdata | d324391d7eac346b0599c26252daec7eeafa481b | Named tuple track objects to classes
Move all track namedtuples to classes to
(1) more easily document the meaning of each attribute
(2) lazy load larger annotation files | diff --git a/mirdata/beatles.py b/mirdata/beatles.py
index 734def9..1667995 100644
--- a/mirdata/beatles.py
+++ b/mirdata/beatles.py
@@ -1,39 +1,70 @@
"""Beatles Dataset Loader
"""
-from collections import namedtuple
import numpy as np
import os
import csv
-import json
import mirdata.utils as utils
-BEATLES_D... |
mir-group__flare-214 | [
{
"changes": {
"added_entities": [
"flare/ase/atoms.py:FLARE_Atoms.as_dict",
"flare/ase/atoms.py:FLARE_Atoms.from_dict"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"flare/ase/atoms.py:FLARE_Atoms"
]
},
"file": "flare/... | mir-group/flare | 69516d403249117616e7c141d06b93df05bdb04d | Structure.from_ase_atoms does not copy forces | diff --git a/docs/source/tutorials/ase.ipynb b/docs/source/tutorials/ase.ipynb
index 033984b6..e12b1afc 100644
--- a/docs/source/tutorials/ase.ipynb
+++ b/docs/source/tutorials/ase.ipynb
@@ -261,8 +261,11 @@
"cell_type": "markdown",
"metadata": {},
"source": [
- "3. Set up parameters for On-The-Fly (OTF)... |
mirumee__ariadne-1071 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/asgi/handlers/graphql_transport_ws.py:GraphQLTransportWSHandler.handle_websocket_subscribe"
],
"edited_modules": [
"ariadne/asgi/handlers/graphql_transport_ws.py:GraphQLTrans... | mirumee/ariadne | 81a77136b4a28c6ec0da2462e3207c8a4804847d | GraphQLTransportWSHandler sends invalid errors message breaking `graphql-ws` clients on error (should be an array)
Lately I switched over to fully using the GraphQLTransportWSHandler for everything (including mutations and queries). However, I am receiving the following error on the client (`"graphql-ws": "^5.11.2",`).... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index fa6ed03..6b8d5bd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,10 +1,13 @@
# CHANGELOG
## 0.20 (UNRELEASED)
+
- Added `query_validator` option to ASGI and WSGI `GraphQL` applications that enables customization of query validation step.
+- Fixed `ERROR` message in... |
mirumee__ariadne-1080 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/validation/query_cost.py:CostValidator.compute_node_cost"
],
"edited_modules": [
"ariadne/validation/query_cost.py:CostValidator"
]
},
"file": "ariadne/validati... | mirumee/ariadne | 1f62d2da08abc8ed5dfd50c83befa8f965a840ed | Query cost validation is skipping `InlineFragmentNode`
I've got tipped by @przlada that our query cost validator skips `InlineFragmentNode` when calculating the costs.
`InlineFragmentNode` is a fragment used when querying interfaces and unions:
```graphql
{
search(query: "lorem ipsum") {
... on User {
... | diff --git a/ariadne/validation/query_cost.py b/ariadne/validation/query_cost.py
index f46775b..d5b29a6 100644
--- a/ariadne/validation/query_cost.py
+++ b/ariadne/validation/query_cost.py
@@ -144,14 +144,18 @@ class CostValidator(ValidationRule):
fragment_type = self.context.schema.get_type(
... |
mirumee__ariadne-1098 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/enums.py:_get_field_with_keys"
],
"edited_modules": [
"ariadne/enums.py:_get_field_with_keys"
]
},
"file": "ariadne/enums.py"
}
] | mirumee/ariadne | 545a957c4aa6fbb3a5bc563160763a4acde1db21 | Query filter with default `null` filter causes error
**GraphQL Schema:**
```gql
Query {
"""Get sensors with filtering"""
sensors(filters: SensorFilters = null): [Sensor!]!
}
```
**Expected Behavior:**
Schema is built with no errors. This happens in Ariadne 0.13.0.
**Actual Behavior:**
In Ari... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f44f302..5934b6b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,15 +2,16 @@
## 0.20 (UNRELEASED)
+- Dropped support for Python 3.7.
+- Added `OpenTelemetry` and `opentelemetry_extension` extension, importable form `ariadne.tracing.opentelemetry`.
- Added `query_v... |
mirumee__ariadne-1160 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/asgi/graphql.py:GraphQL.__init__"
],
"edited_modules": [
"ariadne/asgi/graphql.py:GraphQL"
]
},
"file": "ariadne/asgi/graphql.py"
},
{
"changes": {
... | mirumee/ariadne | de7968498f860ed149a421d6b9eebe61904b01e4 | Support QUERY execution over the GET
GraphQL spec describes a way for executing the queries over `GET`, via `query=`.
Quick research shows that this usage is supported by Apollo Server, but only for `query` operations. This protects it from 2005 happening all over again with `?action=delete&target=123` links-traps b... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 84039c4..829c70d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,11 @@
# CHANGELOG
+## 0.23 (UNRELEASED)
+
+- Added `execute_get_queries` setting to the `GraphQL` apps that controls execution of the GraphQL "query" operations made with GET requests. Defaults to ... |
mirumee__ariadne-1189 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/resolvers.py:resolve_parent_field"
],
"edited_modules": [
"ariadne/resolvers.py:resolve_parent_field"
]
},
"file": "ariadne/resolvers.py"
}
] | mirumee/ariadne | 85d4652d09acb0b2552c8faad1c0a20c543fef06 | set_alias support for nested attributes
I have a use case where the parent resolver returns something like this:
`Person(name="John", state=PersonState(married=False))`
To implement `person { married }`, you would need to create a new resolver returning `parent.state.married`, and in a large schema, there are man... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index bbcf59f..21981d9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,8 +7,9 @@
- Replaced hardcoded HTTP statuses with `HTTPStatus` from the `http` stdlib module.
- Added `include_cookies` option to the `ExplorerApollo`.
- Fixed typing on `extract_data_from_request` meth... |
mirumee__ariadne-153 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/objects.py:ObjectType.field"
],
"edited_modules": [
"ariadne/objects.py:ObjectType"
]
},
"file": "ariadne/objects.py"
},
{
"changes": {
"added_ent... | mirumee/ariadne | aa3d994c27a740306edace41ce66842e6a8a02a3 | Raise ValueError when `field` or `source` decorator was called incorrectly
Currently there's no error when the developer forgets to follow the `field` or `source` decorator with `("name")`, tricking them into thinking that decorated function has been registered while in fact it wasn't.
We could update implementation... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 140a270..befe10e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
- Updated `graphql-core-next` to 1.0.3 which has feature parity with GraphQL.js 14.2.1 and better type annotations.
- `ariadne.asgi.GraphQL` is now an ASGI3 application. ASGI3 is now handled ... |
mirumee__ariadne-172 | [
{
"changes": {
"added_entities": [
"ariadne/enums.py:set_default_enum_values_on_schema",
"ariadne/enums.py:set_default_enum_values"
],
"added_modules": [
"ariadne/enums.py:set_default_enum_values_on_schema",
"ariadne/enums.py:set_default_enum_values"
],
... | mirumee/ariadne | ccf9e5cb89570bc99f5ebc0f28d6f016642d74b3 | Unbound enum values are None when used in arguments
When used as a mutation input, enum parameter should be `str`, but actually is `None`.
```python
def test_executing_mutation_takes_enum():
type_defs = """
type Query {
_: String
}
type Mutation {
eat(meal... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8064549..4e2c0e0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,7 +12,7 @@
- Added support for `extend type` in schema definitions.
- Removed unused `format_errors` utility function and renamed `ariadne.format_errors` module to `ariadne.format_error`.
- Removed exp... |
mirumee__ariadne-266 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/executable_schema.py:make_executable_schema"
],
"edited_modules": [
"ariadne/executable_schema.py:make_executable_schema"
]
},
"file": "ariadne/executable_schem... | mirumee/ariadne | c74037919273300ecc5ceee68097f21faba3954e | Change `make_executable_schema` API to accept multiple bindables args
Currently, the second argument to `make_executable_schema` is list of `SchemaBindlables` or single bindable:
```python
# Single bindable:
schema = make_executable_schema(type_defs, query_type, debug=True)
# Multiple bindables:
schema = make_... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 180e02a..83a51ec 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
## 0.8.0 (UNRELEASED)
- Added recursive loading of GraphQL schema files from provided path.
+- Added support for passing multiple bindables as `*args` to `make_executable_schema`.
- Updated ... |
mirumee__ariadne-357 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/scalars.py:create_default_literal_parser"
],
"edited_modules": [
"ariadne/scalars.py:create_default_literal_parser"
]
},
"file": "ariadne/scalars.py"
}
] | mirumee/ariadne | cdc74bf6db821c702836be9e787b7bbe0113467b | Exception in default_literal_parser() when ValueNode has no "value" member
The [default_literal_parser() function](https://github.com/mirumee/ariadne/blob/master/ariadne/scalars.py#L90) in ariadne.scalars expects nodes to have a "value" member. However, this is not the case with, for example, `ObjectValueNode` or `Lis... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 13ca89f..d0b316d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
- Added `validation_rules` option to query executors as well as ASGI and WSGI apps and Django view that allow developers to include custom query validation logic in their APIs.
- Added `valid... |
mirumee__ariadne-481 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/utils.py:convert_camel_case_to_snake"
],
"edited_modules": [
"ariadne/utils.py:convert_camel_case_to_snake"
]
},
"file": "ariadne/utils.py"
}
] | mirumee/ariadne | 3550f5ee281d87d2c988d00ed3c83bcdcbf7e29d | Unexpected Snake Case for Acronyms
The snake case conversion of the `snake_case_fallback_resolvers` yields unexpected results for words with multiple uppercase letters in a row, e.g.
- `getHTTPResponse` is converted to `get_h_t_t_p_response`, or
- `externalID` is converted to "external_i_d`.
These are unlikely... | diff --git a/ariadne/utils.py b/ariadne/utils.py
index 13c34d0..2a3e3bf 100644
--- a/ariadne/utils.py
+++ b/ariadne/utils.py
@@ -6,20 +6,29 @@ from graphql import GraphQLError, parse
def convert_camel_case_to_snake(graphql_name: str) -> str:
+ # pylint: disable=too-many-boolean-expressions
+ max_index = len(... |
mirumee__ariadne-565 | [
{
"changes": {
"added_entities": [
"ariadne/contrib/federation/schema.py:has_query_type"
],
"added_modules": [
"ariadne/contrib/federation/schema.py:has_query_type"
],
"edited_entities": [
"ariadne/contrib/federation/schema.py:make_federated_schema"
],... | mirumee/ariadne | 8b23fbe5305fc88f4a5f320e22ff717c027ccb80 | Federated schemas should not require at least one query to be implemented
In a Federated environment, the Gateway instantiates the Query type by default. This means that an implementing services should _not_ be required to implement or extend a query.
# Ideal Scenario
This is an example scenario of what is valid i... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4198b89..14971ee 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,7 +5,7 @@
- Added `on_connect` and `on_disconnect` options to `ariadne.asgi.GraphQL`, enabling developers to run additional initialization and cleanup for websocket connections.
- Updated Starlette depen... |
mirumee__ariadne-661 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/resolvers.py:resolve_parent_field"
],
"edited_modules": [
"ariadne/resolvers.py:resolve_parent_field"
]
},
"file": "ariadne/resolvers.py"
},
{
"changes"... | mirumee/ariadne | 851dc4774407cb07cd698ce9fa870b3f0ace0416 | snake_case_fallback_resolvers not calling obj.get(attr_name)
**Ariadne version:** 0.13.0
**Python version:** 3.8.11
Hello. I am using the [databases](https://www.encode.io/databases/) package with an [asyncpg](https://magicstack.github.io/asyncpg/current/) backend to interact with a PostgreSQL database. The objects... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 14971ee..d3898fc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,7 +6,8 @@
- Updated Starlette dependency to 0.15.
- Added support for multiple keys for GraphQL federations.
- Made `Query` type optional in federated schemas.
-
+- Updated default resolvers to test for... |
mirumee__ariadne-719 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/validation/query_cost.py:CostValidator.get_multipliers_from_string"
],
"edited_modules": [
"ariadne/validation/query_cost.py:CostValidator"
]
},
"file": "ariadn... | mirumee/ariadne | daeb597937498b17c520423546bb33a28856b7c0 | Handle optional args in query cost multiplers
Query cost validator supports complexity multipliers which multiply given complexity by sum of specified values:
```graphql
type Query {
news(promoted: Int, regular: Int): Post @cost(complexity: 1, multipliers: ["promoted", "regular"])
}
```
In situation when ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 478164c..87a6827 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@
- Made `Query` type optional in federated schemas.
- Updated default resolvers to test for `Mapping` instead of `dict`.
- Removed `ariadne.contrib.django`. (Use [ariadne_django](https://github... |
mirumee__ariadne-980 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/asgi/graphql.py:GraphQL.__init__"
],
"edited_modules": [
"ariadne/asgi/graphql.py:GraphQL"
]
},
"file": "ariadne/asgi/graphql.py"
},
{
"changes": {
... | mirumee/ariadne | 36c72e0a9aabc76aeb5955831c0e88bddd7fea22 | Add `execution_context_class` to ASGI and WSGI GraphQL apps
#968 added support for `execution_context_class` customization in our `graphql` wrappers around `execute`, but there's no way currently to set those on GraphQL apps. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cae3086..027bb41 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,7 +10,7 @@
- Added support for `@tag` directive used by Apollo Federation.
- Updated `starlette` dependency in setup.py to `<1.0`.
- Moved project configuration from `setup.py` to `pyproject.toml`.
-- ... |
mirumee__ariadne-990 | [
{
"changes": {
"added_entities": [
"ariadne/graphql.py:root_value_two_args_deprecated"
],
"added_modules": [
"ariadne/graphql.py:root_value_two_args_deprecated"
],
"edited_entities": [
"ariadne/graphql.py:graphql",
"ariadne/graphql.py:graphql_sync",
... | mirumee/ariadne | bc1e00bc31ccab9e8312872075ffd05043e5a59e | Pass operation name and variables to root value resolver
Split form #843
Callable root value resolver becomes really useful in scenarios like GraphQL proxies, but it should have easy access to operation name and variables dict for that.
Plan is to change root value callable to support those as extra arguments, ef... | diff --git a/.pylintrc b/.pylintrc
index 02b186f..46abd67 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -3,7 +3,7 @@ ignore=snapshots
load-plugins=pylint.extensions.bad_builtin, pylint.extensions.mccabe
[MESSAGES CONTROL]
-disable=C0103, C0111, C0209, C0412, I0011, R0101, R0801, R0901, R0902, R0903, R0912, R0913, R0914... |
mirumee__ariadne-993 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ariadne/asgi/handlers/base.py:GraphQLHandler.get_context_for_request"
],
"edited_modules": [
"ariadne/asgi/handlers/base.py:GraphQLHandler"
]
},
"file": "ariadne/asgi/h... | mirumee/ariadne | 408982696eab53c05acf5d9ee38fe03ac2df2fb0 | Pass in data to get_context_for_request
That way you can write something like:
```python
async def get_context_for_request(
self,
request: Any,
*, data: Dict[str, Any] = None
) -> Any:
if callable(self.context_value):
context = self.context_value(request)
... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 57f4b2f..71e21a0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@
- Changed `logger` option to also support `Logger` and `LoggerAdapter` instance in addition to `str` with logger name.
- Added support for `@tag` directive used by Apollo Federation.
- Moved p... |
mirumee__django-prices-62 | [
{
"changes": {
"added_entities": [
"django_prices/models.py:TaxedMoneyField.__eq__",
"django_prices/models.py:TaxedMoneyField.__lt__"
],
"added_modules": null,
"edited_entities": [
"django_prices/models.py:TaxedMoneyField.__init__"
],
"edited_modules":... | mirumee/django-prices | a6e44f6b7ac6ae71af5d99f8b872eb2f1ed340fa | TaxedMoneyField should be Django Field type
Right now there is:
```
class TaxedMoneyField(object):
...
```
is being used and named as a Field, so I guess it should also be type of some Django Field, not `object`. | diff --git a/django_prices/models.py b/django_prices/models.py
index 48a2de5..264d179 100644
--- a/django_prices/models.py
+++ b/django_prices/models.py
@@ -2,6 +2,7 @@ import itertools
from django.core import validators
from django.db import models
+from django.db.models import Field
from django.utils.functional ... |
mirumee__google-i18n-address-30 | [
{
"changes": {
"added_entities": [
"i18naddress/__init__.py:ValidationRules.__init__",
"i18naddress/__init__.py:ValidationRules.__repr__"
],
"added_modules": [
"i18naddress/__init__.py:ValidationRules"
],
"edited_entities": [
"i18naddress/__init__.py... | mirumee/google-i18n-address | c0f6abf05be235c29fc0a22098081b717ba6e704 | Could the postal_code_examples be returned as array not string?
```python
ValidationRules.postal_code_examples
```
returns a list of zip codes examples but as string separated by `,`. | diff --git a/README.rst b/README.rst
index dc2cd14..1dd7670 100644
--- a/README.rst
+++ b/README.rst
@@ -201,6 +201,7 @@ useful for constructing address forms specific for a particular country:
>>> from i18naddress import get_validation_rules
>>> get_validation_rules({'country_code': 'US', 'country_area': 'CA... |
mirumee__google-i18n-address-62 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"i18naddress/__init__.py:load_validation_data"
],
"edited_modules": [
"i18naddress/__init__.py:load_validation_data"
]
},
"file": "i18naddress/__init__.py"
}
] | mirumee/google-i18n-address | aaa90ee859a5ff445b9cb39a67e12db047db0027 | `load_validation_data` throws TypeErrors if site-packages path includes `%` characters
https://github.com/mirumee/google-i18n-address/blob/aaa90ee859a5ff445b9cb39a67e12db047db0027/i18naddress/__init__.py#L31
The above line throws TypeError exceptions if `VALIDATION_DATA_PATH` contains any `%` characters.
```
10:3... | diff --git a/i18naddress/__init__.py b/i18naddress/__init__.py
index 4ea2bd5..c53c8fc 100644
--- a/i18naddress/__init__.py
+++ b/i18naddress/__init__.py
@@ -28,7 +28,14 @@ def load_validation_data(country_code="all"):
if not VALID_COUNTRY_CODE.match(country_code):
raise ValueError("%r is not a valid count... |
mirumee__prices-26 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"prices/price.py:Price.__init__"
],
"edited_modules": [
"prices/price.py:Price"
]
},
"file": "prices/price.py"
},
{
"changes": {
"added_entities": null,
... | mirumee/prices | e56c162aa254f17ab3fa50b718d74e491a90b913 | Price can be created with net and gross with different currencies
Right now we allow to create Price with net Amount and gross Amount with different currencies.
`Price(net=Amount('25', 'USD'), gross=Amount('30', 'EUR'))`
This should not be allowed and should rise an exception. | diff --git a/prices/price.py b/prices/price.py
index ffc15bb..549dfab 100644
--- a/prices/price.py
+++ b/prices/price.py
@@ -14,6 +14,10 @@ class Price(object):
if not isinstance(net, Amount) or not isinstance(gross, Amount):
raise TypeError('Price requires two amounts, got %r, %r' % (
... |
mishana__vectorized2d-21 | [
{
"changes": {
"added_entities": [
"vectorized2d/vector2d.py:Vector2D._calc_angle_diff",
"vectorized2d/vector2d.py:Vector2D.angle_to"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"vectorized2d/vector2d.py:Vector2D"
]
},
... | mishana/vectorized2d | 2e7da39fab9afcea100a8b813de86db2f5922314 | Add "Calc angle between vectors" method to Vector2D | diff --git a/vectorized2d/vector2d.py b/vectorized2d/vector2d.py
index d33e6f6..f054ca7 100644
--- a/vectorized2d/vector2d.py
+++ b/vectorized2d/vector2d.py
@@ -84,6 +84,24 @@ class Vector2D(Array2D):
new_direction = self.direction + rotation_angle
return Vector2D(magnitude=self.norm, direction=new_di... |
missionpinball__mpf-1062 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "mpf/_version.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/core/config_proc... | missionpinball/mpf | 6ba39ef0491365f87da0a9bc28ab541a600bc7f4 | String placeholders are lower cased. Support uppercase strings
Fix and test | diff --git a/mpf/_version.py b/mpf/_version.py
index 11d3ee171..d79f94544 100644
--- a/mpf/_version.py
+++ b/mpf/_version.py
@@ -10,7 +10,7 @@ PyPI.
"""
-__version__ = '0.50.0-dev.44'
+__version__ = '0.50.0-dev.43'
'''The full version of MPF.'''
__short_version__ = '0.50'
diff --git a/mpf/core/config_processor... |
missionpinball__mpf-1074 | [
{
"changes": {
"added_entities": [
"mpf/core/placeholder_manager.py:PlayersPlaceholder.__init__",
"mpf/core/placeholder_manager.py:PlayersPlaceholder.subscribe",
"mpf/core/placeholder_manager.py:PlayersPlaceholder.subscribe_attribute",
"mpf/core/placeholder_manager.py:Playe... | missionpinball/mpf | ca7dadb34fac8c7bc0cb2a036e61af9ec0b1369b | Text templates ng
Current text templates look like this:
```
Player (player|number) Score: (player|score) Color: (machine|score)
```
Those work fine mostly. But they have a few limitations:
* No internationalization (i18n)
* No math/conditionals
* No formating
* Pipes are confusing because we use dots for o... | diff --git a/mpf/core/placeholder_manager.py b/mpf/core/placeholder_manager.py
index 90badc6af..0295c4f80 100644
--- a/mpf/core/placeholder_manager.py
+++ b/mpf/core/placeholder_manager.py
@@ -226,7 +226,7 @@ class MpfFormatter(string.Formatter):
class TextTemplate:
- """Legacy text placeholder."""
+ """Text... |
missionpinball__mpf-1104 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/core/service_controller.py:ServiceController.get_light_map"
],
"edited_modules": [
"mpf/core/service_controller.py:ServiceController"
]
},
"file": "mpf/core/service... | missionpinball/mpf | 04f9b7a8615af0c81701ddd066e77188be706c4a | Support multiple channels for the same color in lights
This will only use the last channel since there can be only one per color:
```
l_white_led:
number: 6-8
type: www
``` | diff --git a/mpf/core/service_controller.py b/mpf/core/service_controller.py
index 694780a75..f4e53b5d3 100644
--- a/mpf/core/service_controller.py
+++ b/mpf/core/service_controller.py
@@ -105,7 +105,7 @@ class ServiceController(MpfController):
raise AssertionError("Not in service mode!")
light_ma... |
missionpinball__mpf-1169 | [
{
"changes": {
"added_entities": [
"mpf/assets/show.py:RunningShow._start_now"
],
"added_modules": null,
"edited_entities": [
"mpf/assets/show.py:Show.play",
"mpf/assets/show.py:RunningShow.__init__",
"mpf/assets/show.py:RunningShow._start_play",
"... | missionpinball/mpf | 879c4891d320e089ef7bb9a7b8aba0873c287afa | Stop shows with sync_ms
When playing a show with sync_ms any previous show with the same key will be stopped instantly but the new show will play in sync. Delay the stop until the new show starts. | diff --git a/mpf/assets/show.py b/mpf/assets/show.py
index 341ccac7c..1ab70ade1 100644
--- a/mpf/assets/show.py
+++ b/mpf/assets/show.py
@@ -274,7 +274,7 @@ class Show(Asset):
events_when_looped=None, events_when_paused=None,
events_when_resumed=None, events_when_advanced=None,
... |
missionpinball__mpf-1226 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/core/bcp/bcp_socket_client.py:decode_command_string"
],
"edited_modules": [
"mpf/core/bcp/bcp_socket_client.py:decode_command_string"
]
},
"file": "mpf/core/bcp/bcp... | missionpinball/mpf | baa7bc960de8089abee0d917212c8f6093311f70 | Crash in BCP when decoding a percent sign
```
ERROR : BCP Client : DECODE BCP ERROR. Message: monitored_event?json={"event_name": "logicblock_baby_bonus_hit", "event_type": null, "event_callback": null, "event_kwargs": {"count": 3}, "registered_handlers": [["<bound method ConfigPlayer.config_play_callback of ConfigPla... | diff --git a/mpf/core/bcp/bcp_socket_client.py b/mpf/core/bcp/bcp_socket_client.py
index 19fb225f9..a0ba6c7f6 100644
--- a/mpf/core/bcp/bcp_socket_client.py
+++ b/mpf/core/bcp/bcp_socket_client.py
@@ -38,12 +38,12 @@ def decode_command_string(bcp_string):
"""
bcp_command = urlsplit(bcp_string)
+ if bcp_c... |
missionpinball__mpf-1236 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/devices/drop_target.py:DropTargetBank.reset"
],
"edited_modules": [
"mpf/devices/drop_target.py:DropTargetBank"
]
},
"file": "mpf/devices/drop_target.py"
}
] | missionpinball/mpf | 1a9272de79eab757957e1aba112a59997f8f4f1a | Only reset drop target banks when they are not reset
Currently we always trigger a reset no matter if the bank of up or down. Mirror the behavior of reset on individual drop targets. See this thread for an example: https://groups.google.com/forum/#!topic/mpf-users/kHq3dM1PMyo | diff --git a/mpf/devices/drop_target.py b/mpf/devices/drop_target.py
index 2ac95d3b5..e6eb21095 100644
--- a/mpf/devices/drop_target.py
+++ b/mpf/devices/drop_target.py
@@ -326,11 +326,18 @@ class DropTargetBank(SystemWideDevice, ModeDevice):
del kwargs
self.debug_log('Resetting')
+ if self.d... |
missionpinball__mpf-1244 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/modes/attract/code/attract.py:Attract.mode_start",
"mpf/modes/attract/code/attract.py:Attract.start_button_released"
],
"edited_modules": [
"mpf/modes/attract/code/attrac... | missionpinball/mpf | ea714f2719e28818d07afbc52d774c79e148a4b3 | Support game start/player add with an event in attract and game mode
Currently we only support switches to start a game. Also allow event only starts (e.g. with combo_switches). See: https://groups.google.com/forum/#!topic/mpf-users/vuUJMdSI2_A | diff --git a/mpf/config_spec.yaml b/mpf/config_spec.yaml
index 937b708c5..39c05c8eb 100644
--- a/mpf/config_spec.yaml
+++ b/mpf/config_spec.yaml
@@ -544,7 +544,9 @@ game:
balls_per_game: single|template_int|3
max_players: single|template_int|4
start_game_switch_tag: single|str|start
+ start_game_event... |
missionpinball__mpf-1262 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/core/placeholder_manager.py:BaseTemplate.__init__",
"mpf/core/placeholder_manager.py:RawTemplate.evaluate",
"mpf/core/placeholder_manager.py:DeviceClassPlaceholder.__init__",
... | missionpinball/mpf | d245805eef8a9518d8e8d17a0e3301cd024f6230 | Add conditional variables to shots and shot_groups
Expose the current state of shots and shot_groups to conditional events. | diff --git a/mpf/core/placeholder_manager.py b/mpf/core/placeholder_manager.py
index 601650f00..29a98ba5a 100644
--- a/mpf/core/placeholder_manager.py
+++ b/mpf/core/placeholder_manager.py
@@ -44,10 +44,11 @@ class BaseTemplate(metaclass=abc.ABCMeta):
"""Base class for templates."""
- __slots__ = ["template... |
missionpinball__mpf-1287 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/config_players/coil_player.py:CoilPlayer.play"
],
"edited_modules": [
"mpf/config_players/coil_player.py:CoilPlayer"
]
},
"file": "mpf/config_players/coil_player.py... | missionpinball/mpf | e67b40d891febb679279708351a6fb2560889b9f | coil_player action 'off' crashes out
Using 'off' as an action in a coil_player generates (at run time) an error that the action is not valid (**_Invalid action off_**). Easily worked-around by using 'disabled' instead, but either the code needs fixing or the documentation updating.
So this works fine when the ball_... | diff --git a/mpf/config_players/coil_player.py b/mpf/config_players/coil_player.py
index 9fe7fc5d1..ee67b8552 100644
--- a/mpf/config_players/coil_player.py
+++ b/mpf/config_players/coil_player.py
@@ -27,16 +27,22 @@ class CoilPlayer(DeviceConfigPlayer):
if not isinstance(coil, Driver):
se... |
missionpinball__mpf-1289 | [
{
"changes": {
"added_entities": [
"mpf/platforms/snux.py:SnuxHardwarePlatform.c_side_busy",
"mpf/platforms/snux.py:SnuxHardwarePlatform.a_side_active",
"mpf/platforms/snux.py:SnuxHardwarePlatform._prefer_a_side",
"mpf/platforms/snux.py:SnuxHardwarePlatform._prefer_c_side",... | missionpinball/mpf | 06fc30212bbe3ed4d73dff3bdec8248e1cc7ca28 | System 11 A/C select relay handling
[snux.zip](https://github.com/missionpinball/mpf/files/2730432/snux.zip)
Add 2 parameters to the snux: platform in config_spec.yaml... (the last 2 in this list)
```
snux:
__valid_in__: machine
flipper_enable_driver: single|machine(coils)|
diag_led_driver: sing... | diff --git a/mpf/config_spec.yaml b/mpf/config_spec.yaml
index afe7a653e..9772cb31c 100644
--- a/mpf/config_spec.yaml
+++ b/mpf/config_spec.yaml
@@ -1232,6 +1232,8 @@ snux:
platform: single|str|None
console_log: single|enum(none,basic,full)|none
file_log: single|enum(none,basic,full)|basic
+ prefer_a_... |
missionpinball__mpf-1321 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/core/machine.py:MachineController.__init__"
],
"edited_modules": [
"mpf/core/machine.py:MachineController"
]
},
"file": "mpf/core/machine.py"
},
{
"changes"... | missionpinball/mpf | fae71087b212c35ffa32a7a9da82afe8fe9eb544 | Better error for diverter without coil
Show a better error message: https://groups.google.com/forum/m/#!topic/mpf-users/YZlYmkEzAkw | diff --git a/mpf/core/machine.py b/mpf/core/machine.py
index d40f23119..050a488cf 100644
--- a/mpf/core/machine.py
+++ b/mpf/core/machine.py
@@ -68,6 +68,7 @@ if MYPY: # pragma: no cover
from mpf.devices.dmd import Dmd
from mpf.devices.rgb_dmd import RgbDmd
from mpf.devices.flipper import Flipper
+ ... |
missionpinball__mpf-1331 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/modes/high_score/code/high_score.py:HighScore._run"
],
"edited_modules": [
"mpf/modes/high_score/code/high_score.py:HighScore"
]
},
"file": "mpf/modes/high_score/co... | missionpinball/mpf | 211d5d0711e50bb49c2a02b7961394a008e2b86c | Fix crash in high_score mode
Crash when starting high acores mode after game enderd:
```
Traceback (most recent call last):
File "c:\users\wilder\appdata\local\programs\python\python36\lib\site-packages\mpf\commands\game.py", line 220, in __init__
MachineController(mpf_path, machine_path, vars(self.args)).r... | diff --git a/mpf/modes/high_score/code/high_score.py b/mpf/modes/high_score/code/high_score.py
index cbaf6c6a8..088ca061d 100644
--- a/mpf/modes/high_score/code/high_score.py
+++ b/mpf/modes/high_score/code/high_score.py
@@ -124,7 +124,8 @@ class HighScore(AsyncMode):
@asyncio.coroutine
def _run(self) -> Gene... |
missionpinball__mpf-1397 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/config_players/event_player.py:EventPlayer.play"
],
"edited_modules": [
"mpf/config_players/event_player.py:EventPlayer"
]
},
"file": "mpf/config_players/event_play... | missionpinball/mpf | 203713532706bda29e2ea0a0b83cf10f7c5ccf61 | Move parse_conditional_template out of players
Parsing should be done when loading the player not during runtime. Move all calls to load time. | diff --git a/mpf/config_players/event_player.py b/mpf/config_players/event_player.py
index 4bcdb7223..e15c77633 100644
--- a/mpf/config_players/event_player.py
+++ b/mpf/config_players/event_player.py
@@ -28,15 +28,15 @@ class EventPlayer(FlatConfigPlayer):
s = deepcopy(s)
event_dict = self.ma... |
missionpinball__mpf-1424 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mpf/config_players/show_player.py:ShowPlayer._expand_device_config"
],
"edited_modules": [
"mpf/config_players/show_player.py:ShowPlayer"
]
},
"file": "mpf/config_playe... | missionpinball/mpf | c43bf1badfedd961d324af3199ea586438102ca3 | Suggest config section on typos
With a broken config such as:
```
hardware_sound_system:
default:
label: LISY
```
Users get errors such as: `Found a "hardware_sound_system:" section in config file xxx\config\config, but that section is not valid in machine config files.`
Ideally we would recomm... | diff --git a/mpf/config_players/show_player.py b/mpf/config_players/show_player.py
index 1b721778f..b7627fdc1 100644
--- a/mpf/config_players/show_player.py
+++ b/mpf/config_players/show_player.py
@@ -67,7 +67,7 @@ class ShowPlayer(DeviceConfigPlayer):
for key in RESERVED_KEYS:
if key in device_se... |
missionpinball__mpf-1564 | [
{
"changes": {
"added_entities": [
"mpf/devices/logic_blocks.py:LogicBlock._logic_block_timer_start",
"mpf/devices/logic_blocks.py:LogicBlock._logic_block_timeout"
],
"added_modules": null,
"edited_entities": [
"mpf/devices/logic_blocks.py:LogicBlock.__init__",
... | missionpinball/mpf | 5903fba37c6ab4fbfcfc3e0e9523d0e8dc80cb22 | Add timeouts to logic blocks
Add a timeout to logic blocks such as counters, sequences and sequels. It should reset the block if it expires. This should only cover this very basic usecase and everything advanced can use an external timer. | diff --git a/mpf/config_spec.yaml b/mpf/config_spec.yaml
index 4f90ba675..dce39ea73 100644
--- a/mpf/config_spec.yaml
+++ b/mpf/config_spec.yaml
@@ -835,6 +835,7 @@ logic_blocks_common:
start_enabled: single|bool|None
events_when_complete: list|event_posted|None
events_when_hit: list|event_posted|None
+ ... |
mit-ll-responsible-ai__hydra-zen-115 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
],
"edited_modules": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
]
},
"file": "src/hydr... | mit-ll-responsible-ai/hydra-zen | be833ddd76f8380a987a26c8990802801adb5d63 | hydra_partial=True and hydra_recursive=False should be permitted
Thanks to #110 we don't need to rely on recursive instantiation to implement `hydra_partial=True` anymore. I.e. we can get rid of:
https://github.com/mit-ll-responsible-ai/hydra-zen/blob/5f48f4b0c408a8a25ed8d5c2aa66b2316e9d8118/src/hydra_zen/structure... | diff --git a/src/hydra_zen/structured_configs/_implementations.py b/src/hydra_zen/structured_configs/_implementations.py
index 5bddae30..0b06ce47 100644
--- a/src/hydra_zen/structured_configs/_implementations.py
+++ b/src/hydra_zen/structured_configs/_implementations.py
@@ -681,12 +681,6 @@ def builds(
if any(not ... |
mit-ll-responsible-ai__hydra-zen-162 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
],
"edited_modules": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
]
},
"file": "src/hydr... | mit-ll-responsible-ai/hydra-zen | baa7fa0118896cf9e4335e29257246b5521546ca | meta fields dont get set properly when populate_full_signature=True
```python
def foo(a, b):
return a, b
```
Here, `c` is appropriately included in the config.
```python
>>> print(to_yaml(builds(foo, a="${.c}", zen_meta=dict(c=2), populate_full_signature=False)))
_target_: hydra_zen.funcs.zen_processin... | diff --git a/src/hydra_zen/structured_configs/_implementations.py b/src/hydra_zen/structured_configs/_implementations.py
index a05ae3d2..ce826967 100644
--- a/src/hydra_zen/structured_configs/_implementations.py
+++ b/src/hydra_zen/structured_configs/_implementations.py
@@ -1272,33 +1272,6 @@ def builds(
for n... |
mit-ll-responsible-ai__hydra-zen-196 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:make_config"
],
"edited_modules": [
"src/hydra_zen/structured_configs/_implementations.py:make_config"
]
},
"file":... | mit-ll-responsible-ai/hydra-zen | 00c50b770af2644551c30b821ff61f740fd4399a | `make_config` is too aggressive with type-widening
https://github.com/mit-ll-responsible-ai/hydra-zen/blob/00c50b770af2644551c30b821ff61f740fd4399a/src/hydra_zen/structured_configs/_implementations.py#L2405-L2409
needs identical fix from: https://github.com/mit-ll-responsible-ai/hydra-zen/pull/185 | diff --git a/docs/source/changes.rst b/docs/source/changes.rst
index 6d4ee28a..00bf9bd7 100644
--- a/docs/source/changes.rst
+++ b/docs/source/changes.rst
@@ -19,7 +19,7 @@ Improvements
------------
- Fixed an edge case `caused by an upstream bug in inspect.signature <https://bugs.python.org/issue40897>`_, which prev... |
mit-ll-responsible-ai__hydra-zen-199 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
],
"edited_modules": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
]
},
"file": "src/hydr... | mit-ll-responsible-ai/hydra-zen | 764eee669ddcd1cea3f6262b5740e27801fd1494 | Provide support for `builds(functools.partial(target, ...), ...)`
Currently, attempting to use `builds` on a "partial'd" target raises an error because the `__name__` of the object cannot be resolved (which is needed to determine `__target__`):
```python
from hydra_zen import builds
from functools import partial... | diff --git a/docs/source/api_reference.rst b/docs/source/api_reference.rst
index b7f50b66..535faaa3 100644
--- a/docs/source/api_reference.rst
+++ b/docs/source/api_reference.rst
@@ -121,6 +121,8 @@ Values of the following types can be specified directly in configs:
- :py:class:`enum.Enum`
+.. _additional-types:
+... |
mit-ll-responsible-ai__hydra-zen-207 | [
{
"changes": {
"added_entities": [
"src/hydra_zen/structured_configs/_implementations.py:_retain_type_info"
],
"added_modules": [
"src/hydra_zen/structured_configs/_implementations.py:_retain_type_info"
],
"edited_entities": [
"src/hydra_zen/structured_confi... | mit-ll-responsible-ai/hydra-zen | 1a10c852c28ee6260d406b29545b01c1304505ae | Detecting need for auto type-widening in case of interpolation field
hydra-zen reduces common sources of friction with Hydra's runtime type-checking; this includes [applying automatic type-widening to accommodate Builds-as-default](https://github.com/mit-ll-responsible-ai/hydra-zen/pull/84)
In cases where the interp... | diff --git a/docs/source/how_to/pytorch_lightning.rst b/docs/source/how_to/pytorch_lightning.rst
index 2bff5394..cc7f2e2c 100644
--- a/docs/source/how_to/pytorch_lightning.rst
+++ b/docs/source/how_to/pytorch_lightning.rst
@@ -51,7 +51,7 @@ following code. Here, we define our single-layer neural network and the `lightn... |
mit-ll-responsible-ai__hydra-zen-262 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/hydra_zen/_compatibility.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"ed... | mit-ll-responsible-ai/hydra-zen | d64f55c7baf1c82531059c1640e7dc2e46a0978c | omegaconf is adding native support for `bytes`
Tracking at https://github.com/omry/omegaconf/pull/845
On our end:
- [x] `bytes` needs to be (dynamically) added to `HYDRA_SUPPORTED_PRIMITIVE_TYPES` for `omegaconf >= 2.2.0` and removed from `ZEN_SUPPORTED_PRIMITIVES`.
- [x] Ensure that `bytes`, used as a type-ann... | diff --git a/docs/source/api_reference.rst b/docs/source/api_reference.rst
index b7603dcf..2132a8dd 100644
--- a/docs/source/api_reference.rst
+++ b/docs/source/api_reference.rst
@@ -116,7 +116,7 @@ Values of the following types can be specified directly in configs:
- :py:class:`list`
- :py:class:`dict`
- :py:class:... |
mit-ll-responsible-ai__hydra-zen-264 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/hydra_zen/structured_configs/_globals.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
... | mit-ll-responsible-ai/hydra-zen | e9cd49644432176e46c082bee21ac632e5462416 | Add `hydra_defaults` argument to `builds`
Hydra supports specifying `defaults` on targeted configs:
```python
from dataclasses import dataclass, field
from typing import Any
from hydra_zen import launch
import hydra
from hydra.core.config_store import ConfigStore
class MyClass:
def __init__(self,... | diff --git a/docs/source/tutorials/config_groups.rst b/docs/source/tutorials/config_groups.rst
index 674fae4d..cb5cc616 100644
--- a/docs/source/tutorials/config_groups.rst
+++ b/docs/source/tutorials/config_groups.rst
@@ -114,7 +114,7 @@ default config for that group. Let's specify the ``CharConf`` config, which we n
... |
mit-ll-responsible-ai__hydra-zen-266 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_utils.py:get_obj_path",
"src/hydra_zen/structured_configs/_utils.py:sanitized_type"
],
"edited_modules": [
"src/hydra_zen/structured_configs... | mit-ll-responsible-ai/hydra-zen | 8837cdaf536a435c1aa96dd726c3c956ac1147ba | Building an inherited classmethod yields method from parent
```python
class A:
@classmethod
def foo(cls):
return cls.bar()
@classmethod
def bar(self):
raise NotImplementedError()
class B(A):
@classmethod
def bar(self):
return 1
```
```python
>>... | diff --git a/docs/source/changes.rst b/docs/source/changes.rst
index 3be891da..c6219f6b 100644
--- a/docs/source/changes.rst
+++ b/docs/source/changes.rst
@@ -64,11 +64,15 @@ installed. (See :pull:`261`)
Deprecations
------------
-:pull:`263` deprecates the ``builds_bases`` argument in ``make_custom_builds``. It wi... |
mit-ll-responsible-ai__hydra-zen-299 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
],
"edited_modules": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
]
},
"file": "src/hydr... | mit-ll-responsible-ai/hydra-zen | 4d90e3171c831baebe2796096234d10220be355b | Add support for `builds(Dataclass, populate_full_signature=True)` when Dataclass has default factory
`builds(<target>, populate_full_signature=True)` cannot work when `<target>` is a dataclass that has a field described by a default factory[^1].
[^1]: Discovered when playing around with implementation of #293
Min... | diff --git a/docs/source/changes.rst b/docs/source/changes.rst
index 3e999dcb..828005bf 100644
--- a/docs/source/changes.rst
+++ b/docs/source/changes.rst
@@ -28,10 +28,11 @@ hydra-zen :ref:`already provides support for these <additional-types>`, but this
Improvements
------------
-- The :ref:`automatic type refine... |
mit-ll-responsible-ai__hydra-zen-355 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/hydra_zen/typing/_implementations.py:Partial"
]
},
"file": "src/hydra_zen/typing/_implementations.py"
}
] | mit-ll-responsible-ai/hydra-zen | 430b961a6392b0ae5750d824d11b5b7a559a1baf | `validates_with_beartype` considers `Partial` as `NoneType`
Hi @rsokl. I was having a blast using this fascinating library. But It seems when used with `hydra_zen.third_party.validates_with_beartype`, it casts `hydra_zen.typing.Partial` as `NoneType`.
```python
from hydra_zen.typing import Partial
from hydra_ze... | diff --git a/.github/workflows/tox_run.yml b/.github/workflows/tox_run.yml
index fe7d517c..6d7f016b 100644
--- a/.github/workflows/tox_run.yml
+++ b/.github/workflows/tox_run.yml
@@ -91,10 +91,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- - name: Set up Python 3.8
+ - name... |
mit-ll-responsible-ai__hydra-zen-364 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/hydra_zen/_compatibility.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/... | mit-ll-responsible-ai/hydra-zen | 409bd74b390c6ee803eaa7e8c46161e2033430c9 | Add support for `_convert_='object'` for Hydra 1.3.0
See [FR](https://github.com/facebookresearch/hydra/issues/1719) and [merged PR](https://github.com/facebookresearch/hydra/pull/2451) in Hydra for additional details.
In short, starting with Hydra 1.3.0, hydra-zen's config-creation functions should support `hydra_c... | diff --git a/.github/workflows/tox_run.yml b/.github/workflows/tox_run.yml
index bbd88cb4..2f93237c 100644
--- a/.github/workflows/tox_run.yml
+++ b/.github/workflows/tox_run.yml
@@ -139,21 +139,6 @@ jobs:
- name: Test with tox
run: tox -e pre-release
- test-against-hydra-1_1_2dev:
- runs-on: ubuntu-l... |
mit-ll-responsible-ai__hydra-zen-367 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
],
"edited_modules": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
]
},
"file": "src/hydr... | mit-ll-responsible-ai/hydra-zen | 9807b1ba603c6fa74d9756dabf755457007e0048 | `zen_wrapper` should support partial'd wrappers
This should work:
```python
builds(something, zen_wrappers=partial(my_wrapper, param=100))
```
Currently, one would have to write:
```python
builds(something, zen_wrappers=builds(my_wrapper, param=100, zen_partial=True))
```
we just need to check if a wrap... | diff --git a/docs/source/changes.rst b/docs/source/changes.rst
index ac757753..c928b5b1 100644
--- a/docs/source/changes.rst
+++ b/docs/source/changes.rst
@@ -134,6 +134,7 @@ New Features
- Adds `hyda_zen.store`, which is a pre-initialized instance of :class:`~hydra_zen.ZenStore` (see :pull:`331`)
- The option `hydra... |
mit-ll-responsible-ai__hydra-zen-384 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/wrapper/_implementations.py:Zen.__init__",
"src/hydra_zen/wrapper/_implementations.py:Zen.hydra_main"
],
"edited_modules": [
"src/hydra_zen/wrapper/_implementat... | mit-ll-responsible-ai/hydra-zen | 9e7ad1ace47843bdde637d565ac5bcb5d8ebf1b7 | `config_path` broken for `hydra_main`
Hello, it seems like `config_path` is not functional when used with the new `@zen` + `hydra_main` pattern introduced in 0.9.0.
Here's how I repro:
File `/home/petosa/repro/config.yaml`
```
db:
host: local
port: 3307
```
File `/home/petosa/repro/zen.py`
```
from hy... | diff --git a/docs/source/changes.rst b/docs/source/changes.rst
index 41ad1571..28536744 100644
--- a/docs/source/changes.rst
+++ b/docs/source/changes.rst
@@ -8,6 +8,21 @@ Changelog
This is a record of all past hydra-zen releases and what went into them, in reverse
chronological order. All previous releases should s... |
mit-ll-responsible-ai__hydra-zen-455 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
],
"edited_modules": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
]
},
"file": "src/hydr... | mit-ll-responsible-ai/hydra-zen | a44645f68fd52c126bc591d4a540ff83fac5c689 | Nested Partial Builds not Converted when Using Stores and Hydrated_dataclass with Zen_partial
When using stores and hydrated_dataclass together with zen_partial, it seems that the _target_ field gets assigned the Config instead of the actual target. This results in functools.partial[<class '__main__.NestedModelConf'>] ... | diff --git a/docs/source/changes.rst b/docs/source/changes.rst
index bc98b949..56ef9293 100644
--- a/docs/source/changes.rst
+++ b/docs/source/changes.rst
@@ -20,15 +20,57 @@ This release drops support for hydra-core 1.1 and for omegaconf 2.1; this enable
removal of a lot of complex compatibility logic from hydra-zen'... |
mit-ll-responsible-ai__hydra-zen-459 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/hydra_zen/structured_configs/_implementations.py"
}
] | mit-ll-responsible-ai/hydra-zen | 450e1cf0beefeb2d8b2605a55e1048fb6cab2d42 | Don't make any configs frozen by default
Apparently this causes config merge issues: https://github.com/mit-ll-responsible-ai/hydra-zen/discussions/438 | diff --git a/docs/source/changes.rst b/docs/source/changes.rst
index b78326f0..bc98b949 100644
--- a/docs/source/changes.rst
+++ b/docs/source/changes.rst
@@ -8,28 +8,36 @@ Changelog
This is a record of all past hydra-zen releases and what went into them, in reverse
chronological order. All previous releases should ... |
mit-ll-responsible-ai__hydra-zen-600 | [
{
"changes": {
"added_entities": [
"src/hydra_zen/structured_configs/_implementations.py:_ConversionFn.__call__",
"src/hydra_zen/structured_configs/_implementations.py:ConfigComplex.__post_init__",
"src/hydra_zen/structured_configs/_implementations.py:ConfigPath.__post_init__"
... | mit-ll-responsible-ai/hydra-zen | 7b93b419091ce5303f9563d4fb3eca316fc46af9 | Cusont `BuildsFn` autoconfig support doesn't work for hydra-zen extended types
E.g. set, deque, counter have their elements converted by `DefaultBuilds`. | diff --git a/src/hydra_zen/structured_configs/_implementations.py b/src/hydra_zen/structured_configs/_implementations.py
index ebda2b9f..32fbe3eb 100644
--- a/src/hydra_zen/structured_configs/_implementations.py
+++ b/src/hydra_zen/structured_configs/_implementations.py
@@ -50,6 +50,7 @@ from typing_extensions import (... |
mit-ll-responsible-ai__hydra-zen-708 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:BuildsFn._get_obj_path",
"src/hydra_zen/structured_configs/_implementations.py:BuildsFn._make_hydra_compatible"
],
"edited_module... | mit-ll-responsible-ai/hydra-zen | 2e7e253ba904707dc9b3d67b24a37aa7d9771853 | _target_ for inner classes is incorrect
Hello there, big fan of this package.
I believe that there is a bug with the `safe_name` function, that causes the `_target_` field of dynamic configs to be wrong if the target is an inner class:
```python
# project.configs.algorithm.__init__.py
import hydra_zen
import... | diff --git a/src/hydra_zen/structured_configs/_implementations.py b/src/hydra_zen/structured_configs/_implementations.py
index ce556de5..8d44e77d 100644
--- a/src/hydra_zen/structured_configs/_implementations.py
+++ b/src/hydra_zen/structured_configs/_implementations.py
@@ -948,6 +948,7 @@ class BuildsFn(Generic[T]):
... |
mit-ll-responsible-ai__hydra-zen-73 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
],
"edited_modules": [
"src/hydra_zen/structured_configs/_implementations.py:builds"
]
},
"file": "src/hydr... | mit-ll-responsible-ai/hydra-zen | f49084dd8f0e70888199d658a7de097d8db1d84f | Typing Error for `builds` using ART
I was hoping to make a simple example but I'm not sure what is causing the error:
```python
from art.estimators.classification import PyTorchClassifier
builds(PyTorchClassifier) # the config is actually incomplete but it never gets to that error
```
error:
```python
-... | diff --git a/src/hydra_zen/structured_configs/_implementations.py b/src/hydra_zen/structured_configs/_implementations.py
index d13fcf6f..2afbc11c 100644
--- a/src/hydra_zen/structured_configs/_implementations.py
+++ b/src/hydra_zen/structured_configs/_implementations.py
@@ -647,8 +647,9 @@ def builds(
type... |
mitmproxy__pdoc-657 | [
{
"changes": {
"added_entities": [
"pdoc/doc.py:_remove_memory_addresses"
],
"added_modules": [
"pdoc/doc.py:_remove_memory_addresses"
],
"edited_entities": [
"pdoc/doc.py:Function.__init__",
"pdoc/doc.py:Variable.default_value_str",
"pdoc/do... | mitmproxy/pdoc | 3e93213ea55192e1077cbddf9993d06daa5b393b | source_file not extracted for cached function
#### Problem Description
I've created a custom template to show the source file path together with the source of a member.
In this context I found that the source_file of a cached function is not extracted.
#### Steps to reproduce the behavior:
```python
# from the ... | diff --git a/.github/workflows/autofix.yml b/.github/workflows/autofix.yml
index f0e36f5..a69f8ba 100644
--- a/.github/workflows/autofix.yml
+++ b/.github/workflows/autofix.yml
@@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- - uses: actions/setup-python@v4
+ ... |
mitmproxy__pdoc-710 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pdoc/extract.py:iter_modules2"
],
"edited_modules": [
"pdoc/extract.py:iter_modules2"
]
},
"file": "pdoc/extract.py"
}
] | mitmproxy/pdoc | a3d49463b28b351caad20a594b80dc297a72d646 | TypeError in /pdoc/extract.py
#### Problem Description
When running pdoc, i get a TypeError. I cannot figure out if this is a bug in pdoc or if it is a problem with my project, since the traceback is completely internal to pdoc files and does not show any file from my module, so i would not even know where to start lo... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f732c04..0bb2389 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,8 @@
([#708](https://github.com/mitmproxy/pdoc/pull/708), @mhils)
- Fix a bug where hyperlinks would get parsed as docstring references.
([#709](https://github.com/mitmproxy/pdoc/pull/709), @mh... |
mitmproxy__pdoc-751 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pdoc/extract.py:mock_some_common_side_effects"
],
"edited_modules": [
"pdoc/extract.py:mock_some_common_side_effects"
]
},
"file": "pdoc/extract.py"
}
] | mitmproxy/pdoc | 308c3a143dbb947d92396772645b2a70362c6829 | pdoc crashes on `sys.stdout.reconfigure(encoding='utf-8')`
#### Problem Description
pdoc crashes with the following error message if the code to document contains `sys.stdout.reconfigure(encoding='utf-8')`.
```
$ pdoc foo.py -o docs
Traceback (most recent call last):
File "/home/stolzmann/miniconda3/lib/python... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8e51a6a..c085743 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,8 @@
- Inherited members are now hidden by default if the base class is not part of the documentation.
Please make yourself heard in https://github.com/mitmproxy/pdoc/issues/715 if you relied on... |
mitmproxy__pdoc-754 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pdoc/doc.py:Module._taken_from"
],
"edited_modules": [
"pdoc/doc.py:Module"
]
},
"file": "pdoc/doc.py"
}
] | mitmproxy/pdoc | 5a8fdc1f915edaf77c6ab9ccdc00d64f6ddf2f46 | TypeError: argument of type '_SentinelObject' is not iterable (`unittest.mock`)
#### Problem Description
`pdoc` fails to generate API documentation for the `unittest.mock` module.
#### Steps to reproduce the behavior:
```sh
pdoc --output-directory /tmp/docs unittest.mock
```
```py
Traceback (most recent ca... | diff --git a/pdoc/doc.py b/pdoc/doc.py
index 51468dd..752cd17 100644
--- a/pdoc/doc.py
+++ b/pdoc/doc.py
@@ -445,7 +445,7 @@ class Module(Namespace[types.ModuleType]):
mod = _safe_getattr(obj, "__module__", None)
qual = _safe_getattr(obj, "__qualname__", None)
- if mod and qual and "<locals>"... |
mitmproxy__pdoc-787 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pdoc/web.py:DocHandler.handle_request"
],
"edited_modules": [
"pdoc/web.py:DocHandler"
]
},
"file": "pdoc/web.py"
}
] | mitmproxy/pdoc | 85503a1c68835aabf93a5cae622e4c933f70d4e6 | Modules with unicode characters in their name 404 on the interactive development server
#### Problem Description
When generating docs for modules with unicode characters in them, hosting them with `http.server` works fine. Links to those modules within the generated documentation work fine as well. However, using pdoc'... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4248f72..7317814 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
## Unreleased: pdoc next
+- Fix handling of URL-escaped module names ([#787](https://github.com/mitmproxy/pdoc/pull/787), @iFreilicht)
## 2024-12-12: pdoc 15.0.1
diff --git a/pdoc/web.p... |
mitodl__ocw-data-parser-106 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ocw_data_parser/ocw_data_parser.py:load_raw_jsons",
"ocw_data_parser/ocw_data_parser.py:OCWParser.extract_media_locally",
"ocw_data_parser/ocw_data_parser.py:OCWParser.extract_foreign_me... | mitodl/ocw-data-parser | de6bce9b76c3c468a82c6ac0dce321fa2fbba577 | Raise exception instead of log.error when possible
We should go through the uses of `log.error` and convert them to raise exceptions, remove them entirely, or leave as is depending on context. For example https://github.com/mitodl/ocw-data-parser/blob/32a9b125c6a5bdcb1af38dafd7a82ca7407cadc9/ocw_data_parser/ocw_data_pa... | diff --git a/ocw_data_parser/ocw_data_parser.py b/ocw_data_parser/ocw_data_parser.py
index 615c5d0..1ae5f79 100644
--- a/ocw_data_parser/ocw_data_parser.py
+++ b/ocw_data_parser/ocw_data_parser.py
@@ -10,7 +10,7 @@ from pathlib import Path
from urllib.parse import urljoin
import boto3
-from requests import get
+imp... |
mitodl__ocw-data-parser-152 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ocw_data_parser/utils.py:convert_to_vtt"
],
"edited_modules": [
"ocw_data_parser/utils.py:convert_to_vtt"
]
},
"file": "ocw_data_parser/utils.py"
}
] | mitodl/ocw-data-parser | 4437c0b531eb25cca1013bc84fede1909f47d5ce | Error converting subtitle halts parse_all
I found an error running ocw-data-parser on a course while converting the subtitle content. To reproduce, convert the course at `PROD/physics` in `ocw-content-storage`
Note: This is a different error than #150. That deals with a VTT conversion error which is caught and logge... | diff --git a/ocw_data_parser/utils.py b/ocw_data_parser/utils.py
index c0dd738..868d49a 100644
--- a/ocw_data_parser/utils.py
+++ b/ocw_data_parser/utils.py
@@ -322,6 +322,11 @@ def convert_to_vtt(loaded_json):
msg,
)
return None
+ except... |
miurahr__aqtinstall-102 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"aqt/archives.py:QtArchives._get_archives"
],
"edited_modules": [
"aqt/archives.py:QtArchives"
]
},
"file": "aqt/archives.py"
},
{
"changes": {
"added_enti... | miurahr/aqtinstall | 36238fc007350b2043e6bac144282ae24d4df9b7 | Better error handling
I made a mistake typing the `aqt` command:
```
$ aqt install 5.12 mac desktop 216ms
Finished installation
Traceback (most recent call last):
Fil... | diff --git a/.travis.yml b/.travis.yml
index cfbda92..2e90ce5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,6 +7,10 @@ matrix:
env: TOXENV=check
- python: 3.7
env: TOXENV=docs
+ - python: 3.6
+ env:
+ TOXENV=py36
+ PYTEST_ADDOPTS="--remote-data"
install: pip install tox-tr... |
miurahr__aqtinstall-136 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"aqt/cli.py:Cli.run"
],
"edited_modules": [
"aqt/cli.py:Cli"
]
},
"file": "aqt/cli.py"
}
] | miurahr/aqtinstall | 67eee8d2bd73acc36c14206d684f4901bbad71d6 | Running aqt without arguments produces error
If you run aqt without arguments, you get a confusing error:
```
C:\Users\nyanpasu64\scoop\apps\consolez\current>aqt
Traceback (most recent call last):
File "c:\users\nyanpasu64\appdata\local\programs\python\python38\lib\runpy.py", line 194, in _run_module_as_main
... | diff --git a/aqt/cli.py b/aqt/cli.py
index 412d454..3913ee3 100644
--- a/aqt/cli.py
+++ b/aqt/cli.py
@@ -260,4 +260,6 @@ class Cli():
def run(self, arg=None):
args = self.parser.parse_args(arg)
self._setup_logging(args)
- args.func(args)
+ if getattr(args, 'func', None) is None:
+ ... |
miurahr__aqtinstall-138 | [
{
"changes": {
"added_entities": [
"aqt/archives.py:SrcDocExamplesArchives.__init__",
"aqt/archives.py:SrcDocExamplesArchives._get_archives",
"aqt/archives.py:SrcDocExamplesArchives.get_target_config",
"aqt/archives.py:ToolArchives._parse_update_xml"
],
"added_m... | miurahr/aqtinstall | 093a111025952ca5fe05d25e77d527fe9e52817e | download qt5_xxxx_src_doc_examples
can add feature to download: qt5_xxxx_src_doc_examples
thanks a lot. | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index cba4746..d13fd35 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -14,12 +14,16 @@ Current changes
Added
-----
+* New subcommand doc/src/example to install each components.(#137, 138)
+
Changed
-------
Fixed
-----
+* Show help when launched without any argum... |
miurahr__aqtinstall-272 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"aqt/archives.py:QtArchives.__init__"
],
"edited_modules": [
"aqt/archives.py:QtArchives"
]
},
"file": "aqt/archives.py"
},
{
"changes": {
"added_entities"... | miurahr/aqtinstall | 173d9e78c09dd4f1e93b71d67a880a7a42b60679 | leaked semaphore objects?
aqt 1.2.0b3, macOS 11.4
```
% aqt install --outputdir ~/junkaqt 5.12.11 mac desktop -m qtwebengine
2021-06-11 11:16:07,044 - aqt - INFO - aqtinstall(aqt) vunknown on Python 3.9.4 [CPython Clang 12.0.0 (clang-1200.0.32.29)]
2021-06-11 11:16:07,044 - aqt - WARNING - Specified Qt version is... | diff --git a/aqt/archives.py b/aqt/archives.py
index 5348286..6f21340 100644
--- a/aqt/archives.py
+++ b/aqt/archives.py
@@ -143,7 +143,7 @@ class QtArchives:
self.arch = arch
self.os_name = os_name
self.all_extra = all_extra
- self.arch_list = [item.get("arch") for item in Settings().... |
miurahr__aqtinstall-364 | [
{
"changes": {
"added_entities": [
"aqt/archives.py:QtArchives._version_str"
],
"added_modules": null,
"edited_entities": [
"aqt/archives.py:QtArchives.__init__",
"aqt/archives.py:QtArchives._get_archives"
],
"edited_modules": [
"aqt/archives.p... | miurahr/aqtinstall | dd0b42bd72a49c5f361ccff582662411912392a9 | Qt 5.9 installation was broken at some point
`aqt install 5.9 linux desktop` returns "Invalid version string: '5.9'"
Qt 5.9 has a weird package name but it is hosted: https://download.qt.io/online/qtsdkrepository/linux_x64/desktop/qt5_59/
This worked in 1.1.3 but is broken in 1.2.x, as I discovered when trying to... | diff --git a/aqt/archives.py b/aqt/archives.py
index 480f5bf..64730c9 100644
--- a/aqt/archives.py
+++ b/aqt/archives.py
@@ -98,19 +98,16 @@ class QtArchives:
else:
for m in modules if modules is not None else []:
self.mod_list.append(
- "qt.qt{0}.{0}{1}{2}.{3}.... |
miurahr__aqtinstall-414 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"aqt/archives.py:ToolArchives.__init__",
"aqt/archives.py:ToolArchives._parse_update_xml"
],
"edited_modules": [
"aqt/archives.py:ToolArchives"
]
},
"file": "aqt... | miurahr/aqtinstall | 372113fe9df9dbe0ec0d943fe64b08a06daec554 | Keeping v1 commands available in v2 may confuse users
## Overview
In [Legacy subcommands § Command Line Options — aqtinstall 2.0.0 documentation](https://aqtinstall.readthedocs.io/en/v2.0.0/cli.html#legacy-subcommands), we wrote:
> The subcommands `install`, `tool`, `src`, `doc`, and `examples` have been deprecat... | diff --git a/aqt/archives.py b/aqt/archives.py
index 3c06d8c..2874747 100644
--- a/aqt/archives.py
+++ b/aqt/archives.py
@@ -371,6 +371,7 @@ class ToolArchives(QtArchives):
self.tool_name = tool_name
self.os_name = os_name
self.logger = getLogger("aqt.archives")
+ self.is_require_versi... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.