id
int64
1
6.5k
bug_id
int64
2.03k
426k
summary
stringlengths
9
251
description
stringlengths
1
32.8k
report_time
stringlengths
19
19
report_timestamp
int64
1B
1.39B
status
stringclasses
6 values
commit
stringlengths
7
9
commit_timestamp
int64
1B
1.39B
files
stringlengths
25
32.8k
project_name
stringclasses
6 values
2,730
207,838
Bug 207838 [DataBinding] ComputedList contribution
null
2007-10-29 15:25:34
1,193,690,000
verified fixed
0861375
1,196,620,000
bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/list/ComputedList.java bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/list/ComputedList.java
Eclipse_Platform_UI
2,731
146,623
Bug 146623 [Commands] Define command / retargetable action / keybinding for switching pages in a PageBookView
N20060611-0010 The platform should define a command for cycling through pages of a PageBookView (e.g. Search, Console, Synchronize) or other views that use a notion of switchable pages (e.g. JUnit, Type Hierarchy, Call Hierarchy). There should be a retargetable action that can be used by views that want to support easy switching between their pages. The action cannot be bound by default, since some PageBookViews may not want to give the user this power (e.g. Outline), or they need to know about page switching events (e.g. JUnit). Good default keybindings would be Alt+PageUp / Alt+PageDown. Today, using such views is often cumbersome, since the views usually only offer a dropdown toolbar button, which has a very small target area to open a menu. Furthermore, opening the menu is unnecessary when the user already knows she wants to go to the previous/next page.
2006-06-12 12:55:23
1,150,130,000
verified fixed
ed2df4a
1,196,450,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleBaseHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleEditorHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CyclePerspectiveHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleViewHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/CyclePageHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/PageSwitcher.java
Eclipse_Platform_UI
2,732
211,493
Bug 211493 [Markers] [Markers] New Markers view slows down traversal in Package Explorer
I20071127-0800 Traversing over elements in the Package Explorer via Arrow_Down key is slowed down by the new Markers view. Steps: - select org.eclipse.jdt.doc.user (from CVS) - press Arrow_Right - press and hold Arrow_Down => selection moves slowly, gets faster after folders with many files have been passed I quickly profiled this and found that a lot of time is burned in org.eclipse.ui.internal.provisional.views.markers.CachedMarkerBuilder$1.run(IProgressMonitor) This is probably because ExtendedMarkersView.createPartControl(Composite) contains: ISelectionListener listener = getPageSelectionListener(); getSite().getPage().addSelectionListener(listener); listener.selectionChanged(getSite().getPage().getActivePart(), getSite().getPage().getSelection()); 1. => should not leak the listener when the view is disposed 2. => should not update when the Markers view is not visible 3. => should not use addSelectionListener() but addPostSelectionListener()
2007-11-29 14:21:32
1,196,360,000
verified fixed
20ace3c
1,196,450,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerEntry.java
Eclipse_Platform_UI
2,733
203,595
Bug 203595 [Contributions] SubMenuManager should use ListenerList's clear() method
null
2007-09-17 10:29:08
1,190,040,000
verified fixed
d78542d
1,196,440,000
bundles/org.eclipse.jface/src/org/eclipse/jface/action/SubMenuManager.java
Eclipse_Platform_UI
2,734
211,610
Bug 211610 [Forms] Adopt new MPE key binding API
null
2007-11-30 11:54:52
1,196,440,000
resolved fixed
e222d12
1,196,440,000
bundles/org.eclipse.ui.forms/src/org/eclipse/ui/forms/editor/FormEditor.java bundles/org.eclipse.ui.forms/src/org/eclipse/ui/forms/editor/SharedHeaderFormEditor.java
Eclipse_Platform_UI
2,735
184,074
Bug 184074 [MPE] Need API to disable key bindings in shared editor header
null
2007-04-25 13:57:41
1,177,520,000
verified fixed
eb23f3b
1,196,440,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/MultiPageEditorPart.java
Eclipse_Platform_UI
2,736
36,446
Bug 36446 [Contributions] widgets: Associating Actions with Buttons
Actions can be associated with Menu items , and tool bar items using MenuManager and ToolBarManager but there is not way to associate Action with a regular button and obtaining a reference to that button the closest thing is creating an ActionContributionItem with the desired action in its constructor , then filling the parent composite with ActionContributionItem.fill(Control parent) this creats the button , but it doesn't return a reference to that button , so for example i can't give it any layout data i suggest the ActionContributionItem.fill(Control parent) returns the created widget
2003-04-14 08:28:32
1,050,320,000
verified fixed
9e28ee4
1,196,440,000
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java tests/org.eclipse.ui.tests/Eclipse JFace Tests/org/eclipse/jface/tests/action/ContributionItemTest.java
Eclipse_Platform_UI
2,737
102,616
Bug 102616 [Contributions] StatusLineContributionItem should be moved to JFace
The JFace ApplicationWindow class lets you add a StatusLineManager, but an application using it has to become dependent on the Eclipse UI to be able to use it, because StatusLineContributionItem is in org.eclipse.ui.texteditor, and that shouldn't be the case. The StatusLineContributionItem class should be moved to org.eclipse.jface.action.
2005-07-03 21:37:50
1,120,440,000
verified fixed
9c8c2993
1,196,440,000
bundles/org.eclipse.jface/src/org/eclipse/jface/action/StatusLineContributionItem.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeyBindingState.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/util/StatusLineContributionItem.java
Eclipse_Platform_UI
2,738
79,581
Bug 79581 [Commands] request: Declare a command for "Link with Editor"
I200411240800 Platform/UI should declare a retargetable toggling action/command for "Link with Editor". Currently, almost every decent view that shows editable elements has its own view toolbar button "Link with Editor". I would like to toggle these buttons via a keyboard shortcut (and the shortcut should be the same in every view :-). I'm not sure whether this should go into to the IDE or the RCP layer, but I'm sure you'll find a good place.
2004-11-26 12:26:15
1,101,490,000
verified fixed
7930751
1,196,440,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ResourceNavigator.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ToggleLinkingAction.java bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/CommonNavigatorActionGroup.java bundles/org.eclipse.ui.navigator/src/org/eclipse/ui/internal/navigator/actions/LinkEditorAction.java
Eclipse_Platform_UI
2,739
210,946
Bug 210946 [Workbench] Unproper error handling in class ModalContext
Build ID: M20070921-1145 Steps To Reproduce: A caught Throwable is not written to the Eclipse log. It is just written on the console. org.eclipse.jface.operation.ModalContext public void block() { if (display == Display.getCurrent()) { while (continueEventDispatching) { // Run the event loop. Handle any uncaught exceptions caused // by UI events. try { if (!display.readAndDispatch()) { display.sleep(); } } // ThreadDeath is a normal error when the thread is dying. We must // propagate it in order for it to properly terminate. catch (ThreadDeath e) { throw (e); } // For all other exceptions, log the problem. catch (Throwable e) { System.err.println("Unhandled event loop exception during blocked modal context."); //$NON-NLS-1$ e.printStackTrace(); } More information:
2007-11-26 12:05:02
1,196,100,000
verified fixed
044d907
1,196,370,000
bundles/org.eclipse.jface/src/org/eclipse/jface/operation/ModalContext.java
Eclipse_Platform_UI
2,740
211,179
Bug 211179 [DetachedWindows] Detached eclipse windows may render outside desktop
Build ID: I20070621-1340 Steps To Reproduce: 1. Start with XP on two monitors (right click on Desktop, Properties, Settings, "Extend my Windows desktop onto this monitor") 2. Detach a view into a floating window (doesn't matter what view) 3. Move that window onto the second monitor/desktop 4. Shutdown Eclipse 5. Switch XP to a single monitor (reverse process in step 1) 6. Restart Eclipse 7. The view will now not be visible. It remains rendered off screen on the now defunct second desktop. It is very difficult to move this window back onto the first desktop, or even "re-attach" it, since you can't click on it. More information: I found this issue when using remote desktops onto my main machine.
2007-11-28 04:28:26
1,196,240,000
verified fixed
b694393
1,196,280,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/DetachedWindow.java
Eclipse_Platform_UI
2,741
211,212
Bug 211212 Cannot delete a bookmark in the new markers view
The delete action is not enabled for bookmarks
2007-11-28 08:49:18
1,196,260,000
verified fixed
26ee623
1,196,280,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/EditablePropertyTester.java
Eclipse_Platform_UI
2,742
211,122
Bug 211122 [Markers] Errors 'Marker id 301832 not found.' logged when opening new Markers view
[I20071127-0800] Not sure what I did other than opening the new Markers view. The error log does not have any detail other than 'Marker id 301832 not found.' and 'Marker id 301833 not found.'. Related question: why is there no associated stack trace in the log? The plug-in id says 'org.eclipse.core.resources' - does this really come from Resources? Could they produce a stack trace in this case to help debug the issue?
2007-11-27 15:26:11
1,196,200,000
verified fixed
6ff9750
1,196,260,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/Policy.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerEntry.java
Eclipse_Platform_UI
2,743
210,934
Bug 210934 [ErrorHandling] [StatusHandling] StatusManager#handle(StatusAdapter) should log that the adapter or status is null
null
2007-11-26 10:12:42
1,196,090,000
verified fixed
84af3d5
1,196,250,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/statushandlers/StatusManager.java
Eclipse_Platform_UI
2,744
209,023
Bug 209023 [Markers] New Problems view does not select current problem from editor
I20071106-0816 The Problems view used to select and reveal the problem at a Java editor's caret position. The new Problems view doesn't.
2007-11-07 08:53:57
1,194,440,000
verified fixed
999c673
1,196,190,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/CachedMarkerBuilder.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerMap.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerSupportInternalUtilities.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/MarkerViewUtil.java
Eclipse_Platform_UI
2,745
209,239
Bug 209239 [Services] Convert the ISelectionService
ISelectionService should be available through the service locator and dispose listeners for free.
2007-11-08 14:04:32
1,194,550,000
verified fixed
2ddd87a
1,196,180,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SlaveSelectionService.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchSupportFactory.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/WorkbenchServiceRegistry.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/api/ISelectionServiceTest.java
Eclipse_Platform_UI
2,746
209,240
Bug 209240 [Services] Convert the IPageService
IPageService should be available through the service locator and dispose listeners for free. PW
2007-11-08 14:05:30
1,194,550,000
verified fixed
1934a93
1,196,180,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SlavePageService.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchSupportFactory.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/api/IPageServiceTest.java
Eclipse_Platform_UI
2,747
209,558
Bug 209558 [Import/Export] FileSystemImportWizard and FileSystemExportWizard require the compatibility plug-in
Build ID: M20070921-1145 Steps To Reproduce: 1.Create an RCP app. 2.Add an export wizard to plugin.xml, pointing to org.eclipse.ui.wizards.datatransfer.ZipFileExportWizard. Could also just invoke it from code, like in an action. 3.Attempt to run the wizard and observe the error message. More information: ZipFileImportWizard, ExternalProjectImportWizard, PreferencesImportWizard, and PreferencesExportWizard can be brought up fine in the same RCP app, while FileSystemImportWizard and FileSystemExportWizard issue the message. The difference is that the wizards which start up call WorkbenchPlugin.getDefault(), while the ones which don't call the deprecated method Platform.getPlugin(). I figured out that adding the org.eclipse.core.runtime.compatibility plug-in to the dependency list allows all the wizards to start up without the message. It seems like perhaps all these classes ought to be calling WorkbenchPlugin.getDefault() now.
2007-11-12 16:50:59
1,194,900,000
verified fixed
054cd75
1,196,110,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/FileSystemExportWizard.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/FileSystemImportWizard.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/wizards/datatransfer/ZipFileExportWizard.java
Eclipse_Platform_UI
2,748
191,662
Bug 191662 [Import/Export] Warn of duplicate projects in project import wizard
Build ID: I20070601-1539 Steps To Reproduce: 1. Create a project. 2. Export it to *.zip file. 3. Close the project. 4. Try to import it. 5. Empty projects list. More information: This is pretty annoying, since I am using mylar and a workspace with many closed projects. If I try to import a project that already exists, I see nothing and I am pretty confused (there is no warning).
2007-06-08 05:19:46
1,181,290,000
verified fixed
7c90cbd
1,196,100,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/DataTransferMessages.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/WizardProjectsImportPage.java
Eclipse_Platform_UI
2,749
156,792
Bug 156792 [EditorMgmt] Close a Tab with the middle button
It would be ui-friendly if the tabs could be closed with the middle button as firefox does.
2006-09-09 03:57:02
1,157,790,000
verified fixed
b64b43d
1,196,100,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/PaneFolder.java
Eclipse_Platform_UI
2,750
207,844
Bug 207844 [DataBinding] Support SWTObservables.observeText for Shells.
null
2007-10-29 16:05:01
1,193,690,000
verified fixed
d8bfc48
1,195,880,000
bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/swt/SWTObservables.java bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/internal/swt/ShellObservableValue.java
Eclipse_Platform_UI
2,751
151,158
Bug 151158 [KeyBindings][MPE] MultiPageEditorPart sends key events to editor without focus
I have an Eclipse plugin that contains a MultiPageEditor with 2 pages. The first page is a TextEditor used for editing a type of source code. The second page, an Editor Part, is a graphical representation of the source code. I've run across an issue when the active editor page is the second page. When the second page's editor is active/focused, pressing CTRL-A will select all of the text on the first page's editor (even though it is not active). Then, pressing DEL while on the second page's edtior will delete all of the text on the first page's editor. Other key strokes that get "forwarded" to the first page are CTRL-X, CTRL-V, and CTRL-C. This key event forwarding should not happen, when an editor is not selected, it should not be receiving any key events from the selected editor. If this is indeed a bug, is there a known workaround?
2006-07-19 19:35:52
1,153,350,000
verified fixed
4b165f7
1,195,850,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/KeyBindingService.java
Eclipse_Platform_UI
2,752
180,746
Bug 180746 [DataBinding] TextObservableValue should take a delay-argument
Sometimes SWT.Modify is needed as update event type but the performance (number of propagated update-events) should be similar to SWT.FocusOut. Therefore I suggest to create an additional constructor with a parameter int delayInMilliseconds which defines a delay between the time the last SWT.Modify-Event occured and fireValueChanging() is called. This will allow the customer to enter multiple characters without starting a validation each time. A further advance is when binding the validation result to a label or similar, the label won't change confusingly while you still enter your text. The current structure of TextObservableValue doesn't provide a way to achieve the described behaviour by subclassing without reimplementation. Maybe this behaviour can even be useful whit SWT.FocusOut ? More information:
2007-04-03 12:08:54
1,175,620,000
verified fixed
18e75b2
1,195,770,000
bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/Observables.java bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/StalenessObservableValue.java bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/Observables.java bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/StalenessObservableValue.java bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/swt/SWTObservables.java bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/internal/swt/DelayedObservableValue.java examples/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/snippets/Snippet015DelayTextModifyEvents.java
Eclipse_Platform_UI
2,753
205,053
Bug 205053 [Navigator] Navigator Filters dialog box is empty
Build ID: M20070921-1145 Steps To Reproduce: 1. New install of the platform opening to a new or existing workpsace. 2. Open the Navigator view. 3. Select Filters... from the Navigator view pull-down menu. The Navigator Filters dialog box does not show any types to filter. More information:
2007-10-01 09:44:31
1,191,250,000
resolved fixed
5677aa5
1,195,760,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/FiltersContentProvider.java
Eclipse_Platform_UI
2,754
210,424
Bug 210424 [Trim] (Regression) Minimize view fails to expand adjacent views in its place
null
2007-11-20 12:40:58
1,195,580,000
verified fixed
5cdd06e
1,195,750,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/util/TabbedStackPresentation.java
Eclipse_Platform_UI
2,755
209,836
Bug 209836 [Services] Support service locator creation
null
2007-11-14 12:03:40
1,195,060,000
verified fixed
d3c9205
1,195,750,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PartSite.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchSupportFactory.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/IWorkbenchRegistryConstants.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/ServiceLocator.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/ServiceLocatorCreator.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/WorkbenchServiceRegistry.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/MultiPageEditorSite.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/part/PageSite.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/services/AbstractServiceFactory.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/services/IServiceLocatorCreator.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/services/ContributedServiceTest.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/services/ILevelService.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/services/LevelServiceFactory.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/services/ServicesTestSuite.java
Eclipse_Platform_UI
2,756
209,484
Bug 209484 [Databinding] ObservableSetContentProvider does not update knownElements
Build ID: M20071023-1652 Steps To Reproduce: 1. Use a ObservableSetContentProvider in a databinding table 2. Evaluate the knownElements member 3. knownElements is always empty More information: We use a modified ObservableSetContentProvider to bind a table to a model. Moreover, we would like to register for all known Elements in this table using the member 'knownElements' of this class. However, this elements in this member are always empty. There seems to be a bug in method setInput(): 1.) The set of known elements is created in the constructor. 2.) In the inputChanged method (and then in setInput()) the readable set is set to a new value, but the knownElements remains unchanged.
2007-11-12 08:24:58
1,194,870,000
resolved fixed
b6ba4b6
1,195,750,000
bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/set/WritableSet.java bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/set/WritableSet.java bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/viewers/ObservableSetContentProvider.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/jface/tests/databinding/viewers/ObservableSetContentProviderTest.java
Eclipse_Platform_UI
2,757
210,115
Bug 210115 [DataBinding] NPE when getter called on disposed observable
null
2007-11-16 11:20:05
1,195,230,000
verified fixed
e710033
1,195,710,000
bundles/org.eclipse.core.databinding.observable/src/org/eclipse/core/databinding/observable/ObservableTracker.java bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/observable/ObservableTracker.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/observable/ObservableTrackerTest.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/jface/tests/databinding/BindingTestSuite.java
Eclipse_Platform_UI
2,758
210,448
Bug 210448 [Viewers] [JFace] AbstractTreeViewer inputChanged setRedraw should be in try/finally
The inputChanged method on the AbstractTreeViewer makes use of setRedraw, which is good, but it doesn't use a try/finally block as per recommendations. If an exception is thrown from within one of the methods called, redraw will remain false. Additionally, the commented out portion is fine, but the fact that we have conditionals in the code that always evaluate to true is less fine. When we're ready to actually determine when to use redraw we could put them back in. Current code: protected void inputChanged(Object input, Object oldInput) { preservingSelection(new Runnable() { public void run() { Control tree = getControl(); boolean useRedraw = true; // (size > REDRAW_THRESHOLD) || (table.getItemCount() > // REDRAW_THRESHOLD); if (useRedraw) { tree.setRedraw(false); } removeAll(tree); tree.setData(getRoot()); internalInitializeTree(tree); if (useRedraw) { tree.setRedraw(true); } } }); } Suggestion: protected void inputChanged(Object input, Object oldInput) { preservingSelection(new Runnable() { public void run() { Control tree = getControl(); try { tree.setRedraw(false); removeAll(tree); tree.setData(getRoot()); internalInitializeTree(tree); } finally { tree.setRedraw(true); } } }); }
2007-11-20 16:06:37
1,195,590,000
resolved fixed
bdfee57
1,195,660,000
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractTreeViewer.java
Eclipse_Platform_UI
2,759
208,052
Bug 208052 [Markers] Tasks does not sort by completion
Sorting by the completion currently does nothing.
2007-10-30 13:25:36
1,193,770,000
verified fixed
efc3f3f
1,195,250,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerCompletionField.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerPriorityField.java
Eclipse_Platform_UI
2,760
210,124
Bug 210124 [Markers] MarkersView not listening to the build jobs
The markers view needs to listen to the build jobs to show italics when running
2007-11-16 13:26:03
1,195,240,000
verified fixed
ba5e01f
1,195,240,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/CachedMarkerBuilder.java
Eclipse_Platform_UI
2,761
209,879
Bug 209879 [Databinding] Inadvertent commit to UpdateValueStrategy and UpdateStrategy
while working on databinding on GWT a commit went to the wrong project
2007-11-14 18:01:09
1,195,080,000
resolved fixed
29f4797
1,195,080,000
bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateStrategy.java bundles/org.eclipse.core.databinding/src/org/eclipse/core/databinding/UpdateValueStrategy.java
Eclipse_Platform_UI
2,762
209,786
Bug 209786 [Progress] Elements not refreshing on completion
When we complete a progress item we are not refreshing the title or the icon so we are getting finished jobs with wait icons and cancel requested for jobs that actually cancelled. Steps 1) Create 3 sequential jobs using the progress example 2) Cancel them
2007-11-14 08:09:23
1,195,050,000
verified fixed
62ef119
1,195,060,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressInfoItem.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressMessages.java
Eclipse_Platform_UI
2,763
151,688
Bug 151688 [GlobalActions] [IDE] Allow to extend RefreshAction
null
2006-07-25 08:49:06
1,153,830,000
verified fixed
f06ee5e
1,194,980,000
bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/RefreshAction.java
Eclipse_Platform_UI
2,764
209,667
Bug 209667 [Markers] Add a TODO filter
We should be able to just focus on the TODOs in the tasks list.
2007-11-13 12:09:09
1,194,970,000
verified fixed
6a76b53
1,194,970,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/DescriptionConfigurationArea.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/DescriptionFieldFilter.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/TodoFiltersContributionParameters.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/api/MarkerSupportConstants.java
Eclipse_Platform_UI
2,765
209,000
Bug 209000 [Markers] Copy in Problems view broken
I20071106-0816 Copy in the Problems view is disabled. I'm now forced to manually read and type the error when I file a bug report.
2007-11-07 06:24:44
1,194,430,000
verified fixed
9eba0be
1,194,540,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java
Eclipse_Platform_UI
2,766
207,846
Bug 207846 [Viewers] Virtual TableViewer setSelection() does not work properly
Build ID: 3.3.1.1 Steps To Reproduce: 1. Create a virtual TableViewer 2. Add elements to the table 3. call setSelection() on an item that is not visible The selected item will be revealed. The API contract states that for the selection to be revealed, you must call setSelection(item, true). More information: I'm setting this to blocker because I have code that extends TableViewer that allows me to keep track of a virtual selection and when new elements are added to the table as the user scrolls that are part of the virtual selection, I update the underlying actual selection. This causes the table to jump back to the start of the selection making the table unusable. I have no workaround for this problem, and thus it's blocking me from delivering required functionality to my customers. Looking at the code, it appears that the virtual table viewer calls setSelection() on the underlying SWT Table which in turn calls showIndex() - whereas a non virtual table viewer calls Table select() which does not call showIndex(). Can the virtual table use select() instead of setSelection()?
2007-10-29 16:09:49
1,193,690,000
resolved fixed
8254aff
1,194,470,000
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractTableViewer.java
Eclipse_Platform_UI
2,767
208,987
Bug 208987 [Markers] NPE loading user defined filters
I20071106-0816 I have my problems view configured as fast view. When I opened the view today I got an NPE. The view shows no content other then the stack trace. java.lang.NullPointerException at org.eclipse.ui.internal.provisional.views.markers.MarkerFieldFilterGroup.<init>(MarkerFieldFilterGroup.java:160) at org.eclipse.ui.internal.provisional.views.markers.MarkerContentGenerator.loadUserFilter(MarkerContentGenerator.java:731) at org.eclipse.ui.internal.provisional.views.markers.MarkerContentGenerator.loadSettings(MarkerContentGenerator.java:698) at org.eclipse.ui.internal.provisional.views.markers.MarkerContentGenerator.loadFiltersPreference(MarkerContentGenerator.java:668) at org.eclipse.ui.internal.provisional.views.markers.MarkerContentGenerator.getAllFilters(MarkerContentGenerator.java:412) at org.eclipse.ui.internal.provisional.views.markers.MarkerContentGenerator.getEnabledFilters(MarkerContentGenerator.java:454) at org.eclipse.ui.internal.provisional.views.markers.MarkerContentGenerator.updateNeeded(MarkerContentGenerator.java:816) at org.eclipse.ui.internal.provisional.views.markers.CachedMarkerBuilder.updateForNewSelection(CachedMarkerBuilder.java:483) at org.eclipse.ui.internal.provisional.views.markers.ExtendedMarkersView$8.selectionChanged(ExtendedMarkersView.java:817) at org.eclipse.ui.internal.provisional.views.markers.ExtendedMarkersView.createPartControl(ExtendedMarkersView.java:444) at org.eclipse.ui.internal.ViewReference.createPartHelper(ViewReference.java:372) at org.eclipse.ui.internal.ViewReference.createPart(ViewReference.java:229) at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:594) at org.eclipse.ui.internal.Perspective.showFastView(Perspective.java:2012) at org.eclipse.ui.internal.Perspective.setActiveFastView(Perspective.java:1794) at org.eclipse.ui.internal.Perspective.setActiveFastView(Perspective.java:1807) at org.eclipse.ui.internal.Perspective.toggleFastView(Perspective.java:2200) at org.eclipse.ui.internal.WorkbenchPage.toggleFastView(WorkbenchPage.java:3717) at org.eclipse.ui.internal.ShowFastViewContribution.showView(ShowFastViewContribution.java:157) at org.eclipse.ui.internal.ShowFastViewContribution.access$1(ShowFastViewContribution.java:155) at org.eclipse.ui.internal.ShowFastViewContribution$3.widgetSelected(ShowFastViewContribution.java:138) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:227) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:947) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3744) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3355) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2395) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2359) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2225) at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:468) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:463) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:362) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:175) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:515) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:455) at org.eclipse.equinox.launcher.Main.run(Main.java:1193) at org.eclipse.equinox.launcher.Main.main(Main.java:1169) at org.eclipse.core.launcher.Main.main(Main.java:30)
2007-11-07 04:40:46
1,194,430,000
verified fixed
879e8d6
1,194,450,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerFieldFilterGroup.java
Eclipse_Platform_UI
2,768
208,055
Bug 208055 [Markers] Need a sorting method for the markers view
As there is currently no accessible way to change sort order or direction. A menu should be enough.
2007-10-30 13:36:56
1,193,770,000
verified fixed
734e2ed
1,194,380,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerContentGenerator.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/SortDirectionContribution.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/SortFieldContribution.java
Eclipse_Platform_UI
2,769
205,209
Bug 205209 [WorkbenchParts] NPE due to null mappingService during dispose
3.3 - closed the workbench window - in response to some controls getting disposed, the view tried to set a global action handler - this failed with an NPE due to a null mappingService, since the services had already been disposed Should either: - change the lifecycle so that controls are always disposed before the site and its services, or - make setGlobalActionHandler be resilient to the services having been disposed, or - both Thread [main] (Suspended (exception NullPointerException)) ViewActionBars(SubActionBars).setGlobalActionHandler(String, IAction) line: 492 LocalWorkspaceChangesView$ChangesViewPage$27.hoverToolTipClosed() line: 944 TooltipSupport$1.closeRequested() line: 67 HoverTooltip(Tooltip).close() line: 100 HoverTooltip.close() line: 84 HoverTooltip(Tooltip).dispose() line: 171 Tooltip$2.widgetDisposed(DisposeEvent) line: 398 TypedListener.handleEvent(Event) line: 116 EventTable.sendEvent(Event) line: 66 Shell(Widget).sendEvent(Event) line: 938 Shell(Widget).sendEvent(int, Event, boolean) line: 962 Shell(Widget).sendEvent(int) line: 943 Shell(Widget).release(boolean) line: 740 Shell(Widget).dispose() line: 410 Shell(Decorations).dispose() line: 457 Shell.dispose() line: 653 WorkbenchWindow(Window).close() line: 330 WorkbenchWindow(ApplicationWindow).close() line: 306 WorkbenchWindow.hardClose() line: 1600 WorkbenchWindow.busyClose() line: 699 WorkbenchWindow.access$0(WorkbenchWindow) line: 675 WorkbenchWindow$2.run() line: 790 BusyIndicator.showWhile(Display, Runnable) line: 67 WorkbenchWindow.close() line: 788 WindowManager.close() line: 109 Workbench$15.run() line: 908 SafeRunner.run(ISafeRunnable) line: 37 Workbench.busyClose(boolean) line: 905 Workbench.access$15(Workbench, boolean) line: 834 Workbench$22.run() line: 1078 BusyIndicator.showWhile(Display, Runnable) line: 67 Workbench.close(int, boolean) line: 1076 Workbench.close() line: 1048 QuitAction.run() line: 57 QuitAction(Action).runWithEvent(Event) line: 498 ActionContributionItem.handleWidgetSelection(Event, boolean) line: 545 ActionContributionItem.access$2(ActionContributionItem, Event, boolean) line: 490 ActionContributionItem$5.handleEvent(Event) line: 402 EventTable.sendEvent(Event) line: 66 MenuItem(Widget).sendEvent(Event) line: 938 Display.runDeferredEvents() line: 3682 Display.readAndDispatch() line: 3293 Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 2389 Workbench.runUI() line: 2353 Workbench.access$4(Workbench) line: 2219 Workbench$4.run() line: 466 Realm.runWithDefault(Realm, Runnable) line: 289 Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 461 PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 149 IDEApplication.start(IApplicationContext) line: 106 EclipseAppHandle.run(Object) line: 153 EclipseAppLauncher.runApplication(Object) line: 106 EclipseAppLauncher.start(Object) line: 76 EclipseStarter.run(Object) line: 363 EclipseStarter.run(String[], Runnable) line: 176 NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method] NativeMethodAccessorImpl.invoke(Object, Object[]) line: 64 DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 43 Method.invoke(Object, Object...) line: 615 Main.invokeFramework(String[], URL[]) line: 504 Main.basicRun(String[]) line: 443 Main.run(String[]) line: 1169 Main.main(String[]) line: 1144
2007-10-02 13:06:28
1,191,340,000
verified fixed
bc49386
1,194,370,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/SubActionBars.java
Eclipse_Platform_UI
2,770
74,163
Bug 74163 [IDE] Tips and Tricks dialog; disable OK if no selection
OK should be disabled if one has not selected one entry in the list box above.
2004-09-17 08:37:33
1,095,420,000
verified fixed
3a1dfcc
1,194,300,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/TipsAndTricksAction.java
Eclipse_Platform_UI
2,771
208,791
Bug 208791 [Markers] NPE in ExtendedMarkersView
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException) at org.eclipse.swt.SWT.error(SWT.java:3706) at org.eclipse.swt.SWT.error(SWT.java:3624) [... snip ...] Caused by: java.lang.NullPointerException at org.eclipse.ui.internal.provisional.views.markers.ExtendedMarkersView$10.runInUIThread(ExtendedMarkersView.java:896) at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:94) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:130) ... 52 more This brought down testResourceMappings(), but you just need to check getCategories() can return null. PW
2007-11-05 12:58:10
1,194,290,000
verified fixed
356fa2b
1,194,290,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java
Eclipse_Platform_UI
2,772
72,327
Bug 72327 [WorkbenchLauncher] Workspace Launcher Dialog grows in width for long paths
In most cases, the default width of the Workspace Launcher provides a decent amount of space to display the full path to a workspace. However, in the case that the path is exceptionally long, shouldn't the Workspace Launcher remain at a constant width or have a maximum width that it will expand? It currently expands to a width such that the full path of the selected workspace will be displayed. Steps to reproduce: 1) Select a workspace with path that is very long in the Workspace Launcher. 2) Start Eclipse with that workspace. 3) Restart Eclipse and notice the width of the Workspace Launcher Dialog.
2004-08-19 22:57:38
1,092,970,000
verified fixed
ac6e50d
1,194,290,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceDialog.java
Eclipse_Platform_UI
2,773
207,940
Bug 207940 [Mac] Cannot clear preferences filter on the Mac
I20071030-0010 I cannot completely clear a pre-set preferences filter on the Mac. On other platforms, I can just click the 'Clear' button, but this doesn't work under Mac OS X. Steps: - open Open Type dialog - open menu button at upper right and choose Type Filters...
2007-10-30 07:07:43
1,193,740,000
verified fixed
9150cf3
1,194,280,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FilteredTree.java
Eclipse_Platform_UI
2,774
208,478
Bug 208478 [ErrorHandling] Status Handling makes infos and warnings look like errors
I20071030 When you send a status that is an info or a warning to the status manager the error dialog is used which has a useless details and a "time of error" when there is no error. We should likely use the message dialog in this case.
2007-11-01 16:43:24
1,193,950,000
verified fixed
35c5756
1,194,270,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StatusNotificationManager.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/statushandlers/WorkbenchErrorHandler.java
Eclipse_Platform_UI
2,775
208,101
Bug 208101 [Markers] Tasks content has mark completed enabled for non editable tasks
I20071030-0100 Mark completed is enabled for tasks that are not editable
2007-10-30 15:25:53
1,193,770,000
verified fixed
a682689
1,194,270,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java
Eclipse_Platform_UI
2,776
208,390
Bug 208390 [Markers] Improve 'No Quick Fix' dialog from new Marker view
null
2007-11-01 07:53:44
1,193,920,000
verified fixed
01f1827
1,194,270,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/QuickFixHandler.java
Eclipse_Platform_UI
2,777
208,098
Bug 208098 [Markers] All content provider needs a type field
As All shows everything the type column would be very useful for filtering.
2007-10-30 15:17:51
1,193,770,000
verified fixed
31b5064
1,194,270,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerEntry.java
Eclipse_Platform_UI
2,778
208,092
Bug 208092 [Markers] Markers are using the category icon when flat
20071031-0100 When you set the All Contents to sort by none all of the entries end up with the category icon.
2007-10-30 15:01:54
1,193,770,000
verified fixed
ebdd528
1,194,270,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerSeverityAndMessageField.java
Eclipse_Platform_UI
2,779
208,389
Bug 208389 [Markers] New Marker view should use default Properties dialog
null
2007-11-01 07:42:53
1,193,920,000
verified fixed
10488ba
1,194,270,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkersPropertyPage.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/PropertiesHandler.java
Eclipse_Platform_UI
2,780
207,570
Bug 207570 [ErrorHandling] NPE on shutdown in IDEWorkbenchErrorHandler
The UIJob in IDEWorkbenchErrorHandler gets an NPE when it shuts down after ann OutOfMemory exception. closeWorkbench() appears to be called after closing has started Thread [main] (Suspended (exception NullPointerException)) IDEWorkbenchErrorHandler.closeWorkbench() line: 236 IDEWorkbenchErrorHandler.handleException(Throwable) line: 140 IDEWorkbenchErrorHandler.access$0(IDEWorkbenchErrorHandler, Throwable) line: 131 IDEWorkbenchErrorHandler$1.runInUIThread(IProgressMonitor) line: 106 UIJob$1.run() line: 94 RunnableLock.run() line: 35 UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 124 Display.runAsyncMessages(boolean) line: 3721 Display.readAndDispatch() line: 3358 Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 2395 Workbench.runUI() line: 2359 Workbench.access$4(Workbench) line: 2225 Workbench$4.run() line: 468 Realm.runWithDefault(Realm, Runnable) line: 288 Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 463 PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 149 IDEApplication.start(IApplicationContext) line: 106 EclipseAppHandle.run(Object) line: 193 EclipseAppLauncher.runApplication(Object) line: 106 EclipseAppLauncher.start(Object) line: 76 EclipseStarter.run(Object) line: 362 EclipseStarter.run(String[], Runnable) line: 175 NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method] NativeMethodAccessorImpl.invoke(Object, Object[]) line: 39 DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 25 Method.invoke(Object, Object...) line: 597 Main.invokeFramework(String[], URL[]) line: 515 Main.basicRun(String[]) line: 455 Main.run(String[]) line: 1193 Main.main(String[]) line: 1169
2007-10-26 08:27:00
1,193,400,000
verified fixed
8a41548
1,194,270,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchErrorHandler.java
Eclipse_Platform_UI
2,781
192,051
Bug 192051 [StatusHandling] NPE in StatusNotificationManager
The following NPE occurred in StatusNotificationManager during a JUnit plugin test: Caused by: java.lang.NullPointerException at org.eclipse.ui.internal.statushandlers.StatusNotificationManager$3.run(StatusNotificationManager.java:134) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:123) The code in question is: Display.getDefault().asyncExec(new Runnable() { public void run() { dialog = new StatusDialog(ProgressManagerUtil .getDefaultParent(), statusInfo, IStatus.OK | IStatus.INFO | IStatus.WARNING | IStatus.ERROR, modal); dialog.open(); dialog.getShell().addDisposeListener(disposeListener); // <-- NPE HERE } }); ProgressManagerUtil.getDefaultParent() specifies that it can return null. If this happens, the call to dialog.getShell() will return null and this NPE will occur. This particular case probably occurred when this async runnable ran after the workbench had closed. (For reference, this bug was reported in Jazz defect #24058.)
2007-06-11 18:00:11
1,181,600,000
verified fixed
2167de8
1,194,010,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StatusNotificationManager.java
Eclipse_Platform_UI
2,782
207,829
Bug 207829 [Contributions] Unnecessary plugin activation on shutdown
I20071029-0010 On shutdown, PluginActionCoolBarContributionItem.handleWidgetDispose makes a call to getMenuCreator() that loads the search plugin. SearchPlugin.<init>() line: 95 NativeConstructorAccessorImpl.newInstance0(Constructor, Object[]) line: not available [native method] NativeConstructorAccessorImpl.newInstance(Object[]) line: 39 DelegatingConstructorAccessorImpl.newInstance(Object[]) line: 27 Constructor.newInstance(Object[]) line: 274 Class.newInstance0() line: 308 Class.newInstance() line: 261 BundleHost(AbstractBundle).loadBundleActivator() line: 137 BundleContextImpl.start() line: 970 BundleHost.startWorker(int) line: 346 BundleHost(AbstractBundle).start(int) line: 261 SecureAction.start(Bundle, int) line: 400 EclipseLazyStarter.postFindLocalClass(String, Class, ClasspathManager) line: 111 ClasspathManager.findLocalClass(String) line: 419 DefaultClassLoader.findLocalClass(String) line: 189 BundleLoader.findLocalClass(String) line: 344 BundleLoader.findClassInternal(String, boolean, ClassLoader) line: 412 BundleLoader.findClass(String, boolean) line: 373 BundleLoader.findClass(String) line: 361 DefaultClassLoader.loadClass(String, boolean) line: 83 DefaultClassLoader(ClassLoader).loadClass(String) line: 235 BundleLoader.loadClass(String) line: 289 BundleHost.loadClass(String, boolean) line: 227 BundleHost(AbstractBundle).loadClass(String) line: 1269 EquinoxRegistryStrategy(RegistryStrategyOSGI).createExecutableExtension(RegistryContributor, String, String) line: 160 ExtensionRegistry.createExecutableExtension(RegistryContributor, String, String) line: 819 ConfigurationElement.createExecutableExtension(String) line: 243 ConfigurationElementHandle.createExecutableExtension(String) line: 51 WorkbenchPlugin$1.run() line: 244 BusyIndicator.showWhile(Display, Runnable) line: 67 WorkbenchPlugin.createExtension(IConfigurationElement, String) line: 240 WWinPluginPulldown(PluginAction).createDelegate() line: 122 WWinPluginPulldown(PluginAction).getMenuCreator() line: 380 PluginActionCoolBarContributionItem(ActionContributionItem).handleWidgetDispose(Event) line: 469 ActionContributionItem.access$1(ActionContributionItem, Event) line: 464 ActionContributionItem$6.handleEvent(Event) line: 445 EventTable.sendEvent(Event) line: 66 ToolItem(Widget).sendEvent(Event) line: 1105 ToolItem(Widget).sendEvent(int, Event, boolean) line: 1129 ToolItem(Widget).sendEvent(int) line: 1110 ToolItem(Widget).release(boolean) line: 974 ToolBar.releaseChildren(boolean) line: 402 ToolBar(Widget).release(boolean) line: 977 ToolBar(Control).release(boolean) line: 3156 CoolBar(Composite).releaseChildren(boolean) line: 1175 CoolBar(Widget).release(boolean) line: 977 CoolBar(Control).release(boolean) line: 3156 Composite.releaseChildren(boolean) line: 1175 Composite(Widget).release(boolean) line: 977 Composite(Control).release(boolean) line: 3156 CBanner(Composite).releaseChildren(boolean) line: 1175 CBanner(Widget).release(boolean) line: 977 CBanner(Control).release(boolean) line: 3156 Shell(Composite).releaseChildren(boolean) line: 1175 Shell(Canvas).releaseChildren(boolean) line: 196 Shell(Decorations).releaseChildren(boolean) line: 465 Shell.releaseChildren(boolean) line: 1822 Shell(Widget).release(boolean) line: 977 Shell(Control).release(boolean) line: 3156 Shell(Widget).dispose() line: 434 Shell.dispose() line: 1767 WorkbenchWindow(Window).close() line: 335
2007-10-29 14:22:07
1,193,680,000
verified fixed
c5426e4
1,193,860,000
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
Eclipse_Platform_UI
2,783
208,099
Bug 208099 [Contributions] Toggling logical structure "Show As > Array" has no effect
I20071030 * Using the "Show As >" menu to selectively enable/disable logical structures for specific kinds of objects has no effect 90% of the time. The check mark will usually not toggle on the menu item either. Once and a while the action seems to stick. Strange.
2007-10-30 15:23:33
1,193,770,000
verified fixed
86aefa0
1,193,850,000
bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java
Eclipse_Platform_UI
2,784
204,683
Bug 204683 [Commands] activePart of CycleBaseHandler leaks last editor
I20070925-1406 - open a text editor - press Ctrl+F6 - press Ctrl+W => activePart of CycleBaseHandler leaks last editor
2007-09-26 10:05:09
1,190,820,000
resolved fixed
f8a4d00
1,193,780,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleBaseHandler.java
Eclipse_Platform_UI
2,785
193,832
Bug 193832 [ViewMgmt] ViewPart selection listeners don't work when perspective with secondary IDs first open
Build ID: I20070503-1400 Steps To Reproduce: 1. Extract and run included plugin 2. Open the "Test" perspective 3. Select one of the elements in "View 1", no output shows up 4. Close eclipse with the perspective active 5. Restart the runtime environment 6. Select one of the elements again, no output 7. close the perspective and re-open it, it now works More information: It looks like the first time the perspective is initialized the listeners don't work properly. If the view is closed and re-opened it all works. This is true if the view is first opened in Eclipse or if it was active the last time Eclipse ran and it activated for the first time when Eclipse restarts.
2007-06-21 16:35:27
1,182,460,000
verified fixed
e844625
1,193,710,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PagePartSelectionTracker.java
Eclipse_Platform_UI
2,786
207,619
Bug 207619 [CommonNavigator] StackOverflowError when attempting to import with at least 2 projects in workspace
using eclipse-SDK-I20071023-0800-win32 1. switch to resource perspective 2. create 2 projects (simple or java) 3. file -> import... You get a stack overflow error. This does not seem to happen if you're in the Java perspective. Maybe related to project explorer.
2007-10-26 15:50:49
1,193,430,000
verified fixed
292a59e
1,193,690,000
bundles/org.eclipse.ui.navigator.resources/src/org/eclipse/ui/internal/navigator/resources/actions/PortingActionProvider.java
Eclipse_Platform_UI
2,787
65,731
Bug 65731 [EditorMgmt] editor extension panel missing * for icon
Eclipse 3.0 M9 The plugin.xml editor page used to edit an editor extension does not indicate that the icon field is required (I'm assuming the * next to the names indicates required field).
2004-06-04 11:26:15
1,086,360,000
verified fixed
f977f15
1,193,680,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java
Eclipse_Platform_UI
2,788
204,754
Bug 204754 [DataBinding] BeanObservableValueDecorator.equals method implementation is incorrect
Build ID: I20070621-1340 Steps To Reproduce: The equals() method implementation is not reflexive (a.equals(a) returns false). The decorator is delegating the equals method to the decorated IObservableValue, but first it should check whether the other object to which the decorator is compared is another BeanObservableValueDecorator, if so delegate to check the equality of the decorated IObservableValue. More information:
2007-09-26 22:35:47
1,190,860,000
resolved fixed
5817fe8
1,193,680,000
bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/internal/beans/BeanObservableListDecorator.java bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/internal/beans/BeanObservableSetDecorator.java bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/internal/beans/BeanObservableValueDecorator.java
Eclipse_Platform_UI
2,789
106,059
Bug 106059 [Viewers] Disappearing icon in problem view when selecting the row
Using I20050803-0800, sometimes the icon disappears when I select a problem in the problem view. If it is unselected, it works fine. See attached screenshot.
2005-08-04 11:26:50
1,123,170,000
verified fixed
bd35b03
1,193,680,000
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TableLayout.java
Eclipse_Platform_UI
2,790
198,603
Bug 198603 [DataBinding] ObservableListContentProvider should use AbstractListViewer.insert
null
2007-08-01 21:45:16
1,186,020,000
verified fixed
e1157b0
1,193,680,000
bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/viewers/ObservableListContentProvider.java
Eclipse_Platform_UI
2,791
198,101
Bug 198101 [DataBinding] ComboObservableValue fails to clear cached value
ComboObservableValue fails to update cached currentValue during the doSetValue(...) call. As the result, event may not fire if the next combo selection happens to be the same as cached value. Proposed change (new lines end with // FIX): public void modifyText(ModifyEvent e) { if (!updating) { String oldValue = currentValue; currentValue = ComboObservableValue.this.combo.getText(); fireValueChange(Diffs.createValueDiff(oldValue, currentValue)); } else // FIX currentValue = ComboObservableValue.this.combo.getText(); // FIX
2007-07-27 09:22:08
1,185,540,000
verified fixed
70d6cf7
1,193,680,000
bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/internal/swt/CComboObservableValue.java bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/internal/swt/ComboObservableValue.java
Eclipse_Platform_UI
2,792
207,604
Bug 207604 [KeyBindings] Always include unbound commands
null
2007-10-26 14:13:08
1,193,420,000
verified fixed
8190bb7
1,193,420,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferenceMessages.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java
Eclipse_Platform_UI
2,793
207,601
Bug 207601 [Commands] NullPointerException in HandlerActivation.toString() when tracing enabled
null
2007-10-26 14:00:23
1,193,420,000
verified fixed
d761996
1,193,420,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/HandlerProxy.java
Eclipse_Platform_UI
2,794
207,188
Bug 207188 [Dialogs] org.eclipse.jface.dialogs.Dialog.shortenText calls GC.textExtent too often
null
2007-10-23 12:07:00
1,193,160,000
closed fixed
4f80dcb
1,193,420,000
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/Dialog.java tests/org.eclipse.ui.tests.performance/src/org/eclipse/jface/tests/performance/JFacePerformanceSuite.java tests/org.eclipse.ui.tests.performance/src/org/eclipse/jface/tests/performance/ProgressMonitorDialogPerformanceTest.java
Eclipse_Platform_UI
2,795
207,366
Bug 207366 Circular dependancy introduced by bug 206064
null
2007-10-24 18:20:37
1,193,260,000
verified fixed
44a5bdf
1,193,270,000
bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/DeleteResourceAction.java bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/MoveResourceAction.java bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/RenameResourceAction.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ResourceNavigatorRenameAction.java
Eclipse_Platform_UI
2,796
110,087
Bug 110087 [Markers] "Filters" menu doesn't remember the last selected filter
When I was playing with this it was a true pain. I'd change somes ettings to see what effect it had and then re-open the dialog to try some other settings I had to re-select my filter (it selects the first one always)...
2005-09-20 15:28:41
1,127,240,000
verified fixed
2f0d1a3
1,193,150,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/FiltersConfigurationDialog.java
Eclipse_Platform_UI
2,797
108,493
Bug 108493 [Markers] Show tooltips for table columns in marker views
null
2005-08-31 14:04:00
1,125,510,000
verified fixed
edc6e18
1,193,150,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerCompletionField.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerPriorityField.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/api/MarkerField.java
Eclipse_Platform_UI
2,798
204,842
Bug 204842 [Contributions] setGlobalActionHandler ignores some IActions
When using IActionBars#setGlobalActionHandler(*) any RetargetAction contributed programmatically (a la ActionFactory) would prevent the IAction from generating an ActionHandler (to be used by keybindings). PW
2007-09-27 13:42:45
1,190,910,000
verified fixed
5f71a5e
1,193,150,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/SubActionBars.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/ActionFactory.java
Eclipse_Platform_UI
2,799
207,075
Bug 207075 ResourceManagerTest#testDeviceManagerAllocations failing
null
2007-10-22 14:55:41
1,193,080,000
verified fixed
c1a58da
1,193,080,000
tests/org.eclipse.ui.tests/Eclipse JFace Tests/org/eclipse/jface/tests/images/ResourceManagerTest.java
Eclipse_Platform_UI
2,800
202,893
Bug 202893 [Contributions] F1 key does not work when context id set in org.eclipse.ui.menu
I have converted my rcp to use the new menu/command system. I have created a context id to test adding context help to the menus. I know the context works as I have added it to a TrayDialog to test that PlatformUI.getWorkbench().getHelpSystem().setHelp(getShell(), "com.mitel.swb.help.add"); And pressing F1 or the help icon open the help in the tray as expected. I then tried adding it to a menu item, but highlighting it and pressing F1 does nothing. What have I missed. <extension point="org.eclipse.ui.commands"> <command> defaultHandler="com.mitel.swb.handlers.RegisterWorkbench" helpContextId="com.mitel.swb.help.add" id="com.mitel.swb.commands.registrationCommand" name="Register Workbench"> </command> <extension point="org.eclipse.ui.menus"> <menuContribution locationURI="menu:org.eclipse.ui.main.menu"> <menu id="menuFile" label="File" mnemonic="F"> <command commandId="com.mitel.swb.commands.registrationCommand" helpContextId="com.mitel.swb.help.add" id="registrationCommand" label="Register Workbench"> </command> the context is in the com.mitel.swb.help plugin <contexts> <context id="add" title="add"> <description> Please write a description for this help context. </description> </context> </contexts>
2007-09-11 04:57:36
1,189,500,000
verified fixed
21d2abf
1,193,070,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuAdditionCacheEntry.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/menus/CommandContributionItem.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/menus/CommandContributionItemParameter.java
Eclipse_Platform_UI
2,801
206,475
Bug 206475 [Markers] Switch the markers view to a non virtual view
I will attach a patch for switching the markers view to a non-virtual one. I don't want to do this yet as I am not convinced that any of the problems I am seeing are anything to do with VIRTUAL.
2007-10-16 11:01:26
1,192,550,000
verified fixed
7354692
1,193,070,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java
Eclipse_Platform_UI
2,802
204,458
Bug 204458 [Commands] Allow menu and toolbars to fire execution events
Keybindings will currently fire execution events when executing actions from the action framework. i.e. IActions with their actionDefinitionId set and IActionDelegates with the definitionId attribute in their action contributions. But it would be nice if selecting the menu or tool item would also fire the equivalent events. PW
2007-09-24 10:40:15
1,190,640,000
verified fixed
ec3fb39
1,193,060,000
bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/CommandManager.java bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java bundles/org.eclipse.jface/src/org/eclipse/jface/action/ExternalActionManager.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java
Eclipse_Platform_UI
2,803
198,201
Bug 198201 [DataBinding] Provide POJO observables
There have been quite a few requests on the newsgroup recently about trying to use POJOs and filling up logs with error messages about not being able to register property change event listeners. It would be nice to provide a cleaner solution than using the JavaBean support that we provide today.
2007-07-29 01:52:36
1,185,690,000
verified fixed
40e0c83
1,192,910,000
bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/databinding/beans/BeansObservables.java bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/databinding/beans/PojoObservables.java bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/internal/beans/JavaBeanObservableList.java bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/internal/beans/JavaBeanObservableMap.java bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/internal/beans/JavaBeanObservableSet.java bundles/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/internal/beans/JavaBeanObservableValue.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/databinding/beans/PojoObservablesTest.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/internal/databinding/internal/beans/Bean.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/internal/databinding/internal/beans/JavaBeanObservableListTest.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/internal/databinding/internal/beans/JavaBeanObservableMapTest.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/internal/databinding/internal/beans/JavaBeanObservableSetTest.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/core/tests/internal/databinding/internal/beans/JavaBeanObservableValueTest.java tests/org.eclipse.jface.tests.databinding/src/org/eclipse/jface/tests/databinding/BindingTestSuite.java
Eclipse_Platform_UI
2,804
46,164
Bug 46164 [Tasks] Go To enabled for non-file markers
build I20031105 Go To in the Tasks view is enabled even for a manually created task. It should only be enabled for tasks on files.
2003-11-05 22:31:01
1,068,090,000
verified fixed
9e851e7
1,192,830,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/FileMarkerPropertyTester.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/ActionOpenMarker.java
Eclipse_Platform_UI
2,805
202,382
Bug 202382 [Forms] Behaviour of Section with fixed style changed between Eclipse 3.0 and 3.1 (and later)
Build ID: M20060118-1600 Steps To Reproduce: 1. Create a section and assign a shortcut: final Section addressSection = toolkit.createSection(this, SWT.NONE); addressSection.setText("&Adresse"); 2. Add a text field to the section final Composite nameComposite = toolkit.createComposite(addressComposite, SWT.NONE); toolkit.createLabel(nameComposite, "Name", SWT.NONE); final Text nameText = toolkit.createText(nameComposite, null, SWT.NONE); 3. Run this in a Eclipse 3.0 dialog. Pressing the shortcut key ALT-A moves the focus to the text input file nameText. 4. Run this in a Eclipse 3.1 dialog. Pressing the shortcut key ALT-A hides the section! More information: In the ExpandableComposite which is the base class of Section, there is always a TraverseListener added to the object. This TraverseListener always toggles the state of the section, even if isFixedStyle() returns true. To restore the old behaviour, simply call programmaticToggleState() only if isFixedSytle() returns false.
2007-09-06 02:26:34
1,189,060,000
resolved fixed
dac17dd
1,192,820,000
bundles/org.eclipse.ui.forms/src/org/eclipse/ui/forms/widgets/ExpandableComposite.java
Eclipse_Platform_UI
2,806
205,070
Bug 205070 [JFace] ImageDataImageDescriptor's hashCode doesn't correspond to its equals method
3.3 ImageDataImageDescriptor.hashCode() and equals don't correspond when it's created from an original image. Note that a new ImageData object is created each time, so comparing hashCode/equals on the resulting ImageData does not allow supposedly-equivalent image descriptors to compare (or hash) properly. This can result in leaks when the image descriptor is used in a resource manager. Suggested change: public int hashCode() { if (originalImage != null) { return System.identityHashCode(originalImage); } return data.hashCode(); }
2007-10-01 11:26:35
1,191,250,000
verified fixed
a688fce
1,192,810,000
bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDataImageDescriptor.java
Eclipse_Platform_UI
2,807
206,034
Bug 206034 [CellEditors] ColumnViewerEditor does not check if the last cell editor listener has cancelled the event
Build ID: I20070621-1340 ColumnViewerEditor.activateCellEditor() notifies all ColumnViewerEditorActivationListeners before activating a cell editor. At each stage of the listener iteration it checks whether the activation event has been cancelled. Given the existence of this check it appears to me that it is expected that listeners might choose to cancel the activation event if they desire. If this is the case then the implementation (shown below) is not fully correct, specifically the last listener might cancel the event but the code never checks this. for (int i = 0; i < ls.length; i++) { if (activationEvent.cancel) { return; } ((ColumnViewerEditorActivationListener) ls[i]).beforeEditorActivated(activationEvent); } Swapping the order of the if block and the listener notification would fix this problem, but you then introduce the problem that the first listener may be notified of cancelled events. As a side note, it seems strange that the activationEvent is only checked if you have listeners. I would have expected a check as one of the first lines in activateCellEditor(). If this was added then you could just swap the if block and the listener notification to close the issue. I am currently working around this issue by adding two copies of the same listener in order to guarantee that any desired cancelling is honoured.
2007-10-11 09:02:24
1,192,110,000
verified fixed
7dfdaa5
1,192,740,000
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/ColumnViewerEditor.java
Eclipse_Platform_UI
2,808
206,754
Bug 206754 [KeyBindings] CommandContributionItem does not pick the best key binding
null
2007-10-18 09:49:29
1,192,720,000
verified fixed
08321e2
1,192,720,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/menus/CommandContributionItem.java
Eclipse_Platform_UI
2,809
89,610
Bug 89610 [KeyBindings] preference page: IllegalArgumentException using KeySequenceText delete
Build: I20050330 I haven't tried reproducing yet, but here is exactly what I did to reproduce the error: 1) Started a new workspace 2) Went to the Keys preference page, and assigned Source > Sort Members to "Ctrl+Shift+D", in the context "Editing Java Source" 3) Shutdown and restart -> The following exception appears in my log several times. I will attach the entire log in case it has more interesting details. java.lang.IllegalArgumentException: All triggers in a trigger sequence must be an instance of Trigger at org.eclipse.jface.bindings.TriggerSequence.<init>(TriggerSequence.java:72) at org.eclipse.jface.bindings.keys.KeySequence.<init>(KeySequence.java:191) at org.eclipse.jface.bindings.keys.KeySequence.getInstance(KeySequence.java:130) at org.eclipse.jface.bindings.keys.KeySequenceText$KeyTrapListener.handleEvent(KeySequenceText.java:123) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:866) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:851) at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:879) at org.eclipse.swt.widgets.Text.sendKeyEvent(Text.java:1134) at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:875) at org.eclipse.swt.widgets.Widget.wmKeyDown(Widget.java:1454) at org.eclipse.swt.widgets.Control.WM_KEYDOWN(Control.java:3338) at org.eclipse.swt.widgets.Control.windowProc(Control.java:3058) at org.eclipse.swt.widgets.Text.windowProc(Text.java:1742) at org.eclipse.swt.widgets.Display.windowProc(Display.java:3466) at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method) at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:1625) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2525) at org.eclipse.jface.window.Window.runEventLoop(Window.java:803) at org.eclipse.jface.window.Window.open(Window.java:781) at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:66) at org.eclipse.jface.action.Action.runWithEvent(Action.java:996) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:538) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:488) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:400) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2894) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2527) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1570) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1534) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:338) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:85) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:58) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:60) at java.lang.reflect.Method.invoke(Method.java:391) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:268) at org.eclipse.core.launcher.Main.basicRun(Main.java:260) at org.eclipse.core.launcher.Main.run(Main.java:887) at org.eclipse.core.launcher.Main.main(Main.java:871)
2005-03-30 12:14:18
1,112,200,000
verified fixed
d6e766c
1,192,560,000
bundles/org.eclipse.jface/src/org/eclipse/jface/bindings/keys/KeySequenceText.java
Eclipse_Platform_UI
2,810
206,489
Bug 206489 [Markers] Tasks column too small in the new markers view
Tasks column too small in the new markers view. We need to take into account the twistie.
2007-10-16 12:19:45
1,192,550,000
verified fixed
9380408
1,192,550,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/ExtendedMarkersView.java
Eclipse_Platform_UI
2,811
204,303
Bug 204303 [GlobalActions] Convert MAXIMIZE and MINIMIZE to handlers
We need to convert ActionFactory MAXIMIZE and MINIMIZE to handlers PW
2007-09-21 14:06:46
1,190,400,000
verified fixed
63988ed
1,192,540,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/ActionFactory.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/MaximizePartAction.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/MinimizePartAction.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/MaximizePartHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/MinimizePartHandler.java
Eclipse_Platform_UI
2,812
205,864
Bug 205864 Populate the new forms test plug-in
null
2007-10-09 16:01:56
1,191,960,000
resolved fixed
d968118
1,192,470,000
tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/AllFormsPerformanceTests.java tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/AllFormsTests.java tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/layout/AllLayoutTests.java tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/layout/TestTableWrapLayout.java tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/performance/FormsPerformanceTest.java tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/plugin/FormsTestPlugin.java tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/util/AllUtilityTests.java tests/org.eclipse.ui.tests.forms/forms/org/eclipse/ui/tests/forms/util/FormImagesTests.java
Eclipse_Platform_UI
2,813
205,194
Bug 205194 [ErrorHandling] [StatusHandling] StatusAdapter needs Action and Explanation constants
null
2007-10-02 11:07:18
1,191,340,000
verified fixed
44f363b
1,192,450,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/statushandlers/StatusAdapter.java
Eclipse_Platform_UI
2,814
167,191
Bug 167191 [Markers] Add icon support for marker groupings
3.3 M3 - after a complete rebuild, I wanted to see if there were any errors - switched to the Problems view, which I had grouping by Java Problem Type - it showed several categories (all collapsed) - I couldn't tell at a glance if these represented errors or warnings -- I had to go and read the heading titles and expand a few to be comfortable that there weren't any errors - then I remembered that the counts are shown in the content description, and this showed 0 errors It would be nice if I could tell at a glance (visually, not just textually) what the severities are. Currently the icon used for category headings is a generic "tree of nodes" graphic. Could we associate a severity with a category and show the corresponding icon instead? Since JDT allows severities to be customized, we'd probably need to allow these to be specified programmatically, not just declaratively. Or perhaps the view could calculate the max severity in each category and show that.
2006-12-07 20:12:01
1,165,540,000
verified fixed
1568366
1,192,200,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerCategory.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerDescriptionAndMessageField.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/MarkerSeverityAndMessageField.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/api/MarkerField.java
Eclipse_Platform_UI
2,815
183,218
Bug 183218 [Model] Unused parameter / field in DeferredTreeContentManager
We are adapting our deferred content providers to be ITreePathContentProviders instead of ITreeContentProviders. Unfortunately there is no DeferredTreeContentManager for ITreePathContentProviders. But from my review of the code there appears to be no reason for the DeferredTreeContentManager to require an ITreeContentProvider to be passed into the contructor. The field is set but never used. Seems to be historical remnant from before the IDeferredWorkbenchAdapter?? It would be great if a constructor was added that did not require a content provider. I would suggest at least javadoc that null can be passed in for the content provider to allow for cases where you do not have an ITreeContentProvider. Also I believe the javadoc for getChildren is incorrect for the @return
2007-04-19 12:25:50
1,177,000,000
verified fixed
91f7bb1
1,192,130,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/progress/DeferredTreeContentManager.java
Eclipse_Platform_UI
2,816
179,789
Bug 179789 [Progress] [RCP] Progress Service Dialog requires a call to the progress service
Build ID: M20070212-1330 Steps To Reproduce: Run the simple rcp attached in the class Startup.java you must uncomment the line 24 to get the progresmonitordialog More information:
2007-03-28 12:46:03
1,175,100,000
verified fixed
39eada4
1,192,130,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/progress/IProgressService.java
Eclipse_Platform_UI
2,817
173,995
Bug 173995 [Progress] Switch progress monitoring to asyncExec
Create some code - it has 2 parts one is running in UI and one is code running in background. Call background code: workbench.getProgressService().busyCursorWhile(this); UI code is just updating user interface [-; Let's imagine that the background code has some synchronized section. It enters this synchronized section, and provides feedback to user using progress monitor. This synchronized is long running action. Also background thread/some other thread sent before/during background sync section some stuff to UI which also acquires this background thread lock. So what's the problem - when calling progress monitor AccumulatingProgressMonitor - this class acquires RunnableLock, but this RunnableLock has already been acquired by other UI runner (Display.asyncExec) when there was something to be sent to UI. The problem is generally about UI sync/asyncexec rules. I think that main problem is that AccumulatingProgressMonitor uses Display.syncExec in some parts. I think that any progressmonitor shouldn't acquire any lock and also shouldn't block processing anyhow, because this can cause such pains.
2007-02-13 07:34:45
1,171,370,000
verified fixed
3218fd9
1,192,130,000
bundles/org.eclipse.jface/src/org/eclipse/jface/operation/AccumulatingProgressMonitor.java
Eclipse_Platform_UI
2,818
172,734
Bug 172734 [PropertiesDialog] PropertyDialogAction.isApplicableForSelection does not consider if the page is applicable
PropertyDialogAction.isApplicableForSelection returns true no matter if none of the IPropertyPageContributor are applicable to the object (return true for isApplicableTo(Object). I would propose the implementation of PropertyDialogAction.isApplicableForSelection should use PropertyPageContributorManager.getApplicableContributors
2007-02-02 17:56:28
1,170,460,000
verified fixed
5da83c0
1,192,130,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/PropertyDialogAction.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/PropertyPageContributorManager.java
Eclipse_Platform_UI
2,819
172,000
Bug 172000 [Wizards] WizardNewFileCreationPage should support overwriting existing resources
In the WizardNewFileCreationPage, there should be a method to set allowExistingResources flag for ResourceAndContainerGroup member. It is useful when both "create" and "renew/overwrite" operations are meaningful for a wizard.
2007-01-29 08:28:09
1,170,080,000
verified fixed
e335232
1,192,120,000
bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardNewFileCreationPage.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ProjectContentsLocationArea.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/misc/ResourceAndContainerGroup.java
Eclipse_Platform_UI
2,820
205,541
Bug 205541 view becomes non-responsive after fastview/close/open in two perspectives
Build ID: 120070625-1500 Steps To Reproduce: 1. Pick a view, open it in two different perspectives 2. Go to one of the two perspectives (doesn't matter which one) 3. Close the view in the perspective you picked in step 2 4) Open the view from the FastView icon at bottom left hand corner 5) close the view using the View's "X" button 6) Open the view from Windows menu --> Show Views 7) Now the view is not selectable and not responsive More information: This only happens when the same view is open in more than one perspectives. This happens in both Redhat Linux and Windows XP
2007-10-04 21:46:09
1,191,550,000
verified fixed
b2fcb07
1,192,120,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Perspective.java
Eclipse_Platform_UI
2,821
157,511
Bug 157511 [Preferences] FileFieldEditor should have a constructor allowing the validation strategy to be set
When using the org.eclipse.jface.preference.FileFieldEditor, a user can enter an invalid filename and no error is shown unless focus is removed from the preference page and than brought back to it. As soon as the user types again, the error message is removed and the user doesn't know if the file is valid until they remove/reapply focus to the preference page. Using the StringFieldEditor::setValidateStrategy(int value) method after constructing the object does not solve the problem since StringFieldEditor::getTextControl(Composite parent) is called indirectly from the constructor and the listeners will already be setup before there is a chance to set the validation strategy. Therefore a constructor for the FileFieldEditor is needed that will allow a user to supply the validation strategy they need (since the default is currently VALIDATE_ON_FOCUS_LOST).
2006-09-15 14:36:48
1,158,350,000
verified fixed
2201985
1,192,110,000
bundles/org.eclipse.jface/src/org/eclipse/jface/preference/FileFieldEditor.java
Eclipse_Platform_UI
2,822
155,436
Bug 155436 [IDE] Project>Clean dialog should not use a question-mark icon
I20060822-1200 The clean dialog displays a question mark icon to explain what clean in this context means. Since this dialog is not a message box and does not ask a question, the icon should be an info icon, or better yet, no icon to not suggest that this could be a message box.
2006-08-28 13:45:37
1,156,790,000
verified fixed
c3d6094
1,192,110,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/CleanDialog.java
Eclipse_Platform_UI
2,823
151,204
Bug 151204 [Progress] Blocked status of jobs are not applied/reported
In the method org.eclipse.ui.internal.progress.ProgressManager.JobMonitor.setBlocked(...) line: info.setBlockedStatus(null); should it not be?: info.setBlockedStatus(reason); After I changed the line, I see (e.g. in the progress view) the message "Blocked: ..." which I missed otherwise.
2006-07-20 06:08:15
1,153,390,000
verified fixed
51559e9
1,192,110,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/progress/ProgressManager.java
Eclipse_Platform_UI
2,824
201,664
Bug 201664 [Markers] Problems view's "Show items of type" filter does not work correctly
The Problems view's "Show items of type" filter does not work correctly: 1. Open the Problems view. 2. Click the "Configure the filters to apply to this view" tool. 3. Under "Show items of type", click the "Deselect All" button. 4. Click the "OK" button to accept the changes and close the dialog. 5. Click the "Configure the filters to apply to this view" tool. 6. Under "Show items of type", click the "Select All" button. 7. Click the "OK" button to accept the changes and close the dialog. 8. Click the "Configure the filters to apply to this view" tool. 9. Notice that not all the items are checked. The following are NOT checked: [] Java Build Path Problems [] Build Path Problems [] JRE System Library Problems []Java Problems []Java Problem [] PDE Problems []PDE Problem
2007-08-29 17:52:41
1,188,420,000
verified fixed
16d2ef9
1,192,030,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/TypesConfigurationArea.java bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/DialogMarkerFilter.java
Eclipse_Platform_UI
2,825
205,923
Bug 205923 [Viewers] Javadoc for setAllChecked() does not mention that only visible items are checked
setAllChecked which was added (by me) in 3.2 does not mention that all chidren must be visible for it to be checked (see setSubtreeChecked). We will have to leave it as it is API and does not expand the tree but I think we should deprecate it as setSubtreeChecked is really the only useful one. Boris what is your opinion?
2007-10-10 10:19:27
1,192,030,000
verified fixed
e68f116
1,192,030,000
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/CheckboxTreeViewer.java
Eclipse_Platform_UI
2,826
205,869
Bug 205869 [Markers] org.eclipse.ui.ide does not compile due to usage of Java 6 APIs
null
2007-10-09 17:01:43
1,191,960,000
verified fixed
b795651
1,191,960,000
bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/provisional/views/markers/DescriptionFieldFilter.java
Eclipse_Platform_UI
2,827
192,996
Bug 192996 [Workbench] Reduce amount of garbage created by HeapStatus
Version: 3.3.0 Build id: I20070525-1350 Currently the Heap Status Monitor updates the tooltip each time it detects the UI needs updating. This can further be optimized to only update when the mouse is in the general area of the control. The savings aren't much, but it is an easy win. Patch to follow
2007-06-15 23:45:28
1,181,970,000
verified fixed
909ba74
1,191,960,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/HeapStatus.java
Eclipse_Platform_UI
2,828
204,581
Bug 204581 [Preferences] Filtered tree doesn't update font and size
I20070921-0919. FilteredPreferenceDialog.updateTreeFont(Font) is called when the font changes. This method calls: FilteredPreferenceDialog.updateTreeFont(Font) which only updates the font when the widget doesn't have a(ny) font set. If a dialog font has already been set then this method does nothing. Test Case: 1. open 'Colors and Fonts' pref page 2. change dialog font to something else 3. click 'Apply' ==> font is changed (but entry field size wrong) 4. change dialog font a second time 5. click 'Apply' ==> tree not updated.
2007-09-25 13:01:56
1,190,740,000
verified fixed
4d7035d
1,191,960,000
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/FilteredPreferenceDialog.java
Eclipse_Platform_UI
2,829
194,825
Bug 194825 IconAndMessage dialog has an inconsistent margin
null
2007-06-28 15:11:58
1,183,060,000
verified fixed
8d87a5d
1,191,960,000
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/IconAndMessageDialog.java
Eclipse_Platform_UI