issue_id int64 2.04k 425k | title stringlengths 9 251 | body stringlengths 4 32.8k ⌀ | status stringclasses 6
values | after_fix_sha stringlengths 7 7 | project_name stringclasses 6
values | repo_url stringclasses 6
values | repo_name stringclasses 6
values | language stringclasses 1
value | issue_url null | before_fix_sha null | pull_url null | commit_datetime timestamp[us, tz=UTC] | report_datetime timestamp[us, tz=UTC] | updated_file stringlengths 23 187 | chunk_content stringlengths 1 22k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
353,349 | Bug 353349 NPE in deleteNewAndDup | java.lang.NullPointerException at org.aspectj.weaver.bcel.BcelShadow.deleteNewAndDup(BcelShadow.java:179) at org.aspectj.weaver.bcel.BcelShadow.prepareForMungers(BcelShadow.java:303) at org.aspectj.weaver.Shadow.implement(Shadow.java:543) at org.aspectj.weaver.bcel.BcelClassWeaver.implement(BcelClassWeaver.java:3147) a... | resolved fixed | e8ef5bf | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-07-28T20:48:42Z | 2011-07-28T19:06:40Z | weaver/src/org/aspectj/weaver/bcel/BcelShadow.java | return new BcelVar(typeX.resolve(world), genTempVarIndex(typeX.getSize()));
}
public BcelVar genTempVar(UnresolvedType typeX, String localName) {
BcelVar tv = genTempVar(typeX);
return tv;
}
private int genTempVarIndex(int size) {
return enclosingMethod.allocateLocal(size);
}
public In... |
353,349 | Bug 353349 NPE in deleteNewAndDup | java.lang.NullPointerException at org.aspectj.weaver.bcel.BcelShadow.deleteNewAndDup(BcelShadow.java:179) at org.aspectj.weaver.bcel.BcelShadow.prepareForMungers(BcelShadow.java:303) at org.aspectj.weaver.Shadow.implement(Shadow.java:543) at org.aspectj.weaver.bcel.BcelClassWeaver.implement(BcelClassWeaver.java:3147) a... | resolved fixed | e8ef5bf | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-07-28T20:48:42Z | 2011-07-28T19:06:40Z | weaver/src/org/aspectj/weaver/bcel/BcelShadow.java | return getEnclosingClass().getType().getSourceLocation();
} else {
int offset = 0;
Kind kind = getKind();
if ((kind == MethodExecution) || (kind == ConstructorExecution) || (kind == AdviceExecution)
|| (kind == StaticInitialization) || (kind == PreInitialization) || (kind == Initialization)) {
... |
340,806 | Bug 340806 Race condition in JavaLangTypeToResolvedTypeConverter (potentially exposed through Spring AOP) | null | resolved fixed | 167b801 | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-03T20:22:40Z | 2011-03-23T19:53:20Z | weaver5/java5-src/org/aspectj/weaver/reflect/JavaLangTypeToResolvedTypeConverter.java | /* *******************************************************************
* Copyright (c) 2005 Contributors.
* All rights reserved.
* This program and the accompanying materials are made available
* under the terms of the Eclipse Public License v1.0
* which accompanies this distribution and is available at
* htt... |
340,806 | Bug 340806 Race condition in JavaLangTypeToResolvedTypeConverter (potentially exposed through Spring AOP) | null | resolved fixed | 167b801 | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-03T20:22:40Z | 2011-03-23T19:53:20Z | weaver5/java5-src/org/aspectj/weaver/reflect/JavaLangTypeToResolvedTypeConverter.java | * Adrian Colyer Initial implementation
* ******************************************************************/
package org.aspectj.weaver.reflect;
import java.lang.reflect.GenericArrayType;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Type;
import java.lang.reflect.WildcardType;
import java.u... |
340,806 | Bug 340806 Race condition in JavaLangTypeToResolvedTypeConverter (potentially exposed through Spring AOP) | null | resolved fixed | 167b801 | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-03T20:22:40Z | 2011-03-23T19:53:20Z | weaver5/java5-src/org/aspectj/weaver/reflect/JavaLangTypeToResolvedTypeConverter.java | }
public ResolvedType fromType(Type aType) {
if (aType instanceof Class) {
Class clazz = (Class) aType;
String name = clazz.getName();
/**
* getName() can return:
*
* 1. If this class object represents a reference type that is not an array type then the binary name of the class is
* returne... |
340,806 | Bug 340806 Race condition in JavaLangTypeToResolvedTypeConverter (potentially exposed through Spring AOP) | null | resolved fixed | 167b801 | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-03T20:22:40Z | 2011-03-23T19:53:20Z | weaver5/java5-src/org/aspectj/weaver/reflect/JavaLangTypeToResolvedTypeConverter.java | if (resolvedArgs[i] == null) {
String ss = "";
try {
ss = aType.toString();
} catch (Exception e) {
}
throw new IllegalStateException("Parameterized type problem. basetype=" + baseType + " arguments="
+ sb.toString() + " ss=" + ss);
}
}
*/
return TypeFactory.createParame... |
340,806 | Bug 340806 Race condition in JavaLangTypeToResolvedTypeConverter (potentially exposed through Spring AOP) | null | resolved fixed | 167b801 | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-03T20:22:40Z | 2011-03-23T19:53:20Z | weaver5/java5-src/org/aspectj/weaver/reflect/JavaLangTypeToResolvedTypeConverter.java | typeVariablesInProgress.remove(aType);
return tvrt;
} else if (aType instanceof WildcardType) {
WildcardType wildType = (WildcardType) aType;
Type[] lowerBounds = wildType.getLowerBounds();
Type[] upperBounds = wildType.getUpperBounds();
ResolvedType bound = null;
boolean isExtends = lowerBounds.le... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | /* *******************************************************************
* Copyright (c) 2002 Palo Alto Research Center, Incorporated (PARC).
* All rights reserved.
* This program and the accompanying materials are made available
* under the terms of the Eclipse Public License v1.0
* which accompanies this distri... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | import org.aspectj.apache.bcel.generic.FieldGen;
import org.aspectj.apache.bcel.generic.FieldInstruction;
import org.aspectj.apache.bcel.generic.Instruction;
import org.aspectj.apache.bcel.generic.InstructionBranch;
import org.aspectj.apache.bcel.generic.InstructionCP;
import org.aspectj.apache.bcel.generic.Instruction... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | import org.aspectj.weaver.AjAttribute;
import org.aspectj.weaver.AjcMemberMaker;
import org.aspectj.weaver.AnnotationAJ;
import org.aspectj.weaver.BCException;
import org.aspectj.weaver.ConcreteTypeMunger;
import org.aspectj.weaver.IClassWeaver;
import org.aspectj.weaver.IntMap;
import org.aspectj.weaver.Member;
import... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | private static Trace trace = TraceFactory.getTraceFactory().getTrace(BcelClassWeaver.class);
public static boolean weave(BcelWorld world, LazyClassGen clazz, List<ShadowMunger> shadowMungers,
List<ConcreteTypeMunger> typeMungers, List<ConcreteTypeMunger> lateTypeMungers, boolean inReweavableMode) {
BcelClassWeave... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | private final ConstantPool cpg;
private final InstructionFactory fact;
private final List<LazyMethodGen> addedLazyMethodGens = new ArrayList<LazyMethodGen>();
private final Set<ResolvedMember> addedDispatchTargets = new HashSet<ResolvedMember>();
private boolean inReweavableMode = false;
private List<IfaceInitLi... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | Properties p = world.getExtraConfiguration();
if (p != null) {
String s = p.getProperty(World.xsetCAPTURE_ALL_CONTEXT, "false");
captureLowLevelContext = s.equalsIgnoreCase("true");
if (captureLowLevelContext) {
world.getMessageHandler().handleMessage(
MessageUtil.info("[" + World.xsetCAPTURE... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (ty.getResolvedTypeX().isTopmostImplementor(superInterfaces[i])) {
if (addSuperInitializer(superInterfaces[i])) {
initializeSuperInitializerMap(superInterfaces[i]);
}
}
}
}
/**
* Process the shadow mungers into array 'buckets', each bucket represents a shadow kind and contains a list of shadowm... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | private boolean addSuperInitializer(ResolvedType onType) {
if (onType.isRawType() || onType.isParameterizedType()) {
onType = onType.getGenericType();
}
IfaceInitList l = addedSuperInitializers.get(onType);
if (l != null) {
return false;
}
l = new IfaceInitList(onType);
addedSuperInitializers.put(on... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | final ResolvedType onType;
List<ConcreteTypeMunger> list = new ArrayList<ConcreteTypeMunger>();
IfaceInitList(ResolvedType onType) {
this.onType = onType;
}
public int compareTo(Object other) {
IfaceInitList o = (IfaceInitList) other;
if (onType.isAssignableFrom(o.onType)) {
return +1;
} else if... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | public int fallbackCompareTo(Object other) {
return 0;
}
}
public boolean addDispatchTarget(ResolvedMember m) {
return addedDispatchTargets.add(m);
}
public void addLazyMethodGen(LazyMethodGen gen) {
addedLazyMethodGens.add(gen);
}
public void addOrReplaceLazyMethodGen(LazyMethodGen mg) {
if (already... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | throw new BCException("conflict between: " + mg + " and " + existing);
}
}
}
addedLazyMethodGens.add(mg);
}
private boolean alreadyDefined(LazyClassGen clazz, LazyMethodGen mg) {
for (Iterator<LazyMethodGen> i = clazz.getMethodGens().iterator(); i.hasNext();) {
LazyMethodGen existing = i.next();
if... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | return ret;
}
/**
* Create a single bridge method called 'theBridgeMethod' that bridges to 'whatToBridgeTo'
*/
private static void createBridgeMethod(BcelWorld world, LazyMethodGen whatToBridgeToMethodGen, LazyClassGen clazz,
ResolvedMember theBridgeMethod) {
InstructionList body;
InstructionFactory fact;... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (!whatToBridgeToMethodGen.isStatic()) {
body.append(InstructionFactory.createThis());
pos++;
}
for (int i = 0, len = paramTypes.length; i < len; i++) {
Type paramType = paramTypes[i];
body.append(InstructionFactory.createLoad(paramType, pos));
if (!newParamTypes[i].equals(paramTypes[i])) {
if ... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | Set<String> aspectsAffectingType = null;
if (inReweavableMode || clazz.getType().isAspect()) {
aspectsAffectingType = new HashSet<String>();
}
boolean isChanged = false;
if (clazz.getType().isAspect()) {
isChanged = true;
}
WeaverStateInfo typeWeaverState = (world.isOverWeaving() ? getLazyClassGen(... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | isChanged = weaveDeclareAtField(clazz) || isChanged;
addedSuperInitializersAsList = new ArrayList<IfaceInitList>(addedSuperInitializers.values());
addedSuperInitializersAsList = PartialOrder.sort(addedSuperInitializersAsList);
if (addedSuperInitializersAsList == null) {
throw new BCException("circu... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (inReweavableMode || clazz.getType().isAspect()) {
aspectsAffectingType.addAll(findAspectsForMungers(member));
}
isChanged = true;
}
}
for (LazyMethodGen methodGen : methodGens) {
if (!methodGen.hasBody()) {
continue;
}
implement(methodGen);
}
if (!initializationShadows.isE... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (inReweavableMode || clazz.getType().isAspect()) {
aspectsAffectingType.add(munger.getAspectType().getSignature());
}
}
}
}
}
if (isChanged) {
clazz.getOrCreateWeaverStateInfo(inReweavableMode);
weaveInAddedMethods();
}
if (inReweavableMode) {
WeaverSt... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | method.wipeJoinpointSignatures();
}
}
return isChanged;
}
/**
* Check if a particular method is overriding another - refactored into this helper so it can be used from multiple places.
*/
private static ResolvedMember isOverriding(ResolvedType typeToCheck, ResolvedMember methodThatMightBeGettingOv... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
if (!isVisibilityOverride(mmods, methodThatMightBeGettingOverridden, inSamePackage)) {
return null;
}
if (typeToCheck.getWorld().forDEBUG_bridgingCode) {
System.err.println(" Bridging:seriously considering this might be getting overridden '"
+ methodThatMightBeGettingOverridden + "'");
}
Wor... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
}
}
if (sameParams) {
if (typeToCheck.isParameterizedType()) {
return methodThatMightBeGettingOverridden.getBackingGenericMember();
} else if (!methodThatMightBeGettingOverridden.getReturnType().getErasureSignature().equals(mrettype)) {
Res... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | } else {
return methodThatMightBeGettingOverridden;
}
}
return null;
}
/**
* Looks at the visibility modifiers between two methods, and knows whether they are from classes in the same package, and
* decides whether one overrides the other.
*
* @return true if there is an overrides rather than a 'h... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
/**
* This method recurses up a specified type looking for a method that overrides the one passed in.
*
* @return the method being overridden or null if none is found
*/
public static ResolvedMember checkForOverride(ResolvedType typeToCheck, String mname, String mparams, String mrettype,
int mmods, Stri... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | ResolvedMember isOverriding = isOverriding(typeToCheck, methodThatMightBeGettingOverridden, mname, mrettype, mmods,
inSamePackage, methodParamsArray);
if (isOverriding != null) {
return isOverriding;
}
}
List<ConcreteTypeMunger> l = (typeToCheck.isRawType() ? typeToCheck.getGenericType().getInterT... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
if (typeToCheck.equals(UnresolvedType.OBJECT)) {
return null;
}
ResolvedType superclass = typeToCheck.getSuperclass();
ResolvedMember overriddenMethod = checkForOverride(superclass, mname, mparams, mrettype, mmods, mpkg, methodParamsArray);
if (overriddenMethod != null) {
return overriddenMethod;
}
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
if (clazz.isInterface()) {
return false;
}
boolean didSomething = false;
List<LazyMethodGen> methods = clazz.getMethodGens();
Set<String> methodsSet = new HashSet<String>();
for (int i = 0; i < methods.size(); i++) {
LazyMethodGen aMethod = methods.get(i);
methodsSet.add(aMethod.... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
if (name.endsWith("init>")) {
continue;
}
if (world.forDEBUG_bridgingCode) {
System.err.println("Bridging: Determining if we have to bridge to " + clazz.getName() + "." + name + ""
+ bridgeToCandidate.getSignature());
}
ResolvedType theSuperclass = clazz.getSuperClass();
if (world... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
String[] interfaces = clazz.getInterfaceNames();
for (int j = 0; j < interfaces.length; j++) {
if (world.forDEBUG_bridgingCode) {
System.err.println("Bridging:checking superinterface " + interfaces[j]);
}
ResolvedType interfaceType = world.resolve(interfaces[j]);
overriddenMethod = chec... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | /**
* Weave any declare @method/@ctor statements into the members of the supplied class
*/
private boolean weaveDeclareAtMethodCtor(LazyClassGen clazz) {
List<Integer> reportedProblems = new ArrayList<Integer>();
List<DeclareAnnotation> allDecams = world.getDeclareAnnotationOnMethods();
if (allDecams.isEmpty... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (!mg.getName().startsWith(NameMangler.PREFIX)) {
List<DeclareAnnotation> worthRetrying = new ArrayList<DeclareAnnotation>();
boolean modificationOccured = false;
List<AnnotationGen> annotationsToAdd = null;
for (DeclareAnnotation decaM : decaMs) {
if (decaM.matches(mg.getMemberView(),... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | worthRetrying.add(decaM);
}
}
}
while (!worthRetrying.isEmpty() && modificationOccured) {
modificationOccured = false;
List<DeclareAnnotation> forRemoval = new ArrayList<DeclareAnnotation>();
for (DeclareAnnotation decaM : worthR... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | AsmRelationshipProvider.addDeclareAnnotationMethodRelationship(decaM.getSourceLocation(),
clazz.getName(), mg.getMemberView(), world.getModelAsAsmManager());
isChanged = true;
modificationOccured = true;
forRemoval.add(decaM);
unusedDecams.remove(decaM);
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (!getWorld().getMessageHandler().isIgnoring(IMessage.WEAVEINFO)) {
StringBuffer parmString = new StringBuffer("(");
UnresolvedType[] paramTypes = member.getParameterTypes();
for (int i = 0; i < paramTypes.length; i++) {
UnresolvedType type = paramTypes[i];
String s = org.aspectj.apache.bcel.classfil... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (memberLineNumber != -1) {
loc.append(":" + memberLineNumber);
}
}
getWorld().getMessageHandler().handleMessage(
WeaveMessage.constructWeavingMessage(
WeaveMessage.WEAVEMESSAGE_ANNOTATES,
new String[] { sig.toString(), loc.toString(), decaM.getAnnotationString(),
methodName... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | for (ConcreteTypeMunger typeMunger : clazz.getBcelObjectType().getTypeMungers()) {
if (typeMunger.getMunger().getKind() == wantedKind) {
subset.add(typeMunger);
}
}
return subset;
}
public LazyMethodGen locateAnnotationHolderForFieldMunger(LazyClassGen clazz, ConcreteTypeMunger fieldMunger) {
NewField... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
String name = lookingFor.getName();
String paramSignature = lookingFor.getParameterSignature();
for (LazyMethodGen member : clazz.getMethodGens()) {
if (member.getName().equals(name) && member.getParameterSignature().equals(paramSignature)) {
return member;
}
}
return null;
}
/**
* Applies som... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | annotationHolder.removeAnnotation(decaF.getAnnotationType());
AsmRelationshipProvider.addDeclareAnnotationRelationship(world.getModelAsAsmManager(),
decaF.getSourceLocation(), itdIsActually.getSourceLocation(), true);
} else {
worthRetrying.add(decaF);
}
} else {
LazyMethod... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | DeclareAnnotation decaF = iter2.next();
if (decaF.matches(itdIsActually, world)) {
if (decaF.isRemover()) {
LazyMethodGen annotationHolder = locateAnnotationHolderForFieldMunger(clazz, fieldMunger);
if (annotationHolder.hasAnnotation(decaF.getAnnotationType())) {
isChanged = true;
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
/**
* Applies some set of declare @method/@ctor constructs (List<DeclareAnnotation>) to some bunch of ITDmembers
* (List<BcelTypeMunger>. It will iterate over the fields repeatedly until everything has been applied.
*/
private boolean weaveAtMethodOnITDSRepeatedly(List<DeclareAnnotation> decaMCs,
List<Conc... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (!decaMC.isStarredAnnotationPattern()) {
worthRetrying.add(decaMC);
}
}
}
while (!worthRetrying.isEmpty() && modificationOccured) {
modificationOccured = false;
List<DeclareAnnotation> forRemoval = new ArrayList<DeclareAnnotation>();
for (Iterator<DeclareAnnotation> iter2 = worthRetr... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | private boolean dontAddTwice(DeclareAnnotation decaF, AnnotationAJ[] dontAddMeTwice) {
for (AnnotationAJ ann : dontAddMeTwice) {
if (ann != null && decaF.getAnnotation().getTypeName().equals(ann.getTypeName())) {
return true;
}
}
return false;
}
/**
* Weave any declare @field statements in... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | typeIsChanged = weaveAtFieldRepeatedly(allDecafs, relevantItdFields, reportedProblems);
}
List<DeclareAnnotation> decafs = getMatchingSubset(allDecafs, clazz.getType());
if (decafs.isEmpty()) {
return typeIsChanged;
}
List<BcelField> fields = clazz.getFieldGens();
if (fields != null) {
Set<DeclareAnno... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | reportFieldAnnotationWeavingMessage(clazz, field, decaf, true);
} else {
worthRetrying.add(decaf);
}
unusedDecafs.remove(decaf);
} else {
if (!dontAddTwice(decaf, dontAddMeTwice)) {
if (doesAlreadyHaveAnnotation(field, decaf, reportedProblems)) {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | for (Iterator<DeclareAnnotation> iter = worthRetrying.iterator(); iter.hasNext();) {
DeclareAnnotation decaF = iter.next();
if (decaF.matches(field, world)) {
if (decaF.isRemover()) {
AnnotationAJ annotation = decaF.getAnnotation();
if (field.hasAnnotation(annotation.getType())) ... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
}
checkUnusedDeclareAts(unusedDecafs, true);
}
return typeIsChanged;
}
/**
* Report an error if the reason a "declare @method/ctor/field" was not used was because the member specified does not exist.
* This method is passed some set of declare statements that didn't match and a flag indicating wheth... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
}
}
if (shouldCheck) {
boolean itdMatch = false;
List<ConcreteTypeMunger> lst = clazz.getType().getInterTypeMungers();
for (Iterator<ConcreteTypeMunger> iterator = lst.iterator(); iterator.hasNext() && !itdMatch;) {
ConcreteTypeMunger element = iterator.next();
if (element.getMung... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
}
}
}
private void reportFieldAnnotationWeavingMessage(LazyClassGen clazz, BcelField theField, DeclareAnnotation decaf,
boolean isRemove) {
if (!getWorld().getMessageHandler().isIgnoring(IMessage.WEAVEINFO)) {
world.getMessageHandler().handleMessage(
WeaveMessage.constructWeavingMessage(
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | return true;
}
return false;
}
private boolean doesAlreadyHaveAnnotation(LazyMethodGen rm, ResolvedMember itdfieldsig, DeclareAnnotation deca,
List<Integer> reportedProblems) {
if (rm != null && rm.hasAnnotation(deca.getAnnotationType())) {
if (world.getLint().elementAlreadyAnnotated.isEnabled()) {
In... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | } else {
}
}
}
return aspectsAffectingType;
}
private boolean inlineSelfConstructors(List<LazyMethodGen> methodGens) {
boolean inlinedSomething = false;
for (LazyMethodGen methodGen : methodGens) {
if (!methodGen.getName().equals("<init>")) {
continue;
}
InstructionHandle ih = ... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | private void positionInitializationShadow(BcelShadow s) {
LazyMethodGen mg = s.getEnclosingMethod();
InstructionHandle call = findSuperOrThisCall(mg);
InstructionList body = mg.getBody();
ShadowRange r = new ShadowRange(body);
r.associateWithShadow(s);
if (s.getKind() == Shadow.PreInitialization) {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | /*
* Implementation notes:
*
* We allocate two slots for every tempvar so we don't screw up longs and doubles which may share space. This could be
* conservatively avoided (no reference to a long/double instruction, don't do it) or packed later. Right now we don't
* bother to pack.
*
* Allocate a... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | * Some jumping through firey hoops required - depending on the input code level (1.5 or not) we may or may not be able to use
* the LDC instruction that takes a class literal (doesnt on <1.5).
*
* FIXME asc Before promoting -Xjoinpoints:synchronization to be a standard option, this needs a bunch of tidying up - ... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | prepend.append(InstructionFactory.MONITORENTER);
InstructionList finallyBlock = new InstructionList();
finallyBlock.append(InstructionFactory.createLoad(Type.getType(java.lang.Class.class), slotForLockObject));
finallyBlock.append(InstructionConsta... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | InstructionHandle walker = body.getStart();
List<InstructionHandle> rets = new ArrayList<InstructionHandle>();
while (walker != null) {
if (walker.getInstruction().isReturnInstruction()) {
rets.add(walker);
}
walker = walker.getNext();
}
if (!rets.isEmpty()) {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (targeter instanceof LocalVariableTag) {
} else if (targeter instanceof LineNumberTag) {
} else if (targeter instanceof InstructionBranch) {
targeter.updateTarget(element, monitorExitBlockStart);
} else {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | Type classType = BcelWorld.makeBcelType(synchronizedMethod.getEnclosingClass().getType()); |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | Type clazzType = Type.getType(Class.class);
InstructionList parttwo = new InstructionList();
parttwo.append(InstructionFactory.createDup(1));
int slotForThis = synchronizedMethod.allocateLocal(classType);
parttwo.append(InstructionFactory.createStore(clazzType, slotForThis));
parttwo.append(In... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | InstructionHandle tryInstruction = prepend.getEnd();
prepend.append(fact.createInvoke("java.lang.Class", "forName", clazzType,
new Type[] { Type.getType(String.class) }, Constants.INVOKESTATIC));
InstructionHandle catchInstruction = prepend.getEnd();
prepend.append(InstructionFactory.createDup(1));
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | InstructionList finallyBlock = new InstructionList();
finallyBlock.append(InstructionFactory.createLoad(Type.getType(java.lang.Class.class), slotForThis));
finallyBlock.append(InstructionConstants.MONITOREXIT);
finallyBlock.append(InstructionConstants.ATHROW); |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | InstructionHandle walker = body.getStart();
List<InstructionHandle> rets = new ArrayList<InstructionHandle>();
while (walker != null) {
if (walker.getInstruction().isReturnInstruction()) {
rets.add(walker);
}
walker = walker.getNext();
}
if (rets.size() > 0) {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | InstructionHandle monitorExitBlockStart = body.insert(ret, monitorExitBlock);
for (InstructionTargeter targeter : ret.getTargetersCopy()) {
if (targeter instanceof LocalVariableTag) {
} else if (targeter instanceof LineNumberTag) {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | InstructionHandle tryPosition = body.getStart();
InstructionHandle catchPosition = body.getEnd();
body.insert(body.getStart(), prepend);
synchronizedMethod.getBody().append(finallyBlock);
synchronizedMethod.addExceptionHandler(tryPosition, catchPosition, finallyStart, null, false);
synchronize... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | InstructionList finallyBlock = new InstructionList();
finallyBlock.append(InstructionFactory.createLoad(classType, slotForThis));
finallyBlock.append(InstructionConstants.MONITOREXIT);
finallyBlock.append(InstructionConstants.ATHROW);
Instructi... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | rets.add(walker);
}
walker = walker.getNext();
}
if (!rets.isEmpty()) {
for (Iterator<InstructionHandle> iter = rets.iterator(); iter.hasNext();) {
InstructionHandle element = iter.next();
InstructionList monitorExitBlock = new InstructionList();
monitorExitBl... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | } else if (targeter instanceof InstructionBranch) {
targeter.updateTarget(element, monitorExitBlockStart);
} else {
throw new BCException("Unexpected targeter encountered during transform: " + targeter);
}
}
}
}
InstructionHandle finallyStart = finallyBlock.getStart(... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | trace.exit("transformSynchronizedMethod");
}
}
/**
* generate the instructions to be inlined.
*
* @param donor the method from which we will copy (and adjust frame and jumps) instructions.
* @param recipient the method the instructions will go into. Used to get the frame size so we can allocate new frame l... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (isAcrossClass) {
InstructionCP cpi = (InstructionCP) fresh;
cpi.setIndex(recipientCpg.addConstant(donorCpg.getConstant(cpi.getIndex()), donorCpg));
}
}
if (src.getInstruction() == Range.RANGEINSTRUCTION) {
dest = ret.append(Range.RANGEINSTRUCTION);
} else if (fresh.isReturnInstruction()) ... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | } else {
fresh = ((InstructionLV) fresh).setIndexAndCopyIfNecessary(freshIndex);
}
dest = ret.append(fresh);
} else {
dest = ret.append(fresh);
}
srcToDest.put(src, dest);
}
Map<Tag, Tag> tagMap = new HashMap<Tag, Tag>();
Map<BcelShadow, BcelShadow> shadowMap = new HashMap<BcelShadow,... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | }
}
}
}
Iterator<InstructionTargeter> tIter = src.getTargeters().iterator();
while (tIter.hasNext()) {
InstructionTargeter old = tIter.next();
if (old instanceof Tag) {
Tag oldTag = (Tag) old;
Tag fresh = tagMap.get(oldTag);
if (fresh == null) {
fresh = oldTag.copy();
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | dest.addTargeter(fresh);
} else if (old instanceof ExceptionRange) {
ExceptionRange er = (ExceptionRange) old;
if (er.getStart() == src) {
ExceptionRange freshEr = new ExceptionRange(recipient.getBody(), er.getCatchType(), er.getPriority());
freshEr.associateWithTargets(dest, srcToDest.get(er.... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | ret.append(footer);
}
return ret;
} |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | /**
* generate the argument stores in preparation for inlining.
*
* @param donor the method we will inline from. Used to get the signature.
* @param recipient the method we will inline into. Used to get the frame size so we can allocate fresh locations.
* @param frameEnv an empty environment we populate with... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | * @param fact an instruction factory for recipient
*/
private static InstructionList genArgumentStores(LazyMethodGen donor, LazyMethodGen recipient, IntMap frameEnv,
InstructionFactory fact) {
InstructionList ret = new InstructionList();
int donorFramePos = 0;
if (!donor.isStatic()) {
int targetSlot =... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | String methodName = inst.getName(cpg);
String signature = inst.getSignature(cpg);
return clazz.getLazyMethodGen(methodName, signature);
}
private void weaveInAddedMethods() {
Collections.sort(addedLazyMethodGens, new Comparator<LazyMethodGen>() {
public int compare(LazyMethodGen aa, LazyMethodGen bb) {
i... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | /**
* Returns null if this is not a Java constructor, and then we won't weave into it at all
*/
private InstructionHandle findSuperOrThisCall(LazyMethodGen mg) {
int depth = 1;
InstructionHandle start = mg.getBody().getStart();
while (true) {
if (start == null) {
return null;
}
Instruction inst ... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | List<BcelShadow> shadowAccumulator = new ArrayList<BcelShadow>();
boolean isOverweaving = world.isOverWeaving();
boolean startsAngly = mg.getName().charAt(0) == '<';
if (startsAngly && mg.getName().equals("<init>")) {
return matchInit(mg, shadowAccumulator);
} else if (!shouldWeaveBody(mg)) {
return fa... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | fixParameterNamesForResolvedMember(rm, mg.getMemberView());
fixAnnotationsForResolvedMember(rm, mg.getMemberView());
enclosingShadow = BcelShadow.makeShadowForMethod(world, mg, effective.getShadowKind(), rm);
} else {
return false;
}
}
if (canMatchBodyShadows) {
for (InstructionHandle h... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | return false;
}
enclosingShadow = BcelShadow.makeConstructorExecution(world, mg, superOrThisCall);
if (mg.getEffectiveSignature() != null) {
enclosingShadow.setMatchingSignature(mg.getEffectiveSignature().getEffectiveSignature());
}
boolean beforeSuperOrThisCall = true;
if (shouldWeaveBody(mg)) {
i... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | InstructionList inits = genInitInstructions(l.list, false);
if (match(initShadow, shadowAccumulator) || !inits.isEmpty()) {
initShadow.initIfaceInitializer(curr);
initShadow.getRange().insert(inits, Range.OutsideBefore);
}
}
InstructionList inits = genInitInstructions(addedThisInitializers, ... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (a != null) {
return a.isWeaveBody();
}
return true;
}
/**
* first sorts the mungers, then gens the initializers in the right order
*/
private InstructionList genInitInstructions(List<ConcreteTypeMunger> list, boolean isStatic) {
list = PartialOrder.sort(list);
if (list == null) {
throw new BCEx... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (t instanceof ExceptionRange) {
ExceptionRange er = (ExceptionRange) t;
if (er.getCatchType() == null) {
continue;
}
if (isInitFailureHandler(ih)) {
return;
}
if (!ih.getInstruction().isStoreInstruction() && ih.getInstruction().getOpcode() != Constants.NOP) {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | ih.removeAllTargeters();
match(BcelShadow.makeExceptionHandler(world, er, mg, newNOP, enclosingShadow), shadowAccumulator);
} else {
match(BcelShadow.makeExceptionHandler(world, er, mg, ih, enclosingShadow), shadowAccumulator);
}
}
}
}
if ((i instanceof FieldInstruction) && (canMatch(Sh... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | } else {
if (canMatch(Shadow.FieldSet)) {
matchSetInstruction(mg, ih, enclosingShadow, shadowAccumulator);
}
}
} else {
if (canMatch(Shadow.FieldSet)) {
matchSetInstruction(mg, ih, enclosingShadow, shadowAccumulator);
}
}
} else {
if (canMatch(Shadow.FieldGet)) {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | } else {
matchInvokeInstruction(mg, ih, ii, enclosingShadow, shadowAccumulator);
}
} else if (world.isJoinpointArrayConstructionEnabled() && i.isArrayCreationInstruction()) {
if (canMatch(Shadow.ConstructorCall)) {
if (i.opcode == Constants.ANEWARRAY) {
BcelShadow ctorCallShadow = BcelS... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | } else if (world.isJoinpointSynchronizationEnabled()
&& ((i.getOpcode() == Constants.MONITORENTER) || (i.getOpcode() == Constants.MONITOREXIT))) {
if (i.getOpcode() == Constants.MONITORENTER) {
BcelShadow monitorEntryShadow = BcelShadow.makeMonitorEnter(world, mg, ih, enclosingShadow);
match(monitorE... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | FieldInstruction fi = (FieldInstruction) ih.getInstruction();
Member field = BcelWorld.makeFieldJoinPointSignature(clazz, fi);
if (field.getName().startsWith(NameMangler.PREFIX)) {
return;
}
ResolvedMember resolvedField = field.resolve(world);
if (resolvedField == null) {
return;
} else if (Mod... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | FieldInstruction fi = (FieldInstruction) ih.getInstruction();
Member field = BcelWorld.makeFieldJoinPointSignature(clazz, fi);
if (field.getName().startsWith(NameMangler.PREFIX)) {
return;
}
ResolvedMember resolvedField = field.resolve(world);
if (resolvedField == null) {
return;
} else if (res... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (member.getName().equals(methodName)) {
return member;
}
}
return null;
}
/**
* Find the specified member in the specified type.
*
* @param type the type to search for the member
* @param methodName the name of the method to find
* @param params the method parameters that the discovered metho... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | for (ResolvedMember candidate : candidates) {
boolean allOK = true;
UnresolvedType[] candidateParams = candidate.getParameterTypes();
for (int p = 0; p < candidateParams.length; p++) {
if (!candidateParams[p].getErasureSignature().equals(params[p].getErasureSignature())) {
allOK = false... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | if (rm.getKind() == Member.METHOD && !rm.isAbstract()) {
if (methodName.startsWith("ajc$inlineAccessMethod") || methodName.startsWith("ajc$superDispatch")) {
ResolvedMember resolvedDooberry = world.resolve(declaredSig);
pnames = resolvedDooberry.getParameterNames();
} else {
ResolvedMember realthing =... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | try {
UnresolvedType memberHostType = declaredSig.getDeclaringType();
ResolvedType[] annotations = mapToAnnotations.get(rm);
String methodName = declaredSig.getName();
if (annotations == null) {
if (rm.getKind() == Member.FIELD) {
if (methodName.startsWith("ajc$inlineAccessField")) {
Reso... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | } else if (rm.getKind() == Member.CONSTRUCTOR) {
ResolvedMember realThing = AjcMemberMaker.postIntroducedConstructor(memberHostType.resolve(world),
rm.getDeclaringType(), rm.getParameterTypes());
ResolvedMember resolvedDooberry = world.resolve(realThing);
if (resolvedDooberry == null) {
... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | ResolvedMember declaredSig = jpSig.resolve(world);
if (declaredSig == null) {
return;
}
if (declaredSig.getKind() == Member.FIELD) {
Shadow.Kind kind;
if (jpSig.getReturnType().equals(ResolvedType.VOID)) {
kind = Shadow.FieldSet;
} else {
kind = Shadow.FieldGet;
}
if (canM... |
354,022 | Bug 354022 constructor inlining can fail for some groovy built code | The file grails.util.BuildSettings contains bytecode where the constructors are recursive. You can't compile this in Java A() { this(); } but groovy generates some code where it switches on a value in the ctor and if it is a certain value, the recursive ctor call is made. I imagine this 'never happens' in practice but ... | resolved fixed | 6ae463a | AspectJ | https://github.com/eclipse/org.aspectj | eclipse/org.aspectj | java | null | null | null | 2011-08-05T16:17:39Z | 2011-08-05T16:00:00Z | weaver/src/org/aspectj/weaver/bcel/BcelClassWeaver.java | shadowAccumulator);
}
}
} else {
if (canMatch(Shadow.MethodCall)) {
boolean proceed = true;
if (world.isOverWeaving()) {
String s = invoke.getClassName(mg.getConstantPool());
if (s.length() > 4
&& s.charAt(4) == 'a'
&& (s.equals("org.aspectj.runtime.internal.CFlowC... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.