status stringclasses 1
value | repo_name stringlengths 9 24 | repo_url stringlengths 28 43 | issue_id int64 1 104k | updated_files stringlengths 8 1.76k | title stringlengths 4 369 | body stringlengths 0 254k ⌀ | issue_url stringlengths 37 56 | pull_url stringlengths 37 54 | before_fix_sha stringlengths 40 40 | after_fix_sha stringlengths 40 40 | report_datetime timestamp[ns, tz=UTC] | language stringclasses 5
values | commit_datetime timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | fastify/fastify | https://github.com/fastify/fastify | 2,897 | ["docs/Ecosystem.md"] | Add fastify-schema-to-typescript to ecosystem | Hi team,
I've been working on this tool to generate typescript types from a json schema. It allows to have types that match the validation schema.
Would it be possible to add it to the ecosystem? If no would it be possible to have some feedback to make it better
Here's the repo https://github.com/thomasthieba... | https://github.com/fastify/fastify/issues/2897 | https://github.com/fastify/fastify/pull/2898 | fefab178bc1cc14cfd5965583500800ff0c61d27 | efa77faeac506c0339c28a6708d42a0876d8e2d5 | 2021-03-05T08:44:00Z | javascript | 2021-03-05T23:33:17Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,885 | ["docs/ContentTypeParser.md", "lib/contentTypeParser.js", "lib/errors.js", "test/content-parser.test.js", "test/custom-parser.test.js", "types/content-type-parser.d.ts"] | Support RegExp for the addContentTypeParser API | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2885 | https://github.com/fastify/fastify/pull/2890 | 0b6ca3afaa4687ee83412ab010df62b8261a3684 | fefab178bc1cc14cfd5965583500800ff0c61d27 | 2021-02-28T10:37:47Z | javascript | 2021-03-05T09:19:49Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,852 | ["docs/Reference/Validation-and-Serialization.md", "package.json", "test/schema-feature.test.js"] | Should array support in validation be enabled by default? | ## 🚀 Feature Proposal
In #2841 the question came up whether supporting array validation should be enabled by default, and I was asked to open a new issue to discuss the breaking change.
My naive reasoning was:
- In cases that don't use `type: 'array'` in the schema there shouldn't be an impact on either behavio... | https://github.com/fastify/fastify/issues/2852 | https://github.com/fastify/fastify/pull/3594 | 38fc063ecd3febeb7e2d93453760ab4cd9147845 | 0033f739d4c8471b55991835f92eee94d7491292 | 2021-02-13T11:12:44Z | javascript | 2022-01-06T08:16:17Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,842 | ["docs/Errors.md", "fastify.js", "lib/errors.js", "lib/hooks.js", "package.json", "test/hooks.on-ready.test.js", "test/plugin.test.js"] | Improve errors user experience | Fastify has many assertions around in the codebase to make sure that the user didn't misconfigure something, for instance, it checks if a route has been declared twice or if a plugin is not a function.
This is great, we vastly reduce the possibility of weird runtime issues, but for historical reasons the errors we are... | https://github.com/fastify/fastify/issues/2842 | https://github.com/fastify/fastify/pull/3106 | 71b21bfafc4b074b2e4d42f20b5e60a4a7ada395 | c631bb71b8c180c8ba326e81455836f93b0d08c9 | 2021-02-09T07:08:07Z | javascript | 2021-06-05T07:28:52Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,836 | ["docs/Server.md"] | Logger option genReqId not considered | ## 🐛 Bug Report
The `genReqId` function specified within the standard Pino Logger options object is not considered, when generating identifiers for incoming requests.
## To Reproduce
```js
fastify({
logger: {
genReqId: req => 'whatever string',
},
});
```
This bug was fixed here https... | https://github.com/fastify/fastify/issues/2836 | https://github.com/fastify/fastify/pull/2838 | fc33ae97ed2de9d2c9c262f5efb966c84e942547 | 91d87c54efe961496e85053bdb1bebbdffbd29ef | 2021-02-05T10:43:45Z | javascript | 2021-02-05T17:53:29Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,813 | ["docs/Request.md", "lib/request.js", "test/schema-special-usage.test.js"] | Validation tries to set headers but its not possible | ## 🐛 Bug Report
Hi people, while upgrading to v3 I've noticed a strange behavior.
#2426 has changed headers to be a getter, but `validateParam` (https://github.com/fastify/fastify/blob/master/lib/validation.js#L74) does try to assign it if the validation result contains the `value`. This does not come up with ajv ... | https://github.com/fastify/fastify/issues/2813 | https://github.com/fastify/fastify/pull/2817 | 612ff0beacd7c803114853dd29ec27f3c7c1178d | fb5e1f176500654a97fc27f91a08288a83eb3ebe | 2021-01-23T10:48:58Z | javascript | 2021-08-09T19:18:53Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,788 | ["lib/route.js", "test/route.test.js"] | Creates incorrect HEAD route when using exposeHeadRoute | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2788 | https://github.com/fastify/fastify/pull/2790 | 3634c6e01e4049e946da68647a6aaf5847dbccbd | f3d5742f5398e37401d9ea0766d9a37d6f38f08a | 2021-01-12T06:41:47Z | javascript | 2021-01-25T09:49:45Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,770 | ["lib/reply.js", "test/internals/reply.test.js"] | preSerialization won't be exeecuted in case of a custom serializer. | If you define a custom [reply serializer](https://www.fastify.io/docs/latest/Reply/#serializerfunc), the `preSerialization` won't be executed.
I think this is a leftover of previous implementations and it should considered a bug.
https://github.com/fastify/fastify/blob/834a4e58de86d7996b50a4663fbf2b0fac4686ee/lib/r... | https://github.com/fastify/fastify/issues/2770 | https://github.com/fastify/fastify/pull/2773 | 886fd348150476ff1303f7ca28d76546c57a3f15 | 9b0c85472e07cc2907591b3df8f9e7e0b1869b7d | 2020-12-31T17:44:09Z | javascript | 2021-01-05T08:34:35Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,767 | ["lib/route.js", "test/hooks.test.js", "test/route-prefix.test.js", "test/route.test.js"] | Allow onRoute to alter options without side effects |
## 🚀 Feature Proposal
The way the `onRoute` hook can be used is to derive some info from the route settings (for swagger for example), or to __mutate the route definition itself__. However in certain cases Fastify creates two routes from the same definition (see https://github.com/fastify/fastify/blob/834a4e58... | https://github.com/fastify/fastify/issues/2767 | https://github.com/fastify/fastify/pull/2782 | 9135e8e79a03e02063b1e6b96115ac6abca5ccf0 | 5a6aa29a113704448433b6cc19f6e33032aae77f | 2020-12-30T12:17:27Z | javascript | 2021-01-13T21:57:42Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,761 | ["lib/request.js", "package.json", "test/internals/request.test.js"] | [FST_LIGHTMYREQUEST_DEP01] When I run my test units | ## 🐛 Bug Report
When I run my test units , i get [FST_LIGHTMYREQUEST_DEP01] deprecation warning.
I use jest for testing and request injetcion:
#sample.spec.js
```js
describe('SampleTest', () => {
/** @type {import('awilix').AwilixContainer} */
let container;
afterEach(async () => {
await c... | https://github.com/fastify/fastify/issues/2761 | https://github.com/fastify/fastify/pull/2849 | 7fdef2dcd7d08c2b908402fa6fb5ecc26b762c41 | e5ed15466f26840bc7a71f8f74da54dcce4192e2 | 2020-12-23T15:00:55Z | javascript | 2021-02-13T09:18:53Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,760 | ["lib/pluginUtils.js", "test/plugin.test.js"] | Report actual plugin requiring decorator | https://github.com/fastify/fastify/blob/c2c5cfca689234864d5a208301dde10cefab9804/lib/pluginUtils.js#L82-L85
The above assertion isn't too helpful. If a plugin asks for the "foo" decorator on the "fastify" object, then it gives a message like the following when that decorator is not found:
> The decorator 'foo' is... | https://github.com/fastify/fastify/issues/2760 | https://github.com/fastify/fastify/pull/2778 | 9b0c85472e07cc2907591b3df8f9e7e0b1869b7d | af87e7bae038abffe46ff51a0bbd5b0c797cf495 | 2020-12-23T14:47:22Z | javascript | 2021-01-06T17:24:55Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,742 | ["docs/Server.md", "fastify.js", "lib/schema-compilers.js", "lib/schema-controller.js", "package.json", "test/schema-serialization.test.js", "test/schema-special-usage.test.js"] | Ajv@7 upgrade plan | Ajv@6 will be discontinued at 28/2/2021, well before we retire Fastify v3. We are at the early stages of Fastify v4 right now, so there might be 6+ months of potentially unsupported validator against security vulnerabilities. However the code in Ajv@6 is really battle tested, so there might be a small chance of that ha... | https://github.com/fastify/fastify/issues/2742 | https://github.com/fastify/fastify/pull/2862 | 5eeab8b1bdacf14cd7ac2b5785cd0908e8f9693e | 5dfec548f890277cfc2b2f4653e4dd3889af2b3c | 2020-12-16T18:28:21Z | javascript | 2021-05-21T10:58:02Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,736 | ["lib/reqIdGenFactory.js"] | Have default request id generation generate unique id:s | ## 🚀 Feature Proposal
Currently request id:s default to an auto-incremented number, but that number is generated locally in each instance, meaning that if one run two or more instances of Fastify, or restarts a single Fastify instance, then the default generated id:s will be duplicated between between two or more r... | https://github.com/fastify/fastify/issues/2736 | https://github.com/fastify/fastify/pull/2848 | 914000d22694eb30a0601c2fccb232e936e2849c | 291afba794a2ecf780162f27e1b460f9a5670198 | 2020-12-13T18:45:17Z | javascript | 2021-02-23T08:42:52Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,722 | ["test/types/schema.test-d.ts", "types/instance.d.ts", "types/route.d.ts", "types/schema.d.ts"] | Typescript types for `setSerializerCompiler` mismatch | ## 🐛 Bug Report
Similar to #2572 the serializer does not like the type signatures it is given even when using the code sample from the readme.
## To Reproduce
Steps to reproduce the behavior:
```js
fastify.setSerializerCompiler(({ schema, method, url, httpStatus }) => {
return data => JSON.stringify(da... | https://github.com/fastify/fastify/issues/2722 | https://github.com/fastify/fastify/pull/2745 | 6b64483acc1f27202b393dc5a22ab7bb96e2623c | b9d0859b4b36a609eea6fa55a19b3ce73d5057c7 | 2020-12-04T20:45:59Z | javascript | 2020-12-17T09:41:15Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,711 | ["test/types/instance.test-d.ts", "types/instance.d.ts"] | FastifyInstance interface doesn't expose errorHandler | ## 🐛 Bug Report
While documentation states that `FastifyInstance` has a `errorHandler` method:
https://www.fastify.io/docs/latest/Server/#errorhandler
And it is indeed implemented that way, but when trying to implement in TypeScript with strict compilation it fails as `FastifyInstance` doesn't expose this method:... | https://github.com/fastify/fastify/issues/2711 | https://github.com/fastify/fastify/pull/2712 | db39fa74c0d9d5ead9371e414f533f33c2bfd5b5 | 61c8a7bc3c91907e97813b631d35ae1f250b40e2 | 2020-11-26T13:34:10Z | javascript | 2020-11-28T10:17:49Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,707 | ["lib/hooks.js", "test/hooks-async.test.js"] | schema validation error on an async response does not trigger the error handler | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2707 | https://github.com/fastify/fastify/pull/2713 | 273a76f8a6963cd0f633e7e87f5e053a176e0e66 | db39fa74c0d9d5ead9371e414f533f33c2bfd5b5 | 2020-11-25T13:47:59Z | javascript | 2020-11-27T14:05:25Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,692 | ["lib/hooks.js", "lib/route.js", "test/hooks.test.js", "test/internals/hookRunner.test.js"] | Errors in `onSend` makes fastify not respond | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2692 | https://github.com/fastify/fastify/pull/2695 | d7d8c2787698a2e03d9ed02af03027f23d8d3a83 | 088a07c2b26deb93d8d4cd64601bae3e09799b66 | 2020-11-17T09:55:04Z | javascript | 2020-12-16T08:12:45Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,687 | ["docs/Reply.md", "lib/reply.js", "lib/route.js", "lib/symbols.js", "lib/validation.js", "package.json", "test/hooks.test.js", "test/schema-serialization.test.js"] | Custom error properties via schemas | ## 🚀 Feature Proposal
Right now setting the schema response of errors doesn't enhance the default error handler.
```js
const Fastify = require('fastify')
const statusCodes = require('http').STATUS_CODES
async function run () {
const app = Fastify()
app.get('/async-throw', {
schema: {
res... | https://github.com/fastify/fastify/issues/2687 | https://github.com/fastify/fastify/pull/2691 | 61c8a7bc3c91907e97813b631d35ae1f250b40e2 | 43ea177527d535cc17ed168dd479e07cc61db19d | 2020-11-14T18:49:14Z | javascript | 2020-11-29T10:31:23Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,653 | ["lib/wrapThenable.js", "test/async-await.test.js"] | reply.sent is false in setErrorHandler | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2653 | https://github.com/fastify/fastify/pull/2774 | 035ca57a4360900bd2fa81ba1d91405e603f1b5f | 5e0e674823642d851fefb73d78fc590325c880b2 | 2020-10-27T12:39:15Z | javascript | 2021-01-03T21:17:32Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,644 | ["docs/Request.md", "docs/Server.md"] | Support case insensitive query parameters | ## 🚀 Feature Proposal
Could it be possible to support an optional case insentive option for query parameters? Adding the option `caseSensitive: false` does not seems to impact query parameters
## Motivation
For backward compatibilitites you sometime need to support multiple casing
## Example
With that c... | https://github.com/fastify/fastify/issues/2644 | https://github.com/fastify/fastify/pull/3319 | ce6270608be0dd56de629be0df149f94c5df95ba | ad967c2cc878eea3e832503e6a081003d13df110 | 2020-10-23T14:14:08Z | javascript | 2021-09-19T06:30:24Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,633 | ["docs/Reply.md"] | [Minor] Wrong anchor link in Docs | In der [Docs](https://www.fastify.io/docs/latest/Reply/) for Reply the anchor link for _Redirect_ does not work.
* Link: `#redirectdest`
* actual id: `redirectcode--dest`
I don't know how to fix that. Seems like a problem with the markdown-to-html conversion. | https://github.com/fastify/fastify/issues/2633 | https://github.com/fastify/fastify/pull/2640 | b7e31b387641e9a35cadb6948e758dff14a76b01 | 2e9da06e42c14876547d7e95771aefbc5ebdf878 | 2020-10-20T20:29:00Z | javascript | 2020-10-22T20:09:39Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,619 | ["docs/Routes.md", "docs/Server.md", "fastify.d.ts", "fastify.js", "lib/headRoute.js", "lib/route.js", "lib/warnings.js", "test/route.test.js", "types/route.d.ts"] | Automatically handle `HEAD` requests in `GET` handler unless explicit `HEAD` handler exists | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2619 | https://github.com/fastify/fastify/pull/2700 | 27373efa587927f9546fb93489ab2a0455f4b8ca | 834a4e58de86d7996b50a4663fbf2b0fac4686ee | 2020-10-14T12:09:51Z | javascript | 2020-12-28T18:06:38Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,603 | ["fastify.js", "test/internals/version.test.js", "types/instance.d.ts"] | Plugin registration no longer works with webpack | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2603 | https://github.com/fastify/fastify/pull/2605 | 341bbc86c94df5cec49778e9c5657b27cbf59282 | f22cb2f3105d2dfbf4400abe7ade93f48d5d0851 | 2020-10-06T21:41:38Z | javascript | 2020-10-07T15:34:04Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,572 | ["test/types/schema.test-d.ts", "types/schema.d.ts"] | Typescript types for `setValidatorCompiler` mismatch | ## 🐛 Bug Report
Typescript typings no longer work for setting ajv as a schema validator (even when using the code sample from the README).
## To Reproduce
Steps to reproduce the behavior:
```typescript
const ajv = new Ajv({
// the fastify defaults (if needed)
removeAdditional: false,
useD... | https://github.com/fastify/fastify/issues/2572 | https://github.com/fastify/fastify/pull/2576 | c15e8381b23176bc20c390324941e6abceaf318d | df9fbc183fa05fa1a23781b3f11fbf81f6854033 | 2020-09-22T10:58:48Z | javascript | 2020-09-23T08:03:41Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,568 | ["docs/Reference/Validation-and-Serialization.md", "lib/handleRequest.js", "lib/validation.js", "test/schema-special-usage.test.js"] | Support for async ajv schemas | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2568 | https://github.com/fastify/fastify/pull/4752 | 4f367eabcdd70be5e969883c44290a83e8d5f18e | a649133ebd60c59b284dcd92834aa20fa5d2a8e1 | 2020-09-21T09:11:35Z | javascript | 2023-05-26T06:33:00Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,567 | ["lib/route.js", "test/route.test.js"] | Strange behavior with route reusage | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2567 | https://github.com/fastify/fastify/pull/2569 | a40de6d26a92b9d4749d610161efef85d2f23157 | c15e8381b23176bc20c390324941e6abceaf318d | 2020-09-21T08:56:35Z | javascript | 2020-09-22T14:05:29Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,557 | ["docs/TypeScript.md", "fastify.d.ts", "package.json", "test/types/decorate-request-reply.test-d.ts"] | Declaration merging broken for FastifyRequest and FastifyReply | #### What are you trying to achieve or the steps to reproduce?
I've followed the steps for [Creating a TypeScript Fastify Plugin](https://www.fastify.io/docs/latest/TypeScript/#creating-a-typescript-fastify-plugin) exactly (twice), but when I reach step 6 and execute `npm run build` in my terminal I receive four err... | https://github.com/fastify/fastify/issues/2557 | https://github.com/fastify/fastify/pull/2558 | f32061907495eee99f51e93d50aae858f8467aa3 | 29c2af10fa0cc4898a86c66772d6ce4079251ab0 | 2020-09-17T09:04:51Z | javascript | 2020-09-19T05:25:13Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,602 | ["docs/Errors.md", "fastify.js", "lib/reply.js", "lib/setErrorHeaders.js", "test/reply-error.test.js", "test/route-hooks.test.js"] | Fastify's default error handling can serve unexpected responses | ## 🐛 Bug Report
I'm not sure if this is a bug or intended behavior (it is documented to some extent, but it seems like setting your own error handler should disable it), so apologies in advance if this should be a feature request versus a bug report.
Fastify's default error handling checks for properties like `s... | https://github.com/fastify/fastify/issues/2602 | https://github.com/fastify/fastify/pull/2609 | 14f967961623defb907852be9108f710dffa185d | f6ee35587345fac4f4cf9212d139fde97f3ab36e | 2020-09-16T03:02:18Z | javascript | 2020-11-13T08:56:32Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,543 | ["lib/reply.js", "test/content-length.test.js"] | Invalid content-length in custom ErrorHandler | ## 🐛 Bug Report
I add a custom error handler to add some extra data to my api answer (stack, ...).
- I send a request too an elasticsearch server, which reply an answer (an error) with a content-length of 335 bytes.
- In my error handler, I answer with bigger body (more than 335 bytes content-length).
## To Re... | https://github.com/fastify/fastify/issues/2543 | https://github.com/fastify/fastify/pull/2546 | ee84e873ada86dd8a1ba2e1c862cf1ae4b29a25e | f458cea2d360444fd1a2ca5972e8fca6f2e07d88 | 2020-09-08T13:06:04Z | javascript | 2020-09-09T15:29:55Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,538 | ["docs/Request.md"] | definition for request hostname is incorrect | ## 🐛 Bug Report
in the docs request `hostname` is defined as providing the hostname -- which is very incorrect for [what it actually does](https://github.com/fastify/fastify/blob/f2982a245e55f6c9d0a88837434e8423db6cc0ae/lib/request.js#L74-L81).
what it actually does:
- if request.headers['x-forwared-for'] exis... | https://github.com/fastify/fastify/issues/2538 | https://github.com/fastify/fastify/pull/3325 | ad967c2cc878eea3e832503e6a081003d13df110 | c872f0b009bcdd08c5f79b42421f2432075754d2 | 2020-09-04T21:03:21Z | javascript | 2021-09-20T07:05:55Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,566 | ["docs/ContentTypeParser.md", "docs/Server.md", "fastify.js", "lib/contentTypeParser.js", "test/custom-parser.test.js"] | Import the default (json) content type parser? | #### You have already researched for similiar issues?
It's not uncommon that somebody already opened an issue or in best case it's already fixed but not merged. That's the reason why you should [search](https://github.com/fastify/fastify/issues) at first before submitting a new one.
#### What are you trying to achi... | https://github.com/fastify/fastify/issues/2566 | https://github.com/fastify/fastify/pull/2573 | 4068406b1b63ec895ef62a5e16e12430174bec17 | 4ac15542e730a4ff560e73cbd059e633c05d2106 | 2020-09-04T16:55:39Z | javascript | 2020-10-10T13:04:24Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,531 | ["fastify.js", "test/404s.test.js"] | Chaining setNotFoundHandler | `setNotFoundHandler` doesn't support chaining calls:
```
fastify
.setNotFoundHandler(function (request, reply) { })
.get('/', schema, function (req, reply) {
reply.send({ hello: 'world' })
})
```
As does `setErrorHandler` and `setValidatorCompiler` etc..
https://github.com/fastify/fastify/blob/... | https://github.com/fastify/fastify/issues/2531 | https://github.com/fastify/fastify/pull/2533 | 7369e7e3f0e881afecb5cf8854afb03edc708b83 | 87ed2a4875ed77d4c37039998ab30f88751eb661 | 2020-09-02T19:20:08Z | javascript | 2020-09-03T12:46:16Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,529 | ["test/types/reply.test-d.ts", "types/reply.d.ts", "types/route.d.ts"] | TypeScript: reply.send validates against argument's type, not route method payload's type | ## 🐛 Bug Report
If RouteShorthand method is configured with a specific Reply type, i.e.
```
interface Topics {
items: { id: string }[]
}
fastify.get<{
Reply: Topics
}>('/topics',
{ ... skipped ... },
async (request, reply) => {
reply.send({ items: [123] })
}
)
```
reply.sen... | https://github.com/fastify/fastify/issues/2529 | https://github.com/fastify/fastify/pull/2530 | ebca8b478afc6584633dc1964ed9e9830ce776c3 | 8ee4a98df4163a04e4beaaa499c809a69231261d | 2020-09-01T05:45:33Z | javascript | 2020-09-02T14:04:24Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,512 | [".github/workflows/ci.yml"] | Stop running CI on Node 13 | EOL for Node 13 was on 2020-06-01. We probably should stop running CI for it, same as we stopped running it for Node 11. Thoughts? | https://github.com/fastify/fastify/issues/2512 | https://github.com/fastify/fastify/pull/2513 | b9fcf3fae0317a54f4f32c5121d5099d1a4d0ed9 | f71adb1e7cf4ccf189328453ff4551033dae1700 | 2020-08-22T23:34:54Z | javascript | 2020-08-23T08:16:22Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,500 | ["docs/Guides/Delay-Accepting-Requests.md", "docs/Guides/Index.md"] | Improve developer experience around server listening | ## 🚀 Feature Proposal
Document or formalize notifying when the Fastify server is listening for and accepting requests.
## Motivation
I have encountered a need to know when the server is listening for and accepting requests. This is different from our `onReady` hook (which is really `onReadyToListen`). Basic p... | https://github.com/fastify/fastify/issues/2500 | https://github.com/fastify/fastify/pull/3837 | bd4914c1b85305e33b3d541bd85f4f288aad910f | c97fa0fc0d73d128ed72ddd7ba101cd0704e6162 | 2020-08-18T13:10:48Z | javascript | 2022-04-22T13:49:25Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,488 | ["README.md"] | doc: Add discord badge | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2488 | https://github.com/fastify/fastify/pull/2489 | 480d985b98c779fd8eb83f54ae0e2e728f1afa27 | 2ad4fde842b4d872c1532030c73efc1685c14eb7 | 2020-08-12T08:36:42Z | javascript | 2020-08-12T13:38:18Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,455 | ["lib/logger.js", "test/logger.test.js"] | Fastify must not mutate passed in options | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2455 | https://github.com/fastify/fastify/pull/2474 | eee6c8dac6959310703699ddee6fb512cab285c3 | e02c80f95e13d2030aab8de03863212cc9a1f4cc | 2020-08-01T18:09:59Z | javascript | 2020-08-08T13:06:45Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,462 | ["lib/route.js", "lib/schemas.js", "test/schema-feature.test.js", "test/schema-serialization.test.js"] | CORS is breaking Schemas | # 🐛 Bug Report
If I define a schema inside a plugin, `fastify-cors` breaks the application when `preflight` is enabled.
## To Reproduce
I created a simple repository showing the problem.
https://github.com/wandersonwhcr/fastify-cors-problem
## Your Environment
- *node version*: 14
- *fastify versio... | https://github.com/fastify/fastify/issues/2462 | https://github.com/fastify/fastify/pull/2463 | ff886c7c54d9de1afed4e215d174279f3ad72385 | dbfbb310cd03f46b734f8069e80181dc414942c2 | 2020-07-28T17:38:31Z | javascript | 2020-08-05T07:12:57Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,439 | ["test/types/hooks.test-d.ts", "types/hooks.d.ts"] | TypeScript: addHook'a 'onSend' callback typings | ## 🐛 Bug Report
addHook('onSend') disallows next() without arguments.
## To Reproduce
```
fastify.addHook('onSend', function (_request, reply, payload, next) {
Object.assign(reply.res, { payload })
next() // <--- error
})
```
Error:
```
Expected 1-2 arguments, but got 0.
hooks.d.ts[93... | https://github.com/fastify/fastify/issues/2439 | https://github.com/fastify/fastify/pull/2485 | 955314d4b51175952f2e62167075cfa349e33434 | c8eb3d47fe0294554e60e1d5ae643612da8f9a2b | 2020-07-27T16:07:44Z | javascript | 2020-08-12T08:03:49Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,411 | ["lib/errors.js", "lib/server.js", "test/close.test.js"] | Cannot listen on a port after closing the server. Error is misleading. | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2411 | https://github.com/fastify/fastify/pull/2415 | d06287a9a612d218d26e3a94b248b5035d5c44cb | e53abd1118a305763d75fe4c3224e42b7166608d | 2020-07-14T23:46:50Z | javascript | 2020-07-16T15:03:13Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,409 | ["test/types/request.test-d.ts", "types/request.d.ts"] | Add validationErrors property to request object when using attachValidation option |
* *fastify version*: >=3.0.2
* *os*: Linux
| https://github.com/fastify/fastify/issues/2409 | https://github.com/fastify/fastify/pull/2422 | 28881ca8f515789176e37bd6dd5bb1071a40b374 | af880ad3db6bd05468141cd4e136467ab80bfd46 | 2020-07-13T22:11:54Z | javascript | 2020-07-20T21:37:13Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,403 | ["test/types/dummy-plugin.ts", "test/types/plugin.test-d.ts", "types/register.d.ts"] | ESM-style plugin import doesn't pass TypeScript type check. | ## 🐛 Bug Report
## To Reproduce
Pick any Fastify plugin (I'll use `fastify-formbody` for now):
```js
fastify().register(import('fastify-formbody'));
```
TypeScript compiler gives the following error:
```
No overload matches this call.
Overload 1 of 3, '(plugin: FastifyPluginCallback<FastifyPluginOptio... | https://github.com/fastify/fastify/issues/2403 | https://github.com/fastify/fastify/pull/2494 | 1cf972e500f8d5ab215b2217cc133cca6bb4f269 | 102654ecd9957035fcfe58958752314c0e6ede91 | 2020-07-11T17:21:36Z | javascript | 2020-08-12T21:29:01Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,385 | ["fastify.d.ts", "test/types/reply.test-d.ts", "test/types/request.test-d.ts", "types/content-type-parser.d.ts", "types/hooks.d.ts", "types/instance.d.ts", "types/reply.d.ts", "types/request.d.ts", "types/route.d.ts", "types/utils.d.ts"] | Type `FastifyReply` body | ## 🚀 Feature Proposal
The `send` method from `FastifyReply` accepts a generic parameter `T` ([code here](https://github.com/fastify/fastify/blob/master/types/reply.d.ts#L25)), but it is not used anywhere else
Could we make that `T` parameter part of the `FastifyReply` parameters? `express` is doing something sim... | https://github.com/fastify/fastify/issues/2385 | https://github.com/fastify/fastify/pull/2389 | f5ca1fac02d61b0280f191b7019deadc20466570 | 87efb7e7d2c27d3d0e5c7c045b15edb18e95a6be | 2020-07-08T08:43:50Z | javascript | 2020-07-15T14:23:26Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,378 | ["fastify.d.ts", "test/types/fastify.test-d.ts", "test/types/plugin.test-d.ts"] | Investigate how to support `const app = fastify(); await app;` in TypeScript | Related to https://github.com/fastify/fastify/pull/2376
See the test in the PR.
How do we type this behavior?
If its not possible (which I sorta expect but don't know for sure), then we should provide some type-cast option like:
```ts
// untested code ahead do not assume this is the solution :-)
const... | https://github.com/fastify/fastify/issues/2378 | https://github.com/fastify/fastify/pull/2428 | 2a2be75309a796cbe450fdeb39e0d100c78b98d7 | 6233a8f77fd53da88ef001c4e9d4047cda8a6af0 | 2020-07-07T02:06:34Z | javascript | 2020-07-23T22:58:59Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,372 | ["docs/Reply.md"] | Unexpected cookies behaviour | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2372 | https://github.com/fastify/fastify/pull/2553 | 1ce1b308513d2f3e491d8cc2da68b25806e49760 | 875f8a3cf760f363baf1febf5eedb82d1b6da2c8 | 2020-07-05T06:20:28Z | javascript | 2020-09-14T13:31:20Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,358 | ["test/types/instance.test-d.ts", "types/instance.d.ts"] | Error: Property 'setReplySerializer' does not exist on type 'FastifyInstance' | ## 🐛 Bug Report
I'm trying to use setReplySerializer() in my Fastify-powered TypeScript project. However, an error is thrown:
`error TS2339: Property 'setReplySerializer' does not exist on type 'FastifyInstance<Server, IncomingMessage, ServerResponse, FastifyLoggerInstance>'.`
## To Reproduce
Steps to repr... | https://github.com/fastify/fastify/issues/2358 | https://github.com/fastify/fastify/pull/2400 | da021f14c37b2f9a259d5328416afeb4dcc4252b | 2495ba1d62de9ba0c289463cac0c45809a7bb87b | 2020-06-29T15:14:10Z | javascript | 2020-07-14T06:06:17Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,316 | ["package.json"] | Validate this context for fastify errorHandler | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here... | https://github.com/fastify/fastify/issues/2316 | https://github.com/fastify/fastify/pull/2198 | 457886a136aff1f60a8e2c27dfb35789a78f5b6b | a2859c03cd37904994644936fc8b400dae07da56 | 2020-06-02T19:26:42Z | javascript | 2020-04-14T07:27:35Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,298 | ["docs/Ecosystem.md"] | Asynchronous local storage support | ## 🚀 Feature Proposal
Support for AsyncLocalStorage via an official plugin. If user enables this functionality, then fastify will automatically create ALS scope for every new request that could be populated within standard hooks.
## Motivation
Certain cross-cutting functionality (logging, monitoring, authenti... | https://github.com/fastify/fastify/issues/2298 | https://github.com/fastify/fastify/pull/2324 | df40dac9b9e296c13d975c4bb47202610ba282f4 | 09fd065d41ba147726499b5f0cad9d5638b56151 | 2020-05-26T08:58:28Z | javascript | 2020-06-09T11:24:14Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,288 | ["docs/Server.md", "examples/example.js", "fastify.d.ts", "fastify.js", "test/types/fastify.test-d.ts", "test/types/route.test-d.ts", "test/url-rewriting.test.js", "types/route.d.ts"] | Possible type regression from v2 to v3 | ## 💥 Regression Report
It appears that the type definition for route handlers (`RouteHandlerMethod` in v3) no longer has a binding for `this`. I may be entirely misunderstanding the new types though; the abundance of generics is quite clever, but a little hard to quickly grasp.
## Last working version
Worked ... | https://github.com/fastify/fastify/issues/2288 | https://github.com/fastify/fastify/pull/2290 | 8b8485ac5ff56d1ead387f6dd76384f996a2cf8e | 4f3a945871060365117b7ce8eb5d3fb4fd178fef | 2020-05-19T13:49:51Z | javascript | 2020-05-25T13:20:13Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,279 | ["fastify.js", "test/schema-feature.test.js"] | Can't getSchema() even though getSchemas() "has it" | ## 🐛 Bug Report
Schema added inside plugin can't be fetched using getSchema('someid')
## To Reproduce
Steps to reproduce the behavior:
```js
fastify.addSchema({
$id: 'http://example.com/',
type: 'object',
properties: {
hello: { type: 'string' }
}
})
console.log('1 getSchemassssss()', fa... | https://github.com/fastify/fastify/issues/2279 | https://github.com/fastify/fastify/pull/2280 | 2f56e10a24ecb70c2c7950bfffd60eda8f7782a6 | 425b68e71c3f88cd16e45b831c6cf017d95bbefa | 2020-05-14T13:48:15Z | javascript | 2020-05-14T19:44:02Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,265 | ["README.md"] | Remove absolute URL | In our docs, there are some link that refers to `master`
Like https://raw.githubusercontent.com/fastify/fastify/master/docs/Server.md
```
<a href="https://github.com/fastify/fastify/blob/master/docs/Server.md"><code><b>Fastify server</b></code></a>
```
I think we should update all those links to relative ones ... | https://github.com/fastify/fastify/issues/2265 | https://github.com/fastify/fastify/pull/2274 | 15703f51109d0381e6abed1c4c226f25ceefc4d0 | 82a081dfea3b065492df435cff3d695a36ceb60c | 2020-05-06T17:54:19Z | javascript | 2020-05-12T14:26:55Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,259 | ["fastify.js", "test/inject.test.js"] | `started` flag for fastify no longer set in v3 on ready() | ## 🐛 Bug Report
In v3 running `fastify.ready()` no longer sets `fastify[kState].started` to `true`. This results in `lightMyRequest` Chain returned for a builder to be wrapped into a Promise and prematurely resolved, failing with an error.
## To Reproduce
Steps to reproduce the behavior:
https://github.com/f... | https://github.com/fastify/fastify/issues/2259 | https://github.com/fastify/fastify/pull/2257 | a60391e9b6b7b516e24d18f0c5a437db28989ff8 | 09170fe41777ddf821179c4aef60d434d6de1efb | 2020-05-05T15:06:29Z | javascript | 2020-05-05T20:52:52Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,229 | ["docs/Reply.md", "docs/Server.md", "lib/handleRequest.js", "lib/reply.js", "test/404s.test.js"] | reply.callNotFound not triggering hooks | <!--
Before you submit an issue we recommend you visit [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If you ignore these instructions
and post an issue here tha... | https://github.com/fastify/fastify/issues/2229 | https://github.com/fastify/fastify/pull/2256 | 1cdf6219ca4ebb015c926f5c467b1bf7b6c88c67 | ae6b57c94cbfcec10b66c4a19d8a62df540486c1 | 2020-04-25T18:16:30Z | javascript | 2020-05-06T13:28:47Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,223 | ["test/types/route.test-d.ts", "types/reply.d.ts"] | reply.statusCode is not defined in TS type definitions |
## 🐛 Bug Report
Docs & implementation have a prop `statusCode`, which isn't available via `FastifyReply<HttpResponse>` definition.
Docs: https://www.fastify.io/docs/latest/Reply/#statuscode
Definitions: https://github.com/fastify/fastify/blob/64296c84b57eb8f6f63bf51579febcfd274a97a5/types/reply.d.ts#L8 | https://github.com/fastify/fastify/issues/2223 | https://github.com/fastify/fastify/pull/2224 | 28fcb5f9438e85031265a9b0ba60bb01791db010 | 2e9994d1c3cb0c61424d624674ec517360542c26 | 2020-04-23T11:39:08Z | javascript | 2020-04-24T09:38:50Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,214 | ["lib/reply.js", "test/content-length.test.js"] | Error with `content-lenght` header | ## 🐛 Bug Report
If in a async handler, an error is thrown and `headers` property contains `content-length` key, the response header `content-length` doesn't match the real response body length
## To Reproduce
```js
'use strict'
const assert = require('assert')
const fastify = require('./fastify')({ log: { ... | https://github.com/fastify/fastify/issues/2214 | https://github.com/fastify/fastify/pull/2215 | 121f32a46b9f3d4df2be4e81ea9427386c37eb14 | 6e8035201b07b5a7a7fe2c7722652d50c37e07bb | 2020-04-22T12:02:56Z | javascript | 2020-04-22T13:51:19Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,203 | ["docs/Hooks.md", "lib/context.js", "lib/hooks.js", "lib/route.js", "test/hooks.test.js", "test/types/hooks.test-d.ts", "types/hooks.d.ts", "types/instance.d.ts", "types/route.d.ts"] | Add an onTimeout hook | ## 🚀 Feature Proposal
There are hooks for most events in a request's lifecycle, but I believe that a request that times out doesn't go through the onError or onResponse hooks, so there currently isn't any way to respond to timeouts. This feature proposal is adding an onTimeout hook (or something similar) that woul... | https://github.com/fastify/fastify/issues/2203 | https://github.com/fastify/fastify/pull/2457 | 21578f56dea6bfd3de1c9a4df497fd535d174221 | 8e2d008c450b29b39aff8aa127e0ed7a10775988 | 2020-04-14T18:49:58Z | javascript | 2020-08-06T12:35:44Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,169 | ["lib/errors.js", "lib/reply.js", "test/reply-error.test.js"] | Fastify crashes when reply code is not recognized | ## 🐛 Bug Report
Fastify crashes when reply code is not recognized.
## To Reproduce
Steps to reproduce the behavior:
Run fastify server that returns an exotic response code.
```js
const fastify = require('fastify')({ logger: true });
fastify.get('/', async (request, reply) => {
reply.code(525); //... | https://github.com/fastify/fastify/issues/2169 | https://github.com/fastify/fastify/pull/2184 | 08e0a0443cbdd432c87cc0cfaf8f10d54e42ff45 | 8ba959d67c5bc3782eec891cc44bdc1c8ce5d641 | 2020-04-01T05:50:48Z | javascript | 2020-04-08T09:24:29Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,117 | ["docs/Decorators.md"] | Add docs for explaining the concept of object shapes | Using the decorator defines the shape of request objects. See https://mathiasbynens.be/notes/shapes-ics
_Originally posted by @jsumners in https://github.com/fastify/fastify/issues/2115#issuecomment-590562376_ | https://github.com/fastify/fastify/issues/2117 | https://github.com/fastify/fastify/pull/2127 | ba9086b163ea0e9ac3b4a4ec935cb8e4b64fea6d | 2874af53002dd9fde9ab24e74b90121cb86bc62d | 2020-02-25T13:31:02Z | javascript | 2020-03-08T02:05:08Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,116 | ["lib/decorate.js", "lib/errors.js", "test/decorator.test.js", "test/internals/decorator.test.js"] | Make decorate* methods throw after server is started. |
## 🚀 Feature Proposal
In https://github.com/fastify/fastify/issues/2115, the reporter is trying to decorate the global request object within a route. This is not supported by Fastify, and we should throw if `server.decorate()`, `server.decorateRequest()` or `server.decorateReply()` are called after `.ready()`.
| https://github.com/fastify/fastify/issues/2116 | https://github.com/fastify/fastify/pull/2128 | 2874af53002dd9fde9ab24e74b90121cb86bc62d | 512561f9b868d5ebc5b3cdf9016bf73ae07304ad | 2020-02-24T19:21:03Z | javascript | 2020-03-08T21:16:10Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,112 | ["lib/route.js", "test/http2/plain.js"] | request.hostname isn't set when using HTTP2 | ## 🐛 Bug Report
`request.hostname` isn't set when using HTTP2.
## To Reproduce
`index.js`:
```js
module.exports = async function (fastify, opts) {
fastify.get('/', async (req, r) => r.send(`hostname: ${req.hostname}\n`));
};
module.exports.options = { http2: true };
```
## Expected behavior
Ru... | https://github.com/fastify/fastify/issues/2112 | https://github.com/fastify/fastify/pull/2113 | 6f79a90703078451f4571ac3e08b815a26753503 | 093947b75dfbb5da784c3714550d4d7ecf9a340f | 2020-02-24T00:37:54Z | javascript | 2020-02-24T12:10:14Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,104 | ["lib/schemas.js", "lib/symbols.js", "test/hooks.test.js", "test/route.test.js"] | PR-2044 (one schema for multiple routes) introduce breaking change behavior on routes schema resolve. | ## 💥 Regression Report
PR https://github.com/fastify/fastify/pull/2044 breaks https://github.com/SkeLLLa/fastify-oas and probably related to https://github.com/fastify/fastify-swagger/issues/224
Consider you have fastify onRoute hook and save the routes like
```js
const myRouteData = []
fastify.addHook('o... | https://github.com/fastify/fastify/issues/2104 | https://github.com/fastify/fastify/pull/2108 | 98ca7fd538c1f2ebc0ee5d71272d9dcd3f34601b | 6f79a90703078451f4571ac3e08b815a26753503 | 2020-02-18T11:46:07Z | javascript | 2020-02-23T17:23:27Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,078 | ["lib/errors.js", "lib/reply.js", "test/reply-error.test.js"] | Truncated error response when using reply.code(undefined) | ## 🐛 Bug Report
When setting the response status code to `undefined` inside error handler, response returned is truncated.
This bug was unveiled while working on an issue with `fastifh-gql` [default error handler](https://github.com/mcollina/fastify-gql/blob/174ebb5185e0377acefcac0b0c638b3a575e61e3/lib/routes.js... | https://github.com/fastify/fastify/issues/2078 | https://github.com/fastify/fastify/pull/2082 | 14b4e02d3648355987568eccf328a7111558c1b2 | 41cd02fe81f8895ee7fe9de6579ac39438465776 | 2020-02-03T10:16:38Z | javascript | 2020-02-13T19:35:02Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,075 | ["docs/Hooks.md", "test/hooks-async.js", "test/hooks.test.js"] | Use symbol to denote early termination of request | ## 🚀 Feature Proposal
Introduce `Symbol.for('fastify.end-request')` to terminate requests prior to reaching the defined request handler. When this symbol is received from a hook, or any function in the request life _prior_ to the defined request handler, Fastify should issue a `res.send()` that sends any headers an... | https://github.com/fastify/fastify/issues/2075 | https://github.com/fastify/fastify/pull/2079 | c052c21db4b1d8b80eafd3435a6ba4ccdc9f97f8 | aacefcde84334edc0feeb335807bd530a2bcff19 | 2020-02-02T17:19:26Z | javascript | 2020-02-06T18:05:37Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,070 | ["docs/Errors.md", "lib/errors.js", "lib/hooks.js", "test/hooks.test.js"] | Promise rejection without error |
## 🐛 Bug Report
If an async hook returns a `Promise.reject()` the flow continue.
This usage of promise should be avoided at all, let me know if you think this is an `invalid` bug.
Here we should check the `err` param
https://github.com/fastify/fastify/blob/7fa4bddca07aac18e0600cff40d97b95a96ab970/lib/hooks.j... | https://github.com/fastify/fastify/issues/2070 | https://github.com/fastify/fastify/pull/2074 | 6b3987003fea822feee9eb559e009efbb177ff67 | c052c21db4b1d8b80eafd3435a6ba4ccdc9f97f8 | 2020-01-31T21:19:42Z | javascript | 2020-02-03T21:11:06Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,065 | ["docs/Errors.md", "lib/handleRequest.js", "test/error-in-post.test.js", "test/sync-routes.test.js"] | Support synchronous routes |
## 🚀 Feature Proposal
I propose we call `reply.send()` in synchronous routes if the returned value is not Promise or a Stream.
## Motivation
It seems a lot of newbies to fastify mistake the use of `async`, and we are not providing them a good developer experience.
## Example
```js
'use strict';
mo... | https://github.com/fastify/fastify/issues/2065 | https://github.com/fastify/fastify/pull/2073 | 798f18526d6199b505141724a6c6ed2804bb80fd | 3486afe04a05c0874c63010f7525361a316905fe | 2020-01-30T14:58:50Z | javascript | 2020-02-06T18:06:13Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,040 | ["fastify.d.ts", "test/types/hooks.test-d.ts", "test/types/route.test-d.ts", "types/hooks.d.ts", "types/instance.d.ts", "types/middleware.d.ts", "types/route.d.ts"] | v3 type def clarification for `addHook` method | I've been fixing the `hooks.d.ts` part of the new types and I've hit a very difficult snag. We have two hooks `onSend` and `preSerialization` that pass through the `payload` argument to the hook handler. For best type safety, we should allow the user to specify what this is via a generic parameter. But because all of t... | https://github.com/fastify/fastify/issues/2040 | https://github.com/fastify/fastify/pull/2042 | b9a6a041d1dfc341600abe16f6ec309f0386c402 | aadefb2e5c4451452c03573e0c8e844812864b19 | 2020-01-15T17:10:05Z | javascript | 2020-03-19T21:56:36Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,036 | ["docs/Server.md", "fastify.js", "test/request-error.test.js"] | fastify behind haproxy results into "read ECONNRESET" errors | ## 🐛 Bug Report
As mentioned in https://github.com/fastify/fastify/blob/master/docs/Recommendations.md we would like to run fastify behind haproxy (for TLS termination and load balancing)
After processing an request proxied over haproxy it throws an ECONNRESET error:
```
{"level":30,"time":1578524093038,"pid... | https://github.com/fastify/fastify/issues/2036 | https://github.com/fastify/fastify/pull/2268 | d335a7a729c0bbba4a3ae0fbe08254fd410f86ea | d8feb2323c00d49a16b48401a2f7e8fcfbbb0338 | 2020-01-09T08:31:41Z | javascript | 2020-05-08T13:05:43Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,030 | ["fastify.d.ts", "test/types/index.ts"] | Add generic parameter for Reply send method | Based on a discussion in https://github.com/fastify/help/issues/125 a good feature for the type system (current and future) would be to add a generic parameter to the `reply.send` method to allow the user to specify the payload type being passed in. It is currently set to `any` see [v2](https://github.com/fastify/fasti... | https://github.com/fastify/fastify/issues/2030 | https://github.com/fastify/fastify/pull/2032 | 620a7a073b8eca1d7be5cae22fad6e7f9348623b | e6c63c33327084b6feaac147ab6e82d5d0ae47b9 | 2020-01-07T21:19:09Z | javascript | 2020-01-08T17:39:12Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 2,024 | ["lib/schemas.js", "test/route.test.js"] | I cant use one schema for two different routes | 🐛 Bug Report
when I want too set my schema to different routs I get this error
FastifyError [FST_ERR_SCH_DUPLICATE]: FST_ERR_SCH_DUPLICATE: Schema with 'querystring' already present!
## To Reproduce
create a schema with query and add it to different routes
```js
this is my schema
"sportSite_sportSiteS... | https://github.com/fastify/fastify/issues/2024 | https://github.com/fastify/fastify/pull/2044 | 5258f421a32592396d9e9999812f6c6096ccf6db | 62f21b1211dab665cccca4dec966169ae548ba1b | 2020-01-05T13:20:44Z | javascript | 2020-01-18T11:34:40Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,993 | ["lib/handleRequest.js", "test/http2/head.test.js", "test/internals/handleRequest.test.js"] | Under Nodejs v13.5.0, Fastify HTTP2.0 use .finished which could be true when .writableEnded is false | Maybe it is a nodejs bug, but in handleRequest.js:
function preValidationCallback (err, request, reply) {
if (reply.sent === true || reply.res.**finished** === true) return
if (err != null) {
reply.send(err)
return
}
...
function preHandlerCallback (err, request, reply) {
if (reply.sent || repl... | https://github.com/fastify/fastify/issues/1993 | https://github.com/fastify/fastify/pull/2233 | 4f88ce7034597199ed4b5e6c76819cfd80e6d487 | a0b5673447de3451e43ef46960045ce352b4ae32 | 2019-12-19T04:12:52Z | javascript | 2020-04-27T10:12:24Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,973 | ["package.json"] | Use Pino v6 | In fastify v3 we will use Pino v6. | https://github.com/fastify/fastify/issues/1973 | https://github.com/fastify/fastify/pull/2163 | f1cfcadbe201f98137a5b2a9ee1159215b5d81e5 | f40ca9729eec4d8632fd3397b691a31c0ad3c671 | 2019-12-09T09:23:22Z | javascript | 2020-03-28T14:37:39Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,970 | ["docs/Hooks.md", "fastify.js", "lib/hooks.js", "lib/route.js", "lib/symbols.js", "test/hooks.test.js"] | new scope for fastify plugin | ## 💬 Questions and Help
I try to encapsule the rate-limit plugin to its own fastify instance.
```js
const fastify = require("fastify");
const fastifyRateLimit = require("fastify-rate-limit");
const ioredis_1 = require("ioredis");
const server = fastify();
const start = async () => {
server.get('/', asy... | https://github.com/fastify/fastify/issues/1970 | https://github.com/fastify/fastify/pull/2004 | 747311e820b2c964b2d01dadbcba425617787065 | 80d87c959fcbb2ae00295bebbd1d912c97f64184 | 2019-12-08T15:08:57Z | javascript | 2019-12-27T16:02:46Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,960 | ["lib/route.js", "package.json", "test/route.test.js", "test/schemas.test.js"] | Schema and route declaration order conflict. | ## 🐛 Bug Report
Initially opened at https://github.com/fastify/fastify-cors/issues/47 because upgrading the cors plugin caused shared schemas to fail. I looped through the debugger many times and I think I found the issue.
This was because the `fastify-cors` plugin starting from version 2.2.0 added a default lin... | https://github.com/fastify/fastify/issues/1960 | https://github.com/fastify/fastify/pull/2077 | a272f153946fbe5134ff2d55d1e9526967e0ad41 | 0b50f38df033ae112d5043cdf21297c7562f608e | 2019-11-28T16:38:42Z | javascript | 2020-03-02T09:04:59Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,914 | ["test/types/hooks.test-d.ts", "test/types/instance.test-d.ts", "test/types/route.test-d.ts", "types/error.d.ts", "types/hooks.d.ts", "types/instance.d.ts"] | TypeScript FastifyError inherits from Error instead of ErrnoException | ## 🐛 Bug Report
`FastifyError` inherits from `Error` (JavaScript type), but it can hold other properties as `NodeJS.ErrnoException` (Node.js Error type) defined.
`ErrnoException` in:
Node.js v6:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/v6/base.d.ts#L327
Node.js v8: https:/... | https://github.com/fastify/fastify/issues/1914 | https://github.com/fastify/fastify/pull/2337 | 68f1ac6b727d938287d5d8dba114ea8c8c63f4ee | 25d7ba2b86d00dd68c4bbb5648ee3706a6b8dafe | 2019-10-24T13:41:50Z | javascript | 2020-06-18T19:21:02Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,900 | ["README.md"] | Fluent Schema not shown in documentations? | Before you submit an issue we recommend you drop into the [Gitter community](https://gitter.im/fastify) or [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If yo... | https://github.com/fastify/fastify/issues/1900 | https://github.com/fastify/fastify/pull/1903 | 3991088b4b22fb04263d197eb271973390f28e6a | 7f8c3f2ba7c7f01cd24397976e545dd57e924d47 | 2019-10-17T23:26:00Z | javascript | 2019-10-19T19:30:36Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,884 | ["fastify.js", "package.json", "test/404s.test.js"] | 404 with not encoded URI path parameter | ## 🐛 Bug Report
If I send a wrong path parameter without appling an `encodedURI` I get a 404 response and a warn:
```
{"level":30,"time":1570179820901,"pid":21956,"hostname":"MSPIGOLON5591","reqId":3,"req":{"method":"GET","url":"/%25what%","remotePort":53476},"msg":"incoming request","v":1}
{"level":40,"time":... | https://github.com/fastify/fastify/issues/1884 | https://github.com/fastify/fastify/pull/1888 | 7c4c7d64ee84655cfa00d34e450404cf10145662 | 11d286e4cab57d466b58385ee7a091abcc5348cc | 2019-10-04T09:08:15Z | javascript | 2019-10-26T10:11:30Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,881 | ["fastify.d.ts", "lib/schemas.js", "package.json", "test/schemas.test.js", "test/types/index.ts"] | Broken JSON Schema resolution | ## 🐛 Bug Report
When using a reference to a full schema definition, instead of to a sub resource of the referenced schema, Fastify's schema resolution incorrectly mutates the reference name. The result is that it cannot find the referenced schema.
## To Reproduce
Steps to reproduce the behavior:
Paste your... | https://github.com/fastify/fastify/issues/1881 | https://github.com/fastify/fastify/pull/1882 | 89dd7493c06774600635b010ebac6a622bfd42f2 | f199f9ff8723d7c04b93c6db3a941f675365d75b | 2019-10-01T18:15:47Z | javascript | 2019-10-05T16:04:10Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,871 | ["lib/schemas.js", "test/internals/schemas.test.js"] | Creates invalid schema | ## 🐛 Bug Report
Fastify with fastify-swagger creates invalid swagger schema. It should not contain $id fields.
## To Reproduce
https://repl.it/repls/HoarseCoolEditor
And you'll got
```json
...
"paths": {
"/first": {
"get": {
"responses": {
... | https://github.com/fastify/fastify/issues/1871 | https://github.com/fastify/fastify/pull/1872 | 72451e901227048707fff157df6abeab6d5e23a8 | 5c00909721c16ceafae46da9378017a401ed96be | 2019-09-25T11:22:47Z | javascript | 2019-09-25T15:36:26Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,870 | [".github/workflows/ci.yml"] | Coveralls GH action posts too many comments | Currently, the coveralls GitHub action is posting too many comments in the pull request. I've checked our coveralls configuration, and the comments are disabled. I'm not even sure that problem is caused by the [coveralls GitHub action](https://github.com/coverallsapp/github-action).
A couple of examples of pr with t... | https://github.com/fastify/fastify/issues/1870 | https://github.com/fastify/fastify/pull/1918 | 16173896d42ce34f7af5d702587d9487762cf444 | d0e78d16d151db402332386127385fed8541a9cb | 2019-09-24T08:20:12Z | javascript | 2019-11-02T21:07:16Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,864 | ["docs/Reply.md", "docs/Routes.md", "lib/reply.js", "test/async-await.js", "test/internals/reply.test.js", "test/promises.test.js"] | Async style with reply.send | ## 🐛 Bug Report
`repl.send` inside an async function has created a lot of headache.
- https://github.com/fastify/fastify/issues/238
- https://github.com/fastify/fastify/issues/238
- https://github.com/fastify/fastify/issues/548
- https://github.com/fastify/fastify/issues/1131
with https://github.com/fastif... | https://github.com/fastify/fastify/issues/1864 | https://github.com/fastify/fastify/pull/1869 | 5a61f3e0b163bfa51df846e29cce6519c94ef5ee | 0e39b83c3bde8a9cb6531ad2dbe960be75199e1d | 2019-09-21T08:30:37Z | javascript | 2019-09-25T12:01:49Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,855 | ["docs/Server.md", "docs/Validation-and-Serialization.md", "fastify.js", "lib/errors.js", "lib/handleRequest.js", "lib/route.js", "lib/schemas.js", "lib/symbols.js", "lib/validation.js", "test/schemas.test.js"] | Using custom AJV breaks resolving references | ## 🐛 Bug Report
When using a custom AJV instance as described in the documentation (https://www.fastify.io/docs/latest/Validation-and-Serialization/#schema-compiler) one cannot provide a schema with references as a response schema.
## To Reproduce
```js
'use strict';
const AJV = require('ajv');
const ajv... | https://github.com/fastify/fastify/issues/1855 | https://github.com/fastify/fastify/pull/1858 | 27ff97cad56f01d5b5bcb71c0b919a04ae0b3a6a | 4cf5c338edcdece7272f9935da91e6b1080eb190 | 2019-09-17T21:05:21Z | javascript | 2019-09-27T08:55:30Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,847 | [".github/workflows/ci.yml", ".github/workflows/package-manager-ci.yml", ".github/workflows/website.yml", ".travis.yml", "README.md", "docs/LTS.md"] | Leverage Github Actions |
## 🚀 Feature Proposal
We have Github Actions enabled in this repo! What can we do with them?
One thing that would be nice is to move the trigger to CircleCI for deploying the website.
Moreover, we can actually redo the automation for the [website](https://github.com/fastify/website) using actions!
@lmammino ... | https://github.com/fastify/fastify/issues/1847 | https://github.com/fastify/fastify/pull/1853 | d50e173c6ca46a43c2b357de759cdf793ed6a1ee | 03d2408a2d910df2a4625c590fe15ee1ae0e277a | 2019-09-10T16:38:55Z | javascript | 2019-09-20T13:31:53Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,823 | ["lib/fourOhFour.js", "test/404s.test.js", "test/logger.test.js", "test/route-prefix.test.js"] | Do not create an Error for the default 404 route |
## 🚀 Feature Proposal
Creating an `Error` is costly, and we should be able to avoid that in https://github.com/fastify/fastify/blob/d48c6a21f21d72b7683808aa88b3fdcd2e0478db/lib/fourOhFour.js#L53. Moreover, it complicates debugging (see #1822 for details).
| https://github.com/fastify/fastify/issues/1823 | https://github.com/fastify/fastify/pull/1826 | 05c0329cce02d3124e868d13c4072b9c6c9981ad | 76c8879a07aa221f98aa9df89cfdac7ad844c521 | 2019-08-26T09:21:15Z | javascript | 2019-08-28T13:05:59Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,776 | ["lib/handleRequest.js", "package.json", "test/hooks-async.js"] | async preValidation hook does not abort request | ## 🐛 Bug Report
When calling `reply.send` within an async preValidation hook, this does not abort the request and thus emits a `Response has already been sent` error. Related: #677
According to the linked issue and pr, it should have been fixed, however it doesn't seem to be (At least for me):
## To Reproduce... | https://github.com/fastify/fastify/issues/1776 | https://github.com/fastify/fastify/pull/1778 | b856f07facb6667d8e34e6e352d76a0c53b452f9 | 2996fd83042084a2ecccc38b6fa123ec87546eec | 2019-07-30T07:39:42Z | javascript | 2019-07-31T07:59:03Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,733 | ["lib/handleRequest.js", "package.json", "test/hooks-async.js"] | Lifecycle is not interrupted when onSend executes asynchronously | ## 🐛 Bug Report
When an instance `onSend` hook executes asynchronously, responding from a route hook does not always prevent the route handler from being called.
## To Reproduce
#### Setup
1. `npm init -y && npm i -S fastify@2.6.0`
2. Add the code from [this gist](https://gist.github.com/ericmacfa/e5331... | https://github.com/fastify/fastify/issues/1733 | https://github.com/fastify/fastify/pull/1778 | b856f07facb6667d8e34e6e352d76a0c53b452f9 | 2996fd83042084a2ecccc38b6fa123ec87546eec | 2019-07-05T15:39:44Z | javascript | 2019-07-31T07:59:03Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,680 | ["docs/Reply.md"] | Error thrown from a hook is not propagating to custom error handler | If you throw an error from a hook it is not propagated to the custom error handler.
## To Reproduce
```js
const fastify = require('fastify')();
fastify.setErrorHandler(async (error, request, reply) => {
console.log("Im in error handler", error);
reply.code(401).send({ error });
});
fastify.addHook("... | https://github.com/fastify/fastify/issues/1680 | https://github.com/fastify/fastify/pull/2126 | a8d5448862bcff5c616ac863d73e2b3f2e00d6e6 | ba9086b163ea0e9ac3b4a4ec935cb8e4b64fea6d | 2019-05-30T14:33:41Z | javascript | 2020-03-07T17:14:05Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,672 | ["lib/route.js", "test/route-prefix.test.js"] | Setting ignoreTrailingSlash and prefixTrailingSlash prevents avvio from throwing an error | ## 🐛 Bug Report
Setting `ignoreTrailingSlash: true` on main Fastify instance and registering a plugin with tralingSlash prefixed path (`prefix: '/attendances/'`), prevents avvio from crashing on startup with `AssertionError [ERR_ASSERTION]: Method 'GET' already declared for route '/v1/attendances/'` error.
As y... | https://github.com/fastify/fastify/issues/1672 | https://github.com/fastify/fastify/pull/1675 | fc52dc3813dec514b8bb374660818e0a52ec13b6 | ecea232ae596fd0eb06a5b38080e19e4414bd942 | 2019-05-24T13:22:14Z | javascript | 2019-06-04T15:36:31Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,668 | ["docs/TypeScript.md", "fastify.d.ts", "types/instance.d.ts", "types/plugin.d.ts", "types/register.d.ts", "types/reply.d.ts", "types/request.d.ts"] | TypeScript Schema Example Documentation | ## 🚀 Feature Proposal
The upcoming type refactor #1569 references a documentation example of how to declare strict schema types. This issue will track that documentation addition. (It'll also be the start to the next stage of v3 types which is improving the TS docs and examples).
## Motivation
TypeScript supp... | https://github.com/fastify/fastify/issues/1668 | https://github.com/fastify/fastify/pull/1966 | feb0bb6d3cf338fca35ced347d904e7a6a45eafa | f7bc276008b85215e4901ad271cf29dea69c8af4 | 2019-05-23T16:54:12Z | javascript | 2020-03-29T14:33:32Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,667 | ["fastify.d.ts", "test/types/index.ts"] | TypeScript RouteOptions interface generics missing defaults | ## 🐛 Bug Report
Working with routes definition I found that `RouteOptions` interface hasn't default generics declared. (https://github.com/fastify/fastify/blob/master/fastify.d.ts#L266) as opposed to `RouteShorthandOptions`(https://github.com/fastify/fastify/blob/master/fastify.d.ts#L230) that it extends from.
Is... | https://github.com/fastify/fastify/issues/1667 | https://github.com/fastify/fastify/pull/1669 | 712337d6be084b8fc6dca88923eb9cbe6c205b13 | 1958c74a2bc2e96d3892254904f485985bc57330 | 2019-05-23T15:07:46Z | javascript | 2019-05-24T13:29:37Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,662 | [".npmignore"] | Git folder was included in v2.4.0 | Hi!
In v2.4.0 NPM package `.git` folder was included and this can cause 2 issue
- Security issue (may be?)
- Installation fails (after installing fastify v2.4.0)
You can see direct NPM folder online at [here](https://unpkg.com/fastify@2.4.0/)
Have a nice day! | https://github.com/fastify/fastify/issues/1662 | https://github.com/fastify/fastify/pull/1663 | a6fa039939ee9f9317f9ef7739f265e45f2427b2 | 5d442c54970797a985eaad981abca2342eae23f9 | 2019-05-22T09:20:17Z | javascript | 2019-05-22T09:37:38Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,658 | [".npmignore", ".travis.yml", "README.md", "docs/LTS.md"] | Remove Travis CI from next branch | As title says. I think the azure-pipelines CI is much better than Travis; I see no reason to continue using the service going forward. | https://github.com/fastify/fastify/issues/1658 | https://github.com/fastify/fastify/pull/1670 | 05ed74244d6050aaa87a615df7e9c6f8506e20df | 98658080df2d1d26b45d8752958399d2eac48707 | 2019-05-19T19:05:25Z | javascript | 2019-06-01T21:01:11Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,656 | ["fastify.js", "test/route-hooks.test.js"] | Make logs (errors, warnings) useful | Before you submit an issue we recommend you drop into the [Gitter community](https://gitter.im/fastify) or [Fastify Help](https://github.com/fastify/help) and ask any questions you have or mention any problems you've had getting started with Fastify.
**Please read this entire template before posting any issue. If yo... | https://github.com/fastify/fastify/issues/1656 | https://github.com/fastify/fastify/pull/1657 | dd059016134f97fa8b8509e373dbc0b8194455a4 | 1f3c0de979ed8e6edf2e30c9a8594d85d4299ee9 | 2019-05-18T09:38:19Z | javascript | 2019-05-19T10:13:14Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,652 | ["package.json"] | An in-range update of flatstr is breaking the build 🚨 |
## The dependency [flatstr](https://github.com/davidmarkclements/flatstr) was updated from `1.0.11` to `1.0.12`.
🚨 [View failing branch](https://github.com/fastify/fastify/compare/master...fastify:greenkeeper%2Fflatstr-1.0.12).
This version is **covered** by your **current version range** and after updating it in y... | https://github.com/fastify/fastify/issues/1652 | https://github.com/fastify/fastify/pull/1653 | f627bbf5b35bfb9f5d91f8d3a83275f1f437e616 | 6e4e662bc51c8e5dd5aa960efb8575e183fd7e6a | 2019-05-16T15:15:20Z | javascript | 2019-05-16T19:34:26Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,620 | ["package.json"] | Cannot access with ip | `localhost:8080` can work but `[ipv4]:8080`.
Express.js can work properly. | https://github.com/fastify/fastify/issues/1620 | https://github.com/fastify/fastify/pull/4581 | c6a40ebe3ec9aaa2886d8ba7646fea88559412f6 | 2e9526e6245421570a5ef54d3676421f617dc4d7 | 2019-04-30T08:07:19Z | javascript | 2023-02-13T15:35:50Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,592 | ["docs/Reply.md"] | set status code to 302 on res.redirect by default. | ## 🚀 Feature Proposal
Right now fastify `redirect` method set the status code only to `302` when it's not set before. I would like to have this changed and make it act like `express` does. What express does is: set the status code to `302` when `redirect` is called. You can still sent an other code by providing it ... | https://github.com/fastify/fastify/issues/1592 | https://github.com/fastify/fastify/pull/2121 | a378dd583dfc2ae0f705e09b449aa6a636c639b2 | 350f00b6bf508b40c1f6bb5fa1a9e81b1b09ef3a | 2019-04-13T01:38:32Z | javascript | 2020-02-28T11:38:34Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,587 | ["docs/Hooks.md", "fastify.js", "lib/fourOhFour.js", "lib/hooks.js", "lib/route.js", "test/hooks-async.test.js"] | Enable to set all hooks (including .use middlewares) in route() | ## 🚀 Feature Proposal
Currently we do not expose an API to add `onRequest` and route specific middlewares, however our codebase can definitely support them. Adding them would ensure an higher level of flexibility combined with the new `onRoute` hook.
Missing things:
* [x] `onRequest` - done in https://github... | https://github.com/fastify/fastify/issues/1587 | https://github.com/fastify/fastify/pull/2005 | f47b3d2e174d71c2443c9425cb3eddf7f63815fb | 747311e820b2c964b2d01dadbcba425617787065 | 2019-04-10T11:38:47Z | javascript | 2019-12-27T11:56:20Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,560 | ["lib/initialConfigValidation.js", "test/internals/initialConfig.test.js"] | Azure Pipeline Failing | ## 💥 Regression Report
Branch master
Azure says:
> should be equal
Error: should be equal
at Test.t (test/internals/initialConfig.test.js:154:7)
at loop (node_modules/function-loop/index.js:46:15)
Travis agree but says more:
> test/internals/initialConfig.test.js ................ 58/59
Ret... | https://github.com/fastify/fastify/issues/1560 | https://github.com/fastify/fastify/pull/1561 | 9ee4ecda4f953376fa3143d46bf3ab1d6da8acb1 | fc388633f6e1f5e250f06ee41bcfa0650c10ccdd | 2019-03-29T08:00:44Z | javascript | 2019-03-29T09:34:34Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,553 | ["lib/schemas.js", "test/shared-schemas.test.js"] | Server.close() mutates used shared schemas | ## 🐛 Bug Report
I've encountered this super weird bug. It seems that if you use a shared schema in an endpoint schema, then shut down the server, the shared schema will get mutated somehow :man_shrugging:
## To Reproduce
```js
const t = require("tap");
const fastify = require("fastify");
const sharedSc... | https://github.com/fastify/fastify/issues/1553 | https://github.com/fastify/fastify/pull/1565 | d98629b36b5dedfaa9385c99f9c913f2fe6ad944 | 5de74406dbff5cba90516f6c9f499ea9d5e70e1b | 2019-03-24T23:15:40Z | javascript | 2019-04-03T19:19:51Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,551 | ["docs/Logging.md", "docs/Request.md", "lib/context.js", "lib/logger.js", "lib/reply.js", "lib/request.js", "lib/route.js", "test/internals/handleRequest.test.js"] | Logger: serialize Fastify objects instead of Node.js | Since Fastify v2 we can access our `Request` and `Reply` objects anywhere, it could be a useful enhancement *(unfortunately it is a breaking change)* update our logger serializers to handle our objects instead of Node.js core ones.
Thoughts?
Related: https://github.com/fastify/fastify/issues/1548
/cc @fastify/... | https://github.com/fastify/fastify/issues/1551 | https://github.com/fastify/fastify/pull/2017 | 94bcf373cf5ff05fda5dddfb31b480b6e2f7d7ca | 8f210861cfe8f49c601ae57605933bf6851c648e | 2019-03-23T13:23:51Z | javascript | 2020-01-03T17:28:58Z |
closed | fastify/fastify | https://github.com/fastify/fastify | 1,542 | ["docs/Server.md"] | Update Server#logger to discuss custom logger option | The [Server#logger](https://www.fastify.io/docs/latest/Server/#logger) doc section lists 3 options for the logger server option. I believe the `pinoInstance` option should be expanded (or a new, 4th option should be added) to tell the user they can define or use their own custom logger as long as it follows the rules s... | https://github.com/fastify/fastify/issues/1542 | https://github.com/fastify/fastify/pull/1577 | c79d90e3a9762723509f25955649580e80eb5b68 | 62dc95651f2725a14ead5805d48af4594570fc5c | 2019-03-15T06:00:35Z | javascript | 2019-04-12T20:35:48Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.