id int64 1.14B 2.23B | labels_url stringlengths 75 75 | body stringlengths 2 33.9k ⌀ | updated_at stringlengths 20 20 | number int64 3.76k 6.79k | milestone dict | repository_url stringclasses 1 value | draft bool 2 classes | labels listlengths 0 4 | created_at stringlengths 20 20 | comments_url stringlengths 70 70 | assignee dict | timeline_url stringlengths 70 70 | title stringlengths 1 290 | events_url stringlengths 68 68 | active_lock_reason null | user dict | assignees listlengths 0 3 | performed_via_github_app null | state_reason stringclasses 3 values | author_association stringclasses 3 values | closed_at stringlengths 20 20 ⌀ | pull_request dict | node_id stringlengths 18 19 | comments listlengths 0 30 | reactions dict | state stringclasses 2 values | locked bool 1 class | url stringlengths 61 61 | html_url stringlengths 49 51 | is_pull_request bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1,267,555,994 | https://api.github.com/repos/huggingface/datasets/issues/4473/labels{/name} | Add SST-2 dataset.
Currently it is part of GLUE benchmark.
This PR adds it as a standalone dataset.
CC: @julien-c | 2022-06-13T14:11:34Z | 4,473 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-10T13:37:26Z | https://api.github.com/repos/huggingface/datasets/issues/4473/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4473/timeline | Add SST-2 dataset | https://api.github.com/repos/huggingface/datasets/issues/4473/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-13T14:01:09Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4473.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4473",
"merged_at": "2022-06-13T14:01:09Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4473.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4473"
} | PR_kwDODunzps45d5-R | [
"_The documentation is not available anymore as the PR was closed or merged._",
"on the hub this dataset is referenced as `sst-2` not `sst2` – is there a canonical orthography? If not, could we name it `sst-2`?",
"@julien-c, we normally do not use hyphens for dataset names: whenever the original dataset name co... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 1,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4473/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4473 | https://github.com/huggingface/datasets/pull/4473 | true |
1,267,488,523 | https://api.github.com/repos/huggingface/datasets/issues/4472/labels{/name} | The hub now returns 401 instead of 404 for unauthenticated requests to non-existing repos.
This PR add support for the 401 error and fixes the CI fails on `master` | 2022-06-10T13:05:11Z | 4,472 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-10T12:38:11Z | https://api.github.com/repos/huggingface/datasets/issues/4472/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4472/timeline | Fix 401 error for unauthticated requests to non-existing repos | https://api.github.com/repos/huggingface/datasets/issues/4472/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | 2022-06-10T12:55:57Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4472.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4472",
"merged_at": "2022-06-10T12:55:56Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4472.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4472"
} | PR_kwDODunzps45drcb | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 2,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4472/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4472 | https://github.com/huggingface/datasets/pull/4472 | true |
1,267,475,268 | https://api.github.com/repos/huggingface/datasets/issues/4471/labels{/name} | ## Describe the bug
CI is failing because of repo "lhoestq/_dummy". See: https://app.circleci.com/pipelines/github/huggingface/datasets/12461/workflows/1b040b45-9578-4ab9-8c44-c643c4eb8691/jobs/74269
```
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://huggingface.co/api/datasets/lhoestq/_dummy?full=true
```
The repo seems to no longer exist: https://huggingface.co/api/datasets/lhoestq/_dummy
```
error: "Repository not found"
```
CC: @lhoestq | 2022-06-10T13:24:53Z | 4,471 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-06-10T12:26:06Z | https://api.github.com/repos/huggingface/datasets/issues/4471/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4471/timeline | CI error with repo lhoestq/_dummy | https://api.github.com/repos/huggingface/datasets/issues/4471/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | completed | MEMBER | 2022-06-10T13:24:53Z | null | I_kwDODunzps5LjCNE | [
"fixed by https://github.com/huggingface/datasets/pull/4472"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4471/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4471 | https://github.com/huggingface/datasets/issues/4471 | false |
1,267,470,051 | https://api.github.com/repos/huggingface/datasets/issues/4470/labels{/name} | null | 2022-06-10T18:04:10Z | 4,470 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-10T12:21:13Z | https://api.github.com/repos/huggingface/datasets/issues/4470/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4470/timeline | Reorder returned validation/test splits in script template | https://api.github.com/repos/huggingface/datasets/issues/4470/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-10T17:54:50Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4470.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4470",
"merged_at": "2022-06-10T17:54:50Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4470.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4470"
} | PR_kwDODunzps45dnYw | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4470/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4470 | https://github.com/huggingface/datasets/pull/4470 | true |
1,267,213,849 | https://api.github.com/repos/huggingface/datasets/issues/4469/labels{/name} | This PR replaces the URLs of data files in Google Drive with our Hub ones, once the data owners have approved to host their data on the Hub.
They also informed us that their dataset is licensed under CC BY-NC-ND. | 2022-06-10T16:42:08Z | 4,469 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-10T08:13:25Z | https://api.github.com/repos/huggingface/datasets/issues/4469/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4469/timeline | Replace data URLs in wider_face dataset once hosted on the Hub | https://api.github.com/repos/huggingface/datasets/issues/4469/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-10T16:32:46Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4469.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4469",
"merged_at": "2022-06-10T16:32:46Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4469.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4469"
} | PR_kwDODunzps45cweQ | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 2,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4469/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4469 | https://github.com/huggingface/datasets/pull/4469 | true |
1,266,715,742 | https://api.github.com/repos/huggingface/datasets/issues/4468/labels{/name} | This PR updates the tutorials to be more generalizable to all modalities. After reading the tutorials, a user should be able to load any type of dataset, know how to index into and slice a dataset, and do the most basic/common type of preprocessing (tokenization, resampling, applying transforms) depending on their dataset.
Other changes include:
- Removed the sections about a dataset's metadata, features, and columns because we cover this in an earlier tutorial about inspecting the `DatasetInfo` through the dataset builder.
- Separate the sharing dataset tutorial into two sections: (1) uploading via the web interface and (2) using the `huggingface_hub` library.
- Renamed some tutorials in the TOC to be more clear and specific.
- Added more text to nudge users towards joining the community and asking questions on the forums.
- If it's okay with everyone, I'd also like to remove the section about loading and using metrics since we have the `evaluate` docs now.
| 2022-06-14T16:22:02Z | 4,468 | null | https://api.github.com/repos/huggingface/datasets | false | [
{
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation",
"id": 1935892861,
"name": "documentation",
"node_id": "MDU6TGFiZWwxOTM1ODkyODYx",
"url": "https://api.github.com/repos/huggingface/datasets/labels/documentation"
}
] | 2022-06-09T22:00:44Z | https://api.github.com/repos/huggingface/datasets/issues/4468/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4468/timeline | Generalize tutorials for audio and vision | https://api.github.com/repos/huggingface/datasets/issues/4468/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4",
"events_url": "https://api.github.com/users/stevhliu/events{/privacy}",
"followers_url": "https://api.github.com/users/stevhliu/followers",
"following_url": "https://api.github.com/users/stevhliu/following{/other_user}",
"gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stevhliu",
"id": 59462357,
"login": "stevhliu",
"node_id": "MDQ6VXNlcjU5NDYyMzU3",
"organizations_url": "https://api.github.com/users/stevhliu/orgs",
"received_events_url": "https://api.github.com/users/stevhliu/received_events",
"repos_url": "https://api.github.com/users/stevhliu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stevhliu"
} | [] | null | null | MEMBER | 2022-06-14T16:12:00Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4468.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4468",
"merged_at": "2022-06-14T16:12:00Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4468.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4468"
} | PR_kwDODunzps45bERK | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4468/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4468 | https://github.com/huggingface/datasets/pull/4468 | true |
1,266,218,358 | https://api.github.com/repos/huggingface/datasets/issues/4467/labels{/name} | ## Issue
I am training a luxembourgish speech-recognition model in Colab with a custom dataset, including a dictionary of luxembourgish words, for example the speaken numbers 0 to 9. When preparing the dataset with the script
`ds_train1 = mydataset.map(prepare_dataset)`
the following error was issued:
```
ValueError Traceback (most recent call last)
<ipython-input-69-1e8f2b37f5bc> in <module>()
----> 1 ds_train = mydataset_train.map(prepare_dataset)
11 frames
/usr/local/lib/python3.7/dist-packages/transformers/tokenization_utils_base.py in __call__(self, text, text_pair, add_special_tokens, padding, truncation, max_length, stride, is_split_into_words, pad_to_multiple_of, return_tensors, return_token_type_ids, return_attention_mask, return_overflowing_tokens, return_special_tokens_mask, return_offsets_mapping, return_length, verbose, **kwargs)
2450 if not _is_valid_text_input(text):
2451 raise ValueError(
-> 2452 "text input must of type str (single example), List[str] (batch or single pretokenized example) "
2453 "or List[List[str]] (batch of pretokenized examples)."
2454 )
ValueError: text input must of type str (single example), List[str] (batch or single pretokenized example) or List[List[str]] (batch of pretokenized examples).
```
Debugging this problem was not easy, all transcriptions in the dataset are correct strings. Finally I discovered that the transcription string 'null' is interpreted as [None] by the `load_dataset()` script. By deleting this row in the dataset the training worked fine.
## Expected result:
transcription 'null' interpreted as 'str' instead of 'None'.
## Reproduction
Here is the code to reproduce the error with a one-row-dataset.
```
with open("null-test.csv") as f:
reader = csv.reader(f)
for row in reader:
print(row)
```
['wav_filename', 'wav_filesize', 'transcript']
['wavs/female/NULL1.wav', '17530', 'null']
```
dataset = load_dataset('csv', data_files={'train': 'null-test.csv'})
```
Using custom data configuration default-81ac0c0e27af3514
Downloading and preparing dataset csv/default to /root/.cache/huggingface/datasets/csv/default-81ac0c0e27af3514/0.0.0/433e0ccc46f9880962cc2b12065189766fbb2bee57a221866138fb9203c83519...
Downloading data files: 100%
1/1 [00:00<00:00, 29.55it/s]
Extracting data files: 100%
1/1 [00:00<00:00, 23.66it/s]
Dataset csv downloaded and prepared to /root/.cache/huggingface/datasets/csv/default-81ac0c0e27af3514/0.0.0/433e0ccc46f9880962cc2b12065189766fbb2bee57a221866138fb9203c83519. Subsequent calls will reuse this data.
100%
1/1 [00:00<00:00, 25.84it/s]
```
print(dataset['train']['transcript'])
```
[None]
## Environment info
```
!pip install datasets==2.2.2
!pip install transformers==4.19.2
``` | 2023-07-04T02:18:39Z | 4,467 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-06-09T14:26:00Z | https://api.github.com/repos/huggingface/datasets/issues/4467/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4467/timeline | Transcript string 'null' converted to [None] by load_dataset() | https://api.github.com/repos/huggingface/datasets/issues/4467/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/1360633?v=4",
"events_url": "https://api.github.com/users/mbarnig/events{/privacy}",
"followers_url": "https://api.github.com/users/mbarnig/followers",
"following_url": "https://api.github.com/users/mbarnig/following{/other_user}",
"gists_url": "https://api.github.com/users/mbarnig/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mbarnig",
"id": 1360633,
"login": "mbarnig",
"node_id": "MDQ6VXNlcjEzNjA2MzM=",
"organizations_url": "https://api.github.com/users/mbarnig/orgs",
"received_events_url": "https://api.github.com/users/mbarnig/received_events",
"repos_url": "https://api.github.com/users/mbarnig/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mbarnig/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mbarnig/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mbarnig"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | NONE | 2022-06-09T16:29:02Z | null | I_kwDODunzps5LePV2 | [
"Hi @mbarnig, thanks for reporting.\r\n\r\nPlease note that is an expected behavior by `pandas` (we use the `pandas` library to parse CSV files): https://pandas.pydata.org/docs/reference/api/pandas.read_csv.html\r\n```\r\nBy default the following values are interpreted as NaN: \r\n‘’, ‘#N/A’, ‘#N/A N/A’, ‘#NA’, ‘-1... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4467/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4467 | https://github.com/huggingface/datasets/issues/4467 | false |
1,266,159,920 | https://api.github.com/repos/huggingface/datasets/issues/4466/labels{/name} | Currently `.shard()` and `.select()` always create an indices mapping. However if the requested data are contiguous, it's much more optimized to simply slice the Arrow table instead of building an indices mapping. In particular:
- the shard/select operation will be much faster
- reading speed will be much faster in the resulting dataset, since it won't have to do a lookup step in the indices mapping
Since `.shard()` is also used for `.map()` with `num_proc>1`, it will also significantly improve the reading speed of multiprocessed `.map()` operations
Here is an example of speed-up:
```python
>>> import io
>>> import numpy as np
>>> from datasets import Dataset
>>> ds = Dataset.from_dict({"a": np.random.rand(10_000_000)})
>>> shard = ds.shard(num_shards=4, index=0, contiguous=True) # this calls `.select(range(2_500_000))`
>>> buf = io.BytesIO()
>>> %time dd.to_json(buf)
Creating json from Arrow format: 100%|██████████████████| 100/100 [00:00<00:00, 376.17ba/s]
CPU times: user 258 ms, sys: 9.06 ms, total: 267 ms
Wall time: 266 ms
```
while previously it was
```python
Creating json from Arrow format: 100%|███████████████████| 100/100 [00:03<00:00, 29.41ba/s]
CPU times: user 3.33 s, sys: 69.1 ms, total: 3.39 s
Wall time: 3.4 s
```
In this simple case the speed-up is x10, but @sayakpaul experienced a x100 speed-up on its data when exporting to JSON.
## Implementation details
I mostly improved `.select()`: it now checks if the input corresponds to a contiguous chunk of data and then it slices the main Arrow table (or the indices mapping table if it exists). To check if the input indices are contiguous it checks two possibilities:
- if the indices is of type `range`, it checks that start >= 0 and step = 1
- otherwise in the general case, it iterates over the indices. If all the indices are contiguous then we're good, otherwise we have to build an indices mapping.
Having to iterate over the indices doesn't cause performance issues IMO because:
- either they are contiguous and in this case the cost of iterating over the indices is much less than the cost of creating an indices mapping
- or they are not contiguous, and then iterating generally stops quickly when it first encounters the first indice that is not contiguous. | 2022-06-14T16:04:30Z | 4,466 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-09T13:45:39Z | https://api.github.com/repos/huggingface/datasets/issues/4466/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4466/timeline | Optimize contiguous shard and select | https://api.github.com/repos/huggingface/datasets/issues/4466/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | 2022-06-14T15:54:45Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4466.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4466",
"merged_at": "2022-06-14T15:54:45Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4466.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4466"
} | PR_kwDODunzps45ZLsd | [
"_The documentation is not available anymore as the PR was closed or merged._",
"I thought of just mentioning the benefits I got. Here's the code that @lhoestq provided:\r\n\r\n```py\r\nimport os\r\nfrom datasets import load_dataset\r\nfrom tqdm.auto import tqdm\r\n\r\nds = load_dataset(\"squad\", split=\"train\"... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 1,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4466/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4466 | https://github.com/huggingface/datasets/pull/4466 | true |
1,265,754,479 | https://api.github.com/repos/huggingface/datasets/issues/4465/labels{/name} | Fix https://github.com/huggingface/datasets/issues/4462 in the case of bigbench | 2022-06-09T14:38:36Z | 4,465 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-09T08:06:19Z | https://api.github.com/repos/huggingface/datasets/issues/4465/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4465/timeline | Fix bigbench config names | https://api.github.com/repos/huggingface/datasets/issues/4465/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | 2022-06-09T14:29:19Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4465.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4465",
"merged_at": "2022-06-09T14:29:18Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4465.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4465"
} | PR_kwDODunzps45X0XY | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4465/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4465 | https://github.com/huggingface/datasets/pull/4465 | true |
1,265,682,931 | https://api.github.com/repos/huggingface/datasets/issues/4464/labels{/name} | This PR extends the support in streaming mode for datasets that use `xml.dom.minidom.parse`, by patching that function.
This PR adds support for streaming datasets like "Yaxin/SemEval2015".
Fix #4453. | 2022-06-09T08:43:24Z | 4,464 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-09T06:58:25Z | https://api.github.com/repos/huggingface/datasets/issues/4464/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4464/timeline | Extend support for streaming datasets that use xml.dom.minidom.parse | https://api.github.com/repos/huggingface/datasets/issues/4464/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-09T08:34:16Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4464.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4464",
"merged_at": "2022-06-09T08:34:15Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4464.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4464"
} | PR_kwDODunzps45XlWW | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4464/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4464 | https://github.com/huggingface/datasets/pull/4464 | true |
1,265,093,211 | https://api.github.com/repos/huggingface/datasets/issues/4463/labels{/name} | Fix https://github.com/huggingface/datasets/issues/4462 | 2023-09-24T10:03:00Z | 4,463 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-08T17:45:24Z | https://api.github.com/repos/huggingface/datasets/issues/4463/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4463/timeline | Use config_id to check split sizes instead of config name | https://api.github.com/repos/huggingface/datasets/issues/4463/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | 2022-06-09T08:06:37Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4463.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4463",
"merged_at": null,
"patch_url": "https://github.com/huggingface/datasets/pull/4463.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4463"
} | PR_kwDODunzps45Vnzu | [
"_The documentation is not available anymore as the PR was closed or merged._",
"closing in favor of https://github.com/huggingface/datasets/pull/4465"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4463/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4463 | https://github.com/huggingface/datasets/pull/4463 | true |
1,265,079,347 | https://api.github.com/repos/huggingface/datasets/issues/4462/labels{/name} | As noticed in https://github.com/huggingface/datasets/pull/4125 when a dataset config class has a parameter that reduces the number of examples (e.g. named `max_examples`), then loading the dataset and passing `max_examples` raises `NonMatchingSplitsSizesError`.
This is because it will check for expected the number of examples of the config with the same name without taking into account the `max_examples` parameter. This can be fixed by checking the expected number of examples using the **config id** instead of name. Indeed the config id corresponds to the config name + an optional suffix that depends on the config parameters | 2022-07-05T07:39:55Z | 4,462 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-06-08T17:31:24Z | https://api.github.com/repos/huggingface/datasets/issues/4462/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4462/timeline | BigBench: NonMatchingSplitsSizesError when passing a dataset configuration parameter | https://api.github.com/repos/huggingface/datasets/issues/4462/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | reopened | MEMBER | null | null | I_kwDODunzps5LZ5Qz | [
"Why not adding `max_examples` as part of the config name?",
"Yup it can also work, and maybe it's simpler this way. Opening a PR to fix bigbench instead of https://github.com/huggingface/datasets/pull/4463",
"Hi @lhoestq,\r\n\r\nThank you for taking a look at this issue, and proposing a solution. \r\nUnfortuna... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4462/reactions"
} | open | false | https://api.github.com/repos/huggingface/datasets/issues/4462 | https://github.com/huggingface/datasets/issues/4462 | false |
1,264,800,451 | https://api.github.com/repos/huggingface/datasets/issues/4461/labels{/name} | ## Describe the bug
I have piped install datasets, but this package doesn't have these attributes: load_dataset, load_metric.
## Environment info
- `datasets` version: 1.9.0
- Platform: Linux-5.13.0-44-generic-x86_64-with-debian-bullseye-sid
- Python version: 3.6.13
- PyArrow version: 6.0.1
| 2024-03-25T12:58:29Z | 4,461 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-06-08T13:59:20Z | https://api.github.com/repos/huggingface/datasets/issues/4461/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4461/timeline | AttributeError: module 'datasets' has no attribute 'load_dataset' | https://api.github.com/repos/huggingface/datasets/issues/4461/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/59248970?v=4",
"events_url": "https://api.github.com/users/AlexNLP/events{/privacy}",
"followers_url": "https://api.github.com/users/AlexNLP/followers",
"following_url": "https://api.github.com/users/AlexNLP/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexNLP/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AlexNLP",
"id": 59248970,
"login": "AlexNLP",
"node_id": "MDQ6VXNlcjU5MjQ4OTcw",
"organizations_url": "https://api.github.com/users/AlexNLP/orgs",
"received_events_url": "https://api.github.com/users/AlexNLP/received_events",
"repos_url": "https://api.github.com/users/AlexNLP/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AlexNLP/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexNLP/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AlexNLP"
} | [] | null | completed | NONE | 2022-06-08T14:41:00Z | null | I_kwDODunzps5LY1LD | [
"I'm having the same issue，Can you tell me how to solve it？",
"I have the same issue, can you tell me how to solve it? Thanks",
"I had a folder named 'datasets' so this is why it can't find the import, it's looking in the wrong place",
"@briandw your comment saved my day 👍 "
] | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4461/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4461 | https://github.com/huggingface/datasets/issues/4461 | false |
1,264,644,205 | https://api.github.com/repos/huggingface/datasets/issues/4460/labels{/name} | Remove the fallback imports/checks in the code needed for Python 3.6 and update the requirements/CI files. Also, use Python types for the NumPy dtype wherever possible to avoid deprecation warnings in newer NumPy versions.
| 2022-07-26T19:16:39Z | 4,460 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-08T12:10:18Z | https://api.github.com/repos/huggingface/datasets/issues/4460/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4460/timeline | Drop Python 3.6 support | https://api.github.com/repos/huggingface/datasets/issues/4460/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | [] | null | null | CONTRIBUTOR | 2022-07-26T19:04:21Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4460.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4460",
"merged_at": "2022-07-26T19:04:21Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4460.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4460"
} | PR_kwDODunzps45UHIs | [
"_The documentation is not available anymore as the PR was closed or merged._",
"I've disabled the `test_dummy_dataset_serialize_s3` tests in the Linux CI to avoid the failures (these tests only fail on Windows in 3.6). These failures are unrelated to this PR's changes, and I would like to address this in a new P... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 2,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4460/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4460 | https://github.com/huggingface/datasets/pull/4460 | true |
1,264,636,481 | https://api.github.com/repos/huggingface/datasets/issues/4459/labels{/name} | Related to #4362. | 2022-06-08T12:36:24Z | 4,459 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-08T12:03:42Z | https://api.github.com/repos/huggingface/datasets/issues/4459/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4459/timeline | Add and fix language tags for udhr dataset | https://api.github.com/repos/huggingface/datasets/issues/4459/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-08T12:27:13Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4459.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4459",
"merged_at": "2022-06-08T12:27:13Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4459.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4459"
} | PR_kwDODunzps45UFc8 | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4459/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4459 | https://github.com/huggingface/datasets/pull/4459 | true |
1,263,531,911 | https://api.github.com/repos/huggingface/datasets/issues/4457/labels{/name} | I might cc a few of the other TF people to take a look when this is closer to being finished, but it's still a draft for now. | 2022-06-14T16:08:41Z | 4,457 | null | https://api.github.com/repos/huggingface/datasets | false | [
{
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation",
"id": 1935892861,
"name": "documentation",
"node_id": "MDU6TGFiZWwxOTM1ODkyODYx",
"url": "https://api.github.com/repos/huggingface/datasets/labels/documentation"
}
] | 2022-06-07T16:06:48Z | https://api.github.com/repos/huggingface/datasets/issues/4457/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4457/timeline | First draft of the docs for TF + Datasets | https://api.github.com/repos/huggingface/datasets/issues/4457/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4",
"events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}",
"followers_url": "https://api.github.com/users/Rocketknight1/followers",
"following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}",
"gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Rocketknight1",
"id": 12866554,
"login": "Rocketknight1",
"node_id": "MDQ6VXNlcjEyODY2NTU0",
"organizations_url": "https://api.github.com/users/Rocketknight1/orgs",
"received_events_url": "https://api.github.com/users/Rocketknight1/received_events",
"repos_url": "https://api.github.com/users/Rocketknight1/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Rocketknight1"
} | [] | null | null | MEMBER | 2022-06-14T15:59:08Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4457.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4457",
"merged_at": "2022-06-14T15:59:08Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4457.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4457"
} | PR_kwDODunzps45QZCU | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Some links are still missing I think :)",
"This is probably quite close to being ready, so cc some TF people @gante @amyeroberts @merveenoyan just so they see it! No need for a full review, but if you have any comments or suggestio... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 1,
"total_count": 1,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4457/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4457 | https://github.com/huggingface/datasets/pull/4457 | true |
1,263,241,449 | https://api.github.com/repos/huggingface/datasets/issues/4456/labels{/name} | Tabular data are treated very differently than data for NLP, audio, vision, etc. and therefore the worflow for tabular data in `datasets` is not ideal.
For example for tabular data, it is common to use pandas/spark/dask to process the data, and then load the data into X and y (X is an array of features and y an array of labels), then train_test_split and finally feed the data to a machine learning model.
In `datasets` the workflow is different: we use load_dataset, then map, then train_test_split (if we only have a train split) and we end up with columnar dataset splits, not formatted as X and y.
Right now, it is already possible to convert a dataset from and to pandas, but there are still many things that could improve the workflow for tabular data:
- be able to load the data into X and y
- be able to load a dataset from the output of spark or dask (as far as I know it's usually csv or parquet files on S3/GCS/HDFS etc.)
- support "unsplit" datasets explicitly, instead of putting everything in "train" by default
cc @adrinjalali @merveenoyan feel free to complete/correct this :)
Feel free to also share ideas of APIs that would be super intuitive in your opinion ! | 2023-03-06T08:53:55Z | 4,456 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "a2eeef",
"default": true,
"description": "New feature or request",
"id": 1935892871,
"name": "enhancement",
"node_id": "MDU6TGFiZWwxOTM1ODkyODcx",
"url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement"
},
{
"color": "c5def5",
"default": fals... | 2022-06-07T12:48:22Z | https://api.github.com/repos/huggingface/datasets/issues/4456/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4456/timeline | Workflow for Tabular data | https://api.github.com/repos/huggingface/datasets/issues/4456/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | null | null | I_kwDODunzps5LS4jp | [
"I use below to load a dataset:\r\n```\r\ndataset = datasets.load_dataset(\"scikit-learn/auto-mpg\")\r\ndf = pd.DataFrame(dataset[\"train\"])\r\n```\r\nTBH as said, tabular folk split their own dataset, they sometimes have two splits, sometimes three. Maybe somehow avoiding it for tabular datasets might be good for... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 1,
"heart": 0,
"hooray": 1,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4456/reactions"
} | open | false | https://api.github.com/repos/huggingface/datasets/issues/4456 | https://github.com/huggingface/datasets/issues/4456 | false |
1,263,089,067 | https://api.github.com/repos/huggingface/datasets/issues/4455/labels{/name} | As stated in their website, data owners updated their URLs on 28/04/2022.
This PR updates the data URLs.
Fix #4452. | 2022-06-08T07:24:54Z | 4,455 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-07T10:40:54Z | https://api.github.com/repos/huggingface/datasets/issues/4455/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4455/timeline | Update data URLs in fever dataset | https://api.github.com/repos/huggingface/datasets/issues/4455/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-08T07:16:17Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4455.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4455",
"merged_at": "2022-06-08T07:16:16Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4455.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4455"
} | PR_kwDODunzps45O5F9 | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4455/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4455 | https://github.com/huggingface/datasets/pull/4455 | true |
1,262,674,973 | https://api.github.com/repos/huggingface/datasets/issues/4454/labels{/name} | ### Link
_No response_
### Description
the link could not visit
### Owner
_No response_ | 2022-06-07T11:53:11Z | 4,454 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "cfd3d7",
"default": true,
"description": "This issue or pull request already exists",
"id": 1935892865,
"name": "duplicate",
"node_id": "MDU6TGFiZWwxOTM1ODkyODY1",
"url": "https://api.github.com/repos/huggingface/datasets/labels/duplicate"
},
{
"color": "E5583E",
... | 2022-06-07T03:31:46Z | https://api.github.com/repos/huggingface/datasets/issues/4454/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url": "https://api.github.com/users/severo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/severo",
"id": 1676121,
"login": "severo",
"node_id": "MDQ6VXNlcjE2NzYxMjE=",
"organizations_url": "https://api.github.com/users/severo/orgs",
"received_events_url": "https://api.github.com/users/severo/received_events",
"repos_url": "https://api.github.com/users/severo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/severo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/severo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/severo"
} | https://api.github.com/repos/huggingface/datasets/issues/4454/timeline | Dataset Viewer issue for Yaxin/SemEval2015 | https://api.github.com/repos/huggingface/datasets/issues/4454/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/18160852?v=4",
"events_url": "https://api.github.com/users/WithYouTo/events{/privacy}",
"followers_url": "https://api.github.com/users/WithYouTo/followers",
"following_url": "https://api.github.com/users/WithYouTo/following{/other_user}",
"gists_url": "https://api.github.com/users/WithYouTo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/WithYouTo",
"id": 18160852,
"login": "WithYouTo",
"node_id": "MDQ6VXNlcjE4MTYwODUy",
"organizations_url": "https://api.github.com/users/WithYouTo/orgs",
"received_events_url": "https://api.github.com/users/WithYouTo/received_events",
"repos_url": "https://api.github.com/users/WithYouTo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/WithYouTo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/WithYouTo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/WithYouTo"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url... | null | completed | NONE | 2022-06-07T11:53:11Z | null | I_kwDODunzps5LQuQd | [
"Closing since it's a duplicate of https://github.com/huggingface/datasets/issues/4453"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4454/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4454 | https://github.com/huggingface/datasets/issues/4454 | false |
1,262,674,105 | https://api.github.com/repos/huggingface/datasets/issues/4453/labels{/name} | ### Link
_No response_
### Description
_No response_
### Owner
_No response_ | 2022-06-09T08:34:16Z | 4,453 | null | https://api.github.com/repos/huggingface/datasets | null | [] | 2022-06-07T03:30:08Z | https://api.github.com/repos/huggingface/datasets/issues/4453/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4453/timeline | Dataset Viewer issue for Yaxin/SemEval2015 | https://api.github.com/repos/huggingface/datasets/issues/4453/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/18160852?v=4",
"events_url": "https://api.github.com/users/WithYouTo/events{/privacy}",
"followers_url": "https://api.github.com/users/WithYouTo/followers",
"following_url": "https://api.github.com/users/WithYouTo/following{/other_user}",
"gists_url": "https://api.github.com/users/WithYouTo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/WithYouTo",
"id": 18160852,
"login": "WithYouTo",
"node_id": "MDQ6VXNlcjE4MTYwODUy",
"organizations_url": "https://api.github.com/users/WithYouTo/orgs",
"received_events_url": "https://api.github.com/users/WithYouTo/received_events",
"repos_url": "https://api.github.com/users/WithYouTo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/WithYouTo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/WithYouTo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/WithYouTo"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | NONE | 2022-06-09T08:34:16Z | null | I_kwDODunzps5LQuC5 | [
"I understand that the issue is that a remote file (URL) is being loaded as a local file. Right @albertvillanova @lhoestq?\r\n\r\n```\r\nMessage: [Errno 2] No such file or directory: 'https://raw.githubusercontent.com/YaxinCui/ABSADataset/main/SemEval2015Task12Corrected/train/restaurants_train.xml'\r\n```",
... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4453/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4453 | https://github.com/huggingface/datasets/issues/4453 | false |
1,262,529,654 | https://api.github.com/repos/huggingface/datasets/issues/4452/labels{/name} | ## Describe the bug
Trying to load the `fever` dataset fails with `datasets.utils.info_utils.NonMatchingChecksumError`.
I tried with `download_mode="force_redownload"` but that did not fix the error. I also tried with `ignore_verification=True` but then that raised a `json.decoder.JSONDecodeError`.
## Steps to reproduce the bug
```python
from datasets import load_dataset
dataset = load_dataset('fever', 'v1.0') # Fails with NonMatchingChecksumError
dataset = load_dataset('fever', 'v1.0', download_mode="force_redownload") # Fails with NonMatchingChecksumError
dataset = load_dataset('fever', 'v1.0', ignore_verification=True)` # Fails with JSONDecodeError
```
## Expected results
I expect this call to return with no error raised.
## Actual results
With `ignore_verification=False`:
```
*** datasets.utils.info_utils.NonMatchingChecksumError: Checksums didn't match for dataset source files:
['https://s3-eu-west-1.amazonaws.com/fever.public/train.jsonl', 'https://s3-eu-west-1.amazonaws.com/fever.public/shared_task_dev.jsonl', 'https://s3-eu-west-1.amazonaws.com/fever.public/shared_task_dev_public.jsonl', 'https://s3-eu-west-1.amazonaws.com/fever.public/shared_task_test.jsonl', 'https://s3-eu-west-1.amazonaws.com/fever.public/paper_dev.jsonl', 'https://s3-eu-west-1.amazonaws.com/fever.public/paper_test.jsonl']
```
With `ignore_verification=True`:
```
*** json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
```
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version: 2.2.3.dev0
- Platform: Linux-4.15.0-50-generic-x86_64-with-glibc2.10
- Python version: 3.8.13
- PyArrow version: 8.0.0
- Pandas version: 1.4.2
| 2022-12-15T13:36:40Z | 4,452 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-06-06T23:13:15Z | https://api.github.com/repos/huggingface/datasets/issues/4452/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4452/timeline | Trying to load FEVER dataset results in NonMatchingChecksumError | https://api.github.com/repos/huggingface/datasets/issues/4452/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/5347982?v=4",
"events_url": "https://api.github.com/users/santhnm2/events{/privacy}",
"followers_url": "https://api.github.com/users/santhnm2/followers",
"following_url": "https://api.github.com/users/santhnm2/following{/other_user}",
"gists_url": "https://api.github.com/users/santhnm2/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/santhnm2",
"id": 5347982,
"login": "santhnm2",
"node_id": "MDQ6VXNlcjUzNDc5ODI=",
"organizations_url": "https://api.github.com/users/santhnm2/orgs",
"received_events_url": "https://api.github.com/users/santhnm2/received_events",
"repos_url": "https://api.github.com/users/santhnm2/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/santhnm2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/santhnm2/subscriptions",
"type": "User",
"url": "https://api.github.com/users/santhnm2"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | NONE | 2022-06-08T07:16:16Z | null | I_kwDODunzps5LQKx2 | [
"Thanks for reporting @santhnm2. We are fixing it.\r\n\r\nData owners updated their URLs recently. We have to align with them, otherwise you do not download anything (that is why ignore_verifications does not work).",
"Hello! Is there any update on this? I am having the same issue 6 months later."
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4452/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4452 | https://github.com/huggingface/datasets/issues/4452 | false |
1,262,103,323 | https://api.github.com/repos/huggingface/datasets/issues/4451/labels{/name} | Closes #4430. | 2022-06-07T17:40:01Z | 4,451 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-06T16:57:08Z | https://api.github.com/repos/huggingface/datasets/issues/4451/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4451/timeline | Use newer version of multi-news with fixes | https://api.github.com/repos/huggingface/datasets/issues/4451/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8917831?v=4",
"events_url": "https://api.github.com/users/JohnGiorgi/events{/privacy}",
"followers_url": "https://api.github.com/users/JohnGiorgi/followers",
"following_url": "https://api.github.com/users/JohnGiorgi/following{/other_user}",
"gists_url": "https://api.github.com/users/JohnGiorgi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JohnGiorgi",
"id": 8917831,
"login": "JohnGiorgi",
"node_id": "MDQ6VXNlcjg5MTc4MzE=",
"organizations_url": "https://api.github.com/users/JohnGiorgi/orgs",
"received_events_url": "https://api.github.com/users/JohnGiorgi/received_events",
"repos_url": "https://api.github.com/users/JohnGiorgi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JohnGiorgi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JohnGiorgi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JohnGiorgi"
} | [] | null | null | CONTRIBUTOR | 2022-06-07T17:14:44Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4451.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4451",
"merged_at": "2022-06-07T17:14:44Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4451.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4451"
} | PR_kwDODunzps45LkGc | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Awesome thanks @mariosasko!"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4451/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4451 | https://github.com/huggingface/datasets/pull/4451 | true |
1,261,878,324 | https://api.github.com/repos/huggingface/datasets/issues/4450/labels{/name} | null | 2022-06-06T14:51:49Z | 4,450 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-06T13:52:41Z | https://api.github.com/repos/huggingface/datasets/issues/4450/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4450/timeline | Update README.md of fquad | https://api.github.com/repos/huggingface/datasets/issues/4450/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | 2022-06-06T14:43:03Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4450.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4450",
"merged_at": "2022-06-06T14:43:03Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4450.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4450"
} | PR_kwDODunzps45Kzwh | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4450/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4450 | https://github.com/huggingface/datasets/pull/4450 | true |
1,261,262,326 | https://api.github.com/repos/huggingface/datasets/issues/4449/labels{/name} | import android.content.DialogInterface;
import android.database.Cursor;
import android.os.Bundle;
import android.view.View;
import android.widget.ArrayAdapter;
import android.widget.Button;
import android.widget.EditText;
import android.widget.Toast;
import androidx.appcompat.app.AlertDialog;
import androidx.appcompat.app.AppCompatActivity;
public class MainActivity extends AppCompatActivity {
private EditText editTextID;
private EditText editTextName;
private EditText editTextNum;
private String name;
private int number;
private String ID;
private dbHelper db;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
db = new dbHelper(this);
editTextID = findViewById(R.id.editText1);
editTextName = findViewById(R.id.editText2);
editTextNum = findViewById(R.id.editText3);
Button buttonSave = findViewById(R.id.button);
Button buttonRead = findViewById(R.id.button2);
Button buttonUpdate = findViewById(R.id.button3);
Button buttonDelete = findViewById(R.id.button4);
Button buttonSearch = findViewById(R.id.button5);
Button buttonDeleteAll = findViewById(R.id.button6);
buttonSave.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
name = editTextName.getText().toString();
String num = editTextNum.getText().toString();
if (name.isEmpty() || num.isEmpty()) {
Toast.makeText(MainActivity.this, "Cannot Submit Empty Fields", Toast.LENGTH_SHORT).show();
} else {
number = Integer.parseInt(num);
try {
// Insert Data
db.insertData(name, number);
// Clear the fields
editTextID.getText().clear();
editTextName.getText().clear();
editTextNum.getText().clear();
} catch (Exception e) {
e.printStackTrace();
}
}
}
});
buttonRead.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
final ArrayAdapter<String> adapter = new ArrayAdapter<>(MainActivity.this, android.R.layout.simple_list_item_1);
String name;
String num;
String id;
try {
Cursor cursor = db.readData();
if (cursor != null && cursor.getCount() > 0) {
while (cursor.moveToNext()) {
id = cursor.getString(0); // get data in column index 0
name = cursor.getString(1); // get data in column index 1
num = cursor.getString(2); // get data in column index 2
// Add SQLite data to listView
adapter.add("ID :- " + id + "\n" +
"Name :- " + name + "\n" +
"Number :- " + num + "\n\n");
}
} else {
adapter.add("No Data");
}
cursor.close();
} catch (Exception e) {
e.printStackTrace();
}
// show the saved data in alertDialog
AlertDialog.Builder builder = new AlertDialog.Builder(MainActivity.this);
builder.setTitle("SQLite saved data");
builder.setIcon(R.mipmap.app_icon_foreground);
builder.setAdapter(adapter, new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
}
});
builder.setPositiveButton("OK", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
dialog.cancel();
}
});
AlertDialog dialog = builder.create();
dialog.show();
}
});
buttonUpdate.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
name = editTextName.getText().toString();
String num = editTextNum.getText().toString();
ID = editTextID.getText().toString();
if (name.isEmpty() || num.isEmpty() || ID.isEmpty()) {
Toast.makeText(MainActivity.this, "Cannot Submit Empty Fields", Toast.LENGTH_SHORT).show();
} else {
number = Integer.parseInt(num);
try {
// Update Data
db.updateData(ID, name, number);
// Clear the fields
editTextID.getText().clear();
editTextName.getText().clear();
editTextNum.getText().clear();
} catch (Exception e) {
e.printStackTrace();
}
}
}
});
buttonDelete.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
ID = editTextID.getText().toString();
if (ID.isEmpty()) {
Toast.makeText(MainActivity.this, "Please enter the ID", Toast.LENGTH_SHORT).show();
} else {
try {
// Delete Data
db.deleteData(ID);
// Clear the fields
editTextID.getText().clear();
editTextName.getText().clear();
editTextNum.getText().clear();
} catch (Exception e) {
e.printStackTrace();
}
}
}
});
buttonDeleteAll.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
// Delete all data
// You can simply delete all the data by calling this method --> db.deleteAllData();
// You can try this also
AlertDialog.Builder builder = new AlertDialog.Builder(MainActivity.this);
builder.setIcon(R.mipmap.app_icon_foreground);
builder.setTitle("Delete All Data");
builder.setCancelable(false);
builder.setMessage("Do you really need to delete your all data ?");
builder.setPositiveButton("Yes", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
// User confirmed , now you can delete the data
db.deleteAllData();
// Clear the fields
editTextID.getText().clear();
editTextName.getText().clear();
editTextNum.getText().clear();
}
});
builder.setNegativeButton("No", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
// user not confirmed
dialog.cancel();
}
});
AlertDialog dialog = builder.create();
dialog.show();
}
});
buttonSearch.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
ID = editTextID.getText().toString();
if (ID.isEmpty()) {
Toast.makeText(MainActivity.this, "Please enter the ID", Toast.LENGTH_SHORT).show();
} else {
try {
// Search data
Cursor cursor = db.searchData(ID);
if (cursor.moveToFirst()) {
editTextName.setText(cursor.getString(1));
editTextNum.setText(cursor.getString(2));
Toast.makeText(MainActivity.this, "Data successfully searched", Toast.LENGTH_SHORT).show();
} else {
Toast.makeText(MainActivity.this, "ID not found", Toast.LENGTH_SHORT).show();
editTextNum.setText("ID Not found");
editTextName.setText("ID not found");
}
cursor.close();
} catch (Exception e) {
e.printStackTrace();
}
}
}
});
}
} | 2022-06-06T15:44:50Z | 4,449 | null | https://api.github.com/repos/huggingface/datasets | null | [] | 2022-06-06T02:24:32Z | https://api.github.com/repos/huggingface/datasets/issues/4449/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4449/timeline | Rj | https://api.github.com/repos/huggingface/datasets/issues/4449/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/87345839?v=4",
"events_url": "https://api.github.com/users/Aeckard45/events{/privacy}",
"followers_url": "https://api.github.com/users/Aeckard45/followers",
"following_url": "https://api.github.com/users/Aeckard45/following{/other_user}",
"gists_url": "https://api.github.com/users/Aeckard45/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Aeckard45",
"id": 87345839,
"login": "Aeckard45",
"node_id": "MDQ6VXNlcjg3MzQ1ODM5",
"organizations_url": "https://api.github.com/users/Aeckard45/orgs",
"received_events_url": "https://api.github.com/users/Aeckard45/received_events",
"repos_url": "https://api.github.com/users/Aeckard45/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Aeckard45/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Aeckard45/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Aeckard45"
} | [] | null | completed | NONE | 2022-06-06T15:44:50Z | null | I_kwDODunzps5LLVX2 | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4449/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4449 | https://github.com/huggingface/datasets/issues/4449 | false |
1,260,966,129 | https://api.github.com/repos/huggingface/datasets/issues/4448/labels{/name} | **Is your feature request related to a problem? Please describe.**
Many large datasets are full of duplications and it has been shown that deduplicating datasets can lead to better performance while training, and more truthful evaluation at test-time.
A feature that allows one to easily deduplicate a dataset can be cool!
**Describe the solution you'd like**
We can define a function and keep only the first/last data-point that yields the value according to this function.
**Describe alternatives you've considered**
The clear alternative is to repeat a clear boilerplate every time someone want to deduplicate a dataset.
| 2023-12-12T07:52:40Z | 4,448 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "cfd3d7",
"default": true,
"description": "This issue or pull request already exists",
"id": 1935892865,
"name": "duplicate",
"node_id": "MDU6TGFiZWwxOTM1ODkyODY1",
"url": "https://api.github.com/repos/huggingface/datasets/labels/duplicate"
},
{
"color": "a2eeef",
... | 2022-06-05T05:32:56Z | https://api.github.com/repos/huggingface/datasets/issues/4448/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4448/timeline | New Preprocessing Feature - Deduplication [Request] | https://api.github.com/repos/huggingface/datasets/issues/4448/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/57996478?v=4",
"events_url": "https://api.github.com/users/yuvalkirstain/events{/privacy}",
"followers_url": "https://api.github.com/users/yuvalkirstain/followers",
"following_url": "https://api.github.com/users/yuvalkirstain/following{/other_user}",
"gists_url": "https://api.github.com/users/yuvalkirstain/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yuvalkirstain",
"id": 57996478,
"login": "yuvalkirstain",
"node_id": "MDQ6VXNlcjU3OTk2NDc4",
"organizations_url": "https://api.github.com/users/yuvalkirstain/orgs",
"received_events_url": "https://api.github.com/users/yuvalkirstain/received_events",
"repos_url": "https://api.github.com/users/yuvalkirstain/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yuvalkirstain/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yuvalkirstain/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yuvalkirstain"
} | [] | null | null | NONE | null | null | I_kwDODunzps5LKNDx | [
"Hi! The [datasets_sql](https://github.com/mariosasko/datasets_sql) package lets you easily find distinct rows in a dataset (an example with `SELECT DISTINCT` is in the readme). Deduplication is (still) not part of the official API because it's hard to implement for datasets bigger than RAM while only using the nat... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4448/reactions"
} | open | false | https://api.github.com/repos/huggingface/datasets/issues/4448 | https://github.com/huggingface/datasets/issues/4448 | false |
1,260,041,805 | https://api.github.com/repos/huggingface/datasets/issues/4447/labels{/name} | Add `paperswithcode_id` and fix some links in the `scene_parse_150` card. | 2022-06-06T15:50:25Z | 4,447 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-03T15:22:34Z | https://api.github.com/repos/huggingface/datasets/issues/4447/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4447/timeline | Minor fixes/improvements in `scene_parse_150` card | https://api.github.com/repos/huggingface/datasets/issues/4447/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | [] | null | null | CONTRIBUTOR | 2022-06-06T15:41:37Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4447.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4447",
"merged_at": "2022-06-06T15:41:37Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4447.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4447"
} | PR_kwDODunzps45E4A- | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4447/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4447 | https://github.com/huggingface/datasets/pull/4447 | true |
1,260,028,995 | https://api.github.com/repos/huggingface/datasets/issues/4446/labels{/name} | null | 2022-06-03T16:10:09Z | 4,446 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-03T15:10:27Z | https://api.github.com/repos/huggingface/datasets/issues/4446/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4446/timeline | Add missing kwargs to docstrings | https://api.github.com/repos/huggingface/datasets/issues/4446/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-03T16:01:29Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4446.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4446",
"merged_at": "2022-06-03T16:01:29Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4446.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4446"
} | PR_kwDODunzps45E1Qb | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4446/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4446 | https://github.com/huggingface/datasets/pull/4446 | true |
1,259,947,568 | https://api.github.com/repos/huggingface/datasets/issues/4445/labels{/name} | Currently, the docstring of `load_dataset_builder` only contains the first parameter `path` (no other):
- https://huggingface.co/docs/datasets/v2.2.1/en/package_reference/loading_methods#datasets.load_dataset_builder.path | 2022-06-03T14:35:32Z | 4,445 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-03T13:55:50Z | https://api.github.com/repos/huggingface/datasets/issues/4445/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4445/timeline | Fix missing args in docstring of load_dataset_builder | https://api.github.com/repos/huggingface/datasets/issues/4445/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-03T14:27:09Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4445.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4445",
"merged_at": "2022-06-03T14:27:09Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4445.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4445"
} | PR_kwDODunzps45EjtA | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4445/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4445 | https://github.com/huggingface/datasets/pull/4445 | true |
1,259,738,209 | https://api.github.com/repos/huggingface/datasets/issues/4444/labels{/name} | To fix the rendering of `**kwargs` in docstrings, a parentheses must be added afterwards.
See:
- huggingface/doc-builder/issues/235 | 2022-06-03T11:01:28Z | 4,444 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-03T10:29:02Z | https://api.github.com/repos/huggingface/datasets/issues/4444/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4444/timeline | Fix kwargs in docstrings | https://api.github.com/repos/huggingface/datasets/issues/4444/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-03T10:52:46Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4444.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4444",
"merged_at": "2022-06-03T10:52:46Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4444.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4444"
} | PR_kwDODunzps45D2XX | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4444/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4444 | https://github.com/huggingface/datasets/pull/4444 | true |
1,259,606,334 | https://api.github.com/repos/huggingface/datasets/issues/4443/labels{/name} | ### Link
_No response_
### Description
_No response_
### Owner
_No response_ | 2023-09-25T12:15:08Z | 4,443 | null | https://api.github.com/repos/huggingface/datasets | null | [] | 2022-06-03T08:17:16Z | https://api.github.com/repos/huggingface/datasets/issues/4443/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4443/timeline | Dataset Viewer issue for openclimatefix/nimrod-uk-1km | https://api.github.com/repos/huggingface/datasets/issues/4443/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/32382826?v=4",
"events_url": "https://api.github.com/users/ZYMXIXI/events{/privacy}",
"followers_url": "https://api.github.com/users/ZYMXIXI/followers",
"following_url": "https://api.github.com/users/ZYMXIXI/following{/other_user}",
"gists_url": "https://api.github.com/users/ZYMXIXI/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ZYMXIXI",
"id": 32382826,
"login": "ZYMXIXI",
"node_id": "MDQ6VXNlcjMyMzgyODI2",
"organizations_url": "https://api.github.com/users/ZYMXIXI/orgs",
"received_events_url": "https://api.github.com/users/ZYMXIXI/received_events",
"repos_url": "https://api.github.com/users/ZYMXIXI/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ZYMXIXI/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ZYMXIXI/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ZYMXIXI"
} | [] | null | null | NONE | null | null | I_kwDODunzps5LFBE- | [
"If I understand correctly, this is due to the key `split` missing in the line https://huggingface.co/datasets/openclimatefix/nimrod-uk-1km/blob/main/nimrod-uk-1km.py#L41 of the script.\r\nMaybe @albertvillanova could confirm.",
"I'm having a look.",
"Indeed there are several issues in this dataset loading scri... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4443/reactions"
} | open | false | https://api.github.com/repos/huggingface/datasets/issues/4443 | https://github.com/huggingface/datasets/issues/4443 | false |
1,258,589,276 | https://api.github.com/repos/huggingface/datasets/issues/4442/labels{/name} | ### Link
https://huggingface.co/datasets/amazon_polarity/viewer/amazon_polarity/test
### Description
For some reason the train split is OK but the test split is not for this dataset:
```
Server error
Status code: 400
Exception: FileNotFoundError
Message: [Errno 2] No such file or directory: '/cache/modules/datasets_modules/datasets/amazon_polarity/__init__.py'
```
### Owner
No | 2022-06-07T18:50:37Z | 4,442 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "E5583E",
"default": false,
"description": "Related to the dataset viewer on huggingface.co",
"id": 3470211881,
"name": "dataset-viewer",
"node_id": "LA_kwDODunzps7O1zsp",
"url": "https://api.github.com/repos/huggingface/datasets/labels/dataset-viewer"
}
] | 2022-06-02T19:18:38Z | https://api.github.com/repos/huggingface/datasets/issues/4442/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url": "https://api.github.com/users/severo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/severo",
"id": 1676121,
"login": "severo",
"node_id": "MDQ6VXNlcjE2NzYxMjE=",
"organizations_url": "https://api.github.com/users/severo/orgs",
"received_events_url": "https://api.github.com/users/severo/received_events",
"repos_url": "https://api.github.com/users/severo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/severo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/severo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/severo"
} | https://api.github.com/repos/huggingface/datasets/issues/4442/timeline | Dataset Viewer issue for amazon_polarity | https://api.github.com/repos/huggingface/datasets/issues/4442/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/26859204?v=4",
"events_url": "https://api.github.com/users/lewtun/events{/privacy}",
"followers_url": "https://api.github.com/users/lewtun/followers",
"following_url": "https://api.github.com/users/lewtun/following{/other_user}",
"gists_url": "https://api.github.com/users/lewtun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lewtun",
"id": 26859204,
"login": "lewtun",
"node_id": "MDQ6VXNlcjI2ODU5MjA0",
"organizations_url": "https://api.github.com/users/lewtun/orgs",
"received_events_url": "https://api.github.com/users/lewtun/received_events",
"repos_url": "https://api.github.com/users/lewtun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lewtun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lewtun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lewtun"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url... | null | completed | MEMBER | 2022-06-07T18:50:37Z | null | I_kwDODunzps5LBIxc | [
"Thanks, looking at it",
"Not sure what happened 😬, but it's fixed"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4442/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4442 | https://github.com/huggingface/datasets/issues/4442 | false |
1,258,568,656 | https://api.github.com/repos/huggingface/datasets/issues/4441/labels{/name} | ### Link
https://huggingface.co/datasets/aeslc
### Description
The dataset viewer can't find `dataset_infos.json` in it's cache:
```
Server error
Status code: 400
Exception: FileNotFoundError
Message: [Errno 2] No such file or directory: '/cache/modules/datasets_modules/datasets/aeslc/eb8e30234cf984a58ebe9f205674597ac1db2ec91e7321cd7f36864f7e3671b8/dataset_infos.json'
```
### Owner
No | 2022-06-07T18:50:55Z | 4,441 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "E5583E",
"default": false,
"description": "Related to the dataset viewer on huggingface.co",
"id": 3470211881,
"name": "dataset-viewer",
"node_id": "LA_kwDODunzps7O1zsp",
"url": "https://api.github.com/repos/huggingface/datasets/labels/dataset-viewer"
}
] | 2022-06-02T18:57:12Z | https://api.github.com/repos/huggingface/datasets/issues/4441/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url": "https://api.github.com/users/severo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/severo",
"id": 1676121,
"login": "severo",
"node_id": "MDQ6VXNlcjE2NzYxMjE=",
"organizations_url": "https://api.github.com/users/severo/orgs",
"received_events_url": "https://api.github.com/users/severo/received_events",
"repos_url": "https://api.github.com/users/severo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/severo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/severo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/severo"
} | https://api.github.com/repos/huggingface/datasets/issues/4441/timeline | Dataset Viewer issue for aeslc | https://api.github.com/repos/huggingface/datasets/issues/4441/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/26859204?v=4",
"events_url": "https://api.github.com/users/lewtun/events{/privacy}",
"followers_url": "https://api.github.com/users/lewtun/followers",
"following_url": "https://api.github.com/users/lewtun/following{/other_user}",
"gists_url": "https://api.github.com/users/lewtun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lewtun",
"id": 26859204,
"login": "lewtun",
"node_id": "MDQ6VXNlcjI2ODU5MjA0",
"organizations_url": "https://api.github.com/users/lewtun/orgs",
"received_events_url": "https://api.github.com/users/lewtun/received_events",
"repos_url": "https://api.github.com/users/lewtun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lewtun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lewtun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lewtun"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url... | null | completed | MEMBER | 2022-06-07T18:50:55Z | null | I_kwDODunzps5LBDvQ | [
"Not sure what happened 😬, but it's fixed"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4441/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4441 | https://github.com/huggingface/datasets/issues/4441 | false |
1,258,494,469 | https://api.github.com/repos/huggingface/datasets/issues/4440/labels{/name} | As part of the strategy to center the docs around the different modalities, this PR updates the quickstart to include audio and vision examples. This improves the developer experience by making audio and vision content more discoverable, enabling users working in these modalities to also quickly get started without digging too deeply into the docs.
Other changes include:
- Moved the installation guide to the Get Started section because it should be part of a user's onboarding to the library before exploring tutorials or how-to's.
- Updated the native TF code at creating a `tf.data.Dataset` because it was throwing an error. The `to_tensor()` bit was redundant and removing it fixed the error (please double-check me here!).
- Added some UI components to the quickstart so it's easier for users to navigate directly to the relevant section with context about what to expect.
- Reverted to the code tabs for content that don't have any framework-specific text. I think this saves space compared to the code blocks. We'll still use the code blocks if the `torch` text is different from the `tf` text.
Let me know what you think, especially if we should include some code samples for training a model in the audio/vision sections. I left this out since we already showed it in the NLP section. I want to keep the focus on using Datasets to load and process a dataset, and not so much the training part. Maybe we can add links to the Transformers docs instead? | 2022-06-23T16:33:19Z | 4,440 | null | https://api.github.com/repos/huggingface/datasets | false | [
{
"color": "0075ca",
"default": true,
"description": "Improvements or additions to documentation",
"id": 1935892861,
"name": "documentation",
"node_id": "MDU6TGFiZWwxOTM1ODkyODYx",
"url": "https://api.github.com/repos/huggingface/datasets/labels/documentation"
}
] | 2022-06-02T17:42:03Z | https://api.github.com/repos/huggingface/datasets/issues/4440/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4440/timeline | Update docs around audio and vision | https://api.github.com/repos/huggingface/datasets/issues/4440/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4",
"events_url": "https://api.github.com/users/stevhliu/events{/privacy}",
"followers_url": "https://api.github.com/users/stevhliu/followers",
"following_url": "https://api.github.com/users/stevhliu/following{/other_user}",
"gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stevhliu",
"id": 59462357,
"login": "stevhliu",
"node_id": "MDQ6VXNlcjU5NDYyMzU3",
"organizations_url": "https://api.github.com/users/stevhliu/orgs",
"received_events_url": "https://api.github.com/users/stevhliu/received_events",
"repos_url": "https://api.github.com/users/stevhliu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stevhliu"
} | [] | null | null | MEMBER | 2022-06-23T16:23:02Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4440.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4440",
"merged_at": "2022-06-23T16:23:02Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4440.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4440"
} | PR_kwDODunzps44_io_ | [
"_The documentation is not available anymore as the PR was closed or merged._",
"> Let me know what you think, especially if we should include some code samples for training a model in the audio/vision sections. I left this out since we already showed it in the NLP section. I want to keep the focus on using Datas... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 1,
"hooray": 0,
"laugh": 0,
"rocket": 1,
"total_count": 2,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4440/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4440 | https://github.com/huggingface/datasets/pull/4440 | true |
1,258,434,111 | https://api.github.com/repos/huggingface/datasets/issues/4439/labels{/name} | ## Describe the bug
I get the message from HuggingFace that it must be downloaded manually. From the URL provided in the message, I got to UPenn page for manual download. (UPenn apparently want $250? for the dataset??) ...So, ok, I obtained a copy from a friend and also a smaller version from Kaggle. But in both cases the HF dataloader fails; it is looking for files that don't exist anywhere in the dataset: it is looking for files with lower-case letters like "**test*" (all the filenames in both my copies are uppercase) and certain file extensions that exclude the .DOC which is provided in TIMIT:
## Steps to reproduce the bug
```python
data = load_dataset('timit_asr', 'clean')['train']
```
## Expected results
The dataset should load with no errors.
## Actual results
This error message:
```
File "/home/ubuntu/envs/data2vec/lib/python3.9/site-packages/datasets/data_files.py", line 201, in resolve_patterns_locally_or_by_urls
raise FileNotFoundError(error_msg)
FileNotFoundError: Unable to resolve any data file that matches '['**test*', '**eval*']' at /home/ubuntu/datasets/timit with any supported extension ['csv', 'tsv', 'json', 'jsonl', 'parquet', 'txt', 'blp', 'bmp', 'dib', 'bufr', 'cur', 'pcx', 'dcx', 'dds', 'ps', 'eps', 'fit', 'fits', 'fli', 'flc', 'ftc', 'ftu', 'gbr', 'gif', 'grib', 'h5', 'hdf', 'png', 'apng', 'jp2', 'j2k', 'jpc', 'jpf', 'jpx', 'j2c', 'icns', 'ico', 'im', 'iim', 'tif', 'tiff', 'jfif', 'jpe', 'jpg', 'jpeg', 'mpg', 'mpeg', 'msp', 'pcd', 'pxr', 'pbm', 'pgm', 'ppm', 'pnm', 'psd', 'bw', 'rgb', 'rgba', 'sgi', 'ras', 'tga', 'icb', 'vda', 'vst', 'webp', 'wmf', 'emf', 'xbm', 'xpm', 'zip']
```
But this is a strange sort of error: why is it looking for lower-case file names when all the TIMIT dataset filenames are uppercase? Why does it exclude .DOC files when the only parts of the TIMIT data set with "TEST" in them have ".DOC" extensions? ...I wonder, how was anyone able to get this to work in the first place?
The files in the dataset look like the following:
```
³ PHONCODE.DOC
³ PROMPTS.TXT
³ SPKRINFO.TXT
³ SPKRSENT.TXT
³ TESTSET.DOC
```
...so why are these being excluded by the dataset loader?
## Environment info
- `datasets` version: 2.2.2
- Platform: Linux-5.4.0-1060-aws-x86_64-with-glibc2.27
- Python version: 3.9.9
- PyArrow version: 8.0.0
- Pandas version: 1.4.2
| 2022-06-03T08:44:17Z | 4,439 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-06-02T16:35:56Z | https://api.github.com/repos/huggingface/datasets/issues/4439/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4439/timeline | TIMIT won't load after manual download: Errors about files that don't exist | https://api.github.com/repos/huggingface/datasets/issues/4439/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/13925685?v=4",
"events_url": "https://api.github.com/users/drscotthawley/events{/privacy}",
"followers_url": "https://api.github.com/users/drscotthawley/followers",
"following_url": "https://api.github.com/users/drscotthawley/following{/other_user}",
"gists_url": "https://api.github.com/users/drscotthawley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/drscotthawley",
"id": 13925685,
"login": "drscotthawley",
"node_id": "MDQ6VXNlcjEzOTI1Njg1",
"organizations_url": "https://api.github.com/users/drscotthawley/orgs",
"received_events_url": "https://api.github.com/users/drscotthawley/received_events",
"repos_url": "https://api.github.com/users/drscotthawley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/drscotthawley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/drscotthawley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/drscotthawley"
} | [] | null | completed | NONE | 2022-06-03T08:44:16Z | null | I_kwDODunzps5LAi4_ | [
"To have some context, please see:\r\n- #4145\r\n\r\nPlease, also note that we have recently made some fixes to the script, which are in our GitHub master branch but not yet released:\r\n- #4422\r\n- #4425 \r\n- #4436",
"Thanks Albert! I'll try pulling `datasets` from the git repo instead of PyPI, and/or just wai... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4439/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4439 | https://github.com/huggingface/datasets/issues/4439 | false |
1,258,255,394 | https://api.github.com/repos/huggingface/datasets/issues/4438/labels{/name} | As pointed out by @sgugger:
- huggingface/doc-builder/issues/235 | 2022-06-02T16:40:55Z | 4,438 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-02T14:21:10Z | https://api.github.com/repos/huggingface/datasets/issues/4438/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4438/timeline | Fix docstring of inspect_dataset | https://api.github.com/repos/huggingface/datasets/issues/4438/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-02T16:32:27Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4438.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4438",
"merged_at": "2022-06-02T16:32:27Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4438.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4438"
} | PR_kwDODunzps44-vhC | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4438/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4438 | https://github.com/huggingface/datasets/pull/4438 | true |
1,258,249,582 | https://api.github.com/repos/huggingface/datasets/issues/4437/labels{/name} | Adds the missing columns to `blended_skill_talk` to align the loading logic with [ParlAI](https://github.com/facebookresearch/ParlAI/blob/main/parlai/tasks/blended_skill_talk/build.py).
Fix #4426 | 2022-06-06T15:49:56Z | 4,437 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-02T14:16:26Z | https://api.github.com/repos/huggingface/datasets/issues/4437/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4437/timeline | Add missing columns to `blended_skill_talk` | https://api.github.com/repos/huggingface/datasets/issues/4437/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | [] | null | null | CONTRIBUTOR | 2022-06-06T15:41:25Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4437.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4437",
"merged_at": "2022-06-06T15:41:25Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4437.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4437"
} | PR_kwDODunzps44-uRW | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4437/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4437 | https://github.com/huggingface/datasets/pull/4437 | true |
1,257,758,834 | https://api.github.com/repos/huggingface/datasets/issues/4436/labels{/name} | Related to:
- #4422 | 2022-06-02T09:32:56Z | 4,436 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-02T06:45:04Z | https://api.github.com/repos/huggingface/datasets/issues/4436/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4436/timeline | Fix directory names for LDC data in timit_asr dataset | https://api.github.com/repos/huggingface/datasets/issues/4436/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-02T09:24:27Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4436.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4436",
"merged_at": "2022-06-02T09:24:27Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4436.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4436"
} | PR_kwDODunzps449FsU | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4436/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4436 | https://github.com/huggingface/datasets/pull/4436 | true |
1,257,496,552 | https://api.github.com/repos/huggingface/datasets/issues/4435/labels{/name} | ## Describe the bug
I have loaded a dataset as follows:
```
d = load_dataset("emotion", split="validation")
```
Afterwards I make some modifications to the dataset via a `map` call:
```
d.map(some_update_func, cache_file_name=modified_dataset)
```
This generates a cached version of the dataset on my local system in the same directory as the original download of the data (/path/to/cache). Running an `ls` returns:
```
modified_dataset
dataset_info.json
emotion-test.arrow
emotion-train.arrow
emotion-validation.arrow
```
as expected. However, when I try to load up the modified cached dataset via a call to
```
modified = load_dataset("emotion", split="validation", data_files="/path/to/cache/modified_dataset")
```
it simply redownloads a new version of the dataset and dumps to a new cache rather than loading up the original modified dataset:
```
Using custom data configuration validation-cdbf51685638421b
Downloading and preparing dataset emotion/validation to ...
```
How am I supposed to load the original modified local cache copy of the dataset?
## Environment info
- `datasets` version: 2.2.2
- Platform: Linux-5.4.0-113-generic-x86_64-with-glibc2.17
- Python version: 3.8.13
- PyArrow version: 8.0.0
- Pandas version: 1.4.2
| 2022-06-02T23:59:26Z | 4,435 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-06-02T01:51:49Z | https://api.github.com/repos/huggingface/datasets/issues/4435/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4435/timeline | Load a local cached dataset that has been modified | https://api.github.com/repos/huggingface/datasets/issues/4435/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/2789441?v=4",
"events_url": "https://api.github.com/users/mihail911/events{/privacy}",
"followers_url": "https://api.github.com/users/mihail911/followers",
"following_url": "https://api.github.com/users/mihail911/following{/other_user}",
"gists_url": "https://api.github.com/users/mihail911/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mihail911",
"id": 2789441,
"login": "mihail911",
"node_id": "MDQ6VXNlcjI3ODk0NDE=",
"organizations_url": "https://api.github.com/users/mihail911/orgs",
"received_events_url": "https://api.github.com/users/mihail911/received_events",
"repos_url": "https://api.github.com/users/mihail911/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mihail911/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mihail911/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mihail911"
} | [] | null | completed | NONE | 2022-06-02T23:59:18Z | null | I_kwDODunzps5K89_o | [
"Hi! `datasets` caches every modification/loading, so you can either rerun the pipeline up to the `map` call or use `Dataset.from_file(modified_dataset)` to load the dataset directly from the cache file.",
"Awesome, hvala Mario! This works. "
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4435/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4435 | https://github.com/huggingface/datasets/issues/4435 | false |
1,256,207,321 | https://api.github.com/repos/huggingface/datasets/issues/4434/labels{/name} | It seems that when user specify nested _URLs structures in their dataset script. An error will be raised when generating dummy dataset.
I think the types of all elements in `dummy_data_dict.values()` should be checked because they may have different types.
Linked to issue #4428
PS: I am not sure whether my code fix this issue in a proper way. | 2022-06-07T12:08:28Z | 4,434 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-01T14:53:15Z | https://api.github.com/repos/huggingface/datasets/issues/4434/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4434/timeline | Fix dummy dataset generation script for handling nested types of _URLs | https://api.github.com/repos/huggingface/datasets/issues/4434/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/2529049?v=4",
"events_url": "https://api.github.com/users/silverriver/events{/privacy}",
"followers_url": "https://api.github.com/users/silverriver/followers",
"following_url": "https://api.github.com/users/silverriver/following{/other_user}",
"gists_url": "https://api.github.com/users/silverriver/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/silverriver",
"id": 2529049,
"login": "silverriver",
"node_id": "MDQ6VXNlcjI1MjkwNDk=",
"organizations_url": "https://api.github.com/users/silverriver/orgs",
"received_events_url": "https://api.github.com/users/silverriver/received_events",
"repos_url": "https://api.github.com/users/silverriver/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/silverriver/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/silverriver/subscriptions",
"type": "User",
"url": "https://api.github.com/users/silverriver"
} | [] | null | null | CONTRIBUTOR | 2022-06-07T09:24:09Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4434.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4434",
"merged_at": "2022-06-07T09:24:09Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4434.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4434"
} | PR_kwDODunzps443mAr | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4434/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4434 | https://github.com/huggingface/datasets/pull/4434 | true |
1,255,830,758 | https://api.github.com/repos/huggingface/datasets/issues/4433/labels{/name} | Fix #4348 | 2022-06-09T10:34:54Z | 4,433 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-01T12:09:56Z | https://api.github.com/repos/huggingface/datasets/issues/4433/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4433/timeline | Fix script fetching and local path handling in `inspect_dataset` and `inspect_metric` | https://api.github.com/repos/huggingface/datasets/issues/4433/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | [] | null | null | CONTRIBUTOR | 2022-06-09T10:26:07Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4433.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4433",
"merged_at": "2022-06-09T10:26:06Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4433.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4433"
} | PR_kwDODunzps442P5L | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Added back the `[:]` and a comment to explain why this is needed. "
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 1,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4433/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4433 | https://github.com/huggingface/datasets/pull/4433 | true |
1,255,523,720 | https://api.github.com/repos/huggingface/datasets/issues/4432/labels{/name} | Currently, the args of `DatasetBuilder` do not appear in the docs: https://huggingface.co/docs/datasets/v2.1.0/en/package_reference/builder_classes#datasets.DatasetBuilder | 2022-06-02T17:43:47Z | 4,432 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-01T09:45:30Z | https://api.github.com/repos/huggingface/datasets/issues/4432/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4432/timeline | Fix builder docstring | https://api.github.com/repos/huggingface/datasets/issues/4432/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-02T17:35:15Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4432.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4432",
"merged_at": "2022-06-02T17:35:15Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4432.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4432"
} | PR_kwDODunzps441JmK | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4432/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4432 | https://github.com/huggingface/datasets/pull/4432 | true |
1,254,618,948 | https://api.github.com/repos/huggingface/datasets/issues/4431/labels{/name} | It seems that all tests are passed | 2022-06-11T12:40:23Z | 4,431 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-06-01T01:20:40Z | https://api.github.com/repos/huggingface/datasets/issues/4431/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4431/timeline | Add personaldialog datasets | https://api.github.com/repos/huggingface/datasets/issues/4431/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/2529049?v=4",
"events_url": "https://api.github.com/users/silverriver/events{/privacy}",
"followers_url": "https://api.github.com/users/silverriver/followers",
"following_url": "https://api.github.com/users/silverriver/following{/other_user}",
"gists_url": "https://api.github.com/users/silverriver/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/silverriver",
"id": 2529049,
"login": "silverriver",
"node_id": "MDQ6VXNlcjI1MjkwNDk=",
"organizations_url": "https://api.github.com/users/silverriver/orgs",
"received_events_url": "https://api.github.com/users/silverriver/received_events",
"repos_url": "https://api.github.com/users/silverriver/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/silverriver/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/silverriver/subscriptions",
"type": "User",
"url": "https://api.github.com/users/silverriver"
} | [] | null | null | CONTRIBUTOR | 2022-06-11T12:31:16Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4431.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4431",
"merged_at": null,
"patch_url": "https://github.com/huggingface/datasets/pull/4431.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4431"
} | PR_kwDODunzps44x5aG | [
"These test errors are related to issue #4428 \r\n",
"_The documentation is not available anymore as the PR was closed or merged._",
"I only made a trivial modification in my commit https://github.com/huggingface/datasets/pull/4431/commits/402c893d35224d7828176717233909ac5f1e7b3e\r\n\r\nI have submitted a PR #4... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4431/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4431 | https://github.com/huggingface/datasets/pull/4431 | true |
1,254,412,591 | https://api.github.com/repos/huggingface/datasets/issues/4430/labels{/name} | **Is your feature request related to a problem? Please describe.**
The [Multi-News dataloader points to the original version of the Multi-News dataset](https://github.com/huggingface/datasets/blob/12540dd75015678ec6019f258d811ee107439a73/datasets/multi_news/multi_news.py#L47), but this has [known errors in it](https://github.com/Alex-Fabbri/Multi-News/issues/11). There exists a [newer version which fixes some of these issues](https://drive.google.com/open?id=1jwBzXBVv8sfnFrlzPnSUBHEEAbpIUnFq).
Unfortunately I don't think you can just replace this old URL with the new one, otherwise this could lead to issues with reproducibility.
**Describe the solution you'd like**
Add a new version to the Multi-News dataloader that points to the updated dataset which has fixes for some known issues.
**Describe alternatives you've considered**
Replace the current URL to the original version to the dataset with the URL to the version with fixes.
**Additional context**
Would be happy to make a PR for this, could someone maybe point me to another dataloader that has multiple versions so I can see how this is handled in `datasets`?
| 2022-06-07T17:14:44Z | 4,430 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "a2eeef",
"default": true,
"description": "New feature or request",
"id": 1935892871,
"name": "enhancement",
"node_id": "MDU6TGFiZWwxOTM1ODkyODcx",
"url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement"
}
] | 2022-05-31T21:00:44Z | https://api.github.com/repos/huggingface/datasets/issues/4430/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4430/timeline | Add ability to load newer, cleaner version of Multi-News | https://api.github.com/repos/huggingface/datasets/issues/4430/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8917831?v=4",
"events_url": "https://api.github.com/users/JohnGiorgi/events{/privacy}",
"followers_url": "https://api.github.com/users/JohnGiorgi/followers",
"following_url": "https://api.github.com/users/JohnGiorgi/following{/other_user}",
"gists_url": "https://api.github.com/users/JohnGiorgi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JohnGiorgi",
"id": 8917831,
"login": "JohnGiorgi",
"node_id": "MDQ6VXNlcjg5MTc4MzE=",
"organizations_url": "https://api.github.com/users/JohnGiorgi/orgs",
"received_events_url": "https://api.github.com/users/JohnGiorgi/received_events",
"repos_url": "https://api.github.com/users/JohnGiorgi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JohnGiorgi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JohnGiorgi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JohnGiorgi"
} | [] | null | completed | CONTRIBUTOR | 2022-06-07T17:14:44Z | null | I_kwDODunzps5KxNEv | [
"Hi! Our versioning is based on Git revisions (the `revision` param in `load_dataset`), so you can just replace the old URL with the new one and open a PR :). I can also give you some pointers if needed.",
"@mariosasko Awesome thanks! I will do that. Looks like this new version of the data is not available as a z... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4430/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4430 | https://github.com/huggingface/datasets/issues/4430 | false |
1,254,184,358 | https://api.github.com/repos/huggingface/datasets/issues/4429/labels{/name} | This PR updates the builder docstring with deprecated/added directives for arguments name/config_name.
Follow up of:
- #4414
- huggingface/doc-builder#233
First merge:
- #4432 | 2022-06-08T11:40:18Z | 4,429 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-31T17:37:25Z | https://api.github.com/repos/huggingface/datasets/issues/4429/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4429/timeline | Update builder docstring for deprecated/added arguments | https://api.github.com/repos/huggingface/datasets/issues/4429/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-08T11:31:45Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4429.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4429",
"merged_at": "2022-06-08T11:31:45Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4429.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4429"
} | PR_kwDODunzps44whxN | [
"_The documentation is not available anymore as the PR was closed or merged._",
"@mishig25 is investigating why deprecated/added do not affect the enclosed text format when used in args docstring: no special formatting appears: \r\n- https://moon-ci-docs.huggingface.co/docs/datasets/pr_4429/en/package_reference/b... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4429/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4429 | https://github.com/huggingface/datasets/pull/4429 | true |
1,254,092,818 | https://api.github.com/repos/huggingface/datasets/issues/4428/labels{/name} | ## Describe the bug
When making dummy data with the `datasets-cli dummy_data` tool,
an error will be raised if you use a nested _URLS in your dataset script.
Traceback (most recent call last):
File "/home/name/LCCC/datasets/src/datasets/commands/datasets_cli.py", line 43, in <module>
main()
File "/home/name/LCCC/datasets/src/datasets/commands/datasets_cli.py", line 39, in main
service.run()
File "/home/name/LCCC/datasets/src/datasets/commands/dummy_data.py", line 311, in run
self._autogenerate_dummy_data(
File "/home/name/LCCC/datasets/src/datasets/commands/dummy_data.py", line 337, in _autogenerate_dummy_data
dataset_builder._split_generators(dl_manager)
File "/home/name/.cache/huggingface/modules/datasets_modules/datasets/personal_dialog/559332bced5eeafa7f7efc2a7c10ce02cee2a8116bbab4611c35a50ba2715b77/personal_dialog.py", line 108, in _split_generators
data_dir = dl_manager.download_and_extract(urls)
File "/home/name/LCCC/datasets/src/datasets/commands/dummy_data.py", line 56, in download_and_extract
dummy_output = self.mock_download_manager.download(url_or_urls)
File "/home/name/LCCC/datasets/src/datasets/download/mock_download_manager.py", line 130, in download
return self.download_and_extract(data_url)
File "/home/name/LCCC/datasets/src/datasets/download/mock_download_manager.py", line 122, in download_and_extract
return self.create_dummy_data_dict(dummy_file, data_url)
File "/home/name/LCCC/datasets/src/datasets/download/mock_download_manager.py", line 165, in create_dummy_data_dict
if isinstance(first_value, str) and len(set(dummy_data_dict.values())) < len(dummy_data_dict.values()):
TypeError: unhashable type: 'list'
## Steps to reproduce the bug
You can use my dataset script implemented here:
https://github.com/silverriver/datasets/blob/2ecd36760c40b8e29b1137cd19b5bad0e19c76fd/datasets/personal_dialog/personal_dialog.py
```python
datasets_cli dummy_data datasets/personal_dialog --auto_generate
```
You can change https://github.com/silverriver/datasets/blob/2ecd36760c40b8e29b1137cd19b5bad0e19c76fd/datasets/personal_dialog/personal_dialog.py#L54
to
```
"train": "https://huggingface.co/datasets/silver/personal_dialog/resolve/main/dev_random.jsonl.gz"
```
before runing the above script to avoid downloading a large training data.
## Expected results
The dummy data should be generated
## Actual results
An error is raised.
It seems that in https://github.com/huggingface/datasets/blob/12540dd75015678ec6019f258d811ee107439a73/src/datasets/download/mock_download_manager.py#L165
We only check if the first item of dummy_data_dict.values() is str.
However, dummy_data_dict.values() may have the type of [str, list, list].
A simple fix would be changing https://github.com/huggingface/datasets/blob/12540dd75015678ec6019f258d811ee107439a73/src/datasets/download/mock_download_manager.py#L165 to
```python
if all([isinstance(value, str) for value in dummy_data_dict.values()]) and len(set(dummy_data_dict.values())) < len(dummy_data_dict.values()):
```
But I don't know if this kinds of change may bring any side effect since I am not sure about the detail logic here.
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version:
- Platform: Linux
- Python version: Python 3.9.10
- PyArrow version: 7.0.0
| 2022-06-07T09:24:09Z | 4,428 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-31T16:10:57Z | https://api.github.com/repos/huggingface/datasets/issues/4428/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4428/timeline | Errors when building dummy data if you use nested _URLS | https://api.github.com/repos/huggingface/datasets/issues/4428/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/2529049?v=4",
"events_url": "https://api.github.com/users/silverriver/events{/privacy}",
"followers_url": "https://api.github.com/users/silverriver/followers",
"following_url": "https://api.github.com/users/silverriver/following{/other_user}",
"gists_url": "https://api.github.com/users/silverriver/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/silverriver",
"id": 2529049,
"login": "silverriver",
"node_id": "MDQ6VXNlcjI1MjkwNDk=",
"organizations_url": "https://api.github.com/users/silverriver/orgs",
"received_events_url": "https://api.github.com/users/silverriver/received_events",
"repos_url": "https://api.github.com/users/silverriver/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/silverriver/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/silverriver/subscriptions",
"type": "User",
"url": "https://api.github.com/users/silverriver"
} | [] | null | completed | CONTRIBUTOR | 2022-06-07T09:24:09Z | null | I_kwDODunzps5Kv_AS | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4428/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4428 | https://github.com/huggingface/datasets/issues/4428 | false |
1,253,959,313 | https://api.github.com/repos/huggingface/datasets/issues/4427/labels{/name} | As in https://github.com/huggingface/transformers/pull/17485, issues and PR for datasets under a namespace have to be on the HF Hub | 2022-06-01T12:37:42Z | 4,427 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-31T14:31:21Z | https://api.github.com/repos/huggingface/datasets/issues/4427/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4427/timeline | Add HF.co for PRs/Issues for specific datasets | https://api.github.com/repos/huggingface/datasets/issues/4427/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | 2022-06-01T12:29:02Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4427.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4427",
"merged_at": "2022-06-01T12:29:02Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4427.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4427"
} | PR_kwDODunzps44vyGg | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4427/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4427 | https://github.com/huggingface/datasets/pull/4427 | true |
1,253,887,311 | https://api.github.com/repos/huggingface/datasets/issues/4426/labels{/name} | **Is your feature request related to a problem? Please describe.**
The original dataset `blended_skill_talk` consists of different sets of columns for the different splits: (test/valid) splits have additional data column `label_candidates` that the (train) doesn't have.
When loading such data, an exception occurs at table.py:cast_table_to_schema, because of mismatched columns. | 2022-06-03T16:25:25Z | 4,426 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "a2eeef",
"default": true,
"description": "New feature or request",
"id": 1935892871,
"name": "enhancement",
"node_id": "MDU6TGFiZWwxOTM1ODkyODcx",
"url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement"
}
] | 2022-05-31T13:40:16Z | https://api.github.com/repos/huggingface/datasets/issues/4426/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4426/timeline | Add loading variable number of columns for different splits | https://api.github.com/repos/huggingface/datasets/issues/4426/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/22641583?v=4",
"events_url": "https://api.github.com/users/DrMatters/events{/privacy}",
"followers_url": "https://api.github.com/users/DrMatters/followers",
"following_url": "https://api.github.com/users/DrMatters/following{/other_user}",
"gists_url": "https://api.github.com/users/DrMatters/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DrMatters",
"id": 22641583,
"login": "DrMatters",
"node_id": "MDQ6VXNlcjIyNjQxNTgz",
"organizations_url": "https://api.github.com/users/DrMatters/orgs",
"received_events_url": "https://api.github.com/users/DrMatters/received_events",
"repos_url": "https://api.github.com/users/DrMatters/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DrMatters/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DrMatters/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DrMatters"
} | [] | null | completed | NONE | 2022-06-03T16:25:25Z | null | I_kwDODunzps5KvM1P | [
"Hi! Indeed the column is missing, but you shouldn't get an error? Have you made some modifications (locally) to the loading script? I've opened a PR to add the missing columns to the script. "
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4426/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4426 | https://github.com/huggingface/datasets/issues/4426 | false |
1,253,641,604 | https://api.github.com/repos/huggingface/datasets/issues/4425/labels{/name} | Related to #4422. | 2022-06-01T14:15:30Z | 4,425 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-31T10:10:04Z | https://api.github.com/repos/huggingface/datasets/issues/4425/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4425/timeline | Make extensions case-insensitive in timit_asr dataset | https://api.github.com/repos/huggingface/datasets/issues/4425/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-01T14:06:51Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4425.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4425",
"merged_at": "2022-06-01T14:06:51Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4425.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4425"
} | PR_kwDODunzps44uuDq | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4425/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4425 | https://github.com/huggingface/datasets/pull/4425 | true |
1,253,542,488 | https://api.github.com/repos/huggingface/datasets/issues/4424/labels{/name} | Fix #4422. | 2022-05-31T13:50:50Z | 4,424 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-31T08:47:45Z | https://api.github.com/repos/huggingface/datasets/issues/4424/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4424/timeline | Fix DuplicatedKeysError in timit_asr dataset | https://api.github.com/repos/huggingface/datasets/issues/4424/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-31T13:42:31Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4424.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4424",
"merged_at": "2022-05-31T13:42:31Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4424.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4424"
} | PR_kwDODunzps44uZBD | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4424/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4424 | https://github.com/huggingface/datasets/pull/4424 | true |
1,253,326,023 | https://api.github.com/repos/huggingface/datasets/issues/4423/labels{/name} | Hi, I am adding a new dataset MMChat.
It seems that all tests are passed | 2022-06-11T12:40:52Z | 4,423 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-31T04:45:07Z | https://api.github.com/repos/huggingface/datasets/issues/4423/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4423/timeline | Add new dataset MMChat | https://api.github.com/repos/huggingface/datasets/issues/4423/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/2529049?v=4",
"events_url": "https://api.github.com/users/silverriver/events{/privacy}",
"followers_url": "https://api.github.com/users/silverriver/followers",
"following_url": "https://api.github.com/users/silverriver/following{/other_user}",
"gists_url": "https://api.github.com/users/silverriver/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/silverriver",
"id": 2529049,
"login": "silverriver",
"node_id": "MDQ6VXNlcjI1MjkwNDk=",
"organizations_url": "https://api.github.com/users/silverriver/orgs",
"received_events_url": "https://api.github.com/users/silverriver/received_events",
"repos_url": "https://api.github.com/users/silverriver/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/silverriver/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/silverriver/subscriptions",
"type": "User",
"url": "https://api.github.com/users/silverriver"
} | [] | null | null | CONTRIBUTOR | 2022-06-11T12:31:42Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4423.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4423",
"merged_at": null,
"patch_url": "https://github.com/huggingface/datasets/pull/4423.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4423"
} | PR_kwDODunzps44trdP | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Thanks ! As for https://github.com/huggingface/datasets/pull/4431 please also update the licensing section in https://huggingface.co/datasets/silver/mmchat ;)\r\n\r\nThen if it's fine for you feel free to close this PR"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4423/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4423 | https://github.com/huggingface/datasets/pull/4423 | true |
1,253,146,511 | https://api.github.com/repos/huggingface/datasets/issues/4422/labels{/name} | ## Describe the bug
I am trying to load the timit_asr data set. I have tried with a copy from the LDC, and a copy from deepai. In both cases they fail with a "duplicate key" error. With the LDC version I have to convert the file extensions all to upper-case before I can load it at all.
## Steps to reproduce the bug
```python
timit = datasets.load_dataset("timit_asr", data_dir = "/path/to/dataset")
# Sample code to reproduce the bug
```
## Expected results
The data set should load without error. It worked for me before the LDC url change.
## Actual results
```
datasets.keyhash.DuplicatedKeysError: FAILURE TO GENERATE DATASET !
Found duplicate Key: SA1
Keys should be unique and deterministic in nature
```
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version:
- `datasets` version: 2.2.2
- Platform: Linux-5.4.0-90-generic-x86_64-with-glibc2.17
- Python version: 3.8.12
- PyArrow version: 8.0.0
- Pandas version: 1.4.2
| 2022-06-02T06:34:05Z | 4,422 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-30T22:00:22Z | https://api.github.com/repos/huggingface/datasets/issues/4422/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4422/timeline | Cannot load timit_asr data set | https://api.github.com/repos/huggingface/datasets/issues/4422/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/992795?v=4",
"events_url": "https://api.github.com/users/bhaddow/events{/privacy}",
"followers_url": "https://api.github.com/users/bhaddow/followers",
"following_url": "https://api.github.com/users/bhaddow/following{/other_user}",
"gists_url": "https://api.github.com/users/bhaddow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bhaddow",
"id": 992795,
"login": "bhaddow",
"node_id": "MDQ6VXNlcjk5Mjc5NQ==",
"organizations_url": "https://api.github.com/users/bhaddow/orgs",
"received_events_url": "https://api.github.com/users/bhaddow/received_events",
"repos_url": "https://api.github.com/users/bhaddow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bhaddow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bhaddow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bhaddow"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | NONE | 2022-05-31T13:42:31Z | null | I_kwDODunzps5KsX-P | [
"Thanks for reporting, @bhaddow.\r\n\r\nI'm fixing it.",
"Thanks for the quick fix!",
"@bhaddow we have also made a fix so that you don't have to convert to uppercase the file extensions of the LDC data.\r\n\r\nWould you mind checking if it works OK now for you and reporting if there are any issues? Thanks. ",
... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4422/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4422 | https://github.com/huggingface/datasets/issues/4422 | false |
1,253,059,467 | https://api.github.com/repos/huggingface/datasets/issues/4421/labels{/name} | This change enables loading bzipped datasets, just like any other compressed dataset. | 2022-06-06T15:22:50Z | 4,421 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-30T19:19:40Z | https://api.github.com/repos/huggingface/datasets/issues/4421/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4421/timeline | Add extractor for bzip2-compressed files | https://api.github.com/repos/huggingface/datasets/issues/4421/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/2910707?v=4",
"events_url": "https://api.github.com/users/osyvokon/events{/privacy}",
"followers_url": "https://api.github.com/users/osyvokon/followers",
"following_url": "https://api.github.com/users/osyvokon/following{/other_user}",
"gists_url": "https://api.github.com/users/osyvokon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/osyvokon",
"id": 2910707,
"login": "osyvokon",
"node_id": "MDQ6VXNlcjI5MTA3MDc=",
"organizations_url": "https://api.github.com/users/osyvokon/orgs",
"received_events_url": "https://api.github.com/users/osyvokon/received_events",
"repos_url": "https://api.github.com/users/osyvokon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/osyvokon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/osyvokon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/osyvokon"
} | [] | null | null | CONTRIBUTOR | 2022-06-06T15:22:50Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4421.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4421",
"merged_at": "2022-06-06T15:22:49Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4421.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4421"
} | PR_kwDODunzps44szxR | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4421/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4421 | https://github.com/huggingface/datasets/pull/4421 | true |
1,252,739,239 | https://api.github.com/repos/huggingface/datasets/issues/4420/labels{/name} | ## Describe the bug
Metric evaluation fails in multi-node within a shared file system, because the master process cannot find the lock files from other nodes. (This issue was originally mentioned in the transformers repo https://github.com/huggingface/transformers/issues/17412)
## Steps to reproduce the bug
1. clone [this huggingface model](https://huggingface.co/PereLluis13/wav2vec2-xls-r-300m-ca-lm) and replace the `run_speech_recognition_ctc.py` script with the version in the gist [here](https://gist.github.com/gullabi/3f66094caa8db1c1e615dd35bd67ec71#file-run_speech_recognition_ctc-py).
2. Setup the `venv` according to the requirements of the model file plus `datasets==2.0.0`, `transformers==4.18.0` and `torch==1.9.0`
3. Launch the runner in a distributed environment which has a shared file system for two nodes, preferably with SLURM. Example [here](https://gist.github.com/gullabi/3f66094caa8db1c1e615dd35bd67ec71)
Specifically for the datasets, for the distributed setup the `load_metric` is called as:
```
process_id=int(os.environ["RANK"])
num_process=int(os.environ["WORLD_SIZE"])
eval_metrics = {metric: load_metric(metric,
process_id=process_id,
num_process=num_process,
experiment_id="slurm")
for metric in data_args.eval_metrics}
```
## Expected results
The training should not fail, due to the failure of the `Metric.compute()` step.
## Actual results
For the test I am executing the world size is 4, with 2 GPUs in 2 nodes. However the process is not finding the necessary lock files
```
File "/gpfs/projects/bsc88/speech/asr/wav2vec2-xls-r-300m-ca-lm/run_speech_recognition_ctc.py", line 841, in <module>
main()
File "/gpfs/projects/bsc88/speech/asr/wav2vec2-xls-r-300m-ca-lm/run_speech_recognition_ctc.py", line 792, in main
train_result = trainer.train(resume_from_checkpoint=checkpoint)
File "/gpfs/projects/bsc88/projects/speech-tech-resources/venv_amd_speech/lib/python3.7/site-packages/transformers/trainer.py", line 1497, in train
self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
File "/gpfs/projects/bsc88/projects/speech-tech-resources/venv_amd_speech/lib/python3.7/site-packages/transformers/trainer.py", line 1624, in _maybe_log_save_evaluate
metrics = self.evaluate(ignore_keys=ignore_keys_for_eval)
File "/gpfs/projects/bsc88/projects/speech-tech-resources/venv_amd_speech/lib/python3.7/site-packages/transformers/trainer.py", line 2291, in evaluate
metric_key_prefix=metric_key_prefix,
File "/gpfs/projects/bsc88/projects/speech-tech-resources/venv_amd_speech/lib/python3.7/site-packages/transformers/trainer.py", line 2535, in evaluation_loop
metrics = self.compute_metrics(EvalPrediction(predictions=all_preds, label_ids=all_labels))
File "/gpfs/projects/bsc88/speech/asr/wav2vec2-xls-r-300m-ca-lm/run_speech_recognition_ctc.py", line 742, in compute_metrics
metrics = {k: v.compute(predictions=pred_str, references=label_str) for k, v in eval_metrics.items()}
File "/gpfs/projects/bsc88/speech/asr/wav2vec2-xls-r-300m-ca-lm/run_speech_recognition_ctc.py", line 742, in <dictcomp>
metrics = {k: v.compute(predictions=pred_str, references=label_str) for k, v in eval_metrics.items()}
File "/gpfs/projects/bsc88/projects/speech-tech-resources/venv_amd_speech/lib/python3.7/site-packages/datasets/metric.py", line 419, in compute
self.add_batch(**inputs)
File "/gpfs/projects/bsc88/projects/speech-tech-resources/venv_amd_speech/lib/python3.7/site-packages/datasets/metric.py", line 465, in add_batch
self._init_writer()
File "/gpfs/projects/bsc88/projects/speech-tech-resources/venv_amd_speech/lib/python3.7/site-packages/datasets/metric.py", line 552, in _init_writer
self._check_rendez_vous() # wait for master to be ready and to let everyone go
File "/gpfs/projects/bsc88/projects/speech-tech-resources/venv_amd_speech/lib/python3.7/site-packages/datasets/metric.py", line 342, in _check_rendez_vous
) from None
ValueError: Expected to find locked file /home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-0.arrow.lock from process 3 but it doesn't exist.
```
When I look at the cache directory, I can see all the lock files in principle:
```
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-0.arrow
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-0.arrow.lock
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-1.arrow
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-1.arrow.lock
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-2.arrow
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-2.arrow.lock
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-3.arrow
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-3.arrow.lock
/home/bsc88/bsc88474/.cache/huggingface/metrics/wer/default/slurm-4-rdv.lock
```
I see that there was another related issue here https://github.com/huggingface/datasets/issues/1942, but it seems to have resolved via https://github.com/huggingface/datasets/pull/1966. Let me know if there is problem with how I am calling the `load_metric` or whether I need to make changes to the `.compute()` steps.
## Environment info
- `datasets` version: 2.0.0
- Platform: Linux-4.18.0-147.8.1.el8_1.x86_64-x86_64-with-centos-8.1.1911-Core
- Python version: 3.7.4
- PyArrow version: 7.0.0
- Pandas version: 1.3.0
| 2023-07-11T09:33:18Z | 4,420 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-30T13:24:05Z | https://api.github.com/repos/huggingface/datasets/issues/4420/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4420/timeline | Metric evaluation problems in multi-node, shared file system | https://api.github.com/repos/huggingface/datasets/issues/4420/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/40303490?v=4",
"events_url": "https://api.github.com/users/gullabi/events{/privacy}",
"followers_url": "https://api.github.com/users/gullabi/followers",
"following_url": "https://api.github.com/users/gullabi/following{/other_user}",
"gists_url": "https://api.github.com/users/gullabi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gullabi",
"id": 40303490,
"login": "gullabi",
"node_id": "MDQ6VXNlcjQwMzAzNDkw",
"organizations_url": "https://api.github.com/users/gullabi/orgs",
"received_events_url": "https://api.github.com/users/gullabi/received_events",
"repos_url": "https://api.github.com/users/gullabi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gullabi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gullabi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gullabi"
} | [] | null | completed | NONE | 2023-07-11T09:33:17Z | null | I_kwDODunzps5Kq0in | [
"If you call `metric.compute` in a distributed setup like yours, then `metric.compute` is called in each process. `metric.compute` first calls `metric.add_batch`, and it looks like your error appears at that stage.\r\n\r\nTo make sure that all the processes have started writing their predictions/references at the s... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4420/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4420 | https://github.com/huggingface/datasets/issues/4420 | false |
1,252,652,896 | https://api.github.com/repos/huggingface/datasets/issues/4419/labels{/name} | **Is your feature request related to a problem? Please describe.**
So this is more a readability improvement rather than a proposal, wouldn't it be better to use `assertTupleEqual` over the tuples rather than `assertEqual`? As `unittest` added that function in `v3.1`, as detailed at https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertTupleEqual, so maybe it's worth updating.
Find an example of an `assertEqual` over a tuple in 🤗 `datasets` unit tests over an `ArrowDataset` at https://github.com/huggingface/datasets/blob/0bb47271910c8a0b628dba157988372307fca1d2/tests/test_arrow_dataset.py#L570
**Describe the solution you'd like**
Start slowly replacing all the `assertEqual` statements with `assertTupleEqual` if the assertion is done over a Python tuple, as we're doing with the Python lists using `assertListEqual` rather than `assertEqual`.
**Additional context**
If so, please let me know and I'll try to go over the tests and create a PR if applicable, otherwise, if you consider this should stay as `assertEqual` rather than `assertSequenceEqual` feel free to close this issue! Thanks 🤗
| 2022-09-30T16:01:37Z | 4,419 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "a2eeef",
"default": true,
"description": "New feature or request",
"id": 1935892871,
"name": "enhancement",
"node_id": "MDU6TGFiZWwxOTM1ODkyODcx",
"url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement"
}
] | 2022-05-30T12:13:18Z | https://api.github.com/repos/huggingface/datasets/issues/4419/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4419/timeline | Update `unittest` assertions over tuples from `assertEqual` to `assertTupleEqual` | https://api.github.com/repos/huggingface/datasets/issues/4419/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/36760800?v=4",
"events_url": "https://api.github.com/users/alvarobartt/events{/privacy}",
"followers_url": "https://api.github.com/users/alvarobartt/followers",
"following_url": "https://api.github.com/users/alvarobartt/following{/other_user}",
"gists_url": "https://api.github.com/users/alvarobartt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alvarobartt",
"id": 36760800,
"login": "alvarobartt",
"node_id": "MDQ6VXNlcjM2NzYwODAw",
"organizations_url": "https://api.github.com/users/alvarobartt/orgs",
"received_events_url": "https://api.github.com/users/alvarobartt/received_events",
"repos_url": "https://api.github.com/users/alvarobartt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alvarobartt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alvarobartt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alvarobartt"
} | [] | null | completed | CONTRIBUTOR | 2022-09-30T16:01:37Z | null | I_kwDODunzps5Kqfdg | [
"Hi! If the only goal is to improve readability, it's better to use `assertTupleEqual` than `assertSequenceEqual` for Python tuples. Also, note that this function is called internally by `assertEqual`, but I guess we can accept a PR to be more verbose.",
"Hi @mariosasko, right! I'll update the issue title/desc wi... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4419/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4419 | https://github.com/huggingface/datasets/issues/4419 | false |
1,252,506,268 | https://api.github.com/repos/huggingface/datasets/issues/4418/labels{/name} | null | 2022-05-30T14:58:18Z | 4,418 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-30T10:10:40Z | https://api.github.com/repos/huggingface/datasets/issues/4418/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4418/timeline | Add dataset MMChat | https://api.github.com/repos/huggingface/datasets/issues/4418/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/2529049?v=4",
"events_url": "https://api.github.com/users/silverriver/events{/privacy}",
"followers_url": "https://api.github.com/users/silverriver/followers",
"following_url": "https://api.github.com/users/silverriver/following{/other_user}",
"gists_url": "https://api.github.com/users/silverriver/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/silverriver",
"id": 2529049,
"login": "silverriver",
"node_id": "MDQ6VXNlcjI1MjkwNDk=",
"organizations_url": "https://api.github.com/users/silverriver/orgs",
"received_events_url": "https://api.github.com/users/silverriver/received_events",
"repos_url": "https://api.github.com/users/silverriver/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/silverriver/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/silverriver/subscriptions",
"type": "User",
"url": "https://api.github.com/users/silverriver"
} | [] | null | null | CONTRIBUTOR | 2022-05-30T14:58:18Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4418.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4418",
"merged_at": null,
"patch_url": "https://github.com/huggingface/datasets/pull/4418.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4418"
} | PR_kwDODunzps44q9pG | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4418/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4418 | https://github.com/huggingface/datasets/pull/4418 | true |
1,251,933,091 | https://api.github.com/repos/huggingface/datasets/issues/4417/labels{/name} | ### Link
_No response_
### Description
Hey there, I have used seqio to get a well distributed mixture of samples from multiple dataset. However the resultant output from seqio is a python generator dict, which I cannot produce back into huggingface dataset.
The generator contains all the samples needed for training the model but I cannot convert it into a huggingface dataset.
The code looks like this:
```
for ex in seqio_data:
print(ex[“text”])
```
I need to convert the seqio_data (generator) into huggingface dataset.
the complete seqio code goes here:
```
import functools
import seqio
import tensorflow as tf
import t5.data
from datasets import load_dataset
from t5.data import postprocessors
from t5.data import preprocessors
from t5.evaluation import metrics
from seqio import FunctionDataSource, utils
TaskRegistry = seqio.TaskRegistry
def gen_dataset(split, shuffle=False, seed=None, column="text", dataset_params=None):
dataset = load_dataset(**dataset_params)
if shuffle:
if seed:
dataset = dataset.shuffle(seed=seed)
else:
dataset = dataset.shuffle()
while True:
for item in dataset[str(split)]:
yield item[column]
def dataset_fn(split, shuffle_files, seed=None, dataset_params=None):
return tf.data.Dataset.from_generator(
functools.partial(gen_dataset, split, shuffle_files, seed, dataset_params=dataset_params),
output_signature=tf.TensorSpec(shape=(), dtype=tf.string, name=dataset_name)
)
@utils.map_over_dataset
def target_to_key(x, key_map, target_key):
"""Assign the value from the dataset to target_key in key_map"""
return {**key_map, target_key: x}
dataset_name = 'oscar-corpus/OSCAR-2109'
subset= 'mr'
dataset_params = {"path": dataset_name, "language":subset, "use_auth_token":True}
dataset_shapes = None
TaskRegistry.add(
"oscar_marathi_corpus",
source=seqio.FunctionDataSource(
dataset_fn=functools.partial(dataset_fn, dataset_params=dataset_params),
splits=("train", "validation"),
caching_permitted=False,
num_input_examples=dataset_shapes,
),
preprocessors=[
functools.partial(
target_to_key, key_map={
"targets": None,
}, target_key="targets")],
output_features={"targets": seqio.Feature(vocabulary=seqio.PassThroughVocabulary, add_eos=False, dtype=tf.string, rank=0)},
metric_fns=[]
)
dataset = seqio.get_mixture_or_task("oscar_marathi_corpus").get_dataset(
sequence_length=None,
split="train",
shuffle=True,
num_epochs=1,
shard_info=seqio.ShardInfo(index=0, num_shards=10),
use_cached=False,
seed=42
)
for _, ex in zip(range(5), dataset):
print(ex['targets'].numpy().decode())
```
### Owner
_No response_ | 2022-09-16T14:44:19Z | 4,417 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d876e3",
"default": true,
"description": "Further information is requested",
"id": 1935892912,
"name": "question",
"node_id": "MDU6TGFiZWwxOTM1ODkyOTEy",
"url": "https://api.github.com/repos/huggingface/datasets/labels/question"
}
] | 2022-05-29T16:28:27Z | https://api.github.com/repos/huggingface/datasets/issues/4417/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | https://api.github.com/repos/huggingface/datasets/issues/4417/timeline | how to convert a dict generator into a huggingface dataset. | https://api.github.com/repos/huggingface/datasets/issues/4417/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/32235549?v=4",
"events_url": "https://api.github.com/users/StephennFernandes/events{/privacy}",
"followers_url": "https://api.github.com/users/StephennFernandes/followers",
"following_url": "https://api.github.com/users/StephennFernandes/following{/other_user}",
"gists_url": "https://api.github.com/users/StephennFernandes/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/StephennFernandes",
"id": 32235549,
"login": "StephennFernandes",
"node_id": "MDQ6VXNlcjMyMjM1NTQ5",
"organizations_url": "https://api.github.com/users/StephennFernandes/orgs",
"received_events_url": "https://api.github.com/users/StephennFernandes/received_events",
"repos_url": "https://api.github.com/users/StephennFernandes/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/StephennFernandes/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/StephennFernandes/subscriptions",
"type": "User",
"url": "https://api.github.com/users/StephennFernandes"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
... | null | completed | NONE | 2022-09-16T14:44:19Z | null | I_kwDODunzps5Knvuj | [
"@albertvillanova @lhoestq , could you please help me on this issue. ",
"Hi ! As mentioned on the [forum](https://discuss.huggingface.co/t/how-to-wrap-a-generator-with-hf-dataset/18464), the simplest for now would be to define a [dataset script](https://huggingface.co/docs/datasets/dataset_script) which can conta... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4417/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4417 | https://github.com/huggingface/datasets/issues/4417 | false |
1,251,875,763 | https://api.github.com/repos/huggingface/datasets/issues/4416/labels{/name} | Hi, I am trying to add a new dataset lccc.
All tests are passed. | 2022-06-15T10:28:59Z | 4,416 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-29T12:27:19Z | https://api.github.com/repos/huggingface/datasets/issues/4416/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4416/timeline | Add LCCC dataset | https://api.github.com/repos/huggingface/datasets/issues/4416/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/2529049?v=4",
"events_url": "https://api.github.com/users/silverriver/events{/privacy}",
"followers_url": "https://api.github.com/users/silverriver/followers",
"following_url": "https://api.github.com/users/silverriver/following{/other_user}",
"gists_url": "https://api.github.com/users/silverriver/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/silverriver",
"id": 2529049,
"login": "silverriver",
"node_id": "MDQ6VXNlcjI1MjkwNDk=",
"organizations_url": "https://api.github.com/users/silverriver/orgs",
"received_events_url": "https://api.github.com/users/silverriver/received_events",
"repos_url": "https://api.github.com/users/silverriver/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/silverriver/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/silverriver/subscriptions",
"type": "User",
"url": "https://api.github.com/users/silverriver"
} | [] | null | null | CONTRIBUTOR | 2022-06-02T09:13:46Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4416.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4416",
"merged_at": "2022-06-02T09:13:46Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4416.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4416"
} | PR_kwDODunzps44o7sF | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Thank you very much for your help @albertvillanova .\r\n\r\nI think I have fixed all the comments.\r\n\r\nPlease let me know if this PR need further modification ;)",
"@albertvillanova Thank you very much for your kind help.\r\nThe... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4416/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4416 | https://github.com/huggingface/datasets/pull/4416 | true |
1,251,002,981 | https://api.github.com/repos/huggingface/datasets/issues/4415/labels{/name} | Update `dataset_infos.json` when pushing splits one by one via `Dataset.push_to_hub` to avoid the splits verification error.
TODO:
~~- [ ] handle token + `{Audio, Image}.embed_storage`~~
- [x] tests | 2022-06-07T12:42:25Z | 4,415 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-27T17:03:42Z | https://api.github.com/repos/huggingface/datasets/issues/4415/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4415/timeline | Update `dataset_infos.json` with new split info in `Dataset.push_to_hub` to avoid verification error | https://api.github.com/repos/huggingface/datasets/issues/4415/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | [] | null | null | CONTRIBUTOR | 2022-06-07T12:33:52Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4415.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4415",
"merged_at": "2022-06-07T12:33:52Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4415.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4415"
} | PR_kwDODunzps44mIJk | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4415/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4415 | https://github.com/huggingface/datasets/pull/4415 | true |
1,250,546,888 | https://api.github.com/repos/huggingface/datasets/issues/4414/labels{/name} | This PR renames the DatasetBuilder keyword argument `name` to `config_name` so that:
- it avoids confusion with the attribute `DatasetBuilder.name`, which is different
- it aligns with the Dataset property name `config_name`, defined in `DatasetInfoMixin.config_name`
Other simpler possibility could be to rename it to just `config` instead.
Please note I have only renamed this argument of DatasetBuilder because I think this refactoring has a low impact on users: we can assume this is not a public facing parameter, but private or related to the inners of our library.
It would have a major impact to rename it also in:
- load_dataset
- load_dataset_builder: although this could also be assumed as inners...
- in our CLI commands
Besides the naming of `name`, I also find really confusing the naming of `path` in `load_dataset`. IMHO, they should have a more simpler and precise meaning (currently, they are too vague). I would propose (maybe for next major release):
```
load_dataset(dataset, config,...
```
instead of
```
load_dataset(path, name,...
``` | 2022-05-31T15:07:21Z | 4,414 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-27T09:28:02Z | https://api.github.com/repos/huggingface/datasets/issues/4414/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4414/timeline | Rename DatasetBuilder config_name | https://api.github.com/repos/huggingface/datasets/issues/4414/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-31T14:58:51Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4414.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4414",
"merged_at": "2022-05-31T14:58:51Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4414.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4414"
} | PR_kwDODunzps44klhY | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4414/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4414 | https://github.com/huggingface/datasets/pull/4414 | true |
1,250,259,822 | https://api.github.com/repos/huggingface/datasets/issues/4413/labels{/name} | ### Link
https://huggingface.co/datasets/ett
### Description
Timestamp is not JSON serializable.
```
Status code: 500
Exception: Status500Error
Message: Type is not JSON serializable: Timestamp
```
### Owner
No | 2022-06-15T07:30:46Z | 4,413 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "E5583E",
"default": false,
"description": "Related to the dataset viewer on huggingface.co",
"id": 3470211881,
"name": "dataset-viewer",
"node_id": "LA_kwDODunzps7O1zsp",
"url": "https://api.github.com/repos/huggingface/datasets/labels/dataset-viewer"
}
] | 2022-05-27T02:12:35Z | https://api.github.com/repos/huggingface/datasets/issues/4413/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url": "https://api.github.com/users/severo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/severo",
"id": 1676121,
"login": "severo",
"node_id": "MDQ6VXNlcjE2NzYxMjE=",
"organizations_url": "https://api.github.com/users/severo/orgs",
"received_events_url": "https://api.github.com/users/severo/received_events",
"repos_url": "https://api.github.com/users/severo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/severo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/severo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/severo"
} | https://api.github.com/repos/huggingface/datasets/issues/4413/timeline | Dataset Viewer issue for ett | https://api.github.com/repos/huggingface/datasets/issues/4413/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/24966039?v=4",
"events_url": "https://api.github.com/users/dgcnz/events{/privacy}",
"followers_url": "https://api.github.com/users/dgcnz/followers",
"following_url": "https://api.github.com/users/dgcnz/following{/other_user}",
"gists_url": "https://api.github.com/users/dgcnz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dgcnz",
"id": 24966039,
"login": "dgcnz",
"node_id": "MDQ6VXNlcjI0OTY2MDM5",
"organizations_url": "https://api.github.com/users/dgcnz/orgs",
"received_events_url": "https://api.github.com/users/dgcnz/received_events",
"repos_url": "https://api.github.com/users/dgcnz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dgcnz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dgcnz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dgcnz"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url... | null | completed | NONE | 2022-06-15T07:30:46Z | null | I_kwDODunzps5KhXNu | [
"Thanks for reporting @dgcnz.\r\n\r\nI have checked that the dataset works fine in streaming mode.\r\n\r\nAdditionally, other datasets containing timestamps are properly rendered by the viewer: https://huggingface.co/datasets/blbooks\r\n\r\nI have tried to force the refresh of the preview, but the endpoint is not r... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4413/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4413 | https://github.com/huggingface/datasets/issues/4413 | false |
1,249,490,179 | https://api.github.com/repos/huggingface/datasets/issues/4412/labels{/name} | Fix #4115 | 2022-06-15T17:11:25Z | 4,412 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-26T12:10:28Z | https://api.github.com/repos/huggingface/datasets/issues/4412/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4412/timeline | Skip hidden files/directories in data files resolution and `iter_files` | https://api.github.com/repos/huggingface/datasets/issues/4412/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | [] | null | null | CONTRIBUTOR | 2022-06-01T13:04:16Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4412.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4412",
"merged_at": "2022-06-01T13:04:16Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4412.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4412"
} | PR_kwDODunzps44hFvq | [
"_The documentation is not available anymore as the PR was closed or merged._",
"This PR (via new release) broke many transformers tests.\r\n\r\nI will try to post a summary shortly.\r\n\r\ncc: @ydshieh ",
"So now it can't handle a local path via: `--train_file tests/deepspeed/../fixtures/tests_samples/wmt_en_r... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4412/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4412 | https://github.com/huggingface/datasets/pull/4412 | true |
1,249,462,390 | https://api.github.com/repos/huggingface/datasets/issues/4411/labels{/name} | As explained at #4398, when calling `dataset.add_faiss_index` under certain conditions when calling a sequence of operations `cast_column`, `map`, and `remove_columns`, it fails as it's trying to look for already removed columns.
So on, after testing some possible fixes, it seems that setting the dataset format right after removing the columns seems to be working fine, so I had to add a call to `.set_format` in the `remove_columns` function.
Hope this helps! | 2022-06-14T19:05:37Z | 4,411 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-26T11:40:06Z | https://api.github.com/repos/huggingface/datasets/issues/4411/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4411/timeline | Update `_format_columns` in `remove_columns` | https://api.github.com/repos/huggingface/datasets/issues/4411/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/36760800?v=4",
"events_url": "https://api.github.com/users/alvarobartt/events{/privacy}",
"followers_url": "https://api.github.com/users/alvarobartt/followers",
"following_url": "https://api.github.com/users/alvarobartt/following{/other_user}",
"gists_url": "https://api.github.com/users/alvarobartt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alvarobartt",
"id": 36760800,
"login": "alvarobartt",
"node_id": "MDQ6VXNlcjM2NzYwODAw",
"organizations_url": "https://api.github.com/users/alvarobartt/orgs",
"received_events_url": "https://api.github.com/users/alvarobartt/received_events",
"repos_url": "https://api.github.com/users/alvarobartt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alvarobartt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alvarobartt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alvarobartt"
} | [] | null | null | CONTRIBUTOR | 2022-06-14T16:01:56Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4411.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4411",
"merged_at": "2022-06-14T16:01:55Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4411.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4411"
} | PR_kwDODunzps44g_yL | [
"🤗 This PR closes https://github.com/huggingface/datasets/issues/4398",
"_The documentation is not available anymore as the PR was closed or merged._",
"Hi! Thanks for reporting and providing a fix. I made a small change to make the fix easier to understand.",
"Hi, @mariosasko thanks! It makes sense, sorry I... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4411/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4411 | https://github.com/huggingface/datasets/pull/4411 | true |
1,249,148,457 | https://api.github.com/repos/huggingface/datasets/issues/4410/labels{/name} | The `spider` dataset is distributed under the [CC BY-SA 4.0](https://creativecommons.org/licenses/by-sa/4.0/legalcode) license.
Fix #4401. | 2022-05-26T06:48:42Z | 4,410 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-26T06:17:35Z | https://api.github.com/repos/huggingface/datasets/issues/4410/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4410/timeline | Remove Google Drive URL in spider dataset | https://api.github.com/repos/huggingface/datasets/issues/4410/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-26T06:40:12Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4410.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4410",
"merged_at": "2022-05-26T06:40:12Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4410.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4410"
} | PR_kwDODunzps44f_Td | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4410/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4410 | https://github.com/huggingface/datasets/pull/4410 | true |
1,249,083,179 | https://api.github.com/repos/huggingface/datasets/issues/4409/labels{/name} | first of all, please look #4323
why i can not use {"path","array","sampling_rate"}
because sf.write(format="wav") and sf.read(BytesIO) is changed my pcm data value
maybe, i think wav got header but, pcm is not.
and variable naming, pcm data is "byte" type. so, "array" name is not fair i think
so, i use scipy lib and numpy (that is huggingface dependency)
and refer to @lhoestq answered,
1. encode -> using sampling_rate and pcm byte -> wav style byte (scipy.wavfile.write to byte)
2. byte converting using fairseq style pcm audio read [FileAudioDataset](https://github.com/facebookresearch/fairseq/blob/main/fairseq/data/audio/raw_audio_dataset.py)
4. decode -> read wavfile.read
that way is not screw up my pcm byte to float data, and another audio type(wav) safety
please check! | 2022-07-07T13:27:29Z | 4,409 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-26T04:26:36Z | https://api.github.com/repos/huggingface/datasets/issues/4409/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4409/timeline | Update: add using pcm bytes (#4323) | https://api.github.com/repos/huggingface/datasets/issues/4409/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/34292279?v=4",
"events_url": "https://api.github.com/users/YooSungHyun/events{/privacy}",
"followers_url": "https://api.github.com/users/YooSungHyun/followers",
"following_url": "https://api.github.com/users/YooSungHyun/following{/other_user}",
"gists_url": "https://api.github.com/users/YooSungHyun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/YooSungHyun",
"id": 34292279,
"login": "YooSungHyun",
"node_id": "MDQ6VXNlcjM0MjkyMjc5",
"organizations_url": "https://api.github.com/users/YooSungHyun/orgs",
"received_events_url": "https://api.github.com/users/YooSungHyun/received_events",
"repos_url": "https://api.github.com/users/YooSungHyun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/YooSungHyun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/YooSungHyun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/YooSungHyun"
} | [] | null | null | CONTRIBUTOR | 2022-07-07T13:16:09Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4409.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4409",
"merged_at": "2022-07-07T13:16:08Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4409.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4409"
} | PR_kwDODunzps44fxiH | [
"@lhoestq Maybe I'm missing something, but what's the reason to read and encode PCM files to WAV in `Audio.encode_example`. Isn't the whole purpose of the decodable types to operate on raw files whenever possible? IMO this PR should only modify `Audio.decode_example` to support PCM files/bytes decoding.",
"Becaus... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4409/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4409 | https://github.com/huggingface/datasets/pull/4409 | true |
1,248,687,574 | https://api.github.com/repos/huggingface/datasets/issues/4408/labels{/name} | null | 2022-05-25T20:45:11Z | 4,408 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-25T20:32:19Z | https://api.github.com/repos/huggingface/datasets/issues/4408/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4408/timeline | Update imagenet gate | https://api.github.com/repos/huggingface/datasets/issues/4408/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | 2022-05-25T20:36:47Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4408.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4408",
"merged_at": "2022-05-25T20:36:47Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4408.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4408"
} | PR_kwDODunzps44ecNI | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4408/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4408 | https://github.com/huggingface/datasets/pull/4408 | true |
1,248,671,778 | https://api.github.com/repos/huggingface/datasets/issues/4407/labels{/name} | ### Link
https://huggingface.co/datasets/conll2012_ontonotesv5
### Description
Dataset viewer outage.
### Owner
No | 2022-06-07T18:39:16Z | 4,407 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "E5583E",
"default": false,
"description": "Related to the dataset viewer on huggingface.co",
"id": 3470211881,
"name": "dataset-viewer",
"node_id": "LA_kwDODunzps7O1zsp",
"url": "https://api.github.com/repos/huggingface/datasets/labels/dataset-viewer"
}
] | 2022-05-25T20:18:33Z | https://api.github.com/repos/huggingface/datasets/issues/4407/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url": "https://api.github.com/users/severo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/severo",
"id": 1676121,
"login": "severo",
"node_id": "MDQ6VXNlcjE2NzYxMjE=",
"organizations_url": "https://api.github.com/users/severo/orgs",
"received_events_url": "https://api.github.com/users/severo/received_events",
"repos_url": "https://api.github.com/users/severo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/severo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/severo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/severo"
} | https://api.github.com/repos/huggingface/datasets/issues/4407/timeline | Dataset Viewer issue for conll2012_ontonotesv5 | https://api.github.com/repos/huggingface/datasets/issues/4407/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/39762734?v=4",
"events_url": "https://api.github.com/users/jiangwangyi/events{/privacy}",
"followers_url": "https://api.github.com/users/jiangwangyi/followers",
"following_url": "https://api.github.com/users/jiangwangyi/following{/other_user}",
"gists_url": "https://api.github.com/users/jiangwangyi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jiangwangyi",
"id": 39762734,
"login": "jiangwangyi",
"node_id": "MDQ6VXNlcjM5NzYyNzM0",
"organizations_url": "https://api.github.com/users/jiangwangyi/orgs",
"received_events_url": "https://api.github.com/users/jiangwangyi/received_events",
"repos_url": "https://api.github.com/users/jiangwangyi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jiangwangyi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jiangwangyi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jiangwangyi"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1676121?v=4",
"events_url": "https://api.github.com/users/severo/events{/privacy}",
"followers_url": "https://api.github.com/users/severo/followers",
"following_url": "https://api.github.com/users/severo/following{/other_user}",
"gists_url... | null | completed | NONE | 2022-06-07T18:39:16Z | null | I_kwDODunzps5KbTgi | [
"Thanks for reporting, @jiangwy99.\r\n\r\nI guess this could be addressed only once we fix our issue with irresponsive backend endpoint.\r\n\r\nCC: @severo ",
"I've just sent the forcing of the refresh of the preview to the new endpoint.",
"Fixed, thanks for the patience. The issue was the amount of RAM allowed... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4407/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4407 | https://github.com/huggingface/datasets/issues/4407 | false |
1,248,626,622 | https://api.github.com/repos/huggingface/datasets/issues/4406/labels{/name} | Hi,
As pointed out by @lhoestq in this discussion (https://huggingface.co/datasets/asi/wikitext_fr/discussions/1), it is not yet possible to edit datasets outside of a namespace with the Hub PR feature and that you have to go through GitHub.
This modification should allow better referencing since only the xx language tags are currently taken into account and not the xx-xx. | 2022-05-27T14:51:23Z | 4,406 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-25T19:41:55Z | https://api.github.com/repos/huggingface/datasets/issues/4406/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4406/timeline | Improve language tag for PIAF dataset | https://api.github.com/repos/huggingface/datasets/issues/4406/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/58078086?v=4",
"events_url": "https://api.github.com/users/lbourdois/events{/privacy}",
"followers_url": "https://api.github.com/users/lbourdois/followers",
"following_url": "https://api.github.com/users/lbourdois/following{/other_user}",
"gists_url": "https://api.github.com/users/lbourdois/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lbourdois",
"id": 58078086,
"login": "lbourdois",
"node_id": "MDQ6VXNlcjU4MDc4MDg2",
"organizations_url": "https://api.github.com/users/lbourdois/orgs",
"received_events_url": "https://api.github.com/users/lbourdois/received_events",
"repos_url": "https://api.github.com/users/lbourdois/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lbourdois/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lbourdois/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lbourdois"
} | [] | null | null | NONE | 2022-05-27T14:51:23Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4406.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4406",
"merged_at": null,
"patch_url": "https://github.com/huggingface/datasets/pull/4406.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4406"
} | PR_kwDODunzps44ePLU | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4406/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4406 | https://github.com/huggingface/datasets/pull/4406 | true |
1,248,574,087 | https://api.github.com/repos/huggingface/datasets/issues/4405/labels{/name} | ## Describe the bug
I am trying to process the [conll2012_ontonotesv5](https://huggingface.co/datasets/conll2012_ontonotesv5) dataset in `datasets` v2.2.2 and am running into a type error when casting the features.
## Steps to reproduce the bug
```python
import os
from typing import (
List,
Dict,
)
from collections import (
defaultdict,
)
from dataclasses import (
dataclass,
)
from datasets import (
load_dataset,
)
@dataclass
class ConllConverter:
path: str
name: str
cache_dir: str
def __post_init__(
self,
):
self.dataset = load_dataset(
path=self.path,
name=self.name,
cache_dir=self.cache_dir,
)
def convert(
self,
):
class_label = self.dataset["train"].features["sentences"][0]["named_entities"].feature
# label_set = list(set([
# label.split("-")[1] if label != "O" else label for label in class_label.names
# ]))
def prepare_chunk(token, entity):
assert len(token) == len(entity)
# Sequence length
length = len(token)
# Variable used
entity_chunk = defaultdict(list)
idx = flag = 0
# While loop
while idx < length:
if entity[idx] == "O":
flag += 1
idx += 1
else:
iob_tp, lab_tp = entity[idx].split("-")
assert iob_tp == "B"
idx += 1
while idx < length and entity[idx].startswith("I-"):
idx += 1
entity_chunk[lab_tp].append(token[flag: idx])
flag = idx
entity_chunk = dict(entity_chunk)
# for label in label_set:
# if label != "O" and label not in entity_chunk.keys():
# entity_chunk[label] = None
return entity_chunk
def prepare_features(
batch: Dict[str, List],
) -> Dict[str, List]:
sentence = [
sent for doc_sent in batch["sentences"] for sent in doc_sent
]
feature = {
"sentence": list(),
}
for sent in sentence:
token = sent["words"]
entity = class_label.int2str(sent["named_entities"])
entity_chunk = prepare_chunk(token, entity)
sent_feat = {
"token": token,
"entity": entity,
"entity_chunk": entity_chunk,
}
feature["sentence"].append(sent_feat)
return feature
column_names = self.dataset.column_names["train"]
dataset = self.dataset.map(
function=prepare_features,
with_indices=False,
batched=True,
batch_size=3,
remove_columns=column_names,
num_proc=1,
)
dataset.save_to_disk(
dataset_dict_path=os.path.join("data", self.path, self.name)
)
if __name__ == "__main__":
converter = ConllConverter(
path="conll2012_ontonotesv5",
name="english_v4",
cache_dir="cache",
)
converter.convert()
```
## Expected results
I want to use the dataset to perform NER task and to change the label list into a {Entity Type: list of spans} format.
## Actual results
<details>
<summary>Traceback</summary>
```python
Traceback (most recent call last): | 0/81 [00:00<?, ?ba/s]
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/multiprocess/pool.py", line 125, in worker
result = (True, func(*args, **kwds))
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/arrow_dataset.py", line 532, in wrapper
out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/arrow_dataset.py", line 499, in wrapper
out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/fingerprint.py", line 458, in wrapper
out = func(self, *args, **kwargs)
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/arrow_dataset.py", line 2751, in _map_single
writer.write_batch(batch)
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/arrow_writer.py", line 503, in write_batch
arrays.append(pa.array(typed_sequence))
File "pyarrow/array.pxi", line 230, in pyarrow.lib.array
File "pyarrow/array.pxi", line 110, in pyarrow.lib._handle_arrow_array_protocol
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/arrow_writer.py", line 198, in __arrow_array__
out = cast_array_to_feature(out, type, allow_number_to_str=not self.trying_type)
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/table.py", line 1675, in wrapper
return func(array, *args, **kwargs)
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/table.py", line 1793, in cast_array_to_feature
arrays = [_c(array.field(name), subfeature) for name, subfeature in feature.items()]
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/table.py", line 1793, in <listcomp>
arrays = [_c(array.field(name), subfeature) for name, subfeature in feature.items()]
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/table.py", line 1675, in wrapper
return func(array, *args, **kwargs)
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/table.py", line 1844, in cast_array_to_feature
raise TypeError(f"Couldn't cast array of type\n{array.type}\nto\n{feature}")
TypeError: Couldn't cast array of type
struct<CARDINAL: list<item: list<item: string>>, DATE: list<item: list<item: string>>, EVENT: list<item: list<item: string>>, FAC: list<item: list<item: string>>, GPE: list<item: list<item: string>>, LANGUAGE: list<item: list<item: string>>, LAW: list<item: list<item: string>>, LOC: list<item: list<item: string>>, MONEY: list<item: list<item: string>>, NORP: list<item: list<item: string>>, ORDINAL: list<item: list<item: string>>, ORG: list<item: list<item: string>>, PERCENT: list<item: list<item: string>>, PERSON: list<item: list<item: string>>, QUANTITY: list<item: list<item: string>>, TIME: list<item: list<item: string>>, WORK_OF_ART: list<item: list<item: string>>>
to
{'CARDINAL': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'DATE': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'EVENT': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'FAC': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'GPE': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'LAW': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'LOC': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'MONEY': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'NORP': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'ORDINAL': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'ORG': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'PERCENT': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'PERSON': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'PRODUCT': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'QUANTITY': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'TIME': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'WORK_OF_ART': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None)}
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home2/jiangwangyi/workspace/work/Entity/dataconverter.py", line 110, in <module>
converter.convert()
File "/home2/jiangwangyi/workspace/work/Entity/dataconverter.py", line 91, in convert
dataset = self.dataset.map(
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/dataset_dict.py", line 770, in map
{
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/dataset_dict.py", line 771, in <dictcomp>
k: dataset.map(
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/datasets/arrow_dataset.py", line 2459, in map
transformed_shards[index] = async_result.get()
File "/home2/jiangwangyi/miniconda3/lib/python3.9/site-packages/multiprocess/pool.py", line 771, in get
raise self._value
TypeError: Couldn't cast array of type
struct<CARDINAL: list<item: list<item: string>>, DATE: list<item: list<item: string>>, EVENT: list<item: list<item: string>>, FAC: list<item: list<item: string>>, GPE: list<item: list<item: string>>, LANGUAGE: list<item: list<item: string>>, LAW: list<item: list<item: string>>, LOC: list<item: list<item: string>>, MONEY: list<item: list<item: string>>, NORP: list<item: list<item: string>>, ORDINAL: list<item: list<item: string>>, ORG: list<item: list<item: string>>, PERCENT: list<item: list<item: string>>, PERSON: list<item: list<item: string>>, QUANTITY: list<item: list<item: string>>, TIME: list<item: list<item: string>>, WORK_OF_ART: list<item: list<item: string>>>
to
{'CARDINAL': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'DATE': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'EVENT': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'FAC': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'GPE': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'LAW': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'LOC': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'MONEY': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'NORP': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'ORDINAL': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'ORG': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'PERCENT': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'PERSON': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'PRODUCT': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'QUANTITY': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'TIME': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None), 'WORK_OF_ART': Sequence(feature=Sequence(feature=Value(dtype='string', id=None), length=-1, id=None), length=-1, id=None)}
```
</details>
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version: 2.2.2
- Platform: Ubuntu 18.04
- Python version: 3.9.7
- PyArrow version: 7.0.0
| 2022-06-07T14:27:20Z | 4,405 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-25T18:56:43Z | https://api.github.com/repos/huggingface/datasets/issues/4405/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4405/timeline | [TypeError: Couldn't cast array of type] Cannot process dataset in v2.2.2 | https://api.github.com/repos/huggingface/datasets/issues/4405/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/39762734?v=4",
"events_url": "https://api.github.com/users/jiangwangyi/events{/privacy}",
"followers_url": "https://api.github.com/users/jiangwangyi/followers",
"following_url": "https://api.github.com/users/jiangwangyi/following{/other_user}",
"gists_url": "https://api.github.com/users/jiangwangyi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jiangwangyi",
"id": 39762734,
"login": "jiangwangyi",
"node_id": "MDQ6VXNlcjM5NzYyNzM0",
"organizations_url": "https://api.github.com/users/jiangwangyi/orgs",
"received_events_url": "https://api.github.com/users/jiangwangyi/received_events",
"repos_url": "https://api.github.com/users/jiangwangyi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jiangwangyi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jiangwangyi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jiangwangyi"
} | [] | null | completed | NONE | 2022-06-07T14:27:20Z | null | I_kwDODunzps5Ka7qH | [
"And if the problem is that the way I am to construct the {Entity Type: list of spans} makes entity types without any spans hard to handle, is there a better way to meet the demand? Although I have verified that to make entity types without any spans to behave like `entity_chunk[label] = [[\"\"]]` can perform norma... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4405/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4405 | https://github.com/huggingface/datasets/issues/4405 | false |
1,248,572,899 | https://api.github.com/repos/huggingface/datasets/issues/4404/labels{/name} | **Is your feature request related to a problem? Please describe.**
If building pipelines that can evaluate on more than one dataset, it would be nice to be able to log results of things like `Evaluating on {dataset.name}` or `results for {dataset.name} are: {results}`
Without some way of concisely identifying a dataset from the dataset object, tools which might run on more than one dataset must be passed the dataset object _and_ the name/id of the dataset being used.
**Describe the solution you'd like**
The DatasetInfo class should have a `name` field which is the name of a dataset. then for a given dataset if it evolves in time the `version` can be updated but its different versions of the same dataset with a unique `name`. The name could then all be accessed by `dataset.name`
**Describe alternatives you've considered**
For my own purposes I am considering making `NamedDataset[Dataset]` where the subclass just has a .name field.
**Additional context**
My guess is that most usecases are not working with more than one dataset in a given pipeline so a name is not really needed. This has surprised me though as one of the advantages of a standard dataset interface is to be able to build pipelines which can be passed in a dataset and separate responsibilities of the dataset loading from the train or eval pipeline.
| 2022-09-13T15:09:30Z | 4,404 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "a2eeef",
"default": true,
"description": "New feature or request",
"id": 1935892871,
"name": "enhancement",
"node_id": "MDU6TGFiZWwxOTM1ODkyODcx",
"url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement"
}
] | 2022-05-25T18:56:08Z | https://api.github.com/repos/huggingface/datasets/issues/4404/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4404/timeline | Dataset should have a `.name` field | https://api.github.com/repos/huggingface/datasets/issues/4404/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/36440?v=4",
"events_url": "https://api.github.com/users/f4hy/events{/privacy}",
"followers_url": "https://api.github.com/users/f4hy/followers",
"following_url": "https://api.github.com/users/f4hy/following{/other_user}",
"gists_url": "https://api.github.com/users/f4hy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/f4hy",
"id": 36440,
"login": "f4hy",
"node_id": "MDQ6VXNlcjM2NDQw",
"organizations_url": "https://api.github.com/users/f4hy/orgs",
"received_events_url": "https://api.github.com/users/f4hy/received_events",
"repos_url": "https://api.github.com/users/f4hy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/f4hy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/f4hy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/f4hy"
} | [] | null | completed | NONE | 2022-06-16T10:47:53Z | null | I_kwDODunzps5Ka7Xj | [
"Hi! You can already use `dset.builder_name` and `dset.config_name` for that purpose. And when it comes to versioning, it's better to use `dset._fingerprint` than the `version` attribute as the former represents a deterministic hash that encodes all the mutable ops executed on a dataset, and the latter stays the sa... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4404/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4404 | https://github.com/huggingface/datasets/issues/4404 | false |
1,248,390,134 | https://api.github.com/repos/huggingface/datasets/issues/4403/labels{/name} | null | 2022-05-31T08:33:36Z | 4,403 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-25T16:46:15Z | https://api.github.com/repos/huggingface/datasets/issues/4403/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4403/timeline | Uncomment logging deactivation for ArrowBasedBuilder | https://api.github.com/repos/huggingface/datasets/issues/4403/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/24695242?v=4",
"events_url": "https://api.github.com/users/thomasw21/events{/privacy}",
"followers_url": "https://api.github.com/users/thomasw21/followers",
"following_url": "https://api.github.com/users/thomasw21/following{/other_user}",
"gists_url": "https://api.github.com/users/thomasw21/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/thomasw21",
"id": 24695242,
"login": "thomasw21",
"node_id": "MDQ6VXNlcjI0Njk1MjQy",
"organizations_url": "https://api.github.com/users/thomasw21/orgs",
"received_events_url": "https://api.github.com/users/thomasw21/received_events",
"repos_url": "https://api.github.com/users/thomasw21/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/thomasw21/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thomasw21/subscriptions",
"type": "User",
"url": "https://api.github.com/users/thomasw21"
} | [] | null | null | CONTRIBUTOR | 2022-05-31T08:25:02Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4403.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4403",
"merged_at": "2022-05-31T08:25:02Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4403.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4403"
} | PR_kwDODunzps44dcpl | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4403/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4403 | https://github.com/huggingface/datasets/pull/4403 | true |
1,248,078,067 | https://api.github.com/repos/huggingface/datasets/issues/4402/labels{/name} | Skip identical files instead of overwriting them to save bandwidth and circumvent (user-side/server-side) errors, which can arise when working with large datasets due to long-lasting HTTP connections, by repeating calls to `push_to_hub` to resume an upload.
To be able to check if an upload can be resumed, this PR modifies the shard naming scheme from:
```
data/{split}-[0-9][0-9][0-9][0-9][0-9]-of-[0-9][0-9][0-9][0-9][0-9].parquet
```
to:
```
data/{split}-[0-9][0-9][0-9][0-9][0-9]-of-[0-9][0-9][0-9][0-9][0-9]-<SHARD_FINGERPRINT>.parquet
```
cc @LysandreJik | 2022-05-25T15:16:36Z | 4,402 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-25T13:12:51Z | https://api.github.com/repos/huggingface/datasets/issues/4402/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4402/timeline | Skip identical files in `push_to_hub` instead of overwriting | https://api.github.com/repos/huggingface/datasets/issues/4402/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | [] | null | null | CONTRIBUTOR | 2022-05-25T15:08:03Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4402.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4402",
"merged_at": "2022-05-25T15:08:03Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4402.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4402"
} | PR_kwDODunzps44cdR5 | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 1,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4402/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4402 | https://github.com/huggingface/datasets/pull/4402 | true |
1,247,695,921 | https://api.github.com/repos/huggingface/datasets/issues/4401/labels{/name} | ## Describe the bug
When importing 'spider' dataset [https://huggingface.co/datasets/spider] an error occurs
## Steps to reproduce the bug
```python
from datasets import load_dataset
dataset = load_dataset('spider')
```
## Expected results
Dataset object
## Actual results
NonMatchingChecksumError: Checksums didn't match for dataset source files:
['https://drive.google.com/uc?export=download&id=1_AckYkinAnhqmRQtGsQgUKAnTHxxX5J0']
## Environment info
- `datasets` version: 2.2.2
- Platform: Windows-10-10.0.19041-SP0
- Python version: 3.7.11
- PyArrow version: 6.0.1
- Pandas version: 1.3.5
| 2022-05-26T06:40:12Z | 4,401 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "8B51EF",
"default": false,
"description": "",
"id": 4069435429,
"name": "hosted-on-google-drive",
"node_id": "LA_kwDODunzps7yjqgl",
"url": "https://api.github.com/repos/huggingface/datasets/labels/hosted-on-google-drive"
}
] | 2022-05-25T07:45:07Z | https://api.github.com/repos/huggingface/datasets/issues/4401/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4401/timeline | "NonMatchingChecksumError" when importing 'spider' dataset | https://api.github.com/repos/huggingface/datasets/issues/4401/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/81417777?v=4",
"events_url": "https://api.github.com/users/OmarAlaaeldein/events{/privacy}",
"followers_url": "https://api.github.com/users/OmarAlaaeldein/followers",
"following_url": "https://api.github.com/users/OmarAlaaeldein/following{/other_user}",
"gists_url": "https://api.github.com/users/OmarAlaaeldein/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/OmarAlaaeldein",
"id": 81417777,
"login": "OmarAlaaeldein",
"node_id": "MDQ6VXNlcjgxNDE3Nzc3",
"organizations_url": "https://api.github.com/users/OmarAlaaeldein/orgs",
"received_events_url": "https://api.github.com/users/OmarAlaaeldein/received_events",
"repos_url": "https://api.github.com/users/OmarAlaaeldein/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/OmarAlaaeldein/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/OmarAlaaeldein/subscriptions",
"type": "User",
"url": "https://api.github.com/users/OmarAlaaeldein"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | NONE | 2022-05-26T06:40:12Z | null | I_kwDODunzps5KXlQx | [
"Thanks for reporting, @OmarAlaaeldein.\r\n\r\nDatasets hosted at Google Drive give problems quite often due to a change in their service:\r\n- #3786 \r\n\r\nRelated to:\r\n- #3906\r\n\r\nI'm having a look.",
"We have made a Pull Request to replace the Google Drive URL. This fix will be accessible in our next `da... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4401/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4401 | https://github.com/huggingface/datasets/issues/4401 | false |
1,247,404,237 | https://api.github.com/repos/huggingface/datasets/issues/4400/labels{/name} | ## Describe the bug
Could not reach wikitext-2-raw-v1.py
## Steps to reproduce the bug
```python
from datasets import load_dataset
load_dataset("wikitext-2-raw-v1")
```
## Expected results
Download `wikitext-2-raw-v1` dataset successfully.
## Actual results
```
File "load_datasets.py", line 13, in <module>
load_dataset("wikitext-2-raw-v1")
File "/root/miniconda3/lib/python3.6/site-packages/datasets/load.py", line 1715, in load_dataset
**config_kwargs,
File "/root/miniconda3/lib/python3.6/site-packages/datasets/load.py", line 1536, in load_dataset_builder
data_files=data_files,
File "/root/miniconda3/lib/python3.6/site-packages/datasets/load.py", line 1282, in dataset_module_factory
raise e1 from None
File "/root/miniconda3/lib/python3.6/site-packages/datasets/load.py", line 1224, in dataset_module_factory
dynamic_modules_path=dynamic_modules_path,
File "/root/miniconda3/lib/python3.6/site-packages/datasets/load.py", line 559, in get_module
local_path = self.download_loading_script(revision)
File "/root/miniconda3/lib/python3.6/site-packages/datasets/load.py", line 539, in download_loading_script
return cached_path(file_path, download_config=download_config)
File "/root/miniconda3/lib/python3.6/site-packages/datasets/utils/file_utils.py", line 246, in cached_path
download_desc=download_config.download_desc,
File "/root/miniconda3/lib/python3.6/site-packages/datasets/utils/file_utils.py", line 582, in get_from_cache
raise ConnectionError(f"Couldn't reach {url} ({repr(head_error)})")
ConnectionError: Couldn't reach https://raw.githubusercontent.com/huggingface/datasets/2.2.2/datasets/wikitext-2-raw-v1/wikitext-2-raw-v1.py (ReadTimeout(ReadTimeoutError("HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Read timed out. (read timeout=100)",),))
```
I tried to download wikitext-2-raw-v1.py by chrome and got:
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version: 2.2.2
- Platform: CentOS 7
- Python version: 3.6
- PyArrow version: 3.0.0
| 2022-10-24T06:10:27Z | 4,400 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-25T03:10:44Z | https://api.github.com/repos/huggingface/datasets/issues/4400/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4400/timeline | load dataset wikitext-2-raw-v1 failed. Could not reach wikitext-2-raw-v1.py. | https://api.github.com/repos/huggingface/datasets/issues/4400/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/20658907?v=4",
"events_url": "https://api.github.com/users/cailun01/events{/privacy}",
"followers_url": "https://api.github.com/users/cailun01/followers",
"following_url": "https://api.github.com/users/cailun01/following{/other_user}",
"gists_url": "https://api.github.com/users/cailun01/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cailun01",
"id": 20658907,
"login": "cailun01",
"node_id": "MDQ6VXNlcjIwNjU4OTA3",
"organizations_url": "https://api.github.com/users/cailun01/orgs",
"received_events_url": "https://api.github.com/users/cailun01/received_events",
"repos_url": "https://api.github.com/users/cailun01/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cailun01/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cailun01/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cailun01"
} | [] | null | completed | NONE | 2022-05-25T03:26:36Z | null | I_kwDODunzps5KWeDN | [
"I tried in this way.\r\n\r\n```python\r\nfrom datasets import load_dataset\r\ndataset = load_dataset(path=\"wikitext\", name=\"wikitext-103-v1\", split=\"train\")\r\n```"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4400/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4400 | https://github.com/huggingface/datasets/issues/4400 | false |
1,246,948,299 | https://api.github.com/repos/huggingface/datasets/issues/4399/labels{/name} | ## Describe the bug
Trying to load a local dataset raises an error indicating that the config builder has to have a name.
No error should be reported, since the call is completly valid.
## Steps to reproduce the bug
```python
load_dataset("./data/some-dataset/", name="some-name")
```
## Expected results
The dataset should be loaded.
## Actual results
```
Traceback (most recent call last):
File "train_lquad.py", line 19, in <module>
load(tokenize_target_function, tokenize_target_function, {}, tokenizer)
File "train_lquad.py", line 14, in load
dataset = load_dataset("./data/lquad/", name="lquad")
File "/net/pr2/scratch/people/plgapohl/python-3.8.6/lib/python3.8/site-packages/datasets/load.py", line 1708, in load_dataset
builder_instance = load_dataset_builder(
File "/net/pr2/scratch/people/plgapohl/python-3.8.6/lib/python3.8/site-packages/datasets/load.py", line 1560, in load_dataset_builder
builder_instance: DatasetBuilder = builder_cls(
File "/net/pr2/scratch/people/plgapohl/python-3.8.6/lib/python3.8/site-packages/datasets/builder.py", line 269, in __init__
self.config, self.config_id = self._create_builder_config(
File "/net/pr2/scratch/people/plgapohl/python-3.8.6/lib/python3.8/site-packages/datasets/builder.py", line 403, in _create_builder_config
raise ValueError(f"BuilderConfig must have a name, got {builder_config.name}")
ValueError: BuilderConfig must have a name, got
```
## Environment info
- `datasets` version: 2.2.2
- Platform: Linux-4.18.0-348.20.1.el8_5.x86_64-x86_64-with-glibc2.2.5
- Python version: 3.8.6
- PyArrow version: 8.0.0
- Pandas version: 1.4.2
The error is probably in line 795 in load.py:
```
builder_kwargs = {
"hash": hash,
"data_files": data_files,
"name": os.path.basename(self.path),
"base_path": self.path,
**builder_kwargs,
}
```
`os.path.basename` for a directory returns an empty string, rather than the name of the directory.
| 2022-09-12T15:30:43Z | 4,399 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
},
{
"color": "7057ff",
"default": true,
"descript... | 2022-05-24T18:03:01Z | https://api.github.com/repos/huggingface/datasets/issues/4399/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4399/timeline | LocalDatasetModuleFactoryWithoutScript extracts invalid builder name | https://api.github.com/repos/huggingface/datasets/issues/4399/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/40543?v=4",
"events_url": "https://api.github.com/users/apohllo/events{/privacy}",
"followers_url": "https://api.github.com/users/apohllo/followers",
"following_url": "https://api.github.com/users/apohllo/following{/other_user}",
"gists_url": "https://api.github.com/users/apohllo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/apohllo",
"id": 40543,
"login": "apohllo",
"node_id": "MDQ6VXNlcjQwNTQz",
"organizations_url": "https://api.github.com/users/apohllo/orgs",
"received_events_url": "https://api.github.com/users/apohllo/received_events",
"repos_url": "https://api.github.com/users/apohllo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/apohllo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/apohllo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/apohllo"
} | [] | null | completed | CONTRIBUTOR | 2022-09-12T15:30:43Z | null | I_kwDODunzps5KUuvL | [
"Ok, so\r\n```\r\nos.path.basename(\"/home/user/\")\r\n```\r\ngives `''` while \r\n```\r\nos.path.basename(\"/home/user\")\r\n```\r\ngives `user`. \r\nThe code should check if the last char is a slash.\r\n",
"The fix is:\r\n```\r\n\"name\": os.path.basename(self.path[:-1] if self.path[-1] == \"/\" else self.path)... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4399/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4399 | https://github.com/huggingface/datasets/issues/4399 | false |
1,246,666,749 | https://api.github.com/repos/huggingface/datasets/issues/4398/labels{/name} | First of all, sorry in advance for the unclear title, but this bug is weird to explain (at least for me), so I tried my best to summarize all the information in this issue.
## Describe the bug
Calling a certain combination of operations over a 🤗 `Dataset` and then trying to calculate the `faiss` index with `.add_faiss_index` ends up throwing an exception while trying to set the format back of a previously removed column. But this just happens over certain conditions... I'll present some scenarios below!
## Steps to reproduce the bug
Assuming the following dataset named `sample.csv` with some IMDb data:
```csv
id,title,summary
1877830,"The Batman","When a sadistic serial killer begins murdering key political figures in Gotham, Batman is forced to investigate the city's hidden corruption and question his family's involvement."
9419884,"Doctor Strange in the Multiverse of Madness","Doctor Strange teams up with a mysterious teenage girl from his dreams who can travel across multiverses, to battle multiple threats, including other-universe versions of himself, which threaten to wipe out millions across the multiverse. They seek help from Wanda the Scarlet Witch, Wong and others."
11138512,"The Northman","From visionary director Robert Eggers comes The Northman, an action-filled epic that follows a young Viking prince on his quest to avenge his father's murder."
1745960,"Top Gun: Maverick","After more than thirty years of service as one of the Navy's top aviators, Pete Mitchell is where he belongs, pushing the envelope as a courageous test pilot and dodging the advancement in rank that would ground him."
```
We'll be able to reproduce the bug using the following piece of code:
```python
# Sample code to reproduce the bug
from transformers import DPRContextEncoder, DPRContextEncoderTokenizer
import torch
torch.set_grad_enabled(False)
ctx_encoder = DPRContextEncoder.from_pretrained("facebook/dpr-ctx_encoder-single-nq-base")
ctx_tokenizer = DPRContextEncoderTokenizer.from_pretrained("facebook/dpr-ctx_encoder-single-nq-base")
from datasets import load_dataset, Value
ds = load_dataset("csv", data_files=["sample.csv"], split="train")
ds = ds.cast_column("id", Value("int32")) # from `int64` to `int32`
ds = ds.map(lambda x: {"inputs": f"{ctx_tokenizer.sep_token}".join(["title", "summary"])})
ds = ds.remove_columns(["title", "summary"])
def generate_embeddings(x):
return {"embeddings": ctx_encoder(**ctx_tokenizer(x["inputs"], return_tensors="pt"))[0][0].numpy()}
ds = ds.map(generate_embeddings)
ds = ds.remove_columns("inputs")
ds.add_faiss_index(column="embeddings") # It fails here!
```
The code above is an adaptation of https://huggingface.co/docs/datasets/faiss_es, for the sake of presenting the bug with a simple example.
## Expected results
Ideally, the `faiss` index should be calculated over the 🤗 `Dataset` and no exception should be triggered.
## Actual results
But what happens instead is that a `ValueError: Columns ['inputs'] not in the dataset. Current columns in the dataset: ['id', 'embeddings']`, which makes no sense as that column has been previously dropped.
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version: 2.2.2
- Platform: Linux-5.4.0-1074-azure-x86_64-with-glibc2.31
- Python version: 3.9.5
- PyArrow version: 8.0.0
- Pandas version: 1.4.2
| 2022-06-14T16:01:56Z | 4,398 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-24T14:41:34Z | https://api.github.com/repos/huggingface/datasets/issues/4398/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4398/timeline | Calling `cast_column`/`remove_columns` and a sequence of `map` operations ends up making `faiss` fail with `ValueError` | https://api.github.com/repos/huggingface/datasets/issues/4398/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/36760800?v=4",
"events_url": "https://api.github.com/users/alvarobartt/events{/privacy}",
"followers_url": "https://api.github.com/users/alvarobartt/followers",
"following_url": "https://api.github.com/users/alvarobartt/following{/other_user}",
"gists_url": "https://api.github.com/users/alvarobartt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alvarobartt",
"id": 36760800,
"login": "alvarobartt",
"node_id": "MDQ6VXNlcjM2NzYwODAw",
"organizations_url": "https://api.github.com/users/alvarobartt/orgs",
"received_events_url": "https://api.github.com/users/alvarobartt/received_events",
"repos_url": "https://api.github.com/users/alvarobartt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alvarobartt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alvarobartt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alvarobartt"
} | [] | null | completed | CONTRIBUTOR | 2022-06-14T16:01:56Z | null | I_kwDODunzps5KTp_9 | [
"It works if we either remove the `ds = ds.cast_column(\"id\", Value(\"int32\"))` line from the code above, or if instead calling `ds.remove_columns()` we remove the columns inside each mapping as `ds.map(..., remove_columns=[...])` instead of right after the mapping.\r\n\r\nBoth of those solutions seem to fix the ... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4398/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4398 | https://github.com/huggingface/datasets/issues/4398 | false |
1,246,597,632 | https://api.github.com/repos/huggingface/datasets/issues/4397/labels{/name} | We had to make a hotfix by pinning dill:
- #4380
because from version 0.3.5, our custom `save_function` pickling function was raising an exception:
- #4379
This PR fixes this by implementing our custom `save_function` depending on the version of dill.
CC: @anivegesana
This PR needs first being merged:
- [x] #4384
- so that a circular import is fixed
It is also convenient to merge first:
- [x] #4385 | 2022-10-26T08:45:37Z | 4,397 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-24T13:54:23Z | https://api.github.com/repos/huggingface/datasets/issues/4397/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4397/timeline | Fix dependency on dill version | https://api.github.com/repos/huggingface/datasets/issues/4397/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-25T13:54:08Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4397.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4397",
"merged_at": "2022-05-25T13:54:08Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4397.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4397"
} | PR_kwDODunzps44XcG3 | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4397/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4397 | https://github.com/huggingface/datasets/pull/4397 | true |
1,245,479,399 | https://api.github.com/repos/huggingface/datasets/issues/4396/labels{/name} | As commented in:
- https://github.com/huggingface/datasets/issues/4386#issuecomment-1134902372
CC: @StevenTang1998 | 2022-05-24T05:49:11Z | 4,396 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-23T17:16:12Z | https://api.github.com/repos/huggingface/datasets/issues/4396/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4396/timeline | Fix URL in gem dataset for totto config | https://api.github.com/repos/huggingface/datasets/issues/4396/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-24T05:41:00Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4396.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4396",
"merged_at": "2022-05-24T05:40:59Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4396.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4396"
} | PR_kwDODunzps44T0Di | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4396/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4396 | https://github.com/huggingface/datasets/pull/4396 | true |
1,245,436,486 | https://api.github.com/repos/huggingface/datasets/issues/4395/labels{/name} | This PR adds the Pascal VOC dataset in the same way TFDS has it added. I believe we can iterate on this dataset and in future versions include more data, such as segmentation masks, but for now I think it is a good idea to just add it the same way as TFDS to get a solid first version out there. | 2023-09-24T09:37:05Z | 4,395 | null | https://api.github.com/repos/huggingface/datasets | false | [
{
"color": "0e8a16",
"default": false,
"description": "Contribution to a dataset script",
"id": 4564477500,
"name": "dataset contribution",
"node_id": "LA_kwDODunzps8AAAABEBBmPA",
"url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20contribution"
}
] | 2022-05-23T16:34:05Z | https://api.github.com/repos/huggingface/datasets/issues/4395/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4395/timeline | Add Pascal VOC dataset | https://api.github.com/repos/huggingface/datasets/issues/4395/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/32437151?v=4",
"events_url": "https://api.github.com/users/nateraw/events{/privacy}",
"followers_url": "https://api.github.com/users/nateraw/followers",
"following_url": "https://api.github.com/users/nateraw/following{/other_user}",
"gists_url": "https://api.github.com/users/nateraw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateraw",
"id": 32437151,
"login": "nateraw",
"node_id": "MDQ6VXNlcjMyNDM3MTUx",
"organizations_url": "https://api.github.com/users/nateraw/orgs",
"received_events_url": "https://api.github.com/users/nateraw/received_events",
"repos_url": "https://api.github.com/users/nateraw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateraw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateraw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateraw"
} | [] | null | null | CONTRIBUTOR | 2022-10-03T09:36:56Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4395.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4395",
"merged_at": null,
"patch_url": "https://github.com/huggingface/datasets/pull/4395.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4395"
} | PR_kwDODunzps44TrBA | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Some CI fails are unrelated to your PR and fixed on master, feel free to merge master into your branch :)",
"Thanks @nateraw for the addition of this dataset.\r\n\r\nI would suggest to transfer it to the Hugging Face Hub, under a \... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4395/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4395 | https://github.com/huggingface/datasets/pull/4395 | true |
1,245,221,657 | https://api.github.com/repos/huggingface/datasets/issues/4394/labels{/name} | ## Describe the bug
Due to memory problem, I need to save my tokenized datasets locally by CPU and reload it by multi GPU for running training script. However, after I reload it by `load_from_disk` and start training, the speed is extremely slow. It says I need about 1500 hours with 8 A100 cards. Before this, I can run the whole script in one day with a single A100 card.
Since I am try to pre-train a BERT, **my dataset is very large(29058165 rows)**
## Steps to reproduce the bug
```python
tokenized_datasets.save_to_disk(
"/pathto/dataset"
)
tokenized_datasets = load_from_disk(
"/pathto/dataset"
)
trainer = Trainer(
model=model,
args=training_args,
train_dataset=tokenized_datasets["train"] if training_args.do_train else None,
eval_dataset=tokenized_datasets["validation"]
if training_args.do_eval
else None,
tokenizer=tokenizer,
data_collator=data_collator,
)
train_result = trainer.train(resume_from_checkpoint=checkpoint)
```
## Expected results
Without the save and reload process, I only need about one day to run the whole script with one A100 card.
## Actual results
```
[INFO|trainer.py:1290] 2022-05-23 22:49:46,266 >> ***** Running training *****
[INFO|trainer.py:1291] 2022-05-23 22:49:46,266 >> Num examples = 29058165
[INFO|trainer.py:1292] 2022-05-23 22:49:46,266 >> Num Epochs = 5
[INFO|trainer.py:1293] 2022-05-23 22:49:46,266 >> Instantaneous batch size per device = 16
[INFO|trainer.py:1294] 2022-05-23 22:49:46,266 >> Total train batch size (w. parallel, distributed & accumulation) = 256
[INFO|trainer.py:1295] 2022-05-23 22:49:46,266 >> Gradient Accumulation steps = 2
[INFO|trainer.py:1296] 2022-05-23 22:49:46,266 >> Total optimization steps = 567540
0%| | 1/567540 [00:09<1544:49:04, 9.80s/it]
0%| | 2/567540 [00:17<1320:00:17, 8.37s/it]
0%| | 3/567540 [00:26<1393:10:17, 8.84s/it]
0%| | 4/567540 [00:34<1344:56:33, 8.53s/it]
0%| | 5/567540 [00:43<1359:36:12, 8.62s/it]
```
## Environment info
```
torch 1.11.0+cu113
torchaudio 0.11.0+cu113
torchvision 0.12.0+cu113
transformers 4.18.0
datasets 2.2.2
``` | 2023-11-23T07:40:30Z | 4,394 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-23T14:04:37Z | https://api.github.com/repos/huggingface/datasets/issues/4394/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4394/timeline | trainer became extremely slow after reload dataset by `load_from_disk` | https://api.github.com/repos/huggingface/datasets/issues/4394/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/50416856?v=4",
"events_url": "https://api.github.com/users/conan1024hao/events{/privacy}",
"followers_url": "https://api.github.com/users/conan1024hao/followers",
"following_url": "https://api.github.com/users/conan1024hao/following{/other_user}",
"gists_url": "https://api.github.com/users/conan1024hao/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/conan1024hao",
"id": 50416856,
"login": "conan1024hao",
"node_id": "MDQ6VXNlcjUwNDE2ODU2",
"organizations_url": "https://api.github.com/users/conan1024hao/orgs",
"received_events_url": "https://api.github.com/users/conan1024hao/received_events",
"repos_url": "https://api.github.com/users/conan1024hao/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/conan1024hao/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/conan1024hao/subscriptions",
"type": "User",
"url": "https://api.github.com/users/conan1024hao"
} | [] | null | null | NONE | null | null | I_kwDODunzps5KOJMZ | [
"I tried to make the dataset much more smaller (100000 rows) , then the speed became `33.88it/s` from`8.62s/it`. It's nearly 200 times... Do you have any idea? Thank you!",
"Similar issue: https://github.com/huggingface/transformers/issues/8818\r\n\r\nI changed `RandomSampler` to `SequentialSampler` in the `tra... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4394/reactions"
} | open | false | https://api.github.com/repos/huggingface/datasets/issues/4394 | https://github.com/huggingface/datasets/issues/4394 | false |
1,244,876,662 | https://api.github.com/repos/huggingface/datasets/issues/4393/labels{/name} | Now our CI still uses a deprecated legacy image:
> You’re using a [deprecated Docker convenience image.](https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034) Upgrade to a next-gen Docker convenience image.
This PR updates to next-generation convenience image.
Related to:
- #2955 | 2022-05-23T10:08:28Z | 4,393 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-23T09:35:42Z | https://api.github.com/repos/huggingface/datasets/issues/4393/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4393/timeline | Update CI deprecated legacy image | https://api.github.com/repos/huggingface/datasets/issues/4393/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-23T09:59:55Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4393.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4393",
"merged_at": "2022-05-23T09:59:55Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4393.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4393"
} | PR_kwDODunzps44RxWN | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4393/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4393 | https://github.com/huggingface/datasets/pull/4393 | true |
1,244,859,971 | https://api.github.com/repos/huggingface/datasets/issues/4392/labels{/name} | Removes the `int` documentation from the [logging section](https://huggingface.co/docs/datasets/package_reference/logging_methods#levels) of the docs. | 2022-05-23T15:16:55Z | 4,392 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-23T09:24:55Z | https://api.github.com/repos/huggingface/datasets/issues/4392/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4392/timeline | remove int documentation from logging docs | https://api.github.com/repos/huggingface/datasets/issues/4392/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8264887?v=4",
"events_url": "https://api.github.com/users/lvwerra/events{/privacy}",
"followers_url": "https://api.github.com/users/lvwerra/followers",
"following_url": "https://api.github.com/users/lvwerra/following{/other_user}",
"gists_url": "https://api.github.com/users/lvwerra/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lvwerra",
"id": 8264887,
"login": "lvwerra",
"node_id": "MDQ6VXNlcjgyNjQ4ODc=",
"organizations_url": "https://api.github.com/users/lvwerra/orgs",
"received_events_url": "https://api.github.com/users/lvwerra/received_events",
"repos_url": "https://api.github.com/users/lvwerra/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lvwerra/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lvwerra/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lvwerra"
} | [] | null | null | MEMBER | 2022-05-23T15:08:32Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4392.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4392",
"merged_at": "2022-05-23T15:08:32Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4392.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4392"
} | PR_kwDODunzps44RtsX | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4392/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4392 | https://github.com/huggingface/datasets/pull/4392 | true |
1,244,839,185 | https://api.github.com/repos/huggingface/datasets/issues/4391/labels{/name} | This PR tweaks the keys in the metadata that are used to define the column mapping for question answering datasets. This is needed in order to faithfully reconstruct column names like `answers.text` and `answers.answer_start` from the keys in AutoTrain.
As observed in https://github.com/huggingface/datasets/pull/4367 we cannot use periods `.` in the keys of the YAML tags, so a decision was made to use a flat mapping with underscores. For QA datasets, however, it's handy to be able to reconstruct the nesting -- hence this PR.
cc @sashavor | 2022-05-24T12:57:00Z | 4,391 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-23T09:13:14Z | https://api.github.com/repos/huggingface/datasets/issues/4391/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4391/timeline | Refactor column mappings for question answering datasets | https://api.github.com/repos/huggingface/datasets/issues/4391/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/26859204?v=4",
"events_url": "https://api.github.com/users/lewtun/events{/privacy}",
"followers_url": "https://api.github.com/users/lewtun/followers",
"following_url": "https://api.github.com/users/lewtun/following{/other_user}",
"gists_url": "https://api.github.com/users/lewtun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lewtun",
"id": 26859204,
"login": "lewtun",
"node_id": "MDQ6VXNlcjI2ODU5MjA0",
"organizations_url": "https://api.github.com/users/lewtun/orgs",
"received_events_url": "https://api.github.com/users/lewtun/received_events",
"repos_url": "https://api.github.com/users/lewtun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lewtun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lewtun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lewtun"
} | [] | null | null | MEMBER | 2022-05-24T12:48:48Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4391.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4391",
"merged_at": "2022-05-24T12:48:48Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4391.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4391"
} | PR_kwDODunzps44RpGv | [
"_The documentation is not available anymore as the PR was closed or merged._",
"> Thanks.\r\n> \r\n> I have no visibility about this, but if you say it is more useful for AutoTrain this way...\r\n\r\nThanks for the review @albertvillanova ! Yes, I need some way to reconstruct the original column names with a per... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4391/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4391 | https://github.com/huggingface/datasets/pull/4391 | true |
1,244,835,877 | https://api.github.com/repos/huggingface/datasets/issues/4390/labels{/name} | Since Python 3.8, the typing module:
- raises an AttributeError when trying to access `__args__` on any type, e.g.: `List.__args__`
- provides the `get_args` function instead: `get_args(List)`
This PR implements a fix for Python >=3.8 whereas maintaining backward compatibility. | 2022-06-01T09:27:52Z | 4,390 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-23T09:11:20Z | https://api.github.com/repos/huggingface/datasets/issues/4390/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4390/timeline | Fix metadata validation | https://api.github.com/repos/huggingface/datasets/issues/4390/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-06-01T09:19:25Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4390.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4390",
"merged_at": "2022-06-01T09:19:25Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4390.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4390"
} | PR_kwDODunzps44RoXs | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4390/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4390 | https://github.com/huggingface/datasets/pull/4390 | true |
1,244,693,690 | https://api.github.com/repos/huggingface/datasets/issues/4389/labels{/name} | This PR fixes some URLs.
Fix #4386. | 2022-05-23T10:38:26Z | 4,389 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-23T07:19:49Z | https://api.github.com/repos/huggingface/datasets/issues/4389/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4389/timeline | Fix bug in gem dataset for wiki_auto_asset_turk config | https://api.github.com/repos/huggingface/datasets/issues/4389/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-23T10:29:55Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4389.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4389",
"merged_at": "2022-05-23T10:29:55Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4389.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4389"
} | PR_kwDODunzps44RKMn | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4389/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4389 | https://github.com/huggingface/datasets/pull/4389 | true |
1,244,645,158 | https://api.github.com/repos/huggingface/datasets/issues/4388/labels{/name} | Now the builder name attribute is set from from the builder class name.
This PR sets the builder name attribute from the module name instead. Some motivating reasons:
- The dataset ID is relevant and unique among all datasets and this is directly related to the repository name, i.e., the name of the directory containing the dataset
- The name of the module (i.e. the file containing the loading loading script) is already relevant for loading: it must have the same name as its containing directory (related to the dataset ID), as we search for it using its directory name
- On the other hand, the name of the builder class is not relevant for loading: in our code, we just search for a class which is subclass of `DatasetBuilder` (independently of its name). We do not put any constraint on the naming of the builder class and indeed it can have a name completely different from its module/direcotry/dataset_id
IMO it makes more sense to align the caching directory name with the dataset_id/directory/module name instead of the builder class name.
Fix #4381. | 2022-05-25T05:24:43Z | 4,388 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-23T06:26:35Z | https://api.github.com/repos/huggingface/datasets/issues/4388/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4388/timeline | Set builder name from module instead of class | https://api.github.com/repos/huggingface/datasets/issues/4388/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-25T05:16:15Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4388.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4388",
"merged_at": "2022-05-25T05:16:15Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4388.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4388"
} | PR_kwDODunzps44RAG1 | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4388/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4388 | https://github.com/huggingface/datasets/pull/4388 | true |
1,244,147,817 | https://api.github.com/repos/huggingface/datasets/issues/4387/labels{/name} | "git clone https://android.googlesource.com/device/google/accessory/adk2012"
https://android.googlesource.com/device/google/accessory/adk2012/#:~:text=git%20clone%20https%3A//android.googlesource.com/device/google/accessory/adk2012 | 2022-05-23T06:36:27Z | 4,387 | null | https://api.github.com/repos/huggingface/datasets | null | [] | 2022-05-22T04:57:19Z | https://api.github.com/repos/huggingface/datasets/issues/4387/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4387/timeline | device/google/accessory/adk2012 - Git at Google | https://api.github.com/repos/huggingface/datasets/issues/4387/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/87345839?v=4",
"events_url": "https://api.github.com/users/Aeckard45/events{/privacy}",
"followers_url": "https://api.github.com/users/Aeckard45/followers",
"following_url": "https://api.github.com/users/Aeckard45/following{/other_user}",
"gists_url": "https://api.github.com/users/Aeckard45/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Aeckard45",
"id": 87345839,
"login": "Aeckard45",
"node_id": "MDQ6VXNlcjg3MzQ1ODM5",
"organizations_url": "https://api.github.com/users/Aeckard45/orgs",
"received_events_url": "https://api.github.com/users/Aeckard45/received_events",
"repos_url": "https://api.github.com/users/Aeckard45/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Aeckard45/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Aeckard45/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Aeckard45"
} | [] | null | completed | NONE | 2022-05-23T06:36:27Z | null | I_kwDODunzps5KKDBp | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4387/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4387 | https://github.com/huggingface/datasets/issues/4387 | false |
1,243,965,532 | https://api.github.com/repos/huggingface/datasets/issues/4386/labels{/name} | ## Describe the bug
The script of wiki_auto_asset_turk for GEM may be out of date.
## Steps to reproduce the bug
```python
import datasets
datasets.load_dataset('gem', 'wiki_auto_asset_turk')
```
## Actual results
```
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/load.py", line 1731, in load_dataset
builder_instance.download_and_prepare(
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/builder.py", line 640, in download_and_prepare
self._download_and_prepare(
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/builder.py", line 1158, in _download_and_prepare
super()._download_and_prepare(dl_manager, verify_infos, check_duplicate_keys=verify_infos)
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/builder.py", line 707, in _download_and_prepare
split_generators = self._split_generators(dl_manager, **split_generators_kwargs)
File "/home/tangtianyi/.cache/huggingface/modules/datasets_modules/datasets/gem/982a54473b12c6a6e40d4356e025fb7172a5bb2065e655e2c1af51f2b3cf4ca1/gem.py", line 538, in _split_generators
dl_dir = dl_manager.download_and_extract(_URLs[self.config.name])
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/utils/download_manager.py", line 416, in download_and_extract
return self.extract(self.download(url_or_urls))
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/utils/download_manager.py", line 294, in download
downloaded_path_or_paths = map_nested(
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/utils/py_utils.py", line 351, in map_nested
mapped = [
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/utils/py_utils.py", line 352, in <listcomp>
_single_map_nested((function, obj, types, None, True, None))
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/utils/py_utils.py", line 288, in _single_map_nested
return function(data_struct)
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/utils/download_manager.py", line 320, in _download
return cached_path(url_or_filename, download_config=download_config)
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/utils/file_utils.py", line 234, in cached_path
output_path = get_from_cache(
File "/home/tangtianyi/miniconda3/lib/python3.8/site-packages/datasets/utils/file_utils.py", line 579, in get_from_cache
raise FileNotFoundError(f"Couldn't find file at {url}")
FileNotFoundError: Couldn't find file at https://github.com/facebookresearch/asset/raw/master/dataset/asset.test.orig
``` | 2022-05-24T05:55:52Z | 4,386 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-21T12:31:30Z | https://api.github.com/repos/huggingface/datasets/issues/4386/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4386/timeline | Bug for wiki_auto_asset_turk from GEM | https://api.github.com/repos/huggingface/datasets/issues/4386/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/37647985?v=4",
"events_url": "https://api.github.com/users/StevenTang1998/events{/privacy}",
"followers_url": "https://api.github.com/users/StevenTang1998/followers",
"following_url": "https://api.github.com/users/StevenTang1998/following{/other_user}",
"gists_url": "https://api.github.com/users/StevenTang1998/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/StevenTang1998",
"id": 37647985,
"login": "StevenTang1998",
"node_id": "MDQ6VXNlcjM3NjQ3OTg1",
"organizations_url": "https://api.github.com/users/StevenTang1998/orgs",
"received_events_url": "https://api.github.com/users/StevenTang1998/received_events",
"repos_url": "https://api.github.com/users/StevenTang1998/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/StevenTang1998/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/StevenTang1998/subscriptions",
"type": "User",
"url": "https://api.github.com/users/StevenTang1998"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | NONE | 2022-05-23T10:29:55Z | null | I_kwDODunzps5KJWhc | [
"Thanks for reporting, @StevenTang1998.\r\n\r\nI'm looking into it. ",
"Hi @StevenTang1998,\r\n\r\nWe have fixed the issue:\r\n- #4389\r\n\r\nThe fix will be available in our next `datasets` library release. In the meantime, you can incorporate that fix by installing `datasets` from our GitHub repo:\r\n```\r\npip... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4386/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4386 | https://github.com/huggingface/datasets/issues/4386 | false |
1,243,921,287 | https://api.github.com/repos/huggingface/datasets/issues/4385/labels{/name} | Regression test for future releases of `dill`.
Related to #4379. | 2022-05-25T08:30:13Z | 4,385 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-21T08:57:43Z | https://api.github.com/repos/huggingface/datasets/issues/4385/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4385/timeline | Test dill | https://api.github.com/repos/huggingface/datasets/issues/4385/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-25T08:21:48Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4385.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4385",
"merged_at": "2022-05-25T08:21:48Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4385.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4385"
} | PR_kwDODunzps44OwXF | [
"_The documentation is not available anymore as the PR was closed or merged._",
"I should point out that the hash will be the same if computed twice with the same code on the same version of dill (after adding huggingface's code that removes line numbers and file names, and sorts globals.) My changes in dill 0.3.... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4385/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4385 | https://github.com/huggingface/datasets/pull/4385 | true |
1,243,919,748 | https://api.github.com/repos/huggingface/datasets/issues/4384/labels{/name} | This PR performs a refactoring of the download functionalities, by proposing a modular solution and moving them to their own package "download". Some motivating arguments:
- understandability: from a logical partitioning of the library, it makes sense to have all download functionalities grouped together instead of scattered in a much larger directory containing many more different functionalities
- abstraction: the level of abstraction of "download" (higher) is not the same as "utils" (lower); putting different levels of abstraction together, makes dependencies more intricate (potential circular dependencies) and the system more tightly coupled; when the levels of abstraction are clearly separated, the dependencies flow in a neat direction from higher to lower
- architectural: "download" is a domain-specific functionality of our library/application (a dataset builder performs several actions: download, generate dataset and cache it); these functionalities are at the core of our library; on the other hand, "utils" are always a low-level set of functionalities, not directly related to our domain/business core logic (all libraries have "utils"), thus at the periphery of our lib architecture
Also note that when a library is not architecturally designed following simple, neat, clean principles, this has a negative impact on extensibility, making more and more difficult to make enhancements.
As a concrete example in this case, please see: https://app.circleci.com/pipelines/github/huggingface/datasets/12185/workflows/ff25a790-8e3f-45a1-aadd-9d79dfb73c4d/jobs/72860
- After an extension, a circular import is found
- Diving into the cause of this circular import, see the dependency flow, which should be from higher to lower levels of abstraction:
```
ImportError while loading conftest '/home/circleci/datasets/tests/conftest.py'.
tests/conftest.py:12: in <module>
import datasets
../.pyenv/versions/3.6.15/lib/python3.6/site-packages/datasets/__init__.py:37: in <module>
from .arrow_dataset import Dataset, concatenate_datasets
../.pyenv/versions/3.6.15/lib/python3.6/site-packages/datasets/arrow_dataset.py:59: in <module>
from . import config
../.pyenv/versions/3.6.15/lib/python3.6/site-packages/datasets/config.py:8: in <module>
from .utils.logging import get_logger
../.pyenv/versions/3.6.15/lib/python3.6/site-packages/datasets/utils/__init__.py:30: in <module>
from .download_manager import DownloadConfig, DownloadManager, DownloadMode
../.pyenv/versions/3.6.15/lib/python3.6/site-packages/datasets/utils/download_manager.py:39: in <module>
from .py_utils import NestedDataStructure, map_nested, size_str
../.pyenv/versions/3.6.15/lib/python3.6/site-packages/datasets/utils/py_utils.py:608: in <module>
if config.DILL_VERSION < version.parse("0.3.5"):
E AttributeError: module 'datasets.config' has no attribute 'DILL_VERSION'
```
Imports:
- datasets
- Dataset: lower level than datasets
- config: lower level than Dataset
- logger: lower level than config
- DownloadManager: !!! HIGHER level of abstraction than logger!!
Why when importing logger we require importing DownloadManager?!?
- Logically, it does not make sense
- This is due to an error in the design/architecture of our library:
- To import the logger, we need to import it from `.utils.logging`
- To import `.utils.logging` we need to import `.utils`
- The import of `.utils` require the import of all its submodules defined in `utils.__init__.py`, among them: `.utils.download_manager`!
When putting `logging` and `download_manager` both inside `utils`, in order to import `logging` we need to import `download_manager` first: this is a strong coupling between modules and moreover between modules at different levels of abstraction (to import a lower level module, we require to import a higher level module). Additionally, it is clear that is makes no sense that in order to import `logging` we require to import `download_manager` first. | 2022-05-25T10:52:02Z | 4,384 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-21T08:49:24Z | https://api.github.com/repos/huggingface/datasets/issues/4384/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4384/timeline | Refactor download | https://api.github.com/repos/huggingface/datasets/issues/4384/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-25T10:43:43Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4384.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4384",
"merged_at": "2022-05-25T10:43:43Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4384.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4384"
} | PR_kwDODunzps44OwFr | [
"_The documentation is not available anymore as the PR was closed or merged._",
"This looks like a breaking change no ?\r\nAlso could you explain why it would be better this way ?",
"The might be only there to help type checkers, but I am not too familiar with the code base to know for sure. I think this might ... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4384/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4384 | https://github.com/huggingface/datasets/pull/4384 | true |
1,243,856,981 | https://api.github.com/repos/huggingface/datasets/issues/4383/labels{/name} | ## Describe the L
L
## Expected L
A clear and concise lmll
Specify the actual results or traceback.
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version:
- Platform:
- Python version:
- PyArrow version: | 2022-05-21T19:20:13Z | 4,383 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-21T03:47:58Z | https://api.github.com/repos/huggingface/datasets/issues/4383/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4383/timeline | L | https://api.github.com/repos/huggingface/datasets/issues/4383/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/99847861?v=4",
"events_url": "https://api.github.com/users/AronCodes21/events{/privacy}",
"followers_url": "https://api.github.com/users/AronCodes21/followers",
"following_url": "https://api.github.com/users/AronCodes21/following{/other_user}",
"gists_url": "https://api.github.com/users/AronCodes21/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AronCodes21",
"id": 99847861,
"login": "AronCodes21",
"node_id": "U_kgDOBfOOtQ",
"organizations_url": "https://api.github.com/users/AronCodes21/orgs",
"received_events_url": "https://api.github.com/users/AronCodes21/received_events",
"repos_url": "https://api.github.com/users/AronCodes21/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AronCodes21/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AronCodes21/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AronCodes21"
} | [] | null | completed | NONE | 2022-05-21T19:20:13Z | null | I_kwDODunzps5KI8BV | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4383/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4383 | https://github.com/huggingface/datasets/issues/4383 | false |
1,243,839,783 | https://api.github.com/repos/huggingface/datasets/issues/4382/labels{/name} | ## Adding a Dataset
- **Name:** *name of the dataset*
- **Description:** *short description of the dataset (or link to social media or blog post)*
- **Paper:** *link to the dataset paper if available*
- **Data:** *link to the Github repository or current dataset location*
- **Motivation:** *what are some good reasons to have this dataset*
Instructions to add a new dataset can be found [here](https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md).
| 2022-05-21T19:20:44Z | 4,382 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "e99695",
"default": false,
"description": "Requesting to add a new dataset",
"id": 2067376369,
"name": "dataset request",
"node_id": "MDU6TGFiZWwyMDY3Mzc2MzY5",
"url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20request"
}
] | 2022-05-21T02:15:18Z | https://api.github.com/repos/huggingface/datasets/issues/4382/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4382/timeline | First time trying | https://api.github.com/repos/huggingface/datasets/issues/4382/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/87345839?v=4",
"events_url": "https://api.github.com/users/Aeckard45/events{/privacy}",
"followers_url": "https://api.github.com/users/Aeckard45/followers",
"following_url": "https://api.github.com/users/Aeckard45/following{/other_user}",
"gists_url": "https://api.github.com/users/Aeckard45/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Aeckard45",
"id": 87345839,
"login": "Aeckard45",
"node_id": "MDQ6VXNlcjg3MzQ1ODM5",
"organizations_url": "https://api.github.com/users/Aeckard45/orgs",
"received_events_url": "https://api.github.com/users/Aeckard45/received_events",
"repos_url": "https://api.github.com/users/Aeckard45/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Aeckard45/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Aeckard45/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Aeckard45"
} | [] | null | completed | NONE | 2022-05-21T19:20:44Z | null | I_kwDODunzps5KI30n | [] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4382/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4382 | https://github.com/huggingface/datasets/issues/4382 | false |
1,243,478,863 | https://api.github.com/repos/huggingface/datasets/issues/4381/labels{/name} | ## Describe the bug
The two datasets `mteb/mtop_intent` and `mteb/mtop_domain `use both the same cache folder `.cache/huggingface/datasets/mteb___mtop`. So if you first load `mteb/mtop_intent` then datasets will not load `mteb/mtop_domain`.
If you delete this cache folder and flip the order how you load the two datasets , you will get the opposite datasets loaded (difference is here in terms of the label and label_text).
## Steps to reproduce the bug
```python
import datasets
dataset = datasets.load_dataset("mteb/mtop_intent", "en")
print(dataset['train'][0])
dataset = datasets.load_dataset("mteb/mtop_domain", "en")
print(dataset['train'][0])
```
## Expected results
```
Reusing dataset mtop (/home/nouamane/.cache/huggingface/datasets/mteb___mtop_intent/en/0.0.0/f930e32a294fed424f70263d8802390e350fff17862266e5fc156175c07d9c35)
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:00<00:00, 920.14it/s]
{'id': 3232343436343136, 'text': 'Has Angelika Kratzer video messaged me?', 'label': 1, 'label_text': 'GET_MESSAGE'}
Reusing dataset mtop (/home/nouamane/.cache/huggingface/datasets/mteb___mtop_domain/en/0.0.0/f930e32a294fed424f70263d8802390e350fff17862266e5fc156175c07d9c35)
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:00<00:00, 1307.59it/s]
{'id': 3232343436343136, 'text': 'Has Angelika Kratzer video messaged me?', 'label': 0, 'label_text': 'messaging'}
```
## Actual results
```
Reusing dataset mtop (/home/nouamane/.cache/huggingface/datasets/mteb___mtop/en/0.0.0/f930e32a294fed424f70263d8802390e350fff17862266e5fc156175c07d9c35)
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:00<00:00, 920.14it/s]
{'id': 3232343436343136, 'text': 'Has Angelika Kratzer video messaged me?', 'label': 1, 'label_text': 'GET_MESSAGE'}
Reusing dataset mtop (/home/nouamane/.cache/huggingface/datasets/mteb___mtop/en/0.0.0/f930e32a294fed424f70263d8802390e350fff17862266e5fc156175c07d9c35)
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:00<00:00, 1307.59it/s]
{'id': 3232343436343136, 'text': 'Has Angelika Kratzer video messaged me?', 'label': 1, 'label_text': 'GET_MESSAGE'}
```
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version: 2.2.1
- Platform: macOS-12.1-arm64-arm-64bit
- Python version: 3.9.12
- PyArrow version: 8.0.0
- Pandas version: 1.4.2
| 2022-06-02T08:18:37Z | 4,381 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-20T18:18:03Z | https://api.github.com/repos/huggingface/datasets/issues/4381/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4381/timeline | Bug in caching 2 datasets both with the same builder class name | https://api.github.com/repos/huggingface/datasets/issues/4381/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/29777165?v=4",
"events_url": "https://api.github.com/users/NouamaneTazi/events{/privacy}",
"followers_url": "https://api.github.com/users/NouamaneTazi/followers",
"following_url": "https://api.github.com/users/NouamaneTazi/following{/other_user}",
"gists_url": "https://api.github.com/users/NouamaneTazi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/NouamaneTazi",
"id": 29777165,
"login": "NouamaneTazi",
"node_id": "MDQ6VXNlcjI5Nzc3MTY1",
"organizations_url": "https://api.github.com/users/NouamaneTazi/orgs",
"received_events_url": "https://api.github.com/users/NouamaneTazi/received_events",
"repos_url": "https://api.github.com/users/NouamaneTazi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/NouamaneTazi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NouamaneTazi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/NouamaneTazi"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | MEMBER | 2022-05-25T05:16:15Z | null | I_kwDODunzps5KHftP | [
"Hi @NouamaneTazi, thanks for reporting.\r\n\r\nPlease note that both datasets are cached in the same directory because their loading builder classes have the same name: `class MTOP(datasets.GeneratorBasedBuilder)`.\r\n\r\nYou should name their builder classes differently, e.g.:\r\n- `MtopDomain`\r\n- `MtopIntent`"... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4381/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4381 | https://github.com/huggingface/datasets/issues/4381 | false |
1,243,183,054 | https://api.github.com/repos/huggingface/datasets/issues/4380/labels{/name} | Hotfix #4379.
CC: @sgugger | 2022-06-13T10:03:52Z | 4,380 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-20T13:54:19Z | https://api.github.com/repos/huggingface/datasets/issues/4380/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4380/timeline | Pin dill | https://api.github.com/repos/huggingface/datasets/issues/4380/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-20T16:33:04Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4380.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4380",
"merged_at": "2022-05-20T16:33:04Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4380.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4380"
} | PR_kwDODunzps44MUz0 | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 1,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4380/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4380 | https://github.com/huggingface/datasets/pull/4380 | true |
1,243,175,854 | https://api.github.com/repos/huggingface/datasets/issues/4379/labels{/name} | ## Describe the bug
As reported by @sgugger, latest dill release is breaking things with Datasets.
```
______________ ExamplesTests.test_run_speech_recognition_seq2seq _______________
self = <multiprocess.pool.ApplyResult object at 0x7fa5981a1cd0>, timeout = None
def get(self, timeout=None):
self.wait(timeout)
if not self.ready():
raise TimeoutError
if self._success:
return self._value
else:
> raise self._value
E TypeError: '>' not supported between instances of 'NoneType' and 'float'
```
| 2022-05-21T15:53:26Z | 4,379 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
}
] | 2022-05-20T13:48:36Z | https://api.github.com/repos/huggingface/datasets/issues/4379/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4379/timeline | Latest dill release raises exception | https://api.github.com/repos/huggingface/datasets/issues/4379/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | MEMBER | 2022-05-20T17:06:27Z | null | I_kwDODunzps5KGVuu | [
"Fixed by:\r\n- #4380 ",
"Just an additional insight, the latest dill (either 0.3.5 or 0.3.5.1) also broke the hashing/fingerprinting of any mapping function.\r\n\r\nFor example:\r\n```\r\nfrom datasets import load_dataset\r\n\r\nd = load_dataset(\"rotten_tomatoes\")\r\nd.map(lambda x: x)\r\n```\r\n\r\nReturns th... | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4379/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4379 | https://github.com/huggingface/datasets/issues/4379 | false |
1,242,935,373 | https://api.github.com/repos/huggingface/datasets/issues/4378/labels{/name} | Amend three licenses on datasets to fit naming convention (lower case, cc licenses include sub-version number). I think that's it - everything else on datasets looks great & super-searchable now! | 2022-05-24T13:50:23Z | 4,378 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-20T10:16:12Z | https://api.github.com/repos/huggingface/datasets/issues/4378/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4378/timeline | Tidy up license metadata for google_wellformed_query, newspop, sick | https://api.github.com/repos/huggingface/datasets/issues/4378/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/121934?v=4",
"events_url": "https://api.github.com/users/leondz/events{/privacy}",
"followers_url": "https://api.github.com/users/leondz/followers",
"following_url": "https://api.github.com/users/leondz/following{/other_user}",
"gists_url": "https://api.github.com/users/leondz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/leondz",
"id": 121934,
"login": "leondz",
"node_id": "MDQ6VXNlcjEyMTkzNA==",
"organizations_url": "https://api.github.com/users/leondz/orgs",
"received_events_url": "https://api.github.com/users/leondz/received_events",
"repos_url": "https://api.github.com/users/leondz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/leondz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/leondz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/leondz"
} | [] | null | null | CONTRIBUTOR | 2022-05-24T13:10:27Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4378.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4378",
"merged_at": "2022-05-24T13:10:27Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4378.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4378"
} | PR_kwDODunzps44Lf2R | [
"_The documentation is not available anymore as the PR was closed or merged._",
"& thank you!"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4378/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4378 | https://github.com/huggingface/datasets/pull/4378 | true |
1,242,746,186 | https://api.github.com/repos/huggingface/datasets/issues/4377/labels{/name} | There was a bug in filepath segment:
- wrong: `jkkummerfeld-irc-disentanglement-fd379e9`
- right: `jkkummerfeld-irc-disentanglement-35f0a40`
Also there was a bug in the checksum of the downloaded file.
This PR fixes these issues.
Fix partially #4376.
| 2022-05-20T09:34:36Z | 4,377 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-20T07:29:28Z | https://api.github.com/repos/huggingface/datasets/issues/4377/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4377/timeline | Fix checksum and bug in irc_disentangle dataset | https://api.github.com/repos/huggingface/datasets/issues/4377/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | [] | null | null | MEMBER | 2022-05-20T09:26:32Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4377.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4377",
"merged_at": "2022-05-20T09:26:32Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4377.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4377"
} | PR_kwDODunzps44K4OY | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4377/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4377 | https://github.com/huggingface/datasets/pull/4377 | true |
1,242,218,144 | https://api.github.com/repos/huggingface/datasets/issues/4376/labels{/name} | the dataviewer shows this message for "ubuntu" - "train", "test", and "validation" splits:
```
Server error
Status code: 400
Exception: ValueError
Message: Cannot seek streaming HTTP file
```
it appears to give the same message for the "channel_two" data as well.
I get a Checksums error when using `load_data()` with this dataset. Even with the `download_mode` and `ignore_verifications` options set. i referenced the issue here: https://github.com/huggingface/datasets/issues/3807 | 2023-01-12T16:56:13Z | 4,376 | null | https://api.github.com/repos/huggingface/datasets | null | [] | 2022-05-19T19:15:16Z | https://api.github.com/repos/huggingface/datasets/issues/4376/comments | {
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/other_user}",
"gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albertvillanova",
"id": 8515462,
"login": "albertvillanova",
"node_id": "MDQ6VXNlcjg1MTU0NjI=",
"organizations_url": "https://api.github.com/users/albertvillanova/orgs",
"received_events_url": "https://api.github.com/users/albertvillanova/received_events",
"repos_url": "https://api.github.com/users/albertvillanova/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albertvillanova"
} | https://api.github.com/repos/huggingface/datasets/issues/4376/timeline | irc_disentagle viewer error | https://api.github.com/repos/huggingface/datasets/issues/4376/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/25671683?v=4",
"events_url": "https://api.github.com/users/labouz/events{/privacy}",
"followers_url": "https://api.github.com/users/labouz/followers",
"following_url": "https://api.github.com/users/labouz/following{/other_user}",
"gists_url": "https://api.github.com/users/labouz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/labouz",
"id": 25671683,
"login": "labouz",
"node_id": "MDQ6VXNlcjI1NjcxNjgz",
"organizations_url": "https://api.github.com/users/labouz/orgs",
"received_events_url": "https://api.github.com/users/labouz/received_events",
"repos_url": "https://api.github.com/users/labouz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/labouz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/labouz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/labouz"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4",
"events_url": "https://api.github.com/users/albertvillanova/events{/privacy}",
"followers_url": "https://api.github.com/users/albertvillanova/followers",
"following_url": "https://api.github.com/users/albertvillanova/following{/o... | null | completed | NONE | 2022-06-02T08:20:00Z | null | I_kwDODunzps5KCr6g | [
"DUPLICATED comment from https://github.com/huggingface/datasets/issues/3807:\r\n\r\nmy code:\r\n```\r\nfrom datasets import load_dataset\r\n\r\ndataset = load_dataset(\"irc_disentangle\", download_mode=\"force_redownload\")\r\n```\r\nhowever, it produces the same error\r\n```\r\n[38](file:///Library/Frameworks/Pyt... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4376/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4376 | https://github.com/huggingface/datasets/issues/4376 | false |
1,241,921,147 | https://api.github.com/repos/huggingface/datasets/issues/4375/labels{/name} | ### Issue
It's currently not possible to properly stream a dataset using multiple `torch.utils.data.DataLoader` workers:
- the `TorchIterableDataset` can't be pickled and passed to the subprocesses: https://github.com/huggingface/datasets/issues/3950
- streaming extension is failing: https://github.com/huggingface/datasets/issues/3951
- `fsspec` doesn't work out of the box in subprocesses
### Solution in this PR
I fixed these to enable passing an `IterableDataset` to a `torch.utils.data.DataLoader` with `num_workers > 0`.
I also had to shard the `IterableDataset` to give each worker a shard, otherwise data would be duplicated. This is implemented in `TorchIterableDataset.__iter__` and uses the new `IterableDataset._iter_shard(shard_idx)` method
I also had to do a few changes the patching that enable streaming in dataset scripts:
- the patches are now always applied - not just for streaming mode. They're applied when a builder is instantiated
- I improved it to also check for renamed modules or attributes (ex: pandas vs pd)
- I grouped all the patches of pathlib.Path into a class `xPath`, so that `Path` outside of dataset scripts stay unchanged - otherwise I didn't change the content of the extended Path methods for streaming
- I fixed a bug with the `pd.read_csv` patch, opening the file in "rb" mode was missing and causing some datasets to not work in streaming mode, and compression inference was missing
### A few details regarding `fsspec` in multiprocessing
From https://github.com/fsspec/filesystem_spec/pull/963#issuecomment-1131709948 :
> Non-async instances might be safe in the forked child, if they hold no open files/sockets etc.; I'm not sure any implementations pass this test!
> If any async instance has been created, the newly forked processes must:
> 1. discard references to locks, threads and event loops and make new ones
> 2. not use any async fsspec instances from the parent process
> 3. clear all class instance caches
Therefore in a DataLoader's worker, I clear the reference to the loop and thread (1). We should be fine for 2 and 3 already since we don't use fsspec class instances from the parent process.
Fix https://github.com/huggingface/datasets/issues/3950
Fix https://github.com/huggingface/datasets/issues/3951
TODO:
- [x] fix tests | 2022-07-04T16:05:14Z | 4,375 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-19T15:00:31Z | https://api.github.com/repos/huggingface/datasets/issues/4375/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4375/timeline | Support DataLoader with num_workers > 0 in streaming mode | https://api.github.com/repos/huggingface/datasets/issues/4375/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/42851186?v=4",
"events_url": "https://api.github.com/users/lhoestq/events{/privacy}",
"followers_url": "https://api.github.com/users/lhoestq/followers",
"following_url": "https://api.github.com/users/lhoestq/following{/other_user}",
"gists_url": "https://api.github.com/users/lhoestq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lhoestq",
"id": 42851186,
"login": "lhoestq",
"node_id": "MDQ6VXNlcjQyODUxMTg2",
"organizations_url": "https://api.github.com/users/lhoestq/orgs",
"received_events_url": "https://api.github.com/users/lhoestq/received_events",
"repos_url": "https://api.github.com/users/lhoestq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lhoestq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lhoestq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lhoestq"
} | [] | null | null | MEMBER | 2022-06-10T20:47:27Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4375.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4375",
"merged_at": "2022-06-10T20:47:26Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4375.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4375"
} | PR_kwDODunzps44IMCS | [
"_The documentation is not available anymore as the PR was closed or merged._",
"Alright this is finally ready for review ! It's quite long I'm sorry, but it's not easy to disentangle everything ^^'\r\n\r\nThe main additions are in\r\n- src/datasets/formatting/dataset_wrappers/torch_iterable_dataset.py\r\n- src/d... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4375/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4375 | https://github.com/huggingface/datasets/pull/4375 | true |
1,241,860,535 | https://api.github.com/repos/huggingface/datasets/issues/4374/labels{/name} | ## processing a custom dataset loaded as .txt file is extremely slow, compared to a dataset of similar volume from the hub
I have a large .txt file of 22 GB which i load into HF dataset
`lang_dataset = datasets.load_dataset("text", data_files="hi.txt")`
further i use a pre-processing function to clean the dataset
`lang_dataset["train"] = lang_dataset["train"].map(
remove_non_indic_sentences, num_proc=12, batched=True, remove_columns=lang_dataset['train'].column_names), batch_size=64)`
the following processing takes astronomical time to process, while hoging all the ram.
similar dataset of same size that's available in the huggingface hub works completely fine. which runs the same processing function and has the same amount of data.
`lang_dataset = datasets.load_dataset("oscar-corpus/OSCAR-2109", "hi", use_auth_token=True)`
the hours predicted to preprocess are as follows:
huggingface hub dataset: 6.5 hrs
custom loaded dataset: 7000 hrs
note: both the datasets are almost actually same, just provided by different sources with has +/- some samples, only one is hosted on the HF hub and the other is downloaded in a text format.
## Steps to reproduce the bug
```
import datasets
import psutil
import sys
import glob
from fastcore.utils import listify
import re
import gc
def remove_non_indic_sentences(example):
tmp_ls = []
eng_regex = r'[. a-zA-Z0-9ÖÄÅöäå _.,!"\'\/$]*'
for e in listify(example['text']):
matches = re.findall(eng_regex, e)
for match in (str(match).strip() for match in matches if match not in [""," ", " ", ",", " ,", ", ", " , "]):
if len(list(match.split(" "))) > 2:
e = re.sub(match," ",e,count=1)
tmp_ls.append(e)
gc.collect()
example['clean_text'] = tmp_ls
return example
lang_dataset = datasets.load_dataset("text", data_files="hi.txt")
lang_dataset["train"] = lang_dataset["train"].map(
remove_non_indic_sentences, num_proc=12, batched=True, remove_columns=lang_dataset['train'].column_names), batch_size=64)
## same thing work much faster when loading similar dataset from hub
lang_dataset = datasets.load_dataset("oscar-corpus/OSCAR-2109", "hi", split="train", use_auth_token=True)
lang_dataset["train"] = lang_dataset["train"].map(
remove_non_indic_sentences, num_proc=12, batched=True, remove_columns=lang_dataset['train'].column_names), batch_size=64)
```
## Actual results
similar dataset of same size that's available in the huggingface hub works completely fine. which runs the same processing function and has the same amount of data.
`lang_dataset = datasets.load_dataset("oscar-corpus/OSCAR-2109", "hi", use_auth_token=True)
**the hours predicted to preprocess are as follows:**
huggingface hub dataset: 6.5 hrs
custom loaded dataset: 7000 hrs
**i even tried the following:**
- sharding the large 22gb text files into smaller files and loading
- saving the file to disk and then loading
- using lesser num_proc
- using smaller batch size
- processing without batches ie : without `batched=True`
## Environment info
<!-- You can run the command `datasets-cli env` and copy-and-paste its output below. -->
- `datasets` version: 2.2.2.dev0
- Platform: Ubuntu 20.04 LTS
- Python version: 3.9.7
- PyArrow version:8.0.0
| 2023-07-25T15:07:17Z | 4,374 | null | https://api.github.com/repos/huggingface/datasets | null | [
{
"color": "d73a4a",
"default": true,
"description": "Something isn't working",
"id": 1935892857,
"name": "bug",
"node_id": "MDU6TGFiZWwxOTM1ODkyODU3",
"url": "https://api.github.com/repos/huggingface/datasets/labels/bug"
},
{
"color": "d876e3",
"default": true,
"descript... | 2022-05-19T14:18:05Z | https://api.github.com/repos/huggingface/datasets/issues/4374/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4374/timeline | extremely slow processing when using a custom dataset | https://api.github.com/repos/huggingface/datasets/issues/4374/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/32235549?v=4",
"events_url": "https://api.github.com/users/StephennFernandes/events{/privacy}",
"followers_url": "https://api.github.com/users/StephennFernandes/followers",
"following_url": "https://api.github.com/users/StephennFernandes/following{/other_user}",
"gists_url": "https://api.github.com/users/StephennFernandes/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/StephennFernandes",
"id": 32235549,
"login": "StephennFernandes",
"node_id": "MDQ6VXNlcjMyMjM1NTQ5",
"organizations_url": "https://api.github.com/users/StephennFernandes/orgs",
"received_events_url": "https://api.github.com/users/StephennFernandes/received_events",
"repos_url": "https://api.github.com/users/StephennFernandes/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/StephennFernandes/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/StephennFernandes/subscriptions",
"type": "User",
"url": "https://api.github.com/users/StephennFernandes"
} | [] | null | completed | NONE | 2023-07-25T15:07:16Z | null | I_kwDODunzps5KBUm3 | [
"Hi !\r\n\r\nMy guess is that some examples in your dataset are bigger than your RAM, and therefore loading them in RAM to pass them to `remove_non_indic_sentences` takes forever because it might use SWAP memory.\r\n\r\nMaybe several examples in your dataset are grouped together, can you check `len(lang_dataset[\"t... | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4374/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4374 | https://github.com/huggingface/datasets/issues/4374 | false |
1,241,769,310 | https://api.github.com/repos/huggingface/datasets/issues/4373/labels{/name} | Remove the links in the docs to the no longer maintained dataset viewer. | 2022-05-20T15:24:28Z | 4,373 | null | https://api.github.com/repos/huggingface/datasets | false | [] | 2022-05-19T13:24:39Z | https://api.github.com/repos/huggingface/datasets/issues/4373/comments | null | https://api.github.com/repos/huggingface/datasets/issues/4373/timeline | Remove links in docs to old dataset viewer | https://api.github.com/repos/huggingface/datasets/issues/4373/events | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/47462742?v=4",
"events_url": "https://api.github.com/users/mariosasko/events{/privacy}",
"followers_url": "https://api.github.com/users/mariosasko/followers",
"following_url": "https://api.github.com/users/mariosasko/following{/other_user}",
"gists_url": "https://api.github.com/users/mariosasko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mariosasko",
"id": 47462742,
"login": "mariosasko",
"node_id": "MDQ6VXNlcjQ3NDYyNzQy",
"organizations_url": "https://api.github.com/users/mariosasko/orgs",
"received_events_url": "https://api.github.com/users/mariosasko/received_events",
"repos_url": "https://api.github.com/users/mariosasko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mariosasko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mariosasko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mariosasko"
} | [] | null | null | CONTRIBUTOR | 2022-05-20T15:16:05Z | {
"diff_url": "https://github.com/huggingface/datasets/pull/4373.diff",
"html_url": "https://github.com/huggingface/datasets/pull/4373",
"merged_at": "2022-05-20T15:16:05Z",
"patch_url": "https://github.com/huggingface/datasets/pull/4373.patch",
"url": "https://api.github.com/repos/huggingface/datasets/pulls/4373"
} | PR_kwDODunzps44HsaY | [
"_The documentation is not available anymore as the PR was closed or merged._"
] | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/huggingface/datasets/issues/4373/reactions"
} | closed | false | https://api.github.com/repos/huggingface/datasets/issues/4373 | https://github.com/huggingface/datasets/pull/4373 | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.