text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -136,6 +123,20 @@ private static async Task<bool> InitializeLogFileWriterBackgroundTaskAsync() return false; }
bad
review
csharp
0x7c13/Notepads
ad7c8d959d20f38045f980bd6683265cb823f9d2
diff --git a/src/Notepads/Services/LoggingService.cs b/src/Notepads/Services/LoggingService.cs index 5c291013d..1d9deaa9b 100644 --- a/src/Notepads/Services/LoggingService.cs +++ b/src/Notepads/Services/LoggingService.cs @@ -13,7 +13,7 @@ public static class LoggingService { - private const string Me...
good
review_fixed
csharp
0x7c13/Notepads
ad7c8d959d20f38045f980bd6683265cb823f9d2
@@ -67,8 +67,13 @@ manim-render example_scenes.py OpeningManimExample ```sh brew install ffmpeg mactex ``` + +2. If you are using M1, install Cairo.
bad
review
3b1b/manim
2f2fc297005b3245e56db4c3143d8f0420907ecd
diff --git a/README.md b/README.md index 240d03a698..3451515742 100644 --- a/README.md +++ b/README.md @@ -67,8 +67,13 @@ manim-render example_scenes.py OpeningManimExample ```sh brew install ffmpeg mactex ``` + +2. If you are using an ARM-based processor, install Cairo. + ```sh + arch -arm64 brew...
good
review_fixed
3b1b/manim
2f2fc297005b3245e56db4c3143d8f0420907ecd
@@ -142,35 +143,48 @@ def get_indent(code_lines: list[str], line_number: int) -> str: return n_spaces * " " -def insert_embed_line_to_module(module: Module, line_number: int): +def insert_embed_line_to_module(module: Module, run_config: Dict) -> None: """ This is hacky, but convenient. When user incl...
bad
review
python
3b1b/manim
f562d749d94a6f9c8ed2461643524fe9c2e2c4db
diff --git a/manimlib/extract_scene.py b/manimlib/extract_scene.py index 5509778b05..28e22256ee 100644 --- a/manimlib/extract_scene.py +++ b/manimlib/extract_scene.py @@ -12,6 +12,7 @@ from manimlib.scene.scene import Scene from typing import TYPE_CHECKING + if TYPE_CHECKING: Module = importlib.util.types.Mod...
good
review_fixed
python
3b1b/manim
f562d749d94a6f9c8ed2461643524fe9c2e2c4db
@@ -5,13 +5,13 @@ # you are running manim. For 3blue1brown, for instance, mind is # here: https://github.com/3b1b/videos/blob/master/custom_config.yml -# Alternatively, you can create it whereever you like, and on running +# Alternatively, you can create it where ever you like, and on running
bad
review
3b1b/manim
f562d749d94a6f9c8ed2461643524fe9c2e2c4db
diff --git a/manimlib/default_config.yml b/manimlib/default_config.yml index 397de60ebf..6e2135b995 100644 --- a/manimlib/default_config.yml +++ b/manimlib/default_config.yml @@ -5,13 +5,13 @@ # you are running manim. For 3blue1brown, for instance, mind is # here: https://github.com/3b1b/videos/blob/master/custom_con...
good
review_fixed
3b1b/manim
f562d749d94a6f9c8ed2461643524fe9c2e2c4db
@@ -142,35 +143,48 @@ def get_indent(code_lines: list[str], line_number: int) -> str: return n_spaces * " " -def insert_embed_line_to_module(module: Module, line_number: int): +def insert_embed_line_to_module(module: Module, run_config: Dict) -> None: """ This is hacky, but convenient. When user incl...
bad
review
python
3b1b/manim
f562d749d94a6f9c8ed2461643524fe9c2e2c4db
diff --git a/manimlib/extract_scene.py b/manimlib/extract_scene.py index 5509778b05..28e22256ee 100644 --- a/manimlib/extract_scene.py +++ b/manimlib/extract_scene.py @@ -12,6 +12,7 @@ from manimlib.scene.scene import Scene from typing import TYPE_CHECKING + if TYPE_CHECKING: Module = importlib.util.types.Mod...
good
review_fixed
python
3b1b/manim
f562d749d94a6f9c8ed2461643524fe9c2e2c4db
@@ -0,0 +1,54 @@ +#ifndef _BOARD_CONFIG_H_ +#define _BOARD_CONFIG_H_ + +#include <driver/gpio.h> + +#define AUDIO_INPUT_SAMPLE_RATE 24000 +#define AUDIO_OUTPUT_SAMPLE_RATE 24000 + +#define AUDIO_INPUT_REFERENCE true + +#define AUDIO_I2S_GPIO_MCLK GPIO_NUM_13 +#define AUDIO_I2S_GPIO_...
bad
review
c
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
diff --git a/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/config.h b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/config.h new file mode 100644 index 0000000000..749b601207 --- /dev/null +++ b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/config.h @@ -0,0 +1,45 @@ +#ifndef _BOARD_CONFIG_H_ +#define _BO...
good
review_fixed
c
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
@@ -0,0 +1,21 @@ +{ + "manufacturer": "waveshare", + "target": "esp32p4", + "builds": [ + { + "name": "esp32-p4-wifi6-touch-lcd-3.5", + "sdkconfig_append": [ + "CONFIG_SPIRAM_MALLOC_ALWAYSINTERNAL=0", + "CONFIG_BOOTLOADER_CACHE_32BIT_ADDR_QUAD_FLASH=y"...
bad
review
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
diff --git a/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/config.json b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/config.json new file mode 100644 index 0000000000..50f640886e --- /dev/null +++ b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/config.json @@ -0,0 +1,17 @@ +{ + "manufacturer": "wave...
good
review_fixed
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
@@ -0,0 +1,205 @@ +#include "wifi_board.h" +#include "codecs/es8311_audio_codec.h" +#include "application.h" +#include "display/lcd_display.h" +#include "button.h" +#include "esp_video.h" +#include "esp_video_init.h" +#include "esp_cam_sensor_xclk.h" +#include "esp_lcd_mipi_dsi.h"
bad
review
cpp
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
diff --git a/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-touch-lcd-3.5.cc b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-touch-lcd-3.5.cc new file mode 100644 index 0000000000..f042611d31 --- /dev/null +++ b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-tou...
good
review_fixed
cpp
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
@@ -0,0 +1,205 @@ +#include "wifi_board.h" +#include "codecs/es8311_audio_codec.h" +#include "application.h" +#include "display/lcd_display.h" +#include "button.h" +#include "esp_video.h" +#include "esp_video_init.h" +#include "esp_cam_sensor_xclk.h" +#include "esp_lcd_mipi_dsi.h" +#include "esp_lcd_panel_ops.h" +#incl...
bad
review
cpp
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
diff --git a/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-touch-lcd-3.5.cc b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-touch-lcd-3.5.cc new file mode 100644 index 0000000000..f042611d31 --- /dev/null +++ b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-tou...
good
review_fixed
cpp
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
@@ -0,0 +1,205 @@ +#include "wifi_board.h" +#include "codecs/es8311_audio_codec.h" +#include "application.h" +#include "display/lcd_display.h" +#include "button.h" +#include "esp_video.h" +#include "esp_video_init.h" +#include "esp_cam_sensor_xclk.h" +#include "esp_lcd_mipi_dsi.h" +#include "esp_lcd_panel_ops.h" +#incl...
bad
review
cpp
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
diff --git a/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-touch-lcd-3.5.cc b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-touch-lcd-3.5.cc new file mode 100644 index 0000000000..f042611d31 --- /dev/null +++ b/main/boards/waveshare/esp32-p4-wifi6-touch-lcd-3.5/esp32-p4-wifi6-tou...
good
review_fixed
cpp
78/xiaozhi-esp32
d54e523dd9102342c3e9e19cb431b22b18cf199a
@@ -0,0 +1,12 @@ +{ + "target": "esp32s3",
bad
review
78/xiaozhi-esp32
74fa5413fcb81599f177c87dc2183c9d8670f7b3
diff --git a/main/boards/waveshare/esp32-s3-touch-lcd-1.54/config.json b/main/boards/waveshare/esp32-s3-touch-lcd-1.54/config.json new file mode 100644 index 0000000000..ec065cae1d --- /dev/null +++ b/main/boards/waveshare/esp32-s3-touch-lcd-1.54/config.json @@ -0,0 +1,13 @@ +{ + "manufacturer": "waveshare", + "t...
good
review_fixed
78/xiaozhi-esp32
74fa5413fcb81599f177c87dc2183c9d8670f7b3
@@ -0,0 +1,12 @@ +{ + "target": "esp32s3",
bad
review
78/xiaozhi-esp32
74fa5413fcb81599f177c87dc2183c9d8670f7b3
diff --git a/main/boards/waveshare/esp32-s3-lcd-0.85/config.json b/main/boards/waveshare/esp32-s3-lcd-0.85/config.json new file mode 100644 index 0000000000..6520b37337 --- /dev/null +++ b/main/boards/waveshare/esp32-s3-lcd-0.85/config.json @@ -0,0 +1,15 @@ +{ + "manufacturer": "waveshare", + "target": "esp32s3",...
good
review_fixed
78/xiaozhi-esp32
74fa5413fcb81599f177c87dc2183c9d8670f7b3
@@ -0,0 +1,13 @@ +{ + "manufacturer": "waveshare", + "target": "esp32s3", + "builds": [ + { + "name": "esp32-s3-lcd-0.85", + "sdkconfig_append": [ + "CONFIG_USE_ESP_WAKE_WORD=y"
bad
review
78/xiaozhi-esp32
74fa5413fcb81599f177c87dc2183c9d8670f7b3
diff --git a/main/boards/waveshare/esp32-s3-lcd-0.85/config.json b/main/boards/waveshare/esp32-s3-lcd-0.85/config.json new file mode 100644 index 0000000000..6520b37337 --- /dev/null +++ b/main/boards/waveshare/esp32-s3-lcd-0.85/config.json @@ -0,0 +1,15 @@ +{ + "manufacturer": "waveshare", + "target": "esp32s3",...
good
review_fixed
78/xiaozhi-esp32
74fa5413fcb81599f177c87dc2183c9d8670f7b3
@@ -0,0 +1,13 @@ +{ + "manufacturer": "waveshare", + "target": "esp32s3", + "builds": [ + { + "name": "esp32-s3-touch-lcd-1.54", + "sdkconfig_append": [ + "CONFIG_USE_ESP_WAKE_WORD=y"
bad
review
78/xiaozhi-esp32
74fa5413fcb81599f177c87dc2183c9d8670f7b3
diff --git a/main/boards/waveshare/esp32-s3-touch-lcd-1.54/config.json b/main/boards/waveshare/esp32-s3-touch-lcd-1.54/config.json new file mode 100644 index 0000000000..ec065cae1d --- /dev/null +++ b/main/boards/waveshare/esp32-s3-touch-lcd-1.54/config.json @@ -0,0 +1,13 @@ +{ + "manufacturer": "waveshare", + "t...
good
review_fixed
78/xiaozhi-esp32
74fa5413fcb81599f177c87dc2183c9d8670f7b3
@@ -326,7 +327,13 @@ if (1) "mt_xowa": "there are bugs in iOS preventing background playback using this format; please use caf or mp3 instead", "mt_tint": "background level (0-100) on the seekbar$Nto make buffering less distracting", "mt_eq": "enables the equalizer and gain control;$N$Nboost &lt;code&gt;0&lt;/...
bad
review
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js index 70c623567..eb6d2a65a 100644 --- a/copyparty/web/browser.js +++ b/copyparty/web/browser.js @@ -290,6 +290,7 @@ if (1) "ml_tint": "tint", "ml_eq": "audio equalizer", "ml_drc": "dynamic range compressor", + "ml_ss": "skip silence", "mt_l...
good
review_fixed
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
@@ -2690,11 +2700,15 @@ var afilt = (function () { var r = { "eqen": false, "drcen": false, + "ssen": false, "bands": [31.25, 62.5, 125, 250, 500, 1000, 2000, 4000, 8000, 16000], "gains": [4, 3, 2, 1, 0, 0, 1, 2, 3, 4], "drcv": [-24, 30, 12, 0.01, 0.25], - "drch": ['tresh', 'knee', 'ratio', 'atk', 'r...
bad
review
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js index 70c623567..eb6d2a65a 100644 --- a/copyparty/web/browser.js +++ b/copyparty/web/browser.js @@ -290,6 +290,7 @@ if (1) "ml_tint": "tint", "ml_eq": "audio equalizer", "ml_drc": "dynamic range compressor", + "ml_ss": "skip silence", "mt_l...
good
review_fixed
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
@@ -2583,6 +2591,8 @@ var mpui = (function () { // occasionally draw buffered regions if (nth % 5 == 0) pbar.drawbuf(); + + if (!IE && jread('au_ss', false)) skipSilence();
bad
review
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js index 70c623567..eb6d2a65a 100644 --- a/copyparty/web/browser.js +++ b/copyparty/web/browser.js @@ -290,6 +290,7 @@ if (1) "ml_tint": "tint", "ml_eq": "audio equalizer", "ml_drc": "dynamic range compressor", + "ml_ss": "skip silence", "mt_l...
good
review_fixed
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
@@ -2769,6 +2783,7 @@ var afilt = (function () { r.gains = gains; r.drcv = jread('au_drcv', r.drcv); + r.sscv = jread('au_sscv', r.sscv)
bad
review
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js index 70c623567..eb6d2a65a 100644 --- a/copyparty/web/browser.js +++ b/copyparty/web/browser.js @@ -290,6 +290,7 @@ if (1) "ml_tint": "tint", "ml_eq": "audio equalizer", "ml_drc": "dynamic range compressor", + "ml_ss": "skip silence", "mt_l...
good
review_fixed
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
@@ -9929,6 +9984,94 @@ function reload_browser() { dsel_init(); })(); +function skipSilence() { + var ae = mp.au; + var ssconf = jread('au_sscv', [1, 5, 5, 5.0, 0.2]);
bad
review
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js index 70c623567..eb6d2a65a 100644 --- a/copyparty/web/browser.js +++ b/copyparty/web/browser.js @@ -290,6 +290,7 @@ if (1) "ml_tint": "tint", "ml_eq": "audio equalizer", "ml_drc": "dynamic range compressor", + "ml_ss": "skip silence", "mt_l...
good
review_fixed
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
@@ -9929,6 +9984,94 @@ function reload_browser() { dsel_init(); })(); +function skipSilence() { + var ae = mp.au; + var ssconf = jread('au_sscv', [1, 5, 5, 5.0, 0.2]); + + var config = { + vthresh: ssconf[0], + sthresh: ssconf[1], + etresh: ssconf[2], + sspeed: ssconf[3], + rspeed: ssconf[4], + loopInterval:...
bad
review
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js index 70c623567..eb6d2a65a 100644 --- a/copyparty/web/browser.js +++ b/copyparty/web/browser.js @@ -290,6 +290,7 @@ if (1) "ml_tint": "tint", "ml_eq": "audio equalizer", "ml_drc": "dynamic range compressor", + "ml_ss": "skip silence", "mt_l...
good
review_fixed
javascript
9001/copyparty
8f4bb8033a74ddc7a0e3a99918f74efffc95b475
@@ -36,10 +36,10 @@ window.baguetteBox = (function () { touchFlag = false, // busy scrollCSS = ['', ''], scrollTimer = 0, - re_i = /^[^?]+\.(a?png|avif|bmp|gif|heif|jpe?g|jfif|svg|webp)(\?|$)/i, + re_i = /^[^?]+\.(a?png|avif|bmp|gif|heif|jpe?g|jfif|svg|webp|jxl)(\?|$)/i,
bad
review
javascript
9001/copyparty
fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef
diff --git a/copyparty/web/baguettebox.js b/copyparty/web/baguettebox.js index 4b132a494..c8fbeecbf 100644 --- a/copyparty/web/baguettebox.js +++ b/copyparty/web/baguettebox.js @@ -36,7 +36,7 @@ window.baguetteBox = (function () { touchFlag = false, // busy scrollCSS = ['', ''], scrollTimer ...
good
review_fixed
javascript
9001/copyparty
fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef
@@ -36,10 +36,10 @@ window.baguetteBox = (function () { touchFlag = false, // busy scrollCSS = ['', ''], scrollTimer = 0, - re_i = /^[^?]+\.(a?png|avif|bmp|gif|heif|jpe?g|jfif|svg|webp)(\?|$)/i, + re_i = /^[^?]+\.(a?png|avif|bmp|gif|heif|jpe?g|jfif|svg|webp|jxl)(\?|$)/i, ...
bad
review
javascript
9001/copyparty
fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef
diff --git a/copyparty/web/baguettebox.js b/copyparty/web/baguettebox.js index 4b132a494..c8fbeecbf 100644 --- a/copyparty/web/baguettebox.js +++ b/copyparty/web/baguettebox.js @@ -36,7 +36,7 @@ window.baguetteBox = (function () { touchFlag = false, // busy scrollCSS = ['', ''], scrollTimer ...
good
review_fixed
javascript
9001/copyparty
fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef
@@ -1147,22 +1147,26 @@ function read_sbw() { onresize100.add(read_sbw, true); -var have_webp = sread('have_webp'); -(function () { - if (have_webp !== null) +function check_image_support(format, uri) { + var cached = sread('have_' + format);
bad
review
javascript
9001/copyparty
fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef
diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js index eb6d2a65a..17787ca11 100644 --- a/copyparty/web/browser.js +++ b/copyparty/web/browser.js @@ -1154,22 +1154,26 @@ function read_sbw() { onresize100.add(read_sbw, true); -var have_webp = sread('have_webp'); -(function () { - if (have_webp !== nu...
good
review_fixed
javascript
9001/copyparty
fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef
@@ -89,10 +90,10 @@ def get(self, dbv: VFS, rem: str, mtime: float, fmt: str) -> Optional[str]: preferred = self.args.th_dec[0] if self.args.th_dec else "" - if rem.startswith(".hist/th/") and rem.split(".")[-1] in ["webp", "jpg", "png"]: + if rem.startswith(".hist/th/") and rem.split(".")[-1...
bad
review
python
9001/copyparty
fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef
diff --git a/copyparty/th_cli.py b/copyparty/th_cli.py index 384316eeb..5297b6b90 100644 --- a/copyparty/th_cli.py +++ b/copyparty/th_cli.py @@ -8,7 +8,7 @@ from .__init__ import TYPE_CHECKING from .authsrv import VFS from .bos import bos -from .th_srv import EXTS_AC, HAVE_WEBP, thumb_path +from .th_srv import EXTS_...
good
review_fixed
python
9001/copyparty
fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef
@@ -117,8 +118,10 @@ eclair { timeout = 60 seconds } - dust-limit-satoshis = 546 - max-remote-dust-limit-satoshis = 600 + // Now that most channels use anchor outputs, HTLCs aren't trimmed based on feerate, so we need to set our dust + // limit to an amount that is economical to spend on-chain...
bad
review
ACINQ/eclair
8c75c5caa7f47ee228ff318f528fc62f92505f88
diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf index 64a988c122..87741f1ab9 100644 --- a/eclair-core/src/main/resources/reference.conf +++ b/eclair-core/src/main/resources/reference.conf @@ -76,6 +76,7 @@ eclair { option_quiesce = optional option_att...
good
review_fixed
ACINQ/eclair
8c75c5caa7f47ee228ff318f528fc62f92505f88
@@ -190,6 +217,11 @@ object Transactions { } object RedeemInfo { sealed trait SegwitV0 extends RedeemInfo { def redeemScript: ByteVector } + /** @param publicKey the public key for this p2wpkh input. */ + case class P2wpkh(publicKey: PublicKey) extends SegwitV0 { + override val redeemScript: ByteV...
bad
review
scala
ACINQ/eclair
8c75c5caa7f47ee228ff318f528fc62f92505f88
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala b/eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala index a9b9c981a5..d53e614275 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala +++ b/eclair-core/src/main/scala/fr/ac...
good
review_fixed
scala
ACINQ/eclair
8c75c5caa7f47ee228ff318f528fc62f92505f88
@@ -2416,102 +2416,104 @@ class Channel(val nodeParams: NodeParams, val channelKeys: ChannelKeys, val wall case Event(INPUT_RECONNECTED(r, localInit, remoteInit), d: DATA_WAIT_FOR_DUAL_FUNDING_SIGNED) => activeConnection = r + val d1 = Helpers.updateFeatures(d, localInit, remoteInit)
bad
review
scala
ACINQ/eclair
d395c5509180936d771cae00c54ec2279bb94287
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala index 407f0cb903..af889c5140 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel...
good
review_fixed
scala
ACINQ/eclair
d395c5509180936d771cae00c54ec2279bb94287
@@ -128,6 +128,7 @@ 191acabbce3e466008fe4274d09793603eb0083e3b36c692feb958aa8b067821 com/typesafe/akka/akka-cluster-tools_2.13/2.6.20/akka-cluster-tools_2.13-2.6.20.jar 1933a6037439b389bda2feaccfc0113880fd8d88f7d240d2052b91108dd5ae89 org/apache/apache/5/apache-5.pom 1955432f6d8af32806d82d8218fedfe4be3bb3e23d59a74d...
bad
review
ACINQ/eclair
a86a2293cd4cf272bdee918956d1bd9299e9873c
diff --git a/.mvn/checksums/checksums-central.sha256 b/.mvn/checksums/checksums-central.sha256 index 2182f6ed6d..302b72a978 100644 --- a/.mvn/checksums/checksums-central.sha256 +++ b/.mvn/checksums/checksums-central.sha256 @@ -128,6 +128,7 @@ 191acabbce3e466008fe4274d09793603eb0083e3b36c692feb958aa8b067821 com/typesa...
good
review_fixed
ACINQ/eclair
a86a2293cd4cf272bdee918956d1bd9299e9873c
@@ -56,6 +63,47 @@ object Monitoring { } } + def recordInteractiveTx(fundingParams: InteractiveTxParams, sharedTx: SharedTransaction, liquidityPurchase_opt: Option[LiquidityAds.Purchase]): Unit = {
bad
review
scala
ACINQ/eclair
306480c9d4363f675b279e4b565b2a4503f13345
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala index d0322f1c6f..23c1aee886 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Mo...
good
review_fixed
scala
ACINQ/eclair
306480c9d4363f675b279e4b565b2a4503f13345
@@ -33,6 +33,10 @@ object Monitoring { val HtlcValueInFlightGlobal = Kamon.gauge("channels.htlc-value-in-flight-global", "Global HTLC value in flight across all channels") val LocalFeeratePerByte = Kamon.histogram("channels.local-feerate-per-byte") val RemoteFeeratePerByte = Kamon.histogram("channels.rem...
bad
review
scala
ACINQ/eclair
0c8bfec956f35c22cf561de16da209986a448cb6
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala index 863de3a8b3..d0322f1c6f 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Mo...
good
review_fixed
scala
ACINQ/eclair
0c8bfec956f35c22cf561de16da209986a448cb6
@@ -33,6 +33,10 @@ object Monitoring { val HtlcValueInFlightGlobal = Kamon.gauge("channels.htlc-value-in-flight-global", "Global HTLC value in flight across all channels") val LocalFeeratePerByte = Kamon.histogram("channels.local-feerate-per-byte") val RemoteFeeratePerByte = Kamon.histogram("channels.rem...
bad
review
scala
ACINQ/eclair
0c8bfec956f35c22cf561de16da209986a448cb6
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala index 863de3a8b3..d0322f1c6f 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Mo...
good
review_fixed
scala
ACINQ/eclair
0c8bfec956f35c22cf561de16da209986a448cb6
@@ -150,8 +150,11 @@ object ChannelTypes { /** Returns our preferred channel type for public channels, if supported by our peer. */ def preferredForPublicChannels(localFeatures: Features[InitFeature], remoteFeatures: Features[InitFeature], announceChannel: Boolean): Option[SupportedChannelType] = { - if (Fea...
bad
review
scala
ACINQ/eclair
68a85a3c66201d8f20a0d1c206026266a7bda433
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala index 311e960198..f1537938f1 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala +++ b/eclair-core/src/main/scala/fr/acinq/ec...
good
review_fixed
scala
ACINQ/eclair
68a85a3c66201d8f20a0d1c206026266a7bda433
@@ -4,6 +4,36 @@ ## Major changes +### Channel Splicing + +With this release, we add support for the final version of [splicing](https://github.com/lightning/bolts/pull/1160) that was recently added to the BOLTs. +Splicing allows node operators to change the size of their existing channels, which makes it easier a...
bad
review
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md index 9ec1a25923..3d19f22128 100644 --- a/docs/release-notes/eclair-vnext.md +++ b/docs/release-notes/eclair-vnext.md @@ -9,6 +9,39 @@ With this release, eclair requires using Bitcoin Core 30.x. Newer versions of Bitcoin Core may be ...
good
review_fixed
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -1033,6 +1074,100 @@ class Channel(val nodeParams: NodeParams, val wallet: OnChainChannelFunder with stay() sending Warning(d.channelId, UnexpectedInteractiveTxMessage(d.channelId, msg).getMessage) } + case Event(msg: TxInitRbf, d: DATA_NORMAL) => + d.spliceStatus match { + case Sp...
bad
review
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala index 7b2586071a..aefb30b00c 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel...
good
review_fixed
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -885,68 +918,73 @@ class Channel(val nodeParams: NodeParams, val wallet: OnChainChannelFunder with stay() case Event(msg: Stfu, d: DATA_NORMAL) => - if (d.commitments.params.useQuiescence) { - if (d.commitments.remoteIsQuiescent) { - d.spliceStatus match { - case SpliceS...
bad
review
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala index 7b2586071a..aefb30b00c 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel...
good
review_fixed
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -885,68 +918,73 @@ class Channel(val nodeParams: NodeParams, val wallet: OnChainChannelFunder with stay() case Event(msg: Stfu, d: DATA_NORMAL) => - if (d.commitments.params.useQuiescence) { - if (d.commitments.remoteIsQuiescent) { - d.spliceStatus match { - case SpliceS...
bad
review
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala index 7b2586071a..aefb30b00c 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel...
good
review_fixed
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -1373,93 +1478,86 @@ class NormalSplicesStateSpec extends TestKitBaseClass with FixtureAnyFunSuiteLik test("re-send splice_locked on reconnection") { f => import f._ - initiateSplice(f, spliceIn_opt = Some(SpliceIn(500_000 sat, pushAmount = 0 msat))) - val fundingTx1 = alice.stateData.asInstanceOf[DA...
bad
review
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala index dfab1676eb..053d3929cc 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.sc...
good
review_fixed
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -1475,145 +1573,132 @@ class NormalSplicesStateSpec extends TestKitBaseClass with FixtureAnyFunSuiteLik } } - def testForceCloseWithMultipleSplicesSimple(f: FixtureParam): Unit = { + test("force-close with multiple splices (simple)") { f => import f._ val htlcs = setupHtlcs(f) - initiate...
bad
review
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala index dfab1676eb..053d3929cc 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.sc...
good
review_fixed
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -118,7 +118,7 @@ class OpenChannelInterceptorSpec extends ScalaTestWithActorTestKit(ConfigFactory test("add liquidity if on-the-fly funding is used", Tag(noPlugin)) { f => import f._ - val features = defaultFeatures.add(Features.SplicePrototype, FeatureSupport.Optional).add(Features.OnTheFlyFunding, Fea...
bad
review
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala index bb050bf95c..b8badd7d45 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala +++ b/eclair-core/src/test...
good
review_fixed
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -210,7 +210,7 @@ class OpenChannelInterceptorSpec extends ScalaTestWithActorTestKit(ConfigFactory test("reject on-the-fly channel if another channel exists", Tag(noPlugin)) { f => import f._ - val features = defaultFeatures.add(Features.SplicePrototype, FeatureSupport.Optional).add(Features.OnTheFlyFund...
bad
review
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala index bb050bf95c..b8badd7d45 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala +++ b/eclair-core/src/test...
good
review_fixed
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -143,14 +144,14 @@ case class TxSignatures(channelId: ByteVector32, txId: TxId, witnesses: Seq[ScriptWitness], tlvStream: TlvStream[TxSignaturesTlv] = TlvStream.empty) extends InteractiveTxMessage with HasChannelId { - val previousFundingTxS...
bad
review
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala b/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala index 0ceb57534e..8f405b55dd 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala +++ b/ec...
good
review_fixed
scala
ACINQ/eclair
318ba314d5bc9824e031d07b772c84920ccfd6ff
@@ -346,7 +350,7 @@ private class PeerScorer(nodeParams: NodeParams, wallet: OnChainBalanceChecker, // We only close channels for which liquidity is idle. .filter(p => p.stats.map(_.totalAmountOut).sum <= p.capacity * 0.05 && p.stats.map(_.totalAmountIn).sum <= p.capacity * 0.05)
bad
review
scala
ACINQ/eclair
509f99468a580d5fcd2c2a3a15376eb3b94a2b13
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala index c0703f8745..cafea52d8c 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerSc...
good
review_fixed
scala
ACINQ/eclair
509f99468a580d5fcd2c2a3a15376eb3b94a2b13
@@ -51,7 +51,7 @@ import scala.util.{Random, Try} /** * Created by PM on 24/05/2016. */ -class Router(val nodeParams: NodeParams, watcher: typed.ActorRef[ZmqWatcher.Command], initialized: Option[Promise[Done]] = None) extends FSMDiagnosticActorLogging[Router.State, Router.Data] { +class Router(val nodeParams: Node...
bad
review
scala
ACINQ/eclair
f5ad2841de695c51d4f31225128e9ab88f75770f
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala b/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala index e7a47b1920..ad1a48d359 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala @@ -2...
good
review_fixed
scala
ACINQ/eclair
f5ad2841de695c51d4f31225128e9ab88f75770f
@@ -88,10 +88,11 @@ class Peer(val nodeParams: NodeParams, channel ! INPUT_RESTORED(state) FinalChannelId(state.channelId) -> channel }.toMap + val isMobileWallet = init.storedChannels.exists(_.channelParams.remoteParams.initFeatures.hasFeature(Features.WakeUpNotificationClient))
bad
review
scala
ACINQ/eclair
b5d77da49490965d74105e0b193f59c20d1c32e6
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala index ccf59b108b..a9ae568090 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala @@ -88,10 +88,12 @@ class Pee...
good
review_fixed
scala
ACINQ/eclair
b5d77da49490965d74105e0b193f59c20d1c32e6
@@ -80,7 +80,11 @@ class ReconnectionTask(nodeParams: NodeParams, remoteNodeId: PublicKey) extends when(IDLE) { case Event(Peer.Transition(previousPeerData, nextPeerData: Peer.DisconnectedData), d: IdleData) => - if (nodeParams.autoReconnect && nextPeerData.channels.nonEmpty) { // we only reconnect if no...
bad
review
scala
ACINQ/eclair
b5d77da49490965d74105e0b193f59c20d1c32e6
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala index c74177b61c..0d14b7f530 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Reco...
good
review_fixed
scala
ACINQ/eclair
b5d77da49490965d74105e0b193f59c20d1c32e6
@@ -88,10 +88,11 @@ class Peer(val nodeParams: NodeParams, channel ! INPUT_RESTORED(state) FinalChannelId(state.channelId) -> channel }.toMap + val autoReconnect = init.storedChannels.isEmpty || init.storedChannels.exists(c => !c.channelParams.remoteParams.initFeatures.hasFeature(Features....
bad
review
scala
ACINQ/eclair
b5d77da49490965d74105e0b193f59c20d1c32e6
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala index ccf59b108b..a9ae568090 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala @@ -88,10 +88,12 @@ class Pee...
good
review_fixed
scala
ACINQ/eclair
b5d77da49490965d74105e0b193f59c20d1c32e6
@@ -553,7 +554,8 @@ class Peer(val nodeParams: NodeParams, } else { d.channels.values.toSet[ActorRef].foreach(_ ! INPUT_DISCONNECTED) // we deduplicate with toSet because there might be two entries per channel (tmp id and final id) val lastRemoteFeatures = LastRemoteFeatures(d.remoteFeatu...
bad
review
scala
ACINQ/eclair
b5d77da49490965d74105e0b193f59c20d1c32e6
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala index ccf59b108b..a9ae568090 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala @@ -88,10 +88,12 @@ class Pee...
good
review_fixed
scala
ACINQ/eclair
b5d77da49490965d74105e0b193f59c20d1c32e6
@@ -671,6 +671,12 @@ eclair { top-peers-count = 10 // A list of node_ids with whom we will try to maintain liquidity. top-peers-whitelist = [] + // On restart, we read all past events from the previous week from the DB, which is expensive. + // We do this in 56 3-hour chunks to avoid performance is...
bad
review
ACINQ/eclair
a04cd46ce61850471fdacf3a539fe9d01c9d289e
diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf index e452e9be2a..7b03f01f65 100644 --- a/eclair-core/src/main/resources/reference.conf +++ b/eclair-core/src/main/resources/reference.conf @@ -671,6 +671,14 @@ eclair { top-peers-count = 10 // A list of...
good
review_fixed
ACINQ/eclair
a04cd46ce61850471fdacf3a539fe9d01c9d289e
@@ -479,7 +479,9 @@ class PeerStatsTrackerSpec extends ScalaTestWithActorTestKit(ConfigFactory.load( } // Add another confirmed transaction, verify the cumulative total. - val now2 = TimestampMilli.now() + // Note that we subtract 1 millisecond, otherwise the test may be flaky if it runs too fast and ...
bad
review
scala
ACINQ/eclair
166d3936fab15ba149ba8eea26aab7657d872b6e
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala index 4d0afda2d6..c2b7a95c9c 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala +++ b/eclair-core/src/test/scala...
good
review_fixed
scala
ACINQ/eclair
166d3936fab15ba149ba8eea26aab7657d872b6e
@@ -103,6 +103,7 @@ eclair.relay.reserved-for-accountable = 0.0 ### API changes - `findroute`, `findroutetonode` and `findroutebetweennodes` now include a `maxCltvExpiryDelta` parameter (#3234) +- `findroute`, `findroutetonode` and `findroutebetweennodes` now include a `fee` field for each hop in their full format ...
bad
review
ACINQ/eclair
302c37ad729aa8e247ac301acfeb01c8e7b0173e
diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md index 03207f23f2..ed697f909c 100644 --- a/docs/release-notes/eclair-vnext.md +++ b/docs/release-notes/eclair-vnext.md @@ -103,6 +103,7 @@ eclair.relay.reserved-for-accountable = 0.0 ### API changes - `findroute`, `findroutetonode` ...
good
review_fixed
ACINQ/eclair
302c37ad729aa8e247ac301acfeb01c8e7b0173e