text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -102,12 +102,15 @@ class TransportHandler(keyPair: KeyPair, rs: Option[ByteVector], connection: Act case Attempt.Successful(DecodeResult(message, _)) => logMessage(message, "IN") Monitoring.Metrics.MessageSize.withTag(Monitoring.Tags.MessageDirection, Monitoring.Tags.MessageDirections.IN).re...
bad
review
scala
ACINQ/eclair
cae0560748f217dc0954db17d8e6329d18274f4a
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala b/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala index 25e9277d91..262246cd81 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala +++ b/eclair-core/src/main/scala/fr/acinq/ec...
good
review_fixed
scala
ACINQ/eclair
cae0560748f217dc0954db17d8e6329d18274f4a
@@ -458,6 +458,19 @@ case class Commitment(fundingTxIndex: Long, } else if (missingForReceiver < 0.msat) { if (params.localParams.isInitiator) { // receiver is not the channel initiator; it is ok if it can't maintain its channel_reserve for now, as long as its balance is increasing, which is the ca...
bad
review
scala
ACINQ/eclair
3201d61e102e96c090f72f59885c72d960941def
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala index 26665bd02b..fc7ee28546 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel...
good
review_fixed
scala
ACINQ/eclair
3201d61e102e96c090f72f59885c72d960941def
@@ -349,15 +349,15 @@ class Channel(val nodeParams: NodeParams, val wallet: OnChainChannelFunder, val // note: spec would allow us to keep sending new htlcs after having received their shutdown (and not sent ours) // but we want to converge as fast as possible and they would probably not route them anyway...
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala index bab02b5eae..9decc58b0d 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -186,28 +184,46 @@ object Helpers { } /** - * The general rule is that we use remote_alias for our channel_update until the channel is publicly announced, and + * The general rule is that we use our local alias for our channel_update until the channel is publicly announced, and
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala index 357f418a62..8cdb82327a 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -186,27 +184,31 @@ object Helpers { } /** - * The general rule is that we use remote_alias for our channel_update until the channel is publicly announced, and - * then we use the real scid. - * - * Private channels are handled like public channels that have not yet been announced, there is no special...
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala index 357f418a62..8cdb82327a 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -186,27 +184,31 @@ object Helpers { } /** - * The general rule is that we use remote_alias for our channel_update until the channel is publicly announced, and - * then we use the real scid. - * - * Private channels are handled like public channels that have not yet been announced, there is no special...
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala index 357f418a62..8cdb82327a 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -262,20 +266,35 @@ class ChannelRelay private(nodeParams: NodeParams, case None => RelayFailure(CMD_FAIL_HTLC(add.id, Right(UnknownNextPeer), commit = true)) case Some(c) if !c.channelUpdate.channelFlags.isEnabled => - RelayFailure(CMD_FAIL_HTLC(add.id, Right(ChannelDisabled(c.channelUp...
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala b/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala index c811d03a84..3ba8c507f4 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala +++ b/eclair-core/src/main/scala/fr...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -262,20 +266,35 @@ class ChannelRelay private(nodeParams: NodeParams, case None => RelayFailure(CMD_FAIL_HTLC(add.id, Right(UnknownNextPeer), commit = true)) case Some(c) if !c.channelUpdate.channelFlags.isEnabled => - RelayFailure(CMD_FAIL_HTLC(add.id, Right(ChannelDisabled(c.channelUp...
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala b/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala index c811d03a84..3ba8c507f4 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala +++ b/eclair-core/src/main/scala/fr...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -118,11 +117,8 @@ object Announcements { def makeChannelUpdate(chainHash: ByteVector32, nodeSecret: PrivateKey, remoteNodeId: PublicKey, shortChannelId: ShortChannelId, cltvExpiryDelta: CltvExpiryDelta, htlcMinimumMsat: MilliSatoshi, feeBaseMsat: MilliSatoshi, feeProportionalMillionths: Long, htlcMaximumMsat: Mil...
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala b/eclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala index da8381840c..5441a3407f 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/rout...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -181,7 +181,7 @@ trait ChannelStateTestsBase extends Assertions with Eventually { // those features can only be enabled with AnchorOutputsZeroFeeHtlcTxs, this is to prevent incompatible test configurations if (tags.contains(ChannelStateTestsTags.ZeroConf)) assert(tags.contains(ChannelStateTestsTags.Ancho...
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala index 48b031fd52..6386271f94 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTes...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -107,33 +123,40 @@ class ZeroConfAliasIntegrationSpec extends FixtureSpec with IntegrationPatience } } + def validateFailure(failure: PaymentFailed): Unit = { + failure.failures.foreach { + case LocalFailure(_, _, t) => assert(t == RouteNotFound || t == RetryExhausted) + case Remo...
bad
review
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/ZeroConfAliasIntegrationSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/ZeroConfAliasIntegrationSpec.scala index 05af0ee034..33bdf0d4c9 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/ZeroConfAl...
good
review_fixed
scala
ACINQ/eclair
8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d
@@ -458,7 +458,7 @@ case class Commitment(fundingTxIndex: Long, } else if (missingForReceiver < 0.msat) { if (params.localParams.isInitiator) { // receiver is not the channel initiator; it is ok if it can't maintain its channel_reserve for now, as long as its balance is increasing, which is the cas...
bad
review
scala
ACINQ/eclair
0139369c0637a1e1064aa101d5147dfcbd42cbb1
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala index 6df8ed5fda..5dedab5146 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel...
good
review_fixed
scala
ACINQ/eclair
0139369c0637a1e1064aa101d5147dfcbd42cbb1
@@ -280,9 +280,18 @@ private[channel] object ChannelCodecs5 { ("txid" | txId) :: ("remotePerCommitmentPoint" | publicKey)).as[RemoteCommit] - private def nextRemoteCommitCodec(commitmentSpecCodec: Codec[CommitmentSpec]): Codec[NextRemoteCommit] = ( - ("sig" | lengthDelimited(commitSigCodec))...
bad
review
scala
ACINQ/eclair
ccf8d17a7c45c15d3e4c025f47ac22f6a5ebbcdd
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/ChannelCodecs5.scala b/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/ChannelCodecs5.scala index 12c28c2f35..657e02d3b6 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5...
good
review_fixed
scala
ACINQ/eclair
ccf8d17a7c45c15d3e4c025f47ac22f6a5ebbcdd
@@ -562,6 +537,153 @@ class BitcoinCoreClientSpec extends TestKitBaseClass with BitcoindService with A }, max = 10 seconds, interval = 1 second) } + test("unlock transaction inputs when double-spent by another wallet transaction") { + assume(!useEclairSigner) + + val sender = TestProbe() + val priv ...
bad
review
scala
ACINQ/eclair
e92291f78d599e2db93c1c44a662135bce2aacdb
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala index 2fd27b9703..f5ad7f3521 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS...
good
review_fixed
scala
ACINQ/eclair
e92291f78d599e2db93c1c44a662135bce2aacdb
@@ -1374,39 +1491,195 @@ class BitcoinCoreClientSpec extends TestKitBaseClass with BitcoindService with A }) generateBlocks(1) - def publishLargeTx(parentTx: Transaction, amount: Satoshi, wallet: BitcoinCoreClient): Transaction = { - val mainInput = TxIn(OutPoint(parentTx, 0), Nil, 0) - val inp...
bad
review
scala
ACINQ/eclair
e92291f78d599e2db93c1c44a662135bce2aacdb
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala index 2fd27b9703..f5ad7f3521 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS...
good
review_fixed
scala
ACINQ/eclair
e92291f78d599e2db93c1c44a662135bce2aacdb
@@ -1374,39 +1491,195 @@ class BitcoinCoreClientSpec extends TestKitBaseClass with BitcoindService with A }) generateBlocks(1) - def publishLargeTx(parentTx: Transaction, amount: Satoshi, wallet: BitcoinCoreClient): Transaction = { - val mainInput = TxIn(OutPoint(parentTx, 0), Nil, 0) - val inp...
bad
review
scala
ACINQ/eclair
e92291f78d599e2db93c1c44a662135bce2aacdb
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala index 2fd27b9703..f5ad7f3521 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS...
good
review_fixed
scala
ACINQ/eclair
e92291f78d599e2db93c1c44a662135bce2aacdb
@@ -1374,39 +1491,195 @@ class BitcoinCoreClientSpec extends TestKitBaseClass with BitcoindService with A }) generateBlocks(1) - def publishLargeTx(parentTx: Transaction, amount: Satoshi, wallet: BitcoinCoreClient): Transaction = { - val mainInput = TxIn(OutPoint(parentTx, 0), Nil, 0) - val inp...
bad
review
scala
ACINQ/eclair
e92291f78d599e2db93c1c44a662135bce2aacdb
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala index 2fd27b9703..f5ad7f3521 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS...
good
review_fixed
scala
ACINQ/eclair
e92291f78d599e2db93c1c44a662135bce2aacdb
@@ -109,7 +109,7 @@ eclair { funding { // Each RBF attempt adds more data that we need to store and process, so we want to limit our peers to a reasonable use of RBF. remote-rbf-limits { - max-attempts = 5 // maximum number of RBF attempts our peer is allowed to make + max-attempts = 10...
bad
review
ACINQ/eclair
70ab54c80d7b27f9d8485d98986e797231c79cbc
diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf index ba318dbedf..e452e9be2a 100644 --- a/eclair-core/src/main/resources/reference.conf +++ b/eclair-core/src/main/resources/reference.conf @@ -109,7 +109,7 @@ eclair { funding { // Each RBF attempt ad...
good
review_fixed
ACINQ/eclair
70ab54c80d7b27f9d8485d98986e797231c79cbc
@@ -1089,9 +1089,11 @@ case class Commitments(channelParams: ChannelParams, case _: CommitSig if active.size > 1 => return Left(CommitSigCountMismatch(channelId, active.size, 1)) case commitSig: CommitSig => Seq(commitSig) } - // Signatures are sent in order (most recent first), calling `zip` will...
bad
review
scala
ACINQ/eclair
70ab54c80d7b27f9d8485d98986e797231c79cbc
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala index 901f45ec85..dd18fca801 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel...
good
review_fixed
scala
ACINQ/eclair
70ab54c80d7b27f9d8485d98986e797231c79cbc
@@ -395,3 +403,13 @@ object ClosingSigTlv { ) } +sealed trait StartBatchTlv extends Tlv + +object StartBatchTlv { + /** Type of [[LightningMessage]] that is included in the batch, when batching a single message type. */ + case class MessageType(tag: Int) extends StartBatchTlv
bad
review
scala
ACINQ/eclair
70ab54c80d7b27f9d8485d98986e797231c79cbc
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala b/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala index ac0f921e50..9aad296841 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala +++ b/eclair-core/src/main/scala/fr/acinq...
good
review_fixed
scala
ACINQ/eclair
70ab54c80d7b27f9d8485d98986e797231c79cbc
@@ -32,7 +32,14 @@ trait ChannelEvent case class ChannelCreated(channel: ActorRef, peer: ActorRef, remoteNodeId: PublicKey, isFunder: Boolean, temporaryChannelId: ByteVector32, initialFeeratePerKw: FeeratePerKw, fundingTxFeeratePerKw: Option[FeeratePerKw]) extends ChannelEvent -case class ChannelRestored(channel: ...
bad
review
scala
ACINQ/eclair
ff0c9b2c869e00d302f9dc84094a17dcc7990817
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala index ba9275e1ee..9999ce323c 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/c...
good
review_fixed
scala
ACINQ/eclair
ff0c9b2c869e00d302f9dc84094a17dcc7990817
@@ -0,0 +1,30 @@ +package fr.acinq.eclair.channel + +import fr.acinq.eclair._ + +import scala.concurrent.duration._ +import akka.actor.{ActorRef, ActorSystem, Props} +import akka.testkit.TestProbe +import fr.acinq.bitcoin.ByteVector32 +import fr.acinq.bitcoin.Crypto.PublicKey +import org.scalatest.funsuite.AnyFunSuite ...
bad
review
scala
ACINQ/eclair
ff0c9b2c869e00d302f9dc84094a17dcc7990817
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala new file mode 100644 index 0000000000..b32ec0d9bd --- /dev/null +++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala @@ -0,0 +1,24 @@ +package...
good
review_fixed
scala
ACINQ/eclair
ff0c9b2c869e00d302f9dc84094a17dcc7990817
@@ -0,0 +1,30 @@ +package fr.acinq.eclair.channel + +import fr.acinq.eclair._ + +import scala.concurrent.duration._ +import akka.actor.{ActorRef, ActorSystem, Props} +import akka.testkit.TestProbe +import fr.acinq.bitcoin.ByteVector32 +import fr.acinq.bitcoin.Crypto.PublicKey +import org.scalatest.funsuite.AnyFunSuite ...
bad
review
scala
ACINQ/eclair
ff0c9b2c869e00d302f9dc84094a17dcc7990817
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala new file mode 100644 index 0000000000..b32ec0d9bd --- /dev/null +++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala @@ -0,0 +1,24 @@ +package...
good
review_fixed
scala
ACINQ/eclair
ff0c9b2c869e00d302f9dc84094a17dcc7990817
@@ -0,0 +1,30 @@ +package fr.acinq.eclair.channel + +import fr.acinq.eclair._ + +import scala.concurrent.duration._ +import akka.actor.{ActorRef, ActorSystem, Props} +import akka.testkit.TestProbe +import fr.acinq.bitcoin.ByteVector32 +import fr.acinq.bitcoin.Crypto.PublicKey +import org.scalatest.funsuite.AnyFunSuite ...
bad
review
scala
ACINQ/eclair
ff0c9b2c869e00d302f9dc84094a17dcc7990817
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala new file mode 100644 index 0000000000..b32ec0d9bd --- /dev/null +++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala @@ -0,0 +1,24 @@ +package...
good
review_fixed
scala
ACINQ/eclair
ff0c9b2c869e00d302f9dc84094a17dcc7990817
@@ -69,15 +70,19 @@ class Register extends Actor with ActorLogging { val compatReplyTo = if (replyTo == ActorRef.noSender) sender() else replyTo channels.get(channelId) match { case Some(channel) => channel.tell(msg, compatReplyTo) - case None => compatReplyTo ! ForwardFailure(fwd) + ...
bad
review
scala
ACINQ/eclair
9ca8551a1d16a2cec2acb1ea46373a3d9266946e
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala index 7622bd13f1..f7d3e6c2cc 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register...
good
review_fixed
scala
ACINQ/eclair
9ca8551a1d16a2cec2acb1ea46373a3d9266946e
@@ -69,15 +70,19 @@ class Register extends Actor with ActorLogging { val compatReplyTo = if (replyTo == ActorRef.noSender) sender() else replyTo channels.get(channelId) match { case Some(channel) => channel.tell(msg, compatReplyTo) - case None => compatReplyTo ! ForwardFailure(fwd) + ...
bad
review
scala
ACINQ/eclair
9ca8551a1d16a2cec2acb1ea46373a3d9266946e
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala index 7622bd13f1..f7d3e6c2cc 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register...
good
review_fixed
scala
ACINQ/eclair
9ca8551a1d16a2cec2acb1ea46373a3d9266946e
@@ -71,6 +72,9 @@ object MinimalNodeFixture extends Assertions { def apply(nodeParams: NodeParams): MinimalNodeFixture = { implicit val system: ActorSystem = ActorSystem(s"system-${nodeParams.alias}") + val readyListener = TestProbe("ready-listener") + system.eventStream.subscribe(readyListener.ref, cla...
bad
review
scala
ACINQ/eclair
9ca8551a1d16a2cec2acb1ea46373a3d9266946e
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala index 491a3ea271..4646f513a2 100644 --- a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/Min...
good
review_fixed
scala
ACINQ/eclair
9ca8551a1d16a2cec2acb1ea46373a3d9266946e
@@ -62,6 +62,7 @@ class Router(val nodeParams: NodeParams, watcher: typed.ActorRef[ZmqWatcher.Comm context.system.eventStream.subscribe(self, classOf[LocalChannelUpdate]) context.system.eventStream.subscribe(self, classOf[LocalChannelDown]) context.system.eventStream.subscribe(self, classOf[AvailableBalanceCha...
bad
review
scala
ACINQ/eclair
9ca8551a1d16a2cec2acb1ea46373a3d9266946e
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala b/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala index 5755151d33..4a7224fc27 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala @@ -6...
good
review_fixed
scala
ACINQ/eclair
9ca8551a1d16a2cec2acb1ea46373a3d9266946e
@@ -518,14 +518,36 @@ object Helpers { Left(InvalidCloseFee(commitments.channelId, remoteClosingFee)) } else { val (closingTx, closingSigned) = makeClosingTx(keyManager, commitments, localScriptPubkey, remoteScriptPubkey, ClosingFees(remoteClosingFee, remoteClosingFee, remoteClosingFee)) - ...
bad
review
scala
ACINQ/eclair
ca2c87f1990bf98a07fa2bc2a3a2cc91db2d9444
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala index 675ebad7fd..afa436caa8 100644 --- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala +++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca...
good
review_fixed
scala
ACINQ/eclair
ca2c87f1990bf98a07fa2bc2a3a2cc91db2d9444
@@ -124,17 +204,68 @@ def commit(self, fnames=None, context=None, message=None, aider_edits=False): else: commit_message = self.get_commit_message(diffs, context) - if aider_edits and self.attribute_commit_message_author: - commit_message = "aider: " + commit_message - e...
bad
review
python
Aider-AI/aider
1d42690824f4208c612210b73b6d002830aa7882
diff --git a/aider/repo.py b/aider/repo.py index 5ece5147ce8..aa2d525f731 100644 --- a/aider/repo.py +++ b/aider/repo.py @@ -1,3 +1,4 @@ +import contextlib import os import time from pathlib import Path, PurePosixPath @@ -34,6 +35,19 @@ ANY_GIT_ERROR = tuple(ANY_GIT_ERROR) +@contextlib.contextmanager +def set_g...
good
review_fixed
python
Aider-AI/aider
1d42690824f4208c612210b73b6d002830aa7882
@@ -152,36 +283,30 @@ def commit(self, fnames=None, context=None, message=None, aider_edits=False): original_user_name = self.repo.git.config("--get", "user.name") original_committer_name_env = os.environ.get("GIT_COMMITTER_NAME") + original_author_name_env = os.environ.get("GIT_AUTHOR_NAME")...
bad
review
python
Aider-AI/aider
1d42690824f4208c612210b73b6d002830aa7882
diff --git a/aider/repo.py b/aider/repo.py index 5ece5147ce8..aa2d525f731 100644 --- a/aider/repo.py +++ b/aider/repo.py @@ -1,3 +1,4 @@ +import contextlib import os import time from pathlib import Path, PurePosixPath @@ -34,6 +35,19 @@ ANY_GIT_ERROR = tuple(ANY_GIT_ERROR) +@contextlib.contextmanager +def set_g...
good
review_fixed
python
Aider-AI/aider
1d42690824f4208c612210b73b6d002830aa7882
@@ -124,17 +204,68 @@ def commit(self, fnames=None, context=None, message=None, aider_edits=False): else: commit_message = self.get_commit_message(diffs, context) - if aider_edits and self.attribute_commit_message_author: - commit_message = "aider: " + commit_message - e...
bad
review
python
Aider-AI/aider
1d42690824f4208c612210b73b6d002830aa7882
diff --git a/aider/repo.py b/aider/repo.py index 5ece5147ce8..aa2d525f731 100644 --- a/aider/repo.py +++ b/aider/repo.py @@ -1,3 +1,4 @@ +import contextlib import os import time from pathlib import Path, PurePosixPath @@ -34,6 +35,19 @@ ANY_GIT_ERROR = tuple(ANY_GIT_ERROR) +@contextlib.contextmanager +def set_g...
good
review_fixed
python
Aider-AI/aider
1d42690824f4208c612210b73b6d002830aa7882
@@ -124,17 +204,68 @@ def commit(self, fnames=None, context=None, message=None, aider_edits=False): else: commit_message = self.get_commit_message(diffs, context) - if aider_edits and self.attribute_commit_message_author: - commit_message = "aider: " + commit_message - e...
bad
review
python
Aider-AI/aider
1d42690824f4208c612210b73b6d002830aa7882
diff --git a/aider/repo.py b/aider/repo.py index 5ece5147ce8..aa2d525f731 100644 --- a/aider/repo.py +++ b/aider/repo.py @@ -1,3 +1,4 @@ +import contextlib import os import time from pathlib import Path, PurePosixPath @@ -34,6 +35,19 @@ ANY_GIT_ERROR = tuple(ANY_GIT_ERROR) +@contextlib.contextmanager +def set_g...
good
review_fixed
python
Aider-AI/aider
1d42690824f4208c612210b73b6d002830aa7882
@@ -0,0 +1,39 @@ +load("//tools:apollo_package.bzl", "apollo_package", "apollo_cc_library", "apollo_component") +load("//tools:cpplint.bzl", "cpplint") + +package(default_visibility = ["//visibility:public"]) + +VANJEE_COPTS = ['-DMODULE_NAME=\\"vanjeelidar\\"'] + +apollo_component( + name = "libvanjeelidar_...
bad
review
ApolloAuto/apollo
0eb4f9f5fe75d444f2260d492e7620bc864a9f87
diff --git a/modules/drivers/lidar/vanjeelidar/BUILD b/modules/drivers/lidar/vanjeelidar/BUILD new file mode 100644 index 00000000000..c8e42a1b551 --- /dev/null +++ b/modules/drivers/lidar/vanjeelidar/BUILD @@ -0,0 +1,38 @@ +load("//tools:apollo_package.bzl", "apollo_package", "apollo_cc_library", "apollo_component") ...
good
review_fixed
ApolloAuto/apollo
0eb4f9f5fe75d444f2260d492e7620bc864a9f87
@@ -0,0 +1,183 @@ +/****************************************************************************** + * Copyright 2024 The Apollo Authors. All Rights Reserved. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a...
bad
review
cpp
ApolloAuto/apollo
0eb4f9f5fe75d444f2260d492e7620bc864a9f87
diff --git a/modules/drivers/lidar/vanjeelidar/src/vanjeelidar_component.cpp b/modules/drivers/lidar/vanjeelidar/src/vanjeelidar_component.cpp new file mode 100644 index 00000000000..dfce9b34f8f --- /dev/null +++ b/modules/drivers/lidar/vanjeelidar/src/vanjeelidar_component.cpp @@ -0,0 +1,182 @@ +/*********************...
good
review_fixed
cpp
ApolloAuto/apollo
0eb4f9f5fe75d444f2260d492e7620bc864a9f87
@@ -272,9 +272,9 @@ def perception_publisher(perception_channel, files, period): node = cyber.Node("perception") writer = node.create_writer(perception_channel, PerceptionObstacles) perception_description = load_descrptions(files) - sleep_time = int(1.0 / period) # 10Hz + sleep_time = float(1.0 / ...
bad
review
python
ApolloAuto/apollo
f553badf637d049f3cc8940ae7bdfce7de509f64
diff --git a/modules/tools/perception/replay_perception.py b/modules/tools/perception/replay_perception.py index 3b1578b6a37..5fe167cde47 100644 --- a/modules/tools/perception/replay_perception.py +++ b/modules/tools/perception/replay_perception.py @@ -231,7 +231,7 @@ def linear_project_perception(description, prev_per...
good
review_fixed
python
ApolloAuto/apollo
f553badf637d049f3cc8940ae7bdfce7de509f64
@@ -231,7 +231,7 @@ def linear_project_perception(description, prev_perception): get_point(trace[i - 1], trace[i], ratio)) perception.theta = math.atan2(trace[i][1] - trace[i - 1][1], trace[i][0] - trace[i - 1][0]) - + perception.veloci...
bad
review
python
ApolloAuto/apollo
f553badf637d049f3cc8940ae7bdfce7de509f64
diff --git a/modules/tools/perception/replay_perception.py b/modules/tools/perception/replay_perception.py index 3b1578b6a37..5fe167cde47 100644 --- a/modules/tools/perception/replay_perception.py +++ b/modules/tools/perception/replay_perception.py @@ -231,7 +231,7 @@ def linear_project_perception(description, prev_per...
good
review_fixed
python
ApolloAuto/apollo
f553badf637d049f3cc8940ae7bdfce7de509f64
@@ -23,7 +23,7 @@ <PackageVersion Include="MinVer" Version="7.0.0" /> <PackageVersion Include="Newtonsoft.Json" Version="13.0.4" /> <PackageVersion Include="NSubstitute" Version="5.3.0" /> - <PackageVersion Include="Polly" Version="8.6.6" /> + <PackageVersion Include="Polly" Version="8.7.0" />
bad
review
App-vNext/Polly
bc1e84cf7d45797afc98cc0f2b357c3c6b9675db
diff --git a/Directory.Packages.props b/Directory.Packages.props index edd89424761..3733a887556 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -23,12 +23,12 @@ <PackageVersion Include="MinVer" Version="7.0.0" /> <PackageVersion Include="Newtonsoft.Json" Version="13.0.4" /> <Packa...
good
review_fixed
App-vNext/Polly
bc1e84cf7d45797afc98cc0f2b357c3c6b9675db
@@ -0,0 +1,31 @@ +namespace Polly.Utils; + +internal static class OutcomeUtilities +{ + /// <summary> + /// Ensures that an <see cref="OperationCanceledException"/> escaping a strategy that substituted the + /// execution <see cref="CancellationToken"/> (e.g. timeout or hedging) carries the caller's token when...
bad
review
csharp
App-vNext/Polly
b36796061a77b6ba489d883b04c4c266dbe136f8
diff --git a/src/Polly.Core/Utils/OutcomeUtilities.cs b/src/Polly.Core/Utils/OutcomeUtilities.cs new file mode 100644 index 00000000000..4d7ef63d7e8 --- /dev/null +++ b/src/Polly.Core/Utils/OutcomeUtilities.cs @@ -0,0 +1,32 @@ +namespace Polly.Utils; + +internal static class OutcomeUtilities +{ + /// <summary> + ...
good
review_fixed
csharp
App-vNext/Polly
b36796061a77b6ba489d883b04c4c266dbe136f8
@@ -0,0 +1,197 @@ +using Polly.Hedging; +using Polly.Timeout; + +namespace Polly.Core.Tests.Issues; + +public partial class IssuesTests +{ + // https://github.com/App-vNext/Polly/issues/3086 + // When a strategy substitutes the caller's CancellationToken with an internal one (timeout, hedging), + // a caller-i...
bad
review
csharp
App-vNext/Polly
b36796061a77b6ba489d883b04c4c266dbe136f8
diff --git a/test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs b/test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs new file mode 100644 index 00000000000..991bffa22dc --- /dev/null +++ b/test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs...
good
review_fixed
csharp
App-vNext/Polly
b36796061a77b6ba489d883b04c4c266dbe136f8
@@ -1,6 +1,6 @@ { "sdk": { - "version": "10.0.300", + "version": "10.0.301", "allowPrerelease": false, "rollForward": "latestMinor"
bad
review
App-vNext/Polly
678296530c9e96093e4c89b5095b879f4cc1371b
diff --git a/global.json b/global.json index 53f0e477991..6b5ad33c94e 100644 --- a/global.json +++ b/global.json @@ -1,8 +1,7 @@ { "sdk": { - "version": "10.0.300", - "allowPrerelease": false, - "rollForward": "latestMinor" + "version": "10.0.301", + "allowPrerelease": false }, "msbuild-sdks": ...
good
review_fixed
App-vNext/Polly
678296530c9e96093e4c89b5095b879f4cc1371b
@@ -0,0 +1,50 @@ +using System.Diagnostics.Metrics; + +namespace Polly.Telemetry; + +internal sealed class TelemetrySource +{ + internal const string Name = "Polly"; + + public static readonly TelemetrySource Instance = new(); + + private TelemetrySource() + { + var version = GetVersion(); + ...
bad
review
csharp
App-vNext/Polly
517ce137d8b7f023fc928bebd81d85c10db86035
diff --git a/src/Polly.Extensions/Telemetry/TelemetrySource.cs b/src/Polly.Extensions/Telemetry/TelemetrySource.cs new file mode 100644 index 00000000000..6e95d62919f --- /dev/null +++ b/src/Polly.Extensions/Telemetry/TelemetrySource.cs @@ -0,0 +1,50 @@ +using System.Diagnostics.Metrics; + +namespace Polly.Telemetry; ...
good
review_fixed
csharp
App-vNext/Polly
517ce137d8b7f023fc928bebd81d85c10db86035
@@ -0,0 +1,50 @@ +using System.Diagnostics.Metrics; + +namespace Polly.Telemetry; + +internal sealed class TelemetrySource +{ + internal const string Name = "Polly"; + + public static readonly TelemetrySource Instance = new(); + + private TelemetrySource() + { + var version = GetVersion(); + ...
bad
review
csharp
App-vNext/Polly
517ce137d8b7f023fc928bebd81d85c10db86035
diff --git a/src/Polly.Extensions/Telemetry/TelemetrySource.cs b/src/Polly.Extensions/Telemetry/TelemetrySource.cs new file mode 100644 index 00000000000..6e95d62919f --- /dev/null +++ b/src/Polly.Extensions/Telemetry/TelemetrySource.cs @@ -0,0 +1,50 @@ +using System.Diagnostics.Metrics; + +namespace Polly.Telemetry; ...
good
review_fixed
csharp
App-vNext/Polly
517ce137d8b7f023fc928bebd81d85c10db86035
@@ -0,0 +1,19 @@ +using Polly.Telemetry; + +namespace Polly.Extensions.Tests.Telemetry; + +public static class TelemetrySourceTests +{ + [Fact] + public static void TelemetrySource_CreatesActivitySourceAndMeter()
bad
review
csharp
App-vNext/Polly
517ce137d8b7f023fc928bebd81d85c10db86035
diff --git a/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs b/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs new file mode 100644 index 00000000000..529096d21b5 --- /dev/null +++ b/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs @@ -0,0 +1,22 @@ +using Polly.Telemetry; + +na...
good
review_fixed
csharp
App-vNext/Polly
517ce137d8b7f023fc928bebd81d85c10db86035
@@ -0,0 +1,19 @@ +using Polly.Telemetry; + +namespace Polly.Extensions.Tests.Telemetry; + +public static class TelemetrySourceTests +{ + [Fact] + public static void TelemetrySource_CreatesActivitySourceAndMeter()
bad
review
csharp
App-vNext/Polly
517ce137d8b7f023fc928bebd81d85c10db86035
diff --git a/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs b/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs new file mode 100644 index 00000000000..529096d21b5 --- /dev/null +++ b/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs @@ -0,0 +1,22 @@ +using Polly.Telemetry; + +na...
good
review_fixed
csharp
App-vNext/Polly
517ce137d8b7f023fc928bebd81d85c10db86035
@@ -22,8 +22,8 @@ permissions: {} jobs: build: - name: ${{ matrix.os }} - runs-on: ${{ matrix.os }} + name: ${{ matrix.job-name }}
bad
review
App-vNext/Polly
0bde17cd4de2e9e5d4e8a909d88394d916df0876
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 00afbc7a721..f0849c4038d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,8 +22,8 @@ permissions: {} jobs: build: - name: ${{ matrix.os }} - runs-on: ${{ matrix.os }} + name: ${{ matrix.job-name ...
good
review_fixed
App-vNext/Polly
0bde17cd4de2e9e5d4e8a909d88394d916df0876
@@ -96,35 +98,35 @@ jobs: if: always() uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: - name: coverage-${{ matrix.os_name }} + name: coverage-${{ matrix.os-name }} path: ./artifacts/coverage-reports if-no-files-found: ignore
bad
review
App-vNext/Polly
0bde17cd4de2e9e5d4e8a909d88394d916df0876
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 00afbc7a721..f0849c4038d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,8 +22,8 @@ permissions: {} jobs: build: - name: ${{ matrix.os }} - runs-on: ${{ matrix.os }} + name: ${{ matrix.job-name ...
good
review_fixed
App-vNext/Polly
0bde17cd4de2e9e5d4e8a909d88394d916df0876
@@ -96,35 +98,35 @@ jobs: if: always() uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: - name: coverage-${{ matrix.os_name }} + name: coverage-${{ matrix.os-name }} path: ./artifacts/coverage-reports if-no-files-found: ignore ...
bad
review
App-vNext/Polly
0bde17cd4de2e9e5d4e8a909d88394d916df0876
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 00afbc7a721..f0849c4038d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,8 +22,8 @@ permissions: {} jobs: build: - name: ${{ matrix.os }} - runs-on: ${{ matrix.os }} + name: ${{ matrix.job-name ...
good
review_fixed
App-vNext/Polly
0bde17cd4de2e9e5d4e8a909d88394d916df0876
@@ -96,35 +98,35 @@ jobs: if: always() uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 with: - name: coverage-${{ matrix.os_name }} + name: coverage-${{ matrix.os-name }} path: ./artifacts/coverage-reports if-no-files-found: ignore ...
bad
review
App-vNext/Polly
0bde17cd4de2e9e5d4e8a909d88394d916df0876
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 00afbc7a721..f0849c4038d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,8 +22,8 @@ permissions: {} jobs: build: - name: ${{ matrix.os }} - runs-on: ${{ matrix.os }} + name: ${{ matrix.job-name ...
good
review_fixed
App-vNext/Polly
0bde17cd4de2e9e5d4e8a909d88394d916df0876
@@ -83,7 +83,7 @@ async void WatchNameAsync(string name) { await Task.Delay(Timeout.Infinite, linked.Token); } - catch (OperationCanceledException) when (!cancellationToken.IsCancellationRequested) + ...
bad
review
csharp
AvaloniaUI/Avalonia
3eccdf621339a4ce863d589b8b6ef7550c8b6730
diff --git a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs index cfd28b29aa8..236276f8058 100644 --- a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs +++ b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs @@ -64,9 +64,9 ...
good
review_fixed
csharp
AvaloniaUI/Avalonia
3eccdf621339a4ce863d589b8b6ef7550c8b6730