text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -814,10 +811,11 @@ Supported fuel-core version: ${supportedVersion}.` * * @returns the base asset ID. */ - getBaseAssetId() { + async getBaseAssetId() {
bad
review
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/packages/account/src/providers/provider.ts b/packages/account/src/providers/provider.ts index 5f9ffe88f42..201c4dad7bf 100644 --- a/packages/account/src/providers/provider.ts +++ b/packages/account/src/providers/provider.ts @@ -465,7 +465,7 @@ export default class Provider { * @param options - Addition...
good
review_fixed
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -824,7 +833,10 @@ describe('TransactionSummary', () => { fromType: AddressType.account, toType: AddressType.contract, recipients: [ - { address: contract.id, quantities: [{ amount, assetId: provider.getBaseAssetId() }] }, + { + address: contract.id, + ...
bad
review
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/packages/fuel-gauge/src/transaction-summary.test.ts b/packages/fuel-gauge/src/transaction-summary.test.ts index b230bdd69da..06edf5d69eb 100644 --- a/packages/fuel-gauge/src/transaction-summary.test.ts +++ b/packages/fuel-gauge/src/transaction-summary.test.ts @@ -94,7 +94,7 @@ describe('TransactionSummary'...
good
review_fixed
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -856,7 +868,7 @@ describe('TransactionSummary', () => { expect(operations[0].to?.chain).toEqual(ChainName.ethereum); expect(operations[0].assetsSent).toHaveLength(1); expect(operations[0].assetsSent?.[0].amount).toEqual(bn(amountToWithdraw)); - expect(operations[0].assetsSent?.[0].assetId)....
bad
review
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/packages/fuel-gauge/src/transaction-summary.test.ts b/packages/fuel-gauge/src/transaction-summary.test.ts index b230bdd69da..06edf5d69eb 100644 --- a/packages/fuel-gauge/src/transaction-summary.test.ts +++ b/packages/fuel-gauge/src/transaction-summary.test.ts @@ -94,7 +94,7 @@ describe('TransactionSummary'...
good
review_fixed
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -6,16 +6,16 @@ import { WALLET_PVT_KEY_2, } from '../../../env'; -const provider = await Provider.create(LOCAL_NETWORK_URL); +const provider = new Provider(LOCAL_NETWORK_URL); const sender = Wallet.fromPrivateKey(WALLET_PVT_KEY, provider); -const assetId = provider.getBaseAssetId(); +const assetId = await pro...
bad
review
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/apps/docs/src/guide/transactions/snippets/transaction.ts b/apps/docs/src/guide/transactions/snippets/transaction.ts index 312dcd9ccc1..1a429f759c0 100644 --- a/apps/docs/src/guide/transactions/snippets/transaction.ts +++ b/apps/docs/src/guide/transactions/snippets/transaction.ts @@ -6,16 +6,16 @@ import { ...
good
review_fixed
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -437,7 +440,7 @@ export class Account extends AbstractAccount { async transferToContract( contractId: string | AbstractAddress, amount: BigNumberish, - assetId?: BytesLike, + assetId: BytesLike,
bad
review
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/packages/account/src/account.ts b/packages/account/src/account.ts index 60484577999..546c5c00c3a 100644 --- a/packages/account/src/account.ts +++ b/packages/account/src/account.ts @@ -56,13 +56,13 @@ export type TxParamsType = Pick< export type TransferParams = { destination: string | AbstractAddress; ...
good
review_fixed
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -318,11 +309,11 @@ export class BaseInvocationScope<TReturn = any> { */ addTransfer(transferParams: TransferParams) { const { amount, destination, assetId } = transferParams; - const baseAssetId = this.getProvider().getBaseAssetId(); + // const baseAssetId = await this.getProvider().getBaseAssetId(...
bad
review
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/packages/program/src/functions/base-invocation-scope.ts b/packages/program/src/functions/base-invocation-scope.ts index 7312fdaec0c..a4f75a0598b 100644 --- a/packages/program/src/functions/base-invocation-scope.ts +++ b/packages/program/src/functions/base-invocation-scope.ts @@ -87,28 +87,19 @@ export clas...
good
review_fixed
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -0,0 +1,10 @@ +--- +"@fuel-ts/contract": patch +"@fuel-ts/account": patch +"@fuel-ts/program": patch +"@fuel-ts/recipes": patch +"@fuel-ts/script": patch +"fuels": patch
bad
review
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/.changeset/old-laws-film.md b/.changeset/old-laws-film.md new file mode 100644 index 00000000000..e53b47c828f --- /dev/null +++ b/.changeset/old-laws-film.md @@ -0,0 +1,11 @@ +--- +"@fuel-ts/contract": minor +"@fuel-ts/account": minor +"@fuel-ts/program": minor +"@fuel-ts/recipes": minor +"@fuel-ts/script"...
good
review_fixed
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -1131,22 +1132,22 @@ describe('Provider', () => { using launched = await setupTestProviderAndWallets(); const { provider } = launched; - const gasConfig = provider.getGasConfig(); + const gasConfig = await provider.getGasConfig(); expect(gasConfig.gasPerByte).toBeDefined(); expect(gasCo...
bad
review
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/packages/account/src/providers/provider.test.ts b/packages/account/src/providers/provider.test.ts index d9775e3252d..cf20f316843 100644 --- a/packages/account/src/providers/provider.test.ts +++ b/packages/account/src/providers/provider.test.ts @@ -91,7 +91,7 @@ describe('Provider', () => { } = launche...
good
review_fixed
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -611,40 +605,36 @@ export default class Provider { * @returns A promise that resolves to the Chain and NodeInfo. */ async fetchChainAndNodeInfo(ignoreCache: boolean = false) { - let nodeInfo: NodeInfo; - let chain: ChainInfo; + let nodeInfo = Provider.nodeInfoCache[this.urlWithoutAuth]; + let ...
bad
review
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/packages/account/src/providers/provider.ts b/packages/account/src/providers/provider.ts index 5f9ffe88f42..201c4dad7bf 100644 --- a/packages/account/src/providers/provider.ts +++ b/packages/account/src/providers/provider.ts @@ -465,7 +465,7 @@ export default class Provider { * @param options - Addition...
good
review_fixed
typescript
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -0,0 +1,11 @@ +--- +"@fuel-ts/contract": minor +"@fuel-ts/account": minor +"@fuel-ts/program": minor +"@fuel-ts/recipes": minor +"@fuel-ts/script": minor +"fuels": minor +"create-fuels": minor +--- + +feat!: make `provider` initialization `sync` again
bad
review
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
diff --git a/.changeset/old-laws-film.md b/.changeset/old-laws-film.md new file mode 100644 index 00000000000..e53b47c828f --- /dev/null +++ b/.changeset/old-laws-film.md @@ -0,0 +1,11 @@ +--- +"@fuel-ts/contract": minor +"@fuel-ts/account": minor +"@fuel-ts/program": minor +"@fuel-ts/recipes": minor +"@fuel-ts/script"...
good
review_fixed
FuelLabs/fuels-ts
5632de76624dbdfeaf1ffb446c8907775b60a7be
@@ -84,7 +87,6 @@ jobs: githubTagName: ${{ env.RELEASE_VERSION }} env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - NODE_AUTH_TOKEN: ${{ secrets.NPM_DEPLOY_TOKEN }}
bad
review
FuelLabs/fuels-ts
f0192e9b3cb9353199d50aab4a91800c293792e4
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index edc919df02c..e41e1150a26 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -13,6 +13,11 @@ env: VERCEL_TS_DOCS_PROJECT_ID: "prj_iBhTlkv2hj2E6BiA3GeacxgNHIEL" VERCEL_TS_DOCS_API_PROJECT_ID: "prj_hBy...
good
review_fixed
FuelLabs/fuels-ts
f0192e9b3cb9353199d50aab4a91800c293792e4
@@ -222,5 +222,9 @@ export const extractTxError = (params: IExtractTxError): FuelError => { if (isPanic) { return assemblePanicError(statusReason, metadata); } - return assembleRevertError(receipts, logs, metadata, statusReason, abis); + const decodedLogs = logs.filter((l: unknown) => { + const log = l ...
bad
review
typescript
FuelLabs/fuels-ts
90df0341067aa7bb5be95127d4bacd870b7c8aa2
diff --git a/packages/account/src/providers/utils/extract-tx-error.ts b/packages/account/src/providers/utils/extract-tx-error.ts index a6cb5723e63..f62565b8fb4 100644 --- a/packages/account/src/providers/utils/extract-tx-error.ts +++ b/packages/account/src/providers/utils/extract-tx-error.ts @@ -222,5 +222,14 @@ export...
good
review_fixed
typescript
FuelLabs/fuels-ts
90df0341067aa7bb5be95127d4bacd870b7c8aa2
@@ -61,6 +68,16 @@ function validateDuplicatedPolicies(policies: Policy[]): void { }); } +export function getPolicyTypesArray(policyTypes: number): number[] { + const out: number[] = []; + let m = policyTypes >>> 0;
bad
review
typescript
FuelLabs/fuels-ts
d5858310d16ecb44bf21c19d8e69c9c30ac47e77
diff --git a/packages/transactions/src/coders/policy.ts b/packages/transactions/src/coders/policy.ts index 1dcac8c7cf8..384a1569329 100644 --- a/packages/transactions/src/coders/policy.ts +++ b/packages/transactions/src/coders/policy.ts @@ -1,4 +1,4 @@ -import { BigNumberCoder, Coder, NumberCoder } from '@fuel-ts/abi-c...
good
review_fixed
typescript
FuelLabs/fuels-ts
d5858310d16ecb44bf21c19d8e69c9c30ac47e77
@@ -0,0 +1,27 @@ +--- +"@internal/check-imports": minor +"@internal/check-tests": minor +"@internal/forc": minor +"@internal/fuel-core": minor +"@fuel-ts/abi-coder": minor +"@fuel-ts/abi-typegen": minor +"@fuel-ts/account": minor +"@fuel-ts/address": minor +"@fuel-ts/contract": minor +"create-fuels": minor +"@fuel-ts/c...
bad
review
FuelLabs/fuels-ts
6f894bc1ff5e7e59f71929b42835728d8adf649a
diff --git a/.changeset/hungry-clouds-switch.md b/.changeset/hungry-clouds-switch.md new file mode 100644 index 00000000000..ca09a37d275 --- /dev/null +++ b/.changeset/hungry-clouds-switch.md @@ -0,0 +1,5 @@ +--- +"@internal/fuel-core": minor +--- + +chore!: breaking change for `fuel-core@v0.44.0`
good
review_fixed
FuelLabs/fuels-ts
6f894bc1ff5e7e59f71929b42835728d8adf649a
@@ -0,0 +1,8 @@ +--- +"@internal/fuel-core": minor +"@fuel-ts/versions": minor +"@fuel-ts/account": minor +"@fuel-ts/errors": minor +--- + +chore!: upgrade `fuel-core` to `0.44.0`
bad
review
FuelLabs/fuels-ts
45430b237788817c8169a88c9d2557479173a835
diff --git a/.changeset/full-carpets-lose.md b/.changeset/full-carpets-lose.md new file mode 100644 index 00000000000..90b55d28e1d --- /dev/null +++ b/.changeset/full-carpets-lose.md @@ -0,0 +1,11 @@ +--- +"@internal/fuel-core": patch +"@fuel-ts/account": patch +"@fuel-ts/contract": patch +"fuels": patch +"@fuel-ts/pro...
good
review_fixed
FuelLabs/fuels-ts
45430b237788817c8169a88c9d2557479173a835
@@ -0,0 +1,8 @@ +--- +"@internal/fuel-core": minor +"@fuel-ts/versions": minor +"@fuel-ts/account": minor +"@fuel-ts/errors": minor +---
bad
review
FuelLabs/fuels-ts
45430b237788817c8169a88c9d2557479173a835
diff --git a/.changeset/full-carpets-lose.md b/.changeset/full-carpets-lose.md new file mode 100644 index 00000000000..90b55d28e1d --- /dev/null +++ b/.changeset/full-carpets-lose.md @@ -0,0 +1,11 @@ +--- +"@internal/fuel-core": patch +"@fuel-ts/account": patch +"@fuel-ts/contract": patch +"fuels": patch +"@fuel-ts/pro...
good
review_fixed
FuelLabs/fuels-ts
45430b237788817c8169a88c9d2557479173a835
@@ -0,0 +1,11 @@ +--- +"@internal/fuel-core": patch +"@fuel-ts/account": patch +"@fuel-ts/contract": patch +"fuels": patch +"@fuel-ts/programs": patch
bad
review
FuelLabs/fuels-ts
45430b237788817c8169a88c9d2557479173a835
diff --git a/.changeset/full-carpets-lose.md b/.changeset/full-carpets-lose.md new file mode 100644 index 00000000000..90b55d28e1d --- /dev/null +++ b/.changeset/full-carpets-lose.md @@ -0,0 +1,11 @@ +--- +"@internal/fuel-core": patch +"@fuel-ts/account": patch +"@fuel-ts/contract": patch +"fuels": patch +"@fuel-ts/pro...
good
review_fixed
FuelLabs/fuels-ts
45430b237788817c8169a88c9d2557479173a835
@@ -85,6 +85,7 @@ interface GasCosts { mul: number; muli: number; mldv: number; + niop: number | undefined;
bad
review
typescript
FuelLabs/fuels-ts
45430b237788817c8169a88c9d2557479173a835
diff --git a/packages/utils/src/utils/types.ts b/packages/utils/src/utils/types.ts index 662649b8dd8..66341f8d74b 100644 --- a/packages/utils/src/utils/types.ts +++ b/packages/utils/src/utils/types.ts @@ -85,6 +85,7 @@ interface GasCosts { mul: number; muli: number; mldv: number; + niop: number | undefined; ...
good
review_fixed
typescript
FuelLabs/fuels-ts
45430b237788817c8169a88c9d2557479173a835
@@ -191,13 +212,30 @@ export class Account extends AbstractAccount implements WithAddress { * * @param quantities - Quantities of resources to be obtained. * @param resourcesIdsToIgnore - IDs of resources to be excluded from the query (optional). + * @param shouldAutoConsolidate - Whether to automatically...
bad
review
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
diff --git a/packages/account/src/account.ts b/packages/account/src/account.ts index f9789247b8a..7575c7bc00c 100644 --- a/packages/account/src/account.ts +++ b/packages/account/src/account.ts @@ -55,6 +55,11 @@ import { import { mergeQuantities } from './providers/utils/merge-quantities'; import { serializeProviderC...
good
review_fixed
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
@@ -432,15 +480,19 @@ export class Account extends AbstractAccount implements WithAddress { * @param amount - The amount of coins to transfer. * @param assetId - The asset ID of the coins to transfer (optional). * @param txParams - The transaction parameters (optional). + * @param shouldAutoConsolidate - ...
bad
review
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
diff --git a/packages/account/src/account.ts b/packages/account/src/account.ts index f9789247b8a..7575c7bc00c 100644 --- a/packages/account/src/account.ts +++ b/packages/account/src/account.ts @@ -55,6 +55,11 @@ import { import { mergeQuantities } from './providers/utils/merge-quantities'; import { serializeProviderC...
good
review_fixed
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
@@ -1153,59 +1265,6 @@ export class Account extends AbstractAccount implements WithAddress { } } - /** @hidden * */ - private async estimateAndFundTransaction( - transactionRequest: ScriptTransactionRequest, - txParams: TxParamsType, - costParams?: TransactionCostParams - ) { - let request = tr...
bad
review
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
diff --git a/packages/account/src/account.ts b/packages/account/src/account.ts index f9789247b8a..7575c7bc00c 100644 --- a/packages/account/src/account.ts +++ b/packages/account/src/account.ts @@ -55,6 +55,11 @@ import { import { mergeQuantities } from './providers/utils/merge-quantities'; import { serializeProviderC...
good
review_fixed
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
@@ -0,0 +1,241 @@ +import { Address } from '@fuel-ts/address'; +import { ErrorCode, FuelError } from '@fuel-ts/errors'; +import { bn } from '@fuel-ts/math'; +import { OutputType } from '@fuel-ts/transactions'; +import type { TransactionType, OutputChange, Output } from '@fuel-ts/transactions'; +import { splitEvery } fr...
bad
review
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
diff --git a/packages/account/src/utils/consolidate-coins.ts b/packages/account/src/utils/consolidate-coins.ts new file mode 100644 index 00000000000..e9fb6a1e3a0 --- /dev/null +++ b/packages/account/src/utils/consolidate-coins.ts @@ -0,0 +1,238 @@ +import { Address } from '@fuel-ts/address'; +import { ErrorCode, FuelE...
good
review_fixed
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
@@ -0,0 +1,241 @@ +import { Address } from '@fuel-ts/address'; +import { ErrorCode, FuelError } from '@fuel-ts/errors'; +import { bn } from '@fuel-ts/math'; +import { OutputType } from '@fuel-ts/transactions'; +import type { TransactionType, OutputChange, Output } from '@fuel-ts/transactions'; +import { splitEvery } fr...
bad
review
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
diff --git a/packages/account/src/utils/consolidate-coins.ts b/packages/account/src/utils/consolidate-coins.ts new file mode 100644 index 00000000000..e9fb6a1e3a0 --- /dev/null +++ b/packages/account/src/utils/consolidate-coins.ts @@ -0,0 +1,238 @@ +import { Address } from '@fuel-ts/address'; +import { ErrorCode, FuelE...
good
review_fixed
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
@@ -0,0 +1,241 @@ +import { Address } from '@fuel-ts/address'; +import { ErrorCode, FuelError } from '@fuel-ts/errors'; +import { bn } from '@fuel-ts/math'; +import { OutputType } from '@fuel-ts/transactions'; +import type { TransactionType, OutputChange, Output } from '@fuel-ts/transactions'; +import { splitEvery } fr...
bad
review
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
diff --git a/packages/account/src/utils/consolidate-coins.ts b/packages/account/src/utils/consolidate-coins.ts new file mode 100644 index 00000000000..e9fb6a1e3a0 --- /dev/null +++ b/packages/account/src/utils/consolidate-coins.ts @@ -0,0 +1,238 @@ +import { Address } from '@fuel-ts/address'; +import { ErrorCode, FuelE...
good
review_fixed
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
@@ -0,0 +1,7 @@ +--- +"@fuel-ts/account": patch +"@fuel-ts/program": patch
bad
review
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
diff --git a/.changeset/spicy-waves-throw.md b/.changeset/spicy-waves-throw.md new file mode 100644 index 00000000000..bcfc09c6db9 --- /dev/null +++ b/.changeset/spicy-waves-throw.md @@ -0,0 +1,8 @@ +--- +"@fuel-ts/account": patch +"@fuel-ts/contract": patch +"@fuel-ts/program": patch +"@fuel-ts/errors": patch +--- + +...
good
review_fixed
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
@@ -290,31 +294,48 @@ export class BaseInvocationScope<TReturn = any> { } } - // eslint-disable-next-line prefer-const - let { assembledRequest, gasPrice } = await provider.assembleTx({ - request, - feePayerAccount, - accountCoinQuantities, - ...restAssembleTxParams, - }); + ...
bad
review
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
diff --git a/packages/program/src/functions/base-invocation-scope.ts b/packages/program/src/functions/base-invocation-scope.ts index 731afdbdc72..40f709ac384 100644 --- a/packages/program/src/functions/base-invocation-scope.ts +++ b/packages/program/src/functions/base-invocation-scope.ts @@ -11,8 +11,10 @@ import type ...
good
review_fixed
typescript
FuelLabs/fuels-ts
15fc369f5557285739d4e39443973ccdc88b774f
@@ -449,4 +439,316 @@ describe('consolidate-coins', () => { ); }); }); + + describe('Non-base asset', () => { + it('should consolidate base asset just fine [ACCOUNT HAS LESS THAN MAX INPUTS]', async () => { + const maxInputs = 255; + const totalCoins = maxInputs - 1; // Expected to be 1 con...
bad
review
typescript
FuelLabs/fuels-ts
30753767b129ec5ff9fb95425a4112e22185332a
diff --git a/packages/account/src/consolidate-coins.test.ts b/packages/account/src/consolidate-coins.test.ts index c90a181de4f..b7386bd394e 100644 --- a/packages/account/src/consolidate-coins.test.ts +++ b/packages/account/src/consolidate-coins.test.ts @@ -138,166 +138,156 @@ describe('consolidate-coins', () => { ...
good
review_fixed
typescript
FuelLabs/fuels-ts
30753767b129ec5ff9fb95425a4112e22185332a
@@ -449,4 +439,316 @@ describe('consolidate-coins', () => { ); }); }); + + describe('Non-base asset', () => { + it('should consolidate base asset just fine [ACCOUNT HAS LESS THAN MAX INPUTS]', async () => { + const maxInputs = 255; + const totalCoins = maxInputs - 1; // Expected to be 1 con...
bad
review
typescript
FuelLabs/fuels-ts
30753767b129ec5ff9fb95425a4112e22185332a
diff --git a/packages/account/src/consolidate-coins.test.ts b/packages/account/src/consolidate-coins.test.ts index c90a181de4f..b7386bd394e 100644 --- a/packages/account/src/consolidate-coins.test.ts +++ b/packages/account/src/consolidate-coins.test.ts @@ -138,166 +138,156 @@ describe('consolidate-coins', () => { ...
good
review_fixed
typescript
FuelLabs/fuels-ts
30753767b129ec5ff9fb95425a4112e22185332a
@@ -449,4 +439,316 @@ describe('consolidate-coins', () => { ); }); }); + + describe('Non-base asset', () => { + it('should consolidate base asset just fine [ACCOUNT HAS LESS THAN MAX INPUTS]', async () => { + const maxInputs = 255; + const totalCoins = maxInputs - 1; // Expected to be 1 con...
bad
review
typescript
FuelLabs/fuels-ts
30753767b129ec5ff9fb95425a4112e22185332a
diff --git a/packages/account/src/consolidate-coins.test.ts b/packages/account/src/consolidate-coins.test.ts index c90a181de4f..b7386bd394e 100644 --- a/packages/account/src/consolidate-coins.test.ts +++ b/packages/account/src/consolidate-coins.test.ts @@ -138,166 +138,156 @@ describe('consolidate-coins', () => { ...
good
review_fixed
typescript
FuelLabs/fuels-ts
30753767b129ec5ff9fb95425a4112e22185332a
@@ -449,4 +439,316 @@ describe('consolidate-coins', () => { ); }); }); + + describe('Non-base asset', () => { + it('should consolidate base asset just fine [ACCOUNT HAS LESS THAN MAX INPUTS]', async () => { + const maxInputs = 255; + const totalCoins = maxInputs - 1; // Expected to be 1 con...
bad
review
typescript
FuelLabs/fuels-ts
30753767b129ec5ff9fb95425a4112e22185332a
diff --git a/packages/account/src/consolidate-coins.test.ts b/packages/account/src/consolidate-coins.test.ts index c90a181de4f..b7386bd394e 100644 --- a/packages/account/src/consolidate-coins.test.ts +++ b/packages/account/src/consolidate-coins.test.ts @@ -138,166 +138,156 @@ describe('consolidate-coins', () => { ...
good
review_fixed
typescript
FuelLabs/fuels-ts
30753767b129ec5ff9fb95425a4112e22185332a
@@ -40,7 +40,8 @@ export const FAILED_ASSERT_SIGNAL = '0xffffffffffff0004'; // Revert with this value for a failing call to `std::assert::assert_ne`. export const FAILED_ASSERT_NE_SIGNAL = '0xffffffffffff0005'; -export const FAILED_UNKNOWN_SIGNAL = '0x0';
bad
review
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
diff --git a/packages/transactions/src/configs.ts b/packages/transactions/src/configs.ts index bee093067d7..9608ba041f0 100644 --- a/packages/transactions/src/configs.ts +++ b/packages/transactions/src/configs.ts @@ -40,7 +40,8 @@ export const FAILED_ASSERT_SIGNAL = '0xffffffffffff0004'; // Revert with this value for ...
good
review_fixed
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
@@ -99,3 +100,16 @@ export interface Configurable { readonly concreteTypeId: string; readonly offset: number; } + +export interface ErrorPosition { + pkg: string; + file: string; + line: number; + column: number;
bad
review
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
diff --git a/packages/abi-coder/src/types/JsonAbiNew.ts b/packages/abi-coder/src/types/JsonAbiNew.ts index 6aff2ad11c1..036c13eaf92 100644 --- a/packages/abi-coder/src/types/JsonAbiNew.ts +++ b/packages/abi-coder/src/types/JsonAbiNew.ts @@ -12,6 +12,7 @@ export interface JsonAbi { readonly loggedTypes: readonly Logg...
good
review_fixed
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
@@ -99,3 +100,16 @@ export interface Configurable { readonly concreteTypeId: string; readonly offset: number; } + +export interface ErrorPosition { + pkg: string;
bad
review
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
diff --git a/packages/abi-coder/src/types/JsonAbiNew.ts b/packages/abi-coder/src/types/JsonAbiNew.ts index 6aff2ad11c1..036c13eaf92 100644 --- a/packages/abi-coder/src/types/JsonAbiNew.ts +++ b/packages/abi-coder/src/types/JsonAbiNew.ts @@ -12,6 +12,7 @@ export interface JsonAbi { readonly loggedTypes: readonly Logg...
good
review_fixed
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
@@ -55,3 +56,14 @@ export interface JsonAbiConfigurable { configurableType: JsonAbiArgument; offset: number; } + +export interface JsonAbiErrorCode { + pos: { + pkg: string; + file: string; + line: number; + column: number;
bad
review
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
diff --git a/packages/abi-typegen/src/types/interfaces/JsonAbi.ts b/packages/abi-typegen/src/types/interfaces/JsonAbi.ts index eed9fee4d46..2aaa51598ae 100644 --- a/packages/abi-typegen/src/types/interfaces/JsonAbi.ts +++ b/packages/abi-typegen/src/types/interfaces/JsonAbi.ts @@ -8,6 +8,7 @@ export interface JsonAbiOld...
good
review_fixed
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
@@ -99,3 +100,16 @@ export interface Configurable { readonly concreteTypeId: string; readonly offset: number; } + +export interface ErrorPosition { + pkg: string; + file: string; + line: number; + column: number;
bad
review
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
diff --git a/packages/abi-typegen/src/types/interfaces/JsonAbiNew.ts b/packages/abi-typegen/src/types/interfaces/JsonAbiNew.ts index 6aff2ad11c1..036c13eaf92 100644 --- a/packages/abi-typegen/src/types/interfaces/JsonAbiNew.ts +++ b/packages/abi-typegen/src/types/interfaces/JsonAbiNew.ts @@ -12,6 +12,7 @@ export interf...
good
review_fixed
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
@@ -147,5 +220,5 @@ export const extractTxError = (params: IExtractTxError): FuelError => { if (isPanic) { return assemblePanicError(statusReason, metadata); } - return assembleRevertError(receipts, logs, metadata); + return assembleRevertError(statusReason, logs, metadata, abis);
bad
review
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
diff --git a/packages/account/src/providers/utils/extract-tx-error.ts b/packages/account/src/providers/utils/extract-tx-error.ts index c76f34991b2..da4f470cbd7 100644 --- a/packages/account/src/providers/utils/extract-tx-error.ts +++ b/packages/account/src/providers/utils/extract-tx-error.ts @@ -1,6 +1,6 @@ +import typ...
good
review_fixed
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
@@ -0,0 +1,19 @@ +import { ErrorCode } from '../abi/errors/ErrorCode'; +import type { IType } from '../types/interfaces/IType'; +import type { JsonAbiErrorCode } from '../types/interfaces/JsonAbi'; + +import { makeErrorCode } from './makeErrorCodes'; + +export function parseErrorCodes(params: { + types: IType[]; + ra...
bad
review
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
diff --git a/packages/abi-typegen/src/utils/parseErrorCodes.ts b/packages/abi-typegen/src/utils/parseErrorCodes.ts new file mode 100644 index 00000000000..54487f4d4b8 --- /dev/null +++ b/packages/abi-typegen/src/utils/parseErrorCodes.ts @@ -0,0 +1,18 @@ +import type { ErrorCode } from '../abi/errors/ErrorCode'; +import...
good
review_fixed
typescript
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
@@ -0,0 +1,25 @@ +script; + +#[error_type] +enum MyError { + #[error(m = "error A")] + A: (), + #[error(m = "error B")] + B: (u64, u8), +} + +pub fn main(a: u8) { + match a { + 0 => require(1 == 0, MyError::A), + 1 => assert(false), + 2 => assert_eq(1, 10), + 3 => assert_ne(10...
bad
review
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
diff --git a/packages/fuel-gauge/test/fixtures/forc-projects/script-error/src/main.sw b/packages/fuel-gauge/test/fixtures/forc-projects/script-error/src/main.sw new file mode 100644 index 00000000000..2fa2486b456 --- /dev/null +++ b/packages/fuel-gauge/test/fixtures/forc-projects/script-error/src/main.sw @@ -0,0 +1,25 ...
good
review_fixed
FuelLabs/fuels-ts
4155d0b4bb2034acd5cbf59ae15f10fb5ac0731c
@@ -0,0 +1,14 @@ +# Custom Contract Call + +In certain scenarios, your use case may require more control over how contract calls are prepared and submitted. + +For instance, imagine a liquidity pool contract where users can deposit a specific asset to receive some form of benefit. To make the experience smoother and mo...
bad
review
FuelLabs/fuels-ts
28af88a4cdf73a75d35c04e9ac26888b59eb4d79
diff --git a/apps/docs/src/guide/contracts/custom-contract-calls.md b/apps/docs/src/guide/contracts/custom-contract-calls.md new file mode 100644 index 00000000000..97757c869f2 --- /dev/null +++ b/apps/docs/src/guide/contracts/custom-contract-calls.md @@ -0,0 +1,29 @@ +# Custom Contract Call + +In certain scenarios, yo...
good
review_fixed
FuelLabs/fuels-ts
28af88a4cdf73a75d35c04e9ac26888b59eb4d79
@@ -0,0 +1,14 @@ +# Custom Contract Call + +In certain scenarios, your use case may require more control over how contract calls are prepared and submitted. + +For instance, imagine a liquidity pool contract where users can deposit a specific asset to receive some form of benefit. To make the experience smoother and mo...
bad
review
FuelLabs/fuels-ts
28af88a4cdf73a75d35c04e9ac26888b59eb4d79
diff --git a/apps/docs/src/guide/contracts/custom-contract-calls.md b/apps/docs/src/guide/contracts/custom-contract-calls.md new file mode 100644 index 00000000000..97757c869f2 --- /dev/null +++ b/apps/docs/src/guide/contracts/custom-contract-calls.md @@ -0,0 +1,29 @@ +# Custom Contract Call + +In certain scenarios, yo...
good
review_fixed
FuelLabs/fuels-ts
28af88a4cdf73a75d35c04e9ac26888b59eb4d79
@@ -0,0 +1,14 @@ +# Custom Contract Call + +In certain scenarios, your use case may require more control over how contract calls are prepared and submitted. + +For instance, imagine a liquidity pool contract where users can deposit a specific asset to receive some form of benefit. To make the experience smoother and mo...
bad
review
FuelLabs/fuels-ts
28af88a4cdf73a75d35c04e9ac26888b59eb4d79
diff --git a/apps/docs/src/guide/contracts/custom-contract-calls.md b/apps/docs/src/guide/contracts/custom-contract-calls.md new file mode 100644 index 00000000000..97757c869f2 --- /dev/null +++ b/apps/docs/src/guide/contracts/custom-contract-calls.md @@ -0,0 +1,29 @@ +# Custom Contract Call + +In certain scenarios, yo...
good
review_fixed
FuelLabs/fuels-ts
28af88a4cdf73a75d35c04e9ac26888b59eb4d79
@@ -172,18 +146,19 @@ while IFS=, read -r project bench gas; do KEYS+=("$local_key") SEEN_KEYS["$local_key"]=1 fi -done < <(parse_commit "$AFTER_SHA") +done < <(parse_perf_file "$AFTER_FILE") if [[ ${#KEYS[@]} -eq 0 ]]; then - echo "ERROR: no benchmark data found for the given commits." >&2...
bad
review
FuelLabs/sway
1bf4b0b1cb438fa64439bc328084309ca28206c0
diff --git a/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/perf_diff.sh b/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/perf_diff.sh index 5d74fb9a98c..955c3c13969 100755 --- a/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/perf_diff.sh +++ b/test/src/e2e_vm...
good
review_fixed
FuelLabs/sway
1bf4b0b1cb438fa64439bc328084309ca28206c0
@@ -1,2 +1,3 @@ *.perf-diff.* *.perf-diff-stats.* +perf_out/*.txt
bad
review
FuelLabs/sway
1bf4b0b1cb438fa64439bc328084309ca28206c0
diff --git a/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/.gitignore b/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/.gitignore index 13bad1647e4..fd738c1eec6 100644 --- a/test/src/e2e_vm_tests/test_programs/should_pass/storage_benchmarks/.gitignore +++ b/test/src/e2e_vm_tests...
good
review_fixed
FuelLabs/sway
1bf4b0b1cb438fa64439bc328084309ca28206c0
@@ -45,9 +94,69 @@ fn run_tests<F: Fn(&str, &mut Context) -> bool>(sub_dir: &str, opt_fn: F) { let first_line = input.split('\n').next().unwrap(); - // The tests should return true, indicating they made modifications. + let before = ir.to_string(); + let r = opt_fn(first_line, &mut ir)...
bad
review
rust
FuelLabs/sway
c044fa73051a35d59d72daa22c57c8092e5397bd
diff --git a/sway-ir/tests/tests.rs b/sway-ir/tests/tests.rs index 2ede1eb7358..acd491875d8 100644 --- a/sway-ir/tests/tests.rs +++ b/sway-ir/tests/tests.rs @@ -1,4 +1,7 @@ -use std::path::PathBuf; +use std::{ + panic::catch_unwind, + path::{Path, PathBuf}, +}; use itertools::Itertools; use sway_features::Exp...
good
review_fixed
rust
FuelLabs/sway
c044fa73051a35d59d72daa22c57c8092e5397bd
@@ -1484,37 +1586,96 @@ impl<V> StorageKey<StorageVec<V>> { }); } - let len_in_bytes = len * SIZE_OF_V; - let index_offset = index * SIZE_OF_V; - let new_len_in_bytes = len_in_bytes - SIZE_OF_V; - - // 1. Read current slot content. - ...
bad
review
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw index 369b7de24dc..32cea254387 100644 --- a/sway-lib-std/src/storage/storage_vec.sw +++ b/sway-lib-std/src/storage/storage_vec.sw @@ -65,6 +65,11 @@ pub struct StorageVec<V> {} /// - `StorageVec<StorageMap<u64, b256>>` ///...
good
review_fixed
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
@@ -1221,6 +1250,42 @@ impl<V> StorageKey<StorageVec<V>> { // /// True if the `StorageVec` stores a storage type, i.e., if `V` is a storage type. // const STORES_STORAGE_TYPE: bool = __size_of::<V>() == 0; + /// Returns the storage slot key and byte offset within that slot for the element at `index`. + ...
bad
review
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw index 369b7de24dc..32cea254387 100644 --- a/sway-lib-std/src/storage/storage_vec.sw +++ b/sway-lib-std/src/storage/storage_vec.sw @@ -65,6 +65,11 @@ pub struct StorageVec<V> {} /// - `StorageVec<StorageMap<u64, b256>>` ///...
good
review_fixed
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
@@ -1328,33 +1408,28 @@ impl<V> StorageKey<StorageVec<V>> { return None; } + let new_len = len - 1; + const STORES_STORAGE_TYPE: bool = __size_of::<V>() == 0; if STORES_STORAGE_TYPE { // Reducing len by 1, effectively removing the last item. /...
bad
review
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw index 369b7de24dc..32cea254387 100644 --- a/sway-lib-std/src/storage/storage_vec.sw +++ b/sway-lib-std/src/storage/storage_vec.sw @@ -65,6 +65,11 @@ pub struct StorageVec<V> {} /// - `StorageVec<StorageMap<u64, b256>>` ///...
good
review_fixed
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
@@ -1404,19 +1480,19 @@ impl<V> StorageKey<StorageVec<V>> { const STORES_STORAGE_TYPE: bool = __size_of::<V>() == 0; - let (offset, field_id) = if STORES_STORAGE_TYPE { + let (field_id, offset) = if STORES_STORAGE_TYPE { // For nested storage types, we want to use a unique `field...
bad
review
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw index 369b7de24dc..32cea254387 100644 --- a/sway-lib-std/src/storage/storage_vec.sw +++ b/sway-lib-std/src/storage/storage_vec.sw @@ -65,6 +65,11 @@ pub struct StorageVec<V> {} /// - `StorageVec<StorageMap<u64, b256>>` ///...
good
review_fixed
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
@@ -1221,6 +1250,43 @@ impl<V> StorageKey<StorageVec<V>> { // /// True if the `StorageVec` stores a storage type, i.e., if `V` is a storage type. // const STORES_STORAGE_TYPE: bool = __size_of::<V>() == 0; + /// Returns the storage slot key and byte offset within that slot for the element at `index`. + ...
bad
review
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw index 369b7de24dc..32cea254387 100644 --- a/sway-lib-std/src/storage/storage_vec.sw +++ b/sway-lib-std/src/storage/storage_vec.sw @@ -65,6 +65,11 @@ pub struct StorageVec<V> {} /// - `StorageVec<StorageMap<u64, b256>>` ///...
good
review_fixed
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
@@ -1165,13 +1165,38 @@ fn offset_calculator<T>(index: u64) -> u64 { (index * size_in_bytes) / 8 } -// A dynamic-slot-based `StorageVec` has two distinctive modes +// A chunked-dynamic-slot-based `StorageVec` has two distinctive modes // of operations and storage access: // // 1. Storing non-zero-sized types...
bad
review
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92
diff --git a/sway-lib-std/src/storage/storage_vec.sw b/sway-lib-std/src/storage/storage_vec.sw index 369b7de24dc..32cea254387 100644 --- a/sway-lib-std/src/storage/storage_vec.sw +++ b/sway-lib-std/src/storage/storage_vec.sw @@ -65,6 +65,11 @@ pub struct StorageVec<V> {} /// - `StorageVec<StorageMap<u64, b256>>` ///...
good
review_fixed
FuelLabs/sway
56b5d54eb0a47fbf345081f8ea74739eff875c92