task_id
stringlengths
10
58
repo
stringclasses
854 values
pr_number
int32
1
321k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
task
stringlengths
2
105k
plan
listlengths
1
100
subagents
listlengths
1
100
revisions
listlengths
0
100
final_diff
stringlengths
256
202M
num_subtasks
int32
1
100
num_changed_files
int32
2
100
yhirose/cpp-httplib#2463
yhirose/cpp-httplib
2,463
44215e23e92c473a3553d24ae634aed6eefc7dd0
e0c548b0380c28d550f962563c9820a080150bad
add set_hostname_addr_map to WebSocketClient WebSockets also need the set_hostname_addr_map function when connecting.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: add set_hostname_addr_map to WebSocketClient", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: add set_hostname_addr_map to WebSocketCli...
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex 8eb86a36e0..80da0f275f 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -3842,6 +3842,7 @@ class WebSocketClient {\n void set_socket_options(SocketOptions socket_options);\n void s...
[ { "subtask_id": "s2", "comment": "Implementation looks good โ€” faithfully mirrors `ClientImpl::set_hostname_addr_map` ๐Ÿ‘\n\nOne issue in this test: `0.0.0.0` will likely fail on the Linux CI. There, `connect(2)` to `0.0.0.0` is treated as `127.0.0.1`, so it reaches the server bound above โ†’ `connect()` succee...
diff --git a/httplib.h b/httplib.h index 8eb86a36e0..80da0f275f 100644 --- a/httplib.h +++ b/httplib.h @@ -3842,6 +3842,7 @@ class WebSocketClient { void set_socket_options(SocketOptions socket_options); void set_connection_timeout(time_t sec, time_t usec = 0); void set_interface(const std::string &intf); + v...
2
2
yhirose/cpp-httplib#2465
yhirose/cpp-httplib
2,465
44215e23e92c473a3553d24ae634aed6eefc7dd0
d6fbf942a568abf3c8ce9df9245ea2f51f484c23
Ignore range requests for unknown-length streaming responses Clients like ffmpeg/browser-like clients may send `Range: bytes=0-` for live multipart streams. A concrete example is a live MJPEG stream served as multipart/x-mixed-replace. In such a scenario the resource is not meaningfully byte-range addressable: ther...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Ignore range requests for unknown-length streaming responses", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Ignore range requests for...
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex 439b3facef..557d532909 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -8362,6 +8362,14 @@ inline void coalesce_ranges(Ranges &ranges, size_t content_length) {\n \n inline bool range_...
[]
diff --git a/httplib.h b/httplib.h index 439b3facef..557d532909 100644 --- a/httplib.h +++ b/httplib.h @@ -8362,6 +8362,14 @@ inline void coalesce_ranges(Ranges &ranges, size_t content_length) { inline bool range_error(Request &req, Response &res) { if (!req.ranges.empty() && 200 <= res.status && res.status < 300...
2
2
yhirose/cpp-httplib#2448
yhirose/cpp-httplib
2,448
b1792ef29ca66f8dcb44b1678e597676a33a3f1b
2ad877322b3528afd55a40df4e22f6d065afb384
Feature 2446 no proxy env The primary goal of this pull request is to provide a reference implementation with Opus 4.7 (#2446), focusing not only on functionality but also on security by ensuring there are no vulnerabilities.
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Feature 2446 no proxy env", "scope_files": [ "README.md", "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs-src/pages/en/cookbook/` needed for: Feature 2446 no pro...
[ { "subtask_id": "s1", "scope_files": [ "README.md", "httplib.h" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 1037ab2e36..d4bbb2e5c2 100644\n--- a/README.md\n+++ b/README.md\n@@ -1181,6 +1181,17 @@ cli.set_proxy_bearer_token_auth(\"pass\");\n > [!NOTE]\n > OpenSSL is req...
[]
diff --git a/README.md b/README.md index 1037ab2e36..d4bbb2e5c2 100644 --- a/README.md +++ b/README.md @@ -1181,6 +1181,17 @@ cli.set_proxy_bearer_token_auth("pass"); > [!NOTE] > OpenSSL is required for Digest Authentication. +#### Bypass the proxy for specific hosts (`NO_PROXY`) + +```cpp +cli.set_no_proxy({"inter...
4
5
yhirose/cpp-httplib#2460
yhirose/cpp-httplib
2,460
c86c192f3e86ab2ccb5062c070274102a64780c3
25622658093bdfc1aed9fa254e999980fe3c132f
Fix #2458: send body when no 100 Continue arrives over TLS ## Problem `Client::Put`/`Post` with a body of at least `CPPHTTPLIB_EXPECT_100_THRESHOLD` (1024) bytes auto-adds `Expect: 100-continue`. Over TLS, this could fail with `Failed to read connection` (#2458): the server received the request but the client never s...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Fix #2458: send body when no 100 Continue arrives over TLS", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Fix #2458: send body when n...
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex 0e7e2aaceb..66d4c2fd84 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -13810,13 +13810,28 @@ inline bool ClientImpl::process_request(Stream &strm, Request &req,\n }\n #endif\n \n- ...
[]
diff --git a/httplib.h b/httplib.h index 0e7e2aaceb..66d4c2fd84 100644 --- a/httplib.h +++ b/httplib.h @@ -13810,13 +13810,28 @@ inline bool ClientImpl::process_request(Stream &strm, Request &req, } #endif - // Handle Expect: 100-continue with timeout - if (expect_100_continue && CPPHTTPLIB_EXPECT_100_TIMEOUT_M...
2
2
yhirose/cpp-httplib#2455
yhirose/cpp-httplib
2,455
b1cc8095a8feca1b99e296ef78eddd312e80d2c6
88a92152d343cbad5b5b6bc6f25221d966f828b5
Fix iOS build break and modernize macOS Keychain cert loading ## Summary - Replace deprecated `SecTrustCopyAnchorCertificates` with `SecTrustSettingsCopyCertificates`, iterating over the System/Admin/User trust domains - Restrict the `CPPHTTPLIB_USE_CERTS_FROM_MACOSX_KEYCHAIN` auto-enable and `Security.h` include guar...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Fix iOS build break and modernize macOS Keychain cert loading", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: Fix iOS bui...
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex 7c924e6a65..2af1f507c5 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -339,16 +339,26 @@ using socket_t = int;\n #include <utility>\n \n // On macOS with a TLS backend, enable Keycha...
[]
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 38787cc214..d0e41c38c9 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -250,6 +250,54 @@ jobs: - name: build and run ThreadPool test run: cd test && make test_thread_pool && ./test_thread_pool + ...
2
2
yhirose/cpp-httplib#2456
yhirose/cpp-httplib
2,456
0d7d6374666956c9f5e2767573fb7be0d4477d16
9b67c9833a11f63168e0eeef59f3489cb4753e1e
ci: add best-effort BoringSSL job ## Summary Adds first-class CI coverage for BoringSSL as a best-effort TLS backend, on both Linux and macOS, plus the small code/test/docs adjustments that fall out of supporting it. ## What's in the PR **CI jobs** (`.github/workflows/test.yaml`) - `ubuntu-boringssl` and `macos-bor...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: ci: add best-effort BoringSSL job", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: ci: add best-effort BoringSSL job", ...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex f1fd63a7e7..1037ab2e36 100644\n--- a/README.md\n+++ b/README.md\n@@ -73,6 +73,9 @@ cpp-httplib supports multiple TLS backends through an abstraction layer:\n > [!NOTE]\n > **Mbed T...
[]
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index d0e41c38c9..ea50f94cd3 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -120,6 +120,155 @@ jobs: - name: build and run ThreadPool test run: cd test && make test_thread_pool && ./test_thread_pool +...
3
3
yhirose/cpp-httplib#2445
yhirose/cpp-httplib
2,445
a1fdc07f34ef4788b24c7be3c3fb41a402409662
0e02c8de71983b7d7fa43d9ac4b8372fc07e2650
ThreadPool constructor might fail when pthread_create fails leaving threads unjoined We are using httplib in duckdb, and we are super happy with it. In an experimental branch, I try to use `httplib`'s `ThreadPool`, but I found out that when (due to resource exhaustion in the system I was running the tests) pthread_cr...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: ThreadPool constructor might fail when pthread_create fails leaving threads unjoined", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: T...
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex d400c7bca8..f68ad84961 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -10047,9 +10047,29 @@ inline ThreadPool::ThreadPool(size_t n, size_t max_n, size_t mqr)\n #endif\n max_thread_...
[]
diff --git a/httplib.h b/httplib.h index d400c7bca8..f68ad84961 100644 --- a/httplib.h +++ b/httplib.h @@ -10047,9 +10047,29 @@ inline ThreadPool::ThreadPool(size_t n, size_t max_n, size_t mqr) #endif max_thread_count_ = max_n == 0 ? n : max_n; threads_.reserve(base_thread_count_); - for (size_t i = 0; i < base...
2
3
yhirose/cpp-httplib#2438
yhirose/cpp-httplib
2,438
0cbeafe6a4026e0ebf890d8e779dca65d8e0a3b9
a838ccf4dbe2d66564d5f1d3b8ba182354713813
mmap CreateFile2 without FILE_SHARE_WRITE Hi, I have the following issue using the httplib server on win32. When using Server::set_mount_point, httplib opens the file in mmap with the following line: `File_ = ::CreateFile2(wpath.c_str(), GENERIC_READ, FILE_SHARE_READ, OPEN_EXISTING, NULL);` - GENERIC_READ the right ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: mmap CreateFile2 without FILE_SHARE_WRITE", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: mmap CreateFile2 without FILE_SHARE_WRITE", ...
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex 7cf8c45471..d69c007996 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -5319,8 +5319,9 @@ inline bool mmap::open(const char *path) {\n auto wpath = u8string_to_wstring(path);\n if...
[]
diff --git a/httplib.h b/httplib.h index 7cf8c45471..d69c007996 100644 --- a/httplib.h +++ b/httplib.h @@ -5319,8 +5319,9 @@ inline bool mmap::open(const char *path) { auto wpath = u8string_to_wstring(path); if (wpath.empty()) { return false; } - hFile_ = ::CreateFile2(wpath.c_str(), GENERIC_READ, FILE_SHARE_R...
2
2
yhirose/cpp-httplib#2437
yhirose/cpp-httplib
2,437
5ebbfeef0bf8e26b41036a2033fd391e05d5639f
a2f1538e8290b45a1fd7948f99843d21267356e3
Add client fuzzing harness Cover client request processing logic. The goal is to enable this running on OSS-Fuzz.
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/fuzzing/` needed for: Add client fuzzing harness", "scope_files": [ "test/fuzzing/Makefile", "test/fuzzing/client_fuzzer.cc" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "test/fuzzing/Makefile", "test/fuzzing/client_fuzzer.cc" ], "solution_diff": "diff --git a/test/fuzzing/Makefile b/test/fuzzing/Makefile\nindex 7f0b4dab71..da5d696825 100644\n--- a/test/fuzzing/Makefile\n+++ b/test/fuzzing/Makefile\n@@ -13,7 +13,7 @...
[]
diff --git a/test/fuzzing/Makefile b/test/fuzzing/Makefile index 7f0b4dab71..da5d696825 100644 --- a/test/fuzzing/Makefile +++ b/test/fuzzing/Makefile @@ -13,7 +13,7 @@ ZLIB_SUPPORT = -DCPPHTTPLIB_ZLIB_SUPPORT -lz BROTLI_DIR = /usr/local/opt/brotli # BROTLI_SUPPORT = -DCPPHTTPLIB_BROTLI_SUPPORT -I$(BROTLI_DIR)/inclu...
1
2
yhirose/cpp-httplib#2433
yhirose/cpp-httplib
2,433
33bc1df930363e73fb1fd97f8d475e4272b1f221
aec17168b204ba4685ad8d96fc0413a04e2334ca
Reproducer test for #2431 (getaddrinfo_a use-after-free) ## Summary Adds a CI-gated reproducer for #2431 โ€” the use-after-free in `detail::getaddrinfo_with_timeout()` on Linux/glibc when `gai_suspend()` hits the connection timeout and the non-blocking `gai_cancel()` returns `EAI_NOTCANCELED`, leaving the resolver work...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: Reproducer test for #2431 (getaddrinfo_a use-after-free)", "scope_files": [ ".github/workflows/test.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: ...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/test.yaml" ], "solution_diff": "diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml\nindex 69cc8d7463..12bee95bb9 100644\n--- a/.github/workflows/test.yaml\n+++ b/.github/workflows/test.yaml\n@@ -114,6 +114,92 @@ jobs...
[]
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 69cc8d7463..12bee95bb9 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -114,6 +114,92 @@ jobs: - name: build and run ThreadPool test run: cd test && make test_thread_pool && ./test_thread_pool + ...
2
4
yhirose/cpp-httplib#2428
yhirose/cpp-httplib
2,428
b045ee7f6b434a85fd011e96e28c6d4abfb18788
0e989162b19586f24365bab065b82c2a0b6f57b5
Fix #2427 This pull request improves the reliability of the HTTP server in the test suite by ensuring that the server reads the entire HTTP request from the client before sending a response. This change prevents connection resets that can occur if the server closes the socket while unread request data remains in the k...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/` needed for: Fix #2427", "scope_files": [ "test/Makefile", "test/test.cc" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "test/Makefile", "test/test.cc" ], "solution_diff": "diff --git a/test/Makefile b/test/Makefile\nindex 40b208874a..eb32bf1ebb 100644\n--- a/test/Makefile\n+++ b/test/Makefile\n@@ -18,6 +18,8 @@ ifneq ($(OS), Windows_NT)\n \t\tOPENSSL_SUPPORT = -DCPP...
[]
diff --git a/test/Makefile b/test/Makefile index 40b208874a..eb32bf1ebb 100644 --- a/test/Makefile +++ b/test/Makefile @@ -18,6 +18,8 @@ ifneq ($(OS), Windows_NT) OPENSSL_SUPPORT = -DCPPHTTPLIB_OPENSSL_SUPPORT -lssl -lcrypto MBEDTLS_SUPPORT = -DCPPHTTPLIB_MBEDTLS_SUPPORT -lmbedtls -lmbedx509 -lmbedcrypto WOLF...
1
2
yhirose/cpp-httplib#2430
yhirose/cpp-httplib
2,430
b045ee7f6b434a85fd011e96e28c6d4abfb18788
f066189b23a5b7461536759bbf22b57ee540d2b0
fix #2429 When SSL_read() returns 0 after receiving a close_notify alert, tls::read() incorrectly returned -1, making clean peer shutdown indistinguishable from a read error. This broke HTTP responses using Connection: close without Content-Length, where the connection close signals end-of-body. Return 0 for PeerClose...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: fix #2429", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: fix #2429", "scope_files": [ "test/test.cc" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex c5ae2c8a0e..e2236879ed 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -16766,6 +16766,9 @@ inline ssize_t read(session_t session, void *buf, size_t len, TlsError &err) {\n \n auto ...
[]
diff --git a/httplib.h b/httplib.h index c5ae2c8a0e..e2236879ed 100644 --- a/httplib.h +++ b/httplib.h @@ -16766,6 +16766,9 @@ inline ssize_t read(session_t session, void *buf, size_t len, TlsError &err) { auto ssl_err = SSL_get_error(ssl, ret); err.code = impl::map_ssl_error(ssl_err, err.sys_errno); + if (err...
2
2
yhirose/cpp-httplib#2423
yhirose/cpp-httplib
2,423
c0248ff7fc1506c1bdd12a57cef4e2c5026032a7
6f375c47b3d003fe3c89d6ce4b70ca91cdb15078
Removed deprecated APIs This pull request primarily removes documentation and test references to deprecated APIs, specifically those related to SSL error handling and deprecated constructors. It also updates example code to use the current API for reporting SSL backend errors. The changes help clean up the codebase an...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Removed deprecated APIs", "scope_files": [ "README.md", "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs-src/pages/en/cookbook/` needed for: Removed deprecated AP...
[ { "subtask_id": "s1", "scope_files": [ "README.md", "httplib.h" ], "solution_diff": "diff --git a/README.md b/README.md\nindex f6134a112d..5df1ce529e 100644\n--- a/README.md\n+++ b/README.md\n@@ -1564,10 +1564,6 @@ Include `httplib.h` before `Windows.h` or include `Windows.h` by defining...
[]
diff --git a/README.md b/README.md index f6134a112d..5df1ce529e 100644 --- a/README.md +++ b/README.md @@ -1564,10 +1564,6 @@ Include `httplib.h` before `Windows.h` or include `Windows.h` by defining `WIN32 > [!NOTE] > cpp-httplib officially supports only the latest Visual Studio. It might work with former versions o...
5
6
yhirose/cpp-httplib#2412
yhirose/cpp-httplib
2,412
32c82492dec964b6192f77ca47da86e284aa4a72
c57c247ff286f40c7b7b399c6b679b360b57ee1c
Add two new fuzzers The goal is to increase code coverage by way of OSS-Fuzz. A recent code coverage report is available at https://storage.googleapis.com/oss-fuzz-coverage/cpp-httplib/reports/20260326/linux/report.html
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/fuzzing/` needed for: Add two new fuzzers", "scope_files": [ "test/fuzzing/Makefile", "test/fuzzing/header_parser_fuzzer.cc", "test/fuzzing/url_parser_fuzzer.cc" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "test/fuzzing/Makefile", "test/fuzzing/header_parser_fuzzer.cc", "test/fuzzing/url_parser_fuzzer.cc" ], "solution_diff": "diff --git a/test/fuzzing/Makefile b/test/fuzzing/Makefile\nindex b08ecd0848..7f0b4dab71 100644\n--- a/test/fuzzing/Makef...
[]
diff --git a/test/fuzzing/Makefile b/test/fuzzing/Makefile index b08ecd0848..7f0b4dab71 100644 --- a/test/fuzzing/Makefile +++ b/test/fuzzing/Makefile @@ -13,8 +13,10 @@ ZLIB_SUPPORT = -DCPPHTTPLIB_ZLIB_SUPPORT -lz BROTLI_DIR = /usr/local/opt/brotli # BROTLI_SUPPORT = -DCPPHTTPLIB_BROTLI_SUPPORT -I$(BROTLI_DIR)/incl...
1
3
yhirose/cpp-httplib#2403
yhirose/cpp-httplib
2,403
c2bdb1c5c15adb8ffcf398702084eb52aed3757f
94a7e335f9e3ae5bfcc101613f4820ba4c6ab0c9
"Building a Desktop LLM App with cpp-httplib"
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: \"Building a Desktop LLM App with cpp-httplib\"", "scope_files": [ "justfile" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs-src/pages/en/` needed for: \"Building a Desktop LLM A...
[ { "subtask_id": "s1", "scope_files": [ "justfile" ], "solution_diff": "diff --git a/justfile b/justfile\nindex 6a2a7b404e..7ba7909a13 100644\n--- a/justfile\n+++ b/justfile\n@@ -46,11 +46,8 @@ build:\n bench:\n @(cd benchmark && make bench-all)\n \n-docs:\n- @cargo build --release --man...
[]
diff --git a/docs-src/pages/en/index.md b/docs-src/pages/en/index.md index 3fbfcb6e8d..90a3ebf1c4 100644 --- a/docs-src/pages/en/index.md +++ b/docs-src/pages/en/index.md @@ -18,8 +18,8 @@ Under the hood, it uses blocking I/O with a thread pool. It's not built for hand ## Documentation - [A Tour of cpp-httplib](tou...
6
35
yhirose/cpp-httplib#2388
yhirose/cpp-httplib
2,388
ab3098f18bd78da2b67c135c18cf48702ea979cd
5be1d2c5e4def65695c0a8f125d568fa36046cf0
Remove 32-bit limitation
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Remove 32-bit limitation", "scope_files": [ "CMakeLists.txt", "README.md", "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: Remov...
[ { "subtask_id": "s1", "scope_files": [ "CMakeLists.txt", "README.md", "httplib.h" ], "solution_diff": "diff --git a/CMakeLists.txt b/CMakeLists.txt\nindex ae236c3767..1874e36be0 100644\n--- a/CMakeLists.txt\n+++ b/CMakeLists.txt\n@@ -173,9 +173,6 @@ if(CMAKE_SYSTEM_NAME MATCHES \"W...
[]
diff --git a/.github/workflows/test-32bit.yml b/.github/workflows/test-32bit.yml new file mode 100644 index 0000000000..2fa0337152 --- /dev/null +++ b/.github/workflows/test-32bit.yml @@ -0,0 +1,36 @@ +name: 32-bit Build Test + +on: + push: + branches: [master] + pull_request: + branches: [master] + workflow_d...
3
6
yhirose/cpp-httplib#2376
yhirose/cpp-httplib
2,376
85b18a9c6431877188a706ba3c61679fa9de3e27
f88387dccf33fddf2a36946d5f2a4feed538aeda
Documentation Site on GitHub Pages
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Documentation Site on GitHub Pages", "scope_files": [ ".gitignore", "justfile" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/` needed for: Documentation Site on GitHub Pag...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore", "justfile" ], "solution_diff": "diff --git a/.gitignore b/.gitignore\nindex 1ea2142f62..40930943d4 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -57,6 +57,7 @@ test/*.log\n test/_build_*\n work/\n benchmark/server*\n+docs-gen/target/\...
[]
diff --git a/.gitignore b/.gitignore index 1ea2142f62..40930943d4 100644 --- a/.gitignore +++ b/.gitignore @@ -57,6 +57,7 @@ test/*.log test/_build_* work/ benchmark/server* +docs-gen/target/ *.swp diff --git a/docs-gen/Cargo.lock b/docs-gen/Cargo.lock new file mode 100644 index 0000000000..6d12b6715b --- /dev/...
40
66
yhirose/cpp-httplib#2360
yhirose/cpp-httplib
2,360
a9fc9359196210a7b5d81c20a77ed2f5501c0840
08c87be3fc9c08c326160baf2a1e033bb88ec326
CMake component `MbedTLS` I think that [this pull request](https://github.com/yhirose/cpp-httplib/pull/2342) requires a small update of `CMakeLists.txt`. Probably a new component like `MbedTLS` to set the macro `CPPHTTPLIB_MBEDTLS_SUPPORT`. Overall conidition via `CPPHTTPLIB_SSL_ENABLED`. Sets macro `CPPHTTPLIB_OPEN...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: CMake component `MbedTLS`", "scope_files": [ "CMakeLists.txt" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `cmake/` needed for: CMake component `MbedTLS`", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "CMakeLists.txt" ], "solution_diff": "diff --git a/CMakeLists.txt b/CMakeLists.txt\nindex 96ede135d7..ae236c3767 100644\n--- a/CMakeLists.txt\n+++ b/CMakeLists.txt\n@@ -2,11 +2,15 @@\n \tBuild options:\n \t* Standard BUILD_SHARED_LIBS is supported and set...
[ { "subtask_id": "s2", "comment": "typo", "revised_diff": "diff --git a/cmake/httplibConfig.cmake.in b/cmake/httplibConfig.cmake.in\nindex 8ca8b991a2..933862a5e0 100644\n--- a/cmake/httplibConfig.cmake.in\n+++ b/cmake/httplibConfig.cmake.in\n@@ -4,6 +4,8 @@\n # Setting these here so they're accessible af...
diff --git a/CMakeLists.txt b/CMakeLists.txt index 96ede135d7..ae236c3767 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -2,11 +2,15 @@ Build options: * Standard BUILD_SHARED_LIBS is supported and sets HTTPLIB_SHARED default value. * HTTPLIB_USE_OPENSSL_IF_AVAILABLE (default on) + * HTTPLIB_USE_WOLFSSL_IF_AV...
2
2
yhirose/cpp-httplib#2377
yhirose/cpp-httplib
2,377
7c33fd47bf3ab74fe968e31c5e585598373e2d8c
f09894708592fd4d2cfb2b9100eb25d41f096148
Make loading system certificates from the Keychain on macOS an opt-out feature
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Make loading system certificates from the Keychain on macOS an opt-out feature", "scope_files": [ "CMakeLists.txt", "README.md", "httplib.h", "meson.build", "meson_options.txt" ] }, { ...
[ { "subtask_id": "s1", "scope_files": [ "CMakeLists.txt", "README.md", "httplib.h", "meson.build", "meson_options.txt" ], "solution_diff": "diff --git a/CMakeLists.txt b/CMakeLists.txt\nindex 45a0e16b98..96ede135d7 100644\n--- a/CMakeLists.txt\n+++ b/CMakeLists.txt\n@@ -...
[]
diff --git a/CMakeLists.txt b/CMakeLists.txt index 45a0e16b98..96ede135d7 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -10,7 +10,7 @@ * HTTPLIB_REQUIRE_ZLIB (default off) * HTTPLIB_REQUIRE_BROTLI (default off) * HTTPLIB_REQUIRE_ZSTD (default off) - * HTTPLIB_USE_CERTS_FROM_MACOSX_KEYCHAIN (default on) + * ...
2
6
yhirose/cpp-httplib#2370
yhirose/cpp-httplib
2,370
718d7d92b993d8fdf6a74d82af8572b96787a909
dc5adc01852b532cbac598f6d7412364e06913d8
Add wolfSSL support woflSSL support
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add wolfSSL support", "scope_files": [ ".gitignore", "README.md", "httplib.h", "justfile" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed f...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore", "README.md", "httplib.h", "justfile" ], "solution_diff": "diff --git a/.gitignore b/.gitignore\nindex 04d7498fd9..01cc6cfd54 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -36,12 +36,14 @@ test/httplib.cc\n test/httplib.h\n...
[]
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 69158d3f7d..378c0ce3d9 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -77,7 +77,7 @@ jobs: (github.event_name == 'workflow_dispatch' && github.event.inputs.test_linux == 'true') strategy: matri...
3
6
yhirose/cpp-httplib#1612
yhirose/cpp-httplib
1,612
82acdca638b64e0c00b43e2b192fbce0a4de9567
28e34136e0ab52a31e1c9e020426e2cd5926d393
Fix successful decompress reported as Error::Read Streams less than 4096 bytes are sometimes reported as failed reads because stream_.avail_in is not reduced to 0. The next iteration of the loop finds `prev_avail_in == strm_.avail_in` and return false. `ret = inflate(...)` returns `Z_STREAM_END` on the first iteration...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Fix successful decompress reported as Error::Read", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Fix successful decompress reported a...
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex 9753439abb..4691b7354b 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -3384,16 +3384,12 @@ inline bool gzip_decompressor::decompress(const char *data, size_t data_length,\n data ...
[]
diff --git a/httplib.h b/httplib.h index 9753439abb..4691b7354b 100644 --- a/httplib.h +++ b/httplib.h @@ -3384,16 +3384,12 @@ inline bool gzip_decompressor::decompress(const char *data, size_t data_length, data += strm_.avail_in; std::array<char, CPPHTTPLIB_COMPRESSION_BUFSIZ> buff{}; - while (strm_.ava...
2
2
yhirose/cpp-httplib#1046
yhirose/cpp-httplib
1,046
e3e28c623165f9965efd2abbb7a31891c0fad684
40c2abb68a296a984144c31995349cf327b3d06b
Read buffer
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Read buffer", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Read buffer", "scope_files": [ "test/test.cc" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex b65a89a72a..fae47fa75e 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -1671,6 +1671,10 @@ bool parse_range_header(const std::string &s, Ranges &ranges);\n \n int close_socket(socket_...
[]
diff --git a/httplib.h b/httplib.h index b65a89a72a..fae47fa75e 100644 --- a/httplib.h +++ b/httplib.h @@ -1671,6 +1671,10 @@ bool parse_range_header(const std::string &s, Ranges &ranges); int close_socket(socket_t sock); +ssize_t send_socket(socket_t sock, const void *ptr, size_t size, int flags); + +ssize_t read...
2
2
yhirose/cpp-httplib#845
yhirose/cpp-httplib
845
ae6cf70bc459ffc0f0f4c710b6c050f3b5d60cf2
9be81a62ea7a25299c75829eac1b65b698222b6a
Add exception handler This pull request adds the option to handle C++ exceptions caused by user handlers when routing. This allows users to react to exceptions globally by logging them and restarting safely. This may be used over try/catch's within the handlers to avoid repetition in error messages: an API might retur...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add exception handler", "scope_files": [ "README.md", "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Add exception handler", "scope_files": [ ...
[ { "subtask_id": "s1", "scope_files": [ "README.md", "httplib.h" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 952a757dd3..37d2db119e 100644\n--- a/README.md\n+++ b/README.md\n@@ -177,6 +177,19 @@ svr.set_error_handler([](const auto& req, auto& res) {\n });\n ```\n \n+###...
[ { "subtask_id": "s1", "comment": "missing `, std::exception &e` in the argument list?", "revised_diff": "diff --git a/README.md b/README.md\nindex 952a757dd3..37d2db119e 100644\n--- a/README.md\n+++ b/README.md\n@@ -177,6 +177,19 @@ svr.set_error_handler([](const auto& req, auto& res) {\n });\n ```\n \n...
diff --git a/README.md b/README.md index 952a757dd3..37d2db119e 100644 --- a/README.md +++ b/README.md @@ -177,6 +177,19 @@ svr.set_error_handler([](const auto& req, auto& res) { }); ``` +### Exception handler +The exception handler gets called if a user routing handler throws an error. + +```cpp +svr.set_exception...
2
3
yhirose/cpp-httplib#2166
yhirose/cpp-httplib
2,166
696c02f2bcc494011239e666ae46f5fde7d3260d
8561b6f6ac92c1e572cb475bc09088eae31479c5
Cleaner API
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Cleaner API", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Cleaner API", "scope_files": [ "test/test.cc" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex e7fe9efe6e..27c4501ffa 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -126,6 +126,10 @@\n #define CPPHTTPLIB_RECV_BUFSIZ size_t(16384u)\n #endif\n \n+#ifndef CPPHTTPLIB_SEND_BUFSIZ\n...
[]
diff --git a/httplib.h b/httplib.h index e7fe9efe6e..27c4501ffa 100644 --- a/httplib.h +++ b/httplib.h @@ -126,6 +126,10 @@ #define CPPHTTPLIB_RECV_BUFSIZ size_t(16384u) #endif +#ifndef CPPHTTPLIB_SEND_BUFSIZ +#define CPPHTTPLIB_SEND_BUFSIZ size_t(16384u) +#endif + #ifndef CPPHTTPLIB_COMPRESSION_BUFSIZ #define CP...
2
2
yhirose/cpp-httplib#2268
yhirose/cpp-httplib
2,268
1acf18876fdbd1a4f3ff91f43cf21495af357850
2214859dc2ceb74940853a4d391bfad5800769c0
Add Client methods with both content provider and receiver Add most `Post` overloads for `Client`, with both content provider and content receiver. * Result Post(const std::string &path, size_t content_length, ContentProvider content_provider, const std::string &content_type, ContentReceiver content_receiver, Uploa...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add Client methods with both content provider and receiver", "scope_files": [ "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Add Client methods with bot...
[ { "subtask_id": "s1", "scope_files": [ "httplib.h" ], "solution_diff": "diff --git a/httplib.h b/httplib.h\nindex 8411c8c93b..8ed840efd7 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -1421,14 +1421,18 @@ class ClientImpl {\n Result Post(const std::string &path, const char *body, size_t conten...
[ { "subtask_id": "s1", "comment": "Could you explain why these lines need to be added? These are already added at line 3842 and 3843.", "revised_diff": "diff --git a/httplib.h b/httplib.h\nindex 8411c8c93b..8ed840efd7 100644\n--- a/httplib.h\n+++ b/httplib.h\n@@ -1421,14 +1421,18 @@ class ClientImpl {\n ...
diff --git a/httplib.h b/httplib.h index 8411c8c93b..8ed840efd7 100644 --- a/httplib.h +++ b/httplib.h @@ -1421,14 +1421,18 @@ class ClientImpl { Result Post(const std::string &path, const char *body, size_t content_length, const std::string &content_type, UploadProgress progress = nullptr); Result Post(const std...
2
2
yhirose/cpp-httplib#2368
yhirose/cpp-httplib
2,368
d4180e923f846b44a3d30acd938438d6e64fc9f6
81cbc42b7d469a3222f41b30f6a29c25531cb3f6
WebSocket and Dynamic Thread Pool support Long waited features are finally supported! - WebSocket support - Dynamic Thread Pool support
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: WebSocket and Dynamic Thread Pool support", "scope_files": [ ".gitignore", "README-websocket.md", "README.md", "httplib.h" ] }, { "subtask_id": "s2", "goal": "Implement the changes un...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore", "README-websocket.md", "README.md", "httplib.h" ], "solution_diff": "diff --git a/.gitignore b/.gitignore\nindex c2590a0e28..04d7498fd9 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -29,6 +29,8 @@ example/server_and_client...
[]
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 027eda56e7..69158d3f7d 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -103,6 +103,11 @@ jobs: - name: run fuzz test target if: matrix.tls_backend == 'openssl' run: cd test && make fuzz_te...
4
11
yhirose/cpp-httplib#2364
yhirose/cpp-httplib
2,364
c1ee85d89ea2d857509164df6b759e36342ef2e4
45ed6c0ba9bfea00b3453ab2aecaa5c565771807
Parallel test on CI
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Parallel test on CI", "scope_files": [ ".gitignore", "justfile" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `.github/workflows/` needed for: Parallel test on CI", "scope_f...
[ { "subtask_id": "s1", "scope_files": [ ".gitignore", "justfile" ], "solution_diff": "diff --git a/.gitignore b/.gitignore\nindex 80278dc2d0..c2590a0e28 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -46,6 +46,7 @@ test/test.xcodeproj/*/xcuser*\n test/*.o\n test/*.pem\n test/*.srl\n+test/...
[ { "subtask_id": "s3", "comment": "https://github.com/google/gtest-parallel may be useful here", "revised_diff": "diff --git a/test/Makefile b/test/Makefile\nindex 9b2d1e75cf..b8f5babee0 100644\n--- a/test/Makefile\n+++ b/test/Makefile\n@@ -56,6 +56,42 @@ STYLE_CHECK_FILES = $(filter-out httplib.h httpli...
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 31459e863d..027eda56e7 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -94,12 +94,12 @@ jobs: run: sudo apt-get install -y libmbedtls-dev - name: build and run tests (OpenSSL) if: matrix.t...
3
7
yhirose/cpp-httplib#2363
yhirose/cpp-httplib
2,363
14e37bd75b52a31d7e68ccd20bc4e1b505257b6e
630eee8bd9180a6e192208448bdc2fd948da2596
Use iptables to disable network
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: Use iptables to disable network", "scope_files": [ ".github/workflows/test_offline.yaml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: Use iptables to d...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/test_offline.yaml" ], "solution_diff": "diff --git a/.github/workflows/test_offline.yaml b/.github/workflows/test_offline.yaml\nindex 64e86177b1..8814877e61 100644\n--- a/.github/workflows/test_offline.yaml\n+++ b/.github/workflows/test...
[]
diff --git a/.github/workflows/test_offline.yaml b/.github/workflows/test_offline.yaml index 64e86177b1..8814877e61 100644 --- a/.github/workflows/test_offline.yaml +++ b/.github/workflows/test_offline.yaml @@ -40,7 +40,13 @@ jobs: if: matrix.tls_backend == 'openssl' run: sudo apt-get install -y libs...
2
2
yiisoft/yii2#20944
yiisoft/yii2
20,944
58a18a87bfd8e79a3a61f2b1757f77b2629623a1
9893aea1042cd67f661fe0cdb70e90fb4914a1c1
Fix MSSQL `QueryBuilder::renameColumn()` to pass `sp_rename` named arguments and a one-part new column name. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix MSSQL `QueryBuilder::renameColumn()` to pass `sp_rename` named arguments and a one-part new column name.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 2ef5a57ccc7..f7177f83287 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -95,6 +95,7 @@ Yii Framework 2 Change Log\n -...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 2ef5a57ccc7..f7177f83287 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -95,6 +95,7 @@ Yii Framework 2 Change Log - Enh #20941: Modernize MSSQL `yii\db\mssql\Schema` internals and remove dead `unsigned` detection (terabytesoftw) -...
4
6
yiisoft/yii2#20943
yiisoft/yii2
20,943
d649d0b90101e76e0265a558bc67e6f73af9985b
9d25e787f6dc05ccbbec81aca9a9599f8fd3d8bd
Fix MSSQL `QueryBuilder::renameTable()` to call `sp_rename` with string parameters and one-part new table names. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix MSSQL `QueryBuilder::renameTable()` to call `sp_rename` with string parameters and one-part new table names.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Imple...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex f4ca42bbda6..2ef5a57ccc7 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -94,6 +94,7 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s2", "comment": "_๐ŸŽฏ Functional Correctness_ | _๐ŸŸ  Major_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐ŸŒ Web query:\n\n`In SQL Server `sp_rename`, for `@objtype = 'OBJECT'`, must `@newname` be provided as a one-part string value (not a multipart/qualified name)?`\n\n๐Ÿ’ก Result:\n\n...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index f4ca42bbda6..2ef5a57ccc7 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -94,6 +94,7 @@ Yii Framework 2 Change Log - Enh #20939: Replace `strpos()` with `str_contains()` in `yii\db\Schema` quoting methods and fix `quoteValue()` `@pa...
4
6
yiisoft/yii2#20942
yiisoft/yii2
20,942
f7cf36e0e55871ad9f34f400540941e03c58cc57
acd1ae3f18a74ea0c8ab0cf0265b8c862f85cf45
Fix MSSQL `yii\db\mssql\QueryBuilder::alterColumn()` to drop column default, check, and unique constraints before the `ALTER COLUMN` statement, allowing column redefinition on constrained columns without duplicate constraint name errors. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix MSSQL `yii\\db\\mssql\\QueryBuilder::alterColumn()` to drop column default, check, and unique constraints before the `ALTER COLUMN` statement, allowing column ", "scope_files": [ "framework/CHANGELOG.md" ] ...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex b746d6500a0..f4ca42bbda6 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -92,7 +92,8 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s2", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ | _โšก Quick win_\n\n**Drop the same constraint types you recreate.**\n\nLine 156 removes only default constraints, but Lines 178-193 always append new `CHECK`/`UNIQUE` constraints when the builder still carries those modifiers. An `alterColu...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index b746d6500a0..f4ca42bbda6 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -92,7 +92,8 @@ Yii Framework 2 Change Log - Bug #20937: Exclude configurable system schema names from MSSQL `yii\db\Schema::getSchemaNames()` to match the non-...
4
7
yiisoft/yii2#20941
yiisoft/yii2
20,941
eb6de08ff4a6aa63e4f0f5f02c24c6074738a9e1
1cf903c5ce6584aa4a4bcca350191593c150a31d
Modernize MSSQL `yii\db\mssql\Schema` internals and remove dead `unsigned` detection. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Modernize MSSQL `yii\\db\\mssql\\Schema` internals and remove dead `unsigned` detection.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 8d00eb9e8da..b746d6500a0 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -92,6 +92,7 @@ Yii Framework 2 Change Log\n -...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 8d00eb9e8da..b746d6500a0 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -92,6 +92,7 @@ Yii Framework 2 Change Log - Bug #20937: Exclude configurable system schema names from MSSQL `yii\db\Schema::getSchemaNames()` to match the non-...
2
2
yiisoft/yii2#20939
yiisoft/yii2
20,939
733998b2a863e6c39e6389f35a2ab873957009a5
97bbd044b9a83e97ebfb0aa8ae339006afbdd1d0
Replace `strpos()` with `str_contains()` in `yii\db\Schema` quoting methods and fix `quoteValue()` `@param` to `mixed`. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Replace `strpos()` with `str_contains()` in `yii\\db\\Schema` quoting methods and fix `quoteValue()` `@param` to `mixed`.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 6a59bb7b534..8d00eb9e8da 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -91,6 +91,7 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s2", "comment": "_๐Ÿงน Nitpick_ | _๐Ÿ”ต Trivial_ | _โšก Quick win_\n\n**Missing `str_starts_with` import for consistency.**\n\n`str_starts_with()` is used at line 513 but is not included in the function imports. While it will work as a global function in PHP 8+, adding it would maintain consisten...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 6a59bb7b534..8d00eb9e8da 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -91,6 +91,7 @@ Yii Framework 2 Change Log - Chg #20936: Remove redundant `resolveTableNames()` from MSSQL, MySQL, PostgreSQL, and Oracle schema classes; `loadT...
14
16
yiisoft/yii2#20938
yiisoft/yii2
20,938
e67b0c44e8b227b2a5e597c34669b00f66d8cfb4
83366023c601e9f3e6325f87d340d60007c6f707
Fix MSSQL `QueryBuilder::dropConstraintsForColumn()` to drop primary key, foreign key, and table-level check constraints, replacing deprecated `sys.sysconstraints` with modern catalog views. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix MSSQL `QueryBuilder::dropConstraintsForColumn()` to drop primary key, foreign key, and table-level check constraints, replacing deprecated `sys.sysconstrain", "scope_files": [ "framework/CHANGELOG.md" ] }...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 0d5fa53829e..6a59bb7b534 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -90,6 +90,7 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s1", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Use changelog convention and correct change type on Line 93.**\n\nLine 93 should follow the sectionโ€™s `<Type> #<id>:` format and be marked as a bugfix, not enhancement, to match PR `#20938` intent and keep changelog tra...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 0d5fa53829e..6a59bb7b534 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -90,6 +90,7 @@ Yii Framework 2 Change Log - Bug #20935: Fix MSSQL index, foreign key, and constraint metadata lookups for catalog-qualified table names (teraby...
4
4
yiisoft/yii2#20937
yiisoft/yii2
20,937
dce74588f25e6f3f221b571c0466c5787afa5172
7e1b4595c880d4cd677039cc7f82018e8fd19d71
Exclude configurable system schema names from MSSQL `yii\db\Schema::getSchemaNames()` to match the non-system schema contract. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Exclude configurable system schema names from MSSQL `yii\\db\\Schema::getSchemaNames()` to match the non-system schema contract.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", ...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex cecbaa5351b..0d5fa53829e 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -89,6 +89,7 @@ Yii Framework 2 Change Log\n -...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index cecbaa5351b..0d5fa53829e 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -89,6 +89,7 @@ Yii Framework 2 Change Log - Enh #20934: Replace MSSQL `INFORMATION_SCHEMA.TABLES` in `Schema::findTableNames()` and `Schema::findViewNames()` w...
5
5
yiisoft/yii2#20936
yiisoft/yii2
20,936
5c2419a3be165643175da71cb1387e936af772c3
2f6e6dc3aa6b6dace4c62c08db1f6ae5bd350e90
Remove redundant `resolveTableNames()` from MSSQL, MySQL, PostgreSQL, and Oracle schema classes; `loadTableSchema()` now uses `resolveTableName()`. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โœ”๏ธ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Remove redundant `resolveTableNames()` from MSSQL, MySQL, PostgreSQL, and Oracle schema classes; `loadTableSchema()` now uses `resolveTableName()`.", "scope_files": [ "framework/CHANGELOG.md", "framework/UPGR...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md", "framework/UPGRADE-22.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 0143d15d653..cecbaa5351b 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -88,6 +88,7 ...
[ { "subtask_id": "s5", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Use the quote-stripped single-part name here.**\n\nLine 86 falls back to `$name` instead of `$parts[0]`. For unqualified quoted input like `\"MyTable\"`, `TableSchema::$name` keeps the quotes, so the later `ALL_TAB_COLU...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 0143d15d653..cecbaa5351b 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -88,6 +88,7 @@ Yii Framework 2 Change Log - Enh #20933: Replace MSSQL `INFORMATION_SCHEMA.KEY_COLUMN_USAGE` and `TABLE_CONSTRAINTS` in `Schema::findTableConstr...
8
9
yiisoft/yii2#20935
yiisoft/yii2
20,935
2a68575dc822bdbef5795c9a726544dc9afc4b58
a2b067dc4dcd0cfd3df3e9531a0d945d8ec0ab64
Fix MSSQL index, foreign key, and constraint metadata lookups for catalog-qualified table names. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix MSSQL index, foreign key, and constraint metadata lookups for catalog-qualified table names.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex fd5dc0b4840..0143d15d653 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -87,6 +87,7 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s3", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ | _โšก Quick win_\n\n**Ensure fixture cleanup runs on assertion failures.**\n\nCleanup currently runs only on the success path (e.g., Line 216, Line 266, Line 324, Line 366, Line 413, Line 460). If an assertion fails earlier, test tables are ...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index fd5dc0b4840..0143d15d653 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -87,6 +87,7 @@ Yii Framework 2 Change Log - Bug #20931: Fix `yii\caching\DbCache` MSSQL reference schema using the invalid `BLOB` type instead of `varbinary(ma...
4
4
yiisoft/yii2#20934
yiisoft/yii2
20,934
5f5756712dabfb7ab5d9e69d2fc57888dd47aa6a
6634313dcb113c7491801279e38c9010c1a72e65
Replace MSSQL `INFORMATION_SCHEMA.TABLES` in `Schema::findTableNames()` and `Schema::findViewNames()` with catalog-qualified `sys.objects` and `sys.views` catalog views. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Replace MSSQL `INFORMATION_SCHEMA.TABLES` in `Schema::findTableNames()` and `Schema::findViewNames()` with catalog-qualified `sys.objects` and `sys.views` catal", "scope_files": [ "framework/CHANGELOG.md" ] }...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 9717090f1ce..fd5dc0b4840 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -86,6 +86,7 @@ Yii Framework 2 Change Log\n -...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 9717090f1ce..fd5dc0b4840 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -86,6 +86,7 @@ Yii Framework 2 Change Log - Bug #20931: Fix `yii\caching\DbCache` reading PostgreSQL `bytea` cached data as a stream by converting it in `yii\d...
4
4
yiisoft/yii2#20933
yiisoft/yii2
20,933
97bbf066daeb5b3965712bf6bd15f2a5932d7f1a
e0714e7d61706fe9cb1b06655f52c06d454cb617
Replace MSSQL `INFORMATION_SCHEMA.KEY_COLUMN_USAGE` and `TABLE_CONSTRAINTS` in `Schema::findTableConstraints()` with `sys.key_constraints`, and preserve composite key column order with `sys.index_columns.key_ordinal`. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Replace MSSQL `INFORMATION_SCHEMA.KEY_COLUMN_USAGE` and `TABLE_CONSTRAINTS` in `Schema::findTableConstraints()` with `sys.key_constraints`, and preserve composi", "scope_files": [ "framework/CHANGELOG.md" ] }...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex cf5efb0b09b..9717090f1ce 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -85,6 +85,7 @@ Yii Framework 2 Change Log\n -...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index cf5efb0b09b..9717090f1ce 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -85,6 +85,7 @@ Yii Framework 2 Change Log - Chg #19595: Store `yii\web\DbSession` `data` as `varbinary(max)` on MSSQL and cast it through `yii\db\mssql\ColumnS...
4
5
yiisoft/yii2#20932
yiisoft/yii2
20,932
49d41252e91b37aea87054bb5ca00993941d8e24
7329d0eeb9eac513c5de3fadb00034184096be96
Sync to master brach. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/guide/` needed for: Sync to master brach.", "scope_files": [ "docs/guide/caching-data.md", "docs/guide/security-authorization.md", "docs/guide/security-best-practices.md" ] }, { "subtask_id": "s2", "goal":...
[ { "subtask_id": "s1", "scope_files": [ "docs/guide/caching-data.md", "docs/guide/security-authorization.md", "docs/guide/security-best-practices.md" ], "solution_diff": "diff --git a/docs/guide/caching-data.md b/docs/guide/caching-data.md\nindex 89b1e54506b..6add029880c 100644\n---...
[]
diff --git a/docs/guide/caching-data.md b/docs/guide/caching-data.md index 89b1e54506b..6add029880c 100644 --- a/docs/guide/caching-data.md +++ b/docs/guide/caching-data.md @@ -281,6 +281,11 @@ Below is a summary of the available cache dependencies: the dependency associated with the cached data, if there is any, ha...
5
7
yiisoft/yii2#20931
yiisoft/yii2
20,931
bbd8de9c1b01fac1691264230eb4cbe96b52aec4
a8b50ef58f83e149535587b4b05cab39f00479b5
MSSql schema getting identity column fails when crossing databases ### Problem Active record schema inspection fails to identify MSSql identity columns in a specific circumstance. ### What steps will reproduce the problem? Using a CActiveRecord model with MSSql where tableName is something like ``` class Blah...
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: MSSql schema getting identity column fails when crossing databases", "scope_files": [ "framework/CHANGELOG.md", "framework/UPGRADE-22.md" ] }, { "subtask_id": "s2", "goal": "Implement the chan...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md", "framework/UPGRADE-22.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex df16c938709..a376426c642 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -81,6 +81,10...
[ { "subtask_id": "s5", "comment": "_๐Ÿงน Nitpick_ | _๐Ÿ”ต Trivial_ | _โšก Quick win_\n\n**Consider explicit handling of stream read failures.**\n\nIf `stream_get_contents()` fails and returns `false`, the current code falls through to `parent::phpTypecast($value)`, which would likely convert `false` to an empty st...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index df16c938709..a376426c642 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -81,6 +81,10 @@ Yii Framework 2 Change Log - Enh #20923: Add explicit default values to `ColumnSchema` properties in `yii\db`, `yii\db\mssql`, and `yii\db\pgsq...
16
24
yiisoft/yii2#20888
yiisoft/yii2
20,888
d77f4bb160c3a405a91f66da9893b7f617d79093
53ca5c032828766d3b4de391490dc97881cbcbcf
Fix #20261: Preserve modification time when rotating log files | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โŒ | Tests added? | โœ”๏ธ | Breaks BC? | โŒ | Fixed issues | #20261 ## What does this PR do? Preserves the modification time of a log file when `yii\log\FileTarget`...
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix #20261: Preserve modification time when rotating log files", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `framework/log/` needed for...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 9b8f2906284..eecb82c2708 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -18,6 +18,7 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s2", "comment": "`@touch($newFile, $mtime)` runs even when `@copy()` fails. Since `touch()` creates the file when it doesn't exist, a failed copy (I/O error, or a concurrent rotation that unlinks the destination) could leave behind an empty\nrotated file. Gating the touch on a successful co...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 9b8f2906284..eecb82c2708 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -18,6 +18,7 @@ Yii Framework 2 Change Log - Bug #20891: Fix `@property` annotation for `Request::$bodyParams` (mspirkov) - Bug #20889: Remove unreachable PHP ...
3
3
yiisoft/yii2#20930
yiisoft/yii2
20,930
139635be2d0ad344811aedb901655430d8022cb6
e37a601487433ddf6117292d7911bef850954f8a
Add schema providers and enhance schema tests for across databases. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Add schema providers and enhance schema tests for across databases.", "scope_files": [ "composer.lock", "phpstan-baseline.neon" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `te...
[ { "subtask_id": "s1", "scope_files": [ "composer.lock", "phpstan-baseline.neon" ], "solution_diff": "diff --git a/composer.lock b/composer.lock\nindex 2ba14915eb7..73fba923ac7 100644\n--- a/composer.lock\n+++ b/composer.lock\n@@ -389,16 +389,16 @@\n },\n {\n \...
[ { "subtask_id": "s2", "comment": "_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_ | _โšก Quick win_\n\n**Incorrect parameter in refreshTableSchema call.**\n\nLine 222 passes `$testTablePrefix` (a prefix like `\"ty\"`) to `refreshTableSchema()`, but the method expects a table name, not a prefix. This should be `$testTabl...
diff --git a/composer.lock b/composer.lock index 2ba14915eb7..73fba923ac7 100644 --- a/composer.lock +++ b/composer.lock @@ -389,16 +389,16 @@ }, { "name": "composer/composer", - "version": "2.10.0", + "version": "2.10.1", "source": { "t...
19
70
yiisoft/yii2#20929
yiisoft/yii2
20,929
3cbf93b4b003f27438e0d16ef1a121f3ac5da329
36459e36083b06ecf1974a4425371811f02b201f
Fix `yii\db\oci\Schema::insert()` returning only the first primary key value for composite keys, caused by a reused `foreach` reference. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ | Fixed issues | <!-- comma-separated list of tickets # fixed by the PR, ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix `yii\\db\\oci\\Schema::insert()` returning only the first primary key value for composite keys, caused by a reused `foreach` reference.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex c8d49bd0d9e..df16c938709 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -80,6 +80,7 @@ Yii Framework 2 Change Log\n -...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index c8d49bd0d9e..df16c938709 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -80,6 +80,7 @@ Yii Framework 2 Change Log - Enh #20922: Consolidate SQLite data-type conversion into `ColumnSchema::defaultPhpTypecast()` and fix `DEFAULT NULL...
4
4
yiisoft/yii2#20928
yiisoft/yii2
20,928
3ca89c7b91f2dcfb99f43622566674e83ec736d2
3a91ee3753d901c6b9f3e69761e5cefb6741a444
Remove legacy MySQL version support code from `yii\db\mysql\Schema`. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โœ”๏ธ
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/guide/` needed for: Remove legacy MySQL version support code from `yii\\db\\mysql\\Schema`.", "scope_files": [ "docs/guide/db-dao.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `framework/` needed...
[ { "subtask_id": "s1", "scope_files": [ "docs/guide/db-dao.md" ], "solution_diff": "diff --git a/docs/guide/db-dao.md b/docs/guide/db-dao.md\nindex 4249a03157a..2e7519583bf 100644\n--- a/docs/guide/db-dao.md\n+++ b/docs/guide/db-dao.md\n@@ -11,16 +11,12 @@ you have to take extra effort to creat...
[]
diff --git a/docs/guide/db-dao.md b/docs/guide/db-dao.md index 4249a03157a..2e7519583bf 100644 --- a/docs/guide/db-dao.md +++ b/docs/guide/db-dao.md @@ -11,16 +11,12 @@ you have to take extra effort to create a database-agnostic application. In Yii 2.0, DAO supports the following databases out of the box: -- [MySQ...
4
5
yiisoft/yii2#20913
yiisoft/yii2
20,913
a560bc87616ce4334b05ce4619122dd872bd8696
40df4d9f060bd741d97b15a9be191c3e598ed0a7
Hardening: consider safer serialization formats for cache and RBAC storage Yii2 currently uses PHP serialization for some trusted persistence formats, including cache entries with dependencies and RBAC item/rule data. This is expected behavior today and is not directly exploitable through normal Yii APIs: an attacker ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `docs/guide/` needed for: Hardening: consider safer serialization formats for cache and RBAC storage", "scope_files": [ "docs/guide/caching-data.md", "docs/guide/security-authorization.md", "docs/guide/security-best-practices.m...
[ { "subtask_id": "s1", "scope_files": [ "docs/guide/caching-data.md", "docs/guide/security-authorization.md", "docs/guide/security-best-practices.md" ], "solution_diff": "diff --git a/docs/guide/caching-data.md b/docs/guide/caching-data.md\nindex 89b1e54506b..6add029880c 100644\n---...
[ { "subtask_id": "s1", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"== Cache serializer API ==\"\nrg -n -C3 '\\$serializer|serialize\\(|unserialize\\(' framework do...
diff --git a/docs/guide/caching-data.md b/docs/guide/caching-data.md index 89b1e54506b..6add029880c 100644 --- a/docs/guide/caching-data.md +++ b/docs/guide/caching-data.md @@ -281,6 +281,11 @@ Below is a summary of the available cache dependencies: the dependency associated with the cached data, if there is any, ha...
3
5
yiisoft/yii2#20923
yiisoft/yii2
20,923
ba34f48ec0600011280fd5a47149a086c2990ce0
7248b49ef0e89838d4fcce74bc34c1cb722288b0
Add explicit default values to `ColumnSchema` properties in `yii\db`, `yii\db\mssql`, and `yii\db\pgsql`. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Add explicit default values to `ColumnSchema` properties in `yii\\db`, `yii\\db\\mssql`, and `yii\\db\\pgsql`.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Impleme...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 4dab8855cc8..a55f8f17121 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -78,6 +78,7 @@ Yii Framework 2 Change Log\n -...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 4dab8855cc8..a55f8f17121 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -78,6 +78,7 @@ Yii Framework 2 Change Log - Enh #20920: Consolidate Oracle data-type conversion into `ColumnSchema::defaultPhpTypecast()` and fix `CURRENT_TIME...
6
6
yiisoft/yii2#20922
yiisoft/yii2
20,922
8580d5e073fe8f487cc4e82fcb759d80c02fecf1
484ddedb10d9733c58c456bf70ab66db605a71e4
Consolidate SQLite data-type conversion into `ColumnSchema::defaultPhpTypecast()` and fix `DEFAULT NULL` and escaped-quote defaults. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Consolidate SQLite data-type conversion into `ColumnSchema::defaultPhpTypecast()` and fix `DEFAULT NULL` and escaped-quote defaults.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2"...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 239d235bd84..4dab8855cc8 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -77,6 +77,7 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s2", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ | _โšก Quick win_\n\n**Preserve non-string defaults before coercing to SQLite text.**\n\nThis override string-casts every non-null input, so the public `defaultPhpTypecast()` API no longer behaves like the base class for already-typed values ...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 239d235bd84..4dab8855cc8 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -77,6 +77,7 @@ Yii Framework 2 Change Log - Enh #20919: Consolidate MySQL data-type conversion into `ColumnSchema::defaultPhpTypecast()` and preserve explicit ...
4
6
yiisoft/yii2#20921
yiisoft/yii2
20,921
f768e13701ba32a6d557a26e2ba3b9c301c0b122
5bd44e31fb7caa46c6f27fab2190b6927b43e1cb
Consolidate PostgreSQL data-type conversion into `ColumnSchema::defaultPhpTypecast()` and fix `phpTypecastValue()` for native boolean value. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Consolidate PostgreSQL data-type conversion into `ColumnSchema::defaultPhpTypecast()` and fix `phpTypecastValue()` for native boolean value.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_i...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex ce362f02035..239d235bd84 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -33,49 +33,50 @@ Yii Framework 2 Change Log\n...
[ { "subtask_id": "s1", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Add the PR reference in this changelog item.**\n\nPlease include the PR number (e.g., `Enh #<PR_NUMBER>:`) for consistency and traceability in `framework/CHANGELOG.md`. \n \n\nBased on learnings, `framework/CHANGELOG.m...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index ce362f02035..239d235bd84 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -33,49 +33,50 @@ Yii Framework 2 Change Log - Enh #20801: Update PHP `8.3` and PHPUnit `11.5` compatibility (terabytesoftw) - Chg #20804: Remove Yii runtime a...
7
9
yiisoft/yii2#20882
yiisoft/yii2
20,882
fa9bd28bebb2da0540a516cd5e903a5f4b3583c0
b76577b1b0ca285bac4fe7ec39d84c19696b2207
Fix `Sort::createUrl()` and `Pagination::createUrl()` to fall back when no controller is active, supporting standalone actions discovered through `Module::$actionNamespace`. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Fix `Sort::createUrl()` and `Pagination::createUrl()` to fall back when no controller is active, supporting standalone actions discovered through `Module::$acti", "scope_files": [ "composer.lock" ] }, { "s...
[ { "subtask_id": "s1", "scope_files": [ "composer.lock" ], "solution_diff": "diff --git a/composer.lock b/composer.lock\nindex 595956640b4..48ea4d43e72 100644\n--- a/composer.lock\n+++ b/composer.lock\n@@ -1426,11 +1426,11 @@\n },\n {\n \"name\": \"phpstan/phpstan\",...
[ { "subtask_id": "s3", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\n# Verify whether the repo already contains subclasses of Pagination\n# or additional resolveRoute() dec...
diff --git a/composer.lock b/composer.lock index 595956640b4..48ea4d43e72 100644 --- a/composer.lock +++ b/composer.lock @@ -1426,11 +1426,11 @@ }, { "name": "phpstan/phpstan", - "version": "2.1.54", + "version": "2.1.55", "dist": { "typ...
4
6
yiisoft/yii2#20920
yiisoft/yii2
20,920
dd4ad5da511cc181a308e33134be805ac60ff92a
68cc9b7726f29ce7f9c38f10ece38d0417221487
Consolidate Oracle data-type conversion into `ColumnSchema::defaultPhpTypecast()` and fix `CURRENT_TIMESTAMP` defaults returned as `null`. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Consolidate Oracle data-type conversion into `ColumnSchema::defaultPhpTypecast()` and fix `CURRENT_TIMESTAMP` defaults returned as `null`.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id"...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex ed7fa663cfd..ce362f02035 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -75,6 +75,7 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s4", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Make the `NULL` literal check case-insensitive.**\n\nOracle stores `DATA_DEFAULT` text verbatim, so a column defined with lowercase `DEFAULT null` arrives here as `'null'` and bypasses this guard. It then falls through ...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index ed7fa663cfd..ce362f02035 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -75,6 +75,7 @@ Yii Framework 2 Change Log - Bug: Fix `yii\helpers\Url::current()` and `yii\helpers\Url::canonical()` to fall back to `Application::$requestedRo...
9
11
yiisoft/yii2#20919
yiisoft/yii2
20,919
07d7a582d5f29295a341688fa607d9229e8f473b
507ac9e31afbbc08f7b49016195c6d4b1be0da24
Consolidate MySQL data-type conversion into `ColumnSchema::defaultPhpTypecast()` and preserve explicit `CURRENT_TIMESTAMP(0)` default precision. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Consolidate MySQL data-type conversion into `ColumnSchema::defaultPhpTypecast()` and preserve explicit `CURRENT_TIMESTAMP(0)` default precision.", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subta...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 7dda5e33deb..ed7fa663cfd 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -74,6 +74,7 @@ Yii Framework 2 Change Log\n -...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 7dda5e33deb..ed7fa663cfd 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -74,6 +74,7 @@ Yii Framework 2 Change Log - Bug: Fix `Sort::createUrl()` and `Pagination::createUrl()` to fall back when no controller is active, supporting st...
4
6
yiisoft/yii2#20918
yiisoft/yii2
20,918
bb89a9d0526e9286d4559a8e51d43cb51dd66cba
bd90ac83e38cf4a96f5c4985aed2b65f999c4033
Consolidate MSSQL data-type conversion into `ColumnSchema`: harden `defaultPhpTypecast()` for unicode (`N'...'`), escaped quotes, and expression defaults; add `getOutputColumnDeclaration()` used by `QueryBuilder::insert()`. | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Consolidate MSSQL data-type conversion into `ColumnSchema`: harden `defaultPhpTypecast()` for unicode (`N'...'`), escaped quotes, and expression defaults; add `", "scope_files": [ "composer.lock", "phpstan-basel...
[ { "subtask_id": "s1", "scope_files": [ "composer.lock", "phpstan-baseline.neon" ], "solution_diff": "diff --git a/composer.lock b/composer.lock\nindex 48ea4d43e72..2ba14915eb7 100644\n--- a/composer.lock\n+++ b/composer.lock\n@@ -248,16 +248,16 @@\n },\n {\n \...
[ { "subtask_id": "s5", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Add a combined unicode + escaped-quote default case**\n\nThe hardening target includes unicode literals and escaped quotes; add a single case such as `(N'it''s') => \"it's\"` to cover the combined parsing path and preve...
diff --git a/composer.lock b/composer.lock index 48ea4d43e72..2ba14915eb7 100644 --- a/composer.lock +++ b/composer.lock @@ -248,16 +248,16 @@ }, { "name": "composer/ca-bundle", - "version": "1.5.11", + "version": "1.5.12", "source": { "...
5
9
yiisoft/yii2#20917
yiisoft/yii2
20,917
066e168d674268637bb568cd40c31a106a4e1412
32151face43e1e9fb2dcfd65def3161cc1cf458c
Sync to master brach. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/controllers/` needed for: Sync to master brach.", "scope_files": [ "build/controllers/ReleaseController.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `framework/` needed for: Sync to master bra...
[ { "subtask_id": "s1", "scope_files": [ "build/controllers/ReleaseController.php" ], "solution_diff": "diff --git a/build/controllers/ReleaseController.php b/build/controllers/ReleaseController.php\nindex 4ffa7142f05..e7c36cf436a 100644\n--- a/build/controllers/ReleaseController.php\n+++ b/buil...
[]
diff --git a/build/controllers/ReleaseController.php b/build/controllers/ReleaseController.php index 4ffa7142f05..e7c36cf436a 100644 --- a/build/controllers/ReleaseController.php +++ b/build/controllers/ReleaseController.php @@ -854,6 +854,7 @@ protected function openChangelogs($what, $version) protected function ...
6
6
yiisoft/yii2#20895
yiisoft/yii2
20,895
3dea6d59b9a54e1eaa599081ae30bfd4a976d69a
1f4fb57bd147ea7b4870ed260d14197da4da3770
Harden PhpMessageSource category path handling `yii\i18n\PhpMessageSource` builds message file paths from the translation category. Category names intentionally support slash-separated namespaces such as `app/error`, `modules/users/validation`, and `widgets/menu/messages`, but unsafe path segments are currently not re...
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Harden PhpMessageSource category path handling", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `framework/i18n/` needed for: Harden PhpMes...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 4bba8cbfa39..3a9a40dca30 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -16,6 +16,7 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s2", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ | _โšก Quick win_\n\n**Don't overconstrain the first category segment.**\n\nThis regex now rejects safe relative categories whose first segment starts with `.` or `-` (for example, `.messages`), even though they still resolve under `basePath`...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 4bba8cbfa39..3a9a40dca30 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -16,6 +16,7 @@ Yii Framework 2 Change Log - Bug #20891: Fix `@return` annotation for `RequestParserInterface::parse()`, `JsonParser::parse()`, `Request::getBod...
4
4
yiisoft/yii2#20911
yiisoft/yii2
20,911
540c7de68aad91907481f8cb34ba97ae91aec973
2ebf83509323de04076ddf5d9ca9552741595a93
Fix release changelog version detection ## Summary - keep the release command's selected version authoritative - update the active CHANGELOG `under development` section to the selected version before sorting - normalize invalid `Fix #...` changelog entries to canonical `Bug #...` before sorting - fail loudly when no m...
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/controllers/` needed for: Fix release changelog version detection", "scope_files": [ "build/controllers/ReleaseController.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/framework/` needed...
[ { "subtask_id": "s1", "scope_files": [ "build/controllers/ReleaseController.php" ], "solution_diff": "diff --git a/build/controllers/ReleaseController.php b/build/controllers/ReleaseController.php\nindex b5f53881186..e7c36cf436a 100644\n--- a/build/controllers/ReleaseController.php\n+++ b/buil...
[ { "subtask_id": "s1", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ | _โšก Quick win_\n\n**Use exact version-boundary matching when locating the changelog section.**\n\n`splitChangelog()` still uses substring matching for headings. A requested version like `2.0.5` can incorrectly match `2.0.50 ...`, mark the ...
diff --git a/build/controllers/ReleaseController.php b/build/controllers/ReleaseController.php index b5f53881186..e7c36cf436a 100644 --- a/build/controllers/ReleaseController.php +++ b/build/controllers/ReleaseController.php @@ -854,6 +854,7 @@ protected function openChangelogs($what, $version) protected function ...
2
2
yiisoft/yii2#20910
yiisoft/yii2
20,910
dc66de6f7af49927aace4bd778cb1761eba19087
640f803e40ae12a75adbe18ee12c140bb68af05e
Fix changelog sorting when there are fix intries instead of bug | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ | Fixed issues | -
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/controllers/` needed for: Fix changelog sorting when there are fix intries instead of bug", "scope_files": [ "build/controllers/ReleaseController.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `...
[ { "subtask_id": "s1", "scope_files": [ "build/controllers/ReleaseController.php" ], "solution_diff": "diff --git a/build/controllers/ReleaseController.php b/build/controllers/ReleaseController.php\nindex 4ffa7142f05..b5f53881186 100644\n--- a/build/controllers/ReleaseController.php\n+++ b/buil...
[]
diff --git a/build/controllers/ReleaseController.php b/build/controllers/ReleaseController.php index 4ffa7142f05..b5f53881186 100644 --- a/build/controllers/ReleaseController.php +++ b/build/controllers/ReleaseController.php @@ -913,6 +913,7 @@ protected function resortChangelog($changelog) // cleanup whitespa...
2
2
yiisoft/yii2#20903
yiisoft/yii2
20,903
04bb96d928c06b3e12e87ab8100cdefeb0905212
15ddf5a4235ef05fc20e8d4396ec4674556b9db7
Fix `yii\helpers\Url::current()` and `yii\helpers\Url::canonical()` to fall back to `Application::$requestedRoute` when no controller is active, supporting standalone actions. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix `yii\\helpers\\Url::current()` and `yii\\helpers\\Url::canonical()` to fall back to `Application::$requestedRoute` when no controller is active, supporting stan", "scope_files": [ "framework/CHANGELOG.md", ...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md", "framework/UPGRADE-22.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 31153757114..b500b9a0520 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -72,6 +72,7 ...
[ { "subtask_id": "s1", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Use PHP method-call syntax in the route example.**\n\n`parent.runAction('child/ping')` is not valid PHP notation and may mislead readers during migration. Prefer a PHP-style call or explicitly mark it as pseudocode.\n\n...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 31153757114..b500b9a0520 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -72,6 +72,7 @@ Yii Framework 2 Change Log - Chg: Drop dead SQL Server `< 2017` branches from MSSQL `Schema::loadColumnSchema()` (terabytesoftw) - Chg: Drop de...
8
13
yiisoft/yii2#20892
yiisoft/yii2
20,892
1b37da4fd1d4bfd0ab1a23eee5618efd45dbaf96
446ae2532595144a53d3205825e9f5f953f230f6
Sync to master brach. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/controllers/` needed for: Sync to master brach.", "scope_files": [ "build/controllers/MimeTypeController.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `framework/` needed for: Sync to master br...
[ { "subtask_id": "s1", "scope_files": [ "build/controllers/MimeTypeController.php" ], "solution_diff": "diff --git a/build/controllers/MimeTypeController.php b/build/controllers/MimeTypeController.php\nindex d8709cdca6e..2549f67ea23 100644\n--- a/build/controllers/MimeTypeController.php\n+++ b/...
[]
diff --git a/build/controllers/MimeTypeController.php b/build/controllers/MimeTypeController.php index d8709cdca6e..2549f67ea23 100644 --- a/build/controllers/MimeTypeController.php +++ b/build/controllers/MimeTypeController.php @@ -47,6 +47,7 @@ class MimeTypeController extends Controller 'application/bmp' =>...
5
7
yiisoft/yii2#20891
yiisoft/yii2
20,891
1b2fc6812bae97674d885021c64b20f8616710e3
7c76543e65eb30ff3603c7ab6d9133c6b478888c
Fix the types in the PHPDoc annotations for `JsonParser`, `Request`, and `RequestParserInterface` | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ | Fixed issues | <!-- comma-separated list of tickets # fixed by the PR, if any -->
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix the types in the PHPDoc annotations for `JsonParser`, `Request`, and `RequestParserInterface`", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask_id": "s2", "goal": "Implement the change...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex b355f2e7d36..4bba8cbfa39 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -13,6 +13,9 @@ Yii Framework 2 Change Log\n -...
[ { "subtask_id": "s2", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Complete the type-doc update for `bodyParams` to avoid conflicting contracts.**\n\nThese new `mixed` annotations conflict with existing docs that still state `array|object` (Line 44 `@property $bodyParams`, Line 595 `ge...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index b355f2e7d36..4bba8cbfa39 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -13,6 +13,9 @@ Yii Framework 2 Change Log - Bug #20878: Fix `@var` annotation for `yii\db\Query::$from` (mspirkov) - Enh #7616: Add `yii\web\ErrorHandler::EVE...
2
4
yiisoft/yii2#20884
yiisoft/yii2
20,884
7d6cf45aeb1f119cc4e23132190437ce5391cf7f
029a8d30920a8287478561eade0d9ee39c016ab7
Can we add an additional mime-type for RAR? The list of mime-types at https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types and in the framework only includes the `application/x-rar-compressed` type. https://github.com/yiisoft/yii2/blob/22889d314ab4ea20df00e594d4ef7fb09fa55f5a/framework/helpers/mim...
[ { "subtask_id": "s1", "goal": "Implement the changes under `build/controllers/` needed for: Can we add an additional mime-type for RAR?", "scope_files": [ "build/controllers/MimeTypeController.php" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `framework/` needed ...
[ { "subtask_id": "s1", "scope_files": [ "build/controllers/MimeTypeController.php" ], "solution_diff": "diff --git a/build/controllers/MimeTypeController.php b/build/controllers/MimeTypeController.php\nindex d8709cdca6e..2549f67ea23 100644\n--- a/build/controllers/MimeTypeController.php\n+++ b/...
[ { "subtask_id": "s4", "comment": "_๐Ÿงน Nitpick_ | _๐Ÿ”ต Trivial_ | _๐Ÿ’ค Low value_\n\n**Consider adding test cases with `preferShort=true` for completeness.**\n\nWhile the current test cases with `preferShort=false` are correct, adding test cases with `preferShort=true` would provide more comprehensive coverage...
diff --git a/build/controllers/MimeTypeController.php b/build/controllers/MimeTypeController.php index d8709cdca6e..2549f67ea23 100644 --- a/build/controllers/MimeTypeController.php +++ b/build/controllers/MimeTypeController.php @@ -47,6 +47,7 @@ class MimeTypeController extends Controller 'application/bmp' =>...
4
4
yiisoft/yii2#20881
yiisoft/yii2
20,881
2ab8eaf777bff2ba6c942f4d1b77a5929d4246ee
645d7d54f0a1570a0e88e72844141e4a684c6558
Sync to master brach. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Sync to master brach.", "scope_files": [ "composer.lock", "phpstan-baseline.neon", "phpstan.dist.neon" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `docs/guide/` needed f...
[ { "subtask_id": "s1", "scope_files": [ "composer.lock", "phpstan-baseline.neon", "phpstan.dist.neon" ], "solution_diff": "diff --git a/composer.lock b/composer.lock\nindex f9f75af4753..595956640b4 100644\n--- a/composer.lock\n+++ b/composer.lock\n@@ -389,16 +389,16 @@\n },\...
[ { "subtask_id": "s1", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n#!/bin/bash\n# Verify where isMariaDb() is called and what static type is used nearby.\nrg -n -C3 '\\bisMariaDb\\s*\\(' tests/framework/d...
diff --git a/composer.lock b/composer.lock index f9f75af4753..595956640b4 100644 --- a/composer.lock +++ b/composer.lock @@ -389,16 +389,16 @@ }, { "name": "composer/composer", - "version": "2.9.7", + "version": "2.9.8", "source": { "typ...
13
39
yiisoft/yii2#20878
yiisoft/yii2
20,878
ff66e6a8548034043c416b71cbd572ce811e8f23
a75e4ce0bade2864f790126a6aa2b83099167c9e
Analyze the `yiiunit\framework\db` namespace using PHPStan | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โœ”๏ธ | Breaks BC? | โŒ | Fixed issues | <!-- comma-separated list of tickets # fixed by the PR, if any -->
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Analyze the `yiiunit\\framework\\db` namespace using PHPStan", "scope_files": [ "phpstan-baseline-7x.neon", "phpstan.dist.neon" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `fr...
[ { "subtask_id": "s1", "scope_files": [ "phpstan-baseline-7x.neon", "phpstan.dist.neon" ], "solution_diff": "diff --git a/phpstan-baseline-7x.neon b/phpstan-baseline-7x.neon\nindex 13be3e5bae1..6be48e7c140 100644\n--- a/phpstan-baseline-7x.neon\n+++ b/phpstan-baseline-7x.neon\n@@ -77,3 +7...
[ { "subtask_id": "s4", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Fix PHPDoc type mismatch for `orderItems2`.**\n\nLine 37 documents `@property-read Item[] $orderItems2`, but `getOrderItems2()` (Line 104-108) returns `hasMany(OrderItem::class, ...)`. This gives wrong type info to PHPS...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index a1ae1155dc9..d220536ddb5 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -4,11 +4,13 @@ Yii Framework 2 Change Log 2.0.56 under development ------------------------ -- Bug #20783: Fix PHPDoc annotations for the `yii\log\Target::$...
12
37
yiisoft/yii2#20877
yiisoft/yii2
20,877
95d8df577f6d0e49b2b3539b67cbbf8fc8de0514
c360844a44762d80f3c92151e0b136a84a1b6987
Fix #7616: Add `yii\web\ErrorHandler::EVENT_AFTER_RENDER` and `yii\web\ErrorHandlerRenderEvent` to post-process rendered HTML error output | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โœ”๏ธ | Breaks BC? | โŒ | Fixed issues | #7616
[ { "subtask_id": "s1", "goal": "Implement the changes under `framework/` needed for: Fix #7616: Add `yii\\web\\ErrorHandler::EVENT_AFTER_RENDER` and `yii\\web\\ErrorHandlerRenderEvent` to post-process rendered HTML error output", "scope_files": [ "framework/CHANGELOG.md" ] }, { "subtask...
[ { "subtask_id": "s1", "scope_files": [ "framework/CHANGELOG.md" ], "solution_diff": "diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md\nindex 0d83c0d7557..a1ae1155dc9 100644\n--- a/framework/CHANGELOG.md\n+++ b/framework/CHANGELOG.md\n@@ -9,6 +9,7 @@ Yii Framework 2 Change Log\n - B...
[]
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 0d83c0d7557..a1ae1155dc9 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -9,6 +9,7 @@ Yii Framework 2 Change Log - Bug #20785: Fix `@return` annotation for `yii\base\Model::getErrors()` (mspirkov) - Bug #20785: Fix `@var` annotatio...
3
4
yiisoft/yii2#20876
yiisoft/yii2
20,876
532d02f22f4df59ec9cec3a3c8ae27b4585841fa
fd73f904838fd358b2920a4f171d6997545858d5
Sync to master brach. | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Sync to master brach.", "scope_files": [ ".git-blame-ignore-revs", "composer.lock", "phpstan-baseline.neon", "phpstan.dist.neon" ] }, { "subtask_id": "s2", "goal": "Implement the chan...
[ { "subtask_id": "s1", "scope_files": [ ".git-blame-ignore-revs", "composer.lock", "phpstan-baseline.neon", "phpstan.dist.neon" ], "solution_diff": "diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs\nindex ce85e65af96..881b51a65e3 100644\n--- a/.git-blame-ignore-rev...
[ { "subtask_id": "s19", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ | _โšก Quick win_\n\n**Harden savepoint test cleanup to avoid state leakage on failure.**\n\nThis test only deletes inserted data on the happy path. If an assertion/DB call fails earlier, rows can leak and destabilize later tests.\n\n \n<det...
diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index ce85e65af96..881b51a65e3 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -24,3 +24,5 @@ da20adc82aef3eb5ae0bad3889fe6695e6424f06 7a7d2a9c06c099de8064729ca3fc95fb24241b75 # Fixed error PHPCS latest version in `PHP 8.5` f66d5c886471...
35
90
yiisoft/yii2#20875
yiisoft/yii2
20,875
0f5774ae62b22c9724a12e520cea8adb7ac83785
280fd066b1c55490d88bf3e3a72a8ee143dfa4f9
Analyze the `yiiunit\framework\validators` namespace using PHPStan | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โœ”๏ธ | Breaks BC? | โŒ | Fixed issues | <!-- comma-separated list of tickets # fixed by the PR, if any -->
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Analyze the `yiiunit\\framework\\validators` namespace using PHPStan", "scope_files": [ "phpstan.dist.neon" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `build/controllers/` needed f...
[ { "subtask_id": "s1", "scope_files": [ "phpstan.dist.neon" ], "solution_diff": "diff --git a/phpstan.dist.neon b/phpstan.dist.neon\nindex c369f29ed19..608efda39af 100644\n--- a/phpstan.dist.neon\n+++ b/phpstan.dist.neon\n@@ -5,6 +5,8 @@ includes:\n parameters:\n level: 3\n \n+ reportIgn...
[ { "subtask_id": "s6", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Document `attr_image` and `attr_images` too for PHPStan completeness.**\n\nThe docblock omits two dynamic `attr*` fields that are actively used in `rules()` (`attr_image`, `attr_images`). Adding them keeps the dynamic-p...
diff --git a/build/controllers/PhpDocController.php b/build/controllers/PhpDocController.php index b0da27b75ad..bc4f3ea5f09 100644 --- a/build/controllers/PhpDocController.php +++ b/build/controllers/PhpDocController.php @@ -713,13 +713,14 @@ protected function updateDocComment($doc, $properties, $className) ...
9
25
yiisoft/yii2#20874
yiisoft/yii2
20,874
fad5fd58eb61e4bf937db4646bf2389f7f32f1dd
98c8351236517d49aba592befd3e20c520c87d8f
Analyze more tests using PHPStan | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โŒ | Breaks BC? | โŒ | Fixed issues | <!-- comma-separated list of tickets # fixed by the PR, if any -->
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Analyze more tests using PHPStan", "scope_files": [ "phpstan.dist.neon" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/framework/grid/` needed for: Analyze more tests using PHPS...
[ { "subtask_id": "s1", "scope_files": [ "phpstan.dist.neon" ], "solution_diff": "diff --git a/phpstan.dist.neon b/phpstan.dist.neon\nindex 51e87b57398..c369f29ed19 100644\n--- a/phpstan.dist.neon\n+++ b/phpstan.dist.neon\n@@ -17,9 +17,6 @@ parameters:\n - tests/framework/*/mocks/*\n...
[ { "subtask_id": "s4", "comment": "_๐Ÿงน Nitpick_ | _๐Ÿ”ต Trivial_ | _โšก Quick win_\n\n**Add explicit return type for PHPStan compliance.**\n\nThe `customError()` method should declare its return type as `:string` to improve static analysis and code clarity, aligning with the PR's goal of PHPStan compliance.\n\n\...
diff --git a/phpstan.dist.neon b/phpstan.dist.neon index 51e87b57398..c369f29ed19 100644 --- a/phpstan.dist.neon +++ b/phpstan.dist.neon @@ -17,9 +17,6 @@ parameters: - tests/framework/*/mocks/* # TODO: Analyze these directories - tests/framework/db - - tests/framework/...
5
13
yiisoft/yii2#20873
yiisoft/yii2
20,873
f52efd863a5b91939844280d8e9385d20fe3271f
3810dbf11837fa8405cac8eba30a6fcb1abf8ec3
Analyze the `yiiunit\framework\log` namespace using PHPStan | Q | A | ------------- | --- | Is bugfix? | โœ”๏ธ | New feature? | โŒ | Breaks BC? | โŒ | Fixed issues | <!-- comma-separated list of tickets # fixed by the PR, if any -->
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Analyze the `yiiunit\\framework\\log` namespace using PHPStan", "scope_files": [ "phpstan.dist.neon" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `framework/` needed for: Analyze the...
[ { "subtask_id": "s1", "scope_files": [ "phpstan.dist.neon" ], "solution_diff": "diff --git a/phpstan.dist.neon b/phpstan.dist.neon\nindex 20abc47d15b..51e87b57398 100644\n--- a/phpstan.dist.neon\n+++ b/phpstan.dist.neon\n@@ -20,7 +20,6 @@ parameters:\n - tests/framework/grid\n ...
[ { "subtask_id": "s2", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ | _โšก Quick win_\n\n**Add the missing list marker for the new changelog item.**\n\nLine 7 should use the same bullet-list format as other entries (`- ...`) to keep changelog formatting consistent.\n\n \n\n<details>\n<summary>Suggested fix</s...
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md index 27b0954258b..2296dfc0938 100644 --- a/framework/CHANGELOG.md +++ b/framework/CHANGELOG.md @@ -4,7 +4,7 @@ Yii Framework 2 Change Log 2.0.56 under development ------------------------ -- no changes in this release. +- Bug #20783: Fix PHPDoc annotatio...
5
10
yiisoft/yii2#20786
yiisoft/yii2
20,786
cef4122784b39a2e4aae6b65a8e2b5c508f1afa2
e7f28131f4cf0688070ccfda579a1d6046897a45
Add unit tests for mutex classes | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โŒ | Tests added? | โœ”๏ธ | Breaks BC? | โŒ | Fixed issues | ## What does this PR do? Adds unit tests for `Mutex`, `DbMutex`, and `OracleMutex`. ### Coverage | File | Tests | Lines | MSI |...
[ { "subtask_id": "s1", "goal": "Implement the changes under `tests/framework/mutex/` needed for: Add unit tests for mutex classes", "scope_files": [ "tests/framework/mutex/DbMutexTest.php", "tests/framework/mutex/MutexTest.php", "tests/framework/mutex/OracleMutexTest.php" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "tests/framework/mutex/DbMutexTest.php", "tests/framework/mutex/MutexTest.php", "tests/framework/mutex/OracleMutexTest.php" ], "solution_diff": "diff --git a/tests/framework/mutex/DbMutexTest.php b/tests/framework/mutex/DbMutexTest.php\nnew fi...
[]
diff --git a/tests/framework/mutex/DbMutexTest.php b/tests/framework/mutex/DbMutexTest.php new file mode 100644 index 00000000000..3392c9ac549 --- /dev/null +++ b/tests/framework/mutex/DbMutexTest.php @@ -0,0 +1,72 @@ +<?php + +/** + * @link https://www.yiiframework.com/ + * @copyright Copyright (c) 2008 Yii Software ...
1
3
yiisoft/yii2#20795
yiisoft/yii2
20,795
a271aeee800a3e5dcda705180e72f3168973b7aa
583dfe6e06550015f221383fa0f0f8f9d7f4d2be
Strengthen MSSQL `QueryBuilderTest` and `SchemaTest` coverage | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โŒ | Tests added? | โœ”๏ธ | Breaks BC? | โŒ | Fixed issues | ## What does this PR do? Adds tests for previously uncovered methods in MSSQL QueryBuilder, Schema and I...
[ { "subtask_id": "s1", "goal": "Implement the changes under `tests/framework/db/mssql/` needed for: Strengthen MSSQL `QueryBuilderTest` and `SchemaTest` coverage", "scope_files": [ "tests/framework/db/mssql/QueryBuilderTest.php", "tests/framework/db/mssql/SchemaTest.php" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "tests/framework/db/mssql/QueryBuilderTest.php", "tests/framework/db/mssql/SchemaTest.php" ], "solution_diff": "diff --git a/tests/framework/db/mssql/QueryBuilderTest.php b/tests/framework/db/mssql/QueryBuilderTest.php\nindex 3d626dacd58..6624729524...
[]
diff --git a/tests/framework/db/mssql/QueryBuilderTest.php b/tests/framework/db/mssql/QueryBuilderTest.php index 3d626dacd58..6624729524b 100644 --- a/tests/framework/db/mssql/QueryBuilderTest.php +++ b/tests/framework/db/mssql/QueryBuilderTest.php @@ -855,4 +855,159 @@ public static function buildFromDataProvider(): ...
1
2
yiisoft/yii2#20872
yiisoft/yii2
20,872
8d024ec5bed740af370f93782a75c1241d382f5b
3e46c59446d107631c900122ef33ed6a2c6a3030
Analyze more tests using PHPStan | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โŒ | Breaks BC? | โŒ | Fixed issues | <!-- comma-separated list of tickets # fixed by the PR, if any -->
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Analyze more tests using PHPStan", "scope_files": [ "phpstan.dist.neon" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `tests/framework/base/` needed for: Analyze more tests using PHPS...
[ { "subtask_id": "s1", "scope_files": [ "phpstan.dist.neon" ], "solution_diff": "diff --git a/phpstan.dist.neon b/phpstan.dist.neon\nindex 4f6666327d7..20abc47d15b 100644\n--- a/phpstan.dist.neon\n+++ b/phpstan.dist.neon\n@@ -13,25 +13,14 @@ parameters:\n excludePaths:\n analyse:\n ...
[ { "subtask_id": "s7", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ | _โšก Quick win_\n\n**Docblock types for `$pagination`/`$sort` are incorrect for actual data-provider inputs.**\n\nOn Line 75 and Line 76, both params are documented as `array`, but this test also passes `Pagination|false` and `Sort|false`. ...
diff --git a/phpstan.dist.neon b/phpstan.dist.neon index 4f6666327d7..20abc47d15b 100644 --- a/phpstan.dist.neon +++ b/phpstan.dist.neon @@ -13,25 +13,14 @@ parameters: excludePaths: analyse: - tests/data - - tests/framework/base/stub - - tests/framework/console/stubs - ...
8
15
yiisoft/yii2#20871
yiisoft/yii2
20,871
d0a0f0f93e8a382549775ae5970e193bda1bc5b8
9c520a46189032b5b5a9c5dd6c1e54fcdaa99c90
Analyze the `yiiunit\framework\web` and `yiiunit\framework\widgets` namespaces using PHPStan | Q | A | ------------- | --- | Is bugfix? | โŒ | New feature? | โŒ | Breaks BC? | โŒ | Fixed issues | <!-- comma-separated list of tickets # fixed by the PR, if any -->
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Analyze the `yiiunit\\framework\\web` and `yiiunit\\framework\\widgets` namespaces using PHPStan", "scope_files": [ "phpstan.dist.neon" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `...
[ { "subtask_id": "s1", "scope_files": [ "phpstan.dist.neon" ], "solution_diff": "diff --git a/phpstan.dist.neon b/phpstan.dist.neon\nindex 4728321b2fe..4f6666327d7 100644\n--- a/phpstan.dist.neon\n+++ b/phpstan.dist.neon\n@@ -14,8 +14,11 @@ parameters:\n analyse:\n - tests/d...
[ { "subtask_id": "s1", "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ | _๐Ÿ—๏ธ Heavy lift_\n\n**New exclusions contradict the PRโ€™s analysis scope.**\n\nAdding `tests/framework/web/mocks` and `tests/framework/web/stubs` to `excludePaths.analyse` narrows analysis for the exact `web` area this PR is meant to cover...
diff --git a/phpstan.dist.neon b/phpstan.dist.neon index 4728321b2fe..4f6666327d7 100644 --- a/phpstan.dist.neon +++ b/phpstan.dist.neon @@ -14,8 +14,11 @@ parameters: analyse: - tests/data - tests/framework/base/stub + - tests/framework/console/stubs - tests/f...
8
27
yt-dlp/yt-dlp#16948
yt-dlp/yt-dlp
16,948
9055188250348c3e6e29eee53e5fb3dc2c951977
6e6bbb28ac54af9c9ba05de637160d9824ebae42
[youtube] yt-dlp occasionally only fetches the first 100 vids of a playlist ### Checklist - [x] I'm reporting that yt-dlp is broken on a **supported** site - [x] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels)) - [x] I've check...
[ { "subtask_id": "s1", "goal": "Implement the changes under `yt_dlp/extractor/youtube/` needed for: [youtube] yt-dlp occasionally only fetches the first 100 vids of a playlist", "scope_files": [ "yt_dlp/extractor/youtube/_base.py", "yt_dlp/extractor/youtube/_tab.py" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "yt_dlp/extractor/youtube/_base.py", "yt_dlp/extractor/youtube/_tab.py" ], "solution_diff": "diff --git a/yt_dlp/extractor/youtube/_base.py b/yt_dlp/extractor/youtube/_base.py\nindex d3e4ab11767e..59a470ff6d81 100644\n--- a/yt_dlp/extractor/youtube/...
[ { "subtask_id": "s1", "comment": "fyi: creepy bible banger channel got taken down", "revised_diff": "diff --git a/yt_dlp/extractor/youtube/_tab.py b/yt_dlp/extractor/youtube/_tab.py\nindex 78d5e5b6088a..197231daff91 100644\n--- a/yt_dlp/extractor/youtube/_tab.py\n+++ b/yt_dlp/extractor/youtube/_tab.py\n...
diff --git a/yt_dlp/extractor/youtube/_base.py b/yt_dlp/extractor/youtube/_base.py index d3e4ab11767e..59a470ff6d81 100644 --- a/yt_dlp/extractor/youtube/_base.py +++ b/yt_dlp/extractor/youtube/_base.py @@ -1037,8 +1037,10 @@ def _extract_continuation(cls, renderer): return next_continuation ret...
1
2
yt-dlp/yt-dlp#16931
yt-dlp/yt-dlp
16,931
707537a03946fbc5707e22be429545c670cd8ec2
7ce44d0916125e6c71d910288cf0c5223806661d
[utils] Deprecate `make_dir` in favor of `make_parent_dirs` <!-- **IMPORTANT**: PRs without the template will be CLOSED Due to the high volume of pull requests, it may be a while before your PR is reviewed. Please try to keep your pull request focused on a single bugfix or new feature. Pull r...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [utils] Deprecate `make_dir` in favor of `make_parent_dirs`", "scope_files": [ "pyproject.toml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `yt_dlp/` needed for: [utils] Deprecate `...
[ { "subtask_id": "s1", "scope_files": [ "pyproject.toml" ], "solution_diff": "diff --git a/pyproject.toml b/pyproject.toml\nindex 8128fb31a85a..ccbfa74404e5 100644\n--- a/pyproject.toml\n+++ b/pyproject.toml\n@@ -395,6 +395,7 @@ banned-from = [\n \"yt_dlp.utils.bytes_to_intlist\".msg = \"Use `l...
[ { "subtask_id": "s4", "comment": "can move this to `yt_dlp.utils._deprecated`, have it import `make_parent_dirs` locally, and add it to `tool.ruff.flake8-tidy-import.banned-api` in pyproject.toml", "revised_diff": "diff --git a/yt_dlp/utils/_utils.py b/yt_dlp/utils/_utils.py\nindex 43ee53729ebb..4cc7a76...
diff --git a/pyproject.toml b/pyproject.toml index 8128fb31a85a..ccbfa74404e5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -395,6 +395,7 @@ banned-from = [ "yt_dlp.utils.bytes_to_intlist".msg = "Use `list` instead." "yt_dlp.utils.intlist_to_bytes".msg = "Use `bytes` instead." "yt_dlp.utils.jwt_encode_hs256".m...
4
5
yt-dlp/yt-dlp#3435
yt-dlp/yt-dlp
3,435
afac4caa7db30804bebac33e53c3cb0237958224
c8d5c5ee3bd7d1a86d73c1537f6ca090ab5a06e6
add '--client-certificate some.pem' to authenticate a site user to the remote machine ### Checklist - [X] I'm reporting a feature request - [X] I've looked through the [README](https://github.com/yt-dlp/yt-dlp#readme) - [X] I've verified that I'm running yt-dlp version **2022.03.08.1** ([update instructions](https://...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: add '--client-certificate some.pem' to authenticate a site user to the remote machine", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: ...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 448b5c884f19..f8813cbb6dcd 100644\n--- a/README.md\n+++ b/README.md\n@@ -840,6 +840,15 @@ You can also fork the project on github and run your fork's [build workflow](.gi\n ...
[ { "subtask_id": "s1", "comment": "imo, it should be `--client-certificate`, `--client-certificate-key`, `--client-certificate-password`.\r\n\r\nAlso, it would be great if password (if not given) can be obtained from netrc", "revised_diff": "diff --git a/README.md b/README.md\nindex 448b5c884f19..f8813cb...
diff --git a/README.md b/README.md index 448b5c884f19..f8813cbb6dcd 100644 --- a/README.md +++ b/README.md @@ -840,6 +840,15 @@ You can also fork the project on github and run your fork's [build workflow](.gi interactively --ap-list-mso List all supported mu...
4
16
yt-dlp/yt-dlp#16930
yt-dlp/yt-dlp
16,930
e47691215f75fe7e9684080d17fadf340c9a8450
519ccdf6a558cf8caf981ce1df1747a2fcccb09c
[utils] Fix `HTTPHeaderDict.__ior__` <!-- **IMPORTANT**: PRs without the template will be CLOSED Due to the high volume of pull requests, it may be a while before your PR is reviewed. Please try to keep your pull request focused on a single bugfix or new feature. Pull requests with a vast sco...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/` needed for: [utils] Fix `HTTPHeaderDict.__ior__`", "scope_files": [ "test/test_utils.py" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `yt_dlp/utils/` needed for: [utils] Fix `HTTPHeaderDict.__ior_...
[ { "subtask_id": "s1", "scope_files": [ "test/test_utils.py" ], "solution_diff": "diff --git a/test/test_utils.py b/test/test_utils.py\nindex cd0fb0f2e970..8f86d151b28c 100644\n--- a/test/test_utils.py\n+++ b/test/test_utils.py\n@@ -2172,6 +2172,10 @@ def test_http_header_dict(self):\n ...
[]
diff --git a/yt_dlp/utils/networking.py b/yt_dlp/utils/networking.py index 32c7acdb1483..33cca412dc38 100644 --- a/yt_dlp/utils/networking.py +++ b/yt_dlp/utils/networking.py @@ -64,7 +64,7 @@ def __ior__(self, other, /): other = other.sensitive() if isinstance(other, dict): self.upda...
2
2
yt-dlp/yt-dlp#16920
yt-dlp/yt-dlp
16,920
7f7bdc974dc61d941d1a0d51c4e21a0fdb7b2d06
d3bd1b8cc344064ceb6b69b3ee11c308c01e57ed
compat-options allow-unsafe-ext errors yt-dlp ### Checklist - [x] I'm reporting a bug unrelated to a specific site - [x] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels)) - [x] I've searched [known issues](https://github.com/yt-...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/` needed for: compat-options allow-unsafe-ext errors yt-dlp", "scope_files": [ "test/test_utils.py" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `yt_dlp/` needed for: compat-options allow-unsafe-ext...
[ { "subtask_id": "s1", "scope_files": [ "test/test_utils.py" ], "solution_diff": "diff --git a/test/test_utils.py b/test/test_utils.py\nindex 180ede624077..cd0fb0f2e970 100644\n--- a/test/test_utils.py\n+++ b/test/test_utils.py\n@@ -327,6 +327,12 @@ def test_prepend_extension(self):\n ...
[]
diff --git a/yt_dlp/__init__.py b/yt_dlp/__init__.py index 18cf4c8d2c3f..ec3d52755dc6 100644 --- a/yt_dlp/__init__.py +++ b/yt_dlp/__init__.py @@ -619,7 +619,7 @@ def report_conflict(arg1, opt1, arg2='--allow-unplayable-formats', opt2='allow_u warnings.append( 'Using allow-unsafe-ext opens you up ...
3
3
yt-dlp/yt-dlp#16697
yt-dlp/yt-dlp
16,697
25056f0d2d47adbd235a8d422fa62d68d0be2bc2
1aeef222c575ee7a036520f138c1f7089e44713d
[cleanup] Misc <!-- **IMPORTANT**: PRs without the template will be CLOSED Due to the high volume of pull requests, it may be a while before your PR is reviewed. Please try to keep your pull request focused on a single bugfix or new feature. Pull requests with a vast scope and/or very large d...
[ { "subtask_id": "s1", "goal": "Implement the changes under `devscripts/` needed for: [cleanup] Misc", "scope_files": [ "devscripts/changelog_override.json", "devscripts/update_requirements.py" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for:...
[ { "subtask_id": "s1", "scope_files": [ "devscripts/changelog_override.json", "devscripts/update_requirements.py" ], "solution_diff": "diff --git a/devscripts/changelog_override.json b/devscripts/changelog_override.json\nindex 937a8880bc8f..7ff3a6caa0fc 100644\n--- a/devscripts/changelog_...
[]
diff --git a/devscripts/changelog_override.json b/devscripts/changelog_override.json index 937a8880bc8f..7ff3a6caa0fc 100644 --- a/devscripts/changelog_override.json +++ b/devscripts/changelog_override.json @@ -342,5 +342,30 @@ "action": "add", "when": "1fbbe29b99dc61375bf6d786f824d9fcf6ea9c1a", ...
4
7
yt-dlp/yt-dlp#16137
yt-dlp/yt-dlp
16,137
e85da3b98532761573d8b48ccd4d8d28dee94b15
e8dddb9176c3a15a7d692b0ab71462b22a01140c
hketv: unable to extract file ID ### Checklist - [X] I'm reporting a broken site - [X] I've verified that I'm running yt-dlp version **2022.02.03**. ([update instructions](https://github.com/yt-dlp/yt-dlp#update)) - [X] I've checked that all provided URLs are alive and playable in a browser - [X] I've checked th...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/` needed for: hketv: unable to extract file ID", "scope_files": [ "test/test_subtitles.py" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `yt_dlp/extractor/` needed for: hketv: unable to extract file ...
[ { "subtask_id": "s1", "scope_files": [ "test/test_subtitles.py" ], "solution_diff": "diff --git a/test/test_subtitles.py b/test/test_subtitles.py\nindex 53e0b4eaf8dc..32e80df952c0 100644\n--- a/test/test_subtitles.py\n+++ b/test/test_subtitles.py\n@@ -16,7 +16,6 @@\n CeskaTelevizeIE,\n ...
[ { "subtask_id": "s2", "comment": "it calls a non-existent `_extract_video_info` method now\r\n```suggestion\r\n _WORKING = False\r\n IE_DESC = 'VGTV, BTTV, FTV, Aftenposten and Aftonbladet'\r\n```", "revised_diff": "diff --git a/yt_dlp/extractor/vgtv.py b/yt_dlp/extractor/vgtv.py\nindex 1eb25530f8...
diff --git a/yt_dlp/extractor/_extractors.py b/yt_dlp/extractor/_extractors.py index 1a29a93edaf8..f47a36099a12 100644 --- a/yt_dlp/extractor/_extractors.py +++ b/yt_dlp/extractor/_extractors.py @@ -54,7 +54,6 @@ WyborczaPodcastIE, WyborczaVideoIE, ) -from .airtv import AirTVIE from .aitube import AitubeKZV...
2
96
yt-dlp/yt-dlp#16827
yt-dlp/yt-dlp
16,827
bc90c36b139c87cdc59399561dc1650198047a72
83c32f03861755dc7feb23d798f9317cc235157b
Extract supplemental codecs from DASH manifests <!-- **IMPORTANT**: PRs without the template will be CLOSED Due to the high volume of pull requests, it may be a while before your PR is reviewed. Please try to keep your pull request focused on a single bugfix or new feature. Pull requests with...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/` needed for: Extract supplemental codecs from DASH manifests", "scope_files": [ "test/test_InfoExtractor.py" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/testdata/mpd/` needed for: Extract su...
[ { "subtask_id": "s1", "scope_files": [ "test/test_InfoExtractor.py" ], "solution_diff": "diff --git a/test/test_InfoExtractor.py b/test/test_InfoExtractor.py\nindex f66fdbf8da6f..63aef689a14f 100644\n--- a/test/test_InfoExtractor.py\n+++ b/test/test_InfoExtractor.py\n@@ -1415,6 +1415,51 @@ def...
[]
diff --git a/yt_dlp/extractor/common.py b/yt_dlp/extractor/common.py index 31c0266d4a9d..048c542858e5 100644 --- a/yt_dlp/extractor/common.py +++ b/yt_dlp/extractor/common.py @@ -2970,6 +2970,8 @@ def extract_Initialization(source): content_type = representation_attrib.get('contentType', mime_type....
3
3
yt-dlp/yt-dlp#16782
yt-dlp/yt-dlp
16,782
10b54835cf3f0d63cdd964a2f411db8f7cac3ff1
32724e2ac3f0b7449e0be95536b88045345a11de
[ci] Update 3 actions in 9 workflows <!-- BEGIN dlp-bot generated section --> Updated with `--exclude-newer 2026-06-08T13:09:14.108419Z` action | old | new | diff -------|-----|-----|----- [**`actions/checkout`**](<https://github.com/actions/checkout>) | [v6.0.***2***](<https://github.com/actions/checkout/releases/t...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [ci] Update 3 actions in 9 workflows", "scope_files": [ ".github/workflows/build.yml", ".github/workflows/challenge-tests.yml", ".github/workflows/codeql.yml", ".github/workflows/core.yml"...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/build.yml", ".github/workflows/challenge-tests.yml", ".github/workflows/codeql.yml", ".github/workflows/core.yml", ".github/workflows/quick-test.yml", ".github/workflows/release-nightly.yml", ".github/workflo...
[]
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a45a4b4e158f..37bbd65893bb 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -195,7 +195,7 @@ jobs: UPDATE_TO: yt-dlp/yt-dlp@2025.09.05 steps: - - uses: actions/checkout@de0fac2e4500dabe0009e67214...
1
9
yt-dlp/yt-dlp#16903
yt-dlp/yt-dlp
16,903
1e4668e9df78ff2409e139b51610442cbefe762e
7fe27c4d1aba6b6d25fc715f96870dfbd8517e89
[build] Update 12 dependencies <!-- BEGIN dlp-bot generated section --> package | old | new | diff | changelog --------|-----|-----|------|---------- [**`certifi`**](<https://pypi.org/project/certifi/>) | [2026.***4.22***](<https://github.com/certifi/python-certifi/releases/tag/2026.04.22>) | [2026.***5.20***](<https...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [build] Update 12 dependencies", "scope_files": [ "pyproject.toml", "uv.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `bundle/requirements/` needed for: [build] Update 12 ...
[ { "subtask_id": "s1", "scope_files": [ "pyproject.toml", "uv.lock" ], "solution_diff": "diff --git a/pyproject.toml b/pyproject.toml\nindex b2f8a007335b..8128fb31a85a 100644\n--- a/pyproject.toml\n+++ b/pyproject.toml\n@@ -69,9 +69,9 @@ deno = [\n pin = [\n \"brotli==1.2.0 ; implemen...
[]
diff --git a/bundle/requirements/build.txt b/bundle/requirements/build.txt index 16068a0eb5f9..00850201a6c8 100644 --- a/bundle/requirements/build.txt +++ b/bundle/requirements/build.txt @@ -81,11 +81,11 @@ tomli==2.4.1 ; python_full_version < '3.11' \ # via # build # hatchling -trove-classifiers==20...
2
12
yt-dlp/yt-dlp#16589
yt-dlp/yt-dlp
16,589
98e42eb04486e00bf86479b24dbfe19321f652ee
0415640523afcfb97dbf5e87e1cd4459b341f212
[build] Update 14 dependencies <!-- BEGIN dlp-bot generated section --> package | old | new | diff | changelog --------|-----|-----|------|---------- [**`build`**](<https://pypi.org/project/build/>) | [1.***4.4***](<https://github.com/pypa/build/releases/tag/1.4.4>) | [1.***5.0***](<https://github.com/pypa/build/rele...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [build] Update 14 dependencies", "scope_files": [ "pyproject.toml", "uv.lock" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `bundle/requirements/` needed for: [build] Update 14 ...
[ { "subtask_id": "s1", "scope_files": [ "pyproject.toml", "uv.lock" ], "solution_diff": "diff --git a/pyproject.toml b/pyproject.toml\nindex dcc67352b813..b2f8a007335b 100644\n--- a/pyproject.toml\n+++ b/pyproject.toml\n@@ -71,11 +71,11 @@ pin = [\n \"brotlicffi==1.2.0.1 ; implementat...
[]
diff --git a/bundle/requirements/build.txt b/bundle/requirements/build.txt index 3b3830cd7806..16068a0eb5f9 100644 --- a/bundle/requirements/build.txt +++ b/bundle/requirements/build.txt @@ -1,6 +1,6 @@ -build==1.4.4 \ - --hash=sha256:8c3f48a6090b39edec1a273d2d57949aaf13723b01e02f9d518396887519f64d \ - --hash=sha...
2
16
yt-dlp/yt-dlp#16883
yt-dlp/yt-dlp
16,883
7aac95eae663be82cffeaf2a8c1193a5e349e401
4431ce9d64b78b4cbdf94fc3420201e81b28220d
[pp/exec] Restrict `--exec` template usage to safe conversions Remove `--exec` footguns by restricting the conversions and default/placeholder values that are able to be used in the `exec` command template. Previously, the user was able to pass something like this: ``` --exec 'echo "%(title)s"' ``` This could y...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [pp/exec] Restrict `--exec` template usage to safe conversions", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/` needed for: [pp/exec] Restrict `--e...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 09e290b89dbc..e334bec8ed41 100644\n--- a/README.md\n+++ b/README.md\n@@ -2332,8 +2332,8 @@ Some of yt-dlp's default options are different from that of youtube-dl and youtu\n * `cer...
[ { "subtask_id": "s3", "comment": "do we want to allow `'S'` (filename-sanitized)?", "revised_diff": "diff --git a/yt_dlp/YoutubeDL.py b/yt_dlp/YoutubeDL.py\nindex 7db6303d4fda..8ce01d52335b 100644\n--- a/yt_dlp/YoutubeDL.py\n+++ b/yt_dlp/YoutubeDL.py\n@@ -112,6 +112,7 @@\n RejectedVideoReached,\n ...
diff --git a/README.md b/README.md index 09e290b89dbc..e334bec8ed41 100644 --- a/README.md +++ b/README.md @@ -2332,8 +2332,8 @@ Some of yt-dlp's default options are different from that of youtube-dl and youtu * `certifi` will be used for SSL root certificates, if installed. If you want to use system certificates (e.g...
5
7
yt-dlp/yt-dlp#16896
yt-dlp/yt-dlp
16,896
7fdc46d01619afbb2371b0465d6830602013148f
c1e68c43dd875ff23897f45cf5c6d5250b9b5ba5
[ci] Test with Python 3.15 <details open><summary>Template</summary> <!-- OPEN is intentional --> ### Before submitting a *pull request* make sure you have: - [x] At least skimmed through [contributing guidelines](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#developer-instructions) including [yt-...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [ci] Test with Python 3.15", "scope_files": [ ".github/workflows/challenge-tests.yml", ".github/workflows/core.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/challenge-tests.yml", ".github/workflows/core.yml" ], "solution_diff": "diff --git a/.github/workflows/challenge-tests.yml b/.github/workflows/challenge-tests.yml\nindex f55cf68f47d0..7f0f7078f6d1 100644\n--- a/.github/workflows/c...
[]
diff --git a/.github/workflows/challenge-tests.yml b/.github/workflows/challenge-tests.yml index f55cf68f47d0..7f0f7078f6d1 100644 --- a/.github/workflows/challenge-tests.yml +++ b/.github/workflows/challenge-tests.yml @@ -36,7 +36,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-l...
1
2
yt-dlp/yt-dlp#2222
yt-dlp/yt-dlp
2,222
fdeab99eaba64317f4c72ba6384da98f1c4f2687
d3c074036e1e527e20d6b516a2c6da4134e1bff4
[openrec] support movie URLs ### Checklist - [X] I'm reporting a site feature request - [X] I've verified that I'm running yt-dlp version **2021.12.27**. ([update instructions](https://github.com/yt-dlp/yt-dlp#update)) - [X] I've checked that all provided URLs are alive and playable in a browser - [X] I've searc...
[ { "subtask_id": "s1", "goal": "Implement the changes under `yt_dlp/extractor/` needed for: [openrec] support movie URLs", "scope_files": [ "yt_dlp/extractor/extractors.py", "yt_dlp/extractor/openrec.py" ] } ]
[ { "subtask_id": "s1", "scope_files": [ "yt_dlp/extractor/extractors.py", "yt_dlp/extractor/openrec.py" ], "solution_diff": "diff --git a/yt_dlp/extractor/extractors.py b/yt_dlp/extractor/extractors.py\nindex 77d6ef511de4..02236bf6796b 100644\n--- a/yt_dlp/extractor/extractors.py\n+++ b/y...
[]
diff --git a/yt_dlp/extractor/extractors.py b/yt_dlp/extractor/extractors.py index 77d6ef511de4..02236bf6796b 100644 --- a/yt_dlp/extractor/extractors.py +++ b/yt_dlp/extractor/extractors.py @@ -1058,6 +1058,7 @@ from .openrec import ( OpenRecIE, OpenRecCaptureIE, + OpenRecMovieIE, ) from .ora import Or...
1
2
yt-dlp/yt-dlp#624
yt-dlp/yt-dlp
624
888299e6ca65009e8ae2809c384ba1ba6b5ae701
867c7a3c32093b1dd197beba21ca62a6ad08ba37
[openrec] add support for openrec.tv ## Please follow the guide below - You will be asked some questions, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x]) - Use *Preview* tab to see how your *pull request* will actually look lik...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [openrec] add support for openrec.tv", "scope_files": [ "README.md" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `yt_dlp/extractor/` needed for: [openrec] add support for openrec.tv"...
[ { "subtask_id": "s1", "scope_files": [ "README.md" ], "solution_diff": "diff --git a/README.md b/README.md\nindex 7fb2c087404d..9ac50dbe00e2 100644\n--- a/README.md\n+++ b/README.md\n@@ -88,7 +88,7 @@ The major new features from the latest release of [blackjack4494/yt-dlc](https:/\n \n * **Ari...
[ { "subtask_id": "s2", "comment": "Use try_get / traverse_obj", "revised_diff": "diff --git a/yt_dlp/extractor/openrec.py b/yt_dlp/extractor/openrec.py\nnew file mode 100644\nindex 000000000000..d7073ab445bc\n--- /dev/null\n+++ b/yt_dlp/extractor/openrec.py\n@@ -0,0 +1,126 @@\n+# coding: utf-8\n+from __f...
diff --git a/README.md b/README.md index 7fb2c087404d..9ac50dbe00e2 100644 --- a/README.md +++ b/README.md @@ -88,7 +88,7 @@ The major new features from the latest release of [blackjack4494/yt-dlc](https:/ * **Aria2c with HLS/DASH**: You can use `aria2c` as the external downloader for DASH(mpd) and HLS(m3u8) formats...
2
3
yt-dlp/yt-dlp#16787
yt-dlp/yt-dlp
16,787
e534a32619d1d944631a0483f28522bdd11f0745
5781682ef3b24e14264ed03a4e620adce332b6d1
[Announcement] `ejs` is dropping support for Node v20 and v21 Node (aka Node.js) is an [`ejs`](https://github.com/yt-dlp/ejs)-compatible JavaScript runtime. Node v20 reached its end-of-life (EOL) at the end of April 2026. Node v21, which is not a long-term support (LTS) version of Node, reached its end-of-life well b...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [Announcement] `ejs` is dropping support for Node v20 and v21", "scope_files": [ ".github/workflows/challenge-tests.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `yt_d...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/challenge-tests.yml" ], "solution_diff": "diff --git a/.github/workflows/challenge-tests.yml b/.github/workflows/challenge-tests.yml\nindex c76b9fa84c83..36f973f9b77d 100644\n--- a/.github/workflows/challenge-tests.yml\n+++ b/.github/wo...
[]
diff --git a/.github/workflows/challenge-tests.yml b/.github/workflows/challenge-tests.yml index c76b9fa84c83..36f973f9b77d 100644 --- a/.github/workflows/challenge-tests.yml +++ b/.github/workflows/challenge-tests.yml @@ -60,7 +60,7 @@ jobs: - name: Install Node uses: actions/setup-node@48b55a011bda9f5d6ae...
2
2
yt-dlp/yt-dlp#16788
yt-dlp/yt-dlp
16,788
125bb40468a8618e592d607c1c496095fda764f0
2942dc0334d22b03e50b156181d93b7a267c3c79
[Announcement] Raising the minimum supported version of Deno to v2.3.0 Deno is an [`ejs`](https://github.com/yt-dlp/ejs)-compatible JavaScript runtime. As of the next yt-dlp and/or ejs release, the minimum supported version of Deno will be raised from `v2.0.0` to `v2.3.0`. This is being done for security reasons: De...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [Announcement] Raising the minimum supported version of Deno to v2.3.0", "scope_files": [ ".github/workflows/challenge-tests.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes un...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/challenge-tests.yml" ], "solution_diff": "diff --git a/.github/workflows/challenge-tests.yml b/.github/workflows/challenge-tests.yml\nindex 287a115bd10d..c76b9fa84c83 100644\n--- a/.github/workflows/challenge-tests.yml\n+++ b/.github/wo...
[]
diff --git a/.github/workflows/challenge-tests.yml b/.github/workflows/challenge-tests.yml index 287a115bd10d..c76b9fa84c83 100644 --- a/.github/workflows/challenge-tests.yml +++ b/.github/workflows/challenge-tests.yml @@ -50,7 +50,7 @@ jobs: - name: Install Deno uses: denoland/setup-deno@667a34cdef165d8d2b...
2
2
yt-dlp/yt-dlp#16786
yt-dlp/yt-dlp
16,786
b536d72c869e47eb048fc54746e4d2f384706d2f
efc3fcab514e9f43931815ff22dbbbd70acb38b4
[Announcement] Bun support is now limited and deprecated Due to foreseeable compatibility and security issues, yt-dlp's support for Bun as an [`ejs`](https://github.com/yt-dlp/ejs)-compatible JavaScript runtime is being both limited and deprecated. As of the next yt-dlp and/or ejs release, only Bun versions `1.2.11` ...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [Announcement] Bun support is now limited and deprecated", "scope_files": [ ".github/workflows/challenge-tests.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `test/test...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/challenge-tests.yml" ], "solution_diff": "diff --git a/.github/workflows/challenge-tests.yml b/.github/workflows/challenge-tests.yml\nindex 36f973f9b77d..f55cf68f47d0 100644\n--- a/.github/workflows/challenge-tests.yml\n+++ b/.github/wo...
[]
diff --git a/.github/workflows/challenge-tests.yml b/.github/workflows/challenge-tests.yml index 36f973f9b77d..f55cf68f47d0 100644 --- a/.github/workflows/challenge-tests.yml +++ b/.github/workflows/challenge-tests.yml @@ -54,8 +54,7 @@ jobs: - name: Install Bun uses: oven-sh/setup-bun@0c5077e51419868618aea...
5
6
yt-dlp/yt-dlp#14257
yt-dlp/yt-dlp
14,257
7c9b10ebc83907d37f9f65ea9d4bd6f5e3bd1371
cc6bf1c384de37365160ca50eee03d6e652fd06b
Clarify third-party licenses and license Windows builds under GPL due to `mutagen` <!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: Clarify third-party licenses and license Windows builds under GPL due to `mutagen`", "scope_files": [ "README.md", "THIRD_PARTY_LICENSES.txt" ] }, { "subtask_id": "s2", "goal": "Implement the cha...
[ { "subtask_id": "s1", "scope_files": [ "README.md", "THIRD_PARTY_LICENSES.txt" ], "solution_diff": "diff --git a/README.md b/README.md\nindex e582e1e53cbe..7be3266ea54c 100644\n--- a/README.md\n+++ b/README.md\n@@ -138,6 +138,17 @@ curl -L https://github.com/yt-dlp/yt-dlp/raw/master/publ...
[ { "subtask_id": "s1", "comment": "```suggestion\r\nWhile yt-dlp is licensed under the [Unlicense](LICENSE), many of the release files contain code from other projects with different licenses.\r\n\r\nMost notably, the PyInstaller-bundled executables include GPLv3+ licensed code, and as such the combined work...
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 911bdaf6afee..ab02f59beec8 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -269,12 +269,11 @@ jobs: "[![Master](https://img.shields.io/badge/Master%20builds-lightblue.svg?style=for-the-badge...
4
5
yt-dlp/yt-dlp#16269
yt-dlp/yt-dlp
16,269
18656b2f2af41a138793c7012a88f467c0d90274
86eb0f9030fcbd0ecabfef759cfd40f2e3730f7c
[youtube] [jsc] Error solving n challenge request using "deno" provider: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'origin') ### Checklist - [x] I'm reporting that yt-dlp is broken on a **supported** site - [x] I've verified that I have **updated yt-dlp to nightly or master** ([upd...
[ { "subtask_id": "s1", "goal": "Implement the changes under `(root)/` needed for: [youtube] [jsc] Error solving n challenge request using \"deno\" provider: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'origin')", "scope_files": [ "Makefile", "README.md", ...
[ { "subtask_id": "s1", "scope_files": [ "Makefile", "README.md", "pyproject.toml" ], "solution_diff": "diff --git a/Makefile b/Makefile\nindex b4daeb88a419..de3eabd13b3b 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -202,9 +202,9 @@ CONTRIBUTORS: Changelog.md\n \n # The following EJS_-...
[ { "subtask_id": "s1", "comment": "1", "revised_diff": "diff --git a/Makefile b/Makefile\nindex b4daeb88a419..de3eabd13b3b 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -202,9 +202,9 @@ CONTRIBUTORS: Changelog.md\n \n # The following EJS_-prefixed variables are auto-generated by devscripts/update_ejs.py\n #...
diff --git a/Makefile b/Makefile index b4daeb88a419..de3eabd13b3b 100644 --- a/Makefile +++ b/Makefile @@ -202,9 +202,9 @@ CONTRIBUTORS: Changelog.md # The following EJS_-prefixed variables are auto-generated by devscripts/update_ejs.py # DO NOT EDIT! -EJS_VERSION = 0.7.0 -EJS_WHEEL_NAME = yt_dlp_ejs-0.7.0-py3-none...
4
7
yt-dlp/yt-dlp#16743
yt-dlp/yt-dlp
16,743
32f1671a906bf375e5b5d39433dd13f917a8dfa7
e728d6290852c7c5fa1c911d1f684b79faaa7dc4
[ci] Update 2 actions in 2 workflows <!-- BEGIN dlp-bot generated section --> Updated with `--exclude-newer 2026-05-19T01:54:28.178549+00:00` action | old | new | diff -------|-----|-----|----- [**`github/codeql-action`**](<https://github.com/github/codeql-action>) | [v4.35.***2***](<https://github.com/github/codeql...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [ci] Update 2 actions in 2 workflows", "scope_files": [ ".github/workflows/codeql.yml", ".github/workflows/test-workflows.yml" ] } ]
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/codeql.yml", ".github/workflows/test-workflows.yml" ], "solution_diff": "diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml\nindex 7a048015d8f5..4bc3a63be85e 100644\n--- a/.github/workflows/codeql.yml\n+++ b/...
[]
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 7a048015d8f5..4bc3a63be85e 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -36,12 +36,12 @@ jobs: persist-credentials: false - name: Initialize CodeQL - uses: github/codeql-action/init@95e...
1
2
yt-dlp/yt-dlp#16740
yt-dlp/yt-dlp
16,740
410e0af5379c5fc5f2acb6abaa8965637f80ad76
a282538776726d08d8b6c0d6b25b5b0dddac6ccc
[build] Rename requirements files to clean up dependency graph We have GitHub's dependency graph and dependabot security scanning enabled for the repo, and dependabot seems to be very confused by the presence of both a `uv.lock` file and a `requirements-dev.txt` file. The result is a buggy dependabot code path bein...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [build] Rename requirements files to clean up dependency graph", "scope_files": [ ".github/workflows/build.yml", ".github/workflows/challenge-tests.yml", ".github/workflows/core.yml", ".gi...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/build.yml", ".github/workflows/challenge-tests.yml", ".github/workflows/core.yml", ".github/workflows/quick-test.yml", ".github/workflows/release.yml", ".github/workflows/test-workflows.yml" ], "solution_di...
[]
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ecb335433747..a45a4b4e158f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -325,7 +325,7 @@ jobs: brew uninstall --ignore-dependencies python3 python3 -m venv ~/yt-dlp-build-venv s...
4
25
yt-dlp/yt-dlp#16738
yt-dlp/yt-dlp
16,738
a85b38621286903b9124fdb05d177983d8273ec7
99a66bd7960e8eb7ad5570eec7d562e036649302
[build] Upgrade all Linux binaries to Python 3.14 Per https://www.python.org/downloads/release/python-3145/ : > Notably, the garbage collector (GC) has changed in Python 3.14.5. > > The incremental garbage collector shipped in Python 3.14.0-3.14.4 has been reverted back to the generational garbage collector from...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [build] Upgrade all Linux binaries to Python 3.14", "scope_files": [ ".github/workflows/build.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `bundle/docker/linux/` need...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/build.yml" ], "solution_diff": "diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml\nindex 2f76e0494d4a..ecb335433747 100644\n--- a/.github/workflows/build.yml\n+++ b/.github/workflows/build.yml\n@@ -124,7 +124,7 @@ j...
[]
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2f76e0494d4a..ecb335433747 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -124,7 +124,7 @@ jobs: id: linux_matrix env: INPUTS: ${{ toJSON(inputs) }} - PYTHON_VERSION: '3.13' ...
2
2
yt-dlp/yt-dlp#16384
yt-dlp/yt-dlp
16,384
c8695f52a91f0d2aabbba7b7200c1099bfa9a3e5
ddc22504a056fd7f7729a9e532cee3c830ccb53d
[ci] Update 8 actions in 7 workflows <!-- [ci] Update 8 actions in 7 workflows * Bump actions/cache v5.0.3 => v5.0.5 * Bump actions/setup-node v6.3.0 => v6.4.0 * Bump actions/upload-artifact v7.0.0 => v7.0.1 * Bump denoland/setup-deno v2.0.3 => v2.0.4 * Bump github/codeql-action v4.33.0 => v4.35.2 * Bump py...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [ci] Update 8 actions in 7 workflows", "scope_files": [ ".github/workflows/build.yml", ".github/workflows/challenge-tests.yml", ".github/workflows/codeql.yml", ".github/workflows/release-m...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/build.yml", ".github/workflows/challenge-tests.yml", ".github/workflows/codeql.yml", ".github/workflows/release-master.yml", ".github/workflows/release-nightly.yml", ".github/workflows/release.yml", ".github/...
[]
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b02c7280aa31..2f76e0494d4a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -231,7 +231,7 @@ jobs: [[ "${version}" != "${downgraded_version}" ]] - name: Upload artifacts - uses: actions/u...
1
7
ytdl-org/youtube-dl#33227
ytdl-org/youtube-dl
33,227
d0283f5385acd21dd51afa2102844c8cb2fe6b62
fc469aace7097887c353d6a28fc3dc75ed7acba1
no videos returned when trying to download youtube playlist <!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-...
[ { "subtask_id": "s1", "goal": "Implement the changes under `youtube_dl/` needed for: no videos returned when trying to download youtube playlist", "scope_files": [ "youtube_dl/YoutubeDL.py" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `youtube_dl/extractor/` need...
[ { "subtask_id": "s1", "scope_files": [ "youtube_dl/YoutubeDL.py" ], "solution_diff": "diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py\nindex ec1d35c3aca..4c762bf2ccd 100755\n--- a/youtube_dl/YoutubeDL.py\n+++ b/youtube_dl/YoutubeDL.py\n@@ -2404,60 +2404,52 @@ def format_resoluti...
[]
diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py index ec1d35c3aca..4c762bf2ccd 100755 --- a/youtube_dl/YoutubeDL.py +++ b/youtube_dl/YoutubeDL.py @@ -2404,60 +2404,52 @@ def format_resolution(format, default='unknown'): return res def _format_note(self, fdict): - res = '' - ...
2
2
ytdl-org/youtube-dl#33216
ytdl-org/youtube-dl
33,216
1e109aaee13a30e2a23f982410ffb3e4f73913df
2486fbbae152f689f5d538fa55d964173101a110
[YouTube] Unable to download API page: HTTP Error 400: Bad Request <!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checkli...
[ { "subtask_id": "s1", "goal": "Implement the changes under `test/` needed for: [YouTube] Unable to download API page: HTTP Error 400: Bad Request", "scope_files": [ "test/helper.py", "test/test_traversal.py", "test/test_utils.py" ] }, { "subtask_id": "s2", "goal": "Impl...
[ { "subtask_id": "s1", "scope_files": [ "test/helper.py", "test/test_traversal.py", "test/test_utils.py" ], "solution_diff": "diff --git a/test/helper.py b/test/helper.py\nindex 6f2129efff3..fac069d25c9 100644\n--- a/test/helper.py\n+++ b/test/helper.py\n@@ -85,10 +85,10 @@ def expe...
[]
diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py index 8367b6e5345..ec1d35c3aca 100755 --- a/youtube_dl/YoutubeDL.py +++ b/youtube_dl/YoutubeDL.py @@ -357,7 +357,7 @@ class YoutubeDL(object): _NUMERIC_FIELDS = set(( 'width', 'height', 'tbr', 'abr', 'asr', 'vbr', 'fps', 'filesize', 'filesiz...
3
10
ytdl-org/youtube-dl#33198
ytdl-org/youtube-dl
33,198
82552faba6f29ced4914cd670ccd80836364fd45
49a4d31e59ddbee3603c762e9d3c56a02cacdaf3
Crash in dev mode when trying to download private YouTube-playlist <!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checkli...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: Crash in dev mode when trying to download private YouTube-playlist", "scope_files": [ ".github/workflows/ci.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `youtube_dl/e...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/ci.yml" ], "solution_diff": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex c7a8fff8449..073c4458c1d 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@@ -365,7 +365,7 @@ jobs:\n py...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c7a8fff8449..073c4458c1d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -365,7 +365,7 @@ jobs: python -m ensurepip || python -m pip --version || { \ get_pip="${{ contains(needs.select.outputs.own-pip-vers...
2
2
ytdl-org/youtube-dl#33189
ytdl-org/youtube-dl
33,189
a084c80f7bac9ae343075a97cc0fb2c1c96ade89
59da256324073e03d0fd2e36947790376e283957
[YouTube] unable to extract player URL, Sign in to confirm you're not a bot <!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> #...
[ { "subtask_id": "s1", "goal": "Implement the changes under `.github/workflows/` needed for: [YouTube] unable to extract player URL, Sign in to confirm you're not a bot", "scope_files": [ ".github/workflows/ci.yml" ] }, { "subtask_id": "s2", "goal": "Implement the changes under `you...
[ { "subtask_id": "s1", "scope_files": [ ".github/workflows/ci.yml" ], "solution_diff": "diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml\nindex 8234e0ccb6d..c7a8fff8449 100644\n--- a/.github/workflows/ci.yml\n+++ b/.github/workflows/ci.yml\n@@ -122,12 +122,12 @@ jobs:\n ...
[]
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8234e0ccb6d..c7a8fff8449 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -122,12 +122,12 @@ jobs: ytdl-test-set: ${{ fromJSON(needs.select.outputs.test-set) }} run-tests-ext: [sh] include: - ...
4
5