repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
DioxusLabs/dioxus | 5,553 | issue_to_patch | Bug: `--ssg` fails with `--web --fullstack true` — server binary not started before static routes call
## **Problem**
When running `dx build --verbose --trace --web --fullstack true --features fullstack --release --ssg`, the build fails because `dx` attempts to call `http://127.0.0.1:9999/api/static_routes` but no se... | Respect https for ssg static routes | If the backing server only accepts https, we still use http for ssg requests. This PR uses the matching protocol instead but doesn't try to validate the cert since the server is running on localhost
Fixes #5503 | 1816bea9382c44513fd95cea290120c1b830837d | 9219cd0d8fea4d4326dae891d67fcac264d62da7 | diff --git a/packages/cli/src/build/builder.rs b/packages/cli/src/build/builder.rs
index 82814fac16..ae6c983108 100644
--- a/packages/cli/src/build/builder.rs
+++ b/packages/cli/src/build/builder.rs
@@ -2098,7 +2098,15 @@ impl AppBuilder {
let address = &address;
let port = &port;
- tracing::... | [
"packages/cli/src/build/builder.rs"
] | [] | true | |
DioxusLabs/dioxus | 5,550 | issue_to_patch | docs: fix image link in translations into files | I don't know how to md file into pt-br of header image without replacing for other translations md file some?
<img width="1535" height="701" alt="image" src="https://github.com/user-attachments/assets/7297c355-9cea-4735-b766-59e8a051aec0" />
<img width="1537" height="770" alt="image" src="https://github.com/user-... | 4b1b60a487b682f62305342c29ece0553d0da8d8 | ae4527b79df7405eebbd5690a97120daaa707ac7 | diff --git a/notes/translations/fa-ir/README.md b/notes/translations/fa-ir/README.md
index b9e8683aaf..4985615c4f 100644
--- a/notes/translations/fa-ir/README.md
+++ b/notes/translations/fa-ir/README.md
@@ -1,9 +1,9 @@
<p>
<p align="center" >
- <img src="../../notes/header-light.svg#gh-light-mode-only" >
- ... | [
"notes/translations/fa-ir/README.md",
"notes/translations/ja-jp/README.md",
"notes/translations/ko-kr/README.md",
"notes/translations/tr-tr/README.md",
"notes/translations/zh-cn/README.md"
] | [] | true | ||
DioxusLabs/dioxus | 5,042 | issue_to_patch | Trigger rebuilds on both [web.watcher].watch_path (in the config but not wired up) and cargo's depinfo | Hullo hullo – as described. In using build.rs with Dioxus, I found that there wasn't a way (any more) to get the watcher to rebuild on custom input paths.
I'm using `rerun-if-changed` – I first tried using `watch_path`, but it looks like that got un-wired in #3797. I also wired up support for directories in rerun-if... | 386153672e68228eacb4b2adf9f66e02e66a3e36 | d988d639fa24e6c55e4516550932070a4354b876 | diff --git a/packages/cli/src/serve/runner.rs b/packages/cli/src/serve/runner.rs
index 4d06ae7131..a3446aa106 100644
--- a/packages/cli/src/serve/runner.rs
+++ b/packages/cli/src/serve/runner.rs
@@ -480,10 +480,22 @@ impl AppServer {
// If it's not a rust file, then it might be depended on via include! or ... | [
"packages/cli/src/serve/runner.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,538 | issue_to_patch | Revert "Fix: Lifetime unsafety in `ReadableExt::deref_impl`" | Reverts DioxusLabs/dioxus#4801 | ddefccdeb0f284f6f379d9afb8d3b82daf9035c6 | 84a9deb0d93cb5f6a8678681db8717f090beab09 | diff --git a/packages/fullstack-core/src/loader.rs b/packages/fullstack-core/src/loader.rs
index 5c7cc4ea41..4958e7ccd6 100644
--- a/packages/fullstack-core/src/loader.rs
+++ b/packages/fullstack-core/src/loader.rs
@@ -281,7 +281,7 @@ where
type Target = dyn Fn() -> T;
fn deref(&self) -> &Self::Target {
- ... | [
"packages/fullstack-core/src/loader.rs",
"packages/hooks/src/use_future.rs",
"packages/hooks/src/use_resource.rs",
"packages/signals/src/boxed.rs",
"packages/signals/src/copy_value.rs",
"packages/signals/src/global/mod.rs",
"packages/signals/src/map.rs",
"packages/signals/src/map_mut.rs",
"packages/... | [] | true | ||
DioxusLabs/dioxus | 4,801 | issue_to_patch | Fix: Lifetime unsafety in `ReadableExt::deref_impl` | # Objective
The current implementation of `dioxus_signals::read::ReadableExt::deref_impl` is unsafe with an undocumented invariant: it's possible to use this method to extend the lifetime of a borrow, allowing undefined behavior. This is because the "trick" used to cast `&'_ Self` into a `&'a dyn Fn() -> Self::Targe... | 2ab9a5586dc6b4d95e210eded692f50e7ab7575e | 3114e08279677acc6998ff0c23960e9c8ce4b731 | diff --git a/packages/fullstack-core/src/loader.rs b/packages/fullstack-core/src/loader.rs
index 8a4a6b23a7..aec4565cf0 100644
--- a/packages/fullstack-core/src/loader.rs
+++ b/packages/fullstack-core/src/loader.rs
@@ -280,7 +280,7 @@ where
type Target = dyn Fn() -> T;
fn deref(&self) -> &Self::Target {
- ... | [
"packages/fullstack-core/src/loader.rs",
"packages/hooks/src/use_future.rs",
"packages/hooks/src/use_resource.rs",
"packages/signals/src/boxed.rs",
"packages/signals/src/copy_value.rs",
"packages/signals/src/global/mod.rs",
"packages/signals/src/map.rs",
"packages/signals/src/map_mut.rs",
"packages/... | [
{
"comment": "Making `ReadableExt::deref_impl` itself safe solves the lack of `// SAFETY: ...` comments in the multitude of calls to it across Dioxus.",
"path": "packages/fullstack-core/src/loader.rs",
"hunk": "@@ -280,7 +280,7 @@ where\n type Target = dyn Fn() -> T;\n \n fn deref(&self) -> &Sel... | true | ||
DioxusLabs/dioxus | 4,801 | comment_to_fix | Fix: Lifetime unsafety in `ReadableExt::deref_impl` | Making `ReadableExt::deref_impl` itself safe solves the lack of `// SAFETY: ...` comments in the multitude of calls to it across Dioxus. | 2ab9a5586dc6b4d95e210eded692f50e7ab7575e | 3114e08279677acc6998ff0c23960e9c8ce4b731 | diff --git a/packages/fullstack-core/src/loader.rs b/packages/fullstack-core/src/loader.rs
index 8a4a6b23a7..aec4565cf0 100644
--- a/packages/fullstack-core/src/loader.rs
+++ b/packages/fullstack-core/src/loader.rs
@@ -280,7 +280,7 @@ where
type Target = dyn Fn() -> T;
fn deref(&self) -> &Self::Target {
- ... | [
"packages/fullstack-core/src/loader.rs"
] | [
{
"comment": "Making `ReadableExt::deref_impl` itself safe solves the lack of `// SAFETY: ...` comments in the multitude of calls to it across Dioxus.",
"path": "packages/fullstack-core/src/loader.rs",
"hunk": "@@ -280,7 +280,7 @@ where\n type Target = dyn Fn() -> T;\n \n fn deref(&self) -> &Sel... | true | ||
DioxusLabs/dioxus | 4,801 | comment_to_fix | Fix: Lifetime unsafety in `ReadableExt::deref_impl` | This safety comment did not previously capture the fact that you must also ensure the lifetime `'a` is no greater than that of the provided `&self` borrow. Additionally, I'm unsure it's possible in safe rust to invoke `deref_impl` with a value that _isn't_ `&self`, since that violates the function signature. | 2ab9a5586dc6b4d95e210eded692f50e7ab7575e | 3114e08279677acc6998ff0c23960e9c8ce4b731 | diff --git a/packages/signals/src/read.rs b/packages/signals/src/read.rs
index 42442f6757..f992daff0b 100644
--- a/packages/signals/src/read.rs
+++ b/packages/signals/src/read.rs
@@ -1,8 +1,5 @@
use std::collections::{HashMap, HashSet};
-use std::{
- mem::MaybeUninit,
- ops::{Deref, Index},
-};
+use std::ops::{D... | [
"packages/signals/src/read.rs"
] | [
{
"comment": "This safety comment did not previously capture the fact that you must also ensure the lifetime `'a` is no greater than that of the provided `&self` borrow. Additionally, I'm unsure it's possible in safe rust to invoke `deref_impl` with a value that _isn't_ `&self`, since that violates the function... | true | ||
DioxusLabs/dioxus | 4,801 | comment_to_fix | Fix: Lifetime unsafety in `ReadableExt::deref_impl` | By returning `impl Fn` instead of `dyn Fn`, we can use precise capturing syntax, `+ use<Self>` to communicate to the compiler that the returned closure cannot outlive the _type_ `Self`. We can also remove the `unsafe` annotation from this function, as size and alignment requirements are now compile-time verified within... | 2ab9a5586dc6b4d95e210eded692f50e7ab7575e | 3114e08279677acc6998ff0c23960e9c8ce4b731 | diff --git a/packages/signals/src/read.rs b/packages/signals/src/read.rs
index 42442f6757..f992daff0b 100644
--- a/packages/signals/src/read.rs
+++ b/packages/signals/src/read.rs
@@ -1,8 +1,5 @@
use std::collections::{HashMap, HashSet};
-use std::{
- mem::MaybeUninit,
- ops::{Deref, Index},
-};
+use std::ops::{D... | [
"packages/signals/src/read.rs"
] | [
{
"comment": "By returning `impl Fn` instead of `dyn Fn`, we can use precise capturing syntax, `+ use<Self>` to communicate to the compiler that the returned closure cannot outlive the _type_ `Self`. We can also remove the `unsafe` annotation from this function, as size and alignment requirements are now compil... | true | ||
DioxusLabs/dioxus | 4,801 | comment_to_fix | Fix: Lifetime unsafety in `ReadableExt::deref_impl` | This replaces the `cast_lifetime` method and better articulates that its real purpose is for allowing `transmute` to infer the type of an unnameable type (`uninit_closure`). Since we no longer violate lifetime safety, we don't need to use transmute to change the lifetime of the produced closure. | 2ab9a5586dc6b4d95e210eded692f50e7ab7575e | 3114e08279677acc6998ff0c23960e9c8ce4b731 | diff --git a/packages/signals/src/read.rs b/packages/signals/src/read.rs
index 42442f6757..f992daff0b 100644
--- a/packages/signals/src/read.rs
+++ b/packages/signals/src/read.rs
@@ -1,8 +1,5 @@
use std::collections::{HashMap, HashSet};
-use std::{
- mem::MaybeUninit,
- ops::{Deref, Index},
-};
+use std::ops::{D... | [
"packages/signals/src/read.rs"
] | [
{
"comment": "This replaces the `cast_lifetime` method and better articulates that its real purpose is for allowing `transmute` to infer the type of an unnameable type (`uninit_closure`). Since we no longer violate lifetime safety, we don't need to use transmute to change the lifetime of the produced closure.",... | true | ||
DioxusLabs/dioxus | 4,801 | comment_to_fix | Fix: Lifetime unsafety in `ReadableExt::deref_impl` | Using a `const { ... }` block to ensure as much of this method as possible is evaluated at compile time. It's entirely possible the compiler was already optimizing this, but being explicit ensures this is the case. | 2ab9a5586dc6b4d95e210eded692f50e7ab7575e | 3114e08279677acc6998ff0c23960e9c8ce4b731 | diff --git a/packages/signals/src/read.rs b/packages/signals/src/read.rs
index 42442f6757..f992daff0b 100644
--- a/packages/signals/src/read.rs
+++ b/packages/signals/src/read.rs
@@ -1,8 +1,5 @@
use std::collections::{HashMap, HashSet};
-use std::{
- mem::MaybeUninit,
- ops::{Deref, Index},
-};
+use std::ops::{D... | [
"packages/signals/src/read.rs"
] | [
{
"comment": "Using a `const { ... }` block to ensure as much of this method as possible is evaluated at compile time. It's entirely possible the compiler was already optimizing this, but being explicit ensures this is the case.",
"path": "packages/signals/src/read.rs",
"hunk": "@@ -239,44 +239,75 @@ pu... | true | ||
DioxusLabs/dioxus | 4,801 | comment_to_fix | Fix: Lifetime unsafety in `ReadableExt::deref_impl` | `MaybeUninit::assume_init_ref` is more idiomatic than getting a `*const Self` pointer and casting it to a `&Self`. | 2ab9a5586dc6b4d95e210eded692f50e7ab7575e | 3114e08279677acc6998ff0c23960e9c8ce4b731 | diff --git a/packages/signals/src/read.rs b/packages/signals/src/read.rs
index 42442f6757..f992daff0b 100644
--- a/packages/signals/src/read.rs
+++ b/packages/signals/src/read.rs
@@ -1,8 +1,5 @@
use std::collections::{HashMap, HashSet};
-use std::{
- mem::MaybeUninit,
- ops::{Deref, Index},
-};
+use std::ops::{D... | [
"packages/signals/src/read.rs"
] | [
{
"comment": "`MaybeUninit::assume_init_ref` is more idiomatic than getting a `*const Self` pointer and casting it to a `&Self`.",
"path": "packages/signals/src/read.rs",
"hunk": "@@ -239,44 +239,75 @@ pub trait ReadableExt: Readable {\n <Self::Storage as AnyStorage>::map(self.read(), |v| v.inde... | true | ||
DioxusLabs/dioxus | 4,801 | comment_to_fix | Fix: Lifetime unsafety in `ReadableExt::deref_impl` | Ideally, there would be a `const_assert_eq!(::core::alloc::Layout::new::<Self>(), ::core::alloc::Layout::for_value(&uninit_closure))` call here, but that's not currently possible in stable Rust. Instead, I've explicitly checked the size and alignment within the `const` block where this closure is created. This translat... | 2ab9a5586dc6b4d95e210eded692f50e7ab7575e | 3114e08279677acc6998ff0c23960e9c8ce4b731 | diff --git a/packages/signals/src/read.rs b/packages/signals/src/read.rs
index 42442f6757..f992daff0b 100644
--- a/packages/signals/src/read.rs
+++ b/packages/signals/src/read.rs
@@ -1,8 +1,5 @@
use std::collections::{HashMap, HashSet};
-use std::{
- mem::MaybeUninit,
- ops::{Deref, Index},
-};
+use std::ops::{D... | [
"packages/signals/src/read.rs"
] | [
{
"comment": "Ideally, there would be a `const_assert_eq!(::core::alloc::Layout::new::<Self>(), ::core::alloc::Layout::for_value(&uninit_closure))` call here, but that's not currently possible in stable Rust. Instead, I've explicitly checked the size and alignment within the `const` block where this closure is ... | true | ||
DioxusLabs/dioxus | 5,527 | issue_to_patch | Fix macos signing/notarization | This PR contains two fixes:
- Staple notarization ticket to `.app` not `.zip`. You must zip a `.app` before submitting to Apple for notarization (because a `.app` is just a directory, and you can't upload a directory), but the resulting ticket should be stapled to the `.app` not the `.zip`.
- Fix `hardened_runtime`... | a626d609c1995601215f780431d315cf7c063d1e | 55cdf3bda6850c9ac22f4197c678ed068aadf44a | diff --git a/packages/cli/src/bundler/macos.rs b/packages/cli/src/bundler/macos.rs
index c64c09cb83..2f2d8a2e9f 100644
--- a/packages/cli/src/bundler/macos.rs
+++ b/packages/cli/src/bundler/macos.rs
@@ -221,7 +221,7 @@ impl BundleContext<'_> {
bail!("ditto failed to create zip for notarization");
... | [
"packages/cli/src/bundler/macos.rs",
"packages/cli/src/config/bundle.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,506 | issue_to_patch | enable hotpatch by default, hotreload cargo.toml, dynamic file watcher | This PR enables hot-patching with `dx serve`. Now, to run with hotpatching disabled you `dx serve --hotpatch false`.
It also
- [x] fixes bugs with log ordering being random in single async ticks
- [x] changes `p` to toggle between hot-reload modes
- [x] fixes some latent bugs with the rsx hot-reload system
- [x... | 2bce06929c7ba723ed267550303d7855ad03929b | 9cee6f3c19a53e1cb5002fb1e0efb21ec70dc7a1 | diff --git a/Cargo.lock b/Cargo.lock
index 4e96347147..e7ce86f6ff 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3081,8 +3081,9 @@ dependencies = [
[[package]]
name = "depinfo"
-version = "0.7.6"
+version = "0.7.9"
dependencies = [
+ "dunce",
"thiserror 2.0.18",
]
@@ -3217,7 +3218,7 @@ dependencies = [
[[pac... | [
"Cargo.lock",
"Cargo.toml",
"packages/cli-harnesses/harness-default-to-non-default/Cargo.toml",
"packages/cli-harnesses/harness-fullstack-desktop-with-default/Cargo.toml",
"packages/cli-harnesses/harness-fullstack-desktop-with-features/Cargo.toml",
"packages/cli-harnesses/harness-fullstack-desktop/Cargo.t... | [] | diff --git a/packages/cli/src/test_harnesses.rs b/packages/cli/src/test_harnesses.rs
index f405171c9b..cca10913b3 100644
--- a/packages/cli/src/test_harnesses.rs
+++ b/packages/cli/src/test_harnesses.rs
@@ -258,7 +258,7 @@ async fn test_harnesses() {
),
TestHarnessBuilder::new("harness-fullstack-w... | true | |
DioxusLabs/dioxus | 5,242 | issue_to_patch | `dx serve --hot-patch` fails on Windows with `linker = "rust-lld.exe"` set
**Problem**
Explicitly opting into lld on Windows (a practice recommended, for example, by [Bevy's getting started guide](https://bevy.org/learn/quick-start/getting-started/setup/#alternative-linkers)) causes `dx serve` to fail consistently wi... | fix: remove "rust-lld" as custom linker on windows | While porting some of the windows fixes into `cargo-hot` ([this PR](https://github.com/hecrj/cargo-hot/pull/5)), I discovered and fixed another issue on windows that also exists on dioxus cli.
The issue is that the `lld` packed by rust by default as `rust-lld.exe` on windows needs a `-flavor` flag to tell it which f... | d01a820b6f6921ecb6ae459fa85de7bc575a9133 | e5e18178a4cdbc2d69340fa1dda5f5983e18aef0 | diff --git a/packages/cli/src/build/request.rs b/packages/cli/src/build/request.rs
index 1fd53edd56..4a116173bc 100644
--- a/packages/cli/src/build/request.rs
+++ b/packages/cli/src/build/request.rs
@@ -861,6 +861,20 @@ impl BuildRequest {
let mut custom_linker = cargo_config.linker(triple.to_string()).ok().fl... | [
"packages/cli/src/build/request.rs"
] | [] | true | |
DioxusLabs/dioxus | 5,487 | issue_to_patch | ResizeEvent bubbles up in desktop
**Problem**
Resize Event is not supposed to bubble up, but it does in desktop target. (v0.7.3, Windows OS)
When both of parent and child element have resize event, parent's resize event receives not only one's resize data but also child's. This does not happen in web target.
We can p... | fix (desktop): Preserve non-bubbling desktop event forwarding | one parameter fix + two generated artifacts and a regression test
bubbling was being passed as true regardless of the events bubbling property, led to some variation between desktop and web.
Fixes #5258 | 348208d1cb8765759759aa0cc6c161569514256b | 056abade3bf4986b53566e22283edb3738c76581 | diff --git a/packages/desktop/headless_tests/events.rs b/packages/desktop/headless_tests/events.rs
index dc5f629291..27396a2327 100644
--- a/packages/desktop/headless_tests/events.rs
+++ b/packages/desktop/headless_tests/events.rs
@@ -38,6 +38,7 @@ fn app() -> Element {
test_mouse_down_div {}
... | [
"packages/desktop/headless_tests/events.rs",
"packages/interpreter/src/js/hash.txt",
"packages/interpreter/src/js/native.js",
"packages/interpreter/src/ts/native.ts"
] | [] | true | |
DioxusLabs/dioxus | 5,535 | issue_to_patch | backport iframe fix to v0.7 | This backports https://github.com/DioxusLabs/dioxus/pull/5531 and the follow-up commit to v0.7 | 003ec3270b1b142d89e30d4d9a0260c88c493003 | cf3cdecbe9cb55c487747839087366080ec946ac | diff --git a/packages/desktop/src/config.rs b/packages/desktop/src/config.rs
index 78d45bfe9e..11c62a1a63 100644
--- a/packages/desktop/src/config.rs
+++ b/packages/desktop/src/config.rs
@@ -20,6 +20,10 @@ type CustomEventHandler = Box<
),
>;
+/// A function taking a URL and returning whether the webview sh... | [
"packages/desktop/src/config.rs",
"packages/desktop/src/webview.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,531 | issue_to_patch | feat:Add opt‑in navigation handler for external URLs | Pretty much the same as #5231, which was closed without comment.
Without this change, iframes will open in an external browser, breaking existing apps and disallowing many legitimate uses like embedding a YouTube video, etc.
One change was made after discussing it with @jkelleyrtp, which was to make all URLs navi... | f2e4353f93354f3ed565e145adbfb6acef3dbb7e | b18482ba77f8cc300afaaf8e52671a6608adce9b | diff --git a/packages/desktop/src/config.rs b/packages/desktop/src/config.rs
index 18e343fe02..4c616f2333 100644
--- a/packages/desktop/src/config.rs
+++ b/packages/desktop/src/config.rs
@@ -20,6 +20,10 @@ type CustomEventHandler = Box<
),
>;
+/// A function taking a URL and returning whether the webview sh... | [
"packages/desktop/src/config.rs",
"packages/desktop/src/webview.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,534 | issue_to_patch | fix: toctou in wasm hotpatch apply_patch causing UB | This fixes https://github.com/DioxusLabs/dioxus/issues/5532
I discovered this while hacking on the component library but it is the source of errors reported by other people in WASM with hotpatching.
Note this is a v0.7 commit - it will also be part of https://github.com/DioxusLabs/dioxus/pull/5506 | 83f492d10d3732bc09c4496048c698ccf3b917ee | e314216c1de75e4cc9e0c0051c5e94c5d4615d26 | diff --git a/packages/subsecond/subsecond/src/lib.rs b/packages/subsecond/subsecond/src/lib.rs
index 0497f2570b..f6a4e374c1 100644
--- a/packages/subsecond/subsecond/src/lib.rs
+++ b/packages/subsecond/subsecond/src/lib.rs
@@ -551,7 +551,7 @@ pub unsafe fn apply_patch(mut table: JumpTable) -> Result<(), PatchError> {
... | [
"packages/subsecond/subsecond/src/lib.rs"
] | [] | true | ||
DioxusLabs/dioxus | 3,753 | issue_to_patch | Icon option in Dioxus.toml does not work on Windows
**Problem**
On Windows, if you try to change the location of your icon image via editing dioxus.toml under [bundle] using the icon variable, your choice is not respected when bundling for Desktop Windows. It will automatically default to `project\\icons/icon.ico\`
... | feat: windows app icon | 
Closes: #3648
Implement #3596 for windows
Windows app resources will only be build with --release flag, otherwise it will be embedded (no app icon (thumbnail) or metadata when installed)
This pr also reduces the binary s... | 51b0cd3313fe0de1a69e8b661c8bc1ffddd9ff7a | dfaa9ffb95282e6f032e1bc3986ed728f87ac1b6 | diff --git a/Cargo.lock b/Cargo.lock
index 8138d5d449..4481ac4022 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3578,6 +3578,7 @@ version = "0.7.5"
name = "dioxus-desktop"
version = "0.7.5"
dependencies = [
+ "anyhow",
"async-trait",
"base64 0.22.1",
"bytes",
@@ -3602,6 +3603,7 @@ dependencies = [
"generation... | [
"Cargo.lock",
"_typos.toml",
"packages/cli/assets/icon.ico",
"packages/cli/schema.json",
"packages/cli/src/build/mod.rs",
"packages/cli/src/build/request.rs",
"packages/cli/src/build/windows.rs",
"packages/cli/src/cli/bundle.rs",
"packages/cli/src/config/app.rs",
"packages/cli/src/config/bundle.rs... | [
{
"comment": "This is causing issue for me, any idea when this can be merged ?",
"path": "packages/cli/src/build/request.rs",
"hunk": "@@ -4575,4 +4580,110 @@ __wbg_init({{module_or_path: \"/{}/{wasm_path}\"}}).then((wasm) => {{\n \n Ok(())\n }\n+\n+ fn winres_icon_path(&self) -> crate::w... | true | |
DioxusLabs/dioxus | 3,753 | comment_to_fix | feat: windows app icon | This is causing issue for me, any idea when this can be merged ? | 51b0cd3313fe0de1a69e8b661c8bc1ffddd9ff7a | dfaa9ffb95282e6f032e1bc3986ed728f87ac1b6 | diff --git a/packages/cli/src/build/request.rs b/packages/cli/src/build/request.rs
index 9e3090618b..652ffaa14d 100644
--- a/packages/cli/src/build/request.rs
+++ b/packages/cli/src/build/request.rs
@@ -943,6 +943,15 @@ impl BuildRequest {
AndroidTools::unpack_prebuilt_openssl()?;
}
+ // ... | [
"packages/cli/src/build/request.rs"
] | [
{
"comment": "This is causing issue for me, any idea when this can be merged ?",
"path": "packages/cli/src/build/request.rs",
"hunk": "@@ -4575,4 +4580,110 @@ __wbg_init({{module_or_path: \"/{}/{wasm_path}\"}}).then((wasm) => {{\n \n Ok(())\n }\n+\n+ fn winres_icon_path(&self) -> crate::w... | true | ||
DioxusLabs/dioxus | 3,753 | comment_to_fix | feat: windows app icon | This should probably be named write_winres or compile_winres since it also adds other metadata to the app, not just the icon | 51b0cd3313fe0de1a69e8b661c8bc1ffddd9ff7a | dfaa9ffb95282e6f032e1bc3986ed728f87ac1b6 | diff --git a/packages/cli/src/build/request.rs b/packages/cli/src/build/request.rs
index 9e3090618b..652ffaa14d 100644
--- a/packages/cli/src/build/request.rs
+++ b/packages/cli/src/build/request.rs
@@ -943,6 +943,15 @@ impl BuildRequest {
AndroidTools::unpack_prebuilt_openssl()?;
}
+ // ... | [
"packages/cli/src/build/request.rs"
] | [
{
"comment": "This should probably be named write_winres or compile_winres since it also adds other metadata to the app, not just the icon",
"path": "packages/cli/src/build/request.rs",
"hunk": "@@ -4575,4 +4580,110 @@ __wbg_init({{module_or_path: \"/{}/{wasm_path}\"}}).then((wasm) => {{\n \n Ok... | true | ||
DioxusLabs/dioxus | 3,753 | comment_to_fix | feat: windows app icon | I don't think that this is a good idea, since the app will crash in dioxus if the icon fails to compile on windows as it's only loaded from resources so I think it would be better to fail the build instead, especially for release builds | 51b0cd3313fe0de1a69e8b661c8bc1ffddd9ff7a | dfaa9ffb95282e6f032e1bc3986ed728f87ac1b6 | diff --git a/packages/cli/src/build/request.rs b/packages/cli/src/build/request.rs
index 9e3090618b..652ffaa14d 100644
--- a/packages/cli/src/build/request.rs
+++ b/packages/cli/src/build/request.rs
@@ -943,6 +943,15 @@ impl BuildRequest {
AndroidTools::unpack_prebuilt_openssl()?;
}
+ // ... | [
"packages/cli/src/build/request.rs"
] | [
{
"comment": "I don't think that this is a good idea, since the app will crash in dioxus if the icon fails to compile on windows as it's only loaded from resources so I think it would be better to fail the build instead, especially for release builds",
"path": "packages/cli/src/build/request.rs",
"hunk"... | true | ||
DioxusLabs/dioxus | 3,753 | comment_to_fix | feat: windows app icon | as for other platforms than windows, the easy way would be to replace this with an user icon for the default icon from toml to work, so if thats fine I can do that | 51b0cd3313fe0de1a69e8b661c8bc1ffddd9ff7a | dfaa9ffb95282e6f032e1bc3986ed728f87ac1b6 | diff --git a/packages/desktop/src/default_icon.rs b/packages/desktop/src/default_icon.rs
new file mode 100644
index 0000000000..77941cff91
--- /dev/null
+++ b/packages/desktop/src/default_icon.rs
@@ -0,0 +1,187 @@
+use anyhow::Result;
+use image::load_from_memory;
+use image::GenericImageView;
+use image::ImageReader;
... | [
"packages/desktop/src/default_icon.rs"
] | [
{
"comment": "as for other platforms than windows, the easy way would be to replace this with an user icon for the default icon from toml to work, so if thats fine I can do that",
"path": "packages/desktop/src/default_icon.rs",
"hunk": "@@ -0,0 +1,173 @@\n+use anyhow::Result;\n+use image::load_from_memo... | true | ||
DioxusLabs/dioxus | 5,528 | issue_to_patch | Fix macos signing/notarization (0.7 backport) | Backport of https://github.com/DioxusLabs/dioxus/pull/5527 to the `v0.7` branch. | a7c0e3bfddf99715d1d9bb81d6522a5858d5e157 | cccbd986706d348938c08928571be0e364786f65 | diff --git a/packages/cli/src/bundler/macos.rs b/packages/cli/src/bundler/macos.rs
index f9805be3ac..cb4691cb38 100644
--- a/packages/cli/src/bundler/macos.rs
+++ b/packages/cli/src/bundler/macos.rs
@@ -221,7 +221,7 @@ impl BundleContext<'_> {
bail!("ditto failed to create zip for notarization");
... | [
"packages/cli/src/bundler/macos.rs",
"packages/cli/src/config/bundle.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,524 | issue_to_patch | Fix bundling on aarch64 Alpine Linux | Heyo
`dx bundle --release` fails on Alpine Linux on aarch64 CPUs, because we always download the GNU version of wasm-bindgen and it doesn't run on Alpine. Since we already use the musl version for x86_64, I guess we can just switch to musl on aarch64 too.
Also, is it maybe possible to add a musl build of `dioxus-... | 487aa057bf80f0773ca14b1ab942ba9d992e53fd | 886fc2104790815a946141b27b3efadf69af60ad | diff --git a/packages/cli/src/wasm_bindgen.rs b/packages/cli/src/wasm_bindgen.rs
index 510bf0161b..df96f5b778 100644
--- a/packages/cli/src/wasm_bindgen.rs
+++ b/packages/cli/src/wasm_bindgen.rs
@@ -437,7 +437,7 @@ impl WasmBindgen {
} else if cfg!(all(target_os = "linux", target_arch = "x86_64")) {
... | [
"packages/cli/src/wasm_bindgen.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,522 | issue_to_patch | clippy fixes for rust 1.95 | I noticed on my newer rust version that our workspace was throwing lots of clippy warnings. this fixes that | d4e98054156c11feb3609f6af8569fa920152cfa | 4d4cb3c9fb85cc7fb786a7d3cbc4c312260b92d5 | diff --git a/examples/01-app-demos/calculator.rs b/examples/01-app-demos/calculator.rs
index 8ab82c5591..2cb57ebe99 100644
--- a/examples/01-app-demos/calculator.rs
+++ b/examples/01-app-demos/calculator.rs
@@ -49,10 +49,8 @@ fn app() -> Element {
let mut input_operator = move |key: &str| val.push_str(key);
... | [
"examples/01-app-demos/calculator.rs",
"packages/cli/src/build/builder.rs",
"packages/cli/src/build/request.rs",
"packages/cli/src/build/web.rs",
"packages/cli/src/bundler/windows.rs",
"packages/cli/src/cli/run.rs",
"packages/cli/src/serve/runner.rs",
"packages/cli/src/serve/server.rs",
"packages/rs... | [] | true | ||
DioxusLabs/dioxus | 5,521 | issue_to_patch | port js bundle regression fix | Ports https://github.com/DioxusLabs/dioxus/pull/5515 to main | d4e98054156c11feb3609f6af8569fa920152cfa | 339e0bdfd7dcca1876a4b30fbcc959da7e5188f9 | diff --git a/packages/cli/src/build/assets.rs b/packages/cli/src/build/assets.rs
index 2939cb62e5..fbbef692be 100644
--- a/packages/cli/src/build/assets.rs
+++ b/packages/cli/src/build/assets.rs
@@ -276,6 +276,8 @@ fn legacy_asset_to_modern_asset(
.with_minify(js.minified())
.with_preload(js.p... | [
"packages/cli/src/build/assets.rs",
"packages/cli/src/build/builder.rs",
"packages/cli/src/build/web.rs",
"packages/cli/src/cli/bundle.rs",
"packages/cli/src/opt/file.rs",
"packages/cli/src/opt/folder.rs",
"packages/cli/src/opt/hash.rs",
"packages/cli/src/opt/js.rs",
"packages/cli/src/opt/mod.rs",
... | [] | diff --git a/packages/playwright-tests/cli-optimization.spec.js b/packages/playwright-tests/cli-optimization.spec.js
index 3f35d48cc8..1bc61ccc7f 100644
--- a/packages/playwright-tests/cli-optimization.spec.js
+++ b/packages/playwright-tests/cli-optimization.spec.js
@@ -63,4 +63,108 @@ for (let { port, name } of test_v... | true | |
DioxusLabs/dioxus | 5,515 | issue_to_patch | autodetect js module type - only bundle esm | This fixes a regression caused by the upgrade to esbuild.
Fixes https://github.com/DioxusLabs/dioxus/issues/5512
~~Fixes https://github.com/DioxusLabs/dioxus/issues/4440~~
~~Fixes https://github.com/DioxusLabs/dioxus/issues/3748~~
Previously, the js bundling system would inline all imports by walking the js ass... | 2f40780ce0c2ecba851718f56c21babf34841609 | f4ea30b9de40ce52f816801906c6449b41c3183d | diff --git a/Cargo.lock b/Cargo.lock
index 9cb3cb1f98..a65d708365 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -242,23 +242,21 @@ checksum = "683d7910e743518b0e34f1186f92494becacb047c7b6bf616c96772180fef923"
[[package]]
name = "android-activity"
-version = "0.6.0"
+version = "0.6.1"
source = "registry+https://githu... | [
"Cargo.lock",
"packages/cli/src/build/assets.rs",
"packages/cli/src/build/builder.rs",
"packages/cli/src/build/web.rs",
"packages/cli/src/cli/bundle.rs",
"packages/cli/src/opt/file.rs",
"packages/cli/src/opt/folder.rs",
"packages/cli/src/opt/hash.rs",
"packages/cli/src/opt/js.rs",
"packages/cli/sr... | [] | diff --git a/packages/playwright-tests/cli-optimization.spec.js b/packages/playwright-tests/cli-optimization.spec.js
index 3f35d48cc8..1bc61ccc7f 100644
--- a/packages/playwright-tests/cli-optimization.spec.js
+++ b/packages/playwright-tests/cli-optimization.spec.js
@@ -63,4 +63,108 @@ for (let { port, name } of test_v... | true | |
DioxusLabs/dioxus | 5,520 | issue_to_patch | Add retention days to bundle smoke workflow | This was using 80gb/100gb of artifact storage. Cleared some existing old artifacts manually, but this should prevent the issue in the future | 1766af46bd23dc7fcbda10d530b14e046a20c95e | 05bb68fff4753a97ddcdd728cd2ef86502868094 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index b5caf4da4a..16ed3e2688 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -210,7 +210,7 @@ jobs:
test -n "$(find target -name '*.deb' -print -quit)"
test -n "$(find target -name '*.rpm' -print -quit... | [
".github/workflows/main.yml",
"packages/core-macro/src/props/mod.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,464 | issue_to_patch | dx fmt breaks indentation of commented-out RSX blocks (regression since v0.7.3)
Since v0.7.4 (commit b6793dc2b, PR #5257), `dx fmt` mangles the indentation of commented-out RSX blocks. Two variants:
**Variant 1: First line keeps indentation, rest gets dedented**
Idempotency test with this input fails:
```diff
rsx!... | fix(autofmt): preserve indentation of commented-out RSX blocks | Fixes #5463
Trailing comments before `}` in `write_rsx_block` were indented at parent level instead of child level, breaking commented-out RSX blocks (regression from #5257).
Fix: before `apply_line_comments`, truncate the tab from `tabbed_line()` and bump indent to child level. Same approach as `write_trailing_body_... | 71df8c790f0790ea1d2d87d14d094000c0fa2a45 | 56bd704041fd1830fceb8e83de319978df2f5dec | diff --git a/packages/autofmt/src/writer.rs b/packages/autofmt/src/writer.rs
index d9dfbd3ec8..462a4ba83d 100644
--- a/packages/autofmt/src/writer.rs
+++ b/packages/autofmt/src/writer.rs
@@ -426,7 +426,13 @@ impl<'a> Writer<'a> {
{
let comments = self.accumulate_full_line_comments(brace.span.span(... | [
"packages/autofmt/src/writer.rs",
"packages/autofmt/tests/samples.rs",
"packages/autofmt/tests/samples/commented_rsx_block.rsx",
"packages/autofmt/tests/samples/commented_rsx_block_between.rsx",
"packages/autofmt/tests/samples/commented_rsx_block_deep.rsx",
"packages/autofmt/tests/samples/commented_rsx_bl... | [] | diff --git a/packages/autofmt/tests/samples.rs b/packages/autofmt/tests/samples.rs
index 7a8257f735..d38cfef931 100644
--- a/packages/autofmt/tests/samples.rs
+++ b/packages/autofmt/tests/samples.rs
@@ -69,6 +69,11 @@ twoway![
blank_lines,
blank_lines_preserved,
forloop_tuple,
+ commented_rsx_block,
+... | true |
DioxusLabs/dioxus | 5,507 | issue_to_patch | Sync 0.8.x versions of `dioxus-native` and `dioxus-native-dom` from Blitz repo |
## Changes made
- Sync from Blitz repo
```bash
rm -rf packages/native && cp -a ../blitz/packages/dioxus-native ./packages/native
rm -rf packages/native-dom && cp -a ../blitz/packages/dioxus-native-dom ./packages/native-dom
```
- Use workspace package version for `dioxus-native` and `dioxus-native-dom`... | 2cd524553ec3c87139b6823e85fbed293990ca45 | 596b85fbce586d9f06323814ab6e8500d7b07c5a | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index dc17a4153d..b5caf4da4a 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -191,7 +191,7 @@ jobs:
with:
packages: libwebkit2gtk-4.1-dev libgtk-3-dev libasound2-dev libudev-dev libayatana-appindicator3-... | [
".github/workflows/main.yml",
".github/workflows/publish.yml",
"Cargo.lock",
"Cargo.toml",
"examples/01-app-demos/calculator.rs",
"examples/01-app-demos/calculator_mutable.rs",
"examples/08-apis/wgpu_child_window.rs",
"examples/10-integrations/native-headless/Cargo.toml",
"examples/10-integrations/n... | [] | true | ||
DioxusLabs/dioxus | 5,425 | issue_to_patch | Enforce method and field visibility in store derives with visibility witness types | When you derive store on a public struct with private fields, those private fields get added to the public trait. This PR changes the behavior to generate seals for each method that ensures the caller can view the scope the method is visible in
For a struct like this in a store, you can now only access todos outside... | 1eb00b5e0080ab4bd6a11ddd0a01c97f28493e04 | 8b6fb0cab865320c975efb4991fccb01aad01400 | diff --git a/.gitignore b/.gitignore
index be4a1fdd92..672ba816ca 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,5 @@
.dioxus
+.claude/settings.local.json
/target
/packages/playwright-tests/cli-optimization/monaco-editor-0.52.2
/packages/playwright-tests/web/dist
diff --git a/Cargo.lock b/Cargo.lock
index 6f86... | [
".gitignore",
"Cargo.lock",
"Cargo.toml",
"packages/stores-macro/Cargo.toml",
"packages/stores-macro/src/derive.rs",
"packages/stores-macro/src/extend.rs",
"packages/stores-macro/src/lib.rs",
"packages/stores-macro/src/seal.rs",
"packages/stores/Cargo.toml",
"packages/stores/tests/cross_crate.rs",... | [] | diff --git a/packages/stores/tests/cross_crate.rs b/packages/stores/tests/cross_crate.rs
new file mode 100644
index 0000000000..6e72baf693
--- /dev/null
+++ b/packages/stores/tests/cross_crate.rs
@@ -0,0 +1,17 @@
+//! Cross-crate sealing tests for `#[derive(Store)]`.
+//!
+//! `packages/stores/tests/visibility-helper` ... | true | |
DioxusLabs/dioxus | 5,312 | issue_to_patch | Fix dropped store comparison when coercing into a readsignal | When diffing between multiple different reactive sources to create a single combined `ReadSignal`, we currently read both sources and panic if they are no longer valid. This causes issues if one is dropped like in this example [reported on discord](https://discord.com/channels/899851952891002890/943190605067079712/1471... | 64cc42e16ee9ac970ebcde23e85037c805754526 | 35339450a36ac757aee093d2cb579cccc5372285 | diff --git a/packages/core-macro/src/props/mod.rs b/packages/core-macro/src/props/mod.rs
index f7b0a51dba..688361aeb7 100644
--- a/packages/core-macro/src/props/mod.rs
+++ b/packages/core-macro/src/props/mod.rs
@@ -661,10 +661,13 @@ mod struct_info {
// If they are equal, we don't need to rerun the com... | [
"packages/core-macro/src/props/mod.rs",
"packages/signals/src/boxed.rs",
"packages/stores/src/impls/mod.rs",
"packages/stores/src/impls/slice.rs",
"packages/stores/tests/vec_remove.rs"
] | [] | diff --git a/packages/stores/tests/vec_remove.rs b/packages/stores/tests/vec_remove.rs
new file mode 100644
index 0000000000..997b326160
--- /dev/null
+++ b/packages/stores/tests/vec_remove.rs
@@ -0,0 +1,53 @@
+use dioxus::prelude::*;
+use dioxus_core::generation;
+
+#[derive(Debug, Clone, dioxus_stores::Store)]
+struc... | true | |
DioxusLabs/dioxus | 5,276 | issue_to_patch | Layouts get re-mounted in when opt-level > 1
**Problem**
A layout in the router is re-mounting when it should not be. This only occurs when the dependencies are at a higher opt-level.
```
# enabling this causes the layout to remount
[profile.dev.package."*"]
opt-level = 3
```
I have not seen this in release mode, b... | Switch to a const hash instead of comparing pointers for template diffing | Currently we compare templates in two different ways depending on the opt level of dioxus-core:
1) By content if static functions aren't merged when building core
2) By pointer if static functions are merged
This causes issues if dioxus-core is built at a higher level than dioxus itself.
This PR changes the com... | 2f40780ce0c2ecba851718f56c21babf34841609 | 9a61ac994c8f4421dbbaeb6a6917568f84375b70 | diff --git a/.gitignore b/.gitignore
index cdbfec4a03..79c1d430ff 100644
--- a/.gitignore
+++ b/.gitignore
@@ -41,3 +41,6 @@ tmp/
# in debugging we frequently dump wasm to wat with `wasm-tools print`
*.wat
+
+# External macos drives have extra ._ files
+._*
\ No newline at end of file
diff --git a/Cargo.lock b/Carg... | [
".gitignore",
"Cargo.lock",
"packages/cli-harnesses/harness-fullstack-with-optional-tokio/Cargo.toml",
"packages/core/Cargo.toml",
"packages/core/src/diff/iterator.rs",
"packages/core/src/diff/mod.rs",
"packages/core/src/diff/node.rs",
"packages/core/src/error_boundary.rs",
"packages/core/src/hotrel... | [] | diff --git a/packages/core/tests/attributes_pass.rs b/packages/core/tests/attributes_pass.rs
index 49b4080d38..601ee174e0 100644
--- a/packages/core/tests/attributes_pass.rs
+++ b/packages/core/tests/attributes_pass.rs
@@ -18,9 +18,9 @@ fn attributes_pass_properly() {
let template = &o.template;
- assert_eq... | true |
DioxusLabs/dioxus | 5,422 | issue_to_patch | Add non-exhaustive to the derived props in #[component] | Currently it is a breaking change to add an optional field to a public component with props derived with the #[component] macro even though it isn't breaking for usage within rsx. This PR adds non_exhaustive to the derived props so it isn't breaking in future releases.
Changing this component:
```rust
#[componen... | 0d94a51ec8df2c70dba4027ecb2886bb0f07f9e6 | bda6e9defcbe244b5c6967d3d13b1ed4283cb376 | diff --git a/packages/core-macro/src/component.rs b/packages/core-macro/src/component.rs
index 776871b66a..14d8fa4fa7 100644
--- a/packages/core-macro/src/component.rs
+++ b/packages/core-macro/src/component.rs
@@ -245,6 +245,7 @@ impl ComponentBody {
let item_struct = parse_quote! {
#[derive(Pr... | [
"packages/core-macro/src/component.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,101 | issue_to_patch | Port dioxus to use `objc2` for interacting with macOS/iOS platform apis | Replaces the `objc`, `objc_id`, `cocoa`, and `core_foundation` crates with `objc2`, `objc2_foundation`, `objc2_ui_kit` and `objc2_app_kit`.
This is unfortunately breaking because the `objc` crate is/was in the public API due to the `push_view` function. | 291c110dd49fa9fe82e9f9bb66db4d18a5125ee7 | 009b0b77964892bed7cb8b1f2316fc35cde2857f | diff --git a/Cargo.lock b/Cargo.lock
index 4f91d205fb..a57ad6aa33 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3488,35 +3488,6 @@ dependencies = [
"thiserror 2.0.18",
]
-[[package]]
-name = "cocoa"
-version = "0.26.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ad36507aeb7e16159d... | [
"Cargo.lock",
"Cargo.toml",
"packages/desktop/Cargo.toml",
"packages/desktop/src/desktop_context.rs",
"packages/desktop/src/webview.rs"
] | [] | true | ||
DioxusLabs/dioxus | 5,501 | issue_to_patch | update the dioxus cratesio readme, add many more examples | > **Overview**
> Refreshes the crates.io-facing `packages/dioxus/README.md` with new branding, badges/links, and a much shorter, marketing-style overview (feature highlights, guides links, hot-reload, bundling, mobile/fullstack sections, and updated screenshots), replacing the previous long-form introduction.
>
> U... | 74e7d20f80c9af419a5209f29490cf29953ae0d5 | c0f3823d1a2f6d145ce1257a9a70a5b2fa108fac | diff --git a/Cargo.toml b/Cargo.toml
index a71a77d39d..b4a57d9568 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -579,6 +579,56 @@ name = "svg"
path = "examples/02-building-ui/svg.rs"
doc-scrape-examples = true
+[[example]]
+name = "counter"
+path = "examples/02-building-ui/counter.rs"
+doc-scrape-examples = true
+
+[... | [
"Cargo.toml",
"README.md",
"examples/02-building-ui/checkbox_radio.rs",
"examples/02-building-ui/children.rs",
"examples/02-building-ui/components.rs",
"examples/02-building-ui/conditional_rendering.rs",
"examples/02-building-ui/counter.rs",
"examples/02-building-ui/dynamic_classes.rs",
"examples/02... | [] | true | ||
DioxusLabs/dioxus | 5,499 | issue_to_patch | Manganis can't pass numeric value to kotlin function
**Problem**
If i want to pass an numeric value (e.g. i64) to a kotlin function im getting this error:
```
error[E0308]: mismatched types
--> packages/haptics/src/android.rs:8:5
|
8 | #[manganis::ffi("android")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `J... | Manganis: Don't double borrow primitive JNI args | Fixes #5485
Removes `.borrow()` calls from created `jni::objects::JValue` instances, since those are already borrowed. | 51b0cd3313fe0de1a69e8b661c8bc1ffddd9ff7a | 0f695f873fdc3a576f3a474c6f4190a6ede62b89 | diff --git a/packages/manganis/manganis-macro/src/ffi.rs b/packages/manganis/manganis-macro/src/ffi.rs
index 42dcf3e79c..247decefa5 100644
--- a/packages/manganis/manganis-macro/src/ffi.rs
+++ b/packages/manganis/manganis-macro/src/ffi.rs
@@ -502,31 +502,31 @@ impl FfiBridgeParser {
let (binding, arg_expr)... | [
"packages/manganis/manganis-macro/src/ffi.rs"
] | [] | true | |
DioxusLabs/dioxus | 5,498 | issue_to_patch | Add FreeBSD target detection for esbuild | Adds detection for freebsd-x64 and presumably freebsd-arm64 in the esbuild target logic. This enables the CLI to run on FreeBSD by resolving the correct platform binary, this issue can also be bypassed by changing some settings, but this should let it work out-of-the-box. I tested it on x86 FreeBSD. | 51b0cd3313fe0de1a69e8b661c8bc1ffddd9ff7a | ca6b37e8ee72ed759dc4e8028cc7bd300e537190 | diff --git a/packages/cli/src/esbuild.rs b/packages/cli/src/esbuild.rs
index 35e3c8fbc8..b620d07e1e 100644
--- a/packages/cli/src/esbuild.rs
+++ b/packages/cli/src/esbuild.rs
@@ -151,6 +151,7 @@ impl Esbuild {
/// - darwin-arm64, darwin-x64
/// - linux-x64, linux-arm64
/// - win32-x64, win32-arm64
+ /... | [
"packages/cli/src/esbuild.rs"
] | [] | true | ||
DioxusLabs/dioxus | 2,998 | issue_to_patch | docs: add korean translation for README.md | I added Korean translated README | 9f22e9043ce5d9e2b0cbc25d6d24550b41cc122f | a3a66aeef631c826ca273e75901dd7633a80c24d | diff --git a/README.md b/README.md
index c330b73998..4331276422 100644
--- a/README.md
+++ b/README.md
@@ -54,6 +54,8 @@
<a href="https://github.com/DioxusLabs/dioxus/blob/main/translations/ja-jp/README.md"> 日本語 </a>
<span> | </span>
<a href="https://github.com/DioxusLabs/dioxus/blob/main/translations/tr... | [
"README.md",
"translations/ko-kr/README.md"
] | [] | true | ||
DioxusLabs/dioxus | 5,481 | issue_to_patch | dx serve --addr 0.0.0.0 should report http://0.0.0.0:8080 as the address
## Feature Request
I'm accustomed to tools where you can set 0.0.0.0 showing THAT address when you start the dev server. Mine is still showing
> Serving at: http://127.0.0.1:8080
It also seems to redirect to 127 if I manually visit the all 0s ... | fix(cli): display user-specified address in serve output | ## Summary
Fixes #5477
When running `dx serve --addr 0.0.0.0`, the CLI overrode the displayed address to `127.0.0.1`. This was confusing for users who explicitly chose `0.0.0.0` and expected the output to reflect their choice.
Removed the override in `displayed_address()` and the now-unused `devserver_bind_ip` struc... | 94e446524402145f15d994ebb1c0a4beb278b7d5 | 143fe48c0dca98dd0c83532461e71cf54f421f70 | diff --git a/packages/cli/src/serve/output.rs b/packages/cli/src/serve/output.rs
index 6a0637a11b..76b15e364e 100644
--- a/packages/cli/src/serve/output.rs
+++ b/packages/cli/src/serve/output.rs
@@ -31,7 +31,7 @@ use tracing::Level;
use super::AppServer;
const TICK_RATE_MS: u64 = 100;
-const VIEWPORT_MAX_WIDTH: u16... | [
"packages/cli/src/serve/output.rs",
"packages/cli/src/serve/server.rs"
] | [] | true | |
DioxusLabs/dioxus | 5,489 | issue_to_patch | fix: more panic resilience | This PR minimizes the refcells carried over scopes where we run user code, allowing apps that panic to recover a bit more gracefully than just bricking the page.
While we can't handle async tasks bricking apps with signals left open, we can improve the cases where user code runs, crashes, but doesn't leave the app b... | cb5abb48dd667164f0aa65670181472710e22886 | eff7fe9cc03f0aae198cec63805618f65bf22957 | diff --git a/packages/core/src/runtime.rs b/packages/core/src/runtime.rs
index 42fdc54d4b..e112e68832 100644
--- a/packages/core/src/runtime.rs
+++ b/packages/core/src/runtime.rs
@@ -406,36 +406,44 @@ fn MyComponent() -> Element {{
name = "VirtualDom::handle_bubbling_event"
)]
fn handle_bubbling_even... | [
"packages/core/src/runtime.rs"
] | [] | true | ||
Dogfalo/materialize | 6,339 | issue_to_patch | Make v0.100.2 date picker and dropdown play nice with Chrome 73 | ## Proposed changes
Chrome 73 changes broke v0.100.2 date picker and dropdown, among other things.
1. Datepicker - was being closed as soon as it is opened. I just ported over pickadate v.3.6.3 picker constructor prepareElement function contents (https://github.com/amsul/pickadate.js/blob/master/lib/picker.js). Th... | b94dd3c7eb37cf51acf6398cd710f7984f62e9e2 | 68a7c1f4250bd5a1a94ff39235a9372d36420963 | diff --git a/js/date_picker/picker.js b/js/date_picker/picker.js
index 745ef71777..0b3ca36043 100644
--- a/js/date_picker/picker.js
+++ b/js/date_picker/picker.js
@@ -579,6 +579,8 @@ function PickerConstructor( ELEMENT, NAME, COMPONENT, OPTIONS ) {
/**
* Prepare the input element with all bindings.
+ *... | [
"js/date_picker/picker.js",
"js/forms.js"
] | [] | true | ||
Dogfalo/materialize | 6,471 | issue_to_patch | fix: update tooltip delay info to correct increments | ## Proposed changes
This fixes issue #6468 where the `exitDelay` and `enterDelay` times are reversed.
## Screenshots (if appropriate) or codepen:
<!-- Add supplemental screenshots or code examples. Look for a codepen template in our **[CONTRIBUTING document](https://github.com/Dogfalo/materialize/blob/master/CONTR... | e49d32a9b5962a54dfde715d9fe801682b7efc7c | ca853fb9cec4d75f9eae5b8569190ed1dbec54b7 | diff --git a/jade/page-contents/tooltips_content.html b/jade/page-contents/tooltips_content.html
index 48017fa82c..90c935a7b3 100644
--- a/jade/page-contents/tooltips_content.html
+++ b/jade/page-contents/tooltips_content.html
@@ -57,13 +57,13 @@ <h3 class="header">Options</h3>
<tr>
<td>exit... | [
"jade/page-contents/tooltips_content.html"
] | [] | true | ||
Dogfalo/materialize | 6,461 | issue_to_patch | New inputs | Adding new outlined text fields.
Demo at /text-inputs.html#outlined | 2e3dbf392d6111903407229c435859ce16905120 | 60f9b45160b38ad1f905303f33946d63532762df | diff --git a/Gruntfile.js b/Gruntfile.js
index a8f26ea294..53f5eb33f3 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -608,7 +608,6 @@ module.exports = function(grunt) {
grunt.loadNpmTasks('grunt-banner');
grunt.loadNpmTasks('grunt-rename-util');
grunt.loadNpmTasks('grunt-browser-sync');
- grunt.loadNpmTasks(... | [
"Gruntfile.js",
"docs/js/init.js",
"jade/page-contents/text_inputs_content.html",
"js/forms.js",
"js/global.js",
"sass/components/forms/_input-fields.scss"
] | [] | true | ||
Dogfalo/materialize | 6,313 | issue_to_patch | Update _input-fields.scss | ## Proposed changes
fix .browser-default wont take effect when there is no type attribute in input.
## Screenshots (if appropriate) or codepen:
## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking cha... | e5f686b87bd95eeec2b9c7cac8e0eb7241f0ccaf | b4651b0ad9b33dd894003ca4f15563975bc353a7 | diff --git a/sass/components/forms/_input-fields.scss b/sass/components/forms/_input-fields.scss
index f18c2f8097..b44c7b7f01 100644
--- a/sass/components/forms/_input-fields.scss
+++ b/sass/components/forms/_input-fields.scss
@@ -9,7 +9,7 @@
/* Text inputs */
-input:not([type]),
+input:not([type]):not(.browser-de... | [
"sass/components/forms/_input-fields.scss"
] | [] | true | ||
Dogfalo/materialize | 6,391 | issue_to_patch | Fix Travis CI url and badge | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
Updated Travis CI URL from org to com
## Screenshots (if appropriate) or codepen:
<!-... | 0573d853fb943e4dd833afd91fc341d48411d6f2 | 1305245af18a493c78e8f239eb770adbeefb3394 | diff --git a/README.md b/README.md
index d8cca9c583..e89aca1b32 100644
--- a/README.md
+++ b/README.md
@@ -12,8 +12,8 @@
<a href="http://materializecss.com/"><strong>-- Browse the docs --</strong></a>
<br>
<br>
- <a href="https://travis-ci.org/Dogfalo/materialize">
- <img src="https://travis-ci.org/Dogfalo... | [
"README.md"
] | [] | true | ||
Dogfalo/materialize | 4,881 | issue_to_patch | Fix issue: Cursor blinking in select box input field in iphone | Fix issue: Cursor blinking in select box input field in iphone
https://github.com/Dogfalo/materialize/issues/3790 | 0552c37d7cadaa5301019234f804dc08e6b58c98 | 033f036325c5f9ec8baec2ee9a5ce7b0b538b9f2 | diff --git a/sass/components/forms/_select.scss b/sass/components/forms/_select.scss
index 687d49743d..e68317dfaf 100644
--- a/sass/components/forms/_select.scss
+++ b/sass/components/forms/_select.scss
@@ -34,6 +34,11 @@ select {
margin: $input-margin;
padding: 0;
display: block;
+ -webkit-user-selec... | [
"sass/components/forms/_select.scss"
] | [] | true | ||
Dogfalo/materialize | 6,289 | issue_to_patch | 2018 -> 2019 | ## Proposed changes
Change license year to 2019
## Screenshots (if appropriate) or codepen:
Not Applicable
## Types of changes
- [x] Documentation
## Checklist:
- [x] I have read the **[CONTRIBUTING document](https://github.com/Dogfalo/materialize/blob/master/CONTRIBUTING.md)**.
- [x] My change requ... | 47b53e908413755b30eb60bec616ef64be85b821 | d31f1df6a46afefc8e4a89d057460e57dd4fd183 | diff --git a/LICENSE b/LICENSE
index fcff17ec0d..c790fc282f 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,6 +1,6 @@
The MIT License (MIT)
-Copyright (c) 2014-2018 Materialize
+Copyright (c) 2014-2019 Materialize
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associat... | [
"LICENSE"
] | [] | true | ||
Dogfalo/materialize | 6,268 | issue_to_patch | Update v1-upgrade-guide.md | Fix typo on sidenav section
## Types of changes
- [X] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing functionality to change).
## Checklist:
- [X] I have read the **[CONTRIBUT... | 856b617cdb870965d3230017475d8698b0131619 | 74737a8cf568bad9c33642044df397b767c7a49e | diff --git a/v1-upgrade-guide.md b/v1-upgrade-guide.md
index 8403f8c881..b7de92f50d 100644
--- a/v1-upgrade-guide.md
+++ b/v1-upgrade-guide.md
@@ -77,7 +77,7 @@
- Rename plugin call `.sideNav()` to `.sidenav()`
- Sidenav option `closeOnClick` no longer exists
- Instead apply the class `.sidenav-close` to any item ... | [
"v1-upgrade-guide.md"
] | [] | true | ||
Dogfalo/materialize | 6,214 | issue_to_patch | Update v1-upgrade-guide.md | Corrected spelling of components in line 5.
## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
Corrected spelling of components in line 5... | 7b6e39efc36092b5945ab286292bab646ebc0f64 | e8ffab6068b8ce9bf9b98643993ae6abffabb1d2 | diff --git a/v1-upgrade-guide.md b/v1-upgrade-guide.md
index 756cbc2140..8403f8c881 100644
--- a/v1-upgrade-guide.md
+++ b/v1-upgrade-guide.md
@@ -2,7 +2,7 @@
## Auto Init
- Components are no longer initialized automatically on document load by Materialize
-- Added function `M.AutoInit()` that initializes all compo... | [
"v1-upgrade-guide.md"
] | [] | true | ||
Dogfalo/materialize | 5,942 | issue_to_patch | fix(datepicker): increase month selector width | ## Proposed changes
Increase the month selector width because it is too small to accommodate "September", "November", and "December".
## Screenshots (if appropriate) or codepen:
## Types of changes
- [... | d3d9b9cc2d5a5266110f3bab79b5c6bfd420b18d | 07f06c355dd21f96e2497152ebf61a5528ff9493 | diff --git a/sass/components/_datepicker.scss b/sass/components/_datepicker.scss
index d2c920b254..8d92c6f1b1 100644
--- a/sass/components/_datepicker.scss
+++ b/sass/components/_datepicker.scss
@@ -41,7 +41,7 @@
}
.select-month input {
- width: 70px;
+ width: 80px;
}
}
| [
"sass/components/_datepicker.scss"
] | [] | true | ||
Dogfalo/materialize | 6,177 | issue_to_patch | Fix dropdown section in v1 upgrade guide documentation | ## Proposed changes
This PR fixes issue #6116 which is a simple change to this line in the Dropdown section:
> Call plugin on .dropdown-content instead of .dropdown-button
As the issue points out, it should be `.dropdown-trigger` and not `.dropdown-content`.
## Types of changes
<!-- What types of changes doe... | 335ff54ffdef20be5a40b8527df8452af41cb117 | 1b12fc47e59d19f8b0d1a2d9c077ca5561fa20a1 | diff --git a/v1-upgrade-guide.md b/v1-upgrade-guide.md
index 103e705b2f..756cbc2140 100644
--- a/v1-upgrade-guide.md
+++ b/v1-upgrade-guide.md
@@ -38,7 +38,7 @@
## Dropdown
- Removed gutter option
- Removed stopPropagation option
-- Call plugin on `.dropdown-content` instead of `.dropdown-button`
+- Call plugin on `... | [
"v1-upgrade-guide.md"
] | [] | true | ||
Dogfalo/materialize | 6,125 | issue_to_patch | Fix TypeError when chips are initialized with a label. | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
This fixes the bug described in issue #6124.
## Types of changes
<!-- What types of c... | 80e8ed370487aaf1e2185b028f7deda40da94eb9 | c525dca42dcf0c7e98025b841b8e6ebcdbc96eff | diff --git a/js/chips.js b/js/chips.js
index 84fd934152..c47ff20bcd 100644
--- a/js/chips.js
+++ b/js/chips.js
@@ -361,7 +361,7 @@
_setupLabel() {
this.$label = this.$el.find('label');
if (this.$label.length) {
- this.$label.setAttribute('for', this.$input.attr('id'));
+ this.$label[0].... | [
"js/chips.js"
] | [] | true | ||
Dogfalo/materialize | 4,445 | issue_to_patch | Date- and Timepicker new layout according to md specs | @smileytechguy This is a replacement PR for PR #2732
Reworked layout for datepicker to be like the specs including a landscape and portrait-layout
Added a Timepicker with the same layout
Added timepicker to docs
landscape:
 {
"js/scrollFire.js",
"js/date_picker/picker.js",
"js/date_picker/picker.date.js",
+ "js/date_picker/picker.ti... | [
"Gruntfile.js",
"jade/page-contents/forms_content.html",
"js/date_picker/picker.date.js",
"js/date_picker/picker.js",
"js/date_picker/picker.time.js",
"js/init.js",
"sass/components/_variables.scss",
"sass/components/date_picker/_default.date.scss",
"sass/components/date_picker/_default.scss",
"sa... | [] | true | ||
Dogfalo/materialize | 6,035 | issue_to_patch | Fixed typo in tooltips docs page. | "I am tooltip" to "I am a tooltip"
| 5759200bac2b02d1efde028356b529f707b1a815 | 368a08b100b302bca06fa014c47f3b0f35b97681 | diff --git a/jade/page-contents/tooltips_content.html b/jade/page-contents/tooltips_content.html
index 6382bbc1b0..48017fa82c 100644
--- a/jade/page-contents/tooltips_content.html
+++ b/jade/page-contents/tooltips_content.html
@@ -7,7 +7,7 @@
<p>Tooltips are small, interactive, textual hints for mainly graphic... | [
"jade/page-contents/tooltips_content.html"
] | [] | true | ||
Dogfalo/materialize | 4,299 | issue_to_patch | '.fixed' sidenav with closeOnClick true closes on large screens (issue #1426) | fix issue #1426 - fixed sidenav with closeOnClick enabled
'.fixed' sideNav closes when closeOnclick:true in large screens.
http://codepen.io/anon/pen/LWpRdM
Solution: check `menu.hasClass('fixed')` and screen width before `removeMenu();`
| 400aca6e15f7cd4ff9328270b2761f6b410b75c3 | f97bf0b5e4061b10c5e6a9624de97f138583c003 | diff --git a/bin/materialize.js b/bin/materialize.js
index 4a8cad5e9d..dfbfe2397e 100644
--- a/bin/materialize.js
+++ b/bin/materialize.js
@@ -1,5 +1,5 @@
if("undefined"==typeof jQuery){var jQuery;jQuery="function"==typeof require?$=require("jquery"):$}jQuery.easing.jswing=jQuery.easing.swing,jQuery.extend(jQuery.easi... | [
"bin/materialize.js",
"js/sideNav.js"
] | [] | true | ||
Dogfalo/materialize | 5,960 | issue_to_patch | Collapsible closes on pressing enter even after being destroyed (desktop/mobile).
## Expected behavior:
- The user shouldn't be able to interact with the collapsible in any way after it's been destroyed
## Actual behavior:
- Pressing enter closes it
## Steps to Reproduce (for bugs)
```
const elemColl... | Remove all the event handlers after destroying it. | Potentially fixes [this issue](https://github.com/Dogfalo/materialize/issues/5959).
This is in no way tested and I cannot guarantee that this will work and have no side effects.
This is just meant to locate the problem that caused the bug. | 605c3591238608b2fc78583efa81f85bab694dfb | 64191e4d017e892ff407a9b22106071d57391deb | diff --git a/js/collapsible.js b/js/collapsible.js
index 6606acfb57..d7b9a28984 100644
--- a/js/collapsible.js
+++ b/js/collapsible.js
@@ -98,6 +98,11 @@
*/
_removeEventHandlers() {
this.el.removeEventListener('click', this._handleCollapsibleClickBound);
+
+ // NOTE: This is NOT tested in a... | [
"js/collapsible.js"
] | [] | true | |
Dogfalo/materialize | 5,896 | issue_to_patch | Spelling update | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
## Screenshots (if appropriate) or codepen:
<!-- Add supplemental screenshots or code ... | 07ef07d0122cec7750de07d99f312a89915d2f17 | 6a466d9068de13ec3d15cc88b19754b3836f0cb5 | diff --git a/v1-upgrade-guide.md b/v1-upgrade-guide.md
index d5ddc5a3de..8aafb1cda3 100644
--- a/v1-upgrade-guide.md
+++ b/v1-upgrade-guide.md
@@ -5,7 +5,7 @@
- Added function `M.AutoInit()` that initializes all componenets
## Character Counter
-- Automatic initialization removed, initialize it manually as shown in... | [
"v1-upgrade-guide.md"
] | [] | true | ||
Dogfalo/materialize | 5,894 | issue_to_patch | Update README.md | Replaced 2017 with 2018.
## Proposed changes
Replaced 2017 with 2018 on README.md
## Screenshots (if appropriate) or codepen:
<!-- Add supplemental screenshots or code examples. Look for a codepen template in our **[CONTRIBUTING document](https://github.com/Dogfalo/materialize/blob/master/CONTRIBUTING.md)**. --... | 1f5a935d8e65f0a53ceceaf6118a1996dc001473 | 0db3ee734f14ee69ee8a09e513fee53dacfa63bc | diff --git a/README.md b/README.md
index 91557af649..a070bdc779 100644
--- a/README.md
+++ b/README.md
@@ -88,4 +88,4 @@ We use Jasmine as our testing framework and we're trying to write a robust test
Check out the [CONTRIBUTING document](CONTRIBUTING.md) in the root of the repository to learn how you can contribute. ... | [
"README.md"
] | [] | true | ||
Dogfalo/materialize | 5,872 | issue_to_patch | Make Autocomplete sort optional | When sortFunction is falsy, do not sort.
## Proposed changes
Autocomplete item sorting should not be required.
This is helpful to users that pass in already-sorted data in the first place. Processing thus far (in `_renderDropdown`) respects the initial ordering from `options.data`.
## Types of changes
<!-- W... | 62b7c01803c7da60075fc3b63ccfbd48b8882639 | a82e104d1595c44e5c9e72484db7a09fd060a129 | diff --git a/jade/page-contents/autocomplete_content.html b/jade/page-contents/autocomplete_content.html
index 3233900112..dca1cfef85 100644
--- a/jade/page-contents/autocomplete_content.html
+++ b/jade/page-contents/autocomplete_content.html
@@ -119,6 +119,7 @@ <h5 class="method-header">
return a.indexOf(inputStr... | [
"jade/page-contents/autocomplete_content.html",
"js/autocomplete.js"
] | [] | true | ||
Dogfalo/materialize | 5,865 | issue_to_patch | Fix typo for hovered dropdown destroy | There was obviously a typo `removeEventHandlers` instead of `removeEventListener`
## Proposed changes
Replace with the correct calls
## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or fea... | de402e483deba6f7ba635d9910ec9e34a9846c7d | 7fe6f82ea7121f31a09942d5f7b2e0b22abd1466 | diff --git a/js/dropdown.js b/js/dropdown.js
index 041747ca92..516327053b 100644
--- a/js/dropdown.js
+++ b/js/dropdown.js
@@ -148,9 +148,9 @@
this.dropdownEl.removeEventListener('click', this._handleDropdownClickBound);
if (this.options.hover) {
- this.el.removeEventHandlers('mouseenter', this._... | [
"js/dropdown.js",
"tests/spec/dropdown/dropdownFixture.html",
"tests/spec/dropdown/dropdownSpec.js"
] | [] | diff --git a/tests/spec/dropdown/dropdownFixture.html b/tests/spec/dropdown/dropdownFixture.html
index 8499e44bf5..1df210b8e2 100644
--- a/tests/spec/dropdown/dropdownFixture.html
+++ b/tests/spec/dropdown/dropdownFixture.html
@@ -24,5 +24,19 @@
<li class="divider"></li>
<li><a href="#!">three</a></li>
... | true | |
Dogfalo/materialize | 5,856 | issue_to_patch | Use Prettier pre-commit hook | Use Prettier to control formatting | 1ce0d324e110da31aba7cabd36232870b0e63e3b | 7a741df5f89235361066526325517c276f1b9033 | diff --git a/.prettierignore b/.prettierignore
new file mode 100644
index 0000000000..d182156034
--- /dev/null
+++ b/.prettierignore
@@ -0,0 +1,7 @@
+js/anime.min.js
+js/cash.js
+js/waves.js
+js/jquery.timeago.min.js
+node_modules/
+package.json
+package.json.lock
\ No newline at end of file
diff --git a/.prettierrc b/... | [
".prettierignore",
".prettierrc",
"js/autocomplete.js",
"js/buttons.js",
"js/cards.js",
"js/carousel.js",
"js/characterCounter.js",
"js/chips.js",
"js/collapsible.js",
"js/component.js",
"js/datepicker.js",
"js/dropdown.js",
"js/forms.js",
"js/global.js",
"js/init.js",
"js/materialbox.... | [] | true | ||
Dogfalo/materialize | 5,831 | issue_to_patch | tests: use npm ci | `npm ci` is much faster and is meant for CI. This PR is meant for evaluating the new ci command and testig the performance and compare the logs of Travis CI.
https://docs.npmjs.com/cli/ci
http://blog.npmjs.org/post/171556855892/introducing-npm-ci-for-faster-more-reliable | ed97b01971f1cfd8c28485ade36907c75c07bbb7 | 53523ef98631a1b3cfadb654476aa2529a40746d | diff --git a/.travis.yml b/.travis.yml
index 2e4529590d..e6681e0738 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,6 +2,8 @@ language: node_js
node_js:
- "6.10"
before_install:
+ - npm install -g npm@latest
- npm install -g grunt-cli
+install: npm ci
git:
depth: 10
diff --git a/package-lock.json b/packag... | [
".travis.yml",
"package-lock.json"
] | [] | true | ||
Dogfalo/materialize | 5,849 | issue_to_patch | Add @YourLabs Patreon Sponsor logo | Add logo for Patreon Sponsor. | ed97b01971f1cfd8c28485ade36907c75c07bbb7 | dfe1fc8ae055e20ee334c3513416f3715851cda7 | diff --git a/jade/_footer.html b/jade/_footer.html
index 283cdf0126..8c5c436fc8 100644
--- a/jade/_footer.html
+++ b/jade/_footer.html
@@ -29,6 +29,11 @@ <h5>Connect</h5>
<h5>Patreon Sponsors</h5>
</div>
<div class="col s12">
+ <div class="patreon-footer-ad"... | [
"jade/_footer.html"
] | [] | true | ||
Dogfalo/materialize | 5,726 | issue_to_patch | Added missing closing `</p>` in README.md | Also fixed indentation
## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
## Screenshots (if appropriate) or codepen:
<!-- Add supplem... | fcb983879b788bab3ce7011222331a79ab4c4c40 | dae069702e6a3cfe29a1fae3cd344c1d7c2234ed | diff --git a/README.md b/README.md
index 796d6cb3f0..796d89f6dd 100644
--- a/README.md
+++ b/README.md
@@ -2,33 +2,34 @@
<a href="http://materializecss.com/">
<img src="http://materializecss.com/res/materialize.svg" width="150">
</a>
+</p>
- <h3 align="center">MaterializeCSS</h3>
+<h3 align="center">Mater... | [
"README.md"
] | [] | true | ||
Dogfalo/materialize | 5,783 | issue_to_patch | Remove ugly collapsible-header blue focus box | ## Proposed changes
Just added an outline rule to the collapsible-header. This way, it won't show the blue box on focus, which is kind of ugly.
## Screenshots (if appropriate) or codepen:
<img width="800" alt="screen shot 2018-03-30 at 18 15 24" src="https://user-images.githubusercontent.com/16862997/38144835-bb5c7c... | 21749fa5d29975a1338c99e451b7e6a7a6d470d5 | 4e7495368c54943b60688635f723ec9e9592521a | diff --git a/sass/components/_collapsible.scss b/sass/components/_collapsible.scss
index 5793a3f51f..c65be5766b 100644
--- a/sass/components/_collapsible.scss
+++ b/sass/components/_collapsible.scss
@@ -24,6 +24,10 @@
}
}
+.collapsible-header:focus {
+ outline: 0
+}
+
.collapsible-body {
display: none;
bo... | [
"sass/components/_collapsible.scss"
] | [] | true | ||
Dogfalo/materialize | 5,782 | issue_to_patch | Add beta install commands/links to README | Helps fix issues like https://github.com/Dogfalo/materialize/issues/1031#issuecomment-377336372
## Proposed changes
Update readme getting started section
## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaki... | 08bfb6942c759975616ebc23c9a80431135d60ce | f4f232632e00e8762b704e40fb58e44fa96090b5 | diff --git a/README.md b/README.md
index 796d89f6dd..91557af649 100644
--- a/README.md
+++ b/README.md
@@ -44,12 +44,12 @@
## Quickstart:
Read the [getting started guide](http://materializecss.com/getting-started.html) for more information on how to use materialize.
-- [Download the latest release](https://github.c... | [
"README.md"
] | [] | true | ||
Dogfalo/materialize | 5,695 | issue_to_patch | Re-add background-color property of card action class | ## Proposed changes
PR raised to fix issue detailed at #5691
## Screenshots (if appropriate) or codepen:
Screenshot of the Materialize "next" site on the left with the current styling and modified content to showcase overflow issue with the card action class, and on the right, a local build of the same documentat... | f4cdab2b5c4815dd935456f6478ae2c9e2c7a642 | f90d399632e987c6b3dece2e102b963b23a87354 | diff --git a/sass/components/_cards.scss b/sass/components/_cards.scss
index eb022bfff6..6931e5711c 100644
--- a/sass/components/_cards.scss
+++ b/sass/components/_cards.scss
@@ -161,6 +161,7 @@
border-radius: 0 0 2px 2px;
}
position: relative;
+ background-color: #fff;
border-top: 1px solid rg... | [
"sass/components/_cards.scss"
] | [] | true | ||
Dogfalo/materialize | 5,676 | issue_to_patch | #4168 Adjust label of date and time input types | ## Proposed changes
Adjust label of date and time input types. Described on issue [4168](https://github.com/Dogfalo/materialize/issues/4168).
Summary of changes:
- Adjust JS to add/remove `active` css class on labels on focus/blur
- Adjust SASS to keep labels in the same position even without focus
## Screenshot... | 9629887bf2947131df1f9acae96ccb9155471914 | d3de6478e9f89af885a6b983cd5d6c65f28db189 | diff --git a/js/forms.js b/js/forms.js
index c277cbf929..d8898917fd 100644
--- a/js/forms.js
+++ b/js/forms.js
@@ -1,7 +1,7 @@
(function ($) {
// Function to update labels of text fields
M.updateTextFields = function() {
- let input_selector = 'input[type=text], input[type=password], input[type=email], input[... | [
"js/forms.js",
"sass/components/forms/_input-fields.scss"
] | [] | true | ||
Dogfalo/materialize | 5,686 | issue_to_patch | Rename plugin call material_select() to formSelect() | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
## Screenshots (if appropriate) or codepen:
<!-- Add supplemental screenshots or code ... | a9a87f4f9cec5e7412a097a132c64cb8ff671663 | a9f113df9c745c85b8ef218145b131fc3376e9c0 | diff --git a/v1-upgrade-guide.md b/v1-upgrade-guide.md
index 6de0b75815..7fca0c473a 100644
--- a/v1-upgrade-guide.md
+++ b/v1-upgrade-guide.md
@@ -29,7 +29,7 @@
## Select
-- Rename plugin call `.material_select()` to `.select()`
+- Rename plugin call `.material_select()` to `.formSelect()`
## Feature Discover... | [
"v1-upgrade-guide.md"
] | [] | true | ||
Dogfalo/materialize | 5,481 | issue_to_patch | Change of SCSS file importing | This change allows fourseven:scss of Meteor.JS to import the files SCSS of this package.
Now we can do `@import '{materialize:materialize}/sass/components/_variables.scss';` in Meteor when this change will be apply.
## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue). | 9478ad787bdc12eb7d13362c0769792bfd20c0ed | 3faa4cb2f826640d633dadd56285672e785879db | diff --git a/package.js b/package.js
index 9998fc76a9..d7d7dfa5b0 100644
--- a/package.js
+++ b/package.js
@@ -61,7 +61,7 @@ Package.onUse(function (api) {
'sass/materialize.scss'
];
- api.addFiles(scssFiles, 'client');
+ api.addFiles(scssFiles, 'client', { isImport: true });
api.export('Materialize'... | [
"package.js"
] | [] | true | ||
Dogfalo/materialize | 5,659 | issue_to_patch | Deleted links to nonexistent resources | ## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing functiona... | fd4e61784b97d946926c285a20a18d541bdd68ac | 1f97f7956fa7bd5efe9f8b61e29b4d87eccb6e41 | diff --git a/sitemap.xml b/sitemap.xml
index 4371dc7755..9e39a078a0 100644
--- a/sitemap.xml
+++ b/sitemap.xml
@@ -24,14 +24,6 @@
<loc>http://materializecss.com/collapsible.html</loc>
<lastmod>2014-11-27</lastmod>
</url>
- <url>
- <loc>http://materializecss.com/bin/materialize-sass_v0.82.zip</loc>
- ... | [
"sitemap.xml"
] | [] | true | ||
Dogfalo/materialize | 5,664 | issue_to_patch | Fix for https://github.com/Dogfalo/materialize/issues/5663 | make sure i18n defaults are not lost when single i18n options are passed
## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
## Screensh... | fd4e61784b97d946926c285a20a18d541bdd68ac | f85723ccd6f9cd6a50361c31e14acfe5a653150e | diff --git a/js/datepicker.js b/js/datepicker.js
index a4a5e4310a..81eb17ea9d 100644
--- a/js/datepicker.js
+++ b/js/datepicker.js
@@ -92,6 +92,11 @@
this.el.M_Datepicker = this;
this.options = $.extend({}, Datepicker.defaults, options);
+
+ // make sure i18n defaults are not lost when only f... | [
"js/datepicker.js"
] | [] | true | ||
Dogfalo/materialize | 5,657 | issue_to_patch | add noopener to external links | `rel="noopener"` should be used for external links for better security | 69da23a6e0624deeaa2950469d6aee8b5151fac2 | c8948cbde263711739edcca54ceba6419687b6d0 | diff --git a/jade/_footer.html b/jade/_footer.html
index c24f2b041e..e9586a3c32 100644
--- a/jade/_footer.html
+++ b/jade/_footer.html
@@ -30,44 +30,44 @@ <h5>Patreon Sponsors</h5>
</div>
<div class="col s12">
<div class="patreon-footer-ad">
- <a href="htt... | [
"jade/_footer.html"
] | [] | true | ||
Dogfalo/materialize | 5,640 | issue_to_patch | update footer copyright year, make it dynamic | 595185077effc967f77d7bed48245c86bd280773 | 31d58c8bc053f853b0f2ad0d5c3a62a81aef934f | diff --git a/jade/_footer.html b/jade/_footer.html
index b774583b8d..270b69e600 100644
--- a/jade/_footer.html
+++ b/jade/_footer.html
@@ -48,7 +48,7 @@ <h5>Patreon Sponsors</h5>
</div>
<div class="footer-copyright">
- © 2014-2017 Materialize, All rights reserved.
+ ... | [
"jade/_footer.html"
] | [] | true | |||
Dogfalo/materialize | 5,347 | issue_to_patch | Fixed inline input field in documentation | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
In the documentation (in Forms > Text Inputs), after clicking on the full-column "Email... | 632ec5c6e75815aeae3c53723e3ad18a5cb4a764 | e26baaee22417242d7d0665d7d77f4d41b442e52 | diff --git a/jade/page-contents/text_inputs_content.html b/jade/page-contents/text_inputs_content.html
index b6dbdae6af..f15a21baa3 100644
--- a/jade/page-contents/text_inputs_content.html
+++ b/jade/page-contents/text_inputs_content.html
@@ -46,8 +46,8 @@ <h3 class="header">Input fields</h3>
<div class=... | [
"jade/page-contents/text_inputs_content.html"
] | [] | true | ||
Dogfalo/materialize | 5,595 | issue_to_patch | Removed carousel methods on chips documentation | ## Proposed changes
Updated the methods section of the Chips documentation to remove some old Carousel examples that aren't applicable.
## Types of changes
- [x] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or fea... | ed4ae6f810ebc10463647a1e20fa6efa21d653d8 | 7ac83d5628c5081d0faa6c3e46caab96c2a0cb1f | diff --git a/jade/page-contents/chips_content.html b/jade/page-contents/chips_content.html
index cb2d02efb6..c590a933ce 100644
--- a/jade/page-contents/chips_content.html
+++ b/jade/page-contents/chips_content.html
@@ -186,14 +186,14 @@ <h3 class="header">Methods</h3>
<blockquote>
<p>Because jQuery ... | [
"jade/page-contents/chips_content.html"
] | [] | true | ||
Dogfalo/materialize | 5,587 | issue_to_patch | Deprecate bower in docs (#5586) | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
## Screenshots (if appropriate) or codepen:
<!-- Add supplemental screenshots or code ... | 69fc408639d4ac3a87916942d230b8cb1089a573 | 644e1e9708673983aaa4b77bd97ea6bb78f6d8c6 | diff --git a/README.md b/README.md
index a58af6d96e..796d6cb3f0 100644
--- a/README.md
+++ b/README.md
@@ -47,7 +47,7 @@ Read the [getting started guide](http://materializecss.com/getting-started.html)
- Clone the repo: `git clone https://github.com/Dogfalo/materialize.git`
- Include the files via [cdnjs](https://cdn... | [
"README.md",
"jade/getting_started/getting_started_content.html"
] | [] | true | ||
Dogfalo/materialize | 5,573 | issue_to_patch | Datepicker formats fix | ## Proposed changes
fixes for datepicker formats (see #5516)
## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Br... | 3cb0791de80edbff33ee4a53aa422d4ff2af6149 | 656f32dfd0739bbfa32b237d8faab44000b527dd | diff --git a/jade/page-contents/pickers_content.html b/jade/page-contents/pickers_content.html
index dbb2d58734..2c102837b4 100644
--- a/jade/page-contents/pickers_content.html
+++ b/jade/page-contents/pickers_content.html
@@ -176,10 +176,15 @@ <h5>Date format options</h5>
<tbody>
<tr>
- ... | [
"jade/page-contents/pickers_content.html",
"js/datepicker.js"
] | [] | true | ||
Dogfalo/materialize | 5,292 | issue_to_patch | tabs with anchor tags with href having a slash following the hash causes an error
When anchor tags in tabs are defined with a forward slash ('/') following the hash ('#') like href='#/link' (this is an angular route) this causes an error at runtime.
 for v1. | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
fix error when hash contains slash ('/').
fix #2848
The same fix for v0.x is in #5291 ... | 668692081a95888d61f0c34da9f384b64d1ca017 | 3b58f3f3c23f7713c8659f8d5a2435ea1c2ff64d | diff --git a/.gitignore b/.gitignore
index 13aa535d7e..f3a7f23a5e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,6 +3,7 @@
.cache
.DS_Store
.idea
+.vs
.project
.projectile
.settings
diff --git a/js/global.js b/js/global.js
index f20fd847b7..218c8b90ab 100644
--- a/js/global.js
+++ b/js/global.js
@@ -121,7 +121,7 ... | [
".gitignore",
"js/global.js"
] | [] | true | |
Dogfalo/materialize | 5,546 | issue_to_patch | Correctly set chipsInstance.autocomplete, plus docs! | ## Proposed changes
chips instance `.autocomplete` was being set to `undefined`, now the underlying autocomplete instance is correctly exposed.
## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an i... | 3cb0791de80edbff33ee4a53aa422d4ff2af6149 | bc35a8365c2bb57b5877da3da42ce67e776abb6f | diff --git a/jade/page-contents/chips_content.html b/jade/page-contents/chips_content.html
index 7b37cac369..45c022b4e8 100644
--- a/jade/page-contents/chips_content.html
+++ b/jade/page-contents/chips_content.html
@@ -279,6 +279,11 @@ <h3 class="header">Properties</h3>
<td>Boolean</td>
<t... | [
"jade/page-contents/chips_content.html",
"js/chips.js"
] | [] | true | ||
Dogfalo/materialize | 5,583 | issue_to_patch | update scss file list in meteor package | Fixes https://github.com/Dogfalo/materialize/issues/5275#issuecomment-359274630
> I also tried cloning the current v1-dev branch, but it failed to build with another error message (Error: ENOENT: no such file or directory, open 'E:\myproj\packages\materialize\sass\components\date_picker\_default.date.scss'). | 03c3fd805a42a3a0b752ac0421c41f476ab5b31f | 3e1ac2425f3a58a0e4ef06870ee28cb6b8a42d1f | diff --git a/package.js b/package.js
index 07e4a7bb82..cafca37955 100644
--- a/package.js
+++ b/package.js
@@ -18,9 +18,6 @@ Package.onUse(function (api) {
], 'client');
var scssFiles = [
- 'sass/components/date_picker/_default.date.scss',
- 'sass/components/date_picker/_default.scss',
- 'sass/componen... | [
"package.js"
] | [] | true | ||
Dogfalo/materialize | 5,551 | issue_to_patch | Update modal.js to properly call onOpenStart |
## Proposed changes
the initialization of this._openingTrigger happens AFTER the onOpenStart callback; this means the callback receives "undefined" the very first time it's called and in the subsequent calls
it receives the element that triggered the previous modal open
by moving the initialization before the o... | 3cb0791de80edbff33ee4a53aa422d4ff2af6149 | dba86dd0dc2739e602a4cec7ade6dd48f0ccc99d | diff --git a/js/modal.js b/js/modal.js
index 3958f0f307..3c92e06b0a 100644
--- a/js/modal.js
+++ b/js/modal.js
@@ -279,6 +279,9 @@
this.isOpen = true;
+ // Set opening trigger, undefined indicates modal was opened by javascript
+ this._openingTrigger = !!$trigger ? $trigger[0] : undefined;
+
... | [
"js/modal.js"
] | [] | true | ||
Dogfalo/materialize | 4,802 | issue_to_patch | Display browser-default for inputs | Added pseudo classes to the input selectors so that "browser-defaults" can be applied to other input fields. This is a replacement PR for #4041
closes Dogfalo/materialize#4041
closes Dogfalo/materialize#3975
closes Dogfalo/materialize#4764 | f951eac8e3d1bde08e996f8d0ed7a31c5f3d3154 | 7fb38e091f9b8add541f1a679b1c08720043645f | diff --git a/jade/page-contents/helpers_content.html b/jade/page-contents/helpers_content.html
index 8610c4f99a..ee57ce7c44 100644
--- a/jade/page-contents/helpers_content.html
+++ b/jade/page-contents/helpers_content.html
@@ -166,6 +166,10 @@ <h2 class="header">Browser Defaults</h2>
<td>SELECT</td>
... | [
"jade/page-contents/helpers_content.html",
"sass/components/forms/_input-fields.scss"
] | [] | true | ||
Dogfalo/materialize | 5,532 | issue_to_patch | Aligned helper-text with inputs when using prefix | ## Proposed changes
Horizontally aligns the helper-text with input, labels etc. when using a prefix.
## Screenshots (if appropriate) or codepen:
Misaligned
Aligned
![aligned](https://user-images... | ed60e56322db195e5faa54ed3f3ac4cd84c0744e | d9de93b70d823cdd0490e1cc10252356213a9441 | diff --git a/sass/components/forms/_input-fields.scss b/sass/components/forms/_input-fields.scss
index 488fcfb12d..32d1659572 100644
--- a/sass/components/forms/_input-fields.scss
+++ b/sass/components/forms/_input-fields.scss
@@ -222,6 +222,7 @@ textarea.materialize-textarea {
.prefix ~ textarea,
.prefix ~ label... | [
"sass/components/forms/_input-fields.scss"
] | [] | true | ||
Dogfalo/materialize | 5,517 | issue_to_patch | 2017 -> 2018 | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
License year is outdated
## Screenshots (if appropriate) or codepen:
<!-- Add supplem... | 13b1cdfb14b2746a56d45176704d0587f0ef443c | 1a5f220843aa0fd5979851e8f76e28a60c6115c2 | diff --git a/LICENSE b/LICENSE
index 44bd03eab7..fcff17ec0d 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,6 +1,6 @@
The MIT License (MIT)
-Copyright (c) 2014-2017 Materialize
+Copyright (c) 2014-2018 Materialize
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associat... | [
"LICENSE"
] | [] | true | ||
Dogfalo/materialize | 5,514 | issue_to_patch | Pass correct element reference to Autocomplete.init | ## Proposed changes
[Chips](http://next.materializecss.com/chips.html) feature is broken in v1-dev (Throwing `TypeError: .Autocomplete.init(...) is null @ chips.js:340:26`). This simple fix makes it work (passes the element itself to the .init call instead of the container jquery-like object.
## Types of changes
... | 13b1cdfb14b2746a56d45176704d0587f0ef443c | 2f6c00c00c1385af94d397581f6632d4e05c5134 | diff --git a/js/chips.js b/js/chips.js
index 87c0a4feaf..968a4e5520 100644
--- a/js/chips.js
+++ b/js/chips.js
@@ -337,7 +337,7 @@
this.$input[0].focus();
};
- this.autocomplete = M.Autocomplete.init(this.$input, this.options.autocompleteOptions)[0];
+ this.autocomplete = M.Autocomplete.init... | [
"js/chips.js"
] | [] | true | ||
Dogfalo/materialize | 5,506 | issue_to_patch | Trailing whitespaces | - [ ] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing functionality to change).
- [x] I have read the **[CONTRIBUTING document](https://github.com/Dogfalo/materialize/blob/master/CO... | 36940460f1d805ec0b721302e68c500592f37b13 | 5b4a53504c1bad10d68c687d1ba6118aa85cca45 | diff --git a/sass/components/_global.scss b/sass/components/_global.scss
index cf12e6197c..0aaff21f92 100644
--- a/sass/components/_global.scss
+++ b/sass/components/_global.scss
@@ -489,7 +489,7 @@ td, th{
min-height: 1.25em;
text-align: left;
}
- tr {
+ tr {
border-bottom: none;
... | [
"sass/components/_global.scss",
"tests/spec/cards/cardsSpec.js"
] | [] | diff --git a/tests/spec/cards/cardsSpec.js b/tests/spec/cards/cardsSpec.js
index 85c7d7242c..61412a41e5 100644
--- a/tests/spec/cards/cardsSpec.js
+++ b/tests/spec/cards/cardsSpec.js
@@ -20,16 +20,16 @@ describe( "Cards", function () {
setTimeout(function() {
activator.click();
-
+
se... | true | |
Dogfalo/materialize | 5,325 | issue_to_patch | Fixed grammar in issue template | ## Proposed changes
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
Fix a few grammar mistakes in the issue template.
## Types of changes
<!-- What typ... | da2376efd2f749aa1616f6803e1a173ded342f46 | bad776da3ad74a3f6c7584bb768fd5ace507861f | diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
index c06679e296..2b3eacc268 100644
--- a/.github/ISSUE_TEMPLATE.md
+++ b/.github/ISSUE_TEMPLATE.md
@@ -1,11 +1,11 @@
-<!-- Before opening an issue here make sure, that you have read the template completly through -->
+<!-- Before opening an issue here ... | [
".github/ISSUE_TEMPLATE.md"
] | [] | true | ||
Dogfalo/materialize | 5,474 | issue_to_patch | Clean elses | ## Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing functionality to change).
## Checklist:
- [x] I have read the **[CONTRIBUTING document](https://github.co... | 9478ad787bdc12eb7d13362c0769792bfd20c0ed | 3b0a7acae2bbf65d577fc1bbc5fa7c16897bf621 | diff --git a/js/carousel.js b/js/carousel.js
index d7f6ffcc4e..9bf49d680b 100644
--- a/js/carousel.js
+++ b/js/carousel.js
@@ -644,9 +644,9 @@
if (index > this.count || index < 0) {
if (this.noWrap) {
return;
- } else {
- index = this._wrap(index);
}
+
+ index ... | [
"js/carousel.js",
"js/cash.js",
"js/chips.js",
"js/datepicker.js",
"js/global.js",
"js/tooltip.js"
] | [] | true | ||
Dogfalo/materialize | 5,477 | issue_to_patch | Datepicker Timepicker fix. doc update. | ## Proposed changes
fix a bug by change modal's complete callback (not available now) to onCloseEnd.
fix Timepicker does not initialize correctly.
update documentation.
<!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or... | 9478ad787bdc12eb7d13362c0769792bfd20c0ed | fcab3dc3a75493e47c22d5a6a1463366c6f18d22 | diff --git a/jade/page-contents/pickers_content.html b/jade/page-contents/pickers_content.html
index a235eca2bf..dbb2d58734 100644
--- a/jade/page-contents/pickers_content.html
+++ b/jade/page-contents/pickers_content.html
@@ -46,15 +46,9 @@ <h5>Options</h5>
<tr>
<td>format</td>
... | [
"jade/page-contents/pickers_content.html",
"js/datepicker.js",
"js/timepicker.js"
] | [] | true | ||
Dzoukr/Dapper.FSharp | 112 | issue_to_patch | Fix: Handle F# 10 BlockExpression in LINQ visitors for joined queries | In F# 10, tuple-destructuring lambdas (e.g. `fun (a, b) -> ...`) used in `where`, `groupBy`, `join`, and `orderBy` clauses of joined queries are compiled as `BlockExpression` LINQ expression trees. Dapper.FSharp's `visitWhere`, `visitGroupBy`, `visitJoin`, and `visitPropertySelector` functions did not handle `Expressio... | 15813dc418e9ed6f9d8c4b4eb6cd27d65f9dd816 | 0e16a31a3afba4f7de12a20c4022178404ee7e04 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index b9052bc..8f0eaf7 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "8.0.3",
+ "version": "10.3.1",
"commands": [
"paket"
... | [
".config/dotnet-tools.json",
".paket/Paket.Restore.targets",
"global.json",
"pack.sh",
"paket.dependencies",
"paket.lock",
"src/Dapper.FSharp/Dapper.FSharp.fsproj",
"src/Dapper.FSharp/MSSQL/LinqExpressionVisitors.fs",
"src/Dapper.FSharp/MySQL/LinqExpressionVisitors.fs",
"src/Dapper.FSharp/PostgreS... | [] | diff --git a/tests/Dapper.FSharp.Tests/Dapper.FSharp.Tests.fsproj b/tests/Dapper.FSharp.Tests/Dapper.FSharp.Tests.fsproj
index a601c4c..f573343 100644
--- a/tests/Dapper.FSharp.Tests/Dapper.FSharp.Tests.fsproj
+++ b/tests/Dapper.FSharp.Tests/Dapper.FSharp.Tests.fsproj
@@ -2,7 +2,7 @@
<Project Sdk="Microsoft.NET.Sdk">
... | true | |
Dzoukr/Dapper.FSharp | 110 | issue_to_patch | Add notes about views and type definition for select | It wasn't clear to me that I could query a View or that I didn't have to define all of the columns.
[I created an issue for it and have a response](https://github.com/Dzoukr/Dapper.FSharp/issues/109) | 85ea05e5b7583a6313f7296c50092b053f088195 | 350632b2618bd02a2b569cc06a319bd4457d1d10 | diff --git a/README.md b/README.md
index ca4083f..39aa13f 100644
--- a/README.md
+++ b/README.md
@@ -268,6 +268,10 @@ select {
NOTE: You also need to use `selectAll` if you have a no `where` and no `orderBy` clauses because a query cannot consist of only `for` or `join` statements.
+NOTE: The type does not have to... | [
"README.md"
] | [] | true | ||
Dzoukr/Dapper.FSharp | 107 | issue_to_patch | Fix/106 sqlite string option handler | This PR fixes issue #106
(For some further clarity on the issue, when looking further into the problem it was when using parameterised queries, and also when "materialising" an object from a select statement. Both test added cover the select part, and I put the non-parameterised test using the standard `select` sta... | ab204cda3fade6d6e5df7a07db77105d800b29a5 | 073089c08466abbb7a4dc41e8e99fa0e33522441 | diff --git a/src/Dapper.FSharp/SQLite/OptionTypes.fs b/src/Dapper.FSharp/SQLite/OptionTypes.fs
index 15b7aca..ff4ce83 100644
--- a/src/Dapper.FSharp/SQLite/OptionTypes.fs
+++ b/src/Dapper.FSharp/SQLite/OptionTypes.fs
@@ -30,6 +30,7 @@ type SqliteOptionSByteHandler() = inherit OptionTypeHandlerWithConverte
typ... | [
"src/Dapper.FSharp/SQLite/OptionTypes.fs",
"tests/Dapper.FSharp.Tests/Database.fs",
"tests/Dapper.FSharp.Tests/MSSQL/Database.fs",
"tests/Dapper.FSharp.Tests/MySQL/Database.fs",
"tests/Dapper.FSharp.Tests/PostgreSQL/Database.fs",
"tests/Dapper.FSharp.Tests/SQLite/Database.fs",
"tests/Dapper.FSharp.Tests... | [] | diff --git a/tests/Dapper.FSharp.Tests/Database.fs b/tests/Dapper.FSharp.Tests/Database.fs
index 6883254..f12ba32 100644
--- a/tests/Dapper.FSharp.Tests/Database.fs
+++ b/tests/Dapper.FSharp.Tests/Database.fs
@@ -17,6 +17,7 @@ type ICrudInitializer =
abstract member InitDogsWeights : unit -> Task<unit>
abstra... | true | |
Dzoukr/Dapper.FSharp | 95 | issue_to_patch | andWhereIf, orWhereIf | Adding new custom operations: `andWhereIf`, `orWhereIf`.
They get `bool` condition as first parameter and acts as `andWhere`, `orWhere` if condition holds and do nothing otherwise.
It allows to optionally extend WHERE condition based on parameters outside of query.
```F#
let pos = Some 10
let posOr = Some 2
select {... | 7ab095e827d31c1a2aa76de56960fb32b4b38df8 | dd53c13cf991a963e437bcd817565cdd16ed07ae | diff --git a/README.md b/README.md
index fcc028e..ca4083f 100644
--- a/README.md
+++ b/README.md
@@ -297,6 +297,19 @@ select {
} |> conn.SelectAsync<Person>
```
+To conditionally add `where` part, you can use `andWhereIf` and `orWhereIf`:
+
+```F#
+let pos = Some 10
+let posOr = Some 2
+select {
+ for p in perso... | [
"README.md",
"src/Dapper.FSharp/MSSQL/Builders.fs",
"src/Dapper.FSharp/MySQL/Builders.fs",
"src/Dapper.FSharp/PostgreSQL/Builders.fs",
"src/Dapper.FSharp/SQLite/Builders.fs",
"tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs",
"tests/Dapper.FSharp.Tests/MySQL/SelectTests.fs",
"tests/Dapper.FSharp.Tests/... | [] | diff --git a/tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs b/tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs
index 3157f14..8303b4e 100644
--- a/tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs
+++ b/tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs
@@ -388,6 +388,58 @@ type SelectTests () =
Assert.AreEqual(2, ... | true | |
Dzoukr/Dapper.FSharp | 94 | issue_to_patch | andWhere, orWhere | This is follow up based on discussion in #89.
Adding new custom operations: `andWhere`, `orWhere`.
They allow combine `WHERE` condition defined so far with new condition.
- multiple `andWhere`, `orWhere` can be used to build complex `WHERE` condition
- first `andWhere`, `orWhere` without `where` before it be... | 4f9de72bc004a335276fd520c7a10ac837b17348 | cd32066c6b92ce7c767a4f64bcc42207188565e2 | diff --git a/README.md b/README.md
index 54bf561..fcc028e 100644
--- a/README.md
+++ b/README.md
@@ -286,6 +286,17 @@ select {
} |> conn.SelectAsync<Person>
```
+You can also combine multiple `where` conditions with `andWhere` and `orWhere`:
+
+```F#
+select {
+ for p in personTable do
+ where (p.Position > 5... | [
"README.md",
"src/Dapper.FSharp/MSSQL/Builders.fs",
"src/Dapper.FSharp/MySQL/Builders.fs",
"src/Dapper.FSharp/PostgreSQL/Builders.fs",
"src/Dapper.FSharp/SQLite/Builders.fs",
"tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs",
"tests/Dapper.FSharp.Tests/MySQL/SelectTests.fs",
"tests/Dapper.FSharp.Tests/... | [] | diff --git a/tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs b/tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs
index 32f6cd9..3157f14 100644
--- a/tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs
+++ b/tests/Dapper.FSharp.Tests/MSSQL/SelectTests.fs
@@ -305,7 +305,89 @@ type SelectTests () =
Asser... | true | |
Dzoukr/Dapper.FSharp | 93 | issue_to_patch | "count" problem with inner join in v4.5.1+
I believe from v4.5.1 (and currently v4.6.0) the lib has problem with `count` and `innerJoin`. For example:
```fsharp
select {
for p in table'<{| Id: string; GameId: string |}> "Players" do
innerJoin g in table'<{| Id: string |}> "Games" on (p.GameId = g.Id)
... | Fix "count" problem with inner join | Support "count" with unqualified column, when we have qualified field.
Fix #92. | 6b642fdd5065eb4b1aa294ab45bd03351ea57094 | 6418509dfdc79d88d2606a87a9cc23ade65d7f2f | diff --git a/src/Dapper.FSharp/MSSQL/Evaluator.fs b/src/Dapper.FSharp/MSSQL/Evaluator.fs
index ca42cd3..0db4334 100644
--- a/src/Dapper.FSharp/MSSQL/Evaluator.fs
+++ b/src/Dapper.FSharp/MSSQL/Evaluator.fs
@@ -99,6 +99,7 @@ let replaceFieldWithAggregate (aggr:(string * string) list) (field:string) =
|> List.tryPick... | [
"src/Dapper.FSharp/MSSQL/Evaluator.fs",
"src/Dapper.FSharp/MySQL/Evaluator.fs",
"src/Dapper.FSharp/PostgreSQL/Evaluator.fs",
"src/Dapper.FSharp/SQLite/Evaluator.fs",
"tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs",
"tests/Dapper.FSharp.Tests/MySQL/AggregatesTests.fs",
"tests/Dapper.FSharp.Tests/Pos... | [] | diff --git a/tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs b/tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs
index 96f7b2b..c1dd971 100644
--- a/tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs
+++ b/tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs
@@ -337,4 +337,36 @@ type AggregatesTests () =
... | true |
Dzoukr/Dapper.FSharp | 91 | issue_to_patch | countDistinct, countByDistinct operations; fix countBy | Support `COUNT(DISTINCT column)` via new custom operations `countDistinct`, `countByDistinct`.
Fix `countBy` operation, so it actually works :) | b220ba36f5c56f036210ba261b05ab17431a42f8 | acc51439e2d70ee7a0d99986cf2439d0149e1d25 | diff --git a/src/Dapper.FSharp/MSSQL/Builders.fs b/src/Dapper.FSharp/MSSQL/Builders.fs
index 79bc0fc..36301a2 100644
--- a/src/Dapper.FSharp/MSSQL/Builders.fs
+++ b/src/Dapper.FSharp/MSSQL/Builders.fs
@@ -265,7 +265,22 @@ type SelectExpressionBuilder<'T>() =
member this.CountBy (state:QuerySource<'T>, [<Projection... | [
"src/Dapper.FSharp/MSSQL/Builders.fs",
"src/Dapper.FSharp/MSSQL/Domain.fs",
"src/Dapper.FSharp/MSSQL/Evaluator.fs",
"src/Dapper.FSharp/MySQL/Builders.fs",
"src/Dapper.FSharp/MySQL/Domain.fs",
"src/Dapper.FSharp/MySQL/Evaluator.fs",
"src/Dapper.FSharp/PostgreSQL/Builders.fs",
"src/Dapper.FSharp/Postgre... | [] | diff --git a/tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs b/tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs
index 96132b0..96f7b2b 100644
--- a/tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs
+++ b/tests/Dapper.FSharp.Tests/MSSQL/AggregatesTests.fs
@@ -35,6 +35,27 @@ type AggregatesTests () =
... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.