repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Hmbown/CodeWhale | 2,800 | issue_to_patch | feat(config): add Xiaomi MiMo token plan mode | Harvests the narrow Xiaomi MiMo Token Plan mode/env-selection/docs slice from #2627 by @xyuai for the v0.9.0 stewardship branch.
Credits #2621 reported by @springeye. This does not close #2621; remaining scope there includes model-list behavior, credit/cost display, and rate-limit awareness.
What landed:
- Adds `prov... | 15c506b777e1a5327c08c801e2075d14cb3ec73e | be37dbd34e27ebc1e9abb10198ae5dc4f8b9f958 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 853b9c575..929cdbd58 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -65,6 +65,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
`SOFYA_API_KEY` fallback, while keeping Sofya scoped to web search rather
than model-provider routing... | [
"CHANGELOG.md",
"README.md",
"README.zh-CN.md",
"config.example.toml",
"crates/config/src/lib.rs",
"crates/tui/CHANGELOG.md",
"crates/tui/src/config.rs",
"docs/CONFIGURATION.md",
"docs/PROVIDERS.md"
] | [
{
"comment": "\n\nIn the current implementation, if both `mode` and `base_url` are provided, the `base_url` inference can override an explicitly configured `mode`. For example, if `mode` is set to `\"token-plan-cn\"` but `base_url` is configu... | true | ||
Hmbown/CodeWhale | 2,770 | issue_to_patch | fix(mcp): harvest trusted workspace MCP config | ## Summary
- harvest #2751 so trusted workspaces can merge `.codewhale/mcp.json` with global MCP config
- default project stdio MCP `cwd` to the workspace and reject project `cwd` escapes
- route TUI engine, runtime API, doctor, and `codewhale mcp` read/connect/validate flows through the merged view
- keep project MCP ... | 499ec42c5da716a343e326cafcdd3a4499c1b40c | c36e4d7d20d39439868cd23dce1992d6885d7b72 | diff --git a/crates/tui/src/core/engine.rs b/crates/tui/src/core/engine.rs
index ff7552a66..5f58d925e 100644
--- a/crates/tui/src/core/engine.rs
+++ b/crates/tui/src/core/engine.rs
@@ -2270,8 +2270,11 @@ In {new} mode: {policy}\n\n\
if let Some(pool) = self.mcp_pool.as_ref() {
return Ok(Arc::clone... | [
"crates/tui/src/core/engine.rs",
"crates/tui/src/main.rs",
"crates/tui/src/mcp.rs",
"crates/tui/src/runtime_api.rs"
] | [
{
"comment": " \n\nComparing non-canonicalized paths against canonicalized paths can lead to both false positives (rejecting valid paths due to symlinks in the wo... | true | ||
Hmbown/CodeWhale | 2,804 | issue_to_patch | fix(tui): surface subagent branch status | ## Summary
- Refresh the parent workspace branch/status chip when a sub-agent finishes a shell-like tool call.
- Add workspace and current git branch metadata to sub-agent snapshots, including `agent_list`, `/subagents`, and the Agents sidebar.
- Persist sub-agent workspace paths so reloaded state can still describe w... | 71cb2212e82bc98e98a0c18d23dda8369f925371 | 805d748a78c9f0de240cb86ab872c96701853a73 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 90611c2b0..67512516c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -182,6 +182,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
+- Sub-agent shell completions now refresh the workspace branch/status chip
+ immediately,... | [
"CHANGELOG.md",
"crates/tui/CHANGELOG.md",
"crates/tui/src/tools/subagent/mod.rs",
"crates/tui/src/tools/subagent/tests.rs",
"crates/tui/src/tui/sidebar.rs",
"crates/tui/src/tui/subagent_routing.rs",
"crates/tui/src/tui/tool_routing.rs",
"crates/tui/src/tui/ui.rs",
"crates/tui/src/tui/ui/tests.rs",
... | [
{
"comment": "\n\n### Efficiency Improvement: Avoid Unnecessary Allocation\n\nUsing `String::from_utf8_lossy(&output.stdout).to_string()` always allocates a new `String` and copies the bytes from the stdout buffer. Since `output.stdout` is an... | true | ||
Hmbown/CodeWhale | 2,995 | issue_to_patch | build(deps): bump actions/stale from 9 to 10 | Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/stale/releases">actions/stale's releases</a>.</em></p>
<blockquote>
<h2>v10.0.0</h2>
<h2>What's Changed</h2>
<h3>Breaking Changes</h3>
<ul>
<li>Upgrade... | 68aee8409f1f2933dccc411b906d39ec5480bd14 | ffc734289e0406eab871e2daf0c2577363eab95f | diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
index 75535aa7f..ab8538ee4 100644
--- a/.github/workflows/stale.yml
+++ b/.github/workflows/stale.yml
@@ -13,7 +13,7 @@ jobs:
stale:
runs-on: ubuntu-latest
steps:
- - uses: actions/stale@v9
+ - uses: actions/stale@v10
... | [
".github/workflows/stale.yml"
] | [] | true | ||
Hmbown/CodeWhale | 2,879 | issue_to_patch | docs: align Hugging Face provider docs, errors, and tests with shipped route | ## Summary
Aligns the Hugging Face provider surface with the shipped route, per the polish list in #2706: documented env aliases now actually resolve (`HUGGINGFACE_API_KEY` primary, `HF_TOKEN` fallback, blank-primary handled so the fallback still fires), provider errors list `huggingface` among known providers, `confi... | 8dff2f7525ead210a01347b48f53ae3f20d094ec | 89cb6c55c81c7d8cc0c07816f215f5d00fe2d414 | diff --git a/config.example.toml b/config.example.toml
index b53435359..3bc8d59fb 100644
--- a/config.example.toml
+++ b/config.example.toml
@@ -248,7 +248,8 @@ max_subagents = 10 # optional (1-20)
# SGLang: SGLANG_BASE_URL, SGLANG_MODEL, optional SGLANG_API_KEY
# vLLM: VLLM_BASE_URL, VLLM_MODEL, optional... | [
"config.example.toml",
"crates/config/src/lib.rs",
"crates/tui/src/config.rs",
"docs/MODEL_LAB.md",
"docs/PROVIDERS.md",
"scripts/check-provider-registry.py"
] | [
{
"comment": "\n\nIf `HUGGINGFACE_BASE_URL` is set to an empty string, `std::env::var` returns `Ok(\"\")`. Because it is `Ok`, the `or_else` fallback is not evaluated, and the empty string is rejected by the subsequent `!value.trim().is_empty()` ... | true | ||
Hmbown/CodeWhale | 3,005 | issue_to_patch | refactor(config): extract provider metadata into data-driven registry | ## Summary
Move provider id, display name, aliases, defaults, and wire format into a single `Provider` trait backed by a static `PROVIDER_REGISTRY`, eliminating ~100 hand-maintained match arms across two crates.
- Add `aliases()` to `Provider` trait, populated per-provider via the `provider!()` macro's `aliases:` c... | 0181493c791f1adfe0941d88874b2b56b69dc373 | f64cf6f0ff79bbfcfc53600e2922e3a077c90e73 | diff --git a/crates/config/src/lib.rs b/crates/config/src/lib.rs
index be1824bdd..5cf52cc5b 100644
--- a/crates/config/src/lib.rs
+++ b/crates/config/src/lib.rs
@@ -171,8 +171,8 @@ impl ProviderKind {
Self::Novita,
Self::Fireworks,
Self::Siliconflow,
- Self::SiliconflowCN,
Sel... | [
"crates/config/src/lib.rs",
"crates/config/src/provider.rs",
"crates/tui/src/config.rs",
"crates/tui/src/tui/provider_picker.rs",
"scripts/check-provider-registry.py"
] | [
{
"comment": "\n\nThere is a critical discriminant mismatch between `ProviderKind` and `FROM_KIND_LOOKUP`. In `ProviderKind` (defined in `crates/config/src/lib.rs`), `Arcee` is defined before `SiliconflowCN`, meaning their discriminants are `11` a... | true | ||
Hmbown/CodeWhale | 3,005 | comment_to_fix | refactor(config): extract provider metadata into data-driven registry | 
There is a critical discriminant mismatch between `ProviderKind` and `FROM_KIND_LOOKUP`. In `ProviderKind` (defined in `crates/config/src/lib.rs`), `Arcee` is defined before `SiliconflowCN`, meaning their discriminants are `11` and `12` respectively. Ho... | 0181493c791f1adfe0941d88874b2b56b69dc373 | f64cf6f0ff79bbfcfc53600e2922e3a077c90e73 | diff --git a/crates/tui/src/config.rs b/crates/tui/src/config.rs
index 140c8f803..fdca413bc 100644
--- a/crates/tui/src/config.rs
+++ b/crates/tui/src/config.rs
@@ -212,126 +212,105 @@ impl ApiProvider {
#[must_use]
pub fn parse(value: &str) -> Option<Self> {
- match value.trim().to_ascii_lowercase()... | [
"crates/tui/src/config.rs"
] | [
{
"comment": "\n\nThere is a critical discriminant mismatch between `ProviderKind` and `FROM_KIND_LOOKUP`. In `ProviderKind` (defined in `crates/config/src/lib.rs`), `Arcee` is defined before `SiliconflowCN`, meaning their discriminants are `11` a... | true | ||
Hmbown/CodeWhale | 3,005 | comment_to_fix | refactor(config): extract provider metadata into data-driven registry | 
The current implementation of `ProviderKind::parse` performs multiple string allocations on every lookup by calling `to_ascii_lowercase()` on `p.id()` and each alias in the loop. We can optimize this by using `eq_ignore_ascii_case` on the trimmed i... | 0181493c791f1adfe0941d88874b2b56b69dc373 | f64cf6f0ff79bbfcfc53600e2922e3a077c90e73 | diff --git a/crates/config/src/lib.rs b/crates/config/src/lib.rs
index be1824bdd..5cf52cc5b 100644
--- a/crates/config/src/lib.rs
+++ b/crates/config/src/lib.rs
@@ -171,8 +171,8 @@ impl ProviderKind {
Self::Novita,
Self::Fireworks,
Self::Siliconflow,
- Self::SiliconflowCN,
Sel... | [
"crates/config/src/lib.rs"
] | [
{
"comment": "\n\nThe current implementation of `ProviderKind::parse` performs multiple string allocations on every lookup by calling `to_ascii_lowercase()` on `p.id()` and each alias in the loop. We can optimize this by using `eq_ignore_asci... | true | ||
Hmbown/CodeWhale | 3,005 | comment_to_fix | refactor(config): extract provider metadata into data-driven registry | 
We can optimize `ApiProvider::parse` to avoid allocating a new `String` via `to_ascii_lowercase()` by using `eq_ignore_ascii_case` on the trimmed string slice.
```rust
pub fn parse(value: &str) -> Option<Self> {
let trimmed = value.tri... | 0181493c791f1adfe0941d88874b2b56b69dc373 | f64cf6f0ff79bbfcfc53600e2922e3a077c90e73 | diff --git a/crates/tui/src/config.rs b/crates/tui/src/config.rs
index 140c8f803..fdca413bc 100644
--- a/crates/tui/src/config.rs
+++ b/crates/tui/src/config.rs
@@ -212,126 +212,105 @@ impl ApiProvider {
#[must_use]
pub fn parse(value: &str) -> Option<Self> {
- match value.trim().to_ascii_lowercase()... | [
"crates/tui/src/config.rs"
] | [
{
"comment": "\n\nWe can optimize `ApiProvider::parse` to avoid allocating a new `String` via `to_ascii_lowercase()` by using `eq_ignore_ascii_case` on the trimmed string slice.\n\n```rust\n pub fn parse(value: &str) -> Option<Self> {\n ... | true | ||
Hmbown/CodeWhale | 3,191 | issue_to_patch | feat(config): add first-party Z.ai and StepFlash/StepFun provider routes (#3187) | Closes #3187.
## Summary
Adds Z.ai (GLM Coding Plan) and StepFun/StepFlash as first-party CodeWhale providers.
## Provider details
### Z.ai
- Default model: GLM-5.1 (200K context, 128K output, thinking mode, function calling)
- Base URL: https://api.z.ai/api/coding/paas/v4
- Auth: ZAI_API_KEY / Z_AI_API_KEY
### Ste... | 12d3053a154f78e76c643cd2e83753c70e5e8240 | 3f2ed5f3d2a26ceb2d2a182b97107e77b374e66b | diff --git a/crates/cli/src/lib.rs b/crates/cli/src/lib.rs
index fcf07e903..65dab59e5 100644
--- a/crates/cli/src/lib.rs
+++ b/crates/cli/src/lib.rs
@@ -780,6 +780,8 @@ fn provider_slot(provider: ProviderKind) -> &'static str {
ProviderKind::Together => "together",
ProviderKind::OpenaiCodex => "openai... | [
"crates/cli/src/lib.rs",
"crates/config/src/lib.rs",
"crates/config/src/provider.rs",
"crates/tui/src/client.rs",
"crates/tui/src/config.rs",
"crates/tui/src/config_persistence.rs",
"crates/tui/src/core/engine.rs",
"crates/tui/src/main.rs",
"crates/tui/src/tui/provider_picker.rs",
"crates/tui/src/... | [
{
"comment": "\n\nThe environment variable for `Zai` and `Stepfun` is incorrectly mapped to `\"OPENAI_API_KEY\"`. Based on the provider definitions and other configuration files, `Zai` should use `\"ZAI_API_KEY/Z_AI_API_KEY\"` and `Stepfun` shoul... | true | ||
Hmbown/CodeWhale | 3,042 | issue_to_patch | feat(exec): add --allowed-tools, --disallowed-tools, --max-turns, --append-system-prompt | ## Summary
Refs #3027 (AC1–AC4 land here; AC5/AC6 are explicitly descoped — see below).
Adds four new CLI flags to `codewhale exec` for unattended/CI/benchmark use:
| Flag | Purpose |
|---|---|
| `--allowed-tools read_file,grep_files` | Comma-separated allowlist; all other tools denied |
| `--disallowed-tools exec_s... | b23067bacd42b1293e44c617466ff1626de9b3ea | c15e93709618dd2d1fa18b81e1b44db8665a0904 | diff --git a/crates/tui/src/core/engine.rs b/crates/tui/src/core/engine.rs
index 6f89fe194..599478fed 100644
--- a/crates/tui/src/core/engine.rs
+++ b/crates/tui/src/core/engine.rs
@@ -325,6 +325,9 @@ pub struct EngineConfig {
/// Tool restriction from custom slash command frontmatter.
/// `None` means the cu... | [
"crates/tui/src/core/engine.rs",
"crates/tui/src/core/engine/tests.rs",
"crates/tui/src/core/engine/turn_loop.rs",
"crates/tui/src/main.rs",
"crates/tui/src/runtime_threads.rs",
"crates/tui/src/tui/ui.rs"
] | [
{
"comment": "\n\nThe helper function `command_denies_tool` is defined here as a private function, but it is never called anywhere in `turn_loop.rs` or the rest of the codebase.\n\nThis has two major consequences:\n1. The compiler will emit a `dea... | true | ||
Hmbown/CodeWhale | 3,040 | issue_to_patch | feat(tui): clickable sidebar rows — click-to-act on Tasks and Agents panels | ## Summary
Refs #3028 (AC1/AC3 land here; AC2/AC4 descoped — see below).
Adds mouse-click dispatch for sidebar rows in the Tasks and Agents panels.
Clicking a background job's label row shows it; clicking its detail row
cancels it while it is running. Clicking an agent row opens `/subagents`.
All actions reuse the e... | 880346622b172d38c81811a16c4fa223eacfe373 | 8a165cc49b2ac46fb1308ce7549ef583f49e6d81 | diff --git a/crates/tui/src/tui/app.rs b/crates/tui/src/tui/app.rs
index 517a38b7b..34f1224bf 100644
--- a/crates/tui/src/tui/app.rs
+++ b/crates/tui/src/tui/app.rs
@@ -1157,6 +1157,11 @@ pub struct SidebarHoverRow {
pub detail: Option<String>,
/// Whether the compact row lost information.
pub is_truncat... | [
"crates/tui/src/tui/app.rs",
"crates/tui/src/tui/mouse_ui.rs",
"crates/tui/src/tui/sidebar.rs"
] | [
{
"comment": "\n\nThe current implementation of `task_panel_row_actions` has a critical logic bug. It increments `bg_idx` on every single line of `lines` (except `i == 0`), regardless of whether the line actually corresponds to a background task.... | true | ||
Hmbown/CodeWhale | 3,038 | issue_to_patch | v0.8.58: Make Ctrl+B background active shell/tool work — move blocking job to background Work/Tasks
## Why
When a shell or tool job is occupying the turn (e.g. a long-running `exec_shell`, a slow MCP tool, or a subagent), the user has no ergonomic way to move it to the background and regain the composer. Ctrl+B is the... | fix(tui): make Ctrl+B directly background the active foreground shell | ## Summary
Closes #3032.
Ctrl+B now directly backgrounds the running foreground shell command
instead of opening a two-step `ShellControlView` menu.
**Before**: Ctrl+B → Shell Control menu → select "Background"
**After**: Ctrl+B → command moves to background immediately
## Changes
- `ui.rs` line 3343: replace `... | b23067bacd42b1293e44c617466ff1626de9b3ea | f55c54c4876560b9a3f07d5fe7be85768f9e4fd3 | diff --git a/crates/tui/src/localization.rs b/crates/tui/src/localization.rs
index 3dfec9a96..97ffc9509 100644
--- a/crates/tui/src/localization.rs
+++ b/crates/tui/src/localization.rs
@@ -1373,7 +1373,7 @@ fn english(id: MessageId) -> &'static str {
MessageId::KbSendDraft => "Send the current draft",
... | [
"crates/tui/src/localization.rs",
"crates/tui/src/tui/history.rs",
"crates/tui/src/tui/ui.rs",
"crates/tui/src/tui/views/mod.rs",
"docs/KEYBINDINGS.md",
"docs/OPERATIONS_RUNBOOK.md"
] | [] | true | |
Hmbown/CodeWhale | 3,034 | issue_to_patch | v0.8.58: Constitution refactor, Codex fixes, sidebar improvements | ## Summary
Initial v0.8.58 branch carrying three stacked commits:
1. **`4d4cbd36`** — Constitution refactor: YAML source-of-truth + Python renderer (511-line constitution.md produced), rebrand fixes across agent-facing surfaces, provider error improvement
2. **`5bea28e4`** — TUI sidebar: split 'Model reasoning' from ... | 5b47a2e3e01625668537c9c0c6cf1910b37ede8f | 06f49af69fe034ebb8814534c1edb5be7a86226d | diff --git a/crates/cli/src/lib.rs b/crates/cli/src/lib.rs
index a721781e3..ba2fbbba8 100644
--- a/crates/cli/src/lib.rs
+++ b/crates/cli/src/lib.rs
@@ -40,6 +40,8 @@ enum ProviderArg {
Vllm,
Ollama,
Huggingface,
+ Together,
+ OpenaiCodex,
}
impl From<ProviderArg> for ProviderKind {
@@ -62,6 +6... | [
"crates/cli/src/lib.rs",
"crates/state/src/lib.rs",
"crates/tui/src/client/responses.rs",
"crates/tui/src/prompts.rs",
"crates/tui/src/prompts/constitution.md",
"crates/tui/src/prompts/constitution.yaml",
"crates/tui/src/prompts/render_constitution.py",
"crates/tui/src/tools/file.rs",
"crates/tui/sr... | [
{
"comment": "\n\nCalling `ensure_properties_object(obj)` can cause a panic if the `\"properties\"` key already exists in `obj` but its value is not a JSON object (e.g., if it is a string, null, or boolean). To prevent panics on malformed schemas... | true | ||
Hmbown/CodeWhale | 3,035 | issue_to_patch | v0.8.58: Fix live-subagent freeze under load — 4+ concurrent subagents block TUI input/rendering
## Why
The TUI froze completely when 4 subagents were running concurrently with active tool execution and sidebar updates. Input became unresponsive, rendering stopped, and the user had to cancel the entire session. This i... | fix(tui): throttle AgentProgress redraws to prevent freeze under subagent load | ## Summary
Closes #3033.
When 4+ sub-agents run concurrently, each `AgentProgress` event sets
`received_engine_event = true` → `needs_redraw = true`, triggering a full
terminal redraw on every progress event. The render loop saturates, the
sidebar recomputes agent rows/HashSet/BTreeMap on every frame, and terminal
i... | b23067bacd42b1293e44c617466ff1626de9b3ea | df1b35ba0fd7629fbb581db3f24ce52732c26eec | diff --git a/crates/tui/src/tui/app.rs b/crates/tui/src/tui/app.rs
index 37bf84c50..0a2a6441f 100644
--- a/crates/tui/src/tui/app.rs
+++ b/crates/tui/src/tui/app.rs
@@ -1445,6 +1445,9 @@ pub struct App {
pub pending_subagent_dispatch: Option<String>,
/// Animation anchor for status-strip active sub-agent spin... | [
"crates/tui/src/tui/app.rs",
"crates/tui/src/tui/ui.rs",
"crates/tui/src/tui/ui/tests.rs"
] | [
{
"comment": "\n\nThere is a bug in the throttling logic when a batch contains multiple `AgentProgress` events (which is very common under high sub-agent load). The first event in the batch will see that the 100ms throttle has expired, update `ap... | true | |
Hmbown/CodeWhale | 3,037 | issue_to_patch | fix(tui): compact tool-call transcript rendering — suppress boilerplate | ## Summary
Refs #3031 (partial — see descope note below).
Reduces low-value detail in the default compact/Live transcript view:
- **ExecCell**: suppress "(no output)" line — the success/failure header already conveys the outcome
- **ExecCell**: suppress sub-second timing — calls under 1s show no timing line; >=1s st... | b23067bacd42b1293e44c617466ff1626de9b3ea | b6e88d2d345dad942859c97d18d954ce3660893d | diff --git a/crates/tui/src/tui/history.rs b/crates/tui/src/tui/history.rs
index 9ca7fb54b..847ec7e48 100644
--- a/crates/tui/src/tui/history.rs
+++ b/crates/tui/src/tui/history.rs
@@ -961,7 +961,10 @@ impl ExecCell {
Style::default().fg(palette::TEXT_MUTED),
width,
... | [
"crates/tui/src/tui/history.rs",
"crates/tui/src/tui/tool_routing.rs"
] | [
{
"comment": "\n\nThe conversion of `duration_ms` (which is a `u64`) to `f64` can be simplified. Using `u32::try_from` with a fallback to `u32::MAX` is unnecessary and artificially caps the duration at ~49.7 days (`u32::MAX` milliseconds). Di... | true | ||
Hmbown/CodeWhale | 3,036 | issue_to_patch | v0.8.58: Hide internal numeric/id slop from normal UI — stable labels for turns, agents, steps
## Why
The TUI leaks raw internal identifiers and sentinel values into the normal user-facing UI. Users see `turn 3625a752-8cb4... (in_progress)`, `agent_3425cb9f`, `agent_1009b0ab`, and `step 16/4294967295` — machine-intern... | fix(tui): hide internal IDs from normal UI — stable labels for turns and agents | ## Summary
Closes #3030.
Replaces raw UUIDs, hex agent IDs, and u32::MAX sentinels in the normal
UI with stable user-facing labels. Full identifiers remain accessible in
hover/detail text for inspection.
## Changes
### 1. Turn label (sidebar Tasks panel)
- **Before**: `turn 3625a752-8cb4... (in_progress)`
- **Afte... | eb610c83ee89e1ac2891f13c3d60164dfd9576dc | 418ad5b744951f72843732c4023e463bd517a753 | diff --git a/crates/tui/src/tools/subagent/mod.rs b/crates/tui/src/tools/subagent/mod.rs
index c9991aa2e..c9166a1d9 100644
--- a/crates/tui/src/tools/subagent/mod.rs
+++ b/crates/tui/src/tools/subagent/mod.rs
@@ -70,6 +70,18 @@ fn release_resident_leases_for(agent_id: &str) {
/// the `SubAgentManager`.
const DEFAULT_... | [
"crates/tui/src/tools/subagent/mod.rs",
"crates/tui/src/tools/subagent/tests.rs",
"crates/tui/src/tui/app.rs",
"crates/tui/src/tui/sidebar.rs",
"crates/tui/src/tui/ui.rs"
] | [
{
"comment": "\n\nIf the user explicitly assigned a custom session name to the agent (e.g., `name: \"researcher\"`), `agent.name` will contain this custom name, which differs from the raw `agent.agent_id`. However, because `app.agent_label_map` i... | true | |
Hmbown/CodeWhale | 3,039 | issue_to_patch | feat(tui): OSC 8 out-of-band hyperlink infrastructure | ## Summary
Partially addresses #3029. Builds the infrastructure for working OSC 8
hyperlinks in the transcript — the emission path that bypasses ratatui's
buffer (which strips ESC bytes and breaks inline OSC 8).
## What this PR delivers
- **`LinkRegion`** struct — (row, col_start, col_end, target) for contiguous li... | b23067bacd42b1293e44c617466ff1626de9b3ea | 948e42397fcb0f3355e07d633cafcfc843111f12 | diff --git a/crates/tui/src/tui/color_compat.rs b/crates/tui/src/tui/color_compat.rs
index 0a8107ecc..0082830fe 100644
--- a/crates/tui/src/tui/color_compat.rs
+++ b/crates/tui/src/tui/color_compat.rs
@@ -129,8 +129,52 @@ impl<W: Write> Backend for ColorCompatBackend<W> {
if let Some(render_debug) = &mut self.... | [
"crates/tui/src/tui/color_compat.rs",
"crates/tui/src/tui/osc8.rs"
] | [
{
"comment": "\n\n### Critical Correctness Bug: State Overwrite & Link Bleeding\n\nEmitting OSC 8 link open sequences before calling `self.inner.draw` and closing them after is highly problematic and will result in broken rendering:\n\n1. **State ... | true | ||
Hmbown/CodeWhale | 3,045 | issue_to_patch | fix(subagent): un-hardcode DeepSeek from model validation — accept any provider id | ## Summary
Partially addresses #3018.
Two changes to let non-DeepSeek providers (Moonshot, Ollama, OpenAI, etc.)
use their own model IDs for sub-agent role models and spawn-time `model`.
## Changes
1. `config.rs` — `requested_model_for_provider(provider, model)`:
DeepSeek/DeepSeekCN use strict `normalize_model_n... | e0b6441a266d030492d8b341ee16188f33214734 | 3f2f154ad271cf15b5fb6b87c30b5aacaee1f2e3 | diff --git a/crates/tui/src/config.rs b/crates/tui/src/config.rs
index d8f17de48..a64b2ebd7 100644
--- a/crates/tui/src/config.rs
+++ b/crates/tui/src/config.rs
@@ -575,6 +575,19 @@ pub(crate) fn normalize_custom_model_id(model: &str) -> Option<String> {
}
}
+/// Validate a user-requested model id against the a... | [
"crates/tui/src/config.rs",
"crates/tui/src/model_routing.rs",
"crates/tui/src/tools/subagent/mod.rs",
"crates/tui/src/tools/subagent/tests.rs",
"docs/SUBAGENTS.md"
] | [
{
"comment": "\n\nThe comment indicates that provider-aware validation is deferred to the spawn path. However, in `AgentSpawnTool::execute` (around line 2627), `spawn_request.model` is not validated when it is `Some(model)`. It is only validated ... | true | ||
Hmbown/CodeWhale | 3,041 | issue_to_patch | v0.8.58: Harvest subagent/tool error-message fixes from PR #2933 — child-model availability, tool-unavailability reasons, session-name conflicts
## Why
Three verified community reports (#2653, #2656, #2657, all OPEN) describe the same failure class: when a tool or sub-agent is unavailable, the error the model sees nam... | fix: harvest error-message fixes from PR #2933 — better tool denial + subagent conflict messages | ## Summary
Closes #3020, #2653, #2656, #2657.
Three targeted error-message improvements extracted from community
PR #2933 (author cy2311), with additional model-not-found annotation
for subagent child-model errors.
## Changes
### 1. `dispatch.rs` — Pass through self-explanatory tool errors (#2657)
`format_tool_erro... | b23067bacd42b1293e44c617466ff1626de9b3ea | 5fb41cc20908247c29c57bdb465f16d46da593c4 | diff --git a/crates/tui/src/core/engine/dispatch.rs b/crates/tui/src/core/engine/dispatch.rs
index 335639c4e..1595507d9 100644
--- a/crates/tui/src/core/engine/dispatch.rs
+++ b/crates/tui/src/core/engine/dispatch.rs
@@ -99,6 +99,15 @@ pub(super) fn caller_allowed_for_tool(
requested == "direct"
}
+/// Whole-wo... | [
"crates/tui/src/core/engine/dispatch.rs",
"crates/tui/src/core/engine/tests.rs",
"crates/tui/src/tools/subagent/mod.rs",
"crates/tui/src/tools/subagent/tests.rs"
] | [
{
"comment": "\n\nUsing `lower.contains(\"mode\")` can lead to false positives because it matches common words like `\"model\"` (e.g., `\"Model Not Exist\"` or `\"does not exist or you do not have access\"`) and `\"modify\"`/`\"modification\"`. S... | true | |
Hmbown/CodeWhale | 3,046 | issue_to_patch | fix(reasoning): add Moonshot/Kimi to reasoning-content provider and model support | ## Summary
Partially addresses #3016.
Two targeted fixes to close the Kimi/Moonshot reasoning gap identified
in the RC audit:
1. `chat.rs` — add `ApiProvider::Moonshot` to `provider_accepts_reasoning_content`
so Kimi thinking traces stream as Thinking blocks instead of leaking
as plain answer text on Moonshot'... | b23067bacd42b1293e44c617466ff1626de9b3ea | 7a64119635c3be1d4c970116eef0bbf43452e8b4 | diff --git a/crates/tui/src/client/chat.rs b/crates/tui/src/client/chat.rs
index 93b087140..438bc94e3 100644
--- a/crates/tui/src/client/chat.rs
+++ b/crates/tui/src/client/chat.rs
@@ -1996,6 +1996,7 @@ fn provider_accepts_reasoning_content(provider: ApiProvider) -> bool {
| ApiProvider::Volcengine
... | [
"crates/tui/src/client/chat.rs",
"crates/tui/src/models.rs"
] | [
{
"comment": "\n\nWhile adding bare `kimi-` prefix support to `model_supports_reasoning` is correct, bare IDs like `kimi-k2.6` are still not recognized in `known_context_window_for_model` (lines 265-266) and `max_output_tokens_for_model` (lin... | true | ||
Hmbown/CodeWhale | 3,054 | issue_to_patch | v0.8.58: Native Anthropic Messages API adapter — cache_control, thinking blocks, tool streaming
## Why
CodeWhale's "all models" goal is currently OpenAI-dialect-only: every provider routes through Chat Completions (`client/chat.rs`) except OpenAI Codex, which has its own Responses bridge (`client/responses.rs`). Claud... | feat(client): native Anthropic Messages API adapter — cache_control, thinking blocks, tool streaming (#3014) | ## Summary
Closes #3014.
Adds the third wire dialect: a **native Anthropic Messages API client**
(`crates/tui/src/client/anthropic.rs`, modeled 1:1 on `responses.rs`),
registered through the established three-enum provider pattern.
`codewhale --provider anthropic` with `ANTHROPIC_API_KEY` talks to
`https://api.anthr... | f87245ff5fa89ab6b801272897af8de11e2c91d6 | d940b7821cc5bf0a8410225dbc6129953540c3d5 | diff --git a/config.example.toml b/config.example.toml
index 0a66c3697..6a0ed0aff 100644
--- a/config.example.toml
+++ b/config.example.toml
@@ -20,7 +20,7 @@
# `api_key` / `base_url` are
# still read as DeepSeek defaults when `[providers.deepseek]` is absent
# (backward compatibility).
-provider = "deepseek" # deep... | [
"config.example.toml",
"crates/agent/src/lib.rs",
"crates/cli/src/lib.rs",
"crates/config/src/lib.rs",
"crates/config/src/provider.rs",
"crates/secrets/src/lib.rs",
"crates/tui/src/client.rs",
"crates/tui/src/client/anthropic.rs",
"crates/tui/src/client/chat.rs",
"crates/tui/src/client/responses.r... | [
{
"comment": "\n\nAnthropic's Messages API does not support the `strict` field on tools. Passing this field will cause the API to return a `400 Bad Request` validation error. We should omit the `strict` field entirely when constructing the tool p... | diff --git a/crates/tui/tests/integration_mock_llm.rs b/crates/tui/tests/integration_mock_llm.rs
index ee447420e..ca87c74e2 100644
--- a/crates/tui/tests/integration_mock_llm.rs
+++ b/crates/tui/tests/integration_mock_llm.rs
@@ -79,6 +79,7 @@ fn assistant_thinking(thinking: &str, text: &str) -> Message {
conte... | true |
Hmbown/CodeWhale | 3,050 | issue_to_patch | fix(reasoning): wire reasoning-effort for Atlascloud, Moonshot, Ollama | ## Summary
Partially addresses #3024.
Three providers previously had silent no-ops for all reasoning-effort
tiers — the user toggled thinking on/off and nothing changed on the
wire. This commit wires them:
| Provider | Off | Low–High | XHigh/Max |
|---|---|---|---|
| Atlascloud | `thinking: {type: disabled}` | `rea... | b23067bacd42b1293e44c617466ff1626de9b3ea | 29e60cd4b97d4b4d7fbb7bdcf6cb0bd0d20b806f | diff --git a/crates/tui/src/client.rs b/crates/tui/src/client.rs
index f7eb50b86..93f722d6d 100644
--- a/crates/tui/src/client.rs
+++ b/crates/tui/src/client.rs
@@ -1226,7 +1226,8 @@ pub(super) fn apply_reasoning_effort(
| ApiProvider::SiliconflowCn
| ApiProvider::Sglang
| ApiProv... | [
"crates/tui/src/client.rs",
"docs/PROVIDERS.md"
] | [
{
"comment": "\n\n### Test Failure Alert\nThe changes introduced here will cause the existing unit test `reasoning_effort_off_is_omitted_for_strict_openai_like_providers` (at line 2574) to fail.\n\nThat test asserts that calling `apply_reasoning_... | true | ||
Hmbown/CodeWhale | 3,047 | issue_to_patch | v0.8.58: Fix provider capability matrix — true context windows and thinking flags for Moonshot/OpenAI/Ollama; query Ollama num_ctx
## Why
The capability matrix feeds capacity/compaction math and the `codewhale doctor` report, but several providers get wrong static values. Moonshot's default model `kimi-k2.6` is report... | fix(providers): use model-based lookups for Moonshot/OpenAI/Atlascloud/Ollama capability | ## Summary
Closes #3023.
Fixes provider capability reporting for Moonshot, OpenAI, Atlascloud,
and Ollama by routing them through the generic model-based lookup path
instead of hardcoded values.
## Changes
1. Delete the `Openai | Atlascloud | Moonshot` early-return arm in
`provider_capability()` — these provider... | b23067bacd42b1293e44c617466ff1626de9b3ea | 4cf9e52f197cf19e7c441c5d29a093f026767333 | diff --git a/crates/tui/src/config.rs b/crates/tui/src/config.rs
index d8f17de48..eac5e694b 100644
--- a/crates/tui/src/config.rs
+++ b/crates/tui/src/config.rs
@@ -387,22 +387,11 @@ pub enum RequestPayloadMode {
/// in the API payload (after normalization / provider-specific mapping).
#[must_use]
pub fn provider_ca... | [
"crates/tui/src/config.rs",
"crates/tui/src/core/engine/tests.rs",
"crates/tui/src/models.rs"
] | [
{
"comment": "\n\nThere are two critical issues with the current implementation of model-based lookups for Ollama and Moonshot:\n\n1. **Ollama Fallback Bug**: Any model containing `\"deepseek\"` (such as `deepseek-coder:1.3b` or `deepseek-v3.1:67... | true | |
Hmbown/CodeWhale | 3,048 | issue_to_patch | feat(prompts): parameterize model-specific facts — context window, pricing, thinking | ## Summary
Partially addresses #3025.
Extends `apply_model_template()` in prompts.rs to substitute model-specific
facts from runtime capability lookups instead of hardcoded V4 claims.
## Changes
1. `pricing.rs` — add `input_cost_note(model)` public helper that returns
a one-line sub-agent cost description (e.g. ... | b23067bacd42b1293e44c617466ff1626de9b3ea | ff6dca1d451f0c786b82dc6a4961728bc2acc55b | diff --git a/crates/tui/src/pricing.rs b/crates/tui/src/pricing.rs
index 2da0eab99..89395f887 100644
--- a/crates/tui/src/pricing.rs
+++ b/crates/tui/src/pricing.rs
@@ -166,6 +166,20 @@ fn deepseek_v4_flash_pricing() -> ModelPricing {
}
}
+/// Return a one-line cost note for the given model, suitable for the
+/... | [
"crates/tui/src/pricing.rs",
"crates/tui/src/prompts.rs",
"crates/tui/src/prompts/base.md"
] | [
{
"comment": "\n\nThis implementation hardcodes the currency to USD (`$`) and uses a direct `format!` instead of the existing `format_cost_amount` helper. This is inconsistent with the rest of the file, which supports multiple currencies and ... | true | ||
Hmbown/CodeWhale | 3,049 | issue_to_patch | v0.8.58: Hooks v2 — JSON decision contract (deny/allow/ask, updatedInput, additionalContext), glob matchers, project-local hooks
## Why
Hooks are CodeWhale's only deterministic, model-agnostic control layer: a policy written once is enforced identically for DeepSeek, Qwen, GPT, or any other model — exactly the trust p... | feat(hooks): JSON decision contract, glob matchers, project-local hooks | ## Summary
Closes #3026.
Three incremental improvements to the hooks control plane:
## Changes
### 1. JSON decision contract for tool_call_before hooks
Hooks can now emit a JSON decision on stdout:
```json
{"decision": "allow"|"deny"|"ask", "reason": "...", "updatedInput": {...}, "additionalContext": "..."}
```
- `... | 667e18888b588aed54c4f840d5c685278513e0fa | d9dff6809cfcd4f835e496335869dc384894cdd4 | diff --git a/crates/tui/src/core/engine/turn_loop.rs b/crates/tui/src/core/engine/turn_loop.rs
index 074b5e2b4..296e937c1 100644
--- a/crates/tui/src/core/engine/turn_loop.rs
+++ b/crates/tui/src/core/engine/turn_loop.rs
@@ -1332,11 +1332,15 @@ impl Engine {
let active_tools_at_batch_start = active_tool_na... | [
"crates/tui/src/core/engine/turn_loop.rs",
"crates/tui/src/hooks.rs",
"crates/tui/src/tui/app.rs",
"crates/tui/src/tui/ui.rs",
"docs/CONFIGURATION.md"
] | [
{
"comment": "\n\nThe private function `parse_tool_call_before_stdout` (along with `ToolCallBeforeStdout` and `ToolCallDecision`) is defined but never called or referenced anywhere in `hooks.rs` or the rest of the codebase.\n\nThis means the **JS... | true | |
Hmbown/CodeWhale | 3,043 | issue_to_patch | v0.8.58: Distributed intelligence — agent-executable issue template, agent-ready labels, and remote runner doc
## Why
v0.8.58's theme is making CodeWhale the strongest harness for ALL models, and the droplet audit behind #1990/#2964 showed the runtime side already works: a headless agent on a DigitalOcean VM can run `... | feat(docs): agent-task issue template, labels, and runner protocol | ## Summary
Closes #3021.
Adds the distributed intelligence infrastructure so remote agents can autonomously execute v0.8.58 milestone issues.
## Changes
1. `.github/ISSUE_TEMPLATE/agent-task.yml` (new) — GitHub issue form with six required sections: Goal, Scope, Key files, Acceptance criteria, Verification, Out of ... | b23067bacd42b1293e44c617466ff1626de9b3ea | e4ea208d538c7ea2325279e1eb3c8cf58cf28d81 | diff --git a/.github/ISSUE_TEMPLATE/agent-task.yml b/.github/ISSUE_TEMPLATE/agent-task.yml
new file mode 100644
index 000000000..263110285
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/agent-task.yml
@@ -0,0 +1,91 @@
+name: Agent task
+description: Create a self-contained task that a headless agent (DeepSeek V4, remote dr... | [
".github/ISSUE_TEMPLATE/agent-task.yml",
"docs/AGENT_RUNNER.md"
] | [
{
"comment": "\n\nUsing `$(cat)` in a pipeline like `command1 | command2 \"$(cat)\"` does not work as intended. The shell evaluates `$(cat)` before setting up the pipeline, causing it to block waiting for stdin from the terminal/parent shell ... | true | |
Hmbown/CodeWhale | 3,044 | issue_to_patch | v0.8.58: DigitalOcean droplet — upgrade to v0.8.57 binaries, gh + PAT, swap; run first autonomous DeepSeek-V4 issue end-to-end
## Why
The `codewhale-smoke` droplet (DO id 576515073, name `codewhale-smoke`, sfo3, last known IP 164.90.151.26 — re-resolve with `doctl compute droplet get 576515073 --format PublicIPv4`) is... | feat(remote-smoke): bump to v0.8.57, add gh CLI, swapfile, agent-session.sh, autonomous loop docs | ## Summary
Closes #3022.
Upgrades the remote-smoke infrastructure for the v0.8.58 autonomous
agent loop on the DigitalOcean droplet.
## Changes
1. `setup-vm.sh` — bump RELEASE_TAG default to v0.8.57, add `gh` CLI
install step (official APT repo), add 4G swapfile creation (idempotent)
2. `agent-session.sh` (new)... | b23067bacd42b1293e44c617466ff1626de9b3ea | 9de6c9d1252e0fec4aa07cd62ba064627bc0c313 | diff --git a/scripts/remote-smoke/README.md b/scripts/remote-smoke/README.md
new file mode 100644
index 000000000..e5f02f27a
--- /dev/null
+++ b/scripts/remote-smoke/README.md
@@ -0,0 +1,153 @@
+# Remote-workbench smoke lab (EXPERIMENTAL)
+
+Status: experimental smoke-lab scripts for the US-first remote-workbench lane
... | [
"scripts/remote-smoke/README.md",
"scripts/remote-smoke/agent-session.sh",
"scripts/remote-smoke/aws-lightsail/provision.sh",
"scripts/remote-smoke/aws-lightsail/teardown.sh",
"scripts/remote-smoke/digitalocean/provision.sh",
"scripts/remote-smoke/digitalocean/teardown.sh",
"scripts/remote-smoke/setup-v... | [
{
"comment": "\n\nIf the provider API key or token contains special characters like `&`, `\\`, or `|` (which is highly common for generated secrets), `sed` will interpret them as special replacement operators (e.g., `&` represents the matched text... | true | |
Hmbown/CodeWhale | 2,686 | issue_to_patch | docs: v0.8.53 tool-surface-diet design + north-star direction (#2681, #2680) | **Design-only** deliverables for the v0.8.53 "tool surface diet / canonical surfaces" cutover. **No tool-catalog code changes in this cycle** — these docs define the policy and contracts so the code PRs can follow with sign-off. Grounded in a verified inventory of the actual tool registry (every cited `file:line` was c... | 03d1bba53879e7a4eb06523748f10335283528f5 | 8cb4f94f30b0d164e6ab48538b06b0c14b1a558a | diff --git a/docs/CODEBASE_SEARCH_DESIGN.md b/docs/CODEBASE_SEARCH_DESIGN.md
new file mode 100644
index 000000000..1a516c848
--- /dev/null
+++ b/docs/CODEBASE_SEARCH_DESIGN.md
@@ -0,0 +1,300 @@
+# `codebase_search` — Local-First Semantic Code Retrieval
+
+> **Status:** Design note + eval scaffold. **Code is DEFERRED.**... | [
"docs/CODEBASE_SEARCH_DESIGN.md",
"docs/SKILL_INVOCATION_DESIGN.md",
"docs/TOOL_LIFECYCLE.md",
"docs/VISION_NORTH_STAR.md"
] | [
{
"comment": "\n\nThe reference to `§7` is broken because there is no Section 7 in this document. The `/memory doctor` subcommand is actually described in Appendix B of this document (and Section 9 of `docs/VISION_NORTH_STAR.md`). We should u... | true | ||
Hmbown/CodeWhale | 2,916 | issue_to_patch | v0.8.55 — Together AI provider + experimental OpenAI Codex (ChatGPT) provider | ## Summary
Cuts **v0.8.55**. Two new providers plus a consistency/de-slop pass so the new Codex provider fits the app's existing patterns rather than being bolted on.
This branch contains two commits:
1. `feat(models)` — Together AI provider + model catalog (Qwen 3.7 Max, MiniMax 2.7, NVIDIA Nemotron 3 Ultra) — *alre... | 9463266cb1278cdb82ada338479f32d47f31a704 | a2ae9a1acf0d67d1c1e24fcf4ef821c31c182aa5 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index fb4d3845b..d9dfbc4cd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,29 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
+## [0.8.55] - 2026-06-08
+
+### Added
+
+- **Together AI provider.** Added Together AI ... | [
"CHANGELOG.md",
"Cargo.lock",
"Cargo.toml",
"config.example.toml",
"crates/agent/Cargo.toml",
"crates/agent/src/lib.rs",
"crates/app-server/Cargo.toml",
"crates/cli/Cargo.toml",
"crates/cli/src/lib.rs",
"crates/config/Cargo.toml",
"crates/config/src/lib.rs",
"crates/config/src/provider.rs",
... | [
{
"comment": "\n\nUsing a `String` as a buffer and calling `String::from_utf8_lossy` on arbitrary stream chunks can corrupt multi-byte UTF-8 characters if they are split across chunk boundaries. Changing `buffer` to a `Vec<u8>` allows processing ... | true | ||
Hmbown/CodeWhale | 2,684 | issue_to_patch | fix(subagent): clearer role vocab, lifecycle signals, and eval ergonomics (v0.8.53) | Part of the **v0.8.53 stabilization** cycle (PR group 3 — subagent usability & lifecycle). Targets the integration branch `codex/v0.8.53`.
## Issues addressed
- **#2649** — role/type schema confusion: `normalize_role_alias` now accepts the full set that `SubAgentType::from_str` accepts (`reviewer`, `implementer`, `ver... | 03d1bba53879e7a4eb06523748f10335283528f5 | 725abeb60328cf21a24fd3334ae8a62f3bee6d82 | diff --git a/crates/tui/src/core/engine/tests.rs b/crates/tui/src/core/engine/tests.rs
index d6e56cdb1..0304f9868 100644
--- a/crates/tui/src/core/engine/tests.rs
+++ b/crates/tui/src/core/engine/tests.rs
@@ -520,6 +520,19 @@ fn non_yolo_mode_retains_default_defer_policy() {
AppMode::Agent,
&always_lo... | [
"crates/tui/src/core/engine/tests.rs",
"crates/tui/src/core/engine/tool_catalog.rs",
"crates/tui/src/prompts/base.md",
"crates/tui/src/tools/subagent/mod.rs",
"crates/tui/src/tools/subagent/tests.rs",
"docs/SUBAGENTS.md"
] | [] | true | ||
Hmbown/CodeWhale | 2,685 | issue_to_patch | fix(tools): activate read-only git history + actionable RLM/field errors (v0.8.53) | Part of the **v0.8.53 stabilization** cycle (PR group 4 — tool/deferred/error UX). Targets `codex/v0.8.53`. Low-risk subset; one medium-risk item deferred (see below).
## Issues addressed
- **#2654** — read-only git history is now first-class: `git_log` and `git_show` join `git_diff`/`git_status` in `DEFAULT_ACTIVE_NA... | 03d1bba53879e7a4eb06523748f10335283528f5 | 7bbc6b78e4188d83a4a39be4c480b5eba184208e | diff --git a/crates/tui/src/core/engine/tests.rs b/crates/tui/src/core/engine/tests.rs
index d6e56cdb1..802867bd8 100644
--- a/crates/tui/src/core/engine/tests.rs
+++ b/crates/tui/src/core/engine/tests.rs
@@ -470,8 +470,9 @@ fn core_native_tools_stay_loaded_in_yolo_mode() {
AppMode::Yolo,
&always_load... | [
"crates/tui/src/core/engine/tests.rs",
"crates/tui/src/core/engine/tool_catalog.rs",
"crates/tui/src/tools/rlm.rs"
] | [
{
"comment": "\n\nThe `likely_field_corrections` logic for `rlm_open` checks that none of `file_path`, `content`, or `url` have been received before suggesting corrections. However, `session_object` is also a valid source field for `rlm_open`... | true | ||
Hmbown/CodeWhale | 2,688 | issue_to_patch | feat(project): deprecate WHALE.md; add .codewhale/constitution.json authority layer (v0.8.53) | Part of the **v0.8.53** cutover. Splits repo-level guidance into two clear artifacts and deprecates the confusing `WHALE.md` concept (it overlapped with `AGENTS.md` and sounded like CodeWhale-native authority — which now has a real home).
## The model
- **`AGENTS.md`** — canonical cross-agent **project instructions** ... | 03d1bba53879e7a4eb06523748f10335283528f5 | fc8ad7b3a85c4530bb885bd17e19ec00b5a3338e | diff --git a/.codewhale/constitution.json b/.codewhale/constitution.json
new file mode 100644
index 000000000..6c9de07d1
--- /dev/null
+++ b/.codewhale/constitution.json
@@ -0,0 +1,30 @@
+{
+ "schema_version": 1,
+ "authority": [
+ "current user request",
+ "live code and tests",
+ "GitHub issue/PR details",... | [
".codewhale/constitution.json",
".gitignore",
"crates/tui/src/commands/init.rs",
"crates/tui/src/project_context.rs",
"crates/tui/src/project_doc.rs",
"docs/CONFIGURATION.md"
] | [
{
"comment": "\n\nTo prevent potential Out Of Memory (OOM) crashes or high latency when loading extremely large or malformed files, it is recommended to enforce a size limit check on the `.codewhale/constitution.json` file before reading it e... | true | ||
Hmbown/CodeWhale | 2,987 | issue_to_patch | v0.8.56 — Community Harvest: localization, providers, prefix-cache stability, and fixes | ## v0.8.56 Release
14 merged PRs from 9 contributors. Full release notes: https://github.com/Hmbown/CodeWhale/releases/tag/v0.8.56
### What is in this PR
- CHANGELOG entry for v0.8.56 (7 Added, 7 Fixed, 2 Changed)
- Contributor credit updates across all four READMEs (new: @hongchen1993; updated: @gordonlu, @LeoAlex0)... | 3c97ba079981150c448294985f16ccade56ce503 | bcaf655316554b9782b73b67fe70f5fe834b865a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cd3201837..eea1e4462 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,62 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
+## [0.8.56] - 2026-06-09
+
+### Added
+
+- **Status picker localization.** The status p... | [
"CHANGELOG.md",
"Cargo.lock",
"Cargo.toml",
"README.ja-JP.md",
"README.md",
"README.vi.md",
"README.zh-CN.md",
"crates/agent/Cargo.toml",
"crates/app-server/Cargo.toml",
"crates/cli/Cargo.toml",
"crates/config/Cargo.toml",
"crates/core/Cargo.toml",
"crates/execpolicy/Cargo.toml",
"crates/h... | [] | true | ||
Homebrew/brew | 22,735 | issue_to_patch | formula: add Zig CPU to `std_zig_args` | -----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process. -->
<!-- Use [x] to mark item done before creation, or just click the checkboxes with device pointer after creation -->
<!-- Do not delete these checkboxes or this pull request will be close... | daf67e8daa1e271297fbd9812669a0e4c57ba66a | 35525637a759f598e7272fd85a635e992985a325 | diff --git a/Library/Homebrew/extend/os/mac/formula.rb b/Library/Homebrew/extend/os/mac/formula.rb
index ed4b3282e0220..8bad3889207d3 100644
--- a/Library/Homebrew/extend/os/mac/formula.rb
+++ b/Library/Homebrew/extend/os/mac/formula.rb
@@ -33,9 +33,10 @@ def std_cmake_args(install_prefix: prefix, install_libdir: "lib"... | [
"Library/Homebrew/extend/os/mac/formula.rb",
"Library/Homebrew/formula.rb",
"Library/Homebrew/hardware.rb",
"Library/Homebrew/test/formula_spec.rb",
"Library/Homebrew/test/hardware_spec.rb",
"docs/Formula-Cookbook.md"
] | [] | diff --git a/Library/Homebrew/test/formula_spec.rb b/Library/Homebrew/test/formula_spec.rb
index f2c965d1e6445..aa295cba1cf8f 100644
--- a/Library/Homebrew/test/formula_spec.rb
+++ b/Library/Homebrew/test/formula_spec.rb
@@ -3114,6 +3114,27 @@ def install
end
end
+ describe "#std_zig_args" do
+ let(:f) do... | true | |
Homebrew/brew | 22,731 | issue_to_patch | generate-zap: search app bundle identifiers | -----
- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/HEAD/CONTRIBUTING.md) document?
- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?
- [x] Have you added an explanation of what your... | 592f0ad2d01ff2f3e2708603cd47e2e5220600c7 | 8afc96d27677fd234eaa226f04b3cd11935347ff | diff --git a/Library/Homebrew/dev-cmd/generate-zap.rb b/Library/Homebrew/dev-cmd/generate-zap.rb
index e9ca72c5ee171..43075520ae191 100644
--- a/Library/Homebrew/dev-cmd/generate-zap.rb
+++ b/Library/Homebrew/dev-cmd/generate-zap.rb
@@ -3,10 +3,13 @@
require "abstract_command"
require "cask/cask_loader"
+require "s... | [
"Library/Homebrew/dev-cmd/generate-zap.rb",
"Library/Homebrew/test/dev-cmd/generate-zap_spec.rb"
] | [
{
"comment": "`Array#to_sentence` is not part of Ruby core; if Homebrew hasn’t loaded an extension providing it, this will raise `NoMethodError` at runtime. Consider replacing with a Ruby-core implementation (e.g., manual Join logic) or requiring the module that defines `to_sentence` in this execution context."... | diff --git a/Library/Homebrew/test/dev-cmd/generate-zap_spec.rb b/Library/Homebrew/test/dev-cmd/generate-zap_spec.rb
index 86abcdb01a1b3..a16b035f378df 100644
--- a/Library/Homebrew/test/dev-cmd/generate-zap_spec.rb
+++ b/Library/Homebrew/test/dev-cmd/generate-zap_spec.rb
@@ -9,14 +9,36 @@
it_behaves_like "parseab... | true | |
Homebrew/brew | 22,731 | comment_to_fix | generate-zap: search app bundle identifiers | `Array#to_sentence` is not part of Ruby core; if Homebrew hasn’t loaded an extension providing it, this will raise `NoMethodError` at runtime. Consider replacing with a Ruby-core implementation (e.g., manual Join logic) or requiring the module that defines `to_sentence` in this execution context. | 592f0ad2d01ff2f3e2708603cd47e2e5220600c7 | 8afc96d27677fd234eaa226f04b3cd11935347ff | diff --git a/Library/Homebrew/dev-cmd/generate-zap.rb b/Library/Homebrew/dev-cmd/generate-zap.rb
index e9ca72c5ee171..43075520ae191 100644
--- a/Library/Homebrew/dev-cmd/generate-zap.rb
+++ b/Library/Homebrew/dev-cmd/generate-zap.rb
@@ -3,10 +3,13 @@
require "abstract_command"
require "cask/cask_loader"
+require "s... | [
"Library/Homebrew/dev-cmd/generate-zap.rb"
] | [
{
"comment": "`Array#to_sentence` is not part of Ruby core; if Homebrew hasn’t loaded an extension providing it, this will raise `NoMethodError` at runtime. Consider replacing with a Ruby-core implementation (e.g., manual Join logic) or requiring the module that defines `to_sentence` in this execution context."... | true | ||
Homebrew/brew | 22,731 | comment_to_fix | generate-zap: search app bundle identifiers | `Array#to_sentence` is not part of Ruby core; if Homebrew hasn’t loaded an extension providing it, this will raise `NoMethodError` at runtime. Consider replacing with a Ruby-core implementation (e.g., manual Join logic) or requiring the module that defines `to_sentence` in this execution context. | 592f0ad2d01ff2f3e2708603cd47e2e5220600c7 | 8afc96d27677fd234eaa226f04b3cd11935347ff | diff --git a/Library/Homebrew/dev-cmd/generate-zap.rb b/Library/Homebrew/dev-cmd/generate-zap.rb
index e9ca72c5ee171..43075520ae191 100644
--- a/Library/Homebrew/dev-cmd/generate-zap.rb
+++ b/Library/Homebrew/dev-cmd/generate-zap.rb
@@ -3,10 +3,13 @@
require "abstract_command"
require "cask/cask_loader"
+require "s... | [
"Library/Homebrew/dev-cmd/generate-zap.rb"
] | [
{
"comment": "`Array#to_sentence` is not part of Ruby core; if Homebrew hasn’t loaded an extension providing it, this will raise `NoMethodError` at runtime. Consider replacing with a Ruby-core implementation (e.g., manual Join logic) or requiring the module that defines `to_sentence` in this execution context."... | true | ||
Homebrew/brew | 22,731 | comment_to_fix | generate-zap: search app bundle identifiers | This changes scanning from “once per directory set” to “once per pattern per directory set” (e.g., scanning twice for name + bundle id). On large directory trees this can significantly increase runtime. Consider scanning each directory set once and matching against all patterns in-memory, or extending `scan_directories... | 592f0ad2d01ff2f3e2708603cd47e2e5220600c7 | 8afc96d27677fd234eaa226f04b3cd11935347ff | diff --git a/Library/Homebrew/dev-cmd/generate-zap.rb b/Library/Homebrew/dev-cmd/generate-zap.rb
index e9ca72c5ee171..43075520ae191 100644
--- a/Library/Homebrew/dev-cmd/generate-zap.rb
+++ b/Library/Homebrew/dev-cmd/generate-zap.rb
@@ -3,10 +3,13 @@
require "abstract_command"
require "cask/cask_loader"
+require "s... | [
"Library/Homebrew/dev-cmd/generate-zap.rb"
] | [
{
"comment": "This changes scanning from “once per directory set” to “once per pattern per directory set” (e.g., scanning twice for name + bundle id). On large directory trees this can significantly increase runtime. Consider scanning each directory set once and matching against all patterns in-memory, or exten... | true | ||
Homebrew/brew | 22,731 | comment_to_fix | generate-zap: search app bundle identifiers | The new early-return branches aren’t covered by the updated spec (missing/unreadable `Info.plist`, and non-String `CFBundleIdentifier`). Adding targeted examples for these cases would lock in the intended behavior and prevent regressions in the “no bundle id available” scenarios. | 592f0ad2d01ff2f3e2708603cd47e2e5220600c7 | 8afc96d27677fd234eaa226f04b3cd11935347ff | diff --git a/Library/Homebrew/dev-cmd/generate-zap.rb b/Library/Homebrew/dev-cmd/generate-zap.rb
index e9ca72c5ee171..43075520ae191 100644
--- a/Library/Homebrew/dev-cmd/generate-zap.rb
+++ b/Library/Homebrew/dev-cmd/generate-zap.rb
@@ -3,10 +3,13 @@
require "abstract_command"
require "cask/cask_loader"
+require "s... | [
"Library/Homebrew/dev-cmd/generate-zap.rb"
] | [
{
"comment": "The new early-return branches aren’t covered by the updated spec (missing/unreadable `Info.plist`, and non-String `CFBundleIdentifier`). Adding targeted examples for these cases would lock in the intended behavior and prevent regressions in the “no bundle id available” scenarios.",
"path": "Li... | true | ||
Homebrew/brew | 22,732 | issue_to_patch | Update sponsors. | Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
| 592f0ad2d01ff2f3e2708603cd47e2e5220600c7 | 7d6b8ade979398f7ca1f6ecb17695551100f8d68 | diff --git a/README.md b/README.md
index a1f7b472ce020..6d56fe09c21d0 100644
--- a/README.md
+++ b/README.md
@@ -112,6 +112,6 @@ Secure password storage and syncing is provided by [1Password for Teams](https:/
[](https://dnsimple.com/resolvin... | [
"README.md"
] | [] | true | ||
Homebrew/brew | 22,727 | issue_to_patch | Handle mksh in Utils::Shell.set_variable_in_profile | mksh users were shown a blank line in place of the `echo 'export ...'`
instruction whenever `Utils::Shell.set_variable_in_profile` was used
(e.g. the `HOMEBREW_GITHUB_API_TOKEN` blurb shown by `brew gist-logs`
and on GitHub API errors, or the Linux `brew doctor` `HOMEBREW_TEMP`
suggestion).
`set_variable_in_prof... | bbba76face1dc81d18c6ae30c78970de680ad62b | 44f2b5ad7e21e668419f889744d98b544fa727f5 | diff --git a/Library/Homebrew/utils/shell.rb b/Library/Homebrew/utils/shell.rb
index b9fc7af143e0a..befe50c606b5e 100644
--- a/Library/Homebrew/utils/shell.rb
+++ b/Library/Homebrew/utils/shell.rb
@@ -79,7 +79,7 @@ def profile
sig { params(variable: String, value: String).returns(T.nilable(String)) }
def set_... | [
"Library/Homebrew/test/utils/shell_spec.rb",
"Library/Homebrew/utils/shell.rb"
] | [
{
"comment": "These examples mutate `ENV[\\\"SHELL\\\"]` without restoring it, which can leak state into later specs and cause order-dependent failures. Save the original value and restore it in an `ensure`/`after` hook, or use an environment helper (e.g., `around` block) to scope the change to each example.",
... | diff --git a/Library/Homebrew/test/utils/shell_spec.rb b/Library/Homebrew/test/utils/shell_spec.rb
index dc088f3f006e4..35edc4226dbb9 100644
--- a/Library/Homebrew/test/utils/shell_spec.rb
+++ b/Library/Homebrew/test/utils/shell_spec.rb
@@ -107,6 +107,14 @@
end
end
+ describe "::set_variable_in_profile" do
+... | true | |
Homebrew/brew | 22,727 | comment_to_fix | Handle mksh in Utils::Shell.set_variable_in_profile | These examples mutate `ENV[\"SHELL\"]` without restoring it, which can leak state into later specs and cause order-dependent failures. Save the original value and restore it in an `ensure`/`after` hook, or use an environment helper (e.g., `around` block) to scope the change to each example. | bbba76face1dc81d18c6ae30c78970de680ad62b | 44f2b5ad7e21e668419f889744d98b544fa727f5 | diff --git a/Library/Homebrew/test/utils/shell_spec.rb b/Library/Homebrew/test/utils/shell_spec.rb
index dc088f3f006e4..35edc4226dbb9 100644
--- a/Library/Homebrew/test/utils/shell_spec.rb
+++ b/Library/Homebrew/test/utils/shell_spec.rb
@@ -107,6 +107,14 @@
end
end
+ describe "::set_variable_in_profile" do
+... | [
"Library/Homebrew/test/utils/shell_spec.rb"
] | [
{
"comment": "These examples mutate `ENV[\\\"SHELL\\\"]` without restoring it, which can leak state into later specs and cause order-dependent failures. Save the original value and restore it in an `ensure`/`after` hook, or use an environment helper (e.g., `around` block) to scope the change to each example.",
... | true | ||
Homebrew/brew | 22,727 | comment_to_fix | Handle mksh in Utils::Shell.set_variable_in_profile | These examples mutate `ENV[\"SHELL\"]` without restoring it, which can leak state into later specs and cause order-dependent failures. Save the original value and restore it in an `ensure`/`after` hook, or use an environment helper (e.g., `around` block) to scope the change to each example. | bbba76face1dc81d18c6ae30c78970de680ad62b | 44f2b5ad7e21e668419f889744d98b544fa727f5 | diff --git a/Library/Homebrew/test/utils/shell_spec.rb b/Library/Homebrew/test/utils/shell_spec.rb
index dc088f3f006e4..35edc4226dbb9 100644
--- a/Library/Homebrew/test/utils/shell_spec.rb
+++ b/Library/Homebrew/test/utils/shell_spec.rb
@@ -107,6 +107,14 @@
end
end
+ describe "::set_variable_in_profile" do
+... | [
"Library/Homebrew/test/utils/shell_spec.rb"
] | [
{
"comment": "These examples mutate `ENV[\\\"SHELL\\\"]` without restoring it, which can leak state into later specs and cause order-dependent failures. Save the original value and restore it in an `ensure`/`after` hook, or use an environment helper (e.g., `around` block) to scope the change to each example.",
... | true | ||
Homebrew/brew | 22,728 | issue_to_patch | Allow Bubblewrap auto-install | - `check_linux_sandbox` blocked source builds before the implicit `bubblewrap` install path could run.
- Keeping it out of fatal checks lets source installs reach the sandbox setup path.
-----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process. -... | 34667e7d577d5fe2a94c13fee4d3a3f09053fddb | 159b3c3246c774e54bb537f9a943c57b3f5ce2d5 | diff --git a/Library/Homebrew/extend/os/linux/diagnostic.rb b/Library/Homebrew/extend/os/linux/diagnostic.rb
index c5f5611f3260e..b91f761995adc 100644
--- a/Library/Homebrew/extend/os/linux/diagnostic.rb
+++ b/Library/Homebrew/extend/os/linux/diagnostic.rb
@@ -27,13 +27,6 @@ def fatal_preinstall_checks
].fre... | [
"Library/Homebrew/extend/os/linux/diagnostic.rb",
"Library/Homebrew/test/os/linux/diagnostic_spec.rb"
] | [] | diff --git a/Library/Homebrew/test/os/linux/diagnostic_spec.rb b/Library/Homebrew/test/os/linux/diagnostic_spec.rb
index 189c3a975ebb8..7d38cb586efb6 100644
--- a/Library/Homebrew/test/os/linux/diagnostic_spec.rb
+++ b/Library/Homebrew/test/os/linux/diagnostic_spec.rb
@@ -42,7 +42,7 @@
end
specify "#fatal_build... | true | |
Homebrew/brew | 22,725 | issue_to_patch | `brew vulns --help` displays the `brew --help` page
Running `brew vulns --help` displays the `brew --help` page, instead of the `brew vulns` options, which is what I expected.
```
% brew vulns --help
Example usage:
brew search TEXT|/REGEX/
brew info [FORMULA|CASK...]
brew install FORMULA|CASK...
brew update
... | help: run an external command's own `--help` when undocumented | `brew <cmd> --help` and `brew help <cmd>` print the generic top-level `brew --help` page for an external command that ships no `#:` help comments — even when that command implements its own `--help`. That makes `--help` useless for those commands.
Fixes https://github.com/Homebrew/homebrew-brew-vulns/issues/85.
-... | bbba76face1dc81d18c6ae30c78970de680ad62b | 1d6f0377bf2726b48bc4eaf75818bb4a98ba088c | diff --git a/Library/Homebrew/brew.rb b/Library/Homebrew/brew.rb
index f44dc932e1d3d..07205a3039273 100644
--- a/Library/Homebrew/brew.rb
+++ b/Library/Homebrew/brew.rb
@@ -89,8 +89,15 @@
# - no arguments are passed
if empty_argv || help_flag
require "help"
+ # `Homebrew::Help.help` may defer to a self-do... | [
"Library/Homebrew/brew.rb",
"Library/Homebrew/help.rb",
"Library/Homebrew/test/cmd/help_spec.rb"
] | [
{
"comment": "For deferred external commands, `ARGV.push(\"--help\")` only runs when *no* Homebrew help flag is present. If the user invokes help via `-h`, `--usage`, or `-?`, `HOMEBREW_HELP` is still set (see `brew.sh:906-910`), so `Homebrew::Help.help` will now defer and `brew.rb` will `exec` the external com... | diff --git a/Library/Homebrew/test/cmd/help_spec.rb b/Library/Homebrew/test/cmd/help_spec.rb
index 9bca5e35aa490..a81fb776e2465 100644
--- a/Library/Homebrew/test/cmd/help_spec.rb
+++ b/Library/Homebrew/test/cmd/help_spec.rb
@@ -144,6 +144,40 @@ def run; end
expect { brew "help", "hello-tap" }
.not_to o... | true |
Homebrew/brew | 22,725 | comment_to_fix | help: run an external command's own `--help` when undocumented | For deferred external commands, `ARGV.push("--help")` only runs when *no* Homebrew help flag is present. If the user invokes help via `-h`, `--usage`, or `-?`, `HOMEBREW_HELP` is still set (see `brew.sh:906-910`), so `Homebrew::Help.help` will now defer and `brew.rb` will `exec` the external command with the *original*... | bbba76face1dc81d18c6ae30c78970de680ad62b | 1d6f0377bf2726b48bc4eaf75818bb4a98ba088c | diff --git a/Library/Homebrew/brew.rb b/Library/Homebrew/brew.rb
index f44dc932e1d3d..07205a3039273 100644
--- a/Library/Homebrew/brew.rb
+++ b/Library/Homebrew/brew.rb
@@ -89,8 +89,15 @@
# - no arguments are passed
if empty_argv || help_flag
require "help"
+ # `Homebrew::Help.help` may defer to a self-do... | [
"Library/Homebrew/brew.rb"
] | [
{
"comment": "For deferred external commands, `ARGV.push(\"--help\")` only runs when *no* Homebrew help flag is present. If the user invokes help via `-h`, `--usage`, or `-?`, `HOMEBREW_HELP` is still set (see `brew.sh:906-910`), so `Homebrew::Help.help` will now defer and `brew.rb` will `exec` the external com... | true | ||
Homebrew/brew | 22,725 | comment_to_fix | help: run an external command's own `--help` when undocumented | `undocumented_external_cmd` re-calls `Commands.external_ruby_v2_cmd_path(cmd)`, but `Commands.path(cmd)` has already resolved the command type and would have returned the Ruby v2 path if it existed. This extra lookup is redundant and potentially expensive (it calls `which` and may trigger trust checks). | bbba76face1dc81d18c6ae30c78970de680ad62b | 1d6f0377bf2726b48bc4eaf75818bb4a98ba088c | diff --git a/Library/Homebrew/help.rb b/Library/Homebrew/help.rb
index 9b3170b682806..682eeaca52c35 100644
--- a/Library/Homebrew/help.rb
+++ b/Library/Homebrew/help.rb
@@ -46,6 +46,15 @@ def self.help(cmd = nil, empty_argv: false, usage_error: nil, remaining_args: []
# Resume execution in `brew.rb` for unknown ... | [
"Library/Homebrew/help.rb"
] | [
{
"comment": "`undocumented_external_cmd` re-calls `Commands.external_ruby_v2_cmd_path(cmd)`, but `Commands.path(cmd)` has already resolved the command type and would have returned the Ruby v2 path if it existed. This extra lookup is redundant and potentially expensive (it calls `which` and may trigger trust ch... | true | ||
Homebrew/brew | 22,725 | comment_to_fix | help: run an external command's own `--help` when undocumented | This fixture command prints usage unconditionally, so the spec passes even if `brew help selfdoc` fails to actually execute the external command with `--help`. Making the script fail unless it receives `--help` will ensure the regression being fixed is actually covered. | bbba76face1dc81d18c6ae30c78970de680ad62b | 1d6f0377bf2726b48bc4eaf75818bb4a98ba088c | diff --git a/Library/Homebrew/test/cmd/help_spec.rb b/Library/Homebrew/test/cmd/help_spec.rb
index 9bca5e35aa490..a81fb776e2465 100644
--- a/Library/Homebrew/test/cmd/help_spec.rb
+++ b/Library/Homebrew/test/cmd/help_spec.rb
@@ -144,6 +144,40 @@ def run; end
expect { brew "help", "hello-tap" }
.not_to o... | [
"Library/Homebrew/test/cmd/help_spec.rb"
] | [
{
"comment": "This fixture command prints usage unconditionally, so the spec passes even if `brew help selfdoc` fails to actually execute the external command with `--help`. Making the script fail unless it receives `--help` will ensure the regression being fixed is actually covered.",
"path": "Library/Home... | true | ||
Homebrew/brew | 22,725 | comment_to_fix | help: run an external command's own `--help` when undocumented | This spec currently matches on the presence of the `#:` output but would still pass if the command body is executed and prints extra output. Make the command body fail if executed so the test truly asserts that `brew help commented` renders comment help without running the external command. | bbba76face1dc81d18c6ae30c78970de680ad62b | 1d6f0377bf2726b48bc4eaf75818bb4a98ba088c | diff --git a/Library/Homebrew/test/cmd/help_spec.rb b/Library/Homebrew/test/cmd/help_spec.rb
index 9bca5e35aa490..a81fb776e2465 100644
--- a/Library/Homebrew/test/cmd/help_spec.rb
+++ b/Library/Homebrew/test/cmd/help_spec.rb
@@ -144,6 +144,40 @@ def run; end
expect { brew "help", "hello-tap" }
.not_to o... | [
"Library/Homebrew/test/cmd/help_spec.rb"
] | [
{
"comment": "This spec currently matches on the presence of the `#:` output but would still pass if the command body is executed and prints extra output. Make the command body fail if executed so the test truly asserts that `brew help commented` renders comment help without running the external command.",
... | true | ||
Homebrew/brew | 22,721 | issue_to_patch | Source-built formulae from custom-remote (non-GitHub) taps fail with a silent UntrustedTapError because the build sandbox can't resolve the tap's git remote
### `brew doctor` output
```shell
Warning: Some installed casks are deprecated or disabled.
You should find replacements for the following casks:
alacritty
Wa... | Keep tap remotes visible in builds | Fixes https://github.com/Homebrew/brew/issues/22719
- `build.rb` trust checks need tap remotes inside the sandbox.
- Global Git config reads can fail before local tap config is read.
- Shared Git helpers keep sandbox and fetch behaviour aligned.
-----
<!-- Do not tick a checkbox if you haven’t performed its ... | 2b207ee2769bbe93d0534da01b6b217173dab6f6 | 099a33d1ed0dc993a1f57229599917ce64b0cb16 | diff --git a/Library/Homebrew/download_strategy/git_download_strategy.rb b/Library/Homebrew/download_strategy/git_download_strategy.rb
index f0915ee8bfd2f..f73c4f9bc2cb7 100644
--- a/Library/Homebrew/download_strategy/git_download_strategy.rb
+++ b/Library/Homebrew/download_strategy/git_download_strategy.rb
@@ -50,7 +5... | [
"Library/Homebrew/download_strategy/git_download_strategy.rb",
"Library/Homebrew/formula.rb",
"Library/Homebrew/git_repository.rb",
"Library/Homebrew/test/download_strategies/git_spec.rb",
"Library/Homebrew/test/formula_spec.rb",
"Library/Homebrew/test/git_repository_spec.rb",
"Library/Homebrew/utils/gi... | [] | diff --git a/Library/Homebrew/test/download_strategies/git_spec.rb b/Library/Homebrew/test/download_strategies/git_spec.rb
index 2035cf7b90907..79dbd084fcd78 100644
--- a/Library/Homebrew/test/download_strategies/git_spec.rb
+++ b/Library/Homebrew/test/download_strategies/git_spec.rb
@@ -45,7 +45,7 @@ def setup_git_rep... | true |
Homebrew/brew | 22,720 | issue_to_patch | Make bottle cache checks cheaper | - GHCR bottle blobs are content-addressed by API checksum metadata.
- Warm cache hits can skip generic discovery and checksum rehashing.
- The guard keeps mirrors, casks, sources and other strategies generic.
-----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a s... | 8afa1a8c755fd8e03e0ee047f00ac55f3f497366 | 5b4c8af08fe4701f1ee7031ae338e43ec74f15e4 | diff --git a/Library/Homebrew/bottle.rb b/Library/Homebrew/bottle.rb
index ef34158e60d85..72e5c83665c18 100644
--- a/Library/Homebrew/bottle.rb
+++ b/Library/Homebrew/bottle.rb
@@ -142,6 +142,20 @@ def fetch(verify_download_integrity: true, timeout: nil, quiet: false)
retry
end
+ sig { override.returns(T::Bo... | [
"Library/Homebrew/bottle.rb",
"Library/Homebrew/download_strategy/curl_github_packages_download_strategy.rb",
"Library/Homebrew/test/bottle_spec.rb",
"Library/Homebrew/test/download_strategies/curl_github_packages_spec.rb"
] | [
{
"comment": "`AbstractFileDownloadStrategy#cached_location` consistently stores cached downloads under `HOMEBREW_CACHE/\"downloads\"` regardless of the `cache:` meta used for symlink placement. Using `cache/\"downloads\"` here changes that behavior for immutable bottle blobs if this strategy is ever instantiat... | diff --git a/Library/Homebrew/test/bottle_spec.rb b/Library/Homebrew/test/bottle_spec.rb
index 2bfee5e574633..58149a9e2c616 100644
--- a/Library/Homebrew/test/bottle_spec.rb
+++ b/Library/Homebrew/test/bottle_spec.rb
@@ -15,4 +15,25 @@
expect(bottle.filename.to_s).to eq("testball_bottle--0.1.arm64_big_sur.bottle... | true | |
Homebrew/brew | 22,720 | comment_to_fix | Make bottle cache checks cheaper | `AbstractFileDownloadStrategy#cached_location` consistently stores cached downloads under `HOMEBREW_CACHE/"downloads"` regardless of the `cache:` meta used for symlink placement. Using `cache/"downloads"` here changes that behavior for immutable bottle blobs if this strategy is ever instantiated with a non-default `cac... | 8afa1a8c755fd8e03e0ee047f00ac55f3f497366 | 5b4c8af08fe4701f1ee7031ae338e43ec74f15e4 | diff --git a/Library/Homebrew/download_strategy/curl_github_packages_download_strategy.rb b/Library/Homebrew/download_strategy/curl_github_packages_download_strategy.rb
index b328d0c69a2c2..99bcc8859f628 100644
--- a/Library/Homebrew/download_strategy/curl_github_packages_download_strategy.rb
+++ b/Library/Homebrew/dow... | [
"Library/Homebrew/download_strategy/curl_github_packages_download_strategy.rb"
] | [
{
"comment": "`AbstractFileDownloadStrategy#cached_location` consistently stores cached downloads under `HOMEBREW_CACHE/\"downloads\"` regardless of the `cache:` meta used for symlink placement. Using `cache/\"downloads\"` here changes that behavior for immutable bottle blobs if this strategy is ever instantiat... | true | ||
Homebrew/brew | 22,724 | issue_to_patch | Update manpage and completions. | Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
| 2f1cb50858298c4ac6e9e9fe65d6ae360160da24 | 9120eac4524a1967460f1280d22c1a96e73c1723 | diff --git a/completions/bash/brew b/completions/bash/brew
index 70bebbc87a1f4..60ce5c3879391 100644
--- a/completions/bash/brew
+++ b/completions/bash/brew
@@ -2746,6 +2746,22 @@ _brew_setup_ruby() {
__brew_complete_commands
}
+_brew_setup_sandbox() {
+ local cur="${COMP_WORDS[COMP_CWORD]}"
+ case "${cur}" in
... | [
"completions/bash/brew",
"completions/fish/brew.fish",
"completions/internal_commands_list.txt",
"completions/zsh/_brew",
"docs/Manpage.md",
"manpages/brew.1"
] | [] | true | ||
Homebrew/brew | 22,691 | issue_to_patch | Add command to set up sandbox | Following https://github.com/Homebrew/actions/pull/866
-----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process. -->
<!-- Use [x] to mark item done before creation, or just click the checkboxes with device pointer after creation -->
<!-- Do not ... | 84a66809e0ab39e49840de74f5edb9a62d9239a6 | a642916b83d69821b804fb80c7f0b2db15c86544 | diff --git a/Library/Homebrew/brew.sh b/Library/Homebrew/brew.sh
index ead689d5630b4..e9c7c455d19f2 100644
--- a/Library/Homebrew/brew.sh
+++ b/Library/Homebrew/brew.sh
@@ -243,6 +243,10 @@ check-run-command-as-root() {
# can immediately dispatch the requested Homebrew command as the console user.
[[ "${HOMEBREW_... | [
"Library/Homebrew/brew.sh",
"Library/Homebrew/cmd/setup-sandbox.rb",
"Library/Homebrew/cmd/setup-sandbox.sh",
"Library/Homebrew/extend/os/linux/diagnostic.rb",
"Library/Homebrew/extend/os/linux/sandbox.rb",
"Library/Homebrew/sandbox.rb",
"Library/Homebrew/test/cmd/setup-sandbox_spec.rb",
"Library/Home... | [
{
"comment": "```suggestion\n Run any necessary commands to setup the Homebrew sandbox.\n Must be run with `sudo`.\n \t Currently a no-op on non-Linux\n```",
"path": "Library/Homebrew/cmd/setup-sandbox.rb",
"hunk": "@@ -0,0 +1,19 @@\n+# typed: strict\n+# frozen_string_literal: t... | diff --git a/Library/Homebrew/test/cmd/setup-sandbox_spec.rb b/Library/Homebrew/test/cmd/setup-sandbox_spec.rb
new file mode 100644
index 0000000000000..afe7ad26804fa
--- /dev/null
+++ b/Library/Homebrew/test/cmd/setup-sandbox_spec.rb
@@ -0,0 +1,119 @@
+# typed: true
+# frozen_string_literal: true
+
+require "open3"
+
... | true | |
Homebrew/brew | 22,691 | comment_to_fix | Add command to set up sandbox | ```suggestion
Run any necessary commands to setup the Homebrew sandbox.
Must be run with `sudo`.
Currently a no-op on non-Linux
``` | 84a66809e0ab39e49840de74f5edb9a62d9239a6 | a642916b83d69821b804fb80c7f0b2db15c86544 | diff --git a/Library/Homebrew/cmd/setup-sandbox.rb b/Library/Homebrew/cmd/setup-sandbox.rb
new file mode 100644
index 0000000000000..ace0d09277fab
--- /dev/null
+++ b/Library/Homebrew/cmd/setup-sandbox.rb
@@ -0,0 +1,20 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "abstract_command"
+require "shell_comm... | [
"Library/Homebrew/cmd/setup-sandbox.rb"
] | [
{
"comment": "```suggestion\n Run any necessary commands to setup the Homebrew sandbox.\n Must be run with `sudo`.\n \t Currently a no-op on non-Linux\n```",
"path": "Library/Homebrew/cmd/setup-sandbox.rb",
"hunk": "@@ -0,0 +1,19 @@\n+# typed: strict\n+# frozen_string_literal: t... | true | ||
Homebrew/brew | 22,691 | comment_to_fix | Add command to set up sandbox | `brew setup-sandbox` is documented as needing to be run under `sudo`, but the Bubblewrap install branch relies on `GITHUB_ACTIONS` being set. In typical `sudo` configurations this env var is not preserved, so this branch may never run on GitHub Actions in the intended invocation. Consider also detecting GitHub Actions ... | 84a66809e0ab39e49840de74f5edb9a62d9239a6 | a642916b83d69821b804fb80c7f0b2db15c86544 | diff --git a/Library/Homebrew/cmd/setup-sandbox.sh b/Library/Homebrew/cmd/setup-sandbox.sh
new file mode 100644
index 0000000000000..87c764528b24d
--- /dev/null
+++ b/Library/Homebrew/cmd/setup-sandbox.sh
@@ -0,0 +1,53 @@
+# Documentation defined in Library/Homebrew/cmd/setup-sandbox.rb
+
+# This Bubblewrap installatio... | [
"Library/Homebrew/cmd/setup-sandbox.sh"
] | [
{
"comment": "`brew setup-sandbox` is documented as needing to be run under `sudo`, but the Bubblewrap install branch relies on `GITHUB_ACTIONS` being set. In typical `sudo` configurations this env var is not preserved, so this branch may never run on GitHub Actions in the intended invocation. Consider also det... | true | ||
Homebrew/brew | 22,714 | issue_to_patch | "Some installed formulae or casks are missing dependencies." - dependencies aren't missing!
### `brew config` AND `brew doctor` output OR `brew gist-logs <formula>` link
```shell
I am getting a missing dependency warning on brew doctor command. The warning says I am missing the `icu4c@78` dependency package, however,... | formula: restore missing finding aliases for old tabs | Fixes https://github.com/Homebrew/homebrew-core/issues/287502
-----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process. -->
<!-- Use [x] to mark item done before creation, or just click the checkboxes with device pointer after creation -->
<!-- ... | 99f2689814a4ee9b224411d8597bed0fc374a150 | 9119819bf6a79a842c173aa76b0ebd7a4132bb30 | diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb
index 8e41a4e034024..9eec286e8f76a 100644
--- a/Library/Homebrew/formula.rb
+++ b/Library/Homebrew/formula.rb
@@ -2893,7 +2893,8 @@ def missing_dependencies(hide: [])
# A dep is "missing" if it's in the hide list (pretend uninstalled) or
... | [
"Library/Homebrew/formula.rb",
"Library/Homebrew/test/formula_spec.rb"
] | [
{
"comment": "`(HOMEBREW_PREFIX/\"opt\"/base_name).directory?` will also return true for a plain directory under `#{HOMEBREW_PREFIX}/opt`, which can incorrectly treat a dependency as installed even when there is no opt *symlink* (Homebrew convention is that `opt/*` entries are symlinks to kegs/oldnames). Consid... | diff --git a/Library/Homebrew/test/formula_spec.rb b/Library/Homebrew/test/formula_spec.rb
index 2a900188dc998..fc9fd139394b7 100644
--- a/Library/Homebrew/test/formula_spec.rb
+++ b/Library/Homebrew/test/formula_spec.rb
@@ -1567,6 +1567,14 @@ def post_install; end
expect(f.missing_dependencies).to be_empty
... | true |
Homebrew/brew | 22,714 | comment_to_fix | formula: restore missing finding aliases for old tabs | `(HOMEBREW_PREFIX/"opt"/base_name).directory?` will also return true for a plain directory under `#{HOMEBREW_PREFIX}/opt`, which can incorrectly treat a dependency as installed even when there is no opt *symlink* (Homebrew convention is that `opt/*` entries are symlinks to kegs/oldnames). Consider requiring the opt ent... | 99f2689814a4ee9b224411d8597bed0fc374a150 | 9119819bf6a79a842c173aa76b0ebd7a4132bb30 | diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb
index 8e41a4e034024..9eec286e8f76a 100644
--- a/Library/Homebrew/formula.rb
+++ b/Library/Homebrew/formula.rb
@@ -2893,7 +2893,8 @@ def missing_dependencies(hide: [])
# A dep is "missing" if it's in the hide list (pretend uninstalled) or
... | [
"Library/Homebrew/formula.rb"
] | [
{
"comment": "`(HOMEBREW_PREFIX/\"opt\"/base_name).directory?` will also return true for a plain directory under `#{HOMEBREW_PREFIX}/opt`, which can incorrectly treat a dependency as installed even when there is no opt *symlink* (Homebrew convention is that `opt/*` entries are symlinks to kegs/oldnames). Consid... | true | ||
Homebrew/brew | 22,723 | issue_to_patch | Drop GitHub code coverage upload | Prefer Codecov for coverage reporting over the GitHub-native `actions/upload-code-coverage` upload.
-----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process. -->
<!-- Use [x] to mark item done before creation, or just click the checkboxes with de... | 8afa1a8c755fd8e03e0ee047f00ac55f3f497366 | c3800ac875ac95603f61c224ffa0a1826930a10e | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 25302a8e24a07..a3101df56bef9 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -320,13 +320,6 @@ jobs:
disable_search: true
token: ${{ secrets.CODECOV_TOKEN }}
- - uses: actions/upload-c... | [
".github/workflows/tests.yml"
] | [] | true | ||
Homebrew/brew | 22,722 | issue_to_patch | Fix Codex stop hook `brew lgtm` output (again) | - Keep Stop hook stdout valid JSON so Codex can parse it.
- Move `./bin/brew lgtm` handling into a wrapper script.
-----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process. -->
<!-- Use [x] to mark item done before creation, or just click the ch... | 2b207ee2769bbe93d0534da01b6b217173dab6f6 | 694e77e1c0f1190ffb586791567513d25e26bfa3 | diff --git a/.codex/hooks.json b/.codex/hooks.json
index 5374b0e628cce..8baaa5a8e2387 100644
--- a/.codex/hooks.json
+++ b/.codex/hooks.json
@@ -5,7 +5,7 @@
"hooks": [
{
"type": "command",
- "command": "./bin/brew lgtm >&2 && printf '{\"continue\":true}'",
+ "comma... | [
".codex/hooks.json",
".codex/hooks/brew-lgtm-stop.sh"
] | [] | true | ||
Homebrew/brew | 22,709 | issue_to_patch | which-formula: parse all expected cli options | Currently, `brew which-formula --help` errors out (but does print usage, if incidentally). Other long form options which-formula claims to support (per `brew help which-formula`) also error out and print usage. All single letter options fail, as they are parsed as arguments rather than options. This behavior is confusi... | 2b207ee2769bbe93d0534da01b6b217173dab6f6 | 62b3a44e8bd9fdf10670ebdcdd9f1df060e3473a | diff --git a/AGENTS.md b/AGENTS.md
index 8271a8a608263..525883c212c57 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -34,6 +34,7 @@ Do not use conventional commit prefixes such as `feat:`, `fix:`, `chore:`, `refa
- When adding or tightening tests, verify them with a red/green cycle using the exact `--only=file:line` target... | [
"AGENTS.md",
"Library/Homebrew/cmd/as-console-user.sh",
"Library/Homebrew/cmd/exec.sh",
"Library/Homebrew/cmd/update-reset.sh",
"Library/Homebrew/cmd/update.sh",
"Library/Homebrew/cmd/vendor-install.sh",
"Library/Homebrew/cmd/which-formula.sh",
"Library/Homebrew/test/cmd/as-console-user_spec.rb",
"L... | [
{
"comment": "The `-*` branch currently consumes *any* short option without validating it or preserving it as a positional argument. For example, `-q`/`-v` will be silently ignored (no effect, not added to `args`, and no error), which is a behavior change from previously treating non-`--*` tokens as args. Consi... | diff --git a/Library/Homebrew/test/cmd/as-console-user_spec.rb b/Library/Homebrew/test/cmd/as-console-user_spec.rb
index 3b1e2a468852e..39a0def9e10fb 100644
--- a/Library/Homebrew/test/cmd/as-console-user_spec.rb
+++ b/Library/Homebrew/test/cmd/as-console-user_spec.rb
@@ -36,6 +36,7 @@ def run_as_console_user_shell(scr... | true | |
Homebrew/brew | 22,709 | comment_to_fix | which-formula: parse all expected cli options | The `-*` branch currently consumes *any* short option without validating it or preserving it as a positional argument. For example, `-q`/`-v` will be silently ignored (no effect, not added to `args`, and no error), which is a behavior change from previously treating non-`--*` tokens as args. Consider explicitly handlin... | 2b207ee2769bbe93d0534da01b6b217173dab6f6 | 62b3a44e8bd9fdf10670ebdcdd9f1df060e3473a | diff --git a/Library/Homebrew/cmd/which-formula.sh b/Library/Homebrew/cmd/which-formula.sh
index 8e4c70dbe1677..6a4f9b06559de 100644
--- a/Library/Homebrew/cmd/which-formula.sh
+++ b/Library/Homebrew/cmd/which-formula.sh
@@ -1,6 +1,7 @@
# Documentation defined in Library/Homebrew/cmd/which-formula.rb
# shellcheck d... | [
"Library/Homebrew/cmd/which-formula.sh"
] | [
{
"comment": "The `-*` branch currently consumes *any* short option without validating it or preserving it as a positional argument. For example, `-q`/`-v` will be silently ignored (no effect, not added to `args`, and no error), which is a behavior change from previously treating non-`--*` tokens as args. Consi... | true | ||
Homebrew/brew | 22,709 | comment_to_fix | which-formula: parse all expected cli options | These options are accepted but intentionally do nothing, which can be confusing (users expect `--verbose`/`--quiet` to change behavior). If these flags are meant to be handled globally elsewhere, consider removing these branches (so they can be caught as unknown here) or add a brief comment explaining why they are pars... | 2b207ee2769bbe93d0534da01b6b217173dab6f6 | 62b3a44e8bd9fdf10670ebdcdd9f1df060e3473a | diff --git a/Library/Homebrew/cmd/which-formula.sh b/Library/Homebrew/cmd/which-formula.sh
index 8e4c70dbe1677..6a4f9b06559de 100644
--- a/Library/Homebrew/cmd/which-formula.sh
+++ b/Library/Homebrew/cmd/which-formula.sh
@@ -1,6 +1,7 @@
# Documentation defined in Library/Homebrew/cmd/which-formula.rb
# shellcheck d... | [
"Library/Homebrew/cmd/which-formula.sh"
] | [
{
"comment": "These options are accepted but intentionally do nothing, which can be confusing (users expect `--verbose`/`--quiet` to change behavior). If these flags are meant to be handled globally elsewhere, consider removing these branches (so they can be caught as unknown here) or add a brief comment explai... | true | ||
Homebrew/brew | 22,715 | issue_to_patch | brew install --head fails during sandbox build unable to open PTY
### `brew doctor` output
```shell
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore t... | Limit sandbox home deny rules | Fixes https://github.com/Homebrew/brew/issues/22711 by reverting the approach in https://github.com/Homebrew/brew/pull/22660.
- avoid recursively enumerating large home directories when Homebrew paths need to stay readable inside the sandbox.
- deny common credential and personal-data paths instead.
- keep `.confi... | c27836f51186825501dde431935392b5047e2d75 | 315b280a203a687418fc59a08adaac7147495797 | diff --git a/Library/Homebrew/sandbox.rb b/Library/Homebrew/sandbox.rb
index bbf06f0549a2f..b33351cafd908 100644
--- a/Library/Homebrew/sandbox.rb
+++ b/Library/Homebrew/sandbox.rb
@@ -212,7 +212,7 @@ def deny_read_path(path)
sig { void }
def deny_read_home
home = Pathname(Dir.home(ENV.fetch("USER"))).realpa... | [
"Library/Homebrew/sandbox.rb",
"Library/Homebrew/test/sandbox_shared_spec.rb"
] | [
{
"comment": "`deny_read_home` unconditionally denies `~/.config` when Homebrew needs some `$HOME` access. But `HOMEBREW_USER_CONFIG_HOME` defaults to `${XDG_CONFIG_HOME}/homebrew` (see `bin/brew`), so when `XDG_CONFIG_HOME=$HOME/.config` this will block reads of the trust store (`$HOMEBREW_USER_CONFIG_HOME/tru... | diff --git a/Library/Homebrew/test/sandbox_shared_spec.rb b/Library/Homebrew/test/sandbox_shared_spec.rb
index 11111eb82da4d..165ec3c0ec721 100644
--- a/Library/Homebrew/test/sandbox_shared_spec.rb
+++ b/Library/Homebrew/test/sandbox_shared_spec.rb
@@ -293,60 +293,120 @@ def executable_usable?(candidate)
expect(... | true |
Homebrew/brew | 22,715 | comment_to_fix | Limit sandbox home deny rules | `deny_read_home` unconditionally denies `~/.config` when Homebrew needs some `$HOME` access. But `HOMEBREW_USER_CONFIG_HOME` defaults to `${XDG_CONFIG_HOME}/homebrew` (see `bin/brew`), so when `XDG_CONFIG_HOME=$HOME/.config` this will block reads of the trust store (`$HOMEBREW_USER_CONFIG_HOME/trust.json`) and can brea... | c27836f51186825501dde431935392b5047e2d75 | 315b280a203a687418fc59a08adaac7147495797 | diff --git a/Library/Homebrew/sandbox.rb b/Library/Homebrew/sandbox.rb
index bbf06f0549a2f..b33351cafd908 100644
--- a/Library/Homebrew/sandbox.rb
+++ b/Library/Homebrew/sandbox.rb
@@ -212,7 +212,7 @@ def deny_read_path(path)
sig { void }
def deny_read_home
home = Pathname(Dir.home(ENV.fetch("USER"))).realpa... | [
"Library/Homebrew/sandbox.rb"
] | [
{
"comment": "`deny_read_home` unconditionally denies `~/.config` when Homebrew needs some `$HOME` access. But `HOMEBREW_USER_CONFIG_HOME` defaults to `${XDG_CONFIG_HOME}/homebrew` (see `bin/brew`), so when `XDG_CONFIG_HOME=$HOME/.config` this will block reads of the trust store (`$HOMEBREW_USER_CONFIG_HOME/tru... | true | ||
Homebrew/brew | 22,715 | comment_to_fix | Limit sandbox home deny rules | The trust-store readability spec only covers `HOMEBREW_USER_CONFIG_HOME` under `~/.homebrew`, but `bin/brew` sets `HOMEBREW_USER_CONFIG_HOME` to `${XDG_CONFIG_HOME}/homebrew` when `XDG_CONFIG_HOME` is set. Adding coverage for the `~/.config/homebrew` case would catch regressions where denying `~/.config` accidentally b... | c27836f51186825501dde431935392b5047e2d75 | 315b280a203a687418fc59a08adaac7147495797 | diff --git a/Library/Homebrew/test/sandbox_shared_spec.rb b/Library/Homebrew/test/sandbox_shared_spec.rb
index 11111eb82da4d..165ec3c0ec721 100644
--- a/Library/Homebrew/test/sandbox_shared_spec.rb
+++ b/Library/Homebrew/test/sandbox_shared_spec.rb
@@ -293,60 +293,120 @@ def executable_usable?(candidate)
expect(... | [
"Library/Homebrew/test/sandbox_shared_spec.rb"
] | [
{
"comment": "The trust-store readability spec only covers `HOMEBREW_USER_CONFIG_HOME` under `~/.homebrew`, but `bin/brew` sets `HOMEBREW_USER_CONFIG_HOME` to `${XDG_CONFIG_HOME}/homebrew` when `XDG_CONFIG_HOME` is set. Adding coverage for the `~/.config/homebrew` case would catch regressions where denying `~/.... | true | ||
Homebrew/brew | 22,717 | issue_to_patch | sandbox: scope `require "trust"` to avoid `brew irb` failure | -----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process. -->
<!-- Use [x] to mark item done before creation, or just click the checkboxes with device pointer after creation -->
<!-- Do not delete these checkboxes or this pull request will be close... | 3c9850f567740780170374716a417cf56800fff4 | 00de9cdccda58d5cbb1134a16378af419c2a43df | diff --git a/Library/Homebrew/sandbox.rb b/Library/Homebrew/sandbox.rb
index b33351cafd908..f2a2b80504d3d 100644
--- a/Library/Homebrew/sandbox.rb
+++ b/Library/Homebrew/sandbox.rb
@@ -5,7 +5,6 @@
require "pty"
require "tempfile"
require "exceptions"
-require "trust"
require "utils/fork"
require "utils/output"
@... | [
"Library/Homebrew/sandbox.rb"
] | [] | true | ||
Homebrew/brew | 22,716 | issue_to_patch | test: deny shell config reads in sandboxed home | Follow-up to https://github.com/Homebrew/brew/pull/22715.
When Homebrew needs some `$HOME` paths to stay readable inside the sandbox, `deny_read_home` now uses a curated deny list instead of denying every home entry. That list already covered shell history files, package-manager credentials and common cloud/tool con... | 3c9850f567740780170374716a417cf56800fff4 | 1d7b8827cd49d950141528be85d5e872c711fae5 | diff --git a/Library/Homebrew/sandbox.rb b/Library/Homebrew/sandbox.rb
index b33351cafd908..716599b4531a2 100644
--- a/Library/Homebrew/sandbox.rb
+++ b/Library/Homebrew/sandbox.rb
@@ -236,6 +236,7 @@ def deny_read_home
".azure",
".boto",
".docker",
+ ".config/fish",
".config/... | [
"Library/Homebrew/sandbox.rb",
"Library/Homebrew/test/sandbox_shared_spec.rb"
] | [] | diff --git a/Library/Homebrew/test/sandbox_shared_spec.rb b/Library/Homebrew/test/sandbox_shared_spec.rb
index 165ec3c0ec721..2ee62384f8deb 100644
--- a/Library/Homebrew/test/sandbox_shared_spec.rb
+++ b/Library/Homebrew/test/sandbox_shared_spec.rb
@@ -307,6 +307,7 @@ def executable_usable?(candidate)
home/".c... | true | |
Homebrew/brew | 22,712 | issue_to_patch | sandbox: deny_read_home causes fatal git error on user config access
### `brew doctor` output
```shell
Your system is ready to brew.
```
### Verification
- [x] I ran `brew update` twice and am still able to reproduce my issue.
- [x] My "`brew doctor` output" above says `Your system is ready to brew` or a definitely... | Avoid sandbox user config reads | Fixes https://github.com/Homebrew/brew/issues/22710
Fixes https://github.com/Homebrew/brew/issues/22711
- `git` treats sandbox-denied global config reads as fatal.
- Keep build, test and postinstall tools away from user config.
- Cover Git downloads and shared sandbox phase environment.
-----
<!-- Do not ti... | 99f2689814a4ee9b224411d8597bed0fc374a150 | bfd1209e3551c5bf64c3ff70b92349d5c00f121a | diff --git a/Library/Homebrew/download_strategy/git_download_strategy.rb b/Library/Homebrew/download_strategy/git_download_strategy.rb
index 9e9eb852dfbd0..f0915ee8bfd2f 100644
--- a/Library/Homebrew/download_strategy/git_download_strategy.rb
+++ b/Library/Homebrew/download_strategy/git_download_strategy.rb
@@ -47,6 +4... | [
"Library/Homebrew/download_strategy/git_download_strategy.rb",
"Library/Homebrew/formula.rb",
"Library/Homebrew/test/download_strategies/git_spec.rb",
"Library/Homebrew/test/formula_spec.rb"
] | [
{
"comment": "PR description says this change fixes #22711 (PTY.open failure in `Sandbox#run`), but this PR doesn't modify `Library/Homebrew/sandbox.rb` and `Sandbox#run` still unconditionally uses `PTY.open`. Unless there are other linked changes, this PR appears unable to address #22711; please remove the “Fi... | diff --git a/Library/Homebrew/test/download_strategies/git_spec.rb b/Library/Homebrew/test/download_strategies/git_spec.rb
index f8766602c4307..2035cf7b90907 100644
--- a/Library/Homebrew/test/download_strategies/git_spec.rb
+++ b/Library/Homebrew/test/download_strategies/git_spec.rb
@@ -39,6 +39,19 @@ def setup_git_re... | true |
Homebrew/brew | 22,712 | comment_to_fix | Avoid sandbox user config reads | PR description says this change fixes #22711 (PTY.open failure in `Sandbox#run`), but this PR doesn't modify `Library/Homebrew/sandbox.rb` and `Sandbox#run` still unconditionally uses `PTY.open`. Unless there are other linked changes, this PR appears unable to address #22711; please remove the “Fixes #22711” claim or a... | 99f2689814a4ee9b224411d8597bed0fc374a150 | bfd1209e3551c5bf64c3ff70b92349d5c00f121a | diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb
index 8e41a4e034024..715096154e502 100644
--- a/Library/Homebrew/formula.rb
+++ b/Library/Homebrew/formula.rb
@@ -1662,7 +1662,6 @@ def run_post_install
TMPDIR: HOMEBREW_TEMP,
TEMP: HOMEBREW_TEMP,
TMP: ... | [
"Library/Homebrew/formula.rb"
] | [
{
"comment": "PR description says this change fixes #22711 (PTY.open failure in `Sandbox#run`), but this PR doesn't modify `Library/Homebrew/sandbox.rb` and `Sandbox#run` still unconditionally uses `PTY.open`. Unless there are other linked changes, this PR appears unable to address #22711; please remove the “Fi... | true | ||
Homebrew/brew | 22,662 | issue_to_patch | Start install downloads earlier | - Start formula prelude fetches before dependant checks when no prompt can block.
- Share prelude-fetch queueing across install, reinstall and upgrade.
- Reuse the early queue later to avoid changing pour/link behaviour.
-----
<!-- Do not tick a checkbox if you haven’t performed its action. Honesty is indispens... | d98430a757c5b2e967d9af290c550d542fce362f | a40d2df7f5536d09333bdd6bee023d8126ff7b2d | diff --git a/Library/Homebrew/cmd/install.rb b/Library/Homebrew/cmd/install.rb
index 194be044f1acd..89b7df85907ca 100644
--- a/Library/Homebrew/cmd/install.rb
+++ b/Library/Homebrew/cmd/install.rb
@@ -304,22 +304,35 @@ def run
skip_link: args.skip_link?,
)
- dependants = Up... | [
"Library/Homebrew/cmd/install.rb",
"Library/Homebrew/cmd/reinstall.rb",
"Library/Homebrew/formula_installer.rb",
"Library/Homebrew/install.rb",
"Library/Homebrew/test/cmd/install_spec.rb",
"Library/Homebrew/test/cmd/reinstall_spec.rb",
"Library/Homebrew/test/formula_installer_spec.rb"
] | [
{
"comment": "## Useless assignment to local variable\n\nThis assignment to <a class=\"Link\" href=\"/Homebrew/brew/blob/7a9a1e1aeffa07f7e7e28e84af8acb633faaaeac/Library/Homebrew/cmd/install.rb#L307-L307\">shared_download_queue</a> is useless, since its value is never read.\n\n---\n\n<p>Remove the redundant ass... | diff --git a/Library/Homebrew/test/cmd/install_spec.rb b/Library/Homebrew/test/cmd/install_spec.rb
index f239719db504e..23bf42bfad5b1 100644
--- a/Library/Homebrew/test/cmd/install_spec.rb
+++ b/Library/Homebrew/test/cmd/install_spec.rb
@@ -278,6 +278,40 @@
expect(Homebrew).to have_failed
end
+ it "starts fo... | true | |
Homebrew/brew | 22,662 | comment_to_fix | Start install downloads earlier | ## Useless assignment to local variable
This assignment to <a class="Link" href="/Homebrew/brew/blob/7a9a1e1aeffa07f7e7e28e84af8acb633faaaeac/Library/Homebrew/cmd/install.rb#L307-L307">shared_download_queue</a> is useless, since its value is never read.
---
<p>Remove the redundant assignment in <code>Library/Homebre... | d98430a757c5b2e967d9af290c550d542fce362f | a40d2df7f5536d09333bdd6bee023d8126ff7b2d | diff --git a/Library/Homebrew/cmd/install.rb b/Library/Homebrew/cmd/install.rb
index 194be044f1acd..89b7df85907ca 100644
--- a/Library/Homebrew/cmd/install.rb
+++ b/Library/Homebrew/cmd/install.rb
@@ -304,22 +304,35 @@ def run
skip_link: args.skip_link?,
)
- dependants = Up... | [
"Library/Homebrew/cmd/install.rb"
] | [
{
"comment": "## Useless assignment to local variable\n\nThis assignment to <a class=\"Link\" href=\"/Homebrew/brew/blob/7a9a1e1aeffa07f7e7e28e84af8acb633faaaeac/Library/Homebrew/cmd/install.rb#L307-L307\">shared_download_queue</a> is useless, since its value is never read.\n\n---\n\n<p>Remove the redundant ass... | true | ||
Homebrew/brew | 22,662 | comment_to_fix | Start install downloads earlier | ## Useless assignment to local variable
This assignment to <a class="Link" href="/Homebrew/brew/blob/7a9a1e1aeffa07f7e7e28e84af8acb633faaaeac/Library/Homebrew/cmd/reinstall.rb#L166-L166">shared_download_queue</a> is useless, since its value is never read.
---
To fix this without changing behavior, remove the dead as... | d98430a757c5b2e967d9af290c550d542fce362f | a40d2df7f5536d09333bdd6bee023d8126ff7b2d | diff --git a/Library/Homebrew/cmd/reinstall.rb b/Library/Homebrew/cmd/reinstall.rb
index 9bc3720686887..2dfbd9d1aa624 100644
--- a/Library/Homebrew/cmd/reinstall.rb
+++ b/Library/Homebrew/cmd/reinstall.rb
@@ -193,22 +193,33 @@ def run
)
end
- dependants = Upgrade.dependants(
- ... | [
"Library/Homebrew/cmd/reinstall.rb"
] | [
{
"comment": "## Useless assignment to local variable\n\nThis assignment to <a class=\"Link\" href=\"/Homebrew/brew/blob/7a9a1e1aeffa07f7e7e28e84af8acb633faaaeac/Library/Homebrew/cmd/reinstall.rb#L166-L166\">shared_download_queue</a> is useless, since its value is never read.\n\n---\n\nTo fix this without chang... | true | ||
Homebrew/brew | 22,662 | comment_to_fix | Start install downloads earlier | `Install.prelude_fetch_formulae` is invoked here before `Upgrade.dependants`, but later the run still calls `Install.enqueue_formulae`, which (via `Install.fetch_formulae`) calls `prelude_fetch_formulae` again. Since `FormulaInstaller#prelude_fetch` itself is not guarded by `@ran_prelude_fetch`, this can rerun the prel... | d98430a757c5b2e967d9af290c550d542fce362f | a40d2df7f5536d09333bdd6bee023d8126ff7b2d | diff --git a/Library/Homebrew/cmd/install.rb b/Library/Homebrew/cmd/install.rb
index 194be044f1acd..89b7df85907ca 100644
--- a/Library/Homebrew/cmd/install.rb
+++ b/Library/Homebrew/cmd/install.rb
@@ -304,22 +304,35 @@ def run
skip_link: args.skip_link?,
)
- dependants = Up... | [
"Library/Homebrew/cmd/install.rb"
] | [
{
"comment": "`Install.prelude_fetch_formulae` is invoked here before `Upgrade.dependants`, but later the run still calls `Install.enqueue_formulae`, which (via `Install.fetch_formulae`) calls `prelude_fetch_formulae` again. Since `FormulaInstaller#prelude_fetch` itself is not guarded by `@ran_prelude_fetch`, t... | true | ||
Homebrew/brew | 22,662 | comment_to_fix | Start install downloads earlier | This early `Install.prelude_fetch_formulae` call starts downloads before `Upgrade.dependants`, but later execution still calls `Install.enqueue_formulae` or `Install.fetch_formulae`, both of which call `prelude_fetch_formulae` internally. Because `FormulaInstaller#prelude_fetch` is not inherently idempotent, this resul... | d98430a757c5b2e967d9af290c550d542fce362f | a40d2df7f5536d09333bdd6bee023d8126ff7b2d | diff --git a/Library/Homebrew/cmd/reinstall.rb b/Library/Homebrew/cmd/reinstall.rb
index 9bc3720686887..2dfbd9d1aa624 100644
--- a/Library/Homebrew/cmd/reinstall.rb
+++ b/Library/Homebrew/cmd/reinstall.rb
@@ -193,22 +193,33 @@ def run
)
end
- dependants = Upgrade.dependants(
- ... | [
"Library/Homebrew/cmd/reinstall.rb"
] | [
{
"comment": "This early `Install.prelude_fetch_formulae` call starts downloads before `Upgrade.dependants`, but later execution still calls `Install.enqueue_formulae` or `Install.fetch_formulae`, both of which call `prelude_fetch_formulae` internally. Because `FormulaInstaller#prelude_fetch` is not inherently ... | true | ||
Homebrew/brew | 22,670 | issue_to_patch | Use API cask metadata for fetch | - Avoid loading simple `homebrew/cask` entries when `brew fetch --cask` can resolve URL, version and checksum data from `CaskStruct`.
- Reuse that API-backed download construction for internal-API casks during installer download enqueueing.
- Keep source-backed cask loading for language-specific casks and other caskf... | febd33cbb093da2ce2411b21afc77173746df004 | 45bd89028bd656cef0be339f705130eb27c64278 | diff --git a/Library/Homebrew/api/cask_download.rb b/Library/Homebrew/api/cask_download.rb
new file mode 100644
index 0000000000000..1665102c664df
--- /dev/null
+++ b/Library/Homebrew/api/cask_download.rb
@@ -0,0 +1,39 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "api/cask_struct"
+require "cask/cask"
... | [
"Library/Homebrew/api/cask_download.rb",
"Library/Homebrew/cask/installer.rb",
"Library/Homebrew/cmd/fetch.rb",
"Library/Homebrew/test/cask/installer_spec.rb",
"Library/Homebrew/test/cmd/fetch_spec.rb"
] | [] | diff --git a/Library/Homebrew/test/cask/installer_spec.rb b/Library/Homebrew/test/cask/installer_spec.rb
index c092dbc00f7d0..bcd87e57f687f 100644
--- a/Library/Homebrew/test/cask/installer_spec.rb
+++ b/Library/Homebrew/test/cask/installer_spec.rb
@@ -555,6 +555,30 @@ class #{Formulary.class_s(dep_name)} < Formula
... | true | |
Homebrew/brew | 22,700 | issue_to_patch | brew install --HEAD sandbox crashes on parentheses in path; HOMEBREW_NO_SANDBOX=1 ineffective
### `brew doctor` output
```shell
brew doctor
Your system is ready to brew.
```
### Verification
- [x] I ran `brew update` twice and am still able to reproduce my issue.
- [x] My "`brew doctor` output" above says `Your sys... | sandbox: fix deny_read_home crashes and trust check | Fixes https://github.com/Homebrew/brew/issues/22697
Fixes https://github.com/Homebrew/brew/issues/22699
- `deny_read_home` enumerates every `$HOME` entry, so a normal directory such as `~/Library/Logs/Microsoft Teams Helper (Renderer)` aborted the whole install via `path_filter`
- parentheses and single quotes a... | fbb628746ddf742ea914dff078cd1bced27df531 | 677b433222972287ff113b680e32c30a03d24897 | diff --git a/Library/Homebrew/extend/os/mac/sandbox.rb b/Library/Homebrew/extend/os/mac/sandbox.rb
index 313a5a1b52a6c..04c4341236d97 100644
--- a/Library/Homebrew/extend/os/mac/sandbox.rb
+++ b/Library/Homebrew/extend/os/mac/sandbox.rb
@@ -155,11 +155,19 @@ def seatbelt_rule(rule)
def seatbelt_path_filter(filte... | [
"Library/Homebrew/extend/os/mac/sandbox.rb",
"Library/Homebrew/sandbox.rb",
"Library/Homebrew/test/sandbox_shared_spec.rb",
"Library/Homebrew/test/sandbox_spec.rb"
] | [
{
"comment": "The ArgumentError message interpolates the invalid character directly. If the invalid character is a newline (\"\\n\"), the exception message itself will contain an actual newline, which makes the error harder to read and can lead to confusing multi-line output. Using `inspect` here keeps the mess... | diff --git a/Library/Homebrew/test/sandbox_shared_spec.rb b/Library/Homebrew/test/sandbox_shared_spec.rb
index 49aae4cefdc78..11111eb82da4d 100644
--- a/Library/Homebrew/test/sandbox_shared_spec.rb
+++ b/Library/Homebrew/test/sandbox_shared_spec.rb
@@ -176,11 +176,10 @@ def executable_usable?(candidate)
end
des... | true |
Homebrew/brew | 22,700 | comment_to_fix | sandbox: fix deny_read_home crashes and trust check | The ArgumentError message interpolates the invalid character directly. If the invalid character is a newline ("\n"), the exception message itself will contain an actual newline, which makes the error harder to read and can lead to confusing multi-line output. Using `inspect` here keeps the message single-line and unamb... | fbb628746ddf742ea914dff078cd1bced27df531 | 677b433222972287ff113b680e32c30a03d24897 | diff --git a/Library/Homebrew/sandbox.rb b/Library/Homebrew/sandbox.rb
index 6ba86884bd6d5..bbf06f0549a2f 100644
--- a/Library/Homebrew/sandbox.rb
+++ b/Library/Homebrew/sandbox.rb
@@ -5,6 +5,7 @@
require "pty"
require "tempfile"
require "exceptions"
+require "trust"
require "utils/fork"
require "utils/output"
@... | [
"Library/Homebrew/sandbox.rb"
] | [
{
"comment": "The ArgumentError message interpolates the invalid character directly. If the invalid character is a newline (\"\\n\"), the exception message itself will contain an actual newline, which makes the error harder to read and can lead to confusing multi-line output. Using `inspect` here keeps the mess... | true | ||
Homebrew/brew | 22,707 | issue_to_patch | Update manpage and completions. | Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
| fbb628746ddf742ea914dff078cd1bced27df531 | 269b042e598a2a16fa73e3a63527b0d824a03741 | diff --git a/completions/bash/brew b/completions/bash/brew
index d7d6e56504e17..70bebbc87a1f4 100644
--- a/completions/bash/brew
+++ b/completions/bash/brew
@@ -789,12 +789,14 @@ exec)
__brewcomp "
--check
--debug
+ --deny-network
--file
--global
--help
... | [
"completions/bash/brew",
"completions/fish/brew.fish",
"completions/internal_commands_list.txt",
"completions/zsh/_brew",
"docs/Manpage.md",
"manpages/brew.1"
] | [] | true | ||
Homebrew/brew | 22,706 | issue_to_patch | Retarget redirected tap trust | - Follow GitHub redirects while preventing old tap names from staying trusted
- Update redirected tap remotes so future operations use the new canonical URL
- Remove old `trustedtaps` and per-item trust entries after a tap redirect
- Show tap trust status in `tap-info` when tap trust is required
- Query redirected ... | c20ffd44732d30349418a9151a45fb8dd6e495ef | 1717af5d68524c9ed69c210665d4040bca65d296 | diff --git a/Library/Homebrew/cmd/tap-info.rb b/Library/Homebrew/cmd/tap-info.rb
index a5062a7bbc7e9..f1a33439c8225 100644
--- a/Library/Homebrew/cmd/tap-info.rb
+++ b/Library/Homebrew/cmd/tap-info.rb
@@ -70,6 +70,10 @@ def print_tap_info(taps)
info = "#{tap}: "
if tap.installed?
... | [
"Library/Homebrew/cmd/tap-info.rb",
"Library/Homebrew/cmd/update-report.rb",
"Library/Homebrew/cmd/update.sh",
"Library/Homebrew/tap.rb",
"Library/Homebrew/test/cmd/tap-info_spec.rb",
"Library/Homebrew/test/cmd/update-report_spec.rb",
"Library/Homebrew/test/cmd/update_spec.rb",
"Library/Homebrew/test/... | [
{
"comment": "`invalidate_tap_references!` uses `remote.present?` to guard calls to `normalise_name(remote)` and `Tap.remote_to_reference(remote)`, but Sorbet won't narrow `T.nilable(String)` based on `present?`, so this will fail typechecking in a `typed: strict` file. Assign `remote = remote.presence` (or `T.... | diff --git a/Library/Homebrew/test/cmd/tap-info_spec.rb b/Library/Homebrew/test/cmd/tap-info_spec.rb
index c08bfe4c9bad9..4b71cb8eee63c 100644
--- a/Library/Homebrew/test/cmd/tap-info_spec.rb
+++ b/Library/Homebrew/test/cmd/tap-info_spec.rb
@@ -25,6 +25,62 @@
.and not_to_output.to_stderr
end
+ it "prints t... | true | |
Homebrew/brew | 22,706 | comment_to_fix | Retarget redirected tap trust | `invalidate_tap_references!` uses `remote.present?` to guard calls to `normalise_name(remote)` and `Tap.remote_to_reference(remote)`, but Sorbet won't narrow `T.nilable(String)` based on `present?`, so this will fail typechecking in a `typed: strict` file. Assign `remote = remote.presence` (or `T.must(remote)` inside t... | c20ffd44732d30349418a9151a45fb8dd6e495ef | 1717af5d68524c9ed69c210665d4040bca65d296 | diff --git a/Library/Homebrew/trust.rb b/Library/Homebrew/trust.rb
index 8fc1545cb0edd..e1f1e378362ef 100644
--- a/Library/Homebrew/trust.rb
+++ b/Library/Homebrew/trust.rb
@@ -60,6 +60,38 @@ def self.untrust!(type, name)
end
end
+ sig { params(name: String, remote: T.nilable(String)).returns(T::Boolea... | [
"Library/Homebrew/trust.rb"
] | [
{
"comment": "`invalidate_tap_references!` uses `remote.present?` to guard calls to `normalise_name(remote)` and `Tap.remote_to_reference(remote)`, but Sorbet won't narrow `T.nilable(String)` based on `present?`, so this will fail typechecking in a `typed: strict` file. Assign `remote = remote.presence` (or `T.... | true | ||
Homebrew/brew | 22,666 | issue_to_patch | Use API bottle metadata for fetch | - Avoid inflating simple `homebrew/core` formulae when `brew fetch` can resolve bottle URLs, tags and checksums from `FormulaStruct`.
- Reuse that bottle construction during installer prefetch so API-loaded formulae do not rebuild bottle metadata just to enqueue manifests.
- Keep full `Formula` objects for install de... | 109191be4988470b51a60a5ef1998520aa24c01b | a07da124a28a1f6b21f50766344f6424d25ae4ad | diff --git a/Library/Homebrew/api/formula_bottle.rb b/Library/Homebrew/api/formula_bottle.rb
new file mode 100644
index 0000000000000..f72c886461a6f
--- /dev/null
+++ b/Library/Homebrew/api/formula_bottle.rb
@@ -0,0 +1,46 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "api/formula_struct"
+require "bottl... | [
"Library/Homebrew/api/formula_bottle.rb",
"Library/Homebrew/bottle.rb",
"Library/Homebrew/cmd/fetch.rb",
"Library/Homebrew/formula_installer.rb",
"Library/Homebrew/test/cmd/fetch_spec.rb",
"Library/Homebrew/test/formula_installer_spec.rb"
] | [
{
"comment": "In the API fast-path, the `DownloadQueue` thread pool is never shut down. `FetchCmd#run` returns early (`return if fetch_api_formula_bottles?`), so the normal `ensure download_queue.shutdown` later in `run` is skipped, leaving the pool running and potentially hanging or leaking threads. Ensure the... | diff --git a/Library/Homebrew/test/cmd/fetch_spec.rb b/Library/Homebrew/test/cmd/fetch_spec.rb
index e3c44506f9342..dc9d03eede664 100644
--- a/Library/Homebrew/test/cmd/fetch_spec.rb
+++ b/Library/Homebrew/test/cmd/fetch_spec.rb
@@ -7,6 +7,45 @@
RSpec.describe Homebrew::Cmd::FetchCmd do
it_behaves_like "parseable a... | true | |
Homebrew/brew | 22,666 | comment_to_fix | Use API bottle metadata for fetch | In the API fast-path, the `DownloadQueue` thread pool is never shut down. `FetchCmd#run` returns early (`return if fetch_api_formula_bottles?`), so the normal `ensure download_queue.shutdown` later in `run` is skipped, leaving the pool running and potentially hanging or leaking threads. Ensure the queue is shut down on... | 109191be4988470b51a60a5ef1998520aa24c01b | a07da124a28a1f6b21f50766344f6424d25ae4ad | diff --git a/Library/Homebrew/cmd/fetch.rb b/Library/Homebrew/cmd/fetch.rb
index 0f47010ef0019..db8aae55d274d 100644
--- a/Library/Homebrew/cmd/fetch.rb
+++ b/Library/Homebrew/cmd/fetch.rb
@@ -4,6 +4,7 @@
require "abstract_command"
require "formula"
require "fetch"
+require "api/formula_bottle"
require "cask/config... | [
"Library/Homebrew/cmd/fetch.rb"
] | [
{
"comment": "In the API fast-path, the `DownloadQueue` thread pool is never shut down. `FetchCmd#run` returns early (`return if fetch_api_formula_bottles?`), so the normal `ensure download_queue.shutdown` later in `run` is skipped, leaving the pool running and potentially hanging or leaking threads. Ensure the... | true | ||
Homebrew/brew | 22,696 | issue_to_patch | Expose sandboxed command execution | - Add `brew sandbox-exec` so users can run arbitrary commands with Homebrew's existing sandbox policy.
- Let `brew exec` and `brew bundle exec` apply the sandbox after their environment setup so Homebrew work stays outside the sandbox.
- Add `--deny-network` for callers that need offline command execution.
-----
... | c20ffd44732d30349418a9151a45fb8dd6e495ef | c70e39541e12c1fca4c61725fa000a5d5303b31d | diff --git a/Library/Homebrew/bundle/subcommand/exec.rb b/Library/Homebrew/bundle/subcommand/exec.rb
index 87a7d6965c83b..bde3a3697e2b4 100644
--- a/Library/Homebrew/bundle/subcommand/exec.rb
+++ b/Library/Homebrew/bundle/subcommand/exec.rb
@@ -15,7 +15,7 @@ class Bundle < Homebrew::AbstractCommand
class ExecSub... | [
"Library/Homebrew/bundle/subcommand/exec.rb",
"Library/Homebrew/cmd/exec.rb",
"Library/Homebrew/cmd/exec.sh",
"Library/Homebrew/cmd/sandbox-exec.rb",
"Library/Homebrew/sandbox.rb",
"Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/bundle.rbi",
"Library/Homebrew/sorbet/rbi/dsl/homebrew/cmd/exec.rbi",
"Libr... | [
{
"comment": "`Pathname(...).realpath` will raise `Errno::ENOENT`/`Errno::ENOTDIR` when the provided `writable_path` does not exist (or isn’t a directory), which will surface as a Ruby backtrace for `brew sandbox-exec`, `brew exec --sandbox`, and `brew bundle exec --sandbox`. It would be better to validate the ... | diff --git a/Library/Homebrew/test/cmd/bundle/exec_subcommand_spec.rb b/Library/Homebrew/test/cmd/bundle/exec_subcommand_spec.rb
index 593e643848531..16a1009909bdb 100644
--- a/Library/Homebrew/test/cmd/bundle/exec_subcommand_spec.rb
+++ b/Library/Homebrew/test/cmd/bundle/exec_subcommand_spec.rb
@@ -5,6 +5,7 @@
requir... | true | |
Homebrew/brew | 22,696 | comment_to_fix | Expose sandboxed command execution | `Pathname(...).realpath` will raise `Errno::ENOENT`/`Errno::ENOTDIR` when the provided `writable_path` does not exist (or isn’t a directory), which will surface as a Ruby backtrace for `brew sandbox-exec`, `brew exec --sandbox`, and `brew bundle exec --sandbox`. It would be better to validate the path and raise a user-... | c20ffd44732d30349418a9151a45fb8dd6e495ef | c70e39541e12c1fca4c61725fa000a5d5303b31d | diff --git a/Library/Homebrew/sandbox.rb b/Library/Homebrew/sandbox.rb
index fc837e80a6a02..6ee9a6dad1b3a 100644
--- a/Library/Homebrew/sandbox.rb
+++ b/Library/Homebrew/sandbox.rb
@@ -4,6 +4,7 @@
require "io/console"
require "pty"
require "tempfile"
+require "exceptions"
require "utils/fork"
require "utils/output... | [
"Library/Homebrew/sandbox.rb"
] | [
{
"comment": "`Pathname(...).realpath` will raise `Errno::ENOENT`/`Errno::ENOTDIR` when the provided `writable_path` does not exist (or isn’t a directory), which will surface as a Ruby backtrace for `brew sandbox-exec`, `brew exec --sandbox`, and `brew bundle exec --sandbox`. It would be better to validate the ... | true | ||
Homebrew/brew | 22,696 | comment_to_fix | Expose sandboxed command execution | New argument validation for `--deny-network` (requires `--sandbox`) is introduced in `cmd/exec.sh` but isn’t covered by this integration spec. Adding an expectation for `brew exec --deny-network <command>` failing with the appropriate error message would prevent regressions. | c20ffd44732d30349418a9151a45fb8dd6e495ef | c70e39541e12c1fca4c61725fa000a5d5303b31d | diff --git a/Library/Homebrew/test/cmd/exec_spec.rb b/Library/Homebrew/test/cmd/exec_spec.rb
index 2a14d0101f182..4ebd176667a25 100644
--- a/Library/Homebrew/test/cmd/exec_spec.rb
+++ b/Library/Homebrew/test/cmd/exec_spec.rb
@@ -143,6 +143,13 @@
.and(output("Error: `--formulae` requires a comma-separated for... | [
"Library/Homebrew/test/cmd/exec_spec.rb"
] | [
{
"comment": "New argument validation for `--deny-network` (requires `--sandbox`) is introduced in `cmd/exec.sh` but isn’t covered by this integration spec. Adding an expectation for `brew exec --deny-network <command>` failing with the appropriate error message would prevent regressions.",
"path": "Library... | true | ||
Homebrew/brew | 22,696 | comment_to_fix | Expose sandboxed command execution | ```suggestion
deny_network: args.deny_network?,
```
| c20ffd44732d30349418a9151a45fb8dd6e495ef | c70e39541e12c1fca4c61725fa000a5d5303b31d | diff --git a/Library/Homebrew/cmd/sandbox-exec.rb b/Library/Homebrew/cmd/sandbox-exec.rb
new file mode 100644
index 0000000000000..2c856cdbfad1e
--- /dev/null
+++ b/Library/Homebrew/cmd/sandbox-exec.rb
@@ -0,0 +1,39 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "abstract_command"
+require "sandbox"
+
+m... | [
"Library/Homebrew/cmd/sandbox-exec.rb"
] | [
{
"comment": "```suggestion\n deny_network: args.deny_network?,\n```\n",
"path": "Library/Homebrew/cmd/sandbox-exec.rb",
"hunk": "@@ -0,0 +1,39 @@\n+# typed: strict\n+# frozen_string_literal: true\n+\n+require \"abstract_command\"\n+require \"sandbox\"\n+\n+module Homebrew\n+ module Cmd\n+ ... | true | ||
Homebrew/brew | 22,693 | issue_to_patch | Restore user alias completions | - Keep internal aliases out of first-word completion suggestions.
- Add user aliases by reading the alias command files that `brew alias` manages.
- Match `brew alias` lookup order and alias-name parsing so edited files still complete consistently.
-----
<!-- Do not tick a checkbox if you haven’t performed its ... | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/Library/Homebrew/completions/bash.erb b/Library/Homebrew/completions/bash.erb
index b1d942329496a..4cf86396cbb28 100644
--- a/Library/Homebrew/completions/bash.erb
+++ b/Library/Homebrew/completions/bash.erb
@@ -114,6 +114,7 @@ __brew_complete_commands() {
local cur="${COMP_WORDS[COMP_CWORD]}"
local ... | [
"Library/Homebrew/completions/bash.erb",
"Library/Homebrew/completions/fish.erb",
"Library/Homebrew/completions/zsh.erb",
"Library/Homebrew/test/completions_spec.rb",
"completions/bash/brew",
"completions/fish/brew.fish",
"completions/zsh/_brew"
] | [
{
"comment": "Alias name parsing here doesn’t match `brew alias`’s parser: `Homebrew::Aliases.each` extracts the name from the *second line* using `/alias: brew (\\S+)/` (not anchored and not requiring a leading `#`). With the current anchored pattern, a valid alias header like `# alias: brew foo ` (trailing ... | diff --git a/Library/Homebrew/test/completions_spec.rb b/Library/Homebrew/test/completions_spec.rb
index a83bd33847d67..256047ddeb219 100644
--- a/Library/Homebrew/test/completions_spec.rb
+++ b/Library/Homebrew/test/completions_spec.rb
@@ -395,13 +395,18 @@ def stub_nested_completion_command(command, subcommands)
... | true | |
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | Alias name parsing here doesn’t match `brew alias`’s parser: `Homebrew::Aliases.each` extracts the name from the *second line* using `/alias: brew (\S+)/` (not anchored and not requiring a leading `#`). With the current anchored pattern, a valid alias header like `# alias: brew foo ` (trailing spaces) will be recogni... | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/Library/Homebrew/completions/bash.erb b/Library/Homebrew/completions/bash.erb
index b1d942329496a..4cf86396cbb28 100644
--- a/Library/Homebrew/completions/bash.erb
+++ b/Library/Homebrew/completions/bash.erb
@@ -114,6 +114,7 @@ __brew_complete_commands() {
local cur="${COMP_WORDS[COMP_CWORD]}"
local ... | [
"Library/Homebrew/completions/bash.erb"
] | [
{
"comment": "Alias name parsing here doesn’t match `brew alias`’s parser: `Homebrew::Aliases.each` extracts the name from the *second line* using `/alias: brew (\\S+)/` (not anchored and not requiring a leading `#`). With the current anchored pattern, a valid alias header like `# alias: brew foo ` (trailing ... | true | ||
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | This duplicates the template logic but has the same issue: alias parsing is anchored to an exact `^# alias: brew ...$` line and scans the whole file. `brew alias` only inspects the second line and matches `/alias: brew (\S+)/`, so completion can diverge from `brew alias` output for edited headers (e.g., trailing spaces... | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/completions/bash/brew b/completions/bash/brew
index 67a4122cbc3af..d7d6e56504e17 100644
--- a/completions/bash/brew
+++ b/completions/bash/brew
@@ -99,6 +99,7 @@ __brew_complete_commands() {
local cur="${COMP_WORDS[COMP_CWORD]}"
local cmds
local maintainer_cmds
+ local user_aliases
if [[ -n ... | [
"completions/bash/brew"
] | [
{
"comment": "This duplicates the template logic but has the same issue: alias parsing is anchored to an exact `^# alias: brew ...$` line and scans the whole file. `brew alias` only inspects the second line and matches `/alias: brew (\\S+)/`, so completion can diverge from `brew alias` output for edited headers... | true | ||
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | The header parsing here is stricter than `brew alias` and can get out of sync. `brew alias` extracts the alias name from the second line using an unanchored `/alias: brew (\S+)/` match; this anchored `^# ...$` regex can miss valid headers (e.g., trailing spaces) and then fall back to the (often sanitized) filename. | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/Library/Homebrew/completions/zsh.erb b/Library/Homebrew/completions/zsh.erb
index c3ba83336d3ff..7c8e2d14acb14 100644
--- a/Library/Homebrew/completions/zsh.erb
+++ b/Library/Homebrew/completions/zsh.erb
@@ -35,6 +35,29 @@ __brew_list_aliases() {
echo "${aliases}"
}
+__brew_user_aliases() {
+ local ... | [
"Library/Homebrew/completions/zsh.erb"
] | [
{
"comment": "The header parsing here is stricter than `brew alias` and can get out of sync. `brew alias` extracts the alias name from the second line using an unanchored `/alias: brew (\\S+)/` match; this anchored `^# ...$` regex can miss valid headers (e.g., trailing spaces) and then fall back to the (often s... | true | ||
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | Same as the template: this uses an anchored `^# alias: brew ...$` regex and scans the whole file. `brew alias` only parses the second line and matches `/alias: brew (\S+)/`, so completion can disagree with `brew alias` for slightly edited headers (e.g., trailing whitespace) and suggest the wrong alias name. | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/completions/zsh/_brew b/completions/zsh/_brew
index 82ae4124861ea..d795d4aa960d8 100644
--- a/completions/zsh/_brew
+++ b/completions/zsh/_brew
@@ -38,6 +38,29 @@ __brew_list_aliases() {
echo "${aliases}"
}
+__brew_user_aliases() {
+ local aliases_dir="${HOME}/.config/brew-aliases"
+ local pattern=... | [
"completions/zsh/_brew"
] | [
{
"comment": "Same as the template: this uses an anchored `^# alias: brew ...$` regex and scans the whole file. `brew alias` only parses the second line and matches `/alias: brew (\\S+)/`, so completion can disagree with `brew alias` for slightly edited headers (e.g., trailing whitespace) and suggest the wrong ... | true | ||
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | `brew alias` parses the alias name from the second line using an unanchored `/alias: brew (\S+)/` match. This completion code instead requires an exact `^# alias: brew ...$` match and will fall back to the filename (often the sanitized script name) if the header has benign edits like trailing whitespace. | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/Library/Homebrew/completions/fish.erb b/Library/Homebrew/completions/fish.erb
index 1e35b9a609f39..5da72187dadbd 100644
--- a/Library/Homebrew/completions/fish.erb
+++ b/Library/Homebrew/completions/fish.erb
@@ -156,6 +156,25 @@ function __fish_brew_suggest_taps_installed -d "List all available taps"
... | [
"Library/Homebrew/completions/fish.erb"
] | [
{
"comment": "`brew alias` parses the alias name from the second line using an unanchored `/alias: brew (\\S+)/` match. This completion code instead requires an exact `^# alias: brew ...$` match and will fall back to the filename (often the sanitized script name) if the header has benign edits like trailing whi... | true | ||
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | Same as the template: this completion code requires an exact `^# alias: brew ...$` match and may fall back to the (sanitized) filename if the header has harmless edits (e.g., trailing spaces). `brew alias` matches `/alias: brew (\S+)/` on the second line only, so it’s better to mirror that here to keep `brew alias` out... | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/completions/fish/brew.fish b/completions/fish/brew.fish
index dcf5618d9be1f..9c83679e5aece 100644
--- a/completions/fish/brew.fish
+++ b/completions/fish/brew.fish
@@ -178,6 +178,25 @@ function __fish_brew_suggest_taps_installed -d "List all available taps"
| string replace (brew --repo)/Library/Taps/... | [
"completions/fish/brew.fish"
] | [
{
"comment": "Same as the template: this completion code requires an exact `^# alias: brew ...$` match and may fall back to the (sanitized) filename if the header has harmless edits (e.g., trailing spaces). `brew alias` matches `/alias: brew (\\S+)/` on the second line only, so it’s better to mirror that here t... | true | ||
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | These tests lock in an anchored `^# alias: brew ...$` header pattern, but `brew alias` parses alias names using an unanchored `/alias: brew (\S+)/` match on the second line (see `Library/Homebrew/aliases/aliases.rb`). To keep completions consistent with `brew alias` for edited headers (e.g., trailing whitespace), the p... | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/Library/Homebrew/test/completions_spec.rb b/Library/Homebrew/test/completions_spec.rb
index a83bd33847d67..256047ddeb219 100644
--- a/Library/Homebrew/test/completions_spec.rb
+++ b/Library/Homebrew/test/completions_spec.rb
@@ -395,13 +395,18 @@ def stub_nested_completion_command(command, subcommands)
... | [
"Library/Homebrew/test/completions_spec.rb"
] | [
{
"comment": "These tests lock in an anchored `^# alias: brew ...$` header pattern, but `brew alias` parses alias names using an unanchored `/alias: brew (\\S+)/` match on the second line (see `Library/Homebrew/aliases/aliases.rb`). To keep completions consistent with `brew alias` for edited headers (e.g., trai... | true | ||
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | This test currently expects an anchored `^# alias: brew ...$` regex, but `brew alias` itself matches `/alias: brew (\S+)/` (unanchored) on the second line only. If completions are updated to mirror `brew alias` parsing, this expectation should be updated too. | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/Library/Homebrew/test/completions_spec.rb b/Library/Homebrew/test/completions_spec.rb
index a83bd33847d67..256047ddeb219 100644
--- a/Library/Homebrew/test/completions_spec.rb
+++ b/Library/Homebrew/test/completions_spec.rb
@@ -395,13 +395,18 @@ def stub_nested_completion_command(command, subcommands)
... | [
"Library/Homebrew/test/completions_spec.rb"
] | [
{
"comment": "This test currently expects an anchored `^# alias: brew ...$` regex, but `brew alias` itself matches `/alias: brew (\\S+)/` (unanchored) on the second line only. If completions are updated to mirror `brew alias` parsing, this expectation should be updated too.",
"path": "Library/Homebrew/test/... | true | ||
Homebrew/brew | 22,693 | comment_to_fix | Restore user alias completions | This fish completion test asserts an anchored `^# alias: brew ...$` match, but `brew alias` parses names with an unanchored `/alias: brew (\S+)/` match on the second line. If the completion implementation is adjusted to mirror `brew alias`, update this expectation to avoid reintroducing the mismatch. | 9a3e38b003f94086a732a5c6146eba32105e7963 | dea60f17d95ff007d89c71ebe100a8abc57ed26a | diff --git a/Library/Homebrew/test/completions_spec.rb b/Library/Homebrew/test/completions_spec.rb
index a83bd33847d67..256047ddeb219 100644
--- a/Library/Homebrew/test/completions_spec.rb
+++ b/Library/Homebrew/test/completions_spec.rb
@@ -395,13 +395,18 @@ def stub_nested_completion_command(command, subcommands)
... | [
"Library/Homebrew/test/completions_spec.rb"
] | [
{
"comment": "This fish completion test asserts an anchored `^# alias: brew ...$` match, but `brew alias` parses names with an unanchored `/alias: brew (\\S+)/` match on the second line. If the completion implementation is adjusted to mirror `brew alias`, update this expectation to avoid reintroducing the misma... | true | ||
Homebrew/brew | 22,695 | issue_to_patch | Suggested `brew trust --formula` gives `Error: Invalid usage`
### `brew doctor` output
```shell
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this.... | Trust custom remote items | Fixes https://github.com/Homebrew/brew/issues/22685
- Allow per-item trust for custom remote taps without trusting the whole tap.
- Store custom remote item trust against the remote reference so a reused tap name does not broaden trust.
- Keep the Bash item listing path aligned with Ruby trust checks.
-----
... | 9a3e38b003f94086a732a5c6146eba32105e7963 | b80ca424184087b1154cae77ed75d11427f0ca0b | diff --git a/Library/Homebrew/items.sh b/Library/Homebrew/items.sh
index f748b8c8447a3..c4c70fb5bb276 100644
--- a/Library/Homebrew/items.sh
+++ b/Library/Homebrew/items.sh
@@ -45,10 +45,12 @@ homebrew-trusted-items() {
select(. != null) |
"\(.user)/\(.tap)/\(.name)" as $item |
($item | split("/") | .[0:... | [
"Library/Homebrew/items.sh",
"Library/Homebrew/test/cmd/trust_spec.rb",
"Library/Homebrew/test/cmd/untrust_spec.rb",
"Library/Homebrew/test/trust_spec.rb",
"Library/Homebrew/trust.rb"
] | [
{
"comment": "`item_trust_name(..., include_existing: true)` currently returns the legacy `tap.name/item` entry whenever it exists, even if the newer remote-qualified entry also exists. This can make `brew untrust --formula <tap>/<item>` remove only the legacy entry and leave the remote-qualified entry behind, ... | diff --git a/Library/Homebrew/test/cmd/trust_spec.rb b/Library/Homebrew/test/cmd/trust_spec.rb
index 920997def710b..d88eb2098bba8 100644
--- a/Library/Homebrew/test/cmd/trust_spec.rb
+++ b/Library/Homebrew/test/cmd/trust_spec.rb
@@ -53,9 +53,10 @@
expect(Homebrew::Trust.trusted_entries(:tap)).to contain_exactly(... | true |
Homebrew/brew | 22,695 | comment_to_fix | Trust custom remote items | `item_trust_name(..., include_existing: true)` currently returns the legacy `tap.name/item` entry whenever it exists, even if the newer remote-qualified entry also exists. This can make `brew untrust --formula <tap>/<item>` remove only the legacy entry and leave the remote-qualified entry behind, so the item stays trus... | 9a3e38b003f94086a732a5c6146eba32105e7963 | b80ca424184087b1154cae77ed75d11427f0ca0b | diff --git a/Library/Homebrew/trust.rb b/Library/Homebrew/trust.rb
index 8fc1545cb0edd..05ea546a82e21 100644
--- a/Library/Homebrew/trust.rb
+++ b/Library/Homebrew/trust.rb
@@ -45,10 +45,18 @@ def self.trust!(type, name)
def self.untrust!(type, name)
key = setting_key(type)
name = normalise_name(name... | [
"Library/Homebrew/trust.rb"
] | [
{
"comment": "`item_trust_name(..., include_existing: true)` currently returns the legacy `tap.name/item` entry whenever it exists, even if the newer remote-qualified entry also exists. This can make `brew untrust --formula <tap>/<item>` remove only the legacy entry and leave the remote-qualified entry behind, ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.