repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
JakeWharton/butterknife | 1,355 | issue_to_patch | Support AndroidX references in listener declarations | Also backfill an AndroidX test for other codegen
Closes #1307 | d4994ae62c8c8a6eb0a6fb5ddb3fa537fd20f08f | 72405e79025fcf5fb0902e62330f54d53b43637f | diff --git a/butterknife-annotations/src/main/java/butterknife/OnPageChange.java b/butterknife-annotations/src/main/java/butterknife/OnPageChange.java
index 3c792e6dc..b1501b5c4 100644
--- a/butterknife-annotations/src/main/java/butterknife/OnPageChange.java
+++ b/butterknife-annotations/src/main/java/butterknife/OnPag... | [
"butterknife-annotations/src/main/java/butterknife/OnPageChange.java",
"butterknife-annotations/src/main/java/butterknife/internal/ListenerClass.java",
"butterknife-compiler/src/main/java/butterknife/compiler/BindingSet.java",
"butterknife-runtime/build.gradle",
"butterknife-runtime/src/test/java/android/su... | [] | diff --git a/butterknife-runtime/src/test/java/android/support/v4/view/ViewPager.java b/butterknife-runtime/src/test/java/android/support/v4/view/ViewPager.java
deleted file mode 100644
index f5be6a297..000000000
--- a/butterknife-runtime/src/test/java/android/support/v4/view/ViewPager.java
+++ /dev/null
@@ -1,16 +0,0 ... | true | |
JakeWharton/butterknife | 1,354 | issue_to_patch | AGP 3.2rc3 | be4792d8a8c76aebd0f90858a1ea426ed31fd36c | bebdb4b4e35e1cedd4408a6bfe1a155f10e75e60 | diff --git a/build.gradle b/build.gradle
index d761251b0..445448b49 100644
--- a/build.gradle
+++ b/build.gradle
@@ -6,8 +6,8 @@ buildscript {
'compileSdk': 27,
'supportLibrary': '27.1.1',
- 'androidPlugin': '3.2.0-rc02',
- 'androidTools': '26.2.0-rc02',
+ 'androidPlugin': '3.2.0-rc03',
+... | [
"build.gradle"
] | [] | true | |||
JamesNK/Newtonsoft.Json | 2,980 | issue_to_patch | Annotate for trim/AOT (in)compatibility | Adds annotations to propagate trim and AOT compatibility warnings to callers. This way, a trimmed/AOT-compiled app referencing Newtonsoft.Json will get warnings at the places where it calls into Newtonsoft.Json, instead of warnings that point at Newtonsoft.Json internals.
Adds a net8.0 target, because the AOT analyz... | 4738a64817bb753667d9ed0ea99c1f955d414b33 | 3087b730bab1ca20ac10367f2b04463f97d7a5ad | diff --git a/Src/Newtonsoft.Json/Converters/BinaryConverter.cs b/Src/Newtonsoft.Json/Converters/BinaryConverter.cs
index 47833a2ac9..57bcdee1b4 100644
--- a/Src/Newtonsoft.Json/Converters/BinaryConverter.cs
+++ b/Src/Newtonsoft.Json/Converters/BinaryConverter.cs
@@ -29,6 +29,7 @@
using Newtonsoft.Json.Utilities;
usin... | [
"Src/Newtonsoft.Json/Converters/BinaryConverter.cs",
"Src/Newtonsoft.Json/Converters/CustomCreationConverter.cs",
"Src/Newtonsoft.Json/Converters/DataSetConverter.cs",
"Src/Newtonsoft.Json/Converters/DataTableConverter.cs",
"Src/Newtonsoft.Json/Converters/DiscriminatedUnionConverter.cs",
"Src/Newtonsoft.J... | [
{
"comment": "Why add these annotations to types like JsonTextReader? I don't think it uses reflection or other problem APIs.\r\n\r\nSame with reader, Newtonsoft.Json.Linq types, etc.",
"path": "Src/Newtonsoft.Json/JsonTextReader.cs",
"hunk": "@@ -54,6 +56,8 @@ internal enum ReadType\n /// <summary>... | true | ||
JamesNK/Newtonsoft.Json | 2,980 | comment_to_fix | Annotate for trim/AOT (in)compatibility | Thinking about this a bit deeper - we really only want the analyzers turned on. We don't want the `IsTrimmable` assembly metadata attribute to be put into the assembly. That is going to break existing apps that work today - like Blazor WASM.
```suggestion
<EnableSingleFileAnalyzer Condition="$([MSBuild]::IsTarg... | 4738a64817bb753667d9ed0ea99c1f955d414b33 | 3087b730bab1ca20ac10367f2b04463f97d7a5ad | diff --git a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
index 47c63018ef..fe60679741 100644
--- a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
+++ b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFr... | [
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj"
] | [
{
"comment": "Thinking about this a bit deeper - we really only want the analyzers turned on. We don't want the `IsTrimmable` assembly metadata attribute to be put into the assembly. That is going to break existing apps that work today - like Blazor WASM.\r\n\r\n```suggestion\r\n <EnableSingleFileAnalyzer Co... | true | ||
JamesNK/Newtonsoft.Json | 2,980 | comment_to_fix | Annotate for trim/AOT (in)compatibility | This is a lot of duplication. Can we put this in a single spot and reuse it between `net8` and `net6`? | 4738a64817bb753667d9ed0ea99c1f955d414b33 | 3087b730bab1ca20ac10367f2b04463f97d7a5ad | diff --git a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
index 47c63018ef..fe60679741 100644
--- a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
+++ b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFr... | [
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj"
] | [
{
"comment": "This is a lot of duplication. Can we put this in a single spot and reuse it between `net8` and `net6`?",
"path": "Src/Newtonsoft.Json/Newtonsoft.Json.csproj",
"hunk": "@@ -51,6 +53,10 @@\n <PackageReference Include=\"Microsoft.CodeAnalysis.NetAnalyzers\" Version=\"$(MicrosoftCodeAnalys... | true | ||
JamesNK/Newtonsoft.Json | 2,980 | comment_to_fix | Annotate for trim/AOT (in)compatibility | Could annotate type for JsonSerializer | 4738a64817bb753667d9ed0ea99c1f955d414b33 | 3087b730bab1ca20ac10367f2b04463f97d7a5ad | diff --git a/Src/Newtonsoft.Json/JsonSerializer.cs b/Src/Newtonsoft.Json/JsonSerializer.cs
index 13e3a9c68d..b72625df33 100644
--- a/Src/Newtonsoft.Json/JsonSerializer.cs
+++ b/Src/Newtonsoft.Json/JsonSerializer.cs
@@ -44,6 +44,8 @@ namespace Newtonsoft.Json
/// Serializes and deserializes objects into and from th... | [
"Src/Newtonsoft.Json/JsonSerializer.cs"
] | [
{
"comment": "Could annotate type for JsonSerializer",
"path": "Src/Newtonsoft.Json/JsonSerializer.cs",
"hunk": "@@ -580,6 +585,8 @@ public JsonSerializer()\n /// The <see cref=\"JsonSerializer\"/> will not use default settings \n /// from <see cref=\"JsonConvert.DefaultSettings\"/>.\n ... | true | ||
JamesNK/Newtonsoft.Json | 1,950 | issue_to_patch | Update Newtonsoft.Json project to use nullable reference types | PCL builds disabled because of VS2019 issue https://developercommunity.visualstudio.com/content/problem/402902/class-library-cannot-be-compiled-gives-sdk-root-fo.html
Some warnings disabled with pragmas to workaround analysis errors
Fixed NRE with JToken.BeforeSelf()
Fixed NRE when using some converters to write... | f940f218041dbc80928ebcd65fe8beaac59f70f1 | 022de520066d0c40231d85da5261422e43ad1524 | diff --git a/Build/build.ps1 b/Build/build.ps1
index 52eb1b087..2c379a5d8 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -14,7 +14,7 @@
$workingName = if ($workingName) {$workingName} else {"Working"}
$assemblyVersion = if ($assemblyVersion) {$assemblyVersion} else {$majorVersion + '.0.0'}
$netCliChanne... | [
"Build/build.ps1",
"Src/Newtonsoft.Json.Tests/Converters/XmlNodeConverterTest.cs",
"Src/Newtonsoft.Json.Tests/JsonConvertTest.cs",
"Src/Newtonsoft.Json.Tests/Linq/JTokenTests.cs",
"Src/Newtonsoft.Json.Tests/Linq/JsonPath/QueryExpressionTests.cs",
"Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj",
... | [
{
"comment": "`public static string SerializeObject(object? value)`",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -526,7 +526,7 @@ public static string ToString(object value)\n [DebuggerStepThrough]\n public static string SerializeObject(object value)",
"resolving_sha":... | true | ||
JamesNK/Newtonsoft.Json | 1,950 | comment_to_fix | Update Newtonsoft.Json project to use nullable reference types | `public static string SerializeObject(object? value)` | f940f218041dbc80928ebcd65fe8beaac59f70f1 | 022de520066d0c40231d85da5261422e43ad1524 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b0e480d62..b09dc1ac5 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -36,9 +36,10 @@
using Newtonsoft.Json.Serialization;
using System.Text;
using System.Diagnostics;
+using System.R... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "`public static string SerializeObject(object? value)`",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -526,7 +526,7 @@ public static string ToString(object value)\n [DebuggerStepThrough]\n public static string SerializeObject(object value)",
"resolving_sha":... | true | ||
JamesNK/Newtonsoft.Json | 1,950 | comment_to_fix | Update Newtonsoft.Json project to use nullable reference types | I've added the `using System.Diagnostics.CodeAnalysis` to my own code but it's not finding this `NotNullWhenAttribute` in VS 2019 16.3 Preview 1. Do you know what could be the issue? | f940f218041dbc80928ebcd65fe8beaac59f70f1 | 022de520066d0c40231d85da5261422e43ad1524 | diff --git a/Src/Newtonsoft.Json/Linq/JPropertyKeyedCollection.cs b/Src/Newtonsoft.Json/Linq/JPropertyKeyedCollection.cs
index 435e45738..1c4c186bc 100644
--- a/Src/Newtonsoft.Json/Linq/JPropertyKeyedCollection.cs
+++ b/Src/Newtonsoft.Json/Linq/JPropertyKeyedCollection.cs
@@ -26,6 +26,8 @@
using System;
using System.... | [
"Src/Newtonsoft.Json/Linq/JPropertyKeyedCollection.cs"
] | [
{
"comment": "I've added the `using System.Diagnostics.CodeAnalysis` to my own code but it's not finding this `NotNullWhenAttribute` in VS 2019 16.3 Preview 1. Do you know what could be the issue?",
"path": "Src/Newtonsoft.Json/Linq/JPropertyKeyedCollection.cs",
"hunk": "@@ -189,7 +191,7 @@ protected ov... | true | ||
JamesNK/Newtonsoft.Json | 2,472 | issue_to_patch | Fix JsonWriter.WriteToken to allow null with string token | 926d2f0f42292cfcdf07cdadeb501b73fd5b1d52 | d9b09b1cb8befd4f7759602546cd8d3e36ca3089 | diff --git a/Src/Newtonsoft.Json.Tests/JsonTextWriterTest.cs b/Src/Newtonsoft.Json.Tests/JsonTextWriterTest.cs
index b3bdd4d93..f0c462337 100644
--- a/Src/Newtonsoft.Json.Tests/JsonTextWriterTest.cs
+++ b/Src/Newtonsoft.Json.Tests/JsonTextWriterTest.cs
@@ -945,13 +945,15 @@ public void WriteTokenDirect()
... | [
"Src/Newtonsoft.Json.Tests/JsonTextWriterTest.cs",
"Src/Newtonsoft.Json.Tests/Linq/JTokenWriterTest.cs",
"Src/Newtonsoft.Json/JsonWriter.cs"
] | [] | true | |||
JamesNK/Newtonsoft.Json | 2,935 | issue_to_patch | Author fuzz tests and fix a comment-related issue | Add some basic fuzz tests:
- `FuzzDeserialization` tests deserialization
- `FuzzSerialization` tests serialization (using deserialization to create an arbitrary object)
- `FuzzIdempotent` ensures that serialize → deserialize gives back the same object (using deserialization to create an arbitrary object initially)... | 55a7204f9b9546aa07145591d42046d509176ad4 | 22a65ae05eecc90daa0e192c54a3eebc0498de77 | diff --git a/Build/build.ps1 b/Build/build.ps1
index 5ae7929c9..cbe086793 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -133,6 +133,10 @@ task Package -depends Build {
robocopy $sourceDir $workingDir\Package\Source\Src /MIR /NFL /NDL /NJS /NC /NS /NP /XD bin obj TestResults AppPackages .vs artifacts /XF *.su... | [
"Build/build.ps1",
"Src/Newtonsoft.Json.FuzzTests/FuzzTests.cs",
"Src/Newtonsoft.Json.FuzzTests/Newtonsoft.Json.FuzzTests.csproj",
"Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs",
"Src/Newtonsoft.Json.Tests/JsonTextWriterTest.cs",
"Src/Newtonsoft.Json.sln",
"Src/Newtonsoft.Json/JsonTextWriter.cs"
] | [
{
"comment": "should this be 2024 for year",
"path": "Src/Newtonsoft.Json.FuzzTests/Newtonsoft.Json.FuzzTests.csproj",
"hunk": "@@ -0,0 +1,21 @@\n+<Project Sdk=\"Microsoft.NET.Sdk\">\n+ <PropertyGroup>\n+ <TargetFrameworks>net6.0</TargetFrameworks>\n+ <LangVersion>9.0</LangVersion>\n+ <Versio... | true | ||
JamesNK/Newtonsoft.Json | 2,935 | comment_to_fix | Author fuzz tests and fix a comment-related issue | should this be 2024 for year | 55a7204f9b9546aa07145591d42046d509176ad4 | 22a65ae05eecc90daa0e192c54a3eebc0498de77 | diff --git a/Src/Newtonsoft.Json.FuzzTests/Newtonsoft.Json.FuzzTests.csproj b/Src/Newtonsoft.Json.FuzzTests/Newtonsoft.Json.FuzzTests.csproj
new file mode 100644
index 000000000..552450dbe
--- /dev/null
+++ b/Src/Newtonsoft.Json.FuzzTests/Newtonsoft.Json.FuzzTests.csproj
@@ -0,0 +1,21 @@
+<Project Sdk="Microsoft.NET.S... | [
"Src/Newtonsoft.Json.FuzzTests/Newtonsoft.Json.FuzzTests.csproj"
] | [
{
"comment": "should this be 2024 for year",
"path": "Src/Newtonsoft.Json.FuzzTests/Newtonsoft.Json.FuzzTests.csproj",
"hunk": "@@ -0,0 +1,21 @@\n+<Project Sdk=\"Microsoft.NET.Sdk\">\n+ <PropertyGroup>\n+ <TargetFrameworks>net6.0</TargetFrameworks>\n+ <LangVersion>9.0</LangVersion>\n+ <Versio... | true | ||
JamesNK/Newtonsoft.Json | 2,935 | comment_to_fix | Author fuzz tests and fix a comment-related issue | also, curious where the pipeline changes are made for enabling fuzzing ? are there any yaml file changes somewhere ? | 55a7204f9b9546aa07145591d42046d509176ad4 | 22a65ae05eecc90daa0e192c54a3eebc0498de77 | diff --git a/Build/build.ps1 b/Build/build.ps1
index 5ae7929c9..cbe086793 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -133,6 +133,10 @@ task Package -depends Build {
robocopy $sourceDir $workingDir\Package\Source\Src /MIR /NFL /NDL /NJS /NC /NS /NP /XD bin obj TestResults AppPackages .vs artifacts /XF *.su... | [
"Build/build.ps1"
] | [
{
"comment": "also, curious where the pipeline changes are made for enabling fuzzing ? are there any yaml file changes somewhere ?",
"path": "Build/build.ps1",
"hunk": "@@ -133,6 +133,10 @@ task Package -depends Build {\n robocopy $sourceDir $workingDir\\Package\\Source\\Src /MIR /NFL /NDL /NJS /NC /N... | true | ||
JamesNK/Newtonsoft.Json | 2,935 | comment_to_fix | Author fuzz tests and fix a comment-related issue | here as well we have 2007 | 55a7204f9b9546aa07145591d42046d509176ad4 | 22a65ae05eecc90daa0e192c54a3eebc0498de77 | diff --git a/Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs b/Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs
new file mode 100644
index 000000000..e641d117d
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs
@@ -0,0 +1,127 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permis... | [
"Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs"
] | [
{
"comment": "here as well we have 2007",
"path": "Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs",
"hunk": "@@ -0,0 +1,127 @@\n+#region License\n+// Copyright (c) 2007 James Newton-King",
"resolving_sha": "22a65ae05eecc90daa0e192c54a3eebc0498de77",
"resolving_diff": "diff --git a/Src/Newtonso... | true | ||
JamesNK/Newtonsoft.Json | 2,935 | comment_to_fix | Author fuzz tests and fix a comment-related issue | Standard C# indenting here. | 55a7204f9b9546aa07145591d42046d509176ad4 | 22a65ae05eecc90daa0e192c54a3eebc0498de77 | diff --git a/Src/Newtonsoft.Json.FuzzTests/FuzzTests.cs b/Src/Newtonsoft.Json.FuzzTests/FuzzTests.cs
new file mode 100644
index 000000000..51c1916df
--- /dev/null
+++ b/Src/Newtonsoft.Json.FuzzTests/FuzzTests.cs
@@ -0,0 +1,85 @@
+using System;
+using System.IO;
+
+namespace Newtonsoft.Json.FuzzTests
+{
+ public stat... | [
"Src/Newtonsoft.Json.FuzzTests/FuzzTests.cs"
] | [
{
"comment": "Standard C# indenting here.",
"path": "Src/Newtonsoft.Json.FuzzTests/FuzzTests.cs",
"hunk": "@@ -0,0 +1,86 @@\n+using System;\n+using System.IO;\n+\n+namespace Newtonsoft.Json.FuzzTests {",
"resolving_sha": "22a65ae05eecc90daa0e192c54a3eebc0498de77",
"resolving_diff": "diff --git a... | true | ||
JamesNK/Newtonsoft.Json | 2,935 | comment_to_fix | Author fuzz tests and fix a comment-related issue | ```suggestion
private static readonly JsonSerializer jsonSerializer = new();
``` | 55a7204f9b9546aa07145591d42046d509176ad4 | 22a65ae05eecc90daa0e192c54a3eebc0498de77 | diff --git a/Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs b/Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs
new file mode 100644
index 000000000..e641d117d
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs
@@ -0,0 +1,127 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permis... | [
"Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs"
] | [
{
"comment": "```suggestion\r\n private static readonly JsonSerializer jsonSerializer = new();\r\n```",
"path": "Src/Newtonsoft.Json.Tests/FuzzRegressionTests.cs",
"hunk": "@@ -0,0 +1,127 @@\n+#region License\n+// Copyright (c) 2007 James Newton-King\n+//\n+// Permission is hereby granted, free o... | true | ||
JamesNK/Newtonsoft.Json | 2,935 | comment_to_fix | Author fuzz tests and fix a comment-related issue | What happens if text has `*/` and a new line? | 55a7204f9b9546aa07145591d42046d509176ad4 | 22a65ae05eecc90daa0e192c54a3eebc0498de77 | diff --git a/Src/Newtonsoft.Json/JsonTextWriter.cs b/Src/Newtonsoft.Json/JsonTextWriter.cs
index 888bb04d1..08f08eeb6 100644
--- a/Src/Newtonsoft.Json/JsonTextWriter.cs
+++ b/Src/Newtonsoft.Json/JsonTextWriter.cs
@@ -784,10 +784,25 @@ public override void WriteValue(Uri? value)
public override void WriteCommen... | [
"Src/Newtonsoft.Json/JsonTextWriter.cs"
] | [
{
"comment": "What happens if text has `*/` and a new line?",
"path": "Src/Newtonsoft.Json/JsonTextWriter.cs",
"hunk": "@@ -784,10 +784,20 @@ public override void WriteValue(Uri? value)\n public override void WriteComment(string? text)\n {\n InternalWriteComment();\n-\n- ... | true | ||
JamesNK/Newtonsoft.Json | 3,104 | issue_to_patch | System.MissingMethodException: Method not found: "Void Newtonsoft.Json.Linq.JToken.WriteTo(Newtonsoft.Json.JsonWriter)
# Problem Summary
Newtonsoft.Json uses the same Assembly Version (`13.0.0.0`) and Public Key Token across all 13.x releases. This makes it impossible to use Assembly Binding Redirects to enforce a sp... | Fix MissingMethodException from JToken.WriteTo | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/3095 | e5f67150a0a2cd6fafcee483add00c1bb0fae306 | 9709ed417a2b652b2a5f9265c2b9e7d6433c19c0 | diff --git a/Src/Newtonsoft.Json/JsonValidatingReader.cs b/Src/Newtonsoft.Json/JsonValidatingReader.cs
index 7b6de5902..f39e34e1e 100644
--- a/Src/Newtonsoft.Json/JsonValidatingReader.cs
+++ b/Src/Newtonsoft.Json/JsonValidatingReader.cs
@@ -660,7 +660,11 @@ private void WriteToken(IList<JsonSchemaModel> schemas)
... | [
"Src/Newtonsoft.Json/JsonValidatingReader.cs",
"Src/Newtonsoft.Json/Linq/JToken.cs"
] | [] | true | |
JamesNK/Newtonsoft.Json | 3,092 | issue_to_patch | JObject.ToString `MissingMethodException` when app built against Newtonsoft.Json 13.0.4 loads 13.0.3 from GAC
Applications compiled against Newtonsoft.Json **13.0.4** can fail at runtime if version **13.0.3** is installed in the Global Assembly Cache (GAC).
Because both 13.0.3 and 13.0.4 use **AssemblyVersion = 13.0.... | Fix MissingMethodException from JToken.ToString(Formatting) | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/3084 | a162f27661ce5bab4167b477f338cf5115343c09 | 5c4c26bbfeffc84f592809944c3972406fa544bd | diff --git a/Src/Newtonsoft.Json/Linq/JToken.cs b/Src/Newtonsoft.Json/Linq/JToken.cs
index c01e51e45..72a0d94b5 100644
--- a/Src/Newtonsoft.Json/Linq/JToken.cs
+++ b/Src/Newtonsoft.Json/Linq/JToken.cs
@@ -473,12 +473,14 @@ public override string ToString()
return ToString(Formatting.Indented);
}
... | [
"Src/Newtonsoft.Json/Linq/JToken.cs"
] | [] | true | |
JamesNK/Newtonsoft.Json | 3,091 | issue_to_patch | Fix inconsistent setting of null value types | DynamicValueProvider errors when setting a null value type. This is inconsistent with other reflection providers.
Fix by checking if value is null before unboxing. | 4e13299d4b0ec96bd4df9954ef646bd2d1b5bf2a | 37efc3a7a8594f6b665bb1bd9a071e357691af41 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs
index 5ce1bf134..4a1fa33a1 100644
--- a/Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs
@@ -11,6 +11,7 @@
namespace Newtonsoft.Json.Tests.Issues
{
+ [TestFi... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs",
"Src/Newtonsoft.Json.Tests/Issues/Issue3055.cs",
"Src/Newtonsoft.Json.Tests/Issues/Issue3056.cs",
"Src/Newtonsoft.Json.Tests/Issues/Issue3080.cs",
"Src/Newtonsoft.Json/Serialization/DynamicValueProvider.cs",
"Src/Newtonsoft.Json/Serialization/ExpressionValu... | [] | true | ||
JamesNK/Newtonsoft.Json | 3,072 | issue_to_patch | Add .NET 8 tests | 8f579cf5970c57025237db4c7eae33ae4af289e3 | b240d545645bb1842596ce140e6bd44463e16945 | diff --git a/Src/Newtonsoft.Json.Tests/ExceptionTests.cs b/Src/Newtonsoft.Json.Tests/ExceptionTests.cs
index 85714d7af..f236ed72b 100644
--- a/Src/Newtonsoft.Json.Tests/ExceptionTests.cs
+++ b/Src/Newtonsoft.Json.Tests/ExceptionTests.cs
@@ -105,15 +105,15 @@ public void JsonSchemaException()
}
#pragma warning... | [
"Src/Newtonsoft.Json.Tests/ExceptionTests.cs",
"Src/Newtonsoft.Json.Tests/JsonTextWriterAsyncTests.cs",
"Src/Newtonsoft.Json.Tests/JsonTextWriterTest.cs",
"Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj"
] | [] | true | |||
JamesNK/Newtonsoft.Json | 3,067 | issue_to_patch | Update code signing | Migrate to https://github.com/dotnet/sign | ba92aa9afe744a4122a4d69fcbec9ee2e4112b5f | 91a8c192f7ad4534c7caf460f23fb38ff48f3098 | diff --git a/Build/Sign-Package.ps1 b/Build/Sign-Package.ps1
index 4a9c0c490..0b66a72b2 100644
--- a/Build/Sign-Package.ps1
+++ b/Build/Sign-Package.ps1
@@ -1,26 +1,29 @@
$currentDirectory = split-path $MyInvocation.MyCommand.Definition
-# See if we have the ClientSecret available
-if([string]::IsNullOrEmpty($Env:... | [
"Build/Sign-Package.ps1",
"azure-pipelines.yml"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,639 | issue_to_patch | Memory usage suggestion : reduce unnecessary boxes
Currently, if you deserialize a model with lots of, say, boolean values in it: you get a *lot* of boxed booleans on the heap, from multiple sources, but mostly:
- `JsonTextReader.SetToken`
- `new JValue(object, [JTokenType])`
Suggestion:
- create `static rea... | implement box avoidance | fix #2638
1. adds internal `BoxedPrimitives` helper that holds boxed instances for common primitive values and has helper APIs
2. use `BoxedPrimitives` in preference to vanilla boxing in `JValue` and `JsonTextReader`
3. avoid `new JValue(object)` in key paths
Disclosure: if someone uses `Unsafe` methods to muta... | 197c6db94a19eaca018debac6e2d07e2ba22ba75 | 71ff2edd555b419fabfd082ca82217ee91d538b8 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2484.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2484.cs
index baa70f32f..d779bb184 100644
--- a/Src/Newtonsoft.Json.Tests/Issues/Issue2484.cs
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2484.cs
@@ -23,7 +23,7 @@
// OTHER DEALINGS IN THE SOFTWARE.
#endregion
-#if (N... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2484.cs",
"Src/Newtonsoft.Json.Tests/Issues/Issue2492.cs",
"Src/Newtonsoft.Json.Tests/Issues/Issue2504.cs",
"Src/Newtonsoft.Json.Tests/Issues/Issue2529.cs",
"Src/Newtonsoft.Json.Tests/Issues/Issue2638.cs",
"Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj",
"... | [
{
"comment": "nit: declare on separate lines for consistency with the rest of the codebase",
"path": "Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs",
"hunk": "@@ -0,0 +1,83 @@\n+#region License\n+// Copyright (c) 2022 James Newton-King\n+//\n+// Permission is hereby granted, free of charge, to any p... | true | |
JamesNK/Newtonsoft.Json | 2,639 | comment_to_fix | implement box avoidance | nit: declare on separate lines for consistency with the rest of the codebase | 197c6db94a19eaca018debac6e2d07e2ba22ba75 | 71ff2edd555b419fabfd082ca82217ee91d538b8 | diff --git a/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
new file mode 100644
index 000000000..e6fb4f2de
--- /dev/null
+++ b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
@@ -0,0 +1,116 @@
+#region License
+// Copyright (c) 2022 James Newton-King
+//
+// Permi... | [
"Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs"
] | [
{
"comment": "nit: declare on separate lines for consistency with the rest of the codebase",
"path": "Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs",
"hunk": "@@ -0,0 +1,83 @@\n+#region License\n+// Copyright (c) 2022 James Newton-King\n+//\n+// Permission is hereby granted, free of charge, to any p... | true | ||
JamesNK/Newtonsoft.Json | 2,639 | comment_to_fix | implement box avoidance | How come there is a range of cached 32/64bit numbers, but only zero for decimal? Why up to 3?
Is there a reason to use an array here rather than separate fields? Fields would avoid array access. | 197c6db94a19eaca018debac6e2d07e2ba22ba75 | 71ff2edd555b419fabfd082ca82217ee91d538b8 | diff --git a/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
new file mode 100644
index 000000000..e6fb4f2de
--- /dev/null
+++ b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
@@ -0,0 +1,116 @@
+#region License
+// Copyright (c) 2022 James Newton-King
+//
+// Permi... | [
"Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs"
] | [
{
"comment": "How come there is a range of cached 32/64bit numbers, but only zero for decimal? Why up to 3?\r\n\r\nIs there a reason to use an array here rather than separate fields? Fields would avoid array access.",
"path": "Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs",
"hunk": "@@ -0,0 +1,83 @@\... | true | ||
JamesNK/Newtonsoft.Json | 2,639 | comment_to_fix | implement box avoidance | ```suggestion
``` | 197c6db94a19eaca018debac6e2d07e2ba22ba75 | 71ff2edd555b419fabfd082ca82217ee91d538b8 | diff --git a/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
new file mode 100644
index 000000000..e6fb4f2de
--- /dev/null
+++ b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
@@ -0,0 +1,116 @@
+#region License
+// Copyright (c) 2022 James Newton-King
+//
+// Permi... | [
"Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs"
] | [
{
"comment": "```suggestion\r\n```",
"path": "Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs",
"hunk": "@@ -0,0 +1,83 @@\n+#region License\n+// Copyright (c) 2022 James Newton-King\n+//\n+// Permission is hereby granted, free of charge, to any person\n+// obtaining a copy of this software and associa... | true | ||
JamesNK/Newtonsoft.Json | 2,639 | comment_to_fix | implement box avoidance | Add braces plus new lines for consistency | 197c6db94a19eaca018debac6e2d07e2ba22ba75 | 71ff2edd555b419fabfd082ca82217ee91d538b8 | diff --git a/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
new file mode 100644
index 000000000..e6fb4f2de
--- /dev/null
+++ b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
@@ -0,0 +1,116 @@
+#region License
+// Copyright (c) 2022 James Newton-King
+//
+// Permi... | [
"Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs"
] | [
{
"comment": "Add braces plus new lines for consistency",
"path": "Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs",
"hunk": "@@ -0,0 +1,83 @@\n+#region License\n+// Copyright (c) 2022 James Newton-King\n+//\n+// Permission is hereby granted, free of charge, to any person\n+// obtaining a copy of this... | true | ||
JamesNK/Newtonsoft.Json | 2,796 | issue_to_patch | Null String being reported as String rather than JTokenType.Null
### Source/destination JSON
{
"NullProperty": null
}
### Expected behavior
In the sample code below, we are creating a JObject with a property set by creating a null string (string nullString = null) or via a ternary operator (j_Object.Add("... | Fix: Null String being reported as String rather than JTokenType.Null | Fixes #2775
I tried reverting #2639 on a hunch and it fixed this issue so that led me here. | c908de3017ee32278c5330f715cef0e9733ce9db | 255e4f14832f0f0740a9e163b2db4fdcfc40b4e8 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs
new file mode 100644
index 000000000..5ce1bf134
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs
@@ -0,0 +1,32 @@
+using System.Linq;
+using Newtonsoft.Json.Linq;
+#if DNXCORE50
+using Xunit;
+us... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2775.cs",
"Src/Newtonsoft.Json/Linq/JTokenWriter.cs"
] | [] | true | |
JamesNK/Newtonsoft.Json | 2,726 | issue_to_patch | []()
... | Add roll forward to global.json | Make build resilient to build server updating SDK version. | b8f4ef0f980a8ee36f511cdec2feb25d5d5d0054 | 64b2869878b067d69ec023994c26af5bcd43fdef | diff --git a/Src/global.json b/Src/global.json
index 19c87f2a5..49d225529 100644
--- a/Src/global.json
+++ b/Src/global.json
@@ -1,5 +1,6 @@
{
"sdk": {
- "version": "6.0.300"
+ "version": "6.0.300",
+ "rollForward": "latestFeature"
}
}
| [
"Src/global.json"
] | [] | true | |
JamesNK/Newtonsoft.Json | 2,769 | issue_to_patch | Parsing 0.0 (decimal) different in 13.0.2
After using Newtonsoft.Json version 13.0.2, I encountered an unwanted behavior.
### Source/destination types
```csharp
[TestMethod]
public void ParseJsonDecimal()
{
var json = @"{ ""property"": 0.0}";
var reader = ne... | Fix parsed decimal losing trailing zeroes | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2768 | 4fba53a324c445f06ee08e45a015c346000a7ef2 | 80ebb4008d1d75ae557ce9f12309fde6f3e2b03f | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs
new file mode 100644
index 000000000..bb3c8f658
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs
@@ -0,0 +1,151 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is ... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs",
"Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs"
] | [
{
"comment": "Check this https://github.com/graphql-dotnet/graphql-dotnet/search?q=DecimalData&type=\r\nShould work for all platforms. ",
"path": "Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs",
"hunk": "@@ -87,9 +90,42 @@ internal static class BoxedPrimitives\n internal static readonly obje... | true | |
JamesNK/Newtonsoft.Json | 2,769 | comment_to_fix | Fix parsed decimal losing trailing zeroes | Check this https://github.com/graphql-dotnet/graphql-dotnet/search?q=DecimalData&type=
Should work for all platforms. | 4fba53a324c445f06ee08e45a015c346000a7ef2 | 80ebb4008d1d75ae557ce9f12309fde6f3e2b03f | diff --git a/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
index e6fb4f2de..2b19cd0a9 100644
--- a/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
+++ b/Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs
@@ -23,6 +23,9 @@
// OTHER DEALINGS IN THE SOFTWARE.
#endregi... | [
"Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs"
] | [
{
"comment": "Check this https://github.com/graphql-dotnet/graphql-dotnet/search?q=DecimalData&type=\r\nShould work for all platforms. ",
"path": "Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs",
"hunk": "@@ -87,9 +90,42 @@ internal static class BoxedPrimitives\n internal static readonly obje... | true | ||
JamesNK/Newtonsoft.Json | 2,777 | issue_to_patch | []()
... | Fix not returning negative double from box cache | Addresses https://github.com/JamesNK/Newtonsoft.Json/issues/2768#issuecomment-1345829355 | 2afdccdb6374c9452a9c82929e59967aab49b37f | 06ebf5e0de2754e1efe91614ace9c8bba4b04a68 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs
index bb3c8f658..6681c2a73 100644
--- a/Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs
@@ -74,6 +74,22 @@ public void Test_Deserialize()
Assert.AreEq... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2768.cs",
"Src/Newtonsoft.Json/Utilities/BoxedPrimitives.cs"
] | [] | true | |
JamesNK/Newtonsoft.Json | 2,811 | issue_to_patch | []()
... | Fix TimeOnly format error deserializing `HH:mm` | This commit also adds a missing Deserialize_Milliseconds test for TimeOnly | 56177005d7add6e1e62ff35ca54f0f76aa98015a | a929e9ba18ce48d42197fb82168b254c160b5ea3 | diff --git a/Src/Newtonsoft.Json.Tests/Serialization/TimeOnlyTests.cs b/Src/Newtonsoft.Json.Tests/Serialization/TimeOnlyTests.cs
index ce9c3d5f7b..6201506272 100644
--- a/Src/Newtonsoft.Json.Tests/Serialization/TimeOnlyTests.cs
+++ b/Src/Newtonsoft.Json.Tests/Serialization/TimeOnlyTests.cs
@@ -144,6 +144,22 @@ public v... | [
"Src/Newtonsoft.Json.Tests/Serialization/TimeOnlyTests.cs",
"Src/Newtonsoft.Json/Utilities/ConvertUtils.cs"
] | [] | true | |
JamesNK/Newtonsoft.Json | 2,993 | issue_to_patch | Add support for list patterns | Add processing for` Index `and `Range` to `JArray.this [object]` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 1de47cd8048d2ccd66d00ca7c30e80c4a3415483 | diff --git a/Src/Newtonsoft.Json.Tests/Linq/JArrayTests.cs b/Src/Newtonsoft.Json.Tests/Linq/JArrayTests.cs
index 2cb76c50ab..0b80ad034a 100644
--- a/Src/Newtonsoft.Json.Tests/Linq/JArrayTests.cs
+++ b/Src/Newtonsoft.Json.Tests/Linq/JArrayTests.cs
@@ -647,5 +647,43 @@ public void Parse_LineInfo()
Assert.Are... | [
"Src/Newtonsoft.Json.Tests/Linq/JArrayTests.cs",
"Src/Newtonsoft.Json/Linq/JArray.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,994 | issue_to_patch | Added explanation for null in `JsonConvert.DeserializeObject` | Hello,
As mentioned [here](https://github.com/JamesNK/Newtonsoft.Json/issues/2366#issuecomment-2446719183), the [documentation](https://www.newtonsoft.com/json/help/html/M_Newtonsoft_Json_JsonConvert_DeserializeObject__1.htm) does not have the correct return type for `DeserializeObject` as it implies that the method... | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -692,7 +692,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -692,7 +692,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -709,7 +709,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -723,7 +723,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -737,7 +737,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized anonymous type from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized anonymous type from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -756,7 +756,7 @@ priv... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized anonymous type from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized anonymous type from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -779,7 +779,7 @@ priv... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -794,7 +794,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -812,7 +812,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -827,7 +827,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see cref="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see cref=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -849,7 +849,7 @@ private stat... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -692,7 +692,7 @@ private ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -709,7 +709,7 @@ private ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -723,7 +723,7 @@ private ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -737,7 +737,7 @@ private ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized anonymous type from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized anonymous type from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -756,7 +756,7 @@ ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized anonymous type from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized anonymous type from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -779,7 +779,7 @@ ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -794,7 +794,7 @@ private ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -812,7 +812,7 @@ private ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -827,7 +827,7 @@ private ... | true | ||
JamesNK/Newtonsoft.Json | 2,994 | comment_to_fix | Added explanation for null in `JsonConvert.DeserializeObject` | ```suggestion
/// <returns>The deserialized object from the JSON string. A <see langword="null"/> value is returned if the provided JSON is valid but represents a null value.</returns>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 5ef9d9b57b9f0d8f595e00fb347c196c2aba45b0 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..c57b3ed5a 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -692,7 +692,7 @@ private static string SerializeObjectInternal(object? value, Type? type, JsonSer
/// Deser... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <returns>The deserialized object from the JSON string. A <see langword=\"null\"/> value is returned if the provided JSON is valid but represents a null value.</returns>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -849,7 +849,7 @@ private ... | true | ||
JamesNK/Newtonsoft.Json | 3,060 | issue_to_patch | Add json:Array attribute on properties with special characters (JSON to XML conversion) | Please refer to https://github.com/JamesNK/Newtonsoft.Json/issues/3055 | 36b605f683c48a976b00ee6a351b97dd2265c7c9 | 51b49aba26c1ebd64fb40ccca99577040570fbd0 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue3055.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue3055.cs
new file mode 100644
index 000000000..f6aabe1e3
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue3055.cs
@@ -0,0 +1,31 @@
+using System.Linq;
+using Newtonsoft.Json.Linq;
+#if DNXCORE50
+using Xunit;
+us... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue3055.cs",
"Src/Newtonsoft.Json/Converters/XmlNodeConverter.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 3,062 | issue_to_patch | Alternate fix duplicate attribute exception on nested arrays with writeArrayAttribute set to true | Please refer to https://github.com/JamesNK/Newtonsoft.Json/issues/3056
This alternate fix is less verbose but also less performant than #3061 version | 36b605f683c48a976b00ee6a351b97dd2265c7c9 | 4ee137250417ed44d91dc49af7b2bdd02f9dce7f | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue3056.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue3056.cs
new file mode 100644
index 000000000..86401c505
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue3056.cs
@@ -0,0 +1,45 @@
+using System.Linq;
+using Newtonsoft.Json.Linq;
+using System;
+
+#if DNXCORE50
... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue3056.cs",
"Src/Newtonsoft.Json/Converters/XmlNodeConverter.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 3,058 | issue_to_patch | Migrate from sln to slnx | bd0773b8f3b948f47840886c2b3f28b9c8bd5333 | 19437bb0eba64d68b15b6bbb0de1a736f083960e | diff --git a/.appveyor.yml b/.appveyor.yml
deleted file mode 100644
index e4a0461ec..000000000
--- a/.appveyor.yml
+++ /dev/null
@@ -1,20 +0,0 @@
-version: '{build}'
-branches:
- only:
- - master
- - /^v\d+(?:\.\d+)?$/
- - /[\b_]validate\b/
-skip_tags: true
-nuget:
- disable_publish_on_pr: true
-image: Visual Stud... | [
".appveyor.yml",
"Build/build.ps1",
"Src/Newtonsoft.Json.sln",
"Src/Newtonsoft.Json.sln.DotSettings",
"Src/Newtonsoft.Json.slnx",
"Src/global.json",
"azure-pipelines.yml"
] | [] | true | |||
JamesNK/Newtonsoft.Json | 3,031 | issue_to_patch | Fix warnings | c603502b95b019f99765d01412e4e74d502b61e0 | 3e4140aa3b3355e0ff43ac2ff5780d7b566da144 | diff --git a/Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj b/Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj
index f564f2bbc..3154f4a51 100644
--- a/Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj
+++ b/Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj
@@ -192,5 +192,6 @@
<AssemblyTitle... | [
"Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj",
"Src/Newtonsoft.Json/JsonException.cs",
"Src/Newtonsoft.Json/Linq/JContainer.cs",
"Src/Newtonsoft.Json/Serialization/JsonFormatterConverter.cs",
"Src/Newtonsoft.Json/Serialization/JsonObjectContract.cs",
"Src/Newtonsoft.Json/Serialization/JsonSeria... | [] | true | |||
JamesNK/Newtonsoft.Json | 3,030 | issue_to_patch | Add CodeQL Advanced action | Products must on board to CodeQL.
All software and services must use approved static analysis tooling with an effective security ruleset (see the Tools table in the Guidance) at a cadence appropriate for your project. This could either be started asynchronously during pull request validation, or periodically (at lea... | e794f1dd0a050724ad3f35629edb1d7dec4687ec | 16fb136703913426e20af171389ca1b4d3b59e5a | diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
new file mode 100644
index 000000000..1d4ed60e6
--- /dev/null
+++ b/.github/workflows/codeql.yml
@@ -0,0 +1,98 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wi... | [
".github/workflows/codeql.yml"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 3,018 | issue_to_patch | Update JsonConvert.cs | Adds clarifying message why setting for Formatting and Settings.Formatting behaves the way it does. | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 8e58d132fc48849d938299d1492482201c8a2564 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..6f25bbbd6 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -630,7 +630,7 @@ public static string SerializeObject(object? value, Type? type, JsonSerializerSe
/// Seria... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <param name=\"formatting\">Indicates how the output should be formatted. Note: this will override any JsonSerializerSettings passed.</param>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -630,7 +630,7 @@ public static string SerializeObjec... | true | ||
JamesNK/Newtonsoft.Json | 3,018 | comment_to_fix | Update JsonConvert.cs | ```suggestion
/// <param name="formatting">Indicates how the output should be formatted. Note: this will override any JsonSerializerSettings passed.</param>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 8e58d132fc48849d938299d1492482201c8a2564 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..6f25bbbd6 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -630,7 +630,7 @@ public static string SerializeObject(object? value, Type? type, JsonSerializerSe
/// Seria... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <param name=\"formatting\">Indicates how the output should be formatted. Note: this will override any JsonSerializerSettings passed.</param>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -630,7 +630,7 @@ public static string SerializeObjec... | true | ||
JamesNK/Newtonsoft.Json | 3,018 | comment_to_fix | Update JsonConvert.cs | ```suggestion
/// <param name="formatting">Indicates how the output should be formatted. This value overrides the formatting specified on <see cref="JsonSerializerSettings" />.</param>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 8e58d132fc48849d938299d1492482201c8a2564 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..6f25bbbd6 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -630,7 +630,7 @@ public static string SerializeObject(object? value, Type? type, JsonSerializerSe
/// Seria... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <param name=\"formatting\">Indicates how the output should be formatted. This value overrides the formatting specified on <see cref=\"JsonSerializerSettings\" />.</param>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -630,7 +630,7 @@ public... | true | ||
JamesNK/Newtonsoft.Json | 3,018 | comment_to_fix | Update JsonConvert.cs | ```suggestion
/// <param name="formatting">Indicates how the output should be formatted. This value overrides the formatting specified on <see cref="JsonSerializerSettings" />.</param>
``` | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 8e58d132fc48849d938299d1492482201c8a2564 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index b507d43e4..6f25bbbd6 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -630,7 +630,7 @@ public static string SerializeObject(object? value, Type? type, JsonSerializerSe
/// Seria... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [
{
"comment": "```suggestion\r\n /// <param name=\"formatting\">Indicates how the output should be formatted. This value overrides the formatting specified on <see cref=\"JsonSerializerSettings\" />.</param>\r\n```",
"path": "Src/Newtonsoft.Json/JsonConvert.cs",
"hunk": "@@ -648,7 +648,7 @@ public... | true | ||
JamesNK/Newtonsoft.Json | 3,013 | issue_to_patch | Fixed a typo in CamelCasePropertyNamesContractResolver | Fixed a typo in code comments. No changes to actual code were made. | 9317d71ac5f08c354060bad2cd9bfe6ed5856294 | 1b7997ecd06054671768ce45699df5a9ed3c754b | diff --git a/Src/Newtonsoft.Json/Serialization/CamelCasePropertyNamesContractResolver.cs b/Src/Newtonsoft.Json/Serialization/CamelCasePropertyNamesContractResolver.cs
index ba336e00b..955a4235d 100644
--- a/Src/Newtonsoft.Json/Serialization/CamelCasePropertyNamesContractResolver.cs
+++ b/Src/Newtonsoft.Json/Serializati... | [
"Src/Newtonsoft.Json/Serialization/CamelCasePropertyNamesContractResolver.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,902 | issue_to_patch | Avoid LINQ expression trees on .NET 6+. | The condition was changed in https://github.com/JamesNK/Newtonsoft.Json/pull/2678 and it looks like an accidental search and replace rather than intentional change. [Other similar code path](https://github.com/JamesNK/Newtonsoft.Json/blob/0a2e291c0d9c0c7675d445703e51750363a549ef/Src/Newtonsoft.Json/Serialization/JsonTy... | 0a2e291c0d9c0c7675d445703e51750363a549ef | 30a031d7449c5736500ddfd75c8f5469090e048d | diff --git a/Src/Newtonsoft.Json/Serialization/DefaultContractResolver.cs b/Src/Newtonsoft.Json/Serialization/DefaultContractResolver.cs
index 94bf51085a..3ff2208cea 100644
--- a/Src/Newtonsoft.Json/Serialization/DefaultContractResolver.cs
+++ b/Src/Newtonsoft.Json/Serialization/DefaultContractResolver.cs
@@ -1412,7 +1... | [
"Src/Newtonsoft.Json/Serialization/DefaultContractResolver.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,959 | issue_to_patch | Update .NET 8 SDK | b0d1d0b9053c14f001bbf25c450cbf86c6f5aaa4 | 113ac22eca12cf5390eaeddc265d1834444ce800 | diff --git a/Build/build.ps1 b/Build/build.ps1
index cbe086793..87d2bdad2 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -13,8 +13,8 @@
$treatWarningsAsErrors = $false
$workingName = if ($workingName) {$workingName} else {"Working"}
$assemblyVersion = if ($assemblyVersion) {$assemblyVersion} else {$majo... | [
"Build/build.ps1",
"Src/Directory.Build.props",
"Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj",
"Src/Newtonsoft.Json/CompatibilitySuppressions.xml",
"Src/global.json",
"azure-pipelines.yml"
] | [] | true | |||
JamesNK/Newtonsoft.Json | 2,956 | issue_to_patch | Fix comment on JsonConvert.SerializeObject | Fixes a small mistake in a function comment for JsonConvert.SerializeObject.
I suspect the comment incorrectly copied from an alternative version of the function and not updated to reflect the new parameters. | 2eaa475f8853f2b01ac5591421dcabd7a44f79ce | 377fa95f840aae3cfd07da8bb6533859717dfbf4 | diff --git a/Src/Newtonsoft.Json/JsonConvert.cs b/Src/Newtonsoft.Json/JsonConvert.cs
index 95019e2b7..1fa3f2195 100644
--- a/Src/Newtonsoft.Json/JsonConvert.cs
+++ b/Src/Newtonsoft.Json/JsonConvert.cs
@@ -593,7 +593,7 @@ public static string SerializeObject(object? value, JsonSerializerSettings? sett
}
... | [
"Src/Newtonsoft.Json/JsonConvert.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,636 | issue_to_patch | Make JPath public to allow more basic operations on JSONPath expressi… | Making JPath public has a lot of benefits. Users of the Newtonsoft JSON library can then parse JSON expressions and validate them, without having to actually supply a data object (which sometimes is not available at validation or preparation).
This functionality is currently missing except using SelectTokens, which ... | 55a7204f9b9546aa07145591d42046d509176ad4 | 55a7204f9b9546aa07145591d42046d509176ad4 | [] | [] | true | |||
JamesNK/Newtonsoft.Json | 2,922 | issue_to_patch | Unexpected exceptions during deserialization due to missing constructor name
<!--
If you have questions about how to use Json.NET, please read the Json.NET documentation or ask on Stack Overflow.
https://www.newtonsoft.com/json/help
https://stackoverflow.com/questions/tagged/json.net
There are thousands of J... | Fix handling of empty constructor names | See #2921 for details.
Closes #2921 & some of #1947. | 01e1759cac40d8154e47ed0e11c12a9d42d2d0ff | 7b4bf93130f9efa97eedd87663997a0ec3f037e9 | diff --git a/Src/Newtonsoft.Json.Tests/JsonConvertTest.cs b/Src/Newtonsoft.Json.Tests/JsonConvertTest.cs
index 2582f43a3..2611929a2 100644
--- a/Src/Newtonsoft.Json.Tests/JsonConvertTest.cs
+++ b/Src/Newtonsoft.Json.Tests/JsonConvertTest.cs
@@ -118,6 +118,17 @@ public void PopulateObjectWithNoContent()
}, ... | [
"Src/Newtonsoft.Json.Tests/JsonConvertTest.cs",
"Src/Newtonsoft.Json/JsonTextReader.cs"
] | [
{
"comment": "```suggestion\r\n if (initialPosition == endPosition)\r\n {\r\n throw JsonReaderException.Create(this, \"Empty constructor name.\");\r\n }\r\n```",
"path": "Src/Newtonsoft.Json/JsonTextReader.cs",
"hunk": "@@ -1937,6 +1937,10 ... | true | |
JamesNK/Newtonsoft.Json | 2,922 | comment_to_fix | Fix handling of empty constructor names | ```suggestion
if (initialPosition == endPosition)
{
throw JsonReaderException.Create(this, "Empty constructor name.");
}
``` | 01e1759cac40d8154e47ed0e11c12a9d42d2d0ff | 7b4bf93130f9efa97eedd87663997a0ec3f037e9 | diff --git a/Src/Newtonsoft.Json/JsonTextReader.cs b/Src/Newtonsoft.Json/JsonTextReader.cs
index 925f4b6b2..dd8094f96 100644
--- a/Src/Newtonsoft.Json/JsonTextReader.cs
+++ b/Src/Newtonsoft.Json/JsonTextReader.cs
@@ -1937,6 +1937,11 @@ private void ParseConstructor()
throw JsonReaderException.C... | [
"Src/Newtonsoft.Json/JsonTextReader.cs"
] | [
{
"comment": "```suggestion\r\n if (initialPosition == endPosition)\r\n {\r\n throw JsonReaderException.Create(this, \"Empty constructor name.\");\r\n }\r\n```",
"path": "Src/Newtonsoft.Json/JsonTextReader.cs",
"hunk": "@@ -1937,6 +1937,10 ... | true | ||
JamesNK/Newtonsoft.Json | 2,757 | issue_to_patch | []()
... | Add JsonCloneSettings to disable copy annotations | Builds on top of https://github.com/JamesNK/Newtonsoft.Json/pull/2747 | d0a328e8a46304d62d2174b8bba54721d02be3d3 | cfe40563bdd97fe42f7d79c9af50249f84b65458 | diff --git a/Src/Newtonsoft.Json.Tests/Linq/AnnotationsTests.cs b/Src/Newtonsoft.Json.Tests/Linq/AnnotationsTests.cs
index 28af83764..7a8eb44ee 100644
--- a/Src/Newtonsoft.Json.Tests/Linq/AnnotationsTests.cs
+++ b/Src/Newtonsoft.Json.Tests/Linq/AnnotationsTests.cs
@@ -303,11 +303,140 @@ public void MultipleAnnotationsA... | [
"Src/Newtonsoft.Json.Tests/Linq/AnnotationsTests.cs",
"Src/Newtonsoft.Json.Tests/Linq/JRawTests.cs",
"Src/Newtonsoft.Json.Tests/Serialization/MetadataPropertyHandlingTests.cs",
"Src/Newtonsoft.Json/Linq/JArray.cs",
"Src/Newtonsoft.Json/Linq/JConstructor.cs",
"Src/Newtonsoft.Json/Linq/JContainer.cs",
"Sr... | [] | true | |
JamesNK/Newtonsoft.Json | 2,493 | issue_to_patch | JsonSerializer.Deserialize<T> throws NullReferenceException. JsonSerializer.Deserialize and JsonConvert.DeserializeObject works well
If JSON has a comment before a complex object, JsonSerializer throws a NullReferenceException
### Expected behavior
No Exceptions or ArgumentException
### Actual behavior
``... | Fix JTokenWriter when writing comment to an object | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2492 | b6dc05be5a0f4808f06ec430f3bb59b24d3fbc3e | f337eb1536f14b9ea7a75fcee6cb5fa990f609e8 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2492.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2492.cs
new file mode 100644
index 000000000..70268abfc
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2492.cs
@@ -0,0 +1,77 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is h... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2492.cs",
"Src/Newtonsoft.Json/Linq/JContainer.cs",
"Src/Newtonsoft.Json/Linq/JObject.cs",
"Src/Newtonsoft.Json/Linq/JProperty.cs",
"Src/Newtonsoft.Json/Linq/JToken.cs",
"Src/Newtonsoft.Json/Linq/JTokenWriter.cs"
] | [] | true | |
JamesNK/Newtonsoft.Json | 2,678 | issue_to_patch | Update .NET 6 tests | bf2e2a78e8febf0006ec647f9bde3aa5bbe0ce72 | d334dae8cb1027f2b2ec9a93fd8cc4382941e6ad | diff --git a/Src/Newtonsoft.Json.Tests/Benchmarks/LowLevelBenchmarks.cs b/Src/Newtonsoft.Json.Tests/Benchmarks/LowLevelBenchmarks.cs
index 3aae21b04..9c5487456 100644
--- a/Src/Newtonsoft.Json.Tests/Benchmarks/LowLevelBenchmarks.cs
+++ b/Src/Newtonsoft.Json.Tests/Benchmarks/LowLevelBenchmarks.cs
@@ -35,7 +35,7 @@
usin... | [
"Src/Newtonsoft.Json.Tests/Benchmarks/LowLevelBenchmarks.cs",
"Src/Newtonsoft.Json.Tests/Bson/BsonReaderTests.cs",
"Src/Newtonsoft.Json.Tests/Bson/BsonWriterAsyncTests.cs",
"Src/Newtonsoft.Json.Tests/Bson/BsonWriterTests.cs",
"Src/Newtonsoft.Json.Tests/Converters/BinaryConverterTests.cs",
"Src/Newtonsoft.... | [] | true | |||
JamesNK/Newtonsoft.Json | 2,679 | issue_to_patch | Support new DateOnly and TimeOnly structs in .NET 6
.NET 6 (starting with preview 4) will support two new primitives: `System.DateOnly` and `System.TimeOnly`.
Refer to: https://github.com/dotnet/runtime/issues/49036
These are similar to `System.DateTime`, but split into subcomponents. They should serialize/deseri... | Add support for DateOnly and TimeOnly | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2521 | 5803c7722af4cf0dc3984e55404694aab09e51bf | 6ef8a36bde22f3cd9a2d6909253c6b999cdc6a23 | diff --git a/Src/Newtonsoft.Json.Tests/Serialization/DateOnlyTests.cs b/Src/Newtonsoft.Json.Tests/Serialization/DateOnlyTests.cs
new file mode 100644
index 000000000..5d84052e0
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Serialization/DateOnlyTests.cs
@@ -0,0 +1,203 @@
+#region License
+// Copyright (c) 2007 James Ne... | [
"Src/Newtonsoft.Json.Tests/Serialization/DateOnlyTests.cs",
"Src/Newtonsoft.Json.Tests/Serialization/TimeOnlyTests.cs",
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj",
"Src/Newtonsoft.Json/Serialization/DefaultContractResolver.cs",
"Src/Newtonsoft.Json/Serialization/JsonSerializerInternalWriter.cs",
"Src/Ne... | [] | true | |
JamesNK/Newtonsoft.Json | 2,736 | issue_to_patch | MaxDepth not being used with ISerializable deserialization
Reader created from token doesn't use serializer's MaxDepth
https://github.com/JamesNK/Newtonsoft.Json/blob/aae9284e2091e4f2409df175d273cba496c21ccc/Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs#L1806 | Fix MaxDepth not being used with ISerializable deserialization | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2735 | aae9284e2091e4f2409df175d273cba496c21ccc | fb38c6b286877046f5549571e2a36f0a5661003e | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs
new file mode 100644
index 000000000..14a08b180
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs
@@ -0,0 +1,164 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is ... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs",
"Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs"
] | [
{
"comment": "Shahzaib Ali s/o Rashid Ali",
"path": "Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs",
"hunk": "@@ -45,7 +45,7 @@\n namespace Newtonsoft.Json.Tests.Issues\n {",
"resolving_sha": "fb38c6b286877046f5549571e2a36f0a5661003e",
"resolving_diff": "diff --git a/Src/Newtonsoft.Json.Tests/Is... | true | |
JamesNK/Newtonsoft.Json | 2,736 | comment_to_fix | Fix MaxDepth not being used with ISerializable deserialization | Shahzaib Ali s/o Rashid Ali | aae9284e2091e4f2409df175d273cba496c21ccc | fb38c6b286877046f5549571e2a36f0a5661003e | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs
new file mode 100644
index 000000000..14a08b180
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs
@@ -0,0 +1,164 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is ... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs"
] | [
{
"comment": "Shahzaib Ali s/o Rashid Ali",
"path": "Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs",
"hunk": "@@ -45,7 +45,7 @@\n namespace Newtonsoft.Json.Tests.Issues\n {",
"resolving_sha": "fb38c6b286877046f5549571e2a36f0a5661003e",
"resolving_diff": "diff --git a/Src/Newtonsoft.Json.Tests/Is... | true | ||
JamesNK/Newtonsoft.Json | 2,736 | comment_to_fix | Fix MaxDepth not being used with ISerializable deserialization | 34104-8572691-9 | aae9284e2091e4f2409df175d273cba496c21ccc | fb38c6b286877046f5549571e2a36f0a5661003e | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs
new file mode 100644
index 000000000..14a08b180
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs
@@ -0,0 +1,164 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is ... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs"
] | [
{
"comment": "34104-8572691-9",
"path": "Src/Newtonsoft.Json.Tests/Issues/Issue2735.cs",
"hunk": "@@ -45,7 +45,7 @@\n namespace Newtonsoft.Json.Tests.Issues\n {\n [TestFixture]\n- public class Issue2709 : TestFixtureBase",
"resolving_sha": "fb38c6b286877046f5549571e2a36f0a5661003e",
"reso... | true | ||
JamesNK/Newtonsoft.Json | 2,505 | issue_to_patch | MaxDepth default value of `null` or `100` is not respected
<!--
If you have questions about how to use Json.NET, please read the Json.NET documentation or ask on Stack Overflow.
https://www.newtonsoft.com/json/help
https://stackoverflow.com/questions/tagged/json.net
There are thousands of Json.NET questions ... | Fix MaxDepth when used with ToObject inside of a JsonConverter | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2501 | ae9fe44e1323e91bcbd185ca1a14099fba7c021f | 6351633f607f2f0c997a8bc83312c94da1f9babb | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2504.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2504.cs
new file mode 100644
index 000000000..4363a9112
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2504.cs
@@ -0,0 +1,121 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is ... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2504.cs",
"Src/Newtonsoft.Json.Tests/JsonTextReaderTests/ReadAsyncTests.cs",
"Src/Newtonsoft.Json.Tests/JsonTextReaderTests/ReadTests.cs",
"Src/Newtonsoft.Json.Tests/Serialization/JsonSerializerTest.cs",
"Src/Newtonsoft.Json.Tests/TestFixtureBase.cs",
"Src/Newtonsoft... | [] | true | |
JamesNK/Newtonsoft.Json | 2,698 | issue_to_patch | Fixing misspelling | This change will only fix some misspelling words. | 94ff24f815a777269920f5a7b13f60db50c5eeb7 | e58b00955eecb00ab813faac9b9742827f1b287d | diff --git a/Src/Newtonsoft.Json/JsonReader.Async.cs b/Src/Newtonsoft.Json/JsonReader.Async.cs
index 537674f19..d76c492e5 100644
--- a/Src/Newtonsoft.Json/JsonReader.Async.cs
+++ b/Src/Newtonsoft.Json/JsonReader.Async.cs
@@ -34,11 +34,11 @@
namespace Newtonsoft.Json
{
public abstract partial class JsonReader
-#i... | [
"Src/Newtonsoft.Json/JsonReader.Async.cs",
"Src/Newtonsoft.Json/JsonTextWriter.Async.cs",
"Src/Newtonsoft.Json/JsonWriter.Async.cs",
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,495 | issue_to_patch | Update SDK to 5.0.200 | c7e8abc09de751785355e3f972150f8a72379b02 | 1655e9f83db50a4adf86a8cc7afd227553fc52f1 | diff --git a/Build/build.ps1 b/Build/build.ps1
index d1b69d96f..ea2c22f8e 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -14,7 +14,7 @@
$workingName = if ($workingName) {$workingName} else {"Working"}
$assemblyVersion = if ($assemblyVersion) {$assemblyVersion} else {$majorVersion + '.0.0'}
$netCliChanne... | [
"Build/build.ps1",
"Src/global.json"
] | [] | true | |||
JamesNK/Newtonsoft.Json | 2,711 | issue_to_patch | Break from 12.0.3 to 13.0.1 with [JsonExtensionData]
We're hitting an issue in production after a 13.0.1 upgrade unable to deserialize JSON. Though the actual code involved `JToken.ToObject<T>()` the repro is the same with a simplified `JsonConvert.DeserializeObject<T>()` so using that below. I've tested this scenario... | Fix deserializing via constructor with ignored base type properties | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2708 | 94ff24f815a777269920f5a7b13f60db50c5eeb7 | edc5ab69794b47bb65d934588459ed22629e0a69 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2708.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2708.cs
new file mode 100644
index 000000000..149544e18
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2708.cs
@@ -0,0 +1,81 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is h... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2708.cs",
"Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs"
] | [] | true | |
JamesNK/Newtonsoft.Json | 2,530 | issue_to_patch | Exception deserializing JArray on JToken-typed property pre-initialized with JValue
### Destination type
```csharp
class Something
{
public JToken Foo { get; set; } = JValue.CreateNull();
}
```
### Source JSON
```javascript
{ "foo": [] }
```
### Expected behavior
Successfully deserialized a `... | Fix deserializing mistmatched JToken types in properties | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2529 | f7e7bd05d9280f17993500085202ff4ea150564a | 13c89f721b13a25f0b46151bd879503b104057b6 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2529.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2529.cs
new file mode 100644
index 000000000..5d7cb7b9d
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2529.cs
@@ -0,0 +1,61 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is h... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2529.cs",
"Src/Newtonsoft.Json/Serialization/JsonSerializerInternalReader.cs"
] | [] | true | |
JamesNK/Newtonsoft.Json | 2,695 | issue_to_patch | Add IAsyncDisposable to JsonReader and JsonWriter
Calling Dispose can result in blocking IO. The fix is to add an async dispose option to clean up these types. | Fix blocking IO in JsonTextWriter.CloseAsync and add IAsyncDisposable | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2694 | f0dcd5b434371bcc59fcb4150979ce35a6a9338d | 50af8b3ebfe4988d14537abec120782e937b76c0 | diff --git a/Src/Newtonsoft.Json.Tests/Issues/Issue2694.cs b/Src/Newtonsoft.Json.Tests/Issues/Issue2694.cs
new file mode 100644
index 000000000..fbb1a947e
--- /dev/null
+++ b/Src/Newtonsoft.Json.Tests/Issues/Issue2694.cs
@@ -0,0 +1,158 @@
+#region License
+// Copyright (c) 2007 James Newton-King
+//
+// Permission is ... | [
"Src/Newtonsoft.Json.Tests/Issues/Issue2694.cs",
"Src/Newtonsoft.Json/JsonReader.Async.cs",
"Src/Newtonsoft.Json/JsonTextWriter.Async.cs",
"Src/Newtonsoft.Json/JsonWriter.Async.cs",
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj"
] | [
{
"comment": "HAVE_ASYNC_DISPOABLE -> HAVE_ASYNC_DISPOSABLE",
"path": "Src/Newtonsoft.Json/JsonWriter.Async.cs",
"hunk": "@@ -37,7 +37,20 @@\n namespace Newtonsoft.Json\n {\n public abstract partial class JsonWriter\n+#if HAVE_ASYNC_DISPOABLE",
"resolving_sha": "50af8b3ebfe4988d14537abec120782e9... | true | |
JamesNK/Newtonsoft.Json | 2,677 | issue_to_patch | Add .NET 6 target | e42c9e4824358b9b38414df0370919c822ed8523 | 5893e9d8bde2f0b076ebc246359bf6c8cc48c40c | diff --git a/Build/build.ps1 b/Build/build.ps1
index 7491dc6ff..d5927e260 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -32,7 +32,8 @@
$nunitConsolePath = "$buildDir\Temp\NUnit.ConsoleRunner.$nunitConsoleVersion"
$builds = @(
- @{Framework = "netstandard2.0"; TestsFunction = "NetCliTests"; TestFramew... | [
"Build/build.ps1",
"Src/Newtonsoft.Json.Tests/Linq/JObjectTests.cs",
"Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj",
"Src/Newtonsoft.Json/Converters/BinaryConverter.cs",
"Src/Newtonsoft.Json/Converters/DataSetConverter.cs",
"Src/Newtonsoft.Json/Converters/DataTableConverter.cs",
"Src/Newtonsof... | [] | true | |||
JamesNK/Newtonsoft.Json | 2,602 | issue_to_patch | Fixed rare race condition in name table when deserializing on device with ARM processors | Issue [2598](https://github.com/JamesNK/Newtonsoft.Json/issues/2598) | 52e257ee57899296d81a868b32300f0b3cfeacbe | f4c0348472fb8b649b4a088fa2579fda6aaa25ac | diff --git a/Src/Newtonsoft.Json/DefaultJsonNameTable.cs b/Src/Newtonsoft.Json/DefaultJsonNameTable.cs
index 5243160ea..659eefab7 100644
--- a/Src/Newtonsoft.Json/DefaultJsonNameTable.cs
+++ b/Src/Newtonsoft.Json/DefaultJsonNameTable.cs
@@ -24,6 +24,7 @@
#endregion
using System;
+using System.Threading;
namespac... | [
"Src/Newtonsoft.Json/DefaultJsonNameTable.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,676 | issue_to_patch | Add copy constructor to JsonSerializerSettings | Replaces https://github.com/JamesNK/Newtonsoft.Json/pull/2584 | 7f78562d4496d6881e3f60504473127656b98554 | 9e9e4b3690e34bbb88bc307f381658de8ee6d581 | diff --git a/Src/Newtonsoft.Json.Tests/Serialization/JsonSerializerTest.cs b/Src/Newtonsoft.Json.Tests/Serialization/JsonSerializerTest.cs
index 6ca78fb3e..b0d3a18a6 100644
--- a/Src/Newtonsoft.Json.Tests/Serialization/JsonSerializerTest.cs
+++ b/Src/Newtonsoft.Json.Tests/Serialization/JsonSerializerTest.cs
@@ -48,6 +4... | [
"Src/Newtonsoft.Json.Tests/Serialization/JsonSerializerTest.cs",
"Src/Newtonsoft.Json/JsonSerializerSettings.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,614 | issue_to_patch | UnixDateTimeConverter throws exception if date is before 1970.
UnixDateTimeConverter is only able to convert dates after 1970, while there is apparently no reason to throw exception for dates previous to 1970.
In several algorithm explanations, dates before 1970 can be converted to negative values in unix timestamp. | Add support to pre-epoch Unix time | Fixes #2292
The existing implementation contains code specifically to disallow dates before Unix epoch. It can be assumed that some users of the library depend on the converter throwing an exception if such date is serialized or deserialized. To maintain backwards compatibility, a constructor parameter and a propert... | 13717cfc452ee9c1ea0b4fc368b8e9922d562028 | 2f6fe8ae2bcd3c702ef69d9e266f102cff39416b | diff --git a/Src/Newtonsoft.Json.Tests/Converters/UnixDateTimeConverterTests.cs b/Src/Newtonsoft.Json.Tests/Converters/UnixDateTimeConverterTests.cs
index 638c74844..ed8ee1f9b 100644
--- a/Src/Newtonsoft.Json.Tests/Converters/UnixDateTimeConverterTests.cs
+++ b/Src/Newtonsoft.Json.Tests/Converters/UnixDateTimeConverter... | [
"Src/Newtonsoft.Json.Tests/Converters/UnixDateTimeConverterTests.cs",
"Src/Newtonsoft.Json/Converters/UnixDateTimeConverter.cs"
] | [
{
"comment": "Static configuration like this isn't desirable. It is global and different apps/libraries can override each other. Please remove.",
"path": "Src/Newtonsoft.Json/Converters/UnixDateTimeConverter.cs",
"hunk": "@@ -36,6 +36,64 @@ public class UnixDateTimeConverter : DateTimeConverterBase\n ... | true | |
JamesNK/Newtonsoft.Json | 2,614 | comment_to_fix | Add support to pre-epoch Unix time | Static configuration like this isn't desirable. It is global and different apps/libraries can override each other. Please remove. | 13717cfc452ee9c1ea0b4fc368b8e9922d562028 | 2f6fe8ae2bcd3c702ef69d9e266f102cff39416b | diff --git a/Src/Newtonsoft.Json/Converters/UnixDateTimeConverter.cs b/Src/Newtonsoft.Json/Converters/UnixDateTimeConverter.cs
index d80be6edd..a211813dc 100644
--- a/Src/Newtonsoft.Json/Converters/UnixDateTimeConverter.cs
+++ b/Src/Newtonsoft.Json/Converters/UnixDateTimeConverter.cs
@@ -36,6 +36,37 @@ public class Uni... | [
"Src/Newtonsoft.Json/Converters/UnixDateTimeConverter.cs"
] | [
{
"comment": "Static configuration like this isn't desirable. It is global and different apps/libraries can override each other. Please remove.",
"path": "Src/Newtonsoft.Json/Converters/UnixDateTimeConverter.cs",
"hunk": "@@ -36,6 +36,64 @@ public class UnixDateTimeConverter : DateTimeConverterBase\n ... | true | ||
JamesNK/Newtonsoft.Json | 2,674 | issue_to_patch | Update tests to use .NET 6 | 52190a3a3de6ef9a556583cbcb2381073e7197bc | fccd86bd2b02081ef1bef9fd88293138b235755a | diff --git a/Build/build.ps1 b/Build/build.ps1
index 718de33c1..7491dc6ff 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -32,7 +32,7 @@
$nunitConsolePath = "$buildDir\Temp\NUnit.ConsoleRunner.$nunitConsoleVersion"
$builds = @(
- @{Framework = "netstandard2.0"; TestsFunction = "NetCliTests"; TestFramew... | [
"Build/build.ps1",
"Src/Newtonsoft.Json.TestConsole/Newtonsoft.Json.TestConsole.csproj",
"Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj",
"Src/Newtonsoft.Json.Tests/Utilities/ExpressionReflectionDelegateFactoryTests.cs",
"Src/global.json"
] | [] | true | |||
JamesNK/Newtonsoft.Json | 2,618 | issue_to_patch | Enabling NuGet package validation | This PR adds the [new NuGet package validation](https://docs.microsoft.com/en-us/dotnet/fundamentals/package-validation/overview) into Newtonsoft.Json's package build. This will ensure that checks are made on each PR to ensure compatibility within the package, as well as against previously shipped package (this PR will... | a45ef9f2d99a911f38154ee9d789051608b9f365 | 68ba80822cce3fbc7089011f704798be919142ff | diff --git a/Src/Newtonsoft.Json/CompatibilitySuppressions.xml b/Src/Newtonsoft.Json/CompatibilitySuppressions.xml
new file mode 100644
index 000000000..64d04acc5
--- /dev/null
+++ b/Src/Newtonsoft.Json/CompatibilitySuppressions.xml
@@ -0,0 +1,104 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Suppressions xmlns:xsi="ht... | [
"Src/Newtonsoft.Json/CompatibilitySuppressions.xml",
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj"
] | [
{
"comment": "Nit, indentation is weird. ",
"path": "Src/Newtonsoft.Json/Newtonsoft.Json.csproj",
"hunk": "@@ -33,6 +33,13 @@\n <SymbolPackageFormat>snupkg</SymbolPackageFormat>\n <CodeAnalysisRuleset>Newtonsoft.Json.ruleset</CodeAnalysisRuleset>\n <EmbedUntrackedSources>true</EmbedUntracked... | true | ||
JamesNK/Newtonsoft.Json | 2,618 | comment_to_fix | Enabling NuGet package validation | Nit, indentation is weird. | a45ef9f2d99a911f38154ee9d789051608b9f365 | 68ba80822cce3fbc7089011f704798be919142ff | diff --git a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
index 6f4bea65f..fd834d77a 100644
--- a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
+++ b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
@@ -33,6 +33,13 @@
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<CodeAna... | [
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj"
] | [
{
"comment": "Nit, indentation is weird. ",
"path": "Src/Newtonsoft.Json/Newtonsoft.Json.csproj",
"hunk": "@@ -33,6 +33,13 @@\n <SymbolPackageFormat>snupkg</SymbolPackageFormat>\n <CodeAnalysisRuleset>Newtonsoft.Json.ruleset</CodeAnalysisRuleset>\n <EmbedUntrackedSources>true</EmbedUntracked... | true | ||
JamesNK/Newtonsoft.Json | 2,618 | comment_to_fix | Enabling NuGet package validation | Can we apply a condition here so that it's not permitted during an official build? Maybe `Condition='$(SignAssembly)' != 'true'"` | a45ef9f2d99a911f38154ee9d789051608b9f365 | 68ba80822cce3fbc7089011f704798be919142ff | diff --git a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
index 6f4bea65f..fd834d77a 100644
--- a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
+++ b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
@@ -33,6 +33,13 @@
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<CodeAna... | [
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj"
] | [
{
"comment": "Can we apply a condition here so that it's not permitted during an official build? Maybe `Condition='$(SignAssembly)' != 'true'\"`",
"path": "Src/Newtonsoft.Json/Newtonsoft.Json.csproj",
"hunk": "@@ -33,6 +33,13 @@\n <SymbolPackageFormat>snupkg</SymbolPackageFormat>\n <CodeAnalysi... | true | ||
JamesNK/Newtonsoft.Json | 2,618 | comment_to_fix | Enabling NuGet package validation | @JamesNK Thanks for fixing the build by updating VS. I added some comments to explain he breaking changes that were found in the package as it is today. Could you please take a look and confirm all of them are by design? | a45ef9f2d99a911f38154ee9d789051608b9f365 | 68ba80822cce3fbc7089011f704798be919142ff | diff --git a/Src/Newtonsoft.Json/CompatibilitySuppressions.xml b/Src/Newtonsoft.Json/CompatibilitySuppressions.xml
new file mode 100644
index 000000000..64d04acc5
--- /dev/null
+++ b/Src/Newtonsoft.Json/CompatibilitySuppressions.xml
@@ -0,0 +1,104 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Suppressions xmlns:xsi="ht... | [
"Src/Newtonsoft.Json/CompatibilitySuppressions.xml"
] | [
{
"comment": "@JamesNK Thanks for fixing the build by updating VS. I added some comments to explain he breaking changes that were found in the package as it is today. Could you please take a look and confirm all of them are by design?",
"path": "Src/Newtonsoft.Json/CompatibilitySuppressions.xml",
"hunk"... | true | ||
JamesNK/Newtonsoft.Json | 2,618 | comment_to_fix | Enabling NuGet package validation | It seems like the condition for this hasn't been added. | a45ef9f2d99a911f38154ee9d789051608b9f365 | 68ba80822cce3fbc7089011f704798be919142ff | diff --git a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
index 6f4bea65f..fd834d77a 100644
--- a/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
+++ b/Src/Newtonsoft.Json/Newtonsoft.Json.csproj
@@ -33,6 +33,13 @@
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<CodeAna... | [
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj"
] | [
{
"comment": "It seems like the condition for this hasn't been added.",
"path": "Src/Newtonsoft.Json/Newtonsoft.Json.csproj",
"hunk": "@@ -33,6 +33,13 @@\n <SymbolPackageFormat>snupkg</SymbolPackageFormat>\n <CodeAnalysisRuleset>Newtonsoft.Json.ruleset</CodeAnalysisRuleset>\n <EmbedUntracked... | true | ||
JamesNK/Newtonsoft.Json | 2,619 | issue_to_patch | Update pipelines image to VS2022 and fix build warnings | af6e7b9c13b80c5fef38204a7543e38cc532961d | d061ae755587a34d7adb1077c0dec27bbf8c847e | diff --git a/Src/Directory.Build.props b/Src/Directory.Build.props
index 661350885..bafd1cd9e 100644
--- a/Src/Directory.Build.props
+++ b/Src/Directory.Build.props
@@ -3,7 +3,7 @@
<AutofacPackageVersion>4.6.2</AutofacPackageVersion>
<BenchmarkDotNetPackageVersion>0.10.10</BenchmarkDotNetPackageVersion>
... | [
"Src/Directory.Build.props",
"Src/Newtonsoft.Json.Tests/Newtonsoft.Json.Tests.csproj",
"azure-pipelines.yml"
] | [] | true | |||
JamesNK/Newtonsoft.Json | 2,610 | issue_to_patch | Correction for arrays of more than 2 dimensions with $type | Replaces https://github.com/JamesNK/Newtonsoft.Json/pull/2605
@Perpete | 4fda2ea27e1f634a53d033d78ea11325dee16ea8 | 4219c9bab4dd7ce06a679e817955268b20cb5828 | diff --git a/Src/Newtonsoft.Json.Tests/Serialization/TypeNameHandlingTests.cs b/Src/Newtonsoft.Json.Tests/Serialization/TypeNameHandlingTests.cs
index 2b65d0aa1..ccb5543cc 100644
--- a/Src/Newtonsoft.Json.Tests/Serialization/TypeNameHandlingTests.cs
+++ b/Src/Newtonsoft.Json.Tests/Serialization/TypeNameHandlingTests.cs... | [
"Src/Newtonsoft.Json.Tests/Serialization/TypeNameHandlingTests.cs",
"Src/Newtonsoft.Json.Tests/TestObjects/HasByteArray.cs",
"Src/Newtonsoft.Json/Utilities/ReflectionUtils.cs"
] | [] | true | ||
JamesNK/Newtonsoft.Json | 2,596 | issue_to_patch | Add README to NuGet packages
Hello!
I am from the NuGet team at Microsoft. We recently introduced support for embedding READMEs into NuGet packages ([blog](https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/), [docs](https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packagereadme... | Add embedded README.md | Fixes https://github.com/JamesNK/Newtonsoft.Json/issues/2571 | 52e257ee57899296d81a868b32300f0b3cfeacbe | 41956e1dbf962b923df42abeb72ec0d313369571 | diff --git a/Build/build.ps1 b/Build/build.ps1
index 1beda3451..718de33c1 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -1,7 +1,7 @@
properties {
$zipFileName = "Json130r3.zip"
$majorVersion = "13.0"
- $majorWithReleaseVersion = "13.0.1"
+ $majorWithReleaseVersion = "13.0.2"
$nugetPrerelease = $nul... | [
"Build/build.ps1",
"Build/version.json",
"Src/Newtonsoft.Json/Newtonsoft.Json.csproj",
"Src/Newtonsoft.Json/README.md",
"Src/global.json",
"azure-pipelines.yml"
] | [] | true | |
JamesNK/Newtonsoft.Json | 2,557 | issue_to_patch | Use latest SDK for reproducible builds | Needs the 16.10 or later MSBuild for the proper metadata. | e44ab3348fabcbe9ed6b5053b706a9e10b945ba1 | a2cebb21889623ed765dfb368d955653ec6e3c82 | diff --git a/Build/build.ps1 b/Build/build.ps1
index ea2c22f8e..1beda3451 100644
--- a/Build/build.ps1
+++ b/Build/build.ps1
@@ -14,7 +14,7 @@
$workingName = if ($workingName) {$workingName} else {"Working"}
$assemblyVersion = if ($assemblyVersion) {$assemblyVersion} else {$majorVersion + '.0.0'}
$netCliChanne... | [
"Build/build.ps1",
"Src/global.json"
] | [
{
"comment": "```suggestion\r\n \"version\": \"5.0.300\"\r\n```",
"path": "Src/global.json",
"hunk": "@@ -1,5 +1,5 @@\n {\n \"sdk\": {\n- \"version\": \"5.0.200\"\n+ \"version\": \"5.0.3 00\"",
"resolving_sha": "a2cebb21889623ed765dfb368d955653ec6e3c82",
"resolving_diff": "diff --git ... | true | ||
JamesNK/Newtonsoft.Json | 2,557 | comment_to_fix | Use latest SDK for reproducible builds | ```suggestion
"version": "5.0.300"
``` | e44ab3348fabcbe9ed6b5053b706a9e10b945ba1 | a2cebb21889623ed765dfb368d955653ec6e3c82 | diff --git a/Src/global.json b/Src/global.json
index 6d19c9f6c..a601da31b 100644
--- a/Src/global.json
+++ b/Src/global.json
@@ -1,5 +1,5 @@
{
"sdk": {
- "version": "5.0.200"
+ "version": "5.0.300"
}
-}
\ No newline at end of file
+}
| [
"Src/global.json"
] | [
{
"comment": "```suggestion\r\n \"version\": \"5.0.300\"\r\n```",
"path": "Src/global.json",
"hunk": "@@ -1,5 +1,5 @@\n {\n \"sdk\": {\n- \"version\": \"5.0.200\"\n+ \"version\": \"5.0.3 00\"",
"resolving_sha": "a2cebb21889623ed765dfb368d955653ec6e3c82",
"resolving_diff": "diff --git ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.