Datasets:
PotatoHD
/
github-pr-resolve

Dataset card Data Studio Files
xet
 Community
repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
twitter/twemproxy
638
issue_to_patch
Update documentation on running tests, config options, etc.
Problem Make it easier for users/contributors/packagers to run tests. `tcpkeepalive` was previously not documented in the README.
4cb2e8681d10dc7af27eaf82337052bcd11aef23
93f3dd989bcdd38f8810e61a616bab6e74e66bb5
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index cb4034df..4444674f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -39,4 +39,4 @@ jobs: # Runs a single command using the runners shell - name: Build and test in docker - run: bash ./travis.sh $...
[ ".github/workflows/main.yml", "README.md", "ci/Dockerfile", "test_in_docker.sh", "tests/README.rst" ]
[]
diff --git a/travis.sh b/test_in_docker.sh similarity index 100% rename from travis.sh rename to test_in_docker.sh diff --git a/tests/README.rst b/tests/README.rst index 5a4c924c..0ae657ea 100644 --- a/tests/README.rst +++ b/tests/README.rst @@ -1,13 +1,19 @@ Python testing facilities for twemproxy, this test suite is...
true
twitter/twemproxy
598
issue_to_patch
Fix failing unit tests, run in Docker
Problem Travis tests are currently failing Solution Running it in docker makes it easier to run this in other CI providers and to easily reproduce any failures seen in Travis locally. Move to python 3 Rewrite travis.sh from scratch Result Travis tests will pass, and it will be easier to run them...
1fde0f4717823fabdd01cdb664f69b70aa8298c7
8caa0a20afb67d59f4a06b0c1fb6b98224a67269
diff --git a/.dockerignore b/.dockerignore new file mode 100644 index 00000000..b925dd86 --- /dev/null +++ b/.dockerignore @@ -0,0 +1,57 @@ +Dockerfile* +**/Dockerfile* +*.gz +src/nutredis +src/nutcracker +tests/_binaries/* + +### Entries copied from .gitignore +# pyc +*.pyc + +# Compiled Object files +*.lo +*.o + +# C...
[ ".dockerignore", ".github/workflows/main.yml", ".travis.yml", "ci/Dockerfile", "ci/build-nutcracker.sh", "tests/README.rst", "tests/_binaries/.gitignore", "tests/conf/redis.conf", "tests/conf/sentinel.conf", "tests/lib/server_modules.py", "tests/lib/utils.py", "tests/nosetests_verbose.sh", "...
[]
diff --git a/tests/README.rst b/tests/README.rst index acceea41..3505f3ca 100644 --- a/tests/README.rst +++ b/tests/README.rst @@ -10,10 +10,10 @@ usage 1. install dependency:: pip install nose - pip install git+https://github.com/andymccurdy/redis-py.git@2.10.3 - pip install git+https://github.com/idning...
true
twitter/twemproxy
623
issue_to_patch
Update tests
Fix compilation warnings in unit test, add more test cases for new commands
42c2a1d07102313432a152b1bd7b15b1e7520c96
9022647b74f28810f1798919cff08b0236c2c9ab
[ "src/test_all.c" ]
[]
diff --git a/src/test_all.c b/src/test_all.c index 070498a3..88de2aa6 100644 --- a/src/test_all.c +++ b/src/test_all.c @@ -7,9 +7,20 @@ static int failures = 0; static int successes = 0; +static void expect_same_int(int expected, int actual, const char* message) { + if (expected != actual) { + printf("FAI...
true
twitter/twemproxy
635
issue_to_patch
Update the changelog
Document changes since `v0.4.1`
1653924a74e38023c2fa9a7a8291e46dc8d3e718
4bd87c0f7e0e87b2a4062402119046f7d2c5117e
diff --git a/ChangeLog b/ChangeLog index a1c22ee7..e64a356f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2021-??-?? Tyson Andre * twemproxy: version 0.5.0 release (dev) + Add 'tcpkeepalive' pool boolean config flag setting + to enable tcp keepalive (charsyam, manju) + Support redis bitpos comman...
[ "ChangeLog" ]
[]
true
twitter/twemproxy
595
issue_to_patch
Segmentation-Fault: ncontinuum versus Pool Server-Count This Is Not A Contribution: Good day. I've encountered reproducible segmentation-faults while using `auto_eject_hosts=true`. Debugging led me to an out-of-bounds attempted access of a `sub_msgs` array. In these functions: - `src/proto/nc_memcache.c` : ...
Use nservers instead of ncontinuum to fix segfault when all hosts are ejected
ncontinuum is `160 * the number of **non-ejected** hosts` for the ketama distribution, where 160 is the ketama consistent hashing points per server. However, the index returned by msg_backend_idx is a number between 0..nservers-1. - This is a waste of time zeroing out 160 times as much memory as needed - When th...
f96e354e2a46842a37fcf740f1c442d19e216f42
14bac4052bdf348db8727ff8dc8b4e28dd3abcee
diff --git a/src/nc_request.c b/src/nc_request.c index 9de12933..5b7f859f 100644 --- a/src/nc_request.c +++ b/src/nc_request.c @@ -673,7 +673,7 @@ req_recv_done(struct context *ctx, struct conn *conn, struct msg *msg, /* do fragment */ pool = conn->owner; TAILQ_INIT(&frag_msgq); - status = msg->fragme...
[ "src/nc_request.c", "src/proto/nc_memcache.c", "src/proto/nc_proto.h", "src/proto/nc_redis.c" ]
[]
true
twitter/twemproxy
615
issue_to_patch
Fail GitHub actions builds on new compiler warnings, warn about incorrect log format strings
Problem Builds would pass despite compiler warnings with the compiler used for CI. Invalid format strings were allowed for logging statements. Solution Stricten the gcc warnings used for GitHub actions (don't change it elsewhere). Warn about mismatches between format strings and arguments in logging statemen...
60060651c2057ad00f01d65a329203e4e03cdaf0
1239ef9e2f14f954b0f5da22369c0d994a347e45
diff --git a/.dockerignore b/.dockerignore index b925dd86..2b1a09f5 100644 --- a/.dockerignore +++ b/.dockerignore @@ -44,7 +44,7 @@ core* nutcracker # extracted yaml -!/contrib/yaml-0.1.4.tar.gz +!/contrib/yaml-0.2.5.tar.gz # Autotools .deps diff --git a/.gitignore b/.gitignore index f482cc55..8e1230f5 100644 ...
[ ".dockerignore", ".gitignore", "ChangeLog", "NOTICE", "ci/build-nutcracker.sh", "configure.ac", "contrib/Makefile.am", "contrib/yaml-0.1.4.tar.gz", "contrib/yaml-0.2.5.tar.gz", "contrib/yaml-0.2.5/.gitignore", "notes/debug.txt", "notes/redis.md", "src/Makefile.am", "src/nc.c", "src/nc_co...
[]
diff --git a/src/test_all.c b/src/test_all.c index 9d2836be..070498a3 100644 --- a/src/test_all.c +++ b/src/test_all.c @@ -57,7 +57,7 @@ static void test_redis_parse_req_success_case(char* data, int expected_type) { struct msg *req = msg_get(&fake_client, 1, 1); req->state = SW_START; req->token = NULL; ...
true
twitter/twemproxy
613
issue_to_patch
Followup for new redis commands and multibulk support
Revert the addition of blocking commands proposed in #599 - including them even as a compilation option is probably a poor way to distribute it, they'll block everything using the same server connection. Support `COMMAND` (used by redis-cli) and a placeholder no-argument command forwarded to a random redis server.
746216cbecb51d2d872c397983f60491f5b5d57e
7e131f825e6d8605f7ce27e702079429592d8f04
diff --git a/src/nc_message.h b/src/nc_message.h index 598c98ba..ffb39004 100644 --- a/src/nc_message.h +++ b/src/nc_message.h @@ -19,8 +19,7 @@ #define _NC_MESSAGE_H_ #include <nc_core.h> - -#define MAXDEPTH 4 +#include <proto/nc_proto.h> typedef void (*msg_parse_t)(struct msg *); typedef rstatus_t (*msg_add_a...
[ "src/nc_message.h", "src/proto/nc_redis.c" ]
[]
true
twitter/twemproxy
599
issue_to_patch
Support various commands from newer redis versions
If this is approved, documentation should also be added to notes/redis.md Some commands such as EXISTS have been changed to support multiple arguments. Copied from https://github.com/ifwe/twemproxy/pull/32/files which also updates unit tests (depends on changes to the test framework) - That PR has the script ...
ace7c2db5c5fa518534d14f8011c204d3f6a0064
c71cb037332a644f056571b3bf8ac6fb18abf13e
diff --git a/notes/redis.md b/notes/redis.md index 1f5fefea..a1f2d529 100644 --- a/notes/redis.md +++ b/notes/redis.md @@ -81,7 +81,7 @@ +-------------------+------------+---------------------------------------------------------------------------------------------------------------------+ | MGET ...
[ "notes/redis.md", "src/nc_message.h", "src/proto/nc_proto.h", "src/proto/nc_redis.c" ]
[]
true
twitter/twemproxy
611
issue_to_patch
0.4.1 Response corruption with timeout and lua script We've found an issue whereby Twemproxy seems to get into a situation where responses are corrupted and mixed incorrectly between clients. The issue seems to be triggered by evaluation of a lua script combined with a response timeout. After a request is times out (a...
Fix parsing of redis error message without space
And add unit tests of redis messages being parsed successfully Add testcase of error with no space The test case was cherry-picked from https://github.com/twitter/twemproxy/pull/406 The alternate fix a74db76ce816caa14e8a85548f34088f9c594e6e was used - both do the same thing, not subtracting is personal prefere...
cb6c56442c8c9f55f9645c1bd0ca798b1ec1289f
7a4e7ada05b648c7ce096bc12654e257a86c8e91
diff --git a/ChangeLog b/ChangeLog index 439b9b91..5da6dd3f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,24 @@ + 2021-??-?? Tyson Andre + * twemproxy: version 0.4.2 release (dev) + Fix parsing of redis error response for error type with no space, + add tests (tyson, tom dalton) + Update integration tests...
[ "ChangeLog", "src/proto/nc_redis.c", "src/test_all.c" ]
[]
diff --git a/src/test_all.c b/src/test_all.c index 2ff2c44e..85ab1c05 100644 --- a/src/test_all.c +++ b/src/test_all.c @@ -2,6 +2,7 @@ #include <nc_conf.h> #include <nc_util.h> #include <proto/nc_proto.h> +#include <stdio.h> static int failures = 0; static int successes = 0; @@ -16,7 +17,7 @@ static void expect_...
true
twitter/twemproxy
612
issue_to_patch
Fix processing of redis multibulk (nested array) responses (from eval, new commands, etc)
Problem Redis hangs or misbehaves when processing multibulk redis responses (nested arrays) Solution Keep track of how many more elements need to be parsed when parsing the redis response, as well as whether the top-level value is a multi-bulk response Continue to properly count the number of top level a...
2e4f1c796917c707b4558e129a5de221c418d88c
523348f69111a220f4dc2bb4fef87ff130ba2b88
diff --git a/ChangeLog b/ChangeLog index 5da6dd3f..8acb6147 100644 --- a/ChangeLog +++ b/ChangeLog @@ -18,6 +18,8 @@ Allow extra parameters for redis spop (charsyam) Update documentation and README (various) Fix memory leak bug for redis mset (deep011) + Support arbitrarily deep nested redis multi-bulk + ...
[ "ChangeLog", "src/nc_message.c", "src/nc_message.h", "src/proto/nc_redis.c", "src/test_all.c", "tests/test_redis/test_basic.py" ]
[]
diff --git a/src/test_all.c b/src/test_all.c index 85ab1c05..9d2836be 100644 --- a/src/test_all.c +++ b/src/test_all.c @@ -133,6 +133,18 @@ static void test_redis_parse_rsp_success(void) { test_redis_parse_rsp_success_case("*2\r\n$3\r\nfoo\r\n$3\r\nbar\r\n"); /* array with 2 bulk strings */ test_redis_parse_...
true
twitter/twemproxy
602
issue_to_patch
Add editorconfig matching the c style guide, fix typos in c style guide
Problem New contributors or contributors working on multiple projects may use different indentation widths or tabs or not be aware of the 80 column limit (or use different line endings or encodings) Solution Add a `.editorconfig` to make it more likely editors/IDEs will choose the correct encoding automatical...
48e3f39c36d0e6b71c0e0375bfec8588ca34e3b6
0421ad35d7a664aa71fd76fef77aac352c405f34
diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 00000000..73461bc7 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,19 @@ +# https://editorconfig.org/ + +root = true + +[*] +trim_trailing_whitespace = true +insert_final_newline = true +end_of_line = lf +charset = utf-...
[ ".editorconfig", "notes/c-styleguide.txt" ]
[]
true
twitter/twemproxy
597
issue_to_patch
If dns lookup fails for all hosts in a pool, memcache get/multiget (and redis mget) requests fail (but not other commands such as incr) **Describe the bug** If hostnames are used instead of ip addresses for all hosts within a pool, and dns lookup fails, then get/multiget will hang indefinitely **instead of** respo...
Don't hang for dns error responding to fragmented requests
If hostnames are used instead of ip addresses for all hosts within a pool, and dns lookup fails, then get/multiget will hang indefinitely **instead of** responding with an error such as `SERVER_ERROR Host is down`. (I expect a client would detect this and close the connection, but this is not ideal, the client tim...
5c2a3730540b2bfc8aa8209ef5933400be9807cc
0667d618d80248ef20dd32bd7e2af99b9ff6bbac
diff --git a/src/nc_request.c b/src/nc_request.c index 5fc4190a..9de12933 100644 --- a/src/nc_request.c +++ b/src/nc_request.c @@ -578,6 +578,21 @@ req_forward(struct context *ctx, struct conn *c_conn, struct msg *msg) s_conn = server_pool_conn(ctx, c_conn->owner, key, keylen); if (s_conn == NULL) { + ...
[ "src/nc_request.c" ]
[]
true
twitter/twemproxy
601
issue_to_patch
Add a clang-format file approximating the c style guide
This detects some inconsistent uses of indentation and inconsistent space after casts, but has a lot more false positives. https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting may be of use for saving time for contributors reformatting new patches Problem Make it easier to automatically...
48e3f39c36d0e6b71c0e0375bfec8588ca34e3b6
a575ab2190a8c1429b35dcaf4254c7b2a5b35ff7
diff --git a/.clang-format.example b/.clang-format.example new file mode 100644 index 00000000..fa3391b2 --- /dev/null +++ b/.clang-format.example @@ -0,0 +1,45 @@ +# This may be useful with https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting +# but some of clang's reformattings may conflict with...
[ ".clang-format.example", ".gitignore" ]
[]
true
twitter/twemproxy
634
issue_to_patch
Test edge cases of parsing memcache/redis protocol
11656756d702745d1c6e39c5512c53210ccc7c27
848d7c1635ed8c6251a68fac67c3206cecec0878
diff --git a/src/proto/nc_redis.c b/src/proto/nc_redis.c index 6f2a030f..a5ea210f 100644 --- a/src/proto/nc_redis.c +++ b/src/proto/nc_redis.c @@ -1960,7 +1960,6 @@ redis_parse_rsp(struct msg *r) SW_START, SW_STATUS, SW_ERROR, - SW_INTEGER, SW_INTEGER_START, SW_SIMPLE...
[ "src/proto/nc_redis.c", "src/test_all.c" ]
[]
diff --git a/src/test_all.c b/src/test_all.c index cd51a2d9..33743596 100644 --- a/src/test_all.c +++ b/src/test_all.c @@ -132,7 +132,7 @@ static void test_redis_parse_rsp_success_case(const char* data, int expected) { msg_put(rsp); /* mbuf_put(m); */ if (failures > original_failures) { - fprintf(...
true
twitter/twemproxy
632
issue_to_patch
Support memcache 'version' request, add memcache tests
Make it easier for clients to automatically detect which commands are supported by backend servers in preparation for supporting the meta-text protocol (assuming backend servers almost always run the same version everywhere)
85f98759aec5d46b4a675333218c282e595c23cc
84733fc875c61dffd0a377e4b5eaa2284338bc7c
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1b141dc3..cb4034df 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -22,13 +22,15 @@ jobs: # See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#using-environment-variables-in-a-m...
[ ".github/workflows/main.yml", "ChangeLog", "notes/debug.txt", "notes/memcache.md", "src/nc_message.c", "src/nc_message.h", "src/proto/nc_memcache.c", "src/proto/nc_redis.c", "src/test_all.c" ]
[]
diff --git a/src/test_all.c b/src/test_all.c index 9a998bae..cd51a2d9 100644 --- a/src/test_all.c +++ b/src/test_all.c @@ -178,6 +178,7 @@ static void test_memcache_parse_rsp_success_case(const char* data, int expected) struct conn fake_client = {0}; struct mbuf *m = mbuf_get(); const int SW_START = 0; ...
true
twitter/twemproxy
622
issue_to_patch
python-memcached warning is now out of date I have been reading about twemproxy for a python environment. I noticed your warning about [python-memcached](https://github.com/twitter/twemproxy/blob/master/notes/recommendation.md#twemproxy-and-python-memcached) and investigated. It looks like this is now fixed per http...
[skip ci] Remove reference to outdated python-memcached version
https://github.com/linsomniac/python-memcached/ 1.5.8 had the delete_multi signature fixed in 2016. Anyone who had installed an outdated version should have seen this recommendation already or worked around it differently. There are a large number of other languages that have their own memcache clients with diff...
cb0db33be813d4e219b347bf839bffac6623a3d5
2e28feb6ca9ee092bdc340197363c9c02aa1c034
diff --git a/notes/recommendation.md b/notes/recommendation.md index 13289297..45782f9c 100644 --- a/notes/recommendation.md +++ b/notes/recommendation.md @@ -151,12 +151,6 @@ You can also graph the timestamp at which any given server was ejected by graphi ## server_connections: > 1 -By design, twemproxy multiplex...
[ "notes/recommendation.md" ]
[]
true
twitter/twemproxy
629
issue_to_patch
Improve single-server pool efficiency, log event backend with version
Improve efficiency when twemproxy is used as a proxy for a single server backend. Make it easier for users to report which asynchronous event processing backend is used in bug reports. Update changelog, indicate that 0.5.0 is the next release
9339bcf2444b030d69722717b27db049331fab04
da3c4b45961da2d33696ca7038d6887b646c45f0
diff --git a/ChangeLog b/ChangeLog index 348bb998..8cf11470 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,5 @@ 2021-??-?? Tyson Andre - * twemproxy: version 0.4.2 release (dev) + * twemproxy: version 0.5.0 release (dev) Fix parsing of redis error response for error type with no space, add tests (ty...
[ "ChangeLog", "src/nc.c", "src/nc_server.c" ]
[]
true
twitter/twemproxy
636
issue_to_patch
Is function 'memcache_copy_bulk()' in nc_memcache.c safe the format of the response for get/gets is: "VALUE key1 0 len1\r\nval1\r\nVALUE key2 0 len2\r\nval2\r\nEND\r\n" is it safe while you are eating 'VALUE key 0'? (line 1450) maybe string 'VALUE key 0' is fragmented into two mbuf? ``` for (i = 0; i < 3; i++) { ...
Fix possible crash copying malformed memcache value responses
Closes #436 Problem Malformed messages may have extremely long flags or expiry fields Solution Check if the end of the mbuf is reached - valid messages key response chunks should not have headers exceeding the minimum mbuf size Result Log an error and discard results if a memcache server responds wit...
c3639c504fe927ea00c0f4bb76512686286dd415
f95c0ab7dcd2d098b77ad4f91bcce1b85a26cec5
diff --git a/src/proto/nc_memcache.c b/src/proto/nc_memcache.c index 51a89f9c..d4c91273 100644 --- a/src/proto/nc_memcache.c +++ b/src/proto/nc_memcache.c @@ -1355,9 +1355,9 @@ memcache_fragment_retrieval(struct msg *r, uint32_t nserver, /* prepend get/gets */ if (r->type == MSG_REQ_MC_GET) { - ...
[ "src/proto/nc_memcache.c" ]
[]
true
twitter/twemproxy
616
issue_to_patch
[skip ci] Add script to extract redis key/arg count ranges
This uses commands.json from redis's documentation to determine which category a given redis command falls into. This will be useful to ensure that twemproxy stays up to date with new redis commands. (but the new script still requires a lot of manual work). This was used to generate the previously added documenta...
db2e64210dd583274509d68be9892cc853b1ec46
92587165743ed83cc70c3e251202e7d87f73a9a6
diff --git a/scripts/extract_redis_commands_argcounts.php b/scripts/extract_redis_commands_argcounts.php new file mode 100755 index 00000000..fbeeeeec --- /dev/null +++ b/scripts/extract_redis_commands_argcounts.php @@ -0,0 +1,359 @@ +#!/usr/bin/env php +<?php +/** + * @author Tyson Andre + * + * Heuristics to extract ...
[ "scripts/extract_redis_commands_argcounts.php" ]
[]
true
twitter/twemproxy
628
issue_to_patch
Add const value qualifiers for C functions where applicable
Problem Make it easier for readers to understand what arguments are or aren't modified by a function (etc.) Make it harder to accidentally modify a pointer that is assumed to not be modified. Solution Add const qualifiers to function signatures, local variables, static variables
4b33ca8b31fb3f0f15f8c2f08050263977c0d8a1
b7177baf46f176ca2e20529fa6f02e97b2c6ef4f
diff --git a/ci/Dockerfile b/ci/Dockerfile index 05b3f1d4..86e1b5dc 100644 --- a/ci/Dockerfile +++ b/ci/Dockerfile @@ -30,7 +30,7 @@ RUN pip3.6 install nose && \ # RUN yum install -y redis redis-sentinel ARG REDIS_VER=3.2.11 -RUN wget https://github.com/antirez/redis/archive/$REDIS_VER.tar.gz && \ +RUN wget https:/...
[ "ci/Dockerfile", "src/hashkit/nc_fnv.c", "src/hashkit/nc_hashkit.h", "src/hashkit/nc_ketama.c", "src/hashkit/nc_md5.c", "src/hashkit/nc_modula.c", "src/hashkit/nc_random.c", "src/nc.c", "src/nc_array.c", "src/nc_array.h", "src/nc_client.c", "src/nc_client.h", "src/nc_conf.c", "src/nc_conf....
[]
diff --git a/src/test_all.c b/src/test_all.c index 88de2aa6..9a998bae 100644 --- a/src/test_all.c +++ b/src/test_all.c @@ -47,7 +47,7 @@ static void test_hash_algorithms(void) { } static void test_config_parsing(void) { - char* conf_file = "../conf/nutcracker.yml"; + const char* conf_file = "../conf/nutcracke...
true
twitter/twemproxy
630
issue_to_patch
Avoid warning about implicit loss of precision in clang
Fix clang compiler warnings in preparation for testing in clang Unit tests and integration tests pass with `CFLAGS="-Werror -Wall -Wno-pointer-sign -Wno-sign-conversion -Wno-missing-braces -Wno-unused-value -Wno-unused-function"`
82c2052406f36c456e0f25fcae937aa939d06354
50b6c8d48b8ddf60bcd5ba54f9dd7a5a6a203107
diff --git a/src/nc_conf.c b/src/nc_conf.c index 32470236..c4e48ddb 100644 --- a/src/nc_conf.c +++ b/src/nc_conf.c @@ -1745,7 +1745,7 @@ conf_set_hash(struct conf *cf, const struct command *cmd, void *conf) continue; } - *hp = hash - hash_strings; + *hp = (hash_type_t)(hash - hash_...
[ "src/nc_conf.c" ]
[]
true
twitter/twemproxy
637
issue_to_patch
Make error for failing to listen on stats port less confusing (nc_stats.c:846 listen on m 4 failed: Address already in use) `nc_stats.c:846 listen on m 4 failed: Address already in use` Including the address that nutcracker is trying to listen on (e.g. 0.0.0.0:22222) would avoid confusion - similar to what nc_proxy...
Make error messages starting the stats server clearer
Closes #618 Problem It isn't immediately obvious that some of the syslog messages are for listening on the stats server. Solution Mention that this is creating a stats server and the address used for listening in the issue message
4700e93c7674c56f4105953a2a65075e306348e2
be8fa000d33d8924a38423627afa4bfde06f0c70
diff --git a/ChangeLog b/ChangeLog index e64a356f..72bb3e69 100644 --- a/ChangeLog +++ b/ChangeLog @@ -35,6 +35,7 @@ exactly one server (tyson) Support memcache 'version' requests by proxying the request to a single backend memcache server to fetch the server version. (tyson) + Make error messages for cre...
[ "ChangeLog", "README.md", "src/nc_stats.c", "src/proto/nc_memcache.c" ]
[]
true
twitter/twemproxy
570
issue_to_patch
Improve formatting of README file
Basic improvements to documentation to improve readability Fix indented bulleted list and add monospaced formatting to command flags within paragraphs
c5c725d2b45715e378909ebc909b0492591c4715
e350a6e81dd98b4e2eff873f9d71a0375fdeaf12
diff --git a/README.md b/README.md index 0b2cb7b4..715b5278 100644 --- a/README.md +++ b/README.md @@ -83,23 +83,23 @@ Twemproxy can be configured through a YAML file specified by the -c or --conf-fi + **listen**: The listening address and port (name:port or ip:port) or an absolute path to sock file (e.g. /var/run/nut...
[ "README.md" ]
[]
true
twitter/twemproxy
541
issue_to_patch
fix list indentation in README
34eb60fb977da9aa8bcac784dee1e7fb04c79d47
a2159dfa5c19983c18e05e9e8bd234c615942768
diff --git a/README.md b/README.md index 0b2cb7b4..117d711e 100644 --- a/README.md +++ b/README.md @@ -83,23 +83,23 @@ Twemproxy can be configured through a YAML file specified by the -c or --conf-fi + **listen**: The listening address and port (name:port or ip:port) or an absolute path to sock file (e.g. /var/run/nut...
[ "README.md" ]
[]
true
twitter/twemproxy
619
issue_to_patch
Fix a crash seen when logging redis `COMMAND` in recent patches
The recent patches add support for a placeholder key, which is actually a constant string in memory. The logging helper method should not be mutating the data it's logging. Solution: Specify the length of the string to log instead of introducing a null byte.
c741bf1613c196e1ae38288ed4b75b3e07ce5881
34dcc49fbb9519e68233a809b9f842e4e65cafe8
diff --git a/src/nc_request.c b/src/nc_request.c index ca54572f..46ab7bad 100644 --- a/src/nc_request.c +++ b/src/nc_request.c @@ -33,14 +33,14 @@ req_get(struct conn *conn) } static void -req_log(struct msg *req) +req_log(const struct msg *req) { struct msg *rsp; /* peer message (response) */ ...
[ "src/nc_request.c" ]
[]
true
twitter/twemproxy
610
issue_to_patch
Add various unit tests and integration tests
Add a `make check` script with standalone unit tests of the c functions. Source: https://github.com/ifwe/twemproxy/tree/build-nutredis This is the subset of the tests that currently pass with the current functionality of twitter/twemproxy Problem Improve test coverage and detect any regressions Solution ...
cb81d61ae3fa03a634fe331c546995ec7e3c0464
0b98d99fa0e771f412d79fe3e70060bf0f8ad1ff
diff --git a/ci/Dockerfile b/ci/Dockerfile index 6e9fa5ed..05b3f1d4 100644 --- a/ci/Dockerfile +++ b/ci/Dockerfile @@ -5,13 +5,13 @@ FROM centos:7 ENV LAST_MODIFIED_DATE 2021-04-09 -# socat Allow tests to open log files -# which (used below) -# python-setuptools for pip RUN yum install -y \ https://repo....
[ "ci/Dockerfile", "src/Makefile.am", "src/hashkit/nc_hashkit.h", "src/hashkit/nc_ketama.c", "src/test_all.c", "tests/README.rst", "tests/_binaries/.gitignore", "tests/conf/conf.py", "tests/lib/server_modules.py", "tests/lib/utils.py", "tests/test_redis/common.py", "tests/test_redis/test_auth.py...
[]
diff --git a/src/test_all.c b/src/test_all.c new file mode 100644 index 00000000..2ff2c44e --- /dev/null +++ b/src/test_all.c @@ -0,0 +1,241 @@ +#include <nc_hashkit.h> +#include <nc_conf.h> +#include <nc_util.h> +#include <proto/nc_proto.h> + +static int failures = 0; +static int successes = 0; + +static void expect_s...
true
twitter/twemproxy
545
issue_to_patch
Always initialize file permissions field for unix domain socket
It seems like field->perm might be uninitialized memory depending on how it is allocated. The intended behavior is to only change file permissions from the default if a permission was specified in the config: https://github.com/twitter/twemproxy/pull/311/files#diff-f74ea9da930e79a9573455a0cbe4785d I ran into an i...
34eb60fb977da9aa8bcac784dee1e7fb04c79d47
85fb83faec3beb1dc2315df49dabcec6e8f54c0f
diff --git a/src/nc_conf.c b/src/nc_conf.c index fa720796..7d773df6 100644 --- a/src/nc_conf.c +++ b/src/nc_conf.c @@ -1474,6 +1474,7 @@ conf_set_listen(struct conf *cf, struct command *cmd, void *conf) /* no permissions field, so use defaults */ name = value->data; namelen = valu...
[ "src/nc_conf.c" ]
[]
true
twitter/twemproxy
607
issue_to_patch
Switch to GitHub actions for builds
Problem Travis CI builds have been queueing for hours for some PRs. Integration tests are run as a simple docker script. Solution Run the dockerized integration tests only in GitHub actions
5c2a3730540b2bfc8aa8209ef5933400be9807cc
05032cef107f6b128157cf69cf0f45d7a3ee1cd4
diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 793cd3e3..00000000 --- a/.travis.yml +++ /dev/null @@ -1,15 +0,0 @@ -services: - - docker - -# We test the latest patch commits of multiple redis versions because sentinel responses are different, -# and to verify that unit tests of redis pass in all...
[ ".travis.yml", "README.md" ]
[]
true
twitter/twemproxy
524
issue_to_patch
Add Docker support
Add Dockerfile to enable image building. Using the official GCC image, latest tag. More info at https://hub.docker.com/_/gcc/ Just adding files, setting working dir and running make instructions. Build: ``` $ docker build -t twemproxy . ``` Run: ``` $ docker run --rm -it -p [ext_port1:port1] -p [ext_...
c5c725d2b45715e378909ebc909b0492591c4715
62b724aaf6bcdc1f3d563f6cb920ce7809fd8714
diff --git a/Dockerfile b/Dockerfile new file mode 100644 index 00000000..165dd9f2 --- /dev/null +++ b/Dockerfile @@ -0,0 +1,12 @@ +FROM gcc + +COPY . /usr/src/twemproxy +WORKDIR /usr/src/twemproxy +RUN \ + autoreconf -h && \ + autoreconf -fvi && \ + ./configure && \ + make && \ + make install + +ENTRYPOINT [ "nut...
[ "Dockerfile" ]
[]
true
twitter/twemproxy
571
issue_to_patch
Fix README typo
Typo in `README.md`
c5c725d2b45715e378909ebc909b0492591c4715
fc02f09e01e0e7a4c16a501854aa914d5095dc50
diff --git a/README.md b/README.md index 0b2cb7b4..21396a31 100644 --- a/README.md +++ b/README.md @@ -255,7 +255,7 @@ https://launchpad.net/~twemproxy/+archive/ubuntu/daily + [smitty for twemproxy failover](https://github.com/areina/smitty) + [Beholder, a Python agent for twemproxy failover](https://github.com/Serek...
[ "README.md" ]
[]
true
twitter/twemproxy
397
issue_to_patch
Document the client_connections config option
We're using this setting, so thought it should be documented. I had a very quick look at the code and couldn't immediately see where there's a check that the number of connections isn't exceeded, but I assume it's in there somewhere!
4bfcc42d1941993ae41ae16f6640622cc38e52d7
0f69053c6c763084553812ef805191aa24c8ed5d
diff --git a/README.md b/README.md index 311e6d16..d53e81d7 100644 --- a/README.md +++ b/README.md @@ -81,6 +81,7 @@ Furthermore, memory for mbufs is managed using a reuse pool. This means that onc Twemproxy can be configured through a YAML file specified by the -c or --conf-file command-line argument on process start...
[ "README.md" ]
[]
true
twitter/twemproxy
551
issue_to_patch
allow spop can parameters
``` This patch to allow SPOP can get count parameter ``` https://redis.io/commands/spop
34eb60fb977da9aa8bcac784dee1e7fb04c79d47
6885783e34c5ecc83c2e6762802eb4159cdec4ac
diff --git a/src/proto/nc_redis.c b/src/proto/nc_redis.c index 2db88882..7a91993d 100644 --- a/src/proto/nc_redis.c +++ b/src/proto/nc_redis.c @@ -85,7 +85,6 @@ redis_arg0(struct msg *r) case MSG_REQ_REDIS_SCARD: case MSG_REQ_REDIS_SMEMBERS: - case MSG_REQ_REDIS_SPOP: case MSG_REQ_REDIS_ZCARD: ...
[ "src/proto/nc_redis.c" ]
[]
true
twitter/twemproxy
548
issue_to_patch
Adding issue and pull request templates to comply with twitter OSS best practices.
34eb60fb977da9aa8bcac784dee1e7fb04c79d47
ee449746e38d35dd1bd0e28f2577a61ae48ef3e9
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 00000000..ef3b9bc7 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,13 @@ +One line summary of the issue here. + +### Expected behavior + +As concisely as possible, describe the expected behavior. + +### Actual behavio...
[ ".github/ISSUE_TEMPLATE.md", ".github/PULL_REQUEST_TEMPLATE.md" ]
[]
true
twitter/twemproxy
517
issue_to_patch
fix typo in README.md
"Finally, only pool alpha and beta can speak the redis protocol, while pool gamma, deta and omega speak memcached protocol." deta -> delta
0f9e1baf06db478065ba43402b975c57a567d00f
1dd442b450c4520c9778bb62961d0bce44180990
diff --git a/README.md b/README.md index c09ef803..0b2cb7b4 100644 --- a/README.md +++ b/README.md @@ -113,7 +113,7 @@ Twemproxy can be configured through a YAML file specified by the -c or --conf-fi + **servers**: A list of server address, port and weight (name:port:weight or ip:port:weight) for this server pool. ...
[ "README.md" ]
[]
true
twitter/twemproxy
492
issue_to_patch
Fix typo in notes/memcache.md
e5739338ddf228b3b900aa116646cb9654fa5f65
b87ba1abfe6a814999279e69af7ce07ba0ff6c68
diff --git a/notes/memcache.md b/notes/memcache.md index d31c9bc2..5c42aaff 100644 --- a/notes/memcache.md +++ b/notes/memcache.md @@ -66,7 +66,7 @@ +-------------------+------------+--------------------------------------------------------------------------+ | Command | Supported? | Format ...
[ "notes/memcache.md" ]
[]
true
twitter/twemproxy
493
issue_to_patch
Update README.md
Added Greta to the list of companys
e5739338ddf228b3b900aa116646cb9654fa5f65
80ef6a7444fd5ae97fcab9606c1abedc19f00824
diff --git a/README.md b/README.md index 067d5a7e..2eb1f5cd 100644 --- a/README.md +++ b/README.md @@ -292,6 +292,7 @@ https://launchpad.net/~twemproxy/+archive/ubuntu/daily + [Hootsuite](https://hootsuite.com) + [Tradesy](https://www.tradesy.com/) + [Uber](http://uber.com) ([details](http://highscalability.com/blog...
[ "README.md" ]
[]
true
twitter/twemproxy
494
issue_to_patch
Update the sensu-metrics link
e5739338ddf228b3b900aa116646cb9654fa5f65
fe68175e0200e3c2589139438ff3efa392042aa6
diff --git a/README.md b/README.md index 067d5a7e..f4c005b5 100644 --- a/README.md +++ b/README.md @@ -250,7 +250,7 @@ https://launchpad.net/~twemproxy/+archive/ubuntu/daily + [puppet module](https://github.com/wuakitv/puppet-twemproxy) + [nutcracker-web](https://github.com/kontera-technologies/nutcracker-web) + [re...
[ "README.md" ]
[]
true
twitter/twemproxy
406
issue_to_patch
Fix parsing bug when error body contains no spaces
Fix for issue https://github.com/twitter/twemproxy/issues/404 Parsing a redis error messages with no space in the body results in [part of] the following message being consumed and resulting errors.
38ff5bdb0f0228b7f479f1fed41839730f709dd3
6f32a928b4830d218fef67aa5d22bc0fd44000f6
diff --git a/src/proto/nc_redis.c b/src/proto/nc_redis.c index 381b9d18..42b1aedf 100644 --- a/src/proto/nc_redis.c +++ b/src/proto/nc_redis.c @@ -1920,6 +1920,9 @@ redis_parse_rsp(struct msg *r) break; } + if (ch == CR) { + p -= 1; + ...
[ "src/proto/nc_redis.c", "tests/test_redis/test_lua_error_return.py" ]
[]
diff --git a/tests/test_redis/test_lua_error_return.py b/tests/test_redis/test_lua_error_return.py new file mode 100644 index 00000000..743e0c7d --- /dev/null +++ b/tests/test_redis/test_lua_error_return.py @@ -0,0 +1,33 @@ +#!/usr/bin/env python +#coding: utf-8 + +from unittest import TestCase + +from redis import Red...
true
twitter/twemproxy
489
issue_to_patch
Update redis docs for PING and QUIT
Support for these was introduced in @4175419288ef66d95e082cfa2124e77fe6d4fe6d.
330f43a430261aa48d4063771ed70fe191177154
eed195341a02fa688b0dfb784d120f337f15a454
diff --git a/notes/redis.md b/notes/redis.md index 7da6a5e7..1f5fefea 100644 --- a/notes/redis.md +++ b/notes/redis.md @@ -341,9 +341,9 @@ +-------------------+------------+---------------------------------------------------------------------------------------------------------------------+ | ECHO ...
[ "notes/redis.md" ]
[]
true
twitter/twemproxy
486
issue_to_patch
fix a memory leak bug for mset command
ced2044980e4b9dd0c91b25fc64ce127879a1491
558e0d40ad79f423c4784565648e6c83cf035777
diff --git a/src/proto/nc_redis.c b/src/proto/nc_redis.c index b8ef86b3..2db88882 100644 --- a/src/proto/nc_redis.c +++ b/src/proto/nc_redis.c @@ -2333,6 +2333,8 @@ redis_copy_bulk(struct msg *dst, struct msg *src) mbuf_remove(&src->mhdr, mbuf); if (dst != NULL) { mbuf_insert(...
[ "src/proto/nc_redis.c" ]
[]
true
twitter/twemproxy
484
issue_to_patch
Fix typo circunous -> circonus
74af2fb2d5d3e214d8c0741a4b0ebb7d93572fc8
1e078e9e9d97560825ae4f1245177a0af29e3c82
diff --git a/README.md b/README.md index bf5ab651..067d5a7e 100644 --- a/README.md +++ b/README.md @@ -246,7 +246,7 @@ https://launchpad.net/~twemproxy/+archive/ubuntu/daily + [munin-plugin](https://github.com/eveiga/contrib/tree/nutcracker/plugins/nutcracker) + [twemproxy-ganglia-module](https://github.com/ganglia/g...
[ "README.md" ]
[]
true
twitter/twemproxy
191
issue_to_patch
Memcache binary protocol support
The changes are split into three commits: - one for the changes in the engine - one for the configuration tweaks to support more protocols than memcache text and redis protocols - one for the memcache binary dedicated protocol functions (parsers, split, coalesce, etc) The binary protocol recommendation for multi-get r...
5a330fef71b53ee40a45df14f912a49c9d699b9b
a4a473685ffd75a6b28ae8e4f2d38f344572e9c2
diff --git a/configure.ac b/configure.ac index b9abc78c..0e11320e 100644 --- a/configure.ac +++ b/configure.ac @@ -5,7 +5,7 @@ m4_define([NC_PATCH], 0) m4_define([NC_BUGS], [manj@cs.stanford.edu]) # Initialize autoconf -AC_PREREQ([2.64]) +AC_PREREQ([2.63]) AC_INIT([nutcracker], [NC_MAJOR.NC_MINOR.NC_PATCH], [NC_BU...
[ "configure.ac", "src/nc_client.c", "src/nc_client.h", "src/nc_conf.c", "src/nc_conf.h", "src/nc_connection.c", "src/nc_connection.h", "src/nc_core.c", "src/nc_message.c", "src/nc_message.h", "src/nc_proxy.c", "src/nc_request.c", "src/nc_response.c", "src/nc_server.c", "src/nc_server.h", ...
[]
true
twitter/twemproxy
439
issue_to_patch
readme: Link to HTTPS for wikimedia.org
9a2611e5992e65e6c15cd23bce06ffed3901f4f8
91a68d3c42638eb8178001f4d67d2606dcd80f51
diff --git a/README.md b/README.md index 08298b37..bf5ab651 100644 --- a/README.md +++ b/README.md @@ -259,7 +259,7 @@ https://launchpad.net/~twemproxy/+archive/ubuntu/daily ## Companies using Twemproxy in Production + [Twitter](https://twitter.com/) -+ [Wikimedia](http://www.wikimedia.org/) ++ [Wikimedia](https://...
[ "README.md" ]
[]
true
twitter/util
4
issue_to_patch
refactor findClass out of Eval, and fix compile.
3e61f245f2d6c98ec1b4c56bf58c4d3441d4f679
717d80caaecf735ed46af596a3be4b4c5fac398d
diff --git a/util-eval/src/main/scala/com/twitter/util/Eval.scala b/util-eval/src/main/scala/com/twitter/util/Eval.scala index c752ebacd5..e5968e09af 100644 --- a/util-eval/src/main/scala/com/twitter/util/Eval.scala +++ b/util-eval/src/main/scala/com/twitter/util/Eval.scala @@ -78,14 +78,14 @@ class Eval { * Eval[I...
[ "util-eval/src/main/scala/com/twitter/util/Eval.scala" ]
[]
true
twitter/util
1
issue_to_patch
implementation of an auth file, for scala and java.
holla!
9e47a39bbcd7d12870f9c9990b66dd2689318520
33b7984c894b2733c4b443c90652fa4c776d4fce
diff --git a/util-core/src/main/scala/com/twitter/util/Credentials.scala b/util-core/src/main/scala/com/twitter/util/Credentials.scala new file mode 100644 index 0000000000..7669668936 --- /dev/null +++ b/util-core/src/main/scala/com/twitter/util/Credentials.scala @@ -0,0 +1,63 @@ +/* + * Copyright 2011 Twitter, Inc. +...
[ "util-core/src/main/scala/com/twitter/util/Credentials.scala", "util-core/src/test/scala/com/twitter/util/CredentialsSpec.scala" ]
[ { "comment": "what does the non-greedy .*? do for you here? why does it need a match? Could this be simpler:\n\n```\n\"(?:\\\\s+|#.*\\\\n)+\".r\n```\n", "path": "util-core/src/main/scala/com/twitter/util/AuthFile.scala", "hunk": "@@ -0,0 +1,58 @@\n+/*\n+ * Copyright 2011 Twitter, Inc.\n+ *\n+ * Licens...
diff --git a/util-core/src/test/scala/com/twitter/util/CredentialsSpec.scala b/util-core/src/test/scala/com/twitter/util/CredentialsSpec.scala new file mode 100644 index 0000000000..7fb2c022da --- /dev/null +++ b/util-core/src/test/scala/com/twitter/util/CredentialsSpec.scala @@ -0,0 +1,52 @@ +/* + * Copyright 2011 Twi...
true
twitter/util
27
issue_to_patch
Removed dependencies on jms / jmx / jdmk in util-zk & util-zk-common
Fix related to #26. Excluded com.sun.jmx#jmxri, com.sun.jdmk#jmxtools, javax.jms#jms in `util-zk` & `util-zk-common` to make the build succeed out of the box.
9172115caff1e7e75ce3fac9be25c29d566868a6
e88c4c6a377ca9ef5a8a488447db8c45722cf72b
diff --git a/project/Build.scala b/project/Build.scala index 55ed9ca8d5..60dd0adfda 100644 --- a/project/Build.scala +++ b/project/Build.scala @@ -183,6 +183,9 @@ object Util extends Build { name := "util-zk", ivyXML := <dependencies> + <exclude org="com.sun.jmx" module="jmxri" /> + <excl...
[ "project/Build.scala" ]
[]
true
twitter/util
18
issue_to_patch
util-logging: Make Level objects thread-safe
The `Level` constructor mutates two unsynchronized maps within the `Logger` singleton. This coupled with the lazy construction of `Level` objects leads to trouble (for example, deadlocks) in multithreaded applications: - Thread 1 accesses `Level.OFF` for the first time, triggering the constructor - Thread 2 accesses co...
c7536ea7c6a539197140f14c3bb277d4483d2da2
60b8a607cd301884c894aff3bc03bdd3e500720b
diff --git a/util-logging/src/main/scala/com/twitter/logging/Logger.scala b/util-logging/src/main/scala/com/twitter/logging/Logger.scala index e8afada990..41e4e19164 100644 --- a/util-logging/src/main/scala/com/twitter/logging/Logger.scala +++ b/util-logging/src/main/scala/com/twitter/logging/Logger.scala @@ -40,6 +40,...
[ "util-logging/src/main/scala/com/twitter/logging/Logger.scala" ]
[]
true
twitter/util
10
issue_to_patch
scaladoc mis-pluralization fixes.
@throw -> @throws @returns -> @return
6888fb57bd6b5c547ccee0e9dd5d0ece2bf7eae6
63067e47c7d726f7fde83c1a17d76bc8627c5ea5
diff --git a/util-core/src/main/scala/com/twitter/concurrent/Offer.scala b/util-core/src/main/scala/com/twitter/concurrent/Offer.scala index 936d3ebe16..8124aea78c 100644 --- a/util-core/src/main/scala/com/twitter/concurrent/Offer.scala +++ b/util-core/src/main/scala/com/twitter/concurrent/Offer.scala @@ -317,7 +317,7 ...
[ "util-core/src/main/scala/com/twitter/concurrent/Offer.scala", "util-eval/src/main/scala/com/twitter/util/Eval.scala" ]
[]
true
twitter/util
25
issue_to_patch
Fix logging configuration code example
9172115caff1e7e75ce3fac9be25c29d566868a6
81b80d60360cca526e9c8daaddded3d723368d33
diff --git a/util-logging/README.markdown b/util-logging/README.markdown index 16b0260382..983e2e0d88 100644 --- a/util-logging/README.markdown +++ b/util-logging/README.markdown @@ -102,7 +102,7 @@ the root logger to filter at `INFO` level and write to a file: val config = new LoggerConfig { node = "" - ...
[ "util-logging/README.markdown" ]
[]
true
twitter/util
3
issue_to_patch
Strip newlines from base 64 encoder.
We used to pass in a don't use newline flag when we used the apache commons codec base 64 encoder. There is not such a flag in the sun.misc encoder. If you override the bytesPerLine method to return Int.MaxInt, it will give you a heap overflow. So we just explicitly strip them.
220bef1f47452f106fe55c95f0a61733f504ad41
1782d6d30ce036c127123c92c4b0640d6f609c9c
diff --git a/util-core/src/main/scala/com/twitter/util/StringEncoder.scala b/util-core/src/main/scala/com/twitter/util/StringEncoder.scala index e2cc994ac7..d746820152 100644 --- a/util-core/src/main/scala/com/twitter/util/StringEncoder.scala +++ b/util-core/src/main/scala/com/twitter/util/StringEncoder.scala @@ -12,8 ...
[ "util-core/src/main/scala/com/twitter/util/StringEncoder.scala", "util-core/src/test/scala/com/twitter/util/StringEncoderSpec.scala" ]
[]
diff --git a/util-core/src/test/scala/com/twitter/util/StringEncoderSpec.scala b/util-core/src/test/scala/com/twitter/util/StringEncoderSpec.scala new file mode 100644 index 0000000000..cf4062a634 --- /dev/null +++ b/util-core/src/test/scala/com/twitter/util/StringEncoderSpec.scala @@ -0,0 +1,36 @@ +/* + * Copyright 20...
true
twitter/util
2
issue_to_patch
Eval2
backport "compile" and "inPlace" to util-eval.
9e47a39bbcd7d12870f9c9990b66dd2689318520
4a38622f8491fa11207b056eaf84a3ba3d210000
diff --git a/util-core/src/main/scala/com/twitter/conversions/string.scala b/util-core/src/main/scala/com/twitter/conversions/string.scala index 49a620a0bf..444526786c 100644 --- a/util-core/src/main/scala/com/twitter/conversions/string.scala +++ b/util-core/src/main/scala/com/twitter/conversions/string.scala @@ -44,7 ...
[ "util-core/src/main/scala/com/twitter/conversions/string.scala", "util-eval/src/main/scala/com/twitter/util/Eval.scala", "util-eval/src/test/scala/com/twitter/util/EvaluatorSpec.scala" ]
[]
diff --git a/util-eval/src/test/scala/com/twitter/util/EvaluatorSpec.scala b/util-eval/src/test/scala/com/twitter/util/EvaluatorSpec.scala index 356ef80e53..f4c2ae7284 100644 --- a/util-eval/src/test/scala/com/twitter/util/EvaluatorSpec.scala +++ b/util-eval/src/test/scala/com/twitter/util/EvaluatorSpec.scala @@ -8,7 +...
true
tymondesigns/jwt-auth
2,292
issue_to_patch
chore: Inherit Doc
When using VSCode with the [laravel/vs-code-extension](https://github.com/laravel/vs-code-extension) plugin installed, the plugin automatically determines and modifies the return value of Auth::user() to the corresponding model (`\App\Models\User`) However, `\Tymon\JWTAuth\JWTGuard::user()` duplicates the return val...
152f571c1a7f76528b03c9843baad3ebd2a2185f
6017038b2736798b00e8d1d796baccce4ade010f
diff --git a/src/JWTGuard.php b/src/JWTGuard.php index 8c82ba81..2a5e7c60 100644 --- a/src/JWTGuard.php +++ b/src/JWTGuard.php @@ -64,9 +64,7 @@ public function __construct(JWT $jwt, UserProvider $provider, Request $request) } /** - * Get the currently authenticated user. - * - * @return \Illumi...
[ "src/JWTGuard.php" ]
[]
true
tymondesigns/jwt-auth
2,299
issue_to_patch
feat: Support Laravel 13
This pull request updates the project to add support for Laravel 13 and PHP 8.5, and modernizes the CI workflow and dependencies accordingly. The main changes ensure compatibility with the latest versions of Laravel and PHP, and update the Codecov integration to use the latest action. **Framework and PHP version sup...
033b2df5e16291b13dd09cbff203f5e1a7afcec9
bd0248f1065d898d664635cff75b8074e32fe373
diff --git a/.codecov.yml b/.codecov.yml deleted file mode 100644 index db247200..00000000 --- a/.codecov.yml +++ /dev/null @@ -1,1 +0,0 @@ -comment: off diff --git a/.github/FUNDING.yml b/.github/FUNDING.yml deleted file mode 100644 index f8e7c15a..00000000 --- a/.github/FUNDING.yml +++ /dev/null @@ -1,12 +0,0 @@ -# T...
[ ".codecov.yml", ".github/FUNDING.yml", ".github/workflows/phpunit.yml", "composer.json" ]
[]
true
tymondesigns/jwt-auth
2,287
issue_to_patch
fix: Carbon 3 diffInMinutes
* Update from https://github.com/tymondesigns/jwt-auth/pull/2285
6c98cea2c3f11a71c0c7f982dd2d76e64247ee28
c4bd82ed47088cb7b021b1899d59c1bbd9da4c5e
diff --git a/src/Blacklist.php b/src/Blacklist.php index 84a703fc..6d20ff9b 100644 --- a/src/Blacklist.php +++ b/src/Blacklist.php @@ -97,14 +97,13 @@ protected function getMinutesUntilExpired(Payload $payload) // get the latter of the two expiration dates and find // the number of minutes until the e...
[ "src/Blacklist.php" ]
[]
true
tymondesigns/jwt-auth
2,282
issue_to_patch
chore: Allow Laravel 12 and other improvements
07fb753d6bba981ecef681a1ecf0e7ab9c3a9e51
390eae257592cc77369895ec647b9452b4cc1644
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml index 2b77f802..b1192b63 100644 --- a/.github/workflows/phpunit.yml +++ b/.github/workflows/phpunit.yml @@ -2,7 +2,6 @@ name: PHPUnit tests on: push: - pull_request: release: types: - published @@ -15,14 +14,16 @@ jobs: ...
[ ".github/workflows/phpunit.yml", "composer.json", "src/Claims/Claim.php" ]
[]
true
tymondesigns/jwt-auth
2,280
issue_to_patch
Add support for PHP 8.4 and Carbon 3
This PR adds support for PHP 8.4 as well as fixing a bug introduced by https://github.com/tymondesigns/jwt-auth/pull/2247. See https://github.com/tymondesigns/jwt-auth/pull/2247#issuecomment-2017414717
51620ebd5b68bb3ce9e66ba86bda303ae5f10f7f
5ba37cf1cc827ee391269752b13404ac7c3aebce
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml index 2a133765..2b77f802 100644 --- a/.github/workflows/phpunit.yml +++ b/.github/workflows/phpunit.yml @@ -14,7 +14,7 @@ jobs: strategy: fail-fast: false matrix: - php: [8.0, 8.1, 8.2, 8.3] + php: [8.0, 8.1, 8.2...
[ ".github/workflows/phpunit.yml", "src/Blacklist.php", "src/Claims/Collection.php", "src/Exceptions/InvalidClaimException.php" ]
[]
true
tymondesigns/jwt-auth
2,065
issue_to_patch
chore(ci): Move to GH actions and remove (most) EOL php versions
- Move to Github actions - Remove support for EOL php versions https://www.php.net/supported-versions.php - Migrate to phpunit v9 - Adds deprecation docblocks to classes that have been removed in v2
e588cb719539366c0e2f6017f975379cb73e9680
95e9e629b251c1b194ad631b47daceba80bf992b
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml new file mode 100644 index 000000000..2bd9e9f25 --- /dev/null +++ b/.github/workflows/run-tests.yml @@ -0,0 +1,70 @@ +name: Run tests + +on: + push: + release: + types: + - published + +jobs: + php-tests: + runs-on: ${{ matrix....
[ ".github/workflows/run-tests.yml", ".gitignore", ".travis.yml", "composer.json", "phpunit.xml.dist", "src/Http/Middleware/Authenticate.php", "src/Http/Middleware/AuthenticateAndRenew.php", "src/Http/Middleware/BaseMiddleware.php", "src/Http/Middleware/Check.php", "src/Http/Middleware/RefreshToken....
[ { "comment": "Hmm, do we really _need_ all of them?\r\n\r\nI think only the absolute necessary ones should be required (and in turn match `require` from composer.json)?", "path": ".github/workflows/run-tests.yml", "hunk": "@@ -0,0 +1,58 @@\n+name: Run tests\n+\n+on:\n+ push:\n+ release:\n+ types:\n...
diff --git a/tests/AbstractTestCase.php b/tests/AbstractTestCase.php index 85aaddd41..45011233b 100644 --- a/tests/AbstractTestCase.php +++ b/tests/AbstractTestCase.php @@ -13,7 +13,7 @@ use Carbon\Carbon; use Mockery; -use PHPUnit\Framework\TestCase; +use Yoast\PHPUnitPolyfills\TestCases\TestCase; abstract clas...
true
tymondesigns/jwt-auth
2,065
comment_to_fix
chore(ci): Move to GH actions and remove (most) EOL php versions
Hmm, do we really _need_ all of them? I think only the absolute necessary ones should be required (and in turn match `require` from composer.json)?
e588cb719539366c0e2f6017f975379cb73e9680
95e9e629b251c1b194ad631b47daceba80bf992b
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml new file mode 100644 index 000000000..2bd9e9f25 --- /dev/null +++ b/.github/workflows/run-tests.yml @@ -0,0 +1,70 @@ +name: Run tests + +on: + push: + release: + types: + - published + +jobs: + php-tests: + runs-on: ${{ matrix....
[ ".github/workflows/run-tests.yml" ]
[ { "comment": "Hmm, do we really _need_ all of them?\r\n\r\nI think only the absolute necessary ones should be required (and in turn match `require` from composer.json)?", "path": ".github/workflows/run-tests.yml", "hunk": "@@ -0,0 +1,58 @@\n+name: Run tests\n+\n+on:\n+ push:\n+ release:\n+ types:\n...
true
tymondesigns/jwt-auth
2,065
comment_to_fix
chore(ci): Move to GH actions and remove (most) EOL php versions
This can be removed, as v2 is already the latest stable default.
e588cb719539366c0e2f6017f975379cb73e9680
95e9e629b251c1b194ad631b47daceba80bf992b
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml new file mode 100644 index 000000000..2bd9e9f25 --- /dev/null +++ b/.github/workflows/run-tests.yml @@ -0,0 +1,70 @@ +name: Run tests + +on: + push: + release: + types: + - published + +jobs: + php-tests: + runs-on: ${{ matrix....
[ ".github/workflows/run-tests.yml" ]
[ { "comment": "This can be removed, as v2 is already the latest stable default.", "path": ".github/workflows/run-tests.yml", "hunk": "@@ -0,0 +1,58 @@\n+name: Run tests\n+\n+on:\n+ push:\n+ release:\n+ types:\n+ - published\n+\n+jobs:\n+ php-tests:\n+ runs-on: ${{ matrix.os }}\n+\n+ stra...
true
tymondesigns/jwt-auth
2,065
comment_to_fix
chore(ci): Move to GH actions and remove (most) EOL php versions
It's not advised to cache vendor directly, this can create hard to track problems. In fact, setup-php has the most recommended way, please see https://github.com/shivammathur/setup-php#cache-composer-dependencies
e588cb719539366c0e2f6017f975379cb73e9680
95e9e629b251c1b194ad631b47daceba80bf992b
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml new file mode 100644 index 000000000..2bd9e9f25 --- /dev/null +++ b/.github/workflows/run-tests.yml @@ -0,0 +1,70 @@ +name: Run tests + +on: + push: + release: + types: + - published + +jobs: + php-tests: + runs-on: ${{ matrix....
[ ".github/workflows/run-tests.yml" ]
[ { "comment": "It's not advised to cache vendor directly, this can create hard to track problems.\r\n\r\nIn fact, setup-php has the most recommended way, please see https://github.com/shivammathur/setup-php#cache-composer-dependencies", "path": ".github/workflows/run-tests.yml", "hunk": "@@ -0,0 +1,58 @@...
true
tymondesigns/jwt-auth
2,065
comment_to_fix
chore(ci): Move to GH actions and remove (most) EOL php versions
I think this misses `7.2`, at least according to the similar changes in `composer.json` => `"php": "^7.2"`
e588cb719539366c0e2f6017f975379cb73e9680
95e9e629b251c1b194ad631b47daceba80bf992b
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml new file mode 100644 index 000000000..2bd9e9f25 --- /dev/null +++ b/.github/workflows/run-tests.yml @@ -0,0 +1,70 @@ +name: Run tests + +on: + push: + release: + types: + - published + +jobs: + php-tests: + runs-on: ${{ matrix....
[ ".github/workflows/run-tests.yml" ]
[ { "comment": "I think this misses `7.2`, at least according to the similar changes in `composer.json` => `\"php\": \"^7.2\"`", "path": ".github/workflows/run-tests.yml", "hunk": "@@ -0,0 +1,68 @@\n+name: Run tests\n+\n+on:\n+ push:\n+ release:\n+ types:\n+ - published\n+\n+jobs:\n+ php-tests:...
true
tymondesigns/jwt-auth
2,247
issue_to_patch
Add support for Carbon 3.X
Adds `^3.0` version tag to the `nesbot/carbon` dependency on `composer.json` file, to fit on Laravel 11's dependencies.
9c82452d93986a877ea606153125304e1104c7f7
0807d097f111d9a48deab775d212c2466cfdeb4d
diff --git a/composer.json b/composer.json index e886b1db..6c750ad8 100644 --- a/composer.json +++ b/composer.json @@ -29,7 +29,7 @@ "illuminate/http": "^9.0|^10.0|^11.0", "illuminate/support": "^9.0|^10.0|^11.0", "lcobucci/jwt": "^4.0", - "nesbot/carbon": "^2.0" + "nesbot/carbo...
[ "composer.json" ]
[]
true
tymondesigns/jwt-auth
2,233
issue_to_patch
Method factory on JWTGuard not found ### Subject of the issue Running static analysis such as PHPStan results in an error for using `$guard->factory()` even if `$guard instanceof JWTGuard` is true. 'expires_in' => auth()->factory()->getTTL() * 60 this doesn't pass PHPStan with the error message Call ...
:sparkles: Add new getter for JWT's factory
fixes https://github.com/tymondesigns/jwt-auth/issues/2232
44982a70d0552cf408f7e6110d6e419cfac59f13
3b217d8b873bb8d480d4a9faeada52b35b9c49a7
diff --git a/src/JWTGuard.php b/src/JWTGuard.php index 31957072..8c82ba81 100644 --- a/src/JWTGuard.php +++ b/src/JWTGuard.php @@ -351,6 +351,16 @@ public function setRequest(Request $request) return $this; } + /** + * Get the token's auth factory. + * + * @return \Tymon\JWTAuth\Factory +...
[ "src/JWTGuard.php" ]
[]
true
tymondesigns/jwt-auth
2,243
issue_to_patch
feat: Add Laravel 11 compatibility
44982a70d0552cf408f7e6110d6e419cfac59f13
61c285e95750913c7393a1d9000a8d7f5587e5f7
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml index 8c243a4c5..2a133765c 100644 --- a/.github/workflows/phpunit.yml +++ b/.github/workflows/phpunit.yml @@ -14,18 +14,22 @@ jobs: strategy: fail-fast: false matrix: - php: [8.0, 8.1, 8.2] - laravel: [9.*, 10.*]...
[ ".github/workflows/phpunit.yml", "README.md", "composer.json", "tests/Stubs/LaravelUserStub.php" ]
[]
diff --git a/tests/Stubs/LaravelUserStub.php b/tests/Stubs/LaravelUserStub.php index 97ca3e9f9..af2434e44 100644 --- a/tests/Stubs/LaravelUserStub.php +++ b/tests/Stubs/LaravelUserStub.php @@ -45,4 +45,9 @@ public function getRememberTokenName() { // } + + public function getAuthPasswordName() + ...
true
tymondesigns/jwt-auth
1,243
issue_to_patch
Fix JWT Guard and add tests #1219
This should fix the missing request mentioned in #1219
21d9e0d315ca1c3ff1ce1a433500666ed012a4f7
b29070befccc8f13496f91aaa7d303381046da8a
diff --git a/src/JWTGuard.php b/src/JWTGuard.php index e298414b1..fced1aac4 100644 --- a/src/JWTGuard.php +++ b/src/JWTGuard.php @@ -72,7 +72,7 @@ public function user() return $this->user; } - if ($this->jwt->getToken() && + if ($this->jwt->setRequest($this->request)->getToken() &...
[ "src/JWTGuard.php", "tests/JWTGuardTest.php" ]
[]
diff --git a/tests/JWTGuardTest.php b/tests/JWTGuardTest.php index 3caad6515..30f6fb430 100644 --- a/tests/JWTGuardTest.php +++ b/tests/JWTGuardTest.php @@ -128,6 +128,7 @@ public function it_should_get_the_authenticated_user_if_a_valid_token_is_provide */ public function it_should_return_null_if_an_invalid_...
true
tymondesigns/jwt-auth
2,217
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/lZEEoQ).
43611dd527132ebc8342ea1f3c0e44913825a286
5bfa2bd8c638f9960b2e7424b97e839f9ca3c359
[ "tests/BlacklistTest.php", "tests/Http/ParserTest.php", "tests/Validators/TokenValidatorTest.php" ]
[]
diff --git a/tests/BlacklistTest.php b/tests/BlacklistTest.php index df3e76cf8..4c2c79e22 100644 --- a/tests/BlacklistTest.php +++ b/tests/BlacklistTest.php @@ -200,6 +200,7 @@ public function blacklist_provider() /** * @test + * * @dataProvider blacklist_provider * * @param mixed $...
true
tymondesigns/jwt-auth
2,210
issue_to_patch
chore(deps): Add Laravel 10 support
* Laravel 10 compatibility
014be8d493d228d14bbc291b24e835d330c092a0
a9020994cb360d6429552710647eb99c5c166efa
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml index 30c843d49..8c243a4c5 100644 --- a/.github/workflows/phpunit.yml +++ b/.github/workflows/phpunit.yml @@ -14,18 +14,18 @@ jobs: strategy: fail-fast: false matrix: - php: [7.4, 8.0, 8.1] - laravel: [6.*, 7.*, ...
[ ".github/workflows/phpunit.yml", "README.md", "composer.json", "src/Providers/JWT/Namshi.php", "tests/AbstractTestCase.php", "tests/Providers/JWT/LcobucciTest.php", "tests/Providers/JWT/NamshiTest.php", "tests/Providers/Keys/id_rsa", "tests/Providers/Keys/id_rsa.pub" ]
[]
diff --git a/tests/AbstractTestCase.php b/tests/AbstractTestCase.php index 45011233b..84d5261b0 100644 --- a/tests/AbstractTestCase.php +++ b/tests/AbstractTestCase.php @@ -13,7 +13,7 @@ use Carbon\Carbon; use Mockery; -use Yoast\PHPUnitPolyfills\TestCases\TestCase; +use PHPUnit\Framework\TestCase; abstract clas...
true
tymondesigns/jwt-auth
2,211
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/VBbV3B).
a9e057080c64bb61ca6b89c82932811fc8b0c171
e2a9972572bf22975809d28c07d9de067ae76f01
[ "tests/AbstractTestCase.php", "tests/Providers/JWT/LcobucciTest.php" ]
[]
diff --git a/tests/AbstractTestCase.php b/tests/AbstractTestCase.php index 10831fd6..84d5261b 100644 --- a/tests/AbstractTestCase.php +++ b/tests/AbstractTestCase.php @@ -11,8 +11,8 @@ namespace Tymon\JWTAuth\Test; -use Mockery; use Carbon\Carbon; +use Mockery; use PHPUnit\Framework\TestCase; abstract class A...
true
tymondesigns/jwt-auth
2,180
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/x0raay).
185d9ad68fa3ab582773f74ee4f6fe683f3512c7
bbb7c6d95690a38ae7d12d5b59031fa0389a52de
diff --git a/src/Providers/JWT/Lcobucci.php b/src/Providers/JWT/Lcobucci.php index ab4c3886..4e08e561 100644 --- a/src/Providers/JWT/Lcobucci.php +++ b/src/Providers/JWT/Lcobucci.php @@ -11,21 +11,21 @@ namespace Tymon\JWTAuth\Providers\JWT; -use Exception; use DateTimeImmutable; use DateTimeInterface; +use Exce...
[ "src/Providers/JWT/Lcobucci.php" ]
[]
true
tymondesigns/jwt-auth
2,176
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/J2KQyE).
3ffeec450981a3e3c7c2e271417ec3644fb0af74
4aa9f4114fc4734e8034682d20e6ecbb93c65302
diff --git a/src/Blacklist.php b/src/Blacklist.php index 5a3f546de..ba12405be 100644 --- a/src/Blacklist.php +++ b/src/Blacklist.php @@ -48,7 +48,6 @@ class Blacklist * Constructor. * * @param \Tymon\JWTAuth\Contracts\Providers\Storage $storage - * * @return void */ public funct...
[ "src/Blacklist.php", "src/Claims/Claim.php", "src/Claims/Collection.php", "src/Claims/Custom.php", "src/Claims/DatetimeTrait.php", "src/Claims/Factory.php", "src/Console/JWTGenerateSecretCommand.php", "src/Contracts/Claim.php", "src/Contracts/Http/Parser.php", "src/Contracts/Providers/Auth.php", ...
[]
diff --git a/tests/BlacklistTest.php b/tests/BlacklistTest.php index 7412e82d3..df3e76cf8 100644 --- a/tests/BlacklistTest.php +++ b/tests/BlacklistTest.php @@ -202,7 +202,7 @@ public function blacklist_provider() * @test * @dataProvider blacklist_provider * - * @param mixed $result + * @param...
true
tymondesigns/jwt-auth
2,068
issue_to_patch
feat: Ability to add custom parser to the chain
After merging this PR, the developers will be able to add one or more parsers to the parser chain without knowing what's parsers are already available. -- Edit: And after merging this PR, developers will not even have to bother about loading the service providers in sequence.
a72c7ab9edd44ae81d3ea9cf65981972ea77b93b
9b43dc4b284fc7dc5be39f6b0b0954730d533103
diff --git a/src/Http/Parser/Parser.php b/src/Http/Parser/Parser.php index fff0d2d0a..4c1881931 100644 --- a/src/Http/Parser/Parser.php +++ b/src/Http/Parser/Parser.php @@ -53,6 +53,20 @@ public function getChain() return $this->chain; } + /** + * Add a new parser to the chain. + * + * @p...
[ "src/Http/Parser/Parser.php", "src/Providers/AbstractServiceProvider.php", "src/Providers/LaravelServiceProvider.php", "src/Providers/LumenServiceProvider.php", "tests/Http/ParserTest.php" ]
[ { "comment": "I'd like to keep editor specific items out of here. You can also add this to your global .gitignore file - See https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/", "path": ".gitignore", "hunk": "@@ -3,3 +3,4 @@ composer.lock\n build\n coverage.xml\n .phpunit.result.cache\n+.i...
diff --git a/tests/Http/ParserTest.php b/tests/Http/ParserTest.php index d333f769b..a414be326 100644 --- a/tests/Http/ParserTest.php +++ b/tests/Http/ParserTest.php @@ -15,6 +15,7 @@ use Illuminate\Routing\Route; use Illuminate\Support\Facades\Crypt; use Mockery; +use Tymon\JWTAuth\Contracts\Http\Parser as ParserCon...
true
tymondesigns/jwt-auth
2,068
comment_to_fix
feat: Ability to add custom parser to the chain
```suggestion public function addParser($parsers) ```
a72c7ab9edd44ae81d3ea9cf65981972ea77b93b
9b43dc4b284fc7dc5be39f6b0b0954730d533103
diff --git a/src/Http/Parser/Parser.php b/src/Http/Parser/Parser.php index fff0d2d0a..4c1881931 100644 --- a/src/Http/Parser/Parser.php +++ b/src/Http/Parser/Parser.php @@ -53,6 +53,20 @@ public function getChain() return $this->chain; } + /** + * Add a new parser to the chain. + * + * @p...
[ "src/Http/Parser/Parser.php" ]
[ { "comment": "```suggestion\r\n public function addParser($parsers)\r\n```", "path": "src/Http/Parser/Parser.php", "hunk": "@@ -53,6 +53,20 @@ public function getChain()\n return $this->chain;\n }\n \n+ /**\n+ * Add a new parser to the chain.\n+ *\n+ * @param array|\\Tymon\...
true
tymondesigns/jwt-auth
2,068
comment_to_fix
feat: Ability to add custom parser to the chain
please import as `ParserContract` instead
a72c7ab9edd44ae81d3ea9cf65981972ea77b93b
9b43dc4b284fc7dc5be39f6b0b0954730d533103
diff --git a/tests/Http/ParserTest.php b/tests/Http/ParserTest.php index d333f769b..a414be326 100644 --- a/tests/Http/ParserTest.php +++ b/tests/Http/ParserTest.php @@ -15,6 +15,7 @@ use Illuminate\Routing\Route; use Illuminate\Support\Facades\Crypt; use Mockery; +use Tymon\JWTAuth\Contracts\Http\Parser as ParserCon...
[ "tests/Http/ParserTest.php" ]
[ { "comment": "please import as `ParserContract` instead", "path": "tests/Http/ParserTest.php", "hunk": "@@ -419,6 +419,39 @@ public function it_should_set_the_cookie_key()\n $this->assertInstanceOf(Cookies::class, $cookies);\n }\n \n+ /** @test */\n+ public function it_should_add_custo...
true
tymondesigns/jwt-auth
32
issue_to_patch
Fixed provider reference
The provider provided in the README didn't work for me, this one does.
d6c8442c720712b604e48dd16d465af5f8073038
5368ffd5e6ca2d1c5b85ee8e48228fbabb7ed60b
diff --git a/README.md b/README.md index 97d335ff8..8c446f02b 100644 --- a/README.md +++ b/README.md @@ -31,7 +31,7 @@ Then run `composer update` in your terminal to pull it in. Once this has finished, you will need to add the service provider to the `providers` array in `app/config/app.php` as follows: ```php -'Ty...
[ "README.md" ]
[]
true
tymondesigns/jwt-auth
1,926
issue_to_patch
Fixed issue with AuthHeaders parser stripping trailing hyphens from tokens
We ran into an intermittent issue when using this library where sometimes a token (that appeared to be valid as far as we could tell) would be rendered invalid or unparseable by the library. After some debugging, I determined it was from the AuthHeaders parser unintentionally stripping trailing hyphens from a header...
f57a0ff33f20d2a0c3ebc9e13ce8382a83f921a8
dd08aa2caa037ba1c18bbc208ec0a8c79649503a
diff --git a/src/Http/Parser/AuthHeaders.php b/src/Http/Parser/AuthHeaders.php index 53808f032..40d2d5a64 100644 --- a/src/Http/Parser/AuthHeaders.php +++ b/src/Http/Parser/AuthHeaders.php @@ -53,8 +53,10 @@ public function parse(Request $request) { $header = $request->headers->get($this->header) ?: $this...
[ "src/Http/Parser/AuthHeaders.php", "tests/Http/ParserTest.php" ]
[]
diff --git a/tests/Http/ParserTest.php b/tests/Http/ParserTest.php index d333f769b..f288854ce 100644 --- a/tests/Http/ParserTest.php +++ b/tests/Http/ParserTest.php @@ -107,6 +107,62 @@ public function it_should_return_the_token_from_the_alt_authorization_headers() $this->assertTrue($parser->hasToken()); ...
true
tymondesigns/jwt-auth
1,976
issue_to_patch
Lumen documentation update
Updated Lumen installation documentation that based on latest Lumen release.
d4cf9fd2b98790712d3e6cd1094e5ff018431f19
90319fe88c06573eec77e09cfdcf966df30df348
diff --git a/docs/lumen-installation.md b/docs/lumen-installation.md index 039abc521..8698e783c 100644 --- a/docs/lumen-installation.md +++ b/docs/lumen-installation.md @@ -8,7 +8,19 @@ composer require tymon/jwt-auth ------------------------------------------------------------------------------- -### Bootstrap fi...
[ "docs/lumen-installation.md" ]
[]
true
tymondesigns/jwt-auth
2,084
issue_to_patch
chore: Test against laravel 6 on php 8.0
Laravel 6 currently supports php 8.0
fb0cfc8b6bf82ec3ace2eed10f27db0da064d8f9
a70873d7a550336728d780da7b25f8a0e003bf9a
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml index 365557aec..b9b5c25f7 100644 --- a/.github/workflows/phpunit.yml +++ b/.github/workflows/phpunit.yml @@ -26,8 +26,6 @@ jobs: exclude: - php: 7.2 laravel: 8.* - - php: 8.0 - laravel: 6.* ...
[ ".github/workflows/phpunit.yml" ]
[]
true
tymondesigns/jwt-auth
2,066
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/e7pWe2).
298ebf6d6bf78d06757f504d0d3bb7ab2abc9ab2
0941d410155f0c97c0aeef3c2934e04f5c1d8a0f
diff --git a/src/Payload.php b/src/Payload.php index a071965af..b7b49974d 100644 --- a/src/Payload.php +++ b/src/Payload.php @@ -11,16 +11,16 @@ namespace Tymon\JWTAuth; -use Countable; use ArrayAccess; -use JsonSerializable; use BadMethodCallException; +use Countable; +use Illuminate\Contracts\Support\Arrayable...
[ "src/Payload.php", "tests/Claims/ClaimTest.php", "tests/Claims/IssuedAtTest.php", "tests/Claims/NotBeforeTest.php", "tests/JWTGuardTest.php", "tests/ManagerTest.php", "tests/Middleware/AuthenticateAndRenewTest.php", "tests/Middleware/AuthenticateTest.php", "tests/Middleware/RefreshTokenTest.php", ...
[]
diff --git a/tests/Claims/ClaimTest.php b/tests/Claims/ClaimTest.php index 7b092c5af..eed44cca4 100644 --- a/tests/Claims/ClaimTest.php +++ b/tests/Claims/ClaimTest.php @@ -11,10 +11,10 @@ namespace Tymon\JWTAuth\Test\Claims; -use Tymon\JWTAuth\Claims\Expiration; -use Tymon\JWTAuth\Test\AbstractTestCase; use Illu...
true
tymondesigns/jwt-auth
2,037
issue_to_patch
Update Auth0 sponsorship link
Hey We recently launched a new page specifically geared towards developers on auth0.com. Can we change the link in the sponsorship message? Thanks again for your open-source work! Sam
b927137cd5bd4d2f5d48a1ca71bc85006b99dbae
7bec4243e893f057af95734bde9901b67e1d3c72
diff --git a/README.md b/README.md index 45dd4d688..71aaa6780 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ For version `0.5.*` See the [WIKI](https://github.com/tymondesigns/jwt-auth/wiki ### Supported by Auth0 <span><img src="https://user-images.githubusercontent.com/1801923/31792116-d4fca9ec-b512-11e7-...
[ "README.md" ]
[]
true
tymondesigns/jwt-auth
2,026
issue_to_patch
Support Laravel 8
## Summary - Add support for Laravel 8 - Test on PHP 7.4 - Remove testing on hhvm (doesn't work)
d4cf9fd2b98790712d3e6cd1094e5ff018431f19
7fc2078c188c304fbdd1f3faa93f6c9e4b977de3
diff --git a/.travis.yml b/.travis.yml index f3d786d6a..5eb5d68a9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,11 +15,6 @@ env: matrix: include: - - php: hhvm-3.18 - sudo: required - dist: trusty - env: LARAVEL='5.4.*' XDEBUG=1 - group: edge - php: 5.5.9 dist: trusty ...
[ ".travis.yml", "composer.json" ]
[]
true
tymondesigns/jwt-auth
2,027
issue_to_patch
styleci: remove is_null fixer
Fixes this error from StyleCI > The risky 'is_null' fixer cannot be enabled because risky mode is not enabled.
d4cf9fd2b98790712d3e6cd1094e5ff018431f19
98d521beb8483f62837635d41939ddaaaa7bb53c
diff --git a/.styleci.yml b/.styleci.yml index 346424006..1bb05494a 100644 --- a/.styleci.yml +++ b/.styleci.yml @@ -1,7 +1,6 @@ preset: laravel enabled: - - is_null - no_useless_else - phpdoc_order - phpdoc_separation
[ ".styleci.yml" ]
[]
true
tymondesigns/jwt-auth
1,813
issue_to_patch
Created events to dispatch in JWTGuard
PR to #886
a7751aaf8ac3c7f29d0b0a6617c34e38fb209fe6
42382b2b1ebb5acf611baa982a067679d21725c1
diff --git a/composer.json b/composer.json index b5f45cb1d..568c9d937 100644 --- a/composer.json +++ b/composer.json @@ -25,6 +25,7 @@ "require": { "php": "^7.2", "illuminate/contracts": "^5.7", + "illuminate/events": "^5.7", "illuminate/http": "^5.7", "illuminate/support...
[ "composer.json", "src/Events/AbstractJWTEvent.php", "src/Events/JWTAttempt.php", "src/Events/JWTInvalidate.php", "src/Events/JWTLogin.php", "src/Events/JWTLogout.php", "src/Events/JWTRefresh.php", "src/JWTGuard.php", "src/Providers/AbstractServiceProvider.php", "tests/JWTGuardTest.php" ]
[ { "comment": "I think this should be dispatched regardless of valid credentials", "path": "src/JWTGuard.php", "hunk": "@@ -121,6 +135,10 @@ public function attempt(array $credentials = [], bool $login = true)\n $this->lastAttempted = $user = $this->provider->retrieveByCredentials($credentials);\...
diff --git a/tests/JWTGuardTest.php b/tests/JWTGuardTest.php index 012b805b5..b956bdf2a 100644 --- a/tests/JWTGuardTest.php +++ b/tests/JWTGuardTest.php @@ -19,9 +19,15 @@ use Tymon\JWTAuth\JWTGuard; use Illuminate\Http\Request; use Tymon\JWTAuth\Claims\Subject; +use Tymon\JWTAuth\Events\JWTLogin; +use Tymon\JWTAuth...
true
tymondesigns/jwt-auth
1,813
comment_to_fix
Created events to dispatch in JWTGuard
I think this should be dispatched regardless of valid credentials
a7751aaf8ac3c7f29d0b0a6617c34e38fb209fe6
42382b2b1ebb5acf611baa982a067679d21725c1
diff --git a/src/JWTGuard.php b/src/JWTGuard.php index 8beafcedc..c646ea1b7 100644 --- a/src/JWTGuard.php +++ b/src/JWTGuard.php @@ -16,12 +16,18 @@ use Illuminate\Http\Request; use Illuminate\Auth\GuardHelpers; use Tymon\JWTAuth\Claims\Subject; +use Tymon\JWTAuth\Events\JWTLogin; +use Tymon\JWTAuth\Events\JWTLogout...
[ "src/JWTGuard.php" ]
[ { "comment": "I think this should be dispatched regardless of valid credentials", "path": "src/JWTGuard.php", "hunk": "@@ -121,6 +135,10 @@ public function attempt(array $credentials = [], bool $login = true)\n $this->lastAttempted = $user = $this->provider->retrieveByCredentials($credentials);\...
true
tymondesigns/jwt-auth
1,813
comment_to_fix
Created events to dispatch in JWTGuard
All of these events should extend a common abstract class containing the constructor and properties
a7751aaf8ac3c7f29d0b0a6617c34e38fb209fe6
42382b2b1ebb5acf611baa982a067679d21725c1
diff --git a/src/Events/JWTInvalidate.php b/src/Events/JWTInvalidate.php new file mode 100644 index 000000000..5b8f6bff3 --- /dev/null +++ b/src/Events/JWTInvalidate.php @@ -0,0 +1,16 @@ +<?php + +/* + * This file is part of jwt-auth. + * + * (c) Sean Tymon <tymon148@gmail.com> + * + * For the full copyright and licens...
[ "src/Events/JWTInvalidate.php" ]
[ { "comment": "All of these events should extend a common abstract class containing the constructor and properties", "path": "src/Events/JWTInvalidate.php", "hunk": "@@ -0,0 +1,41 @@\n+<?php\n+\n+/*\n+ * This file is part of jwt-auth.\n+ *\n+ * (c) Sean Tymon <tymon148@gmail.com>\n+ *\n+ * For the full c...
true
tymondesigns/jwt-auth
1,947
issue_to_patch
Add Laravel 7 support ### Subject of the issue Current dependencies not satisfied by Laravel 7. ### Your environment | Q | A | ----------------- | --- | Bug? | no | New Feature? | yes | Framework | Laravel | Framework version | 7.0.0 | Package version | 1.0.0-rc5....
chore(deps): Support Laravel 7
Add support for Laravel 7 Drop support for `sentinel` & `Laravel 5.1` Closes #1943
f57a0ff33f20d2a0c3ebc9e13ce8382a83f921a8
1d16e4ef5230afa839140d6978402df32689d27b
diff --git a/.travis.yml b/.travis.yml index 3af172bab..f3d786d6a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -20,21 +20,12 @@ matrix: dist: trusty env: LARAVEL='5.4.*' XDEBUG=1 group: edge - - php: 5.5.9 - dist: trusty - env: LARAVEL='5.1.*' - php: 5.5.9 dist: trusty ...
[ ".travis.yml", "composer.json", "src/Providers/Auth/Sentinel.php", "tests/JWTGuardTest.php", "tests/Providers/Auth/SentinelTest.php", "tests/Stubs/SentinelStub.php" ]
[]
diff --git a/tests/JWTGuardTest.php b/tests/JWTGuardTest.php index a2f7c6b10..25078ec68 100644 --- a/tests/JWTGuardTest.php +++ b/tests/JWTGuardTest.php @@ -48,7 +48,6 @@ public function setUp() /** * @test - * @group laravel-5.2 */ public function it_should_get_the_request() { @@ -57,7...
true
tymondesigns/jwt-auth
1,925
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/7aWEb3).
ca33c64b6c2c36ada5520be6817039e6be7ced93
cd65267828ee7470c8371c3ba9eabdedade9e05d
diff --git a/src/Blacklist.php b/src/Blacklist.php index 13d89bfb4..5a3f546de 100644 --- a/src/Blacklist.php +++ b/src/Blacklist.php @@ -11,8 +11,8 @@ namespace Tymon\JWTAuth; -use Tymon\JWTAuth\Support\Utils; use Tymon\JWTAuth\Contracts\Providers\Storage; +use Tymon\JWTAuth\Support\Utils; class Blacklist { d...
[ "src/Blacklist.php", "src/Claims/Claim.php", "src/Claims/Collection.php", "src/Claims/DatetimeTrait.php", "src/Claims/Factory.php", "src/Console/JWTGenerateSecretCommand.php", "src/Factory.php", "src/Http/Middleware/BaseMiddleware.php", "src/Http/Middleware/RefreshToken.php", "src/Http/Parser/Lume...
[]
diff --git a/tests/AbstractTestCase.php b/tests/AbstractTestCase.php index 7ba31e3f3..85aaddd41 100644 --- a/tests/AbstractTestCase.php +++ b/tests/AbstractTestCase.php @@ -11,8 +11,8 @@ namespace Tymon\JWTAuth\Test; -use Mockery; use Carbon\Carbon; +use Mockery; use PHPUnit\Framework\TestCase; abstract class...
true
tymondesigns/jwt-auth
1,924
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/QM3v3o).
3f1bd34bf5d5ef273d70e3660d0ca07a54fa0bad
a9930702b0a0eb3354e402e8249a3f1742d7f78d
diff --git a/src/Blacklist.php b/src/Blacklist.php index b20a0b547..f387702d5 100644 --- a/src/Blacklist.php +++ b/src/Blacklist.php @@ -13,12 +13,12 @@ namespace Tymon\JWTAuth; -use Tymon\JWTAuth\Claims\JwtId; use Tymon\JWTAuth\Claims\Expiration; -use function Tymon\JWTAuth\Support\now; +use Tymon\JWTAuth\Claims...
[ "src/Blacklist.php", "src/Builder.php", "src/Claims/Claim.php", "src/Claims/Collection.php", "src/Claims/DatetimeTrait.php", "src/Claims/Factory.php", "src/Claims/IssuedAt.php", "src/Claims/NotBefore.php", "src/Console/JWTGenerateSecretCommand.php", "src/Contracts/Providers/JWT.php", "src/Factor...
[]
diff --git a/tests/AbstractTestCase.php b/tests/AbstractTestCase.php index 10831fd6c..84d5261b0 100644 --- a/tests/AbstractTestCase.php +++ b/tests/AbstractTestCase.php @@ -11,8 +11,8 @@ namespace Tymon\JWTAuth\Test; -use Mockery; use Carbon\Carbon; +use Mockery; use PHPUnit\Framework\TestCase; abstract class...
true
tymondesigns/jwt-auth
1,765
issue_to_patch
Add Carbon 2 compatibility.
a96e3bce38b26530168ccb75ead40a0d98a20cbc
8e1048e1e40be420dba96c12fe330a325e39d227
diff --git a/composer.json b/composer.json index 344f5aca2..9730eb5fd 100644 --- a/composer.json +++ b/composer.json @@ -30,7 +30,7 @@ "illuminate/support": "^5.1", "lcobucci/jwt": "^3.2", "namshi/jose": "^7.0", - "nesbot/carbon": "^1.0" + "nesbot/carbon": "^1.0 || ^2.0" },...
[ "composer.json" ]
[]
true
tymondesigns/jwt-auth
1,832
issue_to_patch
noeol: .env lost end of line after run jwt command ### Subject of the issue `.env` lost end of line after run jwt command ### Your environment | Q | A | ----------------- | --- | Bug? | yes | New Feature? | no | Framework | Laravel | Framework version | 5.8.18 | Pac...
fix: end of line
fix #1831
13e8ddc7bac782d9f0458ed151e3690ac7ba44fd
5ac835523f33dda9708a95e91660ec0fd3445779
diff --git a/src/Console/JWTGenerateSecretCommand.php b/src/Console/JWTGenerateSecretCommand.php index faf8d75ea..fa952681f 100644 --- a/src/Console/JWTGenerateSecretCommand.php +++ b/src/Console/JWTGenerateSecretCommand.php @@ -52,8 +52,8 @@ public function handle() } if (Str::contains(file_get_con...
[ "src/Console/JWTGenerateSecretCommand.php" ]
[]
true
tymondesigns/jwt-auth
1,841
issue_to_patch
Added "always-no" option to secret generate command
#1840
13e8ddc7bac782d9f0458ed151e3690ac7ba44fd
32cac51578078d33b9aec73838a98f2b8d7747e6
diff --git a/src/Console/JWTGenerateSecretCommand.php b/src/Console/JWTGenerateSecretCommand.php index faf8d75ea..ad6aa1563 100644 --- a/src/Console/JWTGenerateSecretCommand.php +++ b/src/Console/JWTGenerateSecretCommand.php @@ -23,6 +23,7 @@ class JWTGenerateSecretCommand extends Command */ protected $signa...
[ "src/Console/JWTGenerateSecretCommand.php" ]
[]
true
tymondesigns/jwt-auth
1,846
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/86a7Oa).
a3d2d85cdb4751892d43e86ff65bafe4d744bacf
f00dcf2731ed030b27a45cc1ce0dfcbdd68f8edd
[ "tests/PayloadTest.php" ]
[]
diff --git a/tests/PayloadTest.php b/tests/PayloadTest.php index ac8b13cfe..ffdeb3892 100644 --- a/tests/PayloadTest.php +++ b/tests/PayloadTest.php @@ -125,7 +125,7 @@ public function it_should_get_multiple_properties_when_passing_an_array_to_the_g { $values = $this->payload->get(['sub', 'jti']); - ...
true
tymondesigns/jwt-auth
1,845
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/z9NGVn).
f12f049da3ec8e282aab56358c85f8ec47391081
09489d7fd406a68e430c6d090828badbc6c9d17c
[ "tests/Claims/FactoryTest.php", "tests/JWTTest.php" ]
[]
diff --git a/tests/Claims/FactoryTest.php b/tests/Claims/FactoryTest.php index 191b4f419..f1821d8c9 100644 --- a/tests/Claims/FactoryTest.php +++ b/tests/Claims/FactoryTest.php @@ -20,7 +20,6 @@ use Tymon\JWTAuth\Claims\IssuedAt; use Tymon\JWTAuth\Claims\NotBefore; use Tymon\JWTAuth\Claims\Expiration; -use Tymon\JWT...
true
tymondesigns/jwt-auth
1,255
issue_to_patch
Add handle method for Secret Generator Command
Laravel 5.5 is looking for the handle method instead of fire. "handle" method would call "fire" method.
a3f0c2c268237baba6074efde8ef4d7a829202df
56695a9a9c84405f4cf566d3d3c193a2dac3f623
diff --git a/src/Console/JWTGenerateSecretCommand.php b/src/Console/JWTGenerateSecretCommand.php index c02d45f5a..e5e4e3387 100644 --- a/src/Console/JWTGenerateSecretCommand.php +++ b/src/Console/JWTGenerateSecretCommand.php @@ -32,6 +32,16 @@ class JWTGenerateSecretCommand extends Command */ protected $desc...
[ "src/Console/JWTGenerateSecretCommand.php" ]
[]
true
tymondesigns/jwt-auth
1,812
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/XZd0DR).
177dcbc73475189916eb8d7b7ebce256e3c59eaf
5541a405e744c5b5de0e014242ed213cc54fa7cc
[ "tests/PayloadTest.php" ]
[]
diff --git a/tests/PayloadTest.php b/tests/PayloadTest.php index ac8b13cfe..ffdeb3892 100644 --- a/tests/PayloadTest.php +++ b/tests/PayloadTest.php @@ -125,7 +125,7 @@ public function it_should_get_multiple_properties_when_passing_an_array_to_the_g { $values = $this->payload->get(['sub', 'jti']); - ...
true
tymondesigns/jwt-auth
1,807
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/qgPRBQ).
5ef1515337d1b6d96c2e4d2f5258eaa78d5ca353
f01dc686b0480dc2d4d45dba715a87d4f2c5e185
[ "tests/PayloadTest.php" ]
[]
diff --git a/tests/PayloadTest.php b/tests/PayloadTest.php index 21cd5f694..f47f39caf 100644 --- a/tests/PayloadTest.php +++ b/tests/PayloadTest.php @@ -120,7 +120,7 @@ public function it_should_get_multiple_properties_when_passing_an_array_to_the_g { $values = $this->payload->get([Subject::NAME, JwtId::N...
true
tymondesigns/jwt-auth
1,805
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/8AMb4B).
1e78bc902bc174f021ae3626f6647259e6a55540
099980ff323773d40f9c68ce6a555215e597c8cc
[ "tests/PayloadTest.php" ]
[]
diff --git a/tests/PayloadTest.php b/tests/PayloadTest.php index ac8b13cfe..ffdeb3892 100644 --- a/tests/PayloadTest.php +++ b/tests/PayloadTest.php @@ -125,7 +125,7 @@ public function it_should_get_multiple_properties_when_passing_an_array_to_the_g { $values = $this->payload->get(['sub', 'jti']); - ...
true
tymondesigns/jwt-auth
1,782
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/zdxvkg).
9119165936d9c916b25b2a8b3a7e01ab5898b14d
3dca0ff15cc080c7e6501af103680e9c6e19212c
diff --git a/src/Manager.php b/src/Manager.php index 332bb5040..afba6fcd7 100644 --- a/src/Manager.php +++ b/src/Manager.php @@ -13,13 +13,9 @@ namespace Tymon\JWTAuth; -use Tymon\JWTAuth\Claims\JwtId; -use Tymon\JWTAuth\Claims\Expiration; use Tymon\JWTAuth\Contracts\JWTSubject; use Tymon\JWTAuth\Support\CustomC...
[ "src/Manager.php" ]
[]
true
tymondesigns/jwt-auth
1,781
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/qvj6aV).
cd75eacdbc23936a6aa91183ab3f62cee57a286c
f1a4a421d127cf0fe8bac8000200ced140e4d1b0
diff --git a/src/Providers/Storage/Illuminate.php b/src/Providers/Storage/Illuminate.php index ac9610fca..412540159 100644 --- a/src/Providers/Storage/Illuminate.php +++ b/src/Providers/Storage/Illuminate.php @@ -13,7 +13,6 @@ use BadMethodCallException; use Tymon\JWTAuth\Contracts\Providers\Storage; -use Psr\Simpl...
[ "src/Providers/Storage/Illuminate.php" ]
[]
true
tymondesigns/jwt-auth
1,779
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/XWPDKP).
47d5ee543df0ba9f9f09227cae89d0270ac05251
e3295934cf0c89cfae875d1bea53575e31b3e1a7
diff --git a/src/JWT.php b/src/JWT.php index 003a38703..47461635b 100644 --- a/src/JWT.php +++ b/src/JWT.php @@ -13,7 +13,6 @@ namespace Tymon\JWTAuth; -use Illuminate\Support\Arr; use Illuminate\Http\Request; use Tymon\JWTAuth\Http\Parser\Parser; use Tymon\JWTAuth\Claims\HashedSubject;
[ "src/JWT.php" ]
[]
true
tymondesigns/jwt-auth
1,778
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/8Pp329).
277db833f44a079d9bfe29abe083b9e478ed8682
528d8374709d78cdbdd0496220430b7d2501413d
[ "tests/Claims/ClaimTest.php", "tests/Claims/IssuedAtTest.php", "tests/Claims/NotBeforeTest.php", "tests/FactoryTest.php", "tests/JWTGuardTest.php", "tests/JWTTest.php", "tests/ManagerTest.php", "tests/PayloadTest.php", "tests/Providers/JWT/LcobucciTest.php", "tests/Validators/PayloadValidatorTest....
[]
diff --git a/tests/Claims/ClaimTest.php b/tests/Claims/ClaimTest.php index 0d2a6ebcd..74b5a4c74 100644 --- a/tests/Claims/ClaimTest.php +++ b/tests/Claims/ClaimTest.php @@ -31,11 +31,11 @@ public function setUp(): void /** * @test - * @expectedException \Tymon\JWTAuth\Exceptions\InvalidClaimException -...
true