repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
typst/typst
7,629
comment_to_fix
Spot colors
I find the `OrOklab` part confusing. Yes, if other stuff happens, we will go to oklab. But the enum really encodes the _current_ state of a state machine and the crucial part is `MayBeSpot` or even just `Spot`.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/gradient.rs b/crates/typst-library/src/visualize/gradient.rs index 9cd60df6aa14..d93f17bd6183 100644 --- a/crates/typst-library/src/visualize/gradient.rs +++ b/crates/typst-library/src/visualize/gradient.rs @@ -3,16 +3,18 @@ use std::fmt::{self, Debug, Formatter}; use st...
[ "crates/typst-library/src/visualize/gradient.rs" ]
[ { "comment": "I find the `OrOklab` part confusing. Yes, if other stuff happens, we will go to oklab. But the enum really encodes the _current_ state of a state machine and the crucial part is `MayBeSpot` or even just `Spot`.", "path": "crates/typst-library/src/visualize/gradient.rs", "hunk": "@@ -1283,1...
true
typst/typst
7,629
comment_to_fix
Spot colors
I don't get what `WithoutPrejudice` is trying to tell me.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/gradient.rs b/crates/typst-library/src/visualize/gradient.rs index 9cd60df6aa14..d93f17bd6183 100644 --- a/crates/typst-library/src/visualize/gradient.rs +++ b/crates/typst-library/src/visualize/gradient.rs @@ -3,16 +3,18 @@ use std::fmt::{self, Debug, Formatter}; use st...
[ "crates/typst-library/src/visualize/gradient.rs" ]
[ { "comment": "I don't get what `WithoutPrejudice` is trying to tell me.", "path": "crates/typst-library/src/visualize/gradient.rs", "hunk": "@@ -1283,16 +1296,115 @@ cast! {\n angle: Angle => Self::Angle(angle),\n }\n \n-/// Pre-processes the stops, checking that they are valid and computing the\n-/...
true
typst/typst
7,629
comment_to_fix
Spot colors
The comment sounds like both (individually) are terminal states (because plural "are"), but the condition says that they form a terminal state _together._
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/gradient.rs b/crates/typst-library/src/visualize/gradient.rs index 9cd60df6aa14..d93f17bd6183 100644 --- a/crates/typst-library/src/visualize/gradient.rs +++ b/crates/typst-library/src/visualize/gradient.rs @@ -3,16 +3,18 @@ use std::fmt::{self, Debug, Formatter}; use st...
[ "crates/typst-library/src/visualize/gradient.rs" ]
[ { "comment": "The comment sounds like both (individually) are terminal states (because plural \"are\"), but the condition says that they form a terminal state _together._", "path": "crates/typst-library/src/visualize/gradient.rs", "hunk": "@@ -1283,16 +1296,115 @@ cast! {\n angle: Angle => Self::Ang...
true
typst/typst
7,629
comment_to_fix
Spot colors
Please wrap at column 80
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "Please wrap at column 80", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -66,6 +66,9 @@ static TO_SRGB: LazyLock<Arc<moxcms::Transform8BitExecutor>> = LazyLock::new(||\n /// - Linear RGB through the @color.linear-rgb[`color.linear-rgb` function]\n /// - HSL through the...
true
typst/typst
7,629
comment_to_fix
Spot colors
The "any" reads a bit weirdly, I'd drop it
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "The \"any\" reads a bit weirdly, I'd drop it", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -66,6 +66,9 @@ static TO_SRGB: LazyLock<Arc<moxcms::Transform8BitExecutor>> = LazyLock::new(||\n /// - Linear RGB through the @color.linear-rgb[`color.linear-rgb` function]\n /...
true
typst/typst
7,629
comment_to_fix
Spot colors
This should take `self` and then it doesn't need to clone.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "This should take `self` and then it doesn't need to clone.", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1282,118 +1206,82 @@ impl Color {\n };\n \n Ok(match space {\n- ColorSpace::Oklab => Color::Oklab(Oklab::new(m[0], m[1], m[2], m[3])),...
true
typst/typst
7,629
comment_to_fix
Spot colors
I think it suffices to have these constants here and inline the process color definitions. The only use of any of the `ProcessColor` constants is in `impl Frame`, but that could just as well use `Color`.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "I think it suffices to have these constants here and inline the process color definitions.\n\nThe only use of any of the `ProcessColor` constants is in `impl Frame`, but that could just as well use `Color`.", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -291,28 +303,2...
true
typst/typst
7,629
comment_to_fix
Spot colors
The `Self::Process(ProcessColor::Luma(..))` is duplicated across both branches and could go over the whole if. Same may apply for other constructors.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "The `Self::Process(ProcessColor::Luma(..))` is duplicated across both branches and could go over the whole if. Same may apply for other constructors.", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -342,13 +354,16 @@ impl Color {\n color: Color,\n ) -> Sour...
true
typst/typst
7,629
comment_to_fix
Spot colors
I don't think the term "process color" has been properly introduced in the documentation.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "I don't think the term \"process color\" has been properly introduced in the documentation.", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -938,121 +902,89 @@ impl Color {\n /// #(color.space() == cmyk)\n /// ```\n #[func]\n- pub fn space(self) -> Color...
true
typst/typst
7,629
comment_to_fix
Spot colors
```suggestion #[default] ``` For types with an obvious `Default` impl, just this suffices.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "```suggestion\n #[default]\n```\nFor types with an obvious `Default` impl, just this suffices.", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1066,84 +998,70 @@ impl Color {\n /// ```\n #[func]\n pub fn negate(\n- self,\n+ &self,\n ...
true
typst/typst
7,629
comment_to_fix
Spot colors
while we're at it, might add that missing space
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "while we're at it, might add that missing space", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1066,84 +998,70 @@ impl Color {\n /// ```\n #[func]\n pub fn negate(\n- self,\n+ &self,\n /// The color space used for the transformation....
true
typst/typst
7,629
comment_to_fix
Spot colors
why do the other methods take `auto` and then deal with spot colors automatically, but this one expects you to pass the spot colorant as the mixing space?
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "why do the other methods take `auto` and then deal with spot colors automatically, but this one expects you to pass the spot colorant as the mixing space?", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1165,10 +1083,14 @@ impl Color {\n colors: Vec<WeightedCo...
true
typst/typst
7,629
comment_to_fix
Spot colors
```suggestion /// Convert to `ProcessColor`, using fallback for spot colors. ```
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "```suggestion\n /// Convert to `ProcessColor`, using fallback for spot colors.\n```", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1402,51 +1290,662 @@ impl Color {\n self.to_vec4().map(|x| (x * 255.0).round() as u8)\n }\n \n- pub fn to_space(self, ...
true
typst/typst
7,629
comment_to_fix
Spot colors
can't these be derived?
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "can't these be derived?", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1402,51 +1290,662 @@ impl Color {\n self.to_vec4().map(|x| (x * 255.0).round() as u8)\n }\n \n- pub fn to_space(self, space: ColorSpace) -> Self {\n- match space {\n- ...
true
typst/typst
7,629
comment_to_fix
Spot colors
this definition is a bit randomly in the middle of the color impls
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "this definition is a bit randomly in the middle of the color impls", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1402,51 +1290,662 @@ impl Color {\n self.to_vec4().map(|x| (x * 255.0).round() as u8)\n }\n \n- pub fn to_space(self, space: ColorSpace) -...
true
typst/typst
7,629
comment_to_fix
Spot colors
this could also be derived
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "this could also be derived", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1402,51 +1290,662 @@ impl Color {\n self.to_vec4().map(|x| (x * 255.0).round() as u8)\n }\n \n- pub fn to_space(self, space: ColorSpace) -> Self {\n- match space {\n- ...
true
typst/typst
7,629
comment_to_fix
Spot colors
these could all be replaced by ```rs impl<C> From<C> for Color where C: Into<ProcessColor>, { fn from(color: C) -> Self { Self::Process(color.into()) } } ```
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "these could all be replaced by\n```rs\nimpl<C> From<C> for Color\nwhere\n C: Into<ProcessColor>,\n{\n fn from(color: C) -> Self {\n Self::Process(color.into())\n }\n}\n```", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1402,51 +1290,662 @@ impl Color ...
true
typst/typst
7,629
comment_to_fix
Spot colors
I think I'd prefer if the whole `ProcessColor` type (including its definition, inherent and trait impls) would move fully below all of the `Color` impls and, in particular, its trait impls below its inherent impl(s)
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "I think I'd prefer if the whole `ProcessColor` type (including its definition, inherent and trait impls) would move fully below all of the `Color` impls and, in particular, its trait impls below its inherent impl(s)", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1402...
true
typst/typst
7,629
comment_to_fix
Spot colors
Would be nice to move this to `FromStr for ProcessColor` and then just forward here
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "Would be nice to move this to `FromStr for ProcessColor` and then just forward here", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1402,51 +1290,662 @@ impl Color {\n self.to_vec4().map(|x| (x * 255.0).round() as u8)\n }\n \n- pub fn to_space(self, spa...
true
typst/typst
7,629
comment_to_fix
Spot colors
could you add a test for this. error message does not seem to be exercised by the test suite.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "could you add a test for this. error message does not seem to be exercised by the test suite.", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1704,106 +2216,15 @@ impl PartialEq for Color {\n }\n }\n \n-impl Eq for Color {}\n-\n-impl Hash for Color {\n- fn hash...
true
typst/typst
7,629
comment_to_fix
Spot colors
I think the opposite field order would be a bit more natural, also in `new`
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "I think the opposite field order would be a bit more natural, also in `new`", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1881,6 +2302,196 @@ impl Cmyk {\n }\n }\n \n+/// A Spot color.\n+#[derive(Debug, Clone, Eq, PartialEq, Hash)]\n+pub struct SpotColor {\n+ ...
true
typst/typst
7,629
comment_to_fix
Spot colors
`ProcessColor` already implements `Repr` ```suggestion self.fallback.repr() ```
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "`ProcessColor` already implements `Repr`\n```suggestion\n self.fallback.repr()\n```", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1881,6 +2302,196 @@ impl Cmyk {\n }\n }\n \n+/// A Spot color.\n+#[derive(Debug, Clone, Eq, PartialEq, Hash)]\n+pub struc...
true
typst/typst
7,629
comment_to_fix
Spot colors
please organize the impls as usual, with inherent first and trait impls later.
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "please organize the impls as usual, with inherent first and trait impls later. ", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1881,6 +2302,196 @@ impl Cmyk {\n }\n }\n \n+/// A Spot color.\n+#[derive(Debug, Clone, Eq, PartialEq, Hash)]\n+pub struct SpotColor {\n...
true
typst/typst
7,629
comment_to_fix
Spot colors
please move the name to its own section below the SpotColorant impls
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "please move the name to its own section below the SpotColorant impls", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1881,6 +2302,196 @@ impl Cmyk {\n }\n }\n \n+/// A Spot color.\n+#[derive(Debug, Clone, Eq, PartialEq, Hash)]\n+pub struct SpotColor {\n+ /// Ho...
true
typst/typst
7,629
comment_to_fix
Spot colors
```suggestion spot: SpotColorant => Self::Spot(spot), ```
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "```suggestion\n spot: SpotColorant => Self::Spot(spot),\n```", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -1920,8 +2531,49 @@ cast! {\n }\n \n /// A color space for color manipulation.\n-#[derive(Debug, Copy, Clone, Eq, PartialEq, Hash)]\n+#[derive(Debug, Clone, ...
true
typst/typst
7,629
comment_to_fix
Spot colors
The rewrap broke the docs here
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "The rewrap broke the docs here", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -66,75 +66,61 @@ static TO_SRGB: LazyLock<Arc<moxcms::Transform8BitExecutor>> = LazyLock::new(||\n /// - Linear RGB through the @color.linear-rgb[`color.linear-rgb` function]\n /// - HSL thr...
true
typst/typst
7,629
comment_to_fix
Spot colors
I think the `as_str` can be dropped here
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "I think the `as_str` can be dropped here", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -2488,11 +2342,42 @@ impl SpotColorant {\n bail!(value.span, \"spot color tint must not exceed 100%\")\n }\n \n- Ok(Color::Spot(SpotColor::new(value.v, A...
true
typst/typst
7,629
comment_to_fix
Spot colors
this should say "spot colorant" rather than "spot color"
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/crates/typst-library/src/visualize/color.rs b/crates/typst-library/src/visualize/color.rs index 3042e530588a..b2ffbde2646c 100644 --- a/crates/typst-library/src/visualize/color.rs +++ b/crates/typst-library/src/visualize/color.rs @@ -11,10 +11,10 @@ use palette::{ }; use typst_syntax::{Span, Spanned}; ...
[ "crates/typst-library/src/visualize/color.rs" ]
[ { "comment": "this should say \"spot colorant\" rather than \"spot color\"", "path": "crates/typst-library/src/visualize/color.rs", "hunk": "@@ -2556,9 +2494,9 @@ cast! {\n Self::Process(s) => s.variant_constructor(),\n Self::Spot(s) => s.into_value()\n },\n- spot_colorant: SpotCo...
true
typst/typst
7,629
comment_to_fix
Spot colors
This one is still wrong
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
3e32cb92f14268571eb3113012ff5b83edef1e41
diff --git a/tests/suite/visualize/gradient.typ b/tests/suite/visualize/gradient.typ index 49c848510478..55b3bd615dd8 100644 --- a/tests/suite/visualize/gradient.typ +++ b/tests/suite/visualize/gradient.typ @@ -634,7 +634,7 @@ $ A = mat( #test(gradient.linear(red, green, blue).kind(), gradient.linear) --- gradient-...
[ "tests/suite/visualize/gradient.typ" ]
[ { "comment": "This one is still wrong", "path": "tests/suite/visualize/gradient.typ", "hunk": "", "resolving_sha": "3e32cb92f14268571eb3113012ff5b83edef1e41", "resolving_diff": "diff --git a/tests/suite/visualize/gradient.typ b/tests/suite/visualize/gradient.typ\nindex 49c848510478..55b3bd615dd8...
true
typst/typst
8,473
issue_to_patch
Fix typo in export docs
variables → variable
50d222065a169d0194da01d3ee0b106e43d768cb
b901711664f3eaec9845a6a798caf84745347512
diff --git a/docs/content/reference/export/bundle.typ b/docs/content/reference/export/bundle.typ index 18cba91c249b..ff4f411c0b19 100644 --- a/docs/content/reference/export/bundle.typ +++ b/docs/content/reference/export/bundle.typ @@ -7,7 +7,7 @@ ) #info[ - Bundle export is only available for experimentation behin...
[ "docs/content/reference/export/bundle.typ", "docs/content/reference/export/html.typ" ]
[]
true
typst/typst
8,475
issue_to_patch
Correct the link to Hayagriva changelog in Typst 0.15 changelog
It was linked to codex. <!-- Thanks for your interest in landing a change in Typst! Before opening the PR, please review our contribution guidelines: https://github.com/typst/typst/blob/main/CONTRIBUTING.md In particular, please keep in mind that we do not accept contributions implemented by an AI model. We would als...
50d222065a169d0194da01d3ee0b106e43d768cb
f58b1bcece533faabd946aac879fe16ef0647b97
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ index e88e6d0e6e03..a40692839251 100644 --- a/docs/content/changelog/0.15.0.typ +++ b/docs/content/changelog/0.15.0.typ @@ -79,7 +79,7 @@ - Added support for BibLaTeX name options in `.bib` files #pr(90, repo: "typst/biblatex") - A...
[ "docs/content/changelog/0.15.0.typ" ]
[]
true
typst/typst
8,457
issue_to_patch
Typst 0.15 changelog
Yes, it's half past Midnight. Why are you asking?
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/crates/typst-library/src/model/link.rs b/crates/typst-library/src/model/link.rs index f1f235aa8fb4..51417779519b 100644 --- a/crates/typst-library/src/model/link.rs +++ b/crates/typst-library/src/model/link.rs @@ -136,7 +136,7 @@ use crate::text::{LocalName, TextElem}; /// as _named destinations._ PNG doc...
[ "crates/typst-library/src/model/link.rs", "crates/typst-library/src/text/mod.rs", "docs/assets/docs.css", "docs/components/nav.typ", "docs/content/changelog/0.15.0.typ", "docs/content/changelog/index.typ", "docs/content/changelog/utils.typ", "docs/content/guides/accessibility.typ", "docs/content/ref...
[ { "comment": "@mkorje Any input on this would be appreciated.", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box ...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
@mkorje Any input on this would be appreciated.
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "@mkorje Any input on this would be appreciated.", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box ...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
There's some drive-by stuff in the PR. I might extract that into a separate PR ....
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/crates/typst-library/src/text/mod.rs b/crates/typst-library/src/text/mod.rs index 531cc807d464..7246b2c7a401 100644 --- a/crates/typst-library/src/text/mod.rs +++ b/crates/typst-library/src/text/mod.rs @@ -110,6 +110,16 @@ pub struct TextElem { /// below, the font `Inria Serif` is preferred, but since...
[ "crates/typst-library/src/text/mod.rs" ]
[ { "comment": "There's some drive-by stuff in the PR. I might extract that into a separate PR ....", "path": "crates/typst-library/src/text/mod.rs", "hunk": "@@ -110,6 +110,16 @@ pub struct TextElem {\n /// below, the font `Inria Serif` is preferred, but since it does not\n /// contain Arabic gly...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
TODO: Find typos. Or wait for contributors to find typos. Also double check whether all breaking stuff is marked breaking.
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "TODO: Find typos. Or wait for contributors to find typos. Also double check whether all breaking stuff is marked breaking.", "path": "docs/content/changelog/0.15.0.typ", "hunk": "", "resolving_sha": "b0ab66735989bb586e7b8f21b7bb3e6a3b432faf", "resolving_diff": "diff --git a/docs/co...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
(This will be used to link to the current PDF docs from the https://typst.app/docs version.)
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/components/nav.typ b/docs/components/nav.typ index ededdd7ed1b0..970e70646cde 100644 --- a/docs/components/nav.typ +++ b/docs/components/nav.typ @@ -7,7 +7,7 @@ // - `nav-prev-next`: The navigation buttons on the bottom #import "base.typ": ( - icon, inline-style, labelled, search-box, with-short-...
[ "docs/components/nav.typ" ]
[ { "comment": "(This will be used to link to the current PDF docs from the https://typst.app/docs version.)", "path": "docs/components/nav.typ", "hunk": "@@ -78,6 +78,7 @@\n <metadata-nav-separation>,\n )).map(meta => meta.value)\n nav-items(items, current, true)\n+ insertion(\"after-nav-items\"...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
```suggestion - The @text.alternates parameter now accepts an integer in addition to a boolean to select stylistic alternates other than `{0}` and `{1}` #pr(7423) ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "```suggestion\r\n - The @text.alternates parameter now accepts an integer in addition to a boolean to select stylistic alternates other than `{0}` and `{1}` #pr(7423)\r\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlig...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
I would phrase this without parentheses
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "I would phrase this without parentheses", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via Math...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Stylistic
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Stylistic", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via MathML\n+- With the new, experimen...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Wonder if this should include something like (just to clarify): ```suggestion - Added @list.marker-align property for defining how to align list markers #pr(7895) - When omitted, it will default to the new baseline alignment (vertical), combined with alignment towards the end of text (horizontal). ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Wonder if this should include something like (just to clarify):\r\n\r\n```suggestion\r\n- Added @list.marker-align property for defining how to align list markers #pr(7895)\r\n - When omitted, it will default to the new baseline alignment (vertical), combined with alignment towards the end of tex...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Protrude instead of hang?
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Protrude instead of hang?", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via MathML\n+- With th...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Is rendering the right word here? MathML is generated for equations, but it would be the browser that renders them.
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Is rendering the right word here? MathML is generated for equations, but it would be the browser that renders them.", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[va...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Labeled
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Labeled", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via MathML\n+- With the new, experimenta...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
we should probably decide on calling it either "web site" or "website"; currently both are used in the codebase (though the former only three times according to grep).
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "we should probably decide on calling it either \"web site\" or \"website\"; currently both are used in the codebase (though the former only three times according to grep).", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
```suggestion - Diagnostic hints can now have spans (though typically they will be _detached,_ which just means there isn't a span) #pr(7364) ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "```suggestion\n- Diagnostic hints can now have spans (though typically they will be _detached,_ which just means there isn't a span) #pr(7364)\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst ...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Just an idea, but perhaps mention math more prominently here as that's the main use case really ```suggestion - Last but not least, the marker/number and item of a @list or @enum are now properly baseline-aligned with the first line or math equation row of the item even if the item is vertically larger than a nor...
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Just an idea, but perhaps mention math more prominently here as that's the main use case really\r\n\r\n```suggestion\r\n - Last but not least, the marker/number and item of a @list or @enum are now properly baseline-aligned with the first line or math equation row of the item even if the item is ...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Feels like this a word ```suggestion - Fixed a bug where @par.first-line-indent[first-line indent] was applied at the start of a column even if `{all: false}` was set #pr(7722) ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Feels like this a word\r\n\r\n```suggestion\r\n - Fixed a bug where @par.first-line-indent[first-line indent] was applied at the start of a column even if `{all: false}` was set #pr(7722)\r\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.t...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
accidental double space ```suggestion - Fixed gradient @gradient.angle[angle] handling for negative-size shapes #pr(7826) ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "accidental double space\r\n```suggestion\r\n - Fixed gradient @gradient.angle[angle] handling for negative-size shapes #pr(7826)\r\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now support...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
```suggestion - Fixed handling of @gradient.conic.angle[conic gradients' angles] #pr(7952) ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "```suggestion\r\n- Fixed handling of @gradient.conic.angle[conic gradients' angles] #pr(7952)\r\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
```suggestion - Autocompletion and tooltips are now aware of parameters of user-defined functions #pr(7808) ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "```suggestion\r\n - Autocompletion and tooltips are now aware of parameters of user-defined functions #pr(7808)\r\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variation...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
```suggestion - Function autocompletions in math mode now always prefer round parentheses over square brackets (which are not supported in math) #pr(8417) ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "```suggestion\r\n - Function autocompletions in math mode now always prefer round parentheses over square brackets (which are not supported in math) #pr(8417)\r\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <hig...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
We shouldn't forget the [Codex 0.3.0](https://github.com/typst/codex/blob/main/CHANGELOG.md#version-030-june-4-2026) numeral system additions. ```suggestion - Numbering - Added @numbering support for Armenian numerals #pr(7529), Arabic Abjad numerals #pr(170, repo: "typst/codex"), and Tibetan numerals #pr(163, repo:...
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "We shouldn't forget the [Codex 0.3.0](https://github.com/typst/codex/blob/main/CHANGELOG.md#version-030-june-4-2026) numeral system additions.\n\n```suggestion\n- Numbering\n - Added @numbering support for Armenian numerals #pr(7529), Arabic Abjad numerals #pr(170, repo: \"typst/codex\"), and Tib...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
```suggestion - Added support for @color.spot[spot colors] (also called separation colors) #pr(7629) ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "```suggestion\n- Added support for @color.spot[spot colors] (also called separation colors) #pr(7629)\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fo...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
If you're open to whimsy, we could nest these under a "Multiplicity" sub-list
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "If you're open to whimsy, we could nest these under a \"Multiplicity\" sub-list", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now su...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
I feel like this wording could be improved ```suggestion - A path constructed in one file can be used in another file, but will be resolved relative to its original file ```
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "I feel like this wording could be improved\n\n```suggestion\n - A path constructed in one file can be used in another file, but will be resolved relative to its original file\n```", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= H...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
An _and_ at the end?
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "An _and_ at the end?", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via MathML\n+- With the new...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
I think _When_ to _How_?
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "I think _When_ to _How_?", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via MathML\n+- With the...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
A double space.
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "A double space.", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via MathML\n+- With the new, exp...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
I think _in a_ and without full stop?
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "I think _in a_ and without full stop?", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via MathML...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Something like _conic gradient angles_?
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Something like _conic gradient angles_?", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via Math...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
Is there a reason not to use _element_?
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "Is there a reason not to use _element_?", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via Math...
true
typst/typst
8,457
comment_to_fix
Typst 0.15 changelog
I would link to `page.paper` here
d6548454b243521271715aff0e72153696d9df7d
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
diff --git a/docs/content/changelog/0.15.0.typ b/docs/content/changelog/0.15.0.typ new file mode 100644 index 000000000000..e88e6d0e6e03 --- /dev/null +++ b/docs/content/changelog/0.15.0.typ @@ -0,0 +1,303 @@ +#import "utils.typ": * + += Highlights <highlights> +- Typst now supports @text.variations[variable fonts] +- ...
[ "docs/content/changelog/0.15.0.typ" ]
[ { "comment": "I would link to `page.paper` here", "path": "docs/content/changelog/0.15.0.typ", "hunk": "@@ -0,0 +1,317 @@\n+#import \"utils.typ\": *\n+\n+= Highlights <highlights>\n+- Typst now supports @text.variations[variable fonts]\n+- HTML export now supports equations out of the box via MathML\n+-...
true
typst/typst
8,458
issue_to_patch
Fix the type pill `font-size` in headers
Mentioned at https://github.com/typst/typst/pull/7629#discussion_r3377010978 Resets the type pill `font-size` in headers by changing the CSS selector from `h3 .pill` to `h3 > .pill`. (don't we just love CSS?) I also changed the `h1` selector to `h1 > .pill`. The `h3 .pill { font-size: 20px; ... }` rule was merged...
3e32cb92f14268571eb3113012ff5b83edef1e41
86dc5f613a5efa565b77d950d90ce63535b26fcb
diff --git a/docs/assets/docs.css b/docs/assets/docs.css index 4475026a501d..bebd599a8f62 100644 --- a/docs/assets/docs.css +++ b/docs/assets/docs.css @@ -604,15 +604,34 @@ div[role="tooltip"]:not(.mobile)::after { white-space: nowrap; } -a.pill { - color: inherit !important; - text-decoration: none !important;...
[ "docs/assets/docs.css" ]
[]
true
typst/typst
8,469
issue_to_patch
Make test suite independent from Typst version
This ensures that the test reference hashes do not depend on the compiler version. Previously, the version influenced them as part of the `/Creator` metadata. The test suite now overrides this metadata to a static value. I've also added a CLI test to ensure that the CLI still emits the correct, versioned metadata.
f5568a8ef0765ddb1ac0e271023ac4902ba356bf
7bfb54ddd0adbd154d9d028d1041aec37b46ee9f
diff --git a/crates/typst-cli/src/compile.rs b/crates/typst-cli/src/compile.rs index f65ad5d30525..97ace54032ea 100644 --- a/crates/typst-cli/src/compile.rs +++ b/crates/typst-cli/src/compile.rs @@ -612,6 +612,7 @@ fn pdf_options(config: &CompileConfig) -> PdfOptions { PdfOptions { ident: Smart::Auto, +...
[ "crates/typst-cli/src/compile.rs", "crates/typst-cli/tests/smoke.rs", "crates/typst-pdf/src/lib.rs", "crates/typst-pdf/src/metadata.rs", "tests/ref/bundle/asset-query.txt", "tests/ref/bundle/counter-page-bundle.txt", "tests/ref/bundle/document-constructor.txt", "tests/ref/bundle/document-properties-pr...
[]
diff --git a/crates/typst-cli/tests/smoke.rs b/crates/typst-cli/tests/smoke.rs index aabbce14f0ec..53be8af8f0db 100644 --- a/crates/typst-cli/tests/smoke.rs +++ b/crates/typst-cli/tests/smoke.rs @@ -24,6 +24,23 @@ fn test_compile_pdf() { project.read("hello.pdf").must_start_with("%PDF").must_contain(title); } +...
true
typst/typst
8,467
issue_to_patch
Bump typst-dev-assets
Fixes an oversight in the final rebase of https://github.com/typst/typst/pull/8440.
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
7006a343b6b133ffbec893fda3cbf0fb0e13314c
diff --git a/Cargo.lock b/Cargo.lock index de9a8401ff2f..31bac6716247 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3153,7 +3153,7 @@ dependencies = [ [[package]] name = "typst-dev-assets" version = "0.14.2" -source = "git+https://github.com/typst/typst-dev-assets?rev=695335b#695335b66f56481d8f8cdc2273f20f3023fe29db"...
[ "Cargo.lock", "Cargo.toml", "tests/ref/pdf/hashes.txt", "tests/ref/render/issue-8372-stretched-glyphs.png", "tests/ref/svg/hashes.txt", "tests/suite/layout/inline/text.typ" ]
[]
diff --git a/tests/ref/pdf/hashes.txt b/tests/ref/pdf/hashes.txt index cd3e91c7df65..ae2bd6d878c6 100644 --- a/tests/ref/pdf/hashes.txt +++ b/tests/ref/pdf/hashes.txt @@ -841,7 +841,7 @@ c538aeef16ca92d3fb2507ec32bf024d issue-80-emoji-linebreak 48356f3f3fa5243087fe38356bd16b9a issue-8261-string-as-ellipsis 6848c65a5c...
true
typst/typst
8,468
issue_to_patch
Fix release candidate tag format handling in changelog
Fixes a small mistake in the changelog handling of release candidates. I once again thought the format is `-rc1` when it really is `-rc.1`.
b0ab66735989bb586e7b8f21b7bb3e6a3b432faf
98137f6a76168f6515e3db33c3dfa74575617ad6
diff --git a/docs/content/changelog/index.typ b/docs/content/changelog/index.typ index 6768f12d855c..f268e34c8097 100644 --- a/docs/content/changelog/index.typ +++ b/docs/content/changelog/index.typ @@ -31,8 +31,8 @@ #let releases = { releases .pairs() - .map(((tag, date)) => ( - tag, + .map(((versi...
[ "docs/content/changelog/index.typ" ]
[]
true
typst/typst
8,465
issue_to_patch
Add option to docs generator to emit files in watch mode
e36c79f97001957f50c6fd9529bd47b2881725c2
ac3f942dbc080078944b0348f753bc25dde33597
diff --git a/docs/src/args.rs b/docs/src/args.rs index 2381a7cef941..afc3a54b2e50 100644 --- a/docs/src/args.rs +++ b/docs/src/args.rs @@ -49,6 +49,10 @@ pub struct WatchCommand { /// Arguments for compilation. #[clap(flatten)] pub args: CompileArgs, + + /// Whether to emit the files when the source c...
[ "docs/src/args.rs", "docs/src/main.rs" ]
[]
true
typst/typst
8,435
issue_to_patch
Bump New CM fonts to version 8.1.0
Requires https://github.com/typst/typst-assets/pull/21. Again, a bunch of pdf/svg hash updates due to glyph id changes it seems. All looks visually identical though.
86dc5f613a5efa565b77d950d90ce63535b26fcb
d6fcd720512b7196796bd2ab9faa1cd0efd98d7d
diff --git a/Cargo.lock b/Cargo.lock index 49d8df66fa44..de9a8401ff2f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3077,7 +3077,7 @@ dependencies = [ [[package]] name = "typst-assets" version = "0.14.2" -source = "git+https://github.com/typst/typst-assets?rev=5a5500c#5a5500c9fc0415338617f1fe3955b4e0d9142dbf" +source...
[ "Cargo.lock", "Cargo.toml", "tests/ref/pdf/hashes.txt", "tests/ref/svg/hashes.txt" ]
[]
diff --git a/tests/ref/pdf/hashes.txt b/tests/ref/pdf/hashes.txt index 636e9da1c3c4..e8f8481f053f 100644 --- a/tests/ref/pdf/hashes.txt +++ b/tests/ref/pdf/hashes.txt @@ -8,9 +8,9 @@ f06e8780334f2621e927c98131c42e52 background-artifact-1-7 4bf552ed9e84a2e64e13350389f0414b background-artifact-2-0 0d916b8afbf9ed303bdca...
true
typst/typst
8,440
issue_to_patch
Noto Color Emoji is shrinked in SVG with typst `main` ### Description As shown below, when exporting to SVG, ✅ from _Noto Color Emoji_ is shrinked horizontally with typst `main`. - Left: Typst v0.14.2. - Right: 331f1010 (2026-05-27, downloaded from https://github.com/typst-community/dev-builds/actions/runs/265058904...
Fix raster glyph positioning and sizing in PNG and SVG export
Fixes #8372. This even preceeded #7679 (at least for PNGs). This is in line with the other `draw_glyph` functions, which also don't scale their offsets. ~~The aspect ratio is now applied to the width of the raster image not the height. Which makes sense to me because it's computed from `width / height`. Also it s...
e36c79f97001957f50c6fd9529bd47b2881725c2
92e79f296e73f3330089be9aecf2d50be65f9fb2
diff --git a/crates/typst-library/src/text/font/color.rs b/crates/typst-library/src/text/font/color.rs index e293423e0941..2a7a6552808f 100644 --- a/crates/typst-library/src/text/font/color.rs +++ b/crates/typst-library/src/text/font/color.rs @@ -111,9 +111,9 @@ fn draw_glyph(font: &FontInstance, upem: Abs, glyph_id: G...
[ "crates/typst-library/src/text/font/color.rs", "crates/typst-render/src/text.rs", "crates/typst-svg/src/text.rs", "tests/ref/pdf/hashes.txt", "tests/ref/render/issue-8372-stretched-glyphs.png", "tests/ref/svg/hashes.txt", "tests/suite/layout/inline/text.typ" ]
[]
diff --git a/tests/ref/pdf/hashes.txt b/tests/ref/pdf/hashes.txt index e8f8481f053f..cd3e91c7df65 100644 --- a/tests/ref/pdf/hashes.txt +++ b/tests/ref/pdf/hashes.txt @@ -841,6 +841,7 @@ c538aeef16ca92d3fb2507ec32bf024d issue-80-emoji-linebreak 48356f3f3fa5243087fe38356bd16b9a issue-8261-string-as-ellipsis 6848c65a5c...
true
typst/typst
8,464
issue_to_patch
Make `typst eval` support bundle export ### Description Make `typst eval --target …` support `bundle` in addition to `paged` and `html`. ### Use Case It looks that there's no way to use `typst eval` with a document that uses the new bundle feature. Calling `typst eval` leads to an error. ```typst // main.typ #d...
Support bundle export in `typst eval`
Closes https://github.com/typst/typst/issues/8382
34e2392402b27c506e57576d721bd7947c758868
18aea05c975b39fb0f2be27d72495e25ace7c6a1
diff --git a/crates/typst-cli/src/args.rs b/crates/typst-cli/src/args.rs index d514ae4aa054..ee3ae7e319f5 100644 --- a/crates/typst-cli/src/args.rs +++ b/crates/typst-cli/src/args.rs @@ -627,6 +627,8 @@ pub enum Target { Paged, /// HTML. Html, + /// Bundle. + Bundle, } display_possible_values!(...
[ "crates/typst-cli/src/args.rs", "crates/typst-cli/src/eval.rs", "crates/typst-cli/src/query.rs" ]
[]
true
typst/typst
8,463
issue_to_patch
Improve release action and build PDF docs as release asset
- Builds the docs PDF as a release asset - Migrates from a third-party release action to `gh release upload` for asset uploading - Removes `workflow_dispatch`; this was for testing, but I prefer testing in my fork as that's a more realistic test - Fixes formatting - Fixes mistake in docker image action pinning
86dc5f613a5efa565b77d950d90ce63535b26fcb
4c3a73f5d87e53b537504556679d6639bba724cf
diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml index 329ca578210d..10c296581993 100644 --- a/.github/workflows/docker-image.yml +++ b/.github/workflows/docker-image.yml @@ -55,7 +55,7 @@ jobs: - name: Build Docker image id: build - uses: docker/build-push-a...
[ ".github/workflows/docker-image.yml", ".github/workflows/release.yml" ]
[]
true
typst/typst
8,445
issue_to_patch
Add `int.max` and `int.min`
This PR adds the constants `int.min` and `int.max`, and makes some small additions/updates to the integer docs, errors, and tests. This is based on discussion from #7389, although this PR does not change the current behavior that overflowing integers are treated as floats. This will require reconsidering more of the...
f792643ea5690018e7f7ea9fe704b07d3820ee6d
b758c5691a0031b5eb0f7c7ce73a3f356e1fc7a4
diff --git a/crates/typst-library/src/foundations/int.rs b/crates/typst-library/src/foundations/int.rs index 321cd51386f3..b9ac4a15e370 100644 --- a/crates/typst-library/src/foundations/int.rs +++ b/crates/typst-library/src/foundations/int.rs @@ -11,19 +11,17 @@ use crate::foundations::{ Base, Bytes, Cast, Decimal...
[ "crates/typst-library/src/foundations/int.rs", "crates/typst-syntax/src/lexer.rs", "tests/suite/foundations/array.typ", "tests/suite/foundations/calc.typ", "tests/suite/foundations/float.typ", "tests/suite/foundations/int.typ", "tests/suite/foundations/str.typ", "tests/suite/layout/length.typ", "tes...
[ { "comment": "There's a TODO left here", "path": "tests/suite/foundations/int.typ", "hunk": "@@ -5,12 +5,65 @@\n #test(0xA + 0xa, 0x14)\n \n --- int-base-binary-invalid eval ---\n-// Error: 2-7 invalid binary number: 0b123\n+// Error: 2-7 invalid binary number: `0b123`\n #0b123\n \n+--- int-base-octal-i...
diff --git a/tests/suite/foundations/array.typ b/tests/suite/foundations/array.typ index f4457b637aaf..e6910d914a5b 100644 --- a/tests/suite/foundations/array.typ +++ b/tests/suite/foundations/array.typ @@ -26,7 +26,7 @@ #(1*/2) --- array-bad-number-suffix eval --- -// Error: 6-8 invalid number suffix: u +// Error:...
true
typst/typst
8,451
issue_to_patch
Remove unneded Option in `CompletionContext::new`
You have _no option_ but to merge this.
d1a58ed3a98df6c1768c6eb72fea287cfdfe3b7e
06827c0d72bd6515d8e8823813a97cf049bc721d
diff --git a/crates/typst-ide/src/complete.rs b/crates/typst-ide/src/complete.rs index 999940f18824..76c2790f5d26 100644 --- a/crates/typst-ide/src/complete.rs +++ b/crates/typst-ide/src/complete.rs @@ -49,7 +49,7 @@ pub fn autocomplete( &leaf, cursor, explicit, - )?; + ); // Get...
[ "crates/typst-ide/src/complete.rs" ]
[]
true
typst/typst
8,416
issue_to_patch
Expose and use more specific Artifact kinds
Since new artifact kinds have been exposed in Krilla, this PR adds them to the `artifact` element. It also uses them where appropriate in the artifacts written by default by Typst (for example, the change for shapes from other to layout caused a lot of hash updates). A problematic one is background: It is the canoni...
d1a58ed3a98df6c1768c6eb72fea287cfdfe3b7e
0cf3650a47d1a37f413708a0a20b65f77b7344c9
diff --git a/crates/typst-layout/src/flow/compose.rs b/crates/typst-layout/src/flow/compose.rs index 4cbd6c0c2ba9..5a7ebfefbd1d 100644 --- a/crates/typst-layout/src/flow/compose.rs +++ b/crates/typst-layout/src/flow/compose.rs @@ -14,6 +14,7 @@ use typst_library::layout::{ use typst_library::model::{ FootnoteElem...
[ "crates/typst-layout/src/flow/compose.rs", "crates/typst-layout/src/pages/run.rs", "crates/typst-library/src/pdf/accessibility.rs", "crates/typst-pdf/src/convert.rs", "crates/typst-pdf/src/paint.rs", "crates/typst-pdf/src/shape.rs", "crates/typst-pdf/src/tags/groups.rs", "crates/typst-pdf/src/tags/mod...
[ { "comment": "The linebreaks will look bad in autocomplete as will the paragraph breaks. I'd suggest keeping everything in a single paragraph.", "path": "crates/typst-library/src/pdf/accessibility.rs", "hunk": "@@ -54,11 +60,44 @@ pub enum ArtifactKind {\n Header,\n /// Repeats at the bottom of ...
diff --git a/tests/ref/pdf/hashes.txt b/tests/ref/pdf/hashes.txt index 5ae93055f4c7..95e198b092b5 100644 --- a/tests/ref/pdf/hashes.txt +++ b/tests/ref/pdf/hashes.txt @@ -1,32 +1,34 @@ 48172fb385c06dc05c17fe7c7a76fce2 align-center-in-flow -a00ed16ca6d20579fcc87db435574240 align-in-stack +8b5d8409c89d35d98b8a024c1b7ae1...
true
typst/typst
8,416
comment_to_fix
Expose and use more specific Artifact kinds
The linebreaks will look bad in autocomplete as will the paragraph breaks. I'd suggest keeping everything in a single paragraph.
d1a58ed3a98df6c1768c6eb72fea287cfdfe3b7e
0cf3650a47d1a37f413708a0a20b65f77b7344c9
diff --git a/crates/typst-library/src/pdf/accessibility.rs b/crates/typst-library/src/pdf/accessibility.rs index c34e40aa88bf..233b0909f6b7 100644 --- a/crates/typst-library/src/pdf/accessibility.rs +++ b/crates/typst-library/src/pdf/accessibility.rs @@ -20,8 +20,9 @@ use crate::model::{TableCell, TableElem}; /// ///...
[ "crates/typst-library/src/pdf/accessibility.rs" ]
[ { "comment": "The linebreaks will look bad in autocomplete as will the paragraph breaks. I'd suggest keeping everything in a single paragraph.", "path": "crates/typst-library/src/pdf/accessibility.rs", "hunk": "@@ -54,11 +60,44 @@ pub enum ArtifactKind {\n Header,\n /// Repeats at the bottom of ...
true
typst/typst
8,416
comment_to_fix
Expose and use more specific Artifact kinds
This will panic when using e.g. a negative tiling size. Example: ```typ #rect(fill: tiling(size: (-2pt, -2pt))[Hello]) ```
d1a58ed3a98df6c1768c6eb72fea287cfdfe3b7e
0cf3650a47d1a37f413708a0a20b65f77b7344c9
diff --git a/crates/typst-pdf/src/tags/mod.rs b/crates/typst-pdf/src/tags/mod.rs index 7239fb624a3c..6376893263be 100644 --- a/crates/typst-pdf/src/tags/mod.rs +++ b/crates/typst-pdf/src/tags/mod.rs @@ -1,3 +1,4 @@ +use krilla::configure::PdfVersion; use krilla::geom as kg; use krilla::page::Page; use krilla::surfac...
[ "crates/typst-pdf/src/tags/mod.rs" ]
[ { "comment": "This will panic when using e.g. a negative tiling size. Example:\n```typ\n#rect(fill: tiling(size: (-2pt, -2pt))[Hello])\n```", "path": "crates/typst-pdf/src/tags/mod.rs", "hunk": "@@ -108,8 +111,17 @@ pub fn tiling<T>(\n gc.tags.in_tiling = true;\n let mark_artifact = gc.tags.tree...
true
typst/typst
8,416
comment_to_fix
Expose and use more specific Artifact kinds
```suggestion --- line-numbers-pdf-2-0 pdf pdfstandard(2.0) --- ``` for consistency with the others
d1a58ed3a98df6c1768c6eb72fea287cfdfe3b7e
0cf3650a47d1a37f413708a0a20b65f77b7344c9
diff --git a/tests/suite/layout/line-numbers.typ b/tests/suite/layout/line-numbers.typ index 018efda0026c..caf96bb0eabd 100644 --- a/tests/suite/layout/line-numbers.typ +++ b/tests/suite/layout/line-numbers.typ @@ -256,3 +256,10 @@ Line 3 A $ x $ B + +--- line-numbers-pdf-2-0 pdf pdfstandard(2.0) --- +#set page(marg...
[ "tests/suite/layout/line-numbers.typ" ]
[ { "comment": "```suggestion\n--- line-numbers-pdf-2-0 pdf pdfstandard(2.0) ---\n```\nfor consistency with the others", "path": "tests/suite/layout/line-numbers.typ", "hunk": "@@ -256,3 +256,10 @@ Line 3\n A\n $ x $\n B\n+\n+--- line-numbers-pdf-20 pdf pdfstandard(2.0) ---", "resolving_sha": "0cf3650...
true
typst/typst
8,416
comment_to_fix
Expose and use more specific Artifact kinds
Does this not remove the type again in PDF 2.0?
d1a58ed3a98df6c1768c6eb72fea287cfdfe3b7e
0cf3650a47d1a37f413708a0a20b65f77b7344c9
diff --git a/crates/typst-pdf/src/tags/groups.rs b/crates/typst-pdf/src/tags/groups.rs index 1f6977c7e40a..40a70be228e9 100644 --- a/crates/typst-pdf/src/tags/groups.rs +++ b/crates/typst-pdf/src/tags/groups.rs @@ -1,16 +1,19 @@ use std::collections::hash_map::Entry; +use krilla::configure::PdfVersion; +use krilla::...
[ "crates/typst-pdf/src/tags/groups.rs" ]
[ { "comment": "Does this not remove the type again in PDF 2.0?", "path": "crates/typst-pdf/src/tags/groups.rs", "hunk": "@@ -501,23 +500,34 @@ impl GroupKind {\n matches!(self, Self::Link(..))\n }\n \n- pub fn as_artifact(&self, options: &PdfOptions) -> Option<Artifact> {\n- match *...
true
typst/typst
8,446
issue_to_patch
Bump hayro
4fd8697e0503279abc3c889388bf3b168864fbb7
d1a58ed3a98df6c1768c6eb72fea287cfdfe3b7e
diff --git a/Cargo.lock b/Cargo.lock index 5742efba9897..49d8df66fa44 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -640,15 +640,6 @@ dependencies = [ "syn", ] -[[package]] -name = "document-features" -version = "0.2.12" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "d4b8a88685455ed29...
[ "Cargo.lock", "Cargo.toml", "tests/ref/render/image-pdf-complex.png", "tests/ref/render/image-pdf-multiple-pages.png", "tests/src/collect.rs", "tests/src/output.rs", "tests/src/run.rs", "tests/suite/visualize/image.typ" ]
[ { "comment": "Shouldn't the switch to `libm` prevent this kind of reproducibility issue?", "path": "tests/src/collect.rs", "hunk": "@@ -96,6 +96,11 @@ pub struct Attrs {\n pub large: bool,\n pub empty: bool,\n pub pdf_standard: Vec<PdfStandard>,\n+ /// Tolerance for image comparisons. Ren...
diff --git a/tests/ref/render/image-pdf-complex.png b/tests/ref/render/image-pdf-complex.png index f3e32c43eb94..f1cc35410577 100644 Binary files a/tests/ref/render/image-pdf-complex.png and b/tests/ref/render/image-pdf-complex.png differ diff --git a/tests/ref/render/image-pdf-multiple-pages.png b/tests/ref/render/ima...
true
typst/typst
8,444
issue_to_patch
Trim variable font family suffixes
While the whole family name trimming is not ideal, this brings our variable font handling in line with the existing font family handling and ensures that Typst recognizes a font family across its variableness, instead of splitting it up into two families. If the coverage of static and variable fonts in a family overlap...
5fbed1344a5bcaa73d091a9cf296ea776aec04dc
1074139f160b1dc23201e71daf1f9124440f8b8c
diff --git a/crates/typst-ide/src/utils.rs b/crates/typst-ide/src/utils.rs index 2cc12aef9d21..73fca909eee3 100644 --- a/crates/typst-ide/src/utils.rs +++ b/crates/typst-ide/src/utils.rs @@ -279,7 +279,7 @@ mod tests { Supports optical sizing. SOFT 0–100. WONK 0–1." ); assert_eq!( - ...
[ "crates/typst-ide/src/utils.rs", "crates/typst-library/src/text/font/info.rs", "tests/ref/pdf/hashes.txt", "tests/ref/render/issue-7249-multiple-lookup-tables.png", "tests/ref/render/text-font-variable-and-static.png", "tests/ref/svg/hashes.txt", "tests/suite/text/font.typ" ]
[]
diff --git a/tests/ref/pdf/hashes.txt b/tests/ref/pdf/hashes.txt index e8424d78810f..5ae93055f4c7 100644 --- a/tests/ref/pdf/hashes.txt +++ b/tests/ref/pdf/hashes.txt @@ -819,7 +819,7 @@ c57b9e975a415fcbedecad31ff8740ca issue-6597-gradient-angle-negative-size 562eb36fa211da425545cb9d6ce9d07f issue-7113-cjk-latin-spaci...
true
typst/typst
8,441
issue_to_patch
Add `serde(default)` to `FontInfo::axes`
The `skip_serializing_if` is just the one part of the equation...
18b5060d9ea0605e7174ff819af186ca595c0156
4a03d0268751b5033a4a691c3f3f79dbefbc2e97
diff --git a/crates/typst-library/src/text/font/info.rs b/crates/typst-library/src/text/font/info.rs index 5109c17e74e6..0cbf946d741f 100644 --- a/crates/typst-library/src/text/font/info.rs +++ b/crates/typst-library/src/text/font/info.rs @@ -19,7 +19,7 @@ pub struct FontInfo { /// Properties of the font. pub...
[ "crates/typst-library/src/text/font/info.rs" ]
[]
true
typst/typst
8,439
issue_to_patch
Bump hayagriva
This increases the binary size by a non-trivial amount, which is not a big deal for the CLI, but unfortunate for the web app. There's not much we can do about that right now unfortunately, but it once again motivates some sort of lazy data loading system. See https://github.com/typst/hayagriva/pull/314#issuecomment-463...
7c3381e35ec2156ced90c75983e8c360713ba576
e4325d2e1201a47fcdd15e46027334700d266192
diff --git a/Cargo.lock b/Cargo.lock index dfeac9e8b48b..5742efba9897 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -135,9 +135,9 @@ checksum = "72b3254f16251a8381aa12e40e3c4d2f0199f8c6508fbecb9d91f575e0fbb8c6" [[package]] name = "biblatex" -version = "0.11.0" +version = "0.12.0" source = "registry+https://github.co...
[ "Cargo.lock", "Cargo.toml" ]
[]
true
typst/typst
8,436
issue_to_patch
Bump openssl and tar
298272a48b061d5eee862e0d1ed50e8b46d478a1
350811c771a2bdf794a99af1955e3a3188573b96
diff --git a/Cargo.lock b/Cargo.lock index 196623354079..dfeac9e8b48b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1822,9 +1822,9 @@ dependencies = [ [[package]] name = "openssl" -version = "0.10.79" +version = "0.10.80" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "bf0b434746ee2832...
[ "Cargo.lock", "Cargo.toml" ]
[]
true
typst/typst
8,420
issue_to_patch
`stroke` documentation does not provide definitions for dash pattern shorthands ### Description The [documentation for `stroke`](https://typst.app/docs/reference/visualize/stroke/#constructor-dash) mentions the several predefined patterns for `dash`, i.e. - "solid" - "dotted" - "densely-dotted" - "loosely-dotted"...
Improve `stroke.dash` documentation
Closes https://github.com/typst/typst/issues/5982. This lists the exact values of the predefined dash patterns in the documentation. I also removed the "Inspect a predefined pattern" example since all the necessary information is now in the documentation. I would have liked a more generic solution instead of repe...
0a61a29212b094b83ec46f626c267c2fcf8757b7
bdaa6e8c1ebae939688a6ee09e8f784ced186089
diff --git a/crates/typst-library/src/visualize/stroke.rs b/crates/typst-library/src/visualize/stroke.rs index 1bbd3ea66185..ddcb1f6c88e8 100644 --- a/crates/typst-library/src/visualize/stroke.rs +++ b/crates/typst-library/src/visualize/stroke.rs @@ -128,17 +128,8 @@ impl Stroke { /// The dash pattern to use...
[ "crates/typst-library/src/visualize/stroke.rs" ]
[ { "comment": "This will look bad in IDE autocomplete. (It's currently broken because the parameters are for some reason considered positional.)\n\nThere is the more general problem that markup isn't properly stripped in IDE suggestions, but it's especially problematic when relying on expressions to evaluate lik...
true
typst/typst
8,420
comment_to_fix
Improve `stroke.dash` documentation
This will look bad in IDE autocomplete. (It's currently broken because the parameters are for some reason considered positional.) There is the more general problem that markup isn't properly stripped in IDE suggestions, but it's especially problematic when relying on expressions to evaluate like here.
0a61a29212b094b83ec46f626c267c2fcf8757b7
bdaa6e8c1ebae939688a6ee09e8f784ced186089
diff --git a/crates/typst-library/src/visualize/stroke.rs b/crates/typst-library/src/visualize/stroke.rs index 1bbd3ea66185..ddcb1f6c88e8 100644 --- a/crates/typst-library/src/visualize/stroke.rs +++ b/crates/typst-library/src/visualize/stroke.rs @@ -128,17 +128,8 @@ impl Stroke { /// The dash pattern to use...
[ "crates/typst-library/src/visualize/stroke.rs" ]
[ { "comment": "This will look bad in IDE autocomplete. (It's currently broken because the parameters are for some reason considered positional.)\n\nThere is the more general problem that markup isn't properly stripped in IDE suggestions, but it's especially problematic when relying on expressions to evaluate lik...
true
typst/typst
8,420
comment_to_fix
Improve `stroke.dash` documentation
The backticks are unbalanced here
0a61a29212b094b83ec46f626c267c2fcf8757b7
bdaa6e8c1ebae939688a6ee09e8f784ced186089
diff --git a/crates/typst-library/src/visualize/stroke.rs b/crates/typst-library/src/visualize/stroke.rs index 1bbd3ea66185..ddcb1f6c88e8 100644 --- a/crates/typst-library/src/visualize/stroke.rs +++ b/crates/typst-library/src/visualize/stroke.rs @@ -128,17 +128,8 @@ impl Stroke { /// The dash pattern to use...
[ "crates/typst-library/src/visualize/stroke.rs" ]
[ { "comment": "The backticks are unbalanced here", "path": "crates/typst-library/src/visualize/stroke.rs", "hunk": "@@ -553,15 +537,25 @@ cast! {\n DashPattern,\n self => dict! { \"array\" => self.array, \"phase\" => self.phase }.into_value(),\n \n+ /// ```typc ()``", "resolving_sha": "bda...
true
typst/typst
8,420
comment_to_fix
Improve `stroke.dash` documentation
Sorry, I didn't realize that quick enough on my previous comment, but why not just this, as usual? ```suggestion /// `{("dot", 2pt)}` ``` This is simpler and handled even better by the IDE stuff (though ideally, I'd like for the IDE stuff to handle both things equivalently...)
0a61a29212b094b83ec46f626c267c2fcf8757b7
bdaa6e8c1ebae939688a6ee09e8f784ced186089
diff --git a/crates/typst-library/src/visualize/stroke.rs b/crates/typst-library/src/visualize/stroke.rs index 1bbd3ea66185..ddcb1f6c88e8 100644 --- a/crates/typst-library/src/visualize/stroke.rs +++ b/crates/typst-library/src/visualize/stroke.rs @@ -128,17 +128,8 @@ impl Stroke { /// The dash pattern to use...
[ "crates/typst-library/src/visualize/stroke.rs" ]
[ { "comment": "Sorry, I didn't realize that quick enough on my previous comment, but why not just this, as usual?\n\n```suggestion\n /// `{(\"dot\", 2pt)}`\n```\n\nThis is simpler and handled even better by the IDE stuff (though ideally, I'd like for the IDE stuff to handle both things equivalently...)", ...
true
typst/typst
8,415
issue_to_patch
Justification regression with zws ### Description ```typ #set page(width: 4cm, height: auto, margin: .5cm, background: pad(.5cm, rect(width: 100%, height: 100%, stroke: .4pt+blue))) #set par(justify: true) #let n = h(100%-3.1em); #n;Foo Bar Buzz #n;Foo Bar#sym.zws;Buzz ``` ![Image](https://github.com/user-attachm...
Fix trim condition for end-of-line whitespace glyphs
Fixes #7541. During inline layout leading and trailing whitespace *and* zero width spaces (`\u{200B}`) are trimmed, so it doesn't affect layout. These trimmed characters are still shaped and will be placed as zero advance glyphs in the margin. The problem was that the zero width space would be included in the shape...
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
d11babd668cc9d491cc36c3de60cb9a76e7a2d28
diff --git a/crates/typst-layout/src/inline/line.rs b/crates/typst-layout/src/inline/line.rs index 8fd5b9c5a6be..a88b7c1896fe 100644 --- a/crates/typst-layout/src/inline/line.rs +++ b/crates/typst-layout/src/inline/line.rs @@ -325,7 +325,10 @@ fn collect_range<'a>( // Trim end-of-line whitespace glyphs. ...
[ "crates/typst-layout/src/inline/line.rs", "crates/typst-layout/src/inline/linebreak.rs", "tests/ref/pdf/hashes.txt", "tests/ref/render/issue-7541-justify-with-zero-width-space.png", "tests/ref/svg/hashes.txt", "tests/suite/layout/inline/justify.typ" ]
[ { "comment": "```suggestion\n shaped.glyphs.trim(|glyph| trim.layout <= glyph.range.start);\n```\nI find small to large comparisons typically easier to read", "path": "crates/typst-layout/src/inline/line.rs", "hunk": "@@ -326,7 +326,10 @@ fn collect_range<'a>(\n // Trim end-of-line wh...
diff --git a/tests/ref/pdf/hashes.txt b/tests/ref/pdf/hashes.txt index b6be2cc03803..e8424d78810f 100644 --- a/tests/ref/pdf/hashes.txt +++ b/tests/ref/pdf/hashes.txt @@ -826,6 +826,7 @@ d7ce600b8f4ce5b27a9d63c4c738eca5 issue-7292-page-width-auto-margin-zero 5aaf99a17ad83790c8f2e3fe726ef851 issue-7398-grid-line-end-oo...
true
typst/typst
8,415
comment_to_fix
Fix trim condition for end-of-line whitespace glyphs
```suggestion shaped.glyphs.trim(|glyph| trim.layout <= glyph.range.start); ``` I find small to large comparisons typically easier to read
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
d11babd668cc9d491cc36c3de60cb9a76e7a2d28
diff --git a/crates/typst-layout/src/inline/line.rs b/crates/typst-layout/src/inline/line.rs index 8fd5b9c5a6be..a88b7c1896fe 100644 --- a/crates/typst-layout/src/inline/line.rs +++ b/crates/typst-layout/src/inline/line.rs @@ -325,7 +325,10 @@ fn collect_range<'a>( // Trim end-of-line whitespace glyphs. ...
[ "crates/typst-layout/src/inline/line.rs" ]
[ { "comment": "```suggestion\n shaped.glyphs.trim(|glyph| trim.layout <= glyph.range.start);\n```\nI find small to large comparisons typically easier to read", "path": "crates/typst-layout/src/inline/line.rs", "hunk": "@@ -326,7 +326,10 @@ fn collect_range<'a>(\n // Trim end-of-line wh...
true
typst/typst
8,415
comment_to_fix
Fix trim condition for end-of-line whitespace glyphs
```suggestion #set page(background: pad(10pt, rect( width: 100%, height: 100%, stroke: 0.5pt + blue, ))) ```
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
d11babd668cc9d491cc36c3de60cb9a76e7a2d28
diff --git a/tests/suite/layout/inline/justify.typ b/tests/suite/layout/inline/justify.typ index 5f5505eb31e6..6e98510509df 100644 --- a/tests/suite/layout/inline/justify.typ +++ b/tests/suite/layout/inline/justify.typ @@ -280,3 +280,17 @@ int main() { #set par(justify: true) あaあ#linebreak(justify: true) ああaa aaああ#l...
[ "tests/suite/layout/inline/justify.typ" ]
[ { "comment": "```suggestion\n#set page(background: pad(10pt, rect(\n width: 100%,\n height: 100%,\n stroke: 0.5pt + blue,\n)))\n```", "path": "tests/suite/layout/inline/justify.typ", "hunk": "@@ -280,3 +280,13 @@ int main() {\n #set par(justify: true)\n あaあ#linebreak(justify: true)\n ああaa aaああ#linebr...
true
typst/typst
8,415
comment_to_fix
Fix trim condition for end-of-line whitespace glyphs
```suggestion #let n = h(100% - 3.1em) ```
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
d11babd668cc9d491cc36c3de60cb9a76e7a2d28
diff --git a/tests/suite/layout/inline/justify.typ b/tests/suite/layout/inline/justify.typ index 5f5505eb31e6..6e98510509df 100644 --- a/tests/suite/layout/inline/justify.typ +++ b/tests/suite/layout/inline/justify.typ @@ -280,3 +280,17 @@ int main() { #set par(justify: true) あaあ#linebreak(justify: true) ああaa aaああ#l...
[ "tests/suite/layout/inline/justify.typ" ]
[ { "comment": "```suggestion\n#let n = h(100% - 3.1em)\n```", "path": "tests/suite/layout/inline/justify.typ", "hunk": "@@ -280,3 +280,13 @@ int main() {\n #set par(justify: true)\n あaあ#linebreak(justify: true)\n ああaa aaああ#linebreak(justify: true)\n+\n+--- issue-7541-justify-with-zero-width-space paged -...
true
typst/typst
8,415
comment_to_fix
Fix trim condition for end-of-line whitespace glyphs
I'm not sure I understand what the comment wants to tell me. Since there are also others, e.g. ZERO WIDTH JOINER.
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
d11babd668cc9d491cc36c3de60cb9a76e7a2d28
diff --git a/crates/typst-layout/src/inline/linebreak.rs b/crates/typst-layout/src/inline/linebreak.rs index 7ac587c92139..8d6e81e3d363 100644 --- a/crates/typst-layout/src/inline/linebreak.rs +++ b/crates/typst-layout/src/inline/linebreak.rs @@ -10,7 +10,7 @@ use icu_segmenter::{LineSegmenter, LineSegmenterBorrowed}; ...
[ "crates/typst-layout/src/inline/linebreak.rs" ]
[ { "comment": "I'm not sure I understand what the comment wants to tell me. Since there are also others, e.g. ZERO WIDTH JOINER.", "path": "crates/typst-layout/src/inline/linebreak.rs", "hunk": "@@ -85,8 +82,16 @@ impl Breakpoint {\n // layout, so it is included here. Unfortunately, there isn...
true
typst/typst
8,415
comment_to_fix
Fix trim condition for end-of-line whitespace glyphs
This comment seems to be a bit outdated now (only references ZWS).
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
d11babd668cc9d491cc36c3de60cb9a76e7a2d28
diff --git a/crates/typst-layout/src/inline/linebreak.rs b/crates/typst-layout/src/inline/linebreak.rs index 7ac587c92139..8d6e81e3d363 100644 --- a/crates/typst-layout/src/inline/linebreak.rs +++ b/crates/typst-layout/src/inline/linebreak.rs @@ -10,7 +10,7 @@ use icu_segmenter::{LineSegmenter, LineSegmenterBorrowed}; ...
[ "crates/typst-layout/src/inline/linebreak.rs" ]
[ { "comment": "This comment seems to be a bit outdated now (only references ZWS).", "path": "crates/typst-layout/src/inline/linebreak.rs", "hunk": "@@ -85,8 +82,16 @@ impl Breakpoint {\n // layout, so it is included here. Unfortunately, there isn't", "resolving_sha": "d11babd668cc9d491cc3...
true
typst/typst
8,415
comment_to_fix
Fix trim condition for end-of-line whitespace glyphs
I dug a bit and it looks like in https://github.com/typst/typst/pull/6866 I moved away from a generic `is_default_ignorable` check as it caused issues. See also the discussion in https://github.com/typst/typst/pull/6782. Did you see these discussions?
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
d11babd668cc9d491cc36c3de60cb9a76e7a2d28
diff --git a/crates/typst-layout/src/inline/linebreak.rs b/crates/typst-layout/src/inline/linebreak.rs index 7ac587c92139..8d6e81e3d363 100644 --- a/crates/typst-layout/src/inline/linebreak.rs +++ b/crates/typst-layout/src/inline/linebreak.rs @@ -10,7 +10,7 @@ use icu_segmenter::{LineSegmenter, LineSegmenterBorrowed}; ...
[ "crates/typst-layout/src/inline/linebreak.rs" ]
[ { "comment": "I dug a bit and it looks like in https://github.com/typst/typst/pull/6866 I moved away from a generic `is_default_ignorable` check as it caused issues. See also the discussion in https://github.com/typst/typst/pull/6782. Did you see these discussions?", "path": "crates/typst-layout/src/inline/...
true
typst/typst
8,330
issue_to_patch
Bump New CM fonts to version 8.0.1
~~Requires https://github.com/typst/typst-assets/pull/19.~~ Again, lots of PDF and SVG hashes have updated, where glyph ids appear to have changed slightly (no visual changes though). Only one visual change in `math-frac-line-fill-stroke`, where it looks identical. The updated test code for `math-font-features` is b...
0f19ba1df81e15846246d2c40a4e68a683a04618
c9b7fa7e164f1cac97d89dd6257bfad2f75e682a
diff --git a/Cargo.lock b/Cargo.lock index 600df0210266..89cd2141d72d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3048,7 +3048,7 @@ dependencies = [ [[package]] name = "typst-assets" version = "0.14.2" -source = "git+https://github.com/typst/typst-assets?rev=38782c9#38782c90a45aa1651d6eed9c73a3496c76326b01" +source...
[ "Cargo.lock", "Cargo.toml", "tests/ref/pdf/hashes.txt", "tests/ref/render/math-frac-line-fill-stroke.png", "tests/ref/svg/hashes.txt", "tests/suite/math/text.typ" ]
[]
diff --git a/tests/ref/pdf/hashes.txt b/tests/ref/pdf/hashes.txt index 6e2a21b62534..1d3d8b0344e1 100644 --- a/tests/ref/pdf/hashes.txt +++ b/tests/ref/pdf/hashes.txt @@ -6,9 +6,9 @@ f5f4444788c45f00c260aa98d42d509d array-basic-syntax 55de411a611c1df27e9c39eec35478e8 array-join-content 0b43c579c489f40212be8d31b49743d...
true
typst/typst
8,425
issue_to_patch
Support variable fonts for example, https://fonts.google.com/specimen/Bitter, if have the variable font version `Bitter-VariableFont_wght.ttf` installed, selecting font weight by `#set text(font: "Bitter", weight: "medium")` would still render the ExtraLight variant and setting other weight options would not change th...
Support variable fonts
This PR adds support for variable fonts to Typst. It is based on prior work in https://github.com/typst/typst/pull/8240 and https://github.com/typst/typst/pull/6771, but in the end I made some deeper structural changes, so I've opened a new PR. - Closes https://github.com/typst/typst/issues/185 - Fixes https://gith...
38d9f433676ab65430a124003a6d21a6d1d19734
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
diff --git a/Cargo.lock b/Cargo.lock index 89cd2141d72d..196623354079 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1472,9 +1472,9 @@ dependencies = [ [[package]] name = "krilla" -version = "0.8.1" +version = "0.8.2" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "7d958f40f452cc64e4fae...
[ "Cargo.lock", "Cargo.toml", "crates/typst-cli/src/fonts.rs", "crates/typst-ide/Cargo.toml", "crates/typst-ide/src/tooltip.rs", "crates/typst-ide/src/utils.rs", "crates/typst-layout/src/inline/line.rs", "crates/typst-layout/src/inline/shaping.rs", "crates/typst-layout/src/math/fragment/glyph.rs", "...
[ { "comment": "Would be less noisy here to create a variable first and then call `print!(\"{variant}\");`\n", "path": "crates/typst-cli/src/fonts.rs", "hunk": "@@ -13,20 +16,20 @@ pub fn fonts(command: &FontsCommand) {\n for (family, indices) in fonts.book().families() {\n println!(\"{family}...
diff --git a/tests/ref/bundle/link-bundle-html-frame.txt b/tests/ref/bundle/link-bundle-html-frame.txt index dec96aea32c1..8a696015eed1 100644 --- a/tests/ref/bundle/link-bundle-html-frame.txt +++ b/tests/ref/bundle/link-bundle-html-frame.txt @@ -1,2 +1,2 @@ 5caa14f2425347763746e46baed2a725 index.html -7b7134f43d8a840...
true
typst/typst
8,425
comment_to_fix
Support variable fonts
Would be less noisy here to create a variable first and then call `print!("{variant}");`
38d9f433676ab65430a124003a6d21a6d1d19734
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
diff --git a/crates/typst-cli/src/fonts.rs b/crates/typst-cli/src/fonts.rs index f72952f3bb80..890d233d7d35 100644 --- a/crates/typst-cli/src/fonts.rs +++ b/crates/typst-cli/src/fonts.rs @@ -1,7 +1,10 @@ use std::any::Any; +use std::fmt::{self, Display, Formatter}; use std::path::Path; -use typst::text::FontVariant...
[ "crates/typst-cli/src/fonts.rs" ]
[ { "comment": "Would be less noisy here to create a variable first and then call `print!(\"{variant}\");`\n", "path": "crates/typst-cli/src/fonts.rs", "hunk": "@@ -13,20 +16,20 @@ pub fn fonts(command: &FontsCommand) {\n for (family, indices) in fonts.book().families() {\n println!(\"{family}...
true
typst/typst
8,425
comment_to_fix
Support variable fonts
```suggestion variations.0.push((axis.tag, value.clamp(axis))); ```
38d9f433676ab65430a124003a6d21a6d1d19734
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
diff --git a/crates/typst-library/src/text/font/variations.rs b/crates/typst-library/src/text/font/variations.rs new file mode 100644 index 000000000000..f53bac7b08da --- /dev/null +++ b/crates/typst-library/src/text/font/variations.rs @@ -0,0 +1,228 @@ +use ecow::{EcoString, eco_format}; +use serde::{Deserialize, Seri...
[ "crates/typst-library/src/text/font/variations.rs" ]
[ { "comment": "```suggestion\n variations.0.push((axis.tag, value.clamp(axis)));\n```", "path": "crates/typst-library/src/text/font/variations.rs", "hunk": "@@ -0,0 +1,228 @@\n+use ecow::{EcoString, eco_format};\n+use serde::{Deserialize, Serialize};\n+use smallvec::SmallVec;\n+use std::hash::...
true
typst/typst
8,425
comment_to_fix
Support variable fonts
```suggestion } ```
38d9f433676ab65430a124003a6d21a6d1d19734
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
diff --git a/crates/typst-ide/src/utils.rs b/crates/typst-ide/src/utils.rs index 6411a256c9ef..2cc12aef9d21 100644 --- a/crates/typst-ide/src/utils.rs +++ b/crates/typst-ide/src/utils.rs @@ -1,14 +1,19 @@ -use std::fmt::Write; +use std::fmt::{Display, Write}; use std::ops::ControlFlow; use comemo::Track; -use ecow:...
[ "crates/typst-ide/src/utils.rs" ]
[ { "comment": "```suggestion\n }\n```", "path": "crates/typst-ide/src/utils.rs", "hunk": "@@ -33,35 +38,139 @@ where\n }\n \n /// Create a short description of a font family.\n-pub fn summarize_font_family(mut variants: Vec<&FontInfo>) -> EcoString {\n- variants.sort_by_key(|info| info.variant);\n+...
true
typst/typst
8,425
comment_to_fix
Support variable fonts
```suggestion detail.push_str(" Supports optical sizing."); ```
38d9f433676ab65430a124003a6d21a6d1d19734
ace322514971d0d7e36d2576b5be5dc6ac2fa5d5
diff --git a/crates/typst-ide/src/utils.rs b/crates/typst-ide/src/utils.rs index 6411a256c9ef..2cc12aef9d21 100644 --- a/crates/typst-ide/src/utils.rs +++ b/crates/typst-ide/src/utils.rs @@ -1,14 +1,19 @@ -use std::fmt::Write; +use std::fmt::{Display, Write}; use std::ops::ControlFlow; use comemo::Track; -use ecow:...
[ "crates/typst-ide/src/utils.rs" ]
[ { "comment": "```suggestion\n detail.push_str(\" Supports optical sizing.\");\n```", "path": "crates/typst-ide/src/utils.rs", "hunk": "@@ -33,35 +38,139 @@ where\n }\n \n /// Create a short description of a font family.\n-pub fn summarize_font_family(mut variants: Vec<&FontInfo>) -> EcoString {\n...
true